Builder Linux FYI Release (NVIDIA) Build 5589
Results:
Success
Trigger Info:
Project | chromium |
Revision | 402571f89e1aff1627ccf491110764c74029e3de |
Got Revision | 402571f89e1aff1627ccf491110764c74029e3de |
Execution:
- Source: Task 408142eef1fcd010
- Bot: swarm1075-c4
Steps and Logfiles:
Show:-
( 106751 days 23 hrs ) Failed to fetch step information from LogDogLog stream has no annotation entries
- - no logs -
Build Properties:
Name | Value | Source |
---|
Blamelist:
- Findit (findit-for-meohnoyoudont@appspot.gserviceaccount.com)
- Colin Blundell (blundellohnoyoudont@chromium.org)
- Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
- chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
- Morten Stenshorne (mstenshoohnoyoudont@chromium.org)
- Christian Dullweber (dullweberohnoyoudont@chromium.org)
- Xida Chen (xidachenohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
Timing:
Create | Friday, 12-Oct-18 13:22:33 UTC |
Start | Friday, 12-Oct-18 13:22:35 UTC |
End | Friday, 12-Oct-18 14:17:21 UTC |
Pending | 2 secs |
Execution | 54 mins 45 secs |
All Changes:
-
Revert "Files app: Select My files when there are no volumes"
Changed by Findit - findit-for-meohnoyoudont@appspot.gserviceaccount.com Changed at Friday, 12-Oct-18 13:17:58 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 402571f89e1aff1627ccf491110764c74029e3de Comments
Revert "Files app: Select My files when there are no volumes" This reverts commit 5cd8c123e452c0b76fbbcaf53e82d86ca7d54930. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 599026 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNWNkOGMxMjNlNDUyYzBiNzZmYmJjYWY1M2U4MmQ4NmNhN2Q1NDkzMAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/9016 Sample Failed Step: viz_browser_tests Sample Flaky Test: FileDisplay/FilesAppBrowserTest.Test/fileDisplayWithoutVolumesThenMountDrive_DriveFs Original change's description: > Files app: Select My files when there are no volumes > > Make Files app select "My files" when there are no available volumes, > this to allow Files app to behave properly when volumes subsequently > become available. > > Change DirectoryModel.onVolumeInfoListUpdated_ method to check for > non-null |displayRoot| before trying to change to |displayRoot|. This > fixes the error "Cannot read property 'getParent' of null" when Drive > volume becomes available before Downloads volume, which is the default > volume/root. > > Change FakeDriveFs to unbind the two mojo bindings if they're bound, so > DriveFsTestVolume can re-mount itself. > > Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*" > Bug: 893161, 884967 > Change-Id: Ic813b25261530495c11c9f641a92f6e07f883702 > Reviewed-on: https://chromium-review.googlesource.com/c/1272418 > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599026} Change-Id: I883485c8fc1bdcc22dba93cc4b03b7c157dcb5f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 893161, 884967, 889703 Reviewed-on: https://chromium-review.googlesource.com/c/1278063 Cr-Commit-Position: refs/heads/master@{#599190}
Changed files
- chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
- chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
- chromeos/components/drivefs/fake_drivefs.cc
- ui/file_manager/file_manager/foreground/js/directory_model.js
- ui/file_manager/file_manager/foreground/js/file_manager.js
- ui/file_manager/integration_tests/file_manager/file_display.js
-
Start using IdentityTestEnvironment in ProfileSyncServiceBundle
Changed by Colin Blundell - blundellohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 13:10:51 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 863a437d0fdbbba19ad5446420b72d2f91748a72 Comments
Start using IdentityTestEnvironment in ProfileSyncServiceBundle ProfileSyncServiceBundle owns and exposes signin-related objects for use by sync tests. These signin-related objects include ones that are deprecated by IdentityManager and no longer used directly in the production code being tested; however, up until now it has not been feasible to convert this test utility to using IdentityTestEnvironment, as doing so would have required converting the widespread usage of this utility in one go. We recently introduced an IdentityTestEnvironment usage mode wherein it can be supplied with IdentityManager's dependencies from the external client, precisely to enable incremental conversion in use cases like this. This CL exploits this usage mode to introduce IdentityTestEnvironment in ProfileSyncServiceBundle.h and provide an example of its usage to eliminate a direct usage of the deprecated classes. Once the conversion is complete, ProfileSyncServiceBundle can then be changed to *only* hold an IdentityTestEnvironment object. Bug: 886600, 886599 Change-Id: I205c3567fc0a9bcd6f7b613c00a247c302d71be5 Reviewed-on: https://chromium-review.googlesource.com/c/1273065 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#599189}
Changed files
- components/browser_sync/BUILD.gn
- components/browser_sync/profile_sync_service_autofill_unittest.cc
- components/browser_sync/profile_sync_test_util.cc
- components/browser_sync/profile_sync_test_util.h
-
Import wpt@e8a20c396e2ed7b7b8b2cacd3128f959e710a243
Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 12:59:42 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c12ec9eedc27e721f93de806016cfcf26225fde9 Comments
Import wpt@e8a20c396e2ed7b7b8b2cacd3128f959e710a243 Using wpt-import in Chromium 68550e484d7eecf6bd1d39fca300644ab2c21f5d. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25974 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I132a332cdc953a69e5c54c550a9bb4e5d08c9bb5 Reviewed-on: https://chromium-review.googlesource.com/c/1277603 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#599188}
Changed files
- third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
- third_party/WebKit/LayoutTests/external/wpt/interfaces/webrtc.idl
-
Roll src-internal f37e9866851d..2cecd6e79600 (1 commits)
Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com Changed at Friday, 12-Oct-18 12:56:35 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2f64dae1358dab03fb6fb5e12fc444dad20d38f4 Comments
Roll src-internal f37e9866851d..2cecd6e79600 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f37e9866851d..2cecd6e79600 Created with: gclient setdep -r src-internal@2cecd6e79600 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iac9c77c5c0927e0ca3862bf5171f5972e5c40ca7 Reviewed-on: https://chromium-review.googlesource.com/c/1278711 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599187}
Changed files
- DEPS
-
[LayoutNG] Mark nopaint-after-layer-destruction.html as passing again.
Changed by Morten Stenshorne - mstenshoohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 12:45:38 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 17f212ee41ac78c428f851f24fa76ffee0ec8c3d Comments
[LayoutNG] Mark nopaint-after-layer-destruction.html as passing again. Needed some rebaselining on Mac. Attempted to mark it as passing here: https://chromium-review.googlesource.com/c/1277649 Then a sheriff marked it as failing again: https://chromium-review.googlesource.com/c/chromium/src/+/1278785 TBR=kojii@chromium.org,orphis@chromium.org Change-Id: I4b282cba19e6c94f032c127f70672cf4cfe133ab Reviewed-on: https://chromium-review.googlesource.com/c/1278805 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#599186}
Changed files
- third_party/WebKit/LayoutTests/TestExpectations
- third_party/WebKit/LayoutTests/platform/mac/fast/block/float/nopaint-after-layer-destruction-expected.txt
- third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng/fast/block/float/nopaint-after-layer-destruction-expected.png
-
Log UserDeletedCookieOrCacheFromDialog from Android
Changed by Christian Dullweber - dullweberohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 12:43:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision aeec7095a6a5129132a4fe7e5f5f0abeb2cf8ff3 Comments
Log UserDeletedCookieOrCacheFromDialog from Android We currently log the UserDeletedCookieOrCacheFromDialog histogram from Desktop. On Android we only know about total cookie/cache deletion and not those started from CBD. This CL adds logging of the UserDeletedCookieOrCacheFromDialog histogram to the CBD dialog on Android. Change-Id: I51c1ff6d3c5dc6f531f5bfccc59f522718b1abef Reviewed-on: https://chromium-review.googlesource.com/c/1276605 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#599185}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
- chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesBasic.java
- chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java
- content/public/android/BUILD.gn
- content/public/browser/browsing_data_remover.h
-
Rename OnHasTouchEventHandlersForTest in InputRouterImpl
Changed by Xida Chen - xidachenohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 12:40:53 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0f7980b37fba64a72e95e35f17633e6cb3915321 Comments
Rename OnHasTouchEventHandlersForTest in InputRouterImpl The call site of this function is resetting the |allowed_touch_action_| only, so rename this function to ForceResetTouchActionForTest. This CL should not introduce any behavior change. Bug: None Change-Id: I253d73f4f21bdb6268f43ce535453412f4b32c51 Reviewed-on: https://chromium-review.googlesource.com/c/1277947 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#599184}
Changed files
- content/browser/renderer_host/input/input_router_impl.cc
- content/browser/renderer_host/input/input_router_impl.h
- content/browser/renderer_host/input/touch_action_filter.cc
- content/browser/renderer_host/input/touch_action_filter.h
- content/browser/site_per_process_hit_test_browsertest.cc
- content/public/test/browser_test_utils.cc
-
Roll src/third_party/webrtc 28d200c24624..55d1af14751a (2 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Friday, 12-Oct-18 12:35:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9729f6efb4bae858cc91b281091f2df86433da8a Comments
Roll src/third_party/webrtc 28d200c24624..55d1af14751a (2 commits) https://webrtc.googlesource.com/src.git/+log/28d200c24624..55d1af14751a git log 28d200c24624..55d1af14751a --date=short --no-merges --format='%ad %ae %s' 2018-10-12 terelius@webrtc.org Remove support for microsecond resolution in RtcEventLogs. 2018-10-12 sprang@webrtc.org Move TemporalLayers to api/video_codecs. Created with: gclient setdep -r src/third_party/webrtc@55d1af14751a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I15b74c4ebe322c1004b1ba8d1cfb25d82b65614c Reviewed-on: https://chromium-review.googlesource.com/c/1278709 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599183}
Changed files
- DEPS