Builder Linux FYI Release (NVIDIA) Build 5584
Results:
Success
Trigger Info:
| Project | chromium |
| Revision | 755d6f957abd6af5b8bbbf045ac622b92fea60a5 |
| Got Revision | 755d6f957abd6af5b8bbbf045ac622b92fea60a5 |
Execution:
- Source: Task 408049bd70bb6910
- Bot: swarm1075-c4
Steps and Logfiles:
Show:-
( 106751 days 23 hrs ) Failed to fetch step information from LogDogLog stream has no annotation entries
- - no logs -
Build Properties:
| Name | Value | Source |
|---|
Blamelist:
- Gauthier Ambard (gambardohnoyoudont@chromium.org)
- Gauthier Ambard (gambardohnoyoudont@chromium.org)
- Florent Castelli (orphisohnoyoudont@chromium.org)
- Fergal Daly (fergalohnoyoudont@chromium.org)
- Alexander Alekseev (alemateohnoyoudont@chromium.org)
- A Olsen (olsenohnoyoudont@chromium.org)
- Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
- Roman Sorokin (rsorokinohnoyoudont@chromium.org)
- Alexander Alekseev (alemateohnoyoudont@chromium.org)
- Luciano Pacheco (lucmultohnoyoudont@chromium.org)
- Alexandre Courbot (acourbotohnoyoudont@chromium.org)
- Jochen Eisinger (jochenohnoyoudont@chromium.org)
- Yuta Kitamura (yutakohnoyoudont@chromium.org)
- Eliot Courtney (edcourtneyohnoyoudont@google.com)
- Gauthier Ambard (gambardohnoyoudont@chromium.org)
- Alexander Alekseev (alemateohnoyoudont@chromium.org)
Timing:
| Create | Friday, 12-Oct-18 08:50:22 UTC |
| Start | Friday, 12-Oct-18 08:50:24 UTC |
| End | Friday, 12-Oct-18 09:41:38 UTC |
| Pending | 1 secs |
| Execution | 51 mins 13 secs |
All Changes:
-
[iOS] Support Accessibility ContentSize on NTP header
Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 08:35:30 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 755d6f957abd6af5b8bbbf045ac622b92fea60a5 Comments
[iOS] Support Accessibility ContentSize on NTP header This CL changes the header of the "Articles for you" section of the NTP to have a better support for the "accessibility" categories of preferred content size chosen by the user. Bug: 893524 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I56ed6f89e7767697083c3e8e5d5a796db3066aee Reviewed-on: https://chromium-review.googlesource.com/c/1273522 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#599145}
Changed files
- ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_articles_header_item.mm
- ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
-
[iOS] Use Dynamic Type in the empty NTP cell
Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 08:35:26 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c245af46fb47db066cbdc99a5f578e2b94b2ca2f Comments
[iOS] Use Dynamic Type in the empty NTP cell This CL adds Dynamic Type to the cell displayed when the NTP's articles section is empty. Bug: 893527 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If36d6ece1eaac888f606f7730de379aec11ba6be Reviewed-on: https://chromium-review.googlesource.com/c/1273536 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#599144}
Changed files
- ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_text_item.mm
-
Revert "Move InstallAttributes to chromeos/settings"
Changed by Florent Castelli - orphisohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 08:33:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f32368f166f8a2d51078a6c6c2f6ffc8c3f2f7a9 Comments
Revert "Move InstallAttributes to chromeos/settings" This reverts commit aa6c62dce936e966e2db445045dd04414553642b. Reason for revert: Breaks build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-daisy-rel/33402 Original change's description: > Move InstallAttributes to chromeos/settings > > Necessary for moving CrosSettings to chromeos/settings, so it > can eventually be used by Mustash. > > The following changes were necessary: > 1. Move install_attributes{.h, .cc} and unit_test.cc > 2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn > (destination) > 3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h, > which is included by install_attributes.h > > 4. Unfortunately, that same dependency lead to a circular dependency. > I was able to avoid that by separating out a "common_constants" rule in > components/policy/core/common, so that chromeos/settings only depends on > that, and not on all of components/policy. So I had to change > components/policy/core/common/BUILD.gn > and I removed an unnecessary include from > components/policy/core/common/cloud/cloud_policy_constants.cc > > 5. Update #include directives for install_attributes to point to new > location. This is the other 22 files, all with diffs of +1 -1. > > Bug: 446937 > Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288 > Reviewed-on: https://chromium-review.googlesource.com/c/1264757 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Commit-Queue: A Olsen <olsen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599140} TBR=stevenjb@chromium.org,emaxx@chromium.org,olsen@chromium.org Change-Id: I50c58b55830961d97834d86a76088dc50eff672d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 446937 Reviewed-on: https://chromium-review.googlesource.com/c/1278748 Reviewed-by: Florent Castelli <orphis@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#599143}
Changed files
- chrome/browser/chromeos/BUILD.gn
- chrome/browser/chromeos/app_mode/kiosk_app_manager.h
- chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher.cc
- chrome/browser/chromeos/chrome_browser_main_chromeos.cc
- chrome/browser/chromeos/dbus/dbus_helper.cc
- chrome/browser/chromeos/login/demo_mode/demo_session.cc
- chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
- chrome/browser/chromeos/policy/blocking_login_browsertest.cc
- chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
- chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
- chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
- chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
- chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
- chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
- chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
- chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
- chrome/browser/chromeos/policy/enrollment_status_chromeos.h
- chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
- chrome/browser/chromeos/settings/device_settings_provider.cc
- chrome/browser/chromeos/settings/install_attributes.cc
- chrome/browser/chromeos/settings/install_attributes.h
- chrome/browser/chromeos/settings/install_attributes_unittest.cc
- chrome/browser/chromeos/settings/stub_install_attributes.h
- chrome/browser/chromeos/system/device_disabling_manager.cc
- chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
- chrome/browser/ui/webui/policy_ui_handler.cc
- chromeos/DEPS
- chromeos/settings/BUILD.gn
- components/policy/core/common/BUILD.gn
- components/policy/core/common/cloud/cloud_policy_constants.cc
-
[css, dom] Support partmap="foo: bar" syntax.
Changed by Fergal Daly - fergalohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 08:26:25 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4cb84b573a62d8db8d168de16560b4ff78df5bda Comments
[css, dom] Support partmap="foo: bar" syntax. This is the new syntax agreed for partmap. Bug: 805271 Change-Id: I5e8e34551167b4a56706980dae8054e4b7a6fba2 Reviewed-on: https://chromium-review.googlesource.com/c/1278566 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#599142}
Changed files
- third_party/WebKit/LayoutTests/css-shadow-parts/double-forward.html
- third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-change-part-name-forward.html
- third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-change-partmap-forward.html
- third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-complex-selector-forward.html
- third_party/WebKit/LayoutTests/css-shadow-parts/precedence-part-vs-part.html
- third_party/WebKit/LayoutTests/css-shadow-parts/simple-forward.html
- third_party/blink/renderer/core/dom/element_test.cc
- third_party/blink/renderer/core/dom/names_map.cc
- third_party/blink/renderer/core/dom/names_map_test.cc
- third_party/blink/renderer/core/html/parser/html_parser_idioms.h
-
Chrome OS Powerwash screen: update icon and illustration.
Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 08:22:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision afc97ac06f5d3677c1016d1530c1e196844e2432 Comments
Chrome OS Powerwash screen: update icon and illustration. Bug: 894280 Change-Id: I0d478790d35323008a0622404ebde6983fea06ae Reviewed-on: https://chromium-review.googlesource.com/c/1278211 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599141}
Changed files
- chrome/browser/resources/chromeos/login/images/1x/reset_illustration_1x.svg
- chrome/browser/resources/chromeos/login/images/2x/reset_illustration_2x.svg
- chrome/browser/resources/chromeos/login/images/reset_illustration_1x.png
- chrome/browser/resources/chromeos/login/images/reset_illustration_2x.png
- chrome/browser/resources/chromeos/login/oobe_reset.css
- chrome/browser/resources/chromeos/login/oobe_reset.html
-
Move InstallAttributes to chromeos/settings
Changed by A Olsen - olsenohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 08:19:44 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision aa6c62dce936e966e2db445045dd04414553642b Comments
Move InstallAttributes to chromeos/settings Necessary for moving CrosSettings to chromeos/settings, so it can eventually be used by Mustash. The following changes were necessary: 1. Move install_attributes{.h, .cc} and unit_test.cc 2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn (destination) 3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h, which is included by install_attributes.h 4. Unfortunately, that same dependency lead to a circular dependency. I was able to avoid that by separating out a "common_constants" rule in components/policy/core/common, so that chromeos/settings only depends on that, and not on all of components/policy. So I had to change components/policy/core/common/BUILD.gn and I removed an unnecessary include from components/policy/core/common/cloud/cloud_policy_constants.cc 5. Update #include directives for install_attributes to point to new location. This is the other 22 files, all with diffs of +1 -1. Bug: 446937 Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288 Reviewed-on: https://chromium-review.googlesource.com/c/1264757 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#599140}Changed files
- chrome/browser/chromeos/BUILD.gn
- chrome/browser/chromeos/app_mode/kiosk_app_manager.h
- chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher.cc
- chrome/browser/chromeos/chrome_browser_main_chromeos.cc
- chrome/browser/chromeos/dbus/dbus_helper.cc
- chrome/browser/chromeos/login/demo_mode/demo_session.cc
- chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
- chrome/browser/chromeos/policy/blocking_login_browsertest.cc
- chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
- chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
- chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
- chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
- chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
- chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
- chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
- chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
- chrome/browser/chromeos/policy/enrollment_status_chromeos.h
- chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
- chrome/browser/chromeos/settings/device_settings_provider.cc
- chrome/browser/chromeos/settings/stub_install_attributes.h
- chrome/browser/chromeos/system/device_disabling_manager.cc
- chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
- chrome/browser/ui/webui/policy_ui_handler.cc
- chromeos/DEPS
- chromeos/settings/BUILD.gn
- chromeos/settings/install_attributes.cc
- chromeos/settings/install_attributes.h
- chromeos/settings/install_attributes_unittest.cc
- components/policy/core/common/BUILD.gn
- components/policy/core/common/cloud/cloud_policy_constants.cc
-
Import wpt@6446b4dc89324df48019ef6fa4999595d1f80abf
Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 08:18:19 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 112288aae86b2fcd3dde5b2a67872e292e54a8b0 Comments
Import wpt@6446b4dc89324df48019ef6fa4999595d1f80abf Using wpt-import in Chromium fb7986d88b0b8f174020916003d6939d2d928b83. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25972 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I9f8c2a91eb58657997bd243420a319e96a3ebc02 Reviewed-on: https://chromium-review.googlesource.com/c/1278059 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#599139}
Changed files
- third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
- third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-reuse.html
-
Override stub path before PreEarlyInitDBus
Changed by Roman Sorokin - rsorokinohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 08:10:23 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b80ea1c80ef7c8ec439c14def8120498fc35eda8 Comments
Override stub path before PreEarlyInitDBus Otherwise install attributes are not loaded on the linux Chrome OS build. TEST=manual Bug: 848615, 729596 Change-Id: I445b2b337b707822459c076058610f49f02767ab Reviewed-on: https://chromium-review.googlesource.com/c/1264643 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Xi Han <hanxi@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#599138}
Changed files
- chrome/browser/chromeos/chrome_browser_main_chromeos.cc
- chrome/browser/metrics/chrome_feature_list_creator.cc
-
Chrome OS: Integrate Discover PIN setup into First run UI.
Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 08:08:38 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 761a7e81af6dfcf0e5e1c29721d9a9c73a3dd19a Comments
Chrome OS: Integrate Discover PIN setup into First run UI. Bug: 852553 Change-Id: I215392305eee1555441d5dd66f0bb2908d0f5525 Reviewed-on: https://chromium-review.googlesource.com/c/1250136 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#599137}
Changed files
- chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc
- chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.h
- chrome/browser/chromeos/login/oobe_interactive_ui_test.cc
- chrome/browser/chromeos/login/session/user_session_manager.cc
- chrome/browser/chromeos/login/wizard_controller.cc
- chrome/browser/chromeos/login/wizard_controller.h
- chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
- chrome/browser/ui/webui/chromeos/login/discover/discover_manager.h
- chrome/browser/ui/webui/chromeos/login/discover/discover_ui.cc
-
Fix naming issue when renaming files inside My files
Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 08:02:18 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 40a6cb9be79a8d05395498a705e59d50cbb77f57 Comments
Fix naming issue when renaming files inside My files Change DirectoryModel to "unwrap" VolumeEntry when it's selected via file list. This fixes the issue where after selecting a VolumeEntry any operation in the private API would fail because it wouldn't be able to send a VolumeEntry to private API, because it requires a real Entry. This fixes the user issue of trying to rename and always getting "Use shorter name" error, even with a short name. Update FakeEntry to be an implementation of FilesAppDirEntry, since all users were using as directory, also update some functions to typing to use FilesAppDirEntry instead of FakeEntry which is more correct. Test: browser_tests --gtest_filter="*/myFilesFolderRename" Bug: 889636 Change-Id: Ieb75ffbb811a91e4742fb7a49a3badfd129376ad Reviewed-on: https://chromium-review.googlesource.com/c/1276067 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#599136}
Changed files
- chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
- ui/file_manager/file_manager/background/js/volume_info_impl.js
- ui/file_manager/file_manager/common/js/files_app_entry_types.js
- ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.js
- ui/file_manager/file_manager/foreground/js/directory_model.js
- ui/file_manager/file_manager/foreground/js/file_manager.js
- ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
- ui/file_manager/file_manager/foreground/js/file_watcher.js
- ui/file_manager/integration_tests/file_manager/my_files.js
-
media/gpu/v4l2: workaround VIDIOC_G_FMT bug in libtegrav4l2.so.
Changed by Alexandre Courbot - acourbotohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 07:54:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 029544dab67d79059b7610a92890091520ef7603 Comments
media/gpu/v4l2: workaround VIDIOC_G_FMT bug in libtegrav4l2.so. libtegrav4l2.so's implementation of V4L2_G_FMT has a bug which will make it return 0 planes for single-plane multiplanar formats. We obviously cannot have a multiplanar format with 0 planes, so add a workaround at the fake-ioctl level. Implement it as a case-switch for future-proofing against other workarounds we will likely have to add. Also add a few recommendations in v4l2_device.cc against the temptation to spare some memory by using an appropriately-sized array of v4l2_planes: it turns out libv4l2 also likes to write above the number of passed planes, and using anything shorter than VIDEO_MAX_PLANES will result in memory corruption DCHECKS being raised. BUG=893661 TEST=Checked that VDA unittest was passing on both hana and nyan_big. Change-Id: I7ea638f19f5bf0bdfaa0a47885577eb9dec4c225 Reviewed-on: https://chromium-review.googlesource.com/c/1275727 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by: Kuang-che Wu <kcwu@chromium.org> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#599135}
Changed files
- media/gpu/v4l2/tegra_v4l2_device.cc
- media/gpu/v4l2/v4l2_device.cc
-
Add browser tests for when we show the cookie exception
Changed by Jochen Eisinger - jochenohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 07:53:09 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision df554d02051d43d493d30cdf39fb1ee7566355bf Comments
Add browser tests for when we show the cookie exception Depending on the sync / sign-in state. BUG=890925 R=tangltom@chromium.org, msarda@chromium.org Change-Id: I784f13a4981250f851df770d111a13969a6892a6 Reviewed-on: https://chromium-review.googlesource.com/c/1273521 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#599134}
Changed files
- chrome/browser/browsing_data/counters/browsing_data_counter_utils_browsertest.cc
- chrome/test/BUILD.gn
-
Move thread-related functionalities in Platform to Thread.
Changed by Yuta Kitamura - yutakohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 07:47:14 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9deeac4682dc2c2a45fdf483c376c75011a09241 Comments
Move thread-related functionalities in Platform to Thread. This CL moves the most of implementation for Thread in Platform to Thread, so the Platform would contain less implementation (ideally, Platform should be a pure interface to embedders). Previously the global state of threads was stored in Platform, and this CL moves it to Thread. Now the thread-local storage for Blink threads and the main and compositor thread objects are stored as the global variable in thread.cc. This way, the threads state is completely separated from Platform. Old threading functions in Platform are deprecated now, and they will be migrated to Thread ones later. Due to those changes, some test utilities need to be updated. As the state of threads is not stored in Platform, the tests that need to override their main thread have to do that by themselves. To facilitate this, two new utility classes, ScopedMainThreadOverrider and ScopedSchedulerOverrider, are introduced, and TestingPlatform- SupportWithCustomScheduler is removed in favor of the new utilities. Bug: 826203 Change-Id: Ieb702dc85b7ffd75991055038f1165c2bfd7d058 Reviewed-on: https://chromium-review.googlesource.com/c/1273115 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#599133}
Changed files
- content/renderer/render_thread_impl.cc
- third_party/blink/public/platform/platform.h
- third_party/blink/renderer/core/dom/idle_deadline_test.cc
- third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
- third_party/blink/renderer/platform/BUILD.gn
- third_party/blink/renderer/platform/exported/platform.cc
- third_party/blink/renderer/platform/scheduler/common/thread.cc
- third_party/blink/renderer/platform/scheduler/public/thread.h
- third_party/blink/renderer/platform/testing/scoped_main_thread_overrider.cc
- third_party/blink/renderer/platform/testing/scoped_main_thread_overrider.h
- third_party/blink/renderer/platform/testing/scoped_scheduler_overrider.cc
- third_party/blink/renderer/platform/testing/scoped_scheduler_overrider.h
- third_party/blink/renderer/platform/testing/testing_platform_support.cc
- third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.cc
- third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.h
- third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.cc
- third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.h
-
Let ClientControlledState apply animation during bounds change.
Changed by Eliot Courtney - edcourtneyohnoyoudont@google.com Changed at Friday, 12-Oct-18 07:45:24 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 68084907a40caccccb72dd14c0ad3139b97747f7 Comments
Let ClientControlledState apply animation during bounds change. This CL introduces a new BoundsChangeAnimationType for ClientControlledState which will animate the window bounds for a specified duration. Bug: b/115291749 Bug: 841886 Test: Tested with local PIP prototype - applies animation. Change-Id: I8eda8b2131b8d3f679ade5cfbe64d7378efd6881 Reviewed-on: https://chromium-review.googlesource.com/c/1218385 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#599132}
Changed files
- ash/wm/client_controlled_state.cc
- ash/wm/client_controlled_state.h
- ash/wm/client_controlled_state_unittest.cc
- ash/wm/default_state.cc
- ash/wm/window_state.cc
- ash/wm/window_state.h
- ash/wm/wm_event.cc
- ash/wm/wm_event.h
- components/exo/client_controlled_shell_surface.cc
- components/exo/client_controlled_shell_surface_unittest.cc
-
[iOS] Remove ReadingList empty view
Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 07:44:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a53cbb1cdf96e0695e4d24cd408b52cc826d5088 Comments
[iOS] Remove ReadingList empty view This view was used in the old ReadingList implementation. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id4fa1df5a00f0dd572a2d4951764f422231e3874 Reviewed-on: https://chromium-review.googlesource.com/c/1276966 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#599131}
Changed files
- ios/chrome/browser/ui/reading_list/BUILD.gn
- ios/chrome/browser/ui/reading_list/empty_reading_list_background_view.h
- ios/chrome/browser/ui/reading_list/empty_reading_list_background_view.mm
- ios/chrome/browser/ui/reading_list/reading_list_egtest.mm
-
Chrome OS: Integrate PIN setup into Discover UI
Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 07:43:54 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f479db8f992be027ddc9b715919df65ad4e40bb6 Comments
Chrome OS: Integrate PIN setup into Discover UI Bug: 852553 Change-Id: I460a420b1dd0024eaebb114aac2368a7bb3f28ae Reviewed-on: https://chromium-review.googlesource.com/c/1249496 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#599130}
Changed files
- chrome/app/chromeos_strings.grdp
- chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP.png.sha1
- chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_DONE.png.sha1
- chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_PASSWORD_SUBTITLE.png.sha1
- chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_PASSWORD_TITLE.png.sha1
- chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_SUBTITLE3.png.sha1
- chrome/browser/chromeos/login/session/user_session_manager.cc
- chrome/browser/resources/chromeos/login/discover/discover_app.html
- chrome/browser/resources/chromeos/login/discover/discover_app.js
- chrome/browser/resources/chromeos/login/discover/discover_components.html
- chrome/browser/resources/chromeos/login/discover/discover_components.js
- chrome/browser/resources/chromeos/login/discover/discover_module_behavior.js
- chrome/browser/resources/chromeos/login/discover/discover_ui.html
- chrome/browser/resources/chromeos/login/discover/discover_ui.js
- chrome/browser/resources/chromeos/login/discover/discover_welcome.css
- chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.css
- chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.html
- chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.js
- chrome/browser/resources/chromeos/login/discover/modules/images/pin_illustration_1x.svg
- chrome/browser/resources/chromeos/login/discover/modules/images/pin_illustration_2x.svg
- chrome/browser/resources/chromeos/login/screen_discover.html
- chrome/browser/ui/BUILD.gn
- chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
- chrome/browser/ui/webui/chromeos/login/discover/discover_manager.h
- chrome/browser/ui/webui/chromeos/login/discover/discover_module.h
- chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_launch_help_app.cc
- chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_launch_help_app.h
- chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_pin_setup.cc
- chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_pin_setup.h
- chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_redeem_offers.cc
- chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_redeem_offers.h
- chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_sync_files.cc
- chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_sync_files.h
- chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_welcome.cc
- chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_welcome.h
- chrome/common/extensions/api/_api_features.json