Builder Linux FYI Release (AMD R7 240) Build 2762
Results:
Success
Trigger Info:
Project | chromium |
Revision | ac7eccb32027d854536717a0eb589f3784037428 |
Got Revision | ac7eccb32027d854536717a0eb589f3784037428 |
Execution:
- Source: Task 428283a31662f110
- Bot: swarm1080-c4
- Recipe: chromium
Steps and Logfiles:
Show:-
( 232 ms ) report buildersrunning tester 'Linux FYI Release (AMD R7 240)' on master 'chromium.gpu.fyi'
-
- - no logs -
-
( 1 secs ) read test spec (chromium.gpu.fyi.json)path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
-
( 447 ms ) lookup builder GN argsbuild_angle_gles1_conform_tests = truedcheck_always_on = trueffmpeg_branding = "Chrome"internal_gles2_conform_tests = trueis_component_build = falseis_debug = falseproprietary_codecs = truestrip_absolute_paths_from_debug_symbols = truesymbol_level = 1use_goma = truegoma_dir = "/b/swarming/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] angle_white_box_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 1 secs ) angle_white_box_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 7s
-
- - no logs -
-
( 908 ms ) test_pre_run.[trigger] tab_capture_end2end_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 40 secs ) tab_capture_end2end_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Pending time: 14sShard duration: 22s
-
- - no logs -
-
- - no logs -
-
( 856 ms ) test_pre_run.[trigger] gles2_conform_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] swiftshader_unittests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 1 secs ) swiftshader_unittests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 4s
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] context_lost_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 3 mins 14 secs ) context_lost_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:03:10.610339Total tests: 10* Passed: 10 (10 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] depth_capture_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 27 secs ) depth_capture_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 25sTotal tests: 3* Passed: 3 (3 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 898 ms ) test_pre_run.[trigger] gpu_process_launch_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 2 mins 55 secs ) gpu_process_launch_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:02:50.693086Total tests: 15* Passed: 15 (15 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] hardware_accelerated_feature_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 25 secs ) hardware_accelerated_feature_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 22sTotal tests: 2* Passed: 2 (2 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 859 ms ) test_pre_run.[trigger] info_collection_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 25 secs ) info_collection_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 21sTotal tests: 1* Passed: 1 (1 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 36 secs ) maps_pixel_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 32sTotal tests: 1* Passed: 1 (1 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 9 mins 12 secs ) pixel_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:09:10.092167Total tests: 49* Passed: 49 (49 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 859 ms ) test_pre_run.[trigger] screenshot_sync_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 1 mins 16 secs ) screenshot_sync_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:01:13.266858Total tests: 4* Passed: 4 (4 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 5 mins 12 secs ) trace_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:05:04.934184Total tests: 48* Passed: 24 (24 expected, 0 unexpected)* Skipped: 24 (24 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 11 secs ) test_pre_run.[trigger] webgl2_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 2 hrs 5 mins ) webgl2_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Max pending time: 1:58:56.406124 (shard #19)Max shard duration: 0:06:56.343553 (shard #4)Min shard duration: 0:05:26.356930 (shard #7)Total tests: 2803* Passed: 2735 (2735 expected, 0 unexpected)* Skipped: 68 (68 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
- stdout
- json.output
- swarming.summary
- Merge script log
- outdir_json
- step_metadata
- shard #0 isolated out
- shard #0 (363.4 sec)
- shard #1 isolated out
- shard #1 (344.7 sec)
- shard #2 isolated out
- shard #2 (344.1 sec)
- shard #3 isolated out
- shard #3 (362.0 sec)
- shard #4 isolated out
- shard #4 (409.6 sec)
- shard #5 isolated out
- shard #5 (382.0 sec)
- shard #6 isolated out
- shard #6 (402.0 sec)
- shard #7 isolated out
- shard #7 (319.6 sec)
- shard #8 isolated out
- shard #8 (381.0 sec)
- shard #9 isolated out
- shard #9 (352.6 sec)
- shard #10 isolated out
- shard #10 (407.2 sec)
- shard #11 isolated out
- shard #11 (361.0 sec)
- shard #12 isolated out
- shard #12 (384.7 sec)
- shard #13 isolated out
- shard #13 (338.0 sec)
- shard #14 isolated out
- shard #14 (321.8 sec)
- shard #15 isolated out
- shard #15 (379.3 sec)
- shard #16 isolated out
- shard #16 (383.2 sec)
- shard #17 isolated out
- shard #17 (348.1 sec)
- shard #18 isolated out
- shard #18 (401.2 sec)
- shard #19 isolated out
- shard #19 (390.2 sec)
-
- - no logs -
-
( 2 secs ) test_pre_run.[trigger] webgl_conformance_gl_passthrough_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 8 mins 34 secs ) webgl_conformance_gl_passthrough_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Max pending time: 0:02:19.269852 (shard #1)Max shard duration: 0:06:05.403009 (shard #1)Min shard duration: 0:02:07.100989 (shard #0)Total tests: 938* Passed: 932 (932 expected, 0 unexpected)* Skipped: 6 (6 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] webgl_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 9 mins 10 secs ) webgl_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Max pending time: 0:02:17.721534 (shard #1)Max shard duration: 0:06:51.138810 (shard #1)Min shard duration: 0:02:14.759425 (shard #0)Total tests: 938* Passed: 932 (932 expected, 0 unexpected)* Skipped: 6 (6 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm1080-c4" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547961505833475, "id": "8923838432018312160", "project": "chromium", "tags": ["builder:Linux FYI Release (AMD R7 240)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/ac7eccb32027d854536717a0eb589f3784037428", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Linux Builder", "parent_buildnumber:39885", "scheduler_invocation_id:9089268494156596016", "scheduler_job_id:chromium/Linux FYI Release (AMD R7 240)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "Linux FYI Release (AMD R7 240)" | setup_build |
buildnumber | 2762 | setup_build |
mastername | "chromium.gpu.fyi" | setup_build |
parent_buildername | "GPU FYI Linux Builder" | setup_build |
parent_got_angle_revision | "7403dd2cd3764fe96660fe09892e764e9ae1dbca" | setup_build |
parent_got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | setup_build |
parent_got_dawn_revision | "850c0d9aec6bd3f63cb58ff1838380efc112279a" | setup_build |
parent_got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | setup_build |
parent_got_revision | "ac7eccb32027d854536717a0eb589f3784037428" | setup_build |
parent_got_revision_cp | "refs/heads/master@{#624484}" | setup_build |
parent_got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | setup_build |
parent_got_v8_revision | "49d3755f33eb8f2e44b2da7ba21556429d6b2493" | setup_build |
parent_got_v8_revision_cp | "refs/heads/7.3.451@{#1}" | setup_build |
parent_got_webrtc_revision | "74ba99062c48b278675cfe52643719202296fddc" | setup_build |
parent_got_webrtc_revision_cp | "refs/heads/master@{#26298}" | setup_build |
parent_mastername | "chromium.gpu.fyi" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
revision | "ac7eccb32027d854536717a0eb589f3784037428" | setup_build |
swarm_hashes | {"angle_end2end_tests": "fd9b0a1227543187c42cd9df024407aa9950d28a", "angle_perftests": "7c2a833205f660ad79f1951667421db793a72dc3", "angle_unittests": "7c9b4bb307e39b6c4d0c78cc99bb71cf3d10bddc", "angle_white_box_tests": "d6850f6d3b6ab22dd6dd0c72794b30c48ee543ca", "browser_tests": "0445ed771dc2ece26acb0353eb2fb7c517429568", "dawn_end2end_tests": "ad3bd639ddd0d8d39f5b0d15cea6107b0791a0b7", "gl_tests": "4f0db34fa7b160c1dcc04cf701266279bd5ba4ac", "gl_unittests": "10c7ef28bc3272b862e2f75c45bb843977bdf8ab", "gles2_conform_test": "bf00ef6f43dd4a32302ab528d4ca5d667fc17883", "swiftshader_unittests": "5d24bee11c642538ad5762e7cb81c364c09aabbd", "telemetry_gpu_integration_test": "0f6f124ca52e50eea3b54c1465b3f591ddc8d746"} | setup_build |
got_angle_revision | "7403dd2cd3764fe96660fe09892e764e9ae1dbca" | bot_update |
got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | bot_update |
got_dawn_revision | "850c0d9aec6bd3f63cb58ff1838380efc112279a" | bot_update |
got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
got_revision | "ac7eccb32027d854536717a0eb589f3784037428" | bot_update |
got_revision_cp | "refs/heads/master@{#624484}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "49d3755f33eb8f2e44b2da7ba21556429d6b2493" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.451@{#1}" | bot_update |
got_webrtc_revision | "74ba99062c48b278675cfe52643719202296fddc" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26298}" | bot_update |
swarm_hashes | {} | find isolated tests |
Blamelist:
- chrome-release-bot (chrome-release-botohnoyoudont@chromium.org)
- Mike Reed (reedohnoyoudont@google.com)
- Paul Miller (paulmillerohnoyoudont@google.com)
- Avi Drissman (aviohnoyoudont@chromium.org)
- Xing Liu (xingliuohnoyoudont@chromium.org)
- Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
- Christopher Cameron (ccameronohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- edchin (edchinohnoyoudont@chromium.org)
Timing:
Create | Sunday, 20-Jan-19 05:18:25 UTC |
Start | Sunday, 20-Jan-19 05:18:32 UTC |
End | Sunday, 20-Jan-19 08:10:02 UTC |
Pending | 6 secs |
Execution | 2 hrs 51 mins |
All Changes:
-
Updating trunk VERSION from 3678.0 to 3679.0
Changed by chrome-release-bot - chrome-release-botohnoyoudont@chromium.org Changed at Sunday, 20-Jan-19 04:10:27 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ac7eccb32027d854536717a0eb589f3784037428 Comments
Updating trunk VERSION from 3678.0 to 3679.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ibb7e15ab616701cb8ae8632b164552ef8eac4ae7 Reviewed-on: https://chromium-review.googlesource.com/c/1422963 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#624484}
Changed files
- chrome/VERSION
-
fix typo from prev refactor -- hinting is on font
Changed by Mike Reed - reedohnoyoudont@google.com Changed at Sunday, 20-Jan-19 02:35:41 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 08bdd0605e5e93030faacefaf4d7a7f4bab17d14 Comments
fix typo from prev refactor -- hinting is on font ... and IWYU Preparation for https://skia-review.googlesource.com/c/skia/+/185460 TBR= Bug: skia:2664 Change-Id: I9379ad69c3e7baabf736dd2e7d2c285eb81d43b4 Reviewed-on: https://chromium-review.googlesource.com/c/1423627 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#624483}
Changed files
- chrome/renderer/pepper/pepper_flash_renderer_host.cc
- third_party/blink/public/platform/web_font_render_style.h
- third_party/blink/renderer/platform/fonts/font_metrics.cc
- third_party/blink/renderer/platform/fonts/simple_font_data.cc
- ui/gfx/render_text_harfbuzz.cc
-
WebView: Activate AndroidWebViewSessionConsistencyTest
Changed by Paul Miller - paulmillerohnoyoudont@google.com Changed at Sunday, 20-Jan-19 02:35:38 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7ceb27aaaf6fe73e7902c88ce2bd032edc78ec49 Comments
WebView: Activate AndroidWebViewSessionConsistencyTest This study doesn't do anything except exercise session-consistency. Query it once to "activate" it, so it shows up in the logs when WebViewLogVerbosifier.apk is installed, so QA can verify permanent-consistency. BUG=866722 Change-Id: I435b6ed5c93e105ebb49705078f4362eb46e109b Reviewed-on: https://chromium-review.googlesource.com/c/1423837 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#624482}
Changed files
- android_webview/browser/aw_feature_list_creator.cc
-
Alphabetize the flag.json file.
Changed by Avi Drissman - aviohnoyoudont@chromium.org Changed at Sunday, 20-Jan-19 02:34:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7303b44ce364ca00c805bedbcf6a6843688a934a Comments
Alphabetize the flag.json file. I accidentally allowed an entry at the end and didn't notice it being commented out. Fixing. BUG=none TBR=ellyjones@chromium.org Change-Id: I320d7515a94612bc69003adf5617abf2adafcbb6 Reviewed-on: https://chromium-review.googlesource.com/c/1423600 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#624481}
Changed files
- chrome/browser/flag-metadata.json
-
Adds a feature flag for foreground notification manager.
Changed by Xing Liu - xingliuohnoyoudont@chromium.org Changed at Sunday, 20-Jan-19 02:34:18 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7d57dd38a90a426d78e9f2303fb5544c2a8ec00f Comments
Adds a feature flag for foreground notification manager. This CL adds a feature flag for the new foreground notification manager system. Bug: 916659 Change-Id: I9e0fc128a9b094ec438e3c0efcd9da50baa9e15a Reviewed-on: https://chromium-review.googlesource.com/c/1389440 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#624480}
Changed files
- chrome/browser/about_flags.cc
- chrome/browser/android/chrome_feature_list.cc
- chrome/browser/android/chrome_feature_list.h
- chrome/browser/flag-metadata.json
- chrome/browser/flag_descriptions.cc
- chrome/browser/flag_descriptions.h
- tools/metrics/histograms/enums.xml
-
DocumentLoader: make srcdoc navigations async (attempt #2)
Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org Changed at Sunday, 20-Jan-19 02:33:15 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6899796671705603bab3ee6eefd21ac385ca9bc8 Comments
DocumentLoader: make srcdoc navigations async (attempt #2) about:srcdoc is not actually an empty document, so there is no real need to load it synchronously. data-saver.html is split in two, because it relied on specific order between calling internals.setSaveDataEnabled and committing navigation for two separate srcdoc iframes. Includes the following fixes comparing to attempt #1: 1. When script removes iframe's srcdoc attribute after the navigation has been scheduled, but before we retrieve the srcdoc content from the attribute, we could try to load about:srcdoc from the network. Instead, we should just load an empty document. 2. Iframe with src="about:srcdoc" should just load blank instead of issuing a network request for about:srcdoc. 3. Simplify how we pass "is srcdoc" to the document itself, now using DocumentInit instead of calling a method on FrameLoader. This avoids a similar race between starting the main resource load and creating a document. Bug: 919839, 855189 Change-Id: Ie5a9cbcf66ab93b9deea09ee8e756d10e48c741b Reviewed-on: https://chromium-review.googlesource.com/c/1409809 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#624479}
Changed files
- third_party/blink/renderer/core/dom/document.cc
- third_party/blink/renderer/core/dom/document_init.cc
- third_party/blink/renderer/core/dom/document_init.h
- third_party/blink/renderer/core/loader/document_loader.cc
- third_party/blink/renderer/core/loader/document_loader.h
- third_party/blink/renderer/core/loader/frame_loader.cc
- third_party/blink/renderer/core/loader/frame_loader.h
- third_party/blink/web_tests/http/tests/fetch/chromium/data-saver-enabled.html
- third_party/blink/web_tests/http/tests/fetch/chromium/data-saver.html
- third_party/blink/web_tests/http/tests/navigation/srcdoc-as-src-expected.txt
- third_party/blink/web_tests/http/tests/navigation/srcdoc-as-src.html
- third_party/blink/web_tests/http/tests/navigation/srcdoc-attribute-reset-expected.txt
- third_party/blink/web_tests/http/tests/navigation/srcdoc-attribute-reset.html
-
Disable app shim signature check
Changed by Christopher Cameron - ccameronohnoyoudont@chromium.org Changed at Sunday, 20-Jan-19 02:33:11 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision add2f7a11d13cf857b95ccb575afcd5d66690532 Comments
Disable app shim signature check App shims aren't starting on 73.0.3677.0. TBR=sdy Bug: 624228 Change-Id: Ied8fdac4986b61db99333527b118f319d808d5c7 Reviewed-on: https://chromium-review.googlesource.com/c/1424159 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#624478}
Changed files
- chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc
-
Roll src/third_party/skia 60bff2366ee7..66e184425565 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Sunday, 20-Jan-19 02:32:10 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1d3dead200d2b2297247fed3c16e2a56209d7b84 Comments
Roll src/third_party/skia 60bff2366ee7..66e184425565 (1 commits) https://skia.googlesource.com/skia.git/+log/60bff2366ee7..66e184425565 git log 60bff2366ee7..66e184425565 --date=short --no-merges --format='%ad %ae %s' 2019-01-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 3ff6f8afb698..b1e66fcbbc89 (287 commits) Created with: gclient setdep -r src/third_party/skia@66e184425565 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: I732a1cef02d06d64fb0486ff89c64bc25512851f Reviewed-on: https://chromium-review.googlesource.com/c/1424002 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624477}
Changed files
- DEPS
-
[ios] Refactor tab printing
Changed by edchin - edchinohnoyoudont@chromium.org Changed at Sunday, 20-Jan-19 02:32:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision be8d2b21137bfcfb5a4e376447a5568c74f1e554 Comments
[ios] Refactor tab printing This CL does the following: 1) Removes printing code from BVC because it is not necessary there. This is accomplished by directly connecting the PrintTabHelper to the PrintController, which presents the system print dialog. Previously, it was going through the BVC as an intermediary. 2) PrintTabHelper creation is moved to AttachTabHelpers() where it belongs. This splits setting the printer delegate from the tab helper creation. This is the preferred structure. This CL moves the print code in the right direction. In the future, PrintController should be renamed and refactored as a coordinator. Bug: 910017 Change-Id: Ifd21f9959d2926c9b8f661f71f22eb0b73f96dd4 Reviewed-on: https://chromium-review.googlesource.com/c/1419538 Commit-Queue: edchin <edchin@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#624476}
Changed files
- ios/chrome/browser/tabs/tab_helper_util.mm
- ios/chrome/browser/ui/browser_view_controller.mm
- ios/chrome/browser/ui/main/BUILD.gn
- ios/chrome/browser/ui/main/browser_coordinator.mm
- ios/chrome/browser/ui/print/BUILD.gn
- ios/chrome/browser/ui/print/print_controller.h
- ios/chrome/browser/ui/print/print_controller.mm
- ios/chrome/browser/web/print_tab_helper.h
- ios/chrome/browser/web/print_tab_helper.mm