Builder Linux FYI Release (AMD R7 240) Build 2751
Results:
Success
Trigger Info:
Project | chromium |
Revision | d291b28fc62a52a0600837c6793be4fb5cce1247 |
Got Revision | d291b28fc62a52a0600837c6793be4fb5cce1247 |
Execution:
- Source: Task 427ae34ee2a30010
- Bot: swarm1080-c4
- Recipe: chromium
Steps and Logfiles:
Show:-
( 824 ms ) report buildersrunning tester 'Linux FYI Release (AMD R7 240)' on master 'chromium.gpu.fyi'
-
- - no logs -
-
( 1 secs ) read test spec (chromium.gpu.fyi.json)path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
-
( 508 ms ) lookup builder GN argsbuild_angle_gles1_conform_tests = truedcheck_always_on = trueffmpeg_branding = "Chrome"internal_gles2_conform_tests = trueis_component_build = falseis_debug = falseproprietary_codecs = truestrip_absolute_paths_from_debug_symbols = truesymbol_level = 1use_goma = truegoma_dir = "/b/swarming/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] angle_white_box_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 1 secs ) angle_white_box_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 8s
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] tab_capture_end2end_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 50 secs ) tab_capture_end2end_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Pending time: 25sShard duration: 22s
-
- - no logs -
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] gles2_conform_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] swiftshader_unittests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 1 secs ) swiftshader_unittests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 5s
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] context_lost_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 3 mins 14 secs ) context_lost_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:03:09.210251Total tests: 10* Passed: 10 (10 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] depth_capture_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 28 secs ) depth_capture_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 25sTotal tests: 3* Passed: 3 (3 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] gpu_process_launch_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 2 mins 57 secs ) gpu_process_launch_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:02:50.650253Total tests: 15* Passed: 15 (15 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 922 ms ) test_pre_run.[trigger] hardware_accelerated_feature_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 26 secs ) hardware_accelerated_feature_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 22sTotal tests: 2* Passed: 2 (2 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] info_collection_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 27 secs ) info_collection_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 23sTotal tests: 1* Passed: 1 (1 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 42 secs ) maps_pixel_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 37sTotal tests: 1* Passed: 1 (1 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 9 mins 18 secs ) pixel_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:09:09.548046Total tests: 49* Passed: 49 (49 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 900 ms ) test_pre_run.[trigger] screenshot_sync_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 1 mins 21 secs ) screenshot_sync_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:01:15.100803Total tests: 4* Passed: 4 (4 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 5 mins 7 secs ) trace_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:05:00.203342Total tests: 48* Passed: 24 (24 expected, 0 unexpected)* Skipped: 24 (24 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 14 secs ) test_pre_run.[trigger] webgl2_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 2 hrs 6 mins ) webgl2_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Max pending time: 1:59:36.994902 (shard #19)Max shard duration: 0:07:08.070501 (shard #4)Min shard duration: 0:05:27.195691 (shard #14)Total tests: 2803* Passed: 2735 (2735 expected, 0 unexpected)* Skipped: 68 (68 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
- stdout
- json.output
- swarming.summary
- Merge script log
- outdir_json
- step_metadata
- shard #0 isolated out
- shard #0 (369.6 sec)
- shard #1 isolated out
- shard #1 (350.0 sec)
- shard #2 isolated out
- shard #2 (344.2 sec)
- shard #3 isolated out
- shard #3 (374.3 sec)
- shard #4 isolated out
- shard #4 (421.6 sec)
- shard #5 isolated out
- shard #5 (386.5 sec)
- shard #6 isolated out
- shard #6 (396.5 sec)
- shard #7 isolated out
- shard #7 (321.1 sec)
- shard #8 isolated out
- shard #8 (370.4 sec)
- shard #9 isolated out
- shard #9 (356.1 sec)
- shard #10 isolated out
- shard #10 (404.5 sec)
- shard #11 isolated out
- shard #11 (364.4 sec)
- shard #12 isolated out
- shard #12 (389.2 sec)
- shard #13 isolated out
- shard #13 (335.2 sec)
- shard #14 isolated out
- shard #14 (320.9 sec)
- shard #15 isolated out
- shard #15 (384.3 sec)
- shard #16 isolated out
- shard #16 (378.0 sec)
- shard #17 isolated out
- shard #17 (353.0 sec)
- shard #18 isolated out
- shard #18 (404.5 sec)
- shard #19 isolated out
- shard #19 (394.1 sec)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] webgl_conformance_gl_passthrough_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 8 mins 17 secs ) webgl_conformance_gl_passthrough_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Max pending time: 0:02:13.722567 (shard #1)Max shard duration: 0:05:57.803514 (shard #1)Min shard duration: 0:02:12.179088 (shard #0)Total tests: 938* Passed: 932 (932 expected, 0 unexpected)* Skipped: 6 (6 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] webgl_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 9 mins 28 secs ) webgl_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Max pending time: 0:02:18.835856 (shard #1)Max shard duration: 0:06:54.214611 (shard #1)Min shard duration: 0:02:13.507320 (shard #0)Total tests: 938* Passed: 932 (932 expected, 0 unexpected)* Skipped: 6 (6 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm1080-c4" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547833555838096, "id": "8923972597311922336", "project": "chromium", "tags": ["builder:Linux FYI Release (AMD R7 240)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/d291b28fc62a52a0600837c6793be4fb5cce1247", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Linux Builder", "parent_buildnumber:39758", "scheduler_invocation_id:9089402659682238720", "scheduler_job_id:chromium/Linux FYI Release (AMD R7 240)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "Linux FYI Release (AMD R7 240)" | setup_build |
buildnumber | 2751 | setup_build |
mastername | "chromium.gpu.fyi" | setup_build |
parent_buildername | "GPU FYI Linux Builder" | setup_build |
parent_got_angle_revision | "1f750d1e3b50c3c05766a310fdb8606671ec2813" | setup_build |
parent_got_buildtools_revision | "40194ab03962d8183b2796fa58a39ec8a9e83a41" | setup_build |
parent_got_dawn_revision | "850c0d9aec6bd3f63cb58ff1838380efc112279a" | setup_build |
parent_got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | setup_build |
parent_got_revision | "d291b28fc62a52a0600837c6793be4fb5cce1247" | setup_build |
parent_got_revision_cp | "refs/heads/master@{#624185}" | setup_build |
parent_got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | setup_build |
parent_got_v8_revision | "7d071b566681784c84d20dcd8ddb502e3dd959d8" | setup_build |
parent_got_v8_revision_cp | "refs/heads/7.3.443@{#1}" | setup_build |
parent_got_webrtc_revision | "74ba99062c48b278675cfe52643719202296fddc" | setup_build |
parent_got_webrtc_revision_cp | "refs/heads/master@{#26298}" | setup_build |
parent_mastername | "chromium.gpu.fyi" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
revision | "d291b28fc62a52a0600837c6793be4fb5cce1247" | setup_build |
swarm_hashes | {"angle_end2end_tests": "e7f7b2f414eda11c364678ae69f01a38433c21d8", "angle_perftests": "e695bd92190a7a0e598ae45ddc39d646d8e097ef", "angle_unittests": "90600456165da01c38bd93f722fbb98e0bbc703e", "angle_white_box_tests": "ee18ecd98e26c8d22c3410851992fed4e6f54147", "browser_tests": "7f35e41444ae93eb3173948173eedcc5f70abad7", "dawn_end2end_tests": "b802b1a60763cf64dfbd6cb203123a901410850d", "gl_tests": "e8556b51bf0c4807620aead99bc4ad5ec8f3c98f", "gl_unittests": "1f2997559c04d39b54e5ae945fc4ed9d3b2fddd3", "gles2_conform_test": "afa1341e0cc73c8ed928bbc2749b8ebb8135b190", "swiftshader_unittests": "84fa6663a1dd12e99764c625b2718c6c9b2f6e00", "telemetry_gpu_integration_test": "143634832a9d4bb51d77376967ba01fd834f71ab"} | setup_build |
got_angle_revision | "1f750d1e3b50c3c05766a310fdb8606671ec2813" | bot_update |
got_buildtools_revision | "40194ab03962d8183b2796fa58a39ec8a9e83a41" | bot_update |
got_dawn_revision | "850c0d9aec6bd3f63cb58ff1838380efc112279a" | bot_update |
got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
got_revision | "d291b28fc62a52a0600837c6793be4fb5cce1247" | bot_update |
got_revision_cp | "refs/heads/master@{#624185}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "7d071b566681784c84d20dcd8ddb502e3dd959d8" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.443@{#1}" | bot_update |
got_webrtc_revision | "74ba99062c48b278675cfe52643719202296fddc" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26298}" | bot_update |
swarm_hashes | {} | find isolated tests |
Blamelist:
- Mario Sanchez Prada (marioohnoyoudont@igalia.com)
- John Budorick (jbudorickohnoyoudont@chromium.org)
- Aaron Colwell (acolwellohnoyoudont@google.com)
- Jun Mukai (mukaiohnoyoudont@chromium.org)
- Nicolas Ouellet-payeur (nicolasoohnoyoudont@chromium.org)
- Jordan Demeulenaere (jdemeulenaereohnoyoudont@google.com)
- Moe Ahmadi (mahmadiohnoyoudont@chromium.org)
- Xiaohan Wang (xhwangohnoyoudont@chromium.org)
- Jeffrey Cohen (jeffreycohenohnoyoudont@chromium.org)
- Navid Zolghadr (nzolghadrohnoyoudont@chromium.org)
- Gabriel Charette (gabohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Mario Sanchez Prada (marioohnoyoudont@igalia.com)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
- François Beaufort (beaufort.francoisohnoyoudont@gmail.com)
- Alexandre Frechette (frechetteohnoyoudont@chromium.org)
- Felipe Cerqueira (cerqueiraohnoyoudont@chromium.org)
- Brian White (bcwhiteohnoyoudont@chromium.org)
- Aga Wronska (agawronskaohnoyoudont@chromium.org)
- David 'Digit' Turner (digitohnoyoudont@google.com)
- Ehsan Karamad (ekaramadohnoyoudont@chromium.org)
- Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
- Shahbaz Youssefi (syoussefiohnoyoudont@chromium.org)
- Kenneth Russell (kbrohnoyoudont@chromium.org)
- Lowell Manners (lowellohnoyoudont@chromium.org)
- Antonio Gomes (tonikitooohnoyoudont@igalia.com)
- Kush Sinha (sinhakohnoyoudont@chromium.org)
- Kyle Milka (kmilkaohnoyoudont@chromium.org)
- v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
- Nate Fischer (ntfschrohnoyoudont@chromium.org)
- sebsg (sebsgohnoyoudont@chromium.org)
- Henrik Boström (hbosohnoyoudont@chromium.org)
- James Cook (jamescookohnoyoudont@chromium.org)
- Matthew Jones (mdjonesohnoyoudont@chromium.org)
- Christopher Lam (calamityohnoyoudont@chromium.org)
- Ian Kilpatrick (ikilpatrickohnoyoudont@chromium.org)
- Jamie Madill (jmadillohnoyoudont@chromium.org)
- Lei Zhang (thestigohnoyoudont@chromium.org)
- Yuichiro Hanada (yhanadaohnoyoudont@chromium.org)
- Yutaka Hirano (yhiranoohnoyoudont@chromium.org)
- Steven Bingler (binglerohnoyoudont@chromium.org)
- Misha Efimov (mefohnoyoudont@google.com)
- Brian White (bcwhiteohnoyoudont@chromium.org)
- Yuichiro Hanada (yhanadaohnoyoudont@chromium.org)
- Gauthier Ambard (gambardohnoyoudont@chromium.org)
- John Budorick (jbudorickohnoyoudont@chromium.org)
- Antonio Gomes (tonikitooohnoyoudont@igalia.com)
- chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
- Stephen Nusko (nuskosohnoyoudont@chromium.org)
- Andrew Grieve (agrieveohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- François Beaufort (beaufort.francoisohnoyoudont@gmail.com)
- Gabriel Charette (gabohnoyoudont@chromium.org)
- Takuto Ikuta (tikutaohnoyoudont@chromium.org)
- Paul Jensen (pauljensenohnoyoudont@chromium.org)
- Shakti Sahu (shaktisahuohnoyoudont@chromium.org)
- Antonio Gomes (tonikitooohnoyoudont@igalia.com)
- Joe Mason (joenotcharlesohnoyoudont@google.com)
- Aditya Keerthi (adityakeerthiohnoyoudont@google.com)
- François Beaufort (beaufort.francoisohnoyoudont@gmail.com)
- manuk (manukhohnoyoudont@chromium.org)
- Julie Jeongeun Kim (jkimohnoyoudont@igalia.com)
- Cathy Li (chiliohnoyoudont@chromium.org)
- John Budorick (jbudorickohnoyoudont@chromium.org)
- Vlad Tsyrklevich (vtsyrklevichohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
- Dominik Röttsches (drottohnoyoudont@chromium.org)
- Alexander Timin (altiminohnoyoudont@chromium.org)
- François Beaufort (beaufort.francoisohnoyoudont@gmail.com)
- Yutaka Hirano (yhiranoohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Jérôme Lebel (jlebelohnoyoudont@chromium.org)
- Abhijeet Kandalkar (abhijeetohnoyoudont@igalia.com)
Timing:
Create | Friday, 18-Jan-19 17:45:55 UTC |
Start | Friday, 18-Jan-19 17:46:34 UTC |
End | Friday, 18-Jan-19 20:43:02 UTC |
Pending | 38 secs |
Execution | 2 hrs 56 mins |
All Changes:
-
Add API to replace ATS::{IsMigrationSupported,GetMigrationState}
Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com Changed at Friday, 18-Jan-19 17:38:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d291b28fc62a52a0600837c6793be4fb5cce1247 Comments
Add API to replace ATS::{IsMigrationSupported,GetMigrationState} Add the following two legacy methods to IdentityManager that to help with the migration to the Identity service: - IsAccountIdMigrationSupported() - GetAccountIdMigrationState() Bug: 922477 Change-Id: Ic55a21fa70231b6c85227888d5a6a153b886b647 Reviewed-on: https://chromium-review.googlesource.com/c/1418052 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#624185}
Changed files
- services/identity/public/cpp/identity_manager.cc
- services/identity/public/cpp/identity_manager.h
- services/identity/public/cpp/identity_manager_unittest.cc
-
Disable TabRestoreTest.RestoreTabWithSpecialURL on windows.
Changed by John Budorick - jbudorickohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 17:38:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f183fb456d036882ab326c771cc48b5a6174d12b Comments
Disable TabRestoreTest.RestoreTabWithSpecialURL on windows. Tbr: chrisha@chromium.org,sky@chromium.org,gab@chromium.org Bug: 825305 Change-Id: I662b4fa1e6ae45ef9c8864db0f3ddd15ea544591 Reviewed-on: https://chromium-review.googlesource.com/c/1421679 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#624184}
Changed files
- chrome/browser/sessions/tab_restore_browsertest.cc
-
Fix 'Unauthorized origin' errors during shutdown.
Changed by Aaron Colwell - acolwellohnoyoudont@google.com Changed at Friday, 18-Jan-19 17:37:03 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1c42a93d925648ba7d0795bf8de76aeb1e4854a3 Comments
Fix 'Unauthorized origin' errors during shutdown. The RenderProcessHost can be shutdown while a WebDatabaseHostImpl security check task is pending. This happens because WebDatabaseHostImpl must post a task from the DB thread to the UI thread to conduct the security check. This change avoids triggering a 'Unauthorized origin' error by simply verifying that the RenderProcessHost still exists by the time the task is run on the UI thread. Bug: 915203 Change-Id: I0af5f351eaf65a8d74dad2f268f70b51a33812ad Reviewed-on: https://chromium-review.googlesource.com/c/1416840 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#624183}
Changed files
- content/browser/renderer_host/web_database_host_impl.cc
- content/browser/renderer_host/web_database_host_impl.h
- content/browser/renderer_host/web_database_host_impl_unittest.cc
-
Set always-on-top widgets non-activatable in Mash
Changed by Jun Mukai - mukaiohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 17:34:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2bcce6449fcc55bc3ac94198c6d56f2d69063a69 Comments
Set always-on-top widgets non-activatable in Mash Since AshFocusRules consider such windows non-activatable, this should be aligned in the window service client. Otherwise client-side focus -> window-service attempts to focus -> fail -> window blurred happen. Bug: 923049 Test: views_unittests Change-Id: I7d0409b31c9c9188ab4d50f16451f4136bd41e76 Reviewed-on: https://chromium-review.googlesource.com/c/1419221 Auto-Submit: Jun Mukai <mukai@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#624182}
Changed files
- ui/views/mus/desktop_window_tree_host_mus_unittest.cc
- ui/views/widget/desktop_aura/desktop_focus_rules.cc
-
[BrowserSwitcher] Use BrowserSwitcherPrefs instead of raw pref access
Changed by Nicolas Ouellet-payeur - nicolasoohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 17:32:13 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 144374319f0f97fcdd40e9163c3333b9b39a52db Comments
[BrowserSwitcher] Use BrowserSwitcherPrefs instead of raw pref access This updates code across c/b/browser_switcher/ to use the new BrowserSwitcherPrefs class to access prefs, instead of using PrefChangeRegistrar and transforms all over the place. Also deletes AlternativeBrowserLauncher as it's no longer needed. Change-Id: I7045ecac9fe122a1068dfef8dbadf092208999db Reviewed-on: https://chromium-review.googlesource.com/c/1396307 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#624181}
Changed files
- chrome/browser/BUILD.gn
- chrome/browser/browser_switcher/alternative_browser_driver.h
- chrome/browser/browser_switcher/alternative_browser_driver_posix.cc
- chrome/browser/browser_switcher/alternative_browser_driver_unittest.cc
- chrome/browser/browser_switcher/alternative_browser_driver_win.cc
- chrome/browser/browser_switcher/alternative_browser_launcher.cc
- chrome/browser/browser_switcher/alternative_browser_launcher.h
- chrome/browser/browser_switcher/alternative_browser_launcher_unittest.cc
- chrome/browser/browser_switcher/browser_switcher_navigation_throttle.cc
- chrome/browser/browser_switcher/browser_switcher_navigation_throttle_unittest.cc
- chrome/browser/browser_switcher/browser_switcher_prefs.cc
- chrome/browser/browser_switcher/browser_switcher_prefs.h
- chrome/browser/browser_switcher/browser_switcher_prefs_unittest.cc
- chrome/browser/browser_switcher/browser_switcher_service.cc
- chrome/browser/browser_switcher/browser_switcher_service.h
- chrome/browser/browser_switcher/browser_switcher_service_browsertest.cc
- chrome/browser/browser_switcher/browser_switcher_sitelist.cc
- chrome/browser/browser_switcher/browser_switcher_sitelist.h
- chrome/browser/browser_switcher/browser_switcher_sitelist_unittest.cc
- chrome/browser/browser_switcher/mock_alternative_browser_driver.cc
- chrome/browser/browser_switcher/mock_alternative_browser_driver.h
- chrome/test/BUILD.gn
- chrome/test/data/webui/cr_components/cr_components_browsertest.js
-
Rename ButtonMediumStyle to AccentMediumStyle.
Changed by Jordan Demeulenaere - jdemeulenaereohnoyoudont@google.com Changed at Friday, 18-Jan-19 17:29:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4099b5ac14275278c406d49b4ab0e5792205694a Comments
Rename ButtonMediumStyle to AccentMediumStyle. Change-Id: I8a9b22b7bee8aff0d75d050f18e0c0e7ff448ace Reviewed-on: https://chromium-review.googlesource.com/c/1416145 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#624180}
Changed files
- ui/android/java/res/values-v17/styles.xml
-
[iOS][Translate] Support multiline labels in translate infobar popup menus
Changed by Moe Ahmadi - mahmadiohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 17:28:05 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ee232ad7a3ac7fb4081541d904899e23cc31079e Comments
[iOS][Translate] Support multiline labels in translate infobar popup menus - Adds support for multiline labels in the translate infobar popup menus. - Uses a checkmark icon instead of the UITableViewCellAccessoryCheckmark to indicated if a row is selected. Using the cell's accessoryType along with multiline labels has some drabacks including not being able to reserve space for the checkmark accessory as well as the cells being taller than they need to be. Bug: 910994 Change-Id: Iaefa7597011bd50b281a6c0acea17a207134bb4f Reviewed-on: https://chromium-review.googlesource.com/c/1418733 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#624179}
Changed files
- ios/chrome/browser/ui/translate/cells/BUILD.gn
- ios/chrome/browser/ui/translate/cells/resources/checkmark.imageset/Contents.json
- ios/chrome/browser/ui/translate/cells/resources/checkmark.imageset/checkmark.png
- ios/chrome/browser/ui/translate/cells/resources/checkmark.imageset/checkmark@2x.png
- ios/chrome/browser/ui/translate/cells/resources/checkmark.imageset/checkmark@3x.png
- ios/chrome/browser/ui/translate/cells/translate_popup_menu_item.h
- ios/chrome/browser/ui/translate/cells/translate_popup_menu_item.mm
- ios/chrome/browser/ui/translate/translate_popup_menu_mediator.mm
-
media: Add RequestPerDeviceProvisioningPermission()
Changed by Xiaohan Wang - xhwangohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 17:27:54 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b125c04fb36ea7d155df73ee423c2a0acc13fe19 Comments
media: Add RequestPerDeviceProvisioningPermission() This allows to request permission for MediaDrmBridge to use per-device provisioning on devices where per-origin provisioning is supported. See the notes in the new file for more details. Currently this function is not called anywhere, and will be incorporated in a later CL. Bug: 917527 Test: Manually tested. Change-Id: Ie0fbd184c6e92799a9fda05bd423e6f03019b877 Reviewed-on: https://chromium-review.googlesource.com/c/1406131 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#624178}
Changed files
- chrome/browser/BUILD.gn
- chrome/browser/media/android/cdm/per_device_provisioning_permission.cc
- chrome/browser/media/android/cdm/per_device_provisioning_permission.h
-
[SendTabToSelf] Add a keyed service to SendTabToSelf
Changed by Jeffrey Cohen - jeffreycohenohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 17:25:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a89b1158d5ea6ea7c7183ca64dba58b973ba45dd Comments
[SendTabToSelf] Add a keyed service to SendTabToSelf SendTabToSelf Service provides an API for interfacing with the SendTabToSelfModel Bug: 910390 Change-Id: Idef5bfa907b5252ca8d6bede2f903eb6aa736f76 Reviewed-on: https://chromium-review.googlesource.com/c/1415762 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#624177}
Changed files
- components/send_tab_to_self/BUILD.gn
- components/send_tab_to_self/DEPS
- components/send_tab_to_self/send_tab_to_self_service.cc
- components/send_tab_to_self/send_tab_to_self_service.h
-
Consider capture target when sending click events
Changed by Navid Zolghadr - nzolghadrohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 17:24:29 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b84997347f793ee460182e1d89907c812a956f53 Comments
Consider capture target when sending click events Captured targets should be used when calculating the click target. Bug: 689158 Change-Id: I733d0bfc8db6064cab4c1dd22e6a1b3b4ebb1598 Reviewed-on: https://chromium-review.googlesource.com/c/1407506 Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Ella Ge <eirage@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#624176}
Changed files
- third_party/blink/renderer/core/input/event_handler.cc
- third_party/blink/renderer/core/input/event_handler.h
- third_party/blink/renderer/core/input/mouse_event_manager.cc
- third_party/blink/renderer/core/input/mouse_event_manager.h
- third_party/blink/renderer/core/input/pointer_event_manager.cc
- third_party/blink/renderer/core/input/pointer_event_manager.h
- third_party/blink/web_tests/NeverFixTests
- third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_click_during_capture.html
-
Revert "[ios] Call LoadIfNecessary even when displaying the NTP."
Changed by Gabriel Charette - gabohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 17:20:53 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2a974e5ae5d7df2535b2923999f48a075d5394a8 Comments
Revert "[ios] Call LoadIfNecessary even when displaying the NTP." This reverts commit ddf184b056b4c7ddd8e1bd697c17924b6b50ed58. Reason for revert: suspect for crbug.com/916159 (only ios CL in range : https://chromium.googlesource.com/chromium/src/+log/638e15167f366f1808c9122577ab881d18b25331..b485a9cce7a08fad618603f6759cc3167b540b8f?pretty=fuller&n=10000) Original change's description: > [ios] Call LoadIfNecessary even when displaying the NTP. > > WKBasedNavigationManagerImpl::Restore will never actually begin loading > if the current page is an NTP. Call LoadIfNecessary to begin restore > process. > > Change-Id: Iebcfee2680ca665ebdb15883772fc042366eac58 > Reviewed-on: https://chromium-review.googlesource.com/c/1419497 > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Danyao Wang <danyao@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#623950} TBR=justincohen@chromium.org,eugenebut@chromium.org,danyao@chromium.org Bug: 916159 Change-Id: I7fc9766b397c97a774354d9cb28d3b38be4e5594 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1422004 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#624175}
Changed files
- ios/chrome/browser/ui/browser_view_controller.mm
-
Roll src/third_party/catapult 1f939034d069..4ac0b64bb236 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Friday, 18-Jan-19 17:19:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision cb35e4508825f3052b5c70a32f8156792d7184b8 Comments
Roll src/third_party/catapult 1f939034d069..4ac0b64bb236 (1 commits) https://chromium.googlesource.com/catapult.git/+log/1f939034d069..4ac0b64bb236 git log 1f939034d069..4ac0b64bb236 --date=short --no-merges --format='%ad %ae %s' 2019-01-18 perezju@chromium.org [devil] Ensure device_recovery uses correct psutil version Created with: gclient setdep -r src/third_party/catapult@4ac0b64bb236 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:776709 TBR=sullivan@chromium.org Change-Id: I1bd2b95a64b5f4fc35422577cf01437aa74dc60b Reviewed-on: https://chromium-review.googlesource.com/c/1422098 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624174}
Changed files
- DEPS
-
Add API to replace ATS::{SetIsChildAccount,SetIsAdvancedProtectionAccount}
Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com Changed at Friday, 18-Jan-19 17:18:25 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 341c99a2593c16cb9b5c2039ece642b8c5b8f7cc Comments
Add API to replace ATS::{SetIsChildAccount,SetIsAdvancedProtectionAccount} Add AccountsMutator::UpdateAccountInfo() to allow changing |is_child_account| and/or |is_under_advanced_protection| for a given |account_id|, and provide a new unit test to cover this new API. Bug: 922474 Change-Id: I6d549b50b0947964e111f38d0d504936779cbbb2 Reviewed-on: https://chromium-review.googlesource.com/c/1417174 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#624173}
Changed files
- services/identity/public/cpp/accounts_mutator.h
- services/identity/public/cpp/accounts_mutator_impl.cc
- services/identity/public/cpp/accounts_mutator_impl.h
- services/identity/public/cpp/accounts_mutator_unittest.cc
-
Roll src/third_party/skia c7234c9b7767..3a33fa5371e9 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Friday, 18-Jan-19 17:15:29 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8c43b898f3f897f89428d9b8f583df6ecd5d0986 Comments
Roll src/third_party/skia c7234c9b7767..3a33fa5371e9 (1 commits) https://skia.googlesource.com/skia.git/+log/c7234c9b7767..3a33fa5371e9 git log c7234c9b7767..3a33fa5371e9 --date=short --no-merges --format='%ad %ae %s' 2019-01-18 scroggo@google.com Add SK_API to SkHalfToFloat Created with: gclient setdep -r src/third_party/skia@3a33fa5371e9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/120904891,chromium:b/122844033,chromium:b/122514935 TBR=halcanary@chromium.org Change-Id: I4e5bb50c21b8755b169cb77dafc1d8e950793ae1 Reviewed-on: https://chromium-review.googlesource.com/c/1422097 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624172}
Changed files
- DEPS
-
Roll src-internal 917be97785db..89aea79a2037 (4 commits)
Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com Changed at Friday, 18-Jan-19 17:14:10 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 07b680cf7cd1a655a4336fcf8d2b8033da4496e4 Comments
Roll src-internal 917be97785db..89aea79a2037 (4 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/917be97785db..89aea79a2037 Created with: gclient setdep -r src-internal@89aea79a2037 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic27ce8162401e134bd5e0e93c019cb5b822a4a46 Reviewed-on: https://chromium-review.googlesource.com/c/1421738 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624171}
Changed files
- DEPS
-
Set document visibilityState to hidden when window is occluded.
Changed by François Beaufort - beaufort.francoisohnoyoudont@gmail.com Changed at Friday, 18-Jan-19 17:12:49 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision fec686f56d6b09962077a476342fe2af6e94387e Comments
Set document visibilityState to hidden when window is occluded. This CL allows web pages to know when window is occluded via the Page Visibility API. https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/C8QaK-TSrOY Bug: 917303 Change-Id: I44b1a8a2714de38da2e4ecb6b88ca84081b9ecb6 Reviewed-on: https://chromium-review.googlesource.com/c/1408977 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#624170}
Changed files
- chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
- content/browser/web_contents/web_contents_impl.cc
-
Return more than a single language with ULP language code locator.
Changed by Alexandre Frechette - frechetteohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 17:09:09 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e6b6b4d6a3693171a005916d33aa3368cc1114b4 Comments
Return more than a single language with ULP language code locator. - Modifies UlpLanguageCodeLocator and its helper functions to support more than a single quadtree. - Adds second and third most spoken languages data, and modifies BUILD process to embed them into the helper functions. - Augments the test for this extended functionality. Bug: 850947 Change-Id: Ie2c44bbb562d8905454fb2dcf594d7eb4df9a3b4 Reviewed-on: https://chromium-review.googlesource.com/c/1409606 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#624169}
Changed files
- components/language/content/browser/geo_language_provider.cc
- components/language/content/browser/geo_language_provider_unittest.cc
- components/language/content/browser/language_code_locator.h
- components/language/content/browser/language_code_locator_provider.cc
- components/language/content/browser/regional_language_code_locator/regional_language_code_locator.cc
- components/language/content/browser/regional_language_code_locator/regional_language_code_locator.h
- components/language/content/browser/regional_language_code_locator/regional_language_code_locator_unittest.cc
- components/language/content/browser/ulp_language_code_locator/BUILD.gn
- components/language/content/browser/ulp_language_code_locator/geolanguage-data_rank1.txt
- components/language/content/browser/ulp_language_code_locator/geolanguage-data_rank2.txt
- components/language/content/browser/ulp_language_code_locator/s2langquadtree.h
- components/language/content/browser/ulp_language_code_locator/s2langquadtree_datatest.cc
- components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator.cc
- components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator.h
- components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator_helper.h.tmpl
- components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator_unittest.cc
- components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py
-
Improve color contrast on Family Link blocked websites page (ChromeOS)
Changed by Felipe Cerqueira - cerqueiraohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 17:05:40 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1d44e84df29a3403357901d98e3ef7e9d4d732e2 Comments
Improve color contrast on Family Link blocked websites page (ChromeOS) Parent names/emails and navigation links were hard to visualize. Original problem: https://screenshot.googleplex.com/kZtNhpmjR01 https://screenshot.googleplex.com/SriwFdQ3T1t Suggestion from the designer (@johnpcassidy): https://screenshot.googleplex.com/y45WkVn0Soc After the change: https://screenshot.googleplex.com/yJoLNh5Mgq8 https://screenshot.googleplex.com/sxHTcQEf5Vz Bug: 923026,b/72032640 Change-Id: Ic6601212bdabe71dd90051ed908e91b9426605ec Reviewed-on: https://chromium-review.googlesource.com/c/1418270 Commit-Queue: Felipe Cerqueira <cerqueira@google.com> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#624168}
Changed files
- components/supervised_user_error_page/resources/supervised_user_block_interstitial.css
-
Fix chromium domain errors in histograms.xml.
Changed by Brian White - bcwhiteohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 17:00:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d92bd4c5a95473bff8bffd6086d7f557b9f77e77 Comments
Fix chromium domain errors in histograms.xml. Bug: 923083 Change-Id: I9d184fea57a1f365f4f865262844b58c845f993c Reviewed-on: https://chromium-review.googlesource.com/c/1421498 Commit-Queue: Brian White <bcwhite@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#624167}
Changed files
- tools/metrics/histograms/histograms.xml
-
UMA: Add metrics for policy related OAuth token fetch for child user
Changed by Aga Wronska - agawronskaohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 16:59:13 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 611a777e054e27eedabc031b15ea39c01b347beb Comments
UMA: Add metrics for policy related OAuth token fetch for child user Bug: 839025 Test: UserCloudPolicyTokenForwarderTest Change-Id: I44c4973d09e52f75f57bd3fe35c693a083dcb649 Reviewed-on: https://chromium-review.googlesource.com/c/1399516 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#624166}
Changed files
- chrome/browser/chromeos/policy/user_cloud_policy_token_forwarder.cc
- chrome/browser/chromeos/policy/user_cloud_policy_token_forwarder.h
- chrome/browser/chromeos/policy/user_cloud_policy_token_forwarder_unittest.cc
- tools/metrics/histograms/histograms.xml
-
android: Prevent AR and VR modules from using too many strings.
Changed by David 'Digit' Turner - digitohnoyoudont@google.com Changed at Friday, 18-Jan-19 16:53:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 59c90558b3ce3cb025324dd1f30ffe00ce4fb9cb Comments
android: Prevent AR and VR modules from using too many strings. As discovered recently, when building the Monochrome bundle, the AR and VR feature modules embed all localized strings from their source packages, which is much more than needed. This CL fixes the issue by setting aapt_locale_whitelist on each module definition. This is a quick fix, though we may consider in the future supporting setting this variable on the top-level bundle target instead. + Small change to compile_resources.py to fix a runtime crash due to a variable not properly assigned before being referenced (this happens when using a locale whitelist without a resource blacklist regex). BUG=923017 R=agrieve@chromium.org,tiborg@chromium.org,benmason@chromium.org Change-Id: I59e0c305a94521d8c873ffa682613504710c427b Reviewed-on: https://chromium-review.googlesource.com/c/1420798 Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#624165}
Changed files
- build/android/gyp/compile_resources.py
- chrome/android/modules/ar/ar_module_tmpl.gni
- chrome/android/modules/vr/vr_module_tmpl.gni
-
[ FeaturePolicy ] Potential violation for "layout-animation"
Changed by Ehsan Karamad - ekaramadohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 16:52:55 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ad1066ce0df586d19daf9e43942db479a71a687c Comments
[ FeaturePolicy ] Potential violation for "layout-animation" This CL adds the logic to track potential violations for the "layout-animations" feature (Blink.UseCounter.FeaturePolicy.PotentialViolation). This CL counts all potential violations through CSS keyframes or use of element.animate() API. Similar to the real reporting for this policy, "transitions" are currently excluded (will be added in future CLs). Bug: 915788 Change-Id: I94e3356469ba4e65569c39f7a40592663ad8b0ae Reviewed-on: https://chromium-review.googlesource.com/c/1389024 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#624164}
Changed files
- third_party/blink/renderer/core/animation/element_animation.cc
- third_party/blink/renderer/core/css/parser/css_parser_context.cc
- third_party/blink/renderer/core/css/parser/css_parser_context.h
- third_party/blink/renderer/core/css/parser/css_parser_impl.cc
- third_party/blink/renderer/core/exported/web_view_test.cc
- third_party/blink/renderer/core/feature_policy/layout_animations_policy.cc
- third_party/blink/renderer/core/feature_policy/layout_animations_policy.h
-
Optimize InvalidationSet HashSet backings.
Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 16:48:56 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c7ca2242e68cc28f64b32d417046cf0cb146d0ef Comments
Optimize InvalidationSet HashSet backings. InvalidationSet creates HashSet instances for classes, ids, tag names and attributes. However, since it's common for these hash sets to have only one item, most of the capacity in the HashSets are just wasted. (At the time of writing, a HashSet with only one item has a backing array of 8 items). Instead of using HashSets with size=1, we can represent this case as a StringImpl* directly, and then "upgrade" to a real HashSet if two or more items are needed: union Backing { StringImpl* string_impl; HashSet<AtomicString>* hash_set; }; Using this approach, we save around 350kB of memory on facebook.com, which is ~30% of the memory used by InvalidationSet instances (and their HashSet backings). Change-Id: I39cd69d19c67cdd7924f42d1d6fa36d36d361fd8 Reviewed-on: https://chromium-review.googlesource.com/c/1413598 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#624163}
Changed files
- third_party/blink/renderer/core/css/invalidation/invalidation_set.cc
- third_party/blink/renderer/core/css/invalidation/invalidation_set.h
- third_party/blink/renderer/core/css/invalidation/invalidation_set_test.cc
- third_party/blink/renderer/core/css/rule_feature_set_test.cc
-
Vulkan: Enable luminance/alpha WebGL tests
Changed by Shahbaz Youssefi - syoussefiohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 16:46:50 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 71db8459123c7592ce0e4a1836b358c53edc1359 Comments
Vulkan: Enable luminance/alpha WebGL tests TBR=zmo@chromium.org Bug: angleproject:2913 Change-Id: I717a1a755839550ba5873ee81a54c8eb04e3b128 Reviewed-on: https://chromium-review.googlesource.com/c/1344249 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#624162}
Changed files
- content/test/gpu/gpu_tests/webgl_conformance_expectations.py
-
Update docs for process of upgrading GPU drivers.
Changed by Kenneth Russell - kbrohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 16:44:51 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision bdf880cb0da9330d92d7ff21171ffbf1af63605d Comments
Update docs for process of upgrading GPU drivers. Use the new optional Swarming dimensions instead of the multi-dimension trigger script, which has certain pitfalls. Bug: 920665 Tbr: jmadill@chromium.org Tbr: bradhall@chromium.org No-Try: True Change-Id: I076145a456d88fc9f2df0b64bd074857efda57e9 Reviewed-on: https://chromium-review.googlesource.com/c/1421741 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#624161}
Changed files
- docs/gpu/gpu_testing_bot_details.md
-
Update AccountsInCookieJarInfo to use ListedAccount.
Changed by Lowell Manners - lowellohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 16:41:13 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b758f6fbeaae44da900169114087b0562da3f902 Comments
Update AccountsInCookieJarInfo to use ListedAccount. This CL updates AccountsInCookieJarInfo to return lists of ListedAccount, rather than lists of AccountInfo. Before this CL, IdentityManager would convert ListedAccount objects from the gaia cookie, into AccountInfo objects. This wasn't ideal, as AccountInfo and ListedAccount represent different logical concepts, and have non-overlapping fields. Change-Id: I2182ad66aba7952a4145ea8ea3d382f275d61f86 Bug: 923322 Reviewed-on: https://chromium-review.googlesource.com/c/1421178 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#624160}
Changed files
- chrome/browser/signin/signin_ui_util.cc
- components/signin/core/browser/account_investigator.cc
- components/signin/core/browser/account_investigator.h
- components/signin/core/browser/account_investigator_unittest.cc
- components/sync/driver/sync_auth_util.cc
- services/identity/public/cpp/accounts_in_cookie_jar_info.cc
- services/identity/public/cpp/accounts_in_cookie_jar_info.h
- services/identity/public/cpp/identity_manager.cc
- services/identity/public/cpp/identity_manager_unittest.cc
-
[s13n] Convert AccountReconcilor away from PO2TS
Changed by Antonio Gomes - tonikitooohnoyoudont@igalia.com Changed at Friday, 18-Jan-19 16:40:43 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6e62190579ce1577d9fae75760117fc32563f9c9 Comments
[s13n] Convert AccountReconcilor away from PO2TS This is the second part of Bug 903907, where AccountReconcilor is being migrated away from both SigninManager and PO2TS APIs, in favor of IdentityManager. The former was handled by [1]. [1] https://crrev.com/c/1330223 This CL migrates AccountReconcilor away from PO2TS. No functionality change is expected. BUG=903907 Change-Id: If75dadf19069fba1033d56270ae9e3ea6092da06 Reviewed-on: https://chromium-review.googlesource.com/c/1416170 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#624159}
Changed files
- chrome/browser/signin/account_reconcilor_factory.cc
- chrome/browser/signin/dice_response_handler_unittest.cc
- components/signin/core/browser/account_reconcilor.cc
- components/signin/core/browser/account_reconcilor.h
- components/signin/core/browser/account_reconcilor_unittest.cc
- components/signin/ios/browser/account_consistency_service_unittest.mm
- ios/chrome/browser/signin/account_reconcilor_factory.cc
-
Optimize Account Manager welcome page resources
Changed by Kush Sinha - sinhakohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 16:39:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 48b4d2f338617fc4cd691cd57721dd4022bf518f Comments
Optimize Account Manager welcome page resources Bug: 919251 Change-Id: Id1f9df13c5c295c018c4d275c4a47f5ae6644f4f Reviewed-on: https://chromium-review.googlesource.com/c/1421757 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#624158}
Changed files
- chrome/browser/browser_resources.grd
- chrome/browser/ui/webui/chromeos/account_manager_welcome_ui.cc
-
[NTP] Allow blacklisting and opt-out of suggestions
Changed by Kyle Milka - kmilkaohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 16:39:22 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 779c9ce30f7ff154666d1c1612cace6b854af3b9 Comments
[NTP] Allow blacklisting and opt-out of suggestions Provide several new embeddedSearch APIs for blacklisting NTP search suggestions and opting out: window.chrome.embeddedSearch.newTabPage.blacklistSearchSuggestion(task_version, task_id) window.chrome.embeddedSearch.newTabPage.blacklistSearchSuggestionWithHash(task_version, task_id, hash) window.chrome.embeddedSearch.newTabPage.optOutOfSearchSuggestions() Store blacklist and opt-out in user prefs. Append blacklist to requests for suggestions as the url param 'vtgb'. Bug: 904565 Change-Id: I308a57af9e61808d78bfaf606bdfe03bdd7a7acb Reviewed-on: https://chromium-review.googlesource.com/c/1384526 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#624157}
Changed files
- chrome/browser/prefs/browser_prefs.cc
- chrome/browser/search/search_suggest/search_suggest_loader.h
- chrome/browser/search/search_suggest/search_suggest_loader_impl.cc
- chrome/browser/search/search_suggest/search_suggest_loader_impl.h
- chrome/browser/search/search_suggest/search_suggest_loader_impl_unittest.cc
- chrome/browser/search/search_suggest/search_suggest_service.cc
- chrome/browser/search/search_suggest/search_suggest_service.h
- chrome/browser/search/search_suggest/search_suggest_service_factory.cc
- chrome/browser/search/search_suggest/search_suggest_service_unittest.cc
- chrome/browser/ui/search/search_ipc_router.cc
- chrome/browser/ui/search/search_ipc_router.h
- chrome/browser/ui/search/search_ipc_router_policy_impl.cc
- chrome/browser/ui/search/search_ipc_router_policy_impl.h
- chrome/browser/ui/search/search_ipc_router_unittest.cc
- chrome/browser/ui/search/search_tab_helper.cc
- chrome/browser/ui/search/search_tab_helper.h
- chrome/common/pref_names.cc
- chrome/common/pref_names.h
- chrome/common/search.mojom
- chrome/renderer/searchbox/searchbox.cc
- chrome/renderer/searchbox/searchbox.h
- chrome/renderer/searchbox/searchbox_extension.cc
-
Update V8 to version 7.3.443.
Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com Changed at Friday, 18-Jan-19 16:38:02 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 827be29261415525cf71ad75c086697e1aedcc24 Comments
Update V8 to version 7.3.443. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1912df56..7d071b56 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9443348a875bbebf4625429ff8e18c615bfd9b7d Reviewed-on: https://chromium-review.googlesource.com/c/1421959 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624156}
Changed files
- DEPS
-
AW: whitelist broken WebViewSslTest test case
Changed by Nate Fischer - ntfschrohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 16:34:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ddda0c9fede24c395278c17de280b09ec9adb33e Comments
AW: whitelist broken WebViewSslTest test case No change to production logic, this edits our bot config to ignore failures for WebViewSslTest#testSecureServerRequiringClientCertDoesCancelRequest. This test currently fails due to 94c9a948334f6d5d910932ba74ce1316c199de04. That change fixed a long-standing issue in our SSL logic (embedders should not send authentication credentials without first trusting server certificates). Bug: 922400 Test: android_webview/tools/run_cts.py --skip-expected-failures Change-Id: If17d8e5f0fc6a13844a89826660bab375373ee04 Reviewed-on: https://chromium-review.googlesource.com/c/1419900 Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#624155}
Changed files
- android_webview/tools/cts_config/webview_cts_gcs_path.json
-
[AF] Add new strings for the split payments settings page.
Changed by sebsg - sebsgohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 16:31:29 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a0d40506dc658a111ff79e50a1b2e3f7d9e3ce4c Comments
[AF] Add new strings for the split payments settings page. Adds the title of the two sections: On this device In your Google Account Bug: 917396 Change-Id: I1d92f40264b1688e32a3a0cbcd81eb29af0b2a1e Reviewed-on: https://chromium-review.googlesource.com/c/1418075 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Auto-Submit: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#624154}
Changed files
- components/autofill_strings.grdp
-
Clarify RTCTrackEvent-constructor.html failure reason.
Changed by Henrik Boström - hbosohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 16:27:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1a345304d40380b5fcafe47f4ea5986158e3d046 Comments
Clarify RTCTrackEvent-constructor.html failure reason. This code attempts to update the RTCTrackEvent to pass streams by reference rather than value, but our bindings seems to copy them anyway. Bug: 923349 Change-Id: Iacad1514af3b5a121a927c29bb1ada4ef8e21593 Reviewed-on: https://chromium-review.googlesource.com/c/1421898 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#624153}
Changed files
- third_party/blink/renderer/modules/peerconnection/rtc_track_event.cc
- third_party/blink/renderer/modules/peerconnection/rtc_track_event.h
- third_party/blink/web_tests/external/wpt/webrtc/RTCTrackEvent-constructor-expected.txt
- third_party/blink/web_tests/external/wpt/webrtc/RTCTrackEvent-constructor.html
-
Clean up deps in //chrome/browser/chromeos/BUILD.gn
Changed by James Cook - jamescookohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 16:24:55 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 742cdf50e1f80e3bfdcc38d76944fd2d573d56f0 Comments
Clean up deps in //chrome/browser/chromeos/BUILD.gn Sort them and remove entries that aren't used any more. Bug: none Change-Id: Idbf356f4e9422b706d07e733c14173f91d5e1c94 Reviewed-on: https://chromium-review.googlesource.com/c/1419320 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#624152}
Changed files
- chrome/browser/chromeos/BUILD.gn
-
Add histogram for action on first omnibox suggestion
Changed by Matthew Jones - mdjonesohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 16:23:36 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d23145226322b5e580477ae63c173d2beeae587b Comments
Add histogram for action on first omnibox suggestion The added histogram is for the search-ready omnibox and includes: edit, copy, share, suggestion tap, and suggestion long-press. Bug: 881292,901952 Change-Id: Ia12d3cb11c048215bad43c8752aa3afae5b5b15a Reviewed-on: https://chromium-review.googlesource.com/c/1372560 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#624151}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/editurl/EditUrlSuggestionProcessor.java
- tools/metrics/histograms/enums.xml
- tools/metrics/histograms/histograms.xml
-
[Mojo WebUI] Make WebUITestHandler an abstract base class.
Changed by Christopher Lam - calamityohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 16:20:08 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4591322156c3b2af31c04aafbdf794f558be9fa3 Comments
[Mojo WebUI] Make WebUITestHandler an abstract base class. This CL factors out a common WebUITestHandler which is used by a Mojo-specific and a WebUIMessageHandler-specific subclass for their respective testing frameworks. This cleans up the WebUITestHandler which previously subclassed both WebUIMessageHandler and the Mojo interface, and only used half the method implementations at a time. BaseWebUIBrowserTest - Common test base class - WebUIBrowserTest - chrome.send, vanilla WebUIBrowserTest - uses WebUITestMessageHandler for chrome.send communication - MojoWebUIBrowserTest - Mojo-enabled BrowserTest - uses WebUITestPageHandler for Mojo-based communication Both WebUITestMessageHandler and WebUITestPageHandler use the WebUITestHandler to report success/failure. Bug: 849993 Change-Id: I1284f293a63c9b0ae63d47371523f4e3696ae5a3 Reviewed-on: https://chromium-review.googlesource.com/c/1297776 Reviewed-by: Dan Beam <dbeam@chromium.org> Reviewed-by: Alan Cutter <alancutter@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#624150}
Changed files
- chrome/browser/ui/webui/web_ui_test_handler.cc
- chrome/browser/ui/webui/web_ui_test_handler.h
- chrome/test/base/mojo_web_ui_browser_test.cc
- chrome/test/base/mojo_web_ui_browser_test.h
- chrome/test/base/web_ui_browser_test.cc
- chrome/test/base/web_ui_browser_test.h
- chrome/test/base/web_ui_browser_test_browsertest.cc
-
[LayoutNG] Use ForceChildLayout() instead of ForceLayout()
Changed by Ian Kilpatrick - ikilpatrickohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 16:15:56 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0c1ff5206e3dbae5910e12118466ef47c95af0df Comments
[LayoutNG] Use ForceChildLayout() instead of ForceLayout() ForceLayout was causing additional paint invalidations due to: SetShouldDoFullPaintInvalidation(); ...inside it. Instead this now uses LayoutIfNeeded if the item needs layout (probably from a style change/node removal/etc), and ForceChildLayout() which doesn't perform this invalidation. Fixes a bunch of paint invalidation tests. Bug: 635619 Change-Id: I70301097ffd2fa2512f13ad8e090fa5d61a3a300 Reviewed-on: https://chromium-review.googlesource.com/c/1419342 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#624149}
Changed files
- third_party/blink/renderer/core/layout/ng/ng_block_node.cc
- third_party/blink/web_tests/FlagExpectations/enable-blink-features=LayoutNG
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/clip/control-clip-expected.txt
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/css-grid-layout/grid-item-change-column-repaint-expected.txt
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/css-grid-layout/grid-item-z-index-change-repaint-expected.txt
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/flexbox/align-content-change-expected.txt
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/flexbox/align-content-distribution-change-grid-expected.txt
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/flexbox/align-items-change-expected.txt
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/flexbox/align-self-change-expected.txt
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/flexbox/align-self-change-grid-expected.txt
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/flexbox/justify-content-change-expected.txt
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/flexbox/justify-content-distribution-change-grid-expected.txt
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/flexbox/justify-items-change-expected.txt
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/flexbox/justify-self-change-expected.txt
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/flexbox/repaint-during-resize-no-flex-expected.txt
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/multicol/multicol-repaint-expected.txt
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/overflow/align-items-overflow-change-expected.txt
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/overflow/align-self-overflow-change-expected.txt
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/overflow/justify-items-overflow-change-expected.txt
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/overflow/justify-self-overflow-change-expected.txt
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/position/align-content-position-change-grid-expected.txt
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/position/justify-content-position-change-expected.txt
- third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/position/justify-content-position-change-grid-expected.txt
-
Update Win7 NVIDIA bot driver dimensions.
Changed by Jamie Madill - jmadillohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 16:14:31 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 427999cfc3d0da1500edf93898f497ad0e8a91bb Comments
Update Win7 NVIDIA bot driver dimensions. This removes the alternate dimensions now that the driver upgrade is complete. It also fixes the dimensions. The should have used the number 24.21.14.1195 instead of 23.21.14.1195. Bug: 923323 Bug: 887241 Change-Id: I946ee2a2e04b35f9437849162005859dd1eb6fb6 Tbr: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1421877 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#624148}
Changed files
- testing/buildbot/chromium.gpu.fyi.json
- testing/buildbot/mixins.pyl
- testing/buildbot/waterfalls.pyl
-
Fix some nits in component_updater::MetadataTable.
Changed by Lei Zhang - thestigohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 16:12:38 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3b831895d4d73380df841b1f6853d8c5048ed934 Comments
Fix some nits in component_updater::MetadataTable. - Remove Create(), just call the ctor directly. - Avoid deprecated base::Value APIs. - Refactor common code into GetRequiredStringFromDict(). Change-Id: I591003877ad5fce6ffe3f9e0ac3004192e415114 Reviewed-on: https://chromium-review.googlesource.com/c/1420198 Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#624147}
Changed files
- chrome/browser/browser_process_platform_part_chromeos.cc
- chrome/browser/component_updater/metadata_table_chromeos.cc
- chrome/browser/component_updater/metadata_table_chromeos.h
-
Change content::TextInputState::value to base::string16.
Changed by Yuichiro Hanada - yhanadaohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 16:12:26 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1b19cf85d31ab9d7a6b9b035f478a39b74874789 Comments
Change content::TextInputState::value to base::string16. content::TextInputState is a struct used in IPCs between renderer and browser to sync a state of a text input field. The "value" field in the struct is in UTF-8 string, but both end of IPCs use UTF-16 string. Changing the field to base::string16 removes unnecessary conversions. Bug: 923267 Change-Id: Icaf868dfc3014b32e4fe01f12816bdc680314ac0 Reviewed-on: https://chromium-review.googlesource.com/c/1420487 Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#624146}
Changed files
- content/browser/android/ime_adapter_android.cc
- content/common/text_input_state.h
- content/public/test/text_input_test_utils.cc
- content/renderer/render_widget.cc
-
Move WebScopedVirtualTimePauser creation to FrameFetchContext
Changed by Yutaka Hirano - yhiranoohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 16:07:51 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ae427c902dfc8dc3cf6318f3d2d0b9249cec1b62 Comments
Move WebScopedVirtualTimePauser creation to FrameFetchContext In order to remove FetchContext::FrameSchduler, this CL moves WebScopedVirtualTimePauser creation code from ResourceFetcher::StartLoad to FrameFetchContext::PrepareRequest. WorkerFetchContext is not affected because WorkerFetchContext::GetFrameScheduler always returns null. Bug: 914739 Change-Id: I9fbdf9809272ab0c0497b816cd8fe3ff029a45ae Reviewed-on: https://chromium-review.googlesource.com/c/1415237 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#624145}
Changed files
- third_party/blink/renderer/core/loader/frame_fetch_context.cc
- third_party/blink/renderer/core/loader/frame_fetch_context.h
- third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
- third_party/blink/renderer/core/loader/worker_fetch_context.cc
- third_party/blink/renderer/core/loader/worker_fetch_context.h
- third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
- third_party/blink/renderer/platform/loader/fetch/fetch_context.h
- third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
- third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
- third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
-
Simplifying GeneratedCodeCache::WriteData
Changed by Steven Bingler - binglerohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 16:05:49 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b683f3ad115a46fb221ecb8e6981aa0f338ea68f Comments
Simplifying GeneratedCodeCache::WriteData Using new OpenOrCreateEntry function to simplify logic Change-Id: I5a8c09ba5e09f0b13e4a744c9aa16b62811a4c47 Reviewed-on: https://chromium-review.googlesource.com/c/1419501 Reviewed-by: Mythri Alle <mythria@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#624144}
Changed files
- content/browser/code_cache/generated_code_cache.cc
- content/browser/code_cache/generated_code_cache.h
-
[Cronet] Add const qualifier to generated struct accessor functions.
Changed by Misha Efimov - mefohnoyoudont@google.com Changed at Friday, 18-Jan-19 16:03:36 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5ccedfdfefc2a9feb851963c0bee0410ece14abe Comments
[Cronet] Add const qualifier to generated struct accessor functions. This will allow API callers to avoid the need to needlessly cast away const when calling these methods. Bug: 786559 Change-Id: Iea6ada8cabc14823ba0a766bbb5e624a91a59886 Reviewed-on: https://chromium-review.googlesource.com/c/1409904 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#624143}
Changed files
- components/cronet/native/generated/cronet.idl_c.h
- components/cronet/native/generated/cronet.idl_impl_struct.cc
- components/cronet/tools/generators/c_templates/module_c.h.tmpl
- components/cronet/tools/generators/c_templates/module_impl_struct.cc.tmpl
-
Fix some typos in histogram owner names.
Changed by Brian White - bcwhiteohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 15:59:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 56be057d7cca68597d2aa0e1d2125acac91d59df Comments
Fix some typos in histogram owner names. Bug: 923083 Change-Id: Iadb95c7d7dbefb820b01133633d23d3d29965f74 Reviewed-on: https://chromium-review.googlesource.com/c/1418520 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#624142}
Changed files
- tools/metrics/histograms/histograms.xml
-
Fix build of 'wayland_rects_client'.
Changed by Yuichiro Hanada - yhanadaohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 15:58:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d617e6baa851f1b2b57cf3795a979173901eb2b4 Comments
Fix build of 'wayland_rects_client'. Bug: None Change-Id: I656373dd1719f8e0822b60be7d96626e2c93b1d4 Reviewed-on: https://chromium-review.googlesource.com/c/1420491 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#624141}
Changed files
- components/exo/wayland/clients/rects.cc
-
[iOS] Add test for PopupMenuMediator
Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 15:56:43 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 88410c4f9836ef567f34652a448342dff6e404b4 Comments
[iOS] Add test for PopupMenuMediator This CL adds a test to check the enabled state of the SiteInfo item on the NTP. Bug: 919148 Change-Id: I54ee8131dbe3cea907563a44f5f27c60a1bd537c Reviewed-on: https://chromium-review.googlesource.com/c/1397638 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#624140}
Changed files
- ios/chrome/browser/ui/popup_menu/BUILD.gn
- ios/chrome/browser/ui/popup_menu/popup_menu_mediator_unittest.mm
-
Redisable two flaky property manager tests.
Changed by John Budorick - jbudorickohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 15:52:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ed3be06a61312796ddc8207cf0e383f92bf34825 Comments
Redisable two flaky property manager tests. These were reenabled in crrev.com/c/1410504 with a speculative fix. Unfortunately, that fix does not appear to have resolved these tests' flakiness. Tbr: pkasting@chromium.org,bsep@chromium.org Bug: 396344 Change-Id: Ib1a46ff1f86d828ac38116d03fb544d9fcf4fce0 Reviewed-on: https://chromium-review.googlesource.com/c/1421918 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#624139}
Changed files
- chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc
-
[s13n] Convert DiceResponseHandler away from PO2TS
Changed by Antonio Gomes - tonikitooohnoyoudont@igalia.com Changed at Friday, 18-Jan-19 15:50:32 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3eb99abcaae8dd125fe03fe16b19b3a5fc03abcc Comments
[s13n] Convert DiceResponseHandler away from PO2TS This is the 2nd out of two CLs that convert DiceResponseHandler away from SigninManager and PO2TS APIs, in favor of IdentityManager's. Particularly, this tackles the later (former was handled here [1]). [1] https://crrev.com/c/1318550 BUG=902296 Change-Id: I64ec0eee99a30d419dd46dabbd3c0396e478ce95 Reviewed-on: https://chromium-review.googlesource.com/c/1412118 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#624138}
Changed files
- chrome/browser/signin/dice_response_handler.cc
- chrome/browser/signin/dice_response_handler.h
- chrome/browser/signin/dice_response_handler_unittest.cc
-
Roll src-internal 5c1fe186ca81..917be97785db (1 commits)
Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com Changed at Friday, 18-Jan-19 15:40:11 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8474d4f9238b5efb17bd35e2b67995dc25bf8bdf Comments
Roll src-internal 5c1fe186ca81..917be97785db (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5c1fe186ca81..917be97785db Created with: gclient setdep -r src-internal@917be97785db The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibf5848c61dcbe3f88add02f589edcbc4e5f11da6 Reviewed-on: https://chromium-review.googlesource.com/c/1421737 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624137}
Changed files
- DEPS
-
Remove chromium's heap scattered stream delegate in favour of replacing it with perfettos version.
Changed by Stephen Nusko - nuskosohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 15:39:38 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8b115543e44ac6d2b2d215c224d2bb40c8fec68a Comments
Remove chromium's heap scattered stream delegate in favour of replacing it with perfettos version. This is a simple name switch and a couple function name changes. Change-Id: Ia5854a07c20e2d2a9e8590000939d75c8dbfd1ef Reviewed-on: https://chromium-review.googlesource.com/c/1417832 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#624136}
Changed files
- services/tracing/public/cpp/BUILD.gn
- services/tracing/public/cpp/perfetto/heap_scattered_stream_delegate.cc
- services/tracing/public/cpp/perfetto/heap_scattered_stream_delegate.h
- services/tracing/public/cpp/perfetto/traced_value_proto_writer.cc
- services/tracing/public/cpp/perfetto/traced_value_proto_writer_unittest.cc
-
Android: Always compile with errorprone (even for debug)
Changed by Andrew Grieve - agrieveohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 15:38:40 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision eb8cc32f17b408726cee347ff838d13f805bbff7 Comments
Android: Always compile with errorprone (even for debug) Turns out differing system javac versions not only result in binary size variations, but also cause compiles to fail sometimes. Bug: 693079 Change-Id: I76b7d7348dff46be35e6fa996457bb2d9ffc3401 Reviewed-on: https://chromium-review.googlesource.com/c/1420307 Reviewed-by: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#624135}
Changed files
- build/config/android/internal_rules.gni
-
Roll src/third_party/catapult 6ca0a8ed6790..1f939034d069 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Friday, 18-Jan-19 15:34:41 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ac02b504ecad81887c47611f5b62dd2b9a603664 Comments
Roll src/third_party/catapult 6ca0a8ed6790..1f939034d069 (1 commits) https://chromium.googlesource.com/catapult.git/+log/6ca0a8ed6790..1f939034d069 git log 6ca0a8ed6790..1f939034d069 --date=short --no-merges --format='%ad %ae %s' 2019-01-18 perezju@chromium.org [Telemetry] Remove unused methods from telemetry.values Created with: gclient setdep -r src/third_party/catapult@1f939034d069 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:921616 TBR=sullivan@chromium.org Change-Id: I5fd61f4fadcb762d1c1b5c6d8231f47a18249207 Reviewed-on: https://chromium-review.googlesource.com/c/1421263 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624134}
Changed files
- DEPS
-
Auto Picture-in-Picture should apply only to playing video
Changed by François Beaufort - beaufort.francoisohnoyoudont@gmail.com Changed at Friday, 18-Jan-19 15:29:03 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0e6e4575bef92f075c44933afd78117487ef0f46 Comments
Auto Picture-in-Picture should apply only to playing video This CL makes sure entering Auto Picture-in-Picture is only for video that are actually playing (not paused). Bug: 922885 Change-Id: I664378b59a39d9e890ab15a3f63922427ede6bca Reviewed-on: https://chromium-review.googlesource.com/c/1421100 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#624133}
Changed files
- chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
- chrome/test/data/extensions/auto_picture_in_picture/main.html
- third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
-
[base/task] Clarify SingleThreadTaskRunnerThreadMode::DEDICATED docs
Changed by Gabriel Charette - gabohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 15:28:41 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 78a888d89da5c4c3e46cb159aa4b59b51434c91c Comments
[base/task] Clarify SingleThreadTaskRunnerThreadMode::DEDICATED docs Following online discussion @ https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/19988806-14ad-4295-a09c-d3041109f836%40chromium.org?utm_medium=email&utm_source=footer R=fdoray@chromium.org Change-Id: I8fdc0e7c3d566b05033a8bf64e90a4f86eb47e0b Reviewed-on: https://chromium-review.googlesource.com/c/1415307 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#624132}
Changed files
- base/task/single_thread_task_runner_thread_mode.h
-
[build] fix missing outputs file of android lint
Changed by Takuto Ikuta - tikutaohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 15:26:49 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e2b5e4afadc58ee44f1889dc5f41cef70f63bb89 Comments
[build] fix missing outputs file of android lint When we already have result.xml but config.xml is accidentally removed case, lint.py does not generates config.xml. Let me tell lint.py that config.xml is output of execution too. Bug: 923275 Change-Id: I9c556cb235aa1411debf7c9d8cf5ad67d00590a4 Reviewed-on: https://chromium-review.googlesource.com/c/1420638 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#624131}
Changed files
- build/android/gyp/lint.py
-
[Cronet] Fix CronetUrlRequestTest.testManyRequests to run on Jelly Bean
Changed by Paul Jensen - pauljensenohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 15:26:46 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d79719a90b915d7fd60fe334cb34d9149dd8c464 Comments
[Cronet] Fix CronetUrlRequestTest.testManyRequests to run on Jelly Bean Jelly Bean has a 2000 Java global reference limit. Adjust test to create slightly fewer requests so it stays under the limit on Jelly Bean. Bug: 922656 Change-Id: Idf42e04b1e3f9d716d17f3d6293831b650f19da5 Reviewed-on: https://chromium-review.googlesource.com/c/1421777 Auto-Submit: Paul Jensen <pauljensen@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#624130}
Changed files
- components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
-
Download InfoBar : Handling paused and cancelled state correctly
Changed by Shakti Sahu - shaktisahuohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 15:24:23 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 35a381d7f5f22c793e6a095960a3a93b574c97b9 Comments
Download InfoBar : Handling paused and cancelled state correctly Fixed a few bugs : 1 - If an item is cancelled, the infobar should close 2 - If an item moves to paused from pending state, the infobar should close Bug: 915419 Change-Id: Ia3f23e7d213062f7853510cfce2b7cbf7ea43e5e Reviewed-on: https://chromium-review.googlesource.com/c/1418401 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#624129}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfoBarController.java
- chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadInfoBarControllerTest.java
-
Implement an AccoutsMutator API for invalidating refresh token of the primary account
Changed by Antonio Gomes - tonikitooohnoyoudont@igalia.com Changed at Friday, 18-Jan-19 15:22:43 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4eb7ca2abcf8e05a47a67b271f99298169c6e0e7 Comments
Implement an AccoutsMutator API for invalidating refresh token of the primary account This is an action point of the discussion from [1]. Basically, it adds an API to AccountsMutator that invalidates the primary account refresh today. This way, OAuth2TokenServiceDelegate::kInvalidRefreshToken does not get exposed to clients). AccountsMutator was chosen over PrimaryAccountMutator because the later essentially is about setting/clearing the primary account, the use cases of this API fit better to cases related to *mutating* state of the primary account. [1] https://crrev.com/c/1412118/2/chrome/browser/signin/dice_response_handler.cc#340 BUG=922458 Change-Id: Ia8f8d62960528e061c6fd78e0fa089d72d6729a7 Reviewed-on: https://chromium-review.googlesource.com/c/1415070 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#624128}
Changed files
- chrome/browser/signin/identity_manager_factory.cc
- services/identity/public/cpp/accounts_mutator.h
- services/identity/public/cpp/accounts_mutator_impl.cc
- services/identity/public/cpp/accounts_mutator_impl.h
- services/identity/public/cpp/accounts_mutator_unittest.cc
- services/identity/public/cpp/identity_test_environment.cc
-
Add scan locations to chrome_cleaner logs
Changed by Joe Mason - joenotcharlesohnoyoudont@google.com Changed at Friday, 18-Jan-19 15:15:35 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f653f54ee4c25807e545ecedf9788cd4e0f93802 Comments
Add scan locations to chrome_cleaner logs R=csharp Bug: 802092 Change-Id: I928d3daf61ef6b099e5e34e4322b5361184cb712 Reviewed-on: https://chromium-review.googlesource.com/c/1389356 Commit-Queue: Joe Mason <joenotcharles@google.com> Reviewed-by: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#624127}
Changed files
- chrome/chrome_cleaner/logging/BUILD.gn
- chrome/chrome_cleaner/logging/cleaner_logging_service.cc
- chrome/chrome_cleaner/logging/cleaner_logging_service.h
- chrome/chrome_cleaner/logging/logging_service_api.h
- chrome/chrome_cleaner/logging/mock_logging_service.h
- chrome/chrome_cleaner/logging/noop_logging_service.cc
- chrome/chrome_cleaner/logging/noop_logging_service.h
- chrome/chrome_cleaner/logging/proto/reporter_logs.proto
- chrome/chrome_cleaner/logging/reporter_logging_service.cc
- chrome/chrome_cleaner/logging/reporter_logging_service.h
- chrome/chrome_cleaner/logging/reporter_logging_service_unittest.cc
-
TaskScheduler: Add lock annotations to LazyTaskRunner
Changed by Aditya Keerthi - adityakeerthiohnoyoudont@google.com Changed at Friday, 18-Jan-19 15:08:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 964a6ff4d16c5bc60905bd3a49d453dd5bd725cf Comments
TaskScheduler: Add lock annotations to LazyTaskRunner Change-Id: I9906deb12839763628934af6f3d36101cd4bc825 Reviewed-on: https://chromium-review.googlesource.com/c/1416334 Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: Aditya Keerthi <adityakeerthi@google.com> Cr-Commit-Position: refs/heads/master@{#624126}
Changed files
- base/task/lazy_task_runner.h
-
Resume potentially paused video playback if entering Picture-in-Picture
Changed by François Beaufort - beaufort.francoisohnoyoudont@gmail.com Changed at Friday, 18-Jan-19 15:05:17 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3f62f38a104f95d7fbcfdf9c44fc50fc325553eb Comments
Resume potentially paused video playback if entering Picture-in-Picture This CL makes sure a video that was paused because it was no longer visible resumes playback when it enters Picture-in-Picture. Bug: 921577 Change-Id: I16549389dac16f619d8e06c4263d1e00f2af780a Reviewed-on: https://chromium-review.googlesource.com/c/1412455 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#624125}
Changed files
- chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
- chrome/test/data/media/picture-in-picture/window-size.html
- media/blink/webmediaplayer_impl.cc
- third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
-
[omnibox chrome:omnibox] Rename AutocompleteResults to AutocompleteResponse
Changed by manuk - manukhohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 15:04:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 26627dadd2268b06a0867c68bb3d3f32728c9e48 Comments
[omnibox chrome:omnibox] Rename AutocompleteResults to AutocompleteResponse Previously, the debug page and the related page handler referred to responses returned from the page handler to the debug page as results, which in turn contained autocomplete matches also referred to as results. This became slightly confusing when naming methods and variables. To alleviate the issue, the JS code began distinguishing them by referring to the prior as AutocompleteResponses and the latter as results. This left the JS naming slightly inconsistent with the page handler naming. This CL extends the distinction to the page handler. Bug: 891303 Change-Id: I65a6d0986a30bfe4dc9f9ffff9f2001c0fb82fb6 Reviewed-on: https://chromium-review.googlesource.com/c/1407370 Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#624124}
Changed files
- chrome/browser/resources/omnibox/omnibox.js
- chrome/browser/resources/omnibox/omnibox_output.js
- chrome/browser/ui/webui/omnibox/omnibox.mojom
- chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc
-
[s13n] Add IdentityManager::Observer::OnAccountUpdated
Changed by Julie Jeongeun Kim - jkimohnoyoudont@igalia.com Changed at Friday, 18-Jan-19 15:00:57 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b1d45207353420b1fbcad9f0dd426d65ad5e9255 Comments
[s13n] Add IdentityManager::Observer::OnAccountUpdated This CL adds IdentityManager::Observer::OnAccountUpdated to replace AccountTrackerService::Observer::OnAccountUpdated. Test: IdentityManagerTest.ObserveOnAccountUpdated Bug: 922469 Change-Id: I2e787dca982dbb935925f6a00dd239aa3fe915a8 Reviewed-on: https://chromium-review.googlesource.com/c/1417433 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#624123}
Changed files
- services/identity/public/cpp/identity_manager.cc
- services/identity/public/cpp/identity_manager.h
- services/identity/public/cpp/identity_manager_unittest.cc
-
[Explore sites]: Update activity table when there is a site click.
Changed by Cathy Li - chiliohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 14:59:32 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 72d8743550ff6a19afb05d0b1a9b7c0b867a3a5f Comments
[Explore sites]: Update activity table when there is a site click. Bug: 918436 Change-Id: I88fb3e7fe53d4418ff5f749e31e5f2a7b7d1b783 Reviewed-on: https://chromium-review.googlesource.com/c/1415816 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#624122}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridge.java
- chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryCardView.java
- chrome/browser/BUILD.gn
- chrome/browser/android/explore_sites/explore_sites_bridge.cc
- chrome/browser/android/explore_sites/explore_sites_service.h
- chrome/browser/android/explore_sites/explore_sites_service_impl.cc
- chrome/browser/android/explore_sites/explore_sites_service_impl.h
- chrome/browser/android/explore_sites/record_site_click_task.cc
- chrome/browser/android/explore_sites/record_site_click_task.h
- chrome/browser/android/explore_sites/record_site_click_task_unittest.cc
- chrome/test/BUILD.gn
-
Move layout tests entirely to Mac 10.13.
Changed by John Budorick - jbudorickohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 14:54:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a05aae00b991ec291f54a6d43f4782a276bd0ffa Comments
Move layout tests entirely to Mac 10.13. We've been seeing a relatively consistent pattern at peak on mac_chromium_rel_ng: pending times creep toward 20 minutes, then skyrocket to 60 minutes as layout test tasks get dumped into a relatively limited 10.12.6 pool. This should alleviate load on the 10.12.6 pool (allowing us to upgrade more of it) and hopefully will result in fewer task expirations. No-Try: true Tbr: bradhall@chromium.org,kbr@chromium.org Bug: 853356 Change-Id: I7248fb7d0578e1dcf343da2b21ab47a575bd4c1e Reviewed-on: https://chromium-review.googlesource.com/c/1420306 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#624121}
Changed files
- testing/buildbot/chromium.mac.json
- testing/buildbot/test_suite_exceptions.pyl
-
GWP-ASan: Reduce default memory usage
Changed by Vlad Tsyrklevich - vtsyrklevichohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 14:53:02 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ee64a06657f040572f763896d7dea37ee578cff5 Comments
GWP-ASan: Reduce default memory usage The current default settings consume approximately ~250k per process (1k * TotalPage + 4k * MaxAllocations) which causes ~5-6% regression on some memory benchmarks. Change the default GWP-ASan settings to reduce the memory usage ~6x to ~45k per process. Also reduce the maximum TotalPages parameter we support. Given the current settings it is very unlikely that we will ever ratchet up GWP-ASan parameters that high and it will reduce the amount of memory used by AllocatorState::data. Bug: 921237 Change-Id: I097f3445248c5933f216a751c0b67c2e6af3868e Reviewed-on: https://chromium-review.googlesource.com/c/1413615 Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#624120}
Changed files
- components/gwp_asan/client/gwp_asan.cc
- components/gwp_asan/common/allocator_state.h
-
Roll Fuchsia SDK from ccbe4eaa8faa to 7e05172b8c49
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Friday, 18-Jan-19 14:48:35 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ea12da0b8864e1ad88b24aa2fc1a9e30bb555384 Comments
Roll Fuchsia SDK from ccbe4eaa8faa to 7e05172b8c49 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I879b274f584cd74afa6f3fc45ab959d41d4f3814 Reviewed-on: https://chromium-review.googlesource.com/c/1421260 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624119}
Changed files
- build/fuchsia/linux.sdk.sha1
- build/fuchsia/mac.sdk.sha1
-
Update V8 to version 7.3.441.
Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com Changed at Friday, 18-Jan-19 14:47:40 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8555d6c9393603814a097e1c417b59ff22c4a77d Comments
Update V8 to version 7.3.441. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/37b97e95..1912df56 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I604131ea02668b5b1f5bae7594e97dd14890ba54 Reviewed-on: https://chromium-review.googlesource.com/c/1421497 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624118}
Changed files
- DEPS
-
Revert "Reland "Enable unique font matching matching by default""
Changed by Dominik Röttsches - drottohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 14:37:47 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 09e747504f7caf471e94acc4916864790517e40c Comments
Revert "Reland "Enable unique font matching matching by default"" This reverts commit 1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f. Reason for revert: * Preliminary Windows font table lookup build times look too high * Time to first paint affected on some lower end Android tests Original change's description: > Reland "Enable unique font matching matching by default" > > This reverts commit f6c717eb8b60f311b6357b3ddace4c79b1a2e64e. > > Reason for revert: Crash has been addressed in > https://chromium-review.googlesource.com/c/chromium/src/+/1414852 > > Original change's description: > > Revert "Enable unique font matching matching by default" > > > > This reverts commit 2e8e7c130cbb432732e973fd8c266a0608727b5f. > > > > Reason for revert: Crashes observed in Windows Canary > > > > Bug: 922183 > > > > Original change's description: > > > Enable unique font matching matching by default > > > > > > Now that all implementations for Android, Windows, Linux/CrOS and Mac > > > are in place, enable the feature globally. Chrome will match fonts > > > references in @font-face { src: local(<font-name>) } correctly by > > > postscript name or full font name. This addresses a long standing, > > > highly starred font matching issue in Chrome. > > > > > > Bug: 828317, 627143, 921029 > > > Change-Id: I348855fdca817a4cd279f4d938e6d5ffe91ee004 > > > Reviewed-on: https://chromium-review.googlesource.com/c/1400695 > > > Commit-Queue: Dominik Röttsches <drott@chromium.org> > > > Reviewed-by: Avi Drissman <avi@chromium.org> > > > Reviewed-by: Emil A Eklund <eae@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#622456} > > > > TBR=avi@chromium.org,eae@chromium.org,drott@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 828317, 627143, 921029 > > Change-Id: I6a89f36923abb7d87de712c9ac0852da06a66d37 > > Reviewed-on: https://chromium-review.googlesource.com/c/1412824 > > Reviewed-by: Dominik Röttsches <drott@chromium.org> > > Commit-Queue: Dominik Röttsches <drott@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#622898} > > TBR=avi@chromium.org,eae@chromium.org,drott@chromium.org > > Change-Id: I915e1bb20ee51325befa5ef7eab07f78eaa8c974 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 922183, 828317, 627143, 921029, 922183 > Reviewed-on: https://chromium-review.googlesource.com/c/1413603 > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#623199} TBR=avi@chromium.org,eae@chromium.org,drott@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 922183, 828317, 627143, 921029, 923245, 922495, 922941 Change-Id: I27efa4f06148c2fc58d7feb5f15f48623713a570 Reviewed-on: https://chromium-review.googlesource.com/c/1421099 Reviewed-by: Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#624117}
Changed files
- content/public/common/content_features.cc
- third_party/blink/web_tests/NeverFixTests
- third_party/blink/web_tests/fast/css/font-face-character-fallback.html
- third_party/blink/web_tests/fast/css/font-face-descending-unicode-range.html
- third_party/blink/web_tests/fast/css/font-face-download-error.html
- third_party/blink/web_tests/fast/css/font-face-in-media-rule.html
- third_party/blink/web_tests/fast/css/font-face-multiple-ranges-for-unicode-range.html
- third_party/blink/web_tests/fast/css/font-face-unicode-range-monospace.html
- third_party/blink/web_tests/fast/css/fontfaceset-add-remove.html
- third_party/blink/web_tests/fast/css/fontfaceset-download-error.html
- third_party/blink/web_tests/fast/css/fontfaceset-multiple-faces.html
- third_party/blink/web_tests/fast/forms/select-popup/popup-menu-font-face.html
- third_party/blink/web_tests/fast/inline/vertical-align-with-fallback-fonts.html
- third_party/blink/web_tests/fast/text/capitalize-boundaries.html
- third_party/blink/web_tests/fast/text/unique-vs-family-match.html
- third_party/blink/web_tests/inspector-protocol/layout-fonts/unicode-range-order.js
- third_party/blink/web_tests/platform/mac-mac10.10/fast/text/unique-vs-family-match-expected.png
- third_party/blink/web_tests/platform/mac-mac10.12/fast/text/unique-vs-family-match-expected.png
- third_party/blink/web_tests/platform/mac/fast/text/unique-vs-family-match-expected.png
-
[scheduler] Remove throttling from MainThreadScheduler
Changed by Alexander Timin - altiminohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 14:36:55 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 16c9e690685282e3e5d61b393347352b9507e6cd Comments
[scheduler] Remove throttling from MainThreadScheduler We don't need the throttling for expensive tasks anymore and we don't have any default timer tasks as well, so let's kill it. R=alexclarke@chromium.org,skyostil@chromium.org Change-Id: I258786c8893857b25414d9b65b0b501a3a3d9c3e Reviewed-on: https://chromium-review.googlesource.com/c/1418371 Reviewed-by: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#624116}
Changed files
- third_party/blink/renderer/core/scheduler/throttling_test.cc
- third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
- third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
- third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
-
Add experimental support for Auto Picture-in-Picture
Changed by François Beaufort - beaufort.francoisohnoyoudont@gmail.com Changed at Friday, 18-Jan-19 14:34:51 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f09e446e4a5a905e972074c2fc4700a31533f25e Comments
Add experimental support for Auto Picture-in-Picture This CL adds the autoPictureinPicture attribute to the HTMLVideoElement behind an experimental blink runtime flag so that web developers can play with Auto Picture-in-Picture behaviour by running chrome with the --enable-blink-features=AutoPictureInPicture switch. Spec: https://github.com/WICG/picture-in-picture/pull/112 Note that video with no audio don't play in Auto Picture-in-Picture because of background video optimizations. This will be addressed in an upcoming CL. Change-Id: I5aeb0e792ebf3b3ea32e0db8bebee660e640841f Bug: 917303 Reviewed-on: https://chromium-review.googlesource.com/c/1380533 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#624115}
Changed files
- chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
- chrome/browser/ui/browser.cc
- chrome/browser/ui/browser.h
- chrome/test/data/extensions/auto_picture_in_picture/main.html
- content/browser/web_contents/web_contents_impl.cc
- content/browser/web_contents/web_contents_impl_unittest.cc
- content/public/browser/web_contents_delegate.cc
- content/public/browser/web_contents_delegate.h
- content/shell/browser/shell.cc
- content/shell/browser/shell.h
- extensions/browser/app_window/app_window.cc
- extensions/browser/app_window/app_window.h
- extensions/browser/extension_host.cc
- extensions/browser/extension_host.h
- third_party/blink/public/platform/web_feature.mojom
- third_party/blink/renderer/core/html/html_attribute_names.json5
- third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture.cc
- third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture.idl
- third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
- third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.h
- third_party/blink/renderer/platform/runtime_enabled_features.json5
- third_party/blink/web_tests/webexposed/element-instance-property-listing-expected.txt
- third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
- tools/metrics/histograms/enums.xml
-
Move "global properties" to ResourceFetcherProperties, part 4
Changed by Yutaka Hirano - yhiranoohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 14:34:38 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8b06109490928adae220fc5c5add22a7a96e9e30 Comments
Move "global properties" to ResourceFetcherProperties, part 4 Remove the following methods from FetchContext: - GetFetchClientSettingsObject - IsControlledByServiceWorker - ServiceWorkerID - IsMainFrame - DefersLoading - IsLoadComplete - GetSecurityOrigin Add tests for ResourceFetcher::DetachableProperties in resource_fetcher_test.cc. Bug: 914739 Change-Id: I04fbdb95023a3d9f5b4b0f414149321d5af1f059 Reviewed-on: https://chromium-review.googlesource.com/c/1406789 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#624114}
Changed files
- third_party/blink/renderer/core/exported/web_frame_test.cc
- third_party/blink/renderer/core/exported/web_shared_worker_impl.cc
- third_party/blink/renderer/core/loader/base_fetch_context.cc
- third_party/blink/renderer/core/loader/base_fetch_context_test.cc
- third_party/blink/renderer/core/loader/frame_fetch_context.cc
- third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
- third_party/blink/renderer/core/loader/mixed_content_checker.cc
- third_party/blink/renderer/core/loader/modulescript/module_script_loader.cc
- third_party/blink/renderer/core/loader/threadable_loader.cc
- third_party/blink/renderer/core/workers/dedicated_worker.cc
- third_party/blink/renderer/core/workers/worker_classic_script_loader.cc
- third_party/blink/renderer/core/workers/worklet.cc
- third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc
- third_party/blink/renderer/platform/loader/allowed_by_nosniff.cc
- third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
- third_party/blink/renderer/platform/loader/fetch/fetch_context.h
- third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
- third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
- third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc
- third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
- third_party/blink/renderer/platform/loader/testing/test_resource_fetcher_properties.h
-
Roll src/third_party/angle 15214423845e..1f750d1e3b50 (2 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Friday, 18-Jan-19 14:33:14 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3d69f05f4156b97104fbba3e48328156df1239c4 Comments
Roll src/third_party/angle 15214423845e..1f750d1e3b50 (2 commits) https://chromium.googlesource.com/angle/angle.git/+log/15214423845e..1f750d1e3b50 git log 15214423845e..1f750d1e3b50 --date=short --no-merges --format='%ad %ae %s' 2019-01-18 jmadill@chromium.org Even more inlining and micro-optimization. 2019-01-18 jmadill@chromium.org Use a table for vertex attrib type validation. Created with: gclient setdep -r src/third_party/angle@1f750d1e3b50 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ifd5f0d332e0ca0842ab7bad3474c4549b4d52095 Reviewed-on: https://chromium-review.googlesource.com/c/1421261 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624113}
Changed files
- DEPS
-
[iOS] Moving sync error to sync section for Google services settings
Changed by Jérôme Lebel - jlebelohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 14:31:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 377e62e82d594747d7681fee4eee3c395e1a2308 Comments
[iOS] Moving sync error to sync section for Google services settings The sync feedback section is merged into the sync section. Adding -updateAccountSignInItem to update the account sign-in item. Adding -updateSyncErrorItems to update the sync error items. Bug: 914059 Change-Id: I9e96ca17811e815c8b3314d56db4cc789628bc87 Reviewed-on: https://chromium-review.googlesource.com/c/1408249 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#624112}
Changed files
- ios/chrome/browser/ui/settings/google_services_settings_mediator.mm
-
Remove PrefService, AccountTrackerService and ScopedTaskEnvironment references from one_google_bar_service_unittest.cc
Changed by Abhijeet Kandalkar - abhijeetohnoyoudont@igalia.com Changed at Friday, 18-Jan-19 14:27:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9d887b622db98e41cfacb4daf12e27dc87ae7e52 Comments
Remove PrefService, AccountTrackerService and ScopedTaskEnvironment references from one_google_bar_service_unittest.cc Removed |signin_client_| and |token_service_| ivars and their corresponding includes from one_google_bar_service_unittest.cc Removed unwated calls to |task_environment_| Bug: 921610 Change-Id: I429652a10d5b89f92a1472cf655cc63c07721c8f Reviewed-on: https://chromium-review.googlesource.com/c/1415230 Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#624111}
Changed files
- chrome/browser/search/one_google_bar/one_google_bar_service_unittest.cc