Builder Linux FYI Release (AMD R7 240) Build 2749
Results:
Success
Trigger Info:
Project | chromium |
Revision | de32fa1fb962aa82b13f9f80f681b84ea2b29214 |
Got Revision | de32fa1fb962aa82b13f9f80f681b84ea2b29214 |
Execution:
- Source: Task 4279a3b9339df910
- Bot: swarm1080-c4
- Recipe: chromium
Steps and Logfiles:
Show:-
( 228 ms ) report buildersrunning tester 'Linux FYI Release (AMD R7 240)' on master 'chromium.gpu.fyi'
-
- - no logs -
-
( 1 secs ) read test spec (chromium.gpu.fyi.json)path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
-
( 443 ms ) lookup builder GN argsbuild_angle_gles1_conform_tests = truedcheck_always_on = trueffmpeg_branding = "Chrome"internal_gles2_conform_tests = trueis_component_build = falseis_debug = falseproprietary_codecs = truestrip_absolute_paths_from_debug_symbols = truesymbol_level = 1use_goma = truegoma_dir = "/b/swarming/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
-
( 1 mins 24 secs ) angle_unittests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Pending time: 58sShard duration: 23s
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] angle_white_box_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 11 secs ) angle_white_box_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 8s
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] tab_capture_end2end_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 24 secs ) tab_capture_end2end_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 23s
-
- - no logs -
-
- - no logs -
-
( 939 ms ) test_pre_run.[trigger] gles2_conform_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
- - no logs -
-
( 953 ms ) test_pre_run.[trigger] swiftshader_unittests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 1 secs ) swiftshader_unittests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 5s
-
- - no logs -
-
( 2 secs ) test_pre_run.[trigger] context_lost_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 3 mins 10 secs ) context_lost_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:03:06.855349Total tests: 10* Passed: 10 (10 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] depth_capture_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 29 secs ) depth_capture_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 24sTotal tests: 3* Passed: 3 (3 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 946 ms ) test_pre_run.[trigger] gpu_process_launch_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 2 mins 57 secs ) gpu_process_launch_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:02:50.623644Total tests: 15* Passed: 15 (15 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] hardware_accelerated_feature_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 27 secs ) hardware_accelerated_feature_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 22sTotal tests: 2* Passed: 2 (2 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 958 ms ) test_pre_run.[trigger] info_collection_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 24 secs ) info_collection_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 22sTotal tests: 1* Passed: 1 (1 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 35 secs ) maps_pixel_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 32sTotal tests: 1* Passed: 1 (1 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 9 mins 14 secs ) pixel_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:09:09.965885Total tests: 49* Passed: 49 (49 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 844 ms ) test_pre_run.[trigger] screenshot_sync_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 1 mins 17 secs ) screenshot_sync_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:01:12.086195Total tests: 4* Passed: 4 (4 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 5 mins 28 secs ) trace_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:05:21.049969Total tests: 48* Passed: 24 (24 expected, 0 unexpected)* Skipped: 24 (24 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 9 secs ) test_pre_run.[trigger] webgl2_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 2 hrs 6 mins ) webgl2_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Max pending time: 1:59:29.554140 (shard #19)Max shard duration: 0:06:59.762825 (shard #4)Min shard duration: 0:05:28.898257 (shard #14)Total tests: 2803* Passed: 2735 (2735 expected, 0 unexpected)* Skipped: 68 (68 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
- stdout
- json.output
- swarming.summary
- Merge script log
- outdir_json
- step_metadata
- shard #0 isolated out
- shard #0 (367.1 sec)
- shard #1 isolated out
- shard #1 (342.1 sec)
- shard #2 isolated out
- shard #2 (343.4 sec)
- shard #3 isolated out
- shard #3 (377.5 sec)
- shard #4 isolated out
- shard #4 (412.2 sec)
- shard #5 isolated out
- shard #5 (386.6 sec)
- shard #6 isolated out
- shard #6 (402.8 sec)
- shard #7 isolated out
- shard #7 (322.9 sec)
- shard #8 isolated out
- shard #8 (375.2 sec)
- shard #9 isolated out
- shard #9 (354.5 sec)
- shard #10 isolated out
- shard #10 (401.3 sec)
- shard #11 isolated out
- shard #11 (360.9 sec)
- shard #12 isolated out
- shard #12 (390.0 sec)
- shard #13 isolated out
- shard #13 (338.2 sec)
- shard #14 isolated out
- shard #14 (322.1 sec)
- shard #15 isolated out
- shard #15 (378.6 sec)
- shard #16 isolated out
- shard #16 (387.0 sec)
- shard #17 isolated out
- shard #17 (351.4 sec)
- shard #18 isolated out
- shard #18 (403.1 sec)
- shard #19 isolated out
- shard #19 (401.1 sec)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] webgl_conformance_gl_passthrough_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 9 mins 55 secs ) webgl_conformance_gl_passthrough_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Max pending time: 0:03:46.287784 (shard #1)Max shard duration: 0:06:01.804363 (shard #1)Min shard duration: 0:02:12.580307 (shard #0)Total tests: 938* Passed: 932 (932 expected, 0 unexpected)* Skipped: 6 (6 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] webgl_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 9 mins 21 secs ) webgl_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Max pending time: 0:02:14.415246 (shard #1)Max shard duration: 0:06:53.681867 (shard #1)Min shard duration: 0:02:13.182137 (shard #0)Total tests: 938* Passed: 932 (932 expected, 0 unexpected)* Skipped: 6 (6 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm1080-c4" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547812613660877, "id": "8923994556777116656", "project": "chromium", "tags": ["builder:Linux FYI Release (AMD R7 240)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/de32fa1fb962aa82b13f9f80f681b84ea2b29214", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Linux Builder", "parent_buildnumber:39704", "scheduler_invocation_id:9089424618809204896", "scheduler_job_id:chromium/Linux FYI Release (AMD R7 240)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "Linux FYI Release (AMD R7 240)" | setup_build |
buildnumber | 2749 | setup_build |
mastername | "chromium.gpu.fyi" | setup_build |
parent_buildername | "GPU FYI Linux Builder" | setup_build |
parent_got_angle_revision | "15214423845e8cf32dd1b8495e1a2786af1fc8b9" | setup_build |
parent_got_buildtools_revision | "40194ab03962d8183b2796fa58a39ec8a9e83a41" | setup_build |
parent_got_dawn_revision | "850c0d9aec6bd3f63cb58ff1838380efc112279a" | setup_build |
parent_got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | setup_build |
parent_got_revision | "de32fa1fb962aa82b13f9f80f681b84ea2b29214" | setup_build |
parent_got_revision_cp | "refs/heads/master@{#624078}" | setup_build |
parent_got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | setup_build |
parent_got_v8_revision | "79c9d04766de9a845be146902f6503bdd3ff0ae6" | setup_build |
parent_got_v8_revision_cp | "refs/heads/7.3.438@{#1}" | setup_build |
parent_got_webrtc_revision | "74ba99062c48b278675cfe52643719202296fddc" | setup_build |
parent_got_webrtc_revision_cp | "refs/heads/master@{#26298}" | setup_build |
parent_mastername | "chromium.gpu.fyi" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
revision | "de32fa1fb962aa82b13f9f80f681b84ea2b29214" | setup_build |
swarm_hashes | {"angle_end2end_tests": "9cf1893614e2c3f79576671c41be72f0b9771a4d", "angle_perftests": "eb6e485dab7993c67b27da81249651840b1b2d4a", "angle_unittests": "2a5985a4afe7df41167a6e8c2393b5cb4756de08", "angle_white_box_tests": "f708064bc9dcec5d4c360be0213be1329986eb1c", "browser_tests": "427d8b82037b4f71a8500c0511220ddc8d61f3ed", "dawn_end2end_tests": "b802b1a60763cf64dfbd6cb203123a901410850d", "gl_tests": "a7448748277b43b4759f68f5689614720e556874", "gl_unittests": "0a064756d11292cd6c301cfdcc332f765db83435", "gles2_conform_test": "71727a6b31a691aaa326086ae5bdb89c5563699d", "swiftshader_unittests": "84fa6663a1dd12e99764c625b2718c6c9b2f6e00", "telemetry_gpu_integration_test": "a8152ef3ec7443608704f66060dcaaa2ba6b214c"} | setup_build |
got_angle_revision | "85ca189542cdf9880d11edd2a4aca992a5782b91" | bot_update |
got_buildtools_revision | "40194ab03962d8183b2796fa58a39ec8a9e83a41" | bot_update |
got_dawn_revision | "850c0d9aec6bd3f63cb58ff1838380efc112279a" | bot_update |
got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
got_revision | "de32fa1fb962aa82b13f9f80f681b84ea2b29214" | bot_update |
got_revision_cp | "refs/heads/master@{#624078}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "79c9d04766de9a845be146902f6503bdd3ff0ae6" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.438@{#1}" | bot_update |
got_webrtc_revision | "74ba99062c48b278675cfe52643719202296fddc" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26298}" | bot_update |
swarm_hashes | {} | find isolated tests |
Blamelist:
- Yuki Shiino (yukishiinoohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Xianzhu Wang (wangxianzhuohnoyoudont@chromium.org)
- Wojciech Dzierżanowski (wdzierzanowskiohnoyoudont@opera.com)
- Abhijeet Kandalkar (abhijeetohnoyoudont@igalia.com)
- rajendrant (rajendrantohnoyoudont@chromium.org)
- chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
- Morten Stenshorne (mstenshoohnoyoudont@chromium.org)
- Mario Sanchez Prada (marioohnoyoudont@igalia.com)
- Michael Lippautz (mlippautzohnoyoudont@chromium.org)
- Juan Antonio Navarro Perez (perezjuohnoyoudont@chromium.org)
- Joey Arhar (jarharohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Camille Lamy (clamyohnoyoudont@chromium.org)
- Thomas Tangl (tangltomohnoyoudont@chromium.org)
- Arthur Hemery (ahemeryohnoyoudont@chromium.org)
- Julie Jeongeun Kim (jkimohnoyoudont@igalia.com)
- Makoto Shimazu (shimazuohnoyoudont@chromium.org)
- Carlos Caballero (carlscabohnoyoudont@google.com)
- Carlos Caballero (carlscabohnoyoudont@google.com)
- Yi Su (mrsuyiohnoyoudont@chromium.org)
- Carlos Caballero (carlscabohnoyoudont@google.com)
- Hiroki Nakagawa (nhirokiohnoyoudont@chromium.org)
- Lutz Justen (ljustenohnoyoudont@chromium.org)
- Mario Sanchez Prada (marioohnoyoudont@igalia.com)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Gyuyoung Kim (gyuyoungohnoyoudont@igalia.com)
- Takashi Sakamoto (tasakohnoyoudont@google.com)
- Henrik Boström (hbosohnoyoudont@chromium.org)
- Takashi Toyoshima (toyoshimohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Henrique Ferreiro (hferreiroohnoyoudont@igalia.com)
- Andreas Haas (ahaasohnoyoudont@chromium.org)
- Mirko Bonadei (mbonadeiohnoyoudont@chromium.org)
- Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
- Christopher Lam (calamityohnoyoudont@chromium.org)
Timing:
Create | Friday, 18-Jan-19 11:56:53 UTC |
Start | Friday, 18-Jan-19 11:56:59 UTC |
End | Friday, 18-Jan-19 14:52:56 UTC |
Pending | 5 secs |
Execution | 2 hrs 55 mins |
All Changes:
-
v8binding: Support [CallWith=Isolate]
Changed by Yuki Shiino - yukishiinoohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 11:48:33 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision de32fa1fb962aa82b13f9f80f681b84ea2b29214 Comments
v8binding: Support [CallWith=Isolate] Supports [CallWith=Isolate] so that implementations can use v8::Isolate* without requiring ScriptState*. There have been demands of [CallWith=Isolate] but we've been using [CallWith=ScriptState] instead. However, in case of cross origin properties, we cannot use a ScriptState because remote contexts do not have a v8::Context nor ScriptState. Now, in order to use v8::Isolate::GetIncumbentContext, it's necessary rather than nice-to-have to support [CallWith=Isolate]. Change-Id: I047c871cd3d549afcf8ee93ac518130951adaee3 Reviewed-on: https://chromium-review.googlesource.com/c/1417401 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#624078}
Changed files
- third_party/blink/renderer/bindings/IDLExtendedAttributes.txt
- third_party/blink/renderer/bindings/scripts/v8_utilities.py
- third_party/blink/renderer/bindings/tests/idls/core/test_object.idl
- third_party/blink/renderer/bindings/tests/results/core/v8_test_object.cc
- third_party/blink/renderer/bindings/tests/results/core/v8_test_object.h
-
Roll src/third_party/catapult a0e5e3328cd7..8e77731b1363 (6 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Friday, 18-Jan-19 11:33:56 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c47537d42e1cfb7f3ff655a450fd0b026a15b33b Comments
Roll src/third_party/catapult a0e5e3328cd7..8e77731b1363 (6 commits) https://chromium.googlesource.com/catapult.git/+log/a0e5e3328cd7..8e77731b1363 git log a0e5e3328cd7..8e77731b1363 --date=short --no-merges --format='%ad %ae %s' 2019-01-17 crouleau@chromium.org Revert "Stop splitting logcat output on carriage returns." 2019-01-17 crouleau@chromium.org Revert "Ignore zeros in Breakdowns." 2019-01-17 uwyiming@google.com Add an option in WPR replay to prefer previously unmatched responses. 2019-01-17 crouleau@chromium.org [Telemetry] Cleanup: Remove unused argument from FindAllBrowserTypes 2019-01-17 uwyiming@google.com Adding uwyiming (myself) as an owner to WPR. 2019-01-17 skym@chromium.org Stop splitting logcat output on carriage returns. Created with: gclient setdep -r src/third_party/catapult@8e77731b1363 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:919223,chromium:919223,chromium:923125,chromium:922734,chromium:922828,chromium:919223 TBR=sullivan@chromium.org Change-Id: I7fc110d1697c8624cf391c634fa26204b3bef617 Reviewed-on: https://chromium-review.googlesource.com/c/1419365 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624077}
Changed files
- DEPS
-
[BlinkGenPropertyTrees] Avoid visual update loop of two svg images
Changed by Xianzhu Wang - wangxianzhuohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 11:27:42 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f55ea7a02f3aa08ce57225d658d4e94c081247ba Comments
[BlinkGenPropertyTrees] Avoid visual update loop of two svg images When two images referencing the same SVGImage, and they have different sizes, previously setting the different viewport size for the same SVGImage schedules visual update and the next frame update still do the same causing a loop. Now remove the ImageObserver::Changed() call for BGPT/CAP. The call has been unnecessary since crrev.com/c/1393558, and was unnecessary for BGPT even before the CL. Bug: 918752 Change-Id: I13ca36a7d41143d0e639a880ebba37868b31ac49 Reviewed-on: https://chromium-review.googlesource.com/c/1419498 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#624076}
Changed files
- third_party/blink/renderer/core/paint/pre_paint_tree_walk.cc
- third_party/blink/renderer/core/svg/graphics/svg_image.cc
- third_party/blink/renderer/core/svg/graphics/svg_image_chrome_client.h
- third_party/blink/renderer/core/svg/graphics/svg_image_test.cc
-
Expose CONNECT headers to ProxyDelegate
Changed by Wojciech Dzierżanowski - wdzierzanowskiohnoyoudont@opera.com Changed at Friday, 18-Jan-19 11:26:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1f823561df5c393ceabfe36ded1ddbe53b9983ba Comments
Expose CONNECT headers to ProxyDelegate This brings back (slightly refreshed versions of) the OnBeforeTunnelRequest(), OnTunnelHeadersReceived() hooks that were removed in https://chromium-review.googlesource.com/c/chromium/src/+/846261/. These hooks are not used by the Data Reduction Proxy, because it doesn't proxy https:// URLs. They are restored for the benefit of those downstream embedders (Opera) that use CONNECT tunnels to proxy HTTPS requests. Bug: 915659 Change-Id: Id0e120882a22a66c72802087a1775daeef661984 TBR: rockot@google.com Reviewed-on: https://chromium-review.googlesource.com/c/1379766 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#624075}
Changed files
- chrome/browser/extensions/api/socket/tcp_socket_unittest.cc
- components/cast_channel/cast_socket_unittest.cc
- components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc
- components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h
- net/base/proxy_delegate.h
- net/base/test_proxy_delegate.cc
- net/base/test_proxy_delegate.h
- net/dns/address_sorter_posix_unittest.cc
- net/dns/dns_session_unittest.cc
- net/http/http_network_session.cc
- net/http/http_network_session.h
- net/http/http_network_transaction_unittest.cc
- net/http/http_proxy_client_socket.cc
- net/http/http_proxy_client_socket.h
- net/http/http_proxy_client_socket_fuzzer.cc
- net/http/http_proxy_client_socket_pool.cc
- net/http/http_proxy_client_socket_pool.h
- net/http/http_proxy_client_socket_pool_unittest.cc
- net/http/http_proxy_client_socket_unittest.cc
- net/http/http_proxy_client_socket_wrapper.cc
- net/http/http_proxy_client_socket_wrapper.h
- net/http/http_proxy_client_socket_wrapper_unittest.cc
- net/http/http_stream_factory_unittest.cc
- net/http/proxy_client_socket.cc
- net/http/proxy_client_socket.h
- net/proxy_resolution/pac_library_unittest.cc
- net/proxy_resolution/proxy_resolution_service_unittest.cc
- net/socket/client_socket_factory.cc
- net/socket/client_socket_factory.h
- net/socket/client_socket_pool_base_unittest.cc
- net/socket/client_socket_pool_manager_impl.cc
- net/socket/client_socket_pool_manager_impl.h
- net/socket/fuzzed_socket_factory.cc
- net/socket/fuzzed_socket_factory.h
- net/socket/socket_test_util.cc
- net/socket/socket_test_util.h
- net/socket/ssl_client_socket_pool_unittest.cc
- net/socket/transport_client_socket_pool_test_util.cc
- net/socket/transport_client_socket_pool_test_util.h
- net/url_request/url_request_context.cc
- net/url_request/url_request_context.h
- net/url_request/url_request_context_builder.cc
- net/url_request/url_request_context_storage.cc
- net/websockets/websocket_basic_stream_adapters_test.cc
- net/websockets/websocket_end_to_end_test.cc
- services/network/network_service_proxy_delegate.cc
- services/network/network_service_proxy_delegate.h
- services/network/proxy_resolving_client_socket_factory.cc
-
Port android_management related classes to IdentityManager
Changed by Abhijeet Kandalkar - abhijeetohnoyoudont@igalia.com Changed at Friday, 18-Jan-19 11:25:40 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 97836873a9a766395933c9541a327b93c8be0b83 Comments
Port android_management related classes to IdentityManager This CL ports android_management_client to IdentityManager and android_management_client_unittest to IdentityTestEnvironment by passing an IdentityManager instance to AndroidManagementClient in place of PO2TS instance. This CL also fixes arc_android_management_checker away from talking to ProfileOAuth2TokenService in favor of talking to IdentityManager. Bug: 906021 Change-Id: I0554f9a608ac75c555372bc4552d1960bbbbabd3 Reviewed-on: https://chromium-review.googlesource.com/c/1405109 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by: Sergey Poromov <poromov@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#624074}
Changed files
- chrome/browser/chromeos/arc/policy/arc_android_management_checker.cc
- chrome/browser/chromeos/policy/android_management_client.cc
- chrome/browser/chromeos/policy/android_management_client.h
- chrome/browser/chromeos/policy/android_management_client_unittest.cc
-
Reland "LazyLoad: Fix deferred loading of CSS background images"
Changed by rajendrant - rajendrantohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 11:22:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a395226e3bdb1640c5b8b30b3a5f89d38395643a Comments
Reland "LazyLoad: Fix deferred loading of CSS background images" kDeferImageLoad bit is not set in the FetchParameters when CSS background images need to be deferred. This CL fixes that, and also adds browser test and unit test. Reland of https://chromium-review.googlesource.com/c/1416878 after disabling one browser test in windows, chrome OS. TBR=japhet@chromium.org,futhark@chromium.org Bug: 920899 Change-Id: Ide0462c7cc09891761759383adf50ff738929ecb Reviewed-on: https://chromium-review.googlesource.com/c/1420298 Reviewed-by: rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#624073}
Changed files
- chrome/browser/previews/lazyload_browsertest.cc
- chrome/test/BUILD.gn
- chrome/test/data/lazyload/css-background-image.html
- chrome/test/data/lazyload/images/fruit1.jpg
- chrome/test/data/lazyload/images/fruit2.jpg
- third_party/blink/renderer/core/BUILD.gn
- third_party/blink/renderer/core/css/css_image_value.cc
- third_party/blink/renderer/core/html/lazy_load_image_observer_test.cc
- third_party/blink/renderer/platform/loader/fetch/fetch_parameters.cc
- third_party/blink/renderer/platform/loader/fetch/fetch_parameters.h
-
Roll src-internal 35e1e73f42dd..57f5615e2daf (10 commits)
Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com Changed at Friday, 18-Jan-19 11:20:35 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 23e69cc23fbdfd26ba360242165131713c545f23 Comments
Roll src-internal 35e1e73f42dd..57f5615e2daf (10 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/35e1e73f42dd..57f5615e2daf Created with: gclient setdep -r src-internal@57f5615e2daf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia71041827cb39a6b851b130f79016c3c10749f64 Reviewed-on: https://chromium-review.googlesource.com/c/1420717 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624072}
Changed files
- DEPS
-
[LayoutNG] text-overflow-015.html fails in both engines now.
Changed by Morten Stenshorne - mstenshoohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 11:18:05 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 837b8e19e776e4849081d88af42c5d2726b735ad Comments
[LayoutNG] text-overflow-015.html fails in both engines now. TBR=ikilpatrick@chromium.org,kojii@chromium.org Bug: 893550 Change-Id: I7f5cf01c216bc4172d7752ee226a5e36eec2f335 Reviewed-on: https://chromium-review.googlesource.com/c/1420839 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#624071}
Changed files
- third_party/blink/web_tests/FlagExpectations/enable-blink-features=LayoutNG
-
Migrate inline_login_handler_impl.cc away from ProfileOAut2TokenService
Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com Changed at Friday, 18-Jan-19 11:14:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 76ec273db6e52343010095b5d031b89753193a05 Comments
Migrate inline_login_handler_impl.cc away from ProfileOAut2TokenService Use AccountsMutator's API instead, and get rid of the PO2TS dependency. Bug: 913392 Change-Id: Ibdcf6ea228ca760588cdb2e5416994c8d82fd8df Reviewed-on: https://chromium-review.googlesource.com/c/1414857 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#624070}
Changed files
- chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
-
bindings: Improve wrapper tracing for window.performance
Changed by Michael Lippautz - mlippautzohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 11:13:01 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2118b79f4f9da15cfaafb82c0a5f4e3dedf439be Comments
bindings: Improve wrapper tracing for window.performance - This removes the restriction of not being able to swap and move construct HeapVector<TraceWrapperMember<T>>. - Building on this wrapper tracing cannot properly find links through window.performance. This CL is meant to close the gap between wrapper tracing and unified heap garbage collection wrt. memory usage. Bug: 843903 Change-Id: I699a5fcb8f6f2d63d3d6a908692bdf26d1f7901f Reviewed-on: https://chromium-review.googlesource.com/c/1412820 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#624069}
Changed files
- third_party/blink/renderer/core/css/style_sheet_collection.cc
- third_party/blink/renderer/core/timing/performance.h
- third_party/blink/renderer/core/timing/performance_observer.h
- third_party/blink/renderer/core/timing/performance_observer_entry_list.cc
- third_party/blink/renderer/core/timing/performance_observer_entry_list.h
- third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.h
- third_party/blink/renderer/platform/bindings/trace_wrapper_member.h
- third_party/blink/renderer/platform/heap/heap_allocator.h
- third_party/blink/renderer/platform/wtf/allocator/partition_allocator.h
- third_party/blink/renderer/platform/wtf/vector.h
-
[tools/perf] Remove references to deprecated GetRepresentativeNumber
Changed by Juan Antonio Navarro Perez - perezjuohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 11:03:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 478ab9d54c747c6bb1254fabe172623d7db9a93c Comments
[tools/perf] Remove references to deprecated GetRepresentativeNumber Clients should now use instead: - metric.value for scalars, and - metric.mean for lists of scalar values Bug: 921616 Change-Id: Idab3504059d2d91db17eefde6ad2d43f4b7391e7 Reviewed-on: https://chromium-review.googlesource.com/c/1411920 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#624068}
Changed files
- tools/perf/benchmarks/blink_perf_unittest.py
- tools/perf/measurements/rasterize_and_record_micro_unittest.py
- tools/perf/measurements/skpicture_printer_unittest.py
-
[DevTools] Disable prerendering in tabs where DevTools is open
Changed by Joey Arhar - jarharohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 11:02:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision fbbc4cdf513dc10a495b7e46705010bbf09e2dfa Comments
[DevTools] Disable prerendering in tabs where DevTools is open When a navigation to a page with a service worker is prerendered, the service worker is started before DevTools knows to attach to it, which surfaces a bug where DevTools doesn't apply its user agent override to the initial request. Bug: 907072 Change-Id: I81268f5c95db9909ecf9ed7bb3130b0483831d2c Reviewed-on: https://chromium-review.googlesource.com/c/1416912 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#624067}
Changed files
- chrome/browser/ui/omnibox/chrome_omnibox_client.cc
-
Roll src/third_party/skia 14235d1ec095..b84f90df6f82 (2 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Friday, 18-Jan-19 10:59:55 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision feb4953daa8e19037cac0b5a6353d28a1fabcc44 Comments
Roll src/third_party/skia 14235d1ec095..b84f90df6f82 (2 commits) https://skia.googlesource.com/skia.git/+log/14235d1ec095..b84f90df6f82 git log 14235d1ec095..b84f90df6f82 --date=short --no-merges --format='%ad %ae %s' 2019-01-18 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-01-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d46165e3db5a..3159b2e52e05 (2 commits) Created with: gclient setdep -r src/third_party/skia@b84f90df6f82 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: I9b9568747e2c221a7b5d3e5d44815c259d3dd3ee Reviewed-on: https://chromium-review.googlesource.com/c/1420777 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624066}
Changed files
- DEPS
-
Remove members from NavigationHandleImpl 1
Changed by Camille Lamy - clamyohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 10:55:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f75a36b01aca9068c6f84fb507f4360a116ff1c9 Comments
Remove members from NavigationHandleImpl 1 This CL is part of a series of CLs that removes members from NavigationHandleImpl and queries them from NavigationRequest instead. This CL removes the FrameTreeNode member. Bug: 1377855 Change-Id: I643f22dbacad2f2eeb5cae5d079983bb35685732 Reviewed-on: https://chromium-review.googlesource.com/c/1409551 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#624065}
Changed files
- content/browser/frame_host/navigation_handle_impl.cc
- content/browser/frame_host/navigation_handle_impl.h
- content/browser/frame_host/navigation_handle_impl_unittest.cc
- content/browser/frame_host/navigation_request.cc
-
[unified-consent] Add setup-in-progress label to sync account control
Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 10:53:15 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6372395f094afa8539216f9088b69f87dcef1011 Comments
[unified-consent] Add setup-in-progress label to sync account control When the user is setting up sync for the first time while going through the advanced sync opt-in flow, the subtitle of the account control is "Setup in progress...". Screenshot: https://drive.google.com/file/d/1hwA6lTGRmu3TpR1VRK8GbbQ4eBvOUqnb/view?usp=sharing Bug: 920974 Change-Id: Ib2c6781e2891d17e767edd449bfe567c5c22252a Reviewed-on: https://chromium-review.googlesource.com/c/1414931 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#624064}
Changed files
- chrome/browser/resources/settings/people_page/people_page.html
- chrome/browser/resources/settings/people_page/sync_account_control.html
- chrome/browser/resources/settings/people_page/sync_account_control.js
- chrome/browser/resources/settings/people_page/sync_page.html
- chrome/test/data/webui/settings/sync_account_control_test.js
-
Navigation: Pass NavigationRequest directly to commit.
Changed by Arthur Hemery - ahemeryohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 10:51:55 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7c8c00e1e2c82bb02e77bb46072206f07fb1835c Comments
Navigation: Pass NavigationRequest directly to commit. Currently we pass the navigation_id to the RenderFrameHostImpl and then retrieve the NavigationRequest from the storage map. The navigation_id is extracted from the NavigationRequest in the first place so it does not make sense. The corner case where we don't have a NavigationRequest (for certain interstitials), is simply checked for, the same way we had a not found in map case. Bug: 784904 Change-Id: I2671a10c4b4ff395af84ffa80c9896ea3a24d4d2 Reviewed-on: https://chromium-review.googlesource.com/c/1416255 Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#624063}
Changed files
- content/browser/frame_host/navigation_request.cc
- content/browser/frame_host/render_frame_host_impl.cc
- content/browser/frame_host/render_frame_host_impl.h
-
[s13n] Add LegacyLoadCredentials() to IdentityManager
Changed by Julie Jeongeun Kim - jkimohnoyoudont@igalia.com Changed at Friday, 18-Jan-19 10:49:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 01aa03e4c4e7ecbd1dd9895948db03666ef237db Comments
[s13n] Add LegacyLoadCredentials() to IdentityManager This CL adds LegacyLoadCredentials to IdentityManager in order to help s13n IdentityManager migration. It will be used for replacing ProfileOAuth2TokenService::LoadCredentials(). Bug: 922019 Change-Id: Ie74bc4b21ffb968ff6de83eab1aba5a16417135a Reviewed-on: https://chromium-review.googlesource.com/c/1412775 Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#624062}
Changed files
- services/identity/public/cpp/identity_manager.cc
- services/identity/public/cpp/identity_manager.h
- services/identity/public/cpp/identity_manager_unittest.cc
-
Add unittests for WebURLLoaderImpl when ResourceLoadViaDataPipe is on
Changed by Makoto Shimazu - shimazuohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 10:47:02 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c3c7a4f1401be0f35545c7075da44268b466c63e Comments
Add unittests for WebURLLoaderImpl when ResourceLoadViaDataPipe is on Bug: 922349 Change-Id: Ic2e6f66076485b279ecb4c9da654c784fbfe4c0d Reviewed-on: https://chromium-review.googlesource.com/c/1420398 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#624061}
Changed files
- content/renderer/loader/web_url_loader_impl_unittest.cc
-
[scheduling] Use ScopedTaskEnvironment instead of MessageLoop in local_discovery
Changed by Carlos Caballero - carlscabohnoyoudont@google.com Changed at Friday, 18-Jan-19 10:26:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 308c28fdbd36ee1da13d3d6088fc9c4e3c488b46 Comments
[scheduling] Use ScopedTaskEnvironment instead of MessageLoop in local_discovery MessageLoop will go away, eventually. BUG=891670 Change-Id: I0f6023462491329dce6e6bdd3d9df902db2fa1ac Reviewed-on: https://chromium-review.googlesource.com/c/1417551 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#624060}
Changed files
- chrome/browser/local_discovery/local_domain_resolver_unittest.cc
- chrome/browser/local_discovery/service_discovery_client_unittest.cc
-
[scheduling] Use ScopedTaskEnvironment instead of MessageLoop in desktop_session_duration
Changed by Carlos Caballero - carlscabohnoyoudont@google.com Changed at Friday, 18-Jan-19 10:26:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0e068bae6239645502bc0401b42ae9626c176867 Comments
[scheduling] Use ScopedTaskEnvironment instead of MessageLoop in desktop_session_duration MessageLoop will go away, eventually. BUG=891670 Change-Id: I6a207851ffb142d42ee5d60b6092b24440b59148 Reviewed-on: https://chromium-review.googlesource.com/c/1415265 Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#624059}
Changed files
- chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker_unittest.cc
-
Reland "Use bigger tab view under accessibility font size."
Changed by Yi Su - mrsuyiohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 10:25:40 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 19dec234c20e988961baa980f1ffacf05fe436ed Comments
Reland "Use bigger tab view under accessibility font size." This is a reland of 845594fab3d16176e416a25a65b9b9d5490effef Original change's description: > Use bigger tab view under accessibility font size. > > This CL adjusts the size of tab views and height of their titles in tab > grid under accessibility font size. Title will be displayed in 2 lines > when accessibility font size is chosen. > > Screen shots: > iPhoneXR: https://drive.google.com/open?id=1anVBsA3cOBumUqt38OpM6FtprLBFfup5 > > iPad landscape: > 50%: https://drive.google.com/open?id=1E9m9Viqhval_l9Est8U1-sQktI7c_38l > 66%: https://drive.google.com/open?id=1GuXD-miJgBPL3FnhlSRLoDrKMFa9xv0w > 100%: https://drive.google.com/open?id=1jiAutUdf-wcACcckxtFbJFmS_S-2f7t2 > > iPad Portrait: > 40%: https://drive.google.com/open?id=1A9WsE-_vT0kdzuAhEDNQH-UQtVqLGF53 > 60%: https://drive.google.com/open?id=1CR-holR-9JcuvMBjadrzWjcoDFuaJU4i > 100%: https://drive.google.com/open?id=1k8BCFtqKavozdpoihA7tYg3PT7ho7Eo7 > > Bug: 893540 > Change-Id: I314d081439909cf6f3711d06df579c73a9685e99 > Reviewed-on: https://chromium-review.googlesource.com/c/1409546 > Reviewed-by: edchin <edchin@chromium.org> > Commit-Queue: Yi Su <mrsuyi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#623172} Bug: 893540 Change-Id: Idfdd3a9cee1fce3a7dc092ba967f9be3859edee5 Reviewed-on: https://chromium-review.googlesource.com/c/1419842 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#624058}
Changed files
- ios/chrome/browser/ui/tab_grid/grid/grid_cell.mm
- ios/chrome/browser/ui/tab_grid/grid/grid_constants.h
- ios/chrome/browser/ui/tab_grid/grid/grid_constants.mm
- ios/chrome/browser/ui/tab_grid/grid/grid_layout.mm
- ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm
-
[scheduling] Use ScopedTaskEnvironment instead of MessageLoop in browser/net
Changed by Carlos Caballero - carlscabohnoyoudont@google.com Changed at Friday, 18-Jan-19 10:25:15 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f9b03d9c97bb378144d96c8f7c18a708150e8b80 Comments
[scheduling] Use ScopedTaskEnvironment instead of MessageLoop in browser/net MessageLoop will go away, eventually. BUG=891670 Change-Id: I0310928c4f3ff490f684c1ed46acd0154bc0b396 Reviewed-on: https://chromium-review.googlesource.com/c/1417454 Reviewed-by: Asanka Herath <asanka@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#624057}
Changed files
- chrome/browser/net/quota_policy_channel_id_store_unittest.cc
-
ServiceWorker: Make FromWebServiceWorkerNetworkProvider() available for workers
Changed by Hiroki Nakagawa - nhirokiohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 10:24:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7a09c7c9b43bcdb9d0cb1c84439e3061cab1bbbc Comments
ServiceWorker: Make FromWebServiceWorkerNetworkProvider() available for workers FromWebServiceWorkerNetworkProvider takes WebServiceWorkerNetworkProvider as an argument. Before this CL, contrary to the function name, the function implicitly assumes the given network provider is WebServiceWorkerNetworkProviderImplForFrame. This seems confusing. Actually, in the previous CL[1], I used it with WebServiceWorkerNetworkProviderImplForWorker in EmbeddedSharedWorkerStub, and it resulted in type conversion failures from ImplForWorker to ImplForFrame on static_cast. To fix it, this CL introduces WebServiceWorkerNetworkProviderBaseImpl as the base class of both ProviderImplForFrame and ProviderImplForWorker, and makes FromWebServiceWorkerNetworkProvider() take the base class as the argument. Also, this CL moves some common functions from the derived classes to the base class. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1405123 Bug: 906991, 922077 Change-Id: I7f95d41457dc5f68e15b5676fe79f2755d27176a Reviewed-on: https://chromium-review.googlesource.com/c/1420157 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#624056}
Changed files
- content/renderer/BUILD.gn
- content/renderer/service_worker/service_worker_network_provider.cc
- content/renderer/service_worker/service_worker_network_provider.h
- content/renderer/service_worker/web_service_worker_network_provider_base_impl.cc
- content/renderer/service_worker/web_service_worker_network_provider_base_impl.h
- content/renderer/shared_worker/web_service_worker_network_provider_impl_for_worker.cc
- content/renderer/shared_worker/web_service_worker_network_provider_impl_for_worker.h
-
Use install_attributes.proto from system_api
Changed by Lutz Justen - ljustenohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 10:09:53 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b0afc521fa85f664f3de0d2c13a99990c4944097 Comments
Use install_attributes.proto from system_api Gets rid of Chrome's own copy of install_attributes.proto and uses the one from system_api instead, which was recently moved there by CL:1402785. BUG=chromium:775087 TEST=Tryjobs Change-Id: I5e9166eaee380d9f0e47c3312f4f19cb4ef62d72 Reviewed-on: https://chromium-review.googlesource.com/c/1402876 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by: Sergey Poromov <poromov@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#624055}
Changed files
- chromeos/dbus/BUILD.gn
- chromeos/dbus/fake_cryptohome_client.cc
- chromeos/tpm/install_attributes.cc
- chromeos/tpm/install_attributes_unittest.cc
- components/policy/proto/BUILD.gn
- components/policy/proto/install_attributes.proto
-
Convert //chromeos/services/assistant/service.cc to use identity::ScopeSet
Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com Changed at Friday, 18-Jan-19 10:07:26 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision aacb4fc1f524ade63567c41f4cf4515df22971c8 Comments
Convert //chromeos/services/assistant/service.cc to use identity::ScopeSet This allows removing a dependency on oauth2_token_service.h. Bug: 921613 Change-Id: I0470d54b30af8c481784dd37902a8485bf8c2b52 Reviewed-on: https://chromium-review.googlesource.com/c/1412030 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#624054}
Changed files
- chromeos/services/assistant/service.cc
-
Roll src/third_party/angle 5fe7c5b92642..85ca189542cd (2 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Friday, 18-Jan-19 10:05:23 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 654005b07abda6494c739ceae240a975e2365327 Comments
Roll src/third_party/angle 5fe7c5b92642..85ca189542cd (2 commits) https://chromium.googlesource.com/angle/angle.git/+log/5fe7c5b92642..85ca189542cd git log 5fe7c5b92642..85ca189542cd --date=short --no-merges --format='%ad %ae %s' 2019-01-18 jmadill@chromium.org Vulkan: Store reference to context command buffer. 2019-01-18 cwallez@chromium.org Suppress test crashing on Mac ASAN. Created with: gclient setdep -r src/third_party/angle@85ca189542cd The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I32b31cea25f4d155cabb651f586bfd9d1edd9fa3 Reviewed-on: https://chromium-review.googlesource.com/c/1420657 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624053}
Changed files
- DEPS
-
s13n: Eliminate per_user_topic_registration_request.h's include of oauth2_token_service.h
Changed by Gyuyoung Kim - gyuyoungohnoyoudont@igalia.com Changed at Friday, 18-Jan-19 09:59:55 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a0b12748b8f7c9bf3f6cbab89d6bd903c92ed406 Comments
s13n: Eliminate per_user_topic_registration_request.h's include of oauth2_token_service.h Clean up oauth2-token-service-related code in per_user_topic_registration_request.h because there are no uses of OAuth2TokenService. Bug: 921614 Change-Id: If8e010843984cc5c70f5aa96be1c576081a78b9f Reviewed-on: https://chromium-review.googlesource.com/c/1414250 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#624052}
Changed files
- components/invalidation/impl/per_user_topic_registration_request.h
-
Revert "build: Default use_lld to true on ChromeOS for x64"
Changed by Takashi Sakamoto - tasakohnoyoudont@google.com Changed at Friday, 18-Jan-19 09:41:10 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 21092a421cede9e75d24044c840b99c2924d0c5a Comments
Revert "build: Default use_lld to true on ChromeOS for x64" This reverts commit 3c031af060bbdfd54b16442b7891e7237768586a. Reason for revert: suspect compile failure on chromium.chrome/Google Chrome ChromeOS https://logs.chromium.org/logs/chromium/bb/chromium.chrome/Google_Chrome_ChromeOS/60740/+/recipes/steps/compile/0/stdout ld.lld: error: found local symbol '__bss_start' in global part of symbol table in file libassistant.so ld.lld: error: found local symbol '_end' in global part of symbol table in file libassistant.so ld.lld: error: found local symbol '_edata' in global part of symbol table in file libassistant.so ld.lld: error: found local symbol '__stop_malloc_hook' in global part of symbol table in file libassistant.so ld.lld: error: found local symbol '__start_malloc_hook' in global part of symbol table in file libassistant.so clang: error: linker command failed with exit code 1 (use -v to see invocation) Original change's description: > build: Default use_lld to true on ChromeOS for x64 > > This is a partial reland of 12b1bbff0b65f333ea2fa270259412cacbe056c3 > > I confirmed current lld can link chrome with the same config of previously failed build. > https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59619 > > Original change's description: > > build: Default use_lld to true on ChromeOS. > > > > As of https://chromium-review.googlesource.com/c/1372768 ChromeOS > > chrome is always linked with lld. Because ChromeOS's build system > > always overrides the value of use_lld this change should have no > > effect on official ChromeOS builds, but it should make ChromeOS on > > Linux more consistent with "real" ChromeOS. > > > > Bug: 701659 > > Change-Id: I447e1b2dfb6cc970f2c2dd64d396b5ba58bc2ef2 > > Reviewed-on: https://chromium-review.googlesource.com/c/1377139 > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#616485} > > Bug: 701659, 923168, 917504 > Change-Id: Iedb48cfe5b3b9c189dcf1b4c04bea998ee009d2c > Reviewed-on: https://chromium-review.googlesource.com/c/1419558 > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: George Burgess <gbiv@chromium.org> > Commit-Queue: George Burgess <gbiv@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624005} TBR=thakis@chromium.org,pcc@chromium.org,gbiv@chromium.org,tikuta@chromium.org Change-Id: Ieba8a5113b944ef03f954388ebb076ff546fdd08 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 701659, 923168, 917504 Reviewed-on: https://chromium-review.googlesource.com/c/1420493 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#624051}
Changed files
- build/config/compiler/compiler.gni
-
Mark RTCDTMFSender-ontonechange flaky on all platforms.
Changed by Henrik Boström - hbosohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 09:34:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 37fb313b36682f925bd3189b3faf04e78d0dc46e Comments
Mark RTCDTMFSender-ontonechange flaky on all platforms. TBR=hta@chromium.org NOTRY=True Bug: 923244 Change-Id: I6d06dc1bd21e4254e1882a13e04520593b8893f9 Reviewed-on: https://chromium-review.googlesource.com/c/1420797 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#624050}
Changed files
- third_party/blink/web_tests/TestExpectations
-
OOR-CORS: PreflightController can receive null head.headers
Changed by Takashi Toyoshima - toyoshimohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 09:33:57 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c208a22fee4a72a555b5eefcfdf8d152476ec2db Comments
OOR-CORS: PreflightController can receive null head.headers For some special cases, head.headers can contain nullptr. E.g. when ftp is specified though it should not be the case on making CORS-preflight request. Anyway, it should have a null check before calling GetNormalizedHeader. This happens only when the OOR-CORS experiment is enabled on making such a special URL request. Bug: 919515 Change-Id: I4e0b330fcb7eaa2c6ef276df189eeeb173647711 Reviewed-on: https://chromium-review.googlesource.com/c/1420480 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#624049}
Changed files
- services/network/cors/preflight_controller.cc
-
Roll src/third_party/chromite 5cfe5f2c7b78..cec40a962e60 (5 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Friday, 18-Jan-19 09:31:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a78b7d2cfea431ae8f75e08cb9929fd6115e7ad5 Comments
Roll src/third_party/chromite 5cfe5f2c7b78..cec40a962e60 (5 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/5cfe5f2c7b78..cec40a962e60 git log 5cfe5f2c7b78..cec40a962e60 --date=short --no-merges --format='%ad %ae %s' 2019-01-18 mikenichols@chromium.org repository.py: Add FetchAll function 2019-01-18 selcott@google.com PFQ builder for android-vm-pi 2019-01-18 ahassani@chromium.org paygen: Use gspaths.Build as a variable for all Images 2019-01-18 ahassani@chromium.org build_dlc: Change the root directory of dlc contents 2019-01-18 ahassani@chromium.org build_dlc: Fix building DLC with squashfs type Created with: gclient setdep -r src/third_party/chromite@cec40a962e60 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I372eac8685231ca9480c624ac9a41f70367efb0b Reviewed-on: https://chromium-review.googlesource.com/c/1420320 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624048}
Changed files
- DEPS
-
Convert SigninBrowserStateInfoUpdater to use IdentityManager
Changed by Henrique Ferreiro - hferreiroohnoyoudont@igalia.com Changed at Friday, 18-Jan-19 09:20:09 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 05f73c05e6a6ff45f9860306782d3236bec9c6da Comments
Convert SigninBrowserStateInfoUpdater to use IdentityManager Migrate the class from using SigninManager by using the corresponding callbacks from IdentityManager. Bug: 913895 Change-Id: I94b765ebfa804729ce3e54edffc555cc45b9ef05 Reviewed-on: https://chromium-review.googlesource.com/c/1415553 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#624047}
Changed files
- ios/chrome/browser/signin/signin_browser_state_info_updater.h
- ios/chrome/browser/signin/signin_browser_state_info_updater.mm
- ios/chrome/browser/signin/signin_browser_state_info_updater_factory.mm
-
Roll src/third_party/breakpad/breakpad/ 54fa71efb..9b06049ed (9 commits)
Changed by Andreas Haas - ahaasohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 09:14:17 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b3ee3f4e6a5ae45f0f32032c14129986a85a2a87 Comments
Roll src/third_party/breakpad/breakpad/ 54fa71efb..9b06049ed (9 commits) https://chromium.googlesource.com/breakpad/breakpad.git/+log/54fa71efbe50..9b06049ed9fd $ git log 54fa71efb..9b06049ed --date=short --no-merges --format='%ad %ae %s' 2019-01-15 ahaas Introduce SetFirstChanceHandler with more strict signature 2019-01-02 Tom.Tan Extract intruction pointer correctly for Windows ARM64 2018-12-06 vapier support mistaken-pull-closer for automatically clearing incoming PRs 2018-11-26 jperaza Conditionally define BPLOG_LAZY_STREAM 2018-11-26 jperaza Add mac dump_syms support for arm64e 2018-11-26 jperaza fix dump_syms xcode project 2018-11-13 ludovic.guegan Skip empty DWARF code range when mapping lines 2018-10-12 jperaza Conditionally define BPLOG_IF 2018-10-04 bernsteine Adds method to get the date of the most recent iOS crash report. Created with: roll-dep src/third_party/breakpad/breakpad R=mark@chromium.org Bug: chromium:921971 Change-Id: I138f72cc98a7b1ad25837bbaeeff2f29585cfefe Reviewed-on: https://chromium-review.googlesource.com/c/1416141 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#624046}
Changed files
- DEPS
-
Do not implicitly depend on libsrtp and usrsctp.
Changed by Mirko Bonadei - mbonadeiohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 09:10:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ee9c96f1fb4360e53ac7287ba9c30ea8cbb54394 Comments
Do not implicitly depend on libsrtp and usrsctp. When //third_party/webrtc_overrides:init_webrtc is compiled for PNaCl, these dependencies break the build because some system headers are not available. This CL removes them because they are not direct dependencies and other built targets should not rely on these implicit and transitive dependencies to resolve symbols at link time. Bug: 896154 Change-Id: I1c40d90076e870c391f3c3b0a964cb9a3e827cf0 Reviewed-on: https://chromium-review.googlesource.com/c/1419338 Reviewed-by: Tommi <tommi@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#624045}
Changed files
- third_party/webrtc_overrides/BUILD.gn
-
SignedExchange: Move StructuredHeaderParser to separate file
Changed by Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 09:07:13 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 364f859e78bfc4518da481d889107ff732f69cfb Comments
SignedExchange: Move StructuredHeaderParser to separate file This will be used to parse Variants / Variant-Key header too. Bug: 923229 Change-Id: I69e90e977a1838a942aaeb59d58c7142da8d43f4 Reviewed-on: https://chromium-review.googlesource.com/c/1415062 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#624044}
Changed files
- content/browser/BUILD.gn
- content/browser/web_package/http_structured_header.cc
- content/browser/web_package/http_structured_header.h
- content/browser/web_package/signed_exchange_signature_header_field.cc
-
[Downloads] Remove WebUIMessageHandler superclass from Mojo Handler.
Changed by Christopher Lam - calamityohnoyoudont@chromium.org Changed at Friday, 18-Jan-19 09:04:31 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d41bc2dfbc94bffd9a8e6888f4130cfa9b9811cd Comments
[Downloads] Remove WebUIMessageHandler superclass from Mojo Handler. Since MdDownloadsDOMHandler is a Mojo PageHandler now, it doesn't need the WebUIMessageHandler superclass. It was previously left for DisallowJavascript() calls, but that only gets called on WebUI-destroying events anyway. So the corresponding code has been moved into the destructor. Bug: 849993 Change-Id: I97e07b68a902529f37b9847309afbeb9ea3584cf Reviewed-on: https://chromium-review.googlesource.com/c/1409671 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#624043}
Changed files
- chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc
- chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.h
- chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc