Builder Linux FYI Release (AMD R7 240) Build 2739

Results:

Success

Trigger Info:

Project	chromium
Revision	8d6fa22a684af68862a75cf0a3ed280174b96b6f
Got Revision	8d6fa22a684af68862a75cf0a3ed280174b96b6f

Execution:

• Source: Task 42736e175560dc10
• Bot: swarm1080-c4
• Recipe: chromium

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 343 ms ) setup_build

   running recipe: "chromium"
   • stdout
   • run_recipe
2. ( 220 ms ) report builders

    

   running tester 'Linux FYI Release (AMD R7 240)' on master 'chromium.gpu.fyi'
   • stdout
   • bots.json
3. ( 54 secs ) bot_update

   [48GB/295GB used (16%)]
   • stdout
   • json.output
4. ( 144 ms ) ensure_goma
   • - no logs -
   1. ( 144 ms ) ensure_installed
      • stdout
      • json.output
5. ( 582 ms ) swarming.py --version

   0.14
   • stdout
6. ( 11 secs ) gclient runhooks
   • stdout
7. ( 2 secs ) get compile targets for scripts
   • stdout
   • json.output
8. ( 1 secs ) read test spec (chromium.gpu.fyi.json)

   path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
   • stdout
   • json.output
9. ( 463 ms ) lookup builder GN args

    

   build_angle_gles1_conform_tests = true

   dcheck_always_on = true

   ffmpeg_branding = "Chrome"

   internal_gles2_conform_tests = true

   is_component_build = false

   is_debug = false

   proprietary_codecs = true

   strip_absolute_paths_from_debug_symbols = true

   symbol_level = 1

   use_goma = true

   goma_dir = "/b/swarming/w/ir/cache/goma/client"
   • stdout
10. ( 439 ms ) build directory
    • stdout
11. ( 427 ms ) find isolated tests
    • stdout
    • json.output
12. ( 1 secs ) test_pre_run
    • - no logs -
    1. ( 1 secs ) [trigger] angle_unittests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
13. ( 140 ms ) ensure swarming
    • - no logs -
    1. ( 140 ms ) ensure_installed
       • stdout
       • json.output
14. ( 37 secs ) angle_unittests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Pending time: 11s

    Shard duration: 22s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (16.9 sec)
15. ( 2 secs ) Upload to test-results [angle_unittests on ATI GPU on Linux on Ubuntu]
    • stdout
16. ( 1 secs ) test_pre_run (2)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] angle_white_box_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
17. ( 13 secs ) angle_white_box_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 7s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (3.3 sec)
18. ( 1 secs ) Upload to test-results [angle_white_box_tests on ATI GPU on Linux on Ubuntu]
    • stdout
19. ( 1 secs ) test_pre_run (3)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] tab_capture_end2end_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
20. ( 25 secs ) tab_capture_end2end_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 22s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (7.4 sec)
21. ( 2 secs ) Upload to test-results [tab_capture_end2end_tests on ATI GPU on Linux on Ubuntu]
    • stdout
22. ( 1 secs ) test_pre_run (4)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] gl_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
23. ( 16 secs ) gl_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 14s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (9.8 sec)
24. ( 1 secs ) Upload to test-results [gl_tests on ATI GPU on Linux on Ubuntu]
    • stdout
25. ( 1 secs ) test_pre_run (5)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] gles2_conform_test on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
26. ( 40 secs ) gles2_conform_test on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 38s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (33.1 sec)
27. ( 1 secs ) Upload to test-results [gles2_conform_test on ATI GPU on Linux on Ubuntu]
    • stdout
28. ( 1 secs ) test_pre_run (6)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] swiftshader_unittests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
29. ( 1 secs ) swiftshader_unittests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 5s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (0.8 sec) (deduped)
30. ( 1 secs ) Upload to test-results [swiftshader_unittests on ATI GPU on Linux on Ubuntu]
    • stdout
31. ( 1 secs ) test_pre_run (7)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] context_lost_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
32. ( 3 mins 17 secs ) context_lost_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 0:03:11.706225

    Total tests: 10

    * Passed: 10 (10 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (179.1 sec)
33. ( 4 secs ) Upload to test-results [context_lost_tests on ATI GPU on Linux]
    • stdout
34. ( 907 ms ) test_pre_run (8)
    • - no logs -
    1. ( 907 ms ) test_pre_run.[trigger] depth_capture_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
35. ( 31 secs ) depth_capture_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 24s

    Total tests: 3

    * Passed: 3 (3 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (17.8 sec)
36. ( 1 secs ) Upload to test-results [depth_capture_tests on ATI GPU on Linux]
    • stdout
37. ( 951 ms ) test_pre_run (9)
    • - no logs -
    1. ( 951 ms ) test_pre_run.[trigger] gpu_process_launch_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
38. ( 2 mins 56 secs ) gpu_process_launch_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 0:02:50.959183

    Total tests: 15

    * Passed: 15 (15 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (164.2 sec)
39. ( 1 secs ) Upload to test-results [gpu_process_launch_tests on ATI GPU on Linux]
    • stdout
40. ( 959 ms ) test_pre_run (10)
    • - no logs -
    1. ( 959 ms ) test_pre_run.[trigger] hardware_accelerated_feature_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
41. ( 25 secs ) hardware_accelerated_feature_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 21s

    Total tests: 2

    * Passed: 2 (2 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (15.6 sec)
42. ( 1 secs ) Upload to test-results [hardware_accelerated_feature_tests on ATI GPU on Linux]
    • stdout
43. ( 1 secs ) test_pre_run (11)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] info_collection_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
44. ( 23 secs ) info_collection_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 21s

    Total tests: 1

    * Passed: 1 (1 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (15.2 sec)
45. ( 2 secs ) Upload to test-results [info_collection_tests on ATI GPU on Linux]
    • stdout
46. ( 845 ms ) test_pre_run (12)
    • - no logs -
    1. ( 845 ms ) test_pre_run.[trigger] maps_pixel_test on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
47. ( 35 secs ) maps_pixel_test on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 31s

    Total tests: 1

    * Passed: 1 (1 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (25.9 sec)
48. ( 1 secs ) Upload to test-results [maps_pixel_test on ATI GPU on Linux]
    • stdout
49. ( 1 secs ) test_pre_run (13)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] pixel_test on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
50. ( 9 mins 21 secs ) pixel_test on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 0:09:10.276257

    Total tests: 49

    * Passed: 49 (49 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (543.4 sec)
51. ( 19 secs ) Upload to test-results [pixel_test on ATI GPU on Linux]
    • stdout
52. ( 964 ms ) test_pre_run (14)
    • - no logs -
    1. ( 964 ms ) test_pre_run.[trigger] screenshot_sync_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
53. ( 1 mins 21 secs ) screenshot_sync_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 0:01:12.555733

    Total tests: 4

    * Passed: 4 (4 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (65.8 sec)
54. ( 1 secs ) Upload to test-results [screenshot_sync_tests on ATI GPU on Linux]
    • stdout
55. ( 1 secs ) test_pre_run (15)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] trace_test on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
56. ( 4 mins 36 secs ) trace_test on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 0:04:32.158312

    Total tests: 48

    * Passed: 24 (24 expected, 0 unexpected)

    * Skipped: 24 (24 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (265.5 sec)
57. ( 1 secs ) Upload to test-results [trace_test on ATI GPU on Linux]
    • stdout
58. ( 8 secs ) test_pre_run (16)
    • - no logs -
    1. ( 8 secs ) test_pre_run.[trigger] webgl2_conformance_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
       • shard #1
       • shard #2
       • shard #3
       • shard #4
       • shard #5
       • shard #6
       • shard #7
       • shard #8
       • shard #9
       • shard #10
       • shard #11
       • shard #12
       • shard #13
       • shard #14
       • shard #15
       • shard #16
       • shard #17
       • shard #18
       • shard #19
59. ( 2 hrs 6 mins ) webgl2_conformance_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Max pending time: 1:59:32.408315 (shard #19)

    Max shard duration: 0:06:56.825019 (shard #18)

    Min shard duration: 0:05:25.023791 (shard #7)

    Total tests: 2803

    * Passed: 2735 (2735 expected, 0 unexpected)

    * Skipped: 68 (68 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (371.6 sec)
    • shard #1 isolated out
    • shard #1 (338.4 sec)
    • shard #2 isolated out
    • shard #2 (341.8 sec)
    • shard #3 isolated out
    • shard #3 (366.5 sec)
    • shard #4 isolated out
    • shard #4 (407.0 sec)
    • shard #5 isolated out
    • shard #5 (407.4 sec)
    • shard #6 isolated out
    • shard #6 (401.2 sec)
    • shard #7 isolated out
    • shard #7 (318.2 sec)
    • shard #8 isolated out
    • shard #8 (375.2 sec)
    • shard #9 isolated out
    • shard #9 (352.3 sec)
    • shard #10 isolated out
    • shard #10 (406.6 sec)
    • shard #11 isolated out
    • shard #11 (364.7 sec)
    • shard #12 isolated out
    • shard #12 (390.3 sec)
    • shard #13 isolated out
    • shard #13 (330.2 sec)
    • shard #14 isolated out
    • shard #14 (321.4 sec)
    • shard #15 isolated out
    • shard #15 (386.5 sec)
    • shard #16 isolated out
    • shard #16 (381.6 sec)
    • shard #17 isolated out
    • shard #17 (348.5 sec)
    • shard #18 isolated out
    • shard #18 (410.1 sec)
    • shard #19 isolated out
    • shard #19 (394.1 sec)
60. ( 1 secs ) Upload to test-results [webgl2_conformance_tests on ATI GPU on Linux]
    • stdout
61. ( 1 secs ) test_pre_run (17)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] webgl_conformance_gl_passthrough_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
       • shard #1
62. ( 10 mins 46 secs ) webgl_conformance_gl_passthrough_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Max pending time: 0:04:10.392126 (shard #1)

    Max shard duration: 0:06:18.341626 (shard #1)

    Min shard duration: 0:02:16.990034 (shard #0)

    Total tests: 938

    * Passed: 932 (932 expected, 0 unexpected)

    * Skipped: 6 (6 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (129.7 sec)
    • shard #1 isolated out
    • shard #1 (372.0 sec)
63. ( 2 secs ) Upload to test-results [webgl_conformance_gl_passthrough_tests on ATI GPU on Linux]
    • stdout
64. ( 1 secs ) test_pre_run (18)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] webgl_conformance_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
       • shard #1
65. ( 9 mins 18 secs ) webgl_conformance_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Max pending time: 0:02:21.916189 (shard #1)

    Max shard duration: 0:06:47.533153 (shard #1)

    Min shard duration: 0:02:14.252398 (shard #0)

    Total tests: 938

    * Passed: 932 (932 expected, 0 unexpected)

    * Skipped: 6 (6 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (127.7 sec)
    • shard #1 isolated out
    • shard #1 (400.4 sec)
66. ( 1 secs ) Upload to test-results [webgl_conformance_tests on ATI GPU on Linux]
    • stdout
67. ( 2 secs ) Tests statistics

     

    Stats

    Total shards: 39

    Total runtime: 2:43:27.254557

     
    • stdout
    • detailed stats
68. ( 1 ms ) recipe result
    • result

Build Properties:

Name	Value	Source
$recipe_engine/path	{"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"swarm1080-c4"	setup_build
buildbucket	{"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547708435701333, "id": "8924103795284528064", "project": "chromium", "tags": ["builder:Linux FYI Release (AMD R7 240)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/8d6fa22a684af68862a75cf0a3ed280174b96b6f", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Linux Builder", "parent_buildnumber:39481", "scheduler_invocation_id:9089533857501492544", "scheduler_job_id:chromium/Linux FYI Release (AMD R7 240)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"Linux FYI Release (AMD R7 240)"	setup_build
buildnumber	2739	setup_build
mastername	"chromium.gpu.fyi"	setup_build
parent_buildername	"GPU FYI Linux Builder"	setup_build
parent_got_angle_revision	"94d8a9a445bef9b7978f513f7f8d449696716296"	setup_build
parent_got_buildtools_revision	"40194ab03962d8183b2796fa58a39ec8a9e83a41"	setup_build
parent_got_dawn_revision	"799cddcb83fda2911491fd653023c38a28bba1bd"	setup_build
parent_got_nacl_revision	"ff15c51d20785fa51c0ef03ccb480b87299acbeb"	setup_build
parent_got_revision	"8d6fa22a684af68862a75cf0a3ed280174b96b6f"	setup_build
parent_got_revision_cp	"refs/heads/master@{#623607}"	setup_build
parent_got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	setup_build
parent_got_v8_revision	"80dba3f28abc5c6a81dfc45d745eb4746aabce8c"	setup_build
parent_got_v8_revision_cp	"refs/heads/7.3.427@{#1}"	setup_build
parent_got_webrtc_revision	"309aafe3513af2c53439cb0ea105a39156547acb"	setup_build
parent_got_webrtc_revision_cp	"refs/heads/master@{#26282}"	setup_build
parent_mastername	"chromium.gpu.fyi"	setup_build
path_config	"generic"	setup_build
recipe	"chromium"	setup_build
revision	"8d6fa22a684af68862a75cf0a3ed280174b96b6f"	setup_build
swarm_hashes	{"angle_end2end_tests": "5e68603b7ec7877b04edcaab792d8b03a3163086", "angle_perftests": "e2533f9c4b9ff4edc73fbd66384369d2fce64495", "angle_unittests": "885724078cd2f78781798321d0f2372ad1b9435b", "angle_white_box_tests": "ceefecaebc28e5308a32217ac661e40c7f25bab8", "browser_tests": "a500d624776ec0cf3d4d067122aec84977b4b1e6", "dawn_end2end_tests": "e1ee912268cd5d8d450b8bd179f7f7685164d79a", "gl_tests": "f8452b0fe8c4cffafb9eaedf38c2f9bf2214b345", "gl_unittests": "1772c543e01f0256afaa326aa481c6ddbd5485ab", "gles2_conform_test": "5c241488d9c742eff3a5a874215a2bcd81863eb4", "swiftshader_unittests": "84fa6663a1dd12e99764c625b2718c6c9b2f6e00", "telemetry_gpu_integration_test": "5c19bd7be5862796e08498e3fa10fe37b7015d34"}	setup_build
got_angle_revision	"94d8a9a445bef9b7978f513f7f8d449696716296"	bot_update
got_buildtools_revision	"40194ab03962d8183b2796fa58a39ec8a9e83a41"	bot_update
got_dawn_revision	"799cddcb83fda2911491fd653023c38a28bba1bd"	bot_update
got_nacl_revision	"ff15c51d20785fa51c0ef03ccb480b87299acbeb"	bot_update
got_revision	"8d6fa22a684af68862a75cf0a3ed280174b96b6f"	bot_update
got_revision_cp	"refs/heads/master@{#623607}"	bot_update
got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	bot_update
got_v8_revision	"80dba3f28abc5c6a81dfc45d745eb4746aabce8c"	bot_update
got_v8_revision_cp	"refs/heads/7.3.427@{#1}"	bot_update
got_webrtc_revision	"309aafe3513af2c53439cb0ea105a39156547acb"	bot_update
got_webrtc_revision_cp	"refs/heads/master@{#26282}"	bot_update
swarm_hashes	{}	find isolated tests

Blamelist:

1. Trent Apted (taptedohnoyoudont@chromium.org)
2. Christopher Cameron (ccameronohnoyoudont@chromium.org)
3. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
4. Kouhei Ueno (kouheiohnoyoudont@chromium.org)
5. Findit (findit-for-meohnoyoudont@appspot.gserviceaccount.com)
6. Trent Apted (taptedohnoyoudont@chromium.org)
7. Kevin Marshall (kmarshallohnoyoudont@chromium.org)
8. Moja Hsu (mojahsuohnoyoudont@google.com)
9. Kent Tamura (tkentohnoyoudont@chromium.org)
10. Christopher Lam (calamityohnoyoudont@chromium.org)
11. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
12. Richard Li (richard.liohnoyoudont@intel.com)
13. Kent Tamura (tkentohnoyoudont@chromium.org)
14. Matt Falkenhagen (falkenohnoyoudont@chromium.org)
15. John Abd-El-Malek (jamohnoyoudont@chromium.org)
16. Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
17. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
18. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
19. Peter Kasting (pkastingohnoyoudont@chromium.org)
20. Jun Cai (juncaiohnoyoudont@chromium.org)
21. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
22. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
23. Darren Shen (shendohnoyoudont@chromium.org)
24. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
25. Yuki Shiino (yukishiinoohnoyoudont@chromium.org)
26. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
27. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
28. Maggie Chen (magchenohnoyoudont@chromium.org)
29. Kenichi Ishibashi (bashiohnoyoudont@chromium.org)
30. John Delaney (johnidelohnoyoudont@chromium.org)
31. Matt Falkenhagen (falkenohnoyoudont@chromium.org)
32. Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
33. rajendrant (rajendrantohnoyoudont@chromium.org)
34. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
35. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
36. Peter Wen (wnwenohnoyoudont@chromium.org)
37. Andrew Grieve (agrieveohnoyoudont@chromium.org)
38. chrome-release-bot (chrome-release-botohnoyoudont@chromium.org)
39. Simon Que (squeohnoyoudont@google.com)
40. rbpotter (rbpotterohnoyoudont@chromium.org)

Timing:

Create	Thursday, 17-Jan-19 07:00:35 UTC
Start	Thursday, 17-Jan-19 07:00:37 UTC
End	Thursday, 17-Jan-19 09:55:50 UTC
Pending	1 secs
Execution	2 hrs 55 mins

All Changes:

1. Delete ChromeOS's "modal" CertificateViewerModalDialog. Dead code.

   Changed by	Trent Apted - taptedohnoyoudont@chromium.org
   Changed at	Thursday, 17-Jan-19 06:22:15 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	8d6fa22a684af68862a75cf0a3ed280174b96b6f

   Comments

   Delete ChromeOS's "modal" CertificateViewerModalDialog. Dead code.
   
   CertificateViewerModalDialog declares a virtual 'Show()' method, overridden
   by its single subclass, which shows the UI as a constrained dialog. Both the
   base class and the "constrained" version define this method. However, instances
   of the base class are only instantiated in a test file. So the base class
   "Show()" method, and other methods defined and overridden, are dead code in
   the browser. Delete them, and collapse the implementation into one class.
   
   Incidentally, showing the base class triggers a memory leak, but it could only
   happen in the test code.
   
   Bug: 354644
   Change-Id: I1483eeba5bdd7ded0a2da192348bccd07f7af677
   TEST: CertificateViewerUITest.*
   Reviewed-on: https://chromium-review.googlesource.com/c/1410955
   Reviewed-by: Avi Drissman <avi@chromium.org>
   Commit-Queue: Trent Apted <tapted@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623607}

   Changed files

   • build/sanitizers/lsan_suppressions.cc
   • chrome/browser/ui/webui/certificate_viewer_ui.cc
   • chrome/browser/ui/webui/certificate_viewer_ui.h
   • chrome/browser/ui/webui/certificate_viewer_webui.cc
   • chrome/browser/ui/webui/certificate_viewer_webui.h
   • chrome/browser/ui/webui/certificates_handler.cc
   • chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
   • chrome/common/webui_url_constants.cc
   • chrome/common/webui_url_constants.h
   • chrome/test/data/webui/certificate_viewer_dialog_test.js
   • chrome/test/data/webui/certificate_viewer_ui_test-inl.h

2. AppShim: Fix race when extension is unloaded

   Changed by	Christopher Cameron - ccameronohnoyoudont@chromium.org
   Changed at	Thursday, 17-Jan-19 06:13:58 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	add9e90c4c9f78106942717c988c41ee824d598d

   Comments

   AppShim: Fix race when extension is unloaded
   
   This bug has been present in ExtensionAppShimHandler for a very long
   time, but has started appearing in the context of PWAs.
   
   If an extension is uninstalled while it is in use, then there exists a
   race in  ExtensionAppShimHandler::OnBrowserRemoved wherein may no
   longer be an extension for the Browser, causing an early out, which
   then causes two sources of badness (1) an invalid pointer hanging out
   in |app_browser_windows_| and (2) the AppShimHost won't exit.
   
   Fix the bug by doing a more thorough search through
   |app_browser_windows_|, without reference to the actual Extension
   pointer (as it may no longer exist).
   
   Bug: 921456
   Change-Id: Ica1e2c40332e932f979791478d3dac1dab2c07a6
   Reviewed-on: https://chromium-review.googlesource.com/c/1411214
   Commit-Queue: ccameron <ccameron@chromium.org>
   Reviewed-by: Dominick Ng <dominickn@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623606}

   Changed files

   • chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc

3. Roll src-internal fed3aa20d999..41f50c6b8d4a (2 commits)

   Changed by	chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
   Changed at	Thursday, 17-Jan-19 06:13:49 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	fc5778e8493b739225cf6c593e6c8c7e17cb9834

   Comments

   Roll src-internal fed3aa20d999..41f50c6b8d4a (2 commits)
   
   https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fed3aa20d999..41f50c6b8d4a
   
   
   Created with:
     gclient setdep -r src-internal@41f50c6b8d4a
   
   The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
   
   Documentation for the AutoRoller is here:
   https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
   
   If the roll is causing failures, please contact the current sheriff, who should
   be CC'd on the roll, and stop the roller if necessary.
   
   
   TBR=mmoss@chromium.org
   
   Change-Id: I16f799bf67b005dd4c194ce7ba2ea3df8c9bfbb5
   Reviewed-on: https://chromium-review.googlesource.com/c/1417275
   Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
   Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
   Cr-Commit-Position: refs/heads/master@{#623605}

   Changed files

   • DEPS

4. SignedExchange: Migrate test cases to 1b3

   Changed by	Kouhei Ueno - kouheiohnoyoudont@chromium.org
   Changed at	Thursday, 17-Jan-19 06:07:50 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	f75cedf892435f7362e1f8d1ab1d4f21743649d9

   Comments

   SignedExchange: Migrate test cases to 1b3
   
   third_party/blink/web_tests/external/wpt/signed-exchange/sxg-head-request.tentative.html
   is no longer relevant, since 1b3 no longer have request method serialized.
   The request method in a 1b3 SXG is assumed to be always GET.
   
   Bug: 919414
   Change-Id: I0f7ec3de66db70b9cc12af209b74a22a4187460c
   Reviewed-on: https://chromium-review.googlesource.com/c/1405156
   Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
   Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
   Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
   Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623604}

   Changed files

   • content/browser/web_package/signed_exchange_envelope_unittest.cc
   • content/browser/web_package/signed_exchange_handler_unittest.cc
   • content/test/data/sxg/generate-test-sxgs.sh
   • content/test/data/sxg/test.example.com_invalid_test.sxg
   • content/test/data/sxg/test.example.com_invalid_test.sxg.mock-http-headers
   • content/test/data/sxg/test.example.org_hello.txt.sxg
   • content/test/data/sxg/test.example.org_noext_test.sxg
   • content/test/data/sxg/test.example.org_test.sxg
   • content/test/data/sxg/test.example.org_test.sxg.mock-http-headers
   • content/test/data/sxg/test.example.org_test_download.sxg
   • content/test/data/sxg/test.example.org_test_download.sxg.mock-http-headers
   • content/test/data/sxg/test.example.org_test_invalid_cbor_header.sxg
   • content/test/data/sxg/test.example.org_test_invalid_cbor_header.sxg.mock-http-headers
   • content/test/data/sxg/test.example.org_test_invalid_content_type.sxg
   • content/test/data/sxg/test.example.org_test_invalid_magic_string.sxg
   • content/test/data/sxg/test.example.org_test_invalid_magic_string.sxg.mock-http-headers
   • content/test/data/sxg/test.example.org_test_missing_nosniff.sxg
   • content/test/data/sxg/test.example.org_test_missing_nosniff.sxg.mock-http-headers
   • third_party/blink/web_tests/external/wpt/signed-exchange/resources/generate-test-sxgs.sh
   • third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/__dir__.headers
   • third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/check-cert-request.sxg
   • third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/fallback-to-another-sxg.sxg
   • third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/nested-sxg.sxg
   • third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/sxg-head-request.sxg
   • third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/sxg-inner-url-bom.sxg
   • third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/sxg-invalid-utf8-inner-url.sxg
   • third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/sxg-invalid-validity-url.sxg
   • third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/sxg-location.sxg
   • third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/sxg-noncacheable.sxg
   • third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg/sxg-utf8-inner-url.sxg
   • third_party/blink/web_tests/external/wpt/signed-exchange/sxg-head-request.tentative.html

5. Revert "LazyLoad: Fix deferred loading of CSS background images"

   Changed by	Findit - findit-for-meohnoyoudont@appspot.gserviceaccount.com
   Changed at	Thursday, 17-Jan-19 05:55:09 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	1d1fee8b5059cbfc044d6028cff20fb6a3020511

   Comments

   Revert "LazyLoad: Fix deferred loading of CSS background images"
   
   This reverts commit 884d05298198751cbf2fc527181a98404f45884b.
   
   Reason for revert:
   
   Findit (https://goo.gl/kROfz5) identified CL at revision 623575 as the
   culprit for failures in the build cycles as shown on:
   https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzg4NGQwNTI5ODE5ODc1MWNiZjJmYzUyNzE4MWE5ODQwNGY0NTg4NGIM
   
   Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/47077
   
   Sample Failed Step: browser_tests
   
   Original change's description:
   > LazyLoad: Fix deferred loading of CSS background images
   > 
   > kDeferImageLoad bit is not set in the FetchParameters when CSS background
   > images need to be deferred. This CL fixes that, and also adds a browser
   > test.
   > 
   > Bug: 920899
   > Change-Id: I4d96d63c1bba2d2a0892e1b84ae364f29f53c152
   > Reviewed-on: https://chromium-review.googlesource.com/c/1405592
   > Reviewed-by: Nate Chapin <japhet@chromium.org>
   > Reviewed-by: Rune Lillesveen <futhark@chromium.org>
   > Commit-Queue: rajendrant <rajendrant@chromium.org>
   > Cr-Commit-Position: refs/heads/master@{#623575}
   
   Change-Id: Ib129c2f7b13b742a10a48e3b6deaa5e8de707780
   No-Presubmit: true
   No-Tree-Checks: true
   No-Try: true
   Bug: 920899
   Reviewed-on: https://chromium-review.googlesource.com/c/1416878
   Cr-Commit-Position: refs/heads/master@{#623603}

   Changed files

   • chrome/browser/previews/lazyload_browsertest.cc
   • chrome/test/BUILD.gn
   • chrome/test/data/lazyload/css-background-image.html
   • chrome/test/data/lazyload/images/fruit1.jpg
   • chrome/test/data/lazyload/images/fruit2.jpg
   • third_party/blink/renderer/core/BUILD.gn
   • third_party/blink/renderer/core/css/css_image_value.cc
   • third_party/blink/renderer/core/html/lazy_load_image_observer_test.cc
   • third_party/blink/renderer/platform/loader/fetch/fetch_parameters.cc
   • third_party/blink/renderer/platform/loader/fetch/fetch_parameters.h

6. Remove tapted from app_shortcuts watchlist.

   Changed by	Trent Apted - taptedohnoyoudont@chromium.org
   Changed at	Thursday, 17-Jan-19 05:49:53 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	abfd257c64e3052a02a4263b96f0c6ba49579e02

   Comments

   Remove tapted from app_shortcuts watchlist.
   
   Change-Id: Ib5d5ecab995de44ab0868ef44f91c5f4f39238e8
   Reviewed-on: https://chromium-review.googlesource.com/c/1415611
   Reviewed-by: Dominick Ng <dominickn@chromium.org>
   Commit-Queue: Trent Apted <tapted@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623602}

   Changed files

   • WATCHLISTS

7. [fuchsia] Implement Cast Channel API using Connector/MessagePort.

   Changed by	Kevin Marshall - kmarshallohnoyoudont@chromium.org
   Changed at	Thursday, 17-Jan-19 05:38:25 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	dfd6eedb468f73fc55e28f02dad2c59a594ab03f

   Comments

   [fuchsia] Implement Cast Channel API using Connector/MessagePort.
   
   Add a Cast Channel FIDL service, which bridges FIDL clients and the JS
   cast.__platform__.channel API.
   
   Injects cast.__platform__.channel to the document scripting context.
   The Cast Channel can be opened, written to, and closed by JS.
   The C++ side can write messages to an opened Channel.
   
   Modify OnLoadScriptInjector to use to page commit events as a trigger
   for script injection instead of DidClearWindowObject(). Page commits
   are guaranteed to occur only once per page load, which is a more useful
   event than window object clearing, which happens once for an initial
   page load, and then twice for all subsequent navigations.
   
   Enable "castrunner_browsertests" suite for testing bots.
   
   Actual integration into the Cast Runner will take place in a followup
   CL.
   
   Bug: 910799
   Change-Id: Ie7abdb22b5ed61b62fbbfceac9e466c8d36f10f6
   Reviewed-on: https://chromium-review.googlesource.com/c/1357719
   Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
   Reviewed-by: Wez <wez@chromium.org>
   Reviewed-by: John Budorick <jbudorick@chromium.org>
   Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623601}

   Changed files

   • testing/buildbot/chromium.fyi.json
   • testing/buildbot/gn_isolate_map.pyl
   • testing/buildbot/test_suite_exceptions.pyl
   • testing/buildbot/test_suites.pyl
   • webrunner/BUILD.gn
   • webrunner/app/cast/bindings/cast_channel.cc
   • webrunner/app/cast/bindings/cast_channel.h
   • webrunner/app/cast/bindings/cast_channel.js
   • webrunner/app/cast/bindings/cast_channel_browsertest.cc
   • webrunner/app/cast/test/data/cast_channel.html
   • webrunner/app/cast/test/data/cast_channel_reconnect.html
   • webrunner/common/named_message_port_connector.js
   • webrunner/fidl/cast/cast_channel.fidl
   • webrunner/renderer/on_load_script_injector.cc
   • webrunner/renderer/on_load_script_injector.h

8. media: fix partial result count check

   Changed by	Moja Hsu - mojahsuohnoyoudont@google.com
   Changed at	Thursday, 17-Jan-19 05:33:11 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	fe33ecae720b44acdf25f9e9db971d56ec597b0b

   Comments

   media: fix partial result count check
   
   The original implementation of android.request.partialResultCount is
   required to collect the same number of results as it. New implementation
   is by the result id. If the result id is the same as partialResultCount
   we submit the capture result. The same check logic as android framework.
   
   BUG=b:117811693
   TEST=See if we can handle partial result with result id 1/10.
   Pass
   VideoCaptureDeviceTest.UsingRealWebcam_CaptureWithSize/0
   VideoCaptureDeviceTest.UsingRealWebcam_CaptureWithSize/1
   
   Change-Id: I9cba602353b4fa2994689517c89fcaf70c03ad65
   Reviewed-on: https://chromium-review.googlesource.com/c/1414734
   Commit-Queue: Ricky Liang <jcliang@chromium.org>
   Reviewed-by: Ricky Liang <jcliang@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623600}

   Changed files

   • media/capture/video/chromeos/stream_buffer_manager.cc

9. Add ListedElement::From().

   Changed by	Kent Tamura - tkentohnoyoudont@chromium.org
   Changed at	Thursday, 17-Jan-19 05:32:12 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	7ece4ae66c57b1e40d84b03bbce5fec1e1a5d793

   Comments

   Add ListedElement::From().
   
   Move a part of HTMLFormElement::CollectListedElements() to it.
   This new function will be used in form_controller.cc.
   
   This CL has no behavior changes.
   
   Change-Id: I5e3c1855d0670c11db54f35d0123d156f9463bc0
   Reviewed-on: https://chromium-review.googlesource.com/c/1415234
   Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
   Commit-Queue: Kent Tamura <tkent@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623599}

   Changed files

   • third_party/blink/renderer/core/html/forms/html_form_element.cc
   • third_party/blink/renderer/core/html/forms/listed_element.cc
   • third_party/blink/renderer/core/html/forms/listed_element.h

10. [Mojo WebUI] Update for Closure Compiler roll.

    Changed by	Christopher Lam - calamityohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 05:31:54 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	ca3572ce60c863555243530273a76983b7348019

    Comments

    [Mojo WebUI] Update for Closure Compiler roll.
    
    Since the new Closure Compiler actually does Promise return type
    checking, we can rely on type inference.
    
    Bug: 922671
    Change-Id: I1a7cf0dc4bce5aa989e6bb66e113cb66122daa4c
    Reviewed-on: https://chromium-review.googlesource.com/c/1416793
    Reviewed-by: Ken Rockot <rockot@google.com>
    Commit-Queue: calamity <calamity@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623598}

    Changed files

    • mojo/public/tools/bindings/generators/js_templates/lite/test/test.js

11. Roll src/third_party/angle bb4be1ad1034..94d8a9a445be (2 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Thursday, 17-Jan-19 05:31:04 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	d098d477924cf1d7d421cc3de4d033663a737ab2

    Comments

    Roll src/third_party/angle bb4be1ad1034..94d8a9a445be (2 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/bb4be1ad1034..94d8a9a445be
    
    
    git log bb4be1ad1034..94d8a9a445be --date=short --no-merges --format='%ad %ae %s'
    2019-01-17 jiawei.shao@intel.com ES31: Enable several SSBO end2end tests on D3D11
    2019-01-17 jie.a.chen@intel.com ParallelCompile: add GL backend support
    
    
    Created with:
      gclient setdep -r src/third_party/angle@94d8a9a445be
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:849576
    TBR=cwallez@chromium.org
    
    Change-Id: I35e75f60158c707b538cd7907436d91eee43ff22
    Reviewed-on: https://chromium-review.googlesource.com/c/1417274
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623597}

    Changed files

    • DEPS

12. [OnionSoup] replace network::DataElement::Type with DataElementType

    Changed by	Richard Li - richard.liohnoyoudont@intel.com
    Changed at	Thursday, 17-Jan-19 05:30:37 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	2f586ef701ff4fdc6f225c15fd7d6b92340031b6

    Comments

    [OnionSoup] replace network::DataElement::Type with DataElementType
    
    This CL defines a new mojom enum network.mojom.DataElementType to
    replace network::DataElement::Type.
    
    In the future, network::ResourceRequestBody will be typemapped with
    network.mojom.URLRequestBody with every field defined in specific forms.
    This CL is one of preparation works for building typemapping.
    
    TBR=mkwst@chromium.org
    
    Change-Id: I06991e47ce19947a63a633b355856bd1992905c0
    Bug: 860403
    Reviewed-on: https://chromium-review.googlesource.com/c/1393106
    Commit-Queue: Richard Li <richard.li@intel.com>
    Reviewed-by: Ken Rockot <rockot@google.com>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Reviewed-by: Leon Han <leon.han@intel.com>
    Cr-Commit-Position: refs/heads/master@{#623596}

    Changed files

    • content/browser/blob_storage/chrome_blob_storage_context.cc
    • content/browser/child_process_security_policy_impl.cc
    • content/browser/devtools/protocol/network_handler.cc
    • content/browser/loader/upload_data_stream_builder.cc
    • content/browser/service_worker/service_worker_navigation_loader.cc
    • content/browser/service_worker/service_worker_navigation_loader_unittest.cc
    • content/browser/speech/speech_recognition_engine_unittest.cc
    • content/browser/speech/speech_recognizer_impl_unittest.cc
    • content/common/page_state_serialization.cc
    • content/common/page_state_serialization_unittest.cc
    • content/renderer/loader/web_url_request_util.cc
    • content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
    • extensions/browser/api/web_request/web_request_info.cc
    • services/image_annotation/annotator_unittest.cc
    • services/network/public/cpp/data_element.cc
    • services/network/public/cpp/data_element.h
    • services/network/public/cpp/network_ipc_param_traits.cc
    • services/network/public/cpp/resource_request_body.cc
    • services/network/public/cpp/resource_request_body.h
    • services/network/public/cpp/simple_url_loader.cc
    • services/network/public/cpp/simple_url_loader_unittest.cc
    • services/network/public/mojom/url_loader.mojom
    • services/network/test/test_utils.cc
    • services/network/url_loader.cc

13. HTMLFormElement::ConstructEntryList() creates a FormData instance

    Changed by	Kent Tamura - tkentohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 05:29:54 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	b00b1c12b746ef40452273b9a21adef80696b4d3

    Comments

    HTMLFormElement::ConstructEntryList() creates a FormData instance
    
    instead of taking an empty FormData as an argument.
    
    - This matches to what the specification says.
      https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#constructing-form-data-set
    > 1. If form's constructing entry list is true, then return null.
    
    - We avoid to create unnecessary FormData instance in a case where
      FormData::Create() throws an exception.
    
    Change-Id: Iafb8aa09e3d0cf2b013760ef488258e4b61fed5f
    Reviewed-on: https://chromium-review.googlesource.com/c/1414738
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623595}

    Changed files

    • third_party/blink/renderer/core/html/forms/form_data.cc
    • third_party/blink/renderer/core/html/forms/html_form_element.cc
    • third_party/blink/renderer/core/html/forms/html_form_element.h
    • third_party/blink/renderer/core/loader/form_submission.cc

14. xhr: Use the response URL for responseURL and document URL.

    Changed by	Matt Falkenhagen - falkenohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 05:27:34 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	47e1c4bb479ec3aa5be900e2ff99de165baa31cc

    Comments

    xhr: Use the response URL for responseURL and document URL.
    
    Aligns with the spec, see bug.
    Chrome Status: https://www.chromestatus.com/feature/5676711949631488
    
    Bug: 915126
    Change-Id: I7d30a902f95a9e34b32eed891d4e2c3fb983dd71
    Reviewed-on: https://chromium-review.googlesource.com/c/1415057
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623594}

    Changed files

    • third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc
    • third_party/blink/web_tests/external/wpt/service-workers/service-worker/xhr-response-url.https-expected.txt

15. Fix extra headers not being added with network service with Android WebView.

    Changed by	John Abd-El-Malek - jamohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 05:23:56 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	fe6c0d4a09bbda7bc46f0938fcc56b324c83edfe

    Comments

    Fix extra headers not being added with network service with Android WebView.
    
    Bug: 893581
    Change-Id: I26a89e542b008c96229369be161e600dbe02cb7d
    Reviewed-on: https://chromium-review.googlesource.com/c/1415552
    Reviewed-by: Bo <boliu@chromium.org>
    Reviewed-by: Nate Fischer <ntfschr@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623593}

    Changed files

    • android_webview/BUILD.gn
    • android_webview/browser/aw_content_browser_client.cc
    • android_webview/browser/aw_url_loader_throttle.cc
    • android_webview/browser/aw_url_loader_throttle.h
    • android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
    • android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h
    • testing/buildbot/filters/mojo.fyi.network_webview_instrumentation_test_apk.filter

16. [Fuchsia] Exclude vulkan validation layers from release builds.

    Changed by	Sergey Ulanov - sergeyuohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 05:23:09 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	12cc899e71aae6032d6eec4172a4e755c71cb5f3

    Comments

    [Fuchsia] Exclude vulkan validation layers from release builds.
    
    Previously build_package.py was including all .so libs from the
    sdk/arch/dist directory. This includes vulkan validation layer
    libraries that are used only in debug builds. This CL restores
    the original logic in build_package.py that ensures that we only include
    libraries from sdk/arch/dist when they are used by the main
    application binary, or a transitive dependency.
    
    The vulkan libraries now are pulled as data_deps in //gpu/vulkan. The
    validation layer is included only in debug builds, which makes release
    packages smaller.
    
    Bug: 861931, 922139
    Change-Id: I9d7fdbc451194da6013cdde9a32500cd6767d28b
    Reviewed-on: https://chromium-review.googlesource.com/c/1416834
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623592}

    Changed files

    • build/config/fuchsia/build_manifest.py
    • gpu/vulkan/BUILD.gn
    • third_party/fuchsia-sdk/BUILD.gn

17. Roll src/third_party/SPIRV-Tools/src 49b5b0abc655..8d2d66f30c5c (2 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Thursday, 17-Jan-19 05:19:16 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	8ef5aa4a6638f56a49074b55d52e80c9b8330a04

    Comments

    Roll src/third_party/SPIRV-Tools/src 49b5b0abc655..8d2d66f30c5c (2 commits)
    
    https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/49b5b0abc655..8d2d66f30c5c
    
    
    git log 49b5b0abc655..8d2d66f30c5c --date=short --no-merges --format='%ad %ae %s'
    2019-01-16 greg@lunarg.com Fix vertex instrumentation to use VertexIndex and InstanceIndex (#2294)
    2019-01-16 dneto@google.com Fix leaks in tests (#2295)
    
    
    Created with:
      gclient setdep -r src/third_party/SPIRV-Tools/src@8d2d66f30c5c
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: Ia40bc83755b58c7a70cbc3c9a7e6f019bc4cf19b
    Reviewed-on: https://chromium-review.googlesource.com/c/1416873
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623591}

    Changed files

    • DEPS

18. Roll src/third_party/depot_tools 165153fde173..deab113bfb35 (1 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Thursday, 17-Jan-19 05:13:09 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	2d370ed39edde4e73397afdbc8af2131a1bf23cc

    Comments

    Roll src/third_party/depot_tools 165153fde173..deab113bfb35 (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/165153fde173..deab113bfb35
    
    
    git log 165153fde173..deab113bfb35 --date=short --no-merges --format='%ad %ae %s'
    2019-01-17 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@deab113bfb35
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=agable@chromium.org
    
    Change-Id: Ic2a41081eddf5d2bb74b7afb2882397bb24bdb7d
    Reviewed-on: https://chromium-review.googlesource.com/c/1417273
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623590}

    Changed files

    • DEPS

19. Re-enable disabled tests in chrome/browser/ui/views/toolbar/.

    Changed by	Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 05:11:56 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	632a7ce3b8a13e77590e8d0ae76f5b03b959dd2e

    Comments

    Re-enable disabled tests in chrome/browser/ui/views/toolbar/.
    
    Bug: 163931, 401304, 617056, 764111, 788112, 823543, 824418
    Change-Id: I6c1a8be7f5d30e0082b69af12aceb35851ce2f51
    Reviewed-on: https://chromium-review.googlesource.com/c/1351805
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Peter Boström <pbos@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623589}

    Changed files

    • chrome/browser/ui/views/toolbar/outdated_upgrade_bubble_view_browsertest.cc
    • chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc
    • chrome/browser/ui/views/toolbar/toolbar_view.cc
    • chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc
    • chrome/test/base/view_event_test_base.cc
    • chrome/test/base/view_event_test_base.h

20. Network Service: Remove DCHECK(removed_headers.empty()) in PrefetchURLLoader::FollowRedirect()

    Changed by	Jun Cai - juncaiohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 05:09:10 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	23627f04d6b0c12a2bafa67790c3b32775fe574c

    Comments

    Network Service: Remove DCHECK(removed_headers.empty()) in PrefetchURLLoader::FollowRedirect()
    
    This CL removes DCHECK(removed_headers.empty()) in
    PrefetchURLLoader::FollowRedirect(), and just propagates the
    |removed_headers| to the upstream.
    
    Bug: 922362
    Change-Id: Ia4f43325b797c8b4bafd297a757fdcf8fc6d8855
    Reviewed-on: https://chromium-review.googlesource.com/c/1415754
    Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623588}

    Changed files

    • content/browser/loader/prefetch_url_loader.cc

21. Roll src/third_party/pdfium 283677fb5329..8da0e1b3c27a (1 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Thursday, 17-Jan-19 05:07:26 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	359cfd22fd08585f26fe4ef56e43863665940ac2

    Comments

    Roll src/third_party/pdfium 283677fb5329..8da0e1b3c27a (1 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/283677fb5329..8da0e1b3c27a
    
    
    git log 283677fb5329..8da0e1b3c27a --date=short --no-merges --format='%ad %ae %s'
    2019-01-17 zhuo@hexoasis.com Change the type of CIDSystemInfo.{Registry,Ordering} to String
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@8da0e1b3c27a
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I7b8f0803eb3e8abde47461187e913083e97f0438
    Reviewed-on: https://chromium-review.googlesource.com/c/1417272
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623587}

    Changed files

    • DEPS

22. Roll src-internal 94ecd37cdffd..fed3aa20d999 (3 commits)

    Changed by	chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at	Thursday, 17-Jan-19 05:03:48 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	8a84ef0edb8224dd265e3d60bb54eb6f5e5a5781

    Comments

    Roll src-internal 94ecd37cdffd..fed3aa20d999 (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/94ecd37cdffd..fed3aa20d999
    
    
    Created with:
      gclient setdep -r src-internal@fed3aa20d999
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Iadf32e490c5573cc764a88e7332342a096ff9a24
    Reviewed-on: https://chromium-review.googlesource.com/c/1417270
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623586}

    Changed files

    • DEPS

23. [VK] Let KeyboardController control activate/deactivate.

    Changed by	Darren Shen - shendohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 04:59:19 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	00f016e7247626471c628715550a3504db97f350

    Comments

    [VK] Let KeyboardController control activate/deactivate.
    
    In order for KeyboardController to enable/disable by itself, it needs to
    also be able to activate/deactivate by itself. This patch changes the
    KeyboardLayoutDelegate interface so that KeyboardController does the
    activate/deactivate, and the delegate just returns the appropriate
    window to move to.
    
    After this patch, whenever the KeyboardController is enabled, it is
    guaranteed to be activated and when it is disabled, it is guaranteed to
    be deactivated.
    
    Bug: 845780
    Change-Id: I73d02e2b258da32fcc22c78bdc56be9c583f3fec
    Reviewed-on: https://chromium-review.googlesource.com/c/1401928
    Commit-Queue: Darren Shen <shend@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623585}

    Changed files

    • ash/keyboard/ash_keyboard_controller.cc
    • ash/keyboard/ash_keyboard_controller.h
    • ash/keyboard/virtual_keyboard_controller.cc
    • ash/keyboard/virtual_keyboard_controller.h
    • ash/keyboard/virtual_keyboard_controller_unittest.cc
    • ash/login/ui/login_keyboard_test_base.cc
    • ash/wm/system_modal_container_layout_manager_unittest.cc
    • chrome/browser/ui/ash/keyboard/keyboard_controller_browsertest.cc
    • ui/keyboard/BUILD.gn
    • ui/keyboard/keyboard_controller.cc
    • ui/keyboard/keyboard_controller.h
    • ui/keyboard/keyboard_controller_unittest.cc
    • ui/keyboard/keyboard_layout_delegate.h
    • ui/keyboard/keyboard_util_unittest.cc
    • ui/keyboard/test/test_keyboard_layout_delegate.cc
    • ui/keyboard/test/test_keyboard_layout_delegate.h

24. Roll src/third_party/skia 172fff869b37..25b9f192ed8c (4 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Thursday, 17-Jan-19 04:56:15 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	8f1dfdfa911c897d5ce55ad21c41041ae40745d8

    Comments

    Roll src/third_party/skia 172fff869b37..25b9f192ed8c (4 commits)
    
    https://skia.googlesource.com/skia.git/+log/172fff869b37..25b9f192ed8c
    
    
    git log 172fff869b37..25b9f192ed8c --date=short --no-merges --format='%ad %ae %s'
    2019-01-17 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2019-01-17 bsalomon@google.com Exclude PromiseImageTextureReuseDifferentConfig from Metal bots
    2019-01-17 rmistry@google.com Revert "Reland "Remove android framework compile bots from CQ""
    2019-01-17 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    
    
    Created with:
      gclient setdep -r src/third_party/skia@25b9f192ed8c
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=halcanary@chromium.org
    
    Change-Id: If7ae9b6db4a30b29a394c0327f54917a9d2ae301
    Reviewed-on: https://chromium-review.googlesource.com/c/1417271
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623584}

    Changed files

    • DEPS

25. v8binding: Minor cleanup of ToV8(IDL callback)

    Changed by	Yuki Shiino - yukishiinoohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 04:44:33 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	18458ddca32f2e7a9e63222cab226c0cb4f8554f

    Comments

    v8binding: Minor cleanup of ToV8(IDL callback)
    
    Cleans up ToV8(CallbackInterfaceBase*).  This is a leftover of
    https://chromium-review.googlesource.com/c/chromium/src/+/1343816
    https://chromium-review.googlesource.com/c/chromium/src/+/1314023
    
    Change-Id: I409004eaa940b24422f71b8e893f73278d2a10de
    Reviewed-on: https://chromium-review.googlesource.com/c/1414739
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
    Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623583}

    Changed files

    • third_party/blink/renderer/platform/bindings/callback_function_base.h
    • third_party/blink/renderer/platform/bindings/callback_interface_base.h
    • third_party/blink/renderer/platform/bindings/to_v8.h

26. Import wpt@584bdfaebda852482e349f3632ac25680e64ace4

    Changed by	Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at	Thursday, 17-Jan-19 04:43:47 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	0819526dcd4797ecca09678b329aef6b09ad495c

    Comments

    Import wpt@584bdfaebda852482e349f3632ac25680e64ace4
    
    Using wpt-import in Chromium 7ba57f898a5173c4499096c529ac692bd6c7d727.
    With Chromium commits locally applied on WPT:
    1c633d483b "Snap the snapped_dest_rect for backgrounds"
    1061788dd2 "Reland "Add quota usage details tests for all other storage backends.""
    bcd3934d05 "Add a test for ServiceWorker and AppCache interaction with claim()"
    4836c563b1 "Change web platform test with mouse inputs under "pinterevents/""
    33a49f0de5 "[WebLocks]: Modifying weblocks algos to be O(1)"
    66a94294e7 "Verify getContributingSources() does not return any CSRCs."
    8e4e5d7297 "Fix preload tests failing on wpt.fyi dashboard"
    9d7040bd63 "Portals: Add a WindowEventHandler to the PortalActivateEvent."
    
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    NOAUTOREVERT=true
    TBR=robertma
    
    No-Export: true
    Change-Id: Ib768e1bb2af4247aa5388811c4ddf9c07f9ca665
    Reviewed-on: https://chromium-review.googlesource.com/c/1416972
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623582}

    Changed files

    • third_party/blink/web_tests/NeverFixTests
    • third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
    • third_party/blink/web_tests/external/wpt/html/editing/focus/sequential-focus-navigation-and-the-tabindex-attribute/focus-tabindex-event-manual.html

27. Roll src/third_party/webrtc ccc1b57e32bd..309aafe3513a (16 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Thursday, 17-Jan-19 04:41:01 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	c280248748cfdae224300f4edf38e09b2e45db1b

    Comments

    Roll src/third_party/webrtc ccc1b57e32bd..309aafe3513a (16 commits)
    
    https://webrtc.googlesource.com/src.git/+log/ccc1b57e32bd..309aafe3513a
    
    
    git log ccc1b57e32bd..309aafe3513a --date=short --no-merges --format='%ad %ae %s'
    2019-01-16 Peter) Slatala Add 'AudioPacket' notification to media transport interface.
    2019-01-16 titovartem@webrtc.org Fix chromium roll into WebRTC.
    2019-01-16 ilnik@webrtc.org Deflake VideoSendStreamTest.SupportsVideoTimingFrames
    2019-01-16 ssilkin@webrtc.org Harmonic frame rate metric.
    2019-01-16 nisse@webrtc.org Simplify WebRtcVideoChannelTest.PreviousAdaptationDoesNotApplyToScreenshare
    2019-01-16 mbonadei@webrtc.org Using absl::string_view to stringify an RTCErrorType.
    2019-01-16 chxg@google.com Expose `jitterBufferEmittedCount` in addition to the existing `jitterBufferDelay` for `getStats()`.
    2019-01-16 srte@webrtc.org Revert "Reland "Adds richer packet and ice processing to ParsedRtcEventLog.""
    2019-01-16 srte@webrtc.org Reland "Adds richer packet and ice processing to ParsedRtcEventLog."
    2019-01-16 nisse@webrtc.org Rename EncodedImage::_length --> size_, and make private.
    2019-01-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c6a258bb5d..ac86e0cdbd (622808:623074)
    2019-01-16 qingsi@google.com Add the equals method to IceServer.
    2019-01-15 amithi@webrtc.org Revert "Adds richer packet and ice processing to ParsedRtcEventLog."
    2019-01-15 jonasolsson@webrtc.org Make Ice Transports signal failures.
    2019-01-15 srte@webrtc.org Adds richer packet and ice processing to ParsedRtcEventLog.
    2019-01-15 titovartem@webrtc.org Introduce CopyToFileAudioCapturer.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@309aafe3513a
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:None,chromium:none,chromium:none,chromium:None,chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I01c6f830fd53902afcff0ae98801a9a4501c152a
    Reviewed-on: https://chromium-review.googlesource.com/c/1415919
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623581}

    Changed files

    • DEPS

28. Temporarily disable Pixel_DirectComposition_ComplexOverlays pixel test on Windows nVidia machines

    Changed by	Maggie Chen - magchenohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 04:40:06 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	83dd146194b6b2604330994a30e53bac1166c32e

    Comments

    Temporarily disable Pixel_DirectComposition_ComplexOverlays pixel test on Windows nVidia machines
    
    This test has been flaky on nVidia for a few days. We should re-enable it once the bad CL is found.
    
    Bug: 921279
    Change-Id: I36a4371910b96c7a2858b6114a81d225e3f7cb0e
    Reviewed-on: https://chromium-review.googlesource.com/c/1416135
    Commit-Queue: Zhenyao Mo <zmo@chromium.org>
    Reviewed-by: Zhenyao Mo <zmo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623580}

    Changed files

    • content/test/gpu/gpu_tests/pixel_expectations.py

29. service worker: Add instrumentation for fetch event crash

    Changed by	Kenichi Ishibashi - bashiohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 04:39:45 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	4995d06d64ead95c0597431925bf02041ff501c0

    Comments

    service worker: Add instrumentation for fetch event crash
    
    There seems to be a race condition where we don't clean up
    ServiceWorkerContextClient::WorkerContextData properly.
    This CL adds instrumentation code to get some clues.
    
    Bug: 907311
    Change-Id: Ib439983802ae26c3aaec887a301f868d3bf15e3f
    Reviewed-on: https://chromium-review.googlesource.com/c/1405120
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623579}

    Changed files

    • content/renderer/service_worker/service_worker_context_client.cc
    • content/renderer/service_worker/service_worker_context_client.h
    • content/renderer/service_worker/service_worker_context_client_unittest.cc

30. Record unfinished bytes in per-frame ads metrics

    Changed by	John Delaney - johnidelohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 04:38:47 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	7302c33b4c9c9aebc0eaac6989f46932afd230f3

    Comments

    Record unfinished bytes in per-frame ads metrics
    
    To establish accurate percentiles for ad frames sizes, we should include
    unfinished resource bytes in metrics. Currently, videos that have not
    fully buffered are excluded from these metrics. In the future, we will
    need these numbers to establish proper thresholds for ad iframe network
    usage interventions.
    
    Because this will shift metrics, all histograms using ad frame sizes need
    to be renamed.
    
    Bug: 878393
    Change-Id: I3661d5fa17665d6468b6f104be3d5388153433ba
    Reviewed-on: https://chromium-review.googlesource.com/c/1394953
    Commit-Queue: John Delaney <johnidel@chromium.org>
    Reviewed-by: Charlie Harrison <csharrison@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623578}

    Changed files

    • chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc
    • chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h
    • chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc
    • chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc
    • chrome/test/data/ads_observer/ad_with_incomplete_resource.html
    • tools/metrics/histograms/histograms.xml

31. service worker: WPT: Add generated response tests for XHR response URL.

    Changed by	Matt Falkenhagen - falkenohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 04:34:18 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	9c34e04a9e3f0aae3661d2e63f2e3cfaa6236eda

    Comments

    service worker: WPT: Add generated response tests for XHR response URL.
    
    respondWith(new Response()) is a little tricky for response URL so it's
    good to have a test for it.
    
    Bug: 915126
    Change-Id: I21fbc654687d467baf14f02c23f4e41d18ac79ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1415613
    Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623577}

    Changed files

    • third_party/blink/web_tests/external/wpt/service-workers/service-worker/resources/xhr-response-url-worker.js
    • third_party/blink/web_tests/external/wpt/service-workers/service-worker/xhr-response-url.https-expected.txt
    • third_party/blink/web_tests/external/wpt/service-workers/service-worker/xhr-response-url.https.html

32. Mark virtual/threaded/synthetic_gestures/synthetic-pinch-zoom-gesture-touchscreen-desktop.html as Crash

    Changed by	Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 04:32:55 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	9c4b9e11bd4c51f684590a29f9415d6641fdd46b

    Comments

    Mark virtual/threaded/synthetic_gestures/synthetic-pinch-zoom-gesture-touchscreen-desktop.html as Crash
    
    This reverts https://chromium-review.googlesource.com/c/chromium/src/+/1415233
    which marked a wrong test, and mark
    virtual/threaded/synthetic_gestures/synthetic-pinch-zoom-gesture-touchscreen-desktop.html
    as Crash because it's failing on Mac10.13 Tests (dbg) bot.
    
    TBR=mcnee@chromium.org,masonfreed@chromium.org
    
    No-Try: true
    Bug: 922508
    Change-Id: Ib40689bd9d0498788d83ae12c92fa6966a44c2d7
    Reviewed-on: https://chromium-review.googlesource.com/c/1415058
    Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623576}

    Changed files

    • third_party/blink/web_tests/TestExpectations

33. LazyLoad: Fix deferred loading of CSS background images

    Changed by	rajendrant - rajendrantohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 04:32:02 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	884d05298198751cbf2fc527181a98404f45884b

    Comments

    LazyLoad: Fix deferred loading of CSS background images
    
    kDeferImageLoad bit is not set in the FetchParameters when CSS background
    images need to be deferred. This CL fixes that, and also adds a browser
    test.
    
    Bug: 920899
    Change-Id: I4d96d63c1bba2d2a0892e1b84ae364f29f53c152
    Reviewed-on: https://chromium-review.googlesource.com/c/1405592
    Reviewed-by: Nate Chapin <japhet@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Commit-Queue: rajendrant <rajendrant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623575}

    Changed files

    • chrome/browser/previews/lazyload_browsertest.cc
    • chrome/test/BUILD.gn
    • chrome/test/data/lazyload/css-background-image.html
    • chrome/test/data/lazyload/images/fruit1.jpg
    • chrome/test/data/lazyload/images/fruit2.jpg
    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/css/css_image_value.cc
    • third_party/blink/renderer/core/html/lazy_load_image_observer_test.cc
    • third_party/blink/renderer/platform/loader/fetch/fetch_parameters.cc
    • third_party/blink/renderer/platform/loader/fetch/fetch_parameters.h

34. Update V8 to version 7.3.427.

    Changed by	v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at	Thursday, 17-Jan-19 04:26:08 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	34cd6ae994412644b24d3cf0f3bb1dc8923937be

    Comments

    Update V8 to version 7.3.427.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/e9fc92db..80dba3f2
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I92a967d7a2b695375916f541284aea510885eb9e
    Reviewed-on: https://chromium-review.googlesource.com/c/1416831
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623574}

    Changed files

    • DEPS

35. Fix filemanager JS bugs found by latest closure

    Changed by	Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 04:17:41 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	cedd7c50592675cdc2bb7057154e58f2865355e2

    Comments

    Fix filemanager JS bugs found by latest closure
    
    Bug: 922671
    Change-Id: Ifb51ca3a6279e7e6b4b0d855a02edadd16f35584
    Reviewed-on: https://chromium-review.googlesource.com/c/1415055
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623573}

    Changed files

    • ui/file_manager/file_manager/background/js/background.js
    • ui/file_manager/file_manager/background/js/volume_manager_impl.js
    • ui/file_manager/file_manager/common/js/unittest_util.js

36. Reland "Android: Parallelize Error Prone"

    Changed by	Peter Wen - wnwenohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 04:17:11 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	fd9e2835636c89c2e177fbbf640f464b59e1f27b

    Comments

    Reland "Android: Parallelize Error Prone"
    
    Original CL: https://crrev.com/c/1346992
    
    This is a simple reland as the revert was speculative and did not remove
    perf bot issues.
    
    Bug: 906803, 693079, 921422
    Change-Id: Iaddeaf90a40c261775885a1ef37d4320a2e39cd4
    Reviewed-on: https://chromium-review.googlesource.com/c/1414875
    Commit-Queue: agrieve <agrieve@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623572}

    Changed files

    • build/android/gyp/javac.py
    • build/config/android/internal_rules.gni

37. Android: Fix "chrome_modern_bundle logcat" not deobfuscating

    Changed by	Andrew Grieve - agrieveohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 04:14:39 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	f6ee9c195faffacf05754f5eef6a539fab89d5ff

    Comments

    Android: Fix "chrome_modern_bundle logcat" not deobfuscating
    
    Change-Id: Ie7b613483fb19895d5a595a51e3ffb5e94e1dded
    Reviewed-on: https://chromium-review.googlesource.com/c/1412839
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Commit-Queue: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623571}

    Changed files

    • build/config/android/rules.gni

38. Updating trunk VERSION from 3674.0 to 3675.0

    Changed by	chrome-release-bot - chrome-release-botohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 04:11:43 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	744072313d2f4a3d0b1d316d9b8d4b0d8e374abd

    Comments

    Updating trunk VERSION from 3674.0 to 3675.0
    
    # This is an automated release commit.
    # Do not revert without consulting chrome-pmo@google.com.
    NOAUTOREVERT=true
    TBR=cmasso@chromium.org
    
    Change-Id: I940b2572b051a2dedd866a90ccf9d433e50693f8
    Reviewed-on: https://chromium-review.googlesource.com/c/1415817
    Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623570}

    Changed files

    • chrome/VERSION

39. infra: Rearrange Goma RBE builders in luci-scheduler.cfg

    Changed by	Simon Que - squeohnoyoudont@google.com
    Changed at	Thursday, 17-Jan-19 04:11:33 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	faa88675b86a7fc678986d808a689274284b9543

    Comments

    infra: Rearrange Goma RBE builders in luci-scheduler.cfg
    
    - Order trigger list alphabetically
    - Order job list by OS and category (ToT/Staging/Prod)
    
    Bug: 913249
    Change-Id: I9d595bc93181f3d14ad0fc179c114588d0d7465d
    Reviewed-on: https://chromium-review.googlesource.com/c/1411193
    Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    Commit-Queue: Simon Que <sque@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623569}

    Changed files

    • infra/config/global/luci-scheduler.cfg

40. Reland Print Preview: Destinations Dropdown

    Changed by	rbpotter - rbpotterohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 04:06:42 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	342b8ddb1400acec344d5faee8406aecd70d15d5

    Comments

    Reland Print Preview: Destinations Dropdown
    
    Update Print Preview to use a dropdown for the destinations settings
    section. The dropdown includes the recent destinations, Save as PDF,
    and "Save to Google Drive" if the user is signed in.
    
    The destinations dialog is accessible via a "Select destination"
    option.
    
    Fixed in reland: tests pass on debug builds by simplifying destination
    settings tests and adding additional test in model_test.js to verify
    some of the behavior that was being tested by the more complex tests
    
    Bug: 920056
    Change-Id: I8be70a25bf2c68841d0109a8d4f57193c4ceacfa
    Reviewed-on: https://chromium-review.googlesource.com/c/1415991
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623568}

    Changed files

    • chrome/app/printing_strings.grdp
    • chrome/browser/resources/print_preview/cloud_print_interface_js.js
    • chrome/browser/resources/print_preview/new/BUILD.gn
    • chrome/browser/resources/print_preview/new/app.html
    • chrome/browser/resources/print_preview/new/destination_select.html
    • chrome/browser/resources/print_preview/new/destination_select.js
    • chrome/browser/resources/print_preview/new/destination_settings.html
    • chrome/browser/resources/print_preview/new/destination_settings.js
    • chrome/browser/resources/print_preview/new/model.js
    • chrome/browser/resources/print_preview/print_preview_resources.grd
    • chrome/browser/ui/webui/print_preview/print_preview_ui.cc
    • chrome/test/data/webui/print_preview/destination_select_test.js
    • chrome/test/data/webui/print_preview/destination_settings_test.js
    • chrome/test/data/webui/print_preview/invalid_settings_browsertest.js
    • chrome/test/data/webui/print_preview/key_event_test.js
    • chrome/test/data/webui/print_preview/model_test.js
    • chrome/test/data/webui/print_preview/native_layer_stub.js
    • chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
    • chrome/test/data/webui/print_preview/print_preview_test_utils.js
    • chrome/test/data/webui/print_preview/settings_section_test.js