Builder Linux FYI Release (AMD R7 240) Build 2738

Results:

Success

Trigger Info:

Project	chromium
Revision	1ca1f627f2cc56903657cef072306019ea69d82a
Got Revision	1ca1f627f2cc56903657cef072306019ea69d82a

Execution:

• Source: Task 4272d1d04f4de710
• Bot: swarm1080-c4
• Recipe: chromium

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 340 ms ) setup_build

   running recipe: "chromium"
   • stdout
   • run_recipe
2. ( 232 ms ) report builders

    

   running tester 'Linux FYI Release (AMD R7 240)' on master 'chromium.gpu.fyi'
   • stdout
   • bots.json
3. ( 53 secs ) bot_update

   [48GB/295GB used (16%)]
   • stdout
   • json.output
4. ( 106 ms ) ensure_goma
   • - no logs -
   1. ( 106 ms ) ensure_installed
      • stdout
      • json.output
5. ( 577 ms ) swarming.py --version

   0.14
   • stdout
6. ( 11 secs ) gclient runhooks
   • stdout
7. ( 2 secs ) get compile targets for scripts
   • stdout
   • json.output
8. ( 1 secs ) read test spec (chromium.gpu.fyi.json)

   path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
   • stdout
   • json.output
9. ( 466 ms ) lookup builder GN args

    

   build_angle_gles1_conform_tests = true

   dcheck_always_on = true

   ffmpeg_branding = "Chrome"

   internal_gles2_conform_tests = true

   is_component_build = false

   is_debug = false

   proprietary_codecs = true

   strip_absolute_paths_from_debug_symbols = true

   symbol_level = 1

   use_goma = true

   goma_dir = "/b/swarming/w/ir/cache/goma/client"
   • stdout
10. ( 447 ms ) build directory
    • stdout
11. ( 436 ms ) find isolated tests
    • stdout
    • json.output
12. ( 1 secs ) test_pre_run
    • - no logs -
    1. ( 1 secs ) [trigger] angle_unittests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
13. ( 350 ms ) ensure swarming
    • - no logs -
    1. ( 350 ms ) ensure_installed
       • stdout
       • json.output
14. ( 28 secs ) angle_unittests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 21s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (16.9 sec)
15. ( 2 secs ) Upload to test-results [angle_unittests on ATI GPU on Linux on Ubuntu]
    • stdout
16. ( 893 ms ) test_pre_run (2)
    • - no logs -
    1. ( 893 ms ) test_pre_run.[trigger] angle_white_box_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
17. ( 8 secs ) angle_white_box_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 7s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (3.3 sec)
18. ( 1 secs ) Upload to test-results [angle_white_box_tests on ATI GPU on Linux on Ubuntu]
    • stdout
19. ( 1 secs ) test_pre_run (3)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] tab_capture_end2end_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
20. ( 25 secs ) tab_capture_end2end_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 23s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (7.0 sec)
21. ( 1 secs ) Upload to test-results [tab_capture_end2end_tests on ATI GPU on Linux on Ubuntu]
    • stdout
22. ( 956 ms ) test_pre_run (4)
    • - no logs -
    1. ( 956 ms ) test_pre_run.[trigger] gl_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
23. ( 17 secs ) gl_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 14s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (8.9 sec)
24. ( 1 secs ) Upload to test-results [gl_tests on ATI GPU on Linux on Ubuntu]
    • stdout
25. ( 940 ms ) test_pre_run (5)
    • - no logs -
    1. ( 940 ms ) test_pre_run.[trigger] gles2_conform_test on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
26. ( 39 secs ) gles2_conform_test on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 37s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (32.5 sec)
27. ( 1 secs ) Upload to test-results [gles2_conform_test on ATI GPU on Linux on Ubuntu]
    • stdout
28. ( 897 ms ) test_pre_run (6)
    • - no logs -
    1. ( 897 ms ) test_pre_run.[trigger] swiftshader_unittests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
29. ( 1 secs ) swiftshader_unittests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 5s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (0.8 sec) (deduped)
30. ( 1 secs ) Upload to test-results [swiftshader_unittests on ATI GPU on Linux on Ubuntu]
    • stdout
31. ( 911 ms ) test_pre_run (7)
    • - no logs -
    1. ( 911 ms ) test_pre_run.[trigger] context_lost_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
32. ( 3 mins 15 secs ) context_lost_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 0:03:07.105712

    Total tests: 10

    * Passed: 10 (10 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (174.8 sec)
33. ( 1 secs ) Upload to test-results [context_lost_tests on ATI GPU on Linux]
    • stdout
34. ( 888 ms ) test_pre_run (8)
    • - no logs -
    1. ( 888 ms ) test_pre_run.[trigger] depth_capture_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
35. ( 25 secs ) depth_capture_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 24s

    Total tests: 3

    * Passed: 3 (3 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (17.9 sec)
36. ( 1 secs ) Upload to test-results [depth_capture_tests on ATI GPU on Linux]
    • stdout
37. ( 1 secs ) test_pre_run (9)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] gpu_process_launch_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
38. ( 2 mins 56 secs ) gpu_process_launch_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 0:02:52.072865

    Total tests: 15

    * Passed: 15 (15 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (164.3 sec)
39. ( 1 secs ) Upload to test-results [gpu_process_launch_tests on ATI GPU on Linux]
    • stdout
40. ( 1 secs ) test_pre_run (10)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] hardware_accelerated_feature_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
41. ( 27 secs ) hardware_accelerated_feature_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 22s

    Total tests: 2

    * Passed: 2 (2 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (15.6 sec)
42. ( 1 secs ) Upload to test-results [hardware_accelerated_feature_tests on ATI GPU on Linux]
    • stdout
43. ( 1 secs ) test_pre_run (11)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] info_collection_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
44. ( 23 secs ) info_collection_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 21s

    Total tests: 1

    * Passed: 1 (1 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (15.2 sec)
45. ( 1 secs ) Upload to test-results [info_collection_tests on ATI GPU on Linux]
    • stdout
46. ( 1 secs ) test_pre_run (12)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] maps_pixel_test on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
47. ( 36 secs ) maps_pixel_test on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 32s

    Total tests: 1

    * Passed: 1 (1 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (25.8 sec)
48. ( 1 secs ) Upload to test-results [maps_pixel_test on ATI GPU on Linux]
    • stdout
49. ( 1 secs ) test_pre_run (13)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] pixel_test on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
50. ( 9 mins 25 secs ) pixel_test on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 0:09:09.969816

    Total tests: 49

    * Passed: 49 (49 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (543.2 sec)
51. ( 1 secs ) Upload to test-results [pixel_test on ATI GPU on Linux]
    • stdout
52. ( 878 ms ) test_pre_run (14)
    • - no logs -
    1. ( 878 ms ) test_pre_run.[trigger] screenshot_sync_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
53. ( 1 mins 18 secs ) screenshot_sync_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 0:01:12.154262

    Total tests: 4

    * Passed: 4 (4 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (65.6 sec)
54. ( 1 secs ) Upload to test-results [screenshot_sync_tests on ATI GPU on Linux]
    • stdout
55. ( 1 secs ) test_pre_run (15)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] trace_test on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
56. ( 4 mins 44 secs ) trace_test on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 0:04:31.837289

    Total tests: 48

    * Passed: 24 (24 expected, 0 unexpected)

    * Skipped: 24 (24 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (265.0 sec)
57. ( 1 secs ) Upload to test-results [trace_test on ATI GPU on Linux]
    • stdout
58. ( 9 secs ) test_pre_run (16)
    • - no logs -
    1. ( 9 secs ) test_pre_run.[trigger] webgl2_conformance_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
       • shard #1
       • shard #2
       • shard #3
       • shard #4
       • shard #5
       • shard #6
       • shard #7
       • shard #8
       • shard #9
       • shard #10
       • shard #11
       • shard #12
       • shard #13
       • shard #14
       • shard #15
       • shard #16
       • shard #17
       • shard #18
       • shard #19
59. ( 2 hrs 4 mins ) webgl2_conformance_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Max pending time: 1:57:50.827018 (shard #19)

    Max shard duration: 0:06:51.765733 (shard #18)

    Min shard duration: 0:05:15.549491 (shard #7)

    Total tests: 2803

    * Passed: 2735 (2735 expected, 0 unexpected)

    * Skipped: 68 (68 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (361.7 sec)
    • shard #1 isolated out
    • shard #1 (340.3 sec)
    • shard #2 isolated out
    • shard #2 (332.9 sec)
    • shard #3 isolated out
    • shard #3 (362.5 sec)
    • shard #4 isolated out
    • shard #4 (404.5 sec)
    • shard #5 isolated out
    • shard #5 (380.0 sec)
    • shard #6 isolated out
    • shard #6 (394.6 sec)
    • shard #7 isolated out
    • shard #7 (308.4 sec)
    • shard #8 isolated out
    • shard #8 (381.1 sec)
    • shard #9 isolated out
    • shard #9 (346.7 sec)
    • shard #10 isolated out
    • shard #10 (401.9 sec)
    • shard #11 isolated out
    • shard #11 (360.1 sec)
    • shard #12 isolated out
    • shard #12 (386.9 sec)
    • shard #13 isolated out
    • shard #13 (333.1 sec)
    • shard #14 isolated out
    • shard #14 (317.6 sec)
    • shard #15 isolated out
    • shard #15 (383.8 sec)
    • shard #16 isolated out
    • shard #16 (373.6 sec)
    • shard #17 isolated out
    • shard #17 (346.7 sec)
    • shard #18 isolated out
    • shard #18 (405.2 sec)
    • shard #19 isolated out
    • shard #19 (396.2 sec)
60. ( 2 secs ) Upload to test-results [webgl2_conformance_tests on ATI GPU on Linux]
    • stdout
61. ( 1 secs ) test_pre_run (17)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] webgl_conformance_gl_passthrough_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
       • shard #1
62. ( 8 mins 37 secs ) webgl_conformance_gl_passthrough_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Max pending time: 0:02:15.407567 (shard #1)

    Max shard duration: 0:06:18.888755 (shard #1)

    Min shard duration: 0:02:08.655718 (shard #0)

    Total tests: 938

    * Passed: 932 (932 expected, 0 unexpected)

    * Skipped: 6 (6 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (121.7 sec)
    • shard #1 isolated out
    • shard #1 (372.3 sec)
63. ( 2 secs ) Upload to test-results [webgl_conformance_gl_passthrough_tests on ATI GPU on Linux]
    • stdout
64. ( 1 secs ) test_pre_run (18)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] webgl_conformance_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
       • shard #1
65. ( 9 mins 8 secs ) webgl_conformance_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Max pending time: 0:02:15.471573 (shard #1)

    Max shard duration: 0:06:46.698651 (shard #1)

    Min shard duration: 0:02:11.140171 (shard #0)

    Total tests: 938

    * Passed: 932 (932 expected, 0 unexpected)

    * Skipped: 6 (6 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (124.3 sec)
    • shard #1 isolated out
    • shard #1 (400.3 sec)
66. ( 2 secs ) Upload to test-results [webgl_conformance_tests on ATI GPU on Linux]
    • stdout
67. ( 278 ms ) Tests statistics

     

    Stats

    Total shards: 39

    Total runtime: 2:41:33.208251

     
    • stdout
    • detailed stats
68. ( 1 ms ) recipe result
    • result

Build Properties:

Name	Value	Source
$recipe_engine/path	{"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"swarm1080-c4"	setup_build
buildbucket	{"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547698193551372, "id": "8924114534957731200", "project": "chromium", "tags": ["builder:Linux FYI Release (AMD R7 240)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/1ca1f627f2cc56903657cef072306019ea69d82a", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Linux Builder", "parent_buildnumber:39461", "scheduler_invocation_id:9089544597109739600", "scheduler_job_id:chromium/Linux FYI Release (AMD R7 240)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"Linux FYI Release (AMD R7 240)"	setup_build
buildnumber	2738	setup_build
mastername	"chromium.gpu.fyi"	setup_build
parent_buildername	"GPU FYI Linux Builder"	setup_build
parent_got_angle_revision	"a100d8f471f79b9f88d387164992cc5bd9c6ee9f"	setup_build
parent_got_buildtools_revision	"40194ab03962d8183b2796fa58a39ec8a9e83a41"	setup_build
parent_got_dawn_revision	"799cddcb83fda2911491fd653023c38a28bba1bd"	setup_build
parent_got_nacl_revision	"ff15c51d20785fa51c0ef03ccb480b87299acbeb"	setup_build
parent_got_revision	"1ca1f627f2cc56903657cef072306019ea69d82a"	setup_build
parent_got_revision_cp	"refs/heads/master@{#623567}"	setup_build
parent_got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	setup_build
parent_got_v8_revision	"e9fc92db6430d8adbaa64e5def121e137023b20d"	setup_build
parent_got_v8_revision_cp	"refs/heads/7.3.423@{#1}"	setup_build
parent_got_webrtc_revision	"ccc1b57e32bd99e4f220a3db0e540713f4349ad9"	setup_build
parent_got_webrtc_revision_cp	"refs/heads/master@{#26266}"	setup_build
parent_mastername	"chromium.gpu.fyi"	setup_build
path_config	"generic"	setup_build
recipe	"chromium"	setup_build
revision	"1ca1f627f2cc56903657cef072306019ea69d82a"	setup_build
swarm_hashes	{"angle_end2end_tests": "357b8575244d05270818bd0647f6a3c489f3e35a", "angle_perftests": "bc50be6bbc4dfa6f5017cc7f88ea78b272487793", "angle_unittests": "d9aea9f3107202321799186182c95003aba0d568", "angle_white_box_tests": "9b5902251047ea06a350a6a1ba18f84e3be25014", "browser_tests": "354430e38ca3540c80058f47380f90eebeefc3ba", "dawn_end2end_tests": "3d5d1d497da986889aabcb9500c75d5709d98f86", "gl_tests": "df0429f207bb3c4e3fe445aaa4b816087a05b672", "gl_unittests": "ea66cb85b0922b88fbd0ab48b723ae5ab6db1622", "gles2_conform_test": "f8ef7fad094996336802fb04a9eae858fdece555", "swiftshader_unittests": "84fa6663a1dd12e99764c625b2718c6c9b2f6e00", "telemetry_gpu_integration_test": "b1eca2ad5c49cb1f8017527528e7a2ccaac6d205"}	setup_build
got_angle_revision	"bb4be1ad1034193de209d9346dbe12b0ddea513b"	bot_update
got_buildtools_revision	"40194ab03962d8183b2796fa58a39ec8a9e83a41"	bot_update
got_dawn_revision	"799cddcb83fda2911491fd653023c38a28bba1bd"	bot_update
got_nacl_revision	"ff15c51d20785fa51c0ef03ccb480b87299acbeb"	bot_update
got_revision	"1ca1f627f2cc56903657cef072306019ea69d82a"	bot_update
got_revision_cp	"refs/heads/master@{#623567}"	bot_update
got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	bot_update
got_v8_revision	"e9fc92db6430d8adbaa64e5def121e137023b20d"	bot_update
got_v8_revision_cp	"refs/heads/7.3.423@{#1}"	bot_update
got_webrtc_revision	"ccc1b57e32bd99e4f220a3db0e540713f4349ad9"	bot_update
got_webrtc_revision_cp	"refs/heads/master@{#26266}"	bot_update
swarm_hashes	{}	find isolated tests

Blamelist:

1. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
2. David Staessens (dstaessensohnoyoudont@chromium.org)
3. Luum Habtemariam (luumohnoyoudont@chromium.org)
4. Stephen Chenney (schenneyohnoyoudont@chromium.org)
5. Akihiro Ota (akihirootaohnoyoudont@chromium.org)
6. Stephen Chenney (schenneyohnoyoudont@chromium.org)
7. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
8. Dan Beam (dbeamohnoyoudont@chromium.org)
9. Nico Weber (thakisohnoyoudont@chromium.org)
10. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
11. Tetsui Ohkubo (tetsuiohnoyoudont@chromium.org)
12. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
13. Zhongyi Shi (zhongyiohnoyoudont@chromium.org)
14. khachatryan (khachatryanohnoyoudont@chromium.org)
15. Dan Beam (dbeamohnoyoudont@chromium.org)
16. Marijn Kruisselbrink (mekohnoyoudont@chromium.org)
17. Kelvin Jiang (kelvinjiangohnoyoudont@chromium.org)
18. Kehuang Li (kehuangliohnoyoudont@chromium.org)
19. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
20. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
21. James Cook (jamescookohnoyoudont@chromium.org)
22. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
23. Pavel Feldman (pfeldmanohnoyoudont@chromium.org)
24. Gary Kacmarcik (garykacohnoyoudont@chromium.org)
25. Zhenyao Mo (zmoohnoyoudont@chromium.org)
26. Kenichi Ishibashi (bashiohnoyoudont@chromium.org)
27. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
28. Victor Costan (pwnallohnoyoudont@chromium.org)
29. Robert Liao (robliaoohnoyoudont@chromium.org)
30. Jay Harris (harrisjayohnoyoudont@chromium.org)
31. khachatryan (khachatryanohnoyoudont@chromium.org)
32. Peter Boström (pbosohnoyoudont@chromium.org)
33. Ken Rockot (rockotohnoyoudont@google.com)
34. Orin Jaworski (orinjohnoyoudont@chromium.org)
35. Taylor Bergquist (tbergquistohnoyoudont@chromium.org)
36. Dan Beam (dbeamohnoyoudont@chromium.org)
37. Lan Wei (lanweiohnoyoudont@chromium.org)
38. Orin Jaworski (orinjohnoyoudont@chromium.org)
39. Prabir Pradhan (prabirmspohnoyoudont@google.com)
40. Matt Falkenhagen (falkenohnoyoudont@chromium.org)
41. Suman Kancherla (sumankancherlaohnoyoudont@chromium.org)
42. Bailey Berro (baileyberroohnoyoudont@chromium.org)
43. Patrick Noland (pnolandohnoyoudont@chromium.org)
44. Marijn Kruisselbrink (mekohnoyoudont@chromium.org)
45. Becca Hughes (beccahughesohnoyoudont@chromium.org)
46. Michael Spang (spangohnoyoudont@chromium.org)
47. Kevin Bailey (krbohnoyoudont@chromium.org)
48. Doug Turner (dougtohnoyoudont@chromium.org)
49. Tarun Bansal (tbansalohnoyoudont@chromium.org)
50. Allen Webb (allenwebbohnoyoudont@google.com)
51. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
52. Reka Norman (rekanormanohnoyoudont@google.com)
53. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
54. Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
55. Eric Karl (ericrkohnoyoudont@chromium.org)
56. Jonathan Backer (backerohnoyoudont@chromium.org)
57. Nate Fischer (ntfschrohnoyoudont@chromium.org)
58. Nathaniel Steinbock (steinbockohnoyoudont@google.com)
59. Antoine Labour (pimanohnoyoudont@chromium.org)
60. Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
61. Yi Gu (yiguohnoyoudont@chromium.org)
62. dpapad (dpapadohnoyoudont@chromium.org)
63. Lukasz Anforowicz (lukaszaohnoyoudont@chromium.org)
64. David Staessens (dstaessensohnoyoudont@chromium.org)
65. Ted Meyer (tmathmeyerohnoyoudont@chromium.org)
66. Luum Habtemariam (luumohnoyoudont@chromium.org)
67. Lakshmi Kumar Dabbiru (dlkumarohnoyoudont@google.com)
68. Becky Zhou (huayinzohnoyoudont@chromium.org)
69. Collin Baker (collinbakerohnoyoudont@chromium.org)
70. Akihiro Ota (akihirootaohnoyoudont@chromium.org)
71. Martin Kreichgauer (martinkrohnoyoudont@chromium.org)
72. Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
73. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
74. Ted Meyer (tmathmeyerohnoyoudont@chromium.org)
75. John Lee (johntleeohnoyoudont@chromium.org)
76. Becca Hughes (beccahughesohnoyoudont@chromium.org)
77. Gyuyoung Kim (gyuyoungohnoyoudont@igalia.com)
78. Caleb Raitto (caraittoohnoyoudont@chromium.org)
79. Gyuyoung Kim (gyuyoungohnoyoudont@igalia.com)
80. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
81. Mike Reed (reedohnoyoudont@google.com)

Timing:

Create	Thursday, 17-Jan-19 04:09:53 UTC
Start	Thursday, 17-Jan-19 04:09:58 UTC
End	Thursday, 17-Jan-19 07:00:31 UTC
Pending	5 secs
Execution	2 hrs 50 mins

All Changes:

1. Roll src/third_party/depot_tools d1dba6482b22..165153fde173 (4 commits)

   Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
   Changed at	Thursday, 17-Jan-19 04:00:59 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	1ca1f627f2cc56903657cef072306019ea69d82a

   Comments

   Roll src/third_party/depot_tools d1dba6482b22..165153fde173 (4 commits)
   
   https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d1dba6482b22..165153fde173
   
   
   git log d1dba6482b22..165153fde173 --date=short --no-merges --format='%ad %ae %s'
   2019-01-17 recipe-roller@chromium.org Roll recipe dependencies (trivial).
   2019-01-17 recipe-roller@chromium.org Roll recipe dependencies (trivial).
   2019-01-17 recipe-roller@chromium.org Roll recipe dependencies (trivial).
   2019-01-16 tikuta@chromium.org Deploy git 2.20.1 to depot_tools on a bleeding edge
   
   
   Created with:
     gclient setdep -r src/third_party/depot_tools@165153fde173
   
   The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
   
   Documentation for the AutoRoller is here:
   https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
   
   If the roll is causing failures, please contact the current sheriff, who should
   be CC'd on the roll, and stop the roller if necessary.
   
   
   
   BUG=chromium:887141
   TBR=agable@chromium.org
   
   Change-Id: I19d27f5015fe78659d4d5c08bccc6d930fd0fddc
   Reviewed-on: https://chromium-review.googlesource.com/c/1417120
   Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
   Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
   Cr-Commit-Position: refs/heads/master@{#623567}

   Changed files

   • DEPS

2. media/gpu/test: Add generic VideoFrameProcessor interface for testing.

   Changed by	David Staessens - dstaessensohnoyoudont@chromium.org
   Changed at	Thursday, 17-Jan-19 03:58:15 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	848f6501951dbfb0d643f0a8476722f981ae9ce0

   Comments

   media/gpu/test: Add generic VideoFrameProcessor interface for testing.
   
   To increase flexibility and to avoid code duplication, this CL adds a generic
   VideoFrameProcessor interface. This interface will be used to write re-usable
   test helpers that write video frames to files, calculate video frame checksums,
   validate video frames,...
   
   Currently the VideoFrameValidator is the only one using this interface but more
   processors will be added soon. The video player API is slighty adapted to allow
   multiple VideoFrameProcessors to be plugged in.
   
   This CL also contains some minor cleanup.
   
   TEST=ran new VDA tests on nocturne
   
   BUG=879065
   
   Change-Id: I376e0d5aefdfb5af966d1bde7facc5c9f7062340
   Reviewed-on: https://chromium-review.googlesource.com/c/1404763
   Commit-Queue: David Staessens <dstaessens@chromium.org>
   Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623566}

   Changed files

   • media/gpu/test/BUILD.gn
   • media/gpu/test/video_frame_helpers.h
   • media/gpu/test/video_frame_mapper_factory.h
   • media/gpu/test/video_frame_validator.cc
   • media/gpu/test/video_frame_validator.h
   • media/gpu/test/video_player/video_decoder_client.cc
   • media/gpu/test/video_player/video_decoder_client.h
   • media/gpu/test/video_player/video_player.cc
   • media/gpu/test/video_player/video_player.h
   • media/gpu/video_decode_accelerator_tests.cc
   • media/gpu/video_decode_accelerator_unittest.cc

3. PpdProvidcer USB Fetching refactor

   Changed by	Luum Habtemariam - luumohnoyoudont@chromium.org
   Changed at	Thursday, 17-Jan-19 03:51:34 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	01445fd68b6593c5e5be2081433e1329360d2246

   Comments

   PpdProvidcer USB Fetching refactor
   
   Rewrote OnUsbFetchComplete to no longer end the request on failure, i.e.
   cedes back to MaybeStartNext...Resolution() to finish. This allows
   future changes to only modify the latter function, centralizes the
   logic.
   
   Bug: none
   Test: USB resolution tests still pass
   Change-Id: Ib0253de6097d2bd90e8a1dd8cb30cbd11c2cf0b6
   Reviewed-on: https://chromium-review.googlesource.com/c/1413910
   Reviewed-by: Sean Kau <skau@chromium.org>
   Commit-Queue: Luum Habtemariam <luum@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623565}

   Changed files

   • chromeos/printing/ppd_provider.cc

4. Fix numerical inaccuracy in background-size auto

   Changed by	Stephen Chenney - schenneyohnoyoudont@chromium.org
   Changed at	Thursday, 17-Jan-19 03:49:23 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	2dd4985ba4d4952fd0ea9b85ac2111b161ef389f

   Comments

   Fix numerical inaccuracy in background-size auto
   
   We were using intrinsic_width * tile_size / intrinsic_height to
   compute the auto size when only one dimension is given. The values
   are in LayoutUnits and the expression overflows when the tile is
   large and the image is large, resulting in significant distortion
   of the background. The effect is most prominant on high-dpi devices
   but also manifests at high zoom.
   
   Bug: 921269
   Change-Id: I78c2d0adf3c23b1b9d4158d2ffe8d775b3f5b9f4
   Reviewed-on: https://chromium-review.googlesource.com/c/1413175
   Reviewed-by: Fredrik Söderquist <fs@opera.com>
   Reviewed-by: Florin Malita <fmalita@chromium.org>
   Commit-Queue: Stephen Chenney <schenney@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623564}

   Changed files

   • third_party/blink/renderer/core/paint/background_image_geometry.cc
   • third_party/blink/web_tests/external/wpt/css/css-backgrounds/background-image-large-with-auto.html
   • third_party/blink/web_tests/external/wpt/css/css-backgrounds/reference/background-image-large-with-auto-ref.html
   • third_party/blink/web_tests/external/wpt/css/css-backgrounds/support/green-1000x10.png
   • third_party/blink/web_tests/external/wpt/css/css-backgrounds/support/green-10x1000.png

5. ChromeVox background test on document with switching language.

   Changed by	Akihiro Ota - akihirootaohnoyoudont@chromium.org
   Changed at	Thursday, 17-Jan-19 03:47:33 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	c5d4d0485c3ad9213f9b99a8505a052fd138b88e

   Comments

   ChromeVox background test on document with switching language.
   
   Currently a trivial test case. Will create a follow up
   change to assert that ChromeVox is speaking each phrase in
   the correct language.
   
   Change-Id: I9bde58063fd6a5a4eb8a203d3a5124069c6d6b10
   Reviewed-on: https://chromium-review.googlesource.com/c/1413397
   Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
   Reviewed-by: David Tseng <dtseng@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623563}

   Changed files

   • chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs

6. Re-enable Event.Latency.HitTest* histograms with new ownership

   Changed by	Stephen Chenney - schenneyohnoyoudont@chromium.org
   Changed at	Thursday, 17-Jan-19 03:46:27 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	628840b946c1ca8d0ae07ecf7558fb127a7aa34c

   Comments

   Re-enable Event.Latency.HitTest* histograms with new ownership
   
   The Event.Latency.HitTest* histograms were removed due to their noisy
   nature. But the Rendering Core team looks at these and has used them
   to find regressions, so we want them back, and we will own them.
   
   This patch essentially reverts commit
   ab878a2f504bde1cfd53496f62c15716fa225218 with additional changes to
   owners in the histogram file.
   
   Bug: None
   Change-Id: Id2437e84510d05ec345e5ba5d7bc1154de38afd5
   Reviewed-on: https://chromium-review.googlesource.com/c/1409903
   Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
   Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
   Commit-Queue: Stephen Chenney <schenney@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623562}

   Changed files

   • third_party/blink/renderer/core/layout/layout_view.cc
   • tools/metrics/histograms/histograms.xml

7. Return container_path from CrostiniSharePath

   Changed by	Joel Hockey - joelhockeyohnoyoudont@chromium.org
   Changed at	Thursday, 17-Jan-19 03:45:05 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	6ab245ef73de869bc70da32b477f05ad6054771b

   Comments

   Return container_path from CrostiniSharePath
   
   This field is used after sharing path to then determine what the
   backup path will be for tremplin running in termina.
   
   Bug: 912638
   Change-Id: I9c9b4a36b17015cfb8c13746898a49ad8788e63d
   Reviewed-on: https://chromium-review.googlesource.com/c/1414253
   Commit-Queue: Joel Hockey <joelhockey@chromium.org>
   Reviewed-by: Nicholas Verne <nverne@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623561}

   Changed files

   • chrome/browser/chromeos/crostini/crostini_share_path.cc
   • chrome/browser/chromeos/crostini/crostini_share_path.h
   • chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc

8. Dark Mode: spruce up history page (and cr-{checkbox,drawer,toolbar})

   Changed by	Dan Beam - dbeamohnoyoudont@chromium.org
   Changed at	Thursday, 17-Jan-19 03:42:38 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	9e1388e870679122fe84fc3a04867d170802269e

   Comments

   Dark Mode: spruce up history page (and cr-{checkbox,drawer,toolbar})
   
   There's still a bit to do on history, but this gets us a ways.
   
   Screenshots: https://imgur.com/a/ngXdLK4
   Specs: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g481b97d74a_0_389
   
   BUG=883049
   R=aee@chromium.org
   
   Change-Id: Ifb34e89d2d3ea47b145ba012c1bd5975af59bf56
   Reviewed-on: https://chromium-review.googlesource.com/c/1409969
   Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
   Commit-Queue: Dan Beam <dbeam@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623560}

   Changed files

   • chrome/browser/resources/md_history/app.html
   • chrome/browser/resources/md_history/history.html
   • chrome/browser/resources/md_history/shared_style.html
   • chrome/browser/resources/md_history/shared_vars.html
   • chrome/browser/resources/md_history/side_bar.html
   • ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html
   • ui/webui/resources/cr_elements/cr_drawer/cr_drawer.html
   • ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html

9. Reland "Reland "Remove workaround made unnecessary by https://chromium-review.googlesource.com/c/1312234""

   Changed by	Nico Weber - thakisohnoyoudont@chromium.org
   Changed at	Thursday, 17-Jan-19 03:41:55 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	5eaa7f0167358c9073637e636b80b20639e698bb

   Comments

   Reland "Reland "Remove workaround made unnecessary by https://chromium-review.googlesource.com/c/1312234""
   
   This reverts commit 319965600784a41581478e6cef29f0a7d8db210e.
   
   Reason for revert: This might work now, https://crbug.com/906114
   
   Original change's description:
   > Revert "Reland "Remove workaround made unnecessary by https://chromium-review.googlesource.com/c/1312234""
   > 
   > This reverts commit 1ffe990d20bbcec3ffd31e41129bfc48fb9ad297.
   > 
   > Reason for revert:
   > roll-dep is still broken with this (https://bugs.chromium.org/p/chromium/issues/detail?id=906114#c19)
   > 
   > Original change's description:
   > > Reland "Remove workaround made unnecessary by https://chromium-review.googlesource.com/c/1312234"
   > > 
   > > This is a reland of c56126056693dff05fe37f370fc1562cf0c17120
   > > 
   > > Original change's description:
   > > > Remove workaround made unnecessary by https://chromium-review.googlesource.com/c/1312234
   > > >
   > > > Bug: 875037
   > > > Change-Id: Ia4a6393237602b88bb0130d9f916972e930d95b3
   > > > Reviewed-on: https://chromium-review.googlesource.com/c/1339339
   > > > Reviewed-by: Hans Wennborg <hans@chromium.org>
   > > > Commit-Queue: Nico Weber <thakis@chromium.org>
   > > > Cr-Commit-Position: refs/heads/master@{#608783}
   > > 
   > > TBR=hans
   > > 
   > > Bug: 875037
   > > Change-Id: Iac24d9ec462cd4d5720d78a52b7f867be3ab2ec7
   > > Reviewed-on: https://chromium-review.googlesource.com/c/1344198
   > > Commit-Queue: Hans Wennborg <hans@chromium.org>
   > > Reviewed-by: Nico Weber <thakis@chromium.org>
   > > Cr-Commit-Position: refs/heads/master@{#609974}
   > 
   > TBR=thakis@chromium.org,hans@chromium.org,martiniss@chromium.org,ehmaldonado@chromium.org
   > 
   > Change-Id: I1b2327216797da231e11427a29edece425cd35bd
   > No-Presubmit: true
   > No-Tree-Checks: true
   > No-Try: true
   > Bug: 875037
   > Reviewed-on: https://chromium-review.googlesource.com/c/1347333
   > Reviewed-by: Nico Weber <thakis@chromium.org>
   > Commit-Queue: Nico Weber <thakis@chromium.org>
   > Cr-Commit-Position: refs/heads/master@{#610177}
   
   TBR=thakis@chromium.org,hans@chromium.org,martiniss@chromium.org,ehmaldonado@chromium.org
   
   # Not skipping CQ checks because original CL landed > 1 day ago.
   
   Bug: 875037
   Change-Id: I223dd1baf8efe4ba8ca3ba4ff2c87e30319501eb
   Reviewed-on: https://chromium-review.googlesource.com/c/1417030
   Reviewed-by: Nico Weber <thakis@chromium.org>
   Commit-Queue: Nico Weber <thakis@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623559}

   Changed files

   • DEPS

10. Roll src/third_party/dawn acd8b7d937cc..799cddcb83fd (2 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Thursday, 17-Jan-19 03:39:12 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	98918e4f2651633d2cb902c5a60a5a2be092a8e6

    Comments

    Roll src/third_party/dawn acd8b7d937cc..799cddcb83fd (2 commits)
    
    https://dawn.googlesource.com/dawn.git/+log/acd8b7d937cc..799cddcb83fd
    
    
    git log acd8b7d937cc..799cddcb83fd --date=short --no-merges --format='%ad %ae %s'
    2019-01-17 brandon1.jones@intel.com Trigger GC Sweeps on Vulkan
    2019-01-16 yunchao.he@intel.com Remove annoying warnings in dawn_unittests
    
    
    Created with:
      gclient setdep -r src/third_party/dawn@799cddcb83fd
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=cwallez@chromium.org
    
    Change-Id: Ib8be2b7d7fbdfbd494179046c867defd64cb4ebf
    Reviewed-on: https://chromium-review.googlesource.com/c/1416871
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623558}

    Changed files

    • DEPS

11. Merge UnifiedDetailedViewDelegate w/ parent class.

    Changed by	Tetsui Ohkubo - tetsuiohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 03:35:58 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	bd07dddd92c7b386b7185229481b10ff5784c58c

    Comments

    Merge UnifiedDetailedViewDelegate w/ parent class.
    
    This CL merges UnifiedDetailedViewDelegate with its parent class,
    DetailedViewDelegate. Previously, there was a DetailedViewDelegate for
    old SystemTray, but the old one is now removed.
    
    TEST=trybot pass
    BUG=901713
    
    Change-Id: Ibd4aa0d6e09fc6fb0b8ee452e6dc6e2c8a6baa37
    Reviewed-on: https://chromium-review.googlesource.com/c/1414810
    Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623557}

    Changed files

    • ash/BUILD.gn
    • ash/system/accessibility/tray_accessibility_unittest.cc
    • ash/system/accessibility/unified_accessibility_detailed_view_controller.cc
    • ash/system/audio/unified_audio_detailed_view_controller.cc
    • ash/system/bluetooth/unified_bluetooth_detailed_view_controller.cc
    • ash/system/cast/unified_cast_detailed_view_controller.cc
    • ash/system/ime/unified_ime_detailed_view_controller.cc
    • ash/system/ime_menu/ime_menu_tray.cc
    • ash/system/locale/unified_locale_detailed_view_controller.cc
    • ash/system/network/unified_network_detailed_view_controller.cc
    • ash/system/network/unified_vpn_detailed_view_controller.cc
    • ash/system/tray/detailed_view_delegate.cc
    • ash/system/tray/detailed_view_delegate.h
    • ash/system/unified/unified_detailed_view_delegate.h
    • ash/system/unified/unified_notifier_settings_controller.cc

12. Roll src/third_party/skia a30c755f95a3..172fff869b37 (11 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Thursday, 17-Jan-19 03:32:58 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	c32b4bb7e24afff87e887acd0d5ed685281e528e

    Comments

    Roll src/third_party/skia a30c755f95a3..172fff869b37 (11 commits)
    
    https://skia.googlesource.com/skia.git/+log/a30c755f95a3..172fff869b37
    
    
    git log a30c755f95a3..172fff869b37 --date=short --no-merges --format='%ad %ae %s'
    2019-01-17 reed@google.com Reland "remove SK_SUPPORT_LEGACY_CANVAS_DRAW_TEXT flag"
    2019-01-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2019-01-16 reed@google.com hide SkPaint::getFlags/setFlags, use bool acessors instead
    2019-01-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2019-01-16 herb@google.com Remove findOrCreateGlyphCache
    2019-01-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 84497a910c68..a9f87d1e43bb (53 commits)
    2019-01-16 bsalomon@google.com Make GrTexture caching for SkPromiseImageTexture work when same texture
    2019-01-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2019-01-16 csmartdalton@google.com Return GrProcessorSet::Analysis from GrDrawOp::finalize
    2019-01-16 michaelludwig@google.com Implement optimization to convert filled rects to scissored clears
    2019-01-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    
    
    Created with:
      gclient setdep -r src/third_party/skia@172fff869b37
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:423834
    TBR=halcanary@chromium.org
    
    Change-Id: Ib81398e14752a396ab918a377152899b858bbbc8
    Reviewed-on: https://chromium-review.googlesource.com/c/1416872
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623556}

    Changed files

    • DEPS

13. Close all handles after connection close when session decides to close connection on error.

    Changed by	Zhongyi Shi - zhongyiohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 03:32:13 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	59aaf078eaa908431e93a31c871f8d93e7821218

    Comments

    Close all handles after connection close when session decides to close connection on error.
    
    This change also conditionally override quic connection error
    only when the QuicChromiumClientStream contains a valid connection error
    code.
    
    Bug: 922739
    Change-Id: Ib83d65cd5c03f89842a344fa599d3f874107c5b7
    Reviewed-on: https://chromium-review.googlesource.com/c/1415304
    Commit-Queue: Ryan Hamilton <rch@chromium.org>
    Reviewed-by: Ryan Hamilton <rch@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623555}

    Changed files

    • net/quic/quic_chromium_client_session.cc
    • net/quic/quic_http_stream.cc
    • net/quic/quic_stream_factory_test.cc

14. [ChromeDriver] Increase target height in touch_action_tests.html file

    Changed by	khachatryan - khachatryanohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 03:31:51 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	8daee733a199fc3e695af2095231d18dc659ef16

    Comments

    [ChromeDriver] Increase target height in touch_action_tests.html file
    
    Increasing target height in touch_action_tests.html fixes the bug
    in testTouchScrollElement.
    
    Bug: chromedriver:2738
    Change-Id: I11087c8f15e71c52b529427300301835e43aa9a1
    Reviewed-on: https://chromium-review.googlesource.com/c/1416402
    Reviewed-by: John Chen <johnchen@chromium.org>
    Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623554}

    Changed files

    • chrome/test/data/chromedriver/touch_action_tests.html

15. Dark Mode: update history time gap separator color

    Changed by	Dan Beam - dbeamohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 03:31:05 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	7ae9decb48da495b41fa5f5b4c7242eb810e5744

    Comments

    Dark Mode: update history time gap separator color
    
    R=dpapad@chromium.org
    BUG=883049
    
    Change-Id: I23f3973721ae92fbb65d6e346e35a6e48a464615
    Reviewed-on: https://chromium-review.googlesource.com/c/1416818
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: Dan Beam <dbeam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623553}

    Changed files

    • chrome/browser/resources/md_history/history_item.html

16. Disable FileSystemManager::CreateWriter if WritableFiles isn't enabled.

    Changed by	Marijn Kruisselbrink - mekohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 03:28:50 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	f045c704568e9cf6279b3cbccbec6d86c35f8a13

    Comments

    Disable FileSystemManager::CreateWriter if WritableFiles isn't enabled.
    
    Bug: 922677
    Change-Id: Ib16137cbabb2ec07f1ffc0484722f1d9cc533404
    Reviewed-on: https://chromium-review.googlesource.com/c/1416570
    Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
    Reviewed-by: Victor Costan <pwnall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623552}

    Changed files

    • content/browser/fileapi/file_system_manager_impl.cc
    • third_party/blink/web_tests/TestExpectations

17. [Extensions] Fix keyboard focus behavior for activity log page

    Changed by	Kelvin Jiang - kelvinjiangohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 03:27:16 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	ff808d82f7126425bafbea9425f5b963bf0a448c

    Comments

    [Extensions] Fix keyboard focus behavior for activity log page
    
    This CL fixes keyboard focus for the activity log page by introducing
    these 2 behaviors:
    
    1) When the activity log page is entered either through the detail view
    or via url, the back button is focused.
    
    2) When the user navigates back from the activity log page to the detail
    view page, the View Activity Log button/link is focused.
    
    Patchset >1 achieves this by using a flag stored in manager.js which
    indicates if the previous view was the activity log. This flag is set to
    true by an event which is fired when the user is about to exit the
    activity log and is set back to false by manager.js in onViewEnterStart.
    
    The detail view page uses the flag upon onViewEnterStart to determine
    which element should receive focus. This is safe as onViewEnterStart
    is bubbled up in manager.js later so the flag is safely reset.
    
    Bug: 908598
    Change-Id: I58bfda628aa347357315f483f3859856c7264196
    Reviewed-on: https://chromium-review.googlesource.com/c/1410123
    Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623551}

    Changed files

    • chrome/browser/resources/md_extensions/BUILD.gn
    • chrome/browser/resources/md_extensions/activity_log.html
    • chrome/browser/resources/md_extensions/activity_log.js
    • chrome/browser/resources/md_extensions/detail_view.html
    • chrome/browser/resources/md_extensions/detail_view.js
    • chrome/browser/resources/md_extensions/manager.html
    • chrome/browser/resources/md_extensions/manager.js
    • chrome/test/data/webui/extensions/activity_log_test.js
    • chrome/test/data/webui/extensions/detail_view_test.js

18. Enable video capture service on Cast Android device

    Changed by	Kehuang Li - kehuangliohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 03:22:13 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	a315b599864661f4e2dc3e42d33a2e6fab5dcb80

    Comments

    Enable video capture service on Cast Android device
    
    On android devices, features need to be enabled in content client rather
    than in command line. Enable video capture feature on Cast Android
    devices when video capture service build flag is set.
    
    capturing works.
    
    Bug: b/122595653
    Test: No longer see no video provider handler error on device, and video
    Change-Id: I5677e86b7acdc5119ef89431b02021251236e4e7
    Reviewed-on: https://chromium-review.googlesource.com/c/1412998
    Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
    Reviewed-by: Luke Halliwell <halliwell@chromium.org>
    Commit-Queue: Kehuang Li <kehuangli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623550}

    Changed files

    • chromecast/BUILD.gn
    • chromecast/browser/cast_content_browser_client.cc
    • chromecast/chromecast.gni

19. Roll src/third_party/angle dd34b3b9b707..bb4be1ad1034 (4 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Thursday, 17-Jan-19 03:19:00 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	1bce524d11a2a9c7f7b7dda3064d837f36c724a6

    Comments

    Roll src/third_party/angle dd34b3b9b707..bb4be1ad1034 (4 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/dd34b3b9b707..bb4be1ad1034
    
    
    git log dd34b3b9b707..bb4be1ad1034 --date=short --no-merges --format='%ad %ae %s'
    2019-01-16 cwallez@chromium.org Suppress OcclusionQueriesTest.MultiContext on Win NVIDIA Vk
    2019-01-16 jmadill@chromium.org Make path utils return std::string.
    2019-01-16 jgilbert@mozilla.com Add GL_ANGLE_provoking_vertex on D3D11 and GL.
    2019-01-16 jmadill@chromium.org Optimize more front-end VertexArray binding.
    
    
    Created with:
      gclient setdep -r src/third_party/angle@bb4be1ad1034
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=cwallez@chromium.org
    
    Change-Id: If8922be9754d874f932f8a8169cb352812d68c41
    Reviewed-on: https://chromium-review.googlesource.com/c/1416814
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623549}

    Changed files

    • DEPS

20. Roll src-internal cb8994dd48a5..94ecd37cdffd (3 commits)

    Changed by	chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at	Thursday, 17-Jan-19 03:18:03 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	1b43db048d90d36b3d28bcd81d519dcd998e0ead

    Comments

    Roll src-internal cb8994dd48a5..94ecd37cdffd (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cb8994dd48a5..94ecd37cdffd
    
    
    Created with:
      gclient setdep -r src-internal@94ecd37cdffd
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I5e52c8f821599be5754f749158cf0bc6e3a738a7
    Reviewed-on: https://chromium-review.googlesource.com/c/1416976
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623548}

    Changed files

    • DEPS

21. SingleProcessMash: Fix virtual keyboard not appearing in automation tree

    Changed by	James Cook - jamescookohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 03:16:33 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	5d72852411f01369cfa0a54066afbc319e3f9abd

    Comments

    SingleProcessMash: Fix virtual keyboard not appearing in automation tree
    
    The virtual keyboard is an embedded remote view. The window service
    needs to use the embedded window tree to compute the transport ID for
    the VK window.
    
    This fixes the ash-to-chrome "fence hopping" code used by the
    accessibility chrome.automation system to serialize the desktop UI tree.
    
    Chrome OS only, see bug for more details.
    
    Bug: 921405
    Change-Id: I16bd2b4a6050729529a735ad9830609076008667
    Reviewed-on: https://chromium-review.googlesource.com/c/1415259
    Commit-Queue: Scott Violet <sky@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623547}

    Changed files

    • services/ws/window_service.cc

22. Send drivefs_mount_path in StartLxdContainer

    Changed by	Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 03:15:16 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	55411dc5c0adb1c31e04b7803775f6e6a141f54a

    Comments

    Send drivefs_mount_path in StartLxdContainer
    
    Bug: 908122
    Change-Id: I73e1be440e87731210494acb180a6773a6d2794e
    Reviewed-on: https://chromium-review.googlesource.com/c/1405950
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Reviewed-by: Nicholas Verne <nverne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623546}

    Changed files

    • chrome/browser/chromeos/crostini/crostini_manager.cc
    • chrome/browser/chromeos/crostini/crostini_manager_unittest.cc

23. DevTools: disable raf-aligned input when debugger is attached.

    Changed by	Pavel Feldman - pfeldmanohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 03:14:32 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	6708eefa73d16b0af5ff93277ceea660c086be58

    Comments

    DevTools: disable raf-aligned input when debugger is attached.
    
    Bug: 922347
    Change-Id: Ie9208c9f6af1d0b57c272583c5d54138b6d7626e
    Reviewed-on: https://chromium-review.googlesource.com/c/1415311
    Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623545}

    Changed files

    • content/renderer/input/main_thread_event_queue.cc
    • content/renderer/input/main_thread_event_queue.h
    • content/renderer/render_widget.cc
    • content/renderer/render_widget.h
    • third_party/blink/public/web/web_widget_client.h
    • third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc
    • third_party/blink/renderer/core/inspector/inspector_overlay_agent.h
    • third_party/blink/renderer/core/loader/empty_clients.h
    • third_party/blink/renderer/core/page/chrome_client.h
    • third_party/blink/renderer/core/page/chrome_client_impl.cc
    • third_party/blink/renderer/core/page/chrome_client_impl.h

24. [Chromoting] Add host support for SelectSource message from client.

    Changed by	Gary Kacmarcik - garykacohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 03:10:12 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	0c56fda3fda6fedb4b23b8cb4a050590a9566412

    Comments

    [Chromoting] Add host support for SelectSource message from client.
    
    This message is piped through to WebRtc's SelectSource to select
    which display to show.
    
    Bug: 915411
    Change-Id: I30f10c8f94b15ebcff1c0fc0981385cbb8b7bc74
    Reviewed-on: https://chromium-review.googlesource.com/c/1410229
    Commit-Queue: Gary Kacmarcik <garykac@chromium.org>
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Reviewed-by: Joe Downing <joedow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623544}

    Changed files

    • remoting/host/chromoting_messages.h
    • remoting/host/client_session.cc
    • remoting/host/client_session.h
    • remoting/host/desktop_capturer_proxy.cc
    • remoting/host/desktop_session_agent.cc
    • remoting/host/desktop_session_agent.h
    • remoting/host/desktop_session_proxy.cc
    • remoting/host/desktop_session_proxy.h
    • remoting/host/ipc_video_frame_capturer.cc
    • remoting/proto/control.proto
    • remoting/proto/internal.proto
    • remoting/protocol/client_control_dispatcher.cc
    • remoting/protocol/client_control_dispatcher.h
    • remoting/protocol/fake_connection_to_client.cc
    • remoting/protocol/fake_connection_to_client.h
    • remoting/protocol/host_control_dispatcher.cc
    • remoting/protocol/host_stub.h
    • remoting/protocol/protocol_mock_objects.h
    • remoting/protocol/video_frame_pump.cc
    • remoting/protocol/video_frame_pump.h
    • remoting/protocol/video_stream.h
    • remoting/protocol/webrtc_video_stream.cc
    • remoting/protocol/webrtc_video_stream.h
    • remoting/test/fake_connection_event_logger.cc

25. Increase GPU watchdog timeout limit on MacOSX from 10s to 15s

    Changed by	Zhenyao Mo - zmoohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 03:10:02 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	527aa50fe9ce4028aae71fc202b8987f57fbb8a6

    Comments

    Increase GPU watchdog timeout limit on MacOSX from 10s to 15s
    
    BUG=918490
    TEST=bots
    R=kbr@chromium.org
    
    Change-Id: Icfb6e631090fe5a83a762bd45d32e550acb0e47e
    Reviewed-on: https://chromium-review.googlesource.com/c/1416833
    Commit-Queue: Zhenyao Mo <zmo@chromium.org>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623543}

    Changed files

    • gpu/ipc/service/gpu_watchdog_thread.cc

26. Remove unused CacheStorageDispatcherHost::ValidState()

    Changed by	Kenichi Ishibashi - bashiohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 03:05:00 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	c440c10e1a3e100378375cb408439de7135beab6

    Comments

    Remove unused CacheStorageDispatcherHost::ValidState()
    
    There seems no callsite.
    
    Bug: 922449
    Change-Id: I251629affa63cd400825037b882b7aa260a7c268
    Reviewed-on: https://chromium-review.googlesource.com/c/1415051
    Reviewed-by: Ben Kelly <wanderview@chromium.org>
    Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623542}

    Changed files

    • content/browser/cache_storage/cache_storage_dispatcher_host.cc
    • content/browser/cache_storage/cache_storage_dispatcher_host.h

27. Introduce ShouldUseIsolatedCodeCache helper

    Changed by	Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 03:00:14 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	af14958f954813d7eea9497d4c4fe713e2352a0b

    Comments

    Introduce ShouldUseIsolatedCodeCache helper
    
    This helper encapsulates decision about whether to use isolated
    code cache, and will be used from both ResourceLoader and DocumentLoader.
    
    Bug: none
    Change-Id: Id04f4f3bdea716dc6d11bfd6a42b8962f4cbdec8
    Reviewed-on: https://chromium-review.googlesource.com/c/1415691
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Ben Kelly <wanderview@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623541}

    Changed files

    • third_party/blink/renderer/platform/loader/fetch/cached_metadata_handler.cc
    • third_party/blink/renderer/platform/loader/fetch/cached_metadata_handler.h
    • third_party/blink/renderer/platform/loader/fetch/resource_loader.cc

28. sqlite: Backport a third round of bugfixes.

    Changed by	Victor Costan - pwnallohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:55:38 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	77c3fd7aca79b3e1f71c600f69c30667b6cd2cda

    Comments

    sqlite: Backport a third round of bugfixes.
    
    Bug: 921894, 922213, 922312
    Change-Id: I2a72cef00d5429a9f7e15ee94e708e4166022df4
    Reviewed-on: https://chromium-review.googlesource.com/c/1416399
    Reviewed-by: Chris Mumford <cmumford@google.com>
    Commit-Queue: Victor Costan <pwnall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623540}

    Changed files

    • third_party/sqlite/amalgamation/sqlite3.c
    • third_party/sqlite/patches/0001-Modify-default-VFS-to-support-WebDatabase.patch
    • third_party/sqlite/patches/0002-Virtual-table-supporting-recovery-of-corrupted-datab.patch
    • third_party/sqlite/patches/0003-Custom-shell.c-helpers-to-load-Chromium-s-ICU-data.patch
    • third_party/sqlite/patches/0004-fts3-Disable-fts3_tokenizer-and-fts4.patch
    • third_party/sqlite/patches/0005-fuchsia-Use-dot-file-locking-for-sqlite.patch
    • third_party/sqlite/patches/0006-Fix-dbfuzz2-for-Clusterfuzz.patch
    • third_party/sqlite/patches/0007-Fix-the-Makefile-so-that-it-honors-CFLAGS-when-build.patch
    • third_party/sqlite/patches/0008-Adjustments-to-the-page-cache-to-try-to-avoid-harmle.patch
    • third_party/sqlite/patches/0009-Remove-an-ALWAYS-from-a-branch-that-is-not-always-ta.patch
    • third_party/sqlite/patches/0010-Fix-a-problem-with-nested-CTEs-with-the-same-table.patch
    • third_party/sqlite/patches/0011-Fix-detection-of-self-referencing-rows-in-foreign-ke.patch
    • third_party/sqlite/patches/0012-Fix-a-segfault-caused-by-using-the-RAISE-function-in.patch
    • third_party/sqlite/patches/0013-Fix-for-an-assert-that-could-be-false.patch
    • third_party/sqlite/patches/0014-Fix-another-problem-found-by-Matthew-Denton-s-new-fu.patch
    • third_party/sqlite/patches/0015-Report-a-new-corruption-case.patch
    • third_party/sqlite/patches/0016-Avoid-a-buffer-overread-in-ptrmapPutOvflPtr.patch
    • third_party/sqlite/patches/0017-Improved-detection-of-cell-corruption-in-sqlite3Vdbe.patch
    • third_party/sqlite/patches/0018-Fix-a-segfault-in-fts3-prompted-by-a-corrupted-datab.patch
    • third_party/sqlite/patches/0019-Prevent-integer-overflow-from-leading-to-buffer-over.patch
    • third_party/sqlite/patches/0020-Add-extra-tests-for-database-corruption-inside-defra.patch
    • third_party/sqlite/patches/0021-Fix-an-off-by-one-error-on-a-Goto-in-the-code-genera.patch
    • third_party/sqlite/patches/0022-Fix-overread-on-corrupted-btree-key.patch
    • third_party/sqlite/patches/0023-Avoid-buffer-overreads-on-corrupted-database-files.patch
    • third_party/sqlite/patches/0024-Fix-integer-overflow-while-running-PRAGMA-integrity_.patch
    • third_party/sqlite/patches/0025-Improved-corruption-handling-while-balancing-pages.patch
    • third_party/sqlite/patches/0026-Avoid-reading-off-the-front-of-a-page-buffer-when-ba.patch
    • third_party/sqlite/patches/0027-Fix-MSAN-error-in-sqlite3VdbeRecordUnpack-on-a-corru.patch
    • third_party/sqlite/patches/0028-Fix-deleting-a-B-tree-entry-in-a-corrupt-database.patch
    • third_party/sqlite/patches/0029-Fix-sorting-results-with-SRT_EphemTab-and-a-LIMIT-cl.patch
    • third_party/sqlite/patches/0030-Fix-detection-of-orphaned-and-malformed-autoindexes.patch
    • third_party/sqlite/src/src/btree.c
    • third_party/sqlite/src/src/prepare.c
    • third_party/sqlite/src/src/select.c

29. Update Chromium Copyright to 2019

    Changed by	Robert Liao - robliaoohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:54:45 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	c4e5cdafcb7a398b7b161f0a50dbfb5335be78de

    Comments

    Update Chromium Copyright to 2019
    
    BUG=764528,764538
    TBR=oshima@chromium.org
    Similar change, different year.
    
    Change-Id: I370214153fabddfb1f8a8ccbba4513c3f5c97a31
    Reviewed-on: https://chromium-review.googlesource.com/c/1416974
    Reviewed-by: Robert Liao <robliao@chromium.org>
    Commit-Queue: Robert Liao <robliao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623539}

    Changed files

    • chrome/app/theme/chromium/BRANDING

30. Removes grey line between title bar and content for desktop PWAs.

    Changed by	Jay Harris - harrisjayohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:53:37 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	81cfd76abd6e45673dd64196e2ffadc3a0f8a070

    Comments

    Removes grey line between title bar and content for desktop PWAs.
    
    Note: The line this disables was being drawn unintentionally
    (and, in some cases, not properly). In future, we will add a
    similar line controlled by the custom tab bar, which will allow
    us to blend and control whether or not it displays based on
    theme and custom tab bar color.
    
    Bug: 918788
    Change-Id: I5b6e7a9afe55a0fd337dce12db142c473b64af26
    Reviewed-on: https://chromium-review.googlesource.com/c/1414650
    Commit-Queue: Jay Harris <harrisjay@chromium.org>
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623538}

    Changed files

    • chrome/browser/ui/views/frame/browser_non_client_frame_view.cc

31. [ChromeDriver] Disable failing test on Android

    Changed by	khachatryan - khachatryanohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:52:54 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	33926e1ebd60d8acb8531b4064ab62921f69210a

    Comments

    [ChromeDriver] Disable failing test on Android
    
    Test CorrectEventFiringTest.testShouldEmitClickEventWhenClickingOnATextInputElement
    fails on Android platform.
    
    Disabling test.
    
    Bug: chromedriver:2697
    Change-Id: I277638dcbca9fb6e54dcecb243ea9f02d666c786
    Reviewed-on: https://chromium-review.googlesource.com/c/1417110
    Reviewed-by: John Chen <johnchen@chromium.org>
    Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623537}

    Changed files

    • chrome/test/chromedriver/test/test_expectations

32. Strip out most new-tab-animation code

    Changed by	Peter Boström - pbosohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:47:18 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	79436f9066f2ae6ae578228a50ff5c3016942e0c

    Comments

    Strip out most new-tab-animation code
    
    Does not remove painting the favicon under the spinner under the same
    experiment, since there's future exploration that'll likely end up
    using it.
    
    Bug: chromium:922614
    Change-Id: Idc01d89bbc87f9872628e6205fc34e8303a972a5
    Reviewed-on: https://chromium-review.googlesource.com/c/1416611
    Commit-Queue: Peter Boström <pbos@chromium.org>
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623536}

    Changed files

    • chrome/browser/ui/views/frame/browser_view.cc
    • chrome/browser/ui/views/tabs/tab.cc
    • chrome/browser/ui/views/tabs/tab_icon.cc
    • chrome/browser/ui/views/tabs/tab_icon.h
    • chrome/browser/ui/views/tabs/tab_strip.cc
    • chrome/browser/ui/views/tabs/tab_strip.h
    • chrome/browser/ui/views/tabs/tab_unittest.cc

33. [mojo] Per-message dispatch tasks

    Changed by	Ken Rockot - rockotohnoyoudont@google.com
    Changed at	Thursday, 17-Jan-19 02:46:59 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	471aa794bbb9e3a98542ee2135ea61ddf4bf87a3

    Comments

    [mojo] Per-message dispatch tasks
    
    Modifies C++ bindings internals such that incoming messages, while
    still read off the pipe in batch, are each dispatched with
    individual tasks rather than dispatching them all in series within
    the same task.
    
    The first message in a batch is still dispatched synchronously, and
    exceptions are made during sync wait operations where messages must
    be (at least partially) dispatched so that the waiting endpoint can
    get at its anticipated reply without allowing its calling sequence
    to progress.
    
    Also just for fun, deletes Connector::SyncWatch because it hasn't
    been used in, like, forever.
    
    TBR=jam@chromium.org
    
    Bug: 866708
    Change-Id: If56d2341c0642a0fd99a90cb60a2dfc5573e0b4e
    Reviewed-on: https://chromium-review.googlesource.com/c/1145692
    Commit-Queue: Ken Rockot <rockot@google.com>
    Reviewed-by: Reilly Grant <reillyg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623535}

    Changed files

    • content/common/throttling_url_loader.cc
    • ipc/ipc_mojo_bootstrap.cc
    • mojo/public/cpp/bindings/binding.h
    • mojo/public/cpp/bindings/connector.h
    • mojo/public/cpp/bindings/lib/binding_state.cc
    • mojo/public/cpp/bindings/lib/binding_state.h
    • mojo/public/cpp/bindings/lib/connector.cc
    • mojo/public/cpp/bindings/lib/multiplex_router.cc
    • mojo/public/cpp/bindings/lib/multiplex_router.h
    • third_party/blink/web_tests/TestExpectations

34. [omnibox] Clean up all usage of IsNewAnswerLayoutEnabled

    Changed by	Orin Jaworski - orinjohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:45:57 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	c5778366ffd0cc2044e6fc178eeb633435b77d62

    Comments

    [omnibox] Clean up all usage of IsNewAnswerLayoutEnabled
    
    This CL eliminates a bunch of code that depended on feature
    flag kOmniboxNewAnswerLayout which is no longer needed on
    desktop, and has since been repurposed for another feature
    on Android.  See crrev.com/c/1405882 for additional context.
    
    Bug: 900255
    Change-Id: Id20aaeaa648807a1e257d0d80c6e8c33646acb37
    Reviewed-on: https://chromium-review.googlesource.com/c/1412993
    Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
    Commit-Queue: Orin Jaworski <orinj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623534}

    Changed files

    • chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc
    • chrome/browser/ui/views/omnibox/omnibox_text_view.cc
    • components/omnibox/browser/autocomplete_controller.cc
    • components/omnibox/browser/omnibox_field_trial.cc
    • components/omnibox/browser/omnibox_field_trial.h
    • components/omnibox/browser/search_suggestion_parser.cc
    • components/omnibox/browser/suggestion_answer.cc

35. Add context menu submenu to add tab to existing tab group.

    Changed by	Taylor Bergquist - tbergquistohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:45:36 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	4455958e24c4603b1156a53fb57869d16245ec5e

    Comments

    Add context menu submenu to add tab to existing tab group.
    
    Reuses (and slightly simplifies) some of the logic used to add tabs to
    new tab groups.
    
    This CL is part of the prototype of the above-described tab groups
    feature.  The prototype will allow users to create and manipulate groups
    primarily via tab context menus, and will display tab group affiliation
    in the tabstrip.  Future work will include persisting and syncing groups,
    manipulating groups via tab dragging, and a dropdown menu for the group
    headers. See go/chrome-tab-groups-design
    
    Bug: 905491
    
    Change-Id: Id36b896ab5e1cfb51f85b6e1f4fb931670fa2ff1
    Reviewed-on: https://chromium-review.googlesource.com/c/1406292
    Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
    Reviewed-by: Erik Chen <erikchen@chromium.org>
    Reviewed-by: Jesse Doherty <jwd@chromium.org>
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623533}

    Changed files

    • chrome/app/generated_resources.grd
    • chrome/app/generated_resources_grd/IDS_TAB_CXMENU_ADD_TAB_TO_EXISTING_GROUP.png.sha1
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/tabs/existing_tab_group_sub_menu_model.cc
    • chrome/browser/ui/tabs/existing_tab_group_sub_menu_model.h
    • chrome/browser/ui/tabs/tab_group_data.cc
    • chrome/browser/ui/tabs/tab_menu_model.cc
    • chrome/browser/ui/tabs/tab_menu_model.h
    • chrome/browser/ui/tabs/tab_strip_model.cc
    • chrome/browser/ui/tabs/tab_strip_model.h
    • chrome/browser/ui/tabs/tab_strip_model_unittest.cc
    • tools/metrics/actions/actions.xml

36. Dark Mode: add GM2 Google Blue 300 and update link colors

    Changed by	Dan Beam - dbeamohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:44:35 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	91576a07eee92259e583f026c5da3dcc998265fc

    Comments

    Dark Mode: add GM2 Google Blue 300 and update link colors
    
    Because of an unfortunate miscommunication, I assumed colors in the
    WebUI Dark Mode spec were from the Material Design (MD) palette instead
    of the Material Modern/Refresh (GM2) version. Whoops.
    
    There's probably a lot more colors to update soon.
    
    R=hcarmona@chromium.org
    BUG=883049
    
    Change-Id: Idcc8b7a0e811aa1dbe6a5abafcf58544b8dc3988
    Reviewed-on: https://chromium-review.googlesource.com/c/1416771
    Reviewed-by: Hector Carmona <hcarmona@chromium.org>
    Commit-Queue: Dan Beam <dbeam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623532}

    Changed files

    • ui/webui/resources/cr_elements/shared_vars_css.html

37. Enable “InputPaneOnScreenKeyboard” flag

    Changed by	Lan Wei - lanweiohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:44:19 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	756e195fe4708fb63c7f75bddf9ee8208e20d5f1

    Comments

    Enable “InputPaneOnScreenKeyboard” flag
    
    Since we have submitted a fix for the crash of using
    "OnScreenKeyboardDisplayManagerInputPane" for virtual keyboard on
    higher version of Windows 10, we should enable
    “InputPaneOnScreenKeyboard” flag.
    
    Bug: 852386, 497381
    Change-Id: Ideb1aa831d7d433df80838b652d71b6b839388b8
    Reviewed-on: https://chromium-review.googlesource.com/c/1410173
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Lan Wei <lanwei@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623531}

    Changed files

    • ui/base/ui_base_features.cc

38. [omnibox] Improve Pedal triggering with natural concept detection

    Changed by	Orin Jaworski - orinjohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:42:35 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	6c409ed974927e2da7357ffe09eaf1a750edd205

    Comments

    [omnibox] Improve Pedal triggering with natural concept detection
    
    The first method of triggering Pedals used small sets of known
    match suggestions, and did not cover most of the possible ways
    that users might indicate their intention.  This CL dramatically
    expands the space of acceptable queries by checking match text
    against small sets of concepts.  When all required concepts
    are present, with or without non-required concepts, with no
    extraneous text uncovered by the concept set, the Pedal triggers.
    This approach efficiently represents large sets of trigger
    suggestions without wasting a lot of space on string structures.
    
    Bug: 893183
    Change-Id: I75a8ce1510a732c3ea38088ec21b7b3e828c1617
    Reviewed-on: https://chromium-review.googlesource.com/c/1402026
    Commit-Queue: Orin Jaworski <orinj@chromium.org>
    Reviewed-by: Tommy Li <tommycli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623530}

    Changed files

    • components/omnibox/browser/BUILD.gn
    • components/omnibox/browser/omnibox_pedal.cc
    • components/omnibox/browser/omnibox_pedal.h
    • components/omnibox/browser/omnibox_pedal_implementations.cc
    • components/omnibox/browser/omnibox_pedal_implementations.h
    • components/omnibox/browser/omnibox_pedal_implementations_unittest.cc
    • components/omnibox/browser/omnibox_pedal_provider.h
    • components/omnibox/browser/omnibox_pedal_unittest.cc

39. [PointerCapture] Generate headers for wayland relative-pointer extension

    Changed by	Prabir Pradhan - prabirmspohnoyoudont@google.com
    Changed at	Thursday, 17-Jan-19 02:42:15 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	98b4d3adad0a0856c646c2f77c3f1a45ab9ae297

    Comments

    [PointerCapture] Generate headers for wayland relative-pointer extension
    
    Generated headers for the wayland extension
    relative-pointer-unstable-v1 to add pointer capture support.
    
    Bug: b/121287287
    Change-Id: Ia9e69480a5940138462bf856d6db454f64872fff
    Reviewed-on: https://chromium-review.googlesource.com/c/1388724
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623529}

    Changed files

    • third_party/wayland-protocols/BUILD.gn

40. service worker: WPT: Add test for XHR Document's URL.

    Changed by	Matt Falkenhagen - falkenohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:41:10 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	eebd14b2bd0c7c46c951884962a82f5f6a9a2913

    Comments

    service worker: WPT: Add test for XHR Document's URL.
    
    Bug: 915126
    Change-Id: I967a72b1e2317af4ddd0be1144f505ebb80948d8
    Reviewed-on: https://chromium-review.googlesource.com/c/1415231
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Ben Kelly <wanderview@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623528}

    Changed files

    • third_party/blink/web_tests/external/wpt/service-workers/service-worker/resources/xhr-iframe.html
    • third_party/blink/web_tests/external/wpt/service-workers/service-worker/xhr-response-url.https-expected.txt
    • third_party/blink/web_tests/external/wpt/service-workers/service-worker/xhr-response-url.https.html

41. [ui/vr] Notify tab ui about VR state change

    Changed by	Suman Kancherla - sumankancherlaohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:41:06 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	a50783e6957b051fb9404d5e2ec2b524a7a98d1a

    Comments

    [ui/vr] Notify tab ui about VR state change
    
    Bug: 845252
    Change-Id: I6a2788cd612eba36482a1b2a0594d621c485ee5b
    Reviewed-on: https://chromium-review.googlesource.com/c/1412952
    Reviewed-by: Yuri Wiitala <miu@chromium.org>
    Reviewed-by: Bill Orr <billorr@chromium.org>
    Commit-Queue: Suman Kancherla <sumankancherla@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623527}

    Changed files

    • chrome/browser/ui/views/tabs/tab.cc
    • chrome/browser/vr/ui_host/vr_ui_host_impl.cc
    • chrome/browser/vr/vr_tab_helper.cc

42. Add metrics for OobeConfigRestoreResult

    Changed by	Bailey Berro - baileyberroohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:38:56 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	6ba6c8fcd8a6ce689d79fde6f17f0c8c4ebf63ea

    Comments

    Add metrics for OobeConfigRestoreResult
    
    - Adds enum histogram for OobeConfigRestoreResult which represents the
    result from attempting to restore a users data during a rollback.
    - Emitting to this metric will happen via the ChomeOS Metrics Library
    
    Bug: chromium:881341
    Change-Id: Ie44eff2ad99a9a337638c9b473b0034ba838a387
    Reviewed-on: https://chromium-review.googlesource.com/c/1407115
    Reviewed-by: Steven Holte <holte@chromium.org>
    Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
    Commit-Queue: Bailey Berro <baileyberro@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623526}

    Changed files

    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml

43. [Chromeshine] Create a PageViewObserver from ChromeTabbedActivity

    Changed by	Patrick Noland - pnolandohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:36:13 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	f8789c8229e2acf81cad44cd55213519380d62f1

    Comments

    [Chromeshine] Create a PageViewObserver from ChromeTabbedActivity
    
    This will start tracking per-domain start and stop events for Q devices
    
    Bug: 920503
    Change-Id: Iacefed19a7371d0921fed6d9167eb29f7cd1550d
    Reviewed-on: https://chromium-review.googlesource.com/c/1415931
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Patrick Noland <pnoland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623525}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

44. [FileSystem]: Use WeakPtr in FileWriterImpl where appropriate.

    Changed by	Marijn Kruisselbrink - mekohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:26:36 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	b3a4ffd0f73f61034a548f0ee825b1862644b471

    Comments

    [FileSystem]: Use WeakPtr in FileWriterImpl where appropriate.
    
    Bug: 922677
    Change-Id: Icd9466fb40cc54e94ffc612801bd73f2e59338ca
    Reviewed-on: https://chromium-review.googlesource.com/c/1416630
    Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
    Reviewed-by: Victor Costan <pwnall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623524}

    Changed files

    • storage/browser/fileapi/file_writer_impl.cc
    • storage/browser/fileapi/file_writer_impl.h

45. [Media Notification] Fix bug in binding

    Changed by	Becca Hughes - beccahughesohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:25:28 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	3fade378df58860293bc54af79de47cf9c54b40f

    Comments

    [Media Notification] Fix bug in binding
    
    Fix mojo binding in ash::MediaNotificationController.
    
    BUG=897836
    
    Change-Id: I9ba23b10d6078cc99d58ba8e09487e9cc8a310bd
    Reviewed-on: https://chromium-review.googlesource.com/c/1410012
    Commit-Queue: Becca Hughes <beccahughes@chromium.org>
    Reviewed-by: Tommy Steimel <steimel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623523}

    Changed files

    • ash/media/media_notification_controller.cc

46. ozone: scenic: Make software output work with VizDisplayCompositor

    Changed by	Michael Spang - spangohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:25:04 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	6cae8f663715cfc50ec37bff06df0cd04c6193fb

    Comments

    ozone: scenic: Make software output work with VizDisplayCompositor
    
    This makes software output work from Viz on Fuchsia by allowing creation
    of surfaces from non "main" threads. Previously we assumed that the
    thread that ran our initializer was the only one creating any surfaces,
    which were the browser UI and Viz GPU threads. This assumption does not
    hold in Viz display compositor's software path.
    
    Since we use mojo and mojo proxy objects are thread hostile, a couple of
    operations are now posted to the thread that runs the initializer ("main"
    thread).
    
      - Creation of sessions via the master scenic FIDL endpoint
      - Messaging to the browser to attach scenic surfaces to their parents
    
    These are infrequent operations so it shouldn't be a performance concern.
    
    Locking is used to protect the surface map. Surfaces are still thread
    hostile, but software surfaces can now be created from any thread as long
    as they are used and destroyed on the same thread.
    
    Bug: 922242
    Test: run_content_shell --enable-features=VizDisplayCompositor on fuchsia
    
    Change-Id: I7acba0d3cc03ac27825616bec40d86f682d4bf62
    Reviewed-on: https://chromium-review.googlesource.com/c/1413658
    Commit-Queue: Michael Spang <spang@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623522}

    Changed files

    • ui/ozone/platform/scenic/scenic_surface.cc
    • ui/ozone/platform/scenic/scenic_surface.h
    • ui/ozone/platform/scenic/scenic_surface_factory.cc
    • ui/ozone/platform/scenic/scenic_surface_factory.h
    • ui/ozone/platform/scenic/vulkan_implementation_scenic.cc

47. [omnibox] Condition accessibility call

    Changed by	Kevin Bailey - krbohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:24:13 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	33c72e13ece49c36938905cb6d87fbf15e9a0cfb

    Comments

    [omnibox] Condition accessibility call
    
    An added call is apparently triggering IME misbehavior. Condition the
    call to only when it is needed.
    
    Bug: 896962
    Change-Id: I9bfb9aa702d5860f5274c78f9e8f0bb37109f685
    Reviewed-on: https://chromium-review.googlesource.com/c/1413882
    Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
    Commit-Queue: Kevin Bailey <krb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623521}

    Changed files

    • components/omnibox/browser/omnibox_popup_model.cc

48. WebBluetooth - Scanning should use the same device id hashing as Gatt.

    Changed by	Doug Turner - dougtohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:21:55 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	10051dfc9a7ae9a9534a238ea46748230b43f370

    Comments

    WebBluetooth - Scanning should use the same device id hashing as Gatt.
    
    This CL adds a new method to WebBluetoothDeviceId which allows us to
    create a device id from a device address without adding any services
    which allows scanning to share the same device address -> device id
    origin specific mapping.
    
    Bug: 897312
    Change-Id: Ib3dda1c2d47138486c1457eb25a8dc602b52e2f0
    Reviewed-on: https://chromium-review.googlesource.com/c/1405368
    Commit-Queue: Doug Turner <dougt@chromium.org>
    Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623520}

    Changed files

    • content/browser/bluetooth/bluetooth_allowed_devices.cc
    • content/browser/bluetooth/bluetooth_allowed_devices.h
    • content/browser/bluetooth/web_bluetooth_service_impl.cc
    • content/common/bluetooth/web_bluetooth_device_id.cc
    • content/common/bluetooth/web_bluetooth_device_id.h
    • third_party/blink/web_tests/bluetooth/requestLEScan/attempt-to-connect-after-scan.https.html
    • third_party/blink/web_tests/bluetooth/requestLEScan/device-ids-match.https.html

49. Reland of: Condition DRP and connection check from prefetcher

    Changed by	Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:21:03 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	02025fd01627d5a6c7a109c476c4faab4cebc17d

    Comments

    Reland of: Condition DRP and connection check from prefetcher
    
    A previous CL added logic to enable link-rel: prefetch
    when "PredictivePrefetchingAllowedOnAllConnectionTypes"
    experiment is enabled (see change 1350210).
    
    This CL applies the same logic for prefetches initiated by
    external Android apps. This brings Android APIs in-par with
    Chrome's logic.
    
    The original CL for this got reverted. This is a reland.
    
    Bug: 850609,914503
    Change-Id: Ib26fb6be50fdc4a1fd8de9bc22c92d456141bbdb
    TBR: alexilin@chromium.org,lizeb@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/c/1414292
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623519}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
    • chrome/browser/android/chrome_feature_list.cc

50. Add USB Bouncer feature flag for Chrome OS.

    Changed by	Allen Webb - allenwebbohnoyoudont@google.com
    Changed at	Thursday, 17-Jan-19 02:20:40 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	8f7286f1d05e133332e8c892d1a9673f364d2f3c

    Comments

    Add USB Bouncer feature flag for Chrome OS.
    
    This adds the USB Bouncer feature flag that controls whether or not a
    user specific USB device whitelist will be used for generating the
    policy for USB Guard.
    
    BUG=chromium:921058
    
    Change-Id: I99e8461ad81eb8f70671c7bc031b1509e61b23bf
    Reviewed-on: https://chromium-review.googlesource.com/c/1384263
    Commit-Queue: Allen Webb <allenwebb@google.com>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Reviewed-by: Mattias Nissler <mnissler@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623518}

    Changed files

    • chrome/browser/chromeos/dbus/chrome_features_service_provider.cc
    • chrome/common/chrome_features.cc
    • chrome/common/chrome_features.h

51. Roll src/third_party/pdfium 28cfe34a89f2..283677fb5329 (2 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Thursday, 17-Jan-19 02:19:27 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	ad32fcfdb469aa42029977ec72b7341fffafd25e

    Comments

    Roll src/third_party/pdfium 28cfe34a89f2..283677fb5329 (2 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/28cfe34a89f2..283677fb5329
    
    
    git log 28cfe34a89f2..283677fb5329 --date=short --no-merges --format='%ad %ae %s'
    2019-01-16 tsepez@chromium.org Don't check null returns from CFX_FontMgr::GetBuiltinMapper().
    2019-01-16 tsepez@chromium.org Pass out parameter to GetTextNode() by pointer, not reference
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@283677fb5329
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I348e1864779f1ef90d249c9c10744470a185dcce
    Reviewed-on: https://chromium-review.googlesource.com/c/1415973
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623517}

    Changed files

    • DEPS

52. [App Management] Implement Pin to Shelf.

    Changed by	Reka Norman - rekanormanohnoyoudont@google.com
    Changed at	Thursday, 17-Jan-19 02:19:11 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	5235b08f05b13b6b7e81a748824358f5be8447d8

    Comments

    [App Management] Implement Pin to Shelf.
    
    This CL implements pinning apps to the shelf from the app management
    page, by making the PageHandler a ShelfModelObserver. Since the shelf
    only exists on Chrome OS, this required creating a Chrome OS specific
    subclass of the the PageHandler (AppManagementPageHandlerCros) to
    handle the shelf-related functionality.
    
    Bug: 906508
    Change-Id: I135c0aab5c1ffaaa76e9d1f094c880ab53cd7562
    Reviewed-on: https://chromium-review.googlesource.com/c/1410954
    Commit-Queue: Reka Norman <rekanorman@google.com>
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
    Reviewed-by: calamity <calamity@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623516}

    Changed files

    • chrome/browser/resources/app_management/BUILD.gn
    • chrome/browser/resources/app_management/constants.js
    • chrome/browser/resources/app_management/fake_page_handler.js
    • chrome/browser/resources/app_management/metadata_view.html
    • chrome/browser/resources/app_management/metadata_view.js
    • chrome/browser/resources/app_management/permission_item.js
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/webui/app_management/app_management.mojom
    • chrome/browser/ui/webui/app_management/app_management_page_handler.cc
    • chrome/browser/ui/webui/app_management/app_management_page_handler.h
    • chrome/browser/ui/webui/app_management/app_management_shelf_delegate_chromeos.cc
    • chrome/browser/ui/webui/app_management/app_management_shelf_delegate_chromeos.h

53. Roll src/third_party/depot_tools 4d9f86da4d62..d1dba6482b22 (6 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Thursday, 17-Jan-19 02:14:37 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	9fa365b7afb68af316e4b398363f7ad5f21aaf59

    Comments

    Roll src/third_party/depot_tools 4d9f86da4d62..d1dba6482b22 (6 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4d9f86da4d62..d1dba6482b22
    
    
    git log 4d9f86da4d62..d1dba6482b22 --date=short --no-merges --format='%ad %ae %s'
    2019-01-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2019-01-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2019-01-16 maruel@chromium.org roll-dep: use Middle Out Compression™️ for logs
    2019-01-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2019-01-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2019-01-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@d1dba6482b22
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=agable@chromium.org
    
    Change-Id: Ibd855770498bc6a3f111d04a97a67e479b45c842
    Reviewed-on: https://chromium-review.googlesource.com/c/1415583
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623515}

    Changed files

    • DEPS

54. Mark virtual/threaded/synthetic_gestures/synthetic-pinch-zoom-gesture-touchpad-zoom-in-slow.html as flaky

    Changed by	Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:14:33 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	17b48d789ac6ffcdcf4340dd11c2ed56ab19fd48

    Comments

    Mark virtual/threaded/synthetic_gestures/synthetic-pinch-zoom-gesture-touchpad-zoom-in-slow.html as flaky
    
    It's failing on Mac10.13 Tests (dbg) bot too.
    
    TBR=mcnee@chromium.org,masonfreed@chromium.org
    
    No-Try: true
    Bug: 922508
    Change-Id: I3e0748250a9002f1854247aa4962b11f0a40671a
    Reviewed-on: https://chromium-review.googlesource.com/c/1415233
    Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623514}

    Changed files

    • third_party/blink/web_tests/TestExpectations

55. Use EGL_GL_COLORSPACE_DISPLAY_P3_PASSTHROUGH_EXT where available

    Changed by	Eric Karl - ericrkohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:12:00 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	ad9084480bfd6b856d324c0e10017874525cbfde

    Comments

    Use EGL_GL_COLORSPACE_DISPLAY_P3_PASSTHROUGH_EXT where available
    
    Chrome relied on incorrect Android behavior when dealing with P3
    colorspace and framebuffer_srgb interactions. This behavior was
    fixed in Q, which causes invalid Chrome rendering when using wide
    gamut.
    
    See https://www.khronos.org/registry/EGL/extensions/EXT/EGL_EXT_gl_colorspace_display_p3_passthrough.txt
    
    Android introduced an extension to restore P behavior when using
    Q. This patch makes use of this extension.
    
    Bug: 884376
    Change-Id: I7a932edb79920e76a466bc3fadf27f4e55ce960a
    Reviewed-on: https://chromium-review.googlesource.com/c/1413410
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Commit-Queue: Eric Karl <ericrk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623513}

    Changed files

    • ui/gl/gl_surface_egl.cc

56. Release SkImage on GPU main thread

    Changed by	Jonathan Backer - backerohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:05:50 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	0987095c1280d5ba5484de09a466537fca9da916

    Comments

    Release SkImage on GPU main thread
    
    This CL changes it so that promise images are released on the main
    GPU thread with the appropriate GL context current.
    
    It also holds onto the SharedImageRepresentationSkia so that we have
    a ref-count on the SharedImage. This prevents a client from deleting
    the SharedImage until we DestroySkImage.
    
    Change-Id: Ic5f7fd29ee24e2bc0b2d325a1d6fc0624ead5219
    Reviewed-on: https://chromium-review.googlesource.com/c/1413338
    Commit-Queue: Jonathan Backer <backer@chromium.org>
    Reviewed-by: Peng Huang <penghuang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623512}

    Changed files

    • components/viz/service/display/display_resource_provider.cc
    • components/viz/service/display/display_resource_provider.h
    • components/viz/service/display/display_resource_provider_unittest.cc
    • components/viz/service/display/skia_output_surface.h
    • components/viz/service/display/skia_renderer.cc
    • components/viz/service/display_embedder/skia_output_surface_impl.cc
    • components/viz/service/display_embedder/skia_output_surface_impl.h
    • components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
    • components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.h

57. AW: apply the X-Requested-With header to all requests

    Changed by	Nate Fischer - ntfschrohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 02:05:45 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	8824b758b35c2c44deba77d57ac468143acc61aa

    Comments

    AW: apply the X-Requested-With header to all requests
    
    No change to default code path, only network-service path.
    
    The current code path adds the X-Requested-With header to every outgoing
    request. This CL does the same for the network service code path.
    
    This also adds tests, since this was previously uncovered. We filter out
    one test for the mojo bot because loadUrl() currently doesn't work with
    extra headers (which the test relies on).
    
    R=timvolodine@chromium.org, torne@chromium.org
    
    Bug: 922300
    Test: run_webview_instrumentation_test_apk -f AwNetworkConfigurationTest#testRequestedWith*
    Change-Id: Ia9cc5f5629b7c8105d036457cbd5805120ed7e6d
    Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo
    Reviewed-on: https://chromium-review.googlesource.com/c/1413692
    Reviewed-by: Richard Coles <torne@chromium.org>
    Commit-Queue: Nate Fischer <ntfschr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623511}

    Changed files

    • android_webview/browser/aw_proxying_url_loader_factory.cc
    • android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java
    • android_webview/javatests/src/org/chromium/android_webview/test/AwNetworkConfigurationTest.java
    • android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java
    • testing/buildbot/filters/mojo.fyi.network_webview_instrumentation_test_apk.filter

58. Disable FontUniqueNameLookupTest.TestMatchPostScriptNameTtc for Android Things

    Changed by	Nathaniel Steinbock - steinbockohnoyoudont@google.com
    Changed at	Thursday, 17-Jan-19 02:02:58 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	953ac315b3978f8f11a23f480d6177d976265eab

    Comments

    Disable FontUniqueNameLookupTest.TestMatchPostScriptNameTtc for Android Things
    
    This tests that specific fonts are contained within the Android system font
    files. These fonts are only included optionally in Android things builds, so
    disable the test for those builds.
    
    Bug: internal 122917748
    Change-Id: Icad69225f2e5ccd18e29e8a926d76e8d09e47b84
    Reviewed-on: https://chromium-review.googlesource.com/c/1412826
    Commit-Queue: Nate Steinbock <steinbock@google.com>
    Reviewed-by: Sergey Volk <servolk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623510}

    Changed files

    • chromecast/BUILD.gn

59. RasterDecoder: simplify CopySubTexture

    Changed by	Antoine Labour - pimanohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 01:59:39 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	9ddf6ac09b41512336d3cc815e09e26f8670d2ea

    Comments

    RasterDecoder: simplify CopySubTexture
    
    CreateAndConsumeTextureINTERNAL and DeleteTexturesINTERNAL are only
    used in combination with CopySubTexture, so we can merge all 3
    commands into a single one. This in turns simplifies the service
    side, as we don't need to create TextureRefs.
    
    Bug: 829435
    Change-Id: Ie5a616ea57c6dd92c5ac8854af92878bec20c271
    Reviewed-on: https://chromium-review.googlesource.com/c/1413618
    Commit-Queue: Antoine Labour <piman@chromium.org>
    Reviewed-by: Jonathan Backer <backer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623509}

    Changed files

    • gpu/command_buffer/build_raster_cmd_buffer.py
    • gpu/command_buffer/client/raster_cmd_helper_autogen.h
    • gpu/command_buffer/client/raster_implementation.cc
    • gpu/command_buffer/common/raster_cmd_format_autogen.h
    • gpu/command_buffer/common/raster_cmd_format_test_autogen.h
    • gpu/command_buffer/common/raster_cmd_ids_autogen.h
    • gpu/command_buffer/raster_cmd_buffer_functions.txt
    • gpu/command_buffer/service/copy_texture_chromium_mock.h
    • gpu/command_buffer/service/decoder_context.h
    • gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc
    • gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h
    • gpu/command_buffer/service/gles2_cmd_decoder.cc
    • gpu/command_buffer/service/gles2_cmd_decoder_mock.h
    • gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
    • gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
    • gpu/command_buffer/service/gles2_cmd_srgb_converter.cc
    • gpu/command_buffer/service/gles2_cmd_srgb_converter.h
    • gpu/command_buffer/service/raster_decoder.cc
    • gpu/command_buffer/service/raster_decoder_autogen.h
    • gpu/command_buffer/service/raster_decoder_mock.h
    • gpu/command_buffer/service/raster_decoder_unittest.cc
    • gpu/command_buffer/service/raster_decoder_unittest_base.cc
    • gpu/command_buffer/service/raster_decoder_unittest_base.h
    • gpu/command_buffer/service/raster_decoder_unittest_context_lost.cc
    • gpu/command_buffer/service/texture_manager.cc
    • gpu/command_buffer/service/texture_manager.h
    • gpu/command_buffer/service/webgpu_decoder.cc

60. Disable CronetStructTest.TestCronet_DateTime on MSAN

    Changed by	Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 01:55:12 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	fb3f19cdcdf1a1787e727f2d1675facdce88f243

    Comments

    Disable CronetStructTest.TestCronet_DateTime on MSAN
    
    TBR=caraitto@chromium.org,pauljensen@chromium.org,mef@chromium.org
    
    No-Try: true
    Bug: 922842
    Change-Id: I483fe6cfc7a8fbb77f53b15e6de898e6d1c469ce
    Reviewed-on: https://chromium-review.googlesource.com/c/1415053
    Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623508}

    Changed files

    • components/cronet/native/generated/cronet.idl_impl_struct_unittest.cc

61. Reland "[Animation Worklet] Throw upon constructing WorkletAnimation for unregistered animator"

    Changed by	Yi Gu - yiguohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 01:52:44 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	a0e5541641b1c252ce6e7fc4d1cb6a2a454abfba

    Comments

    Reland "[Animation Worklet] Throw upon constructing WorkletAnimation for unregistered animator"
    
    This reverts commit 304e0d5a9053b04bef7e4f277aae0aa6e5ce785a.
    
    Reason for revert: The revert was in build 30164 but the memory leak was gone before that. [1] The reverted patch actually didn't touch the path that was in the crash report.
    [1] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Leak%20Detection%20Linux?limit=200
    
    Original change's description:
    > Revert "[Animation Worklet] Throw upon constructing WorkletAnimation for unregistered animator"
    >
    > This reverts commit b48a21c421756109b23f9cb9c639be6c48d371a0.
    >
    > Reason for revert: Memory leaks, see crbug.com/875262
    >
    > Original change's description:
    > > [Animation Worklet] Throw upon constructing WorkletAnimation for unregistered animator
    > >
    > > Currently the WorkletAnimation construction silently fails if the
    > > animator has not yet been registered. Similar to AudioWorklet, the
    > > proper way of handling such scenario is throwing an exception.
    > >
    > > Bug: 875262
    > > Change-Id: I1be22f1b8c07b5e83b4071b92a70f991449874a5
    > > Reviewed-on: https://chromium-review.googlesource.com/c/1403930
    > > Commit-Queue: Yi Gu <yigu@chromium.org>
    > > Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    > > Reviewed-by: Majid Valipour <majidvp@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#622741}
    >
    > TBR=jbroman@chromium.org,majidvp@chromium.org,yigu@chromium.org
    >
    > Change-Id: I23ef3c2bb7d3605f17b8be5fdbc447dc2b9401c2
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 875262
    > Reviewed-on: https://chromium-review.googlesource.com/c/1411334
    > Reviewed-by: Dominic Battré <battre@chromium.org>
    > Commit-Queue: Dominic Battré <battre@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#622781}
    
    TBR=battre@chromium.org,jbroman@chromium.org,majidvp@chromium.org,yigu@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 875262
    Change-Id: I108089ad956f31c920a352608553d374cc677e89
    Reviewed-on: https://chromium-review.googlesource.com/c/1415831
    Commit-Queue: Yi Gu <yigu@chromium.org>
    Reviewed-by: Yi Gu <yigu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623507}

    Changed files

    • third_party/blink/renderer/core/animation/worklet_animation_controller.cc
    • third_party/blink/renderer/core/animation/worklet_animation_controller.h
    • third_party/blink/renderer/modules/animationworklet/animation_worklet_global_scope.cc
    • third_party/blink/renderer/modules/animationworklet/animation_worklet_global_scope_test.cc
    • third_party/blink/renderer/modules/animationworklet/animation_worklet_proxy_client.cc
    • third_party/blink/renderer/modules/animationworklet/animation_worklet_proxy_client.h
    • third_party/blink/renderer/modules/animationworklet/worklet_animation.cc
    • third_party/blink/renderer/modules/animationworklet/worklet_animation_test.cc
    • third_party/blink/renderer/platform/graphics/animation_worklet_mutator_dispatcher_impl.cc
    • third_party/blink/renderer/platform/graphics/animation_worklet_mutator_dispatcher_impl.h
    • third_party/blink/renderer/platform/graphics/compositor_mutator_client.h
    • third_party/blink/renderer/platform/graphics/main_thread_mutator_client.cc
    • third_party/blink/renderer/platform/graphics/main_thread_mutator_client.h
    • third_party/blink/renderer/platform/graphics/mutator_client.h
    • third_party/blink/web_tests/animations/animationworklet/scroll-timeline-dispose.html
    • third_party/blink/web_tests/animations/animationworklet/worklet-animation-creation.html

62. ChromeOS pin keyboard: Fix newly found Closure compilation error.

    Changed by	dpapad - dpapadohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 01:51:42 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	30faaba26cc0fa9230e482b1fab778fab111fa87

    Comments

    ChromeOS pin keyboard: Fix newly found Closure compilation error.
    
    Overriding the native HTMLElement focus() method and changing its
    signature is causing a compilation error, with the latest version of the
    Closure compiler.
    
    Fix by renaming the method to focusInput() which also reflects better
    what it actually does.
    
    Bug: 922671
    Change-Id: I050caac0e6139eeb1826ddc726f70e349750ca9f
    Reviewed-on: https://chromium-review.googlesource.com/c/1416532
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623506}

    Changed files

    • ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.html
    • ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.js
    • ui/webui/resources/cr_components/chromeos/quick_unlock/setup_pin_keyboard.js

63. Verify |request_initiator| in AppCacheSubresourceURLFactory.

    Changed by	Lukasz Anforowicz - lukaszaohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 01:51:27 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	288027b6b3bc6e41df98ae24d376907692669463

    Comments

    Verify |request_initiator| in AppCacheSubresourceURLFactory.
    
    Compromised renderers can spoof ResourceRequest::request_initiator and
    pretend to be initiating a request on behalf of a victim origin.  This
    CL ensures that such attempt will be caught and result in terminating
    the renderer process (for requests handled by AppCacheSubresourceURLFactory).
    
    Before this CL, URLLoaderInterceptor was intercepting requests as they were
    sent from AppCacheSubresourceURLFactory to the NetworkService.  This wasn't
    sufficient for testing the compromised renderer scenario, where the test needs
    to inject a spoofed origin into a request made from the renderer, *before* the
    request reaches AppCacheSubresourceURLFactory.  The CL accomplishes this, by
    having RenderFrameHostImpl inject a g_create_network_factory_callback_for_test
    both for 1) AppCache and 2) NetworkService factories.
    
    The CL also takes the MojoBadMessageObserver class from
    security_exploit_browertest.cc, makes it general-purpose and exposes it via
    //mojo/public/cpp/test_support.
    
    Bug: 910287
    Change-Id: I665acf336e5c84533e2f5dd88769d88e3f9037ed
    Reviewed-on: https://chromium-review.googlesource.com/c/1410149
    Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Joshua Bell <jsbell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623505}

    Changed files

    • content/browser/appcache/appcache_host.h
    • content/browser/appcache/appcache_subresource_url_factory.cc
    • content/browser/background_fetch/background_fetch_service_unittest.cc
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/loader/cross_site_document_blocking_browsertest.cc
    • content/browser/renderer_host/web_database_host_impl_unittest.cc
    • content/browser/security_exploit_browsertest.cc
    • content/browser/url_loader_factory_getter.cc
    • content/browser/url_loader_factory_getter.h
    • content/public/test/url_loader_interceptor.cc
    • content/test/BUILD.gn
    • mojo/public/cpp/test_support/BUILD.gn
    • mojo/public/cpp/test_support/lib/DEPS
    • mojo/public/cpp/test_support/lib/test_utils.cc
    • mojo/public/cpp/test_support/test_utils.h

64. media/gpu/test: Add per-test setup and teardown to the video decoder tests.

    Changed by	David Staessens - dstaessensohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 01:48:15 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	fbf9aac90ae1f8d6250ac5e753b733e60816e780

    Comments

    media/gpu/test: Add per-test setup and teardown to the video decoder tests.
    
    This CL adds per-test setup and teardown to the video decoder tests. This allows
    us to remove some setters and move arguments to the constructors of the video
    player and video frame validator.
    
    TEST=ran new VDA tests on nocturne
    
    BUG=879065
    
    Change-Id: If6e070fcd684d8fffe0bf9c7a553191a247165f3
    Reviewed-on: https://chromium-review.googlesource.com/c/1412095
    Commit-Queue: David Staessens <dstaessens@chromium.org>
    Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623504}

    Changed files

    • media/gpu/test/video_frame_validator.cc
    • media/gpu/test/video_frame_validator.h
    • media/gpu/test/video_player/video_decoder_client.cc
    • media/gpu/test/video_player/video_decoder_client.h
    • media/gpu/test/video_player/video_player.cc
    • media/gpu/test/video_player/video_player.h
    • media/gpu/video_decode_accelerator_tests.cc

65. Fix memory leak in the media internals UMA handler

    Changed by	Ted Meyer - tmathmeyerohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 01:45:11 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	5360b2b42b2d999c71542fba203cf0ffb447d5b5

    Comments

    Fix memory leak in the media internals UMA handler
    
    PIPELINE_STATE_CHANGED events processed after WEBMEDIAPLAYER_DESTROYED
    events were causing a buildup of PipelineInfo structs, eventually
    causing out of memory errors. This change just drops all changed events
    while there is no player.
    
    Bug: 885385
    Change-Id: I87db8a31063b5187b7d0e2d1d3430a3abb13acd2
    Reviewed-on: https://chromium-review.googlesource.com/c/1414591
    Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623503}

    Changed files

    • content/browser/media/media_internals.cc

66. Automatic PPD resolution for manually added printers

    Changed by	Luum Habtemariam - luumohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 01:41:26 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	eff3bfcdf6b7983e1de3e4dec12778abbfd7dca9

    Comments

    Automatic PPD resolution for manually added printers
    
    Now after the initial IPP Query of the manual printer, we run PPD
    matching before sending the user to the make and model drop-down screen.
    
    Bug: none
    Test: TBD
    Change-Id: Ib71f1f4477376c72345de446a27ee1b0daf56d07
    Reviewed-on: https://chromium-review.googlesource.com/c/1407198
    Commit-Queue: Luum Habtemariam <luum@chromium.org>
    Reviewed-by: Dan Beam <dbeam@chromium.org>
    Reviewed-by: Sean Kau <skau@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623502}

    Changed files

    • chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
    • chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
    • chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
    • chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h
    • chrome/test/data/webui/settings/cups_printer_page_tests.js

67. Enable Android fix flow for beta

    Changed by	Lakshmi Kumar Dabbiru - dlkumarohnoyoudont@google.com
    Changed at	Thursday, 17-Jan-19 01:36:46 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	9d390762bb98907f61da137adefff48aea904e2d

    Comments

    Enable Android fix flow for beta
    
    Approved for beta
    
    Bug: 917482
    Change-Id: I50ed819fe63227ef26fabaa59a25afb788337358
    Reviewed-on: https://chromium-review.googlesource.com/c/1410278
    Reviewed-by: Jesse Doherty <jwd@chromium.org>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
    Cr-Commit-Position: refs/heads/master@{#623501}

    Changed files

    • testing/variations/fieldtrial_testing_config.json

68. Move all modelutil files to ui/

    Changed by	Becky Zhou - huayinzohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 01:30:06 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	66da10391a062d466016d7655d6dc9d24a7c4aa6

    Comments

    Move all modelutil files to ui/
    
    Bug: 899318
    Change-Id: Ice52111542afcaeee3bf3f1766d38faf74ec3d90
    Reviewed-on: https://chromium-review.googlesource.com/c/1413115
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Becky Zhou <huayinz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623500}

    Changed files

    • chrome/android/java/res/values/ids.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessoryPagerAdapter.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetProperties.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetTabModel.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetTabViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMediator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMetricsRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryProperties.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryTabLayoutCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryTabLayoutMediator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryTabLayoutProperties.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryTabLayoutViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetMediator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetModernViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ClusterList.java
    • chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsAdapter.java
    • chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ToolbarCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ToolbarViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/empty/EmptyCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/empty/EmptyViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/FilterCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/FilterViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/chips/ChipsCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/chips/ChipsViewHolder.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/list/BatchListModel.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/list/DateOrderedListView.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/list/DateOrderedListViewAdapter.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/list/DecoratedListItemModel.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/list/ListPropertyViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/ListItemViewHolder.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/storage/StorageCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/explore_sites/CategoryCardAdapter.java
    • chrome/android/java/src/org/chromium/chrome/browser/explore_sites/CategoryCardViewHolderFactory.java
    • chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryCardView.java
    • chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/modaldialog/AppModalPresenter.java
    • chrome/android/java/src/org/chromium/chrome/browser/modaldialog/ModalDialogViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/modaldialog/TabModalPresenter.java
    • chrome/android/java/src/org/chromium/chrome/browser/modelutil/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/PartiallyBindable.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
    • chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBarCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBarViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/omnibox/status/StatusViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/omnibox/status/StatusViewCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionListViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/basic/SuggestionViewViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherButtonCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherButtonViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/bottom/BrowsingModeBottomToolbarCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/bottom/BrowsingModeBottomToolbarViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/bottom/TabSwitcherBottomToolbarCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/bottom/TabSwitcherBottomToolbarViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrModalPresenter.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetTabViewTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetViewTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryTabLayoutViewTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryViewTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/modaldialog/ModalDialogViewTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/TileGridLayoutTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetControllerTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryControllerTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryTabLayoutControllerTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetControllerTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/download/home/list/DateOrderedListMutatorTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/modelutil/OWNERS
    • chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java
    • chrome/test/android/BUILD.gn
    • chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/ContentSuggestionsTestUtils.java
    • ui/android/BUILD.gn
    • ui/android/java/res/values/ids.xml
    • ui/android/java/res/values/values.xml
    • ui/android/java/src/org/chromium/ui/modelutil/ForwardingListObservable.java
    • ui/android/java/src/org/chromium/ui/modelutil/LazyConstructionPropertyMcp.java
    • ui/android/java/src/org/chromium/ui/modelutil/ListModel.java
    • ui/android/java/src/org/chromium/ui/modelutil/ListModelBase.java
    • ui/android/java/src/org/chromium/ui/modelutil/ListModelChangeProcessor.java
    • ui/android/java/src/org/chromium/ui/modelutil/ListObservable.java
    • ui/android/java/src/org/chromium/ui/modelutil/ListObservableImpl.java
    • ui/android/java/src/org/chromium/ui/modelutil/ModelListAdapter.java
    • ui/android/java/src/org/chromium/ui/modelutil/PropertyListModel.java
    • ui/android/java/src/org/chromium/ui/modelutil/PropertyModelChangeProcessor.java
    • ui/android/java/src/org/chromium/ui/modelutil/RecyclerViewAdapter.java
    • ui/android/java/src/org/chromium/ui/modelutil/SimpleList.java
    • ui/android/java/src/org/chromium/ui/modelutil/SimpleRecyclerViewMcp.java
    • ui/android/java/src/org/chromium/ui/modelutil/SimpleRecyclerViewMcpBase.java
    • ui/android/javatests/src/org/chromium/ui/test/util/modelutil/FakeViewProvider.java
    • ui/android/junit/src/org/chromium/ui/modelutil/LazyConstructionPropertyMcpTest.java
    • ui/android/junit/src/org/chromium/ui/modelutil/PropertyModelTest.java
    • ui/android/junit/src/org/chromium/ui/modelutil/SimpleListObservableTest.java

69. Add histogram to track how far user followed reopen tab IPH promo

    Changed by	Collin Baker - collinbakerohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 01:23:14 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	1741332b9a44460cb2f9cab2d8a5c0ff6aecc880

    Comments

    Add histogram to track how far user followed reopen tab IPH promo
    
    This adds UMA logging for the last step of reopen tab IPH a user
    completed. This also adds a new OnExecuteCommand method to
    AppMenuObserver which is necessary for ReopenTabPromoController to
    determine whether IPH was completed successfully.
    
    Bug: 910356
    Change-Id: I8280198b285324f12d10f31d334632fbad77b66b
    Reviewed-on: https://chromium-review.googlesource.com/c/1391423
    Reviewed-by: Mark Pearson <mpearson@chromium.org>
    Reviewed-by: Peter Boström <pbos@chromium.org>
    Commit-Queue: Collin Baker <collinbaker@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623499}

    Changed files

    • chrome/browser/ui/views/feature_promos/reopen_tab_promo_controller.cc
    • chrome/browser/ui/views/feature_promos/reopen_tab_promo_controller.h
    • chrome/browser/ui/views/toolbar/app_menu.cc
    • chrome/browser/ui/views/toolbar/app_menu_observer.h
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml

70. Add new language detection DumpAXTreeTest.

    Changed by	Akihiro Ota - akihirootaohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 01:21:53 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	10cc14fa68db698c4c9bc5539c15dbecfcc898b3

    Comments

    Add new language detection DumpAXTreeTest.
    
    Tests the case of a language-switch mid-paragraph.
    
    Change-Id: Ic2a650a16c8fa7a26d5386ffad598fdd3ffee465
    Reviewed-on: https://chromium-review.googlesource.com/c/1412938
    Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623498}

    Changed files

    • content/browser/accessibility/dump_accessibility_tree_browsertest.cc
    • content/test/data/accessibility/language-detection/lang-attribute-switching-expected-blink.txt
    • content/test/data/accessibility/language-detection/lang-attribute-switching-expected-mac.txt
    • content/test/data/accessibility/language-detection/lang-attribute-switching-expected-win.txt
    • content/test/data/accessibility/language-detection/lang-attribute-switching.html

71. fido: only request direct attestation from Windows when necessary

    Changed by	Martin Kreichgauer - martinkrohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 01:21:28 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	a9abd0dbbd53d26af345e566a308051bf8843430

    Comments

    fido: only request direct attestation from Windows when necessary
    
    The WinWebAuthnApiAuthenticator currently always requests DIRECT attestation
    from the Windows WebAuthn API and relies on AuthenticatorImpl to strip the
    attestation statement later if necessary. This changes the behavior to only
    request attestation when actually requested by the RP in order to avoid
    unneccessarily generating an attestation signature in cases where that is
    computationally expensive.
    
    Bug: 921155
    Change-Id: I2f39f5e85ea2be56cff1df87bc5464374dabf911
    Reviewed-on: https://chromium-review.googlesource.com/c/1414310
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Adam Langley <agl@chromium.org>
    Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623497}

    Changed files

    • content/browser/webauth/authenticator_impl.cc
    • content/browser/webauth/authenticator_impl.h
    • content/browser/webauth/authenticator_type_converters.cc
    • content/browser/webauth/authenticator_type_converters.h
    • device/fido/ctap_make_credential_request.cc
    • device/fido/ctap_make_credential_request.h
    • device/fido/fido_constants.h
    • device/fido/u2f_command_constructor.cc
    • device/fido/u2f_register_operation_unittest.cc
    • device/fido/win/authenticator.cc
    • device/fido/win/type_conversions.cc
    • device/fido/win/type_conversions.h

72. Disable ChildProcessSecurityPolicyTest.DynamicIsolatedOrigins on Fuchsia

    Changed by	Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 01:20:38 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	97250d12107aa37ca1fcc68b6d0d252525d0aaaf

    Comments

    Disable ChildProcessSecurityPolicyTest.DynamicIsolatedOrigins on Fuchsia
    
    TBR=alexmos@chromium.org,creis@chromium.org,lukasza@chromium.org
    
    No-Try: true
    Bug: 922732
    Change-Id: Ic3d35731508e7d8e1365e317a31a787526a3e220
    Reviewed-on: https://chromium-review.googlesource.com/c/1415052
    Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623496}

    Changed files

    • content/browser/child_process_security_policy_unittest.cc

73. Roll src/third_party/chromite 6f796241e4b8..7f4fca60eabb (7 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Thursday, 17-Jan-19 01:17:51 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	242cb201703b497611c6c47f7f2d8529b820eb38

    Comments

    Roll src/third_party/chromite 6f796241e4b8..7f4fca60eabb (7 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/6f796241e4b8..7f4fca60eabb
    
    
    git log 6f796241e4b8..7f4fca60eabb --date=short --no-merges --format='%ad %ae %s'
    2019-01-16 xixuan@chromium.org Revert "autotest: Force paygen test to run in autotest."
    2019-01-16 chrome-bot@chromium.org Update config settings by config-updater.
    2019-01-16 xixuan@google.com autotest: Force paygen test to run in autotest.
    2019-01-16 dburger@chromium.org Remove the unused configuration value critical_for_chrome
    2019-01-16 dhanyaganesh@chromium.org BuildStore: Redirect GetBuildStatus through BuildStore
    2019-01-16 dburger@chromium.org Remove the unused configuration value dev_manifest
    2019-01-16 chrome-bot@chromium.org Update config settings by config-updater.
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@7f4fca60eabb
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: Iad39785632410ccfe2ffb377a048084bd5f171be
    Reviewed-on: https://chromium-review.googlesource.com/c/1416319
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623495}

    Changed files

    • DEPS

74. Remove unused fields from PipelineInfo

    Changed by	Ted Meyer - tmathmeyerohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 01:15:08 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	61f4a44a36cbc1b4c36f963b05f646700cba46a1

    Comments

    Remove unused fields from PipelineInfo
    
    audio_codec_name and origin_url were unused, and have been removed.
    
    Bug: 920589
    Change-Id: Ie107259894c11391c4babb8c0e7e379f7476f2fa
    Reviewed-on: https://chromium-review.googlesource.com/c/1415693
    Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623494}

    Changed files

    • content/browser/media/media_internals.cc

75. WebUI: Add separator line back to dialogs for ChromeOS

    Changed by	John Lee - johntleeohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 01:14:58 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	abbf44639a673016e9b0b26dd10482c182de27ef

    Comments

    WebUI: Add separator line back to dialogs for ChromeOS
    
    With the way @apply works, the !important here was causing the
    border-bottom to always be the initial values of border-bottom
    (solid 1px transparent)[1] and override the bottom-border on
    scrollable bodies [2].
    
    [1] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html?q=cr_dialog.html&sq=package:chromium&g=0&l=117
    [2] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html?q=cr_dialog.html&sq=package:chromium&g=0&l=130
    
    Bug: 908015
    Change-Id: Ie0a5e72eb0f7d0beb724468d3d9f534ae79f6225
    Reviewed-on: https://chromium-review.googlesource.com/c/1413360
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: John Lee <johntlee@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623493}

    Changed files

    • chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_elements.html

76. [Audio Focus] Add prefer stop on suspend bit

    Changed by	Becca Hughes - beccahughesohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 01:13:38 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	89d725de0b7b0570fafd79be64f8904ab99c438d

    Comments

    [Audio Focus] Add prefer stop on suspend bit
    
    Add a bit to allow a media session to request Stop()
    instead of Suspend() when losing audio focus to an
    AudioFocusType::kGain session. This is only true for
    ARC++ sessions.
    
    This also splits out the debug mojo ptr error handler
    into a separate function to avoid breaking the observer
    if the debug mojo ptr disconnects.
    
    BUG=b:122817802
    
    Change-Id: Ie0100f12401af261357a3fd4626e3dcccf8621b9
    Reviewed-on: https://chromium-review.googlesource.com/c/1413358
    Reviewed-by: Tommy Steimel <steimel@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Becca Hughes <beccahughes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623492}

    Changed files

    • content/browser/media/media_internals_audio_focus_helper.cc
    • content/browser/media/media_internals_audio_focus_helper.h
    • services/media_session/audio_focus_manager.cc
    • services/media_session/audio_focus_manager.h
    • services/media_session/audio_focus_manager_unittest.cc
    • services/media_session/public/cpp/test/mock_media_session.cc
    • services/media_session/public/cpp/test/mock_media_session.h
    • services/media_session/public/mojom/media_session.mojom

77. s13n: Remove SigninManager-related includes from app_controller_mac.mm and its unittest

    Changed by	Gyuyoung Kim - gyuyoungohnoyoudont@igalia.com
    Changed at	Thursday, 17-Jan-19 01:12:48 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	fac5b1f2211b8323d145dc8cfbddc9594dc9fbaf

    Comments

    s13n: Remove SigninManager-related includes from app_controller_mac.mm and its unittest
    
    Clean up sign-in-related code in app_controller_mac.mm and app_controller_mac_unittest.mm
    because there are no uses of SigninManager.
    
    Bug: 920201
    Change-Id: I0466c2ccea572af4f60cc1fbbd7b5584bd2b586c
    Reviewed-on: https://chromium-review.googlesource.com/c/1414211
    Reviewed-by: Mark Mentovai <mark@chromium.org>
    Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#623491}

    Changed files

    • chrome/browser/app_controller_mac.mm
    • chrome/browser/app_controller_mac_unittest.mm

78. [Cronet] Add API methods to attach RequestFinishedInfoListeners.

    Changed by	Caleb Raitto - caraittoohnoyoudont@chromium.org
    Changed at	Thursday, 17-Jan-19 01:11:50 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	451c922ea1dac592af1a8723e6f999125bf6f6c3

    Comments

    [Cronet] Add API methods to attach RequestFinishedInfoListeners.
    
    For now, I'm only focusing on defining the API contract --
    implementation will come in a follow-up CL.
    
    Bug: 879208
    Change-Id: I6b0acc5b9a54d0096ce766ec26958785a12db447
    Reviewed-on: https://chromium-review.googlesource.com/c/1399511
    Commit-Queue: Caleb Raitto <caraitto@chromium.org>
    Reviewed-by: Paul Jensen <pauljensen@chromium.org>
    Reviewed-by: Misha Efimov <mef@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623490}

    Changed files

    • components/cronet/native/cronet.idl
    • components/cronet/native/engine.cc
    • components/cronet/native/engine.h
    • components/cronet/native/generated/cronet.idl_c.h
    • components/cronet/native/generated/cronet.idl_impl_interface.cc
    • components/cronet/native/generated/cronet.idl_impl_interface.h
    • components/cronet/native/generated/cronet.idl_impl_interface_unittest.cc
    • components/cronet/native/generated/cronet.idl_impl_struct.cc
    • components/cronet/native/generated/cronet.idl_impl_struct.h
    • components/cronet/native/generated/cronet.idl_impl_struct_unittest.cc

79. s13n: Remove SigninManager-related includes from chrome_browser_main_android.cc

    Changed by	Gyuyoung Kim - gyuyoungohnoyoudont@igalia.com
    Changed at	Thursday, 17-Jan-19 01:11:41 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	d27deff18dd90c3e95c7d3cefc6da6e004beeb92

    Comments

    s13n: Remove SigninManager-related includes from chrome_browser_main_android.cc
    
    There are no uses of SigninManager|SigninManagerFactory in ChromeBrowserMainPartsAndroid.
    So we don't need to keep the signin_manager.h and signing_manager_factory.h
    includes in chrome_browser_main_android.cc.
    
    Bug: 920203
    Change-Id: Ia43fe0fd75fe8ee2af9038bc4eaeb5419683d687
    Reviewed-on: https://chromium-review.googlesource.com/c/1414210
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#623489}

    Changed files

    • chrome/browser/chrome_browser_main_android.cc

80. Roll Fuchsia SDK from d4f82181b96d to 8d06560ada41

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Thursday, 17-Jan-19 01:10:40 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	74d3083a0f5e23a43ebefbfa5f3f5166fd5537e2

    Comments

    Roll Fuchsia SDK from d4f82181b96d to 8d06560ada41
    
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
    TBR=cr-fuchsia+bot@chromium.org
    
    Change-Id: I84af28a923d39a8edee3bc567ba54b495b35d791
    Reviewed-on: https://chromium-review.googlesource.com/c/1416351
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623488}

    Changed files

    • build/fuchsia/linux.sdk.sha1
    • build/fuchsia/mac.sdk.sha1

81. don't use SkPaint get/set-Flags()

    Changed by	Mike Reed - reedohnoyoudont@google.com
    Changed at	Thursday, 17-Jan-19 01:10:36 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	118cd8307290f889be91ead2d53ccfac5019f0bf

    Comments

    don't use SkPaint get/set-Flags()
    
    In preparation for https://skia-review.googlesource.com/c/skia/+/184388
    
    Change-Id: If9ca16ef335c1dc7519bb743c360a9ee6018f9f7
    Reviewed-on: https://chromium-review.googlesource.com/c/1414758
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Reviewed-by: enne <enne@chromium.org>
    Commit-Queue: Mike Reed <reed@google.com>
    Cr-Commit-Position: refs/heads/master@{#623487}

    Changed files

    • cc/paint/paint_flags.cc
    • cc/paint/paint_flags.h
    • skia/ext/benchmarking_canvas.cc
    • third_party/blink/renderer/platform/graphics/logging_canvas.cc