Builder Linux FYI Release (AMD R7 240) Build 2735

Results:

Success

Trigger Info:

Project	chromium
Revision	efcb843fdd5fefaf4f0c106f04f308ed1aba7919
Got Revision	efcb843fdd5fefaf4f0c106f04f308ed1aba7919

Execution:

• Source: Task 4270e5b0fa321310
• Bot: swarm1080-c4
• Recipe: chromium

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 347 ms ) setup_build

   running recipe: "chromium"
   • stdout
   • run_recipe
2. ( 851 ms ) report builders

    

   running tester 'Linux FYI Release (AMD R7 240)' on master 'chromium.gpu.fyi'
   • stdout
   • bots.json
3. ( 5 mins 44 secs ) bot_update

   [48GB/295GB used (16%)]
   • stdout
   • json.output
4. ( 228 ms ) ensure_goma
   • - no logs -
   1. ( 228 ms ) ensure_installed
      • stdout
      • json.output
5. ( 1 secs ) swarming.py --version

   0.14
   • stdout
6. ( 40 secs ) gclient runhooks
   • stdout
7. ( 3 secs ) get compile targets for scripts
   • stdout
   • json.output
8. ( 1 secs ) read test spec (chromium.gpu.fyi.json)

   path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
   • stdout
   • json.output
9. ( 1 secs ) lookup builder GN args

    

   build_angle_gles1_conform_tests = true

   dcheck_always_on = true

   ffmpeg_branding = "Chrome"

   internal_gles2_conform_tests = true

   is_component_build = false

   is_debug = false

   proprietary_codecs = true

   strip_absolute_paths_from_debug_symbols = true

   symbol_level = 1

   use_goma = true

   goma_dir = "/b/swarming/w/ir/cache/goma/client"
   • stdout
10. ( 720 ms ) build directory
    • stdout
11. ( 1 secs ) find isolated tests
    • stdout
    • json.output
12. ( 1 secs ) test_pre_run
    • - no logs -
    1. ( 1 secs ) [trigger] angle_unittests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
13. ( 230 ms ) ensure swarming
    • - no logs -
    1. ( 230 ms ) ensure_installed
       • stdout
       • json.output
14. ( 45 secs ) angle_unittests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Pending time: 20s

    Shard duration: 22s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (17.0 sec)
15. ( 3 secs ) Upload to test-results [angle_unittests on ATI GPU on Linux on Ubuntu]
    • stdout
16. ( 1 secs ) test_pre_run (2)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] angle_white_box_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
17. ( 11 secs ) angle_white_box_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 7s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (3.4 sec)
18. ( 1 secs ) Upload to test-results [angle_white_box_tests on ATI GPU on Linux on Ubuntu]
    • stdout
19. ( 995 ms ) test_pre_run (3)
    • - no logs -
    1. ( 995 ms ) test_pre_run.[trigger] tab_capture_end2end_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
20. ( 26 secs ) tab_capture_end2end_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 22s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (7.4 sec)
21. ( 2 secs ) Upload to test-results [tab_capture_end2end_tests on ATI GPU on Linux on Ubuntu]
    • stdout
22. ( 1 secs ) test_pre_run (4)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] gl_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
23. ( 18 secs ) gl_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 15s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (9.9 sec)
24. ( 1 secs ) Upload to test-results [gl_tests on ATI GPU on Linux on Ubuntu]
    • stdout
25. ( 1 secs ) test_pre_run (5)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] gles2_conform_test on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
26. ( 42 secs ) gles2_conform_test on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 38s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (33.2 sec)
27. ( 1 secs ) Upload to test-results [gles2_conform_test on ATI GPU on Linux on Ubuntu]
    • stdout
28. ( 2 secs ) test_pre_run (6)
    • - no logs -
    1. ( 2 secs ) test_pre_run.[trigger] swiftshader_unittests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
29. ( 6 secs ) swiftshader_unittests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 5s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (0.8 sec)
30. ( 1 secs ) Upload to test-results [swiftshader_unittests on ATI GPU on Linux on Ubuntu]
    • stdout
31. ( 1 secs ) test_pre_run (7)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] context_lost_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
32. ( 3 mins 8 secs ) context_lost_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 0:03:05.594938

    Total tests: 10

    * Passed: 10 (10 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (174.0 sec)
33. ( 1 secs ) Upload to test-results [context_lost_tests on ATI GPU on Linux]
    • stdout
34. ( 1 secs ) test_pre_run (8)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] depth_capture_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
35. ( 29 secs ) depth_capture_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 24s

    Total tests: 3

    * Passed: 3 (3 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (17.9 sec)
36. ( 1 secs ) Upload to test-results [depth_capture_tests on ATI GPU on Linux]
    • stdout
37. ( 1 secs ) test_pre_run (9)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] gpu_process_launch_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
38. ( 2 mins 58 secs ) gpu_process_launch_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 0:02:50.916678

    Total tests: 15

    * Passed: 15 (15 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (163.8 sec)
39. ( 1 secs ) Upload to test-results [gpu_process_launch_tests on ATI GPU on Linux]
    • stdout
40. ( 904 ms ) test_pre_run (10)
    • - no logs -
    1. ( 904 ms ) test_pre_run.[trigger] hardware_accelerated_feature_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
41. ( 29 secs ) hardware_accelerated_feature_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 22s

    Total tests: 2

    * Passed: 2 (2 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (15.7 sec)
42. ( 1 secs ) Upload to test-results [hardware_accelerated_feature_tests on ATI GPU on Linux]
    • stdout
43. ( 1 secs ) test_pre_run (11)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] info_collection_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
44. ( 24 secs ) info_collection_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 21s

    Total tests: 1

    * Passed: 1 (1 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (15.2 sec)
45. ( 1 secs ) Upload to test-results [info_collection_tests on ATI GPU on Linux]
    • stdout
46. ( 994 ms ) test_pre_run (12)
    • - no logs -
    1. ( 994 ms ) test_pre_run.[trigger] maps_pixel_test on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
47. ( 37 secs ) maps_pixel_test on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 32s

    Total tests: 1

    * Passed: 1 (1 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (26.8 sec)
48. ( 8 secs ) Upload to test-results [maps_pixel_test on ATI GPU on Linux]
    • stdout
49. ( 855 ms ) test_pre_run (13)
    • - no logs -
    1. ( 855 ms ) test_pre_run.[trigger] pixel_test on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
50. ( 9 mins 18 secs ) pixel_test on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 0:09:08.263986

    Total tests: 49

    * Passed: 49 (49 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (541.6 sec)
51. ( 1 secs ) Upload to test-results [pixel_test on ATI GPU on Linux]
    • stdout
52. ( 1 secs ) test_pre_run (14)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] screenshot_sync_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
53. ( 1 mins 15 secs ) screenshot_sync_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 0:01:11.901999

    Total tests: 4

    * Passed: 4 (4 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (65.2 sec)
54. ( 1 secs ) Upload to test-results [screenshot_sync_tests on ATI GPU on Linux]
    • stdout
55. ( 920 ms ) test_pre_run (15)
    • - no logs -
    1. ( 920 ms ) test_pre_run.[trigger] trace_test on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
56. ( 5 mins 9 secs ) trace_test on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Shard duration: 0:04:58.125862

    Total tests: 48

    * Passed: 24 (24 expected, 0 unexpected)

    * Skipped: 24 (24 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (291.4 sec)
57. ( 2 secs ) Upload to test-results [trace_test on ATI GPU on Linux]
    • stdout
58. ( 13 secs ) test_pre_run (16)
    • - no logs -
    1. ( 13 secs ) test_pre_run.[trigger] webgl2_conformance_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
       • shard #1
       • shard #2
       • shard #3
       • shard #4
       • shard #5
       • shard #6
       • shard #7
       • shard #8
       • shard #9
       • shard #10
       • shard #11
       • shard #12
       • shard #13
       • shard #14
       • shard #15
       • shard #16
       • shard #17
       • shard #18
       • shard #19
59. ( 2 hrs 6 mins ) webgl2_conformance_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Max pending time: 1:59:10.363606 (shard #19)

    Max shard duration: 0:07:03.184846 (shard #4)

    Min shard duration: 0:05:19.882211 (shard #7)

    Total tests: 2803

    * Passed: 2735 (2735 expected, 0 unexpected)

    * Skipped: 68 (68 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (363.0 sec)
    • shard #1 isolated out
    • shard #1 (343.6 sec)
    • shard #2 isolated out
    • shard #2 (344.8 sec)
    • shard #3 isolated out
    • shard #3 (369.9 sec)
    • shard #4 isolated out
    • shard #4 (413.3 sec)
    • shard #5 isolated out
    • shard #5 (398.3 sec)
    • shard #6 isolated out
    • shard #6 (392.8 sec)
    • shard #7 isolated out
    • shard #7 (313.1 sec)
    • shard #8 isolated out
    • shard #8 (376.0 sec)
    • shard #9 isolated out
    • shard #9 (352.5 sec)
    • shard #10 isolated out
    • shard #10 (400.2 sec)
    • shard #11 isolated out
    • shard #11 (365.2 sec)
    • shard #12 isolated out
    • shard #12 (386.0 sec)
    • shard #13 isolated out
    • shard #13 (334.3 sec)
    • shard #14 isolated out
    • shard #14 (322.4 sec)
    • shard #15 isolated out
    • shard #15 (384.2 sec)
    • shard #16 isolated out
    • shard #16 (376.7 sec)
    • shard #17 isolated out
    • shard #17 (347.6 sec)
    • shard #18 isolated out
    • shard #18 (406.7 sec)
    • shard #19 isolated out
    • shard #19 (399.5 sec)
60. ( 1 secs ) Upload to test-results [webgl2_conformance_tests on ATI GPU on Linux]
    • stdout
61. ( 1 secs ) test_pre_run (17)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] webgl_conformance_gl_passthrough_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
       • shard #1
62. ( 8 mins 42 secs ) webgl_conformance_gl_passthrough_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Max pending time: 0:02:17.303008 (shard #1)

    Max shard duration: 0:06:06.912871 (shard #1)

    Min shard duration: 0:02:12.355606 (shard #0)

    Total tests: 938

    * Passed: 932 (932 expected, 0 unexpected)

    * Skipped: 6 (6 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (125.7 sec)
    • shard #1 isolated out
    • shard #1 (360.1 sec)
63. ( 1 secs ) Upload to test-results [webgl_conformance_gl_passthrough_tests on ATI GPU on Linux]
    • stdout
64. ( 1 secs ) test_pre_run (18)
    • - no logs -
    1. ( 1 secs ) test_pre_run.[trigger] webgl_conformance_tests on ATI GPU on Linux on Ubuntu

       Run on OS: 'Ubuntu'
       • stdout
       • json.output
       • shard #0
       • shard #1
65. ( 9 mins 25 secs ) webgl_conformance_tests on ATI GPU on Linux on Ubuntu

    Run on OS: 'Ubuntu'

    Max pending time: 0:02:27.074127 (shard #1)

    Max shard duration: 0:06:53.132847 (shard #1)

    Min shard duration: 0:02:17.084839 (shard #0)

    Total tests: 938

    * Passed: 932 (932 expected, 0 unexpected)

    * Skipped: 6 (6 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (129.5 sec)
    • shard #1 isolated out
    • shard #1 (406.1 sec)
66. ( 1 secs ) Upload to test-results [webgl_conformance_tests on ATI GPU on Linux]
    • stdout
67. ( 275 ms ) Tests statistics

     

    Stats

    Total shards: 39

    Total runtime: 2:43:14.613157

     
    • stdout
    • detailed stats
68. ( 0 ) recipe result
    • result

Build Properties:

Name	Value	Source
$recipe_engine/path	{"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"swarm1080-c4"	setup_build
buildbucket	{"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547665941732451, "id": "8924148353441062880", "project": "chromium", "tags": ["builder:Linux FYI Release (AMD R7 240)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/efcb843fdd5fefaf4f0c106f04f308ed1aba7919", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Linux Builder", "parent_buildnumber:39400", "scheduler_invocation_id:9089578415575660160", "scheduler_job_id:chromium/Linux FYI Release (AMD R7 240)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"Linux FYI Release (AMD R7 240)"	setup_build
buildnumber	2735	setup_build
mastername	"chromium.gpu.fyi"	setup_build
parent_buildername	"GPU FYI Linux Builder"	setup_build
parent_got_angle_revision	"dd34b3b9b707c93b3323ac857793ddeae5f7a777"	setup_build
parent_got_buildtools_revision	"40194ab03962d8183b2796fa58a39ec8a9e83a41"	setup_build
parent_got_dawn_revision	"acd8b7d937cc4dcc81856377863f2d56af7037b5"	setup_build
parent_got_nacl_revision	"1ea07c56ac9b57c30eb784ab2af582af0cdd4b08"	setup_build
parent_got_revision	"efcb843fdd5fefaf4f0c106f04f308ed1aba7919"	setup_build
parent_got_revision_cp	"refs/heads/master@{#623313}"	setup_build
parent_got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	setup_build
parent_got_v8_revision	"3354653924b10c4199f815a7c4945d15e55e8a5a"	setup_build
parent_got_v8_revision_cp	"refs/heads/7.3.413@{#1}"	setup_build
parent_got_webrtc_revision	"ccc1b57e32bd99e4f220a3db0e540713f4349ad9"	setup_build
parent_got_webrtc_revision_cp	"refs/heads/master@{#26266}"	setup_build
parent_mastername	"chromium.gpu.fyi"	setup_build
path_config	"generic"	setup_build
recipe	"chromium"	setup_build
revision	"efcb843fdd5fefaf4f0c106f04f308ed1aba7919"	setup_build
swarm_hashes	{"angle_end2end_tests": "986c8230eedc52290cb29adc505385062380dbf8", "angle_perftests": "406f20d4042592bde1db3e88f225423f0e16a08c", "angle_unittests": "2ba9ec3dd3fbc6fe49c6201fd57c1dcb92336d2d", "angle_white_box_tests": "85c0d2447f8c9e14a619c94eceafb3b326216a57", "browser_tests": "6f4d8c056498366b68324427375a43edd838cf5c", "dawn_end2end_tests": "5b33007e641428eab53ca6b3e75d8d7367a9879f", "gl_tests": "503387f6915d6b0e2c0caf7f97be785920c0eb75", "gl_unittests": "7c897377fe61340fae2d9c382a4377355dfce19a", "gles2_conform_test": "3d9e7cf262ee771481f2ada8c53bb312321dded2", "swiftshader_unittests": "fd53bf0f78824a7a3b17c12d21bb63ebb35f5b7c", "telemetry_gpu_integration_test": "9bd1a98e561476ce0040e4ac50cdb77516b82b4f"}	setup_build
got_angle_revision	"a5d2d55d2a27987b893e1b37f320a3c8eeaae4d3"	bot_update
got_buildtools_revision	"40194ab03962d8183b2796fa58a39ec8a9e83a41"	bot_update
got_dawn_revision	"acd8b7d937cc4dcc81856377863f2d56af7037b5"	bot_update
got_nacl_revision	"1ea07c56ac9b57c30eb784ab2af582af0cdd4b08"	bot_update
got_revision	"efcb843fdd5fefaf4f0c106f04f308ed1aba7919"	bot_update
got_revision_cp	"refs/heads/master@{#623313}"	bot_update
got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	bot_update
got_v8_revision	"3354653924b10c4199f815a7c4945d15e55e8a5a"	bot_update
got_v8_revision_cp	"refs/heads/7.3.413@{#1}"	bot_update
got_webrtc_revision	"ccc1b57e32bd99e4f220a3db0e540713f4349ad9"	bot_update
got_webrtc_revision_cp	"refs/heads/master@{#26266}"	bot_update
swarm_hashes	{}	find isolated tests

Blamelist:

1. danakj (danakjohnoyoudont@chromium.org)
2. Doug Turner (dougtohnoyoudont@chromium.org)
3. Antoine Labour (pimanohnoyoudont@chromium.org)
4. Robert Phillips (robertphillipsohnoyoudont@google.com)
5. Xiaohan Wang (xhwangohnoyoudont@chromium.org)
6. Zhiqiang Zhang (zqzhangohnoyoudont@google.com)
7. Daniel Murphy (dmurphohnoyoudont@chromium.org)
8. Eduard Satdarov (sathohnoyoudont@yandex-team.ru)
9. Mirko Bonadei (mbonadeiohnoyoudont@chromium.org)
10. Leonard Grey (lgreyohnoyoudont@chromium.org)
11. Bill Orr (billorrohnoyoudont@chromium.org)
12. Alexei Svitkine (asvitkineohnoyoudont@chromium.org)
13. Gauthier Ambard (gambardohnoyoudont@chromium.org)
14. Sammie Quon (sammiequonohnoyoudont@google.com)
15. Sylvain Defresne (sdefresneohnoyoudont@chromium.org)
16. Anastasia Helfinstein (anastasiohnoyoudont@google.com)
17. mrefaat (mrefaatohnoyoudont@chromium.org)
18. Darwin Huang (huangdarwinohnoyoudont@chromium.org)
19. Caleb Raitto (caraittoohnoyoudont@chromium.org)
20. Sylvain Defresne (sdefresneohnoyoudont@chromium.org)
21. Yoav Weiss (yoavweissohnoyoudont@chromium.org)
22. Sylvain Defresne (sdefresneohnoyoudont@chromium.org)
23. Alex Newcomer (newcomerohnoyoudont@chromium.org)
24. Sylvain Defresne (sdefresneohnoyoudont@chromium.org)
25. Dominic Mazzoni (dmazzoniohnoyoudont@chromium.org)
26. Abhijeet Kandalkar (abhijeetohnoyoudont@igalia.com)
27. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
28. Sylvain Defresne (sdefresneohnoyoudont@chromium.org)
29. Sylvain Defresne (sdefresneohnoyoudont@chromium.org)
30. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
31. Mihai Sardarescu (msardaohnoyoudont@chromium.org)
32. Sylvain Defresne (sdefresneohnoyoudont@chromium.org)
33. Colin Blundell (blundellohnoyoudont@chromium.org)
34. Ian Vollick (vollickohnoyoudont@chromium.org)
35. Johannes Henkel (johannesohnoyoudont@chromium.org)
36. Sylvain Defresne (sdefresneohnoyoudont@chromium.org)
37. Rayan Kanso (rayankansohnoyoudont@chromium.org)
38. Yutaka Hirano (yhiranoohnoyoudont@chromium.org)
39. David Roger (drogerohnoyoudont@chromium.org)
40. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
41. Daniel Bratell (bratellohnoyoudont@opera.com)
42. Oystein Eftevaag (oysteineohnoyoudont@chromium.org)
43. Mario Sanchez Prada (marioohnoyoudont@igalia.com)
44. Nicolas Pena (npmohnoyoudont@chromium.org)
45. Manu Cornet (manucornetohnoyoudont@chromium.org)
46. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
47. Sylvain Defresne (sdefresneohnoyoudont@chromium.org)
48. Owen Min (zminohnoyoudont@chromium.org)
49. Sylvain Defresne (sdefresneohnoyoudont@chromium.org)
50. danakj (danakjohnoyoudont@chromium.org)
51. Ian Clelland (iclellandohnoyoudont@chromium.org)
52. Gabriel Charette (gabohnoyoudont@chromium.org)
53. Mark Cogan (marqohnoyoudont@google.com)
54. Sahel Sharify (sahelohnoyoudont@chromium.org)
55. Peter Collingbourne (pccohnoyoudont@chromium.org)
56. Jérôme Lebel (jlebelohnoyoudont@chromium.org)
57. Edwin Joe (ejoeohnoyoudont@google.com)
58. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
59. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
60. Joshua Peraza (jperazaohnoyoudont@chromium.org)
61. Peter Kasting (pkastingohnoyoudont@chromium.org)
62. David Roger (drogerohnoyoudont@chromium.org)
63. Fredrik Söderquist (fsohnoyoudont@opera.com)
64. Etienne Pierre-Doray (etiennepohnoyoudont@chromium.org)
65. Peter Wen (wnwenohnoyoudont@chromium.org)
66. Corentin Wallez (cwallezohnoyoudont@chromium.org)
67. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
68. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
69. Edwin Joe (ejoeohnoyoudont@google.com)
70. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
71. Samuel Huang (huangsohnoyoudont@chromium.org)
72. Shakti Sahu (shaktisahuohnoyoudont@chromium.org)
73. Marc Treib (treibohnoyoudont@chromium.org)
74. Danyao Wang (danyaoohnoyoudont@chromium.org)
75. Ian Kilpatrick (ikilpatrickohnoyoudont@chromium.org)
76. Karolina Soltys (ksoltohnoyoudont@chromium.org)
77. Daniel Nicoara (dnicoaraohnoyoudont@chromium.org)
78. Jan Krcal (jkrcalohnoyoudont@chromium.org)
79. David Roger (drogerohnoyoudont@chromium.org)
80. Tanja Gornak (melandoryohnoyoudont@chromium.org)
81. kylechar (kylecharohnoyoudont@chromium.org)
82. Sylvain Defresne (sdefresneohnoyoudont@chromium.org)
83. Sylvain Defresne (sdefresneohnoyoudont@chromium.org)
84. Niels Möller (nisseohnoyoudont@chromium.org)
85. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
86. Andrey Malets (maletsohnoyoudont@yandex-team.ru)
87. Carlos Caballero (carlscabohnoyoudont@google.com)
88. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
89. Lutz Justen (ljustenohnoyoudont@chromium.org)
90. Mike Reed (reedohnoyoudont@google.com)

Timing:

Create	Wednesday, 16-Jan-19 19:12:21 UTC
Start	Wednesday, 16-Jan-19 19:13:01 UTC
End	Wednesday, 16-Jan-19 22:12:31 UTC
Pending	39 secs
Execution	2 hrs 59 mins

All Changes:

1. Don't use WebView as a proxy to show FPS counter in the compositor.

   Changed by	danakj - danakjohnoyoudont@chromium.org
   Changed at	Wednesday, 16-Jan-19 18:47:14 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	efcb843fdd5fefaf4f0c106f04f308ed1aba7919

   Comments

   Don't use WebView as a proxy to show FPS counter in the compositor.
   
   1. Move the API from WebLayerTreeView to WebWidgetClient
   2. Have RenderViewImpl set the value each time a new WebFrameWidget
   is attached, as in the future each one will have a new WebWidgetClient.
   3. Have inspector go through the WebFrameWidget's client instead of
   through WebView (and WebLayerTreeView).
   
   Also removes the WebSetting for this, which was not used before this
   CL.
   
   R=enne@chromium.org
   
   Change-Id: Ide83b5372033574cb965e973d50ac43d44f2e8fa
   Bug: 912193
   Reviewed-on: https://chromium-review.googlesource.com/c/1407633
   Commit-Queue: danakj <danakj@chromium.org>
   Reviewed-by: enne <enne@chromium.org>
   Reviewed-by: Avi Drissman <avi@chromium.org>
   Reviewed-by: Philip Rogers <pdr@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623313}

   Changed files

   • content/renderer/compositor/layer_tree_view.cc
   • content/renderer/compositor/layer_tree_view.h
   • content/renderer/render_view_impl.cc
   • content/renderer/render_widget.cc
   • content/renderer/render_widget.h
   • third_party/blink/public/platform/web_layer_tree_view.h
   • third_party/blink/public/web/web_settings.h
   • third_party/blink/public/web/web_view.h
   • third_party/blink/public/web/web_widget_client.h
   • third_party/blink/renderer/core/exported/web_settings_impl.cc
   • third_party/blink/renderer/core/exported/web_settings_impl.h
   • third_party/blink/renderer/core/exported/web_view_impl.cc
   • third_party/blink/renderer/core/exported/web_view_impl.h
   • third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc

2. WebBluetooth: clang-format requestLEScan and requestDevice tests.

   Changed by	Doug Turner - dougtohnoyoudont@chromium.org
   Changed at	Wednesday, 16-Jan-19 18:44:48 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	6d6baec006679a1b77dcfb205d951993c74ab26e

   Comments

   WebBluetooth: clang-format requestLEScan and requestDevice tests.
   
   Bug: None
   Change-Id: I1588de77effdd4fe6162b347175f688cdd6e14be
   Reviewed-on: https://chromium-review.googlesource.com/c/1414751
   Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
   Commit-Queue: Doug Turner <dougt@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623312}

   Changed files

   • third_party/blink/web_tests/bluetooth/requestDevice/chooser/consecutive-calls.html
   • third_party/blink/web_tests/bluetooth/requestDevice/chooser/device-removed.html
   • third_party/blink/web_tests/bluetooth/requestDevice/chooser/fake-bluetooth-chooser-test.html
   • third_party/blink/web_tests/bluetooth/requestDevice/chooser/fake-bluetooth-simulate-advertisement-received-test.html
   • third_party/blink/web_tests/bluetooth/requestDevice/chooser/multiple-matching-devices.html
   • third_party/blink/web_tests/bluetooth/requestDevice/chooser/new-scan-all-types.html
   • third_party/blink/web_tests/bluetooth/requestDevice/chooser/new-scan-connected-devices.html
   • third_party/blink/web_tests/bluetooth/requestDevice/chooser/new-scan-device-added.html
   • third_party/blink/web_tests/bluetooth/requestDevice/chooser/new-scan-device-changed.html
   • third_party/blink/web_tests/bluetooth/requestDevice/chooser/new-scan-services-discovered.html
   • third_party/blink/web_tests/bluetooth/requestDevice/chooser/restart-scan-finds-new-device.html
   • third_party/blink/web_tests/bluetooth/requestDevice/chooser/restart-scan-includes-previous-device.html
   • third_party/blink/web_tests/bluetooth/requestDevice/correct-filters.html
   • third_party/blink/web_tests/bluetooth/requestDevice/device-iframe.https.html
   • third_party/blink/web_tests/bluetooth/requestDevice/discovery-fails-to-start.html
   • third_party/blink/web_tests/bluetooth/requestDevice/filter-does-not-match.html
   • third_party/blink/web_tests/bluetooth/requestDevice/name-empty-device-from-name-prefix-filter.html
   • third_party/blink/web_tests/bluetooth/requestDevice/name-empty-device-from-name-wrong-filter.html
   • third_party/blink/web_tests/bluetooth/requestDevice/name-empty-device-from-service-filter.html
   • third_party/blink/web_tests/bluetooth/requestDevice/name-empty-filter.html
   • third_party/blink/web_tests/bluetooth/requestDevice/name-missing-device-from-name-empty-filter.html
   • third_party/blink/web_tests/bluetooth/requestDevice/name-missing-device-from-name-prefix-filter.html
   • third_party/blink/web_tests/bluetooth/requestDevice/name-missing-device-from-name-wrong-filter.html
   • third_party/blink/web_tests/bluetooth/requestDevice/name-missing-device-from-service-filter.html
   • third_party/blink/web_tests/bluetooth/requestDevice/no-devices.html
   • third_party/blink/web_tests/bluetooth/requestDevice/radio-off.html
   • third_party/blink/web_tests/bluetooth/requestDevice/single-filter-two-services-fails.html
   • third_party/blink/web_tests/bluetooth/requestDevice/single-filter-two-services-succeeds.html
   • third_party/blink/web_tests/bluetooth/requestDevice/two-filters.html
   • third_party/blink/web_tests/bluetooth/requestLEScan/accept-all-with-filter-throws.https.html
   • third_party/blink/web_tests/bluetooth/requestLEScan/basic-scan.https.html
   • third_party/blink/web_tests/bluetooth/requestLEScan/doesnt-consume-user-gesture.https.html
   • third_party/blink/web_tests/bluetooth/requestLEScan/le-not-supported.https.html
   • third_party/blink/web_tests/bluetooth/requestLEScan/multiple-scan.https.html
   • third_party/blink/web_tests/bluetooth/requestLEScan/radio-not-present.https.html
   • third_party/blink/web_tests/bluetooth/requestLEScan/scan-iframe.https.html
   • third_party/blink/web_tests/bluetooth/requestLEScan/scan-options.https.html
   • third_party/blink/web_tests/bluetooth/requestLEScan/scan-with-multiple-filters.https.html
   • third_party/blink/web_tests/bluetooth/requestLEScan/scan-with-name-and-uuid-filter.https.html
   • third_party/blink/web_tests/bluetooth/requestLEScan/scan-with-name-filter.https.html
   • third_party/blink/web_tests/bluetooth/requestLEScan/scan-with-name-prefix-filter.https.html
   • third_party/blink/web_tests/bluetooth/requestLEScan/scan-with-service-uuid-filter.https.html

3. Remove viz::TextureAllocation

   Changed by	Antoine Labour - pimanohnoyoudont@chromium.org
   Changed at	Wednesday, 16-Jan-19 18:43:46 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	d79bf755bbb33522976cc315a4bfb1fa0abb392f

   Comments

   Remove viz::TextureAllocation
   
   It's not used anywhere any more.
   
   Bug: None
   Change-Id: I5b9e258e1b02180189de1c7ed0ccc1df7dfa142c
   Reviewed-on: https://chromium-review.googlesource.com/c/1407688
   Commit-Queue: Antoine Labour <piman@chromium.org>
   Reviewed-by: Eric Karl <ericrk@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623311}

   Changed files

   • cc/layers/heads_up_display_layer_impl.cc
   • cc/raster/gpu_raster_buffer_provider.cc
   • cc/trees/layer_tree_host_impl.cc
   • components/viz/common/BUILD.gn
   • components/viz/common/gpu/texture_allocation.cc
   • components/viz/common/gpu/texture_allocation.h
   • components/viz/service/display/renderer_pixeltest.cc

4. Move destruction of GLES2Decoder to end of Context::DestroyService to avoid order issue

   Changed by	Robert Phillips - robertphillipsohnoyoudont@google.com
   Changed at	Wednesday, 16-Jan-19 18:42:49 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	84497a910c681c722cd280a7a70d6bbbb6a932b5

   Comments

   Move destruction of GLES2Decoder to end of Context::DestroyService to avoid order issue
   
   Bug: 922061
   Change-Id: Ic2359837cb0502cbfbf2e8a6d918e2ce288afb35
   Reviewed-on: https://chromium-review.googlesource.com/c/1414760
   Reviewed-by: Antoine Labour <piman@chromium.org>
   Commit-Queue: Robert Phillips <robertphillips@google.com>
   Cr-Commit-Position: refs/heads/master@{#623310}

   Changed files

   • gpu/gles2_conform_support/egl/context.cc

5. media: Change ConvertPacket() MediaLog to DVLOG in FFmpegDemuxerStream

   Changed by	Xiaohan Wang - xhwangohnoyoudont@chromium.org
   Changed at	Wednesday, 16-Jan-19 18:42:32 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	917912ae2272a73e898bf4c817c90c2e1accf7fe

   Comments

   media: Change ConvertPacket() MediaLog to DVLOG in FFmpegDemuxerStream
   
   There are cases where we could get a lot of ConvertPacket() errors
   without failing the playback. Hence, use DVLOG instead of MediaLogs.
   If the video plays fine we don't care about these logs. If it fails we
   should get some (potentially more useful) log from the video decoder.
   
   Also add DVLOGs in ffmpeg_h264_to_annex_b_bitstream_converter.cc for
   debugging the Bug.
   
   Bug: 921715
   Change-Id: I1d684552da83c7342850dc5bb0c7b6f5d9b6b76c
   Reviewed-on: https://chromium-review.googlesource.com/c/1409728
   Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
   Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
   Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623309}

   Changed files

   • media/filters/ffmpeg_demuxer.cc
   • media/filters/ffmpeg_h264_to_annex_b_bitstream_converter.cc

6. Fix an NPE on session start

   Changed by	Zhiqiang Zhang - zqzhangohnoyoudont@google.com
   Changed at	Wednesday, 16-Jan-19 18:41:32 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	05fc7f6c820adcb2b23f3c78af7085068f260ac5

   Comments

   Fix an NPE on session start
   
   This CL fixes an NPE where
   SessionManagerListener.onSessionStart() can be called twice for
   one createRoute request. The fix is to guard the onSessionStart
   logic in this condition.
   
   Bug: 920800
   Change-Id: I483117ba69bd5d4e78faca4391e9f42d7c9cdbbc
   Reviewed-on: https://chromium-review.googlesource.com/c/1407378
   Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org>
   Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623308}

   Changed files

   • chrome/android/java/src/org/chromium/chrome/browser/media/router/caf/CafBaseMediaRouteProvider.java
   • chrome/android/java/src/org/chromium/chrome/browser/media/router/caf/CafMediaRouteProvider.java
   • chrome/android/junit/src/org/chromium/chrome/browser/media/router/caf/CafBaseMediaRouteProviderTest.java
   • chrome/android/junit/src/org/chromium/chrome/browser/media/router/caf/CafMediaRouteProviderTest.java

7. [IndexedDB] Replacing TransactionCoordinator with ScopesLockManager

   Changed by	Daniel Murphy - dmurphohnoyoudont@chromium.org
   Changed at	Wednesday, 16-Jan-19 18:41:10 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	a6d1c4f92e1d82c25dc3877be43808a400f6d39a

   Comments

   [IndexedDB] Replacing TransactionCoordinator with ScopesLockManager
   
   This change removes the old TransactionCoordinator and uses the new
   DisjoinRangeLockManager from the scopes system. This is a prerequisite
   for using Scopes within IndexedDB, and replaces a pretty untested part
   of the system with a very well tested class.
   
   This change also means that the transaction scheduling will be subtly
   different. In the past, read-write transactions could actually start
   (and finish!) while an intersecting read-only transaction is executing.
   This is not the case in any other browser. Tracking bug to put this
   in the spec is here: https://crbug.com/921193
   
   See here for more context:
   https://docs.google.com/document/d/1jX6OOQJ0aLrWAeqYLtARXPFawUlJPbHNIKAK-0vmFHU/edit#heading=h.5v1ggclt33i
   
   R=pwnall@chromium.org
   
   Bug: 862456
   Change-Id: I41a116a3a2e9227eedf3a2337db21ff9c80a3e0b
   Reviewed-on: https://chromium-review.googlesource.com/c/1407783
   Commit-Queue: Daniel Murphy <dmurph@chromium.org>
   Reviewed-by: Victor Costan <pwnall@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623307}

   Changed files

   • content/browser/BUILD.gn
   • content/browser/indexed_db/database_impl.cc
   • content/browser/indexed_db/indexed_db_class_factory.cc
   • content/browser/indexed_db/indexed_db_class_factory.h
   • content/browser/indexed_db/indexed_db_connection.h
   • content/browser/indexed_db/indexed_db_context_impl.cc
   • content/browser/indexed_db/indexed_db_database.cc
   • content/browser/indexed_db/indexed_db_database.h
   • content/browser/indexed_db/indexed_db_database_unittest.cc
   • content/browser/indexed_db/indexed_db_factory_impl.cc
   • content/browser/indexed_db/indexed_db_factory_impl.h
   • content/browser/indexed_db/indexed_db_leveldb_coding.cc
   • content/browser/indexed_db/indexed_db_leveldb_coding.h
   • content/browser/indexed_db/indexed_db_transaction.cc
   • content/browser/indexed_db/indexed_db_transaction.h
   • content/browser/indexed_db/indexed_db_transaction_coordinator.cc
   • content/browser/indexed_db/indexed_db_transaction_coordinator.h
   • content/browser/indexed_db/indexed_db_transaction_unittest.cc
   • content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.cc
   • content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.h
   • content/browser/indexed_db/scopes/scope_lock_range.cc
   • content/browser/indexed_db/scopes/scope_lock_range.h
   • content/browser/indexed_db/scopes/scopes_lock_manager_unittest.cc
   • third_party/blink/web_tests/storage/indexeddb/resources/transaction-starvation.js
   • third_party/blink/web_tests/storage/indexeddb/transaction-starvation-expected.txt
   • third_party/blink/web_tests/storage/indexeddb/transaction-starvation.html

8. Add support PRE_ tests in FakeServer for sync_integration_tests.

   Changed by	Eduard Satdarov - sathohnoyoudont@yandex-team.ru
   Changed at	Wednesday, 16-Jan-19 18:32:59 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	5253c803e3e60330a0f444fe61b97ac8fc82ff46

   Comments

   Add support PRE_ tests in FakeServer for sync_integration_tests.
   
   Use fixed subfolder in DIR_USER_DATA for storing perstent state of
   LoopbackServer.
   
   Bug: 856696
   Change-Id: I8a934e36ca41e38d02140e329de5494617be1d65
   Reviewed-on: https://chromium-review.googlesource.com/c/1409191
   Reviewed-by: Martin Šrámek <msramek@chromium.org>
   Reviewed-by: Mikel Astiz <mastiz@chromium.org>
   Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru>
   Cr-Commit-Position: refs/heads/master@{#623306}

   Changed files

   • chrome/browser/browsing_data/counters/sync_aware_counter_browsertest.cc
   • chrome/browser/sync/test/integration/single_client_secondary_account_sync_test.cc
   • chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
   • chrome/browser/sync/test/integration/sync_test.cc
   • components/sync/test/fake_server/fake_server.cc
   • components/sync/test/fake_server/fake_server.h

9. Remove usage of rtc::SocketAddress.

   Changed by	Mirko Bonadei - mbonadeiohnoyoudont@chromium.org
   Changed at	Wednesday, 16-Jan-19 18:31:24 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	4c6ffe77dfcae9d253da277a3ad2c25c589c1661

   Comments

   Remove usage of rtc::SocketAddress.
   
   Instead of using the WebRTC version of SocketAddress, uses
   net::HostPortPair.
   
   Notably, it removes support for IPs but it seems like hostnames were
   already the only supported way to specify an address (see the
   now deleted test NetworkServiceAsyncSocketTest.NoHostnameConnect).
   
   Bug: 919085
   Change-Id: I58dfd6876ffe07a89726edb5d4868518addcf386
   Reviewed-on: https://chromium-review.googlesource.com/c/1409303
   Reviewed-by: Asanka Herath <asanka@chromium.org>
   Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
   Reviewed-by: Harald Alvestrand <hta@chromium.org>
   Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623305}

   Changed files

   • jingle/glue/network_service_async_socket.cc
   • jingle/glue/network_service_async_socket.h
   • jingle/glue/network_service_async_socket_unittest.cc
   • jingle/notifier/base/fake_base_task.cc
   • jingle/notifier/communicator/connection_settings.cc
   • jingle/notifier/communicator/connection_settings.h
   • jingle/notifier/communicator/connection_settings_unittest.cc
   • third_party/libjingle_xmpp/BUILD.gn
   • third_party/libjingle_xmpp/DEPS
   • third_party/libjingle_xmpp/xmpp/asyncsocket.h
   • third_party/libjingle_xmpp/xmpp/prexmppauth.h
   • third_party/libjingle_xmpp/xmpp/xmppclient.cc
   • third_party/libjingle_xmpp/xmpp/xmppclientsettings.h

10. Add observation callback for NativeWidgetMac init

    Changed by	Leonard Grey - lgreyohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 18:29:01 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	e8a6aa3b78d8a51f6a191c971ed0e3e0ed3ff8e9

    Comments

    Add observation callback for NativeWidgetMac init
    
    This is ground work for UIDevTools on Mac.
    
    Currently, UIDevTools uses aura::Env to track new windows which appear after its element tree has been constructed. This is unavailable on Mac, so we need a way to track newly created widgets instead.
    
    Bug: 769352
    Change-Id: I1aabd164bc6cf8faa700868ac485197e9f46ab8a
    Reviewed-on: https://chromium-review.googlesource.com/c/1413173
    Commit-Queue: Leonard Grey <lgrey@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623304}

    Changed files

    • ui/views/widget/native_widget_mac.h
    • ui/views/widget/native_widget_mac.mm
    • ui/views/widget/native_widget_mac_unittest.mm

11. Fix a crash in VRBrowserRendererThreadWin

    Changed by	Bill Orr - billorrohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 18:27:27 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	96fa6c14aa7e7e8902d6cb703ea2502e0c13215c

    Comments

    Fix a crash in VRBrowserRendererThreadWin
    
    VRBrowserRendererThreadWin behaved as though it lived on a separate
    thread, posting tasks to do work instead of doing the work
    synchronously.  If it was destroyed, those posted tasks would still run,
    potentially using VRBrowserRendererThreadWin or its members after
    destruction.
    
    The fix is to stop pretending it is a thread, avoiding the posted tasks.
    
    BUG=921739
    
    Change-Id: I147cccf9487386b95c25401d444294321fa925af
    Reviewed-on: https://chromium-review.googlesource.com/c/1413413
    Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
    Commit-Queue: Bill Orr <billorr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623303}

    Changed files

    • chrome/browser/vr/ui_host/vr_ui_host_impl.cc
    • chrome/browser/vr/win/vr_browser_renderer_thread_win.cc
    • chrome/browser/vr/win/vr_browser_renderer_thread_win.h

12. Update histogram owners for some Tab* histograms.

    Changed by	Alexei Svitkine - asvitkineohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 18:25:39 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	f86f976a75aa04a230462ecad2249d5c2f50c634

    Comments

    Update histogram owners for some Tab* histograms.
    
    I noticed that Tab.NewTab was owned by two people, neither of
    whom work on Chrome anymore (beaudoin@ and lliabraa@). This
    CL attempts to clean up ownership. New owners are encouraged
    to review the histograms they are now owning and clean up any
    that are not useful and/or add expiry dates to evaluate later.
    
    Here's the logic used for assigning owners:
    
    NTP histograms: kmilka@chromium.org, ramyan@chromium.org
    Desktop Tab histograms: tbergquist@chromium.org, bsep@chromium.org
    iOS Tab histograms: marq@chromium.org
    Android Tab histograms: dtrainor@chromium.org
    Android stability histograms: wnwen@chromium.org
    
    For already-obsolete histograms, I just removed the two people
    who were owners of Tab.NewTab who don't work on Chrome anymore
    instead of finding replacements.
    
    Please let me know if you have better suggestions for owners.
    Also, having more than one owner is encouraged, so consider
    adding others in a follow-up CL or as suggestions on this CL.
    
    Also adds [Android] and [iOS] tags to histograms that are only
    logged on those platforms and marks a few <obsolete> that are no
    longer in the codebase.
    
    Bug: None
    Change-Id: Id0969e84290f5f51f64c84003f224452a0a15c49
    Reviewed-on: https://chromium-review.googlesource.com/c/1407774
    Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Reviewed-by: David Trainor <dtrainor@chromium.org>
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Reviewed-by: Kyle Milka <kmilka@chromium.org>
    Reviewed-by: Peter Wen <wnwen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623302}

    Changed files

    • tools/metrics/histograms/histograms.xml

13. [iOS] Cleanup settings legacy objects

    Changed by	Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 18:25:04 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	96a2a3914079c76d221f550e93eafe4386c5b91d

    Comments

    [iOS] Cleanup settings legacy objects
    
    This CL removes the now-unused classes in settings.
    
    Bug: 894800
    Change-Id: I3aeffb9d87d262f2a91e4ba8f984164b9800e343
    Reviewed-on: https://chromium-review.googlesource.com/c/1392958
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Reviewed-by: Sergio Collazos <sczs@chromium.org>
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623301}

    Changed files

    • ios/chrome/browser/ui/settings/BUILD.gn
    • ios/chrome/browser/ui/settings/alpha_animated_collection_view_flow_layout.h
    • ios/chrome/browser/ui/settings/alpha_animated_collection_view_flow_layout.mm
    • ios/chrome/browser/ui/settings/cells/BUILD.gn
    • ios/chrome/browser/ui/settings/cells/legacy/BUILD.gn
    • ios/chrome/browser/ui/settings/cells/legacy/legacy_autofill_data_item.h
    • ios/chrome/browser/ui/settings/cells/legacy/legacy_autofill_data_item.mm
    • ios/chrome/browser/ui/settings/cells/legacy/legacy_autofill_data_item_unittest.mm
    • ios/chrome/browser/ui/settings/cells/legacy/legacy_settings_image_detail_text_item.h
    • ios/chrome/browser/ui/settings/cells/legacy/legacy_settings_image_detail_text_item.mm
    • ios/chrome/browser/ui/settings/cells/legacy/legacy_settings_switch_item.h
    • ios/chrome/browser/ui/settings/cells/legacy/legacy_settings_switch_item.mm
    • ios/chrome/browser/ui/settings/cells/password_details_item.h
    • ios/chrome/browser/ui/settings/cells/password_details_item.mm
    • ios/chrome/browser/ui/settings/cells/password_details_item_unittest.mm
    • ios/chrome/browser/ui/settings/cells/settings_text_item.h
    • ios/chrome/browser/ui/settings/cells/table_view_clear_browsing_data_item.h
    • ios/chrome/browser/ui/settings/cells/text_and_error_item.h
    • ios/chrome/browser/ui/settings/legacy_autofill_edit_collection_view_controller+protected.h
    • ios/chrome/browser/ui/settings/legacy_autofill_edit_collection_view_controller.h
    • ios/chrome/browser/ui/settings/legacy_autofill_edit_collection_view_controller.mm
    • ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm
    • ios/chrome/test/earl_grey/chrome_actions.h
    • ios/chrome/test/earl_grey/chrome_actions.mm
    • ios/chrome/test/earl_grey/chrome_matchers.h
    • ios/chrome/test/earl_grey/chrome_matchers.mm

14. wm: Moves splitview indicators test code to its own file.

    Changed by	Sammie Quon - sammiequonohnoyoudont@google.com
    Changed at	Wednesday, 16-Jan-19 18:24:01 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	476910bb8551aab130b36033a5cc1f42dd97e50f

    Comments

    wm: Moves splitview indicators test code to its own file.
    
    Test: ash_unittests SplitViewDragIndicators.*
    Bug: 914147
    Change-Id: I60d0d65a5c6fc2ef7d4344a99c85c443b68984a0
    Reviewed-on: https://chromium-review.googlesource.com/c/1409919
    Commit-Queue: Sammie Quon <sammiequon@chromium.org>
    Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623300}

    Changed files

    • ash/BUILD.gn
    • ash/wm/overview/window_selector_unittest.cc
    • ash/wm/splitview/split_view_drag_indicators.h
    • ash/wm/splitview/split_view_drag_indicators_unittest.cc

15. Convert from base::{LazyInstance,Singleton} to base::NoDestructor

    Changed by	Sylvain Defresne - sdefresneohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 18:23:55 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	c16b38f12e0ef74a23beb7fd5b9520cb2de6a55a

    Comments

    Convert from base::{LazyInstance,Singleton} to base::NoDestructor
    
    The class base::NoDestructor is a simpler way to define a static
    global value (aka a singleton) than base::{LazyInstance,Singleton}
    and is the recommended pattern to use.
    
    The changes were automated using a custom one-shot script, then
    fine tuned by hand (to remove unnecessary classes, ...).
    
    This fixes usages in src/ios/chrome/browser/share_extension.
    
    This CL was uploaded by git cl split.
    
    Bug: none
    Change-Id: Ib6670b6ed4f9ae5886ad06177a32bc6661201314
    Reviewed-on: https://chromium-review.googlesource.com/c/1411789
    Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623299}

    Changed files

    • ios/chrome/browser/share_extension/share_extension_service_factory.h
    • ios/chrome/browser/share_extension/share_extension_service_factory.mm

16. Updates appearance of the Switch Access menu

    Changed by	Anastasia Helfinstein - anastasiohnoyoudont@google.com
    Changed at	Wednesday, 16-Jan-19 18:17:36 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	119d87ccc2a88972344ffa1b2d89dc33623a9e10

    Comments

    Updates appearance of the Switch Access menu
    
    Adds icons, changes colors, and changes behavior of unavailable actions.
    
    Bug: 864796
    Change-Id: I6ceb6ed5326aa71431e1d7d3d7b39db4a3fe102f
    Reviewed-on: https://chromium-review.googlesource.com/c/1413418
    Reviewed-by: Katie Dektar <katie@chromium.org>
    Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
    Cr-Commit-Position: refs/heads/master@{#623298}

    Changed files

    • chrome/browser/resources/chromeos/switch_access/BUILD.gn
    • chrome/browser/resources/chromeos/switch_access/icons/dictation.svg
    • chrome/browser/resources/chromeos/switch_access/icons/options.svg
    • chrome/browser/resources/chromeos/switch_access/icons/scroll_down.svg
    • chrome/browser/resources/chromeos/switch_access/icons/scroll_left.svg
    • chrome/browser/resources/chromeos/switch_access/icons/scroll_right.svg
    • chrome/browser/resources/chromeos/switch_access/icons/scroll_up.svg
    • chrome/browser/resources/chromeos/switch_access/icons/select.svg
    • chrome/browser/resources/chromeos/switch_access/menu_panel.css
    • chrome/browser/resources/chromeos/switch_access/menu_panel.html
    • chrome/browser/resources/chromeos/switch_access/menu_panel.js

17. Fix downloadManager cookies usage.

    Changed by	mrefaat - mrefaatohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 18:15:27 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	da9b2b5bc53094a54107bba9fe80e364df191657

    Comments

    Fix downloadManager cookies usage.
    
    Set cookies on the NSURLConfiguration before the session is created,
    because once the session is created the NSURLConfiguration object can't
    be modified (NSURLSession returns a copy of the configuration not the
    one that is used by the session).
    
    This is a resubmit of cr/1394924 with disabling the cookies test for
    iOS 10, because the NSHTTPSharedCookieStorage has a different default
    cookiesAcceptPolicy.
    
    Bug: 916662
    Change-Id: I6f6c298bf65def96775867ce7eb973de45afbd12
    Reviewed-on: https://chromium-review.googlesource.com/c/1394924
    Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Cr-Original-Commit-Position: refs/heads/master@{#621502}
    Reviewed-on: https://chromium-review.googlesource.com/c/1413113
    Cr-Commit-Position: refs/heads/master@{#623297}

    Changed files

    • ios/web/download/download_controller_impl.h
    • ios/web/download/download_controller_impl.mm
    • ios/web/download/download_controller_impl_unittest.mm
    • ios/web/download/download_task_impl.h
    • ios/web/download/download_task_impl.mm
    • ios/web/download/download_task_impl_unittest.mm

18. Blobs: Small spellfixes for readme.

    Changed by	Darwin Huang - huangdarwinohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 18:15:23 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	16d9472b4dd54604a58de04760b1930fa9679d23

    Comments

    Blobs: Small spellfixes for readme.
    
    - I saw Tricium recommend simple spellfixes on https://crrev.com/c/1410503 so
    just did them real quick.
    
    Bug: 816716
    Change-Id: I206a2f8300e1054fa03b19c37b587454bf125515
    Reviewed-on: https://chromium-review.googlesource.com/c/1413871
    Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
    Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623296}

    Changed files

    • storage/browser/blob/README.md

19. [Cronet] Move the metrics back into their own struct.

    Changed by	Caleb Raitto - caraittoohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 18:13:10 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	51cd7d34327cab71ca77228ee5270da4fe0c1751

    Comments

    [Cronet] Move the metrics back into their own struct.
    
    http://crrev.com/c/1405287 added C generator support for structs-in-struct --
    with this, we can move the metrics back into their own struct like the
    Java API.
    
    Bug: 879208
    Change-Id: Ib5dada64b4a674a275d18eeb013e946480fc9435
    Reviewed-on: https://chromium-review.googlesource.com/c/1407638
    Reviewed-by: Paul Jensen <pauljensen@chromium.org>
    Reviewed-by: Misha Efimov <mef@chromium.org>
    Commit-Queue: Caleb Raitto <caraitto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623295}

    Changed files

    • components/cronet/native/cronet.idl
    • components/cronet/native/generated/cronet.idl_c.h
    • components/cronet/native/generated/cronet.idl_impl_struct.cc
    • components/cronet/native/generated/cronet.idl_impl_struct.h
    • components/cronet/native/generated/cronet.idl_impl_struct_unittest.cc

20. Convert from base::{LazyInstance,Singleton} to base::NoDestructor

    Changed by	Sylvain Defresne - sdefresneohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 18:11:05 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	89e8336a060874d24ef9a9e76bd77d8b8749144e

    Comments

    Convert from base::{LazyInstance,Singleton} to base::NoDestructor
    
    The class base::NoDestructor is a simpler way to define a static
    global value (aka a singleton) than base::{LazyInstance,Singleton}
    and is the recommended pattern to use.
    
    The changes were automated using a custom one-shot script, then
    fine tuned by hand (to remove unnecessary classes, ...).
    
    This fixes usages in src/ios/chrome/browser/metrics.
    
    This CL was uploaded by git cl split.
    
    Bug: none
    Change-Id: I603c61ba8221d54ec549d122497368cb0874493d
    Reviewed-on: https://chromium-review.googlesource.com/c/1411694
    Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623294}

    Changed files

    • ios/chrome/browser/metrics/ios_profile_session_durations_service_factory.h
    • ios/chrome/browser/metrics/ios_profile_session_durations_service_factory.mm

21. [Resource-Timing] `name` is wrong for http to https redirection

    Changed by	Yoav Weiss - yoavweissohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 18:06:39 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	5ba90c2f9ee6e23c0ff0b22bc4ef0ae9477c57ad

    Comments

    [Resource-Timing] `name` is wrong for http to https redirection
    
    According to the spec, the `name` attribute MUST provide the
    pre-redirection URL. In the case of http=>https redirections,
    that's not the case and the post-redirection URL is provided.
    This CL fixes that.
    
    BUG=922365
    
    Change-Id: Ic9acf354ef66d654ab41259aa0af297a56e775ce
    Reviewed-on: https://chromium-review.googlesource.com/c/1411929
    Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
    Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623293}

    Changed files

    • third_party/blink/renderer/core/loader/threadable_loader.cc
    • third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
    • third_party/blink/renderer/platform/loader/fetch/resource_request.cc
    • third_party/blink/renderer/platform/loader/fetch/resource_request.h
    • third_party/blink/web_tests/external/wpt/resource-timing/redirects.sub.html
    • third_party/blink/web_tests/external/wpt/resource-timing/resources/blank_page_green.htm.headers

22. Convert from base::{LazyInstance,Singleton} to base::NoDestructor

    Changed by	Sylvain Defresne - sdefresneohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 18:05:31 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	f497974555e28e09156fb21752533fa74a5f8564

    Comments

    Convert from base::{LazyInstance,Singleton} to base::NoDestructor
    
    The class base::NoDestructor is a simpler way to define a static
    global value (aka a singleton) than base::{LazyInstance,Singleton}
    and is the recommended pattern to use.
    
    The changes were automated using a custom one-shot script, then
    fine tuned by hand (to remove unnecessary classes, ...).
    
    This fixes usages in src/ios/web.
    
    This CL was uploaded by git cl split.
    
    Bug: none
    Change-Id: I3d0453852d3e802e49d79ed89deb058272f43d84
    Reviewed-on: https://chromium-review.googlesource.com/c/1411642
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623292}

    Changed files

    • ios/web/browser_state.mm
    • ios/web/browser_url_rewriter_impl.h
    • ios/web/browser_url_rewriter_impl.mm
    • ios/web/service_manager_connection_impl.cc
    • ios/web/service_manager_context.mm
    • ios/web/web_state/global_web_state_event_tracker.h
    • ios/web/web_state/global_web_state_event_tracker.mm
    • ios/web/webui/url_data_manager_ios.cc
    • ios/web/webui/url_data_manager_ios_backend.mm
    • ios/web/webui/web_ui_ios_controller_factory_registry.cc
    • ios/web/webui/web_ui_ios_controller_factory_registry.h

23. cros:Show shelf/wallpaper menu options on the launcher button

    Changed by	Alex Newcomer - newcomerohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 18:05:27 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	af3fd11b06b0635e441680c1a9d5766187411864

    Comments

    cros:Show shelf/wallpaper menu options on the launcher button
    
    To improve the keyboard and a11y use case for showing the
    shelf/wallpaper menu options, show the shelf/wallpaper menu options on
    the AppListButton.
    
    Bug: 922241
    Change-Id: Ifc2fb1cec67cffc9abb182df71dad8d055e06ec9
    Reviewed-on: https://chromium-review.googlesource.com/c/1411927
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: Alex Newcomer <newcomer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623291}

    Changed files

    • ash/shelf/shelf_context_menu_model.cc
    • ash/shelf/shelf_view_unittest.cc

24. Convert from base::{LazyInstance,Singleton} to base::NoDestructor

    Changed by	Sylvain Defresne - sdefresneohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 18:04:22 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	1b03019e252e4b89a3b912fdcf5a626bd3be546c

    Comments

    Convert from base::{LazyInstance,Singleton} to base::NoDestructor
    
    The class base::NoDestructor is a simpler way to define a static
    global value (aka a singleton) than base::{LazyInstance,Singleton}
    and is the recommended pattern to use.
    
    The changes were automated using a custom one-shot script, then
    fine tuned by hand (to remove unnecessary classes, ...).
    
    This fixes usages in src/ios/chrome/browser/autofill.
    
    This CL was uploaded by git cl split.
    
    Bug: none
    Change-Id: I529a7ca29e106854e8f75684ddd1ba503abd0793
    Reviewed-on: https://chromium-review.googlesource.com/c/1411649
    Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623290}

    Changed files

    • ios/chrome/browser/autofill/address_normalizer_factory.cc
    • ios/chrome/browser/autofill/address_normalizer_factory.h
    • ios/chrome/browser/autofill/autocomplete_history_manager_factory.cc
    • ios/chrome/browser/autofill/autocomplete_history_manager_factory.h
    • ios/chrome/browser/autofill/autofill_profile_validator_factory.cc
    • ios/chrome/browser/autofill/autofill_profile_validator_factory.h
    • ios/chrome/browser/autofill/legacy_strike_database_factory.cc
    • ios/chrome/browser/autofill/legacy_strike_database_factory.h
    • ios/chrome/browser/autofill/personal_data_manager_factory.cc
    • ios/chrome/browser/autofill/personal_data_manager_factory.h
    • ios/chrome/browser/autofill/strike_database_factory.cc
    • ios/chrome/browser/autofill/strike_database_factory.h
    • ios/chrome/browser/autofill/validation_rules_storage_factory.cc
    • ios/chrome/browser/autofill/validation_rules_storage_factory.h

25. Replace calls to NodeIndex() with nextSibling/previousSibling.

    Changed by	Dominic Mazzoni - dmazzoniohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 18:04:07 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	98f103ba355d07d060516f769f7ce2a44697bdae

    Comments

    Replace calls to NodeIndex() with nextSibling/previousSibling.
    
    NodeIndex() is O(n) and the difference is measurable if a single node
    has many siblings, like in a paragraph with a lot of explicit line breaks.
    
    Bug: 921789
    Change-Id: I0540105cb2947efffda6958797d16cbcfaa2c583
    Reviewed-on: https://chromium-review.googlesource.com/c/1410175
    Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623289}

    Changed files

    • docs/accessibility/perf.md
    • third_party/blink/perf_tests/accessibility/line-breaks.html
    • third_party/blink/renderer/modules/accessibility/ax_position.cc

26. Remove unused variables and headers

    Changed by	Abhijeet Kandalkar - abhijeetohnoyoudont@igalia.com
    Changed at	Wednesday, 16-Jan-19 17:59:27 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	a8eadaf186f4cec0649428a2c49d6e037040ad91

    Comments

    Remove unused variables and headers
    
    Removed |signin_client_| and |token_service_| ivars and their
    corresponding includes from search_suggest_service_unittest.cc
    
    Bug: 921611
    Change-Id: I5e3645b6d12fdd2eac4097dc25132d743563b131
    Reviewed-on: https://chromium-review.googlesource.com/c/1414740
    Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
    Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623288}

    Changed files

    • chrome/browser/search/search_suggest/search_suggest_service_unittest.cc

27. Roll src/third_party/chromite 09aafe6fb6c6..83d975aac2b4 (1 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Wednesday, 16-Jan-19 17:52:54 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	72ef7db3848ed1f8d7659b207488da85da3c0bef

    Comments

    Roll src/third_party/chromite 09aafe6fb6c6..83d975aac2b4 (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/09aafe6fb6c6..83d975aac2b4
    
    
    git log 09aafe6fb6c6..83d975aac2b4 --date=short --no-merges --format='%ad %ae %s'
    2019-01-16 dhanyaganesh@chromium.org cros_buildresult: Correcting a mistake with cidb changes.
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@83d975aac2b4
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I9ad7f544d2cb5b20a707fd6360141d3037a30a34
    Reviewed-on: https://chromium-review.googlesource.com/c/1415030
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623287}

    Changed files

    • DEPS

28. Convert from base::{LazyInstance,Singleton} to base::NoDestructor

    Changed by	Sylvain Defresne - sdefresneohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 17:52:49 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	5b72f2e13767d886fb0d35899a8a52ca0e8e28c2

    Comments

    Convert from base::{LazyInstance,Singleton} to base::NoDestructor
    
    The class base::NoDestructor is a simpler way to define a static
    global value (aka a singleton) than base::{LazyInstance,Singleton}
    and is the recommended pattern to use.
    
    The changes were automated using a custom one-shot script, then
    fine tuned by hand (to remove unnecessary classes, ...).
    
    This fixes usages in src/ios/chrome/browser/omaha.
    
    This CL was uploaded by git cl split.
    
    Bug: none
    Change-Id: Ia43422b81713ca0a22e01ff258340f28a6898f56
    Reviewed-on: https://chromium-review.googlesource.com/c/1411994
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623286}

    Changed files

    • ios/chrome/browser/omaha/omaha_service.h
    • ios/chrome/browser/omaha/omaha_service.mm

29. Convert from base::{LazyInstance,Singleton} to base::NoDestructor

    Changed by	Sylvain Defresne - sdefresneohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 17:49:16 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	4d0abff48d186a8373bfa22ceddd71f9daaf9ae8

    Comments

    Convert from base::{LazyInstance,Singleton} to base::NoDestructor
    
    The class base::NoDestructor is a simpler way to define a static
    global value (aka a singleton) than base::{LazyInstance,Singleton}
    and is the recommended pattern to use.
    
    The changes were automated using a custom one-shot script, then
    fine tuned by hand (to remove unnecessary classes, ...).
    
    This fixes usages in src/ios/chrome/browser/language.
    
    This CL was uploaded by git cl split.
    
    Bug: none
    Change-Id: Ic0361a980502108310c34570e3aa99385900492d
    Reviewed-on: https://chromium-review.googlesource.com/c/1411788
    Reviewed-by: Michael Martis <martis@chromium.org>
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623285}

    Changed files

    • ios/chrome/browser/language/language_model_manager_factory.cc
    • ios/chrome/browser/language/language_model_manager_factory.h
    • ios/chrome/browser/language/url_language_histogram_factory.cc
    • ios/chrome/browser/language/url_language_histogram_factory.h

30. Roll src/third_party/perfetto e2f79261ed5f..3c4d2b4f8286 (3 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Wednesday, 16-Jan-19 17:47:23 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	86bb457bdedb28c3d38480b2680372ddc5bd3182

    Comments

    Roll src/third_party/perfetto e2f79261ed5f..3c4d2b4f8286 (3 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/e2f79261ed5f..3c4d2b4f8286
    
    
    git log e2f79261ed5f..3c4d2b4f8286 --date=short --no-merges --format='%ad %ae %s'
    2019-01-16 lalitm@google.com Merge "trace_processor: improve best index for thread table"
    2019-01-16 primiano@google.com Perfetto: clean up PERFETTO_EMBEDDER_BUILD
    2019-01-16 taylori@google.com Merge "trace_processor: Fix parsing of empty events"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@3c4d2b4f8286
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:921584
    TBR=perfetto-bugs@google.com
    
    Change-Id: I8f941aa1f253d8d51eca483942e1b58bf4600e66
    Reviewed-on: https://chromium-review.googlesource.com/c/1414992
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623284}

    Changed files

    • DEPS

31. [sync metrics] Correctly log auth errors when sync is disabled.

    Changed by	Mihai Sardarescu - msardaohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 17:45:42 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	6131c574642fe33210ce17c647d0e8223d6db0ef

    Comments

    [sync metrics] Correctly log auth errors when sync is disabled.
    
    Before this CL, when sync was disable, the auth error state was not
    reported correctly in the sign-in & sync browser session metrics (accounts
    in auth errors were still tracked as being valid before this CL).
    
    Bug: NONE
    Change-Id: I976c0d006d3c9c18f3f60058c1151cadeb7c5e5f
    Reviewed-on: https://chromium-review.googlesource.com/c/1406973
    Reviewed-by: Marc Treib <treib@chromium.org>
    Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623283}

    Changed files

    • components/sync/driver/sync_session_durations_metrics_recorder.cc
    • components/sync/driver/sync_session_durations_metrics_recorder.h
    • components/sync/driver/sync_session_durations_metrics_recorder_unittest.cc

32. Convert from base::{LazyInstance,Singleton} to base::NoDestructor

    Changed by	Sylvain Defresne - sdefresneohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 17:45:21 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	000db4fbdfa91638e7e405af3befc15da47e5dc7

    Comments

    Convert from base::{LazyInstance,Singleton} to base::NoDestructor
    
    The class base::NoDestructor is a simpler way to define a static
    global value (aka a singleton) than base::{LazyInstance,Singleton}
    and is the recommended pattern to use.
    
    The changes were automated using a custom one-shot script, then
    fine tuned by hand (to remove unnecessary classes, ...).
    
    This fixes usages in src/ios/chrome/browser/download.
    
    This CL was uploaded by git cl split.
    
    Bug: none
    Change-Id: I80784caad89b004d2bb1f9e7d877c879ec5e5eca
    Reviewed-on: https://chromium-review.googlesource.com/c/1412174
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623282}

    Changed files

    • ios/chrome/browser/download/browser_download_service_factory.h
    • ios/chrome/browser/download/browser_download_service_factory.mm

33. Remove call to LoadCredentials() from OAuth2LoginManager

    Changed by	Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 17:44:18 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	bb45be1b132a75cb1ed489035b4b603222595e1e

    Comments

    Remove call to LoadCredentials() from OAuth2LoginManager
    
    We're aiming to have the loading of refresh tokens be totally internal
    to the identity codebase.
    https://chromium-review.googlesource.com/c/1386427 landed toward that
    goal.
    
    I just noticed that OAuth2LoginManager calls LoadCredentials(),
    seemingly just as a mechanism for having OnRefreshTokensLoaded() be
    fired. I see no obvious reason that any consumers would be listening
    for OnRefreshTokensLoaded() to be fired by OAuth2LoginManager given the
    way that the codebase is organized now.
    
    This CL eliminates these calls entirely.  If there are any such
    consumers, we should ferret them out and they should interact with
    OAuth2LoginManager in some different way (e.g., it can have some
    observer method that these consumers listen for).
    
    Bug: 922410
    Change-Id: Ic8cfc1c25152dc29610fcf823ed9e98bd36ec0a3
    Reviewed-on: https://chromium-review.googlesource.com/c/1412831
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623281}

    Changed files

    • chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
    • chrome/browser/chromeos/login/signin/oauth2_login_manager.h

34. Allow specifying atrace buffer size with profile-chrome-startup.sh

    Changed by	Ian Vollick - vollickohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 17:44:03 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	e932f580a8f601a983cb7b9f922bcd5a04c0265b

    Comments

    Allow specifying atrace buffer size with profile-chrome-startup.sh
    
    We are now able to plumb atrace buffer sizes to catapult's startup
    scripts as of:
    https://chromium-review.googlesource.com/c/catapult/+/1412040
    
    And this change continues that plumbing.
    
    Bug: None
    Change-Id: I594f544c1aa6ca8ee86a0670989f11462832a4cd
    Reviewed-on: https://chromium-review.googlesource.com/c/1412621
    Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
    Commit-Queue: Ian Vollick <vollick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623280}

    Changed files

    • tools/android/tracing/profile-chrome-startup.sh

35. [DevTools] Roll inspector_protocol to fdbdb154336fc1f15a0a6775349dd90243b8d3fc.

    Changed by	Johannes Henkel - johannesohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 17:42:59 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	a44c7daab7ac438d55d9ca09f422817030da606c

    Comments

    [DevTools] Roll inspector_protocol to fdbdb154336fc1f15a0a6775349dd90243b8d3fc.
    
    This should be a non-event, I'm just rolling it to line it up
    with https://chromium.googlesource.com/deps/inspector_protocol/
    again.
    
    Change-Id: I2b752de09eb71a4f1ee27bc925cc09dfa00a225a
    Reviewed-on: https://chromium-review.googlesource.com/c/1413895
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Commit-Queue: Johannes Henkel <johannes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623279}

    Changed files

    • third_party/inspector_protocol/ConvertProtocolToJSON.py
    • third_party/inspector_protocol/OWNERS
    • third_party/inspector_protocol/README.chromium
    • third_party/inspector_protocol/README.md
    • third_party/inspector_protocol/lib/Allocator_h.template
    • third_party/inspector_protocol/lib/Collections_h.template
    • third_party/inspector_protocol/lib/Forward_h.template

36. Convert from base::{LazyInstance,Singleton} to base::NoDestructor

    Changed by	Sylvain Defresne - sdefresneohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 17:38:38 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	6888a3cc0ac915d0df6895cf0dfac6881ee44c02

    Comments

    Convert from base::{LazyInstance,Singleton} to base::NoDestructor
    
    The class base::NoDestructor is a simpler way to define a static
    global value (aka a singleton) than base::{LazyInstance,Singleton}
    and is the recommended pattern to use.
    
    The changes were automated using a custom one-shot script, then
    fine tuned by hand (to remove unnecessary classes, ...).
    
    This fixes usages in src/ios/chrome/browser/history.
    
    This CL was uploaded by git cl split.
    
    Bug: none
    Change-Id: Idb5b708b1ca2aa1dd34e03a6e273331d5957af1b
    Reviewed-on: https://chromium-review.googlesource.com/c/1412352
    Reviewed-by: Sergio Collazos <sczs@chromium.org>
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623278}

    Changed files

    • ios/chrome/browser/history/history_service_factory.cc
    • ios/chrome/browser/history/history_service_factory.h
    • ios/chrome/browser/history/top_sites_factory.cc
    • ios/chrome/browser/history/top_sites_factory.h
    • ios/chrome/browser/history/web_history_service_factory.cc
    • ios/chrome/browser/history/web_history_service_factory.h

37. [Background Fetch] Persist storage schema version with the metadata.

    Changed by	Rayan Kanso - rayankansohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 17:32:52 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	4e829446f61faf9ddc18a8e871c156eb7b4ad29a

    Comments

    [Background Fetch] Persist storage schema version with the metadata.
    
    Include the storage version in case some schema-breaking changes need to
    be made. The change also includes some helper functions to extract that
    information.
    
    The weak_ptr_factory for DatabaseTasks was moved from it's parent class
    to the class itself to allow for some asynchronous utility helper
    functions.
    
    Change-Id: I177e514cb6278acb32cf00e3aa95f287c5d7c2f9
    Reviewed-on: https://chromium-review.googlesource.com/c/1409511
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Mugdha Lakhani <nator@google.com>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623277}

    Changed files

    • content/browser/background_fetch/background_fetch.proto
    • content/browser/background_fetch/background_fetch_data_manager.cc
    • content/browser/background_fetch/background_fetch_data_manager.h
    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/storage/README.md
    • content/browser/background_fetch/storage/create_metadata_task.cc
    • content/browser/background_fetch/storage/database_helpers.cc
    • content/browser/background_fetch/storage/database_helpers.h
    • content/browser/background_fetch/storage/database_task.cc
    • content/browser/background_fetch/storage/database_task.h
    • content/browser/background_fetch/storage/delete_registration_task.cc

38. Move "global properties" to ResourceFetcherProperties, part 3

    Changed by	Yutaka Hirano - yhiranoohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 17:31:50 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	12c199ee65d6c040fa096a85b111598f7cf6f080

    Comments

    Move "global properties" to ResourceFetcherProperties, part 3
    
    This CL introduces ResourceFetcherProperties::IsDetached.
    FetchContext::IsDetached remains, but it is no longer public.
    
    Change-Id: I54f4515929fe497719a5ac8791ea7c5e6c922a64
    Bug: 914739
    Reviewed-on: https://chromium-review.googlesource.com/c/1406728
    Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
    Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623276}

    Changed files

    • third_party/blink/renderer/core/loader/frame_resource_fetcher_properties.h
    • third_party/blink/renderer/core/loader/worker_resource_fetcher_properties.h
    • third_party/blink/renderer/platform/loader/fetch/fetch_context.h
    • third_party/blink/renderer/platform/loader/fetch/null_resource_fetcher_properties.h
    • third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
    • third_party/blink/renderer/platform/loader/fetch/resource_fetcher_properties.h
    • third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
    • third_party/blink/renderer/platform/loader/testing/test_resource_fetcher_properties.h

39. [signin] Remove support for pre-Dice signin in login_ui_test_utils

    Changed by	David Roger - drogerohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 17:31:04 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	c62f2264b7358f0c2c7c0a4a3f78554875619437

    Comments

    [signin] Remove support for pre-Dice signin in login_ui_test_utils
    
    Bug: 915678
    Change-Id: I3a2d39357f257fabe9c29c9a72284db854f7f860
    Reviewed-on: https://chromium-review.googlesource.com/c/1411996
    Commit-Queue: David Roger <droger@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623275}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/ui/webui/signin/login_ui_test_utils.cc

40. Fix errors generated from gcc8

    Changed by	Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 17:30:13 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	5c795a8739203edce37f71466aa3b9ae12eb8440

    Comments

    Fix errors generated from gcc8
    
    Double assignment occurred for these variables. Remove it.
    
    BUG=921582
    
    Change-Id: I47d65ad493ee9bb01a7307b500c0e028fed9233f
    Reviewed-on: https://chromium-review.googlesource.com/c/1409605
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Reviewed-by: David Trainor <dtrainor@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623274}

    Changed files

    • chrome/browser/download/download_shelf_controller.cc
    • headless/lib/browser/protocol/browser_handler.cc

41. Remove team list that was listed as reviewer in wpt/workers/OWNERS

    Changed by	Daniel Bratell - bratellohnoyoudont@opera.com
    Changed at	Wednesday, 16-Jan-19 17:29:50 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	980d1e888a20e1bb74a2c9fe52a4a12f756a9cd4

    Comments

    Remove team list that was listed as reviewer in wpt/workers/OWNERS
    
    R=foolip@chromium.org
    
    Change-Id: I97a3bb19a458a4114c1541ea4aaa790bb849bbca
    Reviewed-on: https://chromium-review.googlesource.com/c/1407074
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Commit-Queue: Daniel Bratell <bratell@opera.com>
    Cr-Commit-Position: refs/heads/master@{#623273}

    Changed files

    • third_party/blink/web_tests/external/wpt/workers/OWNERS
    • third_party/blink/web_tests/external/wpt/worklets/OWNERS

42. Perfetto: Remove conditional compilation flags

    Changed by	Oystein Eftevaag - oysteineohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 17:28:46 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	ccb5def0247eb83931e12478e2c1063990a64d47

    Comments

    Perfetto: Remove conditional compilation flags
    
    All platforms are now supported.
    
    R=eseckler@chromium.org
    
    Change-Id: I15c0d138cda67a3d46ee2c51a8a87f8395a0b9d0
    Reviewed-on: https://chromium-review.googlesource.com/c/1413503
    Commit-Queue: oysteine <oysteine@chromium.org>
    Reviewed-by: Eric Seckler <eseckler@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623272}

    Changed files

    • services/tracing/BUILD.gn
    • services/tracing/public/cpp/BUILD.gn
    • services/tracing/public/cpp/trace_event_agent.cc
    • services/tracing/tracing_service.cc
    • services/tracing/tracing_service.h

43. Call ATS::SetIsAdvancedProtectionAccount() from InlineSigninHelper

    Changed by	Mario Sanchez Prada - marioohnoyoudont@igalia.com
    Changed at	Wednesday, 16-Jan-19 17:28:39 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	19540192d96c5b6f82de25e9716c58436e0cd84c

    Comments

    Call ATS::SetIsAdvancedProtectionAccount() from InlineSigninHelper
    
    We're currently not explicitly setting the |is_under_advanced_protection|
    flag when updating the refresh token for a given account from there, which
    hasn't been a problem for now, but it would be good to add it to explicitly
    track this change before migrating to AccountsMutator::AddOrUpdateAccount(),
    which will always set this flag before calling PO2TS::UpdateCredentials().
    
    Bug: 913392
    Change-Id: I0915de8210e1877b337b9bfaf62ff9709a3733dc
    Reviewed-on: https://chromium-review.googlesource.com/c/1411889
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#623271}

    Changed files

    • chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

44. Change Yoav's ownership email

    Changed by	Nicolas Pena - npmohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 17:20:08 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	7a6b6998a9997ce8d013cf8d590428fb66570333

    Comments

    Change Yoav's ownership email
    
    Change-Id: Ibbc96001fe7bb3d7bb47e8bd5016c47c8b55ca2d
    Reviewed-on: https://chromium-review.googlesource.com/c/1414995
    Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
    Reviewed-by: Yoav Weiss <yoav@yoav.ws>
    Cr-Commit-Position: refs/heads/master@{#623270}

    Changed files

    • WATCHLISTS
    • components/link_header_util/OWNERS
    • third_party/blink/API_OWNERS
    • third_party/blink/OWNERS
    • third_party/blink/renderer/core/OWNERS
    • third_party/blink/renderer/core/html/parser/OWNERS
    • third_party/blink/renderer/platform/loader/OWNERS
    • third_party/blink/web_tests/external/wpt/preload/OWNERS

45. CrOS Shelf: Some hover preview fixes

    Changed by	Manu Cornet - manucornetohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 17:11:23 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	6187efed3c0fbcdd427a6632d33e34642e005065

    Comments

    CrOS Shelf: Some hover preview fixes
    
    * Give the hover preview the same background color as the shelf (this
      requires a little bit of plumbing to get the value from where it is).
    * Set rounded corners for the hover preview as written in the spec.
    * Reduce spacing between window previews within the bubble.
    
    Bug: 874186, 874220, 834392
    Change-Id: I400e62392482a11092379aa1c2d7e941763c803e
    Reviewed-on: https://chromium-review.googlesource.com/c/1411339
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: Manu Cornet <manucornet@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623269}

    Changed files

    • ash/shelf/shelf_tooltip_manager.cc
    • ash/shelf/shelf_tooltip_preview_bubble.cc
    • ash/shelf/shelf_tooltip_preview_bubble.h
    • ash/shelf/shelf_widget.cc
    • ash/shelf/shelf_widget.h

46. Roll src-internal 0c86e5f84f6e..8faaf5edf3dc (3 commits)

    Changed by	chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at	Wednesday, 16-Jan-19 17:09:50 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	d6ebddd3b3f11f7fa4d89ed759a3428dadb31ee3

    Comments

    Roll src-internal 0c86e5f84f6e..8faaf5edf3dc (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0c86e5f84f6e..8faaf5edf3dc
    
    
    Created with:
      gclient setdep -r src-internal@8faaf5edf3dc
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I11b21fc1ab264c5311df996d3d2959de880a75cb
    Reviewed-on: https://chromium-review.googlesource.com/c/1414293
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623268}

    Changed files

    • DEPS

47. Convert from base::{LazyInstance,Singleton} to base::NoDestructor

    Changed by	Sylvain Defresne - sdefresneohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 17:07:07 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	7ef0d519267a5567534358d614446b9aa6a35751

    Comments

    Convert from base::{LazyInstance,Singleton} to base::NoDestructor
    
    The class base::NoDestructor is a simpler way to define a static
    global value (aka a singleton) than base::{LazyInstance,Singleton}
    and is the recommended pattern to use.
    
    The changes were automated using a custom one-shot script, then
    fine tuned by hand (to remove unnecessary classes, ...).
    
    This fixes usages in src/ios/web_view/internal/autofill.
    
    This CL was uploaded by git cl split.
    
    Bug: none
    Change-Id: I7b7743632ee5a5cce905bb98e8a053b9ab964e0c
    Reviewed-on: https://chromium-review.googlesource.com/c/1411783
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623267}

    Changed files

    • ios/web_view/internal/autofill/web_view_autocomplete_history_manager_factory.h
    • ios/web_view/internal/autofill/web_view_autocomplete_history_manager_factory.mm
    • ios/web_view/internal/autofill/web_view_legacy_strike_database_factory.h
    • ios/web_view/internal/autofill/web_view_legacy_strike_database_factory.mm
    • ios/web_view/internal/autofill/web_view_personal_data_manager_factory.h
    • ios/web_view/internal/autofill/web_view_personal_data_manager_factory.mm
    • ios/web_view/internal/autofill/web_view_strike_database_factory.h
    • ios/web_view/internal/autofill/web_view_strike_database_factory.mm

48. Print error message when DMServer returns an error.

    Changed by	Owen Min - zminohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 17:06:17 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	933a8729255f068178ec4ee0dff99281f5d6c11f

    Comments

    Print error message when DMServer returns an error.
    
    DM server now could return a valid DeviceManagementResponse with
    error message.
    
    Change-Id: If7a3063a8c30b512db2d897dafe6e5934ec6529c
    Reviewed-on: https://chromium-review.googlesource.com/c/1412973
    Reviewed-by: Sergey Poromov <poromov@chromium.org>
    Commit-Queue: Owen Min <zmin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623266}

    Changed files

    • components/policy/core/common/cloud/device_management_service.cc

49. Convert from base::{LazyInstance,Singleton} to base::NoDestructor

    Changed by	Sylvain Defresne - sdefresneohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 17:03:31 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	b5b51f9daee55ede3553218127964a5852855b3c

    Comments

    Convert from base::{LazyInstance,Singleton} to base::NoDestructor
    
    The class base::NoDestructor is a simpler way to define a static
    global value (aka a singleton) than base::{LazyInstance,Singleton}
    and is the recommended pattern to use.
    
    The changes were automated using a custom one-shot script, then
    fine tuned by hand (to remove unnecessary classes, ...).
    
    This fixes usages in src/ios/web_view/internal/passwords.
    
    This CL was uploaded by git cl split.
    
    Bug: none
    Change-Id: Ide414ffda9eae8272f4208fd821b9de7ef7d02b5
    Reviewed-on: https://chromium-review.googlesource.com/c/1411647
    Reviewed-by: John Wu <jzw@chromium.org>
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623265}

    Changed files

    • ios/web_view/internal/passwords/web_view_password_manager_internals_service_factory.h
    • ios/web_view/internal/passwords/web_view_password_manager_internals_service_factory.mm
    • ios/web_view/internal/passwords/web_view_password_store_factory.h
    • ios/web_view/internal/passwords/web_view_password_store_factory.mm

50. Split WebWidgetClient setting out of WebView::Create().

    Changed by	danakj - danakjohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 17:00:26 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	284d557d42d9179990b260046c5a25e1ffd25277

    Comments

    Split WebWidgetClient setting out of WebView::Create().
    
    Add WebView::SetWebWidgetClient() that is called before setting up the
    main frame and attaching it to the view. TODOs are sprinkled around as
    what we should do in follow-ups.
    
    Callers other than RenderViewImpl move the SetWebWidgetClient to be
    called after initializing the WebView, but before making the main
    frame. Next should be to remove SetWebWidgetClient calls from all
    these places and move it to where RenderViewImpl attaches the
    WebFrameWidget to the RenderWidget.
    
    Then, RenderWidget::Init() should be moved to be after the attachment
    of the main frame, and at that point RenderWidget will always have a
    WebFrameWidget (instead of WebView as a WebWidget), except when the
    RenderWidget is frozen (the main frame is remote).
    
    Last, we then want to remove the SetWebWidgetClient calls (or reset
    it to null) when the main frame is remote, but CloseWidgetSoon goes
    through WebWidgetClient and should go through WebViewClient instead,
    so a TODO is added. There may be more cases like this.
    
    R=dcheng@chromium.org
    TBR=dcheng
    
    Change-Id: Id6b9d85501c4bf5a3cdfc3106b6bb18656a7c11f
    Bug: 912193
    Reviewed-on: https://chromium-review.googlesource.com/c/1406195
    Commit-Queue: danakj <danakj@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623264}

    Changed files

    • components/plugins/renderer/webview_plugin.cc
    • components/printing/renderer/print_render_frame_helper.cc
    • content/renderer/render_view_impl.cc
    • extensions/renderer/scoped_web_frame.cc
    • media/blink/webmediaplayer_impl_unittest.cc
    • third_party/blink/public/web/web_view.h
    • third_party/blink/public/web/web_widget_client.h
    • third_party/blink/renderer/core/exported/web_view_impl.cc
    • third_party/blink/renderer/core/exported/web_view_impl.h
    • third_party/blink/renderer/core/exported/web_view_test.cc
    • third_party/blink/renderer/core/exported/worker_shadow_page.cc
    • third_party/blink/renderer/core/frame/frame_test_helpers.cc
    • third_party/blink/renderer/core/frame/frame_test_helpers.h

51. Revert "Roll src/third_party/googletest/src/ 879ac092f..933e5df28 (77 commits)"

    Changed by	Ian Clelland - iclellandohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 17:00:19 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	0662f8f76651392ce948262f7f695b1fe3b6dcb3

    Comments

    Revert "Roll src/third_party/googletest/src/ 879ac092f..933e5df28 (77 commits)"
    
    This reverts commit bad68fb909113708fa3d8e911d79a8c12ee64805.
    
    Reason for revert: Sheriff tentatively rolling back, this may be causing consistent failures on two bots:
    
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29 (failing since build 31084)
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux (failing since build 65979)
    
    If this doesn't clear the bots, I'll re-land.
    
    Original change's description:
    > Roll src/third_party/googletest/src/ 879ac092f..933e5df28 (77 commits)
    > 
    > https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/879ac092fde0..933e5df28372
    > Also updates BUILD.gn to reflect new files added to Googletest.
    > 
    > $ git log 879ac092f..933e5df28 --date=short --no-merges --format='%ad %ae %s'
    > 2019-01-02 misterg Remove outdated scripts
    > 2019-01-02 misterg Revert "test, please ignore"
    > 2018-12-28 syohex Update Xcode project file
    > 2018-12-27 machida_mn Merge #2002
    > 2018-12-27 gennadiycivil Update README.md
    > 2018-12-21 chrisjohnsonmail fix:  Correct GitHub paths
    > 2018-12-21 gennadiycivil Update README.md
    > 2018-12-21 absl-team Googletest export
    > 2018-12-20 absl-team Googletest export
    > 2018-12-19 absl-team Googletest export
    > 2018-12-17 absl-team Googletest export
    > 2018-12-17 misterg Googletest export
    > 2018-12-17 misterg Googletest export
    > 2018-12-17 gennadiycivil Update README.md
    > 2018-12-17 misterg Googletest export
    > 2018-12-16 absl-team Googletest export
    > 2018-12-15 absl-team Googletest export
    > 2018-12-14 absl-team Googletest export
    > 2018-12-15 chrisjohnsonmail chore:  Add .vs to .gitignore for Visual Studio
    > 2018-12-15 chrisjohnsonmail fix:  correct JSON syntax
    > 2018-12-13 absl-team Googletest export
    > 2018-12-12 misterg Googletest export
    > 2018-12-13 gennadiycivil Update README.md
    > 2018-12-11 absl-team Googletest export
    > 2018-12-12 dominic Use if statements
    > 2018-12-11 dominic Don't cache APT packages on OS X/macOS
    > 2018-12-11 dominic Change directory ownership earlier
    > 2018-12-11 misterg Googletest export
    > 2018-12-10 absl-team Googletest export
    > 2018-12-10 dominic Cache gcc and clang APT packages
    > 2018-12-07 chrisjohnsonmail chore:  Update version to latest release
    > 2018-12-06 chrisjohnsonmail fix: Remove global chmod from Travis
    > 2018-12-06 chrisjohnsonmail chore:  Add initial library.json config
    > 2018-12-04 chrisjohnsonmail feat:  Add initial support for PlatformIO and Arduino
    > 2018-12-03 absl-team Googletest export
    > 2018-12-04 gregory.pakosz Do not define GTEST_IS_THREADSAFE within GTEST_HAS_SEH
    > 2018-12-03 misterg Googletest export
    > 2018-12-03 gennadiycivil Update WORKSPACE
    > 2018-12-03 gennadiycivil Update README.md
    > 2018-12-03 gennadiycivil Update README.md
    > 2018-12-03 misterg Googletest export
    > 2018-12-03 absl-team Googletest export
    > 2018-12-03 absl-team Googletest export
    > 2018-12-04 godre007 Fixed typo
    > 2018-11-28 durandal Googletest export
    > 2018-11-27 durandal Googletest export
    > 2018-11-21 misterg Googletest export
    > 2018-11-26 gennadiycivil Update .travis.yml
    > 2018-11-26 gennadiycivil Update .travis.yml
    > 2018-11-26 gennadiycivil Update .travis.yml
    > 2018-11-26 gennadiycivil Update .travis.yml
    > 2018-11-26 gennadiycivil Create CODE_OF_CONDUCT.md
    > 2018-11-22 lukas.mosimann Issue #1955: Remove THREADS_PREFER_PTHREAD_FLAG
    > 2018-11-20 gennadiycivil Update build badge
    > 2018-11-20 misterg Googletest export
    > 2018-11-20 absl-team Googletest export
    > 2018-11-20 absl-team Googletest export
    > 2018-11-20 misterg Googletest export
    > 2018-11-19 misterg Googletest export
    > 2018-11-18 absl-team Googletest export
    > 2018-11-16 absl-team Googletest export
    > 2018-11-16 absl-team Googletest export
    > 2018-11-15 durandal Googletest export
    > 2018-11-15 absl-team Googletest export
    > 2018-11-15 absl-team Googletest export
    > 2018-11-14 absl-team Googletest export
    > 2018-11-09 absl-team Googletest export
    > 2018-11-13 13814002+coppered Update README.md
    > 2018-11-10 dev Add back warning suppression that shouldn't have been removed
    > 2018-11-10 dev Define GTEST_DISABLE_MSC_WARNINGS_PUSH/POP for all compilers
    > 2018-11-10 dev Remove GTEST_HAS_HASH_SET/MAP check
    > 2018-11-10 dev Remove workarounds for unsupported MSVC versions
    > 2018-11-08 absl-team Googletest export
    > 2018-11-06 krzysio Googletest export
    > 2018-10-31 misterg Googletest export
    > 2018-11-01 bc818216 Added line to sample Makefile in googletest/googletest/make to specify use of C++11 in CXXFLAGS as required by the system
    > 2018-10-09 misterg test, please ignore
    > 
    > Created with:
    >   roll-dep src/third_party/googletest/src
    > 
    > Change-Id: I6fc2e4d8a4b3ada75bd102a6f45da0df71a3ba92
    > Reviewed-on: https://chromium-review.googlesource.com/c/1410527
    > Reviewed-by: Victor Costan <pwnall@chromium.org>
    > Commit-Queue: Staphany Park <staphany@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#623075}
    
    TBR=pwnall@chromium.org,staphany@chromium.org
    
    Change-Id: Icbb74a7d7478e3ee9bef1358ae8b8f013ae1c3d8
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/1415130
    Reviewed-by: Ian Clelland <iclelland@chromium.org>
    Commit-Queue: Ian Clelland <iclelland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623263}

    Changed files

    • DEPS
    • third_party/googletest/BUILD.gn
    • third_party/googletest/README.chromium

52. Make sandbox/linux/OWNERS also own content/browser/sandbox*_linux*

    Changed by	Gabriel Charette - gabohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 16:53:34 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	e3ce72f6da3038b91d68cda520bb88ef08033fec

    Comments

    Make sandbox/linux/OWNERS also own content/browser/sandbox*_linux*
    
    Old owners were lingering in this per-file section of //content.
    
    Updating owners as discussed @
    https://chromium-review.googlesource.com/c/chromium/src/+/1378683/6#message-0d7ab064a292db7e520ef897c98aa178473bc7db
    
    R=rsesek@chromium.org
    TBR=avi@chromium.org
    
    Change-Id: I1b827a90f836d7e8658c51291f94af9596ddbbd3
    Reviewed-on: https://chromium-review.googlesource.com/c/1414874
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Reviewed-by: Robert Sesek <rsesek@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623262}

    Changed files

    • content/browser/OWNERS

53. [iOS] Factor session window API into a protocol.

    Changed by	Mark Cogan - marqohnoyoudont@google.com
    Changed at	Wednesday, 16-Jan-19 16:52:58 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	30c24495fea0a96cad53199b5cab883dd1f19417

    Comments

    [iOS] Factor session window API into a protocol.
    
    This CL factors the two TabModel methods used to save and restore session into a
    protocol. Code that uses TabModel for these methods is refactored to separate
    dependencies so TabModel isn't directly needed.
    
    Change-Id: I9f7a01052a261278de9b1ca2a50a9140f8256f85
    Reviewed-on: https://chromium-review.googlesource.com/c/1402446
    Commit-Queue: Mark Cogan <marq@chromium.org>
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Reviewed-by: David Jean <djean@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623261}

    Changed files

    • ios/chrome/app/main_controller.mm
    • ios/chrome/browser/crash_report/crash_restore_helper.h
    • ios/chrome/browser/crash_report/crash_restore_helper.mm
    • ios/chrome/browser/prerender/BUILD.gn
    • ios/chrome/browser/prerender/prerender_service.h
    • ios/chrome/browser/prerender/prerender_service.mm
    • ios/chrome/browser/sessions/BUILD.gn
    • ios/chrome/browser/sessions/session_window_restoring.h
    • ios/chrome/browser/tabs/BUILD.gn
    • ios/chrome/browser/tabs/tab_model.h
    • ios/chrome/browser/tabs/tab_model.mm
    • ios/chrome/browser/ui/browser_view_controller.mm
    • ios/chrome/browser/url_loading/url_loading_util.h
    • ios/chrome/browser/url_loading/url_loading_util.mm

54. Enable Passive document level wheel event listeners flag by default.

    Changed by	Sahel Sharify - sahelohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 16:52:00 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	5bbf0564486f6147dc1d646817c54ebdb7129df4

    Comments

    Enable Passive document level wheel event listeners flag by default.
    
    Intent to ship:
    https://groups.google.com/a/chromium.org/forum/?hl=en#!topic/blink-dev/53q-wRk5QkA
    
    Bug: 626196
    Change-Id: Ib6d5587a323cb56f8da29d746453a87a3a23bfe5
    Reviewed-on: https://chromium-review.googlesource.com/c/1409609
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623260}

    Changed files

    • content/public/common/content_features.cc
    • third_party/blink/renderer/core/testing/data/wheel-event-handler.html
    • third_party/blink/renderer/core/testing/internals.cc
    • third_party/blink/renderer/platform/runtime_enabled_features.json5

55. clang: Add HWASAN Android runtime to the package.

    Changed by	Peter Collingbourne - pccohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 16:50:26 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	eee55f546d178db52b469ec19549f5f76b19ca79

    Comments

    clang: Add HWASAN Android runtime to the package.
    
    Bug: 916828
    Change-Id: I89ecdf1b4c72933f0323572bd233b17417ee969b
    Reviewed-on: https://chromium-review.googlesource.com/c/1410266
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Peter Collingbourne <pcc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623259}

    Changed files

    • tools/clang/scripts/package.py
    • tools/clang/scripts/update.py

56. [iOS] Fixing rounded image in TableViewAccountCell

    Changed by	Jérôme Lebel - jlebelohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 16:42:52 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	15e8f2a92929527aa96b6d5aa7374a67c5f01d70

    Comments

    [iOS] Fixing rounded image in TableViewAccountCell
    
    The corner radius of |_imageView| should always be set to
    kHorizontalImageFixedSize / 2.0f.
    
    Also moving all the subviews attributes to -[TableViewAccountItem
    addSubviews].
    
    Bug: 922501
    Change-Id: Ib3fb2ca61038db12deab2edca1f48d049017b9db
    Reviewed-on: https://chromium-review.googlesource.com/c/1412356
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623258}

    Changed files

    • ios/chrome/browser/ui/authentication/cells/table_view_account_item.mm

57. Changed how CompositorEventAckBrowserTest, MainThreadEventQueueBrowserTest, and TouchpadPinchBrowserTest waits for URL to load.

    Changed by	Edwin Joe - ejoeohnoyoudont@google.com
    Changed at	Wednesday, 16-Jan-19 16:41:33 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	59c4d4d293aef3ff66a5ab900b6613704a0082be

    Comments

    Changed how CompositorEventAckBrowserTest, MainThreadEventQueueBrowserTest, and TouchpadPinchBrowserTest waits for URL to load.
    
    Replaced MainThreadFrameObserver with HitTestRegionObserver to wait for hit test data to be ready.
    
    Test: CompositorEventBrowserTest*,MainThreadEventQueueBrowserTest*,TouchpadPinchBrowserTest*
    Bug: 862683
    Change-Id: Ic4c76d0ec2acbfdc30959c476b80efa664198dc0
    Reviewed-on: https://chromium-review.googlesource.com/c/1412626
    Reviewed-by: Jonathan Ross <jonross@chromium.org>
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Commit-Queue: Edwin Joe <ejoe@google.com>
    Cr-Commit-Position: refs/heads/master@{#623257}

    Changed files

    • content/browser/renderer_host/input/compositor_event_ack_browsertest.cc
    • content/browser/renderer_host/input/main_thread_event_queue_browsertest.cc
    • content/browser/renderer_host/input/touchpad_pinch_browsertest.cc

58. Rename Pause/Unpaused to ContextPaused/ContextUnpaused.

    Changed by	Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 16:39:24 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	2cb051b10b43c16be97fd54b657dad8eb40b8b10

    Comments

    Rename Pause/Unpaused to ContextPaused/ContextUnpaused.
    
    Add a enumeration state of the type of pausing of tasks the
    ExecutionContext has.
    
    kPaused is the state where only tasks are paused.
    kFrozen is the state where all things on the page should be paused
    including media.
    
    BUG=907125
    
    Change-Id: Id72209f25bdc7d512d6cc41b02636c2bdadb54a3
    Reviewed-on: https://chromium-review.googlesource.com/c/1409812
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623256}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/script_promise_resolver_test.cc
    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/dom/BUILD.gn
    • third_party/blink/renderer/core/dom/context_lifecycle_notifier.cc
    • third_party/blink/renderer/core/dom/context_lifecycle_notifier.h
    • third_party/blink/renderer/core/dom/document.cc
    • third_party/blink/renderer/core/dom/scripted_idle_task_controller.cc
    • third_party/blink/renderer/core/dom/scripted_idle_task_controller.h
    • third_party/blink/renderer/core/execution_context/BUILD.gn
    • third_party/blink/renderer/core/execution_context/execution_context.cc
    • third_party/blink/renderer/core/execution_context/execution_context.h
    • third_party/blink/renderer/core/execution_context/pausable_object.cc
    • third_party/blink/renderer/core/execution_context/pausable_object.h
    • third_party/blink/renderer/core/execution_context/pausable_object_test.cc
    • third_party/blink/renderer/core/execution_context/pause_state.h
    • third_party/blink/renderer/core/html/media/html_media_element.h
    • third_party/blink/renderer/core/inspector/worker_thread_debugger.cc
    • third_party/blink/renderer/core/loader/frame_loader.cc
    • third_party/blink/renderer/modules/battery/battery_manager.cc
    • third_party/blink/renderer/modules/battery/battery_manager.h
    • third_party/blink/renderer/modules/permissions/permission_status.cc
    • third_party/blink/renderer/modules/permissions/permission_status.h
    • third_party/blink/renderer/modules/presentation/presentation_availability.cc
    • third_party/blink/renderer/modules/presentation/presentation_availability.h
    • third_party/blink/renderer/modules/vr/vr_display.cc
    • third_party/blink/renderer/modules/vr/vr_display.h
    • third_party/blink/renderer/modules/webaudio/base_audio_context.h
    • third_party/blink/renderer/modules/websockets/dom_websocket.cc
    • third_party/blink/renderer/modules/websockets/dom_websocket.h

59. Roll src/third_party/skia 2c379d8e27e6..1b87c6bc1979 (1 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Wednesday, 16-Jan-19 16:38:00 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	6d6bd3ef7265f02b4947d8d99384d828f096f69d

    Comments

    Roll src/third_party/skia 2c379d8e27e6..1b87c6bc1979 (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/2c379d8e27e6..1b87c6bc1979
    
    
    git log 2c379d8e27e6..1b87c6bc1979 --date=short --no-merges --format='%ad %ae %s'
    2019-01-16 reed@google.com remove SK_SUPPORT_LEGACY_CANVAS_DRAW_TEXT flag
    
    
    Created with:
      gclient setdep -r src/third_party/skia@1b87c6bc1979
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=halcanary@chromium.org
    
    Change-Id: I0e3ec2f98b307ff4d07813d76b69b814867c4092
    Reviewed-on: https://chromium-review.googlesource.com/c/1414991
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623255}

    Changed files

    • DEPS

60. android: re-enable context lost tests

    Changed by	Joshua Peraza - jperazaohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 16:31:40 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	9e8a68b1c1f9f3ebef90b7547580cbfa83f61a39

    Comments

    android: re-enable context lost tests
    
    These should be running correctly after recent fixes to Crashpad.
    
    Bug: 911678
    Change-Id: Ib92b29c71a4e1195cf2031f7c9927f8f3edd5a7b
    Reviewed-on: https://chromium-review.googlesource.com/c/1413332
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Commit-Queue: Joshua Peraza <jperaza@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623254}

    Changed files

    • content/test/gpu/gpu_tests/context_lost_expectations.py

61. Remove GetThemedAssetColor().

    Changed by	Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 16:17:39 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	0d7ebfdf51a4c76d023b5171172f7a4d6966d3e5

    Comments

    Remove GetThemedAssetColor().
    
    This method was first added in http://crrev.com/550045 to fix bug 814121 by
    matching Clank behavior.  It was then generalized in http://crrev.com/592661 to
    apply to more cases.
    
    Unfortunately, the Clank behavior does not guarantee sufficient contrast to meet
    WCAG AA standards.  It guarantees contrast 3 against darker colors, when the
    minimum for text is 4.5; and it uses 64% black otherwise, which with the 3
    threshold only guarantees a contrast ratio of ~4.
    
    This patch removes the special "themed" path and uses the normal path for
    caption colors, and restores auto color readability to labels.  The net result
    of this is that:
    * On opaque frame (Linux, Win 7 non-Aero, some themes), title and caption
      buttons will use the color that contrasts most with the background, between
      white and GG900 (the Material Refresh "darkest color").
    * On glass frame (Win 7 Aero, Win 10), the behavior is very similar, but uses
      black instead of GG900 and a "luma midpoint" instead of luminance midpoint
      check.  These better match native.
    * On Ash, caption buttons use GG200 or GG700, but will push the contrast up
      until it reaches at least 3.  Window titles, which use auto color readability,
      will further push the contrast of this color to try and reach 4.5.
    
    Effectively, bug 883177, which was originally fixed by moving Linux and Win 7
    toward CrOS, is largely WontFixed, but hopefully the caption button colors and
    title text are now more consistent; and bug 814121, which was fixed by matching
    Clank, is instead fixed by enforcing minimum contrast ratios.
    
    As a nice bonus, this is noticeably simpler.
    
    Bug: 883177
    Change-Id: I0803617c9dfd7e2a27ef399c89ba64d1eec98867
    Reviewed-on: https://chromium-review.googlesource.com/c/1407264
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Alan Cutter <alancutter@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623253}

    Changed files

    • ash/public/cpp/caption_buttons/frame_caption_button_container_view.cc
    • ash/public/cpp/caption_buttons/frame_caption_button_container_view.h
    • ash/public/cpp/frame_header.cc
    • ash/public/cpp/frame_header.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
    • chrome/browser/ui/views/frame/browser_non_client_frame_view.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
    • chrome/browser/ui/views/frame/glass_browser_frame_view.cc
    • chrome/browser/ui/views/frame/glass_browser_frame_view.h
    • chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
    • chrome/browser/ui/views/frame/opaque_browser_frame_view.h
    • chrome/browser/ui/views/frame/opaque_browser_frame_view_browsertest.cc
    • chrome/browser/ui/views/location_bar/custom_tab_bar_view.cc
    • chrome/browser/ui/views/location_bar/custom_tab_bar_view.h
    • ui/gfx/color_utils.cc
    • ui/gfx/color_utils.h
    • ui/views/window/frame_caption_button.cc
    • ui/views/window/frame_caption_button.h
    • ui/views/window/frame_caption_button_unittest.cc

62. [signin] Remove more uses of chrome://chrome-signin on desktop

    Changed by	David Roger - drogerohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 16:17:16 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	200d78d850f5f04322c02bd399e204c3b98b8c2d

    Comments

    [signin] Remove more uses of chrome://chrome-signin on desktop
    
    Since Dice Milestone 2 is now enabled by default on desktop, support
    for the embedded signin flow can be removed.
    
    Bug: 920973
    Change-Id: I0d808f94cb03644ed0a212f5b00285924ca4bd2c
    Reviewed-on: https://chromium-review.googlesource.com/c/1411696
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: David Roger <droger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623252}

    Changed files

    • chrome/browser/signin/signin_ui_util.cc
    • chrome/browser/ui/chrome_pages.cc
    • chrome/browser/ui/signin_view_controller.cc
    • chrome/browser/ui/signin_view_controller.h

63. Reland "Avoid copying Lengths (non-layout uses)"

    Changed by	Fredrik Söderquist - fsohnoyoudont@opera.com
    Changed at	Wednesday, 16-Jan-19 16:07:34 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	962cd513e118d09d9cb7ccbcf426cf0e271af40b

    Comments

    Reland "Avoid copying Lengths (non-layout uses)"
    
    This reverts commit ae5e5a5785d23ad6ca824b1ff399fe31b9060b77.
    
    Reason for revert: The cause for the link failure is unknown but not the fault of the CL. (See for example https://crbug.com/921967 for similar failures.)
    
    Original change's description:
    > Revert "Avoid copying Lengths (non-layout uses)"
    > 
    > This reverts commit 784f852591a08f9bce6005cbb1df682cc5608af0.
    > 
    > Reason for revert: Causes link failures on Android FYI Release (Nexus 6P)
    > 
    > Original change's description:
    > > Avoid copying Lengths (non-layout uses)
    > > 
    > > Copying/assigning a Length is not just a trivial copy, so when possible,
    > > use a const Length& to avoid making a copy (saving some small bit of
    > > footprint and hopefully a few CPU cycles too).
    > > 
    > > Change-Id: I8bcf5c6e6b99027110a20b1ef95d5f6607673ddc
    > > Reviewed-on: https://chromium-review.googlesource.com/c/1411919
    > > Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    > > Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#623209}
    > 
    > TBR=fs@opera.com,mstensho@chromium.org
    > 
    > Change-Id: Ifd8aad2dc3c78703a7f544564417ceb15cddcdda
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Reviewed-on: https://chromium-review.googlesource.com/c/1414993
    > Reviewed-by: Corentin Wallez <cwallez@chromium.org>
    > Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#623248}
    
    TBR=fs@opera.com,cwallez@chromium.org,mstensho@chromium.org
    
    Change-Id: Id247820a5c902209354452d495537ab02efb7605
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/1414939
    Reviewed-by: Fredrik Söderquist <fs@opera.com>
    Commit-Queue: Fredrik Söderquist <fs@opera.com>
    Cr-Commit-Position: refs/heads/master@{#623251}

    Changed files

    • third_party/blink/renderer/core/frame/page_scale_constraints_set.cc
    • third_party/blink/renderer/core/frame/page_scale_constraints_set.h
    • third_party/blink/renderer/core/html/forms/text_control_inner_elements.cc
    • third_party/blink/renderer/core/html/html_image_fallback_helper.cc
    • third_party/blink/renderer/core/page/viewport_description.cc
    • third_party/blink/renderer/core/page/viewport_description.h
    • third_party/blink/renderer/core/style/style_reflection.h

64. [TaskScheduler]: Migrate off of AssertBlockingAllowedDeprecated in /content/common/mac/font_loader.mm

    Changed by	Etienne Pierre-Doray - etiennepohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 15:48:23 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	ffd976908696323692e2f34cefef9efc4f12d313

    Comments

    [TaskScheduler]: Migrate off of AssertBlockingAllowedDeprecated in /content/common/mac/font_loader.mm
    
    base::AssertBlockingAllowedDeprecated is deprecated in favor of
    ScopedBlockingCall, which serves as a precise annotation of
    the scope that may/will block.
    
    Please make sure of the following:
      - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
        If this is not the case, ScopedBlockingCall should be instantiated
        closer to the blocking call. See scoped_blocking_call.h for more
        info. Please let me know when/where the blocking call happens if this needs
        to be changed.
      - Parameter |blocking_type| matches expectation:
          MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
          WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
            server synchronously).
        See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
        not be the best fit if we know that this callsite is guaranteed to block.
      - The ScopedBlockingCall's scope covers the entirety of the blocking operation
        previously asserted against by the AssertBlockingAllowed().
      - Calls to blocking //base APIs don't need to be annotated
        with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read,
        base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their
        own internal annotations.
    
    Refer to the top-level CL if necessary :
    https://chromium-review.googlesource.com/c/chromium/src/+/1338391
    
    Please CQ if LGTY!
    
    This CL was uploaded by git cl split.
    
    R=tapted@chromium.org
    
    Bug: 903957
    Change-Id: Iac85ee6160e26265c7c41aace19f23fa9553ff46
    Reviewed-on: https://chromium-review.googlesource.com/c/1365880
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623250}

    Changed files

    • content/common/mac/font_loader.mm

65. Android: Remove build/android/play_services

    Changed by	Peter Wen - wnwenohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 15:45:58 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	7899e08d3eafd91c8feba31e2a18b715f833675f

    Comments

    Android: Remove build/android/play_services
    
    We have already migrated upstream to third_party/android_deps so these
    files and related buildsteps are no longer needed.
    
    This CL also removes the [y/n] confirmation for the Play SDK.
    
    Bug: 877957,868879
    Change-Id: I6bdb5355031a2d3a4a9a2f82531bd1956f288edd
    Reviewed-on: https://chromium-review.googlesource.com/c/1394925
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Peter Wen <wnwen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623249}

    Changed files

    • DEPS
    • build/android/PRESUBMIT.py
    • build/android/play_services/LICENSE.sha1
    • build/android/play_services/config.json
    • build/android/play_services/google_play_services_library.zip.sha1
    • build/android/play_services/update.py
    • build/android/play_services/update_test.py
    • tools/android/roll/update_support_library.py

66. Revert "Avoid copying Lengths (non-layout uses)"

    Changed by	Corentin Wallez - cwallezohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 15:45:22 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	ae5e5a5785d23ad6ca824b1ff399fe31b9060b77

    Comments

    Revert "Avoid copying Lengths (non-layout uses)"
    
    This reverts commit 784f852591a08f9bce6005cbb1df682cc5608af0.
    
    Reason for revert: Causes link failures on Android FYI Release (Nexus 6P)
    
    Original change's description:
    > Avoid copying Lengths (non-layout uses)
    > 
    > Copying/assigning a Length is not just a trivial copy, so when possible,
    > use a const Length& to avoid making a copy (saving some small bit of
    > footprint and hopefully a few CPU cycles too).
    > 
    > Change-Id: I8bcf5c6e6b99027110a20b1ef95d5f6607673ddc
    > Reviewed-on: https://chromium-review.googlesource.com/c/1411919
    > Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    > Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#623209}
    
    TBR=fs@opera.com,mstensho@chromium.org
    
    Change-Id: Ifd8aad2dc3c78703a7f544564417ceb15cddcdda
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/1414993
    Reviewed-by: Corentin Wallez <cwallez@chromium.org>
    Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623248}

    Changed files

    • third_party/blink/renderer/core/frame/page_scale_constraints_set.cc
    • third_party/blink/renderer/core/frame/page_scale_constraints_set.h
    • third_party/blink/renderer/core/html/forms/text_control_inner_elements.cc
    • third_party/blink/renderer/core/html/html_image_fallback_helper.cc
    • third_party/blink/renderer/core/page/viewport_description.cc
    • third_party/blink/renderer/core/page/viewport_description.h
    • third_party/blink/renderer/core/style/style_reflection.h

67. Roll Fuchsia SDK from 7602f7f9697e to d4f82181b96d

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Wednesday, 16-Jan-19 15:43:27 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	565439bba38f060906fac58ccb650fbc4c080477

    Comments

    Roll Fuchsia SDK from 7602f7f9697e to d4f82181b96d
    
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
    TBR=cr-fuchsia+bot@chromium.org
    
    Change-Id: Icd9fb0b7ce9b99d13af6e42fe278fcd8ddd8291d
    Reviewed-on: https://chromium-review.googlesource.com/c/1414990
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623247}

    Changed files

    • build/fuchsia/linux.sdk.sha1
    • build/fuchsia/mac.sdk.sha1

68. Roll src/third_party/angle ab2bfa814cee..a5d2d55d2a27 (1 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Wednesday, 16-Jan-19 15:39:58 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	1074c8ac99fa1acb0228f4e9ae540e9fae7081bf

    Comments

    Roll src/third_party/angle ab2bfa814cee..a5d2d55d2a27 (1 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/ab2bfa814cee..a5d2d55d2a27
    
    
    git log ab2bfa814cee..a5d2d55d2a27 --date=short --no-merges --format='%ad %ae %s'
    2019-01-16 jsaarhelo@nvidia.com Remove expected SSBO failures on Windows NVIDIA
    
    
    Created with:
      gclient setdep -r src/third_party/angle@a5d2d55d2a27
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=cwallez@chromium.org
    
    Change-Id: Ib6e17764847a0e0210c5b77665afe90a64f4f0d1
    Reviewed-on: https://chromium-review.googlesource.com/c/1414703
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623246}

    Changed files

    • DEPS

69. Changed how ScrollLatencyBrowserTest waits for URL to load

    Changed by	Edwin Joe - ejoeohnoyoudont@google.com
    Changed at	Wednesday, 16-Jan-19 15:37:49 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	3ffd6f6a6061fd407ea2ceacb36424407cb83045

    Comments

    Changed how ScrollLatencyBrowserTest waits for URL to load
    
    - Changed the LoadURL method to wait for the URL hit test data using
    HitTestFrameObserver instead of MainThreadFrameObserver.
    - Removed the WaitAFrame() method as it is not used anywhere else
    except in LoadURL.
    - Removed MainThreadFrameObserver unique_ptr from the private field since
    it is not used anywhere else except in LoadURL.
    
    Test: ScrollLatencyBrowserTest*
    Bug: 862683
    Change-Id: I837fb52611a9d7f520780d004e230db6a3bdbb18
    Reviewed-on: https://chromium-review.googlesource.com/c/1412803
    Reviewed-by: Jonathan Ross <jonross@chromium.org>
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Commit-Queue: Edwin Joe <ejoe@google.com>
    Cr-Commit-Position: refs/heads/master@{#623245}

    Changed files

    • content/browser/renderer_host/input/scroll_latency_browsertest.cc

70. Roll src-internal 5ab7028d455c..0c86e5f84f6e (1 commits)

    Changed by	chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at	Wednesday, 16-Jan-19 15:36:47 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	930791d3d70052aa65ca41d06c9b7d653e856d6c

    Comments

    Roll src-internal 5ab7028d455c..0c86e5f84f6e (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5ab7028d455c..0c86e5f84f6e
    
    
    Created with:
      gclient setdep -r src-internal@0c86e5f84f6e
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I1e79f96bfc00aee0e39f318474585ec6bb4c6989
    Reviewed-on: https://chromium-review.googlesource.com/c/1414702
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623244}

    Changed files

    • DEPS

71. [Zucchini] ARM code: Fix counting mistake; rename T21 to T20.

    Changed by	Samuel Huang - huangsohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 15:31:06 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	64b76696cded1502e1f9dd055dd3e2a51fa70f80

    Comments

    [Zucchini] ARM code: Fix counting mistake; rename T21 to T20.
    
    ARM instruction B encoding T3 specifies:
      |code|: 11110Scc cciiiiii 10(J1)0(J2)jjj jjjjjjjj
      |disp|: SSSSSSSS SSSS(J2)(J1)ii iiiijjjj jjjjjjj0
    
    There are 20 bits in |code| dedicated for |disp|:
      S iiiiii (J1)(J2)jjj jjjjjjjj
    
    Previously this was miscounted as 21! This CL corrects the mistake, and
    renames "T21" to "T20". There's no change in behavior.
    
    Bug: 918867
    Change-Id: Ie571bc1a413c4b77f2017cfd2ffe8bf99975ef7a
    Reviewed-on: https://chromium-review.googlesource.com/c/1413352
    Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
    Reviewed-by: Samuel Huang <huangs@chromium.org>
    Commit-Queue: Samuel Huang <huangs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623243}

    Changed files

    • components/zucchini/arm_utils.cc
    • components/zucchini/arm_utils.h
    • components/zucchini/arm_utils_unittest.cc

72. Download auto-resumptions : Fixed a crash

    Changed by	Shakti Sahu - shaktisahuohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 15:28:23 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	cb2b6f9fbddc53ea92e59f7966c299b8f5ae57c8

    Comments

    Download auto-resumptions : Fixed a crash
    
    After a download gets interrupted, we try to resume it immediately
    after 1 second delay (due to weird behavior of network listeners when
    going from 4G to WIFI). However the download might get destroyed
    during this delay and we will hit a crash upon resumption.
    Added checks to avoid this crash.
    
    Bug: 921559
    Change-Id: Ifa615f0388cde4879117c6c2dfabfc60c6278c13
    Reviewed-on: https://chromium-review.googlesource.com/c/1396670
    Reviewed-by: David Trainor <dtrainor@chromium.org>
    Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623242}

    Changed files

    • components/download/public/common/auto_resumption_handler.cc
    • components/download/public/common/auto_resumption_handler.h

73. Move source of truth for SetSyncRequested to SyncUserSettings

    Changed by	Marc Treib - treibohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 15:17:32 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	b982d03aea7157c8f0cfbf44e99c72c2b614e16e

    Comments

    Move source of truth for SetSyncRequested to SyncUserSettings
    
    This also lets us remove ProfileSyncService::RequestStart/Stop.
    (RequestStop is now identical to StopImpl, and RequestStart can be
    easily inlined at the call sites.)
    
    Bug: 884159
    Change-Id: I03ca6040e444d351a5fe554adba0f0e685abc768
    Reviewed-on: https://chromium-review.googlesource.com/c/1412031
    Commit-Queue: Marc Treib <treib@chromium.org>
    Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623241}

    Changed files

    • components/browser_sync/profile_sync_service.cc
    • components/browser_sync/profile_sync_service.h
    • components/browser_sync/sync_user_settings_impl.cc
    • components/sync/base/sync_prefs.cc
    • components/sync/base/sync_prefs.h
    • components/sync/base/sync_prefs_unittest.cc

74. [Nav Experiment] Fix crash in CRWWebController -touched.

    Changed by	Danyao Wang - danyaoohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 15:16:32 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	78328156802a611f98d80228cebfb6f50e6f62f0

    Comments

    [Nav Experiment] Fix crash in CRWWebController -touched.
    
    During session restoration, GetItemCount() returns the size of the
    restored session, but GetLastCommittedItem() returns nullptr. Code that
    dereferences GetLastCommittedItem() should check it directly.
    
    Since some instances of this crash predates crrev.com/c/1359040, which
    changed GetLastCommittedItem() to return nullptr during session
    restoration, there may be other use cases that trigger this bug. Added
    DCHECK detect such cases.
    
    Bug: 910229
    Change-Id: I50f5c36a3fa06cb4ce78ce75d8fffe2965a635de
    Reviewed-on: https://chromium-review.googlesource.com/c/1413139
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623240}

    Changed files

    • ios/web/navigation/wk_based_navigation_manager_impl.mm
    • ios/web/web_state/ui/crw_web_controller.mm

75. [LayoutNG] Fix inserting a child into an anonymous first-line inline.

    Changed by	Ian Kilpatrick - ikilpatrickohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 15:15:11 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	c523b7e56ae17c3eb5e9482b6b42691e870f8190

    Comments

    [LayoutNG] Fix inserting a child into an anonymous first-line inline.
    
    This fixes a bug that was brought up in:
    https://chromium-review.googlesource.com/c/chromium/src/+/1405884
    
    Effectively we now have an anonymous inline wrapper representing the
    first-line style. We also have checks in the current codebase relating
    to a similar concept with display:contents. Makes sure this branch
    is only hit for the display:contents case.
    
    Bug: 636993
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I0271952aa981d861cc7a33e646b5594efe22da1f
    Reviewed-on: https://chromium-review.googlesource.com/c/1413634
    Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623239}

    Changed files

    • third_party/blink/renderer/core/dom/layout_tree_builder.h
    • third_party/blink/web_tests/external/wpt/css/css-display/display-inline-dynamic-001-ref.html
    • third_party/blink/web_tests/external/wpt/css/css-display/display-inline-dynamic-001.html

76. [scheduler] Fixing b/920678.

    Changed by	Karolina Soltys - ksoltohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 15:14:14 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	2a5c8e0a42bbec6b2cb6b909a2d96849f0aa21f4

    Comments

    [scheduler] Fixing b/920678.
    
    The different Java scheduler classes were using the same type of native
    scheduler due to a bug in JNI bindings. This now got fixed.
    
    Bug: 920678
    Change-Id: I5b02ae9d446f5abd550d28ae437dc1d4cdb5d888
    Reviewed-on: https://chromium-review.googlesource.com/c/1412001
    Commit-Queue: Karolina Soltys <ksolt@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623238}

    Changed files

    • base/BUILD.gn
    • base/android/java/src/org/chromium/base/task/SequencedTaskRunnerImpl.java
    • base/android/java/src/org/chromium/base/task/SingleThreadTaskRunnerImpl.java
    • base/android/java/src/org/chromium/base/task/TaskRunnerImpl.java
    • base/android/task_scheduler/single_thread_task_runner_android.cc
    • base/android/task_scheduler/task_runner_android.cc
    • base/android/task_scheduler/task_runner_android.h
    • content/public/android/javatests/src/org/chromium/content/browser/scheduler/NativePostTaskTest.java

77. EXO: Initialize NativePixmapFactory in exo::Display()

    Changed by	Daniel Nicoara - dnicoaraohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 15:12:34 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	a8572138f48f5f39449d8df713db73f3c27b45af

    Comments

    EXO: Initialize NativePixmapFactory in exo::Display()
    
    Initializes the NativePixmapFactory in the constructor without any
    arguments. This constructor is used by Chromecast and allows buffers to
    be imported via dmabuf.
    
    Bug: 896710
    Test: Run on device with sample client using accelerated buffers.
    Change-Id: I669b3a8613418b2041ce9d02ae0707fe0b117b40
    Reviewed-on: https://chromium-review.googlesource.com/c/1412512
    Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
    Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623237}

    Changed files

    • components/exo/display.cc

78. [Sync] Re-enable integration tests disabled due to clang roll

    Changed by	Jan Krcal - jkrcalohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 15:06:53 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	eb2905ee5a9671d13704f29efaf0780206c3b9b6

    Comments

    [Sync] Re-enable integration tests disabled due to clang roll
    
    This CL re-enables sync_integration_tests that got disabled due to TSan
    failures (that started occurring after a clang roll). All the issues
    have been resolved in the mean-time so we should be safe to run them
    again.
    
    Bug: 917380
    Change-Id: I1caec9a7df406b1fca717d4b78b7d774215950e1
    Reviewed-on: https://chromium-review.googlesource.com/c/1412812
    Commit-Queue: Jan Krcal <jkrcal@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623236}

    Changed files

    • chrome/browser/sync/test/integration/single_client_custom_passphrase_sync_test.cc
    • chrome/browser/sync/test/integration/single_client_typed_urls_sync_test.cc
    • chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
    • chrome/browser/sync/test/integration/two_client_custom_passphrase_sync_test.cc
    • chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc
    • chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc

79. [signin] Remove SigninTracker usage from login_ui_test_utils

    Changed by	David Roger - drogerohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 15:01:31 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	f5cb3963d0dc67f8daeb524a9ed4a6882476aaf1

    Comments

    [signin] Remove SigninTracker usage from login_ui_test_utils
    
    SigninTracker is only used by deprecated signin flows and will be
    removed.
    
    Bug: 915678
    Change-Id: I77b49971bfb1ac53873b3b091a6819ade7a19f26
    Reviewed-on: https://chromium-review.googlesource.com/c/1414897
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: David Roger <droger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623235}

    Changed files

    • chrome/browser/ui/webui/signin/login_ui_test_utils.cc

80. [Tango->FCM] Consolidate all sender and app ids in one place.

    Changed by	Tanja Gornak - melandoryohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 15:01:02 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	1e9065485845b013e6a5c939fb8d584e4b10a21d

    Comments

    [Tango->FCM] Consolidate all sender and app ids in one place.
    
    The patch is the refactoring, no behavioral changes.
    
    FCM Sender ID is a unique numerical value which is used to identify the project.
    In the invalidations, sender id is used in two places:
    * In order to register against FCM and get the instance id token.
    * In order to identify the request for the subscription.
    
    Currently sender id token is "stored" in two places. This patch fixes that.
    
    Bug: 801985
    Change-Id: I66661d44bb494d9e56509c5b95b594ef8b4814f5
    Reviewed-on: https://chromium-review.googlesource.com/c/1413600
    Commit-Queue: Tatiana Gornak <melandory@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623234}

    Changed files

    • components/invalidation/impl/fcm_invalidation_listener_unittest.cc
    • components/invalidation/impl/fcm_invalidation_service.cc
    • components/invalidation/impl/fcm_invalidator.cc
    • components/invalidation/impl/fcm_invalidator.h
    • components/invalidation/impl/fcm_invalidator_unittest.cc
    • components/invalidation/impl/fcm_network_handler.cc
    • components/invalidation/impl/fcm_network_handler.h
    • components/invalidation/impl/fcm_network_handler_unittests.cc
    • components/invalidation/impl/per_user_topic_registration_manager.cc
    • components/invalidation/impl/per_user_topic_registration_manager.h
    • components/invalidation/impl/per_user_topic_registration_manager_unittest.cc

81. Fix web cursor transparency when scaled.

    Changed by	kylechar - kylecharohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 14:39:37 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	ba5cf7b3d18065b934e9a55e2380450f28ad585a

    Comments

    Fix web cursor transparency when scaled.
    
    Custom web cursors with transparency were not displaying correctly when
    scaled, for example when device scale factor is not 1.0. The cursor
    would become fully opaque after scaling.
    
    The helper function skia::ImageOperations::Resize() doesn't appear to
    handle the alpha channel correctly with unpremultiplied alpha SkBitmaps.
    SkPixmap::scaleImage() does support unpremultiplied alpha SkBitmaps so
    use that instead. I filed https://crbug.com/919866 to see if
    skia::ImageOperations::Resize() could just use SkPixmap::scaleImage() at
    some point.
    
    Also add a test for ScaleAndRotateCursorBitmapAndHotpoint(). There was
    already a test that only ran with X11 and premultiplied alpha SkBitmap.
    Make the test run on all platforms and parameterize it to run with both
    alpha types.
    
    Bug: 829517, 919866
    Change-Id: I12213b03a2569240cf4206869906fb0834217155
    Reviewed-on: https://chromium-review.googlesource.com/c/1400356
    Commit-Queue: kylechar <kylechar@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Mike Klein <mtklein@chromium.org>
    Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623233}

    Changed files

    • content/test/content_test_suite.cc
    • content/test/content_test_suite.h
    • ui/base/BUILD.gn
    • ui/base/cursor/cursor_loader_x11_unittest.cc
    • ui/base/cursor/cursor_util.cc
    • ui/base/cursor/cursor_util_unittest.cc

82. Convert from base::{LazyInstance,Singleton} to base::NoDestructor

    Changed by	Sylvain Defresne - sdefresneohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 14:32:49 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	71423ee1ddfe6dc0efa722e23408d9662d97f2f6

    Comments

    Convert from base::{LazyInstance,Singleton} to base::NoDestructor
    
    The class base::NoDestructor is a simpler way to define a static
    global value (aka a singleton) than base::{LazyInstance,Singleton}
    and is the recommended pattern to use.
    
    The changes were automated using a custom one-shot script, then
    fine tuned by hand (to remove unnecessary classes, ...).
    
    This fixes usages in src/ios/chrome.
    
    This CL was uploaded by git cl split.
    
    Bug: none
    Change-Id: Ie419e6e06684dc36f23dc4565f190ab8c43b3e78
    Reviewed-on: https://chromium-review.googlesource.com/c/1411782
    Reviewed-by: David Roger <droger@chromium.org>
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623232}

    Changed files

    • ios/chrome/browser/autocomplete/autocomplete_classifier_factory.cc
    • ios/chrome/browser/autocomplete/autocomplete_classifier_factory.h
    • ios/chrome/browser/autocomplete/in_memory_url_index_factory.cc
    • ios/chrome/browser/autocomplete/in_memory_url_index_factory.h
    • ios/chrome/browser/autocomplete/shortcuts_backend_factory.h
    • ios/chrome/browser/autocomplete/shortcuts_backend_factory.mm
    • ios/chrome/browser/bookmarks/bookmark_model_factory.cc
    • ios/chrome/browser/bookmarks/bookmark_model_factory.h
    • ios/chrome/browser/bookmarks/bookmark_sync_service_factory.cc
    • ios/chrome/browser/bookmarks/bookmark_sync_service_factory.h
    • ios/chrome/browser/bookmarks/startup_task_runner_service_factory.cc
    • ios/chrome/browser/bookmarks/startup_task_runner_service_factory.h
    • ios/chrome/browser/browsing_data/browsing_data_remover_factory.h
    • ios/chrome/browser/browsing_data/browsing_data_remover_factory.mm
    • ios/chrome/browser/content_settings/cookie_settings_factory.cc
    • ios/chrome/browser/content_settings/cookie_settings_factory.h
    • ios/chrome/browser/content_settings/host_content_settings_map_factory.cc
    • ios/chrome/browser/content_settings/host_content_settings_map_factory.h
    • ios/chrome/browser/google/google_logo_service_factory.h
    • ios/chrome/browser/google/google_logo_service_factory.mm
    • ios/chrome/browser/google/google_url_tracker_factory.cc
    • ios/chrome/browser/google/google_url_tracker_factory.h
    • ios/chrome/browser/leveldb_proto/proto_database_provider_factory.h
    • ios/chrome/browser/leveldb_proto/proto_database_provider_factory.mm
    • ios/chrome/browser/prefs/ios_chrome_pref_model_associator_client.cc
    • ios/chrome/browser/prefs/ios_chrome_pref_model_associator_client.h
    • ios/chrome/browser/prerender/prerender_service_factory.h
    • ios/chrome/browser/prerender/prerender_service_factory.mm
    • ios/chrome/browser/search_engines/template_url_fetcher_factory.cc
    • ios/chrome/browser/search_engines/template_url_fetcher_factory.h
    • ios/chrome/browser/search_engines/template_url_service_factory.cc
    • ios/chrome/browser/search_engines/template_url_service_factory.h
    • ios/chrome/browser/tab_parenting_global_observer.cc
    • ios/chrome/browser/tab_parenting_global_observer.h
    • ios/chrome/browser/undo/bookmark_undo_service_factory.cc
    • ios/chrome/browser/undo/bookmark_undo_service_factory.h
    • ios/chrome/browser/web_data_service_factory.cc
    • ios/chrome/browser/web_data_service_factory.h

83. Convert from base::{LazyInstance,Singleton} to base::NoDestructor

    Changed by	Sylvain Defresne - sdefresneohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 14:32:32 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	4a599ec77ed34748b2b686b0bd270b2ec8771299

    Comments

    Convert from base::{LazyInstance,Singleton} to base::NoDestructor
    
    The class base::NoDestructor is a simpler way to define a static
    global value (aka a singleton) than base::{LazyInstance,Singleton}
    and is the recommended pattern to use.
    
    The changes were automated using a custom one-shot script, then
    fine tuned by hand (to remove unnecessary classes, ...).
    
    This fixes usages in src/ios/chrome/browser/sessions.
    
    This CL was uploaded by git cl split.
    
    Bug: none
    Change-Id: Id5a3582f930b6073b3c42eb365d2deb204e102d9
    Reviewed-on: https://chromium-review.googlesource.com/c/1412175
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623231}

    Changed files

    • ios/chrome/browser/sessions/ios_chrome_tab_restore_service_factory.cc
    • ios/chrome/browser/sessions/ios_chrome_tab_restore_service_factory.h
    • ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios_factory.h
    • ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios_factory.mm

84. Use accessor method EncodedImage::data()

    Changed by	Niels Möller - nisseohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 14:30:55 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	3d7b882ef4138007d7783dee71de8ea519d63dd3

    Comments

    Use accessor method EncodedImage::data()
    
    Intended to enable landing of
    https://webrtc-review.googlesource.com/c/src/+/117722
    
    Bug: webrtc:9378
    Change-Id: If73ae048f1cc42bfdc2d82d89e8097a16f420fd2
    Reviewed-on: https://chromium-review.googlesource.com/c/1412830
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Niels Möller <nisse@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623230}

    Changed files

    • content/renderer/media/webrtc/rtc_video_decoder.cc

85. Enable conversion warnings

    Changed by	Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 14:30:25 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	bf288e60322293526b3083c831b42d6e548a365d

    Comments

    Enable conversion warnings
    
    Explicitly remove ones that are currently failing
    
    BUG=588506
    
    Change-Id: Ib025843f11366442d81c9fa1b6e2fef2b1f75c55
    Reviewed-on: https://chromium-review.googlesource.com/c/1405439
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623229}

    Changed files

    • third_party/blink/renderer/BUILD.gn

86. Fix thread cache after clone() in CanCreateProcessInNewUserNS

    Changed by	Andrey Malets - maletsohnoyoudont@yandex-team.ru
    Changed at	Wednesday, 16-Jan-19 14:29:40 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	40c2f1577996de8510142d8868a65621baaba1e2

    Comments

    Fix thread cache after clone() in CanCreateProcessInNewUserNS
    
    Since CanCreateProcessInNewUserNS uses base::ForkWithFlags() to create new
    process, which in turn uses raw clone(), no function registered through
    pthread_atfork() gets called in child.
    
    This leads to invalid state when g_thread_id in platform_thread_posix.cc is
    stale and PlatformThread::CurrentId() returns wrong thread id on Linux.
    
    Despite the fact that the child process in CanCreateProcessInNewUserNS has very
    short lifetime, it may use PlatformThread APIs when tracing was enabled at the
    time of the call (this is the case when valid --trace-config-file= argument was
    passed to Chrome at startup).
    
    Also add a DCHECK to ensure we do not treat child crash and normal exit with
    code 1 the same (this would have been very helpful to debug the error
    originally).
    
    Bug: 899897, 902514
    Change-Id: I8e2c82c8030537f5a62b725970d4ea5ec5948659
    Reviewed-on: https://chromium-review.googlesource.com/c/1407830
    Commit-Queue: Robert Sesek <rsesek@chromium.org>
    Reviewed-by: Robert Sesek <rsesek@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623228}

    Changed files

    • base/process/launch_posix.cc
    • base/threading/platform_thread_internal_posix.h
    • base/threading/platform_thread_posix.cc
    • base/threading/scoped_blocking_call.cc
    • sandbox/linux/services/credentials.cc

87. Remove TaskQueueProxy

    Changed by	Carlos Caballero - carlscabohnoyoudont@google.com
    Changed at	Wednesday, 16-Jan-19 14:28:39 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	71484617b8149e9c6f6572006d384aa609bb2b93

    Comments

    Remove TaskQueueProxy
    
    Simplify the code by using an base::internal::OperationsController. This
    will also get rid of of an unnecessary lock.
    
    Bug: 901345
    
    Change-Id: Ie78b3338d9ab6643f30834167a8159f02bd7e5cd
    Reviewed-on: https://chromium-review.googlesource.com/c/1407078
    Commit-Queue: Carlos Caballero <carlscab@google.com>
    Reviewed-by: Alex Clarke <alexclarke@chromium.org>
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623227}

    Changed files

    • base/BUILD.gn
    • base/task/sequence_manager/task_queue.cc
    • base/task/sequence_manager/task_queue_impl.cc
    • base/task/sequence_manager/task_queue_impl.h
    • base/task/sequence_manager/task_queue_proxy.cc
    • base/task/sequence_manager/task_queue_proxy.h
    • base/task/sequence_manager/task_queue_task_runner.cc
    • base/task/sequence_manager/task_queue_task_runner.h

88. Update V8 to version 7.3.413.

    Changed by	v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at	Wednesday, 16-Jan-19 14:24:33 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	85f4cd7f81ea9fe24d70d3de8e6ae13b78c46846

    Comments

    Update V8 to version 7.3.413.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/871f913b..33546539
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: Ia188d1bda479785d4cca1ff114539bcb2e808de8
    Reviewed-on: https://chromium-review.googlesource.com/c/1414871
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#623226}

    Changed files

    • DEPS

89. Roll src/third_party/cros_system_api/ ea44d5db9..5e6881be3 (8 commits)

    Changed by	Lutz Justen - ljustenohnoyoudont@chromium.org
    Changed at	Wednesday, 16-Jan-19 14:21:08 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	2e91fec08b1b687045196f844aff5202360d8e42

    Comments

    Roll src/third_party/cros_system_api/ ea44d5db9..5e6881be3 (8 commits)
    
    https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/ea44d5db9e74..5e6881be3c6b
    
    $ git log ea44d5db9..5e6881be3 --date=short --no-merges --format='%ad %ae %s'
    2019-01-14 ljusten system_api: Add LITE_RUNTIME to install_attributes.proto
    2019-01-09 aoldemeier login: Also set block_devmode=0 in system properties when clearing FRE VPD.
    2019-01-09 ljusten Move install_attributes.proto to system_api
    2019-01-07 zachr system_api: add enable_gpu option to StartVmRequest
    2018-12-12 iby vm_tools: Add unit test for ContainerListenerImpl
    2018-11-16 edmanp arc: Add initial arc-keymasterd
    2019-01-03 ejcaruso system_api: add UnmountRequest proto for cryptohome
    2018-11-16 chirantan system_api: Add StartPluginVm method
    
    Created with:
      roll-dep src/third_party/cros_system_api
    
    Bug:775087
    
    Change-Id: I09140cc9fd841b0d89f2e35bc100507bb0070bdb
    Reviewed-on: https://chromium-review.googlesource.com/c/1412002
    Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
    Commit-Queue: Lutz Justen <ljusten@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#623225}

    Changed files

    • DEPS

90. remove SK_SUPPORT_LEGACY_PAINT_FONT_FIELDS flag

    Changed by	Mike Reed - reedohnoyoudont@google.com
    Changed at	Wednesday, 16-Jan-19 14:18:16 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	2228d5f45a00f4fafaa9c39f44c5d3b98a2149ad

    Comments

    remove SK_SUPPORT_LEGACY_PAINT_FONT_FIELDS flag
    
    Change-Id: Ibd60a76d454648b8389902f400732cca500f9934
    Reviewed-on: https://chromium-review.googlesource.com/c/1414752
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Commit-Queue: Mike Reed <reed@google.com>
    Cr-Commit-Position: refs/heads/master@{#623224}

    Changed files

    • skia/config/SkUserConfig.h