Builder Linux FYI Release (AMD R7 240) Build 2721
Results:
Success
Trigger Info:
Project | chromium |
Revision | 7b9ba30b36ca9361d09404883e086e4fc4f30791 |
Got Revision | 7b9ba30b36ca9361d09404883e086e4fc4f30791 |
Execution:
- Source: Task 42665033b8baca10
- Bot: swarm1080-c4
- Recipe: chromium
Steps and Logfiles:
Show:-
( 223 ms ) report buildersrunning tester 'Linux FYI Release (AMD R7 240)' on master 'chromium.gpu.fyi'
-
- - no logs -
-
( 1 secs ) read test spec (chromium.gpu.fyi.json)path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
-
( 462 ms ) lookup builder GN argsbuild_angle_gles1_conform_tests = truedcheck_always_on = trueffmpeg_branding = "Chrome"internal_gles2_conform_tests = trueis_component_build = falseis_debug = falseproprietary_codecs = truestrip_absolute_paths_from_debug_symbols = truesymbol_level = 1use_goma = truegoma_dir = "/b/swarming/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] angle_white_box_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 1 secs ) angle_white_box_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 8s
-
- - no logs -
-
( 872 ms ) test_pre_run.[trigger] tab_capture_end2end_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 33 secs ) tab_capture_end2end_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 24s
-
- - no logs -
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] gles2_conform_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] swiftshader_unittests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 938 ms ) swiftshader_unittests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 6s
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] context_lost_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 3 mins 16 secs ) context_lost_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:03:12.155804Total tests: 10* Passed: 10 (10 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] depth_capture_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 30 secs ) depth_capture_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 25sTotal tests: 3* Passed: 3 (3 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] gpu_process_launch_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 2 mins 58 secs ) gpu_process_launch_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:02:51.091778Total tests: 15* Passed: 15 (15 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] hardware_accelerated_feature_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 33 secs ) hardware_accelerated_feature_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 22sTotal tests: 2* Passed: 2 (2 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] info_collection_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 23 secs ) info_collection_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 21sTotal tests: 1* Passed: 1 (1 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 37 secs ) maps_pixel_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 32sTotal tests: 1* Passed: 1 (1 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 9 mins 15 secs ) pixel_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:09:07.098081Total tests: 49* Passed: 49 (49 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 998 ms ) test_pre_run.[trigger] screenshot_sync_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 1 mins 22 secs ) screenshot_sync_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:01:11.960846Total tests: 4* Passed: 4 (4 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 4 mins 42 secs ) trace_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:04:34.668186Total tests: 48* Passed: 24 (24 expected, 0 unexpected)* Skipped: 24 (24 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 10 secs ) test_pre_run.[trigger] webgl2_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 2 hrs 6 mins ) webgl2_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Max pending time: 1:59:40.702470 (shard #19)Max shard duration: 0:06:58.965448 (shard #4)Min shard duration: 0:05:29.993213 (shard #7)Total tests: 2803* Passed: 2735 (2735 expected, 0 unexpected)* Skipped: 68 (68 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
- stdout
- json.output
- swarming.summary
- Merge script log
- outdir_json
- step_metadata
- shard #0 isolated out
- shard #0 (368.9 sec)
- shard #1 isolated out
- shard #1 (342.7 sec)
- shard #2 isolated out
- shard #2 (345.0 sec)
- shard #3 isolated out
- shard #3 (357.5 sec)
- shard #4 isolated out
- shard #4 (411.9 sec)
- shard #5 isolated out
- shard #5 (396.4 sec)
- shard #6 isolated out
- shard #6 (395.0 sec)
- shard #7 isolated out
- shard #7 (322.3 sec)
- shard #8 isolated out
- shard #8 (383.5 sec)
- shard #9 isolated out
- shard #9 (354.0 sec)
- shard #10 isolated out
- shard #10 (401.7 sec)
- shard #11 isolated out
- shard #11 (360.5 sec)
- shard #12 isolated out
- shard #12 (391.0 sec)
- shard #13 isolated out
- shard #13 (338.8 sec)
- shard #14 isolated out
- shard #14 (332.0 sec)
- shard #15 isolated out
- shard #15 (381.9 sec)
- shard #16 isolated out
- shard #16 (390.3 sec)
- shard #17 isolated out
- shard #17 (352.7 sec)
- shard #18 isolated out
- shard #18 (405.7 sec)
- shard #19 isolated out
- shard #19 (399.1 sec)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] webgl_conformance_gl_passthrough_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 8 mins 30 secs ) webgl_conformance_gl_passthrough_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Max pending time: 0:02:14.051456 (shard #1)Max shard duration: 0:06:06.115612 (shard #1)Min shard duration: 0:02:05.919627 (shard #0)Total tests: 938* Passed: 932 (932 expected, 0 unexpected)* Skipped: 6 (6 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 2 secs ) test_pre_run.[trigger] webgl_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 9 mins 5 secs ) webgl_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Max pending time: 0:02:16.457198 (shard #1)Max shard duration: 0:06:46.835889 (shard #1)Min shard duration: 0:02:13.248258 (shard #0)Total tests: 938* Passed: 932 (932 expected, 0 unexpected)* Skipped: 6 (6 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm1080-c4" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547488371515209, "id": "8924334549309015712", "project": "chromium", "tags": ["builder:Linux FYI Release (AMD R7 240)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/7b9ba30b36ca9361d09404883e086e4fc4f30791", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Linux Builder", "parent_buildnumber:39087", "scheduler_invocation_id:9089764611361890976", "scheduler_job_id:chromium/Linux FYI Release (AMD R7 240)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "Linux FYI Release (AMD R7 240)" | setup_build |
buildnumber | 2721 | setup_build |
mastername | "chromium.gpu.fyi" | setup_build |
parent_buildername | "GPU FYI Linux Builder" | setup_build |
parent_got_angle_revision | "c759b8b4388b1859b80ab7495074e8e9e7eef756" | setup_build |
parent_got_buildtools_revision | "0e1cbc4eab6861b0c84bf2ed9a3c4b7aa2063819" | setup_build |
parent_got_dawn_revision | "03f64292ad554697026316a55ace9022eff4b3b0" | setup_build |
parent_got_nacl_revision | "1ea07c56ac9b57c30eb784ab2af582af0cdd4b08" | setup_build |
parent_got_revision | "7b9ba30b36ca9361d09404883e086e4fc4f30791" | setup_build |
parent_got_revision_cp | "refs/heads/master@{#622501}" | setup_build |
parent_got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | setup_build |
parent_got_v8_revision | "ee9d016b49b77bffad36590f2be0d1cd97f16950" | setup_build |
parent_got_v8_revision_cp | "refs/heads/7.3.387@{#1}" | setup_build |
parent_got_webrtc_revision | "aaa99a93e288f0354b03b96588d0624ee910d2ed" | setup_build |
parent_got_webrtc_revision_cp | "refs/heads/master@{#26222}" | setup_build |
parent_mastername | "chromium.gpu.fyi" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
revision | "7b9ba30b36ca9361d09404883e086e4fc4f30791" | setup_build |
swarm_hashes | {"angle_end2end_tests": "bd2f59991fda23a701a869a4630ad798cbf92b74", "angle_perftests": "de8aa4d6dc6b99d6bd9da76fd1aa54eed280dd9f", "angle_unittests": "d3d55083341d54af933d576cf3e4097313f28053", "angle_white_box_tests": "eea1b579f1061eea8eb6456e86634b1372226054", "browser_tests": "a020b74d7afd266df34c164897c60113936f48af", "dawn_end2end_tests": "de66e463dead1cf0182cb613d81a0e0c15bda62f", "gl_tests": "506efc7bfa4d3096a834c08f6cda5f7a9ac44b3c", "gl_unittests": "bb80c003ccd2d889abaae8709dfce316ea5b2895", "gles2_conform_test": "af5e57573cd140440bddf95f2198a9840d25ecbe", "swiftshader_unittests": "2f4540d45d6ab54483c06fd7f9be654e49a9c203", "telemetry_gpu_integration_test": "a5ba6936ae78f43ce8046f04f113051dd11575c1"} | setup_build |
got_angle_revision | "c759b8b4388b1859b80ab7495074e8e9e7eef756" | bot_update |
got_buildtools_revision | "0e1cbc4eab6861b0c84bf2ed9a3c4b7aa2063819" | bot_update |
got_dawn_revision | "03f64292ad554697026316a55ace9022eff4b3b0" | bot_update |
got_nacl_revision | "1ea07c56ac9b57c30eb784ab2af582af0cdd4b08" | bot_update |
got_revision | "7b9ba30b36ca9361d09404883e086e4fc4f30791" | bot_update |
got_revision_cp | "refs/heads/master@{#622501}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "ee9d016b49b77bffad36590f2be0d1cd97f16950" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.387@{#1}" | bot_update |
got_webrtc_revision | "aaa99a93e288f0354b03b96588d0624ee910d2ed" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26222}" | bot_update |
swarm_hashes | {} | find isolated tests |
Blamelist:
- Wez (wezohnoyoudont@chromium.org)
- sebsg (sebsgohnoyoudont@chromium.org)
- Sylvain Defresne (sdefresneohnoyoudont@chromium.org)
- James Cook (jamescookohnoyoudont@chromium.org)
- Scott Violet (skyohnoyoudont@chromium.org)
- Dominic Battre (battreohnoyoudont@chromium.org)
- Donn Denman (donndohnoyoudont@chromium.org)
- Boris Sazonov (bsazonovohnoyoudont@chromium.org)
- Mihai Sardarescu (msardaohnoyoudont@chromium.org)
- Morten Stenshorne (mstenshoohnoyoudont@chromium.org)
- Tomas Popela (tomas.popelaohnoyoudont@gmail.com)
- Daniel Bratell (bratellohnoyoudont@opera.com)
- Theresa (twellingtonohnoyoudont@chromium.org)
- Fredrik Söderquist (fsohnoyoudont@opera.com)
- Emily Hanley (eyaichohnoyoudont@google.com)
- Benoît Lizé (lizebohnoyoudont@chromium.org)
- Vladislav Kuzkokov (vkuzkokovohnoyoudont@chromium.org)
- Sadrul Habib Chowdhury (sadrulohnoyoudont@chromium.org)
- Abhijeet Kandalkar (abhijeetohnoyoudont@igalia.com)
- Kush Sinha (sinhakohnoyoudont@chromium.org)
- Keiichi Watanabe (keiichiwohnoyoudont@chromium.org)
- Xida Chen (xidachenohnoyoudont@chromium.org)
- Maksim Sisov (msisovohnoyoudont@igalia.com)
- Sam Maier (smaierohnoyoudont@chromium.org)
- chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
- manuk (manukhohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Dominic Battre (battreohnoyoudont@chromium.org)
- Dominic Battre (battreohnoyoudont@chromium.org)
- Ehsan Chiniforooshan (chiniforooshanohnoyoudont@chromium.org)
- Colin Blundell (blundellohnoyoudont@chromium.org)
- Gabriel Charette (gabohnoyoudont@chromium.org)
- Tim Volodine (timvolodineohnoyoudont@chromium.org)
- Philip Rogers (pdrohnoyoudont@chromium.org)
- Michael Lippautz (mlippautzohnoyoudont@chromium.org)
- agrieve (agrieveohnoyoudont@chromium.org)
- Dominic Battre (battreohnoyoudont@chromium.org)
- Dominic Battre (battreohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Marina Ciocea (marinacioceaohnoyoudont@chromium.org)
- v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
- chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
- Nick Diego Yamane (nickdiegoohnoyoudont@igalia.com)
- Christian Dullweber (dullweberohnoyoudont@chromium.org)
- Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
- Dominik Röttsches (drottohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
- Henrique Ferreiro (hferreiroohnoyoudont@igalia.com)
Timing:
Create | Monday, 14-Jan-19 17:52:51 UTC |
Start | Monday, 14-Jan-19 17:52:55 UTC |
End | Monday, 14-Jan-19 20:44:06 UTC |
Pending | 4 secs |
Execution | 2 hrs 51 mins |
All Changes:
-
Fix BlinkFuzzerTestSuppport to initialize TestTimeouts.
Changed by Wez - wezohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 17:40:38 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7b9ba30b36ca9361d09404883e086e4fc4f30791 Comments
Fix BlinkFuzzerTestSuppport to initialize TestTimeouts. Bug: 921137 Change-Id: I8144574710cd02c42750be347838b9305b31bd72 Reviewed-on: https://chromium-review.googlesource.com/c/1407256 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#622501}
Changed files
- third_party/blink/renderer/platform/testing/blink_fuzzer_test_support.cc
-
Fix Autofill Incognito Downstream/Remask Bug
Changed by sebsg - sebsgohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 17:39:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1decf8031c5c029db88fc350da3353e2f0b7e78e Comments
Fix Autofill Incognito Downstream/Remask Bug In Incognito, the SyncService passed to the Autofill Manager is null. By sending this to the PDM via OnSyncServiceInitialized, it creates so bugs: All the unmasked cards gets remasked (When the PDM gets a null Sync Service) Downstream won't work reliably. Basically, if the last page was loaded in incognito it won't work anywhere (including non-incognito) and if it was loaded not in incognito, it will work everywhere. This fixes the bug by only calling OnSyncServiceInitialized when not in incognito. Bug: 916596 Change-Id: Ie93906953387ebc9807abb0c21aee99861d694ea Reviewed-on: https://chromium-review.googlesource.com/c/1404752 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#622500}
Changed files
- components/autofill/core/browser/autofill_manager.cc
- components/autofill/core/browser/autofill_manager_unittest.cc
- components/autofill/core/browser/test_personal_data_manager.cc
- components/autofill/core/browser/test_personal_data_manager.h
-
Remove unnecessary AccountTrackerService::GetAccountImage
Changed by Sylvain Defresne - sdefresneohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 17:39:29 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3e3c634b7774c99cd6d4375e096a6dfe57a68af5 Comments
Remove unnecessary AccountTrackerService::GetAccountImage As the AccountInfo already stores the account image, remove the now unnecessary GetAccountImage and convert client code to get the image from AccountInfo's account_image field. Remove now unnecessary array of image from DiceAccountsMenu. Bug: 914783 Change-Id: I690d7f5f9be2c9d143ecfabf1355070329139122 Reviewed-on: https://chromium-review.googlesource.com/c/1402759 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Thomas Tangl <tangltom@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#622499}
Changed files
- chrome/browser/ui/views/profiles/avatar_toolbar_button.cc
- chrome/browser/ui/views/profiles/dice_accounts_menu.cc
- chrome/browser/ui/views/profiles/dice_accounts_menu.h
- chrome/browser/ui/views/profiles/profile_chooser_view.cc
- chrome/browser/ui/views/sync/dice_bubble_sync_promo_view.cc
- chrome/browser/ui/views/sync/dice_bubble_sync_promo_view.h
- chrome/browser/ui/webui/settings/chromeos/account_manager_handler.cc
- chrome/browser/ui/webui/settings/people_handler.cc
- chrome/browser/ui/webui/settings/people_handler.h
- chrome/browser/ui/webui/settings/people_handler_unittest.cc
- components/signin/core/browser/account_tracker_service.cc
- components/signin/core/browser/account_tracker_service.h
- components/signin/core/browser/account_tracker_service_unittest.cc
-
Fix clusterfuzz crash exiting overview mode with 2 escape key presses
Changed by James Cook - jamescookohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 17:37:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 431a0293d59fc23e464428ba5f837c7e31855ca1 Comments
Fix clusterfuzz crash exiting overview mode with 2 escape key presses The clusterfuzz sequence presses F5 (which enters overview mode), types some garbage (which brings up the text filter), then does a key press sequence that includes 2 escape presses. I think WindowSelectorController::OnSelectionEnded() is called twice. The second time the |window_selector_| is null, so there's a null pointer reference on window_selector_->UpdateMaskAndShadow(). I can't reproduce this locally, either manually or with the clusterfuzz test case. However, I wrote a test that reproduces the clusterfuzz call stack. Bug: 920568, 912623 Test: ash_unittests Change-Id: I2dae1e5fca56f9c34d37a3c605fd231e27d95763 Reviewed-on: https://chromium-review.googlesource.com/c/1405283 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#622498}
Changed files
- ash/wm/overview/window_selector_controller.cc
- ash/wm/overview/window_selector_unittest.cc
-
chromeos: change WindowTreeHostMus accelerated widget ids
Changed by Scott Violet - skyohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 17:37:35 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2d782d1ac05c868d42b075964f2c66757f5c8c8d Comments
chromeos: change WindowTreeHostMus accelerated widget ids This patch converts the ids to start at the max and decrease. This is necessary such that the ids don't conflict with those used by Ozone in SingleProcessMash. This is all too fragile, and I would rather see us remove WindowTreeHost::GetForAcceleratedWidget(), but that's harder. BUG=920788 TEST=none Change-Id: Id4b69a9438b6bcb2c4ee5dcb4c41bbd00d9a77e4 Reviewed-on: https://chromium-review.googlesource.com/c/1407694 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#622497}
Changed files
- ui/aura/mus/mus_context_factory.cc
- ui/aura/mus/window_tree_host_mus.cc
-
Disable http/tests/security/mixedContent/insecure-iframe-with-hsts.https.html
Changed by Dominic Battre - battreohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 17:34:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 56126823ba553ebe0dc4eef005bdeb0705051750 Comments
Disable http/tests/security/mixedContent/insecure-iframe-with-hsts.https.html This CL disables a number of variations of the above mentioned test on Linux. Details on the failure can be found on the bug. TBR=mkwst@chromium.org Bug: 921151 Change-Id: Ic64404b128fa5f40042d0d81ac33f4a3e585b6d3 Reviewed-on: https://chromium-review.googlesource.com/c/1409549 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#622496}
Changed files
- third_party/blink/web_tests/TestExpectations
-
[Navigation] Expire histogram for redirect chain.
Changed by Donn Denman - donndohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 17:31:51 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e4274c5d4d433327ceadc308bb95dfc6922576a8 Comments
[Navigation] Expire histogram for redirect chain. Obsoletes the unused Chrome histogram Navigation.RedirectChainSize, and removes the code that was logging it. The old histogram data should still be available for historic reference, which should serve the purposes for which this was added. BUG=918400 Change-Id: I4034ab3441b70112b1ddcceca9bc2aa2289e0d9e Reviewed-on: https://chromium-review.googlesource.com/c/1403418 Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#622495}
Changed files
- content/browser/frame_host/navigation_controller_impl.cc
- tools/metrics/histograms/histograms.xml
-
[Unity][Android] Use PreferenceCategory in SyncAndServicesPreferences
Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 17:31:48 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7cd7a78b5c648011bdc758c7c34464131357ab3a Comments
[Unity][Android] Use PreferenceCategory in SyncAndServicesPreferences This CL replaces SigninExpandablePreferenceGroup with PreferenceCategory in SyncAndServicesPreferences. SigninExpandablePreferenceGroup is removed. Also, use_sync_and_all_services and sync_error_card preference rows are moved to Sync category. This CL also removes from SyncAndServicesPreferences the code that disabled default dividers between preference entries and removes explicit dividers from the corresponding XML file. Bug: 914056 Change-Id: Id567da329229584792f91f48382e6cf60bca318e Reviewed-on: https://chromium-review.googlesource.com/c/1409282 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#622494}
Changed files
- chrome/android/java/chrome_modern_public_apk.proguard_flags.expected
- chrome/android/java/chrome_public_apk.proguard_flags.expected
- chrome/android/java/monochrome_public_apk.proguard_flags.expected
- chrome/android/java/res/xml/sync_and_services_preferences.xml
- chrome/android/java/src/org/chromium/chrome/browser/preferences/SigninExpandablePreferenceGroup.java
- chrome/android/java/src/org/chromium/chrome/browser/preferences/SyncAndServicesPreferences.java
- chrome/android/java/strings/android_chrome_strings.grd
- chrome/android/java_sources.gni
-
Fire error changed notification only when auth error changes.
Changed by Mihai Sardarescu - msardaohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 17:30:12 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4471bd4f7ed22af267d6dd81813d5d016274ff55 Comments
Fire error changed notification only when auth error changes. This CL avoids sending an error changed notification if the auth error state does not change. Bug: None Change-Id: I298a099f42de6cfb2730e3f1333fca58f4450ca7 Reviewed-on: https://chromium-review.googlesource.com/c/1408971 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#622493}
Changed files
- components/signin/core/browser/signin_error_controller.cc
-
Mark top estimate for bottom-aligned OOFs as bogus when fragmented.
Changed by Morten Stenshorne - mstenshoohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 17:26:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c9815df2e17e7cc61e622a402ec4c7af6d1367c2 Comments
Mark top estimate for bottom-aligned OOFs as bogus when fragmented. As the code already points out, the block-start estimate for block-end aligned out-of-flow positioned objects cannot be determined without laying out. Make sure that we really lay out. Bug: 921546 Change-Id: Id49b7b846886070ce3e49e0220a7b6378e1f9d6a Reviewed-on: https://chromium-review.googlesource.com/c/1409442 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#622492}
Changed files
- third_party/blink/renderer/core/layout/layout_block.cc
- third_party/blink/web_tests/external/wpt/css/css-break/block-end-aligned-abspos-nested.html
-
Reland "Add about flag for enabling the PipeWire support in WebRTC"
Changed by Tomas Popela - tomas.popelaohnoyoudont@gmail.com Changed at Monday, 14-Jan-19 17:22:10 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 253a583b6b687c3484a1568c319f05aaa8274938 Comments
Reland "Add about flag for enabling the PipeWire support in WebRTC" This is a reland of 8788015d2b2efa354c641f4e0ed38fba726f3ae7 Unit tests are fixed in the reland. Original change's description: > Add about flag for enabling the PipeWire support in WebRTC > > Add a new enable-webrtc-pipewire-capturer about flag, that when > enabled, will allow to use the PipeWire media server for providing > the screen content for screen casting when user is running on Wayland > display server on Linux. > > The flag is disabled by default, due to the user experience as it > involves two extra confirmation dialogs outside of Chromium - requested > by Weiyong Yao. It could change the default, once it goes through Chromium > UI review. > > Bug: 682122 > Reviewed-on: https://chromium-review.googlesource.com/c/1365444 > Reviewed-by: Weiyong Yao <braveyao@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> > Cr-Commit-Position: refs/heads/master@{#615886} Bug: 682122 Change-Id: Ie5d0bf4945f621121c14e95a4addad3afac5bec1 Reviewed-on: https://chromium-review.googlesource.com/c/1402441 Reviewed-by: Weiyong Yao <braveyao@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Cr-Commit-Position: refs/heads/master@{#622491}
Changed files
- chrome/browser/BUILD.gn
- chrome/browser/about_flags.cc
- chrome/browser/flag-metadata.json
- chrome/browser/flag_descriptions.cc
- chrome/browser/flag_descriptions.h
- content/public/browser/BUILD.gn
- content/public/browser/desktop_capture.cc
- content/public/common/BUILD.gn
- content/public/common/content_features.cc
- content/public/common/content_features.h
- tools/metrics/histograms/enums.xml
-
Get chromium's major version directly instead of parsing strings
Changed by Daniel Bratell - bratellohnoyoudont@opera.com Changed at Monday, 14-Jan-19 17:22:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision df852a77436e9dee4613433143533d2ca348851a Comments
Get chromium's major version directly instead of parsing strings Getting Chromium's version is not trivial in code and some code got the version string dynamically during runtime and parsed it. Since several files defined the same helper function GetCurrentMajorVersion, those clashed in some extreme jumbo builds. This drops this function and instead gets the version directly from the version system via a C/C++ define. Since the version number now will be compiled into autofill, it will have to recompile if the major version number changes. Bug: 907570 Change-Id: I5823d977f3ff58c4b19f173c01031d4a9aa5c56c Reviewed-on: https://chromium-review.googlesource.com/c/1409548 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#622490}
Changed files
- components/autofill/core/browser/BUILD.gn
- components/autofill/core/browser/autocomplete_history_manager.cc
- components/autofill/core/browser/autocomplete_history_manager_unittest.cc
- components/autofill/core/browser/personal_data_manager.cc
- components/autofill/core/browser/personal_data_manager_unittest.cc
-
Apply FontPreloadingWorkaround to ChromeApplication
Changed by Theresa - twellingtonohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 17:19:08 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 14be14a131d6202cea486264d43c8255f68d60e3 Comments
Apply FontPreloadingWorkaround to ChromeApplication Move the FontPreloadingWorkaround from WebViewApplication to ChromeApplication. Used to workaround an Android bug where preloaded fonts are attempted to be loaded in an isolated process. BUG=920692 Change-Id: Ib1e646f94011e935ba4ec9e3b55c708767a14a63 Reviewed-on: https://chromium-review.googlesource.com/c/1407120 Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#622489}
Changed files
- android_webview/glue/BUILD.gn
- android_webview/glue/glue.gni
- android_webview/glue/java/DEPS
- android_webview/glue/java/src/com/android/webview/chromium/WebViewApplication.java
- chrome/android/BUILD.gn
- chrome/android/java/DEPS
- chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
- chrome/android/java/src/org/chromium/chrome/browser/MonochromeApplication.java
- components/embedder_support/android/BUILD.gn
- components/embedder_support/android/java/src/org/chromium/components/embedder_support/application/FontPreloadingWorkaround.java
-
Reduce the size of execution_context.h
Changed by Fredrik Söderquist - fsohnoyoudont@opera.com Changed at Monday, 14-Jan-19 17:12:36 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2b32f46e421683240c8cede7069940cc909c2145 Comments
Reduce the size of execution_context.h execution_context.h is used in 4400+ compilation units. This reduces its pre-processed size by ~1.1M. The referrer_policy.mojom-shared.h include was added by https://crrev.com/611587. Bug: 242216, 860403 Change-Id: I5cdcbf17f05a6b121672f7fa9263f098a6450ee5 Reviewed-on: https://chromium-review.googlesource.com/c/1408970 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#622488}
Changed files
- third_party/blink/renderer/core/execution_context/execution_context.h
-
Adding navigationId to the user timing events.
Changed by Emily Hanley - eyaichohnoyoudont@google.com Changed at Monday, 14-Jan-19 17:11:23 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 161ea1266c42693334a27e47a6291936c67f01ce Comments
Adding navigationId to the user timing events. This was needed in https://chromium-review.googlesource.com/c/catapult/+/1379733 to correlate the right amp pc mark with its navigation event. Bug: 904879 Change-Id: I8b643619c56f55b7104c23554a00061c3cfd5712 Reviewed-on: https://chromium-review.googlesource.com/c/1401271 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#622487}
Changed files
- base/trace_event/common/trace_event_common.h
- third_party/blink/renderer/core/timing/performance_timing.cc
- third_party/blink/renderer/core/timing/performance_timing.h
- third_party/blink/renderer/core/timing/performance_user_timing.cc
-
cygprofile: Add support for ThinLTO in extract_symbols.py.
Changed by Benoît Lizé - lizebohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 17:08:08 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8c656bb971d5f30a98c48767617b0c2620036d79 Comments
cygprofile: Add support for ThinLTO in extract_symbols.py. Now that ThinLTO is used, object files no longer contain executable code, only LLVM bitcode. As a consequence, it is no longer possible to visualize the code -> object file mapping. extract_symbols.py can be used to overlay the native library code range with the provenance of its code. It generates a HTML visualization of the native library layout, and is used to investigate and assess code ordering. To get it back, use llvm-nm instead of objdump to get the list of symbols. This requires a change to clang scripts, as llvm-nm isn't built with clang yet. Also fixes a few lint warnings. Bug: 758566 Change-Id: I860e2a44132eb05b369c8c8a27a26776267611e2 Reviewed-on: https://chromium-review.googlesource.com/c/1409502 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#622486}
Changed files
- tools/android/native_lib_memory/extract_symbols.py
- tools/cygprofile/symbol_extractor.py
- tools/cygprofile/symbol_extractor_unittest.py
-
Make PrefValueMap use std::map.
Changed by Vladislav Kuzkokov - vkuzkokovohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 17:02:53 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 284640e6da9f43c17ac531cee455f45ed19b5c7e Comments
Make PrefValueMap use std::map. std: :unordered_map is currently discouraged. Change-Id: I926a28eee3b7a57cf2a86193ef456daad99d970d Reviewed-on: https://chromium-review.googlesource.com/c/1382912 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#622485}
Changed files
- components/prefs/pref_value_map.h
-
<webview>: Do not request begin-frames from platform view.
Changed by Sadrul Habib Chowdhury - sadrulohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 17:02:29 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7919db2ce52b20821d7a75f6e1eda18b38049312 Comments
<webview>: Do not request begin-frames from platform view. For <webview> (without OOP-D), begin-frames are pumped to the renderer from two sources: RenderWidgetHostViewChildFrame, and DelegatedFrameHost (since a RenderWidgetHostViewGuest is-a RenderWidgetHostViewChildFrame, but is also backed by a RenderWidgetHostViewAura etc. More details in crbug.com/330264). This is because the 'platform view' (i.e. the platform impl like RenderWidgetHostViewAura) also requests begin-frames, which shouldn't be necessary. So this change removes that. BUG=919562, 330264 Change-Id: Ib7ad078079ce65a2dd23b7f03ce570f11e877d69 Reviewed-on: https://chromium-review.googlesource.com/c/1406143 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#622484}
Changed files
- content/browser/frame_host/render_widget_host_view_guest.cc
- content/browser/frame_host/render_widget_host_view_guest.h
-
Port profile_window.cc to IdentityManager from SigninManager
Changed by Abhijeet Kandalkar - abhijeetohnoyoudont@igalia.com Changed at Monday, 14-Jan-19 16:58:18 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision cec86c95757689dd7bec903574bbcf4a347524aa Comments
Port profile_window.cc to IdentityManager from SigninManager This CL switches profile_window away from using SigninManagerFactory in favor of talking to IdentityManagerFactory. Bug: 920217 Change-Id: I7b1a01ff97f15f2adc8d8599373922d97b861e2f Reviewed-on: https://chromium-review.googlesource.com/c/1407308 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#622483}
Changed files
- chrome/browser/profiles/profile_window.cc
-
Fix: crOS Device Account online auth for Secondary Account errors
Changed by Kush Sinha - sinhakohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 16:57:55 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a952353c3720b9cbe100fb6a5b1b1d791e0c5b59 Comments
Fix: crOS Device Account online auth for Secondary Account errors With Chrome OS Account Manager enabled, if any Secondary Account requires a re-authentication, it forces the Device Account to require an online Gaia sign-in at the Chrome OS sign-in screen. |UserSessionManager| uses |SigninErrorController::HasError()| to check if the Device Account has a valid token or not. Since Chrome OS didn't have a concept of Secondary Accounts before, any error in |SigninErrorController| corresponded to an error in the Device Account. This assumption in no longer true. |SignErrorController::HasError()| can return |true| for Secondary Accounts too, and that should not invalidate the Device Account token. Fix this by using Identity Service APIs to check for Device Account's error state. Bug: 820046 Change-Id: I381e29a38dc284d0e7d27ab942c468ed3d88bf98 Reviewed-on: https://chromium-review.googlesource.com/c/1408449 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#622482}
Changed files
- chrome/browser/chromeos/login/session/user_session_manager.cc
- components/signin/core/browser/signin_error_controller.h
- components/user_manager/user_manager_base.cc
-
[Video Capture, Test] Skip MJPEG tests on ChromeOS devices using HALv3
Changed by Keiichi Watanabe - keiichiwohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 16:56:26 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 669fedf5eccf89245da0bc49e25ae6e7d5dac2f5 Comments
[Video Capture, Test] Skip MJPEG tests on ChromeOS devices using HALv3 On Chrome OS devieces where HAL v3 camera service are used, VideoCaptureDevice class doesn't handle MJPEG data. This is because MJPEG data from a camera are decoded to YUV by the HAL before coming to Chrome. So, UsingRealWebcam_CaptureMjpeg tests should be skipped on such devices. Bug: 893501 Test: run capture_unittests on eve Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org> Change-Id: I55814b1c8368511ee1c1e0c84e1ba6bb1760961f Reviewed-on: https://chromium-review.googlesource.com/c/1404904 Reviewed-by: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#622481}
Changed files
- media/capture/BUILD.gn
- media/capture/video/video_capture_device_unittest.cc
-
[Debugging] Add DumpWithoutCrash in more cases
Changed by Xida Chen - xidachenohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 16:54:24 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision edabab55d7f4c7705e708723c39780458a5adc4d Comments
[Debugging] Add DumpWithoutCrash in more cases In this previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1405289, we added DumpWithoutCrash in GestureScrollBegin. It was in canary for 2 versions and there are only 2 reports. This CL adds DumpWithoutCrash in all the cases where it could crash: GestureScrollBegin, GestureScrollUpdate, GestureTapUnconfirmed and hope that we can gather more info. Bug: 904648 Change-Id: Iabaf43e4fb5375801ddef4fda8968f47d0c6cc00 Reviewed-on: https://chromium-review.googlesource.com/c/1409402 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#622480}
Changed files
- content/browser/renderer_host/input/touch_action_filter.cc
-
[ozone/wayland]: Switch to wl_output version 2.
Changed by Maksim Sisov - msisovohnoyoudont@igalia.com Changed at Monday, 14-Jan-19 16:49:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 985ec97fc79f3581c524e51f48af9b7565f33e08 Comments
[ozone/wayland]: Switch to wl_output version 2. wl_output version 2 has some benefits over the previous version we used to bind to: support of scale values (in version 1, it always sends value 1), OutputDone events, which notifies that changes WaylandOutput through that OutputHandleGeometry, or OutputHandleMode, or OutputHandleScale has been sent and it's time to notify WaylandOutput clients about the changes. Change-Id: I0ccf83357e755a29c30531bd6b7d2a3e13acfd3c Bug: 875161 Reviewed-on: https://chromium-review.googlesource.com/c/1408974 Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#622479}
Changed files
- ui/ozone/platform/wayland/wayland_connection.cc
- ui/ozone/platform/wayland/wayland_output.cc
- ui/ozone/platform/wayland/wayland_output_manager.cc
- ui/ozone/platform/wayland/wayland_screen_unittest.cc
-
Continue running previously queued pre-native tasks after destroy.
Changed by Sam Maier - smaierohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 16:44:03 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 32759988fe1cace3734f15f27f486b4b7c54450a Comments
Continue running previously queued pre-native tasks after destroy. Java tasks that are already in the TaskRunner will now be finished after destroy is called. However, no new tasks will be allowed after destroy. Bug: 149440 Change-Id: I70b6f4c1aaeda1577b1cf06cc5f786aa7e037d4e Reviewed-on: https://chromium-review.googlesource.com/c/1407376 Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#622478}
Changed files
- base/android/java/src/org/chromium/base/task/TaskRunnerImpl.java
-
Roll src-internal 8bd3326cb1d6..fdb2d10b912c (4 commits)
Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com Changed at Monday, 14-Jan-19 16:43:32 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision bea79325971ba0fe09fcfe0881fece92fd57d3a9 Comments
Roll src-internal 8bd3326cb1d6..fdb2d10b912c (4 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8bd3326cb1d6..fdb2d10b912c Created with: gclient setdep -r src-internal@fdb2d10b912c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I966954fc55b5008ac92545cc85a835f91fe591e9 Reviewed-on: https://chromium-review.googlesource.com/c/1409583 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622477}
Changed files
- DEPS
-
[omnibox chrome:omnibox] Connect the browser's omnibox, CL 1 of 2
Changed by manuk - manukhohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 16:42:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision fc6de262fa45f445a3d62ce94d609cdd0d62b459 Comments
[omnibox chrome:omnibox] Connect the browser's omnibox, CL 1 of 2 Interacting with the real omnibox of any normal or incognito browser window while the debug page is open will update the debug page's output. This is the 1st of 2 related CL's. This CL wires in the browser omnibox, whereas the 2nd will add a UI input to disable this feature. Bug: 891303 Change-Id: I64d72ed01710d4eb472373527f7ade61c19b0fda Reviewed-on: https://chromium-review.googlesource.com/c/1399450 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#622476}
Changed files
- chrome/browser/resources/omnibox/omnibox.js
- chrome/browser/ui/omnibox/chrome_omnibox_client.cc
- chrome/browser/ui/omnibox/chrome_omnibox_client.h
- chrome/browser/ui/webui/omnibox/omnibox.mojom
- chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc
- chrome/browser/ui/webui/omnibox/omnibox_page_handler.h
- components/omnibox/browser/BUILD.gn
- components/omnibox/browser/DEPS
- components/omnibox/browser/omnibox_client.cc
- components/omnibox/browser/omnibox_client.h
- components/omnibox/browser/omnibox_controller.cc
- components/omnibox/browser/omnibox_controller_emitter.cc
- components/omnibox/browser/omnibox_controller_emitter.h
-
Roll src/third_party/skia da068c0d1d7c..ec4903d5156e (2 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Monday, 14-Jan-19 16:42:11 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 26f13b71a4d96d52ccfd5b0493d772c35117d8ea Comments
Roll src/third_party/skia da068c0d1d7c..ec4903d5156e (2 commits) https://skia.googlesource.com/skia.git/+log/da068c0d1d7c..ec4903d5156e git log da068c0d1d7c..ec4903d5156e --date=short --no-merges --format='%ad %ae %s' 2019-01-14 kjlubick@google.com [canvaskit] Use textblob 2019-01-14 nigeltao@google.com Have SkWuffsCodec get workbuf_len from decoder Created with: gclient setdep -r src/third_party/skia@ec4903d5156e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: I331e18157a567396b0d1eab6095096ba173be580 Reviewed-on: https://chromium-review.googlesource.com/c/1409582 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622475}
Changed files
- DEPS
-
Record UKM for PasswordManager.FirstFillingResult
Changed by Dominic Battre - battreohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 16:41:47 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a35313b247cab15d31ccb4339be16591c5f9e79b Comments
Record UKM for PasswordManager.FirstFillingResult This implements a UKM for the UMA metric PasswordManager.FirstFillingResult to discover locations from which we receive unexpected results. Bug: 918846 Change-Id: I77c32e64a173be6f6ee557874db7f931e02547f2 Reviewed-on: https://chromium-review.googlesource.com/c/1402892 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#622474}
Changed files
- chrome/browser/password_manager/chrome_password_manager_client.cc
- chrome/browser/password_manager/chrome_password_manager_client.h
- chrome/renderer/autofill/fake_mojo_password_manager_driver.h
- components/autofill/content/common/autofill_driver.mojom
- components/autofill/content/renderer/password_autofill_agent.cc
- components/autofill/content/renderer/password_autofill_agent.h
- components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc
- components/password_manager/core/browser/new_password_form_manager.cc
- components/password_manager/core/browser/new_password_form_manager.h
- components/password_manager/core/browser/password_form_metrics_recorder.cc
- components/password_manager/core/browser/password_form_metrics_recorder.h
- components/password_manager/core/browser/password_manager.cc
- components/password_manager/core/browser/password_manager.h
- tools/metrics/histograms/histograms.xml
- tools/metrics/ukm/ukm.xml
-
Disable PDFExtensionTest.Elements and .ToolbarManager
Changed by Dominic Battre - battreohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 16:41:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5a36d4270ea3dd774c7164f49909cac9adc4f270 Comments
Disable PDFExtensionTest.Elements and .ToolbarManager See bug for details. TBR=yiyix@chromium.org,thestig@chromium.org Bug: 915555 Change-Id: I39ba46a6c72cfcd35bd73ac082d56795a69976f0 Reviewed-on: https://chromium-review.googlesource.com/c/1409547 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#622473}
Changed files
- chrome/browser/pdf/pdf_extension_test.cc
-
Update documentation for the rendering benchmark
Changed by Ehsan Chiniforooshan - chiniforooshanohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 16:27:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b304b1b107b18675673470e1e397ed21df5c3405 Comments
Update documentation for the rendering benchmark Change-Id: I71af78f57da923d5dbd3ff840c24239867388277 Reviewed-on: https://chromium-review.googlesource.com/c/1409604 Reviewed-by: Annie Sullivan <sullivan@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#622472}
Changed files
- docs/speed/benchmark/harnesses/rendering.md
-
Move AccountFetcherService and dependencies into signin_internals
Changed by Colin Blundell - blundellohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 16:24:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8442b70f28ef7a2039b0e6c19078cdd821aaced1 Comments
Move AccountFetcherService and dependencies into signin_internals As we resolved on https://bugs.chromium.org/p/chromium/issues/detail?id=911675, AccountFetcherService and AccountTrackerService are conceptually a single entity. Since AccountTrackerService is targeted for being inside IdentityManager, AccountFetcherService should be as well. This CL moves AccountFetcherService into the signin_internals GN target, and additionally moves necessary dependencies to make "GN check" happy. Note that we move avatar_icon_util.* into the shared target, as this file holds a utility function that just manipulates an avatar icon URL. That functionality is (at least at this time) fine to be shared between clients and IdentityManager internals. A followup CL will do a similar move for FakeAccountInfoFetcher. Bug: 915149 Change-Id: I8bfe4c7eebb1c320164521fd9580f481b5bd14fe Reviewed-on: https://chromium-review.googlesource.com/c/1408910 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#622471}
Changed files
- components/signin/core/browser/BUILD.gn
-
[ui_controls] Unflake Send*NotifyWhenDone() on Windows
Changed by Gabriel Charette - gabohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 16:16:49 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ec52747a5abc25a862843edca761104b3c319764 Comments
[ui_controls] Unflake Send*NotifyWhenDone() on Windows ui_controls::Send*NotifyWhenDone() can be flaky when invoked after ui_controls::Send*() as the former can decide to notify based on observing a yet-to-be-processed event from the latter (or even a yet-to-be-processed event emitted by unrelated code) and thus notify too early, resuming and testing conditions that have yet to be met. Solution: defer the notification if the system queue has pending events of the same type awaiting dispatch. Note: mouse move can be repeated indefinitely during a drag, as such we consider a mouse move complete when it hits the target regardless of remaining mouse move messages in the queue. @ BUG OWNERS : This might unflake many currently disabled tests. I've CC'ed interactive_ui_tests + Windows bugs, please try to re-enable your test after this CL if you think it might be related. Bug: 892228, 640996, 897801,893078,876224,875443,873110,852786,850343,848049,846695,840369,798492,756338,751031,665296,651906,499858,468660,419468,238347,131612,106489,97777,92467 Change-Id: I548856a3948ff71a145435799b4ba3e689561f14 Reviewed-on: https://chromium-review.googlesource.com/c/1392178 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#622470}
Changed files
- chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc
- ui/base/test/ui_controls_internal_win.cc
-
[AW NS] Re-enable AndroidStreamReaderURLLoaderTest tests
Changed by Tim Volodine - timvolodineohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 16:15:26 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b0041cfd59313062e36ca8cb7334325abd8507a2 Comments
[AW NS] Re-enable AndroidStreamReaderURLLoaderTest tests Re-enable: ValidRangeRequest and ReadFakeStream tests. BUG=919929 TBR=jam@chromium.org,tobiasjs@chromium.org Change-Id: Ia5ac10f44ac85ccb52e5c95d052894fd39f1cb8e Reviewed-on: https://chromium-review.googlesource.com/c/1407197 Reviewed-by: Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#622469}
Changed files
- android_webview/browser/net_network_service/android_stream_reader_url_loader_unittest.cc
-
Touch action hit test display items should count as drawable content
Changed by Philip Rogers - pdrohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 16:14:56 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1289c6b4d058c790f2d69a2f307e603e18e5cca0 Comments
Touch action hit test display items should count as drawable content This patch updates PaintLayer::HasBoxDecorationsOrBackground to return true if touch-action rects are painted in the background. This ensures GraphicsLayer::DrawsContent is true if touch-action rects paint so that the GraphicsLayer is included when ScrollingCoordinator collects touch action rects in UpdateLayerTouchActionRects. This fixes a bug where an embeded object's touch action rects were skipped. A unit test has been added and this also passes the pdf extension unit test in: https://chromium-review.googlesource.com/c/chromium/src/+/1407488/1 Bug: 919286 Change-Id: I74f58722509dfb826f3e0ca7701f58cb35194fd0 Reviewed-on: https://chromium-review.googlesource.com/c/1408215 Reviewed-by: Xianda Sun <sunxd@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#622468}
Changed files
- third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
- third_party/blink/renderer/core/paint/paint_layer.cc
- third_party/blink/renderer/core/paint/paint_layer.h
-
heap: Fix tracing of merged mixins
Changed by Michael Lippautz - mlippautzohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 16:13:55 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 13be282fc45460eff28c587e9d166f6afd984f60 Comments
heap: Fix tracing of merged mixins The GC now can hit a merge mixin during construction in which case the GetTraceDescriptor method needsto return the same in construction markers as a regular GarbageCollectedMixin. Bug: 921439 Change-Id: I8c228a9a4c902a1cff3fdd474e7eb740740ebc0a Reviewed-on: https://chromium-review.googlesource.com/c/1409543 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#622467}
Changed files
- third_party/blink/renderer/platform/heap/garbage_collected.h
-
apk_size_regressions.md: Tweaks to bug template.
Changed by agrieve - agrieveohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 16:13:53 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 45afbf600d8bde45e72dcfb1d9e914a59b3f104f Comments
apk_size_regressions.md: Tweaks to bug template. 1 week of effort == 50kb (probably more realistic as of now) Change-Id: I08cb22d868242588edf30d6f261d1145746cfc86 Reviewed-on: https://chromium-review.googlesource.com/c/1408653 Reviewed-by: Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#622466}
Changed files
- docs/speed/apk_size_regressions.md
-
Fix Scoped{List,Dictionary}Updates for non-empty defaut values
Changed by Dominic Battre - battreohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 15:48:13 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 904348e9fd097685b80273f1149c17035533eac4 Comments
Fix Scoped{List,Dictionary}Updates for non-empty defaut values If a PrefService has a registered preference whose default value is a non-empty dictionary or list, then the Scoped*Update functions failed to clone those dictionaries. This is fixed by this CL. Bug: 921542 Change-Id: Ifad622d6345dd6797fa97ac6c2f917eb3928cb98 Reviewed-on: https://chromium-review.googlesource.com/c/1408969 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#622465}
Changed files
- components/prefs/pref_service.cc
- components/prefs/scoped_user_pref_update_unittest.cc
-
Disable flaky DevToolsSanityTest.CreateBrowserContext
Changed by Dominic Battre - battreohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 15:47:33 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3b2c9ab947aa49a2296223efacf0f70af3a99a0f Comments
Disable flaky DevToolsSanityTest.CreateBrowserContext The test fails due to a refcounted destruction on the wrong thread. See bug for details. TBR=dgozman@chromium.org Bug: 921608 Change-Id: I3906909a3d89c7baa5475a217618666954b1b49f Reviewed-on: https://chromium-review.googlesource.com/c/1409542 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#622464}
Changed files
- chrome/browser/devtools/devtools_sanity_browsertest.cc
-
Roll Fuchsia SDK from 54c0375b8b29 to a82b99671732
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Monday, 14-Jan-19 15:37:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3be74ce4d167e08e662f5f803c17e399de9cc8cd Comments
Roll Fuchsia SDK from 54c0375b8b29 to a82b99671732 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I20d68ade93e1a0d2c4cf1f9324344223e7ee1233 Reviewed-on: https://chromium-review.googlesource.com/c/1409322 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622463}
Changed files
- build/fuchsia/linux.sdk.sha1
- build/fuchsia/mac.sdk.sha1
-
Add WPT for applyConstraints() for remote video tracks.
Changed by Marina Ciocea - marinacioceaohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 15:34:41 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4fa087130e4e5f437858b5dc005e8e6ac3d679f4 Comments
Add WPT for applyConstraints() for remote video tracks. Bug: 899789 Change-Id: If7e01be191d8b01f630b69a5f25c2f0929b617fd Reviewed-on: https://chromium-review.googlesource.com/c/1409199 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#622462}
Changed files
- third_party/blink/web_tests/fast/peerconnection/RTCPeerConnection-applyConstraints-remoteVideoTrack.html
-
Update V8 to version 7.3.387.
Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com Changed at Monday, 14-Jan-19 15:27:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0e9488a8838b6bcd72564e0734a293916ed87124 Comments
Update V8 to version 7.3.387. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6b6bec54..ee9d016b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic4b1c49134d47a62b73d7a052054c48190572af1 Reviewed-on: https://chromium-review.googlesource.com/c/1409262 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622461}
Changed files
- DEPS
-
Roll src-internal 6ae0adf04ed9..8bd3326cb1d6 (1 commits)
Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com Changed at Monday, 14-Jan-19 15:20:10 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision cb8fe0c7014cd0b42cf382e0f7041eef2f0db7db Comments
Roll src-internal 6ae0adf04ed9..8bd3326cb1d6 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6ae0adf04ed9..8bd3326cb1d6 Created with: gclient setdep -r src-internal@8bd3326cb1d6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I68bf11096511e50f5ae46d21be83f0b0caf9ffca Reviewed-on: https://chromium-review.googlesource.com/c/1409090 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622460}
Changed files
- DEPS
-
[ozone/wayland] Fix event routing issue when multiple windows are open
Changed by Nick Diego Yamane - nickdiegoohnoyoudont@igalia.com Changed at Monday, 14-Jan-19 15:10:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8c23e17dd76dcf3d2e145f2ad001f0b32955e157 Comments
[ozone/wayland] Fix event routing issue when multiple windows are open Currently ozone wayland implementation uses singletons for bridging wayland input objects (e.g: WaylandPointer, WaylandKeyboard, WaylandTouch), each of them inject events into chromium event system. Additionally they are currently responsible for controlling implicit_grab flag stored on WaylandWindow instances. This particular issue happens when new windows are created and the user tries to trigger any action in browser UI (e.g: create new tab) of the newly created window, what is currently leading to actions to be taken in the wrong window (e.g: the new tab is open in the wrong window). Under the hood, the bug happens because the implicit_grab flag is not correctly unset for the window that lost focus. So the fix consists on properly unsetting it on WaylandPointer. Bug: 921009 Change-Id: I25092fa211849f0345895b88681eaded52f09792 Reviewed-on: https://chromium-review.googlesource.com/c/1407011 Reviewed-by: Maksim Sisov <msisov@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#622459}
Changed files
- ui/ozone/platform/wayland/wayland_pointer.cc
-
Migrate browsing_data helpers to OnceCallback
Changed by Christian Dullweber - dullweberohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 15:10:24 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 96254d48e5941c8808124f16781d4745fe575958 Comments
Migrate browsing_data helpers to OnceCallback Change all fetch callbacks to OnceCallback and fix related code. Change-Id: Iee8c5eeaefccfa57ad40c3c8cdaa3fc84cb6f6f3 Reviewed-on: https://chromium-review.googlesource.com/c/1409190 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#622458}
Changed files
- chrome/browser/browsing_data/browsing_data_appcache_helper.cc
- chrome/browser/browsing_data/browsing_data_appcache_helper.h
- chrome/browser/browsing_data/browsing_data_cookie_helper.cc
- chrome/browser/browsing_data/browsing_data_cookie_helper.h
- chrome/browser/browsing_data/browsing_data_file_system_helper.cc
- chrome/browser/browsing_data/browsing_data_file_system_helper.h
- chrome/browser/browsing_data/browsing_data_indexed_db_helper.cc
- chrome/browser/browsing_data/browsing_data_indexed_db_helper.h
- chrome/browser/browsing_data/browsing_data_local_storage_helper.cc
- chrome/browser/browsing_data/browsing_data_local_storage_helper.h
- chrome/browser/browsing_data/browsing_data_media_license_helper.cc
- chrome/browser/browsing_data/browsing_data_media_license_helper.h
- chrome/browser/browsing_data/browsing_data_service_worker_helper.cc
- chrome/browser/browsing_data/browsing_data_service_worker_helper.h
- chrome/browser/browsing_data/counters/cache_counter.cc
- chrome/browser/browsing_data/counters/site_data_counter.cc
- chrome/browser/browsing_data/counters/site_data_counting_helper.cc
- chrome/browser/browsing_data/counters/site_data_counting_helper.h
- chrome/browser/browsing_data/local_data_container.cc
- chrome/browser/browsing_data/mock_browsing_data_appcache_helper.cc
- chrome/browser/browsing_data/mock_browsing_data_appcache_helper.h
- chrome/browser/browsing_data/mock_browsing_data_cookie_helper.cc
- chrome/browser/browsing_data/mock_browsing_data_cookie_helper.h
- chrome/browser/browsing_data/mock_browsing_data_file_system_helper.cc
- chrome/browser/browsing_data/mock_browsing_data_file_system_helper.h
- chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc
- chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.h
- chrome/browser/browsing_data/mock_browsing_data_local_storage_helper.cc
- chrome/browser/browsing_data/mock_browsing_data_local_storage_helper.h
- chrome/browser/browsing_data/mock_browsing_data_media_license_helper.cc
- chrome/browser/browsing_data/mock_browsing_data_media_license_helper.h
- chrome/browser/browsing_data/mock_browsing_data_service_worker_helper.cc
- chrome/browser/browsing_data/mock_browsing_data_service_worker_helper.h
- chrome/browser/browsing_data/site_data_size_collector.cc
- chrome/browser/browsing_data/site_data_size_collector.h
-
Remove unused imports
Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 15:08:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 69738b80d28975e7573981da7bafdc8fa53f8c79 Comments
Remove unused imports In preparation for renaming PausableObject remove unused imports. BUG=907125 Change-Id: Id6cdc2561d1df04313ac6f16edea81d0b45445f3 Reviewed-on: https://chromium-review.googlesource.com/c/1407650 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#622457}
Changed files
- third_party/blink/renderer/core/css/font_face_set_document.h
- third_party/blink/renderer/core/css/font_face_set_worker.h
- third_party/blink/renderer/core/workers/dedicated_worker.h
- third_party/blink/renderer/core/workers/worker_global_scope.cc
- third_party/blink/renderer/modules/mediarecorder/media_recorder.h
- third_party/blink/renderer/modules/mediastream/user_media_request.h
- third_party/blink/renderer/modules/sensor/sensor.h
-
Enable unique font matching matching by default
Changed by Dominik Röttsches - drottohnoyoudont@chromium.org Changed at Monday, 14-Jan-19 15:06:36 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2e8e7c130cbb432732e973fd8c266a0608727b5f Comments
Enable unique font matching matching by default Now that all implementations for Android, Windows, Linux/CrOS and Mac are in place, enable the feature globally. Chrome will match fonts references in @font-face { src: local(<font-name>) } correctly by postscript name or full font name. This addresses a long standing, highly starred font matching issue in Chrome. Bug: 828317, 627143, 921029 Change-Id: I348855fdca817a4cd279f4d938e6d5ffe91ee004 Reviewed-on: https://chromium-review.googlesource.com/c/1400695 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#622456}
Changed files
- content/public/common/content_features.cc
- third_party/blink/web_tests/NeverFixTests
- third_party/blink/web_tests/fast/css/font-face-character-fallback.html
- third_party/blink/web_tests/fast/css/font-face-descending-unicode-range.html
- third_party/blink/web_tests/fast/css/font-face-download-error.html
- third_party/blink/web_tests/fast/css/font-face-in-media-rule.html
- third_party/blink/web_tests/fast/css/font-face-multiple-ranges-for-unicode-range.html
- third_party/blink/web_tests/fast/css/font-face-unicode-range-monospace.html
- third_party/blink/web_tests/fast/css/fontfaceset-add-remove.html
- third_party/blink/web_tests/fast/css/fontfaceset-download-error.html
- third_party/blink/web_tests/fast/css/fontfaceset-multiple-faces.html
- third_party/blink/web_tests/fast/forms/select-popup/popup-menu-font-face.html
- third_party/blink/web_tests/fast/inline/vertical-align-with-fallback-fonts.html
- third_party/blink/web_tests/fast/text/capitalize-boundaries.html
- third_party/blink/web_tests/fast/text/unique-vs-family-match.html
- third_party/blink/web_tests/inspector-protocol/layout-fonts/unicode-range-order.js
- third_party/blink/web_tests/platform/mac-mac10.10/fast/text/unique-vs-family-match-expected.png
- third_party/blink/web_tests/platform/mac-mac10.12/fast/text/unique-vs-family-match-expected.png
- third_party/blink/web_tests/platform/mac/fast/text/unique-vs-family-match-expected.png
-
Roll src/third_party/skia 33f58abef2b7..da068c0d1d7c (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Monday, 14-Jan-19 15:04:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 77f00271eba04ca6239c9e9c7a2be83cf08050b6 Comments
Roll src/third_party/skia 33f58abef2b7..da068c0d1d7c (1 commits) https://skia.googlesource.com/skia.git/+log/33f58abef2b7..da068c0d1d7c git log 33f58abef2b7..da068c0d1d7c --date=short --no-merges --format='%ad %ae %s' 2019-01-14 borenet@google.com [presubmit] Remove pylint check Created with: gclient setdep -r src/third_party/skia@da068c0d1d7c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: I7e46e1bd54521eba7d4c6030ca5d9d96d69ba0b9 Reviewed-on: https://chromium-review.googlesource.com/c/1409093 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622455}
Changed files
- DEPS
-
Import wpt@1c26e6117f9e5afb6fda2976e3a7f3e2ec157852
Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com Changed at Monday, 14-Jan-19 15:03:14 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4fb653733851359f8686e8d929d660c460f44432 Comments
Import wpt@1c26e6117f9e5afb6fda2976e3a7f3e2ec157852 Using wpt-import in Chromium 95de362e85f94212d46f68f57bfab78d471bf613. With Chromium commits locally applied on WPT: 1c633d483b "Snap the snapped_dest_rect for backgrounds" 1061788dd2 "Reland "Add quota usage details tests for all other storage backends."" bcd3934d05 "Add a test for ServiceWorker and AppCache interaction with claim()" 4836c563b1 "Change web platform test with mouse inputs under "pinterevents/"" 33a49f0de5 "[WebLocks]: Modifying weblocks algos to be O(1)" 66a94294e7 "Verify getContributingSources() does not return any CSRCs." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I65569e25b75d6dce327d1d69d30c1ab0310b8e17 Reviewed-on: https://chromium-review.googlesource.com/c/1409263 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622454}
Changed files
- third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
- third_party/blink/web_tests/external/wpt/html/semantics/selectors/pseudo-classes/link.html
-
Migrate signin_ui_util.cc to IdentityManager
Changed by Henrique Ferreiro - hferreiroohnoyoudont@igalia.com Changed at Monday, 14-Jan-19 14:58:14 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0dcf7a79890ab7201fcf34aa2f18d102f7f56523 Comments
Migrate signin_ui_util.cc to IdentityManager Replace SigninManager with IdentityManager Bug: 920227 Change-Id: I10062fbbbc5ca69a937436632954c5d64216b6eb Reviewed-on: https://chromium-review.googlesource.com/c/1406968 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#622453}
Changed files
- chrome/browser/signin/signin_ui_util.cc