Builder Linux FYI Release (AMD R7 240) Build 2685
Results:
Success
Trigger Info:
Project | chromium |
Revision | 6e83997c8bacf3fcb37b751869abd4bacfc7c14f |
Got Revision | 6e83997c8bacf3fcb37b751869abd4bacfc7c14f |
Execution:
- Source: Task 42500186272d6a10
- Bot: swarm1080-c4
- Recipe: chromium
Steps and Logfiles:
Show:-
( 219 ms ) report buildersrunning tester 'Linux FYI Release (AMD R7 240)' on master 'chromium.gpu.fyi'
-
- - no logs -
-
( 1 secs ) read test spec (chromium.gpu.fyi.json)path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
-
( 464 ms ) lookup builder GN argsbuild_angle_gles1_conform_tests = truedcheck_always_on = trueffmpeg_branding = "Chrome"internal_gles2_conform_tests = trueis_component_build = falseis_debug = falseproprietary_codecs = truestrip_absolute_paths_from_debug_symbols = truesymbol_level = 1use_goma = truegoma_dir = "/b/swarming/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] angle_white_box_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 974 ms ) angle_white_box_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 7s
-
- - no logs -
-
( 940 ms ) test_pre_run.[trigger] tab_capture_end2end_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 1 mins 3 secs ) tab_capture_end2end_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Pending time: 36sShard duration: 23s
-
- - no logs -
-
- - no logs -
-
( 937 ms ) test_pre_run.[trigger] gles2_conform_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] swiftshader_unittests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 1 secs ) swiftshader_unittests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 5s
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] context_lost_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 3 mins 15 secs ) context_lost_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:03:10.760979Total tests: 10* Passed: 10 (10 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 881 ms ) test_pre_run.[trigger] depth_capture_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 30 secs ) depth_capture_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 26sTotal tests: 3* Passed: 3 (3 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] gpu_process_launch_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 2 mins 59 secs ) gpu_process_launch_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:02:50.382029Total tests: 15* Passed: 15 (15 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 979 ms ) test_pre_run.[trigger] hardware_accelerated_feature_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 24 secs ) hardware_accelerated_feature_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 22sTotal tests: 2* Passed: 2 (2 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 874 ms ) test_pre_run.[trigger] info_collection_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 23 secs ) info_collection_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 21sTotal tests: 1* Passed: 1 (1 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 34 secs ) maps_pixel_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 32sTotal tests: 1* Passed: 1 (1 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 9 mins 22 secs ) pixel_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:09:09.796491Total tests: 49* Passed: 49 (49 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 965 ms ) test_pre_run.[trigger] screenshot_sync_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 1 mins 22 secs ) screenshot_sync_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:01:12.610974Total tests: 4* Passed: 4 (4 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 4 mins 56 secs ) trace_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:04:51.663086Total tests: 48* Passed: 24 (24 expected, 0 unexpected)* Skipped: 24 (24 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 11 secs ) test_pre_run.[trigger] webgl2_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 2 hrs 6 mins ) webgl2_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Max pending time: 1:59:21.787593 (shard #19)Max shard duration: 0:07:01.350263 (shard #4)Min shard duration: 0:05:24.232951 (shard #14)Total tests: 2803* Passed: 2735 (2735 expected, 0 unexpected)* Skipped: 68 (68 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
- stdout
- json.output
- swarming.summary
- Merge script log
- outdir_json
- step_metadata
- shard #0 isolated out
- shard #0 (370.4 sec)
- shard #1 isolated out
- shard #1 (342.1 sec)
- shard #2 isolated out
- shard #2 (349.4 sec)
- shard #3 isolated out
- shard #3 (377.8 sec)
- shard #4 isolated out
- shard #4 (414.7 sec)
- shard #5 isolated out
- shard #5 (384.4 sec)
- shard #6 isolated out
- shard #6 (396.1 sec)
- shard #7 isolated out
- shard #7 (320.4 sec)
- shard #8 isolated out
- shard #8 (376.9 sec)
- shard #9 isolated out
- shard #9 (349.5 sec)
- shard #10 isolated out
- shard #10 (411.3 sec)
- shard #11 isolated out
- shard #11 (358.0 sec)
- shard #12 isolated out
- shard #12 (380.8 sec)
- shard #13 isolated out
- shard #13 (345.6 sec)
- shard #14 isolated out
- shard #14 (317.9 sec)
- shard #15 isolated out
- shard #15 (380.3 sec)
- shard #16 isolated out
- shard #16 (377.6 sec)
- shard #17 isolated out
- shard #17 (347.0 sec)
- shard #18 isolated out
- shard #18 (410.4 sec)
- shard #19 isolated out
- shard #19 (401.1 sec)
-
- - no logs -
-
( 2 secs ) test_pre_run.[trigger] webgl_conformance_gl_passthrough_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 10 mins 11 secs ) webgl_conformance_gl_passthrough_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Max pending time: 0:03:56.189826 (shard #1)Max shard duration: 0:06:03.591215 (shard #1)Min shard duration: 0:02:04.753410 (shard #0)Total tests: 938* Passed: 932 (932 expected, 0 unexpected)* Skipped: 6 (6 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] webgl_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 9 mins 25 secs ) webgl_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Max pending time: 0:02:24.223297 (shard #1)Max shard duration: 0:06:52.664568 (shard #1)Min shard duration: 0:02:14.843240 (shard #0)Total tests: 938* Passed: 932 (932 expected, 0 unexpected)* Skipped: 6 (6 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm1080-c4" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547114118042972, "id": "8924726982517770928", "project": "chromium", "tags": ["builder:Linux FYI Release (AMD R7 240)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/6e83997c8bacf3fcb37b751869abd4bacfc7c14f", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Linux Builder", "parent_buildnumber:38623", "scheduler_invocation_id:9090157044783834352", "scheduler_job_id:chromium/Linux FYI Release (AMD R7 240)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "Linux FYI Release (AMD R7 240)" | setup_build |
buildnumber | 2685 | setup_build |
mastername | "chromium.gpu.fyi" | setup_build |
parent_buildername | "GPU FYI Linux Builder" | setup_build |
parent_got_angle_revision | "c05c141619a55ba72aba9a1c1694627093073d03" | setup_build |
parent_got_buildtools_revision | "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" | setup_build |
parent_got_dawn_revision | "bd48385d5009bbe2fc76d973cdeca96673eb9db8" | setup_build |
parent_got_nacl_revision | "1ea07c56ac9b57c30eb784ab2af582af0cdd4b08" | setup_build |
parent_got_revision | "6e83997c8bacf3fcb37b751869abd4bacfc7c14f" | setup_build |
parent_got_revision_cp | "refs/heads/master@{#621525}" | setup_build |
parent_got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | setup_build |
parent_got_v8_revision | "d1ef638da4a0ab4e8d790bf10c98440269f0cc1e" | setup_build |
parent_got_v8_revision_cp | "refs/heads/7.3.354@{#1}" | setup_build |
parent_got_webrtc_revision | "00a6ab568bf021a2861ef15e4a679812c58250cb" | setup_build |
parent_got_webrtc_revision_cp | "refs/heads/master@{#26179}" | setup_build |
parent_mastername | "chromium.gpu.fyi" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
revision | "6e83997c8bacf3fcb37b751869abd4bacfc7c14f" | setup_build |
swarm_hashes | {"angle_end2end_tests": "995c963da843025cfa761cfc6cf3d1ed34726dd4", "angle_perftests": "29a69439de241aa7d598d79f13cf3a479b306d0a", "angle_unittests": "4b87fa9a482e1ae268f93d93b905176abc38694b", "angle_white_box_tests": "e992638cc937d8aa4801fd9379830458fc992efc", "browser_tests": "7d8893c6fa975eb39327c01a6a707dc3380f6d9c", "dawn_end2end_tests": "38dc8389954a76b7586e5e87311dfbdf239e7b98", "gl_tests": "8fac90366eb4b03c6c4a675166a9ed8b990d4ee5", "gl_unittests": "31adb00506a640715cad7d9c116baaf2e85692fd", "gles2_conform_test": "21bc1508f9319d3281ad341e2992137a55c7952b", "swiftshader_unittests": "a8d64def3fec34dd5c2423d7104020f8e197cc70", "telemetry_gpu_integration_test": "11d7d928e50e1e6be53123e44265c26dcece0aa6"} | setup_build |
got_angle_revision | "c05c141619a55ba72aba9a1c1694627093073d03" | bot_update |
got_buildtools_revision | "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" | bot_update |
got_dawn_revision | "bd48385d5009bbe2fc76d973cdeca96673eb9db8" | bot_update |
got_nacl_revision | "1ea07c56ac9b57c30eb784ab2af582af0cdd4b08" | bot_update |
got_revision | "6e83997c8bacf3fcb37b751869abd4bacfc7c14f" | bot_update |
got_revision_cp | "refs/heads/master@{#621525}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "d1ef638da4a0ab4e8d790bf10c98440269f0cc1e" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.354@{#1}" | bot_update |
got_webrtc_revision | "00a6ab568bf021a2861ef15e4a679812c58250cb" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26179}" | bot_update |
swarm_hashes | {} | find isolated tests |
Blamelist:
- Lutz Justen (ljustenohnoyoudont@chromium.org)
- Mirko Bonadei (mbonadeiohnoyoudont@chromium.org)
- Marc Treib (treibohnoyoudont@chromium.org)
- Makoto Shimazu (shimazuohnoyoudont@chromium.org)
- Alex Clarke (alexclarkeohnoyoudont@chromium.org)
- chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
- Xiaocheng Hu (xiaochenghohnoyoudont@chromium.org)
- Kent Tamura (tkentohnoyoudont@chromium.org)
- Edin Kadric (edinohnoyoudont@google.com)
- Andrew Comminos (acomminosohnoyoudont@fb.com)
- Koji Ishii (kojiiohnoyoudont@chromium.org)
- Max Morin (maxmorinohnoyoudont@chromium.org)
- Dominik Röttsches (drottohnoyoudont@chromium.org)
- Jan Krcal (jkrcalohnoyoudont@chromium.org)
- Armando Miraglia (armaxohnoyoudont@chromium.org)
- Friedrich Horschig (fhorschigohnoyoudont@chromium.org)
- CJ DiMeglio (lethalantidoteohnoyoudont@chromium.org)
- Chris Hall (chrishallohnoyoudont@chromium.org)
- Martin Robinson (mrobinsonohnoyoudont@igalia.com)
- Javier Fernandez (jfernandezohnoyoudont@igalia.com)
- Kent Tamura (tkentohnoyoudont@chromium.org)
- Arthur Sonzogni (arthursonzogniohnoyoudont@chromium.org)
- Alexey Baskakov (loysoohnoyoudont@chromium.org)
- mrefaat (mrefaatohnoyoudont@chromium.org)
- Aran Gilman (gilmanmhohnoyoudont@google.com)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Yuki Awano (yawanoohnoyoudont@chromium.org)
- chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Yoshifumi Inoue (yosinohnoyoudont@chromium.org)
- Martin Robinson (mrobinsonohnoyoudont@igalia.com)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Alexander Nohe (noheohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Mirko Bonadei (mbonadeiohnoyoudont@chromium.org)
- Sam McNally (sammcohnoyoudont@chromium.org)
Timing:
Create | Thursday, 10-Jan-19 09:55:18 UTC |
Start | Thursday, 10-Jan-19 09:55:30 UTC |
End | Thursday, 10-Jan-19 12:50:08 UTC |
Pending | 12 secs |
Execution | 2 hrs 54 mins |
All Changes:
-
[Sheriff] Revert "[DevTools] Prevent JSONReader::Read errors from invalid unicode points"
Changed by Lutz Justen - ljustenohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 09:45:03 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6e83997c8bacf3fcb37b751869abd4bacfc7c14f Comments
[Sheriff] Revert "[DevTools] Prevent JSONReader::Read errors from invalid unicode points" This reverts commit ff600d044a97519bf05512af5473e3d48c4f615b. Reason for revert: getResponseBodyInvalidChar times out on chromium.mac Mac10.12 Tests. Original change's description: > [DevTools] Prevent JSONReader::Read errors from invalid unicode points > > Opening a page with an invalid unicode escape sequence prevents > extensions using the chrome.debugger interface from receiving > Network.getResponseBody responses. > > Using base::JSON_REPLACE_INVALID_CHARACTERS makes base::JSONReader::Read > replace invalid unicode code points with \uFFFD. This will cause us to > lose the original invalid code point, but at least getResponseBody will > not silently fail in extensions. > > There is a related problem when using "Save as..." on requests with > invalid characters: http://crbug.com/919906 > > Bug: 824174 > Change-Id: I66d528e88bf5a8feb586d39d357190857f75996e > Reviewed-on: https://chromium-review.googlesource.com/c/1399538 > Commit-Queue: Joey Arhar <jarhar@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621445} TBR=dgozman@chromium.org,rdevlin.cronin@chromium.org,alph@chromium.org,jarhar@chromium.org Change-Id: If601f8ddfb39db0c03799eae28dc0eac8dd6c860 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824174 Reviewed-on: https://chromium-review.googlesource.com/c/1404161 Reviewed-by: Lutz Justen <ljusten@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#621525}
Changed files
- chrome/browser/extensions/api/debugger/debugger_api.cc
- chrome/test/data/extensions/api_test/debugger/background.js
- chrome/test/data/extensions/api_test/debugger/invalid_char.html
-
Remove dependency on rtc::ProxyType and cricket::ProtocolType.
Changed by Mirko Bonadei - mbonadeiohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 09:44:25 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a589b0923807565a2e799b352314118f66d3052b Comments
Remove dependency on rtc::ProxyType and cricket::ProtocolType. Instead of sharing the enum types rtc::ProxyType and cricket::ProtocolType with WebRTC, libjingle_xmpp now has a copy of these emums. This CL also updates the only place where a method affected by this change was invoked. Bug: 919085 Change-Id: I28a94d0f6f141eb2418e71a4ac783f98d8651e50 Reviewed-on: https://chromium-review.googlesource.com/c/1398082 Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#621524}
Changed files
- jingle/notifier/base/xmpp_connection.cc
- jingle/notifier/communicator/connection_settings.cc
- third_party/libjingle_xmpp/xmpp/xmppclientsettings.h
-
Reland: sync_integration_tests: don't instantiate ScopedFeatureList in test body
Changed by Marc Treib - treibohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 09:43:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a0f3d164c7bb26b7677cddc30b2e1f740d68542d Comments
Reland: sync_integration_tests: don't instantiate ScopedFeatureList in test body This is a reland of https://crrev.com/c/1402799. The original CL was reverted for supposedly introducing flakiness, but in fact in only renamed an already-flaky test. That test has since been disabled, so trying again. Creating a ScopedFeatureList instance in the test body creates a data race related to the global FeatureList instance: The ScopedFeatureList overrides the global instance, and then it gets reset after the test body; however, the feature list might still be queried from the Sync thread after that. This CL avoids the issue by instead creating test (sub)classes to hold the ScopedFeatureLists. Bug: 915219 Change-Id: Iaa6185d0dd9a042a9275100e3b1cae1eceb52633 Reviewed-on: https://chromium-review.googlesource.com/c/1402890 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#621523}
Changed files
- chrome/browser/sync/test/integration/single_client_secondary_account_sync_test.cc
- chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc
- chrome/browser/sync/test/integration/single_client_standalone_transport_sync_test.cc
- chrome/browser/sync/test/integration/single_client_user_consents_sync_test.cc
- chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
-
Pass Mojo's data pipe from URLLoaderClientImpl to RequestPeer
Changed by Makoto Shimazu - shimazuohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 09:35:32 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 494ae7b5b117ad07921b77dd2b5474ff62f02748 Comments
Pass Mojo's data pipe from URLLoaderClientImpl to RequestPeer When ResourceLoadViaDataPipe is on, URLLoaderClientImpl starts to transfer Mojo's data pipe directly to the RequestPeer via ResourceDispatcher. URLLoaderClientImpl used to use URLResponseBodyConsumer to read the data pipe and send the body to RequestPeer, but also use it to defer to send the body when SetDeferesLoading() is called. We need to implement the deferring logic at another place where the body is read. Bug: 920081 Change-Id: I5bd89a1e65ffb644debe57b3f5b2692d9e51bc37 Reviewed-on: https://chromium-review.googlesource.com/c/1401831 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#621522}
Changed files
- content/renderer/loader/test_request_peer.cc
- content/renderer/loader/test_request_peer.h
- content/renderer/loader/url_loader_client_impl.cc
- content/renderer/loader/url_loader_client_impl.h
- content/renderer/loader/url_loader_client_impl_unittest.cc
-
Add a top level traits bag comment and improve unittest
Changed by Alex Clarke - alexclarkeohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 09:32:32 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8e92e732734fb13b970dde6603ae6a178b18a38c Comments
Add a top level traits bag comment and improve unittest Change-Id: Ica9aaefb29261df3e741f12880c12e4ebfed948d Reviewed-on: https://chromium-review.googlesource.com/c/1403130 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#621521}
Changed files
- base/traits_bag.h
- base/traits_bag_unittest.cc
-
Roll src-internal eb727ce86607..ad2d19ccb8fa (3 commits)
Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com Changed at Thursday, 10-Jan-19 09:28:08 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b57f39be8f2446089742c6b7043c855c9a78ddb5 Comments
Roll src-internal eb727ce86607..ad2d19ccb8fa (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb727ce86607..ad2d19ccb8fa Created with: gclient setdep -r src-internal@ad2d19ccb8fa The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iae7c483791aa708b0faa65a716f2e73a31361793 Reviewed-on: https://chromium-review.googlesource.com/c/1404798 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621520}
Changed files
- DEPS
-
[LayoutNG] Set IsAnonymousText() as true for ellipsis fragments
Changed by Xiaocheng Hu - xiaochenghohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 09:27:15 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 70a9c2c44d3b46e1d802a54441a518692714f5f2 Comments
[LayoutNG] Set IsAnonymousText() as true for ellipsis fragments This patch makes ellipsis fragments return true for IsAnonymousText(), so that they are not eligible for resolving caret positions. This fixes 8 crashers with bidi caret affinity. Bug: 894651 Change-Id: I4b754416669d4e160650609aabf51ccc419cfa83 Reviewed-on: https://chromium-review.googlesource.com/c/1404387 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#621519}
Changed files
- third_party/blink/renderer/core/layout/ng/inline/ng_physical_text_fragment.cc
- third_party/blink/renderer/core/layout/ng/inline/ng_physical_text_fragment_test.cc
- third_party/blink/web_tests/FlagExpectations/enable-blink-features=LayoutNG
-
Form-associated custom elements: Implement formResetCallback
Changed by Kent Tamura - tkentohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 09:26:29 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d1a9e16e38225d64c99b9b42c2d8d06f2d50f651 Comments
Form-associated custom elements: Implement formResetCallback Form reset is invoked via two paths. * HTMLFormElement.prototype.reset() * Activation behavior of <input type=reset> and <button type=reset> The callback enqueued by CustomElement::EnqueueFormResetCallback() will be invoked at * CEReactions epilogue for the former * A microtask dispatched by "enqueue an element on the appropriate element queue" [1] [1] https://html.spec.whatwg.org/multipage/custom-elements.html#enqueue-an-element-on-the-appropriate-element-queue Bug: 905922 Bug: https://github.com/w3c/webcomponents/issues/187 Change-Id: I9be604cc5893db69ac1bc0e02e4283e6f45086bd Reviewed-on: https://chromium-review.googlesource.com/c/1404548 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#621518}
Changed files
- third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.cc
- third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.h
- third_party/blink/renderer/bindings/core/v8/script_custom_element_definition_builder.cc
- third_party/blink/renderer/bindings/core/v8/script_custom_element_definition_builder.h
- third_party/blink/renderer/bindings/core/v8/script_custom_element_definition_data.h
- third_party/blink/renderer/core/html/custom/custom_element.cc
- third_party/blink/renderer/core/html/custom/custom_element.h
- third_party/blink/renderer/core/html/custom/custom_element_definition.h
- third_party/blink/renderer/core/html/custom/custom_element_reaction_factory.cc
- third_party/blink/renderer/core/html/custom/custom_element_reaction_factory.h
- third_party/blink/renderer/core/html/custom/custom_element_test_helpers.h
- third_party/blink/renderer/core/html/forms/html_form_element.cc
- third_party/blink/web_tests/custom-elements/tentative/form-associated-reset.html
-
Use monospaced font for passwords in password manager bubble.
Changed by Edin Kadric - edinohnoyoudont@google.com Changed at Thursday, 10-Jan-19 09:25:29 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision dfb35c5985c749f1f12574dbf02a0ff8e9dfe5b3 Comments
Use monospaced font for passwords in password manager bubble. This sets the label to a monospace font depending on the OS: MacOS - Menlo Windows - Consolas Chrome OS - DejaVu Sans Mono Linux - DejaVu Sans Mono Also involves changing the font list caching in resource_bundle.cc to receive typeface as parameter and add it to the caching key, instead of only supporting a default font. Support for comboboxes will be added in a future CL (which will be able to reuse some of the work done here). Tested on Mac. I have a Linux workstation that I will test it on next, but I don't have Windows and ChromeOS. Screenshots attached to corresponding bug: https://bugs.chromium.org/p/chromium/issues/detail?id=768825 Bug: 768825 Change-Id: Ie94cec7045dafd1346263c383ca08edd5560d8f5 Reviewed-on: https://chromium-review.googlesource.com/c/1378643 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#621517}
Changed files
- chrome/browser/ui/views/chrome_typography.h
- chrome/browser/ui/views/chrome_typography_provider.cc
- chrome/browser/ui/views/passwords/password_items_view.cc
- ui/base/resource/resource_bundle.cc
- ui/base/resource/resource_bundle.h
-
Perform flexbox child hit testing by testing all children atomically
Changed by Andrew Comminos - acomminosohnoyoudont@fb.com Changed at Thursday, 10-Jan-19 09:23:47 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 25ece8e7574112efedb141a28bc3755e3a0173d7 Comments
Perform flexbox child hit testing by testing all children atomically When two child elements of a flexbox overlap (for example, due to negative margins), the element drawn in the foreground may not actually capture the hit if the element underneath it is hit-tested in an earlier phase (e.g. foreground before child block background), despite being occluded. This is because painting of flexbox children is done atomically (all phases at once). This change makes hit testing atomic as well, in accordance with the spec [1]. [1] https://www.w3.org/TR/css-flexbox-1/#painting Bug: 844505 Change-Id: Iceab80b42f19488dcb59565ea3c0ce40d48c483b Reviewed-on: https://chromium-review.googlesource.com/c/1388206 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#621516}
Changed files
- third_party/blink/renderer/core/layout/layout_flexible_box.cc
- third_party/blink/renderer/core/layout/layout_flexible_box.h
- third_party/blink/web_tests/TestExpectations
- third_party/blink/web_tests/external/wpt/css/css-flexbox/hittest-overlapping-margin.html
- third_party/blink/web_tests/external/wpt/css/css-flexbox/hittest-overlapping-relative.html
-
[LayoutNG] Clear association of fragments before new one is created
Changed by Koji Ishii - kojiiohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 09:21:47 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0af0ddd9c4e8b244eba706ef6a019808065a8c23 Comments
[LayoutNG] Clear association of fragments before new one is created This patch changes the timing of clearing associations between LayoutObject and NGPaintFragment to before new NGPaintFragment is created. Before this change, it was cleared before layout. However, fragment caching may skip creating new NGPaintFragment, and in such cases, association will not be created. When this happens, some LayoutObject look as if they did not produce fragments. Also this change should reduce the number of clearing associations since |NGInlineNode::Layout()| runs for each line while |LayoutNGMixin::SetPaintFragment()| runs for each inline formatting context (per fragmentainer.) This patch also improves support for block fragmentations but only to pass tests that pass before this change. Bug: 916948 Change-Id: Ie7d364cab32c5c56f558a1525e967b760272360d Reviewed-on: https://chromium-review.googlesource.com/c/1391250 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#621515}
Changed files
- third_party/blink/renderer/core/layout/layout_block_flow.cc
- third_party/blink/renderer/core/layout/layout_block_flow.h
- third_party/blink/renderer/core/layout/ng/inline/ng_inline_node.cc
- third_party/blink/renderer/core/layout/ng/inline/ng_inline_node.h
- third_party/blink/renderer/core/layout/ng/layout_ng_mixin.cc
- third_party/blink/renderer/core/layout/ng/layout_ng_mixin.h
- third_party/blink/renderer/core/layout/ng/ng_block_break_token.cc
- third_party/blink/renderer/core/layout/ng/ng_block_break_token.h
- third_party/blink/renderer/core/layout/ng/ng_block_node.cc
- third_party/blink/renderer/core/paint/ng/ng_inline_box_fragment_painter.cc
- third_party/blink/renderer/core/paint/ng/ng_paint_fragment.cc
- third_party/blink/renderer/core/paint/ng/ng_paint_fragment.h
-
Fix audio service quit timeout logic.
Changed by Max Morin - maxmorinohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 09:15:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f10ae53e17c31f66b1597f535e4ceeacb820ced0 Comments
Fix audio service quit timeout logic. With this change, setting it to 0 is still taken as "tear down asap", but the default value is "never tear down". The field trial testing config is updated to not set the teardown_timeout_s parameters (since the default is what we want already). Bug: 920173 Change-Id: Id49a60c7a6ffd231827248431d017755901bd1ee Tbr: dalecurtis Reviewed-on: https://chromium-review.googlesource.com/c/1402766 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#621514}
Changed files
- media/base/media_switches.cc
- services/audio/service.cc
- services/audio/service.h
- services/audio/service_factory.cc
- services/audio/test/service_lifetime_connector_test.cc
- testing/variations/fieldtrial_testing_config.json
-
UMA metrics for detecting uniquely matched fonts outside system font dir
Changed by Dominik Röttsches - drottohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 09:13:15 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c093321cee234053ffdf18958def34219a0f6467 Comments
UMA metrics for detecting uniquely matched fonts outside system font dir Add UMA metrics for detecting whether a uniquely matched font can be instantiated, or whether access to it is restricted by the sandbox or other reasons. The expectation is that this is a highly rare case. If a font cannot be instantiated, Blink automatically falls back to the next font in the CSS font family list, or performs system fallback. With this metric, we would like to find out whether we need to cover the case of uniquely matched fonts outside of system locations, or not. For example, by opening those files on the browser process side and passing the handle to the renderer. Bug: 889864 Change-Id: I27a242a1b2fca39be740897a5f270780f2c91a5a Reviewed-on: https://chromium-review.googlesource.com/c/1400694 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#621513}
Changed files
- third_party/blink/renderer/platform/fonts/win/font_unique_name_lookup_win.cc
- tools/metrics/histograms/enums.xml
- tools/metrics/histograms/histograms.xml
-
[AF Sync] Make storage_key for wallet metadata encode type()
Changed by Jan Krcal - jkrcalohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 09:05:23 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c816dddccba43ac6900e984b39bb4443df4157e9 Comments
[AF Sync] Make storage_key for wallet metadata encode type() This CL changes the storage_key used for wallet metadata sync bridge. We need to include the type() in the storage_key because of a difference between USS and Directory. In USS, DELETE changes are sent from the server to the bridge without the specifics (that include type()). Implementing the deletion without knowing the type() would need a hacky code, to say the least. It is okay to change the storage_key schema now because this was not defined before (in Directory) and the USS implementation has not hit any user, yet. Bug: 853688 Change-Id: I3d5504855783c089686d613822a49904eb233352 Reviewed-on: https://chromium-review.googlesource.com/c/1403417 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#621512}
Changed files
- components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc
- components/autofill/core/browser/webdata/autofill_sync_bridge_util.h
- components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc
- components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge_unittest.cc
-
[getUserMedia] Remove default value update for auto mirroring based on ec.
Changed by Armando Miraglia - armaxohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 08:58:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 61dfcce645ff01e60ad026e579774e3b5467a30b Comments
[getUserMedia] Remove default value update for auto mirroring based on ec. The logic that was upstream before the main refactoring of the constraints made so that the default value of autoGainControl would not be effected by echoCancellation. This CL fixes the current implementation to reflect such behavior. Qualitatively, however, this should not have an impact because (a) this would only effect the default value, and most importantly (b) the assignment was &= rather than a plain assignment. There are already tests in place to prevent regressions in this area. BUG=731170 Change-Id: Icf5a161654b57c70d66cbea7ab209156204a4838 Reviewed-on: https://chromium-review.googlesource.com/c/1402801 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#621511}
Changed files
- content/renderer/media/stream/media_stream_constraints_util_audio.cc
-
[Android] Deflake ManualFillingUiCaptureTests
Changed by Friedrich Horschig - fhorschigohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 08:55:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 937f6250959d6b976b2a52a3d8b5360af1c80957 Comments
[Android] Deflake ManualFillingUiCaptureTests The tests fail while waiting for the home button (which I mistakenly used as a more stable signal that the UI is done loading). Apparently, the home button depends on AppSharedPreferences which are not guaranteed to enable it. Removing that and increasing the waiting time instead. Bug: 911177, 913178, 908174 Change-Id: I3da5a586dbeeb8bad21523a77e02ce8c46d9467e Reviewed-on: https://chromium-review.googlesource.com/c/1403455 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#621510}
Changed files
- chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingTestHelper.java
- chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingUiCaptureTest.java
-
Adds aria attributes directly to download button.
Changed by CJ DiMeglio - lethalantidoteohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 08:54:23 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c8bca58a70e4758539e3151146e84e9bb318ca1b Comments
Adds aria attributes directly to download button. This CL changes the download button to use by aria attributes instead of explicitly creating accessibility nodes. Bug: 836549 Change-Id: I862fe03106ab523fd1f0fce5920aa3e6fad52265 Reviewed-on: https://chromium-review.googlesource.com/c/1391865 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#621509}
Changed files
- third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
- third_party/blink/renderer/modules/media_controls/elements/media_control_download_button_element.cc
- third_party/blink/renderer/modules/media_controls/elements/media_control_element_type.h
- third_party/blink/renderer/modules/media_controls/elements/media_control_input_element_test.cc
- third_party/blink/web_tests/media/controls/accessibility-download-button.html
-
Minor changes to DumpAccessibility testing documentation.
Changed by Chris Hall - chrishallohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 08:54:19 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b619dae107f550b20b275ff134b1ac9862c8b31c Comments
Minor changes to DumpAccessibility testing documentation. R=aboxhall,dmazzoni Change-Id: Iec188edefc214d7687d2387f340d005cbd991423 Reviewed-on: https://chromium-review.googlesource.com/c/1404546 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#621508}
Changed files
- content/test/data/accessibility/readme.md
-
Map accessible relations to AtkRelationSet
Changed by Martin Robinson - mrobinsonohnoyoudont@igalia.com Changed at Thursday, 10-Jan-19 08:53:17 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6a11adfcb5d83a4de1225e28be2ddf516c80e38a Comments
Map accessible relations to AtkRelationSet This adds support for mapping relations and reverse relations to ATK equivalents. Relations are calculated by maintaining a table of attribute to relation mappings with an optional reverse relation. We step through these tables and test each attribute, adding it to the relation set if necessary. Bug: 915453 Change-Id: I6d7db60009fd4d302c457098d5a0256ef6ea7647 Reviewed-on: https://chromium-review.googlesource.com/c/1378977 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#621507}
Changed files
- ui/accessibility/platform/ax_platform_node_auralinux.cc
- ui/accessibility/platform/ax_platform_node_auralinux.h
- ui/accessibility/platform/ax_platform_node_auralinux_unittest.cc
-
The outer node can't cross editing boundaries on paragraphs cloning
Changed by Javier Fernandez - jfernandezohnoyoudont@igalia.com Changed at Thursday, 10-Jan-19 08:51:19 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 64b55aa53b5ed290694431631767b3cf92030108 Comments
The outer node can't cross editing boundaries on paragraphs cloning Since r600342 we use the MoveParagraphWithClones function when we want to create list items from text paragraphs preserving their style. This change created a regression, as it's described in the bug this CL tries to solve. The problem is that a containing span outside the editing boundaries could be selected as outer node passed to the MoveParagraphWithClones function. This outer node can be used to define the node tree to clone. This outer node outside the editing boundaries may lead to duplicate wrongly some parts of the DOM tree. In order to fix the regression, we must ensure the outer node can't cross the editing boundaries. Bug: 919217 Change-Id: I2b60a63f8e451f48af407f67d1cb0883a77b4a6d Reviewed-on: https://chromium-review.googlesource.com/c/1404256 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#621506}
Changed files
- third_party/blink/renderer/core/editing/commands/insert_list_command.cc
- third_party/blink/web_tests/editing/execCommand/listify-styled-paragraph.html
-
custom-elements: Move CustomElementUpgradeReaction to custom_element_reaction_factory.cc
Changed by Kent Tamura - tkentohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 08:51:10 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f3ae74c4aef241fcb9c76f5a92937130db36b87b Comments
custom-elements: Move CustomElementUpgradeReaction to custom_element_reaction_factory.cc This CL has no behavior changes. Change-Id: Ie434ac532671c789a1f11dee055d0b5f9577f469 Reviewed-on: https://chromium-review.googlesource.com/c/1404754 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#621505}
Changed files
- third_party/blink/renderer/core/html/BUILD.gn
- third_party/blink/renderer/core/html/custom/custom_element_definition.cc
- third_party/blink/renderer/core/html/custom/custom_element_reaction_factory.cc
- third_party/blink/renderer/core/html/custom/custom_element_reaction_factory.h
- third_party/blink/renderer/core/html/custom/custom_element_registry.cc
- third_party/blink/renderer/core/html/custom/custom_element_upgrade_reaction.cc
- third_party/blink/renderer/core/html/custom/custom_element_upgrade_reaction.h
-
DynamicModule: Rely on isGoogleDomainUrl instead of the intent.
Changed by Arthur Sonzogni - arthursonzogniohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 08:43:26 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision dbe9457d993bd0bfd5260e70445c4ef012b49433 Comments
DynamicModule: Rely on isGoogleDomainUrl instead of the intent. The Android intent shouldn't be trusted. This CL makes the CCT DynamicModule to rely (less) on the intent to determine whether an URL is managed or not. - export google_util::IsGoogleDomainUrl to Java. - Remove the "module managed host list" concept. - Update DynamicModuleCoordinator.isModuleManagedUrl(url) accordingly. - Update dynamic module tests. Bug: 882404,900594 Change-Id: Ia4b27255f25cdd006c81c6c58f99a9cb5d9ebb85 Reviewed-on: https://chromium-review.googlesource.com/c/1400812 Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#621504}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
- chrome/android/java/src/org/chromium/chrome/browser/customtabs/dynamicmodule/DynamicModuleCoordinator.java
- chrome/android/java/src/org/chromium/chrome/browser/util/UrlUtilities.java
- chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/dynamicmodule/CustomTabsDynamicModuleTestUtils.java
- chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/dynamicmodule/CustomTabsDynamicModuleUITest.java
- chrome/browser/android/url_utilities.cc
-
WebApp: Cleanup WebAppProvider browser tests infrastructure.
Changed by Alexey Baskakov - loysoohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 08:38:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d0392757ad46b0315e11c30db3426a9c7a105c87 Comments
WebApp: Cleanup WebAppProvider browser tests infrastructure. Introduce TestWebAppProvider. This will allow us to simulate real WebApps environment in browser end-to-end tests. Split up WebAppProvider Initialization into two passes: - Create a graph of polymorphic subsystems. - Initialize subsystems: post scheduled tasks, start IO etc. It allows tests to substitute selected subsystems with mock instances OR skip/replace a whole CreateSubsystems or Init pass. - Remove recreation of WebAppAudioFocusIdMap - Remove fake WebAppProvider::Get()->Reset() call in SystemWebAppManager end-end test. - Use TestWebAppProvider with PendingAppManager in SystemWebAppManager tests. TBR=msw@chromium.org Bug: 920062 Change-Id: Id4d49da133da0fdb606b5dba3cc1f926df416614 Reviewed-on: https://chromium-review.googlesource.com/c/1399772 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#621503}
Changed files
- chrome/browser/ui/views/frame/browser_non_client_frame_view_browsertest.cc
- chrome/browser/web_applications/bookmark_apps/BUILD.gn
- chrome/browser/web_applications/bookmark_apps/system_web_app_manager_browsertest.cc
- chrome/browser/web_applications/bookmark_apps/system_web_app_manager_browsertest.h
- chrome/browser/web_applications/bookmark_apps/system_web_app_manager_unittest.cc
- chrome/browser/web_applications/bookmark_apps/test_web_app_provider.cc
- chrome/browser/web_applications/bookmark_apps/test_web_app_provider.h
- chrome/browser/web_applications/components/web_app_tab_helper_base.cc
- chrome/browser/web_applications/system_web_app_manager.cc
- chrome/browser/web_applications/system_web_app_manager.h
- chrome/browser/web_applications/test/test_system_web_app_manager.cc
- chrome/browser/web_applications/test/test_system_web_app_manager.h
- chrome/browser/web_applications/web_app_provider.cc
- chrome/browser/web_applications/web_app_provider.h
- chrome/browser/web_applications/web_app_provider_factory.cc
-
Fix downloadManager cookies usage.
Changed by mrefaat - mrefaatohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 08:29:35 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3f6d32c5b743451ed5fd4e84ff3827f33840d36e Comments
Fix downloadManager cookies usage. Set cookies on the NSURLConfiguration before the session is created, because once the session is created the NSURLConfiguration object can't be modified (NSURLSession returns a copy of the configuration not the one that is used by the session). Bug: 916662 Change-Id: Ia5688ccca1efd8b6370a0b587cbb891e1bfab5e8 Reviewed-on: https://chromium-review.googlesource.com/c/1394924 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#621502}
Changed files
- ios/web/download/download_controller_impl.h
- ios/web/download/download_controller_impl.mm
- ios/web/download/download_controller_impl_unittest.mm
- ios/web/download/download_task_impl.h
- ios/web/download/download_task_impl.mm
- ios/web/download/download_task_impl_unittest.mm
-
Remove computation of row and column indexes from AXObject and always return 0 instead.
Changed by Aran Gilman - gilmanmhohnoyoudont@google.com Changed at Thursday, 10-Jan-19 08:27:55 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 16dbbc22b675335f223a0efc39faebfbe13e465b Comments
Remove computation of row and column indexes from AXObject and always return 0 instead. As of https://crrev.com/c/1393376, this is handled in the browser code instead of by Blink. The test failures in earlier patchsets were fixed by https://crrev.com/c/1398841 and https://crrev.com/c/1396130. Bug: 832289 Change-Id: If29368b3d832d9a7303d22d789bf51d980a1badb Reviewed-on: https://chromium-review.googlesource.com/c/1393551 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#621501}
Changed files
- third_party/blink/renderer/modules/accessibility/ax_object.cc
-
Roll AFDO from 73.0.3666.0_rc-r1 to 73.0.3667.0_rc-r1
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Thursday, 10-Jan-19 08:24:56 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e686d0783c0e6e1ddc3f75e963baab09079e7d99 Comments
Roll AFDO from 73.0.3666.0_rc-r1 to 73.0.3667.0_rc-r1 This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I6c5744d9500072cc04dceff9ad62dbe61ac9d4ff Reviewed-on: https://chromium-review.googlesource.com/c/1404797 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621500}
Changed files
- chrome/android/profiles/newest.txt
-
Enable ChromeVox developer options by default
Changed by Yuki Awano - yawanoohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 08:16:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision dfa1328015f5ad0c8a79ac49073e6f9922cbd56b Comments
Enable ChromeVox developer options by default options UI are shown by default. Bug: 914203 Test: Open ChromeVox options page and confirm that ChromeVox developer Change-Id: I09ebc897cc985523a4c73ce05132b09e755c8cd5 Reviewed-on: https://chromium-review.googlesource.com/c/1399692 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#621499}
Changed files
- chrome/browser/about_flags.cc
- chrome/browser/flag_descriptions.cc
- chrome/browser/flag_descriptions.h
- chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js
- chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js
- chromeos/constants/chromeos_switches.cc
- chromeos/constants/chromeos_switches.h
-
Roll src-internal f9fc6f7d3922..eb727ce86607 (3 commits)
Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com Changed at Thursday, 10-Jan-19 08:16:12 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision cd888f92ae475409c84bc00ea90496081a2490ef Comments
Roll src-internal f9fc6f7d3922..eb727ce86607 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9fc6f7d3922..eb727ce86607 Created with: gclient setdep -r src-internal@eb727ce86607 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I68239ec379d4a2826692a0aa8609ec08f552d366 Reviewed-on: https://chromium-review.googlesource.com/c/1403912 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621498}
Changed files
- DEPS
-
Roll src/third_party/skia d2fa7e33798c..fdf91af698af (5 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Thursday, 10-Jan-19 08:14:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5c5eba6ce746cfc37b17a8b32afa4e5e38dcec70 Comments
Roll src/third_party/skia d2fa7e33798c..fdf91af698af (5 commits) https://skia.googlesource.com/skia.git/+log/d2fa7e33798c..fdf91af698af git log d2fa7e33798c..fdf91af698af --date=short --no-merges --format='%ad %ae %s' 2019-01-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 b5ba549abf2f..c05c141619a5 (1 commits) 2019-01-10 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-01-10 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-01-10 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-01-10 fmalita@chromium.org [sksg] 4x4 matrix support Created with: gclient setdep -r src/third_party/skia@fdf91af698af The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bsalomon@chromium.org Change-Id: I1e3e302783ce58acc45f459b93af548410c23285 Reviewed-on: https://chromium-review.googlesource.com/c/1404796 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621497}
Changed files
- DEPS
-
Simplify MouseEventManager::HandleMouseFocus()
Changed by Yoshifumi Inoue - yosinohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 08:09:03 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ff316f886c168fb26f94e35f3f948b9da2107cd1 Comments
Simplify MouseEventManager::HandleMouseFocus() This patch simplifies |MouseEventManager::HandleMouseFocus()| by sharing common code patch and utilizing early-return style for improving readability. Bug: 919540 Change-Id: Ie6508d1c508e6d4e2b0ed589d634290e7edc8696 Reviewed-on: https://chromium-review.googlesource.com/c/1404553 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#621496}
Changed files
- third_party/blink/renderer/core/input/mouse_event_manager.cc
-
Adjust emission of ATK activate events
Changed by Martin Robinson - mrobinsonohnoyoudont@igalia.com Changed at Thursday, 10-Jan-19 07:48:56 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4e00e614ced4cf12b881f2ab933eff703e8f1bb3 Comments
Adjust emission of ATK activate events Instead of sending an activate signal on toplevel windows whenever an item gets focus, send it only when the window itself receives a focus event. Additionally, don't send focus signals for toplevel windows at all. Bug: 909003 Change-Id: I08bc81712da123cd07162a4f5e03d785c929f542 Reviewed-on: https://chromium-review.googlesource.com/c/1402447 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#621495}
Changed files
- ui/accessibility/platform/ax_platform_node_auralinux.cc
- ui/accessibility/platform/ax_platform_node_auralinux_unittest.cc
-
Roll src/third_party/chromite 79dd338a2170..7906dd9bb540 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Thursday, 10-Jan-19 07:33:25 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c0825add758ad3418f18804b6a99e0833a224ec2 Comments
Roll src/third_party/chromite 79dd338a2170..7906dd9bb540 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/79dd338a2170..7906dd9bb540 git log 79dd338a2170..7906dd9bb540 --date=short --no-merges --format='%ad %ae %s' 2019-01-10 jclinton@chromium.org Add text editor configs to gitignore Created with: gclient setdep -r src/third_party/chromite@7906dd9bb540 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If2919fa17cbd6230f38c67904a1a3768d0025934 Reviewed-on: https://chromium-review.googlesource.com/c/1403913 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621494}
Changed files
- DEPS
-
Added a check for an selected image when toggling the editor
Changed by Alexander Nohe - noheohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 07:29:05 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1fc2f9b5f9298f5c509b80f6969d2951c96aeb5d Comments
Added a check for an selected image when toggling the editor This provides a non-null check for the assert call. When the assert call was being invoked with a null value, the edit mode was not being toggled. Adding this in should allow deleting a single image to toggle the edit mode to off. Bug: 912489 Change-Id: Ia4f6f4633f0856a031d1a22b15425daf68d96d12 Reviewed-on: https://chromium-review.googlesource.com/c/1404061 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#621493}
Changed files
- chrome/browser/chromeos/file_manager/gallery_browsertest.cc
- ui/file_manager/gallery/js/slide_mode.js
- ui/file_manager/integration_tests/gallery/photo_editor.js
-
Roll src/third_party/angle b5ba549abf2f..c05c141619a5 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Thursday, 10-Jan-19 07:09:29 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a7ba9fdf9b3caad8919ddd1e12321e9f0e51d1c4 Comments
Roll src/third_party/angle b5ba549abf2f..c05c141619a5 (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/b5ba549abf2f..c05c141619a5 git log b5ba549abf2f..c05c141619a5 --date=short --no-merges --format='%ad %ae %s' 2019-01-10 courtneygo@google.com Add validation layers to Android apk Created with: gclient setdep -r src/third_party/angle@c05c141619a5 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Iaff5165005d5e5fad422976056d1e2871e3cb841 Reviewed-on: https://chromium-review.googlesource.com/c/1403911 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621492}
Changed files
- DEPS
-
Stop using RTC_LOG and rtc::ConstantLabels machinery.
Changed by Mirko Bonadei - mbonadeiohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 07:08:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7732d36e9bb0b76fedb6e873b727a23efcb8ec03 Comments
Stop using RTC_LOG and rtc::ConstantLabels machinery. Instead of RTC_LOG, this CL switches libjingle_xmpp to DVLOG(1). This also removes a convoluted error message lookup machinery in third_party/libjingle_xmpp/xmpp/xmpplogintask.cc. Bug: 919085 Change-Id: Id8f24dd3a4907923c0c5d4ea2fee0a68d266d5bc Reviewed-on: https://chromium-review.googlesource.com/c/1397607 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#621491}
Changed files
- third_party/libjingle_xmpp/task_runner/task_unittest.cc
- third_party/libjingle_xmpp/xmpp/jid.cc
- third_party/libjingle_xmpp/xmpp/xmppclient.cc
- third_party/libjingle_xmpp/xmpp/xmpplogintask.cc
- third_party/libjingle_xmpp/xmpp/xmpplogintask.h
-
Deflake files app tests covering launching with volumes unmounted.
Changed by Sam McNally - sammcohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 07:01:18 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5a4a120922072e3e91cde73bad8c6d17565583c5 Comments
Deflake files app tests covering launching with volumes unmounted. Starting with volumes mounted and then unmounting them sometimes causes an uncaught exception while resolving the My Drive root. Avoid this by adding an option for files app tests to start without any volumes mounted and update the tests to add volumes as needed. Bug: 918808 Change-Id: I3f6fc59d097750d7b3d10c9ed227ff3a71ec2f17 Reviewed-on: https://chromium-review.googlesource.com/c/1404541 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#621490}
Changed files
- chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
- chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
- chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h
- ui/file_manager/integration_tests/file_manager/file_display.js