Builder Linux FYI Release (AMD R7 240) Build 2675
Results:
Failure webgl2_conformance_tests on ATI GPU on Linux on Ubuntu
Trigger Info:
Project | chromium |
Revision | 7fe0c80170d8f8b5848af1b5136588e497890d08 |
Got Revision | 7fe0c80170d8f8b5848af1b5136588e497890d08 |
Execution:
- Source: Task 42499a43f51f7e10
- Bot: swarm1080-c4
- Recipe: chromium
Steps and Logfiles:
Show:-
( 216 ms ) report buildersrunning tester 'Linux FYI Release (AMD R7 240)' on master 'chromium.gpu.fyi'
-
- - no logs -
-
( 1 secs ) read test spec (chromium.gpu.fyi.json)path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
-
( 458 ms ) lookup builder GN argsbuild_angle_gles1_conform_tests = truedcheck_always_on = trueffmpeg_branding = "Chrome"internal_gles2_conform_tests = trueis_component_build = falseis_debug = falseproprietary_codecs = truestrip_absolute_paths_from_debug_symbols = truesymbol_level = 1use_goma = truegoma_dir = "/b/swarming/w/ir/cache/goma/client"
-
- - no logs -
-
( 38 secs ) angle_unittests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Pending time: 14sShard duration: 21s
-
- - no logs -
-
( 939 ms ) test_pre_run.[trigger] angle_white_box_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 10 secs ) angle_white_box_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 7s
-
- - no logs -
-
( 943 ms ) test_pre_run.[trigger] tab_capture_end2end_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 27 secs ) tab_capture_end2end_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 23s
-
- - no logs -
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] gles2_conform_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
- - no logs -
-
( 846 ms ) test_pre_run.[trigger] swiftshader_unittests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 8 secs ) swiftshader_unittests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 4s
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] context_lost_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 3 mins 12 secs ) context_lost_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:03:07.901183Total tests: 10* Passed: 10 (10 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] depth_capture_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 31 secs ) depth_capture_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 24sTotal tests: 3* Passed: 3 (3 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 849 ms ) test_pre_run.[trigger] gpu_process_launch_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 2 mins 56 secs ) gpu_process_launch_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:02:50.479886Total tests: 15* Passed: 15 (15 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 959 ms ) test_pre_run.[trigger] hardware_accelerated_feature_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 25 secs ) hardware_accelerated_feature_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 23sTotal tests: 2* Passed: 2 (2 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] info_collection_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 25 secs ) info_collection_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 21sTotal tests: 1* Passed: 1 (1 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 35 secs ) maps_pixel_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 32sTotal tests: 1* Passed: 1 (1 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 10 mins 22 secs ) pixel_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:10:10.601839Total tests: 55* Passed: 55 (55 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] screenshot_sync_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 1 mins 14 secs ) screenshot_sync_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:01:12.360524Total tests: 4* Passed: 4 (4 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 5 mins 12 secs ) trace_test on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Shard duration: 0:05:05.737976Total tests: 48* Passed: 24 (24 expected, 0 unexpected)* Skipped: 24 (24 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 10 secs ) test_pre_run.[trigger] webgl2_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 2 hrs 9 mins ) webgl2_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Max pending time: 2:02:17.668811 (shard #19)Max shard duration: 0:07:01.890731 (shard #4)Min shard duration: 0:05:31.110018 (shard #7)Total tests: 2803* Passed: 2735 (2735 expected, 0 unexpected)* Skipped: 67 (67 expected, 0 unexpected)* Failed: 1 (0 expected, >>>1 unexpected<<<)* Flaky: 0 (0 expected, 0 unexpected)Unexpected Failures:* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_uniforms_incompatible_texture_type_for_sampler
- stdout
- json.output
- swarming.summary
- Merge script log
- outdir_json
- step_metadata
- shard #0 isolated out
- shard #0 (363.8 sec)
- shard #1 isolated out
- shard #1 (342.8 sec)
- shard #2 isolated out
- shard #2 (345.9 sec)
- shard #3 isolated out
- shard #3 (370.0 sec)
- shard #4 isolated out
- shard #4 (415.4 sec)
- shard #5 isolated out
- shard #5 (397.8 sec)
- shard #6 isolated out
- shard #6 (397.9 sec)
- shard #7 isolated out
- shard #7 (324.0 sec)
- shard #8 isolated out
- shard #8 (378.0 sec)
- shard #9 isolated out
- shard #9 (352.2 sec)
- shard #10 isolated out
- shard #10 (408.5 sec)
- shard #11 isolated out
- shard #11 (367.0 sec)
- shard #12 isolated out
- shard #12 (382.0 sec)
- shard #13 isolated out
- shard #13 (337.8 sec)
- shard #14 isolated out
- shard #14 (failed) (360.7 sec)
- shard #15 isolated out
- shard #15 (378.2 sec)
- shard #16 isolated out
- shard #16 (380.3 sec)
- shard #17 isolated out
- shard #17 (349.6 sec)
- shard #18 isolated out
- shard #18 (401.6 sec)
- shard #19 isolated out
- shard #19 (400.7 sec)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] webgl_conformance_gl_passthrough_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 8 mins 18 secs ) webgl_conformance_gl_passthrough_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Max pending time: 0:02:09.491641 (shard #1)Max shard duration: 0:05:58.721506 (shard #1)Min shard duration: 0:02:06.417542 (shard #0)Total tests: 938* Passed: 932 (932 expected, 0 unexpected)* Skipped: 6 (6 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] webgl_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'
-
( 9 mins 15 secs ) webgl_conformance_tests on ATI GPU on Linux on UbuntuRun on OS: 'Ubuntu'Max pending time: 0:02:13.490941 (shard #1)Max shard duration: 0:06:46.294659 (shard #1)Min shard duration: 0:02:11.033506 (shard #0)Total tests: 938* Passed: 932 (932 expected, 0 unexpected)* Skipped: 6 (6 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm1080-c4" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547006687529582, "id": "8924839631576044320", "project": "chromium", "tags": ["builder:Linux FYI Release (AMD R7 240)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/7fe0c80170d8f8b5848af1b5136588e497890d08", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Linux Builder", "parent_buildnumber:38384", "scheduler_invocation_id:9090269693676626832", "scheduler_job_id:chromium/Linux FYI Release (AMD R7 240)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "Linux FYI Release (AMD R7 240)" | setup_build |
buildnumber | 2675 | setup_build |
mastername | "chromium.gpu.fyi" | setup_build |
parent_buildername | "GPU FYI Linux Builder" | setup_build |
parent_got_angle_revision | "29b4941737bc2ad101b0899cf18c42f0800e9ec1" | setup_build |
parent_got_buildtools_revision | "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" | setup_build |
parent_got_dawn_revision | "5236eb20579eb2abe7ead762643681061693a4f7" | setup_build |
parent_got_nacl_revision | "1ea07c56ac9b57c30eb784ab2af582af0cdd4b08" | setup_build |
parent_got_revision | "7fe0c80170d8f8b5848af1b5136588e497890d08" | setup_build |
parent_got_revision_cp | "refs/heads/master@{#621037}" | setup_build |
parent_got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | setup_build |
parent_got_v8_revision | "1094debb3d6ee09c6ec02dd7b126e5411fa86fba" | setup_build |
parent_got_v8_revision_cp | "refs/heads/7.3.343@{#1}" | setup_build |
parent_got_webrtc_revision | "455d27c49abfff587babed348ae90f1aba75969e" | setup_build |
parent_got_webrtc_revision_cp | "refs/heads/master@{#26158}" | setup_build |
parent_mastername | "chromium.gpu.fyi" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
revision | "7fe0c80170d8f8b5848af1b5136588e497890d08" | setup_build |
swarm_hashes | {"angle_end2end_tests": "e2f71c40c66dd872f8e0229eb5914dfcac1d646d", "angle_perftests": "fa4c2a132da0c09414ec29442f56e87dc0be3653", "angle_unittests": "da29f852344cd232187dff96e00ce61b726c560f", "angle_white_box_tests": "e5fc385904f2b8ee7824105b956d78b063910814", "browser_tests": "5997b84b6158078ad84b2a48d9936833a12b41ad", "dawn_end2end_tests": "f49f6c3a53a92f6937aecb643d51723a840322c4", "gl_tests": "28ea84a6046103102532b3d15b3adc630da46a75", "gl_unittests": "5884c0511adddac3d68925ba6319c453b3c9881b", "gles2_conform_test": "d68dc0fd1dd4a9f9a3a880803c3f686818b72b31", "swiftshader_unittests": "739c0ded84a704cebeea1e1ac1deec9e7e887bf5", "telemetry_gpu_integration_test": "77c79aaef347211eea9073c1191dc4aa6d9d9b26"} | setup_build |
got_angle_revision | "29b4941737bc2ad101b0899cf18c42f0800e9ec1" | bot_update |
got_buildtools_revision | "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" | bot_update |
got_dawn_revision | "5236eb20579eb2abe7ead762643681061693a4f7" | bot_update |
got_nacl_revision | "1ea07c56ac9b57c30eb784ab2af582af0cdd4b08" | bot_update |
got_revision | "7fe0c80170d8f8b5848af1b5136588e497890d08" | bot_update |
got_revision_cp | "refs/heads/master@{#621037}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "1094debb3d6ee09c6ec02dd7b126e5411fa86fba" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.343@{#1}" | bot_update |
got_webrtc_revision | "455d27c49abfff587babed348ae90f1aba75969e" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26158}" | bot_update |
swarm_hashes | {} | find isolated tests |
Blamelist:
- Taylor Bergquist (tbergquistohnoyoudont@chromium.org)
- Andrey Kosyakov (caseqohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- David Tseng (dtsengohnoyoudont@chromium.org)
- John Lee (johntleeohnoyoudont@chromium.org)
- Kent Tamura (tkentohnoyoudont@chromium.org)
- Navid Zolghadr (nzolghadrohnoyoudont@chromium.org)
- Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
- Matt Wolenetz (wolenetzohnoyoudont@chromium.org)
- Kenneth Russell (kbrohnoyoudont@chromium.org)
- Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
- Bo Liu (boliuohnoyoudont@chromium.org)
- Dominick Ng (dominicknohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Xiyuan Xia (xiyuanohnoyoudont@chromium.org)
- Wez (wezohnoyoudont@chromium.org)
- Takumi Fujimoto (takumifohnoyoudont@chromium.org)
- Bruce Dawson (brucedawsonohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- David Grogan (dgroganohnoyoudont@chromium.org)
- James Darpinian (jdarpinianohnoyoudont@chromium.org)
- Hiroshige Hayashizaki (hiroshigeohnoyoudont@chromium.org)
- Tarun Bansal (tbansalohnoyoudont@chromium.org)
- Victor Costan (pwnallohnoyoudont@chromium.org)
- Kyle Milka (kmilkaohnoyoudont@chromium.org)
- Alexei Filippov (alphohnoyoudont@chromium.org)
- Tien Mai (tienmaiohnoyoudont@chromium.org)
- Ryo Hashimoto (hashimotoohnoyoudont@chromium.org)
- Kent Tamura (tkentohnoyoudont@chromium.org)
- Peter Boström (pbosohnoyoudont@chromium.org)
- CJ DiMeglio (lethalantidoteohnoyoudont@chromium.org)
- Zhenyao Mo (zmoohnoyoudont@chromium.org)
- Hiroki Nakagawa (nhirokiohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Dana Fried (dfriedohnoyoudont@chromium.org)
- Kevin Strohbehn (ginkoohnoyoudont@google.com)
- Christopher Thompson (cthompohnoyoudont@chromium.org)
- Daniel Rubery (druberyohnoyoudont@chromium.org)
- Simon Que (squeohnoyoudont@google.com)
- Chase Phillips (cmpohnoyoudont@chromium.org)
- Ayu Ishii (ayuiohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Matthew Denton (mpdentonohnoyoudont@chromium.org)
- Vlad Tsyrklevich (vtsyrklevichohnoyoudont@chromium.org)
- Peter Kotwicz (pkotwiczohnoyoudont@chromium.org)
- Vlad Tsyrklevich (vtsyrklevichohnoyoudont@chromium.org)
- Ahmed Fakhry (afakhryohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Hajime Hoshi (hajimehoshiohnoyoudont@chromium.org)
- Matt Falkenhagen (falkenohnoyoudont@chromium.org)
- Brian Norris (briannorrisohnoyoudont@chromium.org)
- Mike Dougherty (michaeldoohnoyoudont@chromium.org)
- Cathy Li (chiliohnoyoudont@chromium.org)
- v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
- chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
- Yuki Awano (yawanoohnoyoudont@chromium.org)
- Kenneth Russell (kbrohnoyoudont@chromium.org)
- Karan Bhatia (karandeepbohnoyoudont@chromium.org)
- Michael Spang (spangohnoyoudont@chromium.org)
- khmel@chromium.org (khmelohnoyoudont@chromium.org)
- Peter Kasting (pkastingohnoyoudont@chromium.org)
- Hajime Hoshi (hajimehoshiohnoyoudont@chromium.org)
- dstockwell (dstockwellohnoyoudont@google.com)
- David Jacobo (djacoboohnoyoudont@chromium.org)
- Hajime Hoshi (hajimehoshiohnoyoudont@chromium.org)
- Noel Gordon (noelohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Noel Gordon (noelohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Mei Liang (meiliangohnoyoudont@chromium.org)
- Alan Cutter (alancutterohnoyoudont@chromium.org)
- Vladislav Kaznacheev (kaznacheevohnoyoudont@google.com)
- Noel Gordon (noelohnoyoudont@chromium.org)
Timing:
Create | Wednesday, 09-Jan-19 04:04:47 UTC |
Start | Wednesday, 09-Jan-19 04:04:52 UTC |
End | Wednesday, 09-Jan-19 07:01:33 UTC |
Pending | 4 secs |
Execution | 2 hrs 56 mins |
All Changes:
-
Implement tab context menu option to add tab(s) to new group.
Changed by Taylor Bergquist - tbergquistohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 03:47:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7fe0c80170d8f8b5848af1b5136588e497890d08 Comments
Implement tab context menu option to add tab(s) to new group. go/chrome-tab-groups-design This CL is part of the prototype of the above-described tab groups feature. The prototype will allow users to create and manipulate groups primarily via tab context menus, and will display tab group affiliation in the tabstrip. Future work will include persisting and syncing groups, manipulating groups via tab dragging, and a dropdown menu for the group headers. Adds a new class, TabGroupData, to model a tab group, and an association between tabs and their groups in TabStripModel via a new field in WebContentsData. Adds a new entry to the tab's context menu to add the tab(s) to a new group. Bug: 905491 Change-Id: I0bccd90326c822fbca92e8544051995ea291a332 Reviewed-on: https://chromium-review.googlesource.com/c/1362435 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#621037}
Changed files
- chrome/app/generated_resources.grd
- chrome/app/generated_resources_grd/IDS_TAB_CXMENU_ADD_TAB_TO_NEW_GROUP.png.sha1
- chrome/browser/ui/BUILD.gn
- chrome/browser/ui/tabs/tab_group_data.cc
- chrome/browser/ui/tabs/tab_group_data.h
- chrome/browser/ui/tabs/tab_menu_model.cc
- chrome/browser/ui/tabs/tab_strip_model.cc
- chrome/browser/ui/tabs/tab_strip_model.h
- chrome/browser/ui/tabs/tab_strip_model_unittest.cc
- tools/metrics/actions/actions.xml
-
DevTools: fix reporting of request timing when overriding response for redirected request
Changed by Andrey Kosyakov - caseqohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 03:47:05 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8884b55805554dd4391bf61a58ae550718dd5802 Comments
DevTools: fix reporting of request timing when overriding response for redirected request Change-Id: I9fb06288bc615968aff95f67bb662b607d4ecb8f Reviewed-on: https://chromium-review.googlesource.com/c/1401458 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#621036}
Changed files
- content/browser/devtools/devtools_url_loader_interceptor.cc
- third_party/blink/web_tests/http/tests/inspector-protocol/network/interception-redirect-timing-expected.txt
- third_party/blink/web_tests/http/tests/inspector-protocol/network/interception-redirect-timing.js
-
Roll src/third_party/depot_tools da90c53e3db0..118bb44e1443 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 09-Jan-19 03:43:32 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e8351788d8a3f30eb008d8ff2b96fb30916a2610 Comments
Roll src/third_party/depot_tools da90c53e3db0..118bb44e1443 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/da90c53e3db0..118bb44e1443 git log da90c53e3db0..118bb44e1443 --date=short --no-merges --format='%ad %ae %s' 2019-01-09 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@118bb44e1443 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I0aeffaa744182fdf08c08c49042d0de08f100b01 Reviewed-on: https://chromium-review.googlesource.com/c/1401388 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621035}
Changed files
- DEPS
-
Reland: Migrate LibLouis to web assembly
Changed by David Tseng - dtsengohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 03:40:15 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9b9ad8e3604112d69fe58ad34a16384dc24a0f63 Comments
Reland: Migrate LibLouis to web assembly The failing two memory sanitizer tests were disabled. This is a javascript component. TBR=dtseng@chromium.org Original commit: This change ports the LibLouis C++ library from Native Client to web assembly. Major changes: - the js-wrapper has been re-written (liblouis_wrapper.js) and the protocol with liblouis.js is slightly changed. - liblouis itself has been upgraded to v3.2. - table changes have occurred resulting in removal of some tables (e.g. there is now unified French braille which supplants other French tables). This change only removes the impacted tables with a follow up to add all new tables. - liblouis.js was simplified. Bug: 918730 Test: existing unit tests. Change-Id: If67ee266c39caeab00ea56fdbd3ee0f675809aae Reviewed-on: https://chromium-review.googlesource.com/c/1393785 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Zachary Kuznia <zork@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#620489} Reviewed-on: https://chromium-review.googlesource.com/c/1401049 Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#621034}
Changed files
- DEPS
- chrome/browser/resources/chromeos/chromevox/braille/braille_table_test.extjs
- chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager.js
- chrome/browser/resources/chromeos/chromevox/braille/liblouis.js
- chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs
- chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs
- chrome/test/BUILD.gn
- chrome/test/data/chromeos/liblouis_wasm/manifest.json
- chrome/test/data/chromeos/liblouis_wasm/test.js
- third_party/liblouis/BUILD.gn
- third_party/liblouis/README.chromium
- third_party/liblouis/nacl_wrapper/liblouis_instance.cc
- third_party/liblouis/nacl_wrapper/liblouis_instance.h
- third_party/liblouis/nacl_wrapper/liblouis_module.cc
- third_party/liblouis/nacl_wrapper/liblouis_module.h
- third_party/liblouis/nacl_wrapper/liblouis_wrapper.cc
- third_party/liblouis/nacl_wrapper/liblouis_wrapper.h
- third_party/liblouis/nacl_wrapper/translation_params.h
- third_party/liblouis/nacl_wrapper/translation_result.h
- third_party/liblouis/tables.json
- third_party/liblouis/wasm/DEPS
- third_party/liblouis/wasm/liblouis_wasm.data
- third_party/liblouis/wasm/liblouis_wasm.js
- third_party/liblouis/wasm/liblouis_wasm.wasm
- third_party/liblouis/wasm/liblouis_wrapper.js
- third_party/liblouis/wasm/liblouis_wrapper_browsertest.cc
-
Settings WebUI: Add back line between rows in Printers page
Changed by John Lee - johntleeohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 03:32:48 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4747b6ba46d14ec3523b0169d27612eb1fd619df Comments
Settings WebUI: Add back line between rows in Printers page Bug: 919390 Change-Id: I2fcfc0020a4f5956544aea1d93641adbe63e98e1 Reviewed-on: https://chromium-review.googlesource.com/c/1399706 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#621033}
Changed files
- chrome/browser/resources/settings/printing_page/printing_page.html
-
custom-elements: Introduce blink::CustomElementReactionFactory
Changed by Kent Tamura - tkentohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 03:28:15 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 246513c025779dae8bf92e359172609610f4dae6 Comments
custom-elements: Introduce blink::CustomElementReactionFactory This CL makes the code simpler by merging all subclasses of CustomElementReaction into a single file. It makes adding new callback easier. This CL has no behavior changes. Change-Id: Iac003ac38e0e3353391cabfe87750e020247d88b Reviewed-on: https://chromium-review.googlesource.com/c/1401823 Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#621032}
Changed files
- third_party/blink/renderer/core/html/BUILD.gn
- third_party/blink/renderer/core/html/custom/custom_element.cc
- third_party/blink/renderer/core/html/custom/custom_element_adopted_callback_reaction.cc
- third_party/blink/renderer/core/html/custom/custom_element_adopted_callback_reaction.h
- third_party/blink/renderer/core/html/custom/custom_element_attribute_changed_callback_reaction.cc
- third_party/blink/renderer/core/html/custom/custom_element_attribute_changed_callback_reaction.h
- third_party/blink/renderer/core/html/custom/custom_element_connected_callback_reaction.cc
- third_party/blink/renderer/core/html/custom/custom_element_connected_callback_reaction.h
- third_party/blink/renderer/core/html/custom/custom_element_definition.cc
- third_party/blink/renderer/core/html/custom/custom_element_disabled_state_changed_callback_reaction.cc
- third_party/blink/renderer/core/html/custom/custom_element_disabled_state_changed_callback_reaction.h
- third_party/blink/renderer/core/html/custom/custom_element_disconnected_callback_reaction.cc
- third_party/blink/renderer/core/html/custom/custom_element_disconnected_callback_reaction.h
- third_party/blink/renderer/core/html/custom/custom_element_form_associated_callback_reaction.cc
- third_party/blink/renderer/core/html/custom/custom_element_form_associated_callback_reaction.h
- third_party/blink/renderer/core/html/custom/custom_element_reaction_factory.cc
- third_party/blink/renderer/core/html/custom/custom_element_reaction_factory.h
-
Add caching for inner Element of hit test result
Changed by Navid Zolghadr - nzolghadrohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 03:25:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4e54c2daf3b067a77914e14fd4e0d2b6a6e95562 Comments
Add caching for inner Element of hit test result Change-Id: I6a876752d299947182030c61b26abde9b6178e88 Reviewed-on: https://chromium-review.googlesource.com/c/1400946 Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#621031}
Changed files
- third_party/blink/renderer/core/layout/hit_test_result.cc
- third_party/blink/renderer/core/layout/hit_test_result.h
-
SignedExchange: Verify if the response is cacheable by a shared cache
Changed by Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 03:20:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b48d800f43c97c277dfbe322365091454ee684d3 Comments
SignedExchange: Verify if the response is cacheable by a shared cache This implements the step 5 of [1]. Signed exchange is not valid if response is not cacheable by a shared cache. [1] https://wicg.github.io/webpackage/draft-yasskin-http-origin-signed-responses.html#cross-origin-trust Bug: 919414 Change-Id: I2ceef3c0e3899ae1b9bbe1e0bb644b601732cbe0 Reviewed-on: https://chromium-review.googlesource.com/c/1400422 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#621030}
Changed files
- content/browser/web_package/signed_exchange_envelope.cc
- content/browser/web_package/signed_exchange_envelope_unittest.cc
- third_party/blink/web_tests/external/wpt/signed-exchange/resources/generate-test-sxgs.sh
- third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg-noncacheable.sxg
- third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg-noncacheable.sxg.headers
- third_party/blink/web_tests/external/wpt/signed-exchange/sxg-noncacheable.tentative.html
-
MSE: Allow GC of inactive, unreferenced, HTMLME with MSE still attached
Changed by Matt Wolenetz - wolenetzohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 03:18:48 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f8109d5f3e9c233ec035f2baaba61c458a1ba909 Comments
MSE: Allow GC of inactive, unreferenced, HTMLME with MSE still attached This change is intended to reduce runtime memory usage in cases where inactive, unreferenced HTMLMediaElement connected to MediaSource API would never previously have been garbage collected. To enable their collection, this change allows HTMLME, MediaSource and SourceBuffer ::HasPendingActivity() methods to return false in cases where have no pending activity even though they might be connected/attached. On the Blink side, this CL includes upgrades from Member<> to TraceWrapperMember<> to keep wrappers for otherwise HasPendingActivity()==false objects alive when they are wrapper-traced from an alive object. Otherwise, event dispatch on them might fail even though they are still alive according to GC, for example. Note that an unrevoked MediaSource objectUrl can keep an otherwise unreferenced HTMLME+MSE collection of objects "alive" still. Comment is added accordingly for that case. BUG=881548 TEST=Manual tests confirmed GC of HTMLME+MSE occurs when references are dropped by JS and no work is pending; major upgrade of mediasource-htmlmediaelement-lifetime.html web test. Change-Id: I873d5408daca556fb375624e39347f5fa2fb3d55 Reviewed-on: https://chromium-review.googlesource.com/c/1383434 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#621029}
Changed files
- media/blink/websourcebuffer_impl.cc
- third_party/blink/renderer/core/html/media/html_media_element.cc
- third_party/blink/renderer/core/html/media/html_media_element.h
- third_party/blink/renderer/modules/mediasource/media_source.cc
- third_party/blink/renderer/modules/mediasource/media_source.h
- third_party/blink/renderer/modules/mediasource/source_buffer.cc
- third_party/blink/renderer/modules/mediasource/source_buffer.h
- third_party/blink/renderer/modules/mediasource/source_buffer_list.h
- third_party/blink/web_tests/http/tests/media/media-source/mediasource-htmlmediaelement-lifetime.html
-
Roll WebGL a2b3563..f22b9ad
Changed by Kenneth Russell - kbrohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 03:16:37 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 95f04483a1655984eb27ae004ee1ada05e4a73f1 Comments
Roll WebGL a2b3563..f22b9ad https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/a2b3563..f22b9ad Bug: 739604 Tbr: jdarpinian@chromium.org Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng Change-Id: I4292af75c9dae2ecd8afd34ac37f025addfb3349 Reviewed-on: https://chromium-review.googlesource.com/c/1401602 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#621028}
Changed files
- DEPS
- content/test/gpu/gpu_tests/webgl_conformance_revision.txt
-
[Fuchsia] Update Fuchsia layout tests port
Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 03:15:09 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6754ba20007550f953b4ef4a9ed5983baa51ac20 Comments
[Fuchsia] Update Fuchsia layout tests port Fuchsia layout tests port wasn't working with the current version of runner scripts (because they were not enabled on the bots). Update it and the runner scripts to make them compatible again. Bug: 778467 Change-Id: I54d214d4fbe8b808a5ff3f4e615913cbf66a5b3a Reviewed-on: https://chromium-review.googlesource.com/c/1396308 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#621027}
Changed files
- build/fuchsia/qemu_target.py
- build/fuchsia/remote_cmd.py
- build/fuchsia/target.py
- third_party/blink/tools/blinkpy/web_tests/port/fuchsia.py
-
aw: Add draw_fn implementation
Changed by Bo Liu - boliuohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 03:13:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 84f5a86e9381efa7b671bbe92604e9a709c39782 Comments
aw: Add draw_fn implementation Add a parallel AwDrawFnImpl class to AwGLFunctor. Main change for GL in draw_fn is destroy for RenderThreadManager happens on render thread. So relax and add more DCHECKs. Also switch webview_instrumentation_apk over to draw_fn which should exercise the new code path. Bug: 900965 Change-Id: I54e3faa17749e7cd249e4faa9abcfb616798b2e8 Reviewed-on: https://chromium-review.googlesource.com/c/1389021 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#621026}
Changed files
- android_webview/BUILD.gn
- android_webview/browser/aw_draw_fn_impl.cc
- android_webview/browser/aw_draw_fn_impl.h
- android_webview/browser/browser_view_renderer_unittest.cc
- android_webview/browser/render_thread_manager.cc
- android_webview/browser/render_thread_manager.h
- android_webview/browser/test/fake_window.cc
- android_webview/browser/test/fake_window.h
- android_webview/glue/java/src/com/android/webview/chromium/DrawFunctor.java
- android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
- android_webview/java/src/org/chromium/android_webview/AwContents.java
- android_webview/java/src/org/chromium/android_webview/AwDrawFnImpl.java
- android_webview/public/browser/draw_fn.h
- android_webview/test/BUILD.gn
- android_webview/test/shell/src/draw_gl/draw_fn.cc
- android_webview/test/shell/src/draw_gl/draw_gl.cc
- android_webview/test/shell/src/org/chromium/android_webview/shell/DrawFn.java
- android_webview/test/shell/src/org/chromium/android_webview/shell/DrawGL.java
- android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java
-
Remove requestAppBanner from the DevTools protocol.
Changed by Dominick Ng - dominicknohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 03:12:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 72cfd665f98e6ce700e9a59430283e4a566eb669 Comments
Remove requestAppBanner from the DevTools protocol. This CL removes the ability to request an app banner from DevTools. This follows the removal of the explicit link to trigger this action in https://crrev.com/c/1370371. Follow-up CLs will implement a new AppBannerManager::DryRun method which will be accessed by devtools in order to collect all errors from the installability check to surface to developers. BUG=915945 Change-Id: I2d95030965474ebb35d6f8882c1ff00eeeb6a29a Reviewed-on: https://chromium-review.googlesource.com/c/1393126 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#621025}
Changed files
- chrome/browser/android/tab_web_contents_delegate_android.cc
- chrome/browser/android/tab_web_contents_delegate_android.h
- chrome/browser/ui/browser.cc
- chrome/browser/ui/browser.h
- components/embedder_support/android/delegate/web_contents_delegate_android.cc
- components/embedder_support/android/delegate/web_contents_delegate_android.h
- content/browser/devtools/protocol/page_handler.cc
- content/browser/devtools/protocol/page_handler.h
- content/browser/devtools/protocol_config.json
- content/public/browser/web_contents_delegate.h
- third_party/blink/renderer/core/inspector/browser_protocol-1.2.json
- third_party/blink/renderer/core/inspector/browser_protocol-1.3.json
- third_party/blink/renderer/core/inspector/browser_protocol.pdl
- third_party/blink/renderer/core/inspector/inspector_protocol_config.json
- third_party/blink/renderer/devtools/BUILD.gn
- third_party/blink/renderer/devtools/front_end/inspector_main/RequestAppBannerActionDelegate.js
- third_party/blink/renderer/devtools/front_end/inspector_main/module.json
-
Roll src/third_party/catapult 3511bed44961..4ec170a7bb08 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 09-Jan-19 03:10:30 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5d914d559f58bae7399e184fb466944602ff2dad Comments
Roll src/third_party/catapult 3511bed44961..4ec170a7bb08 (1 commits) https://chromium.googlesource.com/catapult.git/+log/3511bed44961..4ec170a7bb08 git log 3511bed44961..4ec170a7bb08 --date=short --no-merges --format='%ad %ae %s' 2019-01-09 benjhayden@chromium.org Remove shortName from Histogram. Created with: gclient setdep -r src/third_party/catapult@4ec170a7bb08 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ibbef30b45fc3166d92958d6f035d2ba840c93639 Reviewed-on: https://chromium-review.googlesource.com/c/1401392 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621024}
Changed files
- DEPS
-
Fix Browser::OpenFile use-after-free
Changed by Xiyuan Xia - xiyuanohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 03:08:46 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4e75b7938e4738e14949d86cdbeb5cd43bef9b4a Comments
Fix Browser::OpenFile use-after-free Happened when clusterfuzz managed to invoke IDC_OPEN_FILE twice. Bug: 919800 Change-Id: I498c4792696ff508d853a78b63459d0237d39a5e Reviewed-on: https://chromium-review.googlesource.com/c/1401430 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#621023}
Changed files
- chrome/browser/ui/browser.cc
- chrome/browser/ui/browser.h
- chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc
-
Apply a default timeout to RunLoop::Run() calls on test main threads.
Changed by Wez - wezohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 03:07:03 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d9e4cb77324a3d4e0dfd6b599ce34e1224fdedb6 Comments
Apply a default timeout to RunLoop::Run() calls on test main threads. Sheriffs: This change is intended to expose tests which Run() for an excessive amount of time. Please consider disabling tests which hit the new Run() timeouts, rather than reverting this CL. We add RunLoop::ScopedRunTimeoutForTest, which configures the calling thread with a timeout, and optional callback, to apply to all Run() calls made while it is in-scope. If a Run() is not Quit() by the caller within the specified timeout then the loop is implicitly quit, and the optional callback is run, if provided. ScopedTaskEnvironment now applies a default ScopedRunTimeoutForTest set to invoke LOG(FATAL) if any Run() on the test's main thread runs for more than TestTimeouts::action_max_timeout(). Bug: 918724 Change-Id: I080b78e193202da0c9e3deee3a201ef1619cfd37 Reviewed-on: https://chromium-review.googlesource.com/c/1319344 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Albert J. Wong <ajwong@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#621022}
Changed files
- base/run_loop.cc
- base/run_loop.h
- base/run_loop_unittest.cc
- base/test/scoped_task_environment.cc
- base/test/scoped_task_environment.h
- base/test/scoped_task_environment_unittest.cc
- docs/threading_and_tasks.md
-
Add Cast domain to DevTools Protocol
Changed by Takumi Fujimoto - takumifohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 02:59:53 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4eb3b6e49aa880be6e71504a56719a778be26e82 Comments
Add Cast domain to DevTools Protocol Create a new DevTools domain "Cast", and add these functions: - setSinkToUse() - startTabMirroring() - stopCasting() - enable() - disable() And events: - sinksUpdated - issueUpdated They will be used by our swarming tests via ChromeDriver. This domain won't be accessible from the DevTools extension API. Design: https://docs.google.com/document/d/1KugGgS9P7qUkBE1oDPnSDhCoEpuiIE96QgSRWf9-bQY/edit Bug: 915056 Change-Id: Iee8ff5e7e7ef02d7750c6fe7f01d1d41a0e9c7f6 Reviewed-on: https://chromium-review.googlesource.com/c/1357282 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#621021}
Changed files
- chrome/browser/devtools/BUILD.gn
- chrome/browser/devtools/chrome_devtools_session.cc
- chrome/browser/devtools/chrome_devtools_session.h
- chrome/browser/devtools/inspector_protocol_config.json
- chrome/browser/devtools/protocol/cast_handler.cc
- chrome/browser/devtools/protocol/cast_handler.h
- chrome/browser/devtools/protocol/cast_handler_unittest.cc
- chrome/browser/media/router/media_router_dialog_controller.cc
- chrome/browser/media/router/media_router_dialog_controller.h
- chrome/browser/media/router/media_router_dialog_controller_unittest.cc
- chrome/browser/media/router/presentation/presentation_service_delegate_impl.cc
- chrome/browser/media/router/presentation/presentation_service_delegate_impl.h
- chrome/browser/ui/webui/media_router/media_router_dialog_controller_webui_impl_unittest.cc
- chrome/test/BUILD.gn
- third_party/blink/renderer/core/inspector/browser_protocol.pdl
- third_party/blink/web_tests/http/tests/devtools/agents-enable-disable.js
-
Clarify where to land //build changes
Changed by Bruce Dawson - brucedawsonohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 02:56:30 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 934c9e1517b2b59b42fadb8b9be74c9b45d17deb Comments
Clarify where to land //build changes Every few months somebody tries to land changes to the chromium build directory using the chromium/src/build repo. This change modifies README.md to make it clear than these changes should be made in chromium and they will then be automatically replicated out. Change-Id: I36b3310c3c8e274fbe90671157ae4edc1d8801d7 Reviewed-on: https://chromium-review.googlesource.com/c/1399443 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#621020}
Changed files
- build/README.md
-
Roll src/third_party/pdfium 6ce8e849e57d..d1d4bbff7871 (2 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 09-Jan-19 02:50:19 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 35f6b132979973bcb0ca1aaa4683cebbbd4daaf0 Comments
Roll src/third_party/pdfium 6ce8e849e57d..d1d4bbff7871 (2 commits) https://pdfium.googlesource.com/pdfium.git/+log/6ce8e849e57d..d1d4bbff7871 git log 6ce8e849e57d..d1d4bbff7871 --date=short --no-merges --format='%ad %ae %s' 2019-01-09 tsepez@chromium.org Remove fx_ucddata.{h,cpp} (part 3 of ucd cleanup) 2019-01-09 tsepez@chromium.org Cleanup fx_ucddata.cpp, part 2 Created with: gclient setdep -r src/third_party/pdfium@d1d4bbff7871 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If14947e246ef10b85c7a60fa553e14a61c2b4d3d Reviewed-on: https://chromium-review.googlesource.com/c/1401357 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621019}
Changed files
- DEPS
-
Roll src-internal 9e3e12d7ba9e..774de0424ad8 (6 commits)
Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com Changed at Wednesday, 09-Jan-19 02:50:01 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1406ef6d4a098be250450aec73c42d1294edf44d Comments
Roll src-internal 9e3e12d7ba9e..774de0424ad8 (6 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9e3e12d7ba9e..774de0424ad8 Created with: gclient setdep -r src-internal@774de0424ad8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8aad9e91f4288eb4f3734d8895aabcaca9ab2f93 Reviewed-on: https://chromium-review.googlesource.com/c/1401355 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621018}
Changed files
- DEPS
-
Roll src/third_party/chromite b0c021cb3082..843e78956652 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 09-Jan-19 02:49:09 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision aaef959e018f6ded42be9d4ca1782e16115c4a79 Comments
Roll src/third_party/chromite b0c021cb3082..843e78956652 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/b0c021cb3082..843e78956652 git log b0c021cb3082..843e78956652 --date=short --no-merges --format='%ad %ae %s' 2019-01-08 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@843e78956652 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4985440df8b0dd62924ceed1095e8cdfeb33f8a9 Reviewed-on: https://chromium-review.googlesource.com/c/1401390 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621017}
Changed files
- DEPS
-
Roll AFDO from 73.0.3664.0_rc-r1 to 73.0.3665.3_rc-r1
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 09-Jan-19 02:48:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1838ed6daaf31bd78aa5989c3678115cf37a853a Comments
Roll AFDO from 73.0.3664.0_rc-r1 to 73.0.3665.3_rc-r1 This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: If3824f174c05b79c2334d4844ae733a53b5840d2 Reviewed-on: https://chromium-review.googlesource.com/c/1401358 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621016}
Changed files
- chrome/android/profiles/newest.txt
-
Reland [LayoutNG] Calculate flex container intrinsic sizes
Changed by David Grogan - dgroganohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 02:46:57 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 99d8923f2015fbf90c100abda3a9989d4096119d Comments
Reland [LayoutNG] Calculate flex container intrinsic sizes The 7 tests marked Crash crash locally for me and crashed on the trybots but don't on one of the continuous builders[1], possibly that runs without DCHECK enabled. 5 of the tests failed and 2 passed. The failures surfaced as regressions, which got this patch reverted. So just go back to Skip. [1] https://test-results.appspot.com/data/layout_results/Linux_Tests/74761/webkit_layout_tests/layout-test-results/results.html TBR=mstensho@chromium.org Bug: 845235,920039 Change-Id: I3970b3fd77633240a21198358b3f1913022977f3 Reviewed-on: https://chromium-review.googlesource.com/c/1401673 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#621015}
Changed files
- third_party/blink/renderer/core/layout/ng/geometry/ng_box_strut.h
- third_party/blink/renderer/core/layout/ng/ng_flex_layout_algorithm.cc
- third_party/blink/renderer/core/layout/ng/ng_flex_layout_algorithm.h
- third_party/blink/web_tests/TestExpectations
-
gpu: Check that texture format matches sampler
Changed by James Darpinian - jdarpinianohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 02:46:54 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0fce45278dd0c9622984502bd7b427ae39dddd7b Comments
gpu: Check that texture format matches sampler This validation is required by the WebGL 2 spec and tested in conformance2/uniforms/incompatible-texture-type-for-sampler.html Bug: 809237 Change-Id: I288566e27ee17e4a38208f6ae8369dd40d31d8ef Reviewed-on: https://chromium-review.googlesource.com/c/1368832 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#621014}
Changed files
- content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
- gpu/command_buffer/service/gles2_cmd_decoder.cc
- gpu/command_buffer/service/texture_manager.cc
- gpu/command_buffer/service/texture_manager.h
-
[wpt/upgrade-insecure-requests] Fix generateRedirect()
Changed by Hiroshige Hayashizaki - hiroshigeohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 02:43:41 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision cdd159ca09d82ff0a3005f8318469dc210047c89 Comments
[wpt/upgrade-insecure-requests] Fix generateRedirect() |url| in generateRedirect() was string (not URL) and therefore generateRedirect() returned the same URL (|url| as-is) regardless of |host| or |protocol| parameters. Bug: 906850, 878274 Change-Id: I7134726e916854a829eaf7d348776a2b7b547c70 Reviewed-on: https://chromium-review.googlesource.com/c/1389029 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#621013}
Changed files
- third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/support/testharness-helper.sub.js
-
NQE: Enable experiment to use end-to-end RTT and signal strength
Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 02:42:43 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 749feb11c36ef8da21f3db4d8de9ac3eb4d69c7d Comments
NQE: Enable experiment to use end-to-end RTT and signal strength In network quality estimator, enable the experiment to use end-to-end RTT to adjust RTT value. Also, enable the experiment to use the signal strength when computing RTT sample weights. Change-Id: I6d59c2a40555af16765c2caa1ffad53e2e53cdcd Bug: 513681,834119 Reviewed-on: https://chromium-review.googlesource.com/c/1397430 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#621012}
Changed files
- net/nqe/network_quality_estimator_params.cc
- testing/variations/fieldtrial_testing_config.json
-
leveldb: Remove unused header include.
Changed by Victor Costan - pwnallohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 02:38:24 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6d83029b53d1036442601eccbfb7c61d64fbbf3c Comments
leveldb: Remove unused header include. Bug: None Change-Id: I4fd8bfa483a51e9a0faeab0c4961167b0e411ee3 Reviewed-on: https://chromium-review.googlesource.com/c/1400351 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#621011}
Changed files
- third_party/leveldatabase/port/port_chromium.h
-
[NTP] Remove custom backgrounds flag
Changed by Kyle Milka - kmilkaohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 02:38:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 285005f14d06fa764fb2475c30de4d6adbd03336 Comments
[NTP] Remove custom backgrounds flag Remove ntp custom backgrounds flag and all references to it. Bug: 905386 Change-Id: Ic7e782e113eadc7e2f40a06edd48eb625f98602c Reviewed-on: https://chromium-review.googlesource.com/c/1256242 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#621010}
Changed files
- chrome/browser/about_flags.cc
- chrome/browser/flag-metadata.json
- chrome/browser/flag_descriptions.cc
- chrome/browser/flag_descriptions.h
- chrome/browser/resources/local_ntp/custom_backgrounds.js
- chrome/browser/resources/local_ntp/local_ntp.js
- chrome/browser/search/background/ntp_background_service.cc
- chrome/browser/search/background/ntp_background_service.h
- chrome/browser/search/background/ntp_background_service_factory.cc
- chrome/browser/search/background/ntp_background_service_unittest.cc
- chrome/browser/search/instant_service.cc
- chrome/browser/search/instant_service_unittest.cc
- chrome/browser/search/local_ntp_source.cc
- chrome/browser/search/ntp_features.cc
- chrome/browser/search/ntp_features.h
- chrome/browser/ui/search/local_ntp_backgrounds_browsertest.cc
- chrome/browser/ui/search/ntp_user_data_logger.cc
- chrome/browser/ui/search/ntp_user_data_logger_unittest.cc
- chrome/test/data/local_ntp/custom_backgrounds_browsertest.js
- testing/variations/fieldtrial_testing_config.json
-
[heap profiler] Do not try to record allocations with NULL address.
Changed by Alexei Filippov - alphohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 02:37:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 85e0a26e197fc890afe9aaa387a46d04bef70f4f Comments
[heap profiler] Do not try to record allocations with NULL address. Sometimes RecordAlloc is called with NULL address. This is probably caused by failed allocations. Do not try to record a sample in this case. The hash set does not allow zero keys anyway. BUG=917476 Change-Id: Ie734c4343d8def7036ac670beb571b4d369490ae Reviewed-on: https://chromium-review.googlesource.com/c/1400819 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#621009}
Changed files
- base/sampling_heap_profiler/poisson_allocation_sampler.cc
-
Fix gpu-process no longer working on the winlogon desktop.
Changed by Tien Mai - tienmaiohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 02:32:14 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision da84f862bdc995167a23baba367e8badb7e4cdf7 Comments
Fix gpu-process no longer working on the winlogon desktop. The gpu process seems to now need access to the desktop for any kind of rendering (including normal browser pages). To give access to the winlogon desktop (which requires a process integrity of medium) we now set a delayed the integrity level for the gpu process if it is running under a winlogon desktop. This will allow the gpu process to access the desktop at startup and not crash. Bug: 898754 Change-Id: I8c7b1e1a9e43a904308408ccbb89ac01b85224ee Reviewed-on: https://chromium-review.googlesource.com/c/1392600 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#621008}
Changed files
- content/browser/gpu/gpu_process_host.cc
-
Run wayland-scanner as part of build
Changed by Ryo Hashimoto - hashimotoohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 02:30:53 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a64f758399d26a1c80ab0d3dfecee3abf0714305 Comments
Run wayland-scanner as part of build No longer need to run wayland-scanner manually. Add wayland_scanner as a target in third_party/wayland/BUILD.gn. Add wayland_protocol GN template. Try using the new template for aura-shell in components/exo/wayland/BUILD.gn BUG=908346 TEST=build && manually verified that the generated code is the same. Change-Id: Ia40e7800cec5b899a99cc010a88ff7d824747a52 Reviewed-on: https://chromium-review.googlesource.com/c/1375197 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#621007}
Changed files
- components/exo/wayland/BUILD.gn
- components/exo/wayland/clients/client_helper.h
- components/exo/wayland/protocol/BUILD.gn
- components/exo/wayland/public/BUILD.gn
- components/exo/wayland/public/aura-shell-client-protocol.h
- components/exo/wayland/public/aura-shell-protocol.c
- components/exo/wayland/public/aura-shell-server-protocol.h
- third_party/wayland/BUILD.gn
- third_party/wayland/README.chromium
- third_party/wayland/features.gni
- third_party/wayland/include/config.h
- third_party/wayland/wayland_protocol.gni
- third_party/wayland/wayland_scanner_wrapper.py
-
formdata event: Add FormDataEvent constructor and FormDataEventInit dictionary
Changed by Kent Tamura - tkentohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 02:28:57 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 176e6a37cb827f4e487846356421087f45949a9c Comments
formdata event: Add FormDataEvent constructor and FormDataEventInit dictionary Bug: 825684 Change-Id: I6560de355862add37e4aaff55bd58b175e1b608a Reviewed-on: https://chromium-review.googlesource.com/c/1401482 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#621006}
Changed files
- third_party/blink/renderer/core/core_idl_files.gni
- third_party/blink/renderer/core/html/forms/form_data_event.cc
- third_party/blink/renderer/core/html/forms/form_data_event.h
- third_party/blink/renderer/core/html/forms/form_data_event.idl
- third_party/blink/renderer/core/html/forms/form_data_event_init.idl
- third_party/blink/web_tests/external/wpt/html/dom/interfaces.https_exclude=(Document_Window_HTML._)-expected.txt
- third_party/blink/web_tests/external/wpt/html/semantics/forms/form-submission-0/FormDataEvent.window-expected.txt
-
Remove InkDropMask for views::Checkbox
Changed by Peter Boström - pbosohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 02:28:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 225e49786806971237388ee8dbf2ed7e8a186599 Comments
Remove InkDropMask for views::Checkbox By default inkdrops are masked to their focus-ring shape. The ink-drop ripple for Checkbox explodes outside its bounds and shouldn't be clipped by them. Bug: chromium:918828 Change-Id: Id90c266017c8e459374d00291217752cdeb2fc95 Reviewed-on: https://chromium-review.googlesource.com/c/1401614 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#621005}
Changed files
- ui/views/controls/button/checkbox.cc
- ui/views/controls/button/checkbox.h
-
Allow overflow container to be tab selectable again.
Changed by CJ DiMeglio - lethalantidoteohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 02:26:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ae96bb1b3036a26c3709b73c5c26d5c04e0b6b10 Comments
Allow overflow container to be tab selectable again. Because we had given the overflow container element a tab index of -1, it was causing the overflow menu to close on any interaction. Originally we had set the tab index to -1 to take care of some duplication issue in the aria readback, but we have found another solution for that here: https://chromium-review.googlesource.com/c/chromium/src/+/1401454 Bug: 919446 Change-Id: I9fdd794bc131bcd16d04d4fad95bdd366d7f6941 Reviewed-on: https://chromium-review.googlesource.com/c/1401842 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#621004}
Changed files
- third_party/blink/renderer/modules/media_controls/elements/media_control_input_element.cc
-
Sanity check program data returned by GL driver
Changed by Zhenyao Mo - zmoohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 02:25:47 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5f4d448792a554430ac9c8bb0f5d04f4c36f4e46 Comments
Sanity check program data returned by GL driver BUG=905509 TEST=bots R=piman@chromium.org Change-Id: I435a5ae0411dece6cc176391f20aad77e2f9bf73 Reviewed-on: https://chromium-review.googlesource.com/c/1396382 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#621003}
Changed files
- gpu/command_buffer/service/program_manager.cc
-
ServiceWorker: Rename WebServiceWorkerNetworkProviderForFrame to *ImplForFrame
Changed by Hiroki Nakagawa - nhirokiohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 02:25:36 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a40ab7e6acb5fc23ff76f8cddf0b3f7e6188af6b Comments
ServiceWorker: Rename WebServiceWorkerNetworkProviderForFrame to *ImplForFrame This is the follow-up CL for: https://chromium-review.googlesource.com/c/chromium/src/+/1391659 The motivation of this change is to clarify this is not a Blink's public interface (generally named with Web* prefix without *Impl suffix), and to make this aligned with other WebServiceWorkerNetworkProvider implementations (i.e., WebServiceWorkerNetworkProviderImpl and WebServiceWorkerNetworkProviderImplForWorker). Bug: n/a Change-Id: I07166a140a56b3ffa2454831cd5594979fa6ff14 Reviewed-on: https://chromium-review.googlesource.com/c/1399685 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#621002}
Changed files
- content/renderer/service_worker/service_worker_network_provider.cc
-
Roll src/third_party/SPIRV-Tools/src ee95ab15ce7a..df5bd2d05ac1 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 09-Jan-19 02:19:48 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6d1efd265f5869529700b8e77c8700d21e1e0faa Comments
Roll src/third_party/SPIRV-Tools/src ee95ab15ce7a..df5bd2d05ac1 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ee95ab15ce7a..df5bd2d05ac1 git log ee95ab15ce7a..df5bd2d05ac1 --date=short --no-merges --format='%ad %ae %s' 2019-01-09 dneto@google.com Permit UConvert spec-constant op for SPV_AMD_gpu_shader_int16 (#2264) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@df5bd2d05ac1 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4fb3b0e6bc2bcbc5ec944e88931fe89f651ce308 Reviewed-on: https://chromium-review.googlesource.com/c/1401389 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#621001}
Changed files
- DEPS
-
Suppress hotkey prompt when showing transient Zoom dialog.
Changed by Dana Fried - dfriedohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 02:14:40 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3334f0abc56e80bad442ecbce42a341f1a6ef25e Comments
Suppress hotkey prompt when showing transient Zoom dialog. Since the Zoom dialog disappears after a moment, instructing screen reader users to press ALT-SHIFT-A to refocus it is misleading, since it will likely be gone by the time they input the hotkey. There are other accessible ways to access the screen zoom, so this is not a problem. Bug: 920005 Change-Id: I42076474ade89c46eef68e1f6b30eb274c5efc82 Reviewed-on: https://chromium-review.googlesource.com/c/1401841 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#621000}
Changed files
- chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
- chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h
- chrome/browser/ui/views/location_bar/zoom_bubble_view.cc
-
Add ChromeVox support to search box autocomplete
Changed by Kevin Strohbehn - ginkoohnoyoudont@google.com Changed at Wednesday, 09-Jan-19 02:13:51 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 319662cac2d44d75dc56c5df9de39264e078e756 Comments
Add ChromeVox support to search box autocomplete Bug: 882621 Change-Id: Ica19fc45621c4a446b1a7b0feaaa0dd3222531f5 Reviewed-on: https://chromium-review.googlesource.com/c/1388289 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#620999}
Changed files
- ash/app_list/views/search_box_view.cc
- ash/app_list/views/search_box_view.h
- ui/strings/ui_strings.grd
-
Update testing config for Phase 3 of security indicator experiment
Changed by Christopher Thompson - cthompohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 02:11:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b9825eed8dec5ed348456e8b8200bcdc1e016be0 Comments
Update testing config for Phase 3 of security indicator experiment This updates the testing config to use the latest study name. Bug: 803138 Change-Id: Iee4095379f8fee52b90483f45011d7d7dffa237a Reviewed-on: https://chromium-review.googlesource.com/c/1401254 Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#620998}
Changed files
- testing/variations/fieldtrial_testing_config.json
-
Client side changes for AP download protection
Changed by Daniel Rubery - druberyohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 01:58:49 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2991238c37ab1cc28996a5eb0357a975b9a78e9f Comments
Client side changes for AP download protection This CL adds a boolean to ClientDownloadRequest indicating whether we should use the AP protections or not. It also adds a feature flag we can use for testing these protections. Bug: 917190 Change-Id: I4fc7ffc2a761f4339b3b2538be60b4232fd4d795 Reviewed-on: https://chromium-review.googlesource.com/c/1401239 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#620997}
Changed files
- chrome/browser/safe_browsing/download_protection/check_client_download_request.cc
- components/safe_browsing/features.cc
- components/safe_browsing/features.h
- components/safe_browsing/proto/csd.proto
- components/safe_browsing/web_ui/safe_browsing_ui.cc
-
infra: Fix mistake in job builder name
Changed by Simon Que - squeohnoyoudont@google.com Changed at Wednesday, 09-Jan-19 01:55:57 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 46380f562cd4063da8cb354ae3c29240d7785eaf Comments
infra: Fix mistake in job builder name It should match the job ID "... (dbg) (RBE)" Bug: 913372 Change-Id: Id327a33bd75fdf244124bb74884334cdeaf187fd Reviewed-on: https://chromium-review.googlesource.com/c/1399691 Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#620996}
Changed files
- infra/config/global/luci-scheduler.cfg
-
IndexedDB: Move IDBKeyRangeBuilder::Build to IDBKeyRange::Create
Changed by Chase Phillips - cmpohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 01:55:15 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision cc2104d49e6ec23e6806efbe5f2e2c050a7da981 Comments
IndexedDB: Move IDBKeyRangeBuilder::Build to IDBKeyRange::Create Bug: 717812 Change-Id: I851085136c1a40389719a29cc453ca6811b493a3 Reviewed-on: https://chromium-review.googlesource.com/c/1368310 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#620995}
Changed files
- third_party/blink/renderer/modules/indexeddb/BUILD.gn
- third_party/blink/renderer/modules/indexeddb/idb_key_range.h
- third_party/blink/renderer/modules/indexeddb/indexed_db_key_builder.cc
- third_party/blink/renderer/modules/indexeddb/indexed_db_key_builder.h
- third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
-
DevToolsFrontendHost::Create to return unique_ptr instead of raw pointer
Changed by Ayu Ishii - ayuiohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 01:54:53 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 55ed1ac4fc073bcfc9dc0538bd48455350d71c29 Comments
DevToolsFrontendHost::Create to return unique_ptr instead of raw pointer Bug: 916176 Change-Id: I86967df61ccd4e322319ba2544d6bc479ddea188 Reviewed-on: https://chromium-review.googlesource.com/c/1396614 Reviewed-by: Clark DuVall <cduvall@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#620994}
Changed files
- chrome/browser/devtools/devtools_ui_bindings.cc
- content/browser/devtools/devtools_frontend_host_impl.cc
- content/public/browser/devtools_frontend_host.h
- content/shell/browser/shell_devtools_bindings.cc
- content/shell/browser/web_test/devtools_protocol_test_bindings.cc
-
Roll Fuchsia SDK from defaf1abbeeb to d9de74028e2b
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 09-Jan-19 01:47:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision dcf00fbbc10d23a3b6b7dd3f08993d0e0fc83b37 Comments
Roll Fuchsia SDK from defaf1abbeeb to d9de74028e2b The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Idd171c916f05880956153936441b648527817916 Reviewed-on: https://chromium-review.googlesource.com/c/1401391 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#620993}
Changed files
- build/fuchsia/linux.sdk.sha1
- build/fuchsia/mac.sdk.sha1
-
Easier minimization for SQLite LPM Fuzzer
Changed by Matthew Denton - mpdentonohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 01:46:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 55a46db4d17608aca41a7016557d5cea064ae126 Comments
Easier minimization for SQLite LPM Fuzzer Adds support for turning off specific queries with an environment variable; makes it very easy to rule out a ton of irrelevant queries in a very short amount of time when minimizing a test case. R=metzman@chromium.org, pwnall@chromium.org Bug: 909886 Change-Id: Ia785a8d89cad415f791fd28cd498244358437898 Reviewed-on: https://chromium-review.googlesource.com/c/1388035 Reviewed-by: Jonathan Metzman <metzman@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#620992}
Changed files
- third_party/sqlite/BUILD.gn
- third_party/sqlite/fuzz/disabled_queries_parser.cc
- third_party/sqlite/fuzz/disabled_queries_parser.h
- third_party/sqlite/fuzz/sql_fuzzer.cc
- third_party/sqlite/fuzz/sql_multithreaded_fuzzer.cc
- third_party/sqlite/fuzz/sql_query_proto_to_string.cc
- third_party/sqlite/fuzz/sql_query_proto_to_string.h
-
base/allocator clean-ups
Changed by Vlad Tsyrklevich - vtsyrklevichohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 01:45:50 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1eda3c93e998e5d9be34f428dac54ecc7eaeb0dc Comments
base/allocator clean-ups No functional change. Change-Id: Icec05521d1e037200a48bca8b5a61dbaddb72099 Reviewed-on: https://chromium-review.googlesource.com/c/1394733 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#620991}
Changed files
- base/allocator/partition_allocator/PartitionAlloc.md
- base/allocator/winheap_stubs_win.cc
-
[Android WebAPK] Suppress strict mode exception when reading shared file
Changed by Peter Kotwicz - pkotwiczohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 01:44:26 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8a5928b282762119eddd5cc0b86178d1fe8790aa Comments
[Android WebAPK] Suppress strict mode exception when reading shared file This CL suppresses the strict mode exception in WebApkShareTargetUtil#computeMultipartPostData() when the shared file is read. BUG=None Change-Id: Ib0e97ec2f7638b2cc693a38039055b1b335db5b2 Reviewed-on: https://chromium-review.googlesource.com/c/1401503 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#620990}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkShareTargetUtil.java
-
GWP-ASan: Add macOS crash handler support
Changed by Vlad Tsyrklevich - vtsyrklevichohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 01:43:38 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 440a53892076a472b0c2e78b404a11bebc328134 Comments
GWP-ASan: Add macOS crash handler support Add a macOS implementation of CrashAnalyzer::GetAccessAddress() and some small tweaks to accomodate non-Windows platforms. Bug: 912286 Change-Id: I6e438c44ff4a11ec58ba57e2165e7fbf8eddf931 Reviewed-on: https://chromium-review.googlesource.com/c/1401615 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#620989}
Changed files
- components/gwp_asan/BUILD.gn
- components/gwp_asan/crash_handler/BUILD.gn
- components/gwp_asan/crash_handler/crash_analyzer_mac.cc
- components/gwp_asan/crash_handler/crash_handler_unittest.cc
-
Remove histograms from feedback reports
Changed by Ahmed Fakhry - afakhryohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 01:43:18 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ffc0bb9b43023c171f5669aba5eb1c2911062f36 Comments
Remove histograms from feedback reports Histograms data were added to the feedback reports long time ago, but they're uncommonly checked and no good use for them has been found, hence removed. BUG=915227 TEST=File a feedback report and make sure it ends up with no histogram data. Change-Id: Ie8e3540e7afa700ebf4b770c1cee7df729268081 Reviewed-on: https://chromium-review.googlesource.com/c/1401563 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#620988}
Changed files
- chrome/app/generated_resources.grd
- chrome/app/generated_resources_grd/IDS_FEEDBACK_INCLUDE_SYSTEM_INFORMATION_CHKBOX.png.sha1
- chrome/app/generated_resources_grd/IDS_FEEDBACK_INCLUDE_SYSTEM_INFORMATION_CHKBOX_ARC.png.sha1
- chrome/browser/extensions/api/feedback_private/chrome_feedback_private_delegate.cc
- chrome/browser/resources/feedback/js/feedback.js
- components/feedback/feedback_data.cc
- components/feedback/feedback_data.h
- components/feedback/feedback_data_unittest.cc
- extensions/browser/api/feedback_private/feedback_private_api.cc
- extensions/browser/api/feedback_private/feedback_private_api.h
- extensions/common/api/feedback_private.idl
-
Roll src/third_party/pdfium 45531b950b6a..6ce8e849e57d (2 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 09-Jan-19 01:42:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision bdd1b3328db35b550449f1780707d757eff75bb5 Comments
Roll src/third_party/pdfium 45531b950b6a..6ce8e849e57d (2 commits) https://pdfium.googlesource.com/pdfium.git/+log/45531b950b6a..6ce8e849e57d git log 45531b950b6a..6ce8e849e57d --date=short --no-merges --format='%ad %ae %s' 2019-01-08 thestig@chromium.org Fix a crash in FXSYS_wcstof(). 2019-01-08 thestig@chromium.org Avoid out of bounds access inside CFXJSE_ResolveProcessor::GetFilter(). Created with: gclient setdep -r src/third_party/pdfium@6ce8e849e57d The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1d5225b1322ac20c612a335f17f6df3d3e4c2761 Reviewed-on: https://chromium-review.googlesource.com/c/1401387 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#620987}
Changed files
- DEPS
-
Use per-frame task runners instead of per-thread task runners at pepper module
Changed by Hajime Hoshi - hajimehoshiohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 01:42:12 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5959c54fa966daba96b8b41d8741e651f0945cb0 Comments
Use per-frame task runners instead of per-thread task runners at pepper module This CL is based on Alexander's CL: https://chromium-review.googlesource.com/c/chromium/src/+/1367329 Bug: 870606 Change-Id: I2ca696efeb203d7cb48c9f33034163c2d9c6277d Reviewed-on: https://chromium-review.googlesource.com/c/1379607 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#620986}
Changed files
- content/renderer/pepper/host_dispatcher_wrapper.cc
- content/renderer/pepper/host_dispatcher_wrapper.h
- content/renderer/pepper/pepper_plugin_instance_impl.cc
- content/renderer/pepper/plugin_module.cc
- content/renderer/pepper/plugin_module.h
- content/renderer/render_frame_impl.cc
- ppapi/proxy/broker_dispatcher.cc
- ppapi/proxy/host_dispatcher.cc
- ppapi/proxy/host_dispatcher.h
- ppapi/proxy/plugin_dispatcher.cc
- ppapi/proxy/ppapi_proxy_test.cc
- ppapi/proxy/proxy_channel.cc
- ppapi/proxy/proxy_channel.h
-
canvas: Restore the data: URL special case for tainting.
Changed by Matt Falkenhagen - falkenohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 01:33:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 91ae23a52889d7d2e09b328de03918168a01f798 Comments
canvas: Restore the data: URL special case for tainting. CanvasRenderingContext::WouldTaintOrigin() had a special case for data URLs that was removed in r610498.[1] The assumption was that just calling CanvasImageSource::WouldTaintOrigin() would return false on data URLs. It turns out that function can return true due to a historical restriction on SVG foreign object nodes, as discussed in bug 294129. This CL reverses that behavior change, so data URLs again don't taint the canvas. It partially reverts r610498 and dependent change r613433. A WPT test is added. Chrome now passes the test despite bug 294129 being open because it has this special case for data URLs on canvas. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1347953 Bug: 294129, 918460 Change-Id: I7c8cb4d37d950693956785c291dfd7660c42e662 Reviewed-on: https://chromium-review.googlesource.com/c/1400433 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#620985}
Changed files
- third_party/blink/renderer/core/html/canvas/canvas_image_source.h
- third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc
- third_party/blink/renderer/core/html/canvas/image_element_base.cc
- third_party/blink/renderer/core/html/canvas/image_element_base.h
- third_party/blink/renderer/core/html/media/html_video_element.h
- third_party/blink/web_tests/external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_svg_image_with_foreign_object_does_not_taint.html
-
Create histogram for shill's attempts to connect to supplicant
Changed by Brian Norris - briannorrisohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 01:31:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9cabe959346e10ba92042b1997bcdcec93c2dbff Comments
Create histogram for shill's attempts to connect to supplicant We might retry setting up a WiFi device via WPA supplicant a few times. This adds a metric to count how many attempts are required before success -- or, if we give up, we report a "Max" attempt number to mean failure. Implemented in CL:1383253. Bug: 698457 Change-Id: I091f49ca112d0e48de83c6662088927db1b72c51 Reviewed-on: https://chromium-review.googlesource.com/c/1400263 Commit-Queue: Brian Norris <briannorris@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#620984}
Changed files
- tools/metrics/histograms/histograms.xml
-
[iOS] Translate Start and Stop Logging buttons on chrome://inspect page.
Changed by Mike Dougherty - michaeldoohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 01:29:12 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a2ec50cfcc12cdbe2ff160520e7b92acd509710a Comments
[iOS] Translate Start and Stop Logging buttons on chrome://inspect page. Although the notice at the top of the page was localized, translation entries were missing for the strings on the buttons themselves. Bug: 899851 Change-Id: I819aeee7ed7b776fc8a3c36f841e195a9a965133 Reviewed-on: https://chromium-review.googlesource.com/c/1401515 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#620983}
Changed files
- ios/chrome/app/resources/inspect/inspect.html
- ios/chrome/app/strings/ios_strings.grd
- ios/chrome/app/strings/ios_strings_grd/IDS_IOS_INSPECT_UI_CONSOLE_START_LOGGING.png.sha1
- ios/chrome/app/strings/ios_strings_grd/IDS_IOS_INSPECT_UI_CONSOLE_STOP_LOGGING.png.sha1
- ios/chrome/browser/ui/webui/inspect/inspect_ui.mm
-
[Explore Sites]: Schema change for personalization tables.
Changed by Cathy Li - chiliohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 01:28:09 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 51217e700c7157acf1966fcd33cf51cf9964c0d8 Comments
[Explore Sites]: Schema change for personalization tables. Bug: 918436 Change-Id: I9111d1c4763aee83242b6c45aaae986c73810aaa Reviewed-on: https://chromium-review.googlesource.com/c/1394389 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#620982}
Changed files
- chrome/browser/android/explore_sites/explore_sites_schema.cc
- chrome/browser/android/explore_sites/explore_sites_schema.h
- chrome/browser/android/explore_sites/explore_sites_schema_unittest.cc
- chrome/browser/android/explore_sites/explore_sites_types.h
- components/test/data/explore_sites/version_schemas/v1.data
- components/test/data/explore_sites/version_schemas/v1.sql
- components/test/data/explore_sites/version_schemas/v2.data
- components/test/data/explore_sites/version_schemas/v2.sql
-
Update V8 to version 7.3.343.
Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com Changed at Wednesday, 09-Jan-19 01:27:41 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a09a21bae4bd1f9177c3649a57dea1a2ed53e6b2 Comments
Update V8 to version 7.3.343. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dadf4cbe..1094debb Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idf6a6ff17a0443ab42d8fbb391585132896cab85 Reviewed-on: https://chromium-review.googlesource.com/c/1401426 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#620981}
Changed files
- DEPS
-
Roll src-internal 05b6bde0074d..9e3e12d7ba9e (5 commits)
Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com Changed at Wednesday, 09-Jan-19 01:26:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a836de25791e43ff5e3acd11c3c59a2905700543 Comments
Roll src-internal 05b6bde0074d..9e3e12d7ba9e (5 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/05b6bde0074d..9e3e12d7ba9e Created with: gclient setdep -r src-internal@9e3e12d7ba9e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic83f2377748966526b9bc43c1d70040421a97cbc Reviewed-on: https://chromium-review.googlesource.com/c/1401721 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#620980}
Changed files
- DEPS
-
Disable ChromeVox logging options by default
Changed by Yuki Awano - yawanoohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 01:23:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8f5c9061ce04e39895c79a07ee9b949838dfdaca Comments
Disable ChromeVox logging options by default options are disabled by default. Bug: 919757 Test: Open ChromeVox options page and confirm that all ChromeVox logging Change-Id: Ib143b77706fb4e4c312352f2ea6639030648522c Reviewed-on: https://chromium-review.googlesource.com/c/1399779 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#620979}
Changed files
- chrome/browser/resources/chromeos/chromevox/chromevox/background/prefs.js
-
Suppress oes-vertex-array-object on Linux/passthrough.
Changed by Kenneth Russell - kbrohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 01:20:08 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c5b459baa54d6f183d1d4c5b50fcb388035cd15f Comments
Suppress oes-vertex-array-object on Linux/passthrough. conformance/extensions/oes-vertex-array-object.html is occasionally rendering incorrect results for one sub-test on this configuration. Bug: 920033 No-Try: True Change-Id: I6db494ed4aff0f259e76c76c31048ad5e4097c7d Reviewed-on: https://chromium-review.googlesource.com/c/1400818 Reviewed-by: James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#620978}
Changed files
- content/test/gpu/gpu_tests/webgl_conformance_expectations.py
-
WebRequest: Extensions intercepting navigation requests don't need access to initiator.
Changed by Karan Bhatia - karandeepbohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 01:19:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 455363f3a2cf47eb04c13bc65cb80e72387d2252 Comments
WebRequest: Extensions intercepting navigation requests don't need access to initiator. This CL makes the following changes to the host permission model for the Web Request and Declarative Net Request APIs: - To intercept a navigation request (sub-frame or main-frame request), extensions don't need host permissions to the request initiator. They only need access to the request url. This is unlike sub-resource requests which need host permission to both the request url and initiator. - If an extension has access to a navigation request's initiator but it's access to the request url is withheld, the extension isn't implicitly granted access to the request. This is unlike sub-resource requests where the extension will be granted access. BUG=157736, 918137, 851722 Change-Id: I851bfbe79ea737b59934779367d581cdbb6c5297 Reviewed-on: https://chromium-review.googlesource.com/c/1396564 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#620977}
Changed files
- chrome/browser/extensions/api/declarative_net_request/declarative_net_request_browsertest.cc
- chrome/browser/extensions/api/web_request/web_request_apitest.cc
- chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc
- chrome/common/extensions/docs/templates/intros/declarativeNetRequest.html
- chrome/common/extensions/docs/templates/intros/webRequest.html
- extensions/browser/api/declarative_net_request/ruleset_manager.cc
- extensions/browser/api/declarative_webrequest/webrequest_action.cc
- extensions/browser/api/web_request/web_request_api.cc
- extensions/browser/api/web_request/web_request_event_details.cc
- extensions/browser/api/web_request/web_request_permissions.cc
- extensions/browser/api/web_request/web_request_permissions.h
- extensions/browser/api/web_request/web_request_permissions_unittest.cc
-
Fix chromium-style errors in v4l2_decode_surface_handler.h
Changed by Michael Spang - spangohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 01:19:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 605c81409282854868fb24ae94fe3a0cdd0518e4 Comments
Fix chromium-style errors in v4l2_decode_surface_handler.h In file included from ../../media/gpu/v4l2/v4l2_slice_video_decode_accelerator.cc:5: In file included from ../../media/gpu/v4l2/v4l2_slice_video_decode_accelerator.h:25: ../../media/gpu/v4l2/v4l2_decode_surface_handler.h:19:39: error: [chromium-style] Overriding method must be marked with 'override' or 'final'. virtual ~V4L2DecodeSurfaceHandler() = default; ^ override ../../media/gpu/v4l2/v4l2_decode_surface_handler.h:19:3: error: [chromium-style] 'virtual' will be redundant; 'override' implies 'virtual'. virtual ~V4L2DecodeSurfaceHandler() = default; ^~~~~~~~ 2 errors generated. Bug: none Test: compile with clang plugin Change-Id: Ib4ae031eec417508e44f7035c4a6450c08bd7c1d Reviewed-on: https://chromium-review.googlesource.com/c/1401622 Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#620976}
Changed files
- media/gpu/v4l2/v4l2_decode_surface_handler.h
-
app_sync: Implement feature to transfer app attributes.
Changed by khmel@chromium.org - khmelohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 01:06:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1ac5ea94795ae669caea477a299e8db70722d77f Comments
app_sync: Implement feature to transfer app attributes. This allows to transfer attributes (position, pin position and folder id) from one app to another app. This is to be used in case one app is migrating to another app and it is needed to preserve positions in shelf and app launcher. It is particular needed for migrating messages app. Usage example: app_list::AppListSyncableService const * app_service = app_list::AppListSyncableServiceFactory::GetForProfile(profile); app_service->TransferItemAttribute(kAppId1, kAppId2); BUG=TBD TEST=Manually for both modes. In one mode transfer attribute to the existing app and app immediately moved to the position in shelf and position and folder in App Launcher. Did the same but for non-existing app that was installed later. Unit test added. Change-Id: I00343e0acc0744b3f22bac0963f74cc14701e8fe Reviewed-on: https://chromium-review.googlesource.com/c/1396937 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#620975}
Changed files
- chrome/browser/ui/app_list/app_list_syncable_service.cc
- chrome/browser/ui/app_list/app_list_syncable_service.h
- chrome/browser/ui/app_list/app_list_syncable_service_unittest.cc
-
Rename BlendTowardOppositeLuma() to BlendTowardContrastingEndpoint().
Changed by Peter Kasting - pkastingohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 01:04:10 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4ba3d240849dad673869122004a3923db48335a2 Comments
Rename BlendTowardOppositeLuma() to BlendTowardContrastingEndpoint(). This is clearer, and now more accurate as well. Also add GetContrastingEndpoint() as a much more readable substitute for BlendTowardOppositeLuma(color, SK_AlphaOPAQUE). Bug: 659451 Change-Id: I62d818422aae1b1e96dc8578f2ac01e9eb6adef9 Reviewed-on: https://chromium-review.googlesource.com/c/1400060 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#620974}
Changed files
- chrome/browser/themes/theme_service.cc
- chrome/browser/ui/omnibox/omnibox_theme.cc
- chrome/browser/ui/sync/profile_signin_confirmation_helper.cc
- chrome/browser/ui/views/download/download_shelf_view.cc
- chrome/browser/ui/views/frame/glass_browser_frame_view.cc
- chrome/browser/ui/views/tabs/new_tab_button.cc
- chrome/browser/ui/views/toolbar/browser_actions_container.cc
- chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.cc
- ui/gfx/color_utils.cc
- ui/gfx/color_utils.h
- ui/views/controls/button/checkbox.cc
- ui/views/controls/button/md_text_button.cc
- ui/views/controls/focusable_border.cc
- ui/views/controls/progress_bar.cc
-
Revert "Simplify extension update check delay after browser start."
Changed by Hajime Hoshi - hajimehoshiohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 00:58:03 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c7a8a7c4f62192d78412a0260db02ab19cdd247c Comments
Revert "Simplify extension update check delay after browser start." This reverts commit 0a1b4fb27a194a6c4ec3fa22040a4e8152cd45bb. Reason for revert: This causes test failures on Mac build bot: crbug.com/920040 Original change's description: > Simplify extension update check delay after browser start. > > Bug: 907219 > Change-Id: I067fcb333b43f60441e1789cac8caf5b996b7e5d > Reviewed-on: https://chromium-review.googlesource.com/c/1344880 > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#620845} TBR=gab@chromium.org,rdevlin.cronin@chromium.org,waffles@chromium.org,bcwhite@chromium.org,poromov@chromium.org Change-Id: I8da444461a2a9c2c3a09abbe94a43bbd053d3b93 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 907219 Reviewed-on: https://chromium-review.googlesource.com/c/1401881 Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#620973}
Changed files
- chrome/browser/extensions/updater/extension_updater.cc
- chrome/browser/extensions/updater/extension_updater.h
- chrome/browser/extensions/updater/extension_updater_unittest.cc
- chrome/browser/extensions/updater/update_service_browsertest.cc
- chrome/browser/policy/policy_browsertest.cc
- chrome/browser/prefs/browser_prefs.cc
- extensions/browser/extension_prefs.cc
- extensions/browser/pref_names.cc
- extensions/browser/pref_names.h
- tools/metrics/histograms/histograms.xml
-
third_party/ink: Add build artifacts pulled from storage bucket
Changed by dstockwell - dstockwellohnoyoudont@google.com Changed at Wednesday, 09-Jan-19 00:56:13 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision bec9e7df4b7f552f34467e9436f942168bcfd1f8 Comments
third_party/ink: Add build artifacts pulled from storage bucket Bug: 766444,902646 Change-Id: Iaf4fbc0b893aff526e30ca941a27e97df5508741 Reviewed-on: https://chromium-review.googlesource.com/c/1395859 Commit-Queue: dstockwell <dstockwell@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#620972}
Changed files
- DEPS
- third_party/ink/.gitignore
- third_party/ink/README.chromium
- third_party/ink/build/ink_lib_binary.js.sha1
- third_party/ink/build/ink_lib_externs.js.sha1
- third_party/ink/build/wasm/glcore_base.js.sha1
- third_party/ink/build/wasm/glcore_base.wasm.sha1
- third_party/ink/build/wasm/glcore_wasm_bootstrap_compiled.js.sha1
-
Add expiration date to Arc.ShareFilesOnExit
Changed by David Jacobo - djacoboohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 00:55:10 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 73be9ca5e205ddc67230f12fba69105411cadc5b Comments
Add expiration date to Arc.ShareFilesOnExit This CL set an expiration date for Arc.ShareFilesOnExit to the end of M75, by then we can considerate either to prolongate the expiration of it or get rid of the code tracking this metric. Bug: b/112469474 Test: Build Change-Id: I91e15068871a0cd5225b34137258013f5c014e17 Reviewed-on: https://chromium-review.googlesource.com/c/1401506 Commit-Queue: David Jacobo <djacobo@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#620971}
Changed files
- tools/metrics/histograms/histograms.xml
-
Revert "[LayoutNG] Calculate flex container intrinsic sizes"
Changed by Hajime Hoshi - hajimehoshiohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 00:52:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c2d7130928c578cf9b68f7eaf192ae2ff4a228fb Comments
Revert "[LayoutNG] Calculate flex container intrinsic sizes" This reverts commit ca41baba579f7e0ec716cc09470ee222b1bd2f21. Reason for revert: This causes multiple layout test failures on some bots: crbug.com/920039 Original change's description: > [LayoutNG] Calculate flex container intrinsic sizes > > This is based off the old algorithm that legacy implements. The new > algorithm makes more sense but will have compat problems. > > Bug: 845235 > Change-Id: Ib4c115e9ad955ce6ab8a5fbcdd2d993feeebfd4f > Reviewed-on: https://chromium-review.googlesource.com/c/1389315 > Commit-Queue: David Grogan <dgrogan@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#620849} TBR=cbiesinger@chromium.org,dgrogan@chromium.org,mstensho@chromium.org Change-Id: I14cdf536035404693d11d656c09f19124d299fe2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 845235 Reviewed-on: https://chromium-review.googlesource.com/c/1401861 Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#620970}
Changed files
- third_party/blink/renderer/core/layout/ng/geometry/ng_box_strut.h
- third_party/blink/renderer/core/layout/ng/ng_flex_layout_algorithm.cc
- third_party/blink/renderer/core/layout/ng/ng_flex_layout_algorithm.h
- third_party/blink/web_tests/TestExpectations
-
Wrap IDS_FIND_IN_PAGE_COUNT placeholders in a <ph> element
Changed by Noel Gordon - noelohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 00:46:02 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b07863b47aebd4379734808db84322d8c71df525 Comments
Wrap IDS_FIND_IN_PAGE_COUNT placeholders in a <ph> element No-presubmit: true Bug: 919700 Change-Id: Ie46575ed09b6c86666d0858738cc60f2ee88029d Reviewed-on: https://chromium-review.googlesource.com/c/1399765 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#620969}
Changed files
- chrome/android/java/strings/android_chrome_strings.grd
-
Roll src/third_party/angle 988d9a068976..29b4941737bc (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 09-Jan-19 00:45:58 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 21d054d69dca4a67a7ca12d7af33e845acde11e8 Comments
Roll src/third_party/angle 988d9a068976..29b4941737bc (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/988d9a068976..29b4941737bc git log 988d9a068976..29b4941737bc --date=short --no-merges --format='%ad %ae %s' 2019-01-08 syoussefi@chromium.org Make copy texture test more extensive Created with: gclient setdep -r src/third_party/angle@29b4941737bc The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I5f7cf45e8b28ae17ad0d0693d94e187b6a60f549 Reviewed-on: https://chromium-review.googlesource.com/c/1401256 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#620968}
Changed files
- DEPS
-
Wrap IDS_DOWNLOAD_UI_FILES_DOWNLOADED placeholders in a <ph> element
Changed by Noel Gordon - noelohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 00:44:27 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision dbf9a8b458473516226c68267aa2abcc01f608a2 Comments
Wrap IDS_DOWNLOAD_UI_FILES_DOWNLOADED placeholders in a <ph> element No-presubmit: true Bug: 919700 Change-Id: I5ce055c15b8689048015fd2295d756814a7b3bb2 Reviewed-on: https://chromium-review.googlesource.com/c/1399683 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#620967}
Changed files
- chrome/android/java/strings/android_chrome_strings.grd
-
Roll src/third_party/skia f1202c61de08..c96fc37f230a (2 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 09-Jan-19 00:41:56 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 832d4ed87275b01e6b95db3e3c397f713828a403 Comments
Roll src/third_party/skia f1202c61de08..c96fc37f230a (2 commits) https://skia.googlesource.com/skia.git/+log/f1202c61de08..c96fc37f230a git log f1202c61de08..c96fc37f230a --date=short --no-merges --format='%ad %ae %s' 2019-01-08 michaelludwig@google.com Reland "Use specialized quad lists in rectangle ops" 2019-01-08 egdaniel@google.com Add ability to write out VkPipelineCache to gpu PersistentCache. Created with: gclient setdep -r src/third_party/skia@c96fc37f230a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:915025,chromium:917242 TBR=bsalomon@chromium.org Change-Id: I1840ac025711da9d47f2eb4d5552678f3f4f4533 Reviewed-on: https://chromium-review.googlesource.com/c/1401350 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#620966}
Changed files
- DEPS
-
Refresh expiration date for Tabs.Tasks.* histograms
Changed by Mei Liang - meiliangohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 00:37:53 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ac5b31d358c0e5755a9c769c91dff2975356b9ff Comments
Refresh expiration date for Tabs.Tasks.* histograms Bug: 911295 Change-Id: Ibd7b7c26ca6dce7ceb0725d53ea493e4bef9f03a Reviewed-on: https://chromium-review.googlesource.com/c/1400831 Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#620965}
Changed files
- tools/metrics/histograms/histograms.xml
-
RemoteMacViews: Strip language code out of language ID when setting locale
Changed by Alan Cutter - alancutterohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 00:36:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0322dd07e0faba527507505eed07782f5e7dd761 Comments
RemoteMacViews: Strip language code out of language ID when setting locale MacOS may return more than just the language code for the user's preferred language IDs. This CL removes the excess data so we can operate on just the preferred language code. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=372905&signed_aid=JtAfFDt-hrRQP2xuspyhxw==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=372906&signed_aid=d6YDIxqJ7JT0Q6kU6jd7Vw==&inline=1 Bug: 913345 Change-Id: I80225a5e3b6c12484e45a5a9b53a4d61fc85102a Reviewed-on: https://chromium-review.googlesource.com/c/1389477 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#620964}
Changed files
- chrome/app_shim/chrome_main_app_mode_mac.mm
-
Update shelf activity indicator for tabbed web app.
Changed by Vladislav Kaznacheev - kaznacheevohnoyoudont@google.com Changed at Wednesday, 09-Jan-19 00:35:17 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ec9110f4862deffb7419d0255d8bc273be7c9809 Comments
Update shelf activity indicator for tabbed web app. Currently when a tab activates/deactivates, the updated shelf id is written to the kShelfIDKey window property, but not used on the Ash side until a browser window activates/deactivates. Bug: 883130 Test: ash_unit_tests --gtest_filter=ShelfController* Change-Id: I0f167b41593abb57931f514ecea48ad547ea70cd Reviewed-on: https://chromium-review.googlesource.com/c/1401225 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#620963}
Changed files
- ash/shelf/shelf_controller_unittest.cc
- ash/shelf/shelf_window_watcher.cc
-
Wrap IDS_ACCESSIBILITY_TOOLBAR_BTN_TABSWITCHER_TOGGLE placeholders in a <ph> element
Changed by Noel Gordon - noelohnoyoudont@chromium.org Changed at Wednesday, 09-Jan-19 00:34:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e24ccf2862d7527f06006ec15d39f0741c669ece Comments
Wrap IDS_ACCESSIBILITY_TOOLBAR_BTN_TABSWITCHER_TOGGLE placeholders in a <ph> element Bug: 919700 Change-Id: I5d2bab64bcad711ce5d0cd324ed9e10e2a7777f9 Reviewed-on: https://chromium-review.googlesource.com/c/1399764 Reviewed-by: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#620962}
Changed files
- chrome/android/java/strings/android_chrome_strings.grd