Home | Search | chromium - Builders
Login

Builder Linux FYI Release (AMD R7 240) Build 1977 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision028fceebebe0743ddd7bb16dc8b753ae0f41a3f2
Got Revision028fceebebe0743ddd7bb16dc8b753ae0f41a3f2

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries
    • - no logs -

Build Properties:

NameValueSource

Blamelist:

  1. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  2. Patti (patricialorohnoyoudont@chromium.org)
  3. Yuki Yamada (yukiyohnoyoudont@google.com)
  4. Jinsuk Kim (jinsukkimohnoyoudont@chromium.org)
  5. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  6. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  7. Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
  8. Mohamed Amir Yosef (mamirohnoyoudont@chromium.org)
  9. Yuki Yamada (yukiyohnoyoudont@google.com)
  10. Kouhei Ueno (kouheiohnoyoudont@chromium.org)
  11. Justin Cohen (justincohenohnoyoudont@google.com)
  12. John Z Wu (jzwohnoyoudont@chromium.org)
  13. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  14. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  15. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
  16. Keiichi Watanabe (keiichiwohnoyoudont@chromium.org)
  17. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  18. Koji Ishii (kojiiohnoyoudont@chromium.org)
  19. Findit (findit-for-meohnoyoudont@appspot.gserviceaccount.com)
  20. Leon Han (leon.hanohnoyoudont@intel.com)
  21. Fergal Daly (fergalohnoyoudont@chromium.org)
  22. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  23. Tommy Steimel (steimelohnoyoudont@chromium.org)
  24. Gang Wu (gangwuohnoyoudont@chromium.org)
  25. Aga Wronska (agawronskaohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 06:26:15 UTC
Start Friday, 12-Oct-18 06:26:18 UTC
End Friday, 12-Oct-18 09:10:26 UTC
Pending 3 secs
Execution 2 hrs 44 mins

All Changes:

  1. Roll src/third_party/chromite 89e4bf93b1a1..e2727ef6f5dc (3 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 06:12:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 028fceebebe0743ddd7bb16dc8b753ae0f41a3f2

    Comments

    Roll src/third_party/chromite 89e4bf93b1a1..e2727ef6f5dc (3 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/89e4bf93b1a1..e2727ef6f5dc


git log 89e4bf93b1a1..e2727ef6f5dc --date=short --no-merges --format='%ad %ae %s'
2018-10-12 dgarrett@google.com builder_status_lib: Fix logging lint error.
2018-10-12 vapier@chromium.org paygen: paygen_payload_lib: convert to gs.LS
2018-10-12 vapier@chromium.org paygen: urilib_unittest: convert mox to mock


Created with:
  gclient setdep -r src/third_party/chromite@e2727ef6f5dc

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I2f3527661843ab9aafccf5f4f58b19fdde879453
Reviewed-on: https://chromium-review.googlesource.com/c/1278301
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599112}

    Changed files

    • DEPS

  2. Revert "[Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering."

    Changed by Patti - patricialorohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:10:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c2893ee9102687d16f2f65fa96651d8bd1fdab7

    Comments

    Revert "[Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering."

This reverts commit 86da6573944f302cf9df04d59a7e35bba895d059.

Reason for revert: This patch may be causing failures in browser_tests, on chromium.win/Win7 Tests (dbg)(1)
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29

Findit found culprit 598844 with 75% confidence, so reverting this to try and fix.

Original change's description:
> [Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering.
> 
> * The service shouldn't unregister from the topics, when handler
> the Handler is unregistering from topic (as stated in the documentation
> for for UnregisterHandler).
> * Sync shouldn't unregister on browser shutdown
> 
> Bug: 801985, 876274
> Change-Id: I857da7b0fbfa0a0f2e1ad05708cc24cdc9386a76
> Reviewed-on: https://chromium-review.googlesource.com/c/1196522
> Commit-Queue: Tatiana Gornak <melandory@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598844}

TBR=gab@chromium.org,pavely@chromium.org,melandory@chromium.org

Change-Id: I70fa87c3476925814408665644acb23c3c1f1614
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 801985, 876274, 894715
Reviewed-on: https://chromium-review.googlesource.com/c/1278273
Reviewed-by: Patti <patricialor@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599111}

    Changed files

    • chrome/browser/prefs/browser_prefs.cc
    • components/invalidation/impl/BUILD.gn
    • components/invalidation/impl/fcm_fake_invalidator.cc
    • components/invalidation/impl/fcm_invalidation_listener.cc
    • components/invalidation/impl/fcm_invalidation_listener.h
    • components/invalidation/impl/fcm_invalidation_service.cc
    • components/invalidation/impl/fcm_invalidation_service.h
    • components/invalidation/impl/fcm_invalidation_service_unittest.cc
    • components/invalidation/impl/invalidator_registrar.cc
    • components/invalidation/impl/invalidator_registrar.h
    • components/invalidation/impl/invalidator_registrar_with_memory.cc
    • components/invalidation/impl/invalidator_registrar_with_memory.h
    • components/sync/driver/glue/sync_backend_host_impl.cc

  3. Create v8::HandleScope in JSBasedEventListener::GetSourceLocation()

    Changed by Yuki Yamada - yukiyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 06:08:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f93617e5eb9f06935b07002223f33d164f517909

    Comments

    Create v8::HandleScope in JSBasedEventListener::GetSourceLocation()

This is the bug fixing for previous CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1253317

v8::HandleScope was not named.

Bug: 894069
Change-Id: Ib9111275bad434b1968a4bd674a0b8932b8c1533
Reviewed-on: https://chromium-review.googlesource.com/c/1278548
Commit-Queue: Yuki Yamada <yukiy@google.com>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599110}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc

  4. Android: Ensure single TabWebContentsObserver per Tab

    Changed by Jinsuk Kim - jinsukkimohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:07:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e0a45684f1cc9e125daed78cb74c7939415ebadc

    Comments

    Android: Ensure single TabWebContentsObserver per Tab

TabWebContentsObserver is TabWebContentsUserData which is created
for the first active WebContents for a given Tab, and finally
destroyed together with the Tab. There was a bug creating
multiple instances of the observer for every new active WebContents.
This left an instance for old WebContents undestroyed, and caused
a reported bug for already nulled out WebContents references
while handling an event that should not have been triggered.

This CL makes sure there will be a single TabWebContentsObserver
for Tab.

Bug: 894353
Change-Id: Ie2cbe5c79b4d1e9f68d1be045c4d7e88d91c5312
Reviewed-on: https://chromium-review.googlesource.com/c/1278426
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599109}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

  5. Roll src/third_party/webrtc 8f4bc41c4231..a54daf162fac (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 06:05:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9d4f9a68490476ebc67a19242ed76606d57aa853

    Comments

    Roll src/third_party/webrtc 8f4bc41c4231..a54daf162fac (2 commits)

https://webrtc.googlesource.com/src.git/+log/8f4bc41c4231..a54daf162fac


git log 8f4bc41c4231..a54daf162fac --date=short --no-merges --format='%ad %ae %s'
2018-10-11 benwright@webrtc.org Reland "Move CryptoOptions to api/crypto from rtc_base/sslstreamadapter.h"
2018-10-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9d052f4b6f..37b6d53f02 (598839:598967)


Created with:
  gclient setdep -r src/third_party/webrtc@a54daf162fac

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I3d22153c1dd390398aa7dda8a0f8a00d032fc627
Reviewed-on: https://chromium-review.googlesource.com/c/1278298
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599108}

    Changed files

    • DEPS

  6. Roll src-internal 09c355ef00f4..aebffd21b13f (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 05:52:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b8143822153ed2373d843fd588593070ed59894c

    Comments

    Roll src-internal 09c355ef00f4..aebffd21b13f (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09c355ef00f4..aebffd21b13f


Created with:
  gclient setdep -r src-internal@aebffd21b13f

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I816f02425f0557bf4030f14078bb453721cca6fe
Reviewed-on: https://chromium-review.googlesource.com/c/1278300
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599107}

    Changed files

    • DEPS

  7. Signed Exchange: Populate completion time for inner response

    Changed by Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 05:49:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cb0dee4694e580a614f5d380e0c60526cdfd2b90

    Comments

    Signed Exchange: Populate completion time for inner response

This fixes a bug where Resource Timing for prefetched Signed Exchange
had negative duration value.

Bug: 803774
Change-Id: I77006c803c12a6f645f2d5145a4e37e9321757f8
Reviewed-on: https://chromium-review.googlesource.com/c/1278546
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599106}

    Changed files

    • content/browser/web_package/signed_exchange_loader.cc
    • third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-prefetch-resource-timing.html

  8. [Sync::USS] Handle corrupted bookmarks metadata

    Changed by Mohamed Amir Yosef - mamirohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 05:42:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fb7986d88b0b8f174020916003d6939d2d928b83

    Comments

    [Sync::USS] Handle corrupted bookmarks metadata

At startup, the persisted sync metadata (if available) are loaded
and tracked.

This CL adds some integrity checks and makes sure that corrupted
metadata are ignored, and that Sync starts clean in such case.


Bug: 516866
Change-Id: Idf42cce2306f18a94941d40caa1816f737732156
Reviewed-on: https://chromium-review.googlesource.com/c/1274106
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599105}

    Changed files

    • components/sync_bookmarks/BUILD.gn
    • components/sync_bookmarks/DEPS
    • components/sync_bookmarks/bookmark_model_type_processor.cc
    • components/sync_bookmarks/bookmark_model_type_processor.h
    • components/sync_bookmarks/bookmark_model_type_processor_unittest.cc
    • components/sync_bookmarks/synced_bookmark_tracker.cc
    • components/sync_bookmarks/synced_bookmark_tracker.h
    • components/sync_bookmarks/synced_bookmark_tracker_unittest.cc

  9. Add a comment for backup_incumbent_scope in JSEventHandler::SetCompiledHandler()

    Changed by Yuki Yamada - yukiyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 05:38:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e151e38b3dabf71057cd3f303490937fbc24bad

    Comments

    Add a comment for backup_incumbent_scope in JSEventHandler::SetCompiledHandler()

This adds a comment for the previous change:
https://chromium-review.googlesource.com/c/chromium/src/+/1276406

Bug: 893951
Change-Id: Ib7a14eedb9922a03c0f6121205c55a9924a5fd7c
Reviewed-on: https://chromium-review.googlesource.com/c/1278070
Commit-Queue: Yuki Yamada <yukiy@google.com>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599104}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/js_event_handler.cc

  10. Implement SignedExchange.Prefetch UMAs

    Changed by Kouhei Ueno - kouheiohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 05:30:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 97df84454db873390762a20012a30407d6bd1ed5

    Comments

    Implement SignedExchange.Prefetch UMAs

Bug: 890180
Change-Id: I5de8d5b1bdb154455a59e5106ebcefd4973d5bcd
Reviewed-on: https://chromium-review.googlesource.com/c/1275746
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599103}

    Changed files

    • content/browser/loader/prefetch_url_loader_service.cc
    • content/browser/web_package/signed_exchange_loader.cc
    • content/browser/web_package/signed_exchange_prefetch_metric_recorder.cc
    • content/browser/web_package/signed_exchange_prefetch_metric_recorder.h
    • content/browser/web_package/signed_exchange_prefetch_metric_recorder_unittest.cc
    • content/browser/web_package/signed_exchange_request_handler_browsertest.cc
    • content/test/BUILD.gn
    • tools/metrics/histograms/histograms.xml

  11. [ios] Move FYI xcode-clang bot back to Xcode 10.

    Changed by Justin Cohen - justincohenohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 05:20:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1af4ddc196ec7424ff808b37f3ec67aa36577a0c

    Comments

    [ios] Move FYI xcode-clang bot back to Xcode 10.

This bot was erronously moved from Xcode 10 beta 4 all the way to Xcode 10.1
beta.  Now that Xcode 10 GM is in goma, roll to Xcode 10.

Note: This rolls to 10a254a, which is slightly different than the package
goma installed, but it has the same compiler (clang-1000.11.45.2) so it should
work the same.  If not, we'll have to investigate why and upload a new package
to CIPD.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I46e90d60eb562f69d1848df3ff48db3d82cf1cc1
Reviewed-on: https://chromium-review.googlesource.com/c/1278331
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599102}

    Changed files

    • ios/build/bots/chromium.fyi/ios12-sdk-xcode-clang.json

  12. Some fixes for sync:

    Changed by John Z Wu - jzwohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 05:16:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 877046da44d232fb9de9bcbaee249c83ff8b0d1e

    Comments

    Some fixes for sync:

1. Disable feature SyncUserConsentSeparateType for now.
2. Use ReloadCredentials since LoadCredentials DCHECKs and fix up the tests.

Bug: 867548
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I3a9af1b353b3138b411ee9fdab6cc67c447ee109
Reviewed-on: https://chromium-review.googlesource.com/c/1278471
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599101}

    Changed files

    • ios/web_view/BUILD.gn
    • ios/web_view/internal/sync/cwv_sync_controller.mm
    • ios/web_view/internal/sync/cwv_sync_controller_unittest.mm
    • ios/web_view/internal/web_view_web_main_parts.mm

  13. Roll src/third_party/angle c4533eae082f..671809e62e80 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 05:16:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 155a1c23d2f8953f50fcff84366cfaea19f0691e

    Comments

    Roll src/third_party/angle c4533eae082f..671809e62e80 (2 commits)

https://chromium.googlesource.com/angle/angle.git/+log/c4533eae082f..671809e62e80


git log c4533eae082f..671809e62e80 --date=short --no-merges --format='%ad %ae %s'
2018-10-12 jiajia.qin@intel.com ES31: Add vector and matrix support in SSBO for D3D
2018-10-12 jiajia.qin@intel.com ES31: Collect shader storage blocks info for d3d.


Created with:
  gclient setdep -r src/third_party/angle@671809e62e80

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: Ie918b1391ee226eb39be833dc7768cec9bdbee65
Reviewed-on: https://chromium-review.googlesource.com/c/1278299
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599100}

    Changed files

    • DEPS

  14. Roll src/third_party/chromite 9a72c51a329f..89e4bf93b1a1 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 05:06:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 86871d7222d501610f9de98a22fd8a41b495d0c3

    Comments

    Roll src/third_party/chromite 9a72c51a329f..89e4bf93b1a1 (1 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/9a72c51a329f..89e4bf93b1a1


git log 9a72c51a329f..89e4bf93b1a1 --date=short --no-merges --format='%ad %ae %s'
2018-10-12 derat@chromium.org chromeos_config: Run Tast on {amd64-generic,betty}-paladin.


Created with:
  gclient setdep -r src/third_party/chromite@89e4bf93b1a1

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I29f302fb260fcd75ce3d9d3b538f0eed2c2a1f21
Reviewed-on: https://chromium-review.googlesource.com/c/1278493
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599099}

    Changed files

    • DEPS

  15. CrOS FilesApp: refactor only: split out crostini UI tests

    Changed by Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 04:53:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2500163be8a63b6dd75c9427640f8763d6d46b33

    Comments

    CrOS FilesApp: refactor only: split out crostini UI tests

Split crostini UI tests from crostini.js into test files:
 * crostini_mount.js
 * crostini_share.js
 * crostini_tasks.js
The existing tests are getting a bit too large and pushing
the bot testing time limits.

Bug: 878324
Change-Id: I882a38e3f644916e3c904709f3bfc540034b1383
Reviewed-on: https://chromium-review.googlesource.com/c/1278429
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599098}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_uitest.cc
    • ui/file_manager/file_manager/test/BUILD.gn
    • ui/file_manager/file_manager/test/crostini.js
    • ui/file_manager/file_manager/test/crostini_mount.js
    • ui/file_manager/file_manager/test/crostini_share.js
    • ui/file_manager/file_manager/test/crostini_tasks.js

  16. [Video Capture, Test] Make tests requiring real webcam fail if it's not found

    Changed by Keiichi Watanabe - keiichiwohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 04:50:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dfeab488cdc95233b19b9edeedef3d0b7581b17e

    Comments

    [Video Capture, Test] Make tests requiring real webcam fail if it's not found

Use prefix "UsingRealWebcam_" for names of tests that require real webcam and
add checking whether webcam is found or not.
Accordingly, exclude such test cases from test suites for devices that have no
camera.

Bug: 893494
Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebox (guado)
      and it failed.
Test: Ran capture_unittests excluding UsingRealWebcam_ tests on Chromebox (guado)
      and it passed.
Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebook (kevin)
      and it passed.

Change-Id: I5c91380b7674aeace6a7d1764f7fad31f02f8af7
Reviewed-on: https://chromium-review.googlesource.com/c/1276407
Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599097}

    Changed files

    • media/capture/video/video_capture_device_unittest.cc
    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.chromiumos.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.linux.json
    • testing/buildbot/chromium.mac.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.win.json
    • testing/buildbot/test_suites.pyl

  17. Roll src-internal 616feb1a7c2c..09c355ef00f4 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 04:45:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5fc416b1492c1141613708a7234048954198b839

    Comments

    Roll src-internal 616feb1a7c2c..09c355ef00f4 (2 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/616feb1a7c2c..09c355ef00f4


Created with:
  gclient setdep -r src-internal@09c355ef00f4

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I31399eb2e92dae352d53dc7fcde8bf49c0966418
Reviewed-on: https://chromium-review.googlesource.com/c/1278531
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599096}

    Changed files

    • DEPS

  18. [auto] Update FlagExpectations for LayoutNG

    Changed by Koji Ishii - kojiiohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 04:22:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dfdec8007a6f8a83d060f176a335b42537cb8ba9

    Comments

    [auto] Update FlagExpectations for LayoutNG

Following bot results are included.
10421 10431 10436 10446 10458 10478 10484 10489 10494 10496
10498 10499 10503 10509 10514 10516 10519 10523 10525 10530
10541 10549 10550 10552

1 lines were removed and 3 lines were deflaked by consecutive
results since 10503.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I937b189ec5c0061d7c1607828b6ac5fc0bfe71b4
Reviewed-on: https://chromium-review.googlesource.com/c/1270498
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599095}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG

  19. Revert "Fling bubbles from OOPIF properly."

    Changed by Findit - findit-for-meohnoyoudont@appspot.gserviceaccount.com
    Changed at Friday, 12-Oct-18 04:21:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bb03212f2a4bd93f4f87da036a5f9eaeb2256466

    Comments

    Revert "Fling bubbles from OOPIF properly."

This reverts commit a12ef847a57f4aa0282ca47b555c04da18b00f9e.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 599001 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYTEyZWY4NDdhNTdmNGFhMDI4MmNhNDdiNTU1YzA0ZGExOGIwMGY5ZQw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29516

Sample Failed Step: content_browsertests

Sample Flaky Test: BrowserSideFlingBrowserTest.TouchscreenFlingBubblesFromOOPIF

Original change's description:
> Fling bubbles from OOPIF properly.
> 
> While we are bubbling a scroll sequence GFS is sent to the fling controllers
> of both the oopif and the bubbling target. The fling controller of the oopif
> calls progressFling and generates a GSU with inertial phase, the GSU gets acked
> immediately before getting sent to the renderer since we are in bubbling mode.
> Then the oopif's fling controller receives the unconsumed GSU ack and generates
> a GSE to complete the scrolling sequence on the oopif. The bubbling target's
> fling controller receives and processes the GFS and generates GSUs which are
> sent to the target's renderer.
> 
> If the GSE generated by the oopif's fling controller gets bubbled before
> the GFS, the bubbling target gets reset and the target does not receive the
> GFS. This cl fixes the issue by making sure that the events generated by the
> oopif's fling controller are not bubbled to the target. Also in case of
> GFS bubbling, the GFC should also get sent to the bubbling target to make
> sure that the fling controller in charge of flinging receives the GFC.
> 
> 
> Bug: 884728, 249063
> Test: BrowserSideFlingBrowserTest.[Touchpad|Touchscreen]FlingBubblesFromOOPIF
> Change-Id: I064944f125bebcb746f329af4cfb117f3be94ff0
> Reviewed-on: https://chromium-review.googlesource.com/c/1274193
> Reviewed-by: Kevin McNee <mcnee@chromium.org>
> Reviewed-by: Charlie Reis <creis@chromium.org>
> Commit-Queue: Charlie Reis <creis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599001}

Change-Id: Ie8178e456d50cdd43fdeb86939180d20b96bcc36
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 884728, 249063, 894703
Reviewed-on: https://chromium-review.googlesource.com/c/1278536
Cr-Commit-Position: refs/heads/master@{#599094}

    Changed files

    • content/browser/frame_host/cross_process_frame_connector.cc
    • content/browser/renderer_host/input/fling_browsertest.cc
    • content/browser/renderer_host/render_widget_host_input_event_router.cc
    • content/browser/renderer_host/render_widget_host_input_event_router.h
    • content/browser/renderer_host/render_widget_host_view_child_frame.cc

  20. [OnionSoup] Reduce usages of blink::WebServiceWorkerRegistration

    Changed by Leon Han - leon.hanohnoyoudont@intel.com
    Changed at Friday, 12-Oct-18 04:17:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a6856b267639d14077ac2aac923503f586f3c955

    Comments

    [OnionSoup] Reduce usages of blink::WebServiceWorkerRegistration

Currently some modules (push_messaging, background_fetch etc.) are
calling blink::SWRegistration::WebRegistration() to get a pointer to
blink::WebSWRegistration to continue their work there.
However, they use that blink::WebSWRegistration just to retrieve the
service worker registration id, i.e. what they really want is not
blink::WebSWRegistration, but just the registration id.

So, this CL removes blink::SWRegistration::WebRegistration() and
provides a new function blink::SWRegistration::RegistrationId() for
those users instead.

This CL is in preparation for https://crrev.com/c/1275300 which plans to
merge content::WebSWRegistrationImpl into blink::SWRegistration and
remove the public interface blink::WebSWRegistration completely.

BUG=789857,879019

Change-Id: Iafb245ec6f978dfaa294f58ee800d80c5ba60fac
Reviewed-on: https://chromium-review.googlesource.com/c/1275298
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599093}

    Changed files

    • content/renderer/push_messaging/push_messaging_client.cc
    • content/renderer/push_messaging/push_messaging_client.h
    • content/renderer/push_messaging/push_provider.cc
    • content/renderer/push_messaging/push_provider.h
    • third_party/blink/public/platform/modules/push_messaging/web_push_client.h
    • third_party/blink/public/platform/modules/push_messaging/web_push_provider.h
    • third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.cc
    • third_party/blink/renderer/modules/background_sync/sync_manager.cc
    • third_party/blink/renderer/modules/cookie_store/cookie_store.cc
    • third_party/blink/renderer/modules/notifications/notification_manager.cc
    • third_party/blink/renderer/modules/notifications/notification_manager.h
    • third_party/blink/renderer/modules/notifications/service_worker_registration_notifications.cc
    • third_party/blink/renderer/modules/push_messaging/push_manager.cc
    • third_party/blink/renderer/modules/push_messaging/push_subscription.cc
    • third_party/blink/renderer/modules/service_worker/navigation_preload_manager.cc
    • third_party/blink/renderer/modules/service_worker/service_worker_registration.cc
    • third_party/blink/renderer/modules/service_worker/service_worker_registration.h

  21. [css, dom] Improve docs on partmap parser.

    Changed by Fergal Daly - fergalohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 04:09:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cb88d559e0a370eae92cb3812eee20197ec0cd6f

    Comments

    [css, dom] Improve docs on partmap parser.

Make the state transitions more clear and document which transitions
consume a character.

Bug: 805271

Change-Id: I363cb6c9d459b560d0ec1b4cb6649cce981deffc
Reviewed-on: https://chromium-review.googlesource.com/c/1275747
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599092}

    Changed files

    • third_party/blink/renderer/core/dom/names_map.cc

  22. Roll src/third_party/webrtc 1cd39fa9ea0c..8f4bc41c4231 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 03:48:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5de92169da01a3247e6397fc71f44c83447a8a12

    Comments

    Roll src/third_party/webrtc 1cd39fa9ea0c..8f4bc41c4231 (1 commits)

https://webrtc.googlesource.com/src.git/+log/1cd39fa9ea0c..8f4bc41c4231


git log 1cd39fa9ea0c..8f4bc41c4231 --date=short --no-merges --format='%ad %ae %s'
2018-10-11 oprypin@webrtc.org Revert "Move CryptoOptions to api/crypto from rtc_base/sslstreamadapter.h"


Created with:
  gclient setdep -r src/third_party/webrtc@8f4bc41c4231

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I926d7ea870bf3c7c76c519c12806778129e89659
Reviewed-on: https://chromium-review.googlesource.com/c/1277843
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599091}

    Changed files

    • DEPS

  23. [Picture in Picture] Add resize handle for CrOS.

    Changed by Tommy Steimel - steimelohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 03:46:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ccd3669d8798ee2013539723323bfd8d982b36a6

    Comments

    [Picture in Picture] Add resize handle for CrOS.

This change adds a UI affordance that the window is resizable and
draggable on ChromeOS. This adds a ResizeHandleButton made specifically
as the affordance.

This icon is on the edge of the window that points to the center of
the workspace screen. For example, if the window is on the bottom right
quadrant, the icon will be on the top left. In the case where the window
is on the bottom left quadrant, the icon replaces the close button. The
close button is then shifted to the top left corner.

Bug: 890113
Change-Id: Iea6b543e4ee5751d8478dc76daa024f5e85292d2
Reviewed-on: https://chromium-review.googlesource.com/c/1275526
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599090}

    Changed files

    • chrome/app/generated_resources.grd
    • chrome/app/vector_icons/BUILD.gn
    • chrome/app/vector_icons/resize_handle.icon
    • chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/views/overlay/close_image_button.cc
    • chrome/browser/ui/views/overlay/close_image_button.h
    • chrome/browser/ui/views/overlay/overlay_window_views.cc
    • chrome/browser/ui/views/overlay/overlay_window_views.h
    • chrome/browser/ui/views/overlay/resize_handle_button.cc
    • chrome/browser/ui/views/overlay/resize_handle_button.h

  24. [Feed] Wire the logging report with the logging bridge

    Changed by Gang Wu - gangwuohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 03:40:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab5a1ef3e0e0069c84adc62075ae09afbd612c78

    Comments

    [Feed] Wire the logging report with the logging bridge

Wired most of the UMA logging, there are two methods in the bridge not
connected since it is new UMA, will do in next CL.

Bug: 831641
Change-Id: I154261aa3266d1f6d0af07ccb7510b3879f2744e
Reviewed-on: https://chromium-review.googlesource.com/c/1275130
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599089}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedLoggingBridge.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedProcessScopeFactory.java
    • chrome/browser/android/feed/feed_logging_bridge.cc
    • chrome/browser/android/feed/feed_logging_bridge.h
    • components/feed/core/feed_logging_metrics.cc
    • components/feed/core/feed_logging_metrics.h
    • components/feed/core/feed_logging_metrics_unittest.cc

  25. Demo mode: Add debug logs to demo mode setup.

    Changed by Aga Wronska - agawronskaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 03:38:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 17f321cb0b8198ca3c72ac8dbf9a6acbd3588df0

    Comments

    Demo mode: Add debug logs to demo mode setup.

Logging demo setup steps will help to determine at what point problems
occured for example in case of infinite loading.

Change-Id: I04725e4c9d0de12553f6f14fb3d8ee7d106e9699
Reviewed-on: https://chromium-review.googlesource.com/c/1277957
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599088}

    Changed files

    • chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc