Home | Search | chromium - Builders
Login

Builder Linux FYI Release (AMD R7 240) Build 1237 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revisionf59c5558bcae3a45e08edc99450f00242e5e7ce0
Got Revisionf59c5558bcae3a45e08edc99450f00242e5e7ce0

Execution:

Steps and Logfiles:

Show:
  1. ( 304 ms ) setup_build
    running recipe: "chromium"
  2. ( 484 ms ) remove .cipd
  3. ( 39 secs ) bot_update
    [49GB/295GB used (16%)]
  4. ( 0 ) ensure_goma
  5. ( 597 ms ) swarming.py --version
    0.13
  6. ( 10 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
  8. ( 1 secs ) build directory
  9. ( 1 mins 25 secs ) extract build
  10. ( 609 ms ) find isolated tests
  11. ( 0 ) test_pre_run
  12. ( 1 mins 19 secs ) angle_unittests on ATI GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Pending time: 53s
    Shard duration: 21s
  13. ( 14 secs ) angle_white_box_tests on ATI GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 8s
  14. ( 26 secs ) tab_capture_end2end_tests on ATI GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 20s
  15. ( 15 secs ) gl_tests on ATI GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 13s
  16. ( 40 secs ) gles2_conform_test on ATI GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 36s
  17. ( 1 secs ) swiftshader_unittests on ATI GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 6s
  18. ( 1 mins 51 secs ) context_lost_tests on ATI GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:01:45.684370
    Total tests: 8
    * Passed: 8 (8 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  19. ( 27 secs ) depth_capture_tests on ATI GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 22s
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  20. ( 2 mins 33 secs ) gpu_process_launch_tests on ATI GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:02:30.708340
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  21. ( 23 secs ) hardware_accelerated_feature_tests on ATI GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 20s
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  22. ( 21 secs ) info_collection_tests on ATI GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 19s
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  23. ( 33 secs ) maps_pixel_test on ATI GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 30s
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  24. ( 5 mins 46 secs ) pixel_test on ATI GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:05:33.478060
    Total tests: 46
    * Passed: 46 (46 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  25. ( 49 secs ) screenshot_sync_tests on ATI GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 48s
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  26. ( 2 mins 14 secs ) trace_test on ATI GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:02:09.431310
    Total tests: 34
    * Passed: 17 (17 expected, 0 unexpected)
    * Skipped: 17 (17 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  27. ( 50 secs ) viz_screenshot_sync_tests on ATI GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 49s
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 2 hrs 6 mins ) webgl2_conformance_tests on ATI GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Max pending time: 2:00:25.250770 (shard #19)
    Max shard duration: 0:06:52.285850 (shard #7)
    Min shard duration: 0:05:45.974500 (shard #1)
    Total tests: 2761
    * Passed: 2695 (2695 expected, 0 unexpected)
    * Skipped: 66 (66 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 8 mins 10 secs ) webgl_conformance_gl_passthrough_tests on ATI GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Max pending time: 0:02:25.149930 (shard #1)
    Max shard duration: 0:05:32.305670 (shard #1)
    Min shard duration: 0:02:22.812650 (shard #0)
    Total tests: 922
    * Passed: 914 (914 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 9 mins 13 secs ) webgl_conformance_tests on ATI GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Max pending time: 0:02:40.455570 (shard #1)
    Max shard duration: 0:06:23.015390 (shard #1)
    Min shard duration: 0:02:34.372630 (shard #0)
    Total tests: 922
    * Passed: 915 (915 expected, 0 unexpected)
    * Skipped: 7 (7 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  31. ( 296 ms ) Tests statistics
     
    Stats
    Total shards: 40
    Total runtime: 2:35:03.106763
     
  32. ( 1 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm1080-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531382827881330, "id": "8941222435830430192", "project": "chromium", "tags": ["builder:Linux FYI Release (AMD R7 240)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/f59c5558bcae3a45e08edc99450f00242e5e7ce0", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Linux Builder", "parent_buildnumber:14789", "scheduler_invocation_id:9106652502286747088", "scheduler_job_id:chromium/Linux FYI Release (AMD R7 240)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Linux FYI Release (AMD R7 240)" setup_build
buildnumber 1237 setup_build
mastername "chromium.gpu.fyi" setup_build
parent_buildername "GPU FYI Linux Builder" setup_build
parent_got_angle_revision "c9c259cccb2ece20c516b45f2c3782e31860a528" setup_build
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" setup_build
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" setup_build
parent_got_revision "f59c5558bcae3a45e08edc99450f00242e5e7ce0" setup_build
parent_got_revision_cp "refs/heads/master@{#574501}" setup_build
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" setup_build
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" setup_build
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" setup_build
parent_got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23944}" setup_build
parent_mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "f59c5558bcae3a45e08edc99450f00242e5e7ce0" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "f59c5558bcae3a45e08edc99450f00242e5e7ce0" bot_update
got_revision_cp "refs/heads/master@{#574501}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23944}" bot_update
swarm_hashes {"angle_end2end_tests": "8971fedb0db5e27a24338194fb836238e988d281", "angle_perftests": "93582ba5626296d5439e387c717c06349a81ab3a", "angle_unittests": "c8eb7c9abc3e87f0cac64766cb72c5a1095ac633", "angle_white_box_tests": "6f22733154bda1d4e3cfb1d29016bd967f3fd0d4", "browser_tests": "c45324cf244608fa7130d494fd7289f968cbebc2", "gl_tests": "da5670273c42bb29fd6464c8f970c81e07351c74", "gl_unittests": "c9d3c53b4c043168b004d22b657953320216f4fd", "gles2_conform_test": "efb1434f257ef8ef42a7da34f86fe9b8c9a4f118", "swiftshader_unittests": "506e572d0f231545a8053f49cb0826b1e7310773", "telemetry_gpu_integration_test": "a750081fad579b6d6d73626b48a6dae9c4c84a31"} find isolated tests

Blamelist:

  1. Hitoshi Yoshida (periaohnoyoudont@chromium.org)
  2. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
  3. Alan Cutter (alancutterohnoyoudont@chromium.org)
  4. Marc Treib (treibohnoyoudont@chromium.org)
  5. Dominic Mazzoni (dmazzoniohnoyoudont@chromium.org)
  6. Hirokazu Honda (hirohohnoyoudont@chromium.org)
  7. cathiechen (cathiechenohnoyoudont@tencent.com)
  8. Stefan Zager (szagerohnoyoudont@chromium.org)
  9. Jun Mukai (mukaiohnoyoudont@chromium.org)
  10. rbpotter (rbpotterohnoyoudont@chromium.org)
  11. Lei Zhang (thestigohnoyoudont@chromium.org)
  12. John Abd-El-Malek (jamohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 08:07:07 UTC
Start Thursday, 12-Jul-18 08:07:12 UTC
End Thursday, 12-Jul-18 10:54:11 UTC
Pending 4 secs
Execution 2 hrs 46 mins

All Changes:

  1. oilpan: Make ImageLoader::Task::script_state_ WeakPersistent

    Changed by Hitoshi Yoshida - periaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:41:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f59c5558bcae3a45e08edc99450f00242e5e7ce0

    Comments

    oilpan: Make ImageLoader::Task::script_state_ WeakPersistent
    
    ImageLoader::Task class does not actually own the script state,
    so its reference can be weak.
    This CL makes the reference weak.
    
    Bug: 773605
    Change-Id: Ib5761227e6582a8519a9d10ffaa00226559ee3d6
    Reviewed-on: https://chromium-review.googlesource.com/1134629
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574501}

    Changed files

    • third_party/blink/renderer/core/loader/image_loader.cc
  2. Change test to use full-path-for-testing attribute selector

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:12:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a8460b3e49c7b9ee03dcf56af71a0d76c0f60e4

    Comments

    Change test to use full-path-for-testing attribute selector
    
    This makes this test compatible with directory tree having My Files or
    not, and makes the test more readable too.
    
    This is a preparation to enable new navigation (with My Files) by
    default.
    
    Bug: 857335
    No-presubmit: true
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ia35bc2cc7c91e0492f0158990bfc397a6b57da21
    Reviewed-on: https://chromium-review.googlesource.com/1133610
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574500}

    Changed files

    • ui/file_manager/integration_tests/file_manager/context_menu.js
    • ui/file_manager/integration_tests/file_manager/create_new_folder.js
    • ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
  3. Add find bar icon to hosted app windows

    Changed by Alan Cutter - alancutterohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:03:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e35f205a1441afebe9987e606c7c876d5bfc4594

    Comments

    Add find bar icon to hosted app windows
    
    This CL moves the find icon from LocationBarView into PageActionIconContainerView
    enabling the icon to appear in hosted app window title bars.
    
    This change also fixes the find icon getting nudged by
    crrev.com/108c0687254683b3beeaa32b6e0a86f2046a867e.
    
    Before 108c0687254683b3beeaa32b6e0a86f2046a867e:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346964&signed_aid=IuPvufZswamla90tWW5FCg==&inline=1
    Before CL:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346965&signed_aid=Aiy5ATHUK4cWS64MyuRMdQ==&inline=1
    After CL:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346968&signed_aid=DR3vtzLR7tlPH3cEwibshQ==&inline=1
    
    Bug: 788051, 814531
    Change-Id: I5fa60cce484bd2553131582fc39e6737da34e967
    Reviewed-on: https://chromium-review.googlesource.com/1054908
    Commit-Queue: Alan Cutter <alancutter@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574499}

    Changed files

    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
    • chrome/browser/ui/find_bar/find_bar_controller.cc
    • chrome/browser/ui/location_bar/location_bar.h
    • chrome/browser/ui/page_action/page_action_icon_container.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
    • chrome/browser/ui/views/frame/browser_view_layout.cc
    • chrome/browser/ui/views/frame/hosted_app_button_container.cc
    • chrome/browser/ui/views/frame/hosted_app_button_container.h
    • chrome/browser/ui/views/frame/toolbar_button_provider.h
    • chrome/browser/ui/views/location_bar/find_bar_icon.cc
    • chrome/browser/ui/views/location_bar/find_bar_icon.h
    • chrome/browser/ui/views/location_bar/location_bar_view.cc
    • chrome/browser/ui/views/location_bar/location_bar_view.h
    • chrome/browser/ui/views/page_action/page_action_icon_container_view.cc
    • chrome/browser/ui/views/page_action/page_action_icon_container_view.h
    • chrome/browser/ui/views/toolbar/toolbar_view.cc
    • chrome/browser/ui/views/toolbar/toolbar_view.h
    • chrome/test/base/test_browser_window.h
  4. Replace ThreadChecker by SequenceChecker in /components/sync*

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 06:54:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fc8a763a002339d6a7821e3c69d45ad8642dafc1

    Comments

    Replace ThreadChecker by SequenceChecker in /components/sync*
    
    https://crrev.com/c/1131474 removed the unnecessary thread-affinity,
    this one adjusts the checks accordingly.
    
    Bug: 846238
    Change-Id: If4e1145712fe99f4d8236d93e4f645e69c3e7655
    Reviewed-on: https://chromium-review.googlesource.com/1131738
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574498}

    Changed files

    • components/sync/driver/glue/sync_backend_host_core.cc
    • components/sync/driver/glue/sync_backend_host_core.h
    • components/sync/driver/glue/sync_backend_host_impl.cc
    • components/sync/driver/glue/sync_backend_host_impl.h
    • components/sync/driver/sync_service_crypto.cc
    • components/sync/driver/sync_service_crypto.h
    • components/sync/engine/sync_backend_registrar.cc
    • components/sync/engine/sync_backend_registrar.h
    • components/sync/engine_impl/debug_info_event_listener.cc
    • components/sync/engine_impl/debug_info_event_listener.h
    • components/sync/engine_impl/model_type_worker.cc
    • components/sync/engine_impl/model_type_worker.h
    • components/sync/engine_impl/net/server_connection_manager.cc
    • components/sync/engine_impl/net/server_connection_manager.h
    • components/sync/engine_impl/sync_manager_impl.cc
    • components/sync/engine_impl/sync_manager_impl.h
    • components/sync/engine_impl/sync_manager_impl_unittest.cc
    • components/sync/test/engine/fake_model_worker.cc
    • components/sync/test/engine/fake_model_worker.h
    • components/sync_bookmarks/bookmark_change_processor.cc
    • components/sync_bookmarks/bookmark_change_processor.h
  5. Track changes to nodes that are in the AX tree but aren't laid out.

    Changed by Dominic Mazzoni - dmazzoniohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 06:41:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d535bf95b998d1061629905139485c937272fc3b

    Comments

    Track changes to nodes that are in the AX tree but aren't laid out.
    
    Previously we only had hooks to update the children of a node in the
    AX tree when LayoutObjects were inserted or removed. That left out some
    corner cases when Nodes are inserted or removed that are part of the
    AX tree but not laid out, like nodes in the accessible / fallback content
    for a canvas.
    
    Bug: 862311
    Change-Id: I9482a9e0dc9ba45368b2fc87ea3449bdd4ef1c50
    Reviewed-on: https://chromium-review.googlesource.com/1132119
    Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574497}

    Changed files

    • third_party/WebKit/LayoutTests/accessibility/children-changed-in-canvas.html
    • third_party/blink/renderer/core/dom/element.cc
    • third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
    • third_party/blink/renderer/modules/accessibility/ax_layout_object.h
    • third_party/blink/renderer/modules/accessibility/ax_node_object.cc
    • third_party/blink/renderer/modules/accessibility/ax_node_object.h
  6. media/gpu/test/RenderingHelper: Unify interface to process video frame

    Changed by Hirokazu Honda - hirohohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 06:09:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c9e1a62b97488da8c36e7c12d0fe9769a60b4238

    Comments

    media/gpu/test/RenderingHelper: Unify interface to process video frame
    
    VDA test client calls RenderingHelper::RenderThumbnail() if a thumbnail is made
    from a video frame. Otherwise, it calls RenderingHelper::QueueVideoFrame().
    RenderingHelper itself knows which function to be called, and thus these
    functions should be unified into a single interface.
    
    BUG=chromium:834170
    TEST=VDA unittest at veyron_minnie and eve
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I106d4ce1c05b003d6333a6865a8d96e276031598
    Reviewed-on: https://chromium-review.googlesource.com/1122656
    Reviewed-by: Pawel Osciak <posciak@chromium.org>
    Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574496}

    Changed files

    • media/gpu/test/rendering_helper.cc
    • media/gpu/test/rendering_helper.h
    • media/gpu/video_decode_accelerator_unittest.cc
  7. [LayoutNG]Make the first marker of nested list occupying a whole line

    Changed by cathiechen - cathiechenohnoyoudont@tencent.com
    Changed at Thursday, 12-Jul-18 05:58:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 347323ce0f71964c59a50c507f14484baff8a386

    Comments

    [LayoutNG]Make the first marker of nested list occupying a whole line
    
    In legacy Layout, there's line-break between marker and the nesting
    <ul>/<ol>. In order to keep consistency with it, add NeedsOccupyWholeLine()
    in LayoutNGListMarker to indicate that marker would occupy a line.
    During Layout(), this kind of marker won't be added to container_builder_,
    and layout directly. And its margin will be handled after layout.
    
    Bug: 725277
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Ie9f6dbca0945c8e031ec7bb44594db2e96773462
    Reviewed-on: https://chromium-review.googlesource.com/1132819
    Commit-Queue: cathie chen <cathiechen@tencent.com>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574495}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/doctypes/001-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/doctypes/003-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/doctypes/004-expected.txt
    • third_party/blink/renderer/core/layout/ng/list/layout_ng_list_marker.cc
    • third_party/blink/renderer/core/layout/ng/list/layout_ng_list_marker.h
    • third_party/blink/renderer/core/layout/ng/list/ng_unpositioned_list_marker.h
    • third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
    • third_party/blink/renderer/core/paint/ng/ng_box_fragment_painter.cc
  8. Move scroll-related platform test code into core/testing/

    Changed by Stefan Zager - szagerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:49:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ecb9b545a199897e05ca621e40fd5e93289f82bd

    Comments

    Move scroll-related platform test code into core/testing/
    
    Also delete unused fake_scrollable_area.h.
    
    BUG=823365
    R=skobes@chromium.org,pdr@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I5620b9c31d53d523108c0c7a3a247264e588fc90
    Reviewed-on: https://chromium-review.googlesource.com/1132380
    Reviewed-by: Steve Kobes <skobes@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Commit-Queue: Stefan Zager <szager@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574494}

    Changed files

    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/editing/rendered_position_test.cc
    • third_party/blink/renderer/core/frame/frame_test_helpers.h
    • third_party/blink/renderer/core/paint/compositing/compositing_layer_property_updater_test.cc
    • third_party/blink/renderer/core/testing/core_unit_test_helper.h
    • third_party/blink/renderer/core/testing/use_mock_scrollbar_settings.h
    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
    • third_party/blink/renderer/platform/graphics/test/fake_scrollable_area.h
  9. check |focused_surface_| on SetCursorType

    Changed by Jun Mukai - mukaiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:47:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5939dab948bcde131510fa955f2802e93159238

    Comments

    check |focused_surface_| on SetCursorType
    
    SetCursorType hasn't checked the focused surface, thus it could
    change the cursor shapes even though the mouse pointer isn't
    related to the apps under exo.
    
    BUG=b/111360026
    TEST=the new test case in exo_unittests
    
    Change-Id: Ibacb0b8689720caa00ec206848cc6efb74854946
    Reviewed-on: https://chromium-review.googlesource.com/1134185
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Commit-Queue: Jun Mukai <mukai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574493}

    Changed files

    • components/exo/pointer.cc
    • components/exo/pointer_unittest.cc
  10. Print Preview: Add new Cloud Printer Handler flag

    Changed by rbpotter - rbpotterohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:34:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9990eb4884bf57e3f907c5a475d182ff4db6d760

    Comments

    Print Preview: Add new Cloud Printer Handler flag
    
    Use a new cloud printer handler flag to control using the C++ cloud
    printer handler instead of the JS cloud print interface in Print
    Preview. Print Preview will be temporarily whitelisted to send network
    requests with the network service flag enabled, so these changes should
    be de-coupled from the network service flag.
    
    Bug: 829414
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I9a7b53fe69bfe5aad4ab7cc5688dfb88e6074014
    Reviewed-on: https://chromium-review.googlesource.com/1134397
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574492}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • chrome/browser/resources/print_preview/data/destination_store.js
    • chrome/browser/ui/webui/print_preview/print_preview_handler.cc
    • chrome/browser/ui/webui/print_preview/print_preview_ui.cc
    • chrome/common/chrome_features.cc
    • chrome/common/chrome_features.h
    • tools/metrics/histograms/enums.xml
  11. Remove debugging code in base::MessagePumpWin.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:29:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 95f61506c064bf502b2f2f81293866e40843ab2b

    Comments

    Remove debugging code in base::MessagePumpWin.
    
    BUG=596190
    
    Change-Id: Ie9b6ee2cc1db8399247be767cabba1b39df50544
    Reviewed-on: https://chromium-review.googlesource.com/1128274
    Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574491}

    Changed files

    • base/message_loop/message_pump_win.cc
    • base/message_loop/message_pump_win.h
  12. Add workaround for WebUIs that make network requests when running with the network service.

    Changed by John Abd-El-Malek - jamohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:28:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 04bfa853ac261c316e0ef799e7c10ae05dece8c1

    Comments

    Add workaround for WebUIs that make network requests when running with the network service.
    
    Currently with the network service, renderers that have WebUI bindings are not allowed to make requests over the internet. This is to improve security in case the response hijacks the renderer. However there are a couple of WebUIs that are doing this now, so temporarily allow them.
    
    Bug: 848987, 829412
    Change-Id: I34c1b66e63fd1b7c2960cc867709c065329cf489
    Reviewed-on: https://chromium-review.googlesource.com/1134412
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574490}

    Changed files

    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/chrome_content_browser_client.h
    • chrome/browser/extensions/chrome_extensions_browser_client.cc
    • chrome/browser/extensions/chrome_extensions_browser_client.h
    • chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
    • chrome/browser/ui/webui/chrome_web_ui_controller_factory.h
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/public/browser/content_browser_client.cc
    • content/public/browser/content_browser_client.h
    • extensions/browser/api/web_request/web_request_permissions.cc
    • extensions/browser/extensions_browser_client.cc
    • extensions/browser/extensions_browser_client.h