Home | Search | chromium - Builders
Login

Builder Linux FYI Debug (NVIDIA) Build 4784 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revisionbb9ca465cac1a3ec4d0670844865b40efb003c11
Got Revisionbb9ca465cac1a3ec4d0670844865b40efb003c11

Execution:

Steps and Logfiles:

Show:
  1. ( 308 ms ) setup_build
    running recipe: "chromium"
  2. ( 218 ms ) report builders
     
    running tester 'Linux FYI Debug (NVIDIA)' on master 'chromium.gpu.fyi'
  3. ( 49 secs ) bot_update
    [48GB/295GB used (16%)]
  4. ( 567 ms ) swarming.py --version
    0.14
  5. ( 9 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
  7. ( 451 ms ) lookup builder GN args
     
    build_angle_gles1_conform_tests = true
    ffmpeg_branding = "Chrome"
    internal_gles2_conform_tests = true
    is_component_build = true
    is_debug = true
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 435 ms ) build directory
  9. ( 420 ms ) find isolated tests
  10. ( 1 mins 34 secs ) angle_end2end_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Max shard duration: 0:01:32.019373 (shard #0)
    Min shard duration: 51s (shard #2)
  11. ( 3 mins 45 secs ) angle_unittests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:03:41.677699
  12. ( 10 secs ) angle_white_box_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 9s
  13. ( 2 mins 19 secs ) gl_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:02:17.648562
  14. ( 15 secs ) gl_unittests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 14s
  15. ( 3 mins 28 secs ) gles2_conform_test on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:03:19.070137
  16. ( 1 secs ) swiftshader_unittests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 7s
  17. ( 11 mins 41 secs ) context_lost_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:11:31.325417
    Total tests: 10
    * Passed: 10 (10 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  18. ( 1 mins 1 secs ) depth_capture_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 57s
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  19. ( 6 mins 55 secs ) gpu_process_launch_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:06:53.988803
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  20. ( 59 secs ) hardware_accelerated_feature_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 58s
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  21. ( 45 secs ) info_collection_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 42s
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  22. ( 58 secs ) maps_pixel_test on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 57s
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  23. ( 27 mins 35 secs ) pixel_test on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:27:30.067221
    Total tests: 55
    * Passed: 55 (55 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  24. ( 3 mins 7 secs ) screenshot_sync_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:02:59.393432
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  25. ( 9 mins 52 secs ) trace_test on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:09:39.703612
    Total tests: 48
    * Passed: 24 (24 expected, 0 unexpected)
    * Skipped: 24 (24 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  26. ( 13 mins 2 secs ) webgl_conformance_gl_passthrough_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Max shard duration: 0:12:59.307544 (shard #1)
    Min shard duration: 0:08:17.702374 (shard #0)
    Total tests: 936
    * Passed: 931 (931 expected, 0 unexpected)
    * Skipped: 5 (5 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  27. ( 14 mins 41 secs ) webgl_conformance_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Max shard duration: 0:14:25.432105 (shard #1)
    Min shard duration: 0:09:11.478154 (shard #0)
    Total tests: 936
    * Passed: 930 (930 expected, 0 unexpected)
    * Skipped: 6 (6 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 267 ms ) Tests statistics
     
    Stats
    Total shards: 23
    Total runtime: 1:57:33.415116
     

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm1076-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544156035608441, "id": "8927828756764461584", "project": "chromium", "tags": ["builder:Linux FYI Debug (NVIDIA)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/bb9ca465cac1a3ec4d0670844865b40efb003c11", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Linux Builder (dbg)", "parent_buildnumber:41429", "scheduler_invocation_id:9093258818944431264", "scheduler_job_id:chromium/Linux FYI Debug (NVIDIA)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Linux FYI Debug (NVIDIA)" setup_build
buildnumber 4784 setup_build
mastername "chromium.gpu.fyi" setup_build
parent_buildername "GPU FYI Linux Builder (dbg)" setup_build
parent_got_angle_revision "c3e3731cd3b2a3044f1bdec906c8557cc3edae77" setup_build
parent_got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" setup_build
parent_got_dawn_revision "0f50114b3c6849238eedf95236137d614fed4be2" setup_build
parent_got_nacl_revision "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" setup_build
parent_got_revision "bb9ca465cac1a3ec4d0670844865b40efb003c11" setup_build
parent_got_revision_cp "refs/heads/master@{#614579}" setup_build
parent_got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" setup_build
parent_got_v8_revision "2192eb7f7ea45e3a7ee625cf3156f1469abed8b8" setup_build
parent_got_v8_revision_cp "refs/heads/7.3.55@{#1}" setup_build
parent_got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25919}" setup_build
parent_mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "bb9ca465cac1a3ec4d0670844865b40efb003c11" setup_build
swarm_hashes {"angle_end2end_tests": "71574ec992bd8fe4265ec3e75e56e5759fea6421", "angle_unittests": "07efdb473ac2e22cafef3bdd21df68b13a099e55", "angle_white_box_tests": "0423ca1eb67d373c036d0f408f2e5be0350a78b2", "gl_tests": "9723fe9df24a48071bb7a4ddc0bb9f9c73659b73", "gl_unittests": "a9b37d630e33276a67ab3f0c9924b38852c74009", "gles2_conform_test": "6bafb8b29387b4d23a3868d62c1a0a7e481c8d67", "swiftshader_unittests": "de29434988ade5944882ba2e1e9ece1785fc7696", "telemetry_gpu_integration_test": "bada80d3e5634c844bb2cc18d2ff79e364f24fbf"} setup_build
got_angle_revision "132d15c217e0363626a5d789861b75122f718b5d" bot_update
got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" bot_update
got_dawn_revision "0f50114b3c6849238eedf95236137d614fed4be2" bot_update
got_nacl_revision "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" bot_update
got_revision "bb9ca465cac1a3ec4d0670844865b40efb003c11" bot_update
got_revision_cp "refs/heads/master@{#614579}" bot_update
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" bot_update
got_v8_revision "2192eb7f7ea45e3a7ee625cf3156f1469abed8b8" bot_update
got_v8_revision_cp "refs/heads/7.3.55@{#1}" bot_update
got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25919}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. Takashi Sakamoto (tasakohnoyoudont@google.com)
  2. Takashi Sakamoto (tasakohnoyoudont@google.com)
  3. Dan Beam (dbeamohnoyoudont@chromium.org)

Timing:

Create Friday, 07-Dec-18 04:13:55 UTC
Start Friday, 07-Dec-18 04:13:57 UTC
End Friday, 07-Dec-18 05:58:30 UTC
Pending 2 secs
Execution 1 hrs 44 mins

All Changes:

  1. Revert "cros: Move most event/widget handling logic out of LoginBubble"

    Changed by Takashi Sakamoto - tasakohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 03:49:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bb9ca465cac1a3ec4d0670844865b40efb003c11

    Comments

    Revert "cros: Move most event/widget handling logic out of LoginBubble"
    
    This reverts commit a61287973e8f4522ed673ac1a77de0dc56eb1bc8.
    
    Reason for revert: Suspect Failure single_process_mash_ash_unittests Failure ash_unittests:
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/16943
    https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927839167159249024/+/steps/single_process_mash_ash_unittests/0/logs/LoginExpandedPublicAccountViewTest.ChangeMenuSelection/0
    ---
    [ RUN      ] LoginExpandedPublicAccountViewTest.ChangeMenuSelection
    Received signal 11 SEGV_MAPERR ffffe03f000008fe
    #0 0x5631a3caedbf base::debug::StackTrace::StackTrace()
    #1 0x5631a3cae941 base::debug::(anonymous namespace)::StackDumpSignalHandler()
    #2 0x7faa9920f330 <unknown>
    #3 0x5631a3aafbbf ash::LoginBubble::~LoginBubble()
    #4 0x5631a3ab806c ash::RightPaneView::~RightPaneView()
    #5 0x5631a3ab810e ash::RightPaneView::~RightPaneView()
    #6 0x5631a40385d4 views::View::~View()
    #7 0x5631a3ab6df9 ash::LoginExpandedPublicAccountView::~LoginExpandedPublicAccountView()
    #8 0x5631a40385d4 views::View::~View()
    #9 0x5631a300afce ash::(anonymous namespace)::DragTestView::~DragTestView()
    #10 0x5631a4039b42 views::View::DoRemoveChildView()
    #11 0x5631a403a175 views::View::RemoveAllChildViews()
    #12 0x5631a4043b81 views::internal::RootView::~RootView()
    #13 0x5631a400ef0e views::MenuHostRootView::~MenuHostRootView()
    #14 0x5631a404615f views::Widget::~Widget()
    #15 0x5631a34d645e exo::(anonymous namespace)::ShellSurfaceWidget::~ShellSurfaceWidget()
    #16 0x5631a30c36f0 ash::LoginTestBase::TearDown()
    
    Original change's description:
    > cros: Move most event/widget handling logic out of LoginBubble
    > 
    > Changes made:
    > - Move the (keyboard/click/tap) event handling logic into a
    >   LoginBubbleHandler class.
    > - Move the widget handling into LoginBaseBubbleView itself
    > 
    > Bug: 912658
    > Change-Id: Ia1a9bf4b8d847ef74ef1716e73dfe1b16b8d19b2
    > Reviewed-on: https://chromium-review.googlesource.com/c/1366516
    > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
    > Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614544}
    
    TBR=jdufault@chromium.org,qnnguyen@chromium.org
    
    Change-Id: Ia9b9059f24f6aa6a8551c5c6bc5c76caafe592df
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 912658
    Reviewed-on: https://chromium-review.googlesource.com/c/1367070
    Reviewed-by: Takashi Sakamoto <tasak@google.com>
    Commit-Queue: Takashi Sakamoto <tasak@google.com>
    Cr-Commit-Position: refs/heads/master@{#614579}

    Changed files

    • ash/login/ui/login_base_bubble_view.cc
    • ash/login/ui/login_base_bubble_view.h
    • ash/login/ui/login_bubble.cc
    • ash/login/ui/login_bubble.h
  2. Revert "Updating XTBs based on .GRDs from branch master"

    Changed by Takashi Sakamoto - tasakohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 03:43:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df02e792b693ed5007b5c8c4866203219bedfd20

    Comments

    Revert "Updating XTBs based on .GRDs from branch master"
    
    This reverts commit c7424053a784c4d07dcd4617d68a1f2ac7f9657b.
    
    Reason for revert: suspect Android compile failure:
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel
    https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927834375124899248/+/steps/compile/0/stdout
    ---
    ../resource_zips/chrome/android/chrome_strings_grd.resources.zip/values-fr/android_chrome_strings.xml:364 Inconsistent number of arguments in formatting string `data_reduction_benefits_description`; found both 0 and 1: StringFormatCount [warning]
    <string name="data_reduction_benefits_description">"En mode simplifié, Chrome charge les pages plus rapidement et consomme jusqu\'à 60 % de données en moins."</string>
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../resource_zips/chrome/android/chrome_strings_grd.resources.zip/values-fr/android_chrome_strings.xml:389 Inconsistent number of arguments in formatting string `data_reduction_promo_summary`; found both 0 and 1: StringFormatCount [warning]
    <string name="data_reduction_promo_summary">"En mode simplifié, Chrome charge les pages plus rapidement et consomme jusqu\'à 60 % de données en moins. La technologie cloud de Google optimise les pages que vous consultez."</string>
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    Original change's description:
    > Updating XTBs based on .GRDs from branch master
    > 
    > R=​abdulsyed@chromium.org
    > 
    > Change-Id: Ibc94ee5be9db75306313d34881e4026a681eec1d
    > Reviewed-on: https://chromium-review.googlesource.com/c/1366870
    > Reviewed-by: Krishna Govind <govind@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614569}
    
    TBR=govind@chromium.org,abdulsyed@chromium.org
    
    Change-Id: I4dfd803c9c148e5d6e3335d11e06fd61728fe548
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/1366465
    Reviewed-by: Takashi Sakamoto <tasak@google.com>
    Commit-Queue: Takashi Sakamoto <tasak@google.com>
    Cr-Commit-Position: refs/heads/master@{#614578}

    Changed files

    • ash/components/strings/ash_components_strings_te.xtb
    • ash/strings/ash_strings_am.xtb
    • ash/strings/ash_strings_ar.xtb
    • ash/strings/ash_strings_bn.xtb
    • ash/strings/ash_strings_ca.xtb
    • ash/strings/ash_strings_cs.xtb
    • ash/strings/ash_strings_de.xtb
    • ash/strings/ash_strings_el.xtb
    • ash/strings/ash_strings_en-GB.xtb
    • ash/strings/ash_strings_fa.xtb
    • ash/strings/ash_strings_fi.xtb
    • ash/strings/ash_strings_fr.xtb
    • ash/strings/ash_strings_gu.xtb
    • ash/strings/ash_strings_hr.xtb
    • ash/strings/ash_strings_hu.xtb
    • ash/strings/ash_strings_id.xtb
    • ash/strings/ash_strings_it.xtb
    • ash/strings/ash_strings_kn.xtb
    • ash/strings/ash_strings_lt.xtb
    • ash/strings/ash_strings_lv.xtb
    • ash/strings/ash_strings_ml.xtb
    • ash/strings/ash_strings_nl.xtb
    • ash/strings/ash_strings_pl.xtb
    • ash/strings/ash_strings_pt-BR.xtb
    • ash/strings/ash_strings_pt-PT.xtb
    • ash/strings/ash_strings_ru.xtb
    • ash/strings/ash_strings_sk.xtb
    • ash/strings/ash_strings_sl.xtb
    • ash/strings/ash_strings_sr.xtb
    • ash/strings/ash_strings_sv.xtb
    • ash/strings/ash_strings_sw.xtb
    • ash/strings/ash_strings_te.xtb
    • ash/strings/ash_strings_th.xtb
    • ash/strings/ash_strings_tr.xtb
    • ash/strings/ash_strings_uk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_am.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ar.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_bg.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_bn.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ca.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_cs.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_da.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_de.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_el.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_en-GB.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es-419.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fa.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fil.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_gu.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hu.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_id.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_it.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_iw.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ja.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_kn.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lt.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lv.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ml.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_nl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pt-BR.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pt-PT.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ru.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sv.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sw.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ta.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_te.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_th.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_tr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_uk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_zh-CN.xtb
    • chrome/app/resources/chromium_strings_te.xtb
    • chrome/app/resources/generated_resources_am.xtb
    • chrome/app/resources/generated_resources_ar.xtb
    • chrome/app/resources/generated_resources_bg.xtb
    • chrome/app/resources/generated_resources_bn.xtb
    • chrome/app/resources/generated_resources_ca.xtb
    • chrome/app/resources/generated_resources_cs.xtb
    • chrome/app/resources/generated_resources_da.xtb
    • chrome/app/resources/generated_resources_de.xtb
    • chrome/app/resources/generated_resources_el.xtb
    • chrome/app/resources/generated_resources_en-GB.xtb
    • chrome/app/resources/generated_resources_es-419.xtb
    • chrome/app/resources/generated_resources_es.xtb
    • chrome/app/resources/generated_resources_et.xtb
    • chrome/app/resources/generated_resources_fa.xtb
    • chrome/app/resources/generated_resources_fi.xtb
    • chrome/app/resources/generated_resources_fil.xtb
    • chrome/app/resources/generated_resources_fr.xtb
    • chrome/app/resources/generated_resources_gu.xtb
    • chrome/app/resources/generated_resources_hi.xtb
    • chrome/app/resources/generated_resources_hr.xtb
    • chrome/app/resources/generated_resources_hu.xtb
    • chrome/app/resources/generated_resources_id.xtb
    • chrome/app/resources/generated_resources_it.xtb
    • chrome/app/resources/generated_resources_iw.xtb
    • chrome/app/resources/generated_resources_ja.xtb
    • chrome/app/resources/generated_resources_kn.xtb
    • chrome/app/resources/generated_resources_ko.xtb
    • chrome/app/resources/generated_resources_lt.xtb
    • chrome/app/resources/generated_resources_lv.xtb
    • chrome/app/resources/generated_resources_ml.xtb
    • chrome/app/resources/generated_resources_mr.xtb
    • chrome/app/resources/generated_resources_ms.xtb
    • chrome/app/resources/generated_resources_nl.xtb
    • chrome/app/resources/generated_resources_no.xtb
    • chrome/app/resources/generated_resources_pl.xtb
    • chrome/app/resources/generated_resources_pt-BR.xtb
    • chrome/app/resources/generated_resources_pt-PT.xtb
    • chrome/app/resources/generated_resources_ro.xtb
    • chrome/app/resources/generated_resources_ru.xtb
    • chrome/app/resources/generated_resources_sk.xtb
    • chrome/app/resources/generated_resources_sl.xtb
    • chrome/app/resources/generated_resources_sr.xtb
    • chrome/app/resources/generated_resources_sv.xtb
    • chrome/app/resources/generated_resources_sw.xtb
    • chrome/app/resources/generated_resources_ta.xtb
    • chrome/app/resources/generated_resources_te.xtb
    • chrome/app/resources/generated_resources_th.xtb
    • chrome/app/resources/generated_resources_tr.xtb
    • chrome/app/resources/generated_resources_uk.xtb
    • chrome/app/resources/generated_resources_vi.xtb
    • chrome/app/resources/generated_resources_zh-CN.xtb
    • chrome/app/resources/generated_resources_zh-TW.xtb
    • chrome/app/resources/google_chrome_strings_te.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_am.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ar.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_bg.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ca.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_cs.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_da.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_de.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_el.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_en-GB.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_es-419.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_es.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_et.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fa.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fil.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hu.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_id.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_it.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ja.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ko.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_lt.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_lv.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ms.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_nl.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_no.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pl.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pt-BR.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pt-PT.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ro.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ru.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sk.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sv.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sw.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ta.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_th.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_tr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_uk.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_vi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-CN.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-TW.xtb
    • components/policy/resources/policy_templates_am.xtb
    • components/policy/resources/policy_templates_ar.xtb
    • components/policy/resources/policy_templates_bn.xtb
    • components/policy/resources/policy_templates_ca.xtb
    • components/policy/resources/policy_templates_cs.xtb
    • components/policy/resources/policy_templates_de.xtb
    • components/policy/resources/policy_templates_el.xtb
    • components/policy/resources/policy_templates_en-GB.xtb
    • components/policy/resources/policy_templates_es-419.xtb
    • components/policy/resources/policy_templates_fa.xtb
    • components/policy/resources/policy_templates_fi.xtb
    • components/policy/resources/policy_templates_fr.xtb
    • components/policy/resources/policy_templates_hr.xtb
    • components/policy/resources/policy_templates_id.xtb
    • components/policy/resources/policy_templates_it.xtb
    • components/policy/resources/policy_templates_kn.xtb
    • components/policy/resources/policy_templates_ml.xtb
    • components/policy/resources/policy_templates_nl.xtb
    • components/policy/resources/policy_templates_pl.xtb
    • components/policy/resources/policy_templates_pt-BR.xtb
    • components/policy/resources/policy_templates_pt-PT.xtb
    • components/policy/resources/policy_templates_ru.xtb
    • components/policy/resources/policy_templates_sk.xtb
    • components/policy/resources/policy_templates_sr.xtb
    • components/policy/resources/policy_templates_sv.xtb
    • components/policy/resources/policy_templates_sw.xtb
    • components/policy/resources/policy_templates_ta.xtb
    • components/policy/resources/policy_templates_te.xtb
    • components/policy/resources/policy_templates_th.xtb
    • components/policy/resources/policy_templates_tr.xtb
    • components/policy/resources/policy_templates_uk.xtb
    • components/policy/resources/policy_templates_vi.xtb
    • components/strings/components_strings_am.xtb
    • components/strings/components_strings_ar.xtb
    • components/strings/components_strings_bg.xtb
    • components/strings/components_strings_bn.xtb
    • components/strings/components_strings_ca.xtb
    • components/strings/components_strings_cs.xtb
    • components/strings/components_strings_da.xtb
    • components/strings/components_strings_de.xtb
    • components/strings/components_strings_el.xtb
    • components/strings/components_strings_en-GB.xtb
    • components/strings/components_strings_es-419.xtb
    • components/strings/components_strings_es.xtb
    • components/strings/components_strings_et.xtb
    • components/strings/components_strings_fa.xtb
    • components/strings/components_strings_fi.xtb
    • components/strings/components_strings_fil.xtb
    • components/strings/components_strings_fr.xtb
    • components/strings/components_strings_gu.xtb
    • components/strings/components_strings_hi.xtb
    • components/strings/components_strings_hr.xtb
    • components/strings/components_strings_hu.xtb
    • components/strings/components_strings_id.xtb
    • components/strings/components_strings_it.xtb
    • components/strings/components_strings_iw.xtb
    • components/strings/components_strings_ja.xtb
    • components/strings/components_strings_kn.xtb
    • components/strings/components_strings_ko.xtb
    • components/strings/components_strings_lt.xtb
    • components/strings/components_strings_lv.xtb
    • components/strings/components_strings_ml.xtb
    • components/strings/components_strings_mr.xtb
    • components/strings/components_strings_ms.xtb
    • components/strings/components_strings_nl.xtb
    • components/strings/components_strings_no.xtb
    • components/strings/components_strings_pl.xtb
    • components/strings/components_strings_pt-BR.xtb
    • components/strings/components_strings_pt-PT.xtb
    • components/strings/components_strings_ro.xtb
    • components/strings/components_strings_ru.xtb
    • components/strings/components_strings_sk.xtb
    • components/strings/components_strings_sl.xtb
    • components/strings/components_strings_sr.xtb
    • components/strings/components_strings_sv.xtb
    • components/strings/components_strings_sw.xtb
    • components/strings/components_strings_ta.xtb
    • components/strings/components_strings_te.xtb
    • components/strings/components_strings_th.xtb
    • components/strings/components_strings_tr.xtb
    • components/strings/components_strings_uk.xtb
    • components/strings/components_strings_vi.xtb
    • components/strings/components_strings_zh-CN.xtb
    • components/strings/components_strings_zh-TW.xtb
    • content/app/strings/translations/content_strings_te.xtb
    • extensions/strings/extensions_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_google_chrome_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_strings_am.xtb
    • ios/chrome/app/strings/resources/ios_strings_ar.xtb
    • ios/chrome/app/strings/resources/ios_strings_bn.xtb
    • ios/chrome/app/strings/resources/ios_strings_ca.xtb
    • ios/chrome/app/strings/resources/ios_strings_cs.xtb
    • ios/chrome/app/strings/resources/ios_strings_de.xtb
    • ios/chrome/app/strings/resources/ios_strings_el.xtb
    • ios/chrome/app/strings/resources/ios_strings_en-GB.xtb
    • ios/chrome/app/strings/resources/ios_strings_fa.xtb
    • ios/chrome/app/strings/resources/ios_strings_fi.xtb
    • ios/chrome/app/strings/resources/ios_strings_fil.xtb
    • ios/chrome/app/strings/resources/ios_strings_fr.xtb
    • ios/chrome/app/strings/resources/ios_strings_gu.xtb
    • ios/chrome/app/strings/resources/ios_strings_hr.xtb
    • ios/chrome/app/strings/resources/ios_strings_hu.xtb
    • ios/chrome/app/strings/resources/ios_strings_id.xtb
    • ios/chrome/app/strings/resources/ios_strings_it.xtb
    • ios/chrome/app/strings/resources/ios_strings_ja.xtb
    • ios/chrome/app/strings/resources/ios_strings_kn.xtb
    • ios/chrome/app/strings/resources/ios_strings_lt.xtb
    • ios/chrome/app/strings/resources/ios_strings_lv.xtb
    • ios/chrome/app/strings/resources/ios_strings_ml.xtb
    • ios/chrome/app/strings/resources/ios_strings_nl.xtb
    • ios/chrome/app/strings/resources/ios_strings_pl.xtb
    • ios/chrome/app/strings/resources/ios_strings_pt-BR.xtb
    • ios/chrome/app/strings/resources/ios_strings_pt-PT.xtb
    • ios/chrome/app/strings/resources/ios_strings_ru.xtb
    • ios/chrome/app/strings/resources/ios_strings_sk.xtb
    • ios/chrome/app/strings/resources/ios_strings_sl.xtb
    • ios/chrome/app/strings/resources/ios_strings_sr.xtb
    • ios/chrome/app/strings/resources/ios_strings_sv.xtb
    • ios/chrome/app/strings/resources/ios_strings_sw.xtb
    • ios/chrome/app/strings/resources/ios_strings_ta.xtb
    • ios/chrome/app/strings/resources/ios_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_strings_th.xtb
    • ios/chrome/app/strings/resources/ios_strings_tr.xtb
    • ios/chrome/app/strings/resources/ios_strings_uk.xtb
    • remoting/resources/remoting_strings_am.xtb
    • remoting/resources/remoting_strings_ar.xtb
    • remoting/resources/remoting_strings_bn.xtb
    • remoting/resources/remoting_strings_es.xtb
    • remoting/resources/remoting_strings_gu.xtb
    • remoting/resources/remoting_strings_hu.xtb
    • remoting/resources/remoting_strings_id.xtb
    • remoting/resources/remoting_strings_kn.xtb
    • remoting/resources/remoting_strings_lt.xtb
    • remoting/resources/remoting_strings_lv.xtb
    • remoting/resources/remoting_strings_ml.xtb
    • remoting/resources/remoting_strings_ru.xtb
    • remoting/resources/remoting_strings_sl.xtb
    • remoting/resources/remoting_strings_sr.xtb
    • remoting/resources/remoting_strings_te.xtb
    • remoting/resources/remoting_strings_th.xtb
    • remoting/resources/remoting_strings_tr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_am.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ar.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_bg.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_bn.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ca.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_cs.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_da.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_de.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_el.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_en-GB.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_es-419.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_es.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_et.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fa.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fi.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fil.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_gu.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_hi.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_hr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_hu.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_id.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_it.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_iw.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ja.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_kn.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ko.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_lt.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_lv.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ml.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_mr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ms.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_nl.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_no.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_pl.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_pt-BR.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_pt-PT.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ru.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sk.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sl.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sv.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sw.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ta.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_th.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_tr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_uk.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_vi.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_zh-CN.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_zh-TW.xtb
    • ui/chromeos/translations/ui_chromeos_strings_te.xtb
  3. Revert "Enable warmer welcome during Assistant launch."

    Changed by Dan Beam - dbeamohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 02:41:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c71812f1007dae45bce45b451c384bf9c0dbd356

    Comments

    Revert "Enable warmer welcome during Assistant launch."
    
    This reverts commit 29dca9fe6ae866266c976809adc33c09a2ca1088.
    
    Reason for revert:
      ../../chromeos/services/assistant/assistant_manager_service_impl.cc:27:10: fatal error: 'chromeos/services/assistant/assistant_warmer_welcome_log.pb.h' file not found
      #include "chromeos/services/assistant/assistant_warmer_welcome_log.pb.h"
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      1 error generated.
    
    https://logs.chromium.org/logs/chromium/bb/chromium.chrome/Google_Chrome_ChromeOS/59389/+/recipes/steps/compile/0/stdout
    
    Original change's description:
    > Enable warmer welcome during Assistant launch.
    > 
    > 1. It is guarded by a finch flag AssistantWarmerWelcome.
    > 2. WW only shows 3 times.
    > 
    > Bug: b:112495005
    > Test: Manual
    > 
    > Change-Id: I80cbcfd4104c17172939d36b986be65077bf0bb3
    > Reviewed-on: https://chromium-review.googlesource.com/c/1355174
    > Reviewed-by: Will Harris <wfh@chromium.org>
    > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Commit-Queue: Yilei Li <yileili@google.com>
    > Cr-Commit-Position: refs/heads/master@{#614553}
    
    TBR=xiyuan@chromium.org,xiaohuic@chromium.org,wfh@chromium.org,dmblack@google.com,wutao@chromium.org,yileili@google.com
    
    Change-Id: Ib5749ef1c003be49d4923c364d8499b43a2abcf5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: b:112495005
    Reviewed-on: https://chromium-review.googlesource.com/c/1366873
    Reviewed-by: Dan Beam <dbeam@chromium.org>
    Commit-Queue: Dan Beam <dbeam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614577}

    Changed files

    • ash/BUILD.gn
    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_controller.h
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/public/cpp/ash_pref_names.cc
    • ash/public/cpp/ash_pref_names.h
    • ash/shell.cc
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h