Home | Search | chromium - Builders
Login

Builder Linux Clang Analyzer Build 3276 Canonical Ubuntu

Results:

Internal Failure

Trigger Info:

Projectchromium
Revisiona706d62ed54b601a3527b61a7f89b17564c262e0

Execution:

Steps and Logfiles:

Show:
  1. ( 346 ms ) setup_build
    running recipe: "chromium"
  2. ( 3 secs ) report builders
     
    running builder/tester 'Linux Clang Analyzer' on master 'chromium.fyi'
  3. ( 5 mins 20 secs ) bot_update
    [32GB/295GB used (10%)]
  4. ( 2 secs ) swarming.py --version
    0.14
  5. ( 12 mins 40 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.fyi.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.fyi.json
  7. ( 675 ms ) lookup GN args
     
    use_clang_static_analyzer = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 10 secs ) generate_build_files
  9. ( 9 hrs 43 mins ) compile

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2395-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544102955705011, "id": "8927884415077214224", "project": "chromium", "tags": ["builder:Linux Clang Analyzer", "buildset:commit/git/a706d62ed54b601a3527b61a7f89b17564c262e0", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/a706d62ed54b601a3527b61a7f89b17564c262e0", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9093314477123832752", "scheduler_job_id:chromium/Linux Clang Analyzer", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Linux Clang Analyzer" setup_build
buildnumber 3276 setup_build
mastername "chromium.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "a706d62ed54b601a3527b61a7f89b17564c262e0" setup_build
got_angle_revision "d300548fcc2858fab34b7a744a000c48be845d06" bot_update
got_buildtools_revision "04161ec8d7c781e4498c699254c69ba0dd959fde" bot_update
got_dawn_revision "bdd887fce76cd2703f1086b35ad9b9b00b147461" bot_update
got_nacl_revision "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" bot_update
got_revision "a706d62ed54b601a3527b61a7f89b17564c262e0" bot_update
got_revision_cp "refs/heads/master@{#614331}" bot_update
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" bot_update
got_v8_revision "f5137533bdfac762e980b17eb7b4a2433dd07d1d" bot_update
got_v8_revision_cp "refs/heads/7.3.39@{#1}" bot_update
got_webrtc_revision "fafae11bfc4c7d1f8f02e708b0187fb48f7b8810" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25914}" bot_update

Blamelist:

  1. erikchen (erikchenohnoyoudont@chromium.org)
  2. Alex Clarke (alexclarkeohnoyoudont@chromium.org)
  3. Alex Clarke (alexclarkeohnoyoudont@chromium.org)
  4. Mike Reed (reedohnoyoudont@google.com)
  5. Antonio Gomes (tonikitooohnoyoudont@igalia.com)
  6. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  7. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  8. Huanzhong Huang (huanzhongohnoyoudont@google.com)
  9. David Roger (drogerohnoyoudont@chromium.org)
  10. Alex Clarke (alexclarkeohnoyoudont@chromium.org)
  11. Carlos Caballero (carlscabohnoyoudont@google.com)
  12. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  13. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  14. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  15. Dániel Bátyai (dbatyaiohnoyoudont@inf.u-szeged.hu)
  16. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  17. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  18. Robbie Gibson (rkgibsonohnoyoudont@google.com)
  19. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  20. Victor Costan (pwnallohnoyoudont@chromium.org)
  21. Huanzhong Huang (huanzhongohnoyoudont@google.com)
  22. Hiroki Nakagawa (nhirokiohnoyoudont@chromium.org)
  23. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  24. Karolina Soltys (ksoltohnoyoudont@chromium.org)
  25. Mirta Dvornicic (mirtadohnoyoudont@google.com)
  26. Hans Wennborg (hansohnoyoudont@chromium.org)
  27. Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
  28. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  29. Jérôme Lebel (jlebelohnoyoudont@chromium.org)
  30. Kent Tamura (tkentohnoyoudont@chromium.org)
  31. Philip Jägenstedt (foolipohnoyoudont@chromium.org)
  32. Clemens Arbesser (arbesserohnoyoudont@google.com)
  33. Javier Ernesto Flores Robles (javierroblesohnoyoudont@chromium.org)
  34. Yutaka Hirano (yhiranoohnoyoudont@chromium.org)
  35. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  36. Kent Tamura (tkentohnoyoudont@chromium.org)
  37. Makoto Shimazu (shimazuohnoyoudont@chromium.org)
  38. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  39. Reka Norman (rekanormanohnoyoudont@google.com)
  40. Mohamed Amir Yosef (mamirohnoyoudont@chromium.org)
  41. Fumitoshi Ukai (ukaiohnoyoudont@google.com)
  42. Rakina Zata Amni (rakinaohnoyoudont@chromium.org)
  43. Mario Sanchez Prada (marioohnoyoudont@igalia.com)
  44. David Jean (djeanohnoyoudont@google.com)
  45. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  46. dpapad (dpapadohnoyoudont@chromium.org)
  47. Yuichiro Hanada (yhanadaohnoyoudont@chromium.org)
  48. Hiroki Nakagawa (nhirokiohnoyoudont@chromium.org)
  49. Hiroki Nakagawa (nhirokiohnoyoudont@chromium.org)
  50. Hiroshige Hayashizaki (hiroshigeohnoyoudont@chromium.org)
  51. Noel Gordon (noelohnoyoudont@chromium.org)
  52. Hiroki Nakagawa (nhirokiohnoyoudont@chromium.org)
  53. Hiroshige Hayashizaki (hiroshigeohnoyoudont@chromium.org)
  54. Christopher Cameron (ccameronohnoyoudont@chromium.org)
  55. Matt Falkenhagen (falkenohnoyoudont@chromium.org)
  56. Noel Gordon (noelohnoyoudont@chromium.org)
  57. Sam McNally (sammcohnoyoudont@chromium.org)
  58. John Abd-El-Malek (jamohnoyoudont@chromium.org)
  59. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  60. John Abd-El-Malek (jamohnoyoudont@chromium.org)
  61. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  62. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  63. weidongg@chromium.org (weidonggohnoyoudont@chromium.org)
  64. siyua (siyuaohnoyoudont@chromium.org)
  65. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  66. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  67. Jeffrey Yasskin (jyasskinohnoyoudont@chromium.org)
  68. chrome-release-bot (chrome-release-botohnoyoudont@chromium.org)
  69. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  70. Andrew Grieve (agrieveohnoyoudont@chromium.org)
  71. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  72. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  73. Erik Luo (luoeohnoyoudont@chromium.org)
  74. James Darpinian (jdarpinianohnoyoudont@chromium.org)
  75. Zhuoyu Qian (zhuoyu.qianohnoyoudont@samsung.com)
  76. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  77. Tom Anderson (thomasandersonohnoyoudont@chromium.org)
  78. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  79. Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
  80. Chris Hall (chrishallohnoyoudont@chromium.org)
  81. Ben Kelly (wanderviewohnoyoudont@chromium.org)
  82. bsheedy (bsheedyohnoyoudont@chromium.org)
  83. Carlos Knippschild (carloskohnoyoudont@chromium.org)
  84. Ken Rockot (rockotohnoyoudont@chromium.org)
  85. Nasko Oskov (naskoohnoyoudont@chromium.org)
  86. khmel@chromium.org (khmelohnoyoudont@chromium.org)
  87. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  88. Matt Reynolds (mattreynoldsohnoyoudont@google.com)
  89. Piotr Bialecki (bialpioohnoyoudont@chromium.org)
  90. Hui(Andy) Wu (wuandyohnoyoudont@chromium.org)
  91. Chase Phillips (cmpohnoyoudont@chromium.org)
  92. Francois Doray (fdorayohnoyoudont@chromium.org)
  93. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  94. Xida Chen (xidachenohnoyoudont@chromium.org)
  95. Andrew Grieve (agrieveohnoyoudont@chromium.org)
  96. Weidong Guo (weidonggohnoyoudont@chromium.org)
  97. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  98. iOS Autoroller (ios-autorollerohnoyoudont@chromium.org)
  99. Hirokazu Honda (hirohohnoyoudont@chromium.org)
  100. Alex Newcomer (newcomerohnoyoudont@chromium.org)
  101. <blame list capped at 100 commits> ()

Timing:

Create Thursday, 06-Dec-18 13:29:15 UTC
Start Thursday, 06-Dec-18 13:33:37 UTC
End Thursday, 06-Dec-18 23:35:38 UTC
Pending 4 mins 21 secs
Execution 10 hrs 2 mins

All Changes:

  1. Require that .pak files are successfully loaded.

    Changed by erikchen - erikchenohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 13:26:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a706d62ed54b601a3527b61a7f89b17564c262e0

    Comments

    Require that .pak files are successfully loaded.
    
    Several test suites relied on the common resources .pak being unsuccessfully
    loaded in order to function correctly. On Android, .pak files can leak between
    successive runs of different test suites, which would cause flaky test failures.
    This CL makes it so that failing to load the common resources .pak file will hit
    a DCHECK. This CL fixes several instances where test suites were incorrectly
    trying to load [and failing to load] the common resources .pak file.
    
    Change-Id: I5294f921e42524b699c7019b7a56c0a30106c89c
    Bug: 906587
    Reviewed-on: https://chromium-review.googlesource.com/c/1363447
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614331}

    Changed files

    • components/ntp_tiles/icon_cacher_impl_unittest.cc
    • ui/base/resource/resource_bundle_android.cc
    • ui/base/test/run_all_unittests.cc
  2. SequenceManagerImpl::IsIdleForTesting to match MessageLoop behavior

    Changed by Alex Clarke - alexclarkeohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 13:22:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1dc884dc9ff9b74841192d420479197f80c3ac9c

    Comments

    SequenceManagerImpl::IsIdleForTesting to match MessageLoop behavior
    
    The MessageLoop version of IsIdleForTesting does not take Now() into
    account, but the SequenceManager version was.  This is a mistake
    because its flaky when there are delayed tasks that are just about
    to run.
    
    TBR=fdoray@chromium.org
    
    Bug: 910645, 863341, 891670
    Change-Id: Ieaf5e534df0f553046b76fa844f61e4a268082f9
    Reviewed-on: https://chromium-review.googlesource.com/c/1365233
    Reviewed-by: Alex Clarke <alexclarke@chromium.org>
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Commit-Queue: Alex Clarke <alexclarke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614330}

    Changed files

    • base/message_loop/message_loop_unittest.cc
    • base/task/sequence_manager/sequence_manager.h
    • base/task/sequence_manager/sequence_manager_impl.cc
  3. Change interleaving of delayed and immediate tasks to match MessageLoop

    Changed by Alex Clarke - alexclarkeohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 13:20:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dda57a2c6aa319675172f8558ce8c24d9333f894

    Comments

    Change interleaving of delayed and immediate tasks to match MessageLoop
    
    Previously the TaskQueueSelector would allow up to 3 delayed tasks to
    run for every immediate task if both where ready to run.  This patch
    changes it to a 1:1 ratio like the MessageLoop.  NB neither the
    SequenceManager nor the MessageLoop allow delayed tasks to skip ahead
    of immediate tasks.
    
    In addition I've removed the PrioritizingSelector inner class which makes
    the code a bit more readable.  In addition based on review comments I
    changed the style of functions to return a pointer to the WorkQueue or
    null rather than a bool. This in general improves readability.
    
    Bug: 863341, 891670
    Change-Id: I61d4f118880f109c01ad4a2d5301acc9103b0b35
    Reviewed-on: https://chromium-review.googlesource.com/c/1361103
    Commit-Queue: Alex Clarke <alexclarke@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614329}

    Changed files

    • base/task/sequence_manager/sequence_manager_impl.cc
    • base/task/sequence_manager/sequence_manager_impl.h
    • base/task/sequence_manager/sequence_manager_impl_unittest.cc
    • base/task/sequence_manager/task_queue_selector.cc
    • base/task/sequence_manager/task_queue_selector.h
    • base/task/sequence_manager/task_queue_selector_unittest.cc
    • base/task/sequence_manager/work_queue_sets.cc
    • base/task/sequence_manager/work_queue_sets.h
    • base/task/sequence_manager/work_queue_sets_unittest.cc
    • base/task/sequence_manager/work_queue_unittest.cc
    • third_party/blink/web_tests/http/tests/devtools/sources/debugger/debugger-scope-resolve-this-expected.txt
  4. use SkFont for measure and break text

    Changed by Mike Reed - reedohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 13:09:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 15ec682801537617ba819e09336399a51e45bf82

    Comments

    use SkFont for measure and break text
    
    TBR=
    
    Bug: skia:2664
    Change-Id: Idf2e2d1c4eefd295d4262a0b49542c83119f639f
    Reviewed-on: https://chromium-review.googlesource.com/c/1363212
    Commit-Queue: Mike Reed <reed@google.com>
    Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614328}

    Changed files

    • cc/layers/heads_up_display_layer_impl.cc
    • media/blink/webmediaplayer_cast_android.cc
  5. [s13n] Convert account_reconcilor_unittest.cc to IdentityManager

    Changed by Antonio Gomes - tonikitooohnoyoudont@igalia.com
    Changed at Thursday, 06-Dec-18 13:09:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0d46e46ee383877ad62974bf266d5bbc96c2f056

    Comments

    [s13n] Convert account_reconcilor_unittest.cc to IdentityManager
    
    This CL migrates (most of) account_reconcilor_unittest.cc code
    away from SigninManager and PO2TS.
    Production code was migrated and unit tests were minimally updated
    to keep running in [1].
    
    Remarks:
    - The CL can completely remove SigninManager direct API calls.
    - The CL could not completely remove direct PO2TS API calls, due to two
    missing API: set_all_credentials_loaded_for_testing and LoadCredentials.
    - Given how the test uses gaia_id to manipulate reconciles and how
    IdentityTestEnvironment hides setting the gaia_id from the tests,
    there were some adaptations needed so that the functionalities could
    continue fully tested. For instance, the following methods were added/
    used:
    
    * GaiaIdForAccountKey: Added.
    * identity::GetTestGaiaIdForEmail: Referenced.
    
    [1] https://chromium-review.googlesource.com/c/1330223
    
    BUG=910581
    
    Change-Id: I58db6044caa22b6072cb6d22dd7c97c668c46cd3
    Reviewed-on: https://chromium-review.googlesource.com/c/1357059
    Reviewed-by: David Roger <droger@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#614327}

    Changed files

    • components/signin/core/browser/account_reconcilor_unittest.cc
  6. Roll src/third_party/webrtc 518add35a8f3..fafae11bfc4c (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 13:04:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 345809a783fb9cf763ca8e46c49ff17d9cc56bcf

    Comments

    Roll src/third_party/webrtc 518add35a8f3..fafae11bfc4c (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/518add35a8f3..fafae11bfc4c
    
    
    git log 518add35a8f3..fafae11bfc4c --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 terelius@webrtc.org Allow parsing RTC event logs without a transaction ID.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@fafae11bfc4c
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I2becf74e5f60f900df64e46c4e9a20b4e5603999
    Reviewed-on: https://chromium-review.googlesource.com/c/1365414
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614326}

    Changed files

    • DEPS
  7. Roll src-internal ddbf9b06e56d..eb2f2ad6ffdf (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 12:49:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6b7b1e666839441d358ae9d6278f1bb51dc6731b

    Comments

    Roll src-internal ddbf9b06e56d..eb2f2ad6ffdf (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ddbf9b06e56d..eb2f2ad6ffdf
    
    
    Created with:
      gclient setdep -r src-internal@eb2f2ad6ffdf
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I641322947d4d0b62fb0cf79fc9ae43742fb6b51e
    Reviewed-on: https://chromium-review.googlesource.com/c/1365413
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614325}

    Changed files

    • DEPS
  8. Update description of BrowsingDataCounter's |pref_|

    Changed by Huanzhong Huang - huanzhongohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 12:27:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d45ef23cc4d0ce5a4cba1b1433c55e319cb2222a

    Comments

    Update description of BrowsingDataCounter's |pref_|
    
    Remove part of the description of BrowsingDataCounter's |pref_| that's no longer true and irrelevant.
    
    Bug: none
    Change-Id: Ibfb47522b33b5ca92f9e29191c79b7070d425e38
    Reviewed-on: https://chromium-review.googlesource.com/c/1358459
    Reviewed-by: Christian Dullweber <dullweber@chromium.org>
    Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614324}

    Changed files

    • components/browsing_data/core/counters/browsing_data_counter.h
  9. [signin] Delete DiceFixAuthErrors

    Changed by David Roger - drogerohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 12:22:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 153707e1531f4233168575401a73ad4568ab5caa

    Comments

    [signin] Delete DiceFixAuthErrors
    
    This configuration is no longer enabled on any platforms.
    The code can now be removed.
    
    TBR=sky
    
    Bug: 777774
    Change-Id: Id92ef784e3ae933b21d96f8fd39deba1a4fa67a6
    Reviewed-on: https://chromium-review.googlesource.com/c/1355189
    Commit-Queue: David Roger <droger@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614323}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/extensions/api/identity/identity_api.cc
    • chrome/browser/extensions/api/identity/identity_api_unittest.cc
    • chrome/browser/signin/account_consistency_mode_manager.cc
    • chrome/browser/signin/account_consistency_mode_manager.h
    • chrome/browser/signin/account_consistency_mode_manager_unittest.cc
    • chrome/browser/signin/account_reconcilor_factory.cc
    • chrome/browser/signin/chrome_signin_helper_unittest.cc
    • chrome/browser/signin/dice_browsertest.cc
    • chrome/browser/signin/dice_response_handler.cc
    • chrome/browser/signin/dice_response_handler_unittest.cc
    • chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
    • chrome/browser/signin/process_dice_header_delegate_impl.cc
    • chrome/browser/signin/process_dice_header_delegate_impl_unittest.cc
    • chrome/browser/signin/scoped_account_consistency.cc
    • chrome/browser/signin/scoped_account_consistency.h
    • chrome/browser/ui/views/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc
    • chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
    • chrome/browser/ui/webui/settings/people_handler_unittest.cc
    • components/signin/core/browser/about_signin_internals.cc
    • components/signin/core/browser/account_consistency_method.h
    • components/signin/core/browser/account_reconcilor_unittest.cc
    • components/signin/core/browser/dice_account_reconcilor_delegate.cc
    • components/signin/core/browser/dice_account_reconcilor_delegate_unittest.cc
    • components/signin/core/browser/dice_header_helper.cc
    • components/signin/core/browser/signin_header_helper_unittest.cc
  10. Deflake AddFirstWallpaperAnimationEndCallback test

    Changed by Alex Clarke - alexclarkeohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 12:18:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 82b82a8b8c4115741888bb0dfe3fcd439cff51e5

    Comments

    Deflake AddFirstWallpaperAnimationEndCallback test
    
    This test is currently flaky because it relies upon the ordering
    of delayed and non delayed tasks to quit a run loop before the
    very short (0.01s) animation delay is up. This patch deflakes it by
    temporarily freezing time to prevent the animation from
    completing before the test expects it to.
    
    TBR=wzang@chromium.org
    
    Bug: 863341, 891670, 910493
    Change-Id: I34cf2824c387c380134eb38b3375e6ab79de4be8
    Reviewed-on: https://chromium-review.googlesource.com/c/1365244
    Commit-Queue: Alex Clarke <alexclarke@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614322}

    Changed files

    • ash/wallpaper/wallpaper_controller_unittest.cc
  11. Fix race in scheduler fuzzer

    Changed by Carlos Caballero - carlscabohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 12:14:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7333851526d00cee593ca114d3394f77236fcaf8

    Comments

    Fix race in scheduler fuzzer
    
    ThreadManager instances are created on the new thread and thus their
    thread_manager_ member might not be initialized when GetThreadManagerFor
    is called.
    
    This patch addresses that issue by having two different containers. One
    to keep track of threads and the other for keeping track of all the
    ThreadManager instances.
    
    This code could use some nice refactoring, this patch just tries to do
    the minimum changes to get rid of the race.
    
    Bug: 906468
    Change-Id: Ie39f5a6a18111248c4f83264f6adcdaef4befa23
    Reviewed-on: https://chromium-review.googlesource.com/c/1365442
    Commit-Queue: Carlos Caballero <carlscab@google.com>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614321}

    Changed files

    • third_party/blink/renderer/platform/scheduler/test/fuzzer/sequence_manager_fuzzer_processor.cc
    • third_party/blink/renderer/platform/scheduler/test/fuzzer/sequence_manager_fuzzer_processor_unittest.cc
    • third_party/blink/renderer/platform/scheduler/test/fuzzer/simple_thread_impl.cc
    • third_party/blink/renderer/platform/scheduler/test/fuzzer/simple_thread_impl.h
    • third_party/blink/renderer/platform/scheduler/test/fuzzer/thread_pool_manager.cc
    • third_party/blink/renderer/platform/scheduler/test/fuzzer/thread_pool_manager.h
  12. Roll src/third_party/catapult 924d5cbc6627..285509d0e41e (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 12:14:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 24c8eb2bc2374d9dbcbf8ba39a1ad61cdb2d92e4

    Comments

    Roll src/third_party/catapult 924d5cbc6627..285509d0e41e (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/924d5cbc6627..285509d0e41e
    
    
    git log 924d5cbc6627..285509d0e41e --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 dtu@chromium.org [pinpoint] Add cpython to CIPD packages for Swarming tasks.
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@285509d0e41e
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:911511
    TBR=sullivan@chromium.org
    
    Change-Id: If17883c4c319c61a837806e819bd0b6c4bdbee28
    Reviewed-on: https://chromium-review.googlesource.com/c/1365412
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614320}

    Changed files

    • DEPS
  13. Roll src/third_party/webrtc c60a77731d68..518add35a8f3 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 11:51:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9578862335ad0c8697867c4e8a3aedce9746bd7d

    Comments

    Roll src/third_party/webrtc c60a77731d68..518add35a8f3 (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/c60a77731d68..518add35a8f3
    
    
    git log c60a77731d68..518add35a8f3 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 68c6b982a7..d6dec3971c (614157:614285)
    2018-12-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 48afe1fce1..68c6b982a7 (614046:614157)
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@518add35a8f3
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:None,chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Ie8e88fd34dcfea01fdf9936668312881d8648d7e
    Reviewed-on: https://chromium-review.googlesource.com/c/1365490
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614319}

    Changed files

    • DEPS
  14. Roll src-internal ed9aa80dbd6e..ddbf9b06e56d (3 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 11:44:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c3ab799cfe5c295341dd092769ec59df1d10b5e2

    Comments

    Roll src-internal ed9aa80dbd6e..ddbf9b06e56d (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed9aa80dbd6e..ddbf9b06e56d
    
    
    Created with:
      gclient setdep -r src-internal@ddbf9b06e56d
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ib4c1d177947f216078337b7a96776a364e186e1e
    Reviewed-on: https://chromium-review.googlesource.com/c/1365491
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614318}

    Changed files

    • DEPS
  15. Enable gold linker for arm64 linux builds

    Changed by Dániel Bátyai - dbatyaiohnoyoudont@inf.u-szeged.hu
    Changed at Thursday, 06-Dec-18 11:42:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 55fbf5947b5c36906b186bed99b4d029f87d4df3

    Comments

    Enable gold linker for arm64 linux builds
    
    Arm64 builds for chromeos do not currently use gold when linking.
    This change enables gold, which results in smaller binary size.
    
    Bug: 878565
    Change-Id: I70f24490ac010ce58bcc6fd1441ade63288147ad
    Reviewed-on: https://chromium-review.googlesource.com/c/1341913
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Peter Gal <pgal.u-szeged@partner.samsung.com>
    Cr-Commit-Position: refs/heads/master@{#614317}

    Changed files

    • build/config/compiler/compiler.gni
  16. Roll src/third_party/skia 6d59568196c0..7c4a9b7c7e0e (3 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 11:34:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e853d5eefbfcfc22851ff8b2f11f669cfa657207

    Comments

    Roll src/third_party/skia 6d59568196c0..7c4a9b7c7e0e (3 commits)
    
    https://skia.googlesource.com/skia.git/+log/6d59568196c0..7c4a9b7c7e0e
    
    
    git log 6d59568196c0..7c4a9b7c7e0e --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
    2018-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 96bd8fdf36e5..8f1b7a66a5e3 (3 commits)
    2018-12-06 herb@google.com Embed SkPath in SkGlyph::PathData
    
    
    Created with:
      gclient setdep -r src/third_party/skia@7c4a9b7c7e0e
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jcgregorio@chromium.org
    
    Change-Id: I498a50fb1a2fc65424f50214ad9a19d1a004788c
    Reviewed-on: https://chromium-review.googlesource.com/c/1365171
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614316}

    Changed files

    • DEPS
  17. Import wpt@0347da3996b8eb6c4aef1104291efcc5d5356e6d

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 11:25:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 00c7d1a7ee854a01504eff67389ce6bf972fbb5b

    Comments

    Import wpt@0347da3996b8eb6c4aef1104291efcc5d5356e6d
    
    Using wpt-import in Chromium 8fea47aacf80c5e06dc7246a9b3673525cf14b62.
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    NOAUTOREVERT=true
    TBR=raphael.kubo.da.costa
    
    No-Export: true
    Change-Id: I1f6ad756eb6eafe1416332c08f6f9edd7b030f93
    Reviewed-on: https://chromium-review.googlesource.com/c/1365077
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614315}

    Changed files

    • third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
    • third_party/blink/web_tests/external/wpt/event-timing/idlharness.any-expected.txt
    • third_party/blink/web_tests/external/wpt/event-timing/idlharness.any.serviceworker-expected.txt
    • third_party/blink/web_tests/external/wpt/event-timing/idlharness.any.sharedworker-expected.txt
    • third_party/blink/web_tests/external/wpt/event-timing/idlharness.any.worker-expected.txt
    • third_party/blink/web_tests/external/wpt/interfaces/event-timing.idl
  18. [iOS] Disable omnibox drag on iPhone

    Changed by Robbie Gibson - rkgibsonohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 11:14:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4b3f8cea2710992c552785fa2a57097576acce3e

    Comments

    [iOS] Disable omnibox drag on iPhone
    
    This CL disables dragging text out of the omnibox on iPhone because
    there is nowhere to drag the text to.
    
    Bug: 834778
    Change-Id: Ic5c731b8c5400c40e7357c5ff25e5a8e45f3e544
    Reviewed-on: https://chromium-review.googlesource.com/c/1363194
    Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
    Commit-Queue: Robbie Gibson <rkgibson@google.com>
    Cr-Commit-Position: refs/heads/master@{#614314}

    Changed files

    • ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
  19. Roll src/third_party/catapult c7cc237f9582..924d5cbc6627 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 10:57:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0d63eb573db6815ebb2c6820a45edec85b8da77d

    Comments

    Roll src/third_party/catapult c7cc237f9582..924d5cbc6627 (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/c7cc237f9582..924d5cbc6627
    
    
    git log c7cc237f9582..924d5cbc6627 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 benjhayden@chromium.org Add alerts-section for v2spa.
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@924d5cbc6627
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=sullivan@chromium.org
    
    Change-Id: I3ce19b927d52a7efb70f97d51f37cdb8bb4a68d0
    Reviewed-on: https://chromium-review.googlesource.com/c/1365170
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614313}

    Changed files

    • DEPS
  20. sqlite: Upgrade from 3.25.3 to 3.26.0

    Changed by Victor Costan - pwnallohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 10:57:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5c2a181a431696385df115c024debb2ca46bb362

    Comments

    sqlite: Upgrade from 3.25.3 to 3.26.0
    
    This CL removes the following patches:
    
    * patches/0006-fts3-Fix-uninit-variable-in-fts3EvalDeferredPhrase.patch
      was superseded by https://www.sqlite.org/src/info/6f4b0d0494446d46
    * patches/0009-Fix-ossfuzz.c-to-compile-and-run-with-our-config.patch
      was superseded by https://www.sqlite.org/src/info/d343f7d6b05865c2
    * patches/0010-Backport-Windows-VFS-mmap-fix.patch was a backport of
      3.26.0 change https://sqlite.org/src/info/ffce4aac18dacbf2
    
    This CL adds a workaround to our wrapper for SQLite's main header. The
    workaround is needed by the change at
    https://www.sqlite.org/src/info/d584a0cb51281594 which fixes a bug that
    was preventing us from building the SQLite shell on Windows.
    
    The most attractive feature in this version is the introduction of the
    SQLITE_DBCONFIG_DEFENSIVE config flag [1]. The flag will be enabled in a
    follow-up CL, after the upgrade proves stable.
    
    [1] https://www.sqlite.org/c3ref/c_dbconfig_defensive.html
    
    Bug: 910906
    Change-Id: I046dc5a1419188bb93be24fe0edaf536411d100d
    Reviewed-on: https://chromium-review.googlesource.com/c/1357358
    Commit-Queue: Victor Costan <pwnall@chromium.org>
    Reviewed-by: Chris Mumford <cmumford@google.com>
    Cr-Commit-Position: refs/heads/master@{#614312}

    Changed files

    • third_party/sqlite/README.chromium
    • third_party/sqlite/amalgamation/rename_exports.h
    • third_party/sqlite/amalgamation/shell/shell.c
    • third_party/sqlite/amalgamation/sqlite3.c
    • third_party/sqlite/amalgamation/sqlite3.h
    • third_party/sqlite/patches/0001-test-SQLite-tests-compiling-on-Linux.patch
    • third_party/sqlite/patches/0002-Modify-default-VFS-to-support-WebDatabase.patch
    • third_party/sqlite/patches/0003-Virtual-table-supporting-recovery-of-corrupted-datab.patch
    • third_party/sqlite/patches/0004-Custom-shell.c-helpers-to-load-Chromium-s-ICU-data.patch
    • third_party/sqlite/patches/0005-fts3-Disable-fts3_tokenizer-and-fts4.patch
    • third_party/sqlite/patches/0006-fts3-Fix-uninit-variable-in-fts3EvalDeferredPhrase.patch
    • third_party/sqlite/patches/0006-fuchsia-Use-dot-file-locking-for-sqlite.patch
    • third_party/sqlite/patches/0008-Fix-ossfuzz.c-to-compile-and-run-with-our-config.patch
    • third_party/sqlite/patches/0009-Backport-Windows-VFS-mmap-fix.patch
    • third_party/sqlite/sqlite3.h
    • third_party/sqlite/src/Makefile.in
    • third_party/sqlite/src/Makefile.msc
    • third_party/sqlite/src/VERSION
    • third_party/sqlite/src/configure
    • third_party/sqlite/src/doc/lemon.html
    • third_party/sqlite/src/ext/expert/sqlite3expert.c
    • third_party/sqlite/src/ext/fts3/fts3.c
    • third_party/sqlite/src/ext/fts3/fts3Int.h
    • third_party/sqlite/src/ext/fts3/fts3_aux.c
    • third_party/sqlite/src/ext/fts3/fts3_term.c
    • third_party/sqlite/src/ext/fts3/fts3_tokenize_vtab.c
    • third_party/sqlite/src/ext/fts5/fts5_index.c
    • third_party/sqlite/src/ext/fts5/fts5_main.c
    • third_party/sqlite/src/ext/fts5/fts5_test_tok.c
    • third_party/sqlite/src/ext/fts5/fts5_vocab.c
    • third_party/sqlite/src/ext/fts5/test/fts5aa.test
    • third_party/sqlite/src/ext/fts5/test/fts5connect.test
    • third_party/sqlite/src/ext/fts5/test/fts5corrupt.test
    • third_party/sqlite/src/ext/fts5/test/fts5corrupt2.test
    • third_party/sqlite/src/ext/fts5/test/fts5corrupt3.test
    • third_party/sqlite/src/ext/fts5/test/fts5first.test
    • third_party/sqlite/src/ext/fts5/test/fts5integrity.test
    • third_party/sqlite/src/ext/fts5/test/fts5rank.test
    • third_party/sqlite/src/ext/fts5/test/fts5rebuild.test
    • third_party/sqlite/src/ext/fts5/test/fts5rowid.test
    • third_party/sqlite/src/ext/fts5/test/fts5version.test
    • third_party/sqlite/src/ext/fts5/test/fts5vocab.test
    • third_party/sqlite/src/ext/fts5/test/fts5vocab2.test
    • third_party/sqlite/src/ext/misc/amatch.c
    • third_party/sqlite/src/ext/misc/btreeinfo.c
    • third_party/sqlite/src/ext/misc/closure.c
    • third_party/sqlite/src/ext/misc/completion.c
    • third_party/sqlite/src/ext/misc/csv.c
    • third_party/sqlite/src/ext/misc/explain.c
    • third_party/sqlite/src/ext/misc/fileio.c
    • third_party/sqlite/src/ext/misc/json1.c
    • third_party/sqlite/src/ext/misc/memstat.c
    • third_party/sqlite/src/ext/misc/series.c
    • third_party/sqlite/src/ext/misc/sha1.c
    • third_party/sqlite/src/ext/misc/shathree.c
    • third_party/sqlite/src/ext/misc/spellfix.c
    • third_party/sqlite/src/ext/misc/stmt.c
    • third_party/sqlite/src/ext/misc/templatevtab.c
    • third_party/sqlite/src/ext/misc/unionvtab.c
    • third_party/sqlite/src/ext/misc/vtablog.c
    • third_party/sqlite/src/ext/misc/zipfile.c
    • third_party/sqlite/src/ext/rbu/rbu1.test
    • third_party/sqlite/src/ext/rbu/rbu10.test
    • third_party/sqlite/src/ext/rbu/rbu11.test
    • third_party/sqlite/src/ext/rbu/rbu12.test
    • third_party/sqlite/src/ext/rbu/rbu13.test
    • third_party/sqlite/src/ext/rbu/rbu14.test
    • third_party/sqlite/src/ext/rbu/rbu3.test
    • third_party/sqlite/src/ext/rbu/rbu5.test
    • third_party/sqlite/src/ext/rbu/rbu6.test
    • third_party/sqlite/src/ext/rbu/rbu7.test
    • third_party/sqlite/src/ext/rbu/rbu8.test
    • third_party/sqlite/src/ext/rbu/rbu9.test
    • third_party/sqlite/src/ext/rbu/rbuA.test
    • third_party/sqlite/src/ext/rbu/rbuB.test
    • third_party/sqlite/src/ext/rbu/rbuC.test
    • third_party/sqlite/src/ext/rbu/rbucollate.test
    • third_party/sqlite/src/ext/rbu/rbucrash.test
    • third_party/sqlite/src/ext/rbu/rbucrash2.test
    • third_party/sqlite/src/ext/rbu/rbudiff.test
    • third_party/sqlite/src/ext/rbu/rbudor.test
    • third_party/sqlite/src/ext/rbu/rbufault.test
    • third_party/sqlite/src/ext/rbu/rbufault2.test
    • third_party/sqlite/src/ext/rbu/rbufault3.test
    • third_party/sqlite/src/ext/rbu/rbufault4.test
    • third_party/sqlite/src/ext/rbu/rbufts.test
    • third_party/sqlite/src/ext/rbu/rbumulti.test
    • third_party/sqlite/src/ext/rbu/rbuprogress.test
    • third_party/sqlite/src/ext/rbu/rburesume.test
    • third_party/sqlite/src/ext/rbu/rbusave.test
    • third_party/sqlite/src/ext/rbu/rbusplit.test
    • third_party/sqlite/src/ext/rbu/rbutemplimit.test
    • third_party/sqlite/src/ext/rbu/rbuvacuum.test
    • third_party/sqlite/src/ext/rbu/rbuvacuum2.test
    • third_party/sqlite/src/ext/rbu/sqlite3rbu.c
    • third_party/sqlite/src/ext/repair/test/checkindex01.test
    • third_party/sqlite/src/ext/rtree/geopoly.c
    • third_party/sqlite/src/ext/rtree/rtree.c
    • third_party/sqlite/src/ext/rtree/rtree8.test
    • third_party/sqlite/src/ext/rtree/rtreeA.test
    • third_party/sqlite/src/ext/rtree/rtreecheck.test
    • third_party/sqlite/src/ext/rtree/sqlite3rtree.h
    • third_party/sqlite/src/ext/rtree/visual01.txt
    • third_party/sqlite/src/ext/session/changesetfuzz.c
    • third_party/sqlite/src/ext/session/changesetfuzz1.test
    • third_party/sqlite/src/ext/session/session1.test
    • third_party/sqlite/src/ext/session/sessionC.test
    • third_party/sqlite/src/ext/session/sessionD.test
    • third_party/sqlite/src/ext/session/sessionE.test
    • third_party/sqlite/src/ext/session/sessionF.test
    • third_party/sqlite/src/ext/session/sessionG.test
    • third_party/sqlite/src/ext/session/sessionH.test
    • third_party/sqlite/src/ext/session/session_common.tcl
    • third_party/sqlite/src/ext/session/sessionfault2.test
    • third_party/sqlite/src/ext/session/sessioninvert.test
    • third_party/sqlite/src/ext/session/sessionrebase.test
    • third_party/sqlite/src/ext/session/sessionstat1.test
    • third_party/sqlite/src/ext/session/sessionwor.test
    • third_party/sqlite/src/ext/session/sqlite3session.c
    • third_party/sqlite/src/ext/session/sqlite3session.h
    • third_party/sqlite/src/ext/session/test_session.c
    • third_party/sqlite/src/main.mk
    • third_party/sqlite/src/manifest
    • third_party/sqlite/src/manifest.uuid
    • third_party/sqlite/src/src/alter.c
    • third_party/sqlite/src/src/attach.c
    • third_party/sqlite/src/src/auth.c
    • third_party/sqlite/src/src/btree.c
    • third_party/sqlite/src/src/build.c
    • third_party/sqlite/src/src/callback.c
    • third_party/sqlite/src/src/ctime.c
    • third_party/sqlite/src/src/dbpage.c
    • third_party/sqlite/src/src/dbstat.c
    • third_party/sqlite/src/src/delete.c
    • third_party/sqlite/src/src/expr.c
    • third_party/sqlite/src/src/fkey.c
    • third_party/sqlite/src/src/global.c
    • third_party/sqlite/src/src/hash.c
    • third_party/sqlite/src/src/insert.c
    • third_party/sqlite/src/src/loadext.c
    • third_party/sqlite/src/src/main.c
    • third_party/sqlite/src/src/os_unix.c
    • third_party/sqlite/src/src/os_win.c
    • third_party/sqlite/src/src/pager.c
    • third_party/sqlite/src/src/pager.h
    • third_party/sqlite/src/src/parse.y
    • third_party/sqlite/src/src/pcache.c
    • third_party/sqlite/src/src/pcache.h
    • third_party/sqlite/src/src/pcache1.c
    • third_party/sqlite/src/src/pragma.c
    • third_party/sqlite/src/src/pragma.h
    • third_party/sqlite/src/src/prepare.c
    • third_party/sqlite/src/src/resolve.c
    • third_party/sqlite/src/src/select.c
    • third_party/sqlite/src/src/shell.c.in
    • third_party/sqlite/src/src/sqlite.h.in
    • third_party/sqlite/src/src/sqlite3ext.h
    • third_party/sqlite/src/src/sqliteInt.h
    • third_party/sqlite/src/src/test1.c
    • third_party/sqlite/src/src/test_config.c
    • third_party/sqlite/src/src/test_intarray.c
    • third_party/sqlite/src/src/test_intarray.h
    • third_party/sqlite/src/src/test_onefile.c
    • third_party/sqlite/src/src/tokenize.c
    • third_party/sqlite/src/src/treeview.c
    • third_party/sqlite/src/src/update.c
    • third_party/sqlite/src/src/vacuum.c
    • third_party/sqlite/src/src/vdbe.c
    • third_party/sqlite/src/src/vdbeInt.h
    • third_party/sqlite/src/src/vdbeapi.c
    • third_party/sqlite/src/src/vdbeaux.c
    • third_party/sqlite/src/src/vdbemem.c
    • third_party/sqlite/src/src/vtab.c
    • third_party/sqlite/src/src/walker.c
    • third_party/sqlite/src/src/where.c
    • third_party/sqlite/src/src/whereInt.h
    • third_party/sqlite/src/src/wherecode.c
    • third_party/sqlite/src/src/whereexpr.c
    • third_party/sqlite/src/src/window.c
    • third_party/sqlite/src/test/alter.test
    • third_party/sqlite/src/test/alter2.test
    • third_party/sqlite/src/test/alterauth2.test
    • third_party/sqlite/src/test/altercol.test
    • third_party/sqlite/src/test/alterlegacy.test
    • third_party/sqlite/src/test/altermalloc.test
    • third_party/sqlite/src/test/altertab.test
    • third_party/sqlite/src/test/altertab2.test
    • third_party/sqlite/src/test/analyze.test
    • third_party/sqlite/src/test/attach.test
    • third_party/sqlite/src/test/attachmalloc.test
    • third_party/sqlite/src/test/autoinc.test
    • third_party/sqlite/src/test/autoindex5.test
    • third_party/sqlite/src/test/bestindex4.test
    • third_party/sqlite/src/test/bestindex5.test
    • third_party/sqlite/src/test/capi3.test
    • third_party/sqlite/src/test/capi3c.test
    • third_party/sqlite/src/test/corrupt.test
    • third_party/sqlite/src/test/corrupt2.test
    • third_party/sqlite/src/test/corrupt5.test
    • third_party/sqlite/src/test/corruptI.test
    • third_party/sqlite/src/test/corruptK.test
    • third_party/sqlite/src/test/countofview.test
    • third_party/sqlite/src/test/crash5.test
    • third_party/sqlite/src/test/csv01.test
    • third_party/sqlite/src/test/dbfuzz2-seed1.db
    • third_party/sqlite/src/test/dbfuzz2.c
    • third_party/sqlite/src/test/dbpage.test
    • third_party/sqlite/src/test/dbstatus.test
    • third_party/sqlite/src/test/default.test
    • third_party/sqlite/src/test/e_fkey.test
    • third_party/sqlite/src/test/e_fts3.test
    • third_party/sqlite/src/test/e_reindex.test
    • third_party/sqlite/src/test/fkey2.test
    • third_party/sqlite/src/test/fts3auto.test
    • third_party/sqlite/src/test/fts3corrupt.test
    • third_party/sqlite/src/test/fts3corrupt2.test
    • third_party/sqlite/src/test/fts3corrupt3.test
    • third_party/sqlite/src/test/fts3corrupt4.test
    • third_party/sqlite/src/test/fts3cov.test
    • third_party/sqlite/src/test/fts3d.test
    • third_party/sqlite/src/test/fts3defer.test
    • third_party/sqlite/src/test/fts3defer2.test
    • third_party/sqlite/src/test/fts3matchinfo.test
    • third_party/sqlite/src/test/fts3misc.test
    • third_party/sqlite/src/test/fts3query.test
    • third_party/sqlite/src/test/fts3snippet.test
    • third_party/sqlite/src/test/fts4check.test
    • third_party/sqlite/src/test/fts4growth.test
    • third_party/sqlite/src/test/fts4merge.test
    • third_party/sqlite/src/test/fts4opt.test
    • third_party/sqlite/src/test/fuzz_malloc.test
    • third_party/sqlite/src/test/fuzzcheck.c
    • third_party/sqlite/src/test/fuzzdata7.db
    • third_party/sqlite/src/test/incrblob_err.test
    • third_party/sqlite/src/test/incrvacuum.test
    • third_party/sqlite/src/test/index.test
    • third_party/sqlite/src/test/index3.test
    • third_party/sqlite/src/test/indexexpr2.test
    • third_party/sqlite/src/test/intarray.test
    • third_party/sqlite/src/test/lemon-test01.y
    • third_party/sqlite/src/test/like3.test
    • third_party/sqlite/src/test/loadext.test
    • third_party/sqlite/src/test/malloctraceviewer.tcl
    • third_party/sqlite/src/test/misc1.test
    • third_party/sqlite/src/test/misc4.test
    • third_party/sqlite/src/test/misc5.test
    • third_party/sqlite/src/test/misc7.test
    • third_party/sqlite/src/test/mjournal.test
    • third_party/sqlite/src/test/normalize.test
    • third_party/sqlite/src/test/notnull.test
    • third_party/sqlite/src/test/ossfuzz.c
    • third_party/sqlite/src/test/pager1.test
    • third_party/sqlite/src/test/parser1.test
    • third_party/sqlite/src/test/permutations.test
    • third_party/sqlite/src/test/pragma.test
    • third_party/sqlite/src/test/pragma3.test
    • third_party/sqlite/src/test/pragma4.test
    • third_party/sqlite/src/test/printf.test
    • third_party/sqlite/src/test/releasetest.tcl
    • third_party/sqlite/src/test/resetdb.test
    • third_party/sqlite/src/test/shared.test
    • third_party/sqlite/src/test/shared8.test
    • third_party/sqlite/src/test/shell1.test
    • third_party/sqlite/src/test/snapshot2.test
    • third_party/sqlite/src/test/snapshot3.test
    • third_party/sqlite/src/test/snapshot4.test
    • third_party/sqlite/src/test/snapshot_up.test
    • third_party/sqlite/src/test/swarmvtab3.test
    • third_party/sqlite/src/test/swarmvtabfault.test
    • third_party/sqlite/src/test/tabfunc01.test
    • third_party/sqlite/src/test/table.test
    • third_party/sqlite/src/test/tableapi.test
    • third_party/sqlite/src/test/tempdb2.test
    • third_party/sqlite/src/test/tester.tcl
    • third_party/sqlite/src/test/trigger7.test
    • third_party/sqlite/src/test/triggerA.test
    • third_party/sqlite/src/test/triggerE.test
    • third_party/sqlite/src/test/unionvtab.test
    • third_party/sqlite/src/test/unionvtabfault.test
    • third_party/sqlite/src/test/vtab1.test
    • third_party/sqlite/src/test/vtab_err.test
    • third_party/sqlite/src/test/wal64k.test
    • third_party/sqlite/src/test/wherelimit2.test
    • third_party/sqlite/src/test/window1.test
    • third_party/sqlite/src/test/window5.test
    • third_party/sqlite/src/test/window6.test
    • third_party/sqlite/src/test/windowfault.test
    • third_party/sqlite/src/test/without_rowid3.test
    • third_party/sqlite/src/test/zipfile.test
    • third_party/sqlite/src/test/zipfile2.test
    • third_party/sqlite/src/tool/genfkey.test
    • third_party/sqlite/src/tool/lempar.c
    • third_party/sqlite/src/tool/mkpragmatab.tcl
    • third_party/sqlite/src/tool/sqldiff.c
    • third_party/sqlite/src/tool/warnings.sh
  21. Add CheckTextButtonCellButtonText() into ChromeTableViewControllerTest

    Changed by Huanzhong Huang - huanzhongohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 10:56:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c179c83c8fa54f065676aaa8d43a197150cb9e6c

    Comments

    Add CheckTextButtonCellButtonText() into ChromeTableViewControllerTest
    
    To allow checks for |buttonText|.
    
    Change-Id: I367876e36e669b56a2dc4cd436665bd600be398e
    Reviewed-on: https://chromium-review.googlesource.com/c/1356716
    Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614311}

    Changed files

    • ios/chrome/browser/ui/table_view/chrome_table_view_controller_test.h
    • ios/chrome/browser/ui/table_view/chrome_table_view_controller_test.mm
  22. Worker: Move shared_worker_host.mojom from content/ to blink/ (Onion Soup)

    Changed by Hiroki Nakagawa - nhirokiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 10:55:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 86d9e0e9690613df6b2303795e9366e960e243bd

    Comments

    Worker: Move shared_worker_host.mojom from content/ to blink/ (Onion Soup)
    
    Bug: 911415
    Change-Id: If442d03c009fd934dc4f6700b63dc435af381093
    Reviewed-on: https://chromium-review.googlesource.com/c/1364993
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614310}

    Changed files

    • content/browser/worker_host/mock_shared_worker.cc
    • content/browser/worker_host/mock_shared_worker.h
    • content/browser/worker_host/shared_worker_host.cc
    • content/browser/worker_host/shared_worker_host.h
    • content/browser/worker_host/shared_worker_host_unittest.cc
    • content/browser/worker_host/shared_worker_service_impl_unittest.cc
    • content/common/BUILD.gn
    • content/common/shared_worker/shared_worker_factory.mojom
    • content/renderer/shared_worker/embedded_shared_worker_stub.cc
    • content/renderer/shared_worker/embedded_shared_worker_stub.h
    • content/renderer/shared_worker/shared_worker_factory_impl.cc
    • content/renderer/shared_worker/shared_worker_factory_impl.h
    • third_party/blink/public/mojom/BUILD.gn
    • third_party/blink/public/mojom/worker/shared_worker_host.mojom
  23. Roll src/third_party/dawn e2f948469c66..bdd887fce76c (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 10:45:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0c858fb5c4a474f690eb450b923e72c298be5d8a

    Comments

    Roll src/third_party/dawn e2f948469c66..bdd887fce76c (2 commits)
    
    https://dawn.googlesource.com/dawn.git/+log/e2f948469c66..bdd887fce76c
    
    
    git log e2f948469c66..bdd887fce76c --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 kainino@chromium.org Revert "Create new src/tests BUILD.gn file."
    2018-12-05 senorblanco@chromium.org Create new src/tests BUILD.gn file.
    
    
    Created with:
      gclient setdep -r src/third_party/dawn@bdd887fce76c
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=cwallez@chromium.org
    
    Change-Id: If083040df65451a828b022bd4e3c95be0c9c3473
    Reviewed-on: https://chromium-review.googlesource.com/c/1365174
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614309}

    Changed files

    • DEPS
  24. [scheduler] Moving the clock parameter to Settings.

    Changed by Karolina Soltys - ksoltohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 10:41:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision afa5205ccbece4cb80c1b8931a4e52fc9bcf4749

    Comments

    [scheduler] Moving the clock parameter to Settings.
    Follow-up to patch 1353921.
    
    Bug: 891670
    Change-Id: Ibae12547f3550debeda11cc400b6cb1b6eabfca9
    Reviewed-on: https://chromium-review.googlesource.com/c/1363206
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Commit-Queue: Karolina Soltys <ksolt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614308}

    Changed files

    • base/task/sequence_manager/sequence_manager.h
    • base/task/sequence_manager/sequence_manager_impl.cc
    • base/task/sequence_manager/sequence_manager_impl.h
    • base/task/sequence_manager/time_domain_unittest.cc
  25. Add is_hardware_accelerated and has_internal_source to EncoderInfo

    Changed by Mirta Dvornicic - mirtadohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 10:40:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 27c6bb9bd68ef8f1f959a7acf97c92ec5182446c

    Comments

    Add is_hardware_accelerated and has_internal_source to EncoderInfo
    
    webrtc::VideoEncoderFactory::CodecInfo properties are being moved to
    webrtc::VideoEncoder::EncoderInfo, see: https://crbug.com/webrtc/10065.
    
    Bug: webrtc:10065
    Change-Id: Ib74503c5390f4f3c148a8039005a28870733a974
    Reviewed-on: https://chromium-review.googlesource.com/c/1358061
    Commit-Queue: Mirta Dvornicic <mirtad@google.com>
    Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614307}

    Changed files

    • content/renderer/media/webrtc/rtc_video_encoder.cc
    • remoting/protocol/webrtc_dummy_video_encoder.cc
    • remoting/protocol/webrtc_dummy_video_encoder.h
  26. Disable disable_observer_list_unittest.nc

    Changed by Hans Wennborg - hansohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 10:40:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b8a149309d01fa018dba3f5957be945cb503cbc4

    Comments

    Disable disable_observer_list_unittest.nc
    
    It fails with tip-of-tree Clang because the diagnositics have changed
    slightly. Disable for now and possible re-enable with updated
    expectations after the next Clang roll.
    
    TBR=thakis
    
    Bug: 912021
    Change-Id: Ib0d83178ea5c38fa2d19ada720e8526437c916fd
    Reviewed-on: https://chromium-review.googlesource.com/c/1365434
    Reviewed-by: Hans Wennborg <hans@chromium.org>
    Commit-Queue: Hans Wennborg <hans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614306}

    Changed files

    • base/BUILD.gn
    • base/observer_list_unittest.nc
  27. Fix viewport calculation for Link: header preload

    Changed by Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 10:30:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ad030e8d499b927c623fa2715f95fde38c44cdd8

    Comments

    Fix viewport calculation for Link: header preload
    
    This fixes a bug that viewport width was evaluated to zero
    when evaluating media queries from Link: rel=preload headers, if
    "width=device-width" was specified in <meta name="viewport">.
    
    viewport_description->max_width has type = kDeviceWidth and value = 0
    in such case, so device width must be resolved before overriding
    viewport dimensions.
    
    Note: HTMLPreloadScanner is already doing this, in HandleMetaViewport().
    
    Bug: 590188
    Change-Id: Iffb0e031e0316bd41aaf52014609d5e7d0b32284
    Reviewed-on: https://chromium-review.googlesource.com/c/1360209
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614305}

    Changed files

    • third_party/blink/renderer/core/loader/link_loader.cc
    • third_party/blink/web_tests/http/tests/preload/meta-viewport-device-width-link-headers.html
    • third_party/blink/web_tests/http/tests/preload/resources/media-link-headers-device-width.php
    • third_party/blink/web_tests/http/tests/preload/resources/media-link-headers-imagesrcset.php
  28. Roll src-internal baf62bde47d2..ed9aa80dbd6e (3 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 10:25:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision daae39a75dd01f787e5176d0fc7494282920909f

    Comments

    Roll src-internal baf62bde47d2..ed9aa80dbd6e (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/baf62bde47d2..ed9aa80dbd6e
    
    
    Created with:
      gclient setdep -r src-internal@ed9aa80dbd6e
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Iff2613e7527e25d3f2621fb252220a890fc26b8e
    Reviewed-on: https://chromium-review.googlesource.com/c/1365411
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614304}

    Changed files

    • DEPS
  29. Reland "cros: Fix DCHECK for rlz_lib::UpdateExistingAccessPointRlz"

    Changed by Jérôme Lebel - jlebelohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 10:13:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0d2a5a88a940d3df25c6a074824adb6a901e099f

    Comments

    Reland "cros: Fix DCHECK for rlz_lib::UpdateExistingAccessPointRlz"
    
    This is a reland of 1d497322e9fd8d9ab1da00767e30c618186151c6
    
    This patch also includes implementation for:
    RLZTrackerDelegateImpl::ShouldUpdateExistingAccessPointRlz()
    
    Original change's description:
    > cros: Fix DCHECK for rlz_lib::UpdateExistingAccessPointRlz
    >
    > In addition to fixing the DCHECK, this CL contains a speculative fix
    > for flaky test (crbug.com/907379). The guess for the flakiness is
    > (not able to repro the failure locally though):
    >
    > |RecordProductEvent| may fail to acquire the |ScopedRlzValueStoreLock|
    > when recording the CAI event, because the lock is being taken by
    > |UpdateExistingAccessPointRlz|. In tests, the delay for
    > |ScheduleDelayedInit| is set to zero, so it's possible for this race
    > condition to happen. But in production, the delay is non-zero.
    >
    > I don't think we're losing test coverage by disabling
    > |UpdateExistingAccessPointRlz| here because the call is a no-op in
    > tests, and another test (RlzLibTest.UpdateExistingAccessPointRlz) is
    > testing its implementation.
    >
    > Bug: 906293, 907379
    > Change-Id: I208919f22edc09fc1a739a1efe1909a71e5a2730
    > Reviewed-on: https://chromium-review.googlesource.com/c/1353990
    > Reviewed-by: Roger Tawa <rogerta@chromium.org>
    > Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#613172}
    
    Bug: 906293, 907379, 911439
    Change-Id: Ic1d9f85bc3714f890d2dc7fcc1d070d0711baec0
    Reviewed-on: https://chromium-review.googlesource.com/c/1360692
    Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
    Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Reviewed-by: Roger Tawa <rogerta@chromium.org>
    Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614303}

    Changed files

    • chrome/browser/rlz/chrome_rlz_tracker_delegate.cc
    • chrome/browser/rlz/chrome_rlz_tracker_delegate.h
    • components/rlz/rlz_tracker.cc
    • components/rlz/rlz_tracker_delegate.h
    • components/rlz/rlz_tracker_unittest.cc
    • ios/chrome/browser/rlz/rlz_tracker_delegate_impl.cc
    • ios/chrome/browser/rlz/rlz_tracker_delegate_impl.h
  30. Rename MojoLayoutTestHelper to MojoWebTestHelper

    Changed by Kent Tamura - tkentohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 10:11:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 860eb4082747c24078c9de9f0ad2150c908db4d0

    Comments

    Rename MojoLayoutTestHelper to MojoWebTestHelper
    
    mojo_layouttest_test.mojom is renamed to
    mojo_web_test_helper_test.mojom. It keeps _test suffix indicating it
    affects only tests.
    
    Bug: 843412
    Change-Id: Iddfdfcbfd87228fb9ee8abd2777f4838c4b66801
    Reviewed-on: https://chromium-review.googlesource.com/c/1362717
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614302}

    Changed files

    • BUILD.gn
    • content/shell/BUILD.gn
    • content/shell/browser/content_shell_browser_manifest_overlay.json
    • content/shell/browser/web_test/mojo_web_test_helper.cc
    • content/shell/browser/web_test/mojo_web_test_helper.h
    • content/shell/browser/web_test/web_test_content_browser_client.cc
    • content/test/BUILD.gn
    • content/test/data/mojo_web_test_helper_test.mojom
    • third_party/blink/web_tests/external/wpt/bluetooth/resources/bluetooth-helpers.js
    • third_party/blink/web_tests/external/wpt/resources/chromium/mojo_layouttest_test.mojom.js
    • third_party/blink/web_tests/external/wpt/resources/chromium/mojo_web_test_helper_test.mojom.js
    • third_party/blink/web_tests/external/wpt/resources/chromium/mojo_web_test_helper_test.mojom.js.headers
    • third_party/blink/web_tests/mojo/bind-interface.html
    • third_party/blink/web_tests/mojo/detached-frame.html
    • third_party/blink/web_tests/mojo/resources/bind-intercepted-interface-in-worker.js
    • third_party/blink/web_tests/mojo/resources/helpers.js
  31. Add a `run_web_tests.py --no-manifest-update` option

    Changed by Philip Jägenstedt - foolipohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 10:11:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6a79321c87f697c14646dbe75c7408c15c52b2f7

    Comments

    Add a `run_web_tests.py --no-manifest-update` option
    
    This is like the `./wpt run --no-manifest-update` in upstream wpt:
    https://github.com/web-platform-tests/wpt/blob/81607985fc9485cbf9f3d0a8ae74359f885eb36b/tools/wptrunner/wptrunner/wptcommandline.py#L52-L53
    
    Because updating the manifest is pretty slow, this reduces the time to
    run a few tests over and over in development when the manifest is not
    changing.
    
    On a Linux workstation, the time to run a single test
    (dom/historical.html) went from ~14s to ~7s.
    
    Bug: 905406
    Change-Id: I50e4b8bdd9d3bedbf1e31bc34a2338317a30aaf0
    Reviewed-on: https://chromium-review.googlesource.com/c/1361874
    Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
    Reviewed-by: Doug Turner <dougt@chromium.org>
    Reviewed-by: Luke Z <lpz@chromium.org>
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Cr-Commit-Position: refs/heads/master@{#614301}

    Changed files

    • third_party/blink/tools/blinkpy/web_tests/controllers/manager.py
    • third_party/blink/tools/blinkpy/web_tests/port/base.py
    • third_party/blink/tools/blinkpy/web_tests/run_webkit_tests.py
  32. [Autofill Assistant] Fixed SetFieldValue() to support UTF-8 text.

    Changed by Clemens Arbesser - arbesserohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 10:09:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bec01af6dded902830ed08f80fefc816e5f4fdf9

    Comments

    [Autofill Assistant] Fixed SetFieldValue() to support UTF-8 text.
    
    Also in this CL:
     - refactoring of parts of the backend to remove redundant and potentially error-prone code
     - modified unit tests for web_controller to test for UTF-8 compliance of SetFieldValue()
    
    Change-Id: Ib7dd2429159a527ec81f325622e8bf6f97c5e5ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1360691
    Commit-Queue: Clemens Arbesser <arbesser@google.com>
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614300}

    Changed files

    • components/autofill_assistant/browser/actions/action_delegate.h
    • components/autofill_assistant/browser/actions/mock_action_delegate.h
    • components/autofill_assistant/browser/actions/set_form_field_value_action.cc
    • components/autofill_assistant/browser/script_executor.cc
    • components/autofill_assistant/browser/script_executor.h
    • components/autofill_assistant/browser/web_controller.cc
    • components/autofill_assistant/browser/web_controller.h
    • components/autofill_assistant/browser/web_controller_browsertest.cc
  33. [iOS][MF] Remove extra loading indicator

    Changed by Javier Ernesto Flores Robles - javierroblesohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 09:57:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d038d4d49e0ae80b8ce1c7dcb6bac1e365778942

    Comments

    [iOS][MF] Remove extra loading indicator
    
    Only add the loading indicator if the model hasn't been created
    
    Bug: 912085
    Change-Id: I0d557013eeb63cf882793460a342e22485fa48d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1363179
    Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
    Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614299}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.mm
  34. Move FTP directory listing from content/renderer/loader to Blink

    Changed by Yutaka Hirano - yhiranoohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 09:56:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2046dd28639651936de4e8ec6b74fbf7a26c5545

    Comments

    Move FTP directory listing from content/renderer/loader to Blink
    
    In order to WebDataConsumerHandle deprecation easy, move
    content::FtpDirectoryListingResponseDelegate to blink.
    
    Bug: 910489
    Change-Id: I878df1c90c28de1c3f44d9ed48e518207fa831c5
    Reviewed-on: https://chromium-review.googlesource.com/c/1358315
    Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Reviewed-by: Nate Chapin <japhet@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614298}

    Changed files

    • content/renderer/BUILD.gn
    • content/renderer/loader/ftp_directory_listing_response_delegate.cc
    • content/renderer/loader/ftp_directory_listing_response_delegate.h
    • content/renderer/loader/web_url_loader_impl.cc
    • content/renderer/loader/web_url_loader_impl_unittest.cc
    • content/renderer/loader/weburlresponse_extradata_impl.cc
    • content/renderer/loader/weburlresponse_extradata_impl.h
    • content/renderer/render_frame_impl.cc
    • third_party/blink/public/web/web_document_loader.h
    • third_party/blink/renderer/core/exported/web_document_loader_impl.cc
    • third_party/blink/renderer/core/exported/web_document_loader_impl.h
    • third_party/blink/renderer/core/loader/document_loader.cc
    • third_party/blink/renderer/core/loader/document_loader.h
    • third_party/blink/renderer/platform/loader/BUILD.gn
    • third_party/blink/renderer/platform/loader/DEPS
    • third_party/blink/renderer/platform/loader/ftp_directory_listing.cc
    • third_party/blink/renderer/platform/loader/ftp_directory_listing.h
    • third_party/blink/renderer/platform/loader/ftp_directory_listing_test.cc
  35. Roll src/third_party/angle 8f1b7a66a5e3..d300548fcc28 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 09:38:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 11e903b61b49feff17e97ed5fe8060f23d16900e

    Comments

    Roll src/third_party/angle 8f1b7a66a5e3..d300548fcc28 (1 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/8f1b7a66a5e3..d300548fcc28
    
    
    git log 8f1b7a66a5e3..d300548fcc28 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 enga@chromium.org Add ANGLE_multi_draw entrypoints to proc table
    
    
    Created with:
      gclient setdep -r src/third_party/angle@d300548fcc28
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:890539
    TBR=ynovikov@chromium.org
    
    Change-Id: Id92afc679acf0f0e00f46fba3d8806da8987f4d1
    Reviewed-on: https://chromium-review.googlesource.com/c/1365175
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614297}

    Changed files

    • DEPS
  36. Remove CheckValidityEventBehavior.

    Changed by Kent Tamura - tkentohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 09:28:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5dea9d09e55412e6648f68a8e9326d95557888d0

    Comments

    Remove CheckValidityEventBehavior.
    
    The behavior of ListedElement::checkValidity() with
    kCheckValidityDispatchNoEvent was very simple. This CL introduces
    IsNotCandidateOrValid() for that behavior, and removes
    CheckValidityEventBehavior argument of checkValidity().
    
    Change-Id: Ieff28ada30cc47d8617e73306d874cdfa9dee43c
    Reviewed-on: https://chromium-review.googlesource.com/c/1364990
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Reviewed-by: Keishi Hattori <keishi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614296}

    Changed files

    • third_party/blink/renderer/core/html/forms/html_field_set_element.cc
    • third_party/blink/renderer/core/html/forms/html_form_element.cc
    • third_party/blink/renderer/core/html/forms/html_form_element.h
    • third_party/blink/renderer/core/html/forms/listed_element.cc
    • third_party/blink/renderer/core/html/forms/listed_element.h
    • third_party/blink/renderer/core/html/html_element.cc
    • third_party/blink/renderer/core/html/html_element.h
    • third_party/blink/renderer/modules/accessibility/ax_node_object.cc
  37. Flip S13nServiceWorker virtual test to disable the flag

    Changed by Makoto Shimazu - shimazuohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 09:23:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31c1d53ebce0214351eb9c4e9c7d7f5d7e34a78e

    Comments

    Flip S13nServiceWorker virtual test to disable the flag
    
    Currently NetS13nServiceWorker is enabled by default, and we don't have tests
    excercising non-S13nServiceWorker path. This flips the test to enable
    S13nServiceWorker to disabling S13nServiceWorker forcefully.
    
    Bug: 715640
    Change-Id: I8ba3401989dcd9da46e24cd7dc0500f66a200741
    Reviewed-on: https://chromium-review.googlesource.com/c/1365050
    Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614295}

    Changed files

    • third_party/blink/web_tests/FlagExpectations/enable-features=NetworkService
    • third_party/blink/web_tests/NeverFixTests
    • third_party/blink/web_tests/SlowTests
    • third_party/blink/web_tests/TestExpectations
    • third_party/blink/web_tests/VirtualTestSuites
    • third_party/blink/web_tests/virtual/disabled-service-worker-servicification/external/wpt/service-workers/service-worker/README.txt
    • third_party/blink/web_tests/virtual/disabled-service-worker-servicification/http/tests/serviceworker/README.txt
    • third_party/blink/web_tests/virtual/service-worker-servicification/external/wpt/service-workers/service-worker/README.txt
    • third_party/blink/web_tests/virtual/service-worker-servicification/http/tests/serviceworker/README.txt
    • third_party/blink/web_tests/virtual/service-worker-servicification/http/tests/serviceworker/navigation_preload/use-counter-expected.txt
  38. Roll src-internal 3dc3d8f696a7..baf62bde47d2 (9 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 09:12:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ad058b0d0c95e8cbdf14f26c7886c52d5d1aa110

    Comments

    Roll src-internal 3dc3d8f696a7..baf62bde47d2 (9 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3dc3d8f696a7..baf62bde47d2
    
    
    Created with:
      gclient setdep -r src-internal@baf62bde47d2
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I405f390d1485db257fc26dca9ad21eede7227b0f
    Reviewed-on: https://chromium-review.googlesource.com/c/1365173
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614294}

    Changed files

    • DEPS
  39. [App Management] Add FakePageHandler

    Changed by Reka Norman - rekanormanohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 09:11:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3dd7e3574c242e0e4544fe8d7e1780f4c588f614

    Comments

    [App Management] Add FakePageHandler
    
    This CL adds a fake page handler to the app management page which is used when
    accessing chrome://apps?fakeBackend=true.
    
    Bug: 906508
    Change-Id: Ib92a66a45b312efd14b5fb038d7cc506944dd716
    Reviewed-on: https://chromium-review.googlesource.com/c/1360034
    Commit-Queue: calamity <calamity@chromium.org>
    Reviewed-by: calamity <calamity@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614293}

    Changed files

    • chrome/browser/browser_resources.grd
    • chrome/browser/resources/app_management/BUILD.gn
    • chrome/browser/resources/app_management/browser_proxy.html
    • chrome/browser/resources/app_management/browser_proxy.js
    • chrome/browser/resources/app_management/fake_page_handler.js
    • chrome/browser/ui/webui/app_management/app_management_ui.cc
  40. Fix a typo in ResumableDelayedTaskRunner class comment.

    Changed by Mohamed Amir Yosef - mamirohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 09:02:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2b2cd20b5972267a83ede700e622f7d2392a3474

    Comments

    Fix a typo in ResumableDelayedTaskRunner class comment.
    
    This CL introduced the ResumableTaskRunner:
    https://chromium-review.googlesource.com/c/chromium/src/+/1353946
    
    In the class comment where we describe how to make use of the class,
    one of the lines was not updated with the rest during the last
    iterations of the review, leaving the example code incorrect.
    
    This CL just ensures that we are using consistent variable naming
    throughout the example.
    
    Bug: 909682
    
    Change-Id: I67666306888909e867f624dddb85d003e24604e6
    Reviewed-on: https://chromium-review.googlesource.com/c/1363284
    Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
    Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614292}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/invalidation/ResumableDelayedTaskRunner.java
  41. add "Chromium Mac Goma RBE Staging" and "Chromium Mac RBE Goma Staging (dbg)"

    Changed by Fumitoshi Ukai - ukaiohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 09:01:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5f11bc1c065271288d74f2d865f16a82dadaf00d

    Comments

    add "Chromium Mac Goma RBE Staging" and "Chromium Mac RBE Goma Staging (dbg)"
    
    Bug: 901708, 901706
    Change-Id: I7eaaf7434a465be2020d7e81ebf08e8d5ca93ba6
    Reviewed-on: https://chromium-review.googlesource.com/c/1360452
    Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
    Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614291}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
    • infra/config/global/luci-milo.cfg
    • infra/config/global/luci-scheduler.cfg
    • testing/buildbot/chromium.goma.json
    • testing/buildbot/waterfalls.pyl
    • tools/mb/mb_config.pyl
  42. Revert "Add console message in MixedContentChecker::HandleCertificateError"

    Changed by Rakina Zata Amni - rakinaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 08:59:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e092dc1b1477a1192745054d5885eb50cdfd8b2f

    Comments

    Revert "Add console message in MixedContentChecker::HandleCertificateError"
    
    This reverts commit dcfa99386d0b0f91107fdb8c248be833ba18fd25.
    
    Reason for revert: Caused flaky tests: crbug.com/912431
    
    Original change's description:
    > Add console message in MixedContentChecker::HandleCertificateError
    > 
    > Print console message when subresources are loaded over broken HTTPS.
    > Screenshot: https://drive.google.com/file/d/1Sn_2c162NmvCoIXFuFVB68z-MhzphcNT/view?usp=sharing
    > 
    > Bug: 587168
    > Change-Id: I997a8da26f0fe015cc0103b96dcbaa7d40525eb8
    > Reviewed-on: https://chromium-review.googlesource.com/c/1306779
    > Commit-Queue: Livvie Lin <livvielin@chromium.org>
    > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
    > Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    > Reviewed-by: Mike West <mkwst@chromium.org>
    > Reviewed-by: Scott Violet <sky@chromium.org>
    > Reviewed-by: Nate Chapin <japhet@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614212}
    
    TBR=sky@chromium.org,meacer@chromium.org,yhirano@chromium.org,japhet@chromium.org,mkwst@chromium.org,livvielin@chromium.org
    
    Change-Id: I9142c895af7dd1c6a4c9ea7500ee0eca2ce9d118
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 587168, 912431
    Reviewed-on: https://chromium-review.googlesource.com/c/1364974
    Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
    Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614290}

    Changed files

    • chrome/browser/favicon/content_favicon_driver_browsertest.cc
    • chrome/browser/ssl/ssl_browsertest.cc
    • third_party/blink/renderer/core/loader/mixed_content_checker.cc
    • third_party/blink/web_tests/http/tests/cache/history-only-cached-subresource-loads-max-age-https-expected.txt
    • third_party/blink/web_tests/http/tests/fetch/serviceworker/thorough/scheme-blob-base-https-other-https-expected.txt
    • third_party/blink/web_tests/http/tests/fetch/serviceworker/thorough/scheme-blob-expected.txt
    • third_party/blink/web_tests/http/tests/fetch/serviceworker/thorough/scheme-blob-other-https-expected.txt
    • third_party/blink/web_tests/http/tests/mixed-autoupgrade/optionally/image-upgrade-console-message.https-expected.txt
    • third_party/blink/web_tests/http/tests/navigation/ping-cross-origin-from-https-expected.txt
    • third_party/blink/web_tests/http/tests/security/contentSecurityPolicy/register-bypassing-scheme-script.https-expected.txt
    • third_party/blink/web_tests/http/tests/security/mixedContent/active-subresource-in-iframe-blocked.https-expected.txt
    • third_party/blink/web_tests/http/tests/security/mixedContent/insecure-css-image-with-reload-expected.txt
    • third_party/blink/web_tests/http/tests/security/mixedContent/insecure-css-resources-expected.txt
    • third_party/blink/web_tests/http/tests/security/mixedContent/insecure-fetch-on-dedicated-worker-allowed.https-expected.txt
    • third_party/blink/web_tests/http/tests/security/mixedContent/insecure-fetch-on-dedicated-worker-blocked.https-expected.txt
    • third_party/blink/web_tests/http/tests/security/mixedContent/insecure-iframe-with-hsts.https-expected.txt
    • third_party/blink/web_tests/http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame-expected.txt
    • third_party/blink/web_tests/http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt
    • third_party/blink/web_tests/http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt
    • third_party/blink/web_tests/http/tests/security/mixedContent/strict-mode-image-in-frame-blocked.https-expected.txt
    • third_party/blink/web_tests/http/tests/security/referrer-on-client-redirect-expected.txt
    • third_party/blink/web_tests/http/tests/security/referrer-policy-attribute-img-no-referrer-when-downgrade-expected.txt
    • third_party/blink/web_tests/http/tests/security/xssAuditor/report-script-tag-cross-origin-https-expected.txt
  43. Convert InlineLoginHandlerImpl to IdentityManager

    Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com
    Changed at Thursday, 06-Dec-18 08:54:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8fea47aacf80c5e06dc7246a9b3673525cf14b62

    Comments

    Convert InlineLoginHandlerImpl to IdentityManager
    
    Replace usage of SigninManager's API with calls to APIs from the
    IdentityManager and PrimaryAccountMutator.
    
    Bug: 890813
    Change-Id: I1a70a47e41aa132f0d5e4a1de12bd7c5d5eb31ce
    Reviewed-on: https://chromium-review.googlesource.com/c/1259009
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#614289}

    Changed files

    • chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
    • chrome/browser/ui/webui/signin/inline_login_handler_impl.h
  44. [ios] Fixed manual fallback cells vertical offsets

    Changed by David Jean - djeanohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 08:34:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5d604e82d00923e85e22076e806208ab1daa04ba

    Comments

    [ios] Fixed manual fallback cells vertical offsets
    
    Fixed dynamic types for separating labels.
    
    Bug: 912030,912028
    Change-Id: I1acbfed7fe6569c8af712c45a04b8f86dbbbf0af
    Reviewed-on: https://chromium-review.googlesource.com/c/1363180
    Commit-Queue: David Jean <djean@chromium.org>
    Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614288}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/action_cell.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_cell_utils.mm
  45. Roll AFDO from 73.0.3631.0_rc-r1 to 73.0.3632.0_rc-r1

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 08:20:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f27b2e597d5cef4990fb1c109ed576d0412ed1d3

    Comments

    Roll AFDO from 73.0.3631.0_rc-r1 to 73.0.3632.0_rc-r1
    
    This CL may cause a small binary size increase, roughly proportional
    to how long it's been since our last AFDO profile roll. For larger
    increases (around or exceeding 100KB), please file a bug against
    gbiv@chromium.org. Additional context: https://crbug.com/805539
    
    Please note that, despite rolling to chrome/android, this profile is
    used for both Linux and Android.
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=gbiv@chromium.org
    
    Change-Id: Ib51caf6f12f66fcb6b8d98ce42033e316e3f87dd
    Reviewed-on: https://chromium-review.googlesource.com/c/1365390
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614287}

    Changed files

    • chrome/android/profiles/newest.txt
  46. WebUI: Convert remaining usages of var to let/const, part 4.

    Changed by dpapad - dpapadohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 08:14:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f32b4afc9a7da18df541ef79dbbc623ccf2c5fa8

    Comments

    WebUI: Convert remaining usages of var to let/const, part 4.
    
    This is in preparation of turning on no-var, and prefer-const ESLint
    checks for all of chrome/browser/resources/
    
    Bug: 792774
    Change-Id: Id1bfd8720970876275499854d4fccce1c911d0b2
    Reviewed-on: https://chromium-review.googlesource.com/c/1364053
    Reviewed-by: Dan Beam <dbeam@chromium.org>
    Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614286}

    Changed files

    • chrome/browser/resources/cast/cast.js
    • chrome/browser/resources/conflicts/about_conflicts.js
    • chrome/browser/resources/device_log_ui/device_log_ui.js
    • chrome/browser/resources/download_internals/download_internals.js
    • chrome/browser/resources/download_internals/download_internals_browser_proxy.js
    • chrome/browser/resources/engagement/site_engagement.js
  47. Fix DCHECK() crash in ArcImeService.

    Changed by Yuichiro Hanada - yhanadaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 07:24:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d6dec3971cf136c5f6bfd2fcb197b0da132d12fa

    Comments

    Fix DCHECK() crash in ArcImeService.
    
    It should use WMHelper::HasInstance() to check there is WMHelper
    instance, but WMHelper::GetInstance() was used instead.
    
    Bug: 911857
    Change-Id: I46249edd757eff5364863365983be6bef905505c
    Reviewed-on: https://chromium-review.googlesource.com/c/1365093
    Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
    Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614285}

    Changed files

    • components/arc/ime/arc_ime_service.cc
  48. Worker: Move shared_worker_info.mojom from content/ to blink/ (Onion Soup)

    Changed by Hiroki Nakagawa - nhirokiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 06:55:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f236df12021640e9c9e0116d84c8f2914c3ee8c

    Comments

    Worker: Move shared_worker_info.mojom from content/ to blink/ (Onion Soup)
    
    Change-Id: Ieb3f3b689f266d0d6c88824accd31a752dd66cbe
    Bug: 911415
    Reviewed-on: https://chromium-review.googlesource.com/c/1360036
    Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614284}

    Changed files

    • content/browser/worker_host/mock_shared_worker.cc
    • content/browser/worker_host/mock_shared_worker.h
    • content/browser/worker_host/shared_worker_connector_impl.cc
    • content/browser/worker_host/shared_worker_connector_impl.h
    • content/browser/worker_host/shared_worker_host.cc
    • content/browser/worker_host/shared_worker_service_impl.cc
    • content/browser/worker_host/shared_worker_service_impl.h
    • content/browser/worker_host/shared_worker_service_impl_unittest.cc
    • content/common/BUILD.gn
    • content/common/shared_worker/shared_worker_connector.mojom
    • content/common/shared_worker/shared_worker_factory.mojom
    • content/renderer/shared_worker/embedded_shared_worker_stub.cc
    • content/renderer/shared_worker/embedded_shared_worker_stub.h
    • content/renderer/shared_worker/shared_worker_factory_impl.cc
    • content/renderer/shared_worker/shared_worker_factory_impl.h
    • content/renderer/shared_worker/shared_worker_repository.cc
    • third_party/blink/public/mojom/BUILD.gn
    • third_party/blink/public/mojom/worker/shared_worker_info.mojom
  49. CSP: Move content_security_policy.mojom from public/platform/ to public/mojom/csp/

    Changed by Hiroki Nakagawa - nhirokiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 06:50:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 792fcc3ac0290a37dede266b7561e6e365e86396

    Comments

    CSP: Move content_security_policy.mojom from public/platform/ to public/mojom/csp/
    
    This CL just moves content_security_policy.mojom from public/platform/ to
    public/mojom/csp/ for cleanup.
    
    This is useful for onion-soupifying shared workers without an additional
    dependency in BUILD.gn.
    
    Change-Id: I1292c6f18613be38c44e592fc1fe8a35fe070966
    Bug: 911415
    Reviewed-on: https://chromium-review.googlesource.com/c/1362703
    Reviewed-by: Andy Paicu <andypaicu@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614283}

    Changed files

    • content/browser/DEPS
    • content/browser/worker_host/shared_worker_instance.h
    • content/common/DEPS
    • content/common/content_param_traits_macros.h
    • content/common/content_security_policy_header.h
    • content/common/shared_worker/shared_worker_info.mojom
    • content/renderer/shared_worker/shared_worker_repository.h
    • third_party/blink/public/BUILD.gn
    • third_party/blink/public/mojom/BUILD.gn
    • third_party/blink/public/mojom/csp/OWNERS
    • third_party/blink/public/mojom/csp/README.md
    • third_party/blink/public/mojom/csp/content_security_policy.mojom
    • third_party/blink/public/platform/web_content_security_policy_struct.h
    • third_party/blink/public/web/web_remote_frame.h
    • third_party/blink/public/web/web_shared_worker.h
    • third_party/blink/renderer/core/exported/web_shared_worker_impl.h
    • third_party/blink/renderer/platform/network/content_security_policy_parsers.cc
  50. Make FetchContext::GetSecurityOrigin() non-virtual

    Changed by Hiroshige Hayashizaki - hiroshigeohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 06:36:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 87c80ca3a00312eec1c92b7f5c0344b05ef8ef05

    Comments

    Make FetchContext::GetSecurityOrigin() non-virtual
    
    This CL introduces FetchContext::fetch_client_settings_object_ and makes
    - FetchContext::GetSecurityOrigin()
    - FetchContext::GetFetchClientSettingsObject()
    non-virtual, to make it clearer that FetchContext's SecurityOrigin
    is always the SecurityOrigin of FetchContext's FetchClientSettingsObject.
    
    Bug: 880027
    Change-Id: I7ea1cc0edd4d7096b3a0c009c24fcb140d275430
    Reviewed-on: https://chromium-review.googlesource.com/c/1352042
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614282}

    Changed files

    • third_party/blink/renderer/core/dom/document.cc
    • third_party/blink/renderer/core/loader/base_fetch_context_test.cc
    • third_party/blink/renderer/core/loader/frame_fetch_context.cc
    • third_party/blink/renderer/core/loader/frame_fetch_context.h
    • third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
    • third_party/blink/renderer/core/loader/worker_fetch_context.cc
    • third_party/blink/renderer/core/loader/worker_fetch_context.h
    • third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
    • third_party/blink/renderer/platform/loader/fetch/fetch_context.h
    • third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h
  51. Update comment after CL:1364970

    Changed by Noel Gordon - noelohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 06:25:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6562ea1bc24eddee0a22b8d8d64614e69b3792c2

    Comments

    Update comment after CL:1364970
    
    The fix for bug 911609 obsoleted a comment about the affected JS code.
    Let's update the comment too.
    
    No-try: true
    Bug: 873539, 911609
    Change-Id: I2477ce8082724bd9ca3f2ab70cd169d6579b22e4
    Reviewed-on: https://chromium-review.googlesource.com/c/1364971
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Reviewed-by: Sam McNally <sammc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614281}

    Changed files

    • ui/file_manager/file_manager/foreground/js/directory_model.js
  52. Worker: Run http/tests/workers/ with off-the-main-thread top-level dedicated worker script fetch

    Changed by Hiroki Nakagawa - nhirokiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 05:52:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c1505ba885793b3337c504cf98149bb3c1d13316

    Comments

    Worker: Run http/tests/workers/ with off-the-main-thread top-level dedicated worker script fetch
    
    Bug: 835717
    Change-Id: Icde42b1dd837ca6110933b5cffc53864b7778a0d
    Reviewed-on: https://chromium-review.googlesource.com/c/1364811
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614280}

    Changed files

    • third_party/blink/web_tests/TestExpectations
    • third_party/blink/web_tests/VirtualTestSuites
    • third_party/blink/web_tests/virtual/omt-worker-fetch/http/tests/workers/README.txt
  53. Revert unintentional switching to element document in an AllowedByNosniff call

    Changed by Hiroshige Hayashizaki - hiroshigeohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 05:46:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 748875b36e91d5cd25bd8d653677fb5192203c97

    Comments

    Revert unintentional switching to element document in an AllowedByNosniff call
    
    In classic_pending_script.cc, [1] uses
    GetElement()->GetDocument().Fetcher()->Context()
    which corresponds to the element document, while before [1] it was
    GetElement()->GetDocument().ContextDocument()
    which corresponds to the context document.
    
    This CL reverts this change and uses the context document, and
    adds a regression test derived from a clusterfuzz test case.
    
    [1] https://chromium-review.googlesource.com/1351873
    
    Bug: 912046, 880027
    Change-Id: I92ca9723c3fdd1c5d9c304e4e196aeb77c75ee88
    Reviewed-on: https://chromium-review.googlesource.com/c/1364050
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614279}

    Changed files

    • third_party/blink/renderer/core/script/classic_pending_script.cc
    • third_party/blink/web_tests/http/tests/misc/script-moved-to-createDocument-crash.html
  54. Split web_contents_view_mac into Cocoa and C++ files

    Changed by Christopher Cameron - ccameronohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 05:45:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ec34e18cd852699fe8a2b2df2825d6e1d41a8e03

    Comments

    Split web_contents_view_mac into Cocoa and C++ files
    
    Strictly cut-and-paste patch, should have no functional changes.
    
    At present, we don't instantiate a WebContentsViewCocoa in the PWA
    process (rather, we just create a vanilla NSView in
    WebContentsNSViewBridge's constructor). To add support for drag-drop
    in PWAs we'll use a WebContentsViewCocoa in the PWA process, and then
    mojo-ify the boundaries needed for drag-drop support.
    
    Bug: 898608
    Change-Id: I90da19a0508872db8f39123d0e55d4bd24afe696
    Reviewed-on: https://chromium-review.googlesource.com/c/1363966
    Commit-Queue: ccameron <ccameron@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614278}

    Changed files

    • content/browser/BUILD.gn
    • content/browser/web_contents/web_contents_view_cocoa.h
    • content/browser/web_contents/web_contents_view_cocoa.mm
    • content/browser/web_contents/web_contents_view_mac.h
    • content/browser/web_contents/web_contents_view_mac.mm
    • content/browser/web_contents/web_contents_view_mac_unittest.mm
  55. WPT: service worker: fix test for CSS base URL.

    Changed by Matt Falkenhagen - falkenohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 05:40:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5dc21f8d3cf6b02771aa45895b245c59e061f636

    Comments

    WPT: service worker: fix test for CSS base URL.
    
    The existing test was asserting the opposite of the standard,
    which is to use the response URL. See
    https://github.com/whatwg/fetch/pull/146.
    
    This CL does the following:
    - Tests that a CSS stylesheet fetched via respondWith(fetch(responseUrl)
      uses responseUrl as its base URL.
    - Tests that a CSS stylesheet fetched via respondWith(new Response())
      uses the response URL (which is the request URL) as its base URL.
    - Changes the test to not test cross-origin stylesheets. That is more
      complex than needed for this test, and there is talk of making
      subresource requests from opaque stylesheets skip the service worker,
      which would render the test ineffective for testing base URL.
    - Changes the test to use waitUntil() in the message event to try
      to ensure the service worker stays alive between the message and
      fetch events.
    
    Bug: 911974
    Change-Id: I167dfe86986ec718a50d512f862f1eb49889608b
    Reviewed-on: https://chromium-review.googlesource.com/c/1362776
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Ben Kelly <wanderview@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614277}

    Changed files

    • third_party/blink/web_tests/external/wpt/service-workers/service-worker/fetch-request-css-base-url.https-expected.txt
    • third_party/blink/web_tests/external/wpt/service-workers/service-worker/fetch-request-css-base-url.https.html
    • third_party/blink/web_tests/external/wpt/service-workers/service-worker/resources/fetch-request-css-base-url-iframe.html
    • third_party/blink/web_tests/external/wpt/service-workers/service-worker/resources/fetch-request-css-base-url-worker.js
  56. Closure compile task_contoller_unittest

    Changed by Noel Gordon - noelohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 05:38:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6afc4880a78e888a32df06df328386b1f7b31308

    Comments

    Closure compile task_contoller_unittest
    
     - remove task_contoller_unittest.html
     - add BUILD rules to auto-generate and compile this unittest
     - define, install, and use mockChrome in the unittest code
     - use setupFileManagerPrivate() in all test cases
       - testExecuteEntryTask had its own local version but the
         test could also jsut use the common one: make it so.
     - make all test cases use the createTaskController helper
       - update JsDoc: a {FileSelectionHandler} is now required
       - remove the crostini create helper function
       - remove crostini.init call: no test cases depend on the
         crostini volume manager fake.
       - make createTaskController call createCrostiniForTest()
         when new-ing the {TaskController}.
     - make MockFileSelectionHandler @constructor, and @extends
       {FileSelectionHandler} interface, so createTaskController
       construction is both simple and type-safe.
     - add decriptive comments for each test case fixture
     - fix all Closure compiler errors, and auto-format JS code
    
    No change in test behavior, no new tests.
    
    Bug: 912410
    Change-Id: I7a685533632860ce785b9aaca2e84b7c69579979
    Reviewed-on: https://chromium-review.googlesource.com/c/1364270
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614276}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_jstest.cc
    • ui/file_manager/file_manager/foreground/js/BUILD.gn
    • ui/file_manager/file_manager/foreground/js/task_controller_unittest.html
    • ui/file_manager/file_manager/foreground/js/task_controller_unittest.js
  57. Deflake CopyBetweenWindows/FilesAppBrowserTest tests.

    Changed by Sam McNally - sammcohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 05:32:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ba4cf64ec6d7268f1a6922c39198f5b419cbac6f

    Comments

    Deflake CopyBetweenWindows/FilesAppBrowserTest tests.
    
    Bug: 911609
    Change-Id: I69434c3516bc8867eb0a67e2c6df4699887d8ff2
    Reviewed-on: https://chromium-review.googlesource.com/c/1364970
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Commit-Queue: Sam McNally <sammc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614275}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • ui/file_manager/file_manager/foreground/js/directory_model.js
  58. Fix UaF in P2PSocketStunTcp.

    Changed by John Abd-El-Malek - jamohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 04:52:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 089c4414d307a28e3175c7e57ac487bf2fd1ebcd

    Comments

    Fix UaF in P2PSocketStunTcp.
    
    WriteOrQueue may delete the memory if it's written synchronously (in HandleWriteResult). It looks like on Mac this occurs, while other platforms are always sync, which is why it crashes there.
    
    Bug: 884598
    Change-Id: Ia45fb3915531cb5b4efadb5e6cf4d0ce82955f29
    Reviewed-on: https://chromium-review.googlesource.com/c/1364390
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614274}

    Changed files

    • services/network/p2p/socket_tcp.cc
  59. Roll src/third_party/catapult 41fdb78fbbd8..c7cc237f9582 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 04:46:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3376dcf922b83205e166bc0f3bef26e28ab85ee0

    Comments

    Roll src/third_party/catapult 41fdb78fbbd8..c7cc237f9582 (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/41fdb78fbbd8..c7cc237f9582
    
    
    git log 41fdb78fbbd8..c7cc237f9582 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 nduca@google.com Update contributing guide for guidance when git-cl upload fails
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@c7cc237f9582
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=sullivan@chromium.org
    
    Change-Id: I68591156f328dcb0fb90db3d63008e6c7e3fd72c
    Reviewed-on: https://chromium-review.googlesource.com/c/1364771
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614273}

    Changed files

    • DEPS
  60. Stop calling StoragePartition::GetRequestContext in ChannelID browser code when the network service is enabled.

    Changed by John Abd-El-Malek - jamohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 04:43:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ac9f16d5dcb4b9f4fa06a3395c1671e267cca119

    Comments

    Stop calling StoragePartition::GetRequestContext in ChannelID browser code when the network service is enabled.
    
    This will always early exit because ChannelID doesn't work with network service.
    
    Bug: 837753
    Change-Id: Icdd08121e6da55f5a8b6ad1f4cbe2797ca92e8df
    Reviewed-on: https://chromium-review.googlesource.com/c/1363846
    Reviewed-by: Nick Harper <nharper@chromium.org>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614272}

    Changed files

    • content/public/browser/storage_partition.h
    • extensions/browser/api/messaging/message_property_provider.cc
  61. Roll src/third_party/chromite bbdb8efacb83..d138913917ce (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 04:29:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision be9648bfaf3b8c9f36b95a69a5e1b73e8a44766c

    Comments

    Roll src/third_party/chromite bbdb8efacb83..d138913917ce (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/bbdb8efacb83..d138913917ce
    
    
    git log bbdb8efacb83..d138913917ce --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 dgarrett@google.com master-postsubmit: Use MasterSlaveLKGMSyncStage.
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@d138913917ce
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I5d0fc5d23e1ab180c4f5193d71219e2280674d25
    Reviewed-on: https://chromium-review.googlesource.com/c/1364770
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614271}

    Changed files

    • DEPS
  62. Roll src/third_party/skia c84ccb1ff157..6d59568196c0 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 04:28:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0f2ba45a337e9880125ab97002b6f762b52c1611

    Comments

    Roll src/third_party/skia c84ccb1ff157..6d59568196c0 (2 commits)
    
    https://skia.googlesource.com/skia.git/+log/c84ccb1ff157..6d59568196c0
    
    
    git log c84ccb1ff157..6d59568196c0 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 reed@google.com change private alloc methods to also take fonts
    2018-12-06 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    
    
    Created with:
      gclient setdep -r src/third_party/skia@6d59568196c0
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jcgregorio@chromium.org
    
    Change-Id: If986fdbf77b39cbadf18315c0b531e3ccc578742
    Reviewed-on: https://chromium-review.googlesource.com/c/1364179
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614270}

    Changed files

    • DEPS
  63. Remove new style launcher flag and clean up

    Changed by weidongg@chromium.org - weidonggohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 04:22:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 43732e6d56e5b5556590891fcbdb3c53a44fad5f

    Comments

    Remove new style launcher flag and clean up
    
    Remove the flag and also fixed several test failures in
    AppListViewFocusTest.
    
    Bug: 911003
    Change-Id: I361c216d9935dc35add1ab14dd1bcec8bfe45f11
    Reviewed-on: https://chromium-review.googlesource.com/c/1358044
    Commit-Queue: Weidong Guo <weidongg@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614269}

    Changed files

    • ash/app_list/BUILD.gn
    • ash/app_list/model/folder_image.cc
    • ash/app_list/model/folder_image.h
    • ash/app_list/views/app_list_item_view.cc
    • ash/app_list/views/app_list_item_view.h
    • ash/app_list/views/app_list_view.cc
    • ash/app_list/views/app_list_view.h
    • ash/app_list/views/app_list_view_unittest.cc
    • ash/app_list/views/apps_container_view.cc
    • ash/app_list/views/apps_container_view.h
    • ash/app_list/views/apps_grid_view.cc
    • ash/app_list/views/apps_grid_view.h
    • ash/app_list/views/apps_grid_view_unittest.cc
    • ash/app_list/views/contents_view.cc
    • ash/app_list/views/expand_arrow_view.cc
    • ash/app_list/views/expand_arrow_view.h
    • ash/app_list/views/indicator_chip_view.cc
    • ash/app_list/views/indicator_chip_view.h
    • ash/app_list/views/search_box_view.cc
    • ash/app_list/views/search_box_view.h
    • ash/app_list/views/search_result_suggestion_chip_view.cc
    • ash/app_list/views/search_result_suggestion_chip_view.h
    • ash/app_list/views/suggestion_chip_view.cc
    • ash/app_list/views/suggestion_chip_view.h
    • ash/public/cpp/app_list/app_list_config.cc
    • ash/public/cpp/app_list/app_list_config.h
    • ash/public/cpp/app_list/app_list_features.cc
    • ash/public/cpp/app_list/app_list_features.h
    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
  64. [AF Paradise] Fix issue in migration dialog

    Changed by siyua - siyuaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 04:15:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2596ec460ffe11900b95ca0718b53682fb806525

    Comments

    [AF Paradise] Fix issue in migration dialog
    
    1) Make the error dialog block browser, which is consistent with other
    dialogs.
    
    2) Override Close() function since otherwise if user close browser when dialog
    is visible, the default Close() will call Cancel().
    
    Bug: 897998
    Change-Id: I2e0c92621ae04ce34a212dabcf69be2cad99bdf8
    Reviewed-on: https://chromium-review.googlesource.com/c/1359752
    Commit-Queue: Siyu An <siyua@chromium.org>
    Reviewed-by: Evan Stade <estade@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614268}

    Changed files

    • chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc
    • chrome/browser/ui/views/autofill/local_card_migration_dialog_view.h
    • chrome/browser/ui/views/autofill/local_card_migration_error_dialog_view.cc
    • chrome/browser/ui/views/autofill/local_card_migration_error_dialog_view.h
  65. Roll src-internal 4bba89717d68..3dc3d8f696a7 (7 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 04:14:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9676d343d9b4a0214c8907bae9befad61ca93540

    Comments

    Roll src-internal 4bba89717d68..3dc3d8f696a7 (7 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bba89717d68..3dc3d8f696a7
    
    
    Created with:
      gclient setdep -r src-internal@3dc3d8f696a7
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I56e9701b0e86c22bfb3af30ae4049d7f67d50ed0
    Reviewed-on: https://chromium-review.googlesource.com/c/1364180
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614267}

    Changed files

    • DEPS
  66. Import wpt@093a97b6ecc6484c201d704d38b47bef1964d59d

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 04:14:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d9eec5901e71aee7863a8df428eb7c8524001286

    Comments

    Import wpt@093a97b6ecc6484c201d704d38b47bef1964d59d
    
    Using wpt-import in Chromium 1c28ec4741c84e1dce9e981e28d9fcac1c82db6a.
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    NOAUTOREVERT=true
    TBR=raphael.kubo.da.costa
    
    No-Export: true
    Change-Id: I7d4a205e45cf11a1546abc259a5eb3efaa0c99cf
    Reviewed-on: https://chromium-review.googlesource.com/c/1364221
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614266}

    Changed files

    • third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
    • third_party/blink/web_tests/external/wpt/service-workers/service-worker/fetch-cors-xhr.https.html
    • third_party/blink/web_tests/external/wpt/service-workers/service-worker/resources/fetch-cors-xhr-iframe.html
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/color-interpolation-computed.svg
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/color-rendering-computed.svg
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/fill-computed.svg
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/fill-opacity-computed.svg
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/fill-rule-computed.svg
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/image-rendering-computed-expected.txt
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/image-rendering-computed.svg
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/marker-end-computed.svg
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/marker-mid-computed.svg
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/marker-start-computed.svg
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/paint-order-computed.svg
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/shape-rendering-computed.svg
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/stroke-computed.svg
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/stroke-dasharray-computed.svg
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/stroke-dashoffset-computed.svg
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/stroke-linecap-computed.svg
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/stroke-linejoin-computed.svg
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/stroke-miterlimit-computed.svg
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/stroke-opacity-computed.svg
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/stroke-width-computed.svg
    • third_party/blink/web_tests/external/wpt/svg/painting/parsing/text-rendering-computed.svg
  67. Revert "Roll src/third_party/dawn e2f948469c66..0a7ddd43d77c (1 commits)"

    Changed by Jeffrey Yasskin - jyasskinohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 04:12:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 913ce70bd62158a83dee2dd632674e2a29225278

    Comments

    Revert "Roll src/third_party/dawn e2f948469c66..0a7ddd43d77c (1 commits)"
    
    This reverts commit 46b10ea6760666cd5eb4f50e8523a5c1b3bdda0d.
    
    Reason for revert: Broke compile in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-rel/12314.
    
    The only Dawn change appears to be https://dawn-review.googlesource.com/c/dawn/+/2940.
    
    Original change's description:
    > Roll src/third_party/dawn e2f948469c66..0a7ddd43d77c (1 commits)
    > 
    > https://dawn.googlesource.com/dawn.git/+log/e2f948469c66..0a7ddd43d77c
    > 
    > 
    > git log e2f948469c66..0a7ddd43d77c --date=short --no-merges --format='%ad %ae %s'
    > 2018-12-05 senorblanco@chromium.org Create new src/tests BUILD.gn file.
    > 
    > 
    > Created with:
    >   gclient setdep -r src/third_party/dawn@0a7ddd43d77c
    > 
    > The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll
    > 
    > Documentation for the AutoRoller is here:
    > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    > 
    > If the roll is causing failures, please contact the current sheriff, who should
    > be CC'd on the roll, and stop the roller if necessary.
    > 
    > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    > TBR=cwallez@chromium.org
    > 
    > Change-Id: I247d5fe52886ea7f75eb3ad9302f80e9ec371677
    > Reviewed-on: https://chromium-review.googlesource.com/c/1364177
    > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    > Cr-Commit-Position: refs/heads/master@{#614260}
    
    TBR=cwallez@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com
    
    Change-Id: Ia0d39b5cb9fcd8acf8f46638206969e8af0cab7f
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Reviewed-on: https://chromium-review.googlesource.com/c/1364694
    Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
    Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614265}

    Changed files

    • DEPS
  68. Updating trunk VERSION from 3632.0 to 3633.0

    Changed by chrome-release-bot - chrome-release-botohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 04:09:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 453a3a1bb6286b208a13c2dcac7ac0027bd9bdb3

    Comments

    Updating trunk VERSION from 3632.0 to 3633.0
    
    # This is an automated release commit.
    # Do not revert without consulting chrome-pmo@google.com.
    NOAUTOREVERT=true
    TBR=abdulsyed@chromiue.org
    
    Change-Id: I68571af34447521025c62ecb47d6a0a67e969c53
    Reviewed-on: https://chromium-review.googlesource.com/c/1364633
    Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614264}

    Changed files

    • chrome/VERSION
  69. Roll src/third_party/depot_tools 9875e180e5fd..2e00228777c0 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 03:31:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a9e0cd51f3d7bc6927d332966ab734d8045b2d2d

    Comments

    Roll src/third_party/depot_tools 9875e180e5fd..2e00228777c0 (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9875e180e5fd..2e00228777c0
    
    
    git log 9875e180e5fd..2e00228777c0 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 vadimsh@chromium.org [cipd] Update CIPD client to v2.2.13.
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@2e00228777c0
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:911229
    TBR=agable@chromium.org
    
    Change-Id: Ibce76fcee0243f3df875ac171c9b84663e2e4bf4
    Reviewed-on: https://chromium-review.googlesource.com/c/1364018
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614263}

    Changed files

    • DEPS
  70. Android: Rename __build_config targets to __build_config_crbug_908819

    Changed by Andrew Grieve - agrieveohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 03:31:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cec62592a29d5d33fe9049a470dab57a247f9fb1

    Comments

    Android: Rename __build_config targets to __build_config_crbug_908819
    
    Goal is to surface give a pointer in "missing dependency" error messages
    about why the non-existent dependency was added.
    
    TBR=agrieve  # Trivial rename
    
    Bug: 908819
    Change-Id: I42a7b791658101985ec90afe85cbfe54de86b8df
    Reviewed-on: https://chromium-review.googlesource.com/c/1361933
    Commit-Queue: agrieve <agrieve@chromium.org>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614262}

    Changed files

    • android_webview/glue/generate_resource_rewriter.gni
    • build/android/docs/build_config.md
    • build/android/gradle/generate_gradle.py
    • build/config/android/internal_rules.gni
    • build/config/android/rules.gni
  71. Roll src/third_party/catapult a8f4725aa003..41fdb78fbbd8 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 03:30:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7c2c6d0b62ba27d74d76d889cac156032508ada2

    Comments

    Roll src/third_party/catapult a8f4725aa003..41fdb78fbbd8 (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/a8f4725aa003..41fdb78fbbd8
    
    
    git log a8f4725aa003..41fdb78fbbd8 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 rmhasan@google.com Adds new verification to expectation_parser.py
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@41fdb78fbbd8
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:905426
    TBR=sullivan@chromium.org
    
    Change-Id: Iadc0d06b2a4c70581e69076309c1b0be42ad0aec
    Reviewed-on: https://chromium-review.googlesource.com/c/1364178
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614261}

    Changed files

    • DEPS
  72. Roll src/third_party/dawn e2f948469c66..0a7ddd43d77c (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 03:30:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 46b10ea6760666cd5eb4f50e8523a5c1b3bdda0d

    Comments

    Roll src/third_party/dawn e2f948469c66..0a7ddd43d77c (1 commits)
    
    https://dawn.googlesource.com/dawn.git/+log/e2f948469c66..0a7ddd43d77c
    
    
    git log e2f948469c66..0a7ddd43d77c --date=short --no-merges --format='%ad %ae %s'
    2018-12-05 senorblanco@chromium.org Create new src/tests BUILD.gn file.
    
    
    Created with:
      gclient setdep -r src/third_party/dawn@0a7ddd43d77c
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=cwallez@chromium.org
    
    Change-Id: I247d5fe52886ea7f75eb3ad9302f80e9ec371677
    Reviewed-on: https://chromium-review.googlesource.com/c/1364177
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614260}

    Changed files

    • DEPS
  73. DevTools: fix Console scroll preservation with keyboard experiment

    Changed by Erik Luo - luoeohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 03:28:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0835ba4d696ebe20992dee8b5c2ccbe2a4e658c8

    Comments

    DevTools: fix Console scroll preservation with keyboard experiment
    
    To ensure Console preserves scroll position when switching panels,
    - ConsoleView's focus() now focuses the viewport instead of the
      prompt, when needed.
    - ConsoleView manually restores scroll positions, since viewport's
      focus() may scroll items into view.
    
    Bug: 865674
    Change-Id: I8f338a98557c94dddc7f0ba5177b635a72aee503
    Reviewed-on: https://chromium-review.googlesource.com/c/1361793
    Reviewed-by: Joel Einbinder <einbinder@chromium.org>
    Commit-Queue: Erik Luo <luoe@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614259}

    Changed files

    • third_party/blink/renderer/devtools/front_end/console/ConsoleView.js
    • third_party/blink/renderer/devtools/front_end/console/ConsoleViewport.js
    • third_party/blink/web_tests/http/tests/devtools/console/console-focus-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/console/console-focus.js
  74. Fix --disable-gl-error-limit flag

    Changed by James Darpinian - jdarpinianohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 03:24:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 104af6fb98cba827d7eab8783b5bc1ecfdbe4397

    Comments

    Fix --disable-gl-error-limit flag
    
    Respect GpuPreferences rather than checking the command line
    in the logger.
    
    Bug: 910812
    Change-Id: I79e044d9a0e791a2603c36712755c759f1d04f1c
    Reviewed-on: https://chromium-review.googlesource.com/c/1364154
    Commit-Queue: James Darpinian <jdarpinian@chromium.org>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614258}

    Changed files

    • gpu/command_buffer/service/gles2_cmd_decoder.cc
    • gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
    • gpu/command_buffer/service/logger.cc
    • gpu/command_buffer/service/logger.h
    • gpu/command_buffer/service/raster_decoder.cc
  75. Replace IndexedDBContext::CopyOriginData to use url::Origin instead of GURL.

    Changed by Zhuoyu Qian - zhuoyu.qianohnoyoudont@samsung.com
    Changed at Thursday, 06-Dec-18 03:24:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ef13decd92d62733ffa17cf1fb8c700d35615443

    Comments

    Replace IndexedDBContext::CopyOriginData to use url::Origin instead of GURL.
    
    As the comment left by jsbell@, replace IndexedDBContext::CopyOriginData
    to use url::Origin instead of GURL.
    
    Change-Id: I0cf75ad39b1081b32cb4ac060cfa0294d987e767
    Reviewed-on: https://chromium-review.googlesource.com/c/1360211
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Joshua Bell <jsbell@chromium.org>
    Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
    Cr-Commit-Position: refs/heads/master@{#614257}

    Changed files

    • chrome/browser/extensions/app_data_migrator.cc
    • content/browser/indexed_db/indexed_db_context_impl.cc
    • content/browser/indexed_db/indexed_db_context_impl.h
    • content/public/browser/indexed_db_context.h
  76. Roll src/third_party/pdfium 10a8fea122ad..3d29bcfeed81 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 03:23:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a2fbd70f366e6b6d8f73bf80d3a0c74125054462

    Comments

    Roll src/third_party/pdfium 10a8fea122ad..3d29bcfeed81 (1 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/10a8fea122ad..3d29bcfeed81
    
    
    git log 10a8fea122ad..3d29bcfeed81 --date=short --no-merges --format='%ad %ae %s'
    2018-12-05 thestig@chromium.org Change an if-statement into an ASSERT().
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@3d29bcfeed81
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I8b24638e181c01201a33d852b1f81623c83b758a
    Reviewed-on: https://chromium-review.googlesource.com/c/1364176
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614256}

    Changed files

    • DEPS
  77. Add RPATH to shared libraries

    Changed by Tom Anderson - thomasandersonohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 03:23:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3b3db14346589ff4069d004883b52d0a01690fe5

    Comments

    Add RPATH to shared libraries
    
    Fixes libfontconfig.so not being able to find libfreetype_harfbuzz.so:
    
    $ ldd libfontconfig.so | grep freetype_harfbuzz
    	libfreetype_harfbuzz.so => not found
    $ ls libfreetype_harfbuzz.so
    libfreetype_harfbuzz.so
    
    R=thakis
    
    Bug: 911836,912366
    Change-Id: Ia0aaed8fc2c745b02cecf9ee3ce9888c1d8ccf77
    Reviewed-on: https://chromium-review.googlesource.com/c/1362457
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614255}

    Changed files

    • build/config/BUILD.gn
    • build/config/gcc/BUILD.gn
  78. Roll src/third_party/chromite 474edce4406d..bbdb8efacb83 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 03:12:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3cd318393407a2a41d64257adf43328ca0be06b0

    Comments

    Roll src/third_party/chromite 474edce4406d..bbdb8efacb83 (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/474edce4406d..bbdb8efacb83
    
    
    git log 474edce4406d..bbdb8efacb83 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 zhuohao@chromium.org kalista: mark paladin as important (not experiment)
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@bbdb8efacb83
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I6fb66328feffe89fc681fe5c58f480966ce48b73
    Reviewed-on: https://chromium-review.googlesource.com/c/1364175
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614254}

    Changed files

    • DEPS
  79. Defer preloads with imagesrcset/imagesizes until the first chunk is parsed

    Changed by Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 03:10:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 10bb83df93723eeecec3590fdf14904adf835795

    Comments

    Defer preloads with imagesrcset/imagesizes until the first chunk is parsed
    
    Preloads from link headers with the media attribute are deferred until
    the first chunk of the document is parsed, so that ViewportDescription
    from the preload scanner can be taken into account. Preloads with
    imagesrcset or imagesizes depend on the viewport, so such preloads
    should be deferred as well.
    
    Note: This applies to only preloads dispatched by DocumentLoader. Link
    rel=preload headers from subresources (e.g. prefetch) are not deferred
    even if they have media/imagesrcset/imagesizes attributes.
    
    Bug: 813452
    Change-Id: Iccc6ec12cf5bd53b71824463378c854cbd23a5ba
    Reviewed-on: https://chromium-review.googlesource.com/c/1360193
    Reviewed-by: Dominic Farolino <domfarolino@gmail.com>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614253}

    Changed files

    • third_party/blink/renderer/core/loader/link_loader.cc
    • third_party/blink/renderer/platform/loader/link_header.h
    • third_party/blink/web_tests/http/tests/preload/meta-viewport-link-headers-imagesrcset.html
    • third_party/blink/web_tests/http/tests/preload/resources/media-link-headers-imagesrcset.php
  80. Add language detection content browser test including nested nodes.

    Changed by Chris Hall - chrishallohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 03:09:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 198763278fb66b3a7135b29c3817f2dc5df7d6f4

    Comments

    Add language detection content browser test including nested nodes.
    
    R=dmazzoni,aboxhall
    
    Bug: 889370
    Change-Id: I56bd50586a13d754d9dd1547e277d7daab216ec3
    Reviewed-on: https://chromium-review.googlesource.com/c/1362698
    Commit-Queue: Chris Hall <chrishall@chromium.org>
    Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614252}

    Changed files

    • content/browser/accessibility/dump_accessibility_tree_browsertest.cc
    • content/test/data/accessibility/language-detection/lang-attribute-expected-blink.txt
    • content/test/data/accessibility/language-detection/lang-attribute-nested-expected-blink.txt
    • content/test/data/accessibility/language-detection/lang-attribute-nested-expected-mac.txt
    • content/test/data/accessibility/language-detection/lang-attribute-nested-expected-win.txt
    • content/test/data/accessibility/language-detection/lang-attribute-nested.html
  81. CacheStorage: Hold DOM binding objects alive during operations.

    Changed by Ben Kelly - wanderviewohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 03:09:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 20b1274003890d6d42807a41daf846948410f355

    Comments

    CacheStorage: Hold DOM binding objects alive during operations.
    
    We are seeing some DCHECKs trigger that suggest the owning Cache object
    is destroyed while an outstanding operation is in progress.  This can
    in theory happen in code that operates on the cache, but then discards
    its reference while waiting for the promise to settle.
    
    Bug: 912141
    Change-Id: Ic82e8b86bb427808df4d7f16326b50998cf6b031
    Reviewed-on: https://chromium-review.googlesource.com/c/1364130
    Commit-Queue: Ben Kelly <wanderview@chromium.org>
    Reviewed-by: Victor Costan <pwnall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614251}

    Changed files

    • third_party/blink/renderer/modules/cache_storage/cache.cc
    • third_party/blink/renderer/modules/cache_storage/cache_storage.cc
  82. Add XR instrumentation web content workaround

    Changed by bsheedy - bsheedyohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 03:06:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8b38b5d3ba2bc4e343b756f932ac7b807ffa94da

    Comments

    Add XR instrumentation web content workaround
    
    Adds a workaround for https://crbug.com/908917 into the XR
    instrumentation test setup since attempts to work around the issue in
    the test runner haven't been completely successful. This workaround
    performs a swipe which should be a no-op when running a RenderTest,
    which seems to prevent the flakiness when doing pixel diffs.
    
    Bug: 908917
    Change-Id: I38bf8fb5abe1c0a2bf19e044dd9237919ec2b019
    Reviewed-on: https://chromium-review.googlesource.com/c/1362293
    Reviewed-by: Bill Orr <billorr@chromium.org>
    Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614250}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/ChromeTabbedActivityXrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/CustomTabActivityXrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/WebappActivityXrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTestRuleUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/XrTestRuleUtils.java
  83. Fix border colors for offline content preview on dino page

    Changed by Carlos Knippschild - carloskohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 03:06:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6fa34733adbc1a5ee43f18902a7683bfe03e8764

    Comments

    Fix border colors for offline content preview on dino page
    
    TBR: chili@chromium.org
    Bug: 852872
    Change-Id: Iab8527b01c03ea9abb3c7542fe56f88be39bb620
    Reviewed-on: https://chromium-review.googlesource.com/c/1364297
    Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
    Reviewed-by: Cathy Li <chili@chromium.org>
    Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614249}

    Changed files

    • components/neterror/resources/neterror.css
  84. [mojo] Fix JS lite bindings compilation

    Changed by Ken Rockot - rockotohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 03:01:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59b68d8136b3526cf41a42228344bcb52cd73275

    Comments

    [mojo] Fix JS lite bindings compilation
    
    Adds the default compilation options to the js_binary target which
    builds the bindings_lite binary. Fixes all of the miscellaneous resulting
    compilation errors. Some major resulting changes:
    
     - Interface support (stuff which has to depend on generated control
       message bindings) is moved into a separate module to avoid a circular
       dependency between it and the rest of mojo.internal.
     - Enums, Structs, and Unions have had their type specs lifted into a
       $ property. So e.g. an enum e defining FOO, BAR, BAZ will have
       properties e.FOO, e.BAR, e.BAZ, and then e.$ for internal bindings
       use.
     - A few missing core Mojo externs have been filled out.
     - JS lite support library code is now written as if it will always be
       Closure-compiled in a real Closure environment. A simple Python script
       is added to concatenate files and rewrite Closure-style imports and
       exports for environments which do not compile JS.
     - The mojom GN template now emits two new targets, $foo_js_library and
       $foo_js_library_for_compile; the former is a js_library with no
       Closure directives while the latter uses goog.require and goog.provide
       to manage dependencies. They are otherwise equivalent.
     - JS bindings now define everything in a Closure-friendly way within the
       global namespace.
    
    It is still not feasible to use fully compiled (i.e. with
    ADVANCED_OPTIMIZATION) generated bindings from non-complied JS due to
    unavoidable symbol munging, but for fully compiled JS binaries, they
    work just fine.
    
    Bug: 905533
    Change-Id: I0d915188f34dd94b7380a20a80b3d450c367640b
    Reviewed-on: https://chromium-review.googlesource.com/c/1340914
    Commit-Queue: Ken Rockot <rockot@google.com>
    Reviewed-by: calamity <calamity@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614248}

    Changed files

    • mojo/public/js/BUILD.gn
    • mojo/public/js/bindings_lite.js
    • mojo/public/js/compile_preamble.js
    • mojo/public/js/interface_support.js
    • mojo/public/tools/bindings/concatenate_and_replace_closure_exports.py
    • mojo/public/tools/bindings/generators/js_templates/lite/enum_definition.tmpl
    • mojo/public/tools/bindings/generators/js_templates/lite/interface_definition.tmpl
    • mojo/public/tools/bindings/generators/js_templates/lite/module_definition.tmpl
    • mojo/public/tools/bindings/generators/js_templates/lite/mojom-lite.js.tmpl
    • mojo/public/tools/bindings/generators/js_templates/lite/struct_definition.tmpl
    • mojo/public/tools/bindings/generators/js_templates/lite/union_definition.tmpl
    • mojo/public/tools/bindings/generators/mojom_js_generator.py
    • mojo/public/tools/bindings/mojom.gni
    • third_party/closure_compiler/closure_args.gni
    • third_party/closure_compiler/compile_js.gni
    • third_party/closure_compiler/externs/mojo_core.js
  85. Store the committed origin for navigation in FrameNavigationEntry.

    Changed by Nasko Oskov - naskoohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 02:53:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 18006bc7a59e2db7fe94d2511d0a0fe66b678f72

    Comments

    Store the committed origin for navigation in FrameNavigationEntry.
    
    Bug: 882053
    Change-Id: I36960aa5fbab5ef8d3ba89158f31d408950da34b
    Reviewed-on: https://chromium-review.googlesource.com/c/1344876
    Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
    Commit-Queue: Nasko Oskov <nasko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614247}

    Changed files

    • content/browser/frame_host/frame_navigation_entry.cc
    • content/browser/frame_host/frame_navigation_entry.h
    • content/browser/frame_host/navigation_controller_impl.cc
    • content/browser/frame_host/navigation_controller_impl_browsertest.cc
    • content/browser/frame_host/navigation_entry_impl.cc
    • content/browser/frame_host/navigation_entry_impl.h
    • content/test/test_render_frame_host.cc
    • content/test/test_web_contents.cc
  86. arc: Add ability to invalidate app icons.

    Changed by khmel@chromium.org - khmelohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 02:50:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f0e8075ebb34a7197fdbdf93a7ae3c1a59b87fd8

    Comments

    arc: Add ability to invalidate app icons.
    
    This is required when we changed icon processing on Android side and
    would like to apply these changes in case previous apps icons are
    already cached.
    
    TEST=In context of ag/5700881. Blurred icons turned to normal version.
         unit tests extended.
    BUG=904278
    
    Change-Id: I68c4ab8669eb46a56e34316fc154b7554c0ff7a2
    Reviewed-on: https://chromium-review.googlesource.com/c/1362463
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: Yury Khmel <khmel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614246}

    Changed files

    • chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
    • chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
    • chrome/browser/ui/app_list/arc/arc_app_unittest.cc
  87. Roll Fuchsia SDK from 6ffdac9f1330 to 9d623aaaba71

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 02:43:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 601a2be11fca0f6a5e52a11201c1bf07d474f5ab

    Comments

    Roll Fuchsia SDK from 6ffdac9f1330 to 9d623aaaba71
    
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
    TBR=cr-fuchsia+bot@chromium.org
    
    Change-Id: I9c0f1f9aa4b3184840037aca0ee3229356eda75c
    Reviewed-on: https://chromium-review.googlesource.com/c/1364017
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614245}

    Changed files

    • build/fuchsia/linux.sdk.sha1
    • build/fuchsia/mac.sdk.sha1
  88. Add list of known USB and Bluetooth gamepads

    Changed by Matt Reynolds - mattreynoldsohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 02:40:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 054d99ba3502a3138925e5b15ed37633f68b5b33

    Comments

    Add list of known USB and Bluetooth gamepads
    
    A list of known gamepad device IDs is added so that Chrome can
    recognize and report when a gamepad is connected, even if the
    device is not yet supported in Chrome. The metrics collection
    will be added in a future CL.
    
    BUG=786250
    
    Change-Id: I579baf5d8de086061bff828031856c0a4f04359d
    Reviewed-on: https://chromium-review.googlesource.com/c/1298648
    Reviewed-by: Reilly Grant <reillyg@chromium.org>
    Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614244}

    Changed files

    • device/BUILD.gn
    • device/gamepad/BUILD.gn
    • device/gamepad/gamepad_id.h
    • device/gamepad/gamepad_id_list.cc
    • device/gamepad/gamepad_id_list.h
    • device/gamepad/gamepad_id_list_unittest.cc
    • device/gamepad/gamepad_standard_mappings_linux.cc
    • device/gamepad/gamepad_standard_mappings_mac.mm
    • device/gamepad/gamepad_standard_mappings_win.cc
  89. Fix vr android unittest

    Changed by Piotr Bialecki - bialpioohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 02:40:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 56fc0b384e1c2e5d1acd74ba38f5ce94760b1077

    Comments

    Fix vr android unittest
    
    Change-Id: Ifbb0695a08355ce26dfa4717a191c473762b155a
    Bug: 837834
    Reviewed-on: https://chromium-review.googlesource.com/c/1354543
    Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
    Reviewed-by: Bill Orr <billorr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614243}

    Changed files

    • chrome/browser/android/vr/arcore_device/arcore_device_unittest.cc
    • chrome/browser/android/vr/arcore_device/arcore_gl.cc
    • chrome/browser/android/vr/arcore_device/fake_arcore.cc
    • chrome/browser/android/vr/arcore_device/fake_arcore.h
  90. [Autofill Assistant] Fix details button get cut short issue and disable swiping with PR.

    Changed by Hui(Andy) Wu - wuandyohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 02:33:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fada5b98221df3fe98f85e09b980cb147a19a1cc

    Comments

    [Autofill Assistant] Fix details button get cut short issue and disable swiping with PR.
    
    1. The details button gets cut in height when status message has more than 1 line. This is
    because in BottomBarAnimations.java, the height is set to fixed number, and it should have been
    updated when we introduce swipe indicator.
    
    2. Disable bottom sheet swiping behavior when payment request UI is shown. Otherwise user
    won't be able to scrolling up/down in addresses, if they have many of them.
    
    Change-Id: I7f36b3369325e2421590d1da23608a2de1864c5c
    Bugs: http://b/120472977
    http: //b/120445679
    Screenshots: https://drive.google.com/file/d/1lPuMr3CmouPZ-MHABwhT4THZqv65PkYi/view?usp=sharing
    https: //drive.google.com/file/d/146JSZtfZUfxndaIHdpqh1kjyVKjxkD0V/view?usp=sharing
    Reviewed-on: https://chromium-review.googlesource.com/c/1362180
    Commit-Queue: Hui Wu <wuandy@chromium.org>
    Commit-Queue: Ganggui Tang <gogerald@chromium.org>
    Reviewed-by: Ganggui Tang <gogerald@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614242}

    Changed files

    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_sheet.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/BottomBarAnimations.java
  91. IndexedDB: No-op move of files to renderer/modules/indexeddb/

    Changed by Chase Phillips - cmpohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 02:30:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 08d8dc542dcca9bcd2fb1057ed42893f17da8d08

    Comments

    IndexedDB: No-op move of files to renderer/modules/indexeddb/
    
    This change is a no-op move of files from:
    - public/platform/modules/indexeddb/
    - renderer/modules/exported/
    
    to renderer/modules/indexeddb/.  Moving these all at once will allow
    later CLs to be smaller and clearer.
    
    Bug: 717812
    Change-Id: I9952ca8a5d2e220f936662ab4640d26337daa56d
    Reviewed-on: https://chromium-review.googlesource.com/c/1352624
    Commit-Queue: Chase Phillips <cmp@chromium.org>
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Reviewed-by: Daniel Murphy <dmurph@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614241}

    Changed files

    • third_party/blink/public/BUILD.gn
    • third_party/blink/public/platform/modules/indexeddb/web_idb_name_and_version.h
    • third_party/blink/renderer/bindings/modules/v8/v8_binding_for_modules_test.cc
    • third_party/blink/renderer/modules/exported/BUILD.gn
    • third_party/blink/renderer/modules/indexeddb/BUILD.gn
    • third_party/blink/renderer/modules/indexeddb/idb_cursor.cc
    • third_party/blink/renderer/modules/indexeddb/idb_database.cc
    • third_party/blink/renderer/modules/indexeddb/idb_database.h
    • third_party/blink/renderer/modules/indexeddb/idb_database_callbacks.cc
    • third_party/blink/renderer/modules/indexeddb/idb_database_callbacks.h
    • third_party/blink/renderer/modules/indexeddb/idb_factory.cc
    • third_party/blink/renderer/modules/indexeddb/idb_factory_test.cc
    • third_party/blink/renderer/modules/indexeddb/idb_index.cc
    • third_party/blink/renderer/modules/indexeddb/idb_key.cc
    • third_party/blink/renderer/modules/indexeddb/idb_key.h
    • third_party/blink/renderer/modules/indexeddb/idb_key_path.h
    • third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
    • third_party/blink/renderer/modules/indexeddb/idb_observation.cc
    • third_party/blink/renderer/modules/indexeddb/idb_observer_changes.cc
    • third_party/blink/renderer/modules/indexeddb/idb_request_test.cc
    • third_party/blink/renderer/modules/indexeddb/idb_value.cc
    • third_party/blink/renderer/modules/indexeddb/indexed_db_blink.typemap
    • third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.h
    • third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
    • third_party/blink/renderer/modules/indexeddb/indexed_db_database_callbacks_impl.cc
    • third_party/blink/renderer/modules/indexeddb/indexed_db_dispatcher.cc
    • third_party/blink/renderer/modules/indexeddb/indexed_db_dispatcher.h
    • third_party/blink/renderer/modules/indexeddb/indexed_db_key_builder.cc
    • third_party/blink/renderer/modules/indexeddb/indexed_db_key_builder.h
    • third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.h
    • third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.h
    • third_party/blink/renderer/modules/indexeddb/mock_web_idb_factory.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_callbacks.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_cursor.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_database_callbacks.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_database_callbacks_impl.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_database_callbacks_impl.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_database_error.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_key.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_key.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_key_path.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_key_range.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_key_range.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_name_and_version.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_observation.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_value.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_value.h
  92. Allow usage of FileDescriptorWatcher on the UI thread.

    Changed by Francois Doray - fdorayohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 02:29:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c186829bed25f00c5e207cb2344946ea59c2137e

    Comments

    Allow usage of FileDescriptorWatcher on the UI thread.
    
    FileDescriptorWatcher::WatchReadable/WatchWritable delegate the
    responsibility to watch a file descriptor to another thread. There
    is no reason to prevent their usage on the UI thread.
    
    Support for FileDescriptorWatcher::WatchReadable/WatchWritable on the
    UI thread is needed to support lock screen notifications on ChromeOS.
    
    Discussion: https://groups.google.com/a/google.com/forum/?utm_medium=email&utm_source=footer#!msg/chrome-scheduler/rFN0rTSmfho/Fe9m0YS5CAAJ
    Change-Id: Ib82481a8d7224285055447ce64de738764c1c53f
    Reviewed-on: https://chromium-review.googlesource.com/c/1349468
    Commit-Queue: François Doray <fdoray@chromium.org>
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614240}

    Changed files

    • base/files/file_descriptor_watcher_posix.cc
    • base/files/file_descriptor_watcher_posix.h
    • content/browser/browser_thread_impl.cc
    • content/browser/browser_thread_impl.h
  93. Roll src/third_party/angle eae081c6682a..8f1b7a66a5e3 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 02:29:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c613b9aa3786611122560830e68c083d8459364

    Comments

    Roll src/third_party/angle eae081c6682a..8f1b7a66a5e3 (2 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/eae081c6682a..8f1b7a66a5e3
    
    
    git log eae081c6682a..8f1b7a66a5e3 --date=short --no-merges --format='%ad %ae %s'
    2018-12-05 syoussefi@chromium.org Vulkan: Add DispatchUtilsVK
    2018-12-05 timvp@google.com Enhance ANGLE for Android Developer Options
    
    
    Created with:
      gclient setdep -r src/third_party/angle@8f1b7a66a5e3
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=ynovikov@chromium.org
    
    Change-Id: I1b80569aa1cec0d9753a210207531584fba82628
    Reviewed-on: https://chromium-review.googlesource.com/c/1364174
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614239}

    Changed files

    • DEPS
  94. [Code health] Put PaintWorkletInput in a separate file

    Changed by Xida Chen - xidachenohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 02:25:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f146f3f27d71866475aea53282bfa9f2910d6827

    Comments

    [Code health] Put PaintWorkletInput in a separate file
    
    This CL is a code clean up CL, it doesn't introduce any behavior change.
    
    Bug: None
    Change-Id: Ib95288357c0d2934e4e913c2b350dffbb49e9e14
    Reviewed-on: https://chromium-review.googlesource.com/c/1363897
    Reviewed-by: David Bokan <bokan@chromium.org>
    Reviewed-by: vmpstr <vmpstr@chromium.org>
    Commit-Queue: Xida Chen <xidachen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614238}

    Changed files

    • cc/paint/BUILD.gn
    • cc/paint/layer_tree_painter.h
    • cc/paint/paint_image.h
    • cc/paint/paint_worklet_input.h
    • cc/test/test_paint_worklet_input.h
    • third_party/blink/renderer/platform/graphics/platform_paint_worklet_input.h
  95. Enable Python auto-formatting for //build/android

    Changed by Andrew Grieve - agrieveohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 02:23:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5caba8d74f3d888c65d18d45f3608ae2118c71fd

    Comments

    Enable Python auto-formatting for //build/android
    
    This will cause presubmit to fail for deltas that don't match
    YAPF rules, and also enable "git cl format" to fix any such
    violations.
    
    Bug: 846432
    Change-Id: I3602e41811474a068f4780628601a14565320db9
    Reviewed-on: https://chromium-review.googlesource.com/c/1364338
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Commit-Queue: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614237}

    Changed files

    • build/android/.style.yapf
  96. Enable applist autocomplete by default

    Changed by Weidong Guo - weidonggohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 02:21:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7e7760426203ec831021fd866417bb1060ff40a6

    Comments

    Enable applist autocomplete by default
    
    Bug: 877111
    Change-Id: Iae2a27baf7e3b0b8983b08352396e1fbf1d13f9f
    Reviewed-on: https://chromium-review.googlesource.com/c/1358043
    Reviewed-by: Alex Newcomer <newcomer@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: Weidong Guo <weidongg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614236}

    Changed files

    • ash/app_list/views/search_box_view.cc
    • ash/public/cpp/app_list/app_list_features.cc
  97. Roll src-internal 247c822ca9a2..4bba89717d68 (9 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 02:20:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 530e693cc8d08a0b5c19695793b64adf30177857

    Comments

    Roll src-internal 247c822ca9a2..4bba89717d68 (9 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/247c822ca9a2..4bba89717d68
    
    
    Created with:
      gclient setdep -r src-internal@4bba89717d68
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:None
    TBR=mmoss@chromium.org
    
    Change-Id: I87080cdaf04004213764e726abe4a94729dc8ba5
    Reviewed-on: https://chromium-review.googlesource.com/c/1364016
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614235}

    Changed files

    • DEPS
  98. [MDC roll] Roll Material Internationalization to bb833f30561dcaba34ffbb8385395a27ff41f95f

    Changed by iOS Autoroller - ios-autorollerohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 02:20:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision efb260aba49c722d92e906cb6d66dfdac5be9a9a

    Comments

    [MDC roll] Roll Material Internationalization to bb833f30561dcaba34ffbb8385395a27ff41f95f
    
    Roll Material Text Accessibility to 499b45d1895b565096302a209c0c728df03b95d4
    
    TBR=smut
    
    Change-Id: Ia67c2ff6ed39aedbbb9700c31002d1f78c450736
    Reviewed-on: https://chromium-review.googlesource.com/c/1364293
    Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
    Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614234}

    Changed files

    • DEPS
    • ios/third_party/material_internationalization_ios/README.chromium
    • ios/third_party/material_text_accessibility_ios/README.chromium
  99. media/gpu/PlatformVideoFrame: Add function to create DmaBuf-backed VideoFrame using NativePixmap

    Changed by Hirokazu Honda - hirohohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 02:16:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bab718a9743aa3e334b696c4d617157acb446d21

    Comments

    media/gpu/PlatformVideoFrame: Add function to create DmaBuf-backed VideoFrame using NativePixmap
    
    VideoFrame only has the function to create DmaBuf-backed VideoFrame with already
    created DmaBuf fds, WrapExternalDmabufs(). This adds a function to create Dmabuf-backed
    VideoFrame usintg NativePixmap, CreatePlatformVideoFrame. The function is currently
    supported on only Ozone platform.
    
    Bug: 910590
    Test: VDA and VEA unittest on exynos
    Change-Id: I726369deecbdf9f1ae70829b36e59c72034feeae
    Reviewed-on: https://chromium-review.googlesource.com/c/1358198
    Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614233}

    Changed files

    • media/base/video_frame_layout.cc
    • media/base/video_frame_layout.h
    • media/base/video_frame_layout_unittest.cc
    • media/gpu/BUILD.gn
    • media/gpu/platform_video_frame.cc
    • media/gpu/platform_video_frame.h
    • media/gpu/test/texture_ref.cc
    • media/gpu/test/texture_ref.h
    • media/gpu/test/video_encode_accelerator_unittest_helpers.cc
    • media/gpu/v4l2/v4l2_device_unittest.cc
    • media/gpu/video_decode_accelerator_unittest.cc
  100. cros: Remove touchable flag from context_menu_matcher.cc

    Changed by Alex Newcomer - newcomerohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 02:05:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ee2d56d1d898cbda771ca8e5a1d790ed76d684f

    Comments

    cros: Remove touchable flag from context_menu_matcher.cc
    
    This feature is enabled by default, so remove the flag.
    
    This feature was accidentally breaking menu separators on
    other platforms, so re-enable them on !OS_CHROMEOS.
    
    Bug: 904220
    Change-Id: Ief676d4fabdbe800214b5dd441a7fbfb966398b9
    Reviewed-on: https://chromium-review.googlesource.com/c/1364066
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: Alex Newcomer <newcomer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614232}

    Changed files

    • chrome/browser/extensions/context_menu_matcher.cc
    • chrome/browser/extensions/extension_context_menu_browsertest.cc
  101. <blame list capped at 100 commits>

    Changed by <blame list capped at 100 commits> -
    Changed at N/A
    Repository
    Branch
    Revision

    Comments

    <blame list capped at 100 commits>