Home | Search | chromium - Builders
Login

Builder Linux ChromiumOS MSan Tests Build 9536 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revisionb02a7719f78de1e78ded7807aa4d139f8c2b77d6
Got Revisionb02a7719f78de1e78ded7807aa4d139f8c2b77d6

Execution:

Steps and Logfiles:

Show:
  1. ( 326 ms ) setup_build
    running recipe: "chromium"
  2. ( 340 ms ) report builders
     
    running tester 'Linux ChromiumOS MSan Tests' on master 'chromium.memory'
  3. ( 24 secs ) bot_update
    [76GB/295GB used (25%)]
  4. ( 1 secs ) swarming.py --version
    0.13
  5. ( 11 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.memory.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.memory.json
  7. ( 686 ms ) lookup builder GN args
     
    is_component_build = false
    is_debug = false
    is_msan = true
    msan_track_origins = 2
    strip_absolute_paths_from_debug_symbols = true
    target_os = "chromeos"
    use_goma = true
    use_prebuilt_instrumented_libraries = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 1 secs ) build directory
  9. ( 665 ms ) find isolated tests
  10. ( 2 secs ) wait for tasks
  11. ( 1 secs ) shell_dialogs_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  12. ( 3 secs ) base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:24.135509
  13. ( 1 secs ) single_process_mash_exo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 59s
  14. ( 1 secs ) capture_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  15. ( 1 secs ) ui_chromeos_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  16. ( 1 secs ) filesystem_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  17. ( 1 secs ) pdf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  18. ( 1 secs ) ozone_gl_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  19. ( 1 secs ) ozone_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 19s
  20. ( 2 secs ) blink_heap_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 28s
  21. ( 2 secs ) views_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 30s
  22. ( 1 secs ) dbus_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 21s
  23. ( 1 secs ) blink_common_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  24. ( 1 secs ) message_center_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 24s
  25. ( 2 secs ) storage_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 23s
  26. ( 2 secs ) ash_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:18.009733
  27. ( 1 secs ) aura_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 22s
  28. ( 1 secs ) snapshot_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 56s
  29. ( 1 secs ) app_shell_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 39s
  30. ( 1 secs ) ppapi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  31. ( 1 secs ) views_mus_interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 46s
  32. ( 1 secs ) nacl_loader_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  33. ( 1 secs ) gcm_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 20s
  34. ( 1 secs ) midi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  35. ( 1 secs ) keyboard_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  36. ( 1 secs ) exo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:06.725126
  37. ( 1 secs ) ui_base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 24s
  38. ( 1 secs ) boringssl_ssl_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  39. ( 1 secs ) skia_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 21s
  40. ( 1 secs ) mojo_core_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  41. ( 2 secs ) gfx_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 48s
  42. ( 1 secs ) media_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 23s
  43. ( 1 secs ) ipc_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  44. ( 1 secs ) compositor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 21s
  45. ( 1 secs ) sql_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  46. ( 3 secs ) blink_platform_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 35s
  47. ( 2 secs ) chromeos_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 27s
  48. ( 1 secs ) device_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 32s
  49. ( 1 secs ) service_manager_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 23s
  50. ( 1 secs ) cacheinvalidation_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  51. ( 2 secs ) extensions_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:03.578934
  52. ( 1 secs ) app_list_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 28s
  53. ( 1 secs ) accessibility_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  54. ( 1 secs ) ozone_x11_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 16s
  55. ( 1 secs ) perfetto_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 51s
  56. ( 2 secs ) crypto_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  57. ( 1 secs ) components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 52s
  58. ( 1 secs ) printing_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  59. ( 1 secs ) blink_fuzzer_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  60. ( 1 secs ) events_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 20s
  61. ( 1 secs ) url_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  62. ( 1 secs ) chromedriver_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  63. ( 1 secs ) traffic_annotation_auditor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  64. ( 1 secs ) nacl_helper_nonsfi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  65. ( 4 secs ) media_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:25.069115
  66. ( 2 secs ) display_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 16s
  67. ( 1 secs ) google_apis_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  68. ( 26 secs ) net_unittests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:08:14.819323 (shard #0)
    Min shard duration: 0:07:05.102634 (shard #1)
  69. ( 3 secs ) gpu_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 48s
  70. ( 1 secs ) chrome_app_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 27s
  71. ( 1 secs ) libjingle_xmpp_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  72. ( 1 secs ) cast_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  73. ( 2 secs ) viz_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:30.249176
  74. ( 1 secs ) ui_touch_selection_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  75. ( 4 secs ) chromeos_components_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 24s
  76. ( 2 secs ) remoting_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 31s
  77. ( 2 secs ) cc_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:04:02.596316
  78. ( 1 secs ) mojo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 28s
  79. ( 2 secs ) media_blink_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 22s
  80. ( 1 secs ) boringssl_crypto_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 44s
  81. ( 1 secs ) webui_polymer2_interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 56s
  82. ( 5 secs ) content_unittests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:01:35.216896 (shard #0)
    Min shard duration: 0:01:33.870646 (shard #1)
  83. ( 1 secs ) ash_content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 26s
  84. ( 1 secs ) native_theme_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  85. ( 1 secs ) latency_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  86. ( 1 secs ) wm_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  87. ( 2 secs ) views_mus_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:41.350966
  88. ( 5 secs ) angle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:45.626698
  89. ( 3 secs ) single_process_mash_ash_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:22.150521
  90. ( 1 secs ) leveldb_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  91. ( 1 secs ) wtf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 16s
  92. ( 1 secs ) gin_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 22s
  93. ( 1 secs ) jingle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  94. ( 1 secs ) sandbox_linux_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  95. ( 1 secs ) wait for tasks (2)
  96. ( 9 secs ) components_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:06:53.928936
  97. ( 1 secs ) wayland_client_perftests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 49s
  98. ( 3 secs ) single_process_mash_content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:50.905918
  99. ( 7 secs ) webkit_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:51.258864
  100. ( 3 secs ) viz_content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:16.568662
  101. ( 1 secs ) mash_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:35.512029
  102. ( 5 secs ) extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:05:00.503308
  103. ( 6 secs ) unit_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:04:58.739478 (shard #1)
    Min shard duration: 0:03:56.787498 (shard #0)
  104. ( 1 secs ) wait for tasks (3)
  105. ( 8 secs ) single_process_mash_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:10:33.503787 (shard #0)
    Min shard duration: 0:06:58.007100 (shard #1)
  106. ( 4 mins 14 secs ) wait for tasks (4)
  107. ( 3 secs ) sync_integration_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:13:54.937685
  108. ( 8 mins 4 secs ) wait for tasks (5)
  109. ( 7 secs ) viz_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:22:21.644475 (shard #0)
    Min shard duration: 0:21:54.636135 (shard #1)
  110. ( 1 secs ) wait for tasks (6)
  111. ( 2 secs ) interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:23:56.942471 (shard #1)
    Min shard duration: 0:15:58.961638 (shard #4)
  112. ( 2 mins 1 secs ) wait for tasks (7)
  113. ( 3 secs ) webui_polymer2_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:25:57.592072 (shard #1)
    Min shard duration: 0:20:48.725375 (shard #3)
  114. ( 12 mins 4 secs ) wait for tasks (8)
  115. ( 4 secs ) content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:37:14.268920
  116. ( 57 secs ) browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:39:46.334811 (shard #2)
    Min shard duration: 0:19:50.742362 (shard #4)
  117. ( 2 mins 1 secs ) wait for tasks (9)
  118. ( 3 secs ) single_process_mash_interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:40:47.131425 (shard #0)
    Min shard duration: 0:19:59.663877 (shard #1)
  119. ( 1 mins 7 secs ) single_process_mash_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:42:16.572270 (shard #2)
    Min shard duration: 0:24:01.910466 (shard #7)
  120. ( 2 mins 58 secs ) viz_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:47:55.534693 (shard #2)
    Min shard duration: 0:25:44.955975 (shard #19)
  121. ( 1 secs ) Tests statistics
     
    Stats
    Total shards: 181
    Total runtime: 1 day, 15:40:26.104259
     
  122. ( 3 ms ) recipe result

Build Properties:

NameValueSource
$build/goma {"jobs": 500} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2374-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541782524297895, "id": "8930317563760860320", "project": "chromium", "tags": ["builder:Linux ChromiumOS MSan Tests", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/b02a7719f78de1e78ded7807aa4d139f8c2b77d6", "gitiles_ref:refs/heads/master", "parent_buildername:Linux ChromiumOS MSan Builder", "parent_buildnumber:9681", "scheduler_invocation_id:9095747625969382240", "scheduler_job_id:chromium/Linux ChromiumOS MSan Tests", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Linux ChromiumOS MSan Tests" setup_build
buildnumber 9536 setup_build
mastername "chromium.memory" setup_build
parent_buildername "Linux ChromiumOS MSan Builder" setup_build
parent_got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" setup_build
parent_got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" setup_build
parent_got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" setup_build
parent_got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" setup_build
parent_got_revision "b02a7719f78de1e78ded7807aa4d139f8c2b77d6" setup_build
parent_got_revision_cp "refs/heads/master@{#606850}" setup_build
parent_got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" setup_build
parent_got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" setup_build
parent_got_v8_revision_cp "refs/heads/7.2.286@{#1}" setup_build
parent_got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25544}" setup_build
parent_mastername "chromium.memory" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "b02a7719f78de1e78ded7807aa4d139f8c2b77d6" setup_build
swarm_hashes {"accessibility_unittests": "25bc8b39b3fe9fec91e340e4feb34e1d71bd8a93", "angle_unittests": "1ae9ec4fa92cc4d5686f7e16dc10e7017a74b592", "app_list_unittests": "8adda49481b54b90be12445270262ee41769f9ab", "app_shell_unittests": "946c5b70d5cb8a327bd22108a20c608eb6db2f0e", "ash_content_unittests": "8f5040077dce456e6a72981255bbff390cf3fd02", "ash_unittests": "9a3e882d0621096c5724226adfe2a50ddb536347", "aura_unittests": "7c331f11c6c105e350a1a29ba4a599b56f8d29e3", "base_unittests": "d5129854b5a7ed62c11e71f93f5dfc1c60dabbe0", "blink_common_unittests": "f31b2c6651877f859388a9bbd20a180e23eaabba", "blink_fuzzer_unittests": "d18afaffad0bd73e7e7d05bf38992982a5bf8774", "blink_heap_unittests": "268592f30836e8a9b2791ad700501ae8ad23673f", "blink_platform_unittests": "a56f25222dfe3ae6a3964792150ea58ce2aedc1b", "boringssl_crypto_tests": "bdb32aee1b1cd627fb368f04794f6b2edef27dd6", "boringssl_ssl_tests": "453e037f0b62af785a4e212f3ce6d17e6dab3e67", "browser_tests": "406a76044e2fd6f4c9ec5bef0e3e9f8d9cf19d2a", "cacheinvalidation_unittests": "b8fcea13c7d0ee160147318ce2c16a7f60e55f34", "capture_unittests": "5fd47b4eefa94d97650514e3504446db953337a5", "cast_unittests": "fdf438746c8a00396e42432387cee7ac1a761ec7", "cc_unittests": "07da20bc168f5022056e6a1cf154dca09140dd5e", "chrome_app_unittests": "f42a9f4e1565833b666cfcbfb998bc89ec7b8e36", "chromedriver_unittests": "cbb378b33a5751a3d7559371c6dc60a46f0ba586", "chromeos_components_unittests": "28b290d09f07df28105a89b99261898a239dd3e2", "chromeos_unittests": "0ac678e1fe6f44cd3982693656c15cf5a14ce265", "components_browsertests": "7359b7a96c3f54e35fe09ecedf3291e21018ad91", "components_unittests": "dfa386041cfa20d5883b8a7cc38144f8bfc0d9a8", "compositor_unittests": "2787a78aee25c6c40210975361ed15d9f3b5d826", "content_browsertests": "137b915f733c9862fe994c47e079a4284d43a585", "content_unittests": "9722da9fd7b149c4d3ede5ba380d3e0f7aa56029", "crypto_unittests": "faa5674e8aa7258b743de98828ed0ed352a5687c", "dbus_unittests": "4dd9a0f2f13f30d5c88bcdc21466270b36be2046", "device_unittests": "73243e23e62dda2d253f25eaf3211dc9739933c5", "display_unittests": "b300d20aefcc610ace785b8d8b841591011c59f8", "events_unittests": "163e731bf43c76799d5a9ca4536ea8aae4e0bca4", "exo_unittests": "124db6de439932e40794cc49f02c8d79500fce39", "extensions_browsertests": "8af3ef923ded8b396f6faa155bb26601b28c92f5", "extensions_unittests": "eec5a8865162b9f10e795af9d12731f5042f415a", "filesystem_service_unittests": "c4e1ac79cdb64014603198aeb79901b8c08d36d1", "gcm_unit_tests": "2e4c783c095ba7ac1f97ea0c050f5b13e249c369", "gfx_unittests": "9f6a502bfca366c263856d7ced3e276ce61e8725", "gin_unittests": "956b7c799c0d27111bf01944d2d760156c1cd4e9", "google_apis_unittests": "dc5dbf2f40273499d80493848c419c4c336be55e", "gpu_unittests": "242bb4b45d6cb6057f4f5a7839e3343548be29cb", "interactive_ui_tests": "7d5090fdf5910a2318fc915f7f8bd7497a0403b2", "ipc_tests": "6b742ba8b4276ca7ee0d7af0726728af33236227", "jingle_unittests": "6a43bbd1ad616e00111269802412a9ff25d2ac30", "keyboard_unittests": "3f605d7b240e3e9266069a076af3b9c3026f65cb", "latency_unittests": "15de018f26dd959b3bddae9938243ef71e2325ce", "leveldb_service_unittests": "9b0bb39d8a1524fa883c1afdfe5e43fc9e11c467", "libjingle_xmpp_unittests": "306956e4a53b84b91d4095e6581c0f2fb4a6b792", "media_blink_unittests": "23a01bd01047893c7b131da33f15354e7623ca94", "media_service_unittests": "9e8bff0e540bed20a3c2b3c8ce2958a91c041fa5", "media_unittests": "bc3435927f85ed7c5876d093ee30be9606ca8c12", "message_center_unittests": "bf69e8b8012000fdf1a172e00176d014842496e8", "midi_unittests": "2d602ded93b4cc5055b6e2f75919cd912ad8ce57", "mojo_core_unittests": "7767798ada430ace6a416bf1f341353f035927d9", "mojo_unittests": "f3b253efe571d389f660b54b34c2e1507f9bc8fa", "nacl_helper_nonsfi_unittests": "077b5ba5bc63ea90573e0fa83ec8f9b97d184825", "nacl_loader_unittests": "6524f6ba800c0bae8143750937d2d0c7d031f5aa", "native_theme_unittests": "79a33e844741b4c4257925f9110f9b790e9ed66f", "net_unittests": "3ddcd547f6261dd6535be8e7b472740a2afdb816", "ozone_gl_unittests": "7b1b57cb8f8b4fa8c65c7da1ed82e398752e2a92", "ozone_unittests": "91de261fca0d7801e77e15a001b32e32d9c7e670", "ozone_x11_unittests": "52de3ac9b53dbe9571fa35b6b789e0773c2aebbb", "pdf_unittests": "dd5e6be93a28bc323d0255ef18b05675289076ba", "ppapi_unittests": "e48e93d5e99fbc6892ecda0bbdeff18bd6907d68", "printing_unittests": "c87ebb5358907e26261adb0f047540fa879dacd0", "remoting_unittests": "c040b1afb890112acd68cc3aa5e237f6ecb04465", "sandbox_linux_unittests": "c6a442b434e9006e0d8f5ce6e4307103b09ef68e", "service_manager_unittests": "68763ec32831e3e8f8ec09d7ccdf02379c21e48c", "shell_dialogs_unittests": "6df36bcca12d57baad1f1eff3a0cca9c21e53e90", "skia_unittests": "c4cc11d1e69a9c33914eb764f7db452f92432cec", "snapshot_unittests": "059c7743c65250de3efc1581a93ed68a1e78a536", "sql_unittests": "3d8ac0d3254889a38ee681adf866137f70c541d2", "storage_unittests": "01a973285717feaa702f77bb0029868fed8815ce", "sync_integration_tests": "db30c1d975b554d07c6f13c35725968ed74f8894", "traffic_annotation_auditor_unittests": "5f38d5dd0a593f2cd7fbeedc1dc4f706e6776758", "ui_base_unittests": "b7342925d2d46cf04f02c1d5b4915f34d3bc1c32", "ui_chromeos_unittests": "ed422b978d48a318d7628b0bd30d1aea6879fc9d", "ui_touch_selection_unittests": "239894d8d77507c03b95cee4465d0b16a0cebf12", "unit_tests": "f271f042818a681fa127c512e237fea838c46021", "url_unittests": "d4239aeb53a3b3e0e77b35749209b08af1ef7ce3", "views_mus_interactive_ui_tests": "0cacab3ed6d1eb1f36c75d57b802053e23049d76", "views_mus_unittests": "93a31bf31fa051554b7ff9e18ea70fc02f91d83c", "views_unittests": "34e9f9894aabd9637ae41a253bd38360bf1f16fc", "viz_unittests": "229cffe31bf5c781b1c775736b869a3e3e8efb9b", "wayland_client_perftests": "a21edf42dd8075aee1ad1acf1423e2a3302141c4", "webkit_unit_tests": "e0f3788fed35f3322eca42ffb30a0ad86d444db6", "wm_unittests": "ded525edad90245deff93b04c4d059a5d26076ea", "wtf_unittests": "10a605970bc06cd8780be3ff593d17b873adc830"} setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "b02a7719f78de1e78ded7807aa4d139f8c2b77d6" bot_update
got_revision_cp "refs/heads/master@{#606850}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" bot_update
got_v8_revision_cp "refs/heads/7.2.286@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. David Jean (djeanohnoyoudont@google.com)
  2. Aaron Krajeski (aaronhkohnoyoudont@google.com)
  3. Marc Treib (treibohnoyoudont@chromium.org)
  4. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  5. Hiroshige Hayashizaki (hiroshigeohnoyoudont@chromium.org)
  6. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  7. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  8. Lukasz Suder (lsuderohnoyoudont@google.com)
  9. Greg Thompson (grtohnoyoudont@chromium.org)
  10. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  11. Corentin Wallez (cwallezohnoyoudont@chromium.org)
  12. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  13. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  14. Ioana Pandele (ioanapohnoyoudont@chromium.org)
  15. Sam Maier (smaierohnoyoudont@chromium.org)
  16. Hiroshige Hayashizaki (hiroshigeohnoyoudont@chromium.org)
  17. Rohit Rao (rohitraoohnoyoudont@chromium.org)
  18. Sigurdur Asgeirsson (siggiohnoyoudont@chromium.org)
  19. Mike Reed (reedohnoyoudont@google.com)
  20. Marc Treib (treibohnoyoudont@chromium.org)
  21. Marc Treib (treibohnoyoudont@chromium.org)
  22. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)

Timing:

Create Friday, 09-Nov-18 16:55:24 UTC
Start Friday, 09-Nov-18 16:55:35 UTC
End Friday, 09-Nov-18 17:47:11 UTC
Pending 11 secs
Execution 51 mins 35 secs

All Changes:

  1. [ios] add manual fallback credit card and address coordinator

    Changed by David Jean - djeanohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:34:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b02a7719f78de1e78ded7807aa4d139f8c2b77d6

    Comments

    [ios] add manual fallback credit card and address coordinator
    
    And a common base class.
    
    Bug: 845472
    Change-Id: I12999d306804227e605e270c9b4f14bd8ee6a2bb
    Reviewed-on: https://chromium-review.googlesource.com/c/1318914
    Reviewed-by: Eric Noyau <noyau@chromium.org>
    Commit-Queue: David Jean <djean@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606850}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
    • ios/chrome/browser/ui/autofill/manual_fill/address_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/address_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/address_list_delegate.h
    • ios/chrome/browser/ui/autofill/manual_fill/card_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/card_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/card_list_delegate.h
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.mm
  2. Add RAF tests to blink_perf.canvas benchmark.

    Changed by Aaron Krajeski - aaronhkohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:28:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7149ab705c9a7c1c9c57c960c05e2de216680c7d

    Comments

    Add RAF tests to blink_perf.canvas benchmark.
    
    Current canvas benchmarks only measure CPU time.
    Using requestAnimationFrame (raf) in javascript we can
    measure CPU + raster + GPU time. This CL adds a mode to
    blink_perf.py that runs canvas all canvas test in a way
    that takes raster and GPU time into account.
    
    Roughly doubles the duration of `blink_perf.canvas`
    benchmark from ~2 minutes to ~4 minutes on a linux desktop.
    
    Bug: 894043
    Change-Id: I2fdd13af75615802266fa39a01db3e883f2c95bc
    Reviewed-on: https://chromium-review.googlesource.com/c/1300038
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Reviewed-by: Fernando Serboncini <fserb@chromium.org>
    Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606849}

    Changed files

    • docs/speed/benchmark/harnesses/blink_perf.md
    • third_party/blink/perf_tests/canvas/OWNERS
    • third_party/blink/perf_tests/canvas/gpu-bound-shader.html
    • third_party/blink/perf_tests/canvas/resources/canvas_runner.js
    • third_party/blink/perf_tests/canvas/sheets-render.html
    • third_party/blink/perf_tests/canvas/upload-webgl-to-texture.html
    • tools/perf/benchmark.csv
    • tools/perf/benchmarks/blink_perf.py
    • tools/perf/contrib/blink_layoutng_perf/blink_layoutng_perf.py
    • tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py
    • tools/perf/contrib/blink_perf_xml_http_request/blink_perf_xml_http_request.py
    • tools/perf/core/shard_maps/android-nexus5x-perf_map.json
    • tools/perf/core/shard_maps/android_nexus5_perf_map.json
    • tools/perf/core/shard_maps/android_nexus5x_webview_perf_map.json
    • tools/perf/core/shard_maps/android_nexus6_webview_perf_map.json
    • tools/perf/core/shard_maps/linux-perf_map.json
    • tools/perf/core/shard_maps/mac-10_12_laptop_low_end-perf_map.json
    • tools/perf/core/shard_maps/mac-10_13_laptop_high_end-perf_map.json
    • tools/perf/core/shard_maps/win-10-perf_map.json
    • tools/perf/core/shard_maps/win_7_nvidia_gpu_perf_map.json
    • tools/perf/core/shard_maps/win_7_perf_map.json
  3. SyncStandaloneTransport: Add integration test for "Reset Sync" from dashboard

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:27:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 413493e0052d3f0537cf96d619849e8acf248658

    Comments

    SyncStandaloneTransport: Add integration test for "Reset Sync" from dashboard
    
    Bug: 856179
    Change-Id: I0fb499c5bb5c0de6df4fa7c2f46d3b0b35f5f0df
    Reviewed-on: https://chromium-review.googlesource.com/c/1326901
    Commit-Queue: Marc Treib <treib@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606848}

    Changed files

    • chrome/browser/sync/test/integration/single_client_standalone_transport_sync_test.cc
    • components/sync/test/fake_server/fake_server.cc
    • components/sync/test/fake_server/fake_server.h
  4. Fix MergeAndOverrideOnConflict for custom properties.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:25:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3052bf26cacf33ea7dd70fda7cccb5bebb28cfe9

    Comments

    Fix MergeAndOverrideOnConflict for custom properties.
    
    Utilizing CSSPropertyName, to make the code much nicer.
    
    R=futhark@chromium.org
    
    Change-Id: I10733cabe27cc271eaaf3ecf62fa7713cf74eac3
    Reviewed-on: https://chromium-review.googlesource.com/c/1323650
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606847}

    Changed files

    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/css/css_property_value.cc
    • third_party/blink/renderer/core/css/css_property_value.h
    • third_party/blink/renderer/core/css/css_property_value_set.cc
    • third_party/blink/renderer/core/css/css_property_value_set.h
    • third_party/blink/renderer/core/css/css_property_value_set_test.cc
  5. Add redirected cases to CSP/import tests in wpt/worklets

    Changed by Hiroshige Hayashizaki - hiroshigeohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:21:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ff65400edef4c2d8e8ed01f1e2bd60c1c55aa8c

    Comments

    Add redirected cases to CSP/import tests in wpt/worklets
    
    Also this CL replaces some of empty-worklet-script.js usage
    in CSP tests with empty-worklet-script-with-cors-header.js
    to make sure worklets are rejected due to CSP, not CORS.
    
    Change-Id: Ie463d206254c4c6728a79dae0ad79e4f7e333b92
    Reviewed-on: https://chromium-review.googlesource.com/c/1312146
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606846}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/csp-tests.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-insecure-origin-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-insecure-origin-redirected-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-remote-origin-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-remote-origin-redirected-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-tests.js
  6. Add UseCounter for unknown namespace usage in selectors.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:21:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3c413c91c21481af23cfb54d742e80fd2b589608

    Comments

    Add UseCounter for unknown namespace usage in selectors.
    
    R=chrishtr@chromium.org
    
    Bug: 901938
    Change-Id: I9e20fe19f2c97b98f8250c6c9914512b5a73d8c7
    Reviewed-on: https://chromium-review.googlesource.com/c/1318891
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606845}

    Changed files

    • third_party/blink/public/platform/web_feature.mojom
    • third_party/blink/renderer/core/css/parser/css_selector_parser.cc
    • third_party/blink/renderer/core/frame/use_counter_test.cc
    • tools/metrics/histograms/enums.xml
  7. Retire NotificationInlineReplies runtime enabled flag.

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:15:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5395d94feaf7a04c1a7fd9832d3750c636d6dea1

    Comments

    Retire NotificationInlineReplies runtime enabled flag.
    
    NotificationInlineReplies shipped in M70.
    
    BUG=834580
    
    Change-Id: Ibed1612aae4c21a239e9328d7134cd75169c713a
    Reviewed-on: https://chromium-review.googlesource.com/c/1323615
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606844}

    Changed files

    • third_party/blink/renderer/modules/notifications/notification_action.idl
    • third_party/blink/renderer/modules/notifications/notification_event.idl
    • third_party/blink/renderer/modules/notifications/notification_event_init.idl
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  8. [Autofill Assistant] Fixes Payement Request details bug.

    Changed by Lukasz Suder - lsuderohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:13:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision be08662134b0c40ff6913cf531e2fefed5c2d4d9

    Comments

    [Autofill Assistant] Fixes Payement Request details bug.
    
    Before all details where asked each time.
    
    Bug: 806868
    Change-Id: Ie3a278e2882d4829cfe2c54ac641d10abf5af2e6
    Reviewed-on: https://chromium-review.googlesource.com/c/1329167
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Commit-Queue: Lukasz Suder <lsuder@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606843}

    Changed files

    • components/autofill_assistant/browser/actions/get_payment_information_action.cc
  9. Fix the icons for the app menu and the upgrade item in it when an update is available.

    Changed by Greg Thompson - grtohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:12:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a5a766d75a0eb8006212cb5cee94d704650c787b

    Comments

    Fix the icons for the app menu and the upgrade item in it when an update is available.
    
    A regression was introduced in r581520 that caused the wrong icon and/or
    the wrong coloring to be used in some circumstances. This CL fixes this
    in two parts:
    
    - AppMenuIconController may decide that the "annoyance level" from a
      pending update is too low to bother the user. One bug introduced in
      r581520 was that the controller still notified delegates that the
      UPGRADE_NOTIFICATION icon type should be used in this case. Now, the
      VERY_LOW annoyance level is ignore entirely for beta and stable
      channels.
    
    - AppMenuModel no longer bases its decision to include the upgrade menu
      item directly on the UpgradeDetector. Rather, it now queries the
      AppMenuIconController. This ensures that the same logic is used for
      both the badging of the app menu and for the presence of the upgrade
      item in the menu.
    
    BUG=898958
    
    Change-Id: I4b761844365968a24bc69030d711122fcaf16e28
    Reviewed-on: https://chromium-review.googlesource.com/c/1312475
    Commit-Queue: Greg Thompson <grt@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606842}

    Changed files

    • chrome/browser/ui/toolbar/app_menu_icon_controller.cc
    • chrome/browser/ui/toolbar/app_menu_icon_controller.h
    • chrome/browser/ui/toolbar/app_menu_icon_controller_unittest.cc
    • chrome/browser/ui/toolbar/app_menu_model.cc
    • chrome/browser/ui/toolbar/app_menu_model.h
    • chrome/browser/ui/toolbar/app_menu_model_unittest.cc
    • chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
    • chrome/browser/ui/views/toolbar/browser_app_menu_button.h
    • chrome/browser/ui/views/toolbar/toolbar_view.cc
    • chrome/browser/ui/views/toolbar/toolbar_view.h
    • chrome/test/BUILD.gn
  10. Import wpt@47f0061f15dd2973dab11d87c03f0c8264d32e02

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 15:09:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c42eb303c89bfba751ae499abfb7252e2ceb7532

    Comments

    Import wpt@47f0061f15dd2973dab11d87c03f0c8264d32e02
    
    Using wpt-import in Chromium 43d0eed3db77a5e6167b5ebbf6ecb3710790272a.
    With Chromium commits locally applied on WPT:
    270d4abddc "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content."
    
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    NOAUTOREVERT=true
    TBR=foolip
    
    No-Export: true
    Change-Id: I4bcac484d08efe8d6e6412d40b1c7d73ffe512d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1329061
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606841}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/selection-api.idl
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/webrtc.idl
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt
    • third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
  11. testing/buildbot: add fake bots to run Dawn's GPU tests.

    Changed by Corentin Wallez - cwallezohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:05:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9f2b5efa43dfe2ff69fab31ba83c352ecf8e62ab

    Comments

    testing/buildbot: add fake bots to run Dawn's GPU tests.
    
    BUG=chromium:901830
    
    Change-Id: I5c5b0b08fadddc34f6a2d176ae39ebfae7e7f706
    Reviewed-on: https://chromium-review.googlesource.com/c/1326157
    Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606840}

    Changed files

    • testing/buildbot/chromium.gpu.fyi.json
    • testing/buildbot/generate_buildbot_json.py
    • testing/buildbot/gn_isolate_map.pyl
    • testing/buildbot/test_suites.pyl
    • testing/buildbot/waterfalls.pyl
  12. Roll src/third_party/perfetto 606ed681f4ea..fd986312652f (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 15:03:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01d002523922e64775a90ae4fbcb831f3aebf024

    Comments

    Roll src/third_party/perfetto 606ed681f4ea..fd986312652f (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/606ed681f4ea..fd986312652f
    
    
    git log 606ed681f4ea..fd986312652f --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 hjd@google.com Merge "perfetto-ui: Fix UI with counter only traces"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@fd986312652f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I602c7205239349ff0faf4467740388c6cb05725f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329044
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606839}

    Changed files

    • DEPS
  13. Roll src-internal c458532c0628..6166365225d6 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 14:56:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 02a2080524dcf1a59efd81b88b8a6526fc6224ee

    Comments

    Roll src-internal c458532c0628..6166365225d6 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c458532c0628..6166365225d6
    
    
    Created with:
      gclient setdep -r src-internal@6166365225d6
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I57783466072640b229610c2550d50f9c46d0c4e9
    Reviewed-on: https://chromium-review.googlesource.com/c/1329043
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606838}

    Changed files

    • DEPS
  14. Add a provider for the Passwords UI in Settings

    Changed by Ioana Pandele - ioanapohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:51:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision feda313fc19c2032e21eed604a1a0e58d42587ee

    Comments

    Add a provider for the Passwords UI in Settings
    
    This CL introduces ManagePasswordsUIProvider, a class which aims to allow
    for alternative UI surfaces to be shown if available.
    
    Bug: 903249
    Change-Id: I8c03f2f539772044bd5ba0fa944fd5e441d43c76
    Reviewed-on: https://chromium-review.googlesource.com/c/1326488
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Ioana Pandele <ioanap@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606837}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java
    • chrome/android/java/src/org/chromium/chrome/browser/password_manager/ManagePasswordsUIProvider.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
    • chrome/android/java_sources.gni
  15. Apk for test proguard flags ignoring classes which don't exist

    Changed by Sam Maier - smaierohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:50:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b4fffd63b4281c67f7e142087c476ce903a5a08a

    Comments

    Apk for test proguard flags ignoring classes which don't exist
    
    Bug: 872904
    Change-Id: Ib178be906c8d74ecabd7cfafeba8e7cf3a3398ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1327331
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Reviewed-by: Sam Maier <smaier@chromium.org>
    Commit-Queue: Sam Maier <smaier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606836}

    Changed files

    • chrome/android/java/apk_for_test.flags
  16. Enable multiple WorkerFetchContext per one global scope

    Changed by Hiroshige Hayashizaki - hiroshigeohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:46:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7ede5922f5c054c81b5ea049651775ab0503582c

    Comments

    Enable multiple WorkerFetchContext per one global scope
    
    Currently WorkerFetchContext has the ownership of
    some objects originated from WebWorkerFetchContext.
    To create multiple WorkerFetchContexts
    for one WorkerOrWorkletGlobalScope/WebWorkerFetchContext,
    this CL moves these ownership outside WorkerFetchContext.
    Namely,
    - url_loader_factory_ and script_loader_factory_
      from WorkerFetchContext to WebWorketFetchContext subclasses, and
    - subresource_filter_ from WorkerFetchContext to
      WorkerOrWorkletGlobalScope.
      Still |WorkerFetchContext::subresource_filter_| is kept, but
      it is created in WorkerOrWorkletGlobalScope and passed to
      WorkerFetchContext.
    
    This CL doesn't change the observable behavior.
    This CL creates WebURLLoaderFactory a little more eagerly, i.e.
    when WorkerFetchContext is created,
    while previously it was created when
    WorkerFetchContext::CreateURLLoader() is called for the first time.
    
    Bug: 880027, 903579
    Change-Id: I84a8bafee25b7f293201a271d198260e2dfb8e68
    Reviewed-on: https://chromium-review.googlesource.com/c/1193385
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606835}

    Changed files

    • content/renderer/loader/web_worker_fetch_context_impl.cc
    • content/renderer/loader/web_worker_fetch_context_impl.h
    • content/renderer/service_worker/service_worker_fetch_context_impl.cc
    • content/renderer/service_worker/service_worker_fetch_context_impl.h
    • third_party/blink/public/platform/web_worker_fetch_context.h
    • third_party/blink/renderer/core/loader/worker_fetch_context.cc
    • third_party/blink/renderer/core/loader/worker_fetch_context.h
    • third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
    • third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h
  17. [ios] Deletes unused code that was migrated from ios/clean.

    Changed by Rohit Rao - rohitraoohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:41:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6e3ace0051b91c7144046c60acd04c7d658c9b09

    Comments

    [ios] Deletes unused code that was migrated from ios/clean.
    
    BUG=None
    
    Change-Id: I3a14f465f152e9b1b514802723093e9702edc001
    Reviewed-on: https://chromium-review.googlesource.com/c/1326487
    Reviewed-by: edchin <edchin@chromium.org>
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: edchin <edchin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606834}

    Changed files

    • ios/chrome/browser/browser_state/BUILD.gn
    • ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm
    • ios/chrome/browser/ui/coordinators/BUILD.gn
    • ios/chrome/browser/ui/coordinators/browser_coordinator+internal.h
    • ios/chrome/browser/ui/coordinators/browser_coordinator.h
    • ios/chrome/browser/ui/coordinators/browser_coordinator.mm
    • ios/chrome/browser/ui/coordinators/browser_coordinator_test.h
    • ios/chrome/browser/ui/coordinators/browser_coordinator_test.mm
    • ios/chrome/browser/ui/coordinators/browser_coordinator_test_util.h
    • ios/chrome/browser/ui/coordinators/browser_coordinator_test_util.mm
    • ios/chrome/browser/ui/coordinators/browser_coordinator_unittest.mm
    • ios/chrome/browser/ui/coordinators/test_browser_coordinator.h
    • ios/chrome/browser/ui/coordinators/test_browser_coordinator.mm
    • ios/chrome/browser/ui/main_content/BUILD.gn
    • ios/chrome/browser/ui/main_content/main_content_coordinator.h
    • ios/chrome/browser/ui/main_content/main_content_coordinator.mm
    • ios/chrome/browser/ui/main_content/main_content_coordinator_unittest.mm
    • ios/chrome/browser/ui/overlays/BUILD.gn
    • ios/chrome/browser/ui/overlays/OWNERS
    • ios/chrome/browser/ui/overlays/browser_overlay_queue.h
    • ios/chrome/browser/ui/overlays/browser_overlay_queue.mm
    • ios/chrome/browser/ui/overlays/overlay_coordinator+internal.h
    • ios/chrome/browser/ui/overlays/overlay_coordinator.h
    • ios/chrome/browser/ui/overlays/overlay_coordinator.mm
    • ios/chrome/browser/ui/overlays/overlay_queue.h
    • ios/chrome/browser/ui/overlays/overlay_queue.mm
    • ios/chrome/browser/ui/overlays/overlay_queue_manager.h
    • ios/chrome/browser/ui/overlays/overlay_queue_manager.mm
    • ios/chrome/browser/ui/overlays/overlay_queue_manager_observer.h
    • ios/chrome/browser/ui/overlays/overlay_queue_manager_unittest.mm
    • ios/chrome/browser/ui/overlays/overlay_queue_observer.h
    • ios/chrome/browser/ui/overlays/overlay_queue_unittest.mm
    • ios/chrome/browser/ui/overlays/overlay_scheduler.h
    • ios/chrome/browser/ui/overlays/overlay_scheduler.mm
    • ios/chrome/browser/ui/overlays/overlay_scheduler_observer.h
    • ios/chrome/browser/ui/overlays/overlay_scheduler_unittest.mm
    • ios/chrome/browser/ui/overlays/overlay_service.h
    • ios/chrome/browser/ui/overlays/overlay_service_factory.h
    • ios/chrome/browser/ui/overlays/overlay_service_factory.mm
    • ios/chrome/browser/ui/overlays/overlay_service_impl.h
    • ios/chrome/browser/ui/overlays/overlay_service_impl.mm
    • ios/chrome/browser/ui/overlays/overlay_service_observer.h
    • ios/chrome/browser/ui/overlays/overlay_service_observer_bridge.h
    • ios/chrome/browser/ui/overlays/overlay_service_observer_bridge.mm
    • ios/chrome/browser/ui/overlays/test/BUILD.gn
    • ios/chrome/browser/ui/overlays/test/overlay_coordinator_test.h
    • ios/chrome/browser/ui/overlays/test/overlay_coordinator_test.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_coordinator.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_coordinator.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_parent_coordinator.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_parent_coordinator.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue_manager_observer.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue_manager_observer.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue_observer.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue_observer.mm
    • ios/chrome/browser/ui/overlays/web_state_overlay_queue.h
    • ios/chrome/browser/ui/overlays/web_state_overlay_queue.mm
    • ios/chrome/test/BUILD.gn
  18. RC: Compress all chrome://discards resources.

    Changed by Sigurdur Asgeirsson - siggiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:35:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e826ee9592541ae9d53fd23c51761adf9df17cfc

    Comments

    RC: Compress all chrome://discards resources.
    
    I don't know whether to trust these numbers, but this is what I see
    for my local Windows release 32 bit build.
    
    Uncompressed:
    3,034,139 browser_resources.pak
    233,038,336 mini_installer.exe
    
    Compressed:
    2,869,382 browser_resources.pak
    232,873,472 mini_installer.exe
    
    Bug: 891310
    Change-Id: I3db92ad65afc97b80a9acfbd2fabf486739d7822
    Reviewed-on: https://chromium-review.googlesource.com/c/1327406
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606833}

    Changed files

    • chrome/browser/browser_resources.grd
    • chrome/browser/ui/webui/discards/discards_ui.cc
  19. use SkFontHinting

    Changed by Mike Reed - reedohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 14:32:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf

    Comments

    use SkFontHinting
    
    Bug: skia:2664
    Change-Id: I22633705f2f21f95a223a193a1437d2311e5e205
    Reviewed-on: https://chromium-review.googlesource.com/c/1318416
    Commit-Queue: Mike Reed <reed@google.com>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Reviewed-by: Bill Budge <bbudge@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606832}

    Changed files

    • cc/paint/oop_pixeltest.cc
    • cc/paint/paint_flags.cc
    • cc/paint/paint_flags.h
    • chrome/renderer/pepper/pepper_flash_renderer_host.cc
    • content/renderer/render_view_fuchsia.cc
    • content/renderer/render_view_linux.cc
    • skia/config/SkUserConfig.h
    • third_party/blink/public/platform/web_font_render_style.h
    • third_party/blink/renderer/platform/fonts/font_metrics.cc
    • third_party/blink/renderer/platform/fonts/mac/font_platform_data_mac.mm
    • third_party/blink/renderer/platform/fonts/web_font_render_style.cc
    • third_party/blink/renderer/platform/graphics/logging_canvas.cc
  20. PersonalDataManager: Rename AccountStorageForServer(Cards->Data)

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:31:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 41c87263ae4560b264e15ec45be4832be2e79e86

    Comments

    PersonalDataManager: Rename AccountStorageForServer(Cards->Data)
    
    The account storage is now used for both server cards and server
    addresses.
    
    Bug: 864519
    Change-Id: Ia5fb5ebc4bd4e334b162378923ccd04562d4cac9
    Reviewed-on: https://chromium-review.googlesource.com/c/1329241
    Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606831}

    Changed files

    • chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
    • components/autofill/core/browser/personal_data_manager.cc
    • components/autofill/core/browser/personal_data_manager.h
  21. PersonalDataManager: Store server (aka Wallet) addresses in the Server DB

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:24:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 274ab9c5685ffb50c277a68979c46b4abf9c9455

    Comments

    PersonalDataManager: Store server (aka Wallet) addresses in the Server DB
    
    Currently, this makes no functional difference: In full Sync mode, the
    local DB and the server DB are the same thing anyway, and in
    lightweight/Butter mode, we don't store server addresses at all.
    However,
    1) this change will unlock actually supporting Wallet addresses in
       Butter mode, and
    2) it's just less confusing if "server" things are actually stored in
       the "server" DB.
    
    Bug: 864519
    Change-Id: I4f5479faff87cfa4f7def6b98f6b2235294393b8
    Reviewed-on: https://chromium-review.googlesource.com/c/1326492
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606830}

    Changed files

    • components/autofill/core/browser/personal_data_manager.cc
    • components/autofill/core/browser/personal_data_manager_unittest.cc
  22. Ribbon: Apply values via CustomProperty.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:23:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 634f8db566f7e5401be35e6d6d98f8858a41e0d0

    Comments

    Ribbon: Apply values via CustomProperty.
    
    Instead of applying custom properties via the static Variable instance,
    use the new CustomProperty class (which knows about its name and
    registration) to apply values. This brings the custom property code path
    closer to the standard property code path.
    
    To assist CSSPropertyRef in producing a CSSProperty&, this CL adds the
    class CSSPropertyName. The idea is that CSSPropertyName can be used instead
    of CSSPropertyID/AtomicString where both standard and custom properties are
    expected. My intent is to store a CSSPropertyName in
    CSSPropertyValueMetadata (instead of the CSSProperty*), but this is a big
    change, as everything that creates property/value pairs must carry the
    CSSPropertyName. So, for now PropertyReference.Name() is faking it by
    digging the name out of the associated CSSValue.
    
    Note that CSSPropertyName::ToAtomicString intentionally does not return
    a const AtomicString&. This is because 1) I want to try and reduce the
    size of CSSPropertyName to one pointer, which means it will contain a
    StringImpl* rather than an AtomicString, and 2) I want CSSPropertyName to
    be something that can be passed to other threads if needed, which again
    means StringImpl* (or String, at least) rather than AtomicString.
    
    In general, this CL is a step on the path to achieve these things:
    
     1. Removing the useless and dangerous static Variable instance.
     2. Not having to piggy-back the custom property name in a CSSValue.
     3. Not having to smuggle initial/inherit/unset via the
        CSSCustomPropertyDeclaration (vs. applying CSSIdentifierValues
        holding these values, like civilized individuals).
    
    R=flackr@chromium.org, futhark@chromium.org
    
    Change-Id: I1a062138fc86c5a398542ac147bf9d71feed7b3c
    Reviewed-on: https://chromium-review.googlesource.com/c/1323113
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606829}

    Changed files

    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/animation/css_default_interpolation_type.cc
    • third_party/blink/renderer/core/animation/css_var_cycle_interpolation_type.cc
    • third_party/blink/renderer/core/animation/property_handle.h
    • third_party/blink/renderer/core/animation/property_handle_test.cc
    • third_party/blink/renderer/core/css/BUILD.gn
    • third_party/blink/renderer/core/css/css_property_name.cc
    • third_party/blink/renderer/core/css/css_property_name.h
    • third_party/blink/renderer/core/css/css_property_name_test.cc
    • third_party/blink/renderer/core/css/css_property_value_set.cc
    • third_party/blink/renderer/core/css/css_property_value_set.h
    • third_party/blink/renderer/core/css/properties/css_property_ref.cc
    • third_party/blink/renderer/core/css/properties/css_property_ref.h
    • third_party/blink/renderer/core/css/properties/css_property_ref_test.cc
    • third_party/blink/renderer/core/css/properties/longhands/custom_property.cc
    • third_party/blink/renderer/core/css/properties/longhands/custom_property.h
    • third_party/blink/renderer/core/css/properties/longhands/variable.cc
    • third_party/blink/renderer/core/css/properties/longhands/variable.h
    • third_party/blink/renderer/core/css/resolver/css_variable_resolver_test.cc
    • third_party/blink/renderer/core/css/resolver/style_builder.cc
    • third_party/blink/renderer/core/css/resolver/style_builder.h
    • third_party/blink/renderer/core/css/resolver/style_resolver.cc