Home | Search | chromium - Builders
Login

Builder Linux ChromiumOS MSan Tests Build 9023 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision7422130d3da18b70d4cc81951feda2ab615edef9
Got Revision7422130d3da18b70d4cc81951feda2ab615edef9

Execution:

Steps and Logfiles:

Show:
  1. ( 292 ms ) setup_build
    running recipe: "chromium"
  2. ( 328 ms ) report builders
     
    running tester 'Linux ChromiumOS MSan Tests' on master 'chromium.memory'
  3. ( 21 secs ) bot_update
    [56GB/295GB used (18%)]
  4. ( 791 ms ) swarming.py --version
    0.13
  5. ( 10 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.memory.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.memory.json
  7. ( 661 ms ) lookup builder GN args
     
    is_component_build = false
    is_debug = false
    is_msan = true
    msan_track_origins = 2
    strip_absolute_paths_from_debug_symbols = true
    target_os = "chromeos"
    use_goma = true
    use_prebuilt_instrumented_libraries = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 660 ms ) build directory
  9. ( 649 ms ) find isolated tests
  10. ( 1 secs ) accessibility_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  11. ( 3 secs ) angle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:22.506557
  12. ( 1 secs ) app_list_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 20s
  13. ( 1 secs ) app_shell_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 39s
  14. ( 1 secs ) ash_content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  15. ( 2 secs ) ash_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:48.429422
  16. ( 2 secs ) single_process_mash_ash_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:50.084886
  17. ( 1 secs ) aura_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 20s
  18. ( 2 secs ) base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 56s
  19. ( 1 secs ) blink_common_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  20. ( 1 secs ) blink_fuzzer_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  21. ( 1 secs ) blink_heap_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 28s
  22. ( 2 secs ) blink_platform_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 34s
  23. ( 2 secs ) boringssl_crypto_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 36s
  24. ( 1 secs ) boringssl_ssl_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  25. ( 1 secs ) mash_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:34.064652
  26. ( 1 secs ) cacheinvalidation_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  27. ( 1 secs ) capture_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  28. ( 1 secs ) cast_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  29. ( 12 secs ) cc_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:04:22.140879
  30. ( 1 secs ) chrome_app_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 21s
  31. ( 1 secs ) chromedriver_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  32. ( 1 secs ) chromeos_components_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  33. ( 1 secs ) chromeos_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 33s
  34. ( 2 secs ) components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 52s
  35. ( 2 mins 40 secs ) components_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:07:13.162154
  36. ( 1 secs ) compositor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  37. ( 36 mins 24 secs ) content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:43:51.563906
  38. ( 1 secs ) perfetto_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 33s
  39. ( 4 secs ) single_process_mash_content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:51.527661
  40. ( 4 secs ) viz_content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:48.667799
  41. ( 1 secs ) crypto_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  42. ( 1 secs ) dbus_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  43. ( 1 secs ) device_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 21s
  44. ( 1 secs ) display_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  45. ( 1 secs ) events_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  46. ( 1 secs ) exo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 46s
  47. ( 1 secs ) single_process_mash_exo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 43s
  48. ( 1 secs ) extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:46.264652
  49. ( 2 secs ) extensions_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:00.442396
  50. ( 1 secs ) filesystem_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  51. ( 1 secs ) gcm_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  52. ( 3 secs ) gfx_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 40s
  53. ( 1 secs ) gin_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  54. ( 1 secs ) google_apis_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  55. ( 2 secs ) gpu_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 35s
  56. ( 1 secs ) webui_polymer2_interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 39s
  57. ( 1 secs ) ipc_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  58. ( 1 secs ) jingle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  59. ( 1 secs ) keyboard_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  60. ( 1 secs ) latency_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  61. ( 1 secs ) leveldb_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  62. ( 1 secs ) libjingle_xmpp_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 16s
  63. ( 1 secs ) media_blink_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 27s
  64. ( 1 secs ) media_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  65. ( 4 secs ) media_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:20.332569
  66. ( 2 secs ) message_center_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  67. ( 1 secs ) midi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  68. ( 1 secs ) mojo_core_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  69. ( 1 secs ) mojo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  70. ( 1 secs ) nacl_helper_nonsfi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  71. ( 1 secs ) nacl_loader_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  72. ( 1 secs ) native_theme_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  73. ( 1 secs ) ozone_gl_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  74. ( 1 secs ) ozone_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  75. ( 1 secs ) ozone_x11_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  76. ( 1 secs ) pdf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  77. ( 1 secs ) ppapi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  78. ( 1 secs ) printing_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  79. ( 2 secs ) remoting_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 28s
  80. ( 1 secs ) sandbox_linux_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  81. ( 1 secs ) select_to_speak_extension_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:29.781471
  82. ( 1 secs ) service_manager_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 22s
  83. ( 1 secs ) shell_dialogs_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  84. ( 1 secs ) skia_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  85. ( 1 secs ) snapshot_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 50s
  86. ( 1 secs ) sql_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  87. ( 2 secs ) storage_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  88. ( 3 secs ) sync_integration_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:15:00.084368
  89. ( 1 secs ) traffic_annotation_auditor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  90. ( 1 secs ) ui_base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  91. ( 1 secs ) ui_chromeos_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  92. ( 1 secs ) ui_touch_selection_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  93. ( 1 secs ) url_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  94. ( 1 secs ) views_mus_interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:16.110713
  95. ( 1 secs ) views_mus_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:29.614887
  96. ( 2 secs ) views_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 23s
  97. ( 3 secs ) viz_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:31.408285
  98. ( 1 secs ) wayland_client_perftests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 51s
  99. ( 4 secs ) webkit_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:36.693354
  100. ( 1 secs ) wm_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  101. ( 1 secs ) wtf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  102. ( 5 secs ) viz_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:21:32.287615 (shard #0)
    Min shard duration: 0:19:40.699880 (shard #1)
  103. ( 3 secs ) content_unittests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:01:10.023704 (shard #1)
    Min shard duration: 0:01:08.755918 (shard #0)
  104. ( 19 secs ) net_unittests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:07:08.702410 (shard #1)
    Min shard duration: 0:06:40.432642 (shard #0)
  105. ( 9 secs ) unit_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:04:45.937024 (shard #0)
    Min shard duration: 0:04:41.108912 (shard #1)
  106. ( 2 secs ) webui_polymer2_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:08:47.408585 (shard #0)
    Min shard duration: 0:05:17.894047 (shard #1)
  107. ( 3 secs ) single_process_mash_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:07:55.752503 (shard #3)
    Min shard duration: 0:05:08.157691 (shard #4)
  108. ( 2 secs ) interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:26:13.559055 (shard #1)
    Min shard duration: 0:12:21.563978 (shard #4)
  109. ( 2 secs ) chromevox_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:14:54.345273 (shard #2)
    Min shard duration: 0:08:45.643016 (shard #5)
  110. ( 44 secs ) browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max pending time: 13s (shard #0)
    Max shard duration: 0:37:36.847073 (shard #2)
    Min shard duration: 0:18:48.925492 (shard #14)
  111. ( 1 mins 4 secs ) single_process_mash_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:39:41.505076 (shard #2)
    Min shard duration: 0:19:46.248325 (shard #14)
  112. ( 45 secs ) viz_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:39:23.652633 (shard #2)
    Min shard duration: 0:22:38.413653 (shard #19)
  113. ( 1 secs ) Tests statistics
     
    Stats
    Total shards: 180
    Total runtime: 1 day, 9:53:40.817105
     
  114. ( 2 ms ) recipe result

Build Properties:

NameValueSource
$build/goma {"jobs": 500} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2374-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539347997775855, "id": "8932870349843611408", "project": "chromium", "tags": ["builder:Linux ChromiumOS MSan Tests", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/7422130d3da18b70d4cc81951feda2ab615edef9", "gitiles_ref:refs/heads/master", "parent_buildername:Linux ChromiumOS MSan Builder", "parent_buildnumber:9166", "scheduler_invocation_id:9098300412030365024", "scheduler_job_id:chromium/Linux ChromiumOS MSan Tests", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Linux ChromiumOS MSan Tests" setup_build
buildnumber 9023 setup_build
mastername "chromium.memory" setup_build
parent_buildername "Linux ChromiumOS MSan Builder" setup_build
parent_got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" setup_build
parent_got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" setup_build
parent_got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" setup_build
parent_got_revision "7422130d3da18b70d4cc81951feda2ab615edef9" setup_build
parent_got_revision_cp "refs/heads/master@{#599170}" setup_build
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" setup_build
parent_got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" setup_build
parent_got_v8_revision_cp "refs/heads/7.1.302@{#1}" setup_build
parent_got_webrtc_revision "28d200c24624f0f2ce3013e33effc4ffc123cc2c" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25136}" setup_build
parent_mastername "chromium.memory" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "7422130d3da18b70d4cc81951feda2ab615edef9" setup_build
swarm_hashes {"accessibility_unittests": "2b87e8b5895213dcd5f313cbeb268ada0f17b158", "angle_unittests": "14c3336d12873f5b76246adeeab3a9c3d9009589", "app_list_unittests": "d3791293a6e47cd6660551018ba5b35c63780e4a", "app_shell_unittests": "0d4df6bd6ea7749598e9adeb0dcb1866c2570f17", "ash_content_unittests": "43f64353f3fe5773cf5b4c047fbab38a77ccaa13", "ash_unittests": "4cbc46e3373791e4c009ff76175a04d7f86b0047", "aura_unittests": "52f292bbeeaa6b883204f4eb6f7e3ccf04e0bdaa", "base_unittests": "85ba5c66f990c82744d9a85ef585dcc2f760ff8c", "blink_common_unittests": "60f0f60bbec19ce9de03d4fe7689a332a19ce3ca", "blink_fuzzer_unittests": "9f6f7b210bb3ac3ea98b8bf70be46dbdd8200c62", "blink_heap_unittests": "b082a277417568aea86c9b17c76798d06a4cade4", "blink_platform_unittests": "fa0730d38cededb55cf490b4c38cc2368f3a4d54", "boringssl_crypto_tests": "848817e99a4794a18d12371cff9d86294b58fca5", "boringssl_ssl_tests": "309c6a61f7faadd544132873a96fb021c40c1343", "browser_tests": "09e6f4c90d14e5ee70735926a8127bc460fb122e", "cacheinvalidation_unittests": "c4747451b015f1480599c6269d0942cae0488223", "capture_unittests": "e54fd386a65d81b64c638b9cbf715379c5f8395e", "cast_unittests": "50dd26a8b2c40c63efceac7cda82990bb59d2910", "cc_unittests": "ba632f14a06c83fab367a5f0dcfe49342037cb70", "chrome_app_unittests": "8bb90500a97c44b3f4a58b43aaad9cf9333173a3", "chromedriver_unittests": "00d047386b0aeb6df1b5334a80c99f3104a3e2fd", "chromeos_components_unittests": "2361296c868aeec5c865850fcdd6075c9864a687", "chromeos_unittests": "ab9b2170dc55259f8e8adef6a0bd6170f1f00de5", "chromevox_tests": "5c610acca57f5ae24b1b13aae3528aee9c59f0d9", "components_browsertests": "96e7dee9b930712f9356e95116cac3caa5ad4417", "components_unittests": "bdc997be8f307f7fbb804bccb5c5fe9528bc8813", "compositor_unittests": "c924e05a599044b97c261ff474620630bb1a61e0", "content_browsertests": "0255b028439b538d266f349a602ab6c64349d65b", "content_unittests": "20e2fc30e7df1868a26711ddf3f09c23a8759ae7", "crypto_unittests": "bad090b8aff5a92ae4c48f4d2649f8d031a16beb", "dbus_unittests": "ebff7abe3204314803dedf6b94e4510821c63be4", "device_unittests": "16ff9c247d2cf1b987c7cb1b78503f80bc41c9d2", "display_unittests": "5e5cf82a93195695c1a9f50efa21ec4a07e4f988", "events_unittests": "baa62fe4a2183ffad9b7601aa2543c76ffefcf7e", "exo_unittests": "5a876046fe6a9cda00b6ff8f4035ee5cca4910a0", "extensions_browsertests": "1e9733813eca450207576c80ef6595d1f78581bb", "extensions_unittests": "010918d44ad81ae73160920b4fe3666d9e6f4a75", "filesystem_service_unittests": "37932d3a748a2d613f3b41daed2a88c57da39dd9", "gcm_unit_tests": "6d4ed6018f650e2e568ab0942d9f6debb00bd087", "gfx_unittests": "05166a6c742f3776c754f344d90b90e27a158e0a", "gin_unittests": "05aa94c55df29d7365ce400b87902da2abbdfb49", "google_apis_unittests": "6935b12cbd587e89dc456b5735eb9d0b6c19aa58", "gpu_unittests": "dfc6241f4ad4843d42407c004a6b9b57965329b8", "interactive_ui_tests": "2cae62daaecf32b198e99a40554835a08759c49f", "ipc_tests": "0e97f995b44c0383958a8bb13157ae4ca0648596", "jingle_unittests": "844f019dc77fb161a617249275dc84bd69c9b608", "keyboard_unittests": "bbfc8388ee74113b5e534950ede7baf24cfe550d", "latency_unittests": "2e8a3ec2e9db48ea04d6fc6845e7905a7cb2c541", "leveldb_service_unittests": "4d773b9ad2cc51d677ad45553f413e2de844e9bc", "libjingle_xmpp_unittests": "7887fbe5bd98112c7c8b670374b5e6110b135f20", "media_blink_unittests": "0580617e16a8c158808d47c6b34fe4f427da86a3", "media_service_unittests": "6f58e0d1fa110b00d459f0166c452c07f9918063", "media_unittests": "b39caa9078161c826c9e36a40a16b19a65d52756", "message_center_unittests": "eca222bc785b9516904af0262f3221876a47795e", "midi_unittests": "81897c564c035c73344880e482aff042f745f21d", "mojo_core_unittests": "e4134a3638b4eaf5bb230cbd624fb8acef7a4974", "mojo_unittests": "4a7dc80e65b5afbb12cbf0de77639b55990885a0", "nacl_helper_nonsfi_unittests": "e25ef5e5f0f1ba0dca22f1d59ae8562dfcd06861", "nacl_loader_unittests": "bf041b24a8563a6faa9da64adbc7bd2762bb0b3a", "native_theme_unittests": "a6665566348e4d5de3c249e700762c7b37626b60", "net_unittests": "169b87ce95097646d667a5a5906cf8e861e04183", "ozone_gl_unittests": "2a1f10e012c8d8142527a00339df5010dee8eddd", "ozone_unittests": "e6c8350c29c534d60c382e965c9aea0f8aea1787", "ozone_x11_unittests": "5ebef32f42f496b830162220c0465b4f7ea48e15", "pdf_unittests": "9fa8957c69fac2f58f5972f6ccbf06c07870dbae", "ppapi_unittests": "4d5b449de07cdd72bdcd2fe5b5172322bd11061d", "printing_unittests": "8af24b0871d47f49f4b88a30c13d0d0dc4b27b9d", "remoting_unittests": "94a9db8c6fe467bbd9ff974f3b086a8a8a331dcf", "sandbox_linux_unittests": "1fdddc4c49874a4af9f2a7dde32aa95a721ac6f3", "select_to_speak_extension_tests": "1276a7f8eda15ea0866ef3867faaaa5a3305ac1e", "service_manager_unittests": "67ff466b8e9af0ee0efff13ce85c3a98756b1740", "shell_dialogs_unittests": "cfcf2ad6146a549e9657a832f54570d9fb213cc8", "skia_unittests": "66a8a6b2bf0bccc2b2244df1ad68b2ef4643cd1a", "snapshot_unittests": "f1ecfbd06c27b931463e82f5ab52ca3bebb795a5", "sql_unittests": "5af226d206320566bd1bd72d600cca1642426da7", "storage_unittests": "98a0d31c60bdd81ec456aa803f7f63a9591166eb", "sync_integration_tests": "c498e412ea7a9b9d3788b85d2a51a8c8702d909e", "traffic_annotation_auditor_unittests": "49fec02fa030e3d9a62c4d329bc68dd195154409", "ui_base_unittests": "e20a50a31bf61c199be78dfe9d23b1988b0cd6d4", "ui_chromeos_unittests": "8752d9c274df99bf8890f3509daf12da3dbbba89", "ui_touch_selection_unittests": "dc4d51b70946fd7d02ce24b21fd10edf5c60ab6a", "unit_tests": "6bcd42d1223714364dafe42d120715df6fe4836c", "url_unittests": "0bb36ed8d3e3bfafbd3b92b97e149917ee8d1d1b", "views_mus_interactive_ui_tests": "4b7da3df917c06a7253cfafb9a6e0233c8c7972d", "views_mus_unittests": "70d1efdb2c9eeca431d89c1497eec7a7be4f2810", "views_unittests": "2c98f06e7f09747c906a8356b0063ac852bbe0bf", "viz_unittests": "b1cb5a6dcd9273ab6219a41b6e00bc54df459ea4", "wayland_client_perftests": "bccc6575547226fbe6b7f8ab488ef73111809447", "webkit_unit_tests": "f10f803d6c862a451cd57556cf23cdfe46bf39b5", "wm_unittests": "b39cc6f91d985302a3835a00b2cd2b4c8d32dbba", "wtf_unittests": "06764e074088585a986779daf0c4d1d8d0204dd7"} setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "7422130d3da18b70d4cc81951feda2ab615edef9" bot_update
got_revision_cp "refs/heads/master@{#599170}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "28d200c24624f0f2ce3013e33effc4ffc123cc2c" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25136}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. Guido Urdaneta (guidouohnoyoudont@chromium.org)
  2. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  3. Mihai Sardarescu (msardaohnoyoudont@chromium.org)
  4. Scott Wu (scottwuohnoyoudont@chromium.org)
  5. Laís Minchillo (laisminchilloohnoyoudont@chromium.org)
  6. Scott Wu (scottwuohnoyoudont@chromium.org)
  7. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  8. Jordan Demeulenaere (jdemeulenaereohnoyoudont@google.com)
  9. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  10. Kurt Horimoto (kkhorimotoohnoyoudont@chromium.org)
  11. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  12. Fan Yang (fayangohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 12:39:57 UTC
Start Friday, 12-Oct-18 12:40:25 UTC
End Friday, 12-Oct-18 13:38:31 UTC
Pending 28 secs
Execution 58 mins 5 secs

All Changes:

  1. Remove MediaStreamRegistry.

    Changed by Guido Urdaneta - guidouohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:20:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7422130d3da18b70d4cc81951feda2ab615edef9

    Comments

    Remove MediaStreamRegistry.
    
    This class is useless now that URL.createObjectURL(MediaStream) has
    been removed from the Web platform.
    
    Bug: 591719
    Change-Id: I4a56bd8c0cbb86dacab8dafa6acb807509a86367
    Reviewed-on: https://chromium-review.googlesource.com/c/1221320
    Reviewed-by: Camille Lamy <clamy@chromium.org>
    Reviewed-by: Reilly Grant <reillyg@chromium.org>
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Commit-Queue: Guido Urdaneta <guidou@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599170}

    Changed files

    • chrome/renderer/extensions/cast_streaming_native_handler.cc
    • chrome/renderer/extensions/cast_streaming_native_handler.h
    • chrome/renderer/resources/extensions/cast_streaming_receiver_session_custom_bindings.js
    • content/public/renderer/media_stream_utils.cc
    • content/renderer/media/web_media_element_source_utils.cc
    • content/renderer/render_frame_impl.cc
    • content/shell/renderer/layout_test/test_media_stream_renderer_factory.cc
    • third_party/blink/public/BUILD.gn
    • third_party/blink/public/web/web_media_stream_registry.h
    • third_party/blink/renderer/core/html/media/html_media_element.cc
    • third_party/blink/renderer/core/html/media/html_media_element.h
    • third_party/blink/renderer/modules/exported/BUILD.gn
    • third_party/blink/renderer/modules/exported/web_media_stream_registry.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_play_button_element.cc
    • third_party/blink/renderer/modules/mediacapturefromelement/html_media_element_capture.cc
    • third_party/blink/renderer/modules/mediastream/BUILD.gn
    • third_party/blink/renderer/modules/mediastream/media_stream.cc
    • third_party/blink/renderer/modules/mediastream/media_stream.h
    • third_party/blink/renderer/modules/mediastream/media_stream_registry.cc
    • third_party/blink/renderer/modules/mediastream/media_stream_registry.h
  2. Import wpt@a69af5481cdd976c9696f97d9c6547ac87ba83d0

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:49:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 68550e484d7eecf6bd1d39fca300644ab2c21f5d

    Comments

    Import wpt@a69af5481cdd976c9696f97d9c6547ac87ba83d0
    
    Using wpt-import in Chromium afc97ac06f5d3677c1016d1530c1e196844e2432.
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25973
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    binji@chromium.org:
      external/wpt/wasm
    jsbell@chromium.org:
      external/wpt/resources
    
    NOAUTOREVERT=true
    TBR=lukebjerring
    
    No-Export: true
    Change-Id: I02e2714a05f60a13999e2efa76ad5039324ed566
    Reviewed-on: https://chromium-review.googlesource.com/c/1278537
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599169}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/css/geometry/interfaces-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/dom/interfaces_exclude=Node-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/resources/idlharness.js
    • third_party/WebKit/LayoutTests/external/wpt/shape-detection/idlharness.any-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/wasm/idlharness.any.js
    • third_party/WebKit/LayoutTests/external/wpt/wasm/jsapi/idlharness.any-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/wasm/jsapi/idlharness.any.js
    • third_party/WebKit/LayoutTests/external/wpt/wasm/jsapi/idlharness.any.worker-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/wasm/resources/load_wasm.js
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt
    • third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
  3. Reland "Remove IDC_SHOW_SYNC_SETUP"

    Changed by Mihai Sardarescu - msardaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:48:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 290bc882fa0022afd17118d11949266c86fa631b

    Comments

    Reland "Remove IDC_SHOW_SYNC_SETUP"
    
    This reverts commit 2ec520568c51bcd167a1ed24baa3a6f45023f02b.
    
    Reason for revert: This original CL was reverted as in emergency for M70 as it was in the CL dependency chain for the signin allowed pref CL.
    
    Original change's description:
    > Revert "Remove IDC_SHOW_SYNC_SETUP"
    > 
    > This reverts commit eafee2dc30fa6fdb34e07c664fd858a361cb5424.
    > 
    > Reason for revert: Still needed for http://crbug.com/888776
    > 
    > Original change's description:
    > > Remove IDC_SHOW_SYNC_SETUP
    > > 
    > > IDC_SHOW_SYNC_SETUP and IDC_SHOW_SIGNIN have the same integer value. This
    > > CL removes IDC_SHOW_SYNC_SETUP to avoid confusion. It also cleans up
    > > the code in browser_command_controller that was setting both IDC_SHOW_SYNC_SETUP
    > > and IDC_SHOW_SIGNIN without knowing that they are in fact the same thing.
    > > 
    > > Bug: 870239
    > > Change-Id: I3b1ac005d3230fc581e6163a53ad20a84d124402
    > > Reviewed-on: https://chromium-review.googlesource.com/1236263
    > > Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    > > Reviewed-by: Scott Violet <sky@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#593138}
    > 
    > TBR=sky@chromium.org,msarda@chromium.org
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > Bug: 870239
    > Change-Id: I50cd0042f2630dca0bafe4540c2c32411acf0338
    > Reviewed-on: https://chromium-review.googlesource.com/1245381
    > Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    > Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#594261}
    
    TBR=sky@chromium.org,msarda@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 870239
    Change-Id: Icde4e75988dd24b5bb2add35be055177708c7bfe
    Reviewed-on: https://chromium-review.googlesource.com/c/1278745
    Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599168}

    Changed files

    • chrome/app/chrome_command_ids.h
    • chrome/browser/ui/browser_command_controller.cc
    • chrome/browser/ui/browser_command_controller_unittest.cc
    • chrome/browser/ui/toolbar/app_menu_model.cc
  4. Rename PasswordControllerHelper to PasswordFormHelper

    Changed by Scott Wu - scottwuohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:44:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 830919bab9ae548252386c0e0b2bb97b4a22152e

    Comments

    Rename PasswordControllerHelper to PasswordFormHelper
    
    Bug: 865114
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: If08aa34d7c17e9f5a6dabb818669012275443587
    Reviewed-on: https://chromium-review.googlesource.com/c/1278670
    Commit-Queue: Scott Wu <scottwu@chromium.org>
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599167}

    Changed files

    • components/password_manager/ios/BUILD.gn
    • components/password_manager/ios/password_form_helper.h
    • components/password_manager/ios/password_form_helper.mm
    • components/password_manager/ios/password_form_helper_unittest.mm
    • components/password_manager/ios/password_suggestion_helper.h
    • ios/chrome/browser/passwords/password_controller.h
    • ios/chrome/browser/passwords/password_controller.mm
    • ios/chrome/browser/passwords/password_controller_unittest.mm
    • ios/web_view/internal/passwords/cwv_password_controller.mm
  5. [aw] Add callback to proxy override methods

    Changed by Laís Minchillo - laisminchilloohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:36:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e2dd9b16afe9c2808aaa11566aa54fa854282db2

    Comments

    [aw] Add callback to proxy override methods
    
    Add an optional callback to proxy override methods introduced in change
    https://chromium-review.googlesource.com/c/chromium/src/+/1148384
    
    This adds an optional callback developers can use to know when the
    changes have been made to the network settings, since the methods are
    not synchronous with the UI thread.
    
    Bug: 851995
    Change-Id: I08dc7cc87c57d213b67774d3391562ca07fd0217
    Reviewed-on: https://chromium-review.googlesource.com/c/1258770
    Commit-Queue: Laís Minchillo <laisminchillo@chromium.org>
    Reviewed-by: Eric Roman <eroman@chromium.org>
    Reviewed-by: Richard Coles <torne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599166}

    Changed files

    • android_webview/browser/aw_contents_statics.cc
    • android_webview/browser/net/aw_url_request_context_getter.cc
    • android_webview/browser/net/aw_url_request_context_getter.h
    • android_webview/glue/java/src/com/android/webview/chromium/SharedStatics.java
    • android_webview/java/src/org/chromium/android_webview/AwContentsStatics.java
    • android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/StaticsBoundaryInterface.java
    • android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/util/Features.java
    • android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java
    • net/proxy_resolution/proxy_config_service_android.cc
    • net/proxy_resolution/proxy_config_service_android.h
    • net/proxy_resolution/proxy_config_service_android_unittest.cc
  6. Move password suggestion logic into components.

    Changed by Scott Wu - scottwuohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:34:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b9a4429e3b49acb3be07a11697d3d9680f08e616

    Comments

    Move password suggestion logic into components.
    
    Bug: 865114
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Ibf5ee92330172532dff87f9752d301a134ec49fc
    Reviewed-on: https://chromium-review.googlesource.com/c/1264455
    Reviewed-by: John Wu <jzw@chromium.org>
    Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: Scott Wu <scottwu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599165}

    Changed files

    • components/password_manager/ios/BUILD.gn
    • components/password_manager/ios/password_suggestion_helper.h
    • components/password_manager/ios/password_suggestion_helper.mm
    • ios/chrome/browser/passwords/password_controller.mm
  7. [css-properties-values-api] Multi-value StylePropertyMap.set.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:33:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d84303e41153ea9cb0f6475b6bb9e430666022a2

    Comments

    [css-properties-values-api] Multi-value StylePropertyMap.set.
    
    This adds support for setting multiple values with TypedOM for list-valued
    custom properties. For example, for a property --x with syntax <length>+,
    it will now be possible to do:
    
      element.attributeStyleMap.set('--x', CSS.px(1), CSS.px(2));
    
    This is done by producing a CSSVariableReferenceValue holding tokens
    equivalent to the incoming CSSStyleValues, provided that those values
    match the grammar of the custom property.
    
    R=chrishtr@chromium.org
    
    Bug: 641877
    Change-Id: Ic28497edbbea894a9c09b840dcb6c8fb825d99bb
    Reviewed-on: https://chromium-review.googlesource.com/c/1270963
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599164}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/css/css-properties-values-api/typedom.tentative.html
    • third_party/blink/renderer/core/css/css_syntax_descriptor.h
    • third_party/blink/renderer/core/css/cssom/style_property_map.cc
  8. [Autofill Assistant] Make various improvements to the UI.

    Changed by Jordan Demeulenaere - jdemeulenaereohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 10:29:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5e83ced5f800af6a60da52d8a183776b002c7b54

    Comments

    [Autofill Assistant] Make various improvements to the UI.
    
    Screenshot before: https://screenshot.googleplex.com/5zbTV7W40Rh.png
    Screenshot after: https://screenshot.googleplex.com/59OsupD4J5o.png
    
    Binary-Size: Increase is due to adding new bottom bar background.
    Bug: 806868
    Change-Id: Ie6863f6922eca210f3e823c22318cd6bd323be81
    Reviewed-on: https://chromium-review.googlesource.com/c/1273518
    Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
    Reviewed-by: Ganggui Tang <gogerald@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599163}

    Changed files

    • chrome/android/BUILD.gn
    • chrome/android/java/res_autofill_assistant/drawable-hdpi/autofill_assistant_bottombar_bg.9.png
    • chrome/android/java/res_autofill_assistant/drawable-mdpi/autofill_assistant_bottombar_bg.9.png
    • chrome/android/java/res_autofill_assistant/drawable-xhdpi/autofill_assistant_bottombar_bg.9.png
    • chrome/android/java/res_autofill_assistant/drawable-xxhdpi/autofill_assistant_bottombar_bg.9.png
    • chrome/android/java/res_autofill_assistant/drawable-xxxhdpi/autofill_assistant_bottombar_bg.9.png
    • chrome/android/java/res_autofill_assistant/drawable/autofill_assistant_chip_bg.xml
    • chrome/android/java/res_autofill_assistant/drawable/autofill_assistant_chip_bg_normal.xml
    • chrome/android/java/res_autofill_assistant/drawable/autofill_assistant_chip_bg_pressed.xml
    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_chip.xml
    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_sheet.xml
    • chrome/android/java/res_autofill_assistant/values-v17/styles.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
  9. Roll src/third_party/chromite e2727ef6f5dc..03ec3c699be2 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 10:26:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31904c2ab872bb48841916acaa8dd9fad167589e

    Comments

    Roll src/third_party/chromite e2727ef6f5dc..03ec3c699be2 (2 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/e2727ef6f5dc..03ec3c699be2
    
    
    git log e2727ef6f5dc..03ec3c699be2 --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 vapier@chromium.org cros_portage_upgrade_unittest: convert to mock
    2018-10-12 vapier@chromium.org gsutil: add wrapper script for our pinned version
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@03ec3c699be2
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I9f381f438b01450da63805d85cec801baa22ec4d
    Reviewed-on: https://chromium-review.googlesource.com/c/1278706
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599162}

    Changed files

    • DEPS
  10. [iOS] Fix BVC's |-isTabScrolledToTopForBubblePresenter:|.

    Changed by Kurt Horimoto - kkhorimotoohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:24:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 61701cc0ee389e0dae437516d9b8edad2f874b18

    Comments

    [iOS] Fix BVC's |-isTabScrolledToTopForBubblePresenter:|.
    
    Now that the scroll proxy's contentInset is not guaranteed to be zero,
    we need to check against the contentInset instead of CGPointZero.
    
    Bug: 894617
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I5ba5131c969a4584879be905a92f0736a34d7f46
    Reviewed-on: https://chromium-review.googlesource.com/c/1277674
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599161}

    Changed files

    • ios/chrome/browser/ui/browser_view_controller.mm
  11. Roll src-internal 7781cb9daa22..f37e9866851d (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 10:10:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 042ad90ac5334bd95efe24e495bdf3274930305e

    Comments

    Roll src-internal 7781cb9daa22..f37e9866851d (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7781cb9daa22..f37e9866851d
    
    
    Created with:
      gclient setdep -r src-internal@f37e9866851d
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I1d534c0a85bbd4bb0af445e93060dbd898251de6
    Reviewed-on: https://chromium-review.googlesource.com/c/1278707
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599160}

    Changed files

    • DEPS
  12. Drop Dynamic from CreateIncomingDynamicStream, ShouldCreateIncomingDynamicStream and ShouldCreateOutgoingDynamicStream.

    Changed by Fan Yang - fayangohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:05:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5a3bddfbdef537e0ec1eca74bef7fa64596ae5dd

    Comments

    Drop Dynamic from CreateIncomingDynamicStream, ShouldCreateIncomingDynamicStream and ShouldCreateOutgoingDynamicStream.
    
    Merge internal change: 214983203
    
    R=rch@chromium.org
    
    Change-Id: Iacfc81d8ed6e4a8931aab9fcc52ce8d847bd0e06
    Reviewed-on: https://chromium-review.googlesource.com/c/1276445
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Ryan Hamilton <rch@chromium.org>
    Commit-Queue: Fan Yang <fayang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599159}

    Changed files

    • net/quic/quic_chromium_client_session.cc
    • net/quic/quic_chromium_client_session.h
    • net/quic/quic_chromium_client_session_peer.cc
    • net/quic/quic_chromium_client_session_peer.h
    • net/quic/quic_chromium_client_session_test.cc
    • net/quic/quic_chromium_client_stream_test.cc
    • net/third_party/quic/core/http/quic_server_session_base.cc
    • net/third_party/quic/core/http/quic_server_session_base.h
    • net/third_party/quic/core/http/quic_server_session_base_test.cc
    • net/third_party/quic/core/http/quic_spdy_client_session.cc
    • net/third_party/quic/core/http/quic_spdy_client_session.h
    • net/third_party/quic/core/http/quic_spdy_client_session_test.cc
    • net/third_party/quic/core/http/quic_spdy_session.h
    • net/third_party/quic/core/http/quic_spdy_session_test.cc
    • net/third_party/quic/core/quic_dispatcher_test.cc
    • net/third_party/quic/core/quic_session.cc
    • net/third_party/quic/core/quic_session.h
    • net/third_party/quic/core/quic_session_test.cc
    • net/third_party/quic/quartc/quartc_session.cc
    • net/third_party/quic/quartc/quartc_session.h
    • net/third_party/quic/quartc/quartc_stream_test.cc
    • net/third_party/quic/test_tools/quic_test_server.cc
    • net/third_party/quic/test_tools/quic_test_utils.h
    • net/third_party/quic/tools/quic_simple_server_session.cc
    • net/third_party/quic/tools/quic_simple_server_session.h
    • net/third_party/quic/tools/quic_simple_server_session_test.cc
    • net/third_party/quic/tools/quic_simple_server_stream_test.cc
    • third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.cc
    • third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.h