Home | Search | chromium - Builders
Login

Builder Linux ChromiumOS Full Build 109576 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revisionc7586428da170b5323c25305dd3e213c38c6aa41
Got Revisionc7586428da170b5323c25305dd3e213c38c6aa41

Execution:

Steps and Logfiles:

Show:
  1. ( 335 ms ) setup_build
    running recipe: "chromium"
  2. ( 228 ms ) report builders
     
    running builder/tester 'Linux ChromiumOS Full' on master 'chromium.chromiumos'
  3. ( 42 secs ) bot_update
    [89GB/295GB used (30%)]
  4. ( 1 secs ) swarming.py --version
    0.13
  5. ( 9 secs ) gclient runhooks
  6. ( 375 ms ) read test spec (chromium.chromiumos.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.chromiumos.json
  7. ( 425 ms ) lookup GN args
     
    ffmpeg_branding = "ChromeOS"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    target_os = "chromeos"
    use_goma = true
    use_vaapi = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 37 secs ) generate_build_files
  9. ( 1 mins 30 secs ) compile
  10. ( 15 secs ) archive_build

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm1566-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541786334792905, "id": "8930313568167036352", "project": "chromium", "tags": ["builder:Linux ChromiumOS Full", "buildset:commit/git/c7586428da170b5323c25305dd3e213c38c6aa41", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/c7586428da170b5323c25305dd3e213c38c6aa41", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095743630309546256", "scheduler_job_id:chromium/Linux ChromiumOS Full", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Linux ChromiumOS Full" setup_build
buildnumber 109576 setup_build
mastername "chromium.chromiumos" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "c7586428da170b5323c25305dd3e213c38c6aa41" setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "c7586428da170b5323c25305dd3e213c38c6aa41" bot_update
got_revision_cp "refs/heads/master@{#606894}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "f6ed3c5d7eb73112326476d681f0f79d40fc1e0e" bot_update
got_v8_revision_cp "refs/heads/7.2.287@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update

Blamelist:

  1. Mario Sanchez Prada (marioohnoyoudont@igalia.com)
  2. Mohamed Amir Yosef (mamirohnoyoudont@chromium.org)
  3. Peng Huang (penghuangohnoyoudont@chromium.org)
  4. Bin Wu (wubohnoyoudont@chromium.org)

Timing:

Create Friday, 09-Nov-18 17:58:54 UTC
Start Friday, 09-Nov-18 17:58:58 UTC
End Friday, 09-Nov-18 18:03:09 UTC
Pending 3 secs
Execution 4 mins 11 secs

All Changes:

  1. Migrate clear_browsing_data_collection_view_controller_unittest.mm to IdentityManager

    Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com
    Changed at Friday, 09-Nov-18 17:58:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c7586428da170b5323c25305dd3e213c38c6aa41

    Comments

    Migrate clear_browsing_data_collection_view_controller_unittest.mm to IdentityManager
    
    Use IdentityTestEnvironmentChromeBrowserStateAdaptor instead of manually
    creating the browser's state by providing specific factories, and then
    use the APIs from IdentityTestEnvironment, instead of SigninManagerBase.
    
    Also remove an unnecessary DCHECK in clear_browsing_data_manager_unittest.mm,
    as pointed out post-review when fixing crbug.com/890826 (CL 1318974).
    
    Bug: 903703
    Change-Id: I9d4dd625441005a36c962628fe3fe1f15ab56bb6
    Reviewed-on: https://chromium-review.googlesource.com/c/1328985
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Sergio Collazos <sczs@chromium.org>
    Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#606894}

    Changed files

    • ios/chrome/browser/ui/settings/BUILD.gn
    • ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller_unittest.mm
    • ios/chrome/browser/ui/settings/clear_browsing_data_manager_unittest.mm
  2. [Sync::USS] Rename syncPositioningScheme in ModelTypeWorker

    Changed by Mohamed Amir Yosef - mamirohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:52:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c3cd622f0bc02e3b9744194b5ff8e7410d26a27

    Comments

    [Sync::USS] Rename syncPositioningScheme in ModelTypeWorker
    
    Change-Id: I04dcc33b375f552a8e4e6dbc8b5ae75869ddfa08
    Reviewed-on: https://chromium-review.googlesource.com/c/1329783
    Reviewed-by: Marc Treib <treib@chromium.org>
    Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606893}

    Changed files

    • components/sync/engine_impl/model_type_worker.cc
  3. Fix SkiaRenderer WebGL content not show problem

    Changed by Peng Huang - penghuangohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:47:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f2fef5671fb6850a4cdc203534f90483c35e2564

    Comments

    Fix SkiaRenderer WebGL content not show problem
    
    The WebGL content is a flipped TextureQuad. SkiaRenderer only flips the
    Y coordinate for drawImageRect(with canvas->scale(1, -1)). It will draw
    the image outside of the Window (y < 0). To fix this problem, we use
    canvas->translate(0, quad_rect.bottom()) to move it back into the
    window.
    
    Bug: 901822
    Change-Id: I6b98f82fba896021e1c2878632b26a3bd8029845
    Reviewed-on: https://chromium-review.googlesource.com/c/1324137
    Commit-Queue: Peng Huang <penghuang@chromium.org>
    Reviewed-by: danakj <danakj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606892}

    Changed files

    • components/viz/service/display/gl_renderer.cc
    • components/viz/service/display/renderer_pixeltest.cc
    • components/viz/service/display/skia_renderer.cc
    • components/viz/test/data/intersecting_flipped_blue_green_half_size_rectangles.png
    • components/viz/test/data/intersecting_non_flipped_blue_green_half_size_rectangles.png
  4. Reland "Export the quic batch writer code to Chromium. Note it's not used anywhere in Chrome, we are just exporting the code so people outside of Google can take a look."

    Changed by Bin Wu - wubohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:45:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 346d1aac0d7c49126b8a9943434ee88af85481af

    Comments

    Reland "Export the quic batch writer code to Chromium. Note it's not used anywhere in Chrome, we are just exporting the code so people outside of Google can take a look."
    
    This reverts commit 683a348730bbea7ccea7158eacc04b928b3d5256.
    
    
    In addition to the auto-revert, I also changed two bzero calls to memset calls. I don't know why, but net_unittest under msan fails with a use-of-uninitialized-value: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930601665674446576/+/steps/net_unittests/0/stdout
    
    The msan error goes away after I changed the following bzero(s) into memset(s):
    
    diff --git a/net/third_party/quic/platform/impl/quic_linux_socket_utils.h b/net/third_party/quic/platform/impl/quic_linux_socket_utils.h
    index 94f055f35564..198e266dfdf2 100644
    --- a/net/third_party/quic/platform/impl/quic_linux_socket_utils.h
    +++ b/net/third_party/quic/platform/impl/quic_linux_socket_utils.h
    @@ -102,7 +102,7 @@ class QuicMMsgHdr {
         }
    
         storage_.reset(new char[StorageSize()]);
    -    bzero(&storage_[0], StorageSize());
    +    memset(&storage_[0], 0, StorageSize());
    
         int i = -1;
         for (auto it = first; it != last; ++it) {
    diff --git a/net/third_party/quic/platform/impl/quic_socket_utils.cc b/net/third_party/quic/platform/impl/quic_socket_utils.cc
    index c25f4697dbef..1f252e50f953 100644
    --- a/net/third_party/quic/platform/impl/quic_socket_utils.cc
    +++ b/net/third_party/quic/platform/impl/quic_socket_utils.cc
    @@ -78,7 +78,7 @@ void* QuicMsgHdr::GetNextCmsgDataInternal(int cmsg_level,
    
       if (cmsg_ == nullptr) {
         DCHECK_EQ(nullptr, hdr_.msg_control);
    -    bzero(cbuf_, cbuf_size_);
    +    memset(cbuf_, 0, cbuf_size_);
         hdr_.msg_control = cbuf_;
         cmsg_ = CMSG_FIRSTHDR(&hdr_);
       } else {
    
    
    R=rch@chromium.org
    
    Change-Id: Ibe60068cb87c0f974088b8c1601cc516ee333106
    Reviewed-on: https://chromium-review.googlesource.com/c/1329348
    Commit-Queue: Bin Wu <wub@chromium.org>
    Reviewed-by: Ryan Hamilton <rch@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606891}

    Changed files

    • net/BUILD.gn
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_base.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_base.h
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_buffer.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_buffer.h
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_buffer_test.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_test.h
    • net/third_party/quic/platform/impl/batch_writer/quic_gso_batch_writer.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_gso_batch_writer.h
    • net/third_party/quic/platform/impl/batch_writer/quic_gso_batch_writer_test.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_sendmmsg_batch_writer.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_sendmmsg_batch_writer.h
    • net/third_party/quic/platform/impl/batch_writer/quic_sendmmsg_batch_writer_test.cc
    • net/third_party/quic/platform/impl/quic_linux_socket_utils.cc
    • net/third_party/quic/platform/impl/quic_linux_socket_utils.h
    • net/third_party/quic/platform/impl/quic_linux_socket_utils_test.cc
    • net/third_party/quic/platform/impl/quic_socket_utils.cc
    • net/third_party/quic/platform/impl/quic_socket_utils.h