Home | Search | chromium - Builders
Login

Builder Linux ChromiumOS Full Build 106504 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13
Got Revision5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Tanja Gornak (melandoryohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 14:42:51 UTC
Start Friday, 12-Oct-18 14:42:55 UTC
End Friday, 12-Oct-18 14:47:42 UTC
Pending 4 secs
Execution 4 mins 46 secs

All Changes:

  1. [Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering.

    Changed by Tanja Gornak - melandoryohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 14:39:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13

    Comments

    [Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering.
    
    * The service shouldn't unregister from the topics, when handler
    the Handler is unregistering from topic (as stated in the documentation
    for for UnregisterHandler).
    * Sync shouldn't unregister on browser shutdown
    
    TBR=gab@chromium.org, pavely@chromium.org
    
    Bug: 894752, 801985
    Change-Id: If676d159ba7d7beeebf325bce2e78b5847da3f76
    Reviewed-on: https://chromium-review.googlesource.com/c/1277908
    Reviewed-by: Tatiana Gornak <melandory@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Commit-Queue: Tatiana Gornak <melandory@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599206}

    Changed files

    • chrome/browser/prefs/browser_prefs.cc
    • components/invalidation/impl/BUILD.gn
    • components/invalidation/impl/fcm_fake_invalidator.cc
    • components/invalidation/impl/fcm_invalidation_listener.cc
    • components/invalidation/impl/fcm_invalidation_listener.h
    • components/invalidation/impl/fcm_invalidation_service.cc
    • components/invalidation/impl/fcm_invalidation_service.h
    • components/invalidation/impl/fcm_invalidation_service_unittest.cc
    • components/invalidation/impl/invalidator_registrar.cc
    • components/invalidation/impl/invalidator_registrar.h
    • components/invalidation/impl/invalidator_registrar_with_memory.cc
    • components/invalidation/impl/invalidator_registrar_with_memory.h
    • components/invalidation/public/invalidation_util.h
    • components/sync/driver/glue/sync_backend_host_impl.cc