Builder Linux ChromiumOS Full Build 106465

Results:

Success

Trigger Info:

Project	chromium
Revision	2cc06f195b610cbe4aef0645fd96ddc29b2ab72a
Got Revision	2cc06f195b610cbe4aef0645fd96ddc29b2ab72a

Execution:

• Source: Task 408089dfc0e8e310
• Bot: swarm1566-c4
• Recipe: chromium

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog

   Log stream has no annotation entries
   • - no logs -

Build Properties:

Name	Value	Source

Blamelist:

1. Gauthier Ambard (gambardohnoyoudont@chromium.org)

Timing:

Create	Friday, 12-Oct-18 10:00:25 UTC
Start	Friday, 12-Oct-18 10:00:49 UTC
End	Friday, 12-Oct-18 10:04:47 UTC
Pending	24 secs
Execution	3 mins 57 secs

All Changes:

1. [iOS] Add SwitchToTab button to the omnibox popup

   Changed by	Gauthier Ambard - gambardohnoyoudont@chromium.org
   Changed at	Friday, 12-Oct-18 09:59:56 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	2cc06f195b610cbe4aef0645fd96ddc29b2ab72a

   Comments

   [iOS] Add SwitchToTab button to the omnibox popup
   
   This CL adds the SwitchToTab image and handling to the omnibox popup
   row. It allows to switch easily to an opened tab based on omnibox
   suggestions.
   
   Bug: 893121
   Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
   Change-Id: Ib440267802c1210ea416066c679a2ff4e963fbb6
   Reviewed-on: https://chromium-review.googlesource.com/c/1268344
   Commit-Queue: Gauthier Ambard <gambard@chromium.org>
   Reviewed-by: Eugene But <eugenebut@chromium.org>
   Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#599155}

   Changed files

   • ios/chrome/browser/ui/browser_view_controller.mm
   • ios/chrome/browser/ui/browser_view_controller_unittest.mm
   • ios/chrome/browser/ui/commands/browser_commands.h
   • ios/chrome/browser/ui/omnibox/autocomplete_result_consumer.h
   • ios/chrome/browser/ui/omnibox/popup/BUILD.gn
   • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_coordinator.mm
   • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_mediator.h
   • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_mediator.mm
   • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_row.h
   • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_row.mm
   • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.mm
   • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller_unittest.mm
   • ios/chrome/browser/ui/omnibox/popup/resources/BUILD.gn
   • ios/chrome/browser/ui/omnibox/popup/resources/omnibox_popup_tab_match.imageset/Contents.json
   • ios/chrome/browser/ui/omnibox/popup/resources/omnibox_popup_tab_match.imageset/omnibox_popup_tab_match.png
   • ios/chrome/browser/ui/omnibox/popup/resources/omnibox_popup_tab_match.imageset/omnibox_popup_tab_match@2x.png
   • ios/chrome/browser/ui/omnibox/popup/resources/omnibox_popup_tab_match.imageset/omnibox_popup_tab_match@3x.png