Home | Search | chromium - Builders
Login

Builder Linux Chromium OS ASan LSan Tests (1) Build 28244 Canonical Ubuntu

Results:

Failure mash_browser_tests

Trigger Info:

Projectchromium
Revisionb54d1975f16b7efae2408a1428fbde7207556a29
Got Revisionb54d1975f16b7efae2408a1428fbde7207556a29

Execution:

Steps and Logfiles:

Show:
  1. ( 295 ms ) setup_build
    running recipe: "chromium"
  2. ( 728 ms ) remove .cipd
  3. ( 2 mins 34 secs ) bot_update
    [117GB/295GB used (39%)]
  4. ( 0 ) ensure_goma
  5. ( 849 ms ) swarming.py --version
    0.13
  6. ( 29 secs ) gclient runhooks
  7. ( 829 ms ) read test spec (chromium.memory.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.memory.json
  8. ( 3 secs ) build directory
  9. ( 23 mins 46 secs ) extract build
  10. ( 1 secs ) find isolated tests
  11. ( 0 ) test_pre_run
  12. ( 2 secs ) test_pre_run.[trigger] accessibility_unittests
    Run on OS: 'Ubuntu-14.04'
  13. ( 1 secs ) test_pre_run.[trigger] angle_unittests
    Run on OS: 'Ubuntu-14.04'
  14. ( 1 secs ) test_pre_run.[trigger] app_list_unittests
    Run on OS: 'Ubuntu-14.04'
  15. ( 1 secs ) test_pre_run.[trigger] app_shell_unittests
    Run on OS: 'Ubuntu-14.04'
  16. ( 1 secs ) test_pre_run.[trigger] ash_content_unittests
    Run on OS: 'Ubuntu-14.04'
  17. ( 1 secs ) test_pre_run.[trigger] ash_unittests
    Run on OS: 'Ubuntu-14.04'
  18. ( 1 secs ) test_pre_run.[trigger] aura_unittests
    Run on OS: 'Ubuntu-14.04'
  19. ( 1 secs ) test_pre_run.[trigger] base_unittests
    Run on OS: 'Ubuntu-14.04'
  20. ( 1 secs ) test_pre_run.[trigger] blink_common_unittests
    Run on OS: 'Ubuntu-14.04'
  21. ( 1 secs ) test_pre_run.[trigger] blink_fuzzer_unittests
    Run on OS: 'Ubuntu-14.04'
  22. ( 1 secs ) test_pre_run.[trigger] blink_heap_unittests
    Run on OS: 'Ubuntu-14.04'
  23. ( 1 secs ) test_pre_run.[trigger] blink_platform_unittests
    Run on OS: 'Ubuntu-14.04'
  24. ( 1 secs ) test_pre_run.[trigger] boringssl_crypto_tests
    Run on OS: 'Ubuntu-14.04'
  25. ( 1 secs ) test_pre_run.[trigger] boringssl_ssl_tests
    Run on OS: 'Ubuntu-14.04'
  26. ( 5 secs ) test_pre_run.[trigger] browser_tests
    Run on OS: 'Ubuntu-14.04'
  27. ( 11 secs ) test_pre_run.[trigger] mash_browser_tests
    Run on OS: 'Ubuntu-14.04'
  28. ( 5 secs ) test_pre_run.[trigger] viz_browser_tests
    Run on OS: 'Ubuntu-14.04'
  29. ( 1 secs ) test_pre_run.[trigger] cacheinvalidation_unittests
    Run on OS: 'Ubuntu-14.04'
  30. ( 1 secs ) test_pre_run.[trigger] capture_unittests
    Run on OS: 'Ubuntu-14.04'
  31. ( 1 secs ) test_pre_run.[trigger] cast_unittests
    Run on OS: 'Ubuntu-14.04'
  32. ( 1 secs ) test_pre_run.[trigger] cc_unittests
    Run on OS: 'Ubuntu-14.04'
  33. ( 1 secs ) test_pre_run.[trigger] chrome_app_unittests
    Run on OS: 'Ubuntu-14.04'
  34. ( 1 secs ) test_pre_run.[trigger] chromedriver_unittests
    Run on OS: 'Ubuntu-14.04'
  35. ( 1 secs ) test_pre_run.[trigger] chromeos_components_unittests
    Run on OS: 'Ubuntu-14.04'
  36. ( 1 secs ) test_pre_run.[trigger] chromeos_unittests
    Run on OS: 'Ubuntu-14.04'
  37. ( 1 secs ) test_pre_run.[trigger] chromevox_tests
    Run on OS: 'Ubuntu-14.04'
  38. ( 1 secs ) test_pre_run.[trigger] components_browsertests
    Run on OS: 'Ubuntu-14.04'
  39. ( 1 secs ) test_pre_run.[trigger] components_unittests
    Run on OS: 'Ubuntu-14.04'
  40. ( 1 secs ) test_pre_run.[trigger] compositor_unittests
    Run on OS: 'Ubuntu-14.04'
  41. ( 3 secs ) test_pre_run.[trigger] content_browsertests
    Run on OS: 'Ubuntu-14.04'
  42. ( 3 secs ) test_pre_run.[trigger] viz_content_browsertests
    Run on OS: 'Ubuntu-14.04'
  43. ( 1 secs ) test_pre_run.[trigger] content_unittests
    Run on OS: 'Ubuntu-14.04'
  44. ( 1 secs ) test_pre_run.[trigger] viz_content_unittests
    Run on OS: 'Ubuntu-14.04'
  45. ( 1 secs ) test_pre_run.[trigger] crypto_unittests
    Run on OS: 'Ubuntu-14.04'
  46. ( 1 secs ) test_pre_run.[trigger] dbus_unittests
    Run on OS: 'Ubuntu-14.04'
  47. ( 1 secs ) test_pre_run.[trigger] device_unittests
    Run on OS: 'Ubuntu-14.04'
  48. ( 1 secs ) test_pre_run.[trigger] display_unittests
    Run on OS: 'Ubuntu-14.04'
  49. ( 1 secs ) test_pre_run.[trigger] events_unittests
    Run on OS: 'Ubuntu-14.04'
  50. ( 1 secs ) test_pre_run.[trigger] exo_unittests
    Run on OS: 'Ubuntu-14.04'
  51. ( 1 secs ) test_pre_run.[trigger] extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
  52. ( 1 secs ) test_pre_run.[trigger] extensions_unittests
    Run on OS: 'Ubuntu-14.04'
  53. ( 1 secs ) test_pre_run.[trigger] filesystem_service_unittests
    Run on OS: 'Ubuntu-14.04'
  54. ( 1 secs ) test_pre_run.[trigger] gcm_unit_tests
    Run on OS: 'Ubuntu-14.04'
  55. ( 1 secs ) test_pre_run.[trigger] gfx_unittests
    Run on OS: 'Ubuntu-14.04'
  56. ( 3 secs ) test_pre_run.[trigger] gl_unittests_ozone
    Run on OS: 'Ubuntu-14.04'
  57. ( 1 secs ) test_pre_run.[trigger] google_apis_unittests
    Run on OS: 'Ubuntu-14.04'
  58. ( 1 secs ) test_pre_run.[trigger] gpu_unittests
    Run on OS: 'Ubuntu-14.04'
  59. ( 2 secs ) test_pre_run.[trigger] interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
  60. ( 1 secs ) test_pre_run.[trigger] ipc_tests
    Run on OS: 'Ubuntu-14.04'
  61. ( 1 secs ) test_pre_run.[trigger] jingle_unittests
    Run on OS: 'Ubuntu-14.04'
  62. ( 1 secs ) test_pre_run.[trigger] keyboard_unittests
    Run on OS: 'Ubuntu-14.04'
  63. ( 1 secs ) test_pre_run.[trigger] latency_unittests
    Run on OS: 'Ubuntu-14.04'
  64. ( 1 secs ) test_pre_run.[trigger] leveldb_service_unittests
    Run on OS: 'Ubuntu-14.04'
  65. ( 1 secs ) test_pre_run.[trigger] libjingle_xmpp_unittests
    Run on OS: 'Ubuntu-14.04'
  66. ( 1 secs ) test_pre_run.[trigger] mash_unittests
    Run on OS: 'Ubuntu-14.04'
  67. ( 1 secs ) test_pre_run.[trigger] media_blink_unittests
    Run on OS: 'Ubuntu-14.04'
  68. ( 1 secs ) test_pre_run.[trigger] media_service_unittests
    Run on OS: 'Ubuntu-14.04'
  69. ( 1 secs ) test_pre_run.[trigger] media_unittests
    Run on OS: 'Ubuntu-14.04'
  70. ( 1 secs ) test_pre_run.[trigger] message_center_unittests
    Run on OS: 'Ubuntu-14.04'
  71. ( 1 secs ) test_pre_run.[trigger] midi_unittests
    Run on OS: 'Ubuntu-14.04'
  72. ( 1 secs ) test_pre_run.[trigger] mojo_core_unittests
    Run on OS: 'Ubuntu-14.04'
  73. ( 1 secs ) test_pre_run.[trigger] mojo_unittests
    Run on OS: 'Ubuntu-14.04'
  74. ( 1 secs ) test_pre_run.[trigger] nacl_helper_nonsfi_unittests
    Run on OS: 'Ubuntu-14.04'
  75. ( 1 secs ) test_pre_run.[trigger] nacl_loader_unittests
    Run on OS: 'Ubuntu-14.04'
  76. ( 1 secs ) test_pre_run.[trigger] native_theme_unittests
    Run on OS: 'Ubuntu-14.04'
  77. ( 5 secs ) test_pre_run.[trigger] net_unittests
    Run on OS: 'Ubuntu-14.04'
  78. ( 1 secs ) test_pre_run.[trigger] ozone_gl_unittests
    Run on OS: 'Ubuntu-14.04'
  79. ( 3 secs ) test_pre_run.[trigger] ozone_unittests
    Run on OS: 'Ubuntu-14.04'
  80. ( 1 secs ) test_pre_run.[trigger] ozone_x11_unittests
    Run on OS: 'Ubuntu-14.04'
  81. ( 2 secs ) test_pre_run.[trigger] pdf_unittests
    Run on OS: 'Ubuntu-14.04'
  82. ( 1 secs ) test_pre_run.[trigger] ppapi_unittests
    Run on OS: 'Ubuntu-14.04'
  83. ( 1 secs ) test_pre_run.[trigger] printing_unittests
    Run on OS: 'Ubuntu-14.04'
  84. ( 1 secs ) test_pre_run.[trigger] remoting_unittests
    Run on OS: 'Ubuntu-14.04'
  85. ( 1 secs ) test_pre_run.[trigger] sandbox_linux_unittests
    Run on OS: 'Ubuntu-14.04'
  86. ( 1 secs ) test_pre_run.[trigger] select_to_speak_extension_tests
    Run on OS: 'Ubuntu-14.04'
  87. ( 1 secs ) test_pre_run.[trigger] service_manager_unittests
    Run on OS: 'Ubuntu-14.04'
  88. ( 1 secs ) test_pre_run.[trigger] services_unittests
    Run on OS: 'Ubuntu-14.04'
  89. ( 1 secs ) test_pre_run.[trigger] shell_dialogs_unittests
    Run on OS: 'Ubuntu-14.04'
  90. ( 3 secs ) test_pre_run.[trigger] skia_unittests
    Run on OS: 'Ubuntu-14.04'
  91. ( 1 secs ) test_pre_run.[trigger] snapshot_unittests
    Run on OS: 'Ubuntu-14.04'
  92. ( 1 secs ) test_pre_run.[trigger] sql_unittests
    Run on OS: 'Ubuntu-14.04'
  93. ( 1 secs ) test_pre_run.[trigger] storage_unittests
    Run on OS: 'Ubuntu-14.04'
  94. ( 1 secs ) test_pre_run.[trigger] sync_integration_tests
    Run on OS: 'Ubuntu-14.04'
  95. ( 1 secs ) test_pre_run.[trigger] ui_base_unittests
    Run on OS: 'Ubuntu-14.04'
  96. ( 1 secs ) test_pre_run.[trigger] ui_chromeos_unittests
    Run on OS: 'Ubuntu-14.04'
  97. ( 1 secs ) test_pre_run.[trigger] ui_touch_selection_unittests
    Run on OS: 'Ubuntu-14.04'
  98. ( 1 secs ) test_pre_run.[trigger] unit_tests
    Run on OS: 'Ubuntu-14.04'
  99. ( 1 secs ) test_pre_run.[trigger] url_unittests
    Run on OS: 'Ubuntu-14.04'
  100. ( 2 secs ) test_pre_run.[trigger] views_mus_interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
  101. ( 1 secs ) test_pre_run.[trigger] views_mus_unittests
    Run on OS: 'Ubuntu-14.04'
  102. ( 1 secs ) test_pre_run.[trigger] views_unittests
    Run on OS: 'Ubuntu-14.04'
  103. ( 1 secs ) test_pre_run.[trigger] viz_unittests
    Run on OS: 'Ubuntu-14.04'
  104. ( 1 secs ) test_pre_run.[trigger] wayland_client_perftests
    Run on OS: 'Ubuntu-14.04'
  105. ( 1 secs ) test_pre_run.[trigger] webkit_unit_tests
    Run on OS: 'Ubuntu-14.04'
  106. ( 1 secs ) test_pre_run.[trigger] wm_unittests
    Run on OS: 'Ubuntu-14.04'
  107. ( 1 secs ) test_pre_run.[trigger] wtf_unittests
    Run on OS: 'Ubuntu-14.04'
  108. ( 1 secs ) accessibility_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  109. ( 4 secs ) angle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:29:33.820470
  110. ( 1 secs ) app_list_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 21s
  111. ( 1 secs ) app_shell_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 33s
  112. ( 1 secs ) ash_content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 40s
  113. ( 3 mins 45 secs ) ash_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:06:50.533670
  114. ( 2 secs ) aura_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 26s
  115. ( 2 secs ) base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:47.476190
  116. ( 1 secs ) blink_common_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  117. ( 1 secs ) blink_fuzzer_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 20s
  118. ( 1 secs ) blink_heap_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 39s
  119. ( 2 secs ) blink_platform_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:25.976690
  120. ( 1 secs ) boringssl_crypto_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  121. ( 1 secs ) boringssl_ssl_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  122. ( 37 mins 53 secs ) browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:44:24.053450 (shard #8)
    Min shard duration: 0:33:50.058420 (shard #4)
  123. ( 1 mins 3 secs ) mash_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:31:11.197540 (shard #13)
    Min shard duration: 0:17:29.935660 (shard #19)
    failures:
    BrowserActionApiTest.BrowserActionPopupDownload
     
  124. ( 57 secs ) viz_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:44:48.098710 (shard #3)
    Min shard duration: 0:34:07.191030 (shard #4)
  125. ( 1 secs ) cacheinvalidation_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  126. ( 1 secs ) capture_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 16s
  127. ( 1 secs ) cast_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  128. ( 2 secs ) cc_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:26.310010
  129. ( 1 secs ) chrome_app_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 32s
  130. ( 1 secs ) chromedriver_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  131. ( 2 secs ) chromeos_components_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 26s
  132. ( 2 secs ) chromeos_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 56s
  133. ( 5 secs ) chromevox_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:20:49.936020
  134. ( 1 secs ) components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:14.656010
  135. ( 8 secs ) components_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:33:58.210750
  136. ( 1 secs ) compositor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 16s
  137. ( 5 secs ) content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:09:28.184750 (shard #0)
    Min shard duration: 0:08:34.528910 (shard #1)
  138. ( 4 secs ) viz_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:10:00.814520 (shard #0)
    Min shard duration: 0:08:26.015640 (shard #1)
  139. ( 5 secs ) content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:08:41.340380
  140. ( 3 secs ) viz_content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:08:18.479290
  141. ( 1 secs ) crypto_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  142. ( 1 secs ) dbus_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  143. ( 1 secs ) device_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 26s
  144. ( 1 secs ) display_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  145. ( 1 secs ) events_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  146. ( 1 secs ) exo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:43.996920
  147. ( 1 secs ) extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:41.277490
  148. ( 2 secs ) extensions_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:21.019500
  149. ( 1 secs ) filesystem_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  150. ( 1 secs ) gcm_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  151. ( 4 secs ) gfx_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:31.846260
  152. ( 1 secs ) gl_unittests_ozone
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  153. ( 2 secs ) google_apis_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  154. ( 2 secs ) gpu_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:34.507630
  155. ( 3 secs ) interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:18:17.855930 (shard #2)
    Min shard duration: 0:13:36.005440 (shard #1)
  156. ( 1 secs ) ipc_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  157. ( 1 secs ) jingle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  158. ( 1 secs ) keyboard_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  159. ( 1 secs ) latency_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  160. ( 1 secs ) leveldb_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  161. ( 1 secs ) libjingle_xmpp_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  162. ( 1 secs ) mash_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 26s
  163. ( 2 secs ) media_blink_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:43.432560
  164. ( 1 secs ) media_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  165. ( 5 secs ) media_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:04:09.605620
  166. ( 1 secs ) message_center_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  167. ( 2 secs ) midi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  168. ( 1 secs ) mojo_core_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  169. ( 1 secs ) mojo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 30s
  170. ( 2 secs ) nacl_helper_nonsfi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  171. ( 1 secs ) nacl_loader_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  172. ( 1 secs ) native_theme_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  173. ( 23 secs ) net_unittests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:13:55.663300 (shard #1)
    Min shard duration: 0:11:51.443430 (shard #4)
  174. ( 1 secs ) ozone_gl_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  175. ( 1 secs ) ozone_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  176. ( 1 secs ) ozone_x11_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  177. ( 1 secs ) pdf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  178. ( 1 secs ) ppapi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  179. ( 1 secs ) printing_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  180. ( 2 secs ) remoting_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 52s
  181. ( 1 secs ) sandbox_linux_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  182. ( 2 secs ) select_to_speak_extension_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:42.911810
  183. ( 1 secs ) service_manager_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  184. ( 2 secs ) services_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:11.686060
  185. ( 1 secs ) shell_dialogs_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  186. ( 1 secs ) skia_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  187. ( 1 secs ) snapshot_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 23s
  188. ( 1 secs ) sql_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  189. ( 1 secs ) storage_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 25s
  190. ( 3 secs ) sync_integration_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:11:25.351900
  191. ( 1 secs ) ui_base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  192. ( 1 secs ) ui_chromeos_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  193. ( 1 secs ) ui_touch_selection_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  194. ( 12 secs ) unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:30:24.340050
  195. ( 1 secs ) url_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  196. ( 1 secs ) views_mus_interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 47s
  197. ( 2 secs ) views_mus_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:58.353830
  198. ( 2 secs ) views_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 46s
  199. ( 2 secs ) viz_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:38.558300
  200. ( 1 secs ) wayland_client_perftests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 36s
  201. ( 9 secs ) webkit_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:22:39.938810
  202. ( 1 secs ) wm_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  203. ( 1 secs ) wtf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  204. ( 1 secs ) Tests statistics
     
    Stats
    Total shards: 148
    Total runtime: 1 day, 2:57:52.433358
     
  205. ( 5 ms ) Failure reason

Build Properties:

NameValueSource
$build/goma {"jobs": 500} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2376-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531420297493410, "id": "8941183146093952864", "project": "chromium", "tags": ["builder:Linux Chromium OS ASan LSan Tests (1)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/b54d1975f16b7efae2408a1428fbde7207556a29", "gitiles_ref:refs/heads/master", "parent_buildername:Linux Chromium OS ASan LSan Builder", "parent_buildnumber:40154", "scheduler_invocation_id:9106613208186825344", "scheduler_job_id:chromium/Linux Chromium OS ASan LSan Tests (1)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Linux Chromium OS ASan LSan Tests (1)" setup_build
buildnumber 28244 setup_build
mastername "chromium.memory" setup_build
parent_buildername "Linux Chromium OS ASan LSan Builder" setup_build
parent_got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" setup_build
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" setup_build
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" setup_build
parent_got_revision "b54d1975f16b7efae2408a1428fbde7207556a29" setup_build
parent_got_revision_cp "refs/heads/master@{#574597}" setup_build
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" setup_build
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" setup_build
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" setup_build
parent_got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23950}" setup_build
parent_mastername "chromium.memory" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "b54d1975f16b7efae2408a1428fbde7207556a29" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "b54d1975f16b7efae2408a1428fbde7207556a29" bot_update
got_revision_cp "refs/heads/master@{#574597}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23950}" bot_update
swarm_hashes {"accessibility_unittests": "40a97220499daedc2615c01d55d801e3f3f8919b", "angle_unittests": "74443260ec2595eba63519ab1c7bac30b5225cf6", "app_list_unittests": "ee249a333356649cf5f1851dc447581faf24e6c5", "app_shell_unittests": "2d50467bf5f2216b602de0ee691600d9cfec7c27", "ash_content_unittests": "6b07ff2013dd0157e5160d0647f890838ff88a13", "ash_unittests": "0c4064c5455ad8f4fd5b48295d5343cfa7613fdb", "aura_unittests": "3f52cfc5fc8051effc043e084b9028a25b34b291", "base_unittests": "0a8576ab5be71fa6110fc414fce5a947131e485d", "blink_common_unittests": "8c98ab25104b4c6b28fb8ded2e557bca155810ea", "blink_fuzzer_unittests": "2f0420a6633011d02e5539e9fb777abae273cae1", "blink_heap_unittests": "d4b33fac8179fdda2b5ae53947596cc3c2d84181", "blink_platform_unittests": "3b45e4063d16f94aabdab702776416b29a61b49f", "boringssl_crypto_tests": "74bfc7051d6e19590bfe6969d4394bdd8189ea36", "boringssl_ssl_tests": "121a886ddf16c855753548dff4f2a2bd1d7a1efd", "browser_tests": "31b3ab136651f9fecb4232ef00e70abd55426941", "cacheinvalidation_unittests": "ab841e4e21cb5ae09984f00d7b325323be5d8c41", "capture_unittests": "75111089a0d619a612dda154914a88cd309a1722", "cast_unittests": "80893c41d6100605acdc24138d541ebee7ede8ea", "cc_unittests": "dc7bc37fbf9a6f20cbba8b4879c2ae179a404ce2", "chrome_app_unittests": "fef76f1768ad2d44fa00f700f4d5a8a1810ddf7c", "chromedriver_unittests": "788dd5d3a446ae64341f96859e6b5a3d894c0cb6", "chromeos_components_unittests": "efd6d4ce02167a13a7c923a7b1aec27da821a87f", "chromeos_unittests": "2e2e99acd80f5584edd86c7b58bea80f2e61fce1", "chromevox_tests": "c5b6cff1d240a95092a37c5b578e57f947549463", "components_browsertests": "d27f45198bdf46b994d7fa628302bfabbf98c4bc", "components_unittests": "81e78b6b79fab036b3c7535accd01fce07ab1f63", "compositor_unittests": "9ec289ccebcc0f4c46eb176cb44f478a25f7bf58", "content_browsertests": "7bd7236ac7090ea01f1da442708097cf5d71f324", "content_unittests": "4859e798471b2c62a3e3b8c0dacc46d0113d5bae", "crypto_unittests": "13da7f71ee166c90b39e9dd430a3f38f732d521e", "dbus_unittests": "aebb16c5caaa2c65d07f5ba9886ef2b1b0114531", "device_unittests": "53c8fa4c3f884b2625148f7e82c6b7315eb57388", "display_unittests": "03f70ebb77a9006e409c55e4c061884ca08946c5", "events_unittests": "76086f3e6980d4ae02b24c084ad2537d88a054a7", "exo_unittests": "9300c376d92a4d47bb78aae59c02dc337a97bb70", "extensions_browsertests": "a98246695d3307033e32e51fc32fb9dc8a437af0", "extensions_unittests": "c9c643b13402e396d255495f8cd180629213c1d5", "filesystem_service_unittests": "e442eb2e719941c82ff7c3442cb89ca92f164208", "gcm_unit_tests": "27ec27de77ca23340819e22d590a4198ce3303c7", "gfx_unittests": "97fec401c36abcf8c4d6e60bd31e5754bcbfcec7", "gl_unittests_ozone": "b57a230053e463111dea2f381c7f5fd2837cec39", "google_apis_unittests": "25ee2768ba16cfc91953fe17cb0d9361da10c944", "gpu_unittests": "8727db52588e723c8495a39a76caf5c0089f600d", "interactive_ui_tests": "31ffdab754c008ce6c6e952d6609ed786f2139f6", "ipc_tests": "4f8782c7b62ecfb9d1f77d94e10c610669e617a6", "jingle_unittests": "69e5c42b5cf803e68e03a16ee353850a864f7cdb", "keyboard_unittests": "30a3fd05039ac209af5351a8a3cdd2ef06826ff7", "latency_unittests": "d4d6b42967182b44dad0a4e2ce5f7783d356b959", "leveldb_service_unittests": "41a9835566e0638a26aa3e6ca26a13be3485c45f", "libjingle_xmpp_unittests": "d7b8a21ea7910dd134338ca294b1e57b567ec865", "mash_unittests": "151e57e29f895518712ae2c3f1c82280f0fd8471", "media_blink_unittests": "1065840b3276099359860ca873770bdb152d8301", "media_service_unittests": "fd66f275191c98652df42c513c6f0d84498a2361", "media_unittests": "0e0a212ac82d42a6b5ee097340808ad287eadbf2", "message_center_unittests": "5e3a65411ffd2a3fa0a2c2ac9dc37d39ae0982c1", "midi_unittests": "0ebb0c1023c9a68c5f114bd2acc9c948f25c86be", "mojo_core_unittests": "0c0370668bd0a866639a046763773bef913e5b9b", "mojo_unittests": "93b73e7ff1e555f10e367d735065e8e84f746447", "nacl_helper_nonsfi_unittests": "e29d5c579020d0301179b3756a0f54978877bbdc", "nacl_loader_unittests": "86436bcbb3f5dfccc5b88b6211307124f26987a6", "native_theme_unittests": "303d8b36a3e3af6786a715342d456c6b38641a6a", "net_unittests": "31574c89e10c2a9e1c4c3ab11b35f60998521a62", "ozone_gl_unittests": "7571dea7459e522d0e0e762da6a2b201a3267159", "ozone_unittests": "bce00ba581f6b85ade0b5c2c284a1f1f0b0c61cc", "ozone_x11_unittests": "13ad8c222a9b2a5d54a907e17a77023f2f25fcc8", "pdf_unittests": "6fd4e52c0b3d8713451462db0d4b16a6e971b9c1", "ppapi_unittests": "cc14d95209c4d3fe1f4d651caeb385490a017152", "printing_unittests": "aeed213a52aade48ebe3ddb23b19f19102d1f534", "remoting_unittests": "29c4b90c98454f841ba0b3a652596b8fcc3453af", "sandbox_linux_unittests": "f71f85145645e0a50aa7c2f6d10c562c6fa04db8", "select_to_speak_extension_tests": "210bb61f0727785ef94b7ce40e14e29b07fbd1e3", "service_manager_unittests": "8c0e0ca1540e296422fc9a38254a9e36e791f29b", "services_unittests": "e2129cdc4c6b403cf3e23fcbe8e9fb7b3237c1aa", "shell_dialogs_unittests": "860688909e38c3e33ecc9d0d7476790dcd118953", "skia_unittests": "9b0dec3bb3aff2fb45ff02392afa4977e545edb0", "snapshot_unittests": "48cac549327cdf41bb85c2103a1d8e4b35e869bd", "sql_unittests": "be9eea4e8830363720d28545e3c7f2bdbfd63c72", "storage_unittests": "e369b4365e7cfe185b4e0159d5f33b9712754d87", "sync_integration_tests": "57f7de16eb10ca19da7d4f31a2bcf31b47f981f0", "ui_base_unittests": "2906bf9d7f461ba766d00b957f784324e16b5daa", "ui_chromeos_unittests": "22a0917ef8ce38497fe80b5f77c310de1d392619", "ui_touch_selection_unittests": "ccb12ee3be864fb8affc800d57bffb2b9b99f6d8", "unit_tests": "650a58b1ac843a60f2a1529ed7b3822fce5bb19b", "url_unittests": "ad71d5615dc41cd2147020d04777369fed72ffa3", "views_mus_interactive_ui_tests": "85296f49a24bca22df19a854eb5af30c8ea572d7", "views_mus_unittests": "4238d549487670614ab5ecea227f7aefa8ef17b6", "views_unittests": "86fc8121947aff21d4d5ba6c462c6c3e44fc1fd9", "viz_unittests": "8633b6bb3da7794ff18914a425f8db070f3f3650", "wayland_client_perftests": "fdf5bf8e8054d6606a473635a272507039700770", "webkit_unit_tests": "06d914c39bb301576f7f591a07d276fb10c42175", "wm_unittests": "78f2e48031ece00ac802ed296ae78025b3fffb90", "wtf_unittests": "94028ac56ce3985a29605bfc5d21727bad6ce427"} find isolated tests

Blamelist:

  1. Becky Zhou (huayinzohnoyoudont@chromium.org)
  2. Nico Weber (thakisohnoyoudont@chromium.org)
  3. David Grogan (dgroganohnoyoudont@chromium.org)
  4. Nick Burris (nburrisohnoyoudont@google.com)
  5. Rayan Kanso (rayankansohnoyoudont@chromium.org)
  6. Mike Reed (reedohnoyoudont@google.com)
  7. Peter E Conn (peconnohnoyoudont@chromium.org)
  8. Peter Kasting (pkastingohnoyoudont@chromium.org)
  9. Takuto Ikuta (tikutaohnoyoudont@chromium.org)
  10. Jay Civelli (jcivelliohnoyoudont@google.com)
  11. Stefan Zager (szagerohnoyoudont@chromium.org)
  12. Bruce Dawson (brucedawsonohnoyoudont@chromium.org)
  13. Peter Kasting (pkastingohnoyoudont@chromium.org)
  14. Fabio Tirelo (ftireloohnoyoudont@chromium.org)
  15. Devlin Cronin (rdevlin.croninohnoyoudont@chromium.org)
  16. Chris Lu (thegreenfrogohnoyoudont@chromium.org)
  17. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  18. Peter Wen (wnwenohnoyoudont@chromium.org)
  19. Xida Chen (xidachenohnoyoudont@chromium.org)
  20. Daniel Bratell (bratellohnoyoudont@opera.com)
  21. Danyao Wang (danyaoohnoyoudont@chromium.org)
  22. Stephen Lanham (slanohnoyoudont@google.com)
  23. Sujie Zhu (sujiezhuohnoyoudont@google.com)
  24. Jeremy Roman (jbromanohnoyoudont@chromium.org)
  25. Majid Valipour (majidvpohnoyoudont@chromium.org)
  26. kylechar (kylecharohnoyoudont@chromium.org)
  27. stkhapugin@chromium.org (stkhapuginohnoyoudont@chromium.org)
  28. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  29. vitaliii (vitaliiiohnoyoudont@chromium.org)
  30. Ken Rockot (rockotohnoyoudont@chromium.org)
  31. John Abd-El-Malek (jamohnoyoudont@chromium.org)
  32. Rayan Kanso (rayankansohnoyoudont@chromium.org)
  33. Javier Ernesto Flores Robles (javierroblesohnoyoudont@chromium.org)
  34. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  35. Ryan Daum (rdaumohnoyoudont@chromium.org)
  36. Elly Fong-Jones (ellyjonesohnoyoudont@chromium.org)
  37. Jochen Eisinger (jochenohnoyoudont@chromium.org)
  38. Amos Lim (eui-sang.limohnoyoudont@samsung.com)

Timing:

Create Thursday, 12-Jul-18 18:31:37 UTC
Start Thursday, 12-Jul-18 18:32:31 UTC
End Thursday, 12-Jul-18 19:58:00 UTC
Pending 54 secs
Execution 1 hrs 25 mins

All Changes:

  1. [Feed] Scroll and focus handling for the FeedNewTabPage

    Changed by Becky Zhou - huayinzohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:36:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b54d1975f16b7efae2408a1428fbde7207556a29

    Comments

    [Feed] Scroll and focus handling for the FeedNewTabPage
    
    + Implement NewTabPageLayout.ScrollDelegate to the FeedNewTabPage
    + Refactor snap scroll logic to a new class to make it reusable
    + Add top padding for the FeedNewTabPage to display correctly on tablet
    + Fix a small bug that search box is not enabled after auto snap scroll
    
    Bug: 860028, 860032, 862470
    Change-Id: I5bda9696a4515281378c1effe47b6ad47fdd4c49
    Reviewed-on: https://chromium-review.googlesource.com/1133594
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Becky Zhou <huayinz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574597}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/SnapScrollHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java
  2. Remove most android-specific hard_timeout and shard overrides.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:35:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1a64d6771d8b24f079f24e41ebaf14f672747084

    Comments

    Remove most android-specific hard_timeout and shard overrides.
    
    These were added during android swarming bring-up.  We shouldn't use
    per-bot exceptions for this.
    
    Also remove a random sharding setting for base_unittests on ToTMac
    that doesn't look necessary.
    
    Bug: 843511
    Change-Id: Ia20771786f1b4106cd86d24d446e0a66f319dbff
    Reviewed-on: https://chromium-review.googlesource.com/1134531
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574596}

    Changed files

    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.swarm.json
    • testing/buildbot/test_suite_exceptions.pyl
  3. [css-tables] Make table's max-content honor captions' min-content

    Changed by David Grogan - dgroganohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:34:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dff5931455e0302289a3cc9027fd3f98cfe22fca

    Comments

    [css-tables] Make table's max-content honor captions' min-content
    
    Table's min-content already honored it.
    
    We'd apparently never been bitten before by tables occasionally having
    min-content > max-content. A new DCHECK in LayoutNG exposed it.
    
    Bug: 857185
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I49009a4988fbf38c1bf745a4f028e4e8b050804b
    Reviewed-on: https://chromium-review.googlesource.com/1121251
    Commit-Queue: David Grogan <dgrogan@chromium.org>
    Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574595}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/fast/table/caption-min-greater-than-max-crash.html
    • third_party/WebKit/LayoutTests/fast/table/spans-min-greater-than-max-crash.html
    • third_party/blink/renderer/core/layout/layout_table.cc
    • third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
  4. Settings WebUI: Fix extensions url on cleanup result page

    Changed by Nick Burris - nburrisohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:33:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7cde465a809facc9ecb61350aaa5c504a36d9174

    Comments

    Settings WebUI: Fix extensions url on cleanup result page
    
    The cleaner success string now has HTML in it, and the JS i18n
    function strips it off. i18nAdvanced allows us to let the <a> through to
    the string, but the way the cleanup result page works is it simply sets
    the card text variable ("title") to the result message string. This
    would result in the raw string (with HTML) getting displayed, so the
    title variable needs to also be set to be the inner-h-t-m-l.
    
    Bug: 853339
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I8ea98e9868f83fc14a674841072cc2915c7b4a48
    Reviewed-on: https://chromium-review.googlesource.com/1134191
    Commit-Queue: Nick Burris <nburris@google.com>
    Reviewed-by: proberge <proberge@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574594}

    Changed files

    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
    • chrome/test/data/webui/settings/chrome_cleanup_page_test.js
  5. [Background Fetch] Add DB corruption handler to data manager observer.

    Changed by Rayan Kanso - rayankansohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:31:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 96544636e959581575b9c4f1ac2ecd1c5f40296d

    Comments

    [Background Fetch] Add DB corruption handler to data manager observer.
    
    Bug: 850512
    Change-Id: Iddd2773f63fd7aa0368e980a347c1bef4312f23d
    Reviewed-on: https://chromium-review.googlesource.com/1128839
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574593}

    Changed files

    • content/browser/background_fetch/background_fetch_context.cc
    • content/browser/background_fetch/background_fetch_context.h
    • content/browser/background_fetch/background_fetch_data_manager.cc
    • content/browser/background_fetch/background_fetch_data_manager.h
    • content/browser/background_fetch/background_fetch_data_manager_observer.h
    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.cc
    • content/browser/background_fetch/storage/database_task.cc
    • content/browser/background_fetch/storage/database_task.h
    • content/browser/background_fetch/storage/delete_registration_task.cc
    • content/browser/background_fetch/storage/get_settled_fetches_task.cc
    • content/browser/background_fetch/storage/mark_registration_for_deletion_task.cc
    • content/browser/background_fetch/storage/start_next_pending_request_task.cc
  6. suppress until skia roll

    Changed by Mike Reed - reedohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:30:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dcf8a49d5e3d2440dfc3f8e3126fa266fd25a33b

    Comments

    suppress until skia roll
    
    Bug: 863042
    Change-Id: I97a48047d0b6546055c255538fc31ddcc0a07078
    Reviewed-on: https://chromium-review.googlesource.com/1135288
    Commit-Queue: Mike Reed <reed@chromium.org>
    Commit-Queue: Florin Malita <fmalita@chromium.org>
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574592}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  7. 🤝 Add flag to force showing TWA disclosure.

    Changed by Peter E Conn - peconnohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:28:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 967fc76c423a5e86fc2e04b4655aa463d2ae7c12

    Comments

    🤝 Add flag to force showing TWA disclosure.
    
    Add a flag to force showing the disclosure for developer convenience.
    Also trigger even when there isn't an active tab yet.
    
    Bug: 813100
    Change-Id: I3ccd820d58f82040723a8f8a72097262ba374b82
    Reviewed-on: https://chromium-review.googlesource.com/1116922
    Reviewed-by: Benoit L <lizeb@chromium.org>
    Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
    Commit-Queue: Peter Conn <peconn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574591}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
    • chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
  8. Once TabStrip doesn't need it, there's no reason to expose GetTopOffset().

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:28:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b2b9af8ace2bbc3384147241601d4293f0c2259

    Comments

    Once TabStrip doesn't need it, there's no reason to expose GetTopOffset().
    
    Bug: none
    Change-Id: Ia78dd54f4364e7010ddf3ce16b01e5f5f3c764e4
    Reviewed-on: https://chromium-review.googlesource.com/1134499
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Allen Bauer <kylixrd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574590}

    Changed files

    • chrome/browser/ui/views/tabs/new_tab_button.cc
    • chrome/browser/ui/views/tabs/new_tab_button.h
  9. Keep timestamp in aar.py when file is not changed

    Changed by Takuto Ikuta - tikutaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:22:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d186e03f89aa3fa40dc7266cbc33a0310ac3dd8

    Comments

    Keep timestamp in aar.py when file is not changed
    
    This is a reland of
    https://chromium-review.googlesource.com/c/chromium/src/+/1127565
    I didn't understand filecmp.dircmp.
    
    Changed to use md5_check.CallAndRecordIfStale instead.
    Also let ExtractAll create directory even when it is empty.
    
    Bug: 810298, 860251
    Change-Id: I0d1e2e385ff1a12981473ef422099f638ca174cf
    Reviewed-on: https://chromium-review.googlesource.com/1132818
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574589}

    Changed files

    • build/android/gyp/aar.py
    • build/android/gyp/util/build_utils.py
  10. Simplify FakeGaiaCookieManagerService

    Changed by Jay Civelli - jcivelliohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:18:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8

    Comments

    Simplify FakeGaiaCookieManagerService
    
    Simplifying the FakeGaiaCookieManagerService API by not requiring to
    call Init() with a FakeURLFetcherFactory. The FakeURLFetcherFactory is
    instead a member of the FakeGaiaCookieManagerService.
    
    This API simplification is in preparation for switching GaiaAuthFetcher
    to use the SimpleURLLoader (network service).
    
    Bug: 840396
    Change-Id: I917e4236a53bf251c3a8e82c868d5e4d99655aca
    Reviewed-on: https://chromium-review.googlesource.com/1114226
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Commit-Queue: Jay Civelli <jcivelli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574588}

    Changed files

    • chrome/browser/extensions/api/identity/identity_apitest.cc
    • chrome/browser/search/one_google_bar/one_google_bar_service_unittest.cc
    • chrome/browser/signin/dice_response_handler_unittest.cc
    • chrome/browser/signin/fake_gaia_cookie_manager_service_builder.cc
    • chrome/browser/signin/fake_gaia_cookie_manager_service_builder.h
    • chrome/browser/signin/signin_ui_util_unittest.cc
    • chrome/browser/supervised_user/child_accounts/child_account_service_unittest.cc
    • chrome/browser/ui/views/frame/test_with_browser_view.cc
    • chrome/browser/ui/views/frame/test_with_browser_view.h
    • components/search_provider_logos/logo_service_impl_unittest.cc
    • components/signin/core/browser/account_investigator_unittest.cc
    • components/signin/core/browser/account_reconcilor_unittest.cc
    • components/signin/core/browser/fake_gaia_cookie_manager_service.cc
    • components/signin/core/browser/fake_gaia_cookie_manager_service.h
    • components/signin/core/browser/signin_manager_unittest.cc
  11. Get rid of GraphicsLayer::scrollable_area_

    Changed by Stefan Zager - szagerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:18:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 442f13b7e97747ab09612a101159b1eb26072382

    Comments

    Get rid of GraphicsLayer::scrollable_area_
    
    The only place where it was actually used was in
    GraphicsLayer::SetScrollbarsHiddenIfOverlay, so just forward that
    call to the GraphicsLayerClient.
    
    BUG=823365
    R=pdr@chromium.org,skobes@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I3cdd24ceb1ab51563dbc3b6d9ce50ce9edc77bf8
    Reviewed-on: https://chromium-review.googlesource.com/1132536
    Commit-Queue: Stefan Zager <szager@chromium.org>
    Reviewed-by: Steve Kobes <skobes@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574587}

    Changed files

    • third_party/blink/renderer/core/frame/visual_viewport.cc
    • third_party/blink/renderer/core/frame/visual_viewport.h
    • third_party/blink/renderer/core/layout/scrollbars_test.cc
    • third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
    • third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.h
    • third_party/blink/renderer/core/paint/compositing/graphics_layer_tree_as_text.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer.h
    • third_party/blink/renderer/platform/graphics/graphics_layer_client.h
  12. Add "latency" to list of ETW-traceable events

    Changed by Bruce Dawson - brucedawsonohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:15:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a5d9a9d75a9a8f7f6fb9d749c9b797eb2550d34e

    Comments

    Add "latency" to list of ETW-traceable events
    
    The "latency" category looks like a perfect event category for ETW
    tracing. In particular, TabSwitching::Latency indicates when Chrome
    thinks that tab switching has started and stopped which allows it to be
    profiled in detail. This has revealed where CPU time is going, and how
    long the delay is from when the keyboard event is generated to when
    Chrome starts officially processing it. This was helpful in
    investigating tab switching latency in bug 858944.
    
    This will require an update to UIforETW to fully enable, which I have
    done locally for testing purposes.
    
    Bug: 858944
    Change-Id: I4797b804ea6d35458aa3b4e876a78172a29d5131
    Reviewed-on: https://chromium-review.googlesource.com/1134516
    Reviewed-by: Primiano Tucci <primiano@chromium.org>
    Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574586}

    Changed files

    • base/trace_event/trace_event_etw_export_win.cc
  13. Remove NewTabButton::GetVisibleBounds().

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:13:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f448a241361b03dd2b6fd21ab052774e1074fdf1

    Comments

    Remove NewTabButton::GetVisibleBounds().
    
    This was a computed by constructing the border path and computing the bounding
    box.  However, it was only used for the ink drop, and ink drops are only used in
    newer material mode, where the border path is a square.
    
    Instead, we can use GetContentsBounds(), as long as those are actually
    positioned correctly.  The new tab button has empty space at the top, which is
    included (by the tabstrip) in its size and accounted for when doing painting and
    hittesting.  By adding an empty top border of this thickness, a lot of this code
    can be simplified.  (Further simplifications are coming in a subsequent CL.)
    
    Bug: none
    Change-Id: I431c6100d45b7f92a0ab1c9ed9f81f8fab436ebe
    Reviewed-on: https://chromium-review.googlesource.com/1134399
    Reviewed-by: Allen Bauer <kylixrd@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574585}

    Changed files

    • chrome/browser/ui/views/tabs/new_tab_button.cc
    • chrome/browser/ui/views/tabs/new_tab_button.h
    • chrome/browser/ui/views/tabs/tab_strip.cc
  14. [AF] Use views::Separator in the Autofill dropdown

    Changed by Fabio Tirelo - ftireloohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:13:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ff6fb086724fb3cd20409d3e72065bbd4a84abd

    Comments

    [AF] Use views::Separator in the Autofill dropdown
    
    This is a follow-up of crrev.com/c/1131680 and replace a custom view
    to simulate a separator with a views::Separator view.
    
    Change-Id: I0dc1db9c31039ce0959fa4aa4d37e4e99745a2d1
    Reviewed-on: https://chromium-review.googlesource.com/1133328
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574584}

    Changed files

    • chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
  15. [Extensions Cleanup] Clean up ScriptingPermissionsModifier unittests

    Changed by Devlin Cronin - rdevlin.croninohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:11:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b35e9edf0aed36764ee35db8ed9e66466bb18249

    Comments

    [Extensions Cleanup] Clean up ScriptingPermissionsModifier unittests
    
    Remove a redundant URLPatternSet comparison method from
    ScriptingPermissionsModifier unittests, instead leveraging the
    string comparison and gmock utilities. These are slightly less code
    and offer better failure messages.
    
    Bug: None
    
    Change-Id: Ic8b99f0c9294658d6bdd16738f179a2e352eb408
    Reviewed-on: https://chromium-review.googlesource.com/1134496
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574583}

    Changed files

    • chrome/browser/extensions/scripting_permissions_modifier_unittest.cc
  16. [ios] Set favicon fallback style for UI Refresh for ReadingList

    Changed by Chris Lu - thegreenfrogohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:05:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8eeff01fbfa506b55fc9f1c0126c618a788015a4

    Comments

    [ios] Set favicon fallback style for UI Refresh for ReadingList
    
    - Sets the fallback monogram and background colors to a constant color.
    
    Collections flag off screenshot: https://drive.google.com/file/d/10fYA9oHwx_o3cGWXBSR5P4qXKIPDTcfm/view?usp=sharing
    Collections flag on screenshot: https://drive.google.com/file/d/1WtAYb-fPE6QdR4rIpcWxuZtLjGr7iPNQ/view?usp=sharing
    
    Bug: 851390
    
    Change-Id: I7d67a4129263b2deed52eb7603b3f84aa8b8a201
    Reviewed-on: https://chromium-review.googlesource.com/1125271
    Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574582}

    Changed files

    • ios/chrome/browser/ui/reading_list/reading_list_mediator.mm
  17. Enable StaleWhileRevalidate in experimental features.

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:04:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fc2f58c6417a00888317b79f40fd904b1f6628b

    Comments

    Enable StaleWhileRevalidate in experimental features.
    
    To gather some stability enable it for experimental features before
    we do the origin trial.
    
    BUG=348877
    
    Change-Id: I7598f35ac87b719305c6efa98c37de2eec8031a4
    Reviewed-on: https://chromium-review.googlesource.com/1134883
    Reviewed-by: Robert Flack <flackr@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574581}

    Changed files

    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  18. Android: Default to full instead of fast

    Changed by Peter Wen - wnwenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:04:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5c98d04f201c356e8c4e811f3a43afa5c264750c

    Comments

    Android: Default to full instead of fast
    
    Switch from --full being optional to --fast being optional. Quite a few
    users of generate_gradle.py have found it unintuitive to have red
    underlines by default.
    
    Bug: 620034
    Change-Id: I24a19e16ed21baa19bde97bb2f3077430a73d148
    Reviewed-on: https://chromium-review.googlesource.com/1134882
    Commit-Queue: Peter Wen <wnwen@chromium.org>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574580}

    Changed files

    • build/android/gradle/generate_gradle.py
  19. [Code health] Disable TouchActionBrowserTests on Debug and *San bots

    Changed by Xida Chen - xidachenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:02:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da109c8fd1b66a54c514b3012c29ebb232c113e9

    Comments

    [Code health] Disable TouchActionBrowserTests on Debug and *San bots
    
    These tests are flaky on Debug builds and *San bots. These tests sends
    synthetic gesture event and measure scroll offset. It should be fine
    without coverages on Debug and *San builds.
    
    TBR=sahel@chromium.org, tdresser@chromium.org
    
    Bug: 855979, 833015
    Change-Id: I009d3557454e0aab960d35fc5256ed487c2e47fe
    Reviewed-on: https://chromium-review.googlesource.com/1135195
    Reviewed-by: Xida Chen <xidachen@chromium.org>
    Commit-Queue: Xida Chen <xidachen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574579}

    Changed files

    • content/browser/renderer_host/input/touch_action_browsertest.cc
  20. [jumbo] Deduplicate a time constant in autofill code

    Changed by Daniel Bratell - bratellohnoyoudont@opera.com
    Changed at Thursday, 12-Jul-18 16:01:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5a742e15951f4e95d609b6628fc486a88b4fe0df

    Comments

    [jumbo] Deduplicate a time constant in autofill code
    
    Two different bubbles needed the same time constant and when
    they got copies of the constant that broke certain jumbo
    builds. This merges the constants to a single constant.
    
    It also changes type to base::TimeDelta which is the actual
    type needed and since the addition of constexpr can be used
    in global constants.
    
    Bug: 852904,862397
    Change-Id: I52a63d3301efb1c7aec55541c15427c5d96ba524
    Reviewed-on: https://chromium-review.googlesource.com/1134998
    Commit-Queue: Daniel Bratell <bratell@opera.com>
    Commit-Queue: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574578}

    Changed files

    • chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.cc
    • chrome/browser/ui/autofill/popup_constants.h
    • chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
    • chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
  21. Revert "[Nav Experiment] Add a wait after restore session."

    Changed by Danyao Wang - danyaoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:01:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e33b9da8d371a25857c422d277115441c629ce5

    Comments

    Revert "[Nav Experiment] Add a wait after restore session."
    
    This reverts commit bcae87b0c7618e2fc61f78a073cf5589fe9679bd.
    
    Reason for revert: This didn't actually fix the problem and
    I didn't catch it due to a mistake in testing. The real
    problem is that the restore_session request started in 
    WKBasedNavigationManager::Restore() was not run, because
    |_containerView| is not yet initiated in the new CWVWebView.
    
    Original change's description:
    > [Nav Experiment] Add a wait after restore session.
    > 
    > This fixes WebViewRestorableStateTest when WKBasedNavigationManger is
    > enabled. A better approach would be to turn this test into a
    > programmatic test so both navigation managers implementations are
    > tested, but web::features symbols are not exposed in ios/web_view.
    > 
    > Bug: 862714
    > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    > Change-Id: I19916a973b566fac32c8995bd199784f0c846a1e
    > Reviewed-on: https://chromium-review.googlesource.com/1134046
    > Reviewed-by: Eugene But <eugenebut@chromium.org>
    > Commit-Queue: Danyao Wang <danyao@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574367}
    
    TBR=eugenebut@chromium.org,danyao@chromium.org
    
    Change-Id: Ia9d2d127e18264fbf69786c58b71706e0b34ead5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 862714
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Reviewed-on: https://chromium-review.googlesource.com/1135346
    Reviewed-by: Danyao Wang <danyao@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574577}

    Changed files

    • ios/web_view/test/web_view_restorable_state_inttest.mm
  22. [Chromecast] Use MobileScoller on Cast Android builds.

    Changed by Stephen Lanham - slanohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:00:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2bef77d4afc3b73eb7fc96dff1908164994b4a82

    Comments

    [Chromecast] Use MobileScoller on Cast Android builds.
    
    This class was renamed from Scroller here: crrev.com/c/1087641. Update the
    conditionals so that Scroller is only used on non-Android Cast builds,
    and MobileScroller is used on Android Cast builds.
    
    Bug: internal b/111287588
    Test: Compiles
    
    Change-Id: I19dc01e1339016e3db2ab3b7d81a95efc5c6a0f3
    Reviewed-on: https://chromium-review.googlesource.com/1133761
    Reviewed-by: Timothy Dresser <tdresser@chromium.org>
    Commit-Queue: Stephen Lanham <slan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574576}

    Changed files

    • ui/events/gestures/blink/web_gesture_curve_impl.cc
  23. Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type

    Changed by Sujie Zhu - sujiezhuohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 15:56:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cdb64db76a187df14e07aa31daccedb1813ffb8e

    Comments

    Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type
    
    For the workflow of the local card migration, we need to know the type of the imported credit card to decide whether to prompt the migration to the user. The type of the imported credit card from the submitted form can be LOCAL_CARD, SERVER_CARD, NEW_CARD and NO_CARD. Currently we have the offering_upload_of_local_credit_card_ variable to denote the imported card is a local card. For the code simpilicity and reuse, we change the bool variable to an enum to represent the type of the imported credit card.
    
    Since the ImportCreditCard is not always called in the ImportFormData, so we reset the imported_credit_card_record_type in ImportFormData so that every time we try to import from form, the imported_credit_card_record_type is reset. Also, to test the reset, we use ImportFormData instead of directly using ImportCreditCard in the unittest.
    
    In this CL, we add unittest for imported_credit_card_record_type to check correctness of the imported card type.
    
    The following CL will be solve the triggering logic with the imported_credit_card_record_type.
    
    Bug: 852904
    Change-Id: I01191cb8a9d0a3bf954874e6c8beb62d3b02c1ea
    Reviewed-on: https://chromium-review.googlesource.com/1134388
    Reviewed-by: Jared Saul <jsaul@google.com>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Sujie Zhu <sujiezhu@google.com>
    Cr-Commit-Position: refs/heads/master@{#574575}

    Changed files

    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc
  24. fuzzer: Don't assume that the out dir is inside the src git repository.

    Changed by Jeremy Roman - jbromanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:46:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3fb53cf0d187b9537160ad967975f17641d59c1f

    Comments

    fuzzer: Don't assume that the out dir is inside the src git repository.
    
    This might not be the case in general. Not only could a output directory
    exist elsewhere altogether (though this only fixes one issue that breaks
    when you do that), but it could be a symlink or another filesystem; in
    such cases git does not consider it part of the repository.
    
    This can be addressed by explicitly giving the path to src.git when issuing
    git commands.
    
    Change-Id: Ibf62466548e15d6ef57ed1e959d507ff70076352
    Reviewed-on: https://chromium-review.googlesource.com/1131842
    Commit-Queue: Max Moroz <mmoroz@chromium.org>
    Reviewed-by: Max Moroz <mmoroz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574574}

    Changed files

    • testing/libfuzzer/fuzzer_test.gni
    • testing/libfuzzer/gen_fuzzer_owners.py
  25. [testing] Move context menu ever timestamp test to a separate test

    Changed by Majid Valipour - majidvpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:46:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8696fc59786065ffc8a2e06f2db8f9e9ebc772a1

    Comments

    [testing] Move context menu ever timestamp test to a separate test
    
    ContextMenu interaction with other events is a suspected cause of
    flakiness of the original test. This CL is separating it from the
    rest as a potential fix.
    
    Bug: 846750
    Change-Id: I3d452388be65984ca82238d55a938d7a273fcf3f
    Reviewed-on: https://chromium-review.googlesource.com/1134180
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Commit-Queue: Majid Valipour <majidvp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574573}

    Changed files

    • third_party/WebKit/LayoutTests/fast/events/hr-timestamp/context-menu-event.html
    • third_party/WebKit/LayoutTests/fast/events/hr-timestamp/input-events.html
  26. Update viz_content_browsertests filter.

    Changed by kylechar - kylecharohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:43:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9e0d4f50a43ad0ec12342ccbd16bf63f571651a7

    Comments

    Update viz_content_browsertests filter.
    
    Undo revert in https://crrev.com/c/1134144 which didn't end up being
    needed. Revert was in response to FindIt and failures in
    SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest but that problem
    had already been addressed.
    
    TBR: jonross@chromium.org
    Bug: 848825, 848348
    Change-Id: Ie00ce45db8b380847dddf4fb099a120ce7ada987
    Reviewed-on: https://chromium-review.googlesource.com/1135146
    Reviewed-by: kylechar <kylechar@chromium.org>
    Reviewed-by: Jonathan Ross <jonross@chromium.org>
    Commit-Queue: kylechar <kylechar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574572}

    Changed files

    • testing/buildbot/filters/viz.android.content_browsertests.filter
    • testing/buildbot/filters/viz.content_browsertests.filter
  27. [iOS] New location bar icons and fonts.

    Changed by stkhapugin@chromium.org - stkhapuginohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:42:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 57bfd6b0cba9de19f7dd75558447eba072bf84da

    Comments

    [iOS] New location bar icons and fonts.
    
    Updates the logic to switch between larger and smaller fonts, replaces
    security state and voice/share icons.
    
    Bug: 856542
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Iecc5da700dd9b3004e8480abaa842dc6e143bdca
    Reviewed-on: https://chromium-review.googlesource.com/1135128
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574571}

    Changed files

    • ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm
    • ios/chrome/browser/ui/location_bar/resources/location_bar_dangerous.imageset/location_bar_dangerous.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_dangerous.imageset/location_bar_dangerous@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_dangerous.imageset/location_bar_dangerous@3x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_insecure.imageset/location_bar_insecure.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_insecure.imageset/location_bar_insecure@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_insecure.imageset/location_bar_insecure@3x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_offline.imageset/location_bar_offline.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_offline.imageset/location_bar_offline@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_offline.imageset/location_bar_offline@3x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure@3x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_share.imageset/location_bar_share.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_share.imageset/location_bar_share@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_share.imageset/location_bar_share@3x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_voice.imageset/location_bar_voice.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_voice.imageset/location_bar_voice@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_voice.imageset/location_bar_voice@3x.png
    • ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
    • ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.h
    • ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm
  28. Import wpt@b7f4f1d1ea5708bfb7578090f19c75dcf21cbef2

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:42:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b3b164c24e967409cad5205e6a1ed651615566aa

    Comments

    Import wpt@b7f4f1d1ea5708bfb7578090f19c75dcf21cbef2
    
    Using wpt-import in Chromium d18929b41e24487865c4ed9da46129e6b037beeb.
    With Chromium commits locally applied on WPT:
    a9045946af "Add a fail-fast for longtask layouttests"
    
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21188
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    domenic@chromium.org, ricea@chromium.org:
      external/wpt/streams
    jsbell@chromium.org:
      external/wpt/encoding
    kojii@chromium.org:
      external/wpt/css/css-writing-modes
    mlamouri@chromium.org:
      external/wpt/screen-orientation
    
    TBR=foolip
    
    No-Export: true
    Change-Id: Ib04131d32533fd3a6687cc2999f6a0b409f08165
    Reviewed-on: https://chromium-review.googlesource.com/1134875
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574570}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/appmanifest/idlharness.window.js
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-004.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-htb-001.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-007.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-008.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-010.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-014.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-015.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-016.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-020.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-022.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-023.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-005.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-006.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-009.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-011.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-012.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-013.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-019.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-021.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-024.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-025.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/different-block-flow-dir-001.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/different-block-flow-dir-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/first-page-vlr-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/first-page-vrl-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/flexbox_align-items-stretch-writing-modes.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/form-controls-vlr-004.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/form-controls-vlr-005.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/form-controls-vrl-004.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/form-controls-vrl-005.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/inline-replaced-vlr-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/inline-replaced-vrl-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-htb-001.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-007.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-008.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-010.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-013.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-014.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-018.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-020.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-005.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-006.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-009.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-011.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-012.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-017.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-019.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/page-flow-direction-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/page-flow-direction-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/replaced-content-image-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/replaced-content-image-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vlr-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vlr-005.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vlr-007.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vrl-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vrl-004.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vrl-006.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vrl-008.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/writing-mode-vertical-rl-003.htm
    • third_party/WebKit/LayoutTests/external/wpt/encoding/api-basics.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/api-invalid-label.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/api-replacement-encodings.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/api-surrogates-utf8.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/iso-2022-jp-decoder.any-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/encoding/iso-2022-jp-decoder.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/iso-2022-jp-decoder.any.worker-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/encoding/iso-2022-jp-decoder.html
    • third_party/WebKit/LayoutTests/external/wpt/encoding/replacement-encodings.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-byte-order-marks.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-fatal-single-byte.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-fatal-streaming.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-fatal.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-ignorebom.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-labels.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-streaming.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-utf16-surrogates.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textencoder-constructor-non-utf.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textencoder-utf16-surrogates.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/unsupported-encodings.any.js
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-object-element/object-setcustomvalidity-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-object-element/object-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-button-element/button-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-fieldset-element/fieldset-setcustomvalidity-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-fieldset-element/fieldset-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-input-element/input-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-output-element/output-setcustomvalidity-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-output-element/output-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-select-element/select-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-textarea-element/textarea-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/appmanifest.idl
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/screen-orientation.idl
    • third_party/WebKit/LayoutTests/external/wpt/screen-orientation/idlharness.window.js
    • third_party/WebKit/LayoutTests/external/wpt/screen-orientation/interfaces.html
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception.dedicatedworker.html
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception.html
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception.js
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception.serviceworker.https.html
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception.sharedworker.html
    • third_party/WebKit/LayoutTests/platform/mac-retina/external/wpt/appmanifest/idlharness.window-expected.txt
  29. [Sync::Consent] Split ConsentAuditor interface from implementation.

    Changed by vitaliii - vitaliiiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:40:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7782405912e05feca6e0cf3808ab8f3c8ff70f2f

    Comments

    [Sync::Consent] Split ConsentAuditor interface from implementation.
    
    Also rewrite FakeConsentAuditor to implement the interface instead of
    inheriting from the implementation. This unblocks enabling the separate
    datatype feature by default.
    
    Bug: 862186
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I474f74f12278221ef6278c120576f1ff1a224c4a
    Reviewed-on: https://chromium-review.googlesource.com/1131508
    Reviewed-by: Markus Heintz <markusheintz@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: vitaliii <vitaliii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574569}

    Changed files

    • chrome/browser/consent_auditor/consent_auditor_factory.cc
    • chrome/browser/consent_auditor/consent_auditor_test_utils.cc
    • components/consent_auditor/BUILD.gn
    • components/consent_auditor/consent_auditor.cc
    • components/consent_auditor/consent_auditor.h
    • components/consent_auditor/consent_auditor_impl.cc
    • components/consent_auditor/consent_auditor_impl.h
    • components/consent_auditor/consent_auditor_impl_unittest.cc
    • components/consent_auditor/fake_consent_auditor.cc
    • components/consent_auditor/fake_consent_auditor.h
    • ios/chrome/browser/consent_auditor/consent_auditor_factory.cc
    • ios/chrome/browser/ui/authentication/chrome_signin_view_controller_unittest.mm
  30. [content-service] Support basic View embedding

    Changed by Ken Rockot - rockotohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:36:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99c5bc74636041c26d31f3dae12c7fc51032ce27

    Comments

    [content-service] Support basic View embedding
    
    Adds support for embedding a View object within a client application's
    window tree. Currently Chrome OS only.
    
    Enables a new simple_browser test application to be launched via a
    command-line flag in DCHECK-enabled builds only, for manual developer
    testing. This application runs in a sandboxed utility process and embeds
    a View that can be navigated, displaying web contents within the
    application's UI, backed by a concrete WebContents owned by a Content
    Service instance in the browser process.
    
    Bug: 855092
    Change-Id: I95937f987e87ad303689d73b7e57c836ee706d28
    Test: Launch Chrome OS chrome --enable-features=Mash --launch-simple-browser and verify that you can navigate the cute little browser window that pops up.
    Reviewed-on: https://chromium-review.googlesource.com/1125342
    Reviewed-by: Robert Sesek <rsesek@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574568}

    Changed files

    • chrome/app/BUILD.gn
    • chrome/browser/BUILD.gn
    • chrome/browser/DEPS
    • chrome/browser/chrome_browser_main.cc
    • chrome/browser/chrome_content_browser_client.cc
    • chrome/common/BUILD.gn
    • chrome/common/features.gni
    • chrome/utility/BUILD.gn
    • chrome/utility/DEPS
    • chrome/utility/chrome_content_utility_client.cc
    • content/browser/browser_context.cc
    • content/browser/content_service_delegate_impl.cc
    • services/content/BUILD.gn
    • services/content/DEPS
    • services/content/public/cpp/BUILD.gn
    • services/content/public/cpp/DEPS
    • services/content/public/cpp/view.cc
    • services/content/public/cpp/view.h
    • services/content/public/features.gni
    • services/content/public/mojom/BUILD.gn
    • services/content/public/mojom/view.mojom
    • services/content/service_unittest.cc
    • services/content/simple_browser/BUILD.gn
    • services/content/simple_browser/DEPS
    • services/content/simple_browser/OWNERS
    • services/content/simple_browser/README.md
    • services/content/simple_browser/manifest.json
    • services/content/simple_browser/public/mojom/BUILD.gn
    • services/content/simple_browser/public/mojom/OWNERS
    • services/content/simple_browser/public/mojom/constants.mojom
    • services/content/simple_browser/simple_browser_service.cc
    • services/content/simple_browser/simple_browser_service.h
    • services/content/simple_browser/window.cc
    • services/content/simple_browser/window.h
    • services/content/view_delegate.h
    • services/content/view_impl.cc
    • services/content/view_impl.h
    • ui/views/mus/remote_view/BUILD.gn
  31. Fix crash with webRequest and network service when duplicate request IDs are seen.

    Changed by John Abd-El-Malek - jamohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:25:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b4072ab48cadcd3f98481be63bdd59e5c623729d

    Comments

    Fix crash with webRequest and network service when duplicate request IDs are seen.
    
    The cause in this case was SimpleURLLoader always using a request ID of 0. These requests don't go through auth anyways (since there's no tab to associate them with). Gracefully handle this in WebRequestProxyingURLLoaderFactory by not crashing.
    
    Bug: 853118
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I856259f76caf67d7d6c0b8e48535cd56419ead1a
    Reviewed-on: https://chromium-review.googlesource.com/1133692
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574567}

    Changed files

    • extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
    • extensions/browser/api/web_request/web_request_proxying_url_loader_factory.h
    • testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
  32. [Background Fetch] Get options and title on initialization.

    Changed by Rayan Kanso - rayankansohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:21:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3925c59dce4a1a882e581e405c82303fbb99bce0

    Comments

    [Background Fetch] Get options and title on initialization.
    
    Bug: 853058
    Change-Id: Ib5ef98ad0cd988a5ac361b96fa55cebb0e09b800
    Reviewed-on: https://chromium-review.googlesource.com/1128863
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574566}

    Changed files

    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/storage/get_initialization_data_task.cc
    • content/browser/background_fetch/storage/get_initialization_data_task.h
  33. Erase unused const

    Changed by Javier Ernesto Flores Robles - javierroblesohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:17:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5037e10260cd47b7e6ac92b324d2e111e8970a3

    Comments

    Erase unused const
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I09e9bd22b692fb5d9a79bac0d2e29e3ec01046df
    Reviewed-on: https://chromium-review.googlesource.com/1134992
    Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574565}

    Changed files

    • ios/chrome/browser/passwords/password_generation_utils.mm
  34. Add Blink.ResourceFetcher.StaleWhileRevalidateDuration histogram.

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:15:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 12f1a6d2b078baa8bda6dd3f9b94be9897a12e9f

    Comments

    Add Blink.ResourceFetcher.StaleWhileRevalidateDuration histogram.
    
    This histogram tracks the duration of completed stale revalidation
    attempts. This value will be used as a rough approximation of
    the benefit received by using Stale While Revalidate.
    
    BUG=348877
    
    Change-Id: I47601e667394c401ccdc96afc4d73d6c464faa3b
    Reviewed-on: https://chromium-review.googlesource.com/1133961
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574564}

    Changed files

    • third_party/blink/renderer/platform/loader/fetch/stale_revalidation_resource_client.cc
    • third_party/blink/renderer/platform/loader/fetch/stale_revalidation_resource_client.h
    • tools/metrics/histograms/histograms.xml
  35. [chromecast] Fix back gesture behavior.

    Changed by Ryan Daum - rdaumohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:13:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 937dab73796dc72314a70b8825f89484e03881c9

    Comments

    [chromecast] Fix back gesture behavior.
    
    Changes the back gesture behavior to match UX expectations.
    
      - Do not trigger the back gesture until the finger lifts.
      - Make sure progress events never continue after cancel or end.
    
    Bug: internal b/109888887
    Test: manual and unit tests
    Change-Id: I388e078d4ec520e53bfed34dfdaaa378dadf0d0a
    Reviewed-on: https://chromium-review.googlesource.com/1135188
    Commit-Queue: Ryan Daum <rdaum@chromium.org>
    Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574563}

    Changed files

    • chromecast/browser/cast_gesture_dispatcher.cc
    • chromecast/browser/cast_gesture_dispatcher_test.cc
  36. macviews: use cocoa context menus for web content

    Changed by Elly Fong-Jones - ellyjonesohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:10:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c7a09eb8d51c7e5d4d6ae68b4de0c8d3d9fcbabb

    Comments

    macviews: use cocoa context menus for web content
    
    Bug: 860673
    Change-Id: I459eaf26c3fffb6c87ddbe2b8cd28db15d7cc90f
    Reviewed-on: https://chromium-review.googlesource.com/1134539
    Reviewed-by: Leonard Grey <lgrey@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574562}

    Changed files

    • chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm
  37. Revert "tcmalloc: Move existing tcmalloc files under gperftools-2.0."

    Changed by Jochen Eisinger - jochenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 14:59:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 06c7d7e68470ca975c0d10340a89e3e69ebab6ad

    Comments

    Revert "tcmalloc: Move existing tcmalloc files under gperftools-2.0."
    
    This reverts commit 615e0342e44cbe073b1958ab9f5a318d799f6f34.
    
    Reason for revert: breaks compilation with enable_profiling = true
    
    Original change's description:
    > tcmalloc: Move existing tcmalloc files under gperftools-2.0.
    > 
    > Move existing tcmalloc files, both vendor and chromium, under gperftools-2.0
    > in preparation for upreving tcmalloc to the most recent gperftools version.
    > 
    > This CL did:
    > 
    >   # Create a gerftools-2.0 folder.
    >   mkdir gperftools-2.0
    > 
    >   # Move vendor/ and chromium/ under the new folder.
    >   git mv vendor gperftools-2.0/vendor
    >   git mv chromium gperftools-2.0/chromium
    > 
    >   # Update //base/allocator/BUILD.gn to have tcmalloc_dir point to
    >   # //third_party/tcmalloc/gperftools-2.0/chromium/src.
    >   # Update addr2line-pdb sources in tcmalloc/BUILD.gn.
    >   # Update include paths in files under //base/process and //base/allocator.
    > 
    > This is old code that uses currently banned functions.
    > NOPRESUBMIT=true
    > 
    > BUG=724399,b:70905156
    > 
    > Change-Id: I498a6edda48e178bbacfb41e30f75e9e96e336fc
    > Reviewed-on: https://chromium-review.googlesource.com/1130670
    > Reviewed-by: Will Harris <wfh@chromium.org>
    > Commit-Queue: Gabriel Marin <gmx@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574346}
    
    TBR=wfh@chromium.org,gmx@chromium.org
    
    Change-Id: Ifdd162a045009444621c6e3052f348919fdafc96
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 724399, b:70905156
    Reviewed-on: https://chromium-review.googlesource.com/1135266
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Commit-Queue: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574561}

    Changed files

    • base/allocator/BUILD.gn
    • base/allocator/allocator_extension.cc
    • base/allocator/allocator_shim_default_dispatch_to_tcmalloc.cc
    • base/allocator/debugallocation_shim.cc
    • base/process/memory_linux.cc
    • third_party/tcmalloc/BUILD.gn
    • third_party/tcmalloc/chromium/src/OWNERS
    • third_party/tcmalloc/chromium/src/addressmap-inl.h
    • third_party/tcmalloc/chromium/src/base/abort.cc
    • third_party/tcmalloc/chromium/src/base/abort.h
    • third_party/tcmalloc/chromium/src/base/arm_instruction_set_select.h
    • third_party/tcmalloc/chromium/src/base/atomicops-internals-arm-generic.h
    • third_party/tcmalloc/chromium/src/base/atomicops-internals-arm-v6plus.h
    • third_party/tcmalloc/chromium/src/base/atomicops-internals-linuxppc.h
    • third_party/tcmalloc/chromium/src/base/atomicops-internals-macosx.h
    • third_party/tcmalloc/chromium/src/base/atomicops-internals-mips.h
    • third_party/tcmalloc/chromium/src/base/atomicops-internals-windows.h
    • third_party/tcmalloc/chromium/src/base/atomicops-internals-x86.cc
    • third_party/tcmalloc/chromium/src/base/atomicops-internals-x86.h
    • third_party/tcmalloc/chromium/src/base/atomicops.h
    • third_party/tcmalloc/chromium/src/base/basictypes.h
    • third_party/tcmalloc/chromium/src/base/commandlineflags.h
    • third_party/tcmalloc/chromium/src/base/cycleclock.h
    • third_party/tcmalloc/chromium/src/base/dynamic_annotations.c
    • third_party/tcmalloc/chromium/src/base/dynamic_annotations.h
    • third_party/tcmalloc/chromium/src/base/elf_mem_image.cc
    • third_party/tcmalloc/chromium/src/base/elf_mem_image.h
    • third_party/tcmalloc/chromium/src/base/elfcore.h
    • third_party/tcmalloc/chromium/src/base/googleinit.h
    • third_party/tcmalloc/chromium/src/base/linux_syscall_support.h
    • third_party/tcmalloc/chromium/src/base/linuxthreads.cc
    • third_party/tcmalloc/chromium/src/base/linuxthreads.h
    • third_party/tcmalloc/chromium/src/base/logging.cc
    • third_party/tcmalloc/chromium/src/base/logging.h
    • third_party/tcmalloc/chromium/src/base/low_level_alloc.cc
    • third_party/tcmalloc/chromium/src/base/low_level_alloc.h
    • third_party/tcmalloc/chromium/src/base/simple_mutex.h
    • third_party/tcmalloc/chromium/src/base/spinlock.cc
    • third_party/tcmalloc/chromium/src/base/spinlock.h
    • third_party/tcmalloc/chromium/src/base/spinlock_internal.cc
    • third_party/tcmalloc/chromium/src/base/spinlock_internal.h
    • third_party/tcmalloc/chromium/src/base/spinlock_linux-inl.h
    • third_party/tcmalloc/chromium/src/base/spinlock_posix-inl.h
    • third_party/tcmalloc/chromium/src/base/spinlock_win32-inl.h
    • third_party/tcmalloc/chromium/src/base/stl_allocator.h
    • third_party/tcmalloc/chromium/src/base/synchronization_profiling.h
    • third_party/tcmalloc/chromium/src/base/sysinfo.cc
    • third_party/tcmalloc/chromium/src/base/sysinfo.h
    • third_party/tcmalloc/chromium/src/base/thread_annotations.h
    • third_party/tcmalloc/chromium/src/base/thread_lister.c
    • third_party/tcmalloc/chromium/src/base/thread_lister.h
    • third_party/tcmalloc/chromium/src/base/vdso_support.cc
    • third_party/tcmalloc/chromium/src/base/vdso_support.h
    • third_party/tcmalloc/chromium/src/central_freelist.cc
    • third_party/tcmalloc/chromium/src/central_freelist.h
    • third_party/tcmalloc/chromium/src/common.cc
    • third_party/tcmalloc/chromium/src/common.h
    • third_party/tcmalloc/chromium/src/config.h
    • third_party/tcmalloc/chromium/src/config.h.in
    • third_party/tcmalloc/chromium/src/config_android.h
    • third_party/tcmalloc/chromium/src/config_for_unittests.h
    • third_party/tcmalloc/chromium/src/config_freebsd.h
    • third_party/tcmalloc/chromium/src/config_linux.h
    • third_party/tcmalloc/chromium/src/config_win.h
    • third_party/tcmalloc/chromium/src/debugallocation.cc
    • third_party/tcmalloc/chromium/src/free_list.cc
    • third_party/tcmalloc/chromium/src/free_list.h
    • third_party/tcmalloc/chromium/src/getpc.h
    • third_party/tcmalloc/chromium/src/google/heap-checker.h
    • third_party/tcmalloc/chromium/src/google/heap-profiler.h
    • third_party/tcmalloc/chromium/src/google/malloc_extension.h
    • third_party/tcmalloc/chromium/src/google/malloc_extension_c.h
    • third_party/tcmalloc/chromium/src/google/malloc_hook.h
    • third_party/tcmalloc/chromium/src/google/malloc_hook_c.h
    • third_party/tcmalloc/chromium/src/google/profiler.h
    • third_party/tcmalloc/chromium/src/google/stacktrace.h
    • third_party/tcmalloc/chromium/src/google/tcmalloc.h
    • third_party/tcmalloc/chromium/src/gperftools/heap-checker.h
    • third_party/tcmalloc/chromium/src/gperftools/heap-profiler.h
    • third_party/tcmalloc/chromium/src/gperftools/malloc_extension.h
    • third_party/tcmalloc/chromium/src/gperftools/malloc_extension_c.h
    • third_party/tcmalloc/chromium/src/gperftools/malloc_hook.h
    • third_party/tcmalloc/chromium/src/gperftools/malloc_hook_c.h
    • third_party/tcmalloc/chromium/src/gperftools/profiler.h
    • third_party/tcmalloc/chromium/src/gperftools/stacktrace.h
    • third_party/tcmalloc/chromium/src/gperftools/tcmalloc.h
    • third_party/tcmalloc/chromium/src/gperftools/tcmalloc.h.in
    • third_party/tcmalloc/chromium/src/heap-checker-bcad.cc
    • third_party/tcmalloc/chromium/src/heap-checker.cc
    • third_party/tcmalloc/chromium/src/heap-profile-stats.h
    • third_party/tcmalloc/chromium/src/heap-profile-table.cc
    • third_party/tcmalloc/chromium/src/heap-profile-table.h
    • third_party/tcmalloc/chromium/src/heap-profiler.cc
    • third_party/tcmalloc/chromium/src/internal_logging.cc
    • third_party/tcmalloc/chromium/src/internal_logging.h
    • third_party/tcmalloc/chromium/src/libc_override.h
    • third_party/tcmalloc/chromium/src/libc_override_gcc_and_weak.h
    • third_party/tcmalloc/chromium/src/libc_override_glibc.h
    • third_party/tcmalloc/chromium/src/libc_override_osx.h
    • third_party/tcmalloc/chromium/src/libc_override_redefine.h
    • third_party/tcmalloc/chromium/src/linked_list.h
    • third_party/tcmalloc/chromium/src/linux_shadow_stacks.cc
    • third_party/tcmalloc/chromium/src/linux_shadow_stacks.h
    • third_party/tcmalloc/chromium/src/malloc_extension.cc
    • third_party/tcmalloc/chromium/src/malloc_hook-inl.h
    • third_party/tcmalloc/chromium/src/malloc_hook.cc
    • third_party/tcmalloc/chromium/src/malloc_hook_mmap_freebsd.h
    • third_party/tcmalloc/chromium/src/malloc_hook_mmap_linux.h
    • third_party/tcmalloc/chromium/src/maybe_threads.cc
    • third_party/tcmalloc/chromium/src/maybe_threads.h
    • third_party/tcmalloc/chromium/src/memfs_malloc.cc
    • third_party/tcmalloc/chromium/src/memory_region_map.cc
    • third_party/tcmalloc/chromium/src/memory_region_map.h
    • third_party/tcmalloc/chromium/src/packed-cache-inl.h
    • third_party/tcmalloc/chromium/src/page_heap.cc
    • third_party/tcmalloc/chromium/src/page_heap.h
    • third_party/tcmalloc/chromium/src/page_heap_allocator.h
    • third_party/tcmalloc/chromium/src/pagemap.h
    • third_party/tcmalloc/chromium/src/pprof
    • third_party/tcmalloc/chromium/src/profile-handler.cc
    • third_party/tcmalloc/chromium/src/profile-handler.h
    • third_party/tcmalloc/chromium/src/profiledata.cc
    • third_party/tcmalloc/chromium/src/profiledata.h
    • third_party/tcmalloc/chromium/src/profiler.cc
    • third_party/tcmalloc/chromium/src/raw_printer.cc
    • third_party/tcmalloc/chromium/src/raw_printer.h
    • third_party/tcmalloc/chromium/src/sampler.cc
    • third_party/tcmalloc/chromium/src/sampler.h
    • third_party/tcmalloc/chromium/src/solaris/libstdc++.la
    • third_party/tcmalloc/chromium/src/span.cc
    • third_party/tcmalloc/chromium/src/span.h
    • third_party/tcmalloc/chromium/src/stack_trace_table.cc
    • third_party/tcmalloc/chromium/src/stack_trace_table.h
    • third_party/tcmalloc/chromium/src/stacktrace.cc
    • third_party/tcmalloc/chromium/src/stacktrace_android-inl.h
    • third_party/tcmalloc/chromium/src/stacktrace_arm-inl.h
    • third_party/tcmalloc/chromium/src/stacktrace_config.h
    • third_party/tcmalloc/chromium/src/stacktrace_generic-inl.h
    • third_party/tcmalloc/chromium/src/stacktrace_libunwind-inl.h
    • third_party/tcmalloc/chromium/src/stacktrace_mips-inl.h
    • third_party/tcmalloc/chromium/src/stacktrace_powerpc-inl.h
    • third_party/tcmalloc/chromium/src/stacktrace_win32-inl.h
    • third_party/tcmalloc/chromium/src/stacktrace_with_context.cc
    • third_party/tcmalloc/chromium/src/stacktrace_x86-inl.h
    • third_party/tcmalloc/chromium/src/static_vars.cc
    • third_party/tcmalloc/chromium/src/static_vars.h
    • third_party/tcmalloc/chromium/src/symbolize.cc
    • third_party/tcmalloc/chromium/src/symbolize.h
    • third_party/tcmalloc/chromium/src/system-alloc.cc
    • third_party/tcmalloc/chromium/src/system-alloc.h
    • third_party/tcmalloc/chromium/src/tcmalloc.cc
    • third_party/tcmalloc/chromium/src/tcmalloc.h
    • third_party/tcmalloc/chromium/src/tcmalloc_guard.h
    • third_party/tcmalloc/chromium/src/tests/addressmap_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/atomicops_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/current_allocated_bytes_test.cc
    • third_party/tcmalloc/chromium/src/tests/debugallocation_test.cc
    • third_party/tcmalloc/chromium/src/tests/debugallocation_test.sh
    • third_party/tcmalloc/chromium/src/tests/frag_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/getpc_test.cc
    • third_party/tcmalloc/chromium/src/tests/heap-checker-death_unittest.sh
    • third_party/tcmalloc/chromium/src/tests/heap-checker_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/heap-checker_unittest.sh
    • third_party/tcmalloc/chromium/src/tests/heap-profiler_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/heap-profiler_unittest.sh
    • third_party/tcmalloc/chromium/src/tests/low_level_alloc_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/malloc_extension_c_test.c
    • third_party/tcmalloc/chromium/src/tests/malloc_extension_test.cc
    • third_party/tcmalloc/chromium/src/tests/malloc_hook_test.cc
    • third_party/tcmalloc/chromium/src/tests/markidle_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/maybe_threads_unittest.sh
    • third_party/tcmalloc/chromium/src/tests/memalign_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/packed-cache_test.cc
    • third_party/tcmalloc/chromium/src/tests/page_heap_test.cc
    • third_party/tcmalloc/chromium/src/tests/pagemap_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/profile-handler_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/profiledata_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/profiler_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/profiler_unittest.sh
    • third_party/tcmalloc/chromium/src/tests/raw_printer_test.cc
    • third_party/tcmalloc/chromium/src/tests/realloc_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/sampler_test.cc
    • third_party/tcmalloc/chromium/src/tests/sampling_test.cc
    • third_party/tcmalloc/chromium/src/tests/sampling_test.sh
    • third_party/tcmalloc/chromium/src/tests/simple_compat_test.cc
    • third_party/tcmalloc/chromium/src/tests/stack_trace_table_test.cc
    • third_party/tcmalloc/chromium/src/tests/stacktrace_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/system-alloc_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/tcmalloc_large_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/tcmalloc_unittest.cc
    • third_party/tcmalloc/chromium/src/tests/testutil.cc
    • third_party/tcmalloc/chromium/src/tests/testutil.h
    • third_party/tcmalloc/chromium/src/tests/thread_dealloc_unittest.cc
    • third_party/tcmalloc/chromium/src/thread_cache.cc
    • third_party/tcmalloc/chromium/src/thread_cache.h
    • third_party/tcmalloc/chromium/src/windows/TODO
    • third_party/tcmalloc/chromium/src/windows/addr2line-pdb.c
    • third_party/tcmalloc/chromium/src/windows/auto_testing_hook.h
    • third_party/tcmalloc/chromium/src/windows/config.h
    • third_party/tcmalloc/chromium/src/windows/get_mangled_names.cc
    • third_party/tcmalloc/chromium/src/windows/google/tcmalloc.h
    • third_party/tcmalloc/chromium/src/windows/gperftools/tcmalloc.h
    • third_party/tcmalloc/chromium/src/windows/gperftools/tcmalloc.h.in
    • third_party/tcmalloc/chromium/src/windows/ia32_modrm_map.cc
    • third_party/tcmalloc/chromium/src/windows/ia32_opcode_map.cc
    • third_party/tcmalloc/chromium/src/windows/mingw.h
    • third_party/tcmalloc/chromium/src/windows/mini_disassembler.cc
    • third_party/tcmalloc/chromium/src/windows/mini_disassembler.h
    • third_party/tcmalloc/chromium/src/windows/mini_disassembler_types.h
    • third_party/tcmalloc/chromium/src/windows/nm-pdb.c
    • third_party/tcmalloc/chromium/src/windows/override_functions.cc
    • third_party/tcmalloc/chromium/src/windows/patch_functions.cc
    • third_party/tcmalloc/chromium/src/windows/port.cc
    • third_party/tcmalloc/chromium/src/windows/port.h
    • third_party/tcmalloc/chromium/src/windows/preamble_patcher.cc
    • third_party/tcmalloc/chromium/src/windows/preamble_patcher.h
    • third_party/tcmalloc/chromium/src/windows/preamble_patcher_test.cc
    • third_party/tcmalloc/chromium/src/windows/preamble_patcher_with_stub.cc
    • third_party/tcmalloc/chromium/src/windows/shortproc.asm
    • third_party/tcmalloc/gperftools-2.0/chromium/src/config.h
    • third_party/tcmalloc/vendor/AUTHORS
    • third_party/tcmalloc/vendor/COPYING
    • third_party/tcmalloc/vendor/ChangeLog
    • third_party/tcmalloc/vendor/INSTALL
    • third_party/tcmalloc/vendor/Makefile.am
    • third_party/tcmalloc/vendor/Makefile.in
    • third_party/tcmalloc/vendor/NEWS
    • third_party/tcmalloc/vendor/README
    • third_party/tcmalloc/vendor/README_windows.txt
    • third_party/tcmalloc/vendor/TODO
    • third_party/tcmalloc/vendor/aclocal.m4
    • third_party/tcmalloc/vendor/autogen.sh
    • third_party/tcmalloc/vendor/compile
    • third_party/tcmalloc/vendor/config.guess
    • third_party/tcmalloc/vendor/config.sub
    • third_party/tcmalloc/vendor/configure
    • third_party/tcmalloc/vendor/configure.ac
    • third_party/tcmalloc/vendor/depcomp
    • third_party/tcmalloc/vendor/doc/cpuprofile-fileformat.html
    • third_party/tcmalloc/vendor/doc/cpuprofile.html
    • third_party/tcmalloc/vendor/doc/designstyle.css
    • third_party/tcmalloc/vendor/doc/heap-example1.png
    • third_party/tcmalloc/vendor/doc/heap_checker.html
    • third_party/tcmalloc/vendor/doc/heapprofile.html
    • third_party/tcmalloc/vendor/doc/index.html
    • third_party/tcmalloc/vendor/doc/overview.dot
    • third_party/tcmalloc/vendor/doc/overview.gif
    • third_party/tcmalloc/vendor/doc/pageheap.dot
    • third_party/tcmalloc/vendor/doc/pageheap.gif
    • third_party/tcmalloc/vendor/doc/pprof-test-big.gif
    • third_party/tcmalloc/vendor/doc/pprof-test.gif
    • third_party/tcmalloc/vendor/doc/pprof-vsnprintf-big.gif
    • third_party/tcmalloc/vendor/doc/pprof-vsnprintf.gif
    • third_party/tcmalloc/vendor/doc/pprof.1
    • third_party/tcmalloc/vendor/doc/pprof.see_also
    • third_party/tcmalloc/vendor/doc/pprof_remote_servers.html
    • third_party/tcmalloc/vendor/doc/spanmap.dot
    • third_party/tcmalloc/vendor/doc/spanmap.gif
    • third_party/tcmalloc/vendor/doc/t-test1.times.txt
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.1024.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.128.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.131072.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.16384.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.2048.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.256.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.32768.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.4096.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.512.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.64.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.65536.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspercpusec.vs.threads.8192.bytes.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspersec.vs.size.1.threads.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspersec.vs.size.12.threads.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspersec.vs.size.16.threads.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspersec.vs.size.2.threads.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspersec.vs.size.20.threads.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspersec.vs.size.3.threads.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspersec.vs.size.4.threads.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspersec.vs.size.5.threads.png
    • third_party/tcmalloc/vendor/doc/tcmalloc-opspersec.vs.size.8.threads.png
    • third_party/tcmalloc/vendor/doc/tcmalloc.html
    • third_party/tcmalloc/vendor/doc/threadheap.dot
    • third_party/tcmalloc/vendor/doc/threadheap.gif
    • third_party/tcmalloc/vendor/install-sh
    • third_party/tcmalloc/vendor/ltmain.sh
    • third_party/tcmalloc/vendor/m4/ac_have_attribute.m4
    • third_party/tcmalloc/vendor/m4/acx_nanosleep.m4
    • third_party/tcmalloc/vendor/m4/acx_pthread.m4
    • third_party/tcmalloc/vendor/m4/compiler_characteristics.m4
    • third_party/tcmalloc/vendor/m4/install_prefix.m4
    • third_party/tcmalloc/vendor/m4/libtool.m4
    • third_party/tcmalloc/vendor/m4/ltoptions.m4
    • third_party/tcmalloc/vendor/m4/ltsugar.m4
    • third_party/tcmalloc/vendor/m4/ltversion.m4
    • third_party/tcmalloc/vendor/m4/lt~obsolete.m4
    • third_party/tcmalloc/vendor/m4/namespaces.m4
    • third_party/tcmalloc/vendor/m4/pc_from_ucontext.m4
    • third_party/tcmalloc/vendor/m4/program_invocation_name.m4
    • third_party/tcmalloc/vendor/m4/stl_namespace.m4
    • third_party/tcmalloc/vendor/missing
    • third_party/tcmalloc/vendor/mkinstalldirs
    • third_party/tcmalloc/vendor/packages/deb.sh
    • third_party/tcmalloc/vendor/packages/deb/README
    • third_party/tcmalloc/vendor/packages/deb/changelog
    • third_party/tcmalloc/vendor/packages/deb/compat
    • third_party/tcmalloc/vendor/packages/deb/control
    • third_party/tcmalloc/vendor/packages/deb/copyright
    • third_party/tcmalloc/vendor/packages/deb/docs
    • third_party/tcmalloc/vendor/packages/deb/libgperftools-dev.dirs
    • third_party/tcmalloc/vendor/packages/deb/libgperftools-dev.install
    • third_party/tcmalloc/vendor/packages/deb/libgperftools0.dirs
    • third_party/tcmalloc/vendor/packages/deb/libgperftools0.install
    • third_party/tcmalloc/vendor/packages/deb/libgperftools0.manpages
    • third_party/tcmalloc/vendor/packages/deb/rules
    • third_party/tcmalloc/vendor/packages/rpm.sh
    • third_party/tcmalloc/vendor/packages/rpm/rpm.spec
    • third_party/tcmalloc/vendor/src/addressmap-inl.h
    • third_party/tcmalloc/vendor/src/base/arm_instruction_set_select.h
    • third_party/tcmalloc/vendor/src/base/atomicops-internals-arm-generic.h
    • third_party/tcmalloc/vendor/src/base/atomicops-internals-arm-v6plus.h
    • third_party/tcmalloc/vendor/src/base/atomicops-internals-linuxppc.h
    • third_party/tcmalloc/vendor/src/base/atomicops-internals-macosx.h
    • third_party/tcmalloc/vendor/src/base/atomicops-internals-windows.h
    • third_party/tcmalloc/vendor/src/base/atomicops-internals-x86.cc
    • third_party/tcmalloc/vendor/src/base/atomicops-internals-x86.h
    • third_party/tcmalloc/vendor/src/base/atomicops.h
    • third_party/tcmalloc/vendor/src/base/basictypes.h
    • third_party/tcmalloc/vendor/src/base/commandlineflags.h
    • third_party/tcmalloc/vendor/src/base/cycleclock.h
    • third_party/tcmalloc/vendor/src/base/dynamic_annotations.c
    • third_party/tcmalloc/vendor/src/base/dynamic_annotations.h
    • third_party/tcmalloc/vendor/src/base/elf_mem_image.cc
    • third_party/tcmalloc/vendor/src/base/elf_mem_image.h
    • third_party/tcmalloc/vendor/src/base/elfcore.h
    • third_party/tcmalloc/vendor/src/base/googleinit.h
    • third_party/tcmalloc/vendor/src/base/linux_syscall_support.h
    • third_party/tcmalloc/vendor/src/base/linuxthreads.cc
    • third_party/tcmalloc/vendor/src/base/linuxthreads.h
    • third_party/tcmalloc/vendor/src/base/logging.cc
    • third_party/tcmalloc/vendor/src/base/logging.h
    • third_party/tcmalloc/vendor/src/base/low_level_alloc.cc
    • third_party/tcmalloc/vendor/src/base/low_level_alloc.h
    • third_party/tcmalloc/vendor/src/base/simple_mutex.h
    • third_party/tcmalloc/vendor/src/base/spinlock.cc
    • third_party/tcmalloc/vendor/src/base/spinlock.h
    • third_party/tcmalloc/vendor/src/base/spinlock_internal.cc
    • third_party/tcmalloc/vendor/src/base/spinlock_internal.h
    • third_party/tcmalloc/vendor/src/base/spinlock_linux-inl.h
    • third_party/tcmalloc/vendor/src/base/spinlock_posix-inl.h
    • third_party/tcmalloc/vendor/src/base/spinlock_win32-inl.h
    • third_party/tcmalloc/vendor/src/base/stl_allocator.h
    • third_party/tcmalloc/vendor/src/base/synchronization_profiling.h
    • third_party/tcmalloc/vendor/src/base/sysinfo.cc
    • third_party/tcmalloc/vendor/src/base/sysinfo.h
    • third_party/tcmalloc/vendor/src/base/thread_annotations.h
    • third_party/tcmalloc/vendor/src/base/thread_lister.c
    • third_party/tcmalloc/vendor/src/base/thread_lister.h
    • third_party/tcmalloc/vendor/src/base/vdso_support.cc
    • third_party/tcmalloc/vendor/src/base/vdso_support.h
    • third_party/tcmalloc/vendor/src/central_freelist.cc
    • third_party/tcmalloc/vendor/src/central_freelist.h
    • third_party/tcmalloc/vendor/src/common.cc
    • third_party/tcmalloc/vendor/src/common.h
    • third_party/tcmalloc/vendor/src/config.h.in
    • third_party/tcmalloc/vendor/src/config_for_unittests.h
    • third_party/tcmalloc/vendor/src/debugallocation.cc
    • third_party/tcmalloc/vendor/src/getpc.h
    • third_party/tcmalloc/vendor/src/google/heap-checker.h
    • third_party/tcmalloc/vendor/src/google/heap-profiler.h
    • third_party/tcmalloc/vendor/src/google/malloc_extension.h
    • third_party/tcmalloc/vendor/src/google/malloc_extension_c.h
    • third_party/tcmalloc/vendor/src/google/malloc_hook.h
    • third_party/tcmalloc/vendor/src/google/malloc_hook_c.h
    • third_party/tcmalloc/vendor/src/google/profiler.h
    • third_party/tcmalloc/vendor/src/google/stacktrace.h
    • third_party/tcmalloc/vendor/src/google/tcmalloc.h
    • third_party/tcmalloc/vendor/src/gperftools/heap-checker.h
    • third_party/tcmalloc/vendor/src/gperftools/heap-profiler.h
    • third_party/tcmalloc/vendor/src/gperftools/malloc_extension.h
    • third_party/tcmalloc/vendor/src/gperftools/malloc_extension_c.h
    • third_party/tcmalloc/vendor/src/gperftools/malloc_hook.h
    • third_party/tcmalloc/vendor/src/gperftools/malloc_hook_c.h
    • third_party/tcmalloc/vendor/src/gperftools/profiler.h
    • third_party/tcmalloc/vendor/src/gperftools/stacktrace.h
    • third_party/tcmalloc/vendor/src/gperftools/tcmalloc.h.in
    • third_party/tcmalloc/vendor/src/heap-checker-bcad.cc
    • third_party/tcmalloc/vendor/src/heap-checker.cc
    • third_party/tcmalloc/vendor/src/heap-profile-table.cc
    • third_party/tcmalloc/vendor/src/heap-profile-table.h
    • third_party/tcmalloc/vendor/src/heap-profiler.cc
    • third_party/tcmalloc/vendor/src/internal_logging.cc
    • third_party/tcmalloc/vendor/src/internal_logging.h
    • third_party/tcmalloc/vendor/src/libc_override.h
    • third_party/tcmalloc/vendor/src/libc_override_gcc_and_weak.h
    • third_party/tcmalloc/vendor/src/libc_override_glibc.h
    • third_party/tcmalloc/vendor/src/libc_override_osx.h
    • third_party/tcmalloc/vendor/src/libc_override_redefine.h
    • third_party/tcmalloc/vendor/src/linked_list.h
    • third_party/tcmalloc/vendor/src/malloc_extension.cc
    • third_party/tcmalloc/vendor/src/malloc_hook-inl.h
    • third_party/tcmalloc/vendor/src/malloc_hook.cc
    • third_party/tcmalloc/vendor/src/malloc_hook_mmap_freebsd.h
    • third_party/tcmalloc/vendor/src/malloc_hook_mmap_linux.h
    • third_party/tcmalloc/vendor/src/maybe_threads.cc
    • third_party/tcmalloc/vendor/src/maybe_threads.h
    • third_party/tcmalloc/vendor/src/memfs_malloc.cc
    • third_party/tcmalloc/vendor/src/memory_region_map.cc
    • third_party/tcmalloc/vendor/src/memory_region_map.h
    • third_party/tcmalloc/vendor/src/packed-cache-inl.h
    • third_party/tcmalloc/vendor/src/page_heap.cc
    • third_party/tcmalloc/vendor/src/page_heap.h
    • third_party/tcmalloc/vendor/src/page_heap_allocator.h
    • third_party/tcmalloc/vendor/src/pagemap.h
    • third_party/tcmalloc/vendor/src/pprof
    • third_party/tcmalloc/vendor/src/profile-handler.cc
    • third_party/tcmalloc/vendor/src/profile-handler.h
    • third_party/tcmalloc/vendor/src/profiledata.cc
    • third_party/tcmalloc/vendor/src/profiledata.h
    • third_party/tcmalloc/vendor/src/profiler.cc
    • third_party/tcmalloc/vendor/src/raw_printer.cc
    • third_party/tcmalloc/vendor/src/raw_printer.h
    • third_party/tcmalloc/vendor/src/sampler.cc
    • third_party/tcmalloc/vendor/src/sampler.h
    • third_party/tcmalloc/vendor/src/solaris/libstdc++.la
    • third_party/tcmalloc/vendor/src/span.cc
    • third_party/tcmalloc/vendor/src/span.h
    • third_party/tcmalloc/vendor/src/stack_trace_table.cc
    • third_party/tcmalloc/vendor/src/stack_trace_table.h
    • third_party/tcmalloc/vendor/src/stacktrace.cc
    • third_party/tcmalloc/vendor/src/stacktrace_arm-inl.h
    • third_party/tcmalloc/vendor/src/stacktrace_config.h
    • third_party/tcmalloc/vendor/src/stacktrace_generic-inl.h
    • third_party/tcmalloc/vendor/src/stacktrace_libunwind-inl.h
    • third_party/tcmalloc/vendor/src/stacktrace_powerpc-inl.h
    • third_party/tcmalloc/vendor/src/stacktrace_win32-inl.h
    • third_party/tcmalloc/vendor/src/stacktrace_x86-inl.h
    • third_party/tcmalloc/vendor/src/static_vars.cc
    • third_party/tcmalloc/vendor/src/static_vars.h
    • third_party/tcmalloc/vendor/src/symbolize.cc
    • third_party/tcmalloc/vendor/src/symbolize.h
    • third_party/tcmalloc/vendor/src/system-alloc.cc
    • third_party/tcmalloc/vendor/src/system-alloc.h
    • third_party/tcmalloc/vendor/src/tcmalloc.cc
    • third_party/tcmalloc/vendor/src/tcmalloc.h
    • third_party/tcmalloc/vendor/src/tcmalloc_guard.h
    • third_party/tcmalloc/vendor/src/tests/addressmap_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/atomicops_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/current_allocated_bytes_test.cc
    • third_party/tcmalloc/vendor/src/tests/debugallocation_test.cc
    • third_party/tcmalloc/vendor/src/tests/debugallocation_test.sh
    • third_party/tcmalloc/vendor/src/tests/frag_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/getpc_test.cc
    • third_party/tcmalloc/vendor/src/tests/heap-checker-death_unittest.sh
    • third_party/tcmalloc/vendor/src/tests/heap-checker_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/heap-checker_unittest.sh
    • third_party/tcmalloc/vendor/src/tests/heap-profiler_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/heap-profiler_unittest.sh
    • third_party/tcmalloc/vendor/src/tests/low_level_alloc_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/malloc_extension_c_test.c
    • third_party/tcmalloc/vendor/src/tests/malloc_extension_test.cc
    • third_party/tcmalloc/vendor/src/tests/malloc_hook_test.cc
    • third_party/tcmalloc/vendor/src/tests/markidle_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/maybe_threads_unittest.sh
    • third_party/tcmalloc/vendor/src/tests/memalign_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/packed-cache_test.cc
    • third_party/tcmalloc/vendor/src/tests/page_heap_test.cc
    • third_party/tcmalloc/vendor/src/tests/pagemap_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/profile-handler_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/profiledata_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/profiler_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/profiler_unittest.sh
    • third_party/tcmalloc/vendor/src/tests/raw_printer_test.cc
    • third_party/tcmalloc/vendor/src/tests/realloc_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/sampler_test.cc
    • third_party/tcmalloc/vendor/src/tests/sampling_test.cc
    • third_party/tcmalloc/vendor/src/tests/sampling_test.sh
    • third_party/tcmalloc/vendor/src/tests/simple_compat_test.cc
    • third_party/tcmalloc/vendor/src/tests/stack_trace_table_test.cc
    • third_party/tcmalloc/vendor/src/tests/stacktrace_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/system-alloc_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/tcmalloc_large_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/tcmalloc_unittest.cc
    • third_party/tcmalloc/vendor/src/tests/testutil.cc
    • third_party/tcmalloc/vendor/src/tests/testutil.h
    • third_party/tcmalloc/vendor/src/tests/thread_dealloc_unittest.cc
    • third_party/tcmalloc/vendor/src/third_party/valgrind.h
    • third_party/tcmalloc/vendor/src/thread_cache.cc
    • third_party/tcmalloc/vendor/src/thread_cache.h
    • third_party/tcmalloc/vendor/src/windows/TODO
    • third_party/tcmalloc/vendor/src/windows/addr2line-pdb.c
    • third_party/tcmalloc/vendor/src/windows/auto_testing_hook.h
    • third_party/tcmalloc/vendor/src/windows/config.h
    • third_party/tcmalloc/vendor/src/windows/get_mangled_names.cc
    • third_party/tcmalloc/vendor/src/windows/google/tcmalloc.h
    • third_party/tcmalloc/vendor/src/windows/gperftools/tcmalloc.h
    • third_party/tcmalloc/vendor/src/windows/gperftools/tcmalloc.h.in
    • third_party/tcmalloc/vendor/src/windows/ia32_modrm_map.cc
    • third_party/tcmalloc/vendor/src/windows/ia32_opcode_map.cc
    • third_party/tcmalloc/vendor/src/windows/mingw.h
    • third_party/tcmalloc/vendor/src/windows/mini_disassembler.cc
    • third_party/tcmalloc/vendor/src/windows/mini_disassembler.h
    • third_party/tcmalloc/vendor/src/windows/mini_disassembler_types.h
    • third_party/tcmalloc/vendor/src/windows/nm-pdb.c
    • third_party/tcmalloc/vendor/src/windows/override_functions.cc
    • third_party/tcmalloc/vendor/src/windows/patch_functions.cc
    • third_party/tcmalloc/vendor/src/windows/port.cc
    • third_party/tcmalloc/vendor/src/windows/port.h
    • third_party/tcmalloc/vendor/src/windows/preamble_patcher.cc
    • third_party/tcmalloc/vendor/src/windows/preamble_patcher.h
    • third_party/tcmalloc/vendor/src/windows/preamble_patcher_test.cc
    • third_party/tcmalloc/vendor/src/windows/preamble_patcher_with_stub.cc
    • third_party/tcmalloc/vendor/src/windows/shortproc.asm
    • third_party/tcmalloc/vendor/vsprojects/addr2line-pdb/addr2line-pdb.vcproj
    • third_party/tcmalloc/vendor/vsprojects/addressmap_unittest/addressmap_unittest.vcproj
    • third_party/tcmalloc/vendor/vsprojects/frag_unittest/frag_unittest.vcproj
    • third_party/tcmalloc/vendor/vsprojects/libtcmalloc_minimal/libtcmalloc_minimal.vcproj
    • third_party/tcmalloc/vendor/vsprojects/low_level_alloc_unittest/low_level_alloc_unittest.vcproj
    • third_party/tcmalloc/vendor/vsprojects/malloc_extension_test/malloc_extension_test.vcproj
    • third_party/tcmalloc/vendor/vsprojects/markidle_unittest/markidle_unittest.vcproj
    • third_party/tcmalloc/vendor/vsprojects/nm-pdb/nm-pdb.vcproj
    • third_party/tcmalloc/vendor/vsprojects/packed-cache_test/packed-cache_test.vcproj
    • third_party/tcmalloc/vendor/vsprojects/page_heap_test/page_heap_test.vcproj
    • third_party/tcmalloc/vendor/vsprojects/pagemap_unittest/pagemap_unittest.vcproj
    • third_party/tcmalloc/vendor/vsprojects/realloc_unittest/realloc_unittest.vcproj
    • third_party/tcmalloc/vendor/vsprojects/sampler_test/sampler_test.vcproj
    • third_party/tcmalloc/vendor/vsprojects/stack_trace_table_test/stack_trace_table_test.vcproj
    • third_party/tcmalloc/vendor/vsprojects/tcmalloc_minimal_large/tcmalloc_minimal_large_unittest.vcproj
    • third_party/tcmalloc/vendor/vsprojects/tcmalloc_minimal_unittest/tcmalloc_minimal_unittest.vcproj
    • third_party/tcmalloc/vendor/vsprojects/thread_dealloc_unittest/thread_dealloc_unittest.vcproj
    • third_party/tcmalloc/vendor/vsprojects/tmu-static/tmu-static.vcproj
  38. Fix format string without passing in the variables in code

    Changed by Amos Lim - eui-sang.limohnoyoudont@samsung.com
    Changed at Thursday, 12-Jul-18 14:58:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 68c461c15c28ffe895f01e0f9a106564b10c5101

    Comments

    Fix format string without passing in the variables in code
    
    Fix 'OrphanedFormatString' and upgrade it to errorprone error
    to prevent future regressions.
    
    Bug: 834796
    Change-Id: Iff82021736367190cfd45b64ee7134cb40392449
    Reviewed-on: https://chromium-review.googlesource.com/1134828
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
    Cr-Commit-Position: refs/heads/master@{#574560}

    Changed files

    • base/test/android/javatests/src/org/chromium/base/test/params/ParameterizedRunner.java
    • build/android/gyp/javac.py