Builder Linux Chromium OS ASan LSan Builder Build 43116

Results:

Success

Trigger Info:

Project	chromium
Revision	5806d65535351c927454bb79ce4bc1030af0d30b
Got Revision	5806d65535351c927454bb79ce4bc1030af0d30b

Execution:

• Source: Task 428dd7c599473710
• Bot: swarm2377-c4
• Recipe: chromium

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 553 ms ) setup_build

   running recipe: "chromium"
   • stdout
   • run_recipe
2. ( 907 ms ) report builders

    

   running builder 'Linux Chromium OS ASan LSan Builder' on master 'chromium.memory'
   • stdout
   • bots.json
3. ( 3 mins 3 secs ) bot_update

   [160GB/492GB used (32%)]
   • stdout
   • json.output
4. ( 312 ms ) ensure_goma
   • - no logs -
   1. ( 312 ms ) ensure_installed
      • stdout
      • json.output
5. ( 2 secs ) swarming.py --version

   0.14
   • stdout
6. ( 35 secs ) gclient runhooks
   • stdout
7. ( 3 secs ) get compile targets for scripts
   • stdout
   • json.output
8. ( 1 secs ) read test spec (chromium.memory.json)

   path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.memory.json
   • stdout
   • json.output
9. ( 1 secs ) clean isolated files
   • stdout
10. ( 758 ms ) lookup GN args

     

    dcheck_always_on = true

    is_asan = true

    is_component_build = false

    is_debug = false

    is_lsan = true

    strip_absolute_paths_from_debug_symbols = true

    symbol_level = 1

    target_os = "chromeos"

    use_goma = true

    goma_dir = "/b/swarming/w/ir/cache/goma/client"
    • stdout
11. ( 1 mins 11 secs ) generate_build_files
    • stdout
    • swarming-targets-file.txt
12. ( 958 ms ) clang_revision
    • stdout
    • json.output
13. ( 16 secs ) preprocess_for_goma
    • - no logs -
    1. ( 676 ms ) goma cache directory
       • stdout
    2. ( 14 secs ) start_goma
       • stdout
       • cloudtail
    3. ( 1 secs ) start cloudtail
       • stdout
14. ( 54 mins 39 secs ) compile
    • stdout
15. ( 2 mins 15 secs ) compile confirm no-op
    • stdout
16. ( 33 secs ) postprocess_for_goma
    • - no logs -
    1. ( 4 secs ) goma_jsonstatus
       • stdout
       • json.output
    2. ( 747 ms ) goma_stat
       • stdout
    3. ( 759 ms ) stop_goma
       • stdout
    4. ( 24 secs ) upload_log
       • stdout
       • json.output
       • compiler_proxy_log
       • ninja_log
    5. ( 2 secs ) stop cloudtail
       • stdout
17. ( 16 mins 18 secs ) isolate tests
    • stdout
    • json.output
18. ( 1 secs ) trigger
    • stdout
19. ( 0 ) recipe result
    • result

Build Properties:

Name	Value	Source
$build/goma	{"jobs": 500}	setup_build
$recipe_engine/path	{"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"swarm2377-c4"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548151567690594, "id": "8923639137715775312", "project": "chromium", "tags": ["builder:Linux Chromium OS ASan LSan Builder", "buildset:commit/git/5806d65535351c927454bb79ce4bc1030af0d30b", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/5806d65535351c927454bb79ce4bc1030af0d30b", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089069199887388944", "scheduler_job_id:chromium/Linux Chromium OS ASan LSan Builder", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"Linux Chromium OS ASan LSan Builder"	setup_build
buildnumber	43116	setup_build
mastername	"chromium.memory"	setup_build
path_config	"generic"	setup_build
recipe	"chromium"	setup_build
repository	"https://chromium.googlesource.com/chromium/src.git"	setup_build
revision	"5806d65535351c927454bb79ce4bc1030af0d30b"	setup_build
got_angle_revision	"c81e7bfeb5580726f995776ed04fc4517d6d9c27"	bot_update
got_buildtools_revision	"2f02e1f363b1af2715536f38e239853f04ec1497"	bot_update
got_dawn_revision	"c0f31e73e481f32d308cb6232e75e6d860d97063"	bot_update
got_nacl_revision	"ff15c51d20785fa51c0ef03ccb480b87299acbeb"	bot_update
got_revision	"5806d65535351c927454bb79ce4bc1030af0d30b"	bot_update
got_revision_cp	"refs/heads/master@{#624752}"	bot_update
got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	bot_update
got_v8_revision	"7b7a1521956e0f499a6b0170e3a421c109a2288e"	bot_update
got_v8_revision_cp	"refs/heads/7.3.471@{#1}"	bot_update
got_webrtc_revision	"74ba99062c48b278675cfe52643719202296fddc"	bot_update
got_webrtc_revision_cp	"refs/heads/master@{#26298}"	bot_update
got_clang_revision	"351477-1"	clang_revision
isolate_server	"https://isolateserver.appspot.com"	isolate tests
swarm_hashes_refs/heads/master(at){#624752}_without_patch	{"accessibility_unittests": "5c97190ec1609de16c5af5114a59e157ed147dbc", "angle_unittests": "8df0fd45bd38e4eb41b2cbba95f6e8a22b19ae70", "app_list_unittests": "2011a844dd2fced849b74ec829285d1074126544", "app_shell_unittests": "011c4d5cdf7904a42a331cbad6fe54f0e0c88d76", "ash_unittests": "bbc348efc6814fa7f0a71305f0bcd6e2bb2d5f1d", "aura_unittests": "2964f0f58e3df008b4a959077d5d9657a61ed230", "base_unittests": "17a226f13c7855b67c4b7c81c4686bc6d760225a", "blink_common_unittests": "044959c69fe507f08438af6db448438a3c2f57d4", "blink_fuzzer_unittests": "80f4330c58090b1fcaf2a28ae8c4deee66dc89f8", "blink_heap_unittests": "a29c8157a3de777feaf6b69cad2207ba6e0efa82", "blink_platform_unittests": "325271e7e062d46ec18d010f84b4235d01cc4520", "boringssl_crypto_tests": "a370f49e5b91ee07c572e28bd0a1a251bf4a24a7", "boringssl_ssl_tests": "1021291eb8a78518c48a7ba6592c1d1e62ca337c", "browser_tests": "c8449c79d9ae50d103e249c25092c7a9e8fee0bd", "cacheinvalidation_unittests": "77f641f107d1b428e9716ec3952142aaf09872e8", "capture_unittests": "b41adee8a2f6973ad7ea385f91fd9684cdaaae32", "cast_unittests": "55c9313b9232633f04999f8c5dc474bac6b1d06d", "cc_unittests": "36fdfaba188ad63d0d8afa2458bf2ce452aa779d", "chrome_app_unittests": "77d8df3e7a91093e654d1452e9966776ff777c5d", "chromedriver_unittests": "56c13d6610478a57733e03cd185ec982e64dbfb7", "chromeos_components_unittests": "aa651b5dfe1d03ba2cb1df60e158c55f3687f747", "chromeos_unittests": "e94bb4252dbc1fbf137a1d9b20cae19c26894515", "components_browsertests": "5daf5e88b8b7fcb0de3144b5bb626ce1535864a7", "components_unittests": "d2f525ec83c3e83c87025a7e2c92bee6731e7932", "compositor_unittests": "51212695e0ae8a13248b64b205247db0409ce72a", "content_browsertests": "11510369299fc2bb39db564f3c8a88f1ac68257f", "content_unittests": "24a97cf9f77049a8e47440bd694d2fa09319354a", "crypto_unittests": "841b68db8e26e71bdf8343c8183e2fc2fcff1249", "dbus_unittests": "a4daf62d76c590677d99536d6c10f6e8820c2f00", "device_unittests": "516fa5e912917a5b7de83422e37087e93c255231", "display_unittests": "29f45a1e56798dde1031fcae4da0128f5f6f974f", "events_unittests": "f5b2a3aa5ae853da49cf112047496ee6a2425000", "exo_unittests": "8025a36462538f976ca7dfa1eaae50f62fa8a20e", "extensions_browsertests": "ae755b914886697bced619d2cab97070f390ca87", "extensions_unittests": "62af2318488678c94a3876f5561e0a8af37ff294", "filesystem_service_unittests": "5b517668377c806b647be28203a8e77c104c7a15", "gcm_unit_tests": "a2e80176a3e181139a06d11f25b68b7b613ee0aa", "gfx_unittests": "75d3b06a3c96e8a8a1b9af5d74b1907a1aa77b8a", "gl_unittests_ozone": "6f92ed15993bced35f5afeddff3b26a5bb5eb1e8", "google_apis_unittests": "fdacd0c7e5a0dd8784df1c28a98b9cb2c76f17eb", "gpu_unittests": "cb3cd1ba2fb8d5b473ccd2c0760bd7096186ba70", "interactive_ui_tests": "41fe9d7779b7b3f911f660dd42387328b5ac3aad", "ipc_tests": "714e5e5af0038e7adaf8ccb5d82aba31304bfcde", "jingle_unittests": "f7855a9c475988a88782a490efe6a271d1a0dd3b", "keyboard_unittests": "0a3fe28d33fa6ebdbaca77eb78cba406ee3ae8df", "latency_unittests": "9a2e302f7b8292e5b98878e50764304b5306d97b", "leveldb_service_unittests": "c8721168b76621d9b2d34cf9efa9d1ae6a9907a3", "libjingle_xmpp_unittests": "9dc62d47873f2a4da3bc4ce2dea20d537d00cca3", "media_blink_unittests": "f8a1a7bd11223c896ce3b6280fcbe6a2b7822040", "media_service_unittests": "423b6896548d5de15965f717396b6edf6442e735", "media_unittests": "8ec32eff35722846fead1ce2485764c4c74f19a1", "message_center_unittests": "eb012d49d7f6a5f84413ff3806f4fff47e37e561", "midi_unittests": "2e2d7961bdc300a982a4ab2398b3e777e7791306", "mojo_core_unittests": "8b21bf19a818340c2493320c56e037aceb59e519", "mojo_unittests": "d32f25b8d337175a6b27d074e4ba3b9c1d4d83c4", "nacl_helper_nonsfi_unittests": "044c9e7546312d0acece514232ea105b60878d4f", "nacl_loader_unittests": "4dc10fc591bd594ee1d17313ed3a834fcfaa9007", "native_theme_unittests": "f0e91295f20a57ae3122cf72067585df70947520", "net_unittests": "3b415cce2a00d2646aa4c565d1622b5f94c612cd", "ozone_gl_unittests": "d70b9a5c1498ac0ee846a92eb867d0a2b388bd36", "ozone_unittests": "4e3b3dfeedbf34b6545cea4d4d086acf72849dd3", "ozone_x11_unittests": "96707de1b50d2f05eb01a70726b904583e097542", "pdf_unittests": "a1efc8eefedc99ff811df5064d7bea34aeba6792", "ppapi_unittests": "e1c18a095bc8984d2f8f776bfb7cd4626e6887b8", "printing_unittests": "764abf2693a5dbeb02f8bdd328e4952313253dfd", "remoting_unittests": "1b9d3a22c0dc380fdd62aaaea44dcbff01291abe", "sandbox_linux_unittests": "ecc2c91ae7a583ed100005fc16aa426fd828b38d", "service_manager_unittests": "cff99775871bebca641bb1f24eb0dae61993ede7", "services_unittests": "144641a9825b1a102391de35ff7fcb2376d8d0d6", "shell_dialogs_unittests": "11a56f638b78ce9d9f9a1ba1b96dee680dc17c05", "skia_unittests": "aa66547033eb3523e7b35b476e488b44fe10a71b", "snapshot_unittests": "a4b69d14419496dc868418868788bffff0908c19", "sql_unittests": "8379aa19921807a48399888afca19ef948a3c4b4", "storage_unittests": "02c3c1d35358565fe66bc68b009f834513ce08e2", "sync_integration_tests": "10e5090a5b4654712e77a088bb938489e7a71abd", "traffic_annotation_auditor_unittests": "3639423a4707b6a7f23781c59d61b96644eec40b", "ui_base_unittests": "cc46637eac2e89d718b96b00e9bf9791ac982926", "ui_chromeos_unittests": "e46c2f6555e873d4460166befe7e20b95a6b719d", "ui_touch_selection_unittests": "fb07e5663c792b4c9f12d22254fcb449d5d4cba0", "unit_tests": "59999c7f49f43d8c292dc6825a4e41b5401c8540", "url_unittests": "7286a584072ac8e31f4d9f2b7837b3c4afecfe1e", "views_unittests": "415c96e23e37eb2ebaa667b70c37bdc06924787f", "viz_unittests": "5e6c6cbe3efa6f74716d42c51a4ac2deafca2322", "wayland_client_perftests": "e8af786fd3820e9ad719583a44076dabd9494834", "webkit_unit_tests": "67d7f8a8971c1ffff151c3fd6b608b762dfdb861", "wm_unittests": "6c1cc72e09a573b901494c6be54d5b571f89e91e", "wtf_unittests": "02f6852186b0d4ceefe7e5aa251a90b4721a039a"}	isolate tests

Blamelist:

1. A Olsen (olsenohnoyoudont@chromium.org)
2. Tanja Gornak (melandoryohnoyoudont@chromium.org)
3. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
4. Stephane Zermatten (szermattohnoyoudont@chromium.org)
5. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
6. Mohamed Amir Yosef (mamirohnoyoudont@chromium.org)
7. Lowell Manners (lowellohnoyoudont@chromium.org)

Timing:

Create	Tuesday, 22-Jan-19 10:06:07 UTC
Start	Tuesday, 22-Jan-19 10:06:12 UTC
End	Tuesday, 22-Jan-19 11:28:29 UTC
Pending	4 secs
Execution	1 hrs 22 mins

All Changes:

1. Wire up StatsReportingController, don't use CrosSettings::Set

   Changed by	A Olsen - olsenohnoyoudont@chromium.org
   Changed at	Tuesday, 22-Jan-19 09:58:20 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	5806d65535351c927454bb79ce4bc1030af0d30b

   Comments

   Wire up StatsReportingController, don't use CrosSettings::Set
   
   StatsReportingController is used instead of CrosSettings::Set.
   CrosSettings::Set is discouraged due to mostly-unneeded complexity,
   and the way it always gives the callers owner-like privileges -
   see the bug.
   
   This is the last use of CrosSettings::Set. After this change,
   CrosSettings::Set and DeviceSettingsProvider::Set can be removed.
   Hopefully, this will mean CrosSettings and DeviceSettingsProvider
   have less dependencies, which is why I am doing this.
   
   StatsReportingController needs to be called when ownership is
   taken. The existing code which handles this scenario is in
   DeviceSettingsProvider, so the call to OnOwnershipTaken is made
   from there. Because StatsReportingController is taking over
   some of DeviceSettingsProviders functionality, it now makes
   less sense for the existing code to be there - but this, along
   with the new call, can be moved in a later CL.
   
   Bug: 433840
   Change-Id: I5ae99235e2f746f464b61dfdc13dd0d650bde6bb
   Reviewed-on: https://chromium-review.googlesource.com/c/1402765
   Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
   Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
   Reviewed-by: Dominic Battré <battre@chromium.org>
   Reviewed-by: Jochen Eisinger <jochen@chromium.org>
   Reviewed-by: Mattias Nissler <mnissler@chromium.org>
   Reviewed-by: Lutz Justen <ljusten@chromium.org>
   Commit-Queue: A Olsen <olsen@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624752}

   Changed files

   • chrome/browser/chrome_browser_main.cc
   • chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc
   • chrome/browser/chromeos/arc/intent_helper/arc_settings_service_unittest.cc
   • chrome/browser/chromeos/arc/optin/arc_optin_preference_handler.cc
   • chrome/browser/chromeos/arc/optin/arc_optin_preference_handler.h
   • chrome/browser/chromeos/arc/optin/arc_terms_of_service_default_negotiator_unittest.cc
   • chrome/browser/chromeos/login/wizard_controller.cc
   • chrome/browser/chromeos/settings/cros_settings.h
   • chrome/browser/chromeos/settings/device_settings_provider.cc
   • chrome/browser/chromeos/settings/stats_reporting_controller.cc
   • chrome/browser/chromeos/settings/stats_reporting_controller.h
   • chrome/browser/chromeos/settings/stats_reporting_controller_unittest.cc
   • chrome/browser/metrics/chrome_metrics_services_manager_client.cc
   • chrome/browser/metrics/chrome_metrics_services_manager_client.h
   • chrome/browser/prefs/browser_prefs.cc

2. [Tango->FCM] Add unittests, which verify that failed subscription requests are retried

   Changed by	Tanja Gornak - melandoryohnoyoudont@chromium.org
   Changed at	Tuesday, 22-Jan-19 09:56:00 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	f02a2b780c207e538eadda309f79de0b36db9f70

   Comments

   [Tango->FCM] Add unittests, which verify that failed subscription requests are retried
   
   When the subscription request has failed, PerUserTopicRegistrationManager re-schedules
   it. This CL adds unittests to verify that the request is rescheduled.
   
   Bug: 801985, 878446
   Change-Id: I98e5f34c7b83902a7bb5f63089a7405e81db5e8d
   Reviewed-on: https://chromium-review.googlesource.com/c/1424841
   Commit-Queue: Tatiana Gornak <melandory@chromium.org>
   Reviewed-by: Mikel Astiz <mastiz@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624751}

   Changed files

   • components/invalidation/impl/per_user_topic_registration_manager.h
   • components/invalidation/impl/per_user_topic_registration_manager_unittest.cc

3. [Unity][Android] Add UnifiedConsentServiceBridge.enableGoogleServices

   Changed by	Boris Sazonov - bsazonovohnoyoudont@chromium.org
   Changed at	Tuesday, 22-Jan-19 09:33:06 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	8c7556d45ab78c56929b2ad915df45fcb051bff1

   Comments

   [Unity][Android] Add UnifiedConsentServiceBridge.enableGoogleServices
   
   This CL adds UnifiedConsentServiceBridge.enableGoogleServices method
   that is invoked from the new sign-in fragments when the user is signing
   in.
   
   Bug: 914056
   Change-Id: I30a43dd6b5983efb19df85f44b611d918ed01211
   Reviewed-on: https://chromium-review.googlesource.com/c/1425720
   Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
   Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624750}

   Changed files

   • chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSignInProcessor.java
   • chrome/android/java/src/org/chromium/chrome/browser/signin/SigninFragment.java
   • chrome/android/java/src/org/chromium/chrome/browser/signin/UnifiedConsentServiceBridge.java
   • chrome/browser/android/signin/unified_consent_service_bridge.cc

4. [Autofill Assistant] Define highlighted area visually, round boxes again.

   Changed by	Stephane Zermatten - szermattohnoyoudont@chromium.org
   Changed at	Tuesday, 22-Jan-19 08:56:56 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	925d03bddd2ee15a2a6f8feae65807fbd69e33ed

   Comments

   [Autofill Assistant] Define highlighted area visually, round boxes again.
   
   Before this change, a highlighted or touchable area was defined as a
   list of elements to highlight.
   
   How well this works depends on how the website is written. Often, there
   is no element that exactly corresponds to the area of the screen we want
   to highlight. Sometimes more than one elements are necessary, which
   looks bad with rounding. Sometimes the elements that are necessary don't
   touch, leaving strange gaps.
   
   With this patch, a highlighted are is defined visually as a rectangle
   containing one or more elements. This allows selecting arbitrary areas
   on the screen that correspond to no single elements, to remove gaps and
   avoid elements that shouldn't be highlighted.
   
   This patch also allows defining a highlighted area as "full width"
   instead of as a box, even though the elements might not cover exactly
   the full width of the screen. This is useful as full-width highlighted
   area are generally preferred.
   
   This patch reverts change
   https://chromium-review.googlesource.com/c/1397625 which removed the
   rounding of the highlighted boxes.
   
   Example 1:
   
   before: https://screenshot.googleplex.com/RsWQbPXKegD.png
   after: https://screenshot.googleplex.com/yaDQHYWywQC.png
   
   Example 2:
   
   before: https://screenshot.googleplex.com/agVH3LUer9j.png
   after: https://screenshot.googleplex.com/u7Zq8pszfzW.png
   
   Bug: 806868
   Change-Id: I1a1e4ad1ec2dba3fe040ebe41fe29a0e18a2df59
   Reviewed-on: https://chromium-review.googlesource.com/c/1409545
   Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
   Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624749}

   Changed files

   • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/TouchEventFilterView.java
   • components/autofill_assistant/browser/actions/action_delegate.h
   • components/autofill_assistant/browser/actions/focus_element_action.cc
   • components/autofill_assistant/browser/actions/mock_action_delegate.h
   • components/autofill_assistant/browser/controller.cc
   • components/autofill_assistant/browser/controller.h
   • components/autofill_assistant/browser/element_area.cc
   • components/autofill_assistant/browser/element_area.h
   • components/autofill_assistant/browser/element_area_unittest.cc
   • components/autofill_assistant/browser/rectf.cc
   • components/autofill_assistant/browser/rectf.h
   • components/autofill_assistant/browser/script_executor.cc
   • components/autofill_assistant/browser/script_executor.h
   • components/autofill_assistant/browser/script_executor_delegate.h
   • components/autofill_assistant/browser/script_executor_unittest.cc
   • components/autofill_assistant/browser/script_tracker_unittest.cc
   • components/autofill_assistant/browser/selector.h
   • components/autofill_assistant/browser/service.proto

5. Roll Fuchsia SDK from 53183916f07c to f248a8d5f71c

   Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
   Changed at	Tuesday, 22-Jan-19 08:49:07 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	54d843d523c1ca828e7427cc9fd1df1b5437a335

   Comments

   Roll Fuchsia SDK from 53183916f07c to f248a8d5f71c
   
   
   The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
   
   Documentation for the AutoRoller is here:
   https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
   
   If the roll is causing failures, please contact the current sheriff, who should
   be CC'd on the roll, and stop the roller if necessary.
   
   
   CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
   TBR=cr-fuchsia+bot@chromium.org
   
   Change-Id: Ic88d03d5369fca2b16c17d0929ba8bd624676536
   Reviewed-on: https://chromium-review.googlesource.com/c/1426073
   Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
   Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
   Cr-Commit-Position: refs/heads/master@{#624748}

   Changed files

   • build/fuchsia/linux.sdk.sha1
   • build/fuchsia/mac.sdk.sha1

6. [Sync::USS] Fix for cache guid mismatch when loading bookmarks

   Changed by	Mohamed Amir Yosef - mamirohnoyoudont@chromium.org
   Changed at	Tuesday, 22-Jan-19 08:45:55 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	7b3df3ef06b31337442e932fc41a3b30e84e3b70

   Comments

   [Sync::USS] Fix for cache guid mismatch when loading bookmarks
   
   Currently, if there is a mistmatch in the cache guid between the persisted
   one and the one coming from sync, the bookmark model will stay in
   the MODEL_STARTING state and effectively block sync machinery.
   
   This patch makes sure that in such case, the BookmarkModelTypeProcessor
   will consider the persisted data corrupted, and start clean.
   
   Bug: 516866,820049, 816723
   Change-Id: I06605b20f3357016d1b2d5a86009ce7abe0b392d
   Reviewed-on: https://chromium-review.googlesource.com/c/1425501
   Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
   Reviewed-by: Mikel Astiz <mastiz@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624747}

   Changed files

   • components/sync_bookmarks/bookmark_model_type_processor.cc

7. Remove an unnecessary usage of FakeGaiaCookieManagerService.

   Changed by	Lowell Manners - lowellohnoyoudont@chromium.org
   Changed at	Tuesday, 22-Jan-19 08:44:15 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	75ac4524813d10892e342ca52e61ae0c96c5b475

   Comments

   Remove an unnecessary usage of FakeGaiaCookieManagerService.
   
   signin_manager_unit_test.cc doesn't set any fake resonses, so it
   doesn't need to use FakeGaiaCookieManagerService.
   
   Bug: 907782
   Change-Id: Ibd19cf1acc02fa23bc3e7de56b84cdca8127910e
   Reviewed-on: https://chromium-review.googlesource.com/c/1402884
   Reviewed-by: Colin Blundell (slow until Jan 24 due to travel) <blundell@chromium.org>
   Commit-Queue: Lowell Manners <lowell@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624746}

   Changed files

   • components/signin/core/browser/signin_manager_unittest.cc