Builder Linux Chromium OS ASan LSan Builder Build 43072

Results:

Success

Trigger Info:

Project	chromium
Revision	5d27338e97f40e4f18941d3f1233f2c5c22696e4
Got Revision	5d27338e97f40e4f18941d3f1233f2c5c22696e4

Execution:

• Source: Task 427ce45e41d4d510
• Bot: swarm2377-c4
• Recipe: chromium

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 553 ms ) setup_build

   running recipe: "chromium"
   • stdout
   • run_recipe
2. ( 1 secs ) report builders

    

   running builder 'Linux Chromium OS ASan LSan Builder' on master 'chromium.memory'
   • stdout
   • bots.json
3. ( 4 mins ) bot_update

   [160GB/492GB used (32%)]
   • stdout
   • json.output
4. ( 240 ms ) ensure_goma
   • - no logs -
   1. ( 240 ms ) ensure_installed
      • stdout
      • json.output
5. ( 2 secs ) swarming.py --version

   0.14
   • stdout
6. ( 41 secs ) gclient runhooks
   • stdout
7. ( 3 secs ) get compile targets for scripts
   • stdout
   • json.output
8. ( 1 secs ) read test spec (chromium.memory.json)

   path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.memory.json
   • stdout
   • json.output
9. ( 1 secs ) clean isolated files
   • stdout
10. ( 834 ms ) lookup GN args

     

    dcheck_always_on = true

    is_asan = true

    is_component_build = false

    is_debug = false

    is_lsan = true

    strip_absolute_paths_from_debug_symbols = true

    symbol_level = 1

    target_os = "chromeos"

    use_goma = true

    goma_dir = "/b/swarming/w/ir/cache/goma/client"
    • stdout
11. ( 1 mins 29 secs ) generate_build_files
    • stdout
    • swarming-targets-file.txt
12. ( 980 ms ) clang_revision
    • stdout
    • json.output
13. ( 24 secs ) preprocess_for_goma
    • - no logs -
    1. ( 701 ms ) goma cache directory
       • stdout
    2. ( 21 secs ) start_goma
       • stdout
       • cloudtail
    3. ( 1 secs ) start cloudtail
       • stdout
14. ( 1 hrs 13 mins ) compile
    • stdout
15. ( 3 mins ) compile confirm no-op
    • stdout
16. ( 38 secs ) postprocess_for_goma
    • - no logs -
    1. ( 4 secs ) goma_jsonstatus
       • stdout
       • json.output
    2. ( 755 ms ) goma_stat
       • stdout
    3. ( 747 ms ) stop_goma
       • stdout
    4. ( 30 secs ) upload_log
       • stdout
       • json.output
       • compiler_proxy_log
       • ninja_log
    5. ( 2 secs ) stop cloudtail
       • stdout
17. ( 16 mins 24 secs ) isolate tests
    • stdout
    • json.output
18. ( 1 secs ) trigger
    • stdout
19. ( 1 ms ) recipe result
    • result

Build Properties:

Name	Value	Source
$build/goma	{"jobs": 500}	setup_build
$recipe_engine/path	{"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"swarm2377-c4"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547867181629377, "id": "8923937338114601952", "project": "chromium", "tags": ["builder:Linux Chromium OS ASan LSan Builder", "buildset:commit/git/5d27338e97f40e4f18941d3f1233f2c5c22696e4", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/5d27338e97f40e4f18941d3f1233f2c5c22696e4", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089367400274718496", "scheduler_job_id:chromium/Linux Chromium OS ASan LSan Builder", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"Linux Chromium OS ASan LSan Builder"	setup_build
buildnumber	43072	setup_build
mastername	"chromium.memory"	setup_build
path_config	"generic"	setup_build
recipe	"chromium"	setup_build
repository	"https://chromium.googlesource.com/chromium/src.git"	setup_build
revision	"5d27338e97f40e4f18941d3f1233f2c5c22696e4"	setup_build
got_angle_revision	"c3abb7f1a250abb03a169947395cf319c7324227"	bot_update
got_buildtools_revision	"2f02e1f363b1af2715536f38e239853f04ec1497"	bot_update
got_dawn_revision	"850c0d9aec6bd3f63cb58ff1838380efc112279a"	bot_update
got_nacl_revision	"ff15c51d20785fa51c0ef03ccb480b87299acbeb"	bot_update
got_revision	"5d27338e97f40e4f18941d3f1233f2c5c22696e4"	bot_update
got_revision_cp	"refs/heads/master@{#624433}"	bot_update
got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	bot_update
got_v8_revision	"2b307850ca7c30cb80e8438e2fdbe9cac81b8d21"	bot_update
got_v8_revision_cp	"refs/heads/7.3.448@{#1}"	bot_update
got_webrtc_revision	"74ba99062c48b278675cfe52643719202296fddc"	bot_update
got_webrtc_revision_cp	"refs/heads/master@{#26298}"	bot_update
got_clang_revision	"351477-1"	clang_revision
isolate_server	"https://isolateserver.appspot.com"	isolate tests
swarm_hashes_refs/heads/master(at){#624433}_without_patch	{"accessibility_unittests": "0e13de354a967ff829c6f497420e2952b0c5ef8d", "angle_unittests": "c2577006fa235ec739014ac9d92615f21943b526", "app_list_unittests": "7edc6c2354dbb3ab01271a9fcc61988a9344483d", "app_shell_unittests": "72d1663550bb4df26ccaf79d69aaa5396e259799", "ash_unittests": "6db39ef04aed0a59eb5a189606bbf454c11a63bc", "aura_unittests": "ed9c704447e6e6970892edbe7642948e8c8abc2d", "base_unittests": "d90383cffc5746697f43aa223e3c3efd859aea54", "blink_common_unittests": "7e5fe7c9c3873e4d761509561c9984ce0b97e9e0", "blink_fuzzer_unittests": "0c0e722986ad16df14e197f776c17808bccbb5f8", "blink_heap_unittests": "5ea6585d7610dc16681e7579c45b7bad48908569", "blink_platform_unittests": "4599f3ebfebee3b13f7435f0cb87037853b1f884", "boringssl_crypto_tests": "4862171410462927d3c6069af8747304cc956b68", "boringssl_ssl_tests": "13983337f0121965629eb27a94d5399287e77676", "browser_tests": "7394fd823f522fe2c314039146a43af7ef525538", "cacheinvalidation_unittests": "0a420732711a8f3ebcd5f293163bd685015a854d", "capture_unittests": "ff8bdd50a9e7aec3c78e6ff6355a8a571cc3b70f", "cast_unittests": "b8b2ec1a2ffe8554a414e50b5b218da14e965eeb", "cc_unittests": "5174c65214e3122557fd9f4b0c2affc45dba9b58", "chrome_app_unittests": "72be12a0d4ab80937240e329028dfe4d1addfbf2", "chromedriver_unittests": "3ac7fa524753efe3a0b908ed28feba8dd27c13e3", "chromeos_components_unittests": "4d7837c99c3e5f54a7687431ea2df1f5be5fa360", "chromeos_unittests": "aa511a0fb46a2d81f3c349c341fdd8e270e84271", "components_browsertests": "9baae1527bd0593e0921d826601e12dbdc7b0790", "components_unittests": "aa540fe8a754c49607ed260e6a7a81b3541ab25d", "compositor_unittests": "3388c11f55aa3e8ba0522dea5ae6a8e5158380d4", "content_browsertests": "3a08d5a32f1ce44bc2993fc5e5d32f9c929634f9", "content_unittests": "01464cfab2856c98d7e08ddd5ecd6fae2c762a65", "crypto_unittests": "3dae2c17aaee1e2d2f4c0de3fa390789a574f0e9", "dbus_unittests": "a79971ee5acbc4a00cb233f3ede2b69a9146253e", "device_unittests": "eeb4b28c875e15de4f683a8613e499534ae1ad54", "display_unittests": "83fbd409971c5bcdaa0cfcbfdbcd3afe92fffa7f", "events_unittests": "0da2b2b2e2aa5850f9fdf74f34516529c2cbb478", "exo_unittests": "d02e212d7ad5f18f59b0181beb7875a8319b081a", "extensions_browsertests": "02efaa9373474d9f57bdd9adf66c9c478e4915dc", "extensions_unittests": "9fec30364051110e742af2d8c603ce5d729ccf0e", "filesystem_service_unittests": "0e145259f0c6f8ba19d530f38c34eacc95c9ca08", "gcm_unit_tests": "d9131a3f1e4bbd8313bdc580350aac55aa73feff", "gfx_unittests": "4a6ae46fd7b210a4ca92517970622849fdd47e62", "gl_unittests_ozone": "8da5b67e2df2b86c993c3c17e3e03127e9171d60", "google_apis_unittests": "2d0542191c560ae5a486204215599c92feba8e01", "gpu_unittests": "48eea0c816406c36245a4d2e3111aa6df914cf69", "interactive_ui_tests": "6b07bb65f7a5fca2b08339ff319e943e51d25a3c", "ipc_tests": "a5cbc364b44a8660871593d2959ec8c5421b7640", "jingle_unittests": "948087d3887c47b1a7de69bc1cde3a605b29a0eb", "keyboard_unittests": "c9fc790801abca1aa57d2249dfd51ee58471abe7", "latency_unittests": "8bc4d1cb680e4bddace63ad4e60a025b71fb134d", "leveldb_service_unittests": "dd86292c87d04219f42a6a35b6f80da91ecfe05b", "libjingle_xmpp_unittests": "af2285a29ec36900c0830d56220191bd4101e7c9", "media_blink_unittests": "0f18314840803c30485f308140a17e8917b6b5f8", "media_service_unittests": "c11df776fb6bc3eedebfed92bb4656cd5e0af79f", "media_unittests": "adfbc3776cb10f11e81ac2202a74cb4baff2c6d4", "message_center_unittests": "c1cb0487b49d2dcdce14b771c1690055d13318bf", "midi_unittests": "401b16a7593a7007706b07ff3c81ecde369b0b92", "mojo_core_unittests": "8cdcadbac6a87b1ded06c5bac9a51b904d54c186", "mojo_unittests": "f224dd1d9544d7b2e690c62a66f1cd164821213d", "nacl_helper_nonsfi_unittests": "23bfd2bc645642bcb625ae2bf0f3440de878bc2b", "nacl_loader_unittests": "330dd5a13c4e6fc5de86b6e26592e2ebdbf0bc0c", "native_theme_unittests": "699f93ba0c8b5292f93f9685a86e114ecb43a2f3", "net_unittests": "d81d821b55077c88a4c68c423e39630c88513910", "ozone_gl_unittests": "85c03c0a683886cb73ff4bb42f9ac840f7b0f0d1", "ozone_unittests": "426b889434a828d7a14e4fb2d9a27f269f1a9ac0", "ozone_x11_unittests": "59bbe3983f8331382bd91fd85d56da0feca24ba9", "pdf_unittests": "db4b5a65b088bd2b71b94514b2dc076a5661f4f9", "ppapi_unittests": "bb5628c3b1f00e0a0d1fada67f770ab6ce3c21f3", "printing_unittests": "854368fe3db2dac2509ce812d7e146cc2eb5fd70", "remoting_unittests": "2d69c5e8487e45b61459cb72052a1d2028245cb1", "sandbox_linux_unittests": "74f9d99b78d44fde561f3d9a22f4ddd07da4bb5a", "service_manager_unittests": "1ee1d6c6da065e445da6218e33bb16f87d2426c9", "services_unittests": "188eee5d35ab03a4e8f766424efb84860be5c337", "shell_dialogs_unittests": "a065ebb2196287d356f8a4e22d296ab214ff5bed", "skia_unittests": "707241cb9c5dceb027375cafe094b69318c4aa85", "snapshot_unittests": "cde5aef38ee1a85670b2186c943eb1ffc6bc5c16", "sql_unittests": "52a6497f139d8e9ca85e98b67c57c725b835b300", "storage_unittests": "3bb462f273bf2e5f9ae785901024e988f0830fd8", "sync_integration_tests": "bcc3ac6fdfe061e3fc67ed1b2c27384475bbe30c", "traffic_annotation_auditor_unittests": "b3268b520d275646492f6809ff6c770ec755075a", "ui_base_unittests": "122e850e40c7075b989cc274fc190c4db57013d0", "ui_chromeos_unittests": "e69869ad6b632fd8fe80c599e1b4560b357d0c85", "ui_touch_selection_unittests": "f1d3882527db1ccc60468df191122a92eeac90d6", "unit_tests": "3b1e097b71b6d4adfdffa57a8b372de6a38e63c9", "url_unittests": "d11b2850fe0e4f38482278f47874773d9f064a59", "views_unittests": "ba03a444fe1aa54132f0854aa4b1b90c0c57f32c", "viz_unittests": "19870c50a66352e9ce4722586751605d90d89bbd", "wayland_client_perftests": "3981d5e0052ed66944ba2e17f0ffe483d6b2d116", "webkit_unit_tests": "10f1d2cd1603f4e5406135173fb5b7ba07d1dd6b", "wm_unittests": "16f17f3aedacddc2b4c7269014595341679fc671", "wtf_unittests": "2db2073809a68ab8f96dbaf3f62e12922d065255"}	isolate tests

Blamelist:

1. Sean Topping (seantoppingohnoyoudont@chromium.org)
2. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
3. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
4. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
5. Dan Beam (dbeamohnoyoudont@chromium.org)
6. Fabrice de Gans-Riberi (fdegansohnoyoudont@chromium.org)
7. jonross (jonrossohnoyoudont@chromium.org)
8. Pavel Feldman (pfeldmanohnoyoudont@chromium.org)
9. Alexey Baskakov (loysoohnoyoudont@chromium.org)
10. Dan Beam (dbeamohnoyoudont@chromium.org)
11. Caleb Rouleau (crouleauohnoyoudont@chromium.org)
12. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
13. Dana Fried (dfriedohnoyoudont@chromium.org)
14. Dan Beam (dbeamohnoyoudont@chromium.org)
15. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
16. Christian Fremerey (chfremerohnoyoudont@chromium.org)
17. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
18. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
19. Xiaohui Chen (xiaohuicohnoyoudont@google.com)
20. shyam (shyamsundarpohnoyoudont@google.com)
21. Christian Fremerey (chfremerohnoyoudont@chromium.org)
22. Hiroshige Hayashizaki (hiroshigeohnoyoudont@chromium.org)
23. Seth Hampson (shampsonohnoyoudont@chromium.org)
24. Hiroshige Hayashizaki (hiroshigeohnoyoudont@chromium.org)
25. Pavel Feldman (pfeldmanohnoyoudont@chromium.org)
26. Dale Curtis (dalecurtisohnoyoudont@chromium.org)
27. Nate Chapin (japhetohnoyoudont@chromium.org)
28. Dan Beam (dbeamohnoyoudont@chromium.org)
29. Findit (findit-for-meohnoyoudont@appspot.gserviceaccount.com)
30. Dan Harrington (harringtondohnoyoudont@chromium.org)
31. Luum Habtemariam (luumohnoyoudont@chromium.org)
32. John Williams (jrwohnoyoudont@google.com)
33. Darwin Huang (huangdarwinohnoyoudont@chromium.org)
34. Ian Wells (iwellsohnoyoudont@chromium.org)
35. Natalie Chouinard (chouinardohnoyoudont@chromium.org)
36. Nikita Podguzov (nikitapodguzovohnoyoudont@chromium.org)
37. CJ DiMeglio (lethalantidoteohnoyoudont@chromium.org)
38. Andrew Grieve (agrieveohnoyoudont@chromium.org)
39. Becky Zhou (huayinzohnoyoudont@chromium.org)
40. Fabrice de Gans-Riberi (fdegansohnoyoudont@chromium.org)
41. Eugene But (eugenebutohnoyoudont@google.com)
42. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
43. Weidong Guo (weidonggohnoyoudont@chromium.org)
44. Alex Moshchuk (alexmosohnoyoudont@chromium.org)
45. Gabriel Charette (gabohnoyoudont@chromium.org)
46. Katie D (katieohnoyoudont@chromium.org)
47. Becca Hughes (beccahughesohnoyoudont@chromium.org)
48. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
49. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
50. Xiaohui Chen (xiaohuicohnoyoudont@google.com)
51. Caleb Rouleau (crouleauohnoyoudont@chromium.org)
52. Caleb Rouleau (crouleauohnoyoudont@chromium.org)
53. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
54. Adam Langley (aglohnoyoudont@chromium.org)
55. Kelvin Jiang (kelvinjiangohnoyoudont@chromium.org)
56. Domenic Denicola (domenicohnoyoudont@chromium.org)
57. Caleb Rouleau (crouleauohnoyoudont@chromium.org)
58. John Z Wu (jzwohnoyoudont@chromium.org)
59. bsheedy (bsheedyohnoyoudont@chromium.org)

Timing:

Create	Saturday, 19-Jan-19 03:06:21 UTC
Start	Saturday, 19-Jan-19 03:06:23 UTC
End	Saturday, 19-Jan-19 04:51:17 UTC
Pending	2 secs
Execution	1 hrs 44 mins

All Changes:

1. Fix potential null dereference in RenderWidgetHostViewChildFrame

   Changed by	Sean Topping - seantoppingohnoyoudont@chromium.org
   Changed at	Saturday, 19-Jan-19 02:58:58 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	5d27338e97f40e4f18941d3f1233f2c5c22696e4

   Comments

   Fix potential null dereference in RenderWidgetHostViewChildFrame
   
   Bug: 768526
   Test: CQ
   Change-Id: I3577558ddd363ac9309ecd630b562120f29385c2
   Reviewed-on: https://chromium-review.googlesource.com/c/1416273
   Commit-Queue: Sean Topping <seantopping@chromium.org>
   Reviewed-by: Kevin McNee <mcnee@chromium.org>
   Reviewed-by: Fady Samuel <fsamuel@chromium.org>
   Reviewed-by: Lucas Gadani <lfg@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624433}

   Changed files

   • content/browser/renderer_host/render_widget_host_view_child_frame.cc

2. Roll src/third_party/depot_tools cf032973e30c..f7971436824d (1 commits)

   Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
   Changed at	Saturday, 19-Jan-19 02:58:01 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	5758d433d22f78d7e73a8ad49318089097352d7c

   Comments

   Roll src/third_party/depot_tools cf032973e30c..f7971436824d (1 commits)
   
   https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cf032973e30c..f7971436824d
   
   
   git log cf032973e30c..f7971436824d --date=short --no-merges --format='%ad %ae %s'
   2019-01-19 qyearsley@chromium.org Update depot_tools README cpplint section
   
   
   Created with:
     gclient setdep -r src/third_party/depot_tools@f7971436824d
   
   The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
   
   Documentation for the AutoRoller is here:
   https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
   
   If the roll is causing failures, please contact the current sheriff, who should
   be CC'd on the roll, and stop the roller if necessary.
   
   
   
   BUG=chromium:923438
   TBR=agable@chromium.org
   
   Change-Id: I9a5035b8df7eec5d7d6e97c40d642f1421ff0a99
   Reviewed-on: https://chromium-review.googlesource.com/c/1423658
   Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
   Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
   Cr-Commit-Position: refs/heads/master@{#624432}

   Changed files

   • DEPS

3. Roll src/third_party/catapult 4ac0b64bb236..fab27dfe460a (1 commits)

   Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
   Changed at	Saturday, 19-Jan-19 02:55:17 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	7e604bb2d9774bf904e0c0a8999f6d5060e0bc75

   Comments

   Roll src/third_party/catapult 4ac0b64bb236..fab27dfe460a (1 commits)
   
   https://chromium.googlesource.com/catapult.git/+log/4ac0b64bb236..fab27dfe460a
   
   
   git log 4ac0b64bb236..fab27dfe460a --date=short --no-merges --format='%ad %ae %s'
   2019-01-18 dtu@chromium.org [pinpoint] Parse isolate hashes from buildbucket.
   
   
   Created with:
     gclient setdep -r src/third_party/catapult@fab27dfe460a
   
   The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
   
   Documentation for the AutoRoller is here:
   https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
   
   If the roll is causing failures, please contact the current sheriff, who should
   be CC'd on the roll, and stop the roller if necessary.
   
   CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
   
   BUG=chromium:868926
   TBR=sullivan@chromium.org
   
   Change-Id: I96f8caa599338d5f9ce029384737fcd881a8fddd
   Reviewed-on: https://chromium-review.googlesource.com/c/1423467
   Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
   Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
   Cr-Commit-Position: refs/heads/master@{#624431}

   Changed files

   • DEPS

4. Update V8 to version 7.3.448.

   Changed by	v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
   Changed at	Saturday, 19-Jan-19 02:51:31 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	7c5914974dda4fa1a270b110edb5505720363199

   Comments

   Update V8 to version 7.3.448.
   
   Summary of changes available at:
   https://chromium.googlesource.com/v8/v8/+log/8f00f090..2b307850
   
   Please follow these instructions for assigning/CC'ing issues:
   https://github.com/v8/v8/wiki/Triaging%20issues
   
   Please close rolling in case of a roll revert:
   https://v8-roll.appspot.com/
   This only works with a Google account.
   
   CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
   
   TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
   
   Change-Id: Ic6e3257a375ba1368b47cca897b16620f3e2e3be
   Reviewed-on: https://chromium-review.googlesource.com/c/1423132
   Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
   Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
   Cr-Commit-Position: refs/heads/master@{#624430}

   Changed files

   • DEPS

5. Remove unnecessary compiled_resources2.gyp file

   Changed by	Dan Beam - dbeamohnoyoudont@chromium.org
   Changed at	Saturday, 19-Jan-19 02:45:05 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	8894ad9b687349d19a742b9583e318993e62c4e2

   Comments

   Remove unnecessary compiled_resources2.gyp file
   
   R=dpapad@chromium.org
   BUG=none
   
   Change-Id: I5825dae24cba073562fa2aa0c3cc5693e5b6865f
   Reviewed-on: https://chromium-review.googlesource.com/c/1423623
   Commit-Queue: Dan Beam <dbeam@chromium.org>
   Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
   Auto-Submit: Dan Beam <dbeam@chromium.org>
   Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624429}

   Changed files

   • ui/webui/resources/cr_elements/cr_input/compiled_resources2.gyp

6. [Fuchsia] Rename //fuchsia/net_http to //fuchsia/http.

   Changed by	Fabrice de Gans-Riberi - fdegansohnoyoudont@chromium.org
   Changed at	Saturday, 19-Jan-19 02:42:25 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	a9022d392155f62245b09af4b1ff7025dc785f0d

   Comments

   [Fuchsia] Rename //fuchsia/net_http to //fuchsia/http.
   
   This makes the directory layout consistent with the name of the
   Fuchsia package it contains. In addition, this CL removes the C++
   namespace in this part of the //fuchsia directory as this code is not
   called from anywhere else. This CL also cleans up the build file,
   using more common target names and setting the proper visibility to
   targets.
   
   TBR=jbudorick@chromium.org
   
   Bug: 922635
   Change-Id: I47f512e1bfb76dfca98261c884f4fec2da11a23d
   Reviewed-on: https://chromium-review.googlesource.com/c/1423087
   Reviewed-by: John Budorick <jbudorick@chromium.org>
   Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
   Reviewed-by: Wez <wez@chromium.org>
   Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624428}

   Changed files

   • BUILD.gn
   • fuchsia/BUILD.gn
   • fuchsia/http/BUILD.gn
   • fuchsia/http/http_service_impl.cc
   • fuchsia/http/http_service_impl.h
   • fuchsia/http/http_service_main.cc
   • fuchsia/http/http_service_unittest.cc
   • fuchsia/http/sandbox_policy
   • fuchsia/http/testdata/redirect-test.html
   • fuchsia/http/testdata/redirect-test.html.mock-http-headers
   • fuchsia/http/testdata/simple.html
   • fuchsia/http/testdata/simple.html.mock-http-headers
   • fuchsia/http/testdata/with-duplicate-headers.html
   • fuchsia/http/testdata/with-duplicate-headers.html.mock-http-headers
   • fuchsia/http/testdata/with-headers.html
   • fuchsia/http/testdata/with-headers.html.mock-http-headers
   • fuchsia/http/url_loader_impl.cc
   • fuchsia/http/url_loader_impl.h
   • testing/buildbot/gn_isolate_map.pyl

7. Stop suppressing two WebGL-related context loss tests on macOS.

   Changed by	jonross - jonrossohnoyoudont@chromium.org
   Changed at	Saturday, 19-Jan-19 02:39:33 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	6d93258fa5f0ff66e72342ca6876c4ee12c36dc7

   Comments

   Stop suppressing two WebGL-related context loss tests on macOS.
   
     ContextLost_WebGLBlockedAfterJSNavigation
     ContextLost_WebGLUnblockedAfterUserInitiatedReload
   
   Were both flaking due to the same root cause. We believe that has now been fixed.
   
   TBR=kbr@chromium.org
   
   Bug: 900948
   Change-Id: I50598872ba8965a047badb69862defebb49fdaee
   Reviewed-on: https://chromium-review.googlesource.com/c/1423114
   Reviewed-by: Jonathan Ross <jonross@chromium.org>
   Commit-Queue: Jonathan Ross <jonross@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624427}

   Changed files

   • content/test/gpu/gpu_tests/context_lost_expectations.py

8. DevTools: brush up the overlay highlight plumbing.

   Changed by	Pavel Feldman - pfeldmanohnoyoudont@chromium.org
   Changed at	Saturday, 19-Jan-19 02:38:14 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	da0aaf703699e2a2e90ebd162cf3b9f53514b483

   Comments

   DevTools: brush up the overlay highlight plumbing.
   
   Change-Id: I116e087daf4bf14ec40f28299841b99190a62f7c
   Reviewed-on: https://chromium-review.googlesource.com/c/1422389
   Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
   Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624426}

   Changed files

   • third_party/blink/renderer/core/inspector/browser_protocol.pdl
   • third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc
   • third_party/blink/renderer/core/inspector/inspector_overlay_agent.h
   • third_party/blink/renderer/devtools/front_end/accessibility/AccessibilityModel.js
   • third_party/blink/renderer/devtools/front_end/elements/DOMLinkifier.js
   • third_party/blink/renderer/devtools/front_end/elements/ElementsTreeOutline.js
   • third_party/blink/renderer/devtools/front_end/elements/StylesSidebarPane.js
   • third_party/blink/renderer/devtools/front_end/screencast/InputModel.js
   • third_party/blink/renderer/devtools/front_end/screencast/ScreencastView.js
   • third_party/blink/renderer/devtools/front_end/sdk/DOMModel.js
   • third_party/blink/renderer/devtools/front_end/sdk/OverlayModel.js

9. Remove TestingProfile::ForceIncognito() API

   Changed by	Alexey Baskakov - loysoohnoyoudont@chromium.org
   Changed at	Saturday, 19-Jan-19 02:31:54 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	f0f9d8f4aba806979df43593b8a957312013f33b

   Comments

   Remove TestingProfile::ForceIncognito() API
   
   Use incognito WebContents created for profile()->GetOffTheRecordProfile()
   which is exactly as in production code.
   
   Bug: 277296
   Change-Id: Ia7fc636fe1d84306adcae3f8e7d6b02e6fccdc4a
   Reviewed-on: https://chromium-review.googlesource.com/c/1419559
   Reviewed-by: Scott Violet <sky@chromium.org>
   Commit-Queue: Alexey Baskakov <loyso@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624425}

   Changed files

   • chrome/browser/extensions/extension_protocols_unittest.cc
   • chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
   • chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc
   • chrome/test/base/testing_profile.cc
   • chrome/test/base/testing_profile.h

10. Dark Mode: use standard loading message color on bookmarks

    Changed by	Dan Beam - dbeamohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 02:26:43 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	4fc1894e95171615e1576c81c3378ab773fccdc5

    Comments

    Dark Mode: use standard loading message color on bookmarks
    
    Screenshots: https://imgur.com/a/dJrfydP (lighter is correct)
    
    R=dpapad@chromium.org
    BUG=883049
    
    Change-Id: Iceacdb75ba7d78a541a2fad29af455fd2a8bc78f
    Reviewed-on: https://chromium-review.googlesource.com/c/1423637
    Commit-Queue: Dan Beam <dbeam@chromium.org>
    Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
    Auto-Submit: Dan Beam <dbeam@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624424}

    Changed files

    • chrome/browser/resources/bookmarks/list.html

11. Format component for webrtc benchmark.

    Changed by	Caleb Rouleau - crouleauohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 02:26:11 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	9d053a3b037b2ccde0871a77666efcbe85769ee1

    Comments

    Format component for webrtc benchmark.
    
    Change-Id: If41eca7e205816cdc1b9d9d38449529c0a19f446
    Reviewed-on: https://chromium-review.googlesource.com/c/1419441
    Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
    Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
    Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624423}

    Changed files

    • tools/perf/benchmark.csv
    • tools/perf/benchmarks/webrtc.py

12. Roll src/third_party/angle 6ae34889cd8a..c3abb7f1a250 (1 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Saturday, 19-Jan-19 02:25:28 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	b16ce663219653a98a1f4e9ecff89cb5ffcc8a3d

    Comments

    Roll src/third_party/angle 6ae34889cd8a..c3abb7f1a250 (1 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/6ae34889cd8a..c3abb7f1a250
    
    
    git log 6ae34889cd8a..c3abb7f1a250 --date=short --no-merges --format='%ad %ae %s'
    2019-01-18 syoussefi@chromium.org Fix MultiDraw shaders when loaded from cache
    
    
    Created with:
      gclient setdep -r src/third_party/angle@c3abb7f1a250
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:890539
    TBR=cwallez@chromium.org
    
    Change-Id: I8fdaff7cebeb6e057eaf837fff4fab708d1ebd79
    Reviewed-on: https://chromium-review.googlesource.com/c/1423468
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#624422}

    Changed files

    • DEPS

13. Windows titlebar color change now correctly propagates to browser.

    Changed by	Dana Fried - dfriedohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 02:17:13 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	fa22e21ff92e227e2ed1dd3e619bb87162c40dcf

    Comments

    Windows titlebar color change now correctly propagates to browser.
    
    We're using the existing ThemeChanged() pathway, which does a little
    extra work (because it's designed to handle Aero <-> Classic
    transitions) so there may be a touch of flicker, but it fixes the nasty
    visual artifacts we were seeing before.
    
    Bug: 880020
    Change-Id: I56945acb9f53b9abe7bd742a9b57fc08899a2c44
    Reviewed-on: https://chromium-review.googlesource.com/c/1410505
    Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Dana Fried <dfried@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624421}

    Changed files

    • chrome/browser/themes/theme_service_win.cc
    • ui/views/win/hwnd_message_handler.cc
    • ui/views/window/non_client_view.cc
    • ui/views/window/non_client_view.h

14. Remove unnecessary third_party/closure_compiler/build/ directory

    Changed by	Dan Beam - dbeamohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 02:14:36 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	979073dea3467eea27c04ca5029f622e9646c16a

    Comments

    Remove unnecessary third_party/closure_compiler/build/ directory
    
    R=dpapad@chromium.org
    BUG=none
    
    Change-Id: I00e58e1b87b0ed7722d53bcca30a8bae6d1afd04
    Reviewed-on: https://chromium-review.googlesource.com/c/1423625
    Auto-Submit: Dan Beam <dbeam@chromium.org>
    Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624420}

    Changed files

    • third_party/closure_compiler/build/__init__.py
    • third_party/closure_compiler/build/outputs.py

15. Roll AFDO from 73.0.3674.0_rc-r1 to 73.0.3676.1_rc-r1

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Saturday, 19-Jan-19 02:13:33 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	a6de377a8cc71796d66f31bc1a6df1f495e0bd51

    Comments

    Roll AFDO from 73.0.3674.0_rc-r1 to 73.0.3676.1_rc-r1
    
    This CL may cause a small binary size increase, roughly proportional
    to how long it's been since our last AFDO profile roll. For larger
    increases (around or exceeding 100KB), please file a bug against
    gbiv@chromium.org. Additional context: https://crbug.com/805539
    
    Please note that, despite rolling to chrome/android, this profile is
    used for both Linux and Android.
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=gbiv@chromium.org
    
    Change-Id: Id5a7171fd2d03d0274f3ccf8d5a40bfcbc19a6a1
    Reviewed-on: https://chromium-review.googlesource.com/c/1423470
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#624419}

    Changed files

    • chrome/android/profiles/newest.txt

16. [Video Capture Service] Multi-client: Add VideoSource implementation

    Changed by	Christian Fremerey - chfremerohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 02:10:06 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	150ac101397f98d805f4b8cd88ec63ec9083ef8a

    Comments

    [Video Capture Service] Multi-client: Add VideoSource implementation
    
    This CL fills interface VideoSource with methods and adds implementation.
    The implementation uses a class BroadcastingReceiver whose task is to
    distribute events to potentially multiple receivers.
    
    Design Doc: https://docs.google.com/document/d/1mYnsZfLBRmbsDpUtfb6C7dzhfw2Kcxg_-uiG_6MnWVQ/edit?usp=sharing
    Test: services_unittests --gtest_filter=MockVideoCaptureDeviceSharedAccessTest.*
    Bug: 783442
    
    Change-Id: Id9f6c497b0787dfba8caa15b085580ba0939f8b1
    Reviewed-on: https://chromium-review.googlesource.com/c/1263355
    Commit-Queue: Christian Fremerey <chfremer@chromium.org>
    Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
    Reviewed-by: Luke Sorenson <lasoren@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624418}

    Changed files

    • services/video_capture/BUILD.gn
    • services/video_capture/broadcasting_receiver.cc
    • services/video_capture/broadcasting_receiver.h
    • services/video_capture/public/cpp/BUILD.gn
    • services/video_capture/public/cpp/mock_push_subscription.cc
    • services/video_capture/public/cpp/mock_push_subscription.h
    • services/video_capture/public/cpp/mock_video_source.cc
    • services/video_capture/public/cpp/mock_video_source.h
    • services/video_capture/public/cpp/mock_video_source_provider.cc
    • services/video_capture/public/cpp/mock_video_source_provider.h
    • services/video_capture/public/mojom/video_source.mojom
    • services/video_capture/push_video_stream_subscription_impl.cc
    • services/video_capture/push_video_stream_subscription_impl.h
    • services/video_capture/test/mock_device_shared_access_unittest.cc
    • services/video_capture/video_source_impl.cc
    • services/video_capture/video_source_impl.h

17. Roll src-internal 574e57a00200..e62be76615a6 (2 commits)

    Changed by	chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at	Saturday, 19-Jan-19 02:07:40 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	03645bf26ca5de85d0fd1d5660ded0ead5fe94c2

    Comments

    Roll src-internal 574e57a00200..e62be76615a6 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/574e57a00200..e62be76615a6
    
    
    Created with:
      gclient setdep -r src-internal@e62be76615a6
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Iec0703835c63a64ba9105ed2d63c7a9b0d1f3cf3
    Reviewed-on: https://chromium-review.googlesource.com/c/1423657
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#624417}

    Changed files

    • DEPS

18. Roll src/third_party/pdfium e404b2965e7e..a49689f3dde6 (2 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Saturday, 19-Jan-19 02:06:19 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	0575e5c60910be899b2d509cde6f92d4bdfa0f52

    Comments

    Roll src/third_party/pdfium e404b2965e7e..a49689f3dde6 (2 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/e404b2965e7e..a49689f3dde6
    
    
    git log e404b2965e7e..a49689f3dde6 --date=short --no-merges --format='%ad %ae %s'
    2019-01-18 tsepez@chromium.org Remove ~4KB worth of unused zeros from cxfa_graphics.cpp.
    2019-01-18 tsepez@chromium.org Tidy xfa/fxgraphics/cxfa_graphics.h
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@a49689f3dde6
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I707a5cea9dc4935eb1f438706da7bc4313202c27
    Reviewed-on: https://chromium-review.googlesource.com/c/1423082
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#624416}

    Changed files

    • DEPS

19. Add hotword settings for device without DSP support

    Changed by	Xiaohui Chen - xiaohuicohnoyoudont@google.com
    Changed at	Saturday, 19-Jan-19 02:05:58 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	8beab436aeb46115a43e1a278b7373a17255b171

    Comments

    Add hotword settings for device without DSP support
    
    Copied from:
    https://chromium-review.googlesource.com/c/chromium/src/+/1401933
    
    TBR=xiyuan@chromium.org
    TBR=sammc@chromium.org
    
    Bug: b/118908917
    Test: Manual Test
    Change-Id: Id420408e239ca4adc50fe9331643dccf98cea202
    Reviewed-on: https://chromium-review.googlesource.com/c/1419505
    Reviewed-by: Yusuke Sato <yusukes@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624415}

    Changed files

    • ash/public/cpp/assistant/assistant_state_base.h
    • ash/public/cpp/assistant/assistant_state_proxy.cc
    • ash/public/cpp/assistant/assistant_state_proxy.h
    • ash/public/cpp/assistant/default_voice_interaction_observer.h
    • ash/public/interfaces/voice_interaction_controller.mojom
    • ash/voice_interaction/voice_interaction_controller.cc
    • ash/voice_interaction/voice_interaction_controller.h
    • ash/voice_interaction/voice_interaction_controller_unittest.cc
    • chrome/app/settings_strings.grdp
    • chrome/browser/chromeos/arc/voice_interaction/fake_voice_interaction_controller.cc
    • chrome/browser/chromeos/arc/voice_interaction/fake_voice_interaction_controller.h
    • chrome/browser/chromeos/arc/voice_interaction/voice_interaction_controller_client.cc
    • chrome/browser/chromeos/arc/voice_interaction/voice_interaction_controller_client.h
    • chrome/browser/extensions/api/settings_private/prefs_util.cc
    • chrome/browser/resources/settings/google_assistant_page/google_assistant_page.html
    • chrome/browser/resources/settings/google_assistant_page/google_assistant_page.js
    • chrome/browser/ui/webui/chromeos/assistant_optin/assistant_optin_utils.cc
    • chrome/browser/ui/webui/chromeos/assistant_optin/assistant_optin_utils.h
    • chrome/browser/ui/webui/settings/chromeos/google_assistant_handler.cc
    • chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
    • chromeos/services/assistant/BUILD.gn
    • chromeos/services/assistant/service.cc
    • chromeos/services/assistant/service.h
    • components/arc/arc_prefs.cc
    • components/arc/arc_prefs.h

20. [Chromecast] Fix model name for AT N devices.

    Changed by	shyam - shyamsundarpohnoyoudont@google.com
    Changed at	Saturday, 19-Jan-19 02:04:49 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	9f29d27972943b02eb0d38adfc8b634e0b0e3a3b

    Comments

    [Chromecast] Fix model name for AT N devices.
    
    AT N device doesn't implement the ro.oem.* properties and instead rely
    on Build.* properties to set required values like Model name.
    So, modifying the java file to look at the right properties based on
    Android version.
    
    these methods.
    
    Bug: 122964795
    Test: Verified from Logs that the right model name is now returned by
    Change-Id: I278497fa282ffabb0504a5831b68fcc6437ad4b7
    Reviewed-on: https://chromium-review.googlesource.com/c/1420559
    Commit-Queue: Shyamsundar Parthasarathy <shyamsundarp@chromium.org>
    Reviewed-by: Luke Halliwell <halliwell@chromium.org>
    Auto-Submit: Shyamsundar Parthasarathy <shyamsundarp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624414}

    Changed files

    • chromecast/base/cast_sys_info_android_factory.cc
    • chromecast/base/cast_sys_info_android_things.cc
    • chromecast/base/cast_sys_info_android_things.h
    • chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastSysInfoAndroidThings.java

21. [Video Capture Service] Trigger MediaDevices.ondevicechange event when adding/removing virtual devices

    Changed by	Christian Fremerey - chfremerohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 02:01:33 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	8cd2484dd8874fb052efa89d7e1692e86c825cc9

    Comments

    [Video Capture Service] Trigger MediaDevices.ondevicechange event when adding/removing virtual devices
    
    Register class content::ServiceVideoCaptureProvider as a DeviceChangedObserver with the
    video_capture service and have it propagate events when virtual devices are added or
    removed. Since the video_capture service may be started by clients other than the browser
    process, register a ServiceManagerListener to listen for service starts and automatically
    register as DeviceChangedObserver when the service is started.
    
    In order to mitigate raciness of an external client starting the service and adding
    virtual devices vs. the browser process seeing the service start and registering as
    DeviceChangedObserver, ask the service to immediately raise an event if virtual devices
    have already been present at time of registration.
    
    Design Doc: https://docs.google.com/document/d/1CW6wslQFvV9FMIMkpyCzh2TcASr7LLXrawAtlgSecg8/edit?usp=sharing
    
    Test: content_browsertests --gtest_filter=*AddingAndRemovingVirtualDeviceTriggersMediaElementOnDeviceChange
    Bug: 885256
    Change-Id: I17c73507061a2313d8f3661344268f733da13920
    Reviewed-on: https://chromium-review.googlesource.com/c/1237379
    Reviewed-by: Ken Rockot <rockot@google.com>
    Reviewed-by: Emircan Uysaler <emircan@chromium.org>
    Reviewed-by: Guido Urdaneta <guidou@chromium.org>
    Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
    Commit-Queue: Christian Fremerey <chfremer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624413}

    Changed files

    • content/browser/BUILD.gn
    • content/browser/renderer_host/media/media_stream_manager.cc
    • content/browser/renderer_host/media/ref_counted_video_capture_factory.cc
    • content/browser/renderer_host/media/ref_counted_video_capture_factory.h
    • content/browser/renderer_host/media/service_video_capture_device_launcher.cc
    • content/browser/renderer_host/media/service_video_capture_device_launcher.h
    • content/browser/renderer_host/media/service_video_capture_device_launcher_unittest.cc
    • content/browser/renderer_host/media/service_video_capture_provider.cc
    • content/browser/renderer_host/media/service_video_capture_provider.h
    • content/browser/renderer_host/media/service_video_capture_provider_unittest.cc
    • content/browser/renderer_host/media/video_capture_factory_delegate.cc
    • content/browser/renderer_host/media/video_capture_factory_delegate.h
    • content/browser/renderer_host/media/virtual_video_capture_devices_changed_observer.cc
    • content/browser/renderer_host/media/virtual_video_capture_devices_changed_observer.h
    • content/browser/webrtc/webrtc_video_capture_service_enumeration_browsertest.cc
    • content/test/BUILD.gn
    • content/test/data/media/video_capture_test.js
    • services/video_capture/device_factory_media_to_mojo_adapter.cc
    • services/video_capture/device_factory_media_to_mojo_adapter.h
    • services/video_capture/public/cpp/mock_device_factory.h
    • services/video_capture/public/mojom/device_factory.mojom
    • services/video_capture/test/device_factory_provider_connectortest.cc
    • services/video_capture/test/device_factory_provider_unittest.cc
    • services/video_capture/virtual_device_enabled_device_factory.cc
    • services/video_capture/virtual_device_enabled_device_factory.h

22. Add generate script for Layered API resource grdp/h files.

    Changed by	Hiroshige Hayashizaki - hiroshigeohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 02:00:31 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	fe53869f430bce36d38c3b946ec07d14d6ed7d81

    Comments

    Add generate script for Layered API resource grdp/h files.
    
    To remove manual editing of .grdp and .h files for each
    LAPI JS file addition/removal, this CL adds a generator
    script that generates these files.
    
    This CL also adds README.md for how to use the generator.
    
    Bug: 829084
    Change-Id: I4faff75d14a63e675ad8c9ce5e5c1ecee5ac94f2
    Reviewed-on: https://chromium-review.googlesource.com/c/1413502
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624412}

    Changed files

    • third_party/blink/renderer/core/script/BUILD.gn
    • third_party/blink/renderer/core/script/generate_lapi_grdp.py
    • third_party/blink/renderer/core/script/layered_api.cc
    • third_party/blink/renderer/core/script/layered_api.h
    • third_party/blink/renderer/core/script/layered_api_resources.h
    • third_party/blink/renderer/core/script/resources/layered_api/README.md
    • third_party/blink/renderer/core/script/resources/layered_api/resources.grdp

23. Adds pre shared key support to RTCQuicTransport.

    Changed by	Seth Hampson - shampsonohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 02:00:27 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	bfadd29f493aa4dc77a9f93ddd4c78db02e01317

    Comments

    Adds pre shared key support to RTCQuicTransport.
    
    This change adds the PSK APIs to the RTCQuicTransport object. This is
    done with a readonly key, connect() and listen() methods. This change
    keeps the C++ objects certificate support with the current APIs, but
    removes these from being exposed in the web idl file. Tests are updated
    by moving web platform tests that involve certificates into C++
    tests.
    
    Bug: 874296
    Change-Id: I58500dca36bfdb6fdb605d540ccbfc49ed6ec878
    Reviewed-on: https://chromium-review.googlesource.com/c/1415839
    Commit-Queue: Seth Hampson <shampson@chromium.org>
    Reviewed-by: Steve Anton <steveanton@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624411}

    Changed files

    • third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_crypto_config_factory_impl.cc
    • third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_crypto_config_factory_impl.h
    • third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory.h
    • third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory_impl.cc
    • third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.cc
    • third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_test.cc
    • third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_host.cc
    • third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_host.h
    • third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_proxy.cc
    • third_party/blink/renderer/modules/peerconnection/adapters/quic_transport_proxy.h
    • third_party/blink/renderer/modules/peerconnection/adapters/web_rtc_cross_thread_copier.h
    • third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.cc
    • third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.h
    • third_party/blink/renderer/modules/peerconnection/rtc_quic_transport.idl
    • third_party/blink/renderer/modules/peerconnection/rtc_quic_transport_test.cc
    • third_party/blink/web_tests/external/wpt/webrtc-quic/RTCQuicTransport-helper.js
    • third_party/blink/web_tests/external/wpt/webrtc-quic/RTCQuicTransport.https.html
    • third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt

24. [WPT] Unify mixed-content and referrer-policy generator scripts

    Changed by	Hiroshige Hayashizaki - hiroshigeohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 01:52:04 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	f3892ea620b65976caaa76e18a0240014b14d1d1

    Comments

    [WPT] Unify mixed-content and referrer-policy generator scripts
    
    To prepare unifying generator mechanisms of mixed-content and
    referrer-policy WPT tests, this CL unifies minor diffs
    between their generator scripts.
    
    A part of this CL applies
    https://chromium-review.googlesource.com/c/chromium/src/+/1389926
    to mixed-content test generators, which is no-op because
    mixed-content tests don't use 'expansion=override' feature.
    
    This CL doesn't affect the generated results and thus
    this CL doesn't contain any changes to generated files.
    
    Bug: 906850
    Change-Id: I1976422799fd1344fbd471a606b174dc69d40eba
    Reviewed-on: https://chromium-review.googlesource.com/c/1410085
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624410}

    Changed files

    • third_party/blink/web_tests/external/wpt/mixed-content/generic/tools/generate.py
    • third_party/blink/web_tests/external/wpt/mixed-content/generic/tools/spec_validator.py
    • third_party/blink/web_tests/external/wpt/referrer-policy/generic/tools/common_paths.py
    • third_party/blink/web_tests/external/wpt/referrer-policy/generic/tools/generate.py
    • third_party/blink/web_tests/external/wpt/referrer-policy/generic/tools/spec_validator.py

25. DevTools: make contrast value in devtools tooltip accessible.

    Changed by	Pavel Feldman - pfeldmanohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 01:51:22 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	1ed5f7f571ed8737b0c46d567ea8490d523c1879

    Comments

    DevTools: make contrast value in devtools tooltip accessible.
    
    Change-Id: I887812c2de36e504d78a07f984e73a002bf0a7f8
    Reviewed-on: https://chromium-review.googlesource.com/c/1422639
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624409}

    Changed files

    • third_party/blink/renderer/core/inspector/InspectorOverlayPage.html

26. Reorder VideoFrameSubmitter methods to align with header. Add docs.

    Changed by	Dale Curtis - dalecurtisohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 01:48:03 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	0e87b4ebbd6fc663a61876c49dcf2b480ed458a6

    Comments

    Reorder VideoFrameSubmitter methods to align with header. Add docs.
    
    No functional changes. Just documentation and reordering of methods
    to comply with the style guide. Also removes a bunch of test only
    methods to the unittest since it has friend class status.
    
    Documents the memory savings from various features within the
    VideoFrameSubmitter which are not clearly understandable.
    
    Introduces a helper method so SubmitEmptyFrame/SubmitFrame can share
    code for creating a viz::CompositorFrame.
    
    BUG=746182
    TEST=passes cq.
    
    Change-Id: I950e1a2220b84c2b71b0d8ae9844ac50f547d67c
    Reviewed-on: https://chromium-review.googlesource.com/c/1419248
    Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
    Reviewed-by: Frank Liberato <liberato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624408}

    Changed files

    • third_party/blink/renderer/platform/graphics/video_frame_submitter.cc
    • third_party/blink/renderer/platform/graphics/video_frame_submitter.h
    • third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc

27. Fix flaky tests caused by async javascript url execution

    Changed by	Nate Chapin - japhetohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 01:47:01 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	418052e6c2658fa90b0ce08e465bd604fa1fe588

    Comments

    Fix flaky tests caused by async javascript url execution
    
    These tests have variable test completion timing now, so enforce it with
    waitUntilDone/notifyDone
    
    Bug: 914587
    Change-Id: I42cde20c6422839ab26bf89adf6bcb9f845d6280
    Reviewed-on: https://chromium-review.googlesource.com/c/1422746
    Commit-Queue: Nate Chapin <japhet@chromium.org>
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Auto-Submit: Nate Chapin <japhet@chromium.org>
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624407}

    Changed files

    • third_party/blink/web_tests/fast/frames/javascript-url-for-deleted-frame.html
    • third_party/blink/web_tests/fast/loader/detach-iframe-while-loading-javascript-url.html

28. Add --replace to rgbify_hex_vars.py so colors aren't duplicated

    Changed by	Dan Beam - dbeamohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 01:46:48 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	1652e4d259f2877d65ca048b2892cdf77060e3b0

    Comments

    Add --replace to rgbify_hex_vars.py so colors aren't duplicated
    
    --replace transforms a --var: #hex; like this:
    
      --google-color: #010203;
    
    To an equivalent -rgb and then uses that equivalent:
    
      --google-color-rgb: 1, 2, 3;  /* #010203 */
      --google-color: rgb(var(--google-color-rgb));
    
    This style is used in shared_vars_css.html and I'm tired of doing this
    by hand.
    
    R=dpapad@chromium.org
    BUG=none
    
    Change-Id: Ibfd8cf71ac03be17faa2418dd3c1d56769f88a89
    Reviewed-on: https://chromium-review.googlesource.com/c/1422500
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624406}

    Changed files

    • third_party/polymer/v1_0/components-chromium/paper-styles/color.html
    • third_party/polymer/v1_0/reproduce.sh
    • third_party/polymer/v1_0/rgbify_hex_vars.py
    • third_party/polymer/v1_0/rgbify_hex_vars_test.py
    • ui/webui/resources/cr_elements/shared_vars_css.html

29. Revert "Portals: Expose portalHost to portal's browsing context"

    Changed by	Findit - findit-for-meohnoyoudont@appspot.gserviceaccount.com
    Changed at	Saturday, 19-Jan-19 01:45:42 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	8c58c5ecce76b7c8458b2a55dd46fff4d086a9ef

    Comments

    Revert "Portals: Expose portalHost to portal's browsing context"
    
    This reverts commit 9d4738420905a6b28407a8282512d8307d413780.
    
    Reason for revert:
    
    Findit (https://goo.gl/kROfz5) identified CL at revision 624316 as the
    culprit for flakes in the build cycles as shown on:
    https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOWQ0NzM4NDIwOTA1YTZiMjg0MDdhODI4MjUxMmQ4MzA3ZDQxMzc4MAw
    
    Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/WebKit%20Linux%20Trusty%20Leak/29014
    
    Sample Failed Step: webkit_layout_tests
    
    Sample Flaky Test: external/wpt/portals/portals-host-exposure.sub.html
    
    Original change's description:
    > Portals: Expose portalHost to portal's browsing context
    > 
    > window.portalHost returns a PortalHost to script running inside the main
    > frame within a portal.
    > 
    > Bug: 914117
    > Change-Id: I26fb4ae9676261bee4446bfbc6ee34b28dc618b1
    > Reviewed-on: https://chromium-review.googlesource.com/c/1399569
    > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Charlie Reis <creis@chromium.org>
    > Reviewed-by: Lucas Gadani <lfg@chromium.org>
    > Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#624316}
    
    Change-Id: I38d4e208daafc8381495a4249c02928757bbdfc8
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 914117, 923610
    Reviewed-on: https://chromium-review.googlesource.com/c/1423660
    Cr-Commit-Position: refs/heads/master@{#624405}

    Changed files

    • content/browser/renderer_host/render_view_host_delegate.cc
    • content/browser/renderer_host/render_view_host_delegate.h
    • content/browser/renderer_host/render_view_host_impl.cc
    • content/browser/web_contents/web_contents_impl.cc
    • content/browser/web_contents/web_contents_impl.h
    • content/common/renderer.mojom
    • content/renderer/render_view_impl.cc
    • third_party/blink/public/web/web_view.h
    • third_party/blink/renderer/core/events/event_target_names.json5
    • third_party/blink/renderer/core/exported/web_view_impl.cc
    • third_party/blink/renderer/core/exported/web_view_impl.h
    • third_party/blink/renderer/core/html/BUILD.gn
    • third_party/blink/renderer/core/html/portal/dom_window_portal_host.cc
    • third_party/blink/renderer/core/html/portal/portal_host.cc
    • third_party/blink/renderer/core/html/portal/portal_host.h
    • third_party/blink/renderer/core/page/page.cc
    • third_party/blink/renderer/core/page/page.h
    • third_party/blink/web_tests/external/wpt/portals/portals-host-exposure.sub.html
    • third_party/blink/web_tests/external/wpt/portals/resources/portal-forward-with-broadcast.sub.html
    • third_party/blink/web_tests/external/wpt/portals/resources/portal-host-cross-origin-navigate.sub.html
    • third_party/blink/web_tests/external/wpt/portals/resources/portal-host-cross-origin.sub.html
    • third_party/blink/web_tests/external/wpt/portals/resources/portal-host.html

30. Auto-fetch: Add in-progress notification and UMA

    Changed by	Dan Harrington - harringtondohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 01:42:51 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	d7e08558e23d5cdd19f236f3d6530f21b7fd8c33

    Comments

    Auto-fetch: Add in-progress notification and UMA
    
    This CL also improves the instrumentation test.
    
    Bug: 883486
    Change-Id: I424fecf2b5b8e3f8c1f9fa7b036ecfa4b96381cf
    Reviewed-on: https://chromium-review.googlesource.com/c/1415770
    Commit-Queue: Dan H <harringtond@google.com>
    Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Reviewed-by: Brian White <bcwhite@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624404}

    Changed files

    • chrome/android/java/AndroidManifest.xml
    • chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java
    • chrome/android/java/src/org/chromium/chrome/browser/offlinepages/AutoFetchNotifier.java
    • chrome/android/java/strings/android_chrome_strings.grd
    • chrome/android/java/strings/android_chrome_strings_grd/IDS_OFFLINE_PAGES_AUTO_FETCH_IN_PROGRESS_NOTIFICATION_TEXT.png.sha1
    • chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageAutoFetchTest.java
    • chrome/browser/offline_pages/android/auto_fetch_notifier.cc
    • chrome/browser/offline_pages/android/auto_fetch_notifier.h
    • chrome/browser/offline_pages/android/offline_page_auto_fetcher_service.cc
    • chrome/browser/offline_pages/android/offline_page_auto_fetcher_service.h
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml

31. Disallow copy/assign for PpdProviderQueueEntry's

    Changed by	Luum Habtemariam - luumohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 01:35:03 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	ac4281c7fe3b67e707ed50e03c792efcd720822c

    Comments

    Disallow copy/assign for PpdProviderQueueEntry's
    
    These QueueEntry's hold base::OnceCallback's so they can't be
    copied/assigned; structs now reflect that.
    
    Bug: chromium:922852
    Test: PpdProvider tests still pass
    Change-Id: I01ebd72df0a441043951b4b77bf9f3b40f686599
    Reviewed-on: https://chromium-review.googlesource.com/c/1417992
    Auto-Submit: Luum Habtemariam <luum@chromium.org>
    Commit-Queue: Sean Kau <skau@chromium.org>
    Reviewed-by: Sean Kau <skau@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624403}

    Changed files

    • chromeos/printing/ppd_provider.cc

32. [Re-land] [Cast MRP] Media commands, media status, and SET_VOLUME.

    Changed by	John Williams - jrwohnoyoudont@google.com
    Changed at	Saturday, 19-Jan-19 01:35:00 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	e955a2481f88f7d146852da11e060839a5a21913

    Comments

    [Re-land] [Cast MRP] Media commands, media status, and SET_VOLUME.
    
    Third attempt.  Previous versions here:
    https://chromium-review.googlesource.com/c/chromium/src/+/1407303
    https://chromium-review.googlesource.com/c/chromium/src/+/1372666
    
    This patch implements media commands sent from the SDK to the receiver,
    as well as media status messages from the receiver to the SDK.
    
    This patch also implements the SET_VOLUME message which sets the system
    level volume and not considered part of media commands.
    
    Bug: 809249
    Change-Id: Icc2f8d618b86ad2c422de3d11fdb1f870453968b
    Reviewed-on: https://chromium-review.googlesource.com/c/1372666
    Commit-Queue: John Williams <jrw@chromium.org>
    Reviewed-by: mark a. foltz <mfoltz@chromium.org>
    Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
    Cr-Original-Original-Commit-Position: refs/heads/master@{#622254}
    Reviewed-on: https://chromium-review.googlesource.com/c/1407303
    Cr-Original-Commit-Position: refs/heads/master@{#622597}
    Reviewed-on: https://chromium-review.googlesource.com/c/1419204
    Cr-Commit-Position: refs/heads/master@{#624402}

    Changed files

    • chrome/browser/media/router/presentation/presentation_media_sinks_observer.cc
    • chrome/browser/media/router/presentation/presentation_service_delegate_impl_unittest.cc
    • chrome/browser/media/router/providers/cast/cast_activity_manager.cc
    • chrome/browser/media/router/providers/cast/cast_activity_manager.h
    • chrome/browser/media/router/providers/cast/cast_activity_manager_unittest.cc
    • chrome/browser/media/router/providers/cast/cast_app_discovery_service.cc
    • chrome/browser/media/router/providers/cast/cast_app_discovery_service_unittest.cc
    • chrome/browser/media/router/providers/cast/cast_internal_message_util.cc
    • chrome/browser/media/router/providers/cast/cast_internal_message_util.h
    • chrome/browser/media/router/providers/cast/cast_internal_message_util_unittest.cc
    • chrome/browser/media/router/providers/cast/cast_session_tracker.cc
    • chrome/browser/media/router/providers/cast/cast_session_tracker.h
    • chrome/browser/media/router/providers/cast/cast_session_tracker_unittest.cc
    • chrome/browser/media/router/test/test_helper.cc
    • chrome/browser/media/router/test/test_helper.h
    • chrome/common/media_router/discovery/media_sink_internal.h
    • chrome/common/media_router/discovery/media_sink_service_base.cc
    • chrome/common/media_router/discovery/media_sink_service_base.h
    • chrome/common/media_router/media_route.cc
    • chrome/common/media_router/media_route.h
    • chrome/common/media_router/media_source.cc
    • chrome/common/media_router/media_source.h
    • components/cast_channel/cast_message_handler.cc
    • components/cast_channel/cast_message_handler.h
    • components/cast_channel/cast_message_handler_unittest.cc
    • components/cast_channel/cast_message_util.cc
    • components/cast_channel/cast_message_util.h
    • components/cast_channel/cast_message_util_unittest.cc
    • components/cast_channel/cast_socket.cc
    • components/cast_channel/cast_socket.h
    • components/cast_channel/cast_test_util.h
    • components/cast_channel/keep_alive_delegate.cc

33. Async Clipboard: Automate writeImage/readImage test

    Changed by	Darwin Huang - huangdarwinohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 01:33:46 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	ff0ddd7f6bfba9f1f1b19c2e3db0819fe49a3ac7

    Comments

    Async Clipboard: Automate writeImage/readImage test
    
    - Automate tests for writeImage/readImage by duplicating
    web_tests/external/wpt/clipboard-apis/async-write-image-read-image-manual.https.html
    to a directory allowing Chrome-specific permissions-helper.js (and fetching via
    http server).
    - Create appropriate README/OWNERS file for new directory.
    - Update web_tests/clipboard/async-clipboard/README.md with new info regarding
    testrunner.
    - Update external/wpt writeImage/readImage test with simplification found
    through this CL.
    - Follow-up work: add `if(testRunner)` to automated tests so that they can be run
    manually.
    
    Bug: 896479
    Change-Id: I8b2b27f6fcc4abc9e11169c196eee1863d80fd82
    Reviewed-on: https://chromium-review.googlesource.com/c/1413023
    Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
    Reviewed-by: Victor Costan <pwnall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624401}

    Changed files

    • third_party/blink/web_tests/clipboard/async-clipboard/README.md
    • third_party/blink/web_tests/external/wpt/clipboard-apis/async-write-image-read-image-manual.https.html
    • third_party/blink/web_tests/http/tests/clipboard/OWNERS
    • third_party/blink/web_tests/http/tests/clipboard/README.md
    • third_party/blink/web_tests/http/tests/clipboard/async-write-image-read-image.html
    • third_party/blink/web_tests/http/tests/clipboard/resources/greenbox.png

34. Move Limitless Prefetching from Features to Preferences

    Changed by	Ian Wells - iwellsohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 01:32:16 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	3c8ecd1fd20a68dcac998170903f56fb3df205d1

    Comments

    Move Limitless Prefetching from Features to Preferences
    
    In preparation for making a "limitless prefetching" checkbox on
    chrome://offline-internals, this change moves the setting from being a
    boolean stored in features to being stored in preferences. It is stored
    as an expiration time so that the setting eventually turns itself off
    if enabled.
    
    Most of the small changes to numerous files have to do with ensuring a
    PrefService* is available where IsLimitlessPrefetchingEnabled() and
    SetLimitlessPrefetchingEnabledInSettings() are called.
    
    Change-Id: I16753ac9bbdcb43349294819e984f1119e80fa16
    Reviewed-on: https://chromium-review.googlesource.com/c/1387960
    Commit-Queue: Ian Wells <iwells@chromium.org>
    Reviewed-by: Dan H <harringtond@google.com>
    Cr-Commit-Position: refs/heads/master@{#624400}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/offline_pages/android/prefetch_test_bridge.cc
    • chrome/browser/offline_pages/prefetch/prefetch_background_task_handler_impl.cc
    • chrome/browser/offline_pages/prefetch/prefetch_service_factory.cc
    • components/offline_pages/core/offline_page_feature.cc
    • components/offline_pages/core/offline_page_feature.h
    • components/offline_pages/core/offline_page_feature_unittest.cc
    • components/offline_pages/core/prefetch/BUILD.gn
    • components/offline_pages/core/prefetch/prefetch_dispatcher_impl.cc
    • components/offline_pages/core/prefetch/prefetch_dispatcher_impl_unittest.cc
    • components/offline_pages/core/prefetch/prefetch_download_flow_unittest.cc
    • components/offline_pages/core/prefetch/prefetch_downloader_impl.cc
    • components/offline_pages/core/prefetch/prefetch_downloader_impl.h
    • components/offline_pages/core/prefetch/prefetch_downloader_impl_unittest.cc
    • components/offline_pages/core/prefetch/prefetch_network_request_factory_impl.cc
    • components/offline_pages/core/prefetch/prefetch_network_request_factory_impl.h
    • components/offline_pages/core/prefetch/prefetch_network_request_factory_impl_unittest.cc
    • components/offline_pages/core/prefetch/prefetch_prefs.cc
    • components/offline_pages/core/prefetch/prefetch_prefs.h
    • components/offline_pages/core/prefetch/prefetch_prefs_unittest.cc
    • components/offline_pages/core/prefetch/prefetch_service_test_taco.cc
    • components/offline_pages/core/prefetch/prefetch_service_test_taco.h
    • components/offline_pages/core/prefetch/tasks/download_archives_task.cc
    • components/offline_pages/core/prefetch/tasks/download_archives_task.h
    • components/offline_pages/core/prefetch/tasks/download_archives_task_unittest.cc
    • components/offline_pages/core/prefetch/tasks/prefetch_task_test_base.cc
    • components/offline_pages/core/prefetch/tasks/prefetch_task_test_base.h
    • components/offline_pages/core/prefetch/test_prefetch_network_request_factory.cc
    • components/offline_pages/core/prefetch/test_prefetch_network_request_factory.h

35. Reland: "[Chromeshine] Persist suspensions to LevelDB."

    Changed by	Natalie Chouinard - chouinardohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 01:29:35 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	1d9dd0aa89c0b30268b2255a9bc1ce20a6e3bc0d

    Comments

    Reland: "[Chromeshine] Persist suspensions to LevelDB."
    
    Implement the Set- and GetAllSuspensions functions for
    UsageStatsDatabase.
    
    Change previously landed and was reverted due to a minor
    refactor in leveldb_proto: crbug/923591. Now fixed.
    
    Bug: 902570
    Change-Id: I67d454f71288df2640fd58a98431109b13ff8b6a
    Reviewed-on: https://chromium-review.googlesource.com/c/1423618
    Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
    Reviewed-by: Patrick Noland <pnoland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624399}

    Changed files

    • chrome/browser/android/usage_stats/usage_stats_database.cc
    • chrome/browser/android/usage_stats/usage_stats_database.h
    • chrome/browser/android/usage_stats/usage_stats_database_unittest.cc
    • chrome/test/BUILD.gn

36. Add path of the file with fetched data in external data policy pipeline.

    Changed by	Nikita Podguzov - nikitapodguzovohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 01:18:42 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	488dbae09969e27209274d8dbaca1fc3716d3b60

    Comments

    Add path of the file with fetched data in external data policy pipeline.
    
    It will be mostly used by CloudExternalDataPolicyObserver::Delegate and DeviceCloudExternalDataPolicyObserver::Delegate, which are the end point of the pipeline.
    This will be used to migrate DeviceWallpaperImage policy from custom downloader to existing pipeline in upcoming CL.
    
    Bug: 814364
    Change-Id: I4f87823cb5495c6c880493a76719b94dfeb8bb99
    Reviewed-on: https://chromium-review.googlesource.com/c/1403128
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com>
    Cr-Commit-Position: refs/heads/master@{#624398}

    Changed files

    • chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
    • chrome/browser/chromeos/login/users/chrome_user_manager_impl.h
    • chrome/browser/chromeos/policy/cloud_external_data_manager_base.cc
    • chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc
    • chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.h
    • chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc
    • chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc
    • chrome/browser/chromeos/policy/cloud_external_data_policy_observer.h
    • chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc
    • chrome/browser/chromeos/policy/cloud_external_data_store.cc
    • chrome/browser/chromeos/policy/cloud_external_data_store.h
    • chrome/browser/chromeos/policy/cloud_external_data_store_unittest.cc
    • chrome/browser/chromeos/policy/device_cloud_external_data_policy_observer.cc
    • chrome/browser/chromeos/policy/device_cloud_external_data_policy_observer.h
    • chrome/browser/chromeos/policy/device_cloud_external_data_policy_observer_browsertest.cc
    • chrome/browser/chromeos/policy/device_local_account_browsertest.cc
    • chrome/browser/chromeos/policy/device_native_printers_handler.cc
    • chrome/browser/chromeos/policy/device_native_printers_handler.h
    • chrome/browser/chromeos/policy/device_native_printers_handler_unittest.cc
    • chrome/browser/chromeos/policy/device_policy_cloud_external_data_manager_browsertest.cc
    • chrome/browser/chromeos/policy/user_cloud_external_data_manager_browsertest.cc
    • components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc
    • components/policy/core/common/cloud/component_cloud_policy_store.cc
    • components/policy/core/common/cloud/resource_cache.cc
    • components/policy/core/common/cloud/resource_cache.h
    • components/policy/core/common/cloud/resource_cache_unittest.cc
    • components/policy/core/common/external_data_fetcher.cc
    • components/policy/core/common/external_data_fetcher.h

37. Updates time values to use aria attributes.

    Changed by	CJ DiMeglio - lethalantidoteohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 01:18:27 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	61348b6f02c3a00699cc39b0a85005fc876fcf7f

    Comments

    Updates time values to use aria attributes.
    
    This CL changes the TimeRemaining and TimeElapsed values to use aria
    attributes directly instead of explicitly creating accessibility nodes.
    
    Bug: 836549
    Change-Id: I7036d9e0a2b8f956f3c88bc9e838e2001830400b
    Reviewed-on: https://chromium-review.googlesource.com/c/1393843
    Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
    Reviewed-by: Tommy Steimel <steimel@chromium.org>
    Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624397}

    Changed files

    • content/app/strings/content_strings.grd
    • content/test/data/accessibility/html/audio-expected-auralinux.txt
    • third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_current_time_display_element.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_element_type.h
    • third_party/blink/renderer/modules/media_controls/elements/media_control_remaining_time_display_element.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_time_display_element.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_time_display_element.h
    • third_party/blink/web_tests/media/controls/accessibility-time-element.html
    • third_party/blink/web_tests/media/media-controls.js

38. ApplicationStatus.java: Don't use WeakReference in getRunningActivities()

    Changed by	Andrew Grieve - agrieveohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 01:12:26 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	178881d667ce9a35e96a4430a6c4bfa0d1bdb1d2

    Comments

    ApplicationStatus.java: Don't use WeakReference in getRunningActivities()
    
    No call sites store the list, so using weak references was just
    making code more complicated.
    
    No behavior change expected.
    
    Change-Id: Idce436f03da25e3d9fbff9b9b9eae48d8b4ca6c6
    Reviewed-on: https://chromium-review.googlesource.com/c/1409711
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Commit-Queue: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624396}

    Changed files

    • base/android/java/src/org/chromium/base/ApplicationStatus.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedAppLifecycle.java
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivitySessionTracker.java
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDispatcher.java
    • chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsService.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistencePolicy.java
    • chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java
    • chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java
    • chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoUtils.java
    • chrome/android/java/src/org/chromium/chrome/browser/init/ChromeLifetimeController.java
    • chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java
    • chrome/android/java/src/org/chromium/chrome/browser/share/ShareActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
    • chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/ActivityDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateTask.java
    • chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistencePolicyTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/document/LauncherActivityTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/multiwindow/MultiWindowTestHelper.java
    • chrome/test/android/javatests/src/org/chromium/chrome/test/util/ActivityUtils.java
    • chrome/test/android/javatests/src/org/chromium/chrome/test/util/ApplicationTestUtils.java

39. Append managed information on the summary of managed preferences

    Changed by	Becky Zhou - huayinzohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 01:09:14 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	cb697491e506cea51a3aaca8726a2152289421f1

    Comments

    Append managed information on the summary of managed preferences
    
    If preferences are managed by organization or parent, we add another
    line to supervised user about the managed information.
    
    Bug: 892765
    Change-Id: I6930bf939dfafc9f7b3be266332e392670550097
    Reviewed-on: https://chromium-review.googlesource.com/c/1418058
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Becky Zhou <huayinz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624395}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/preferences/ManagedPreferencesUtils.java
    • chrome/android/java/strings/android_chrome_strings.grd

40. [Fuchsia] Remove application_config_manager stub implementation.

    Changed by	Fabrice de Gans-Riberi - fdegansohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 01:06:25 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	b28b7027e56f67bfff7fe4cb2dd7d76143513d9d

    Comments

    [Fuchsia] Remove application_config_manager stub implementation.
    
    This was not used anywhere outside of a test target that was not
    run. This CL only keeps the fake implementation used for cast_runner
    tests.
    
    Bug: 922635
    Change-Id: I0b7c71465cd5d6292a765df6a5193c715d7a172a
    Reviewed-on: https://chromium-review.googlesource.com/c/1422868
    Reviewed-by: Wez <wez@chromium.org>
    Commit-Queue: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624394}

    Changed files

    • fuchsia/BUILD.gn
    • fuchsia/app/cast/application_config_manager/application_config_manager.cc
    • fuchsia/app/cast/application_config_manager/application_config_manager.h
    • fuchsia/app/cast/application_config_manager/application_config_manager_unittest.cc
    • fuchsia/app/cast/application_config_manager/main.cc
    • fuchsia/app/cast/application_config_manager/sandbox_policy
    • fuchsia/app/cast/cast_runner_integration_test.cc
    • fuchsia/app/cast/cast_runner_unittest.cc
    • fuchsia/app/cast/fake_application_config_manager.cc
    • fuchsia/app/cast/fake_application_config_manager.h

41. Remove deprecated keys for CRWNavigationItemStorage.

    Changed by	Eugene But - eugenebutohnoyoudont@google.com
    Changed at	Saturday, 19-Jan-19 01:05:21 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	a777a9c86ec21e73d487a90394163b2cb689e4b2

    Comments

    Remove deprecated keys for CRWNavigationItemStorage.
    
    Bug: 696125
    Change-Id: I3e4dbfa65735ea0462f86ea8dfb69e05510a2e9c
    Reviewed-on: https://chromium-review.googlesource.com/c/1416690
    Auto-Submit: Eugene But <eugenebut@chromium.org>
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624393}

    Changed files

    • ios/web/crw_navigation_item_storage.mm
    • ios/web/navigation/crw_navigation_item_storage_unittest.mm
    • ios/web/public/crw_navigation_item_storage.h

42. Roll src/third_party/depot_tools deab113bfb35..cf032973e30c (1 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Saturday, 19-Jan-19 01:05:17 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	066800888ab8dbf7c5698e7b10db1ac2b3a53a6d

    Comments

    Roll src/third_party/depot_tools deab113bfb35..cf032973e30c (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/deab113bfb35..cf032973e30c
    
    
    git log deab113bfb35..cf032973e30c --date=short --no-merges --format='%ad %ae %s'
    2019-01-18 tikuta@chromium.org Deploy git 2.20.1 to prod win depot_tools users
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@cf032973e30c
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:887141
    TBR=agable@chromium.org
    
    Change-Id: I0bdf843c6543d180eb78c6430261194db6112d00
    Reviewed-on: https://chromium-review.googlesource.com/c/1423465
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#624392}

    Changed files

    • DEPS

43. Fix double focus issue in search results page

    Changed by	Weidong Guo - weidonggohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 01:02:42 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	aaee335781975296a269a9324798e5a23b2cdc41

    Comments

    Fix double focus issue in search results page
    
    Changes:
    Remove the first result's highlight when focus is moved from search
    box textfield. (e.g. to close button or last search result).
    
    Bug: 919050
    Test: AppListViewFocusTest.FirstResultSelectedAfterSearchResultsUpdated
    Change-Id: I6a85f04631145bddfa439ee8acbcff417e0b9d42
    Reviewed-on: https://chromium-review.googlesource.com/c/1423350
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: Weidong Guo <weidongg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624391}

    Changed files

    • ash/app_list/views/app_list_main_view.cc
    • ash/app_list/views/app_list_main_view.h
    • ash/app_list/views/app_list_view_unittest.cc
    • ash/app_list/views/search_box_view_unittest.cc
    • ash/components/shortcut_viewer/views/keyboard_shortcut_view.h
    • ui/chromeos/search_box/search_box_view_base.cc
    • ui/chromeos/search_box/search_box_view_delegate.h

44. Add crash keys to debug DidCommit-time renderer kills.

    Changed by	Alex Moshchuk - alexmosohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 01:02:05 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	80523762de4d645ecc5979199547ce33b4c9f438

    Comments

    Add crash keys to debug DidCommit-time renderer kills.
    
    Bug: 923144
    Change-Id: I64d47ca422b044dbdf1e7b3d52744b4dceb1cb52
    Reviewed-on: https://chromium-review.googlesource.com/c/1419578
    Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
    Reviewed-by: Nasko Oskov <nasko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624390}

    Changed files

    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl.h

45. [VideoFrameCompositor] Don't make an explicit but redundant call to Timer::SetTaskRunner()

    Changed by	Gabriel Charette - gabohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 00:57:34 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	2282c04ec121209372e18a87f32d7f439a974a99

    Comments

    [VideoFrameCompositor] Don't make an explicit but redundant call to Timer::SetTaskRunner()
    
    SetTaskRunner() is racy and the API will soon be restricted to same
    thread usage to mock the clock in tests only :
    https://chromium-review.googlesource.com/c/chromium/src/+/1394311
    
    In this case it wasn't used racily (but the upcoming stricter API will
    prevent making this call before Start()'ing the Timer elsewhere). As-is
    this call was redundant as it's the sequence the Timer is *started* on
    which is bound to it (and in this case Reset() is always called from
    |task_runner| so this was already the case).
    
    And VideoFrameCompositor::BackgroundRender()'s check also proves this
    correct.
    
    Bug: 587199, 896990
    Change-Id: Iddd0353ba9ddf587c128ff1b594cd9c15a2d7662
    Reviewed-on: https://chromium-review.googlesource.com/c/1415131
    Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
    Commit-Queue: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624389}

    Changed files

    • media/blink/video_frame_compositor.cc

46. Show the modal dialog when the user enables the image labels setting.

    Changed by	Katie D - katieohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 00:56:10 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	26172e2a841db6f9c9f9466cef1d33b8007feb15

    Comments

    Show the modal dialog when the user enables the image labels setting.
    
    The same modal is used when the user toggles this from the context
    menu as well.
    
    Bug: 905419
    Change-Id: I293a653168c1e1c0bfd6469e40a491662cc7ae9e
    Reviewed-on: https://chromium-review.googlesource.com/c/1413132
    Reviewed-by: Dan Beam <dbeam@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: Katie Dektar <katie@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624388}

    Changed files

    • chrome/browser/renderer_context_menu/accessibility_labels_menu_observer.cc
    • chrome/browser/resources/settings/a11y_page/a11y_page.html
    • chrome/browser/resources/settings/a11y_page/a11y_page.js
    • chrome/browser/ui/webui/settings/accessibility_main_handler.cc
    • chrome/browser/ui/webui/settings/accessibility_main_handler.h

47. [Media Notification] Use source title as the app name

    Changed by	Becca Hughes - beccahughesohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 00:55:58 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	5a281cad0bb2e451e441067ade93a753693caee0

    Comments

    [Media Notification] Use source title as the app name
    
    Use the source title as the app name for the media
    notification.
    
    BUG=893296
    
    Change-Id: Ida8cb2ac5c140c6c5cdee0804294f7cd9f6fc254
    Reviewed-on: https://chromium-review.googlesource.com/c/1335663
    Commit-Queue: Becca Hughes <beccahughes@chromium.org>
    Reviewed-by: Evan Stade <estade@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624387}

    Changed files

    • ash/media/media_notification_view.cc
    • ash/media/media_notification_view_unittest.cc
    • ui/message_center/views/notification_header_view.cc
    • ui/message_center/views/notification_header_view.h

48. Roll src/third_party/skia 7fdaa178fa97..5c7a3ac0e214 (1 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Saturday, 19-Jan-19 00:52:45 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	a4e8a68164525f93799e79846c61c9284dd21c37

    Comments

    Roll src/third_party/skia 7fdaa178fa97..5c7a3ac0e214 (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/7fdaa178fa97..5c7a3ac0e214
    
    
    git log 7fdaa178fa97..5c7a3ac0e214 --date=short --no-merges --format='%ad %ae %s'
    2019-01-18 benjaminwagner@google.com [infra] Update Win2016 image
    
    
    Created with:
      gclient setdep -r src/third_party/skia@5c7a3ac0e214
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=halcanary@chromium.org
    
    Change-Id: I1b36cb9fc2b2e170a4c6caa77e31e2d0befd4c43
    Reviewed-on: https://chromium-review.googlesource.com/c/1423497
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#624386}

    Changed files

    • DEPS

49. Roll src-internal 641f6a4faeab..574e57a00200 (5 commits)

    Changed by	chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at	Saturday, 19-Jan-19 00:41:27 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	fc36572d319711922c3cad8b30fa4653fd51a8c7

    Comments

    Roll src-internal 641f6a4faeab..574e57a00200 (5 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/641f6a4faeab..574e57a00200
    
    
    Created with:
      gclient setdep -r src-internal@574e57a00200
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:913707
    TBR=mmoss@chromium.org
    
    Change-Id: I1ad3c8588853d1bab9b7835a45608a13e2461aa0
    Reviewed-on: https://chromium-review.googlesource.com/c/1422640
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#624385}

    Changed files

    • DEPS

50. assistant: fix potential shutdown crash

    Changed by	Xiaohui Chen - xiaohuicohnoyoudont@google.com
    Changed at	Saturday, 19-Jan-19 00:39:38 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	32e2b0058e90ffb7847c8cf7e38bc7d5e3799b69

    Comments

    assistant: fix potential shutdown crash
    
    |display_connection_| is passed to |assistant_manager_| but during
    destruction their ordering is wrong. Now we make sure |assistant_manager_|
    is destructed first.
    
    Bug: 922211
    Test: locally build and run
    Change-Id: Icb8416848a10e4ec47dcf8ca550a03dd8a89dae4
    Reviewed-on: https://chromium-review.googlesource.com/c/1422703
    Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
    Auto-Submit: Xiaohui Chen <xiaohuic@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624384}

    Changed files

    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h

51. [Benchmarking] Cleanup: delete unused benchmark_sharding_map.json

    Changed by	Caleb Rouleau - crouleauohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 00:39:26 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	184ef227d583f68c92e058c06ff2943ea12eef5b

    Comments

    [Benchmarking] Cleanup: delete unused benchmark_sharding_map.json
    
    Bug: 922674
    Change-Id: I67089790486a3e38cd5cd580316f003f131a51ca
    Reviewed-on: https://chromium-review.googlesource.com/c/1418122
    Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
    Reviewed-by: John Chen <johnchen@chromium.org>
    Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624383}

    Changed files

    • tools/perf/core/benchmark_sharding_map.json

52. [go/perfbot-sheriff] Make flakiness dashboard link better.

    Changed by	Caleb Rouleau - crouleauohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 00:38:20 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	7dd5adc397e4f9181bec63d7a4c5d852121c8bde

    Comments

    [go/perfbot-sheriff] Make flakiness dashboard link better.
    
    Since the most common location for a sheriff to go is to the
    performance_test_suite, we should link to that.
    
    Change-Id: Id5fa479116461b8aafbd65594e3db16c74edfa63
    Reviewed-on: https://chromium-review.googlesource.com/c/1423084
    Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
    Reviewed-by: John Chen <johnchen@chromium.org>
    Commit-Queue: John Chen <johnchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624382}

    Changed files

    • docs/speed/bot_health_sheriffing/how_to_launch_a_functional_bisect.md

53. Roll src/third_party/SPIRV-Tools/src 81fb2649bf2c..d14db341b834 (2 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Saturday, 19-Jan-19 00:37:21 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	9aa21d6c1f3d747061c5c55461fe1316b45e76fd

    Comments

    Roll src/third_party/SPIRV-Tools/src 81fb2649bf2c..d14db341b834 (2 commits)
    
    https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/81fb2649bf2c..d14db341b834
    
    
    git log 81fb2649bf2c..d14db341b834 --date=short --no-merges --format='%ad %ae %s'
    2019-01-18 greg@lunarg.com Invalidate ConstantManager if TypeManager is invalidated... (#2302)
    2019-01-18 stevenperron@google.com Handle extract with no index in VDCE. (#2305)
    
    
    Created with:
      gclient setdep -r src/third_party/SPIRV-Tools/src@d14db341b834
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I28ff1dcc62a5ed21f6c847d6762280214aa3fd8f
    Reviewed-on: https://chromium-review.googlesource.com/c/1423081
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#624381}

    Changed files

    • DEPS

54. Send KeyUpdates after the first post-handshake write.

    Changed by	Adam Langley - aglohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 00:37:10 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	68df3afe5a62b4bb8f7ec57130f4e8e7002867e9

    Comments

    Send KeyUpdates after the first post-handshake write.
    
    This is intended to ensure that KeyUpdate remains viable on the web as
    TLS 1.3 implementations deploy. Without exercise, we risk broken
    implementations becoming established.
    
    In time we probably don't need to have this at 100%, but 100% leads to
    clear behaviour in case there are already broken implementations.
    
    Finch control included in case we need to disable it.
    
    Change-Id: Icb7699ee3f90d65195cd52c813efedd55e67c707
    Reviewed-on: https://chromium-review.googlesource.com/c/1423423
    Reviewed-by: David Benjamin <davidben@chromium.org>
    Commit-Queue: Adam Langley <agl@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624380}

    Changed files

    • net/base/features.cc
    • net/base/features.h
    • net/socket/ssl_client_socket_impl.cc
    • net/socket/ssl_client_socket_impl.h

55. [Extensions] Implement delete functionality for activity log item

    Changed by	Kelvin Jiang - kelvinjiangohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 00:32:07 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	fb4408bf60de5b259b541be3b2507ba93c9d3d33

    Comments

    [Extensions] Implement delete functionality for activity log item
    
    This CL adds functionality to the delete button in an activity log item
    which makes an API call to delete all activities associated with that
    item (by id).
    
    The activity log is then refetched when the delete operation completes
    successfully as an activity log item can be associated with multiple
    activities with different ids, and
    https://chromium-review.googlesource.com/c/chromium/src/+/1399427
    can split an activity into multiple activity log items which share the
    same id. In short, this re-fetching is done for consistency.
    
    Bug: 832354
    Change-Id: I6aac485ae8d0c626699b3669420c9a360b233af6
    Reviewed-on: https://chromium-review.googlesource.com/c/1404409
    Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624379}

    Changed files

    • chrome/browser/resources/md_extensions/BUILD.gn
    • chrome/browser/resources/md_extensions/activity_log.js
    • chrome/browser/resources/md_extensions/activity_log_item.html
    • chrome/browser/resources/md_extensions/activity_log_item.js
    • chrome/browser/resources/md_extensions/service.js
    • chrome/common/extensions/api/activity_log_private.json
    • chrome/test/data/webui/extensions/activity_log_item_test.js
    • chrome/test/data/webui/extensions/activity_log_test.js
    • chrome/test/data/webui/extensions/test_service.js
    • third_party/closure_compiler/externs/activity_log_private.js

56. KV Storage: make keys()/values()/entries() async iterators

    Changed by	Domenic Denicola - domenicohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 00:29:35 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	c0dc3c07acc0ee8161e24e1dbe2a4008908743f8

    Comments

    KV Storage: make keys()/values()/entries() async iterators
    
    Follows https://github.com/WICG/kv-storage/commit/2432509c487b30b1e35a25414a8b51557bfd6380.
    
    Binary-Size: needed to implement the feature. Enabling gzip is tracked in crbug.com/920264.
    Change-Id: If5262a32d42eb1c7abaad4fb2a029ce44e94834e
    Reviewed-on: https://chromium-review.googlesource.com/c/1396453
    Commit-Queue: Domenic Denicola <domenic@chromium.org>
    Reviewed-by: Joshua Bell <jsbell@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624378}

    Changed files

    • third_party/blink/renderer/core/script/layered_api.cc
    • third_party/blink/renderer/core/script/resources/layered_api/kv-storage/.eslintrc.js
    • third_party/blink/renderer/core/script/resources/layered_api/kv-storage/async_iterator.js
    • third_party/blink/renderer/core/script/resources/layered_api/kv-storage/idb_utils.js
    • third_party/blink/renderer/core/script/resources/layered_api/kv-storage/index.js
    • third_party/blink/renderer/core/script/resources/layered_api/resources.grdp
    • third_party/blink/web_tests/external/wpt/kv-storage/api-surface.https.html
    • third_party/blink/web_tests/external/wpt/kv-storage/cause-errors-via-idb.https.html
    • third_party/blink/web_tests/external/wpt/kv-storage/entries.https.html
    • third_party/blink/web_tests/external/wpt/kv-storage/helpers/class-assert.js
    • third_party/blink/web_tests/external/wpt/kv-storage/helpers/equality-asserters.js
    • third_party/blink/web_tests/external/wpt/kv-storage/helpers/kvs-tests.js
    • third_party/blink/web_tests/external/wpt/kv-storage/keys-values-entries.https.html
    • third_party/blink/web_tests/external/wpt/kv-storage/keys.https.html
    • third_party/blink/web_tests/external/wpt/kv-storage/undefined-value.https.html
    • third_party/blink/web_tests/external/wpt/kv-storage/values.https.html

57. Revert "Add a perf test that PingPongs tasks between two threads."

    Changed by	Caleb Rouleau - crouleauohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 00:27:45 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	5a193551625c7b7e535f4ab24fd11a7e0b1a825c

    Comments

    Revert "Add a perf test that PingPongs tasks between two threads."
    
    This reverts commit f95cea1ee97833d805af100c43bbb0317333513c.
    
    Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=923140
    
    BUG=923140
    
    Original change's description:
    > Add a perf test that PingPongs tasks between two threads.
    > 
    > Change-Id: I8b0a3907d9009d50e9b624e1eb299f90bc87a14d
    > Reviewed-on: https://chromium-review.googlesource.com/c/1414898
    > Commit-Queue: Alex Clarke <alexclarke@chromium.org>
    > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    > Reviewed-by: Alexander Timin <altimin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#623643}
    
    TBR=skyostil@chromium.org,alexclarke@chromium.org,altimin@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Change-Id: I5b40c52ce380cd2f882394923da764d74d0936e7
    Reviewed-on: https://chromium-review.googlesource.com/c/1423355
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624377}

    Changed files

    • base/task/sequence_manager/sequence_manager_perftest.cc

58. Add CVC verification UI to ChromeWebView shell app.

    Changed by	John Z Wu - jzwohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 00:23:31 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	85a8aae0b6208c2a76d1a6e6c0c617070d5df010

    Comments

    Add CVC verification UI to ChromeWebView shell app.
    
    CVC verification requires "risk data" which only internal builds
    may provide. Here we only provide a fake implementation.
    
    This will help with testing credit cards from Google Pay.
    
    Change-Id: I91e0b2836990875c3491bfbc8065d1455d5d7601
    Reviewed-on: https://chromium-review.googlesource.com/c/1419303
    Commit-Queue: John Wu <jzw@chromium.org>
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624376}

    Changed files

    • ios/web_view/shell/BUILD.gn
    • ios/web_view/shell/shell_autofill_delegate.m
    • ios/web_view/shell/shell_risk_data_loader.h
    • ios/web_view/shell/shell_risk_data_loader_fake.m

59. Disable gtest to histogram conversion

    Changed by	bsheedy - bsheedyohnoyoudont@chromium.org
    Changed at	Saturday, 19-Jan-19 00:21:34 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	f622e65f3176520f2b3c8a40dd67c14f7f7e603b

    Comments

    Disable gtest to histogram conversion
    
    Disables the automatic conversion from gtest perf test JSON to
    histograms on LUCI builders, as there are issues with data getting
    halved for no obvious reason and the assumption that smaller is better
    not working for some metrics.
    
    Bug: 921342, 923536
    Change-Id: I88b80e9d8d38798c413d46420c16266951861085
    Reviewed-on: https://chromium-review.googlesource.com/c/1409693
    Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624375}

    Changed files

    • tools/perf/process_perf_results.py