Builder Linux Chromium OS ASan LSan Builder Build 43048

Results:

Success

Trigger Info:

Project	chromium
Revision	137817908fc7673303789ed6b0844c75191af46c
Got Revision	137817908fc7673303789ed6b0844c75191af46c

Execution:

• Source: Task 42740b61e5f61410
• Bot: swarm2377-c4
• Recipe: chromium

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 568 ms ) setup_build

   running recipe: "chromium"
   • stdout
   • run_recipe
2. ( 1 secs ) report builders

    

   running builder 'Linux Chromium OS ASan LSan Builder' on master 'chromium.memory'
   • stdout
   • bots.json
3. ( 3 mins 39 secs ) bot_update

   [159GB/492GB used (32%)]
   • stdout
   • json.output
4. ( 325 ms ) ensure_goma
   • - no logs -
   1. ( 325 ms ) ensure_installed
      • stdout
      • json.output
5. ( 2 secs ) swarming.py --version

   0.14
   • stdout
6. ( 36 secs ) gclient runhooks
   • stdout
7. ( 3 secs ) get compile targets for scripts
   • stdout
   • json.output
8. ( 1 secs ) read test spec (chromium.memory.json)

   path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.memory.json
   • stdout
   • json.output
9. ( 1 secs ) clean isolated files
   • stdout
10. ( 761 ms ) lookup GN args

     

    dcheck_always_on = true

    is_asan = true

    is_component_build = false

    is_debug = false

    is_lsan = true

    strip_absolute_paths_from_debug_symbols = true

    symbol_level = 1

    target_os = "chromeos"

    use_goma = true

    goma_dir = "/b/swarming/w/ir/cache/goma/client"
    • stdout
11. ( 1 mins 19 secs ) generate_build_files
    • stdout
    • swarming-targets-file.txt
12. ( 990 ms ) clang_revision
    • stdout
    • json.output
13. ( 20 secs ) preprocess_for_goma
    • - no logs -
    1. ( 700 ms ) goma cache directory
       • stdout
    2. ( 17 secs ) start_goma
       • stdout
       • cloudtail
    3. ( 1 secs ) start cloudtail
       • stdout
14. ( 50 mins 48 secs ) compile
    • stdout
15. ( 2 mins 42 secs ) compile confirm no-op
    • stdout
16. ( 37 secs ) postprocess_for_goma
    • - no logs -
    1. ( 5 secs ) goma_jsonstatus
       • stdout
       • json.output
    2. ( 711 ms ) goma_stat
       • stdout
    3. ( 714 ms ) stop_goma
       • stdout
    4. ( 28 secs ) upload_log
       • stdout
       • json.output
       • compiler_proxy_log
       • ninja_log
    5. ( 2 secs ) stop cloudtail
       • stdout
17. ( 17 mins 41 secs ) isolate tests
    • stdout
    • json.output
18. ( 1 secs ) trigger
    • stdout
19. ( 0 ) recipe result
    • result

Build Properties:

Name	Value	Source
$build/goma	{"jobs": 500}	setup_build
$recipe_engine/path	{"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"swarm2377-c4"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547718743668178, "id": "8924092986597909536", "project": "chromium", "tags": ["builder:Linux Chromium OS ASan LSan Builder", "buildset:commit/git/137817908fc7673303789ed6b0844c75191af46c", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/137817908fc7673303789ed6b0844c75191af46c", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089523048685555280", "scheduler_job_id:chromium/Linux Chromium OS ASan LSan Builder", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"Linux Chromium OS ASan LSan Builder"	setup_build
buildnumber	43048	setup_build
mastername	"chromium.memory"	setup_build
path_config	"generic"	setup_build
recipe	"chromium"	setup_build
repository	"https://chromium.googlesource.com/chromium/src.git"	setup_build
revision	"137817908fc7673303789ed6b0844c75191af46c"	setup_build
got_angle_revision	"94d8a9a445bef9b7978f513f7f8d449696716296"	bot_update
got_buildtools_revision	"40194ab03962d8183b2796fa58a39ec8a9e83a41"	bot_update
got_dawn_revision	"799cddcb83fda2911491fd653023c38a28bba1bd"	bot_update
got_nacl_revision	"ff15c51d20785fa51c0ef03ccb480b87299acbeb"	bot_update
got_revision	"137817908fc7673303789ed6b0844c75191af46c"	bot_update
got_revision_cp	"refs/heads/master@{#623624}"	bot_update
got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	bot_update
got_v8_revision	"626b53addaae93b2d93ce5905d8a754f87cefb0f"	bot_update
got_v8_revision_cp	"refs/heads/7.3.428@{#1}"	bot_update
got_webrtc_revision	"309aafe3513af2c53439cb0ea105a39156547acb"	bot_update
got_webrtc_revision_cp	"refs/heads/master@{#26282}"	bot_update
got_clang_revision	"350768-3"	clang_revision
isolate_server	"https://isolateserver.appspot.com"	isolate tests
swarm_hashes_refs/heads/master(at){#623624}_without_patch	{"accessibility_unittests": "929c4b067434afa865b62881327cf50f5cdca510", "angle_unittests": "81e0adf4da56850d1446f0d6fdfe6ad386c33633", "app_list_unittests": "bb32378598ba63e9259ae68c5310f45831c88ab4", "app_shell_unittests": "32b9b674d3aa1f41c734cecb274d326b322b8227", "ash_unittests": "98d8869168a49b0abb5e58980328be5f471d1ece", "aura_unittests": "1e0aab6176d525bfb2cd005512cf83724906690a", "base_unittests": "00e3e068b2d92e0b56eec246fdf1ee86da788a41", "blink_common_unittests": "6ea332d203cabe66124fa3155820e0ebae8ce0cb", "blink_fuzzer_unittests": "3889fed93aa519914ef2deac28dfcd9a600682da", "blink_heap_unittests": "c4f17a23eb20d2b4152aff4b4ef5304c1c237ab7", "blink_platform_unittests": "07b7dc6be67b639643cf0850968cf0818ffcc0ab", "boringssl_crypto_tests": "a2557cce0e422bd14e9824dc64395a6b33c5cdfa", "boringssl_ssl_tests": "4edd0369e9da6e1fdb45ae1c91f3bb3a2a58f6f8", "browser_tests": "0cda1730e61b7b585b3afb3db93ce8294a9501c4", "cacheinvalidation_unittests": "c58f4470ea471491e3174eb30459b23b90839a99", "capture_unittests": "9bb4ed619f37fdc4c628853088b19b2d825778a5", "cast_unittests": "ee2bbfda481159a90d6c6d68ef1ace12319b48c5", "cc_unittests": "f8fdaf4c735aadecf491002a45ff84390fc0e861", "chrome_app_unittests": "900636bcb0b8004085328e530801759fa5e78cd7", "chromedriver_unittests": "1887e6a30f29021e076993bf326052a47c23a115", "chromeos_components_unittests": "28939d3ff786c734eaff56b89558fadd3692896e", "chromeos_unittests": "8e6b403b08027ca34dd94a2c0b192bdddfff4dd1", "components_browsertests": "d9257bb4b50264ed9e885d673a0e68d3eb6405ce", "components_unittests": "a11c0515218f54cbd40f47176ff6b0e9baebe95d", "compositor_unittests": "a18533ae81dabfe9ec35f7ec0a7be576b83fa7d8", "content_browsertests": "35940a25bf6551ef45580080e8fd0eb11ebaa238", "content_unittests": "33ce7bf5da095e8e900af15aca6a7c65787004d2", "crypto_unittests": "392671e3527e415df476ae2f34dab17694a46d97", "dbus_unittests": "c5dee648314f0ba07751d5a8b76b83dea1f2b340", "device_unittests": "5e8ad476e9998384d44acf41dab6a1708a6958d9", "display_unittests": "d8a46e641d9431ab50e36cab8f41ea0b60585b3f", "events_unittests": "d8b173129f8b233e43e6398fe7661a64fb0a2c4c", "exo_unittests": "e49466044ac8255c8af12492e4fb4fe1bc44dc94", "extensions_browsertests": "1918a0ad2edb21eb4b3d848d11bfab6bb743cae8", "extensions_unittests": "70c07e098c6531e7fc6cb96a7ef0cbca82ccc75c", "filesystem_service_unittests": "ebad2e4bb90658e6986ad1c83f5d3f30f1d7de83", "gcm_unit_tests": "cb698e0fd46df59cf6bbcbc49721ec64bef83910", "gfx_unittests": "af5240a82a232096221fe03684db6de8375596a6", "gl_unittests_ozone": "3dc7c79921017bf7b3f0c92f0dd574ccf56f9149", "google_apis_unittests": "663091eb3cee0ae125a29d269685174251d485e5", "gpu_unittests": "b7c7b5dec56ff5ae615d05fff17b837bfa530827", "interactive_ui_tests": "ca6da70d2c169baa96a41b34aadf146eb9240015", "ipc_tests": "12a1af43ef0dfec2149019a422ab576aa6ad7dac", "jingle_unittests": "09ed7e85c5554c4b2878ef564a40a1258078cb3e", "keyboard_unittests": "a37425c2d00298fc23294f7f358bbf2950786db3", "latency_unittests": "20a2264145dd5372bb73f8ef8e1ddd60e9c14130", "leveldb_service_unittests": "1808907d1aec6bde1afc9f95a738144ca965e31f", "libjingle_xmpp_unittests": "23c8a24de85d1a4399055d110f0b1986673ddfce", "media_blink_unittests": "820067573effa3ac6d9b486f5ec2d837dc70e26c", "media_service_unittests": "606d80d14e831fcd98d61ca4af04f78c09c82876", "media_unittests": "484db824d30cfc60cb327d6fffd72ccbb9c7264e", "message_center_unittests": "ffda733a98d23e5a2fb09befa860f6bc4b6b1719", "midi_unittests": "bd50686409fffaa74f4c0d7169d5cfac0c3b818a", "mojo_core_unittests": "460f204e44b8cf9432c1b6dd4253720f94db9e40", "mojo_unittests": "0305f94b80656e350b4e0973e059e41df8b0ca85", "nacl_helper_nonsfi_unittests": "667ebc1c5885959568dd51dd4ebb84389c34ce81", "nacl_loader_unittests": "e1e2c7c0e95f554070dfa53ddf67c976c6a5790a", "native_theme_unittests": "258c3c0522a1702177a5b3648e6c75c7dfa3f630", "net_unittests": "cc0c216b6205803a953f1d4a6bd62f54a475b402", "ozone_gl_unittests": "6f23f4e2d5b26e8693e918c6c3dc7d69a6bb78a3", "ozone_unittests": "f821148851a1cd5d6126260181353b031687413f", "ozone_x11_unittests": "45da685291f54dba24141e8ec5722eb1e2e80a94", "pdf_unittests": "542d586856c78ee58e5c81a6a640d3bfa48eb6aa", "ppapi_unittests": "2a0c0c186c817845bb667ec7b97a3b33c836d075", "printing_unittests": "1da6e00ac98c7fe4ad4d430ae55effcacf2dd156", "remoting_unittests": "c855f82c035aca94d9e84676a06b09a4d3a0b3cf", "sandbox_linux_unittests": "7024d7e4a05b57b026e9952586548be693f2f827", "service_manager_unittests": "9afa0e1293e3b3238dcfe7d3e901bcbbd2fa3d7d", "services_unittests": "3c8d11b121310103adf0974765132e334bf9754f", "shell_dialogs_unittests": "34ecc217d774e4f2d89f340c5c1ab5931f24bed6", "skia_unittests": "a694df86139f70fbf5875312e7c11123e779b3c0", "snapshot_unittests": "f59e100e693d655db0d161e6e8e536f55af96e4e", "sql_unittests": "b47b23571aaff8011d586974788c14fc67d6dba9", "storage_unittests": "2acdd93f572d49dd8adfda92367e0c8b26f3d848", "sync_integration_tests": "b8818369d07cf1e87940a0a551c5bbbfb9fe7b3b", "traffic_annotation_auditor_unittests": "d41c27c237b843920f5fecc59e87cb7ca4f0686b", "ui_base_unittests": "81454ade03f01f6d4106623e46ed4406606180fc", "ui_chromeos_unittests": "b88dbb1e1e16b7ab6d2007a9a4c1fa1c819b668c", "ui_touch_selection_unittests": "0e483974656e87dfec18eb8509526f4823b6020a", "unit_tests": "10b9e87c17493357d6e82b624b9fd69a1a281c77", "url_unittests": "7296c507ad2c7a07ad01be4e295679f61886218e", "views_unittests": "6b2bc69893faac8509fe9a08b1abe2a3cd1c1eb2", "viz_unittests": "d9f28adf676b059e7153fb3004a6f8d0623ea4cd", "wayland_client_perftests": "c0ff32db0459002ecb081504b44dd1df26e70a35", "webkit_unit_tests": "ade459835bc67133c463e9bfdf080b80c9bf9634", "wm_unittests": "5f14489499f0a831abc8e6eebb38aab1a51161a9", "wtf_unittests": "8fb6f7c23a6a9c3b495e04c4073e29029af3c554"}	isolate tests

Blamelist:

1. Martin Robinson (mrobinsonohnoyoudont@igalia.com)
2. Kent Tamura (tkentohnoyoudont@chromium.org)
3. Martin Robinson (mrobinsonohnoyoudont@igalia.com)
4. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
5. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
6. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
7. Alexey Baskakov (loysoohnoyoudont@chromium.org)

Timing:

Create	Thursday, 17-Jan-19 09:52:23 UTC
Start	Thursday, 17-Jan-19 09:52:26 UTC
End	Thursday, 17-Jan-19 11:16:34 UTC
Pending	2 secs
Execution	1 hrs 24 mins

All Changes:

1. Reimplement atk_object_get_index_in_parent for AuraLinux

   Changed by	Martin Robinson - mrobinsonohnoyoudont@igalia.com
   Changed at	Thursday, 17-Jan-19 09:50:54 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	137817908fc7673303789ed6b0844c75191af46c

   Comments

   Reimplement atk_object_get_index_in_parent for AuraLinux
   
   Instead of calling into the delegate to get this information, follow the
   approach that Windows uses and just find the item in the parent's child
   vector. This works around a problem where objects from the views code don't
   properly calculate the index in their parent.
   
   Bug: 922383
   Change-Id: I380b7a52ebde7dd77ab7d560d0a5b52e2f9bfa34
   Reviewed-on: https://chromium-review.googlesource.com/c/1415250
   Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
   Commit-Queue: Martin Robinson <mrobinson@igalia.com>
   Cr-Commit-Position: refs/heads/master@{#623624}

   Changed files

   • chrome/browser/ui/views/accessibility/browser_accessibility_uitest_auralinux.cc
   • chrome/test/BUILD.gn
   • ui/accessibility/platform/ax_platform_node_auralinux.cc

2. Form-associated custom elements: Move the code related to control state restore in HTMLFormControlElementWithState to ListedElement.

   Changed by	Kent Tamura - tkentohnoyoudont@chromium.org
   Changed at	Thursday, 17-Jan-19 09:33:47 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	b62fdeea7d015597b119dfc3c1142ff3b9b1c613

   Comments

   Form-associated custom elements: Move the code related to control state restore in HTMLFormControlElementWithState to ListedElement.
   
   This is a preparation to support control state restore feature in
   form-associated custom elements.
   This CL has no behavior changes.
   
   Bug: 905922
   Change-Id: I9eee6c509b6ab974965b0bce397fed14f2dd019c
   Reviewed-on: https://chromium-review.googlesource.com/c/1417390
   Reviewed-by: Hayato Ito <hayato@chromium.org>
   Commit-Queue: Kent Tamura <tkent@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623623}

   Changed files

   • third_party/blink/renderer/core/html/forms/html_form_control_element_with_state.cc
   • third_party/blink/renderer/core/html/forms/html_form_control_element_with_state.h
   • third_party/blink/renderer/core/html/forms/listed_element.cc
   • third_party/blink/renderer/core/html/forms/listed_element.h

3. Remove BrowserAccessibilityManagerAuraLinux::parent_object_

   Changed by	Martin Robinson - mrobinsonohnoyoudont@igalia.com
   Changed at	Thursday, 17-Jan-19 09:33:27 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	857b9b8f7b4845bb5bc2c732f2bc6c0a37b4cf41

   Comments

   Remove BrowserAccessibilityManagerAuraLinux::parent_object_
   
   This member is not used and the parent is now accessed via a window
   property.
   
   Bug: 905013
   Change-Id: I52e4372f8849f2c9111233ed1c12f29ec8525845
   Reviewed-on: https://chromium-review.googlesource.com/c/1415252
   Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
   Commit-Queue: Martin Robinson <mrobinson@igalia.com>
   Cr-Commit-Position: refs/heads/master@{#623622}

   Changed files

   • content/browser/accessibility/browser_accessibility_manager_auralinux.cc
   • content/browser/accessibility/browser_accessibility_manager_auralinux.h

4. Roll src/third_party/skia 25b9f192ed8c..33b4b4908b7a (1 commits)

   Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
   Changed at	Thursday, 17-Jan-19 08:44:24 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	8bd0983ecaaba7886714c5f2c4477badef88ee32

   Comments

   Roll src/third_party/skia 25b9f192ed8c..33b4b4908b7a (1 commits)
   
   https://skia.googlesource.com/skia.git/+log/25b9f192ed8c..33b4b4908b7a
   
   
   git log 25b9f192ed8c..33b4b4908b7a --date=short --no-merges --format='%ad %ae %s'
   2019-01-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
   
   
   Created with:
     gclient setdep -r src/third_party/skia@33b4b4908b7a
   
   The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
   
   Documentation for the AutoRoller is here:
   https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
   
   If the roll is causing failures, please contact the current sheriff, who should
   be CC'd on the roll, and stop the roller if necessary.
   
   CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
   TBR=halcanary@chromium.org
   
   Change-Id: Ia237c8285bacfe2b11af797a49dd8e55bfd23d6a
   Reviewed-on: https://chromium-review.googlesource.com/c/1415696
   Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
   Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
   Cr-Commit-Position: refs/heads/master@{#623621}

   Changed files

   • DEPS

5. Roll src-internal f73a062ed0af..30c81464b991 (1 commits)

   Changed by	chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
   Changed at	Thursday, 17-Jan-19 08:40:50 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	73be317efd02edb9b7967e4575cedaed5613de05

   Comments

   Roll src-internal f73a062ed0af..30c81464b991 (1 commits)
   
   https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f73a062ed0af..30c81464b991
   
   
   Created with:
     gclient setdep -r src-internal@30c81464b991
   
   The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
   
   Documentation for the AutoRoller is here:
   https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
   
   If the roll is causing failures, please contact the current sheriff, who should
   be CC'd on the roll, and stop the roller if necessary.
   
   
   TBR=mmoss@chromium.org
   
   Change-Id: I1ca94cdf6478984d6f76136ae382e7246fd3f660
   Reviewed-on: https://chromium-review.googlesource.com/c/1415697
   Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
   Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
   Cr-Commit-Position: refs/heads/master@{#623620}

   Changed files

   • DEPS

6. Roll Fuchsia SDK from 8d06560ada41 to a3228e6b0585

   Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
   Changed at	Thursday, 17-Jan-19 08:37:40 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	0bde7f6f20a03b160d5464004dba61b7465f4868

   Comments

   Roll Fuchsia SDK from 8d06560ada41 to a3228e6b0585
   
   
   The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
   
   Documentation for the AutoRoller is here:
   https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
   
   If the roll is causing failures, please contact the current sheriff, who should
   be CC'd on the roll, and stop the roller if necessary.
   
   
   CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
   TBR=cr-fuchsia+bot@chromium.org
   
   Change-Id: I5bb1950029ab055b041cd6200d9ead1d7c3bc5ad
   Reviewed-on: https://chromium-review.googlesource.com/c/1416837
   Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
   Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
   Cr-Commit-Position: refs/heads/master@{#623619}

   Changed files

   • build/fuchsia/linux.sdk.sha1
   • build/fuchsia/mac.sdk.sha1

7. WebApp: Add DCHECKs to web application launch logic.

   Changed by	Alexey Baskakov - loysoohnoyoudont@chromium.org
   Changed at	Thursday, 17-Jan-19 08:27:20 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	9d0133c85356fd992054d00e323e861c8e300267

   Comments

   WebApp: Add DCHECKs to web application launch logic.
   
   If there is no WebAppProvider for profile then there is no WebAppTabHelper.
   
   Make sure that WebAppTabHelper exists if we launch a WebApp.
   
   Bug: 921468
   Change-Id: Ib08527f8a42c5dce87ad64de83bbfe10afd41fef
   Reviewed-on: https://chromium-review.googlesource.com/c/1414411
   Reviewed-by: Ben Wells <benwells@chromium.org>
   Commit-Queue: Alexey Baskakov <loyso@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#623618}

   Changed files

   • chrome/browser/ui/extensions/application_launch.cc