Home | Search | chromium - Builders
Login

Builder Linux Chromium OS ASan LSan Builder Build 41452 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision07c46624768cb8f779f4c872aa5951d3cb7d7920
Got Revision07c46624768cb8f779f4c872aa5951d3cb7d7920

Execution:

Steps and Logfiles:

Show:
  1. ( 531 ms ) setup_build
    running recipe: "chromium"
  2. ( 743 ms ) report builders
     
    running builder 'Linux Chromium OS ASan LSan Builder' on master 'chromium.memory'
  3. ( 2 mins 37 secs ) bot_update
    [158GB/492GB used (32%)]
  4. ( 1 secs ) swarming.py --version
    0.13
  5. ( 39 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.memory.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.memory.json
  7. ( 756 ms ) lookup GN args
     
    dcheck_always_on = true
    is_asan = true
    is_component_build = false
    is_debug = false
    is_lsan = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_os = "chromeos"
    use_goma = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 1 mins 4 secs ) generate_build_files
  9. ( 927 ms ) clang_revision
  10. ( 1 hrs 3 mins ) compile
  11. ( 14 mins 6 secs ) isolate tests
  12. ( 1 secs ) trigger

Build Properties:

NameValueSource
$build/goma {"jobs": 500} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2377-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539329945425580, "id": "8932889279104197392", "project": "chromium", "tags": ["builder:Linux Chromium OS ASan LSan Builder", "buildset:commit/git/07c46624768cb8f779f4c872aa5951d3cb7d7920", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/07c46624768cb8f779f4c872aa5951d3cb7d7920", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9098319341165403712", "scheduler_job_id:chromium/Linux Chromium OS ASan LSan Builder", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Linux Chromium OS ASan LSan Builder" setup_build
buildnumber 41452 setup_build
mastername "chromium.memory" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "07c46624768cb8f779f4c872aa5951d3cb7d7920" setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "07c46624768cb8f779f4c872aa5951d3cb7d7920" bot_update
got_revision_cp "refs/heads/master@{#599129}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "a54daf162facb9fe30bcc3e05bd21c1597076157" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25135}" bot_update
got_clang_revision "344066-1" clang_revision
swarm_hashes_refs/heads/master(at){#599129}_without_patch {"accessibility_unittests": "456bce310e52ba03f4f9c11417716d98889fd3f6", "angle_unittests": "fa066158dc6fadcfc04814d3843c87b92536cfc1", "app_list_unittests": "644eb62cd5309d2a867a9943fffa7e2283634059", "app_shell_unittests": "d7d1075bdca3d3ec1eb60c4163661c4e351fdcf2", "ash_content_unittests": "09d3f1be444357d1b56b3ff3e4b2f08e7feaae76", "ash_unittests": "269fa25c0cade4ec9ac8261a56e78ad4b2a3fcbb", "aura_unittests": "f819236f06a3c06844d0019fa68458aa3a1878af", "base_unittests": "5ec5327f12018ecb11a18b9a596a6e216302223d", "blink_common_unittests": "20cbae9a80b09ed0816a45d1a7587f96eed12499", "blink_fuzzer_unittests": "0acaba7e43619c7c9314b075a3685ec3116378d4", "blink_heap_unittests": "a4339326ac283917accf0d0327c58bd3d7733582", "blink_platform_unittests": "815f97dee7d5b310ee56992a7bcbda1a9addac50", "boringssl_crypto_tests": "44fc4b707f4888fd4b0922872b2e55f41b287e3f", "boringssl_ssl_tests": "fef44538e786d29b20f1ddaad9e9f775e2361386", "browser_tests": "38e82e489ad5b5aca01a77805fc13616ea618aeb", "cacheinvalidation_unittests": "71368ff198aa97faf301103a7f59e81f315c5fec", "capture_unittests": "439ef9252be003f7c8ee7555e864930157c04ade", "cast_unittests": "f0e6899a6aa99f002845dfe5c8009b42f9f26a61", "cc_unittests": "b8369ea4e41da86acea3d3fee90135ee981eadcd", "chrome_app_unittests": "ff0c62c9e3b061bdd2334bdc1e2a929ecbe3701c", "chromedriver_unittests": "e7c04d1777f392854cc6f05e75871a937c5f97c5", "chromeos_components_unittests": "33f5ba80c626f52472acefeedac9a32955904a64", "chromeos_unittests": "e4bcab21d7088354481c1cf2872c52dc3a5063a8", "chromevox_tests": "1b80608ea2a81e2da6da919a974df82a47ebcdfe", "components_browsertests": "207cb17f34c7f6f801b8e212528764f87a570768", "components_unittests": "c23101a15e4a1852eb422e554f5b5a8d188731d2", "compositor_unittests": "405a3264f4fa6a56eb8405e2dff1188caf061362", "content_browsertests": "9655637d206c0d0cb60a17f11dccc64780e09870", "content_unittests": "5c08d793931ee0a31d8dfda1e4d9ce1d9a494b2e", "crypto_unittests": "6a0d51053fbabc9c4e5eb8ff6e2fd8fc1dd5f09f", "dbus_unittests": "e9da10c2504f0563c5eb31d978b3d984b19383c2", "device_unittests": "ded771fbc7d93ff99ae8a47df11abf5f60f1f99a", "display_unittests": "76b3245646a46d8a234bc1f44c738755626e90e5", "events_unittests": "48cb327d7d4e79949d996c7cce7fee2d561a00a8", "exo_unittests": "fed2b1a44860aaad6d52d7a10a888a669e4479ec", "extensions_browsertests": "f7fa9666e3910ba0baa0534aef9e2c4d0da765b1", "extensions_unittests": "400dbe9cb72e2b4d095bb2780973fcab897a32dc", "filesystem_service_unittests": "7fbb481f04a7ef5a06714b11657c42c3744fe8c3", "gcm_unit_tests": "673e5faf6dbcdf2c965044ab9bf810e195c50b87", "gfx_unittests": "713a17c66f56243a6713cf7308c4b9bac36e58a3", "gl_unittests_ozone": "603c276d8950f11520dd079539d7fc4caf62a3ef", "google_apis_unittests": "309359731ab0f4f36b8860b91adb2c7a43b93540", "gpu_unittests": "ae91adbd9df04ce0dcf26f63a0f6c14630caaed4", "interactive_ui_tests": "fe3d7e6853f79af398d6d25d7f5de08ef3c7e45b", "ipc_tests": "5c429dbae362223b3ad9c76183d9c474b338652c", "jingle_unittests": "3bdbd79922cb375494653b1cbcea1fe555f4d3fa", "keyboard_unittests": "e2937fc22b4951c16526386b793fbb3abf2fbed3", "latency_unittests": "985f85f1f2e8422662de5e843f7b2927945c0dc0", "leveldb_service_unittests": "8d693ba7453547857701423a47b4f8ff2a41d008", "libjingle_xmpp_unittests": "e2a417da97be098532e92b537f869aa45c42728f", "media_blink_unittests": "ed11c672b598d08bfb3435baf3d9c4625f58d908", "media_service_unittests": "974fe2c85aeb544c60f4da6c08008452cdee95d3", "media_unittests": "a1bf1cd96876ca792bc08eec786e3f7c7e1b5d80", "message_center_unittests": "ec3bbdf4aabfcdc08e0940c03c9b723436720638", "midi_unittests": "4eee665f900a6175afdb89e5dde876406541ffa7", "mojo_core_unittests": "de0dd030198e51ee0485a2733306d81a2423bf06", "mojo_unittests": "22cb7f6c7ca25e92317a25b056f617c428f50520", "nacl_helper_nonsfi_unittests": "cfe83d8f43e57b57e3b5fd06e97c35e8aaefc6d3", "nacl_loader_unittests": "fad926934c90e218a6b0fe33ecfad7ac3eed071c", "native_theme_unittests": "2c0c76c3511e2b9f8403e2867a858f2e3c821ad3", "net_unittests": "2ec467a4e69203cf45f3802dc4296f2e502a7a76", "ozone_gl_unittests": "e82cf6dacccd7eb1305eeece226ba472b11afd80", "ozone_unittests": "5a24b3d62ae59ae71aff8665cc9fab9abd602783", "ozone_x11_unittests": "752f0cff76e39dd68c74aa0a596a2039c0266206", "pdf_unittests": "8d8e15fdd2203b2cfd76d864db58968807f35266", "ppapi_unittests": "163c520b6df01b61255da91eb970df0e0d620f20", "printing_unittests": "0271a22fa3143a2122ceab6df14a9dc74857680e", "remoting_unittests": "7e6aa511099e21f85da22ba763150124730e7eed", "sandbox_linux_unittests": "18e46fa777af0fcf57cc22c8d48d935f2e60aa44", "select_to_speak_extension_tests": "8ed70fab494938af3183dd4db9a438ad974cc083", "service_manager_unittests": "05d0bbf7334b274ceab8ffe59a237a5bce869892", "services_unittests": "1894675643283663aa6e8021e4a1aeb8e0b5de55", "shell_dialogs_unittests": "47c035b8069c73f67ba04e1e03ad539a849b5891", "skia_unittests": "15a3eb35c5afd51963f7d708095514cd442eb145", "snapshot_unittests": "b59141756995a6e9ab1854f8d67221128a19008d", "sql_unittests": "ed1271e470fb09c21fd25336a86df02d7a0dc53f", "storage_unittests": "79c38c73da1567050cffd680d61d4f3495658fac", "sync_integration_tests": "9c4972e34ef9c9199c76c37298fe3e0e3333ae73", "traffic_annotation_auditor_unittests": "e340f59d06afdd4ad18d365a7b0b7922ecb90135", "ui_base_unittests": "8bdb9cc1ed2aca001ece8261045c5002bce44e82", "ui_chromeos_unittests": "8b2ef0e2ed99d0b9eafd0aaa81ae408985dab159", "ui_touch_selection_unittests": "57b3d09c89951b50ddf42e19efba532b8519078c", "unit_tests": "890a34e44a4a672b33351c895ebea646c6d30d33", "url_unittests": "8b9c342fce80d31f7f9de77d8a31e712526a0f7f", "views_mus_interactive_ui_tests": "adebca19198fbbe8b6101cbf744dbbc38da47a3a", "views_mus_unittests": "fbc00b2417ad30a81e0350fe5c038c49237c51c7", "views_unittests": "50ae2bfed798b705a61721b9bd122c24c38e80be", "viz_unittests": "281b87dd13e23e87b3c4a920b3fd4f5a00ee4ef5", "wayland_client_perftests": "0cac678ea5bea0d79f6880e33c54c77660cfeaa9", "webkit_unit_tests": "cacfce82c4d80ea8db7a0717be7a4103c0b49b20", "wm_unittests": "ebbcf083130b1e661a2ea564b0eb3e23f873a52b", "wtf_unittests": "8d18780275b08edbc415f5b49325fa776ad4f7ca"} isolate tests

Blamelist:

  1. Amos Lim (eui-sang.limohnoyoudont@samsung.com)
  2. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
  3. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  4. momohatt (momohatt10ohnoyoudont@gmail.com)
  5. Noel Gordon (noelohnoyoudont@chromium.org)
  6. John Z Wu (jzwohnoyoudont@chromium.org)
  7. Henrik Grunell (grunellohnoyoudont@chromium.org)
  8. Jochen Eisinger (jochenohnoyoudont@chromium.org)
  9. yiyix (yiyixohnoyoudont@chromium.org)
  10. Maksim Sisov (msisovohnoyoudont@igalia.com)
  11. Christopher Cameron (ccameronohnoyoudont@chromium.org)
  12. Trent Apted (taptedohnoyoudont@chromium.org)
  13. Sam McNally (sammcohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 07:39:05 UTC
Start Friday, 12-Oct-18 07:39:07 UTC
End Friday, 12-Oct-18 09:08:30 UTC
Pending 2 secs
Execution 1 hrs 29 mins

All Changes:

  1. Change cpp.tmpl files to cc.tmpl

    Changed by Amos Lim - eui-sang.limohnoyoudont@samsung.com
    Changed at Friday, 12-Oct-18 07:35:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 07c46624768cb8f779f4c872aa5951d3cb7d7920

    Comments

    Change cpp.tmpl files to cc.tmpl
    
    Formats of C++ template files are mixed up with cpp.tmpl and cc.tmpl.
    Unify C++ template files to cc.tmpl
    
    Bug: 894684
    Change-Id: I4f7413f29809bcd3262a20c7f40a23e63ba45d3a
    Reviewed-on: https://chromium-review.googlesource.com/c/1278567
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
    Cr-Commit-Position: refs/heads/master@{#599129}

    Changed files

    • third_party/blink/renderer/bindings/scripts/code_generator_v8.py
    • third_party/blink/renderer/bindings/scripts/generate_v8_context_snapshot_external_references.py
    • third_party/blink/renderer/bindings/templates/attributes.cc.tmpl
    • third_party/blink/renderer/bindings/templates/callback_function.cc.tmpl
    • third_party/blink/renderer/bindings/templates/callback_interface.cc.tmpl
    • third_party/blink/renderer/bindings/templates/callback_invoke.cc.tmpl
    • third_party/blink/renderer/bindings/templates/constants.cc.tmpl
    • third_party/blink/renderer/bindings/templates/dictionary_impl.cc.tmpl
    • third_party/blink/renderer/bindings/templates/dictionary_impl.h.tmpl
    • third_party/blink/renderer/bindings/templates/dictionary_impl_common.cc.tmpl
    • third_party/blink/renderer/bindings/templates/dictionary_v8.cc.tmpl
    • third_party/blink/renderer/bindings/templates/external_reference_table.cc.tmpl
    • third_party/blink/renderer/bindings/templates/interface.cc.tmpl
    • third_party/blink/renderer/bindings/templates/interface_base.cc.tmpl
    • third_party/blink/renderer/bindings/templates/methods.cc.tmpl
    • third_party/blink/renderer/bindings/templates/partial_interface.cc.tmpl
    • third_party/blink/renderer/bindings/templates/templates.gni
    • third_party/blink/renderer/bindings/templates/union_container.cc.tmpl
    • third_party/blink/renderer/bindings/templates/utilities.cc.tmpl
    • third_party/blink/renderer/bindings/tests/results/core/array_buffer_or_array_buffer_view_or_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/boolean_or_element_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/boolean_or_string_or_unrestricted_double.cc
    • third_party/blink/renderer/bindings/tests/results/core/boolean_or_test_callback_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/byte_string_or_node_list.cc
    • third_party/blink/renderer/bindings/tests/results/core/byte_string_sequence_sequence_or_byte_string_byte_string_record.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_double_or_null_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_double_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_long_or_boolean_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_string.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_string_or_double_or_string_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/element_sequence_or_byte_string_double_or_string_record.cc
    • third_party/blink/renderer/bindings/tests/results/core/float_or_boolean.cc
    • third_party/blink/renderer/bindings/tests/results/core/long_or_boolean.cc
    • third_party/blink/renderer/bindings/tests/results/core/long_or_test_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/long_sequence_or_event.cc
    • third_party/blink/renderer/bindings/tests/results/core/nested_union_type.cc
    • third_party/blink/renderer/bindings/tests/results/core/node_or_node_list.cc
    • third_party/blink/renderer/bindings/tests/results/core/string_or_array_buffer_or_array_buffer_view.cc
    • third_party/blink/renderer/bindings/tests/results/core/string_or_double.cc
    • third_party/blink/renderer/bindings/tests/results/core/string_or_string_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_dictionary_derived.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_enum_or_double.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_or_null_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_interface_2_or_uint8_array.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_interface_event_init.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_interface_or_long.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_interface_or_test_interface_empty.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_permissive_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/unrestricted_double_or_string.cc
    • third_party/blink/renderer/bindings/tests/results/core/unsigned_long_long_or_boolean_or_test_callback_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_optional_any_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_variadic_any_args.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_array_buffer.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_array_buffer_view.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_data_view.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_long_callback_function.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_string_sequence_callback_function_long_sequence_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_svg_test_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_attributes.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_functions.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_constants.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary_derived.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_global.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_primary_global.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_2.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_3.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_check_security.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_conditional_secure_context.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_2.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_3.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_4.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_custom_constructor.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_document.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_empty.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init_constructor.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_target.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor_2.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_node.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_origin_trial_enabled.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_secure_context.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_legacy_callback_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_node.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_object.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_permissive_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_special_operations.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_special_operations_not_enumerable.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_typedefs.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_variadic_constructor_arguments.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_treat_non_object_as_null_boolean_function.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_treat_non_object_as_null_void_function.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_uint8_clamped_array.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_dictionary_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_enum_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_interface_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_test_interface_sequence_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_typedef.cc
    • third_party/blink/renderer/bindings/tests/results/core/xml_http_request_or_string.cc
    • third_party/blink/renderer/bindings/tests/results/modules/boolean_or_string.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_inherited_legacy_unenumerable_named_properties.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_2_partial.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_5.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_partial.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_not_enumerable_named_getter.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_sub_object.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_void_callback_function_modules.cc
    • third_party/blink/renderer/core/css/css_primitive_value.h
  2. CrOS FilesApp: Add Manage Linux sharing top menu link to settings page

    Changed by Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:33:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 836e5cd90af24fa6af71e4e633d1c0fb41ca0765

    Comments

    CrOS FilesApp: Add Manage Linux sharing top menu link to settings page
    
    Shown when crostini and flag crostini-files are enabled.
    Links to chrome://settings/crostini/crostiniShared.
    Record UMA for clicks.
    
    Bug: 878324
    Change-Id: Ie09cd5c07edbe6dc0d0bcc22fee78b14981b2020
    Reviewed-on: https://chromium-review.googlesource.com/c/1277130
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599128}

    Changed files

    • chrome/app/file_manager_strings.grdp
    • chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_MANAGE_LINUX_SHARING_BUTTON_LABEL.png.sha1
    • chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
    • tools/metrics/histograms/enums.xml
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/file_manager/foreground/js/file_manager_commands.js
    • ui/file_manager/file_manager/main.html
    • ui/file_manager/file_manager/test/crostini_share.js
  3. Roll src-internal aebffd21b13f..7781cb9daa22 (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 07:17:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d6d014a7e5ef0d330fef991ab82343f02e71b6f8

    Comments

    Roll src-internal aebffd21b13f..7781cb9daa22 (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aebffd21b13f..7781cb9daa22
    
    
    Created with:
      gclient setdep -r src-internal@7781cb9daa22
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ib8911116b9b81a6503414f98f9988cd10a39144e
    Reviewed-on: https://chromium-review.googlesource.com/c/1278303
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599127}

    Changed files

    • DEPS
  4. [ServiceWorker] Add WPT tests to check request header for update

    Changed by momohatt - momohatt10ohnoyoudont@gmail.com
    Changed at Friday, 12-Oct-18 07:05:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4512662655ea5694ebba6c13055e99c9a0b2d096

    Comments

    [ServiceWorker] Add WPT tests to check request header for update
    
    Spec requires that during the update of service workers, request headers
    for fetching main scripts should include "Service-Worker" field, while
    that for fetching importScripts() resources should not.
    This patch adds WPT tests to validate this behavior.
    
    Change-Id: I24949fd0b375f6b811a73ce24aae87a4ea7c234f
    Reviewed-on: https://chromium-review.googlesource.com/c/1267297
    Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599126}

    Changed files

    • AUTHORS
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/service-worker-header.py
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/service-worker-header.https.html
  5. Add Quick View audio load test

    Changed by Noel Gordon - noelohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:04:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae2fcf0ef323eb487edced1ab876a090b3f9ce1e

    Comments

    Add Quick View audio load test
    
    Now we have the QuickView <webview> infra to detect the 'loaded' state
    of the <webview> content, add a <file-safe-media> audio test, and also
    check the <webview> renders its content on a transparent black body.
    
    This test exposed an issue in Blink node code. When the modal <dialog>
    is calling showModal(), its flat tree distribution can be out-of-date,
    causing a DCHECK crash when testing if the Quick View <dialog> element
    contains sibling <iframe id="command-dispatcher"> [1].
    
    Fix that: FlatTreeTraversal::ContainsIncludingPseudoElement() requires
    that its node arguments have up-to-date flat tree distribution. Ensure
    the <dialog>'s flat tree distribution is up-of-date _before_ trying to
    propagate the "inert" bit into sub-frames.
    
    Add crash test: html/dialog/showmodal-shadow-sibling-frame-crash.html
    
    [1] Known crash reports already exist: issue 789094 issue 804047.
    
    test: browser_tests --gtest_filter="QuickView*openQuickViewAudio"
    Bug: 891150, 789094, 804047
    Change-Id: I714585272fc775c157f6d0bd97143af27bf2b961
    Reviewed-on: https://chromium-review.googlesource.com/c/1264138
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599125}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • third_party/WebKit/LayoutTests/html/dialog/showmodal-shadow-sibling-frame-crash-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/showmodal-shadow-sibling-frame-crash.html
    • third_party/blink/renderer/core/html/html_dialog_element.cc
    • ui/file_manager/integration_tests/file_manager/quick_view.js
  6. Clarify |stopSyncAndClearIdentity| with additional comment.

    Changed by John Z Wu - jzwohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:03:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3255a4ba5a80b407cc61864a85c469842894f469

    Comments

    Clarify |stopSyncAndClearIdentity| with additional comment.
    
    Namely, it is OK to call it multiple times.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I7348628de6e39ca50461c25db7343cd46b5f069a
    Reviewed-on: https://chromium-review.googlesource.com/c/1278061
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599124}

    Changed files

    • ios/web_view/public/cwv_sync_controller.h
  7. Revert "[Video Capture, Test] Make tests requiring real webcam fail if it's not found"

    Changed by Henrik Grunell - grunellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:57:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7bb43df173039894cf46c8b3476913f0f20ae6d1

    Comments

    Revert "[Video Capture, Test] Make tests requiring real webcam fail if it's not found"
    
    This reverts commit dfeab488cdc95233b19b9edeedef3d0b7581b17e.
    
    Reason for revert: Tests fail on Chromium WebRTC bots. Example: https://ci.chromium.org/buildbot/chromium.webrtc/Mac%20Tester/84091
    
    Original change's description:
    > [Video Capture, Test] Make tests requiring real webcam fail if it's not found
    > 
    > Use prefix "UsingRealWebcam_" for names of tests that require real webcam and
    > add checking whether webcam is found or not.
    > Accordingly, exclude such test cases from test suites for devices that have no
    > camera.
    > 
    > Bug: 893494
    > Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebox (guado)
    >       and it failed.
    > Test: Ran capture_unittests excluding UsingRealWebcam_ tests on Chromebox (guado)
    >       and it passed.
    > Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebook (kevin)
    >       and it passed.
    > 
    > Change-Id: I5c91380b7674aeace6a7d1764f7fad31f02f8af7
    > Reviewed-on: https://chromium-review.googlesource.com/c/1276407
    > Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org>
    > Reviewed-by: Christian Fremerey <chfremer@chromium.org>
    > Reviewed-by: Ben Pastene <bpastene@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599097}
    
    TBR=bpastene@chromium.org,chfremer@chromium.org,keiichiw@chromium.org
    
    Change-Id: I282dc00ffad2ff6614e7dfab1a9404da85cf032a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 893494
    Reviewed-on: https://chromium-review.googlesource.com/c/1278272
    Reviewed-by: Henrik Grunell <grunell@chromium.org>
    Commit-Queue: Henrik Grunell <grunell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599123}

    Changed files

    • media/capture/video/video_capture_device_unittest.cc
    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.chromiumos.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.linux.json
    • testing/buildbot/chromium.mac.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.win.json
    • testing/buildbot/test_suites.pyl
  8. Remove the round-robin list for third-party additions

    Changed by Jochen Eisinger - jochenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:51:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 13767a51fd778bba049621a733ac7fbe6221922b

    Comments

    Remove the round-robin list for third-party additions
    
    Instead, require an email to opensource-licensing@ again until we
    figured out the new process.
    
    R=jam@chromium.org
    
    Change-Id: I352bd17e42cc1500994ba39368d25a0d91271f9c
    Reviewed-on: https://chromium-review.googlesource.com/c/1275846
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Commit-Queue: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599122}

    Changed files

    • docs/adding_to_third_party.md
    • third_party/OWNERS
  9. GPU_Tests: Remove expectations after rebaseline

    Changed by yiyix - yiyixohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:49:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c30443b0e8a01efd448efc72829fb96584f0db0

    Comments

    GPU_Tests: Remove expectations after rebaseline
    
    Bug: 879379
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I43e957955103e5b2d6e4ae80b296655f1b2aa5b1
    Reviewed-on: https://chromium-review.googlesource.com/c/1277953
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Commit-Queue: Yi Xu <yiyix@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599121}

    Changed files

    • content/test/gpu/gpu_tests/pixel_expectations.py
  10. [ozone/wayland] Fix kiosk mode.

    Changed by Maksim Sisov - msisovohnoyoudont@igalia.com
    Changed at Friday, 12-Oct-18 06:36:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f154daab631433d3d9706af7f3512aa6b196e52f

    Comments

    [ozone/wayland] Fix kiosk mode.
    
    This CL fixes a fullscreen state changes before the surface is
    activated.
    
    That is, Wayland may ignore fullscreen changes before the surface
    is activated. Thus, store a pending state, and once the surface
    is activated, trigger the change.
    
    Change-Id: I8c0b995eb9f282f6be16e82d094d9dd93821a60a
    Bug: 843018
    Reviewed-on: https://chromium-review.googlesource.com/c/1275885
    Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
    Commit-Queue: Maksim Sisov <msisov@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#599120}

    Changed files

    • ui/ozone/platform/wayland/wayland_window.cc
    • ui/ozone/platform/wayland/wayland_window.h
    • ui/ozone/platform/wayland/wayland_window_unittest.cc
  11. RemoteMacViews: Make fullscreen mode not crash

    Changed by Christopher Cameron - ccameronohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:34:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 800a927eb503828f5cf6f489739e1a6efc444429

    Comments

    RemoteMacViews: Make fullscreen mode not crash
    
    Fix a few places where we would dereference a BridgedNativeWidgetImpl
    which is null when out-of-process. This doesn't guarantee correct
    behavior, but avoids a crash.
    
    Make WebContentsNSViewBridge::Show resize the web contents view and
    also all of its children.
    
    Bug: 859152
    Change-Id: I948de1e4f79db4a51c5b86e7960356133eff4342
    Reviewed-on: https://chromium-review.googlesource.com/c/1278533
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: ccameron <ccameron@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599119}

    Changed files

    • chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_views.mm
    • content/browser/web_contents/web_contents_ns_view_bridge.mm
  12. Migrate base::AtomicFlag to std::atomic

    Changed by Trent Apted - taptedohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:34:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d64bfc8e330fea105de74137e6e176763dc546a4

    Comments

    Migrate base::AtomicFlag to std::atomic
    
    atomicops.h uses `volatile` which inhibits some compiler optimisations
    without contributing to threading correctness.
    
    Define AtomicFlag::IsSet() in the header, rather than out-of-line.
    Without this, WeakPtr overheads in ObserverListPerfTest_*.CheckedObserver
    in base_perftests are up to 70% greater.
    
    Bug: 891536
    Change-Id: Ibc733042bf0027738b49c70ccbbcefc4cde3289d
    Reviewed-on: https://chromium-review.googlesource.com/c/1278425
    Commit-Queue: Trent Apted <tapted@chromium.org>
    Reviewed-by: Albert J. Wong <ajwong@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599118}

    Changed files

    • base/synchronization/atomic_flag.cc
    • base/synchronization/atomic_flag.h
  13. Make DriveFS opt-out in FilesApp tests.

    Changed by Sam McNally - sammcohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:33:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e9c79d562d8d3b789cca95b6909aa600a1dd39d2

    Comments

    Make DriveFS opt-out in FilesApp tests.
    
    Bug: 891197
    Change-Id: Id3101a43cfe97e652d71f720b5f312b933af1113
    Reviewed-on: https://chromium-review.googlesource.com/c/1277133
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Commit-Queue: Sam McNally <sammc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599117}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc