Home | Search | chromium - Builders
Login

Builder Linux Chromium OS ASan LSan Builder Build 41452 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision07c46624768cb8f779f4c872aa5951d3cb7d7920
Got Revision07c46624768cb8f779f4c872aa5951d3cb7d7920

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Amos Lim (eui-sang.limohnoyoudont@samsung.com)
  2. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
  3. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  4. momohatt (momohatt10ohnoyoudont@gmail.com)
  5. Noel Gordon (noelohnoyoudont@chromium.org)
  6. John Z Wu (jzwohnoyoudont@chromium.org)
  7. Henrik Grunell (grunellohnoyoudont@chromium.org)
  8. Jochen Eisinger (jochenohnoyoudont@chromium.org)
  9. yiyix (yiyixohnoyoudont@chromium.org)
  10. Maksim Sisov (msisovohnoyoudont@igalia.com)
  11. Christopher Cameron (ccameronohnoyoudont@chromium.org)
  12. Trent Apted (taptedohnoyoudont@chromium.org)
  13. Sam McNally (sammcohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 07:39:05 UTC
Start Friday, 12-Oct-18 07:39:07 UTC
End Friday, 12-Oct-18 09:08:30 UTC
Pending 2 secs
Execution 1 hrs 29 mins

All Changes:

  1. Change cpp.tmpl files to cc.tmpl

    Changed by Amos Lim - eui-sang.limohnoyoudont@samsung.com
    Changed at Friday, 12-Oct-18 07:35:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 07c46624768cb8f779f4c872aa5951d3cb7d7920

    Comments

    Change cpp.tmpl files to cc.tmpl
    
    Formats of C++ template files are mixed up with cpp.tmpl and cc.tmpl.
    Unify C++ template files to cc.tmpl
    
    Bug: 894684
    Change-Id: I4f7413f29809bcd3262a20c7f40a23e63ba45d3a
    Reviewed-on: https://chromium-review.googlesource.com/c/1278567
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
    Cr-Commit-Position: refs/heads/master@{#599129}

    Changed files

    • third_party/blink/renderer/bindings/scripts/code_generator_v8.py
    • third_party/blink/renderer/bindings/scripts/generate_v8_context_snapshot_external_references.py
    • third_party/blink/renderer/bindings/templates/attributes.cc.tmpl
    • third_party/blink/renderer/bindings/templates/callback_function.cc.tmpl
    • third_party/blink/renderer/bindings/templates/callback_interface.cc.tmpl
    • third_party/blink/renderer/bindings/templates/callback_invoke.cc.tmpl
    • third_party/blink/renderer/bindings/templates/constants.cc.tmpl
    • third_party/blink/renderer/bindings/templates/dictionary_impl.cc.tmpl
    • third_party/blink/renderer/bindings/templates/dictionary_impl.h.tmpl
    • third_party/blink/renderer/bindings/templates/dictionary_impl_common.cc.tmpl
    • third_party/blink/renderer/bindings/templates/dictionary_v8.cc.tmpl
    • third_party/blink/renderer/bindings/templates/external_reference_table.cc.tmpl
    • third_party/blink/renderer/bindings/templates/interface.cc.tmpl
    • third_party/blink/renderer/bindings/templates/interface_base.cc.tmpl
    • third_party/blink/renderer/bindings/templates/methods.cc.tmpl
    • third_party/blink/renderer/bindings/templates/partial_interface.cc.tmpl
    • third_party/blink/renderer/bindings/templates/templates.gni
    • third_party/blink/renderer/bindings/templates/union_container.cc.tmpl
    • third_party/blink/renderer/bindings/templates/utilities.cc.tmpl
    • third_party/blink/renderer/bindings/tests/results/core/array_buffer_or_array_buffer_view_or_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/boolean_or_element_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/boolean_or_string_or_unrestricted_double.cc
    • third_party/blink/renderer/bindings/tests/results/core/boolean_or_test_callback_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/byte_string_or_node_list.cc
    • third_party/blink/renderer/bindings/tests/results/core/byte_string_sequence_sequence_or_byte_string_byte_string_record.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_double_or_null_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_double_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_long_or_boolean_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_string.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_string_or_double_or_string_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/element_sequence_or_byte_string_double_or_string_record.cc
    • third_party/blink/renderer/bindings/tests/results/core/float_or_boolean.cc
    • third_party/blink/renderer/bindings/tests/results/core/long_or_boolean.cc
    • third_party/blink/renderer/bindings/tests/results/core/long_or_test_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/long_sequence_or_event.cc
    • third_party/blink/renderer/bindings/tests/results/core/nested_union_type.cc
    • third_party/blink/renderer/bindings/tests/results/core/node_or_node_list.cc
    • third_party/blink/renderer/bindings/tests/results/core/string_or_array_buffer_or_array_buffer_view.cc
    • third_party/blink/renderer/bindings/tests/results/core/string_or_double.cc
    • third_party/blink/renderer/bindings/tests/results/core/string_or_string_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_dictionary_derived.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_enum_or_double.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_or_null_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_interface_2_or_uint8_array.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_interface_event_init.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_interface_or_long.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_interface_or_test_interface_empty.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_permissive_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/unrestricted_double_or_string.cc
    • third_party/blink/renderer/bindings/tests/results/core/unsigned_long_long_or_boolean_or_test_callback_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_optional_any_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_variadic_any_args.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_array_buffer.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_array_buffer_view.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_data_view.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_long_callback_function.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_string_sequence_callback_function_long_sequence_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_svg_test_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_attributes.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_functions.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_constants.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary_derived.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_global.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_primary_global.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_2.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_3.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_check_security.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_conditional_secure_context.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_2.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_3.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_4.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_custom_constructor.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_document.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_empty.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init_constructor.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_target.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor_2.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_node.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_origin_trial_enabled.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_secure_context.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_legacy_callback_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_node.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_object.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_permissive_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_special_operations.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_special_operations_not_enumerable.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_typedefs.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_variadic_constructor_arguments.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_treat_non_object_as_null_boolean_function.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_treat_non_object_as_null_void_function.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_uint8_clamped_array.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_dictionary_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_enum_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_interface_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_test_interface_sequence_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_typedef.cc
    • third_party/blink/renderer/bindings/tests/results/core/xml_http_request_or_string.cc
    • third_party/blink/renderer/bindings/tests/results/modules/boolean_or_string.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_inherited_legacy_unenumerable_named_properties.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_2_partial.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_5.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_partial.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_not_enumerable_named_getter.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_sub_object.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_void_callback_function_modules.cc
    • third_party/blink/renderer/core/css/css_primitive_value.h
  2. CrOS FilesApp: Add Manage Linux sharing top menu link to settings page

    Changed by Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:33:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 836e5cd90af24fa6af71e4e633d1c0fb41ca0765

    Comments

    CrOS FilesApp: Add Manage Linux sharing top menu link to settings page
    
    Shown when crostini and flag crostini-files are enabled.
    Links to chrome://settings/crostini/crostiniShared.
    Record UMA for clicks.
    
    Bug: 878324
    Change-Id: Ie09cd5c07edbe6dc0d0bcc22fee78b14981b2020
    Reviewed-on: https://chromium-review.googlesource.com/c/1277130
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599128}

    Changed files

    • chrome/app/file_manager_strings.grdp
    • chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_MANAGE_LINUX_SHARING_BUTTON_LABEL.png.sha1
    • chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
    • tools/metrics/histograms/enums.xml
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/file_manager/foreground/js/file_manager_commands.js
    • ui/file_manager/file_manager/main.html
    • ui/file_manager/file_manager/test/crostini_share.js
  3. Roll src-internal aebffd21b13f..7781cb9daa22 (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 07:17:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d6d014a7e5ef0d330fef991ab82343f02e71b6f8

    Comments

    Roll src-internal aebffd21b13f..7781cb9daa22 (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aebffd21b13f..7781cb9daa22
    
    
    Created with:
      gclient setdep -r src-internal@7781cb9daa22
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ib8911116b9b81a6503414f98f9988cd10a39144e
    Reviewed-on: https://chromium-review.googlesource.com/c/1278303
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599127}

    Changed files

    • DEPS
  4. [ServiceWorker] Add WPT tests to check request header for update

    Changed by momohatt - momohatt10ohnoyoudont@gmail.com
    Changed at Friday, 12-Oct-18 07:05:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4512662655ea5694ebba6c13055e99c9a0b2d096

    Comments

    [ServiceWorker] Add WPT tests to check request header for update
    
    Spec requires that during the update of service workers, request headers
    for fetching main scripts should include "Service-Worker" field, while
    that for fetching importScripts() resources should not.
    This patch adds WPT tests to validate this behavior.
    
    Change-Id: I24949fd0b375f6b811a73ce24aae87a4ea7c234f
    Reviewed-on: https://chromium-review.googlesource.com/c/1267297
    Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599126}

    Changed files

    • AUTHORS
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/service-worker-header.py
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/service-worker-header.https.html
  5. Add Quick View audio load test

    Changed by Noel Gordon - noelohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:04:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae2fcf0ef323eb487edced1ab876a090b3f9ce1e

    Comments

    Add Quick View audio load test
    
    Now we have the QuickView <webview> infra to detect the 'loaded' state
    of the <webview> content, add a <file-safe-media> audio test, and also
    check the <webview> renders its content on a transparent black body.
    
    This test exposed an issue in Blink node code. When the modal <dialog>
    is calling showModal(), its flat tree distribution can be out-of-date,
    causing a DCHECK crash when testing if the Quick View <dialog> element
    contains sibling <iframe id="command-dispatcher"> [1].
    
    Fix that: FlatTreeTraversal::ContainsIncludingPseudoElement() requires
    that its node arguments have up-to-date flat tree distribution. Ensure
    the <dialog>'s flat tree distribution is up-of-date _before_ trying to
    propagate the "inert" bit into sub-frames.
    
    Add crash test: html/dialog/showmodal-shadow-sibling-frame-crash.html
    
    [1] Known crash reports already exist: issue 789094 issue 804047.
    
    test: browser_tests --gtest_filter="QuickView*openQuickViewAudio"
    Bug: 891150, 789094, 804047
    Change-Id: I714585272fc775c157f6d0bd97143af27bf2b961
    Reviewed-on: https://chromium-review.googlesource.com/c/1264138
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599125}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • third_party/WebKit/LayoutTests/html/dialog/showmodal-shadow-sibling-frame-crash-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/showmodal-shadow-sibling-frame-crash.html
    • third_party/blink/renderer/core/html/html_dialog_element.cc
    • ui/file_manager/integration_tests/file_manager/quick_view.js
  6. Clarify |stopSyncAndClearIdentity| with additional comment.

    Changed by John Z Wu - jzwohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:03:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3255a4ba5a80b407cc61864a85c469842894f469

    Comments

    Clarify |stopSyncAndClearIdentity| with additional comment.
    
    Namely, it is OK to call it multiple times.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I7348628de6e39ca50461c25db7343cd46b5f069a
    Reviewed-on: https://chromium-review.googlesource.com/c/1278061
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599124}

    Changed files

    • ios/web_view/public/cwv_sync_controller.h
  7. Revert "[Video Capture, Test] Make tests requiring real webcam fail if it's not found"

    Changed by Henrik Grunell - grunellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:57:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7bb43df173039894cf46c8b3476913f0f20ae6d1

    Comments

    Revert "[Video Capture, Test] Make tests requiring real webcam fail if it's not found"
    
    This reverts commit dfeab488cdc95233b19b9edeedef3d0b7581b17e.
    
    Reason for revert: Tests fail on Chromium WebRTC bots. Example: https://ci.chromium.org/buildbot/chromium.webrtc/Mac%20Tester/84091
    
    Original change's description:
    > [Video Capture, Test] Make tests requiring real webcam fail if it's not found
    > 
    > Use prefix "UsingRealWebcam_" for names of tests that require real webcam and
    > add checking whether webcam is found or not.
    > Accordingly, exclude such test cases from test suites for devices that have no
    > camera.
    > 
    > Bug: 893494
    > Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebox (guado)
    >       and it failed.
    > Test: Ran capture_unittests excluding UsingRealWebcam_ tests on Chromebox (guado)
    >       and it passed.
    > Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebook (kevin)
    >       and it passed.
    > 
    > Change-Id: I5c91380b7674aeace6a7d1764f7fad31f02f8af7
    > Reviewed-on: https://chromium-review.googlesource.com/c/1276407
    > Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org>
    > Reviewed-by: Christian Fremerey <chfremer@chromium.org>
    > Reviewed-by: Ben Pastene <bpastene@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599097}
    
    TBR=bpastene@chromium.org,chfremer@chromium.org,keiichiw@chromium.org
    
    Change-Id: I282dc00ffad2ff6614e7dfab1a9404da85cf032a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 893494
    Reviewed-on: https://chromium-review.googlesource.com/c/1278272
    Reviewed-by: Henrik Grunell <grunell@chromium.org>
    Commit-Queue: Henrik Grunell <grunell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599123}

    Changed files

    • media/capture/video/video_capture_device_unittest.cc
    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.chromiumos.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.linux.json
    • testing/buildbot/chromium.mac.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.win.json
    • testing/buildbot/test_suites.pyl
  8. Remove the round-robin list for third-party additions

    Changed by Jochen Eisinger - jochenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:51:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 13767a51fd778bba049621a733ac7fbe6221922b

    Comments

    Remove the round-robin list for third-party additions
    
    Instead, require an email to opensource-licensing@ again until we
    figured out the new process.
    
    R=jam@chromium.org
    
    Change-Id: I352bd17e42cc1500994ba39368d25a0d91271f9c
    Reviewed-on: https://chromium-review.googlesource.com/c/1275846
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Commit-Queue: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599122}

    Changed files

    • docs/adding_to_third_party.md
    • third_party/OWNERS
  9. GPU_Tests: Remove expectations after rebaseline

    Changed by yiyix - yiyixohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:49:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c30443b0e8a01efd448efc72829fb96584f0db0

    Comments

    GPU_Tests: Remove expectations after rebaseline
    
    Bug: 879379
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I43e957955103e5b2d6e4ae80b296655f1b2aa5b1
    Reviewed-on: https://chromium-review.googlesource.com/c/1277953
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Commit-Queue: Yi Xu <yiyix@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599121}

    Changed files

    • content/test/gpu/gpu_tests/pixel_expectations.py
  10. [ozone/wayland] Fix kiosk mode.

    Changed by Maksim Sisov - msisovohnoyoudont@igalia.com
    Changed at Friday, 12-Oct-18 06:36:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f154daab631433d3d9706af7f3512aa6b196e52f

    Comments

    [ozone/wayland] Fix kiosk mode.
    
    This CL fixes a fullscreen state changes before the surface is
    activated.
    
    That is, Wayland may ignore fullscreen changes before the surface
    is activated. Thus, store a pending state, and once the surface
    is activated, trigger the change.
    
    Change-Id: I8c0b995eb9f282f6be16e82d094d9dd93821a60a
    Bug: 843018
    Reviewed-on: https://chromium-review.googlesource.com/c/1275885
    Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
    Commit-Queue: Maksim Sisov <msisov@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#599120}

    Changed files

    • ui/ozone/platform/wayland/wayland_window.cc
    • ui/ozone/platform/wayland/wayland_window.h
    • ui/ozone/platform/wayland/wayland_window_unittest.cc
  11. RemoteMacViews: Make fullscreen mode not crash

    Changed by Christopher Cameron - ccameronohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:34:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 800a927eb503828f5cf6f489739e1a6efc444429

    Comments

    RemoteMacViews: Make fullscreen mode not crash
    
    Fix a few places where we would dereference a BridgedNativeWidgetImpl
    which is null when out-of-process. This doesn't guarantee correct
    behavior, but avoids a crash.
    
    Make WebContentsNSViewBridge::Show resize the web contents view and
    also all of its children.
    
    Bug: 859152
    Change-Id: I948de1e4f79db4a51c5b86e7960356133eff4342
    Reviewed-on: https://chromium-review.googlesource.com/c/1278533
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: ccameron <ccameron@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599119}

    Changed files

    • chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_views.mm
    • content/browser/web_contents/web_contents_ns_view_bridge.mm
  12. Migrate base::AtomicFlag to std::atomic

    Changed by Trent Apted - taptedohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:34:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d64bfc8e330fea105de74137e6e176763dc546a4

    Comments

    Migrate base::AtomicFlag to std::atomic
    
    atomicops.h uses `volatile` which inhibits some compiler optimisations
    without contributing to threading correctness.
    
    Define AtomicFlag::IsSet() in the header, rather than out-of-line.
    Without this, WeakPtr overheads in ObserverListPerfTest_*.CheckedObserver
    in base_perftests are up to 70% greater.
    
    Bug: 891536
    Change-Id: Ibc733042bf0027738b49c70ccbbcefc4cde3289d
    Reviewed-on: https://chromium-review.googlesource.com/c/1278425
    Commit-Queue: Trent Apted <tapted@chromium.org>
    Reviewed-by: Albert J. Wong <ajwong@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599118}

    Changed files

    • base/synchronization/atomic_flag.cc
    • base/synchronization/atomic_flag.h
  13. Make DriveFS opt-out in FilesApp tests.

    Changed by Sam McNally - sammcohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:33:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e9c79d562d8d3b789cca95b6909aa600a1dd39d2

    Comments

    Make DriveFS opt-out in FilesApp tests.
    
    Bug: 891197
    Change-Id: Id3101a43cfe97e652d71f720b5f312b933af1113
    Reviewed-on: https://chromium-review.googlesource.com/c/1277133
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Commit-Queue: Sam McNally <sammc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599117}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc