Home | Search | chromium - Builders
Login

Builder Linux Chromium OS ASan LSan Builder Build 40499 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision6df1590559bd965c71b181b4d948e0ea3318189a
Got Revision6df1590559bd965c71b181b4d948e0ea3318189a

Execution:

Steps and Logfiles:

Show:
  1. ( 0 ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Peter Kasting (pkastingohnoyoudont@chromium.org)
  2. Yuwei Huang (yuweihohnoyoudont@chromium.org)
  3. Findit (findit-for-meohnoyoudont@appspot.gserviceaccount.com)
  4. Julie Jeongeun Kim (jkimohnoyoudont@igalia.com)

Timing:

Create Saturday, 11-Aug-18 05:17:03 UTC
Start Saturday, 11-Aug-18 05:17:05 UTC
End Saturday, 11-Aug-18 07:17:49 UTC
Pending 1 secs
Execution 2 hrs

All Changes:

  1. Revert "Remove unnecessary tab key press from Focus_AdvanceFocus test"

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 05:15:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6df1590559bd965c71b181b4d948e0ea3318189a

    Comments

    Revert "Remove unnecessary tab key press from Focus_AdvanceFocus test"
    
    This reverts commit 5eeadd143332f6fc6c26af924d8a38d5f49b06a2.
    
    Reason for revert: Seems to have caused failures on mac_cocoa_rel, see e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8938549477439492256/+/steps/interactive_ui_tests/0/logs/WebViewFocusInteractiveTest.Focus_AdvanceFocus/0
    
    Original change's description:
    > Remove unnecessary tab key press from Focus_AdvanceFocus test
    > 
    > The associated bug which required this extra tab is fixed.
    > 
    > Bug: 147644
    > Change-Id: Ied21533accc82613053e119aa2c5c64fc9de8343
    > Reviewed-on: https://chromium-review.googlesource.com/1170986
    > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
    > Commit-Queue: Kevin McNee <mcnee@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#582240}
    
    TBR=ekaramad@chromium.org,mcnee@chromium.org
    
    Change-Id: I6c84e6950d7f74ae5b15eec084a536115e635ceb
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 147644
    Reviewed-on: https://chromium-review.googlesource.com/1172002
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582429}

    Changed files

    • chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
  2. [CRD iOS] Make ChromotingSession own the AudioStub

    Changed by Yuwei Huang - yuweihohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 04:59:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 206d44a2086dc771c898b5d3f9da0bcd95f6c0a7

    Comments

    [CRD iOS] Make ChromotingSession own the AudioStub
    
    Previously AudioStub is owned by the the (Remoting|Jni)Client class and
    being passed to ChromotingSession as a WeakPtr. The AudioStub is not
    used after it is passed to ChromotingSession and it is a burden for the
    *Client class to manage its lifetime.
    
    This CL fixes this by making ChromotingSession own the AudioStub.
    
    Bug: 868088
    Change-Id: I067f321b3aab7110df7bb85a8b8c519ea889865e
    Reviewed-on: https://chromium-review.googlesource.com/1171840
    Reviewed-by: Joe Downing <joedow@chromium.org>
    Commit-Queue: Yuwei Huang <yuweih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582428}

    Changed files

    • remoting/client/audio/audio_playback_stream.cc
    • remoting/client/audio/audio_playback_stream.h
    • remoting/client/chromoting_session.cc
    • remoting/client/chromoting_session.h
    • remoting/client/jni/jni_client.cc
    • remoting/client/jni/jni_client.h
    • remoting/ios/session/remoting_client.mm
  3. Revert "chromeos: add SingleProcessMash mode"

    Changed by Findit - findit-for-meohnoyoudont@appspot.gserviceaccount.com
    Changed at Saturday, 11-Aug-18 03:38:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 39e00c42d85fedf2a20f7ee4889a7f101def4975

    Comments

    Revert "chromeos: add SingleProcessMash mode"
    
    This reverts commit b092ae622b9ab3856d64d3eca543e4ecb243be77.
    
    Reason for revert:
    
    Findit (https://goo.gl/kROfz5) identified CL at revision 582411 as the
    culprit for failures in the build cycles as shown on:
    https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2IwOTJhZTYyMmI5YWIzODU2ZDY0ZDNlY2E1NDNlNGVjYjI0M2JlNzcM
    
    Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/7241
    
    Sample Failed Step: ash_content_unittests
    
    Original change's description:
    > chromeos: add SingleProcessMash mode
    > 
    > This makes Ash create an Env if passed SingleProcessMash. In addition this
    > makes all window creation go through a factory that ensures the right env is
    > supplied.
    > 
    > See https://docs.google.com/document/d/11ha_KioDdXe4iZS2AML1foKnCJlNKm7Q1hFr6VW8dV4/edit
    > for more details.
    > 
    > This also adds the feature to ui/base.
    > 
    > BUG=847992
    > TEST=covered by tests
    > 
    > Change-Id: Ica3c433627222f0e076dddaf19b1ab09168cebeb
    > Reviewed-on: https://chromium-review.googlesource.com/1168282
    > Commit-Queue: Scott Violet <sky@chromium.org>
    > Reviewed-by: James Cook <jamescook@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#582411}
    
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    BUG=847992
    
    Change-Id: I9e2e3c0d92dc7b51f08fa35a2dfacd5ca8af57f2
    Reviewed-on: https://chromium-review.googlesource.com/1171706
    Cr-Commit-Position: refs/heads/master@{#582427}

    Changed files

    • ash/BUILD.gn
    • ash/README.md
    • ash/app_launch_unittest.cc
    • ash/ash_service_unittest.cc
    • ash/components/fast_ink/fast_ink_view.cc
    • ash/display/cursor_window_controller.cc
    • ash/display/display_manager_unittest.cc
    • ash/display/display_util.cc
    • ash/display/mirror_window_controller.cc
    • ash/display/mouse_cursor_event_filter_unittest.cc
    • ash/display/root_window_transformers_unittest.cc
    • ash/display/screen_ash.cc
    • ash/display/screen_position_controller_unittest.cc
    • ash/display/unified_mouse_warp_controller_unittest.cc
    • ash/display/window_tree_host_manager_unittest.cc
    • ash/drag_drop/drag_drop_tracker.cc
    • ash/events/event_rewriter_controller.cc
    • ash/extended_desktop_unittest.cc
    • ash/frame/detached_title_area_renderer.cc
    • ash/frame/header_view.cc
    • ash/host/DEPS
    • ash/host/ash_window_tree_host.cc
    • ash/host/ash_window_tree_host_platform.cc
    • ash/keyboard/arc/arc_input_method_surface_manager_unittest.cc
    • ash/keyboard/test_keyboard_ui.cc
    • ash/magnifier/docked_magnifier_controller.cc
    • ash/magnifier/magnification_controller_unittest.cc
    • ash/metrics/desktop_task_switch_metric_recorder_unittest.cc
    • ash/public/cpp/frame_border_hit_test.cc
    • ash/root_window_controller.cc
    • ash/root_window_controller_unittest.cc
    • ash/shelf/shelf_layout_manager_unittest.cc
    • ash/shelf/shelf_window_watcher_unittest.cc
    • ash/shell.cc
    • ash/shell.h
    • ash/shell_unittest.cc
    • ash/system/message_center/arc/arc_notification_content_view_unittest.cc
    • ash/system/message_center/arc/arc_notification_view_unittest.cc
    • ash/system/message_center/arc/mock_arc_notification_surface.cc
    • ash/system/message_center/arc/mock_arc_notification_surface.h
    • ash/system/night_light/night_light_controller.cc
    • ash/system/overview/overview_button_tray_unittest.cc
    • ash/system/tray/tray_background_view.cc
    • ash/test/ash_test_base.cc
    • ash/test/ash_test_helper.cc
    • ash/test/ash_test_suite.cc
    • ash/test/ui_controls_factory_ash.cc
    • ash/utility/screenshot_controller_unittest.cc
    • ash/wayland/wayland_server_controller.cc
    • ash/wayland/wayland_server_controller.h
    • ash/window_factory.cc
    • ash/window_factory.h
    • ash/window_user_data_unittest.cc
    • ash/wm/ash_focus_rules_unittest.cc
    • ash/wm/cursor_manager_chromeos.cc
    • ash/wm/drag_window_controller.cc
    • ash/wm/drag_window_resizer_unittest.cc
    • ash/wm/immersive_fullscreen_controller_unittest.cc
    • ash/wm/native_cursor_manager_ash_classic.cc
    • ash/wm/non_client_frame_controller.cc
    • ash/wm/overview/window_selector_unittest.cc
    • ash/wm/stacking_controller_unittest.cc
    • ash/wm/system_gesture_event_filter_unittest.cc
    • ash/wm/system_modal_container_layout_manager_unittest.cc
    • ash/wm/top_level_window_factory.cc
    • ash/wm/toplevel_window_event_handler.cc
    • ash/wm/toplevel_window_event_handler_unittest.cc
    • ash/wm/video_detector.cc
    • ash/wm/window_dimmer.cc
    • ash/wm/window_dimmer_unittest.cc
    • ash/wm/workspace/workspace_event_handler_unittest.cc
    • ash/wm/workspace/workspace_layout_manager_unittest.cc
    • ash/wm/workspace/workspace_window_resizer_unittest.cc
    • ash/wm/workspace_controller_unittest.cc
    • ash/ws/window_service_owner.cc
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
    • chrome/browser/ui/ash/ksv/DEPS
    • chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_util.cc
    • components/exo/test/exo_test_base.cc
    • components/exo/wayland/clients/test/wayland_client_test.cc
    • ui/aura/env.cc
    • ui/aura/env.h
    • ui/aura/test/test_windows.cc
    • ui/aura/test/test_windows.h
    • ui/aura/window.cc
    • ui/aura/window.h
    • ui/aura/window_tree_host_platform.cc
    • ui/base/ui_base_features.cc
    • ui/base/ui_base_features.h
  4. Deliver bounds information to CreateTooltipWidget

    Changed by Julie Jeongeun Kim - jkimohnoyoudont@igalia.com
    Changed at Saturday, 11-Aug-18 03:37:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 490c27babbe440762253c71c8ddc2438d3814d0e

    Comments

    Deliver bounds information to CreateTooltipWidget
    
    When 'CreateTooltipWidget' creates 'Widget' for tooltip and
    initializes it, it needs its bounds at InitParams. If it
    doesn't have the bounds information, some platform widgets
    get crashed and DesktopWindowTreeHostX11 keeps
    |sanitized_params| to avoid this case.
    
    This patch delivers the bounds for the tooltip widget and
    adds DCHECK to find what causes the empty bounds.
    
    Bug: 849585
    Change-Id: I3de067a917e4343bab642c3a1b13434b6cfaeee0
    Reviewed-on: https://chromium-review.googlesource.com/1086820
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#582426}

    Changed files

    • ui/platform_window/x11/x11_window_base.cc
    • ui/views/corewm/tooltip_aura.cc
    • ui/views/corewm/tooltip_aura.h