Home | Search | chromium - Builders
Login

Builder Linux CFI Build 10674 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision863a437d0fdbbba19ad5446420b72d2f91748a72
Got Revision863a437d0fdbbba19ad5446420b72d2f91748a72

Execution:

Steps and Logfiles:

Show:
  1. ( 315 ms ) setup_build
    running recipe: "chromium"
  2. ( 225 ms ) report builders
     
    running builder/tester 'Linux CFI' on master 'chromium.memory'
  3. ( 53 secs ) bot_update
    [79GB/295GB used (26%)]
  4. ( 605 ms ) swarming.py --version
    0.13
  5. ( 10 secs ) gclient runhooks
  6. ( 959 ms ) read test spec (chromium.memory.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.memory.json
  7. ( 490 ms ) lookup GN args
     
    dcheck_always_on = true
    is_cfi = true
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    use_cfi_cast = true
    use_cfi_diag = true
    use_goma = true
    use_thin_lto = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 12 secs ) generate_build_files
  9. ( 41 mins 51 secs ) compile
  10. ( 48 secs ) isolate tests
  11. ( 455 ms ) find isolated tests
  12. ( 1 secs ) accessibility_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  13. ( 3 secs ) angle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 54s
  14. ( 1 secs ) app_shell_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  15. ( 1 secs ) aura_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  16. ( 3 secs ) base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:16.894533
  17. ( 1 secs ) blink_common_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  18. ( 1 secs ) blink_fuzzer_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 26s
  19. ( 1 secs ) blink_heap_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  20. ( 2 secs ) blink_platform_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  21. ( 1 secs ) boringssl_crypto_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  22. ( 1 secs ) boringssl_ssl_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  23. ( 1 secs ) cacheinvalidation_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  24. ( 1 secs ) capture_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  25. ( 1 secs ) cast_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  26. ( 2 secs ) cc_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:24.009178
  27. ( 1 secs ) chrome_app_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 27s
  28. ( 1 secs ) chromedriver_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  29. ( 1 secs ) components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 49s
  30. ( 1 secs ) network_service_components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 45s
  31. ( 8 secs ) components_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:27.866657
  32. ( 1 secs ) compositor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  33. ( 10 mins 41 secs ) content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:14:03.682601
  34. ( 1 secs ) perfetto_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  35. ( 5 secs ) content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 51s
  36. ( 1 secs ) cronet_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  37. ( 1 secs ) cronet_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  38. ( 1 secs ) crypto_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  39. ( 1 secs ) dbus_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  40. ( 1 secs ) device_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  41. ( 1 secs ) display_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  42. ( 1 secs ) events_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  43. ( 1 secs ) extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:12.205273
  44. ( 1 secs ) network_service_extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:05.508817
  45. ( 1 secs ) extensions_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 31s
  46. ( 1 secs ) filesystem_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  47. ( 1 secs ) gcm_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  48. ( 3 secs ) gfx_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  49. ( 1 secs ) gin_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  50. ( 1 secs ) gl_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 22s
  51. ( 1 secs ) gl_unittests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 6s
  52. ( 1 secs ) google_apis_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 25s
  53. ( 2 secs ) gpu_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  54. ( 1 secs ) headless_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 47s
  55. ( 1 secs ) headless_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  56. ( 1 secs ) webui_polymer2_interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:16.963199
  57. ( 1 secs ) ipc_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  58. ( 1 secs ) jingle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  59. ( 1 secs ) latency_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  60. ( 1 secs ) leveldb_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  61. ( 1 secs ) libjingle_xmpp_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  62. ( 3 secs ) media_blink_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  63. ( 1 secs ) media_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  64. ( 2 secs ) media_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 24s
  65. ( 1 secs ) message_center_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  66. ( 1 secs ) midi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  67. ( 1 secs ) mojo_core_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  68. ( 1 secs ) mojo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  69. ( 1 secs ) nacl_helper_nonsfi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  70. ( 1 secs ) nacl_loader_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  71. ( 1 secs ) native_theme_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  72. ( 16 secs ) net_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:04:47.556584
  73. ( 1 secs ) pdf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  74. ( 1 secs ) ppapi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  75. ( 1 secs ) printing_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  76. ( 1 secs ) remoting_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  77. ( 1 secs ) sandbox_linux_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  78. ( 1 secs ) service_manager_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  79. ( 5 secs ) services_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 31s
  80. ( 1 secs ) shell_dialogs_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 4s
  81. ( 1 secs ) skia_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  82. ( 1 secs ) snapshot_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  83. ( 1 secs ) sql_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  84. ( 1 secs ) storage_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  85. ( 2 secs ) sync_integration_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:05:19.964980
  86. ( 1 secs ) traffic_annotation_auditor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  87. ( 1 secs ) ui_base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  88. ( 1 secs ) ui_touch_selection_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 19s
  89. ( 4 secs ) unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:03.360572
  90. ( 1 secs ) url_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  91. ( 4 secs ) views_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  92. ( 1 secs ) viz_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:10.476456
  93. ( 1 secs ) vr_common_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  94. ( 1 secs ) vr_pixeltests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  95. ( 4 secs ) webkit_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:11.031129
  96. ( 1 secs ) wm_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  97. ( 1 secs ) wtf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  98. ( 6 secs ) network_service_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:07:47.848991 (shard #0)
    Min shard duration: 0:07:26.589527 (shard #1)
  99. ( 1 secs ) interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:05:05.792607 (shard #0)
    Min shard duration: 0:03:53.388303 (shard #1)
  100. ( 2 secs ) network_service_interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:05:02.830637 (shard #2)
    Min shard duration: 0:04:01.343852 (shard #1)
  101. ( 2 secs ) webui_polymer2_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:09:13.186729 (shard #2)
    Min shard duration: 0:07:31.462381 (shard #0)
  102. ( 7 secs ) browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:13:40.121887 (shard #2)
    Min shard duration: 0:10:35.563053 (shard #9)
  103. ( 11 secs ) network_service_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:09:21.399986 (shard #2)
    Min shard duration: 0:07:07.754914 (shard #9)
  104. ( 1 secs ) Tests statistics
     
    Stats
    Total shards: 123
    Total runtime: 5:54:01.350417
     
  105. ( 2 ms ) recipe result

Build Properties:

NameValueSource
$build/goma {"jobs": 500} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm787-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539350113650683, "id": "8932868131187591264", "project": "chromium", "tags": ["builder:Linux CFI", "buildset:commit/git/863a437d0fdbbba19ad5446420b72d2f91748a72", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/863a437d0fdbbba19ad5446420b72d2f91748a72", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9098298193300626000", "scheduler_job_id:chromium/Linux CFI", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Linux CFI" setup_build
buildnumber 10674 setup_build
mastername "chromium.memory" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "863a437d0fdbbba19ad5446420b72d2f91748a72" setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "863a437d0fdbbba19ad5446420b72d2f91748a72" bot_update
got_revision_cp "refs/heads/master@{#599189}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "55d1af14751ad10e0cae741240f013ea67039f45" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25138}" bot_update
swarm_hashes_refs/heads/master(at){#599189}_without_patch {"accessibility_unittests": "50c447d87e1297a311bee687381d180f1412884e", "angle_unittests": "5e6d94b68b359ece14e836bdd520418e89ce7fae", "app_shell_unittests": "a11c5bbbc0fb5d559c6e96a2bb83ca4cc00f411e", "aura_unittests": "af2527a3ac677bcec283c3433c2b250d0f22a01c", "base_unittests": "2895d7599b580dfa3be23eb0abe3c50cf6fba80d", "blink_common_unittests": "cd1f5b6e36593a2eb22ddcbf57dc22bca60c45b0", "blink_fuzzer_unittests": "b2a8d1fa38238704a92895c6ad77c5d352fb16e1", "blink_heap_unittests": "70ecf4937a6318c4a267a4949387aa408176a470", "blink_platform_unittests": "7ce47737dc6262f97b0813aefb4181cfd50c0c3c", "boringssl_crypto_tests": "19effff61898722949543f577e36bf5df7247493", "boringssl_ssl_tests": "ff62379569451ba8fe59eeba976e8954ebf502ed", "browser_tests": "d9b178ef22ba15d278946c8576146b2ab0b94ff8", "cacheinvalidation_unittests": "0f8f989e876affa514bed12093f3a058477357b1", "capture_unittests": "76e696e2fcf4d6f4a16a6dd12aeb23b4b9919654", "cast_unittests": "8ed5f01f9bde3957007a26adf1051545bb705526", "cc_unittests": "0e895665762fcfe57421253a25ae4933a0f522c4", "chrome_app_unittests": "f30334d5af7cb96d09b29c1a10d53dbe6dae497e", "chromedriver_unittests": "28f148c13cc7834301e19db51ecaf5edfe2957f9", "components_browsertests": "789dab9a1ee118990d90d5a0507edc12fd1b967f", "components_unittests": "bd621d95358dfeda1c4496a26457d58a45e54ee1", "compositor_unittests": "724827be9b255a752feff7efe0f54c1a9b95445e", "content_browsertests": "c617dae960e34f54d8e556e8ddabdd6b991c2428", "content_unittests": "c31c0af44e7bf14c46fd82e589fc34a46136f43a", "cronet_tests": "ee331554c6fb55ed81acb2a5fdce6e61ea70ac9c", "cronet_unittests": "435244ed4b4fca177964d0d8da6ef603fac4a53c", "crypto_unittests": "ac56cd073f71d9e03cacebeef0bd62e6a1fc395d", "dbus_unittests": "ae28f623094bc241713dbbd8932344e1bbce65f9", "device_unittests": "9e8b705cf98b23fe3f7aa2d5c08ad7dc0c64d853", "display_unittests": "58aaa05852893a1776de01a41126c58db73c8606", "events_unittests": "2e278193170f25c8beb3ed1ab485bc0366843a06", "extensions_browsertests": "c45be3962f3a0c33e7c0eb79dd61220bb350f272", "extensions_unittests": "97fb5fae8301d54b0b2ae7a61dd007171e3b5648", "filesystem_service_unittests": "b733a30c22242e634f7f13fe6757a463f812ed3c", "gcm_unit_tests": "bc7ef51a42f01d62ed5ab0ade2634a6f4e7ff64e", "gfx_unittests": "6f6763d43413bf96f2cbad3a631c8975e03442bf", "gin_unittests": "739065a0990fdcad83582530ed95ac526f8f1c92", "gl_tests": "5689c44ed8402759f14fbf76aa50df0d3e5391d1", "gl_unittests": "138f15e1c18759341dab8991207a339b0d3d2f7c", "google_apis_unittests": "73928896a67a74dd4fde0ccbcef1a9100d9f5fdd", "gpu_unittests": "b1f5305c9a2f34d33e243ebe5fdf8eac2c21b2c7", "headless_browsertests": "49557528733211d0ef4f4093fbd2b8163b9cba0e", "headless_unittests": "c029ad390bb095f7d1223c0f054943466b55e28e", "interactive_ui_tests": "fde4b1252416db714fb09e9ebdd299ea4de63dae", "ipc_tests": "836de4eec20ecee71c4f37be7ce1f37dc969e175", "jingle_unittests": "a85fca1d151121ff106f10f5400baffc873c0163", "latency_unittests": "45148da854c66131ee66ea9ec4f889b2e7742da1", "leveldb_service_unittests": "0f0c80e6ae71cbb27da5ee89c5639a9c6e42d41f", "libjingle_xmpp_unittests": "65fb1552d0ac847e81b212bd23a62c65e542aa82", "media_blink_unittests": "3a73c889b33dba27a1cf10addd073ef170db451d", "media_service_unittests": "ad36352cf1c9622ab48253f1e6a10d2ec791bde3", "media_unittests": "6c23c5146c8c7dfabec744adf32f25794c0680f0", "message_center_unittests": "8245d3986c9bc591e712956d5b2ad49d2e0e12ff", "midi_unittests": "0280767ba02edba6004f733996ff53b6eff643d7", "mojo_core_unittests": "6a323c98665ab116c13a3c4ce18db43d1ff40726", "mojo_unittests": "dad65bd2d4a06325ed83af7189642066b4e405ca", "nacl_helper_nonsfi_unittests": "586a54405c756726a0d993abb74a13126e73c2b8", "nacl_loader_unittests": "75c36f73f66330fb8bda1ef276ff02eeb7700d71", "native_theme_unittests": "e89aedd1c04d752b0afbd63ed151f15bab804af5", "net_unittests": "58236c26fe7f1a47058a87f575d8c371820f08a2", "pdf_unittests": "5326a0a9a0a2f7242802054ecc9d78741e5eaee9", "ppapi_unittests": "22340af25e0c00d8bff44227a7961a9ab9058a78", "printing_unittests": "244fdb6eaad806d5caec42883e359d95058e635c", "remoting_unittests": "b0bb3ab2aa5a2b75168f24f9235b6009d42f4f0e", "sandbox_linux_unittests": "5efb8a071a082022377ab128ca0e441eb73d4ad3", "service_manager_unittests": "e975a5341700ce3c1acedd5f95ddbd4158012fb1", "services_unittests": "cc94e07d491f2b33567d1ab4b5a54f1d01607cc6", "shell_dialogs_unittests": "d06de1ff2903b1e689d6e3ee65999a56189c4b5f", "skia_unittests": "0c6fba73acb68d768ef2a31da2ee3cf8a0f6a5c4", "snapshot_unittests": "4317981532468bcecbbc3637ca78f6c7233ef66d", "sql_unittests": "4f18723b0eb8c324a820af067f160f3b99c35361", "storage_unittests": "9325d3632ed42498c6439656d7d1123f2bdc034b", "sync_integration_tests": "9345b1aba37dbbfc93e31d134aafc2982fdd3709", "traffic_annotation_auditor_unittests": "cfbc6db3f8666d1fdfe3bf0dff38f87ec5789a4c", "ui_base_unittests": "3cce4c1a8f67bff4197f17fd7663141022deda83", "ui_touch_selection_unittests": "4aad51d0acc4d555d446545c6a999fe78cf62a16", "unit_tests": "4f89cfffd2f72d0232d18fdfa787cca5856545e6", "url_unittests": "65accf76d295362f6487f05294762b6e1b4647a0", "views_unittests": "ceb3e82eee8973d532987db5098a0418d5e0d3ba", "viz_unittests": "a682723ee17c8de93406b85715568edcf410dce0", "vr_common_unittests": "9fb72306c4bca1491d729866124b6ad182c713af", "vr_pixeltests": "df20e9b4dc1287e434e1c1725036d61e6f7653cf", "webkit_unit_tests": "f69c090185ddb854f04fcdcd72017e8391ac0586", "wm_unittests": "602c93fd9c8ca9eb76fe54c867788201fda83219", "wtf_unittests": "4f65b5ab3365cc44f95f6a93a65ead1818671cde"} isolate tests
swarm_hashes {"accessibility_unittests": "50c447d87e1297a311bee687381d180f1412884e", "angle_unittests": "5e6d94b68b359ece14e836bdd520418e89ce7fae", "app_shell_unittests": "a11c5bbbc0fb5d559c6e96a2bb83ca4cc00f411e", "aura_unittests": "af2527a3ac677bcec283c3433c2b250d0f22a01c", "base_unittests": "2895d7599b580dfa3be23eb0abe3c50cf6fba80d", "blink_common_unittests": "cd1f5b6e36593a2eb22ddcbf57dc22bca60c45b0", "blink_fuzzer_unittests": "b2a8d1fa38238704a92895c6ad77c5d352fb16e1", "blink_heap_unittests": "70ecf4937a6318c4a267a4949387aa408176a470", "blink_platform_unittests": "7ce47737dc6262f97b0813aefb4181cfd50c0c3c", "boringssl_crypto_tests": "19effff61898722949543f577e36bf5df7247493", "boringssl_ssl_tests": "ff62379569451ba8fe59eeba976e8954ebf502ed", "browser_tests": "d9b178ef22ba15d278946c8576146b2ab0b94ff8", "cacheinvalidation_unittests": "0f8f989e876affa514bed12093f3a058477357b1", "capture_unittests": "76e696e2fcf4d6f4a16a6dd12aeb23b4b9919654", "cast_unittests": "8ed5f01f9bde3957007a26adf1051545bb705526", "cc_unittests": "0e895665762fcfe57421253a25ae4933a0f522c4", "chrome_app_unittests": "f30334d5af7cb96d09b29c1a10d53dbe6dae497e", "chromedriver_unittests": "28f148c13cc7834301e19db51ecaf5edfe2957f9", "components_browsertests": "789dab9a1ee118990d90d5a0507edc12fd1b967f", "components_unittests": "bd621d95358dfeda1c4496a26457d58a45e54ee1", "compositor_unittests": "724827be9b255a752feff7efe0f54c1a9b95445e", "content_browsertests": "c617dae960e34f54d8e556e8ddabdd6b991c2428", "content_unittests": "c31c0af44e7bf14c46fd82e589fc34a46136f43a", "cronet_tests": "ee331554c6fb55ed81acb2a5fdce6e61ea70ac9c", "cronet_unittests": "435244ed4b4fca177964d0d8da6ef603fac4a53c", "crypto_unittests": "ac56cd073f71d9e03cacebeef0bd62e6a1fc395d", "dbus_unittests": "ae28f623094bc241713dbbd8932344e1bbce65f9", "device_unittests": "9e8b705cf98b23fe3f7aa2d5c08ad7dc0c64d853", "display_unittests": "58aaa05852893a1776de01a41126c58db73c8606", "events_unittests": "2e278193170f25c8beb3ed1ab485bc0366843a06", "extensions_browsertests": "c45be3962f3a0c33e7c0eb79dd61220bb350f272", "extensions_unittests": "97fb5fae8301d54b0b2ae7a61dd007171e3b5648", "filesystem_service_unittests": "b733a30c22242e634f7f13fe6757a463f812ed3c", "gcm_unit_tests": "bc7ef51a42f01d62ed5ab0ade2634a6f4e7ff64e", "gfx_unittests": "6f6763d43413bf96f2cbad3a631c8975e03442bf", "gin_unittests": "739065a0990fdcad83582530ed95ac526f8f1c92", "gl_tests": "5689c44ed8402759f14fbf76aa50df0d3e5391d1", "gl_unittests": "138f15e1c18759341dab8991207a339b0d3d2f7c", "google_apis_unittests": "73928896a67a74dd4fde0ccbcef1a9100d9f5fdd", "gpu_unittests": "b1f5305c9a2f34d33e243ebe5fdf8eac2c21b2c7", "headless_browsertests": "49557528733211d0ef4f4093fbd2b8163b9cba0e", "headless_unittests": "c029ad390bb095f7d1223c0f054943466b55e28e", "interactive_ui_tests": "fde4b1252416db714fb09e9ebdd299ea4de63dae", "ipc_tests": "836de4eec20ecee71c4f37be7ce1f37dc969e175", "jingle_unittests": "a85fca1d151121ff106f10f5400baffc873c0163", "latency_unittests": "45148da854c66131ee66ea9ec4f889b2e7742da1", "leveldb_service_unittests": "0f0c80e6ae71cbb27da5ee89c5639a9c6e42d41f", "libjingle_xmpp_unittests": "65fb1552d0ac847e81b212bd23a62c65e542aa82", "media_blink_unittests": "3a73c889b33dba27a1cf10addd073ef170db451d", "media_service_unittests": "ad36352cf1c9622ab48253f1e6a10d2ec791bde3", "media_unittests": "6c23c5146c8c7dfabec744adf32f25794c0680f0", "message_center_unittests": "8245d3986c9bc591e712956d5b2ad49d2e0e12ff", "midi_unittests": "0280767ba02edba6004f733996ff53b6eff643d7", "mojo_core_unittests": "6a323c98665ab116c13a3c4ce18db43d1ff40726", "mojo_unittests": "dad65bd2d4a06325ed83af7189642066b4e405ca", "nacl_helper_nonsfi_unittests": "586a54405c756726a0d993abb74a13126e73c2b8", "nacl_loader_unittests": "75c36f73f66330fb8bda1ef276ff02eeb7700d71", "native_theme_unittests": "e89aedd1c04d752b0afbd63ed151f15bab804af5", "net_unittests": "58236c26fe7f1a47058a87f575d8c371820f08a2", "pdf_unittests": "5326a0a9a0a2f7242802054ecc9d78741e5eaee9", "ppapi_unittests": "22340af25e0c00d8bff44227a7961a9ab9058a78", "printing_unittests": "244fdb6eaad806d5caec42883e359d95058e635c", "remoting_unittests": "b0bb3ab2aa5a2b75168f24f9235b6009d42f4f0e", "sandbox_linux_unittests": "5efb8a071a082022377ab128ca0e441eb73d4ad3", "service_manager_unittests": "e975a5341700ce3c1acedd5f95ddbd4158012fb1", "services_unittests": "cc94e07d491f2b33567d1ab4b5a54f1d01607cc6", "shell_dialogs_unittests": "d06de1ff2903b1e689d6e3ee65999a56189c4b5f", "skia_unittests": "0c6fba73acb68d768ef2a31da2ee3cf8a0f6a5c4", "snapshot_unittests": "4317981532468bcecbbc3637ca78f6c7233ef66d", "sql_unittests": "4f18723b0eb8c324a820af067f160f3b99c35361", "storage_unittests": "9325d3632ed42498c6439656d7d1123f2bdc034b", "sync_integration_tests": "9345b1aba37dbbfc93e31d134aafc2982fdd3709", "traffic_annotation_auditor_unittests": "cfbc6db3f8666d1fdfe3bf0dff38f87ec5789a4c", "ui_base_unittests": "3cce4c1a8f67bff4197f17fd7663141022deda83", "ui_touch_selection_unittests": "4aad51d0acc4d555d446545c6a999fe78cf62a16", "unit_tests": "4f89cfffd2f72d0232d18fdfa787cca5856545e6", "url_unittests": "65accf76d295362f6487f05294762b6e1b4647a0", "views_unittests": "ceb3e82eee8973d532987db5098a0418d5e0d3ba", "viz_unittests": "a682723ee17c8de93406b85715568edcf410dce0", "vr_common_unittests": "9fb72306c4bca1491d729866124b6ad182c713af", "vr_pixeltests": "df20e9b4dc1287e434e1c1725036d61e6f7653cf", "webkit_unit_tests": "f69c090185ddb854f04fcdcd72017e8391ac0586", "wm_unittests": "602c93fd9c8ca9eb76fe54c867788201fda83219", "wtf_unittests": "4f65b5ab3365cc44f95f6a93a65ead1818671cde"} find isolated tests

Blamelist:

  1. Colin Blundell (blundellohnoyoudont@chromium.org)
  2. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  3. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  4. Morten Stenshorne (mstenshoohnoyoudont@chromium.org)
  5. Christian Dullweber (dullweberohnoyoudont@chromium.org)
  6. Xida Chen (xidachenohnoyoudont@chromium.org)
  7. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  8. David Davidović (davidovicohnoyoudont@google.com)
  9. Rune Lillesveen (futharkohnoyoudont@chromium.org)
  10. Florent Castelli (orphisohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 13:15:13 UTC
Start Friday, 12-Oct-18 13:15:17 UTC
End Friday, 12-Oct-18 14:21:50 UTC
Pending 3 secs
Execution 1 hrs 6 mins

All Changes:

  1. Start using IdentityTestEnvironment in ProfileSyncServiceBundle

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:10:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 863a437d0fdbbba19ad5446420b72d2f91748a72

    Comments

    Start using IdentityTestEnvironment in ProfileSyncServiceBundle
    
    ProfileSyncServiceBundle owns and exposes signin-related objects for
    use by sync tests. These signin-related objects include ones that are
    deprecated by IdentityManager and no longer used directly in the
    production code being tested; however, up until now it has not been
    feasible to convert this test utility to using IdentityTestEnvironment,
    as doing so would have required converting the widespread usage of this
    utility in one go.
    
    We recently introduced an IdentityTestEnvironment usage mode wherein
    it can be supplied with IdentityManager's dependencies from the
    external client, precisely to enable incremental conversion in use cases
    like this. This CL exploits this usage mode to introduce
    IdentityTestEnvironment in ProfileSyncServiceBundle.h and provide an
    example of its usage to eliminate a direct usage of the deprecated
    classes. Once the conversion is complete, ProfileSyncServiceBundle can
    then be changed to *only* hold an IdentityTestEnvironment object.
    
    Bug: 886600, 886599
    Change-Id: I205c3567fc0a9bcd6f7b613c00a247c302d71be5
    Reviewed-on: https://chromium-review.googlesource.com/c/1273065
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599189}

    Changed files

    • components/browser_sync/BUILD.gn
    • components/browser_sync/profile_sync_service_autofill_unittest.cc
    • components/browser_sync/profile_sync_test_util.cc
    • components/browser_sync/profile_sync_test_util.h
  2. Import wpt@e8a20c396e2ed7b7b8b2cacd3128f959e710a243

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:59:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c12ec9eedc27e721f93de806016cfcf26225fde9

    Comments

    Import wpt@e8a20c396e2ed7b7b8b2cacd3128f959e710a243
    
    Using wpt-import in Chromium 68550e484d7eecf6bd1d39fca300644ab2c21f5d.
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25974
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    NOAUTOREVERT=true
    TBR=lukebjerring
    
    No-Export: true
    Change-Id: I132a332cdc953a69e5c54c550a9bb4e5d08c9bb5
    Reviewed-on: https://chromium-review.googlesource.com/c/1277603
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599188}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/webrtc.idl
  3. Roll src-internal f37e9866851d..2cecd6e79600 (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 12:56:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2f64dae1358dab03fb6fb5e12fc444dad20d38f4

    Comments

    Roll src-internal f37e9866851d..2cecd6e79600 (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f37e9866851d..2cecd6e79600
    
    
    Created with:
      gclient setdep -r src-internal@2cecd6e79600
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Iac9c77c5c0927e0ca3862bf5171f5972e5c40ca7
    Reviewed-on: https://chromium-review.googlesource.com/c/1278711
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599187}

    Changed files

    • DEPS
  4. [LayoutNG] Mark nopaint-after-layer-destruction.html as passing again.

    Changed by Morten Stenshorne - mstenshoohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:45:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 17f212ee41ac78c428f851f24fa76ffee0ec8c3d

    Comments

    [LayoutNG] Mark nopaint-after-layer-destruction.html as passing again.
    
    Needed some rebaselining on Mac.
    
    Attempted to mark it as passing here:
    https://chromium-review.googlesource.com/c/1277649
    
    Then a sheriff marked it as failing again:
    https://chromium-review.googlesource.com/c/chromium/src/+/1278785
    
    TBR=kojii@chromium.org,orphis@chromium.org
    
    Change-Id: I4b282cba19e6c94f032c127f70672cf4cfe133ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1278805
    Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599186}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/platform/mac/fast/block/float/nopaint-after-layer-destruction-expected.txt
    • third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng/fast/block/float/nopaint-after-layer-destruction-expected.png
  5. Log UserDeletedCookieOrCacheFromDialog from Android

    Changed by Christian Dullweber - dullweberohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:43:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aeec7095a6a5129132a4fe7e5f5f0abeb2cf8ff3

    Comments

    Log UserDeletedCookieOrCacheFromDialog from Android
    
    We currently log the UserDeletedCookieOrCacheFromDialog histogram from
    Desktop. On Android we only know about total cookie/cache deletion
    and not those started from CBD.
    This CL adds logging of the UserDeletedCookieOrCacheFromDialog histogram
    to the CBD dialog on Android.
    
    Change-Id: I51c1ff6d3c5dc6f531f5bfccc59f522718b1abef
    Reviewed-on: https://chromium-review.googlesource.com/c/1276605
    Commit-Queue: Christian Dullweber <dullweber@chromium.org>
    Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599185}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesBasic.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java
    • content/public/android/BUILD.gn
    • content/public/browser/browsing_data_remover.h
  6. Rename OnHasTouchEventHandlersForTest in InputRouterImpl

    Changed by Xida Chen - xidachenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:40:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0f7980b37fba64a72e95e35f17633e6cb3915321

    Comments

    Rename OnHasTouchEventHandlersForTest in InputRouterImpl
    
    The call site of this function is resetting the |allowed_touch_action_|
    only, so rename this function to ForceResetTouchActionForTest.
    
    This CL should not introduce any behavior change.
    
    Bug: None
    Change-Id: I253d73f4f21bdb6268f43ce535453412f4b32c51
    Reviewed-on: https://chromium-review.googlesource.com/c/1277947
    Commit-Queue: Xida Chen <xidachen@chromium.org>
    Reviewed-by: James MacLean <wjmaclean@chromium.org>
    Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599184}

    Changed files

    • content/browser/renderer_host/input/input_router_impl.cc
    • content/browser/renderer_host/input/input_router_impl.h
    • content/browser/renderer_host/input/touch_action_filter.cc
    • content/browser/renderer_host/input/touch_action_filter.h
    • content/browser/site_per_process_hit_test_browsertest.cc
    • content/public/test/browser_test_utils.cc
  7. Roll src/third_party/webrtc 28d200c24624..55d1af14751a (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 12:35:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9729f6efb4bae858cc91b281091f2df86433da8a

    Comments

    Roll src/third_party/webrtc 28d200c24624..55d1af14751a (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/28d200c24624..55d1af14751a
    
    
    git log 28d200c24624..55d1af14751a --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 terelius@webrtc.org Remove support for microsecond resolution in RtcEventLogs.
    2018-10-12 sprang@webrtc.org Move TemporalLayers to api/video_codecs.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@55d1af14751a
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I15b74c4ebe322c1004b1ba8d1cfb25d82b65614c
    Reviewed-on: https://chromium-review.googlesource.com/c/1278709
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599183}

    Changed files

    • DEPS
  8. Reland "[sync::test] Add single client integration test for custom passphrase"

    Changed by David Davidović - davidovicohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 12:18:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d1df3c494cc8dc1ef26ec3514b74b27c3047a4db

    Comments

    Reland "[sync::test] Add single client integration test for custom passphrase"
    
    This is a reland of 475bfe9da1df9ab55685e0a9ce1a62d8e50536f1. Fixed test
    failures which happened because some DCHECKs had side effects.
    
    Original change's description:
    > [sync::test] Add single client integration test for custom passphrase
    >
    > Add a Sync integration test which exercises custom passphrase flows, including
    > the handling and proper functioning of the newly added key derivation method
    > (scrypt).
    >
    > Add an integration test helper file for encryption-related tasks and modify
    > FakeServer and LoopbackServer to allow easier modification of persistent
    > entities such as Nigori. Add passphrase-related functionality to
    > ProfileSyncServiceHarness to give tests better control over how and when
    > passphrase-based encryption is enabled.
    >
    > The test uses a gray-box approach, where it tests the client at the
    > ProfileSyncService granularity, but injects and inspects entities on the (fake)
    > server to ensure that encryption is performed properly. This is necessary
    > because, when it comes to encryption, we are not interested merely in that it
    > does not hinder existing functionality (e.g. two clients are syncing data
    > properly in the presence of a custom passphrase), but also that it provides the
    > expected security to the user. For this reason, we use our knowledge of the
    > encryption architecture internals to ensure that the data committed to the
    > server is encrypted in the expected way.
    >
    > Bug: 894148
    > Change-Id: I728f7f18cc0db7b1da50f747a87a640877d0b023
    > Reviewed-on: https://chromium-review.googlesource.com/c/1274205
    > Commit-Queue: David Davidović <davidovic@google.com>
    > Reviewed-by: vitaliii <vitaliii@chromium.org>
    > Reviewed-by: Marc Treib <treib@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#598912}
    
    Bug: 894148
    Change-Id: I752acff5815531c0c83ebefb43fb620a785e3ca3
    Reviewed-on: https://chromium-review.googlesource.com/c/1278790
    Commit-Queue: David Davidović <davidovic@google.com>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Reviewed-by: vitaliii <vitaliii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599182}

    Changed files

    • chrome/browser/sync/test/integration/bookmarks_helper.cc
    • chrome/browser/sync/test/integration/bookmarks_helper.h
    • chrome/browser/sync/test/integration/encryption_helper.cc
    • chrome/browser/sync/test/integration/encryption_helper.h
    • chrome/browser/sync/test/integration/profile_sync_service_harness.cc
    • chrome/browser/sync/test/integration/profile_sync_service_harness.h
    • chrome/browser/sync/test/integration/single_client_custom_passphrase_sync_test.cc
    • chrome/browser/sync/test/integration/sync_test.cc
    • chrome/browser/sync/test/integration/sync_test.h
    • chrome/test/BUILD.gn
    • components/sync/engine_impl/loopback_server/loopback_server.cc
    • components/sync/engine_impl/loopback_server/loopback_server.h
    • components/sync/test/fake_server/fake_server.cc
    • components/sync/test/fake_server/fake_server.h
  9. Don't update style for focusability when render-blocking.

    Changed by Rune Lillesveen - futharkohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:16:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 369b6fca37d5b416775fd7fafdbc6bde78a18bf8

    Comments

    Don't update style for focusability when render-blocking.
    
    WebNode::IsFocusable() updated style and layout tree, without ignoring
    pending stylesheets, which meant generating a display:none placeholder
    style for the root node. Instead, early return from IsFocusable() when
    we are blocking rendering.
    
    Bug: 521692
    
    Change-Id: Idd6cfcf800e4173cfc1bdcb916728c7a0186edf9
    Reviewed-on: https://chromium-review.googlesource.com/c/1245787
    Reviewed-by: Stefan Zager <szager@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599181}

    Changed files

    • third_party/blink/renderer/core/exported/web_node.cc
    • third_party/blink/renderer/core/exported/web_node_test.cc
  10. Revert "[blink] Control ScriptStreamer with ScriptResource"

    Changed by Florent Castelli - orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:16:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7590d68012b9cf52c14e3f44e019ea36ecc2d9e

    Comments

    Revert "[blink] Control ScriptStreamer with ScriptResource"
    
    This reverts commit 7bd9163502462762e58d8010577dbf36aeef6c13.
    
    Reason for revert: fast/css-grid-layout/grid-columns-rows-get-set.html is flaky
    Bug: 894792, 894795
    
    Original change's description:
    > [blink] Control ScriptStreamer with ScriptResource
    > 
    > Move the ScriptStreamer control logic from ClassicPendingScript to
    > ScriptResource. In the future, this will allow us to start streaming
    > a ScriptResource before the ClassicPendingScript is available, e.g on
    > preload.
    > 
    > The ClassicPendingScript now only sends one "finished" callback, from
    > ScriptResource. This callback is either when the streaming completes,
    > or when there is no streaming and the ClassicPendingScript has told
    > the ScriptResource that it doesn't intend to start streaming. In the
    > long run, we want all scripts to go through the streaming interface,
    > and we want ScriptResource to control when streaming starts, so the
    > "no more streaming" call will disappear -- however it is necessary to
    > maintain the current behaviour, and be able to control it with a
    > runtime flag.
    > 
    > Bug: chromium:865098
    > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
    > Reviewed-on: https://chromium-review.googlesource.com/c/1181430
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
    > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599148}
    
    TBR=kinuko@chromium.org,rmcilroy@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
    
    Change-Id: Id8e8df8f960c60c88762cdf837e7ba9eb74944d6
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:865098
    Reviewed-on: https://chromium-review.googlesource.com/c/1278758
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599180}

    Changed files

    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
    • third_party/blink/renderer/bindings/core/v8/script_streamer.cc
    • third_party/blink/renderer/bindings/core/v8/script_streamer.h
    • third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
    • third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
    • third_party/blink/renderer/core/inspector/inspector_trace_events.cc
    • third_party/blink/renderer/core/loader/document_loader.cc
    • third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
    • third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.h
    • third_party/blink/renderer/core/script/classic_pending_script.cc
    • third_party/blink/renderer/core/script/classic_pending_script.h
    • third_party/blink/renderer/core/script/document_write_intervention.cc
    • third_party/blink/renderer/core/script/pending_script.h
    • third_party/blink/renderer/platform/loader/fetch/resource.cc
    • third_party/blink/renderer/platform/loader/fetch/resource.h
    • tools/metrics/histograms/enums.xml