Builder Linux Builder Build 110722
Results:
Success
Trigger Info:
| Project | chromium |
| Revision | aeb9424e0834afbd96b136974805e34dc39b1e66 |
| Got Revision | aeb9424e0834afbd96b136974805e34dc39b1e66 |
Execution:
- Source: Task 42f7ed5e71c57c10
- Bot: swarm965-c4
- Recipe: chromium
Steps and Logfiles:
Show:-
- - no logs -
-
( 659 ms ) read test spec (chromium.linux.json)path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.linux.json
-
( 529 ms ) lookup GN argsffmpeg_branding = "Chrome"is_component_build = falseis_debug = falseproprietary_codecs = truestrip_absolute_paths_from_debug_symbols = trueuse_goma = truegoma_dir = "/b/swarming/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
-
- - no logs -
Build Properties:
| Name | Value | Source |
|---|---|---|
| $build/goma | {"jobs": 500} | setup_build |
| $recipe_engine/buildbucket | {"build": {"builder": {"bucket": "ci", "builder": "Linux Builder", "project": "chromium"}, "createTime": "2019-02-12T00:29:29.510692Z", "createdBy": "user:luci-scheduler@appspot.gserviceaccount.com", "id": "8921772880242500656", "infra": {"buildbucket": {"serviceConfigRevision": "ef156230f5cd7f8c23f689fa4dc7f92742cd904d"}, "recipe": {"cipdPackage": "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build", "name": "chromium"}, "swarming": {"hostname": "chromium-swarm.appspot.com"}}, "input": {"gitilesCommit": {"host": "chromium.googlesource.com", "id": "aeb9424e0834afbd96b136974805e34dc39b1e66", "project": "chromium/src", "ref": "refs/heads/master"}}, "number": 110722, "tags": [{"key": "builder", "value": "Linux Builder"}, {"key": "buildset", "value": "commit/git/aeb9424e0834afbd96b136974805e34dc39b1e66"}, {"key": "buildset", "value": "commit/gitiles/chromium.googlesource.com/chromium/src/+/aeb9424e0834afbd96b136974805e34dc39b1e66"}, {"key": "scheduler_invocation_id", "value": "9087202944386031760"}, {"key": "scheduler_job_id", "value": "chromium/Linux Builder"}, {"key": "user_agent", "value": "luci-scheduler"}]}} | setup_build |
| $recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
| $recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
| bot_id | "swarm965-c4" | setup_build |
| branch | "refs/heads/master" | setup_build |
| buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1549931369510692, "id": "8921772880242500656", "project": "chromium", "tags": ["build_address:luci.chromium.ci/Linux Builder/110722", "builder:Linux Builder", "buildset:commit/git/aeb9424e0834afbd96b136974805e34dc39b1e66", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/aeb9424e0834afbd96b136974805e34dc39b1e66", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9087202944386031760", "scheduler_job_id:chromium/Linux Builder", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
| buildername | "Linux Builder" | setup_build |
| buildnumber | 110722 | setup_build |
| mastername | "chromium.linux" | setup_build |
| path_config | "generic" | setup_build |
| recipe | "chromium" | setup_build |
| repository | "https://chromium.googlesource.com/chromium/src.git" | setup_build |
| revision | "aeb9424e0834afbd96b136974805e34dc39b1e66" | setup_build |
| got_angle_revision | "6b695c3ffb27ad1df71f4f1682dc7a1d8adc9f31" | bot_update |
| got_dawn_revision | "62e83971caa1099bdbc334817efa035047c90ddf" | bot_update |
| got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
| got_revision | "aeb9424e0834afbd96b136974805e34dc39b1e66" | bot_update |
| got_revision_cp | "refs/heads/master@{#631002}" | bot_update |
| got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
| got_v8_revision | "0e223be0fe07b0ae6eceb58b48cb1719c39db14e" | bot_update |
| got_v8_revision_cp | "refs/heads/7.4.137@{#1}" | bot_update |
| got_webrtc_revision | "f13c2cd9ee41f4ca572232a4e397b05449474632" | bot_update |
| got_webrtc_revision_cp | "refs/heads/master@{#26626}" | bot_update |
| isolate_server | "https://isolateserver.appspot.com" | isolate tests |
| swarm_hashes_refs/heads/master(at){#631002}_without_patch | {"accessibility_unittests": "a603e85879283ddca4a273d6c771a8ba5965aa58", "angle_unittests": "2ea6488d51b3f3870d61a1b368a5072c0063eaa4", "app_shell_unittests": "20ca2c5489ba4647918db90b95f606b4314f1ca9", "aura_unittests": "b2576dd578ffbbc40971d32fff9dfceb0b452069", "base_unittests": "9037ce44aa8b3cad07db6d9a25e520375aa3a387", "blink_common_unittests": "f6f8762a2af53986b0821571dab9daf70e39b0a1", "blink_fuzzer_unittests": "180bb0fe5dd57e2bad0abf9c6cd3fded9b87502e", "blink_heap_unittests": "6cc4fafbebf4f50efabd1a295f5a6d724216e335", "blink_platform_unittests": "0e5b2c4dd187d922fa0741f1c86f70b042c63fa1", "boringssl_crypto_tests": "2454191e79b69925d7dd3ad5eb393371668cf3cb", "boringssl_ssl_tests": "bb5ae6551343620dc00e4fb10ffca00b07028afc", "browser_tests": "055eead6522f4de1e3833be67f494561e149a929", "cacheinvalidation_unittests": "1b4dce87d81ea11f2ce83edf29bb4b98d2f53529", "capture_unittests": "94b3712d96d43ccec14558025c205c244d76273d", "cast_unittests": "6aab4614ab610c245e5661911b7bdeda4cdad9e2", "cc_unittests": "dd186b8baf84830bdbde22a1cb9a797e8a2de97d", "chrome_app_unittests": "ffdd1add6110651b867168fc5f9ce60b9a4a4649", "chromedriver_py_tests": "482ae48b5d0f3728f83f40f698f0a21cb4567351", "chromedriver_replay_unittests": "af039ee07397b927108951882aeb91eeff012f68", "chromedriver_unittests": "c7b9798e7bfd47c724daf7a600b64b6bfcafacfb", "components_browsertests": "a49955de72ad5878a0b80f3302a3e23168531123", "components_unittests": "77949544db5598985e4f4beac956470d343151e6", "compositor_unittests": "056d9a23eb89c1d3bc507cf5f393475b25849c17", "content_browsertests": "fb2369dd999349715919090d23bd3dab26c438d5", "content_shell_crash_test": "98386ad683baeb917d5a9e8cb8a1f63eded8dee8", "content_unittests": "9a6807e65857cd52279b87b8bc5203173532fa98", "cronet_tests": "10682e7b0b1c0808ea0f59b1719a1f1d9b41886e", "cronet_unittests": "23a59f726874fc0d02fb755c3864788113d91a0e", "crypto_unittests": "42555e9eb989fc9d60870e59be191ff3c832a61d", "dbus_unittests": "0742e6073a285333dbb7c3c09e2228135284387d", "device_unittests": "dca4f78a1ea5c1ea4c7fbe99beeb8788209e7457", "devtools_closure_compile": "195b56da4dfd58adc3cc361fc7e5032b7f53e03c", "devtools_eslint": "5c01cbfb7b17824ca69de708cdda41467fd88a36", "display_unittests": "2d829f13f1f2e5a8f15ac37d1d59603d13e6ce65", "events_unittests": "30cef5c77178565e352317d5d28fea8206b173e0", "extensions_browsertests": "5bc0ddddb33c9adda82e6a10625d633275154188", "extensions_unittests": "30cbc06f5e7152cc44abf818d140dd5f5979b63a", "filesystem_service_unittests": "6b5657251f3d938dc59f1c5e1b8e78e813cbd961", "gcm_unit_tests": "5946e910fe04eb15cabaeffd4ddee9ab72600e60", "gfx_unittests": "fc2a59091e7f08c177b405032e099a328de566f3", "gin_unittests": "eca97d224606dfeb624bea4aede415213311dc53", "google_apis_unittests": "700bac752ea85e893d0a1fd59b7ff66af03f978f", "gpu_unittests": "a16716dab1e4dfa2b812159ed9aa53a84d1dd731", "headless_browsertests": "fda5c68cfdd7fd7a3bae548c7a63e2a37502c39b", "headless_unittests": "7ea62977664807792661c604db188d409eeb6a24", "interactive_ui_tests": "fb825c01a633321433a4bef64c43b6bd657b2bf1", "ipc_tests": "910105051e0789770185ee39735facd3ffed013a", "jingle_unittests": "afefeca3ad38076401491ff956342d06e2df7359", "latency_unittests": "6b6c6fd70ae03e905b58be8962cda78052efd2af", "leveldb_service_unittests": "5fb61fd3412772b71be1134ccd25177f0db369b2", "libjingle_xmpp_unittests": "024f7812c1378a5bcca4c9d396b875a52d26e3a6", "media_blink_unittests": "aa892827ea721161db3d4318c1fda54e5278c957", "media_service_unittests": "ff19479bd2ed5e6a7b66539b3e3247162a33cf71", "media_unittests": "e9a8f2fab25e5d4a0f571ce0803a12ef07b1045e", "message_center_unittests": "b687ffe7b86e2980f8093e762116c7b669d81bad", "metrics_python_tests": "f238e9436fb92af0236d9e001f43acabc8897c68", "midi_unittests": "73787af2a54ac87b77ba5bf6c2aec61825ebde84", "mojo_core_unittests": "851423cfb3270a78e02f45fc1aad316c0b0da47c", "mojo_unittests": "66f51506dc23357dea910a52191b291c09f20a04", "nacl_helper_nonsfi_unittests": "66ef9aafbc8c9ee5bc58ed2943c0a06054685ab6", "nacl_loader_unittests": "d44fea4802ee9fe7b66a86f8efcd0f32e5cb3f4e", "native_theme_unittests": "07143c1fd30cd9487ac45c2ad712859d38fc501c", "net_unittests": "3b01ffb95cfcbffff72d6723fc47964671234a32", "pdf_unittests": "212ed2b157d8f3cc5d620a55f97d7ec2c2beed63", "ppapi_unittests": "0f3d0d88a37a29839a53e83250331fb24f2698a0", "printing_unittests": "9d70303be88dbb7477b86b5c0a9d2cf34943ca1d", "remoting_unittests": "22506739cf2e4d126ed9b459229cd0e85ca9721d", "sandbox_linux_unittests": "623db377dc916205f4bb4b3ca6614c7eb5067bda", "service_manager_unittests": "aa2a0d6310322c406f5e878f8cc9d59a9f8408f8", "services_unittests": "269f7b7e064d746c681ade096517f2b0da166ab4", "shell_dialogs_unittests": "56964c1cfa289bcd612ce15410a5219f63460754", "skia_unittests": "3694508623eff61b21711542398df91f566943fc", "snapshot_unittests": "bda41d1b66a7e43aaebb930678ec4c6c5f73fcf7", "sql_unittests": "7a588313ea0a7ac15161837ef4d9a229220e5d24", "storage_unittests": "3594603ec54fc2dbf9e31eae684d7d57e136f3b3", "sync_integration_tests": "52669bbdd8c5654dd7ae82d9f046e396193bf1b0", "telemetry_gpu_unittests": "910e83ec6c509869ddf3645fd6f5a36b7a0771d4", "telemetry_perf_unittests": "a60323e50289b583679360c55c6dd4fec581e707", "telemetry_unittests": "a129cf605989a3f13bdade823b3e3d140e9e5a0b", "traffic_annotation_auditor_unittests": "f607faf94aec1b2b2e17885af76620dfb5322018", "ui_base_unittests": "2a3096fc30448b6f51f04cc6a27b15821dbe00e7", "ui_touch_selection_unittests": "c17e3580e470e2ef31c9cb7d18ac32787083e6a4", "unit_tests": "d4365b04944dfffd624384003a6bafc80af9f3f6", "url_unittests": "cf8dc6d1b1049039fa990bb570315348439a8f66", "views_perftests": "4209a7500b5cb25c8628b5add4f49a91fc0b6a40", "views_unittests": "1af942de03119848491c50011eab602889acc179", "viz_unittests": "9955e3780c43f66cd5952dd9ac67c2b6103c02a3", "vr_common_unittests": "2bf34ab4a5ab137e97e75feca421486935611f74", "vr_pixeltests": "d0e9841d6e8f9bcc1063828536aa44215abc0a22", "webdriver_wpt_tests": "f77cb8f7961efe3d5a62ec3ecd5c88d01ff3bdbf", "webkit_layout_tests_exparchive": "b2b3d650654cda0ebd321c31081dadc5ebf4ff21", "webkit_python_tests": "d68a6c2b2a051f0fe0c392537fa5fd72e70042b9", "webkit_unit_tests": "bbaff54d9104f5e0401ffe02f4cdc4a8c07d4baf", "wm_unittests": "2867b040a610f7d08696cf47b70157d42a86cb97", "wtf_unittests": "4df5260e284fb45fa8d3b793fe9921f1979e5919"} | isolate tests |
| build_archive_url | "gs://chromium-linux-archive/chromium.linux/Linux Builder/full-build-linux_aeb9424e0834afbd96b136974805e34dc39b1e66.zip" | package build |
Blamelist:
- Dominic Farolino (domfarolinoohnoyoudont@gmail.com)
- Sammie Quon (sammiequonohnoyoudont@google.com)
- Daniel Rubery (druberyohnoyoudont@chromium.org)
- Suman Kancherla (sumankancherlaohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Nate Fischer (ntfschrohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Philip Rogers (pdrohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Becky Zhou (huayinzohnoyoudont@chromium.org)
- Robbie McElrath (rmcelrathohnoyoudont@chromium.org)
- wutao (wutaoohnoyoudont@chromium.org)
- Ella Ge (eirageohnoyoudont@chromium.org)
- Xiyuan Xia (xiyuanohnoyoudont@chromium.org)
- Sammie Quon (sammiequonohnoyoudont@google.com)
- Nico Weber (thakisohnoyoudont@chromium.org)
- Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
- Oystein Eftevaag (oysteineohnoyoudont@google.com)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Mounir Lamouri (mlamouriohnoyoudont@chromium.org)
- Henrique Ferreiro (hferreiroohnoyoudont@igalia.com)
- Jimmy Gong (jimmyxgongohnoyoudont@google.com)
- Xianzhu Wang (wangxianzhuohnoyoudont@chromium.org)
- Caleb Rouleau (crouleauohnoyoudont@chromium.org)
- Jamie Madill (jmadillohnoyoudont@chromium.org)
- Gyuyoung Kim (gyuyoungohnoyoudont@igalia.com)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- mark a. foltz (mfoltzohnoyoudont@chromium.org)
- Quan Nguyen (qnnguyenohnoyoudont@chromium.org)
- Lan Wei (lanweiohnoyoudont@chromium.org)
- Ian Kilpatrick (ikilpatrickohnoyoudont@chromium.org)
- Jeffrey Cohen (jeffreycohenohnoyoudont@chromium.org)
Timing:
| Create | Tuesday, 12-Feb-19 00:29:29 UTC |
| Start | Tuesday, 12-Feb-19 00:29:35 UTC |
| End | Tuesday, 12-Feb-19 01:47:43 UTC |
| Pending | 5 secs |
| Execution | 1 hrs 18 mins |
All Changes:
-
Implement TextEncoder()'s encodeInto method
Changed by Dominic Farolino - domfarolinoohnoyoudont@gmail.com Changed at Tuesday, 12-Feb-19 00:23:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision aeb9424e0834afbd96b136974805e34dc39b1e66 Comments
Implement TextEncoder()'s encodeInto method This CL implements the encodeInto method on the TextEncoder interface, which encodes a string into a given pre-allocated Uint8Array. This CL introduces an EncodeInto() method to TextCodecUTF8, which acts similar to EncodeCommon(), however is bound by a given capacity, and also outputs the number of converted UTF16 code units. EncodeInto() is called via an overloaded TextCodec::Encode() method, which is meant only to be implemented in TextCodecUTF8 (since that is only where EncodeInto() is used). Intent to Implement and Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/vTNMrsScW1g R=jsbell@chromium.org, kinuko@chromium.org, ricea@chromium.org Bug: 920107 Change-Id: I178f927e837833731049c4867c0eb71e90d369cc Reviewed-on: https://chromium-review.googlesource.com/c/1456637 Reviewed-by: Adam Rice <ricea@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#631002}
Changed files
- third_party/blink/public/platform/web_feature.mojom
- third_party/blink/renderer/modules/encoding/text_encoder.cc
- third_party/blink/renderer/modules/encoding/text_encoder.h
- third_party/blink/renderer/modules/encoding/text_encoder.idl
- third_party/blink/renderer/modules/encoding/text_encoder_encode_into_result.idl
- third_party/blink/renderer/modules/modules_idl_files.gni
- third_party/blink/renderer/platform/wtf/text/text_codec.h
- third_party/blink/renderer/platform/wtf/text/text_codec_utf8.cc
- third_party/blink/renderer/platform/wtf/text/text_codec_utf8.h
- third_party/blink/web_tests/external/wpt/encoding/encodeInto.any-expected.txt
- third_party/blink/web_tests/external/wpt/encoding/encodeInto.any.worker-expected.txt
- third_party/blink/web_tests/external/wpt/encoding/idlharness.any-expected.txt
- third_party/blink/web_tests/external/wpt/encoding/idlharness.any.serviceworker-expected.txt
- third_party/blink/web_tests/external/wpt/encoding/idlharness.any.sharedworker-expected.txt
- third_party/blink/web_tests/external/wpt/encoding/idlharness.any.worker-expected.txt
- third_party/blink/web_tests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
- third_party/blink/web_tests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
- third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
- third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt
- third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
- third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
- third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
- third_party/blink/web_tests/webexposed/global-interface-listing-shared-worker-expected.txt
- tools/metrics/histograms/enums.xml
-
overview: Introduce OverviewObserver.
Changed by Sammie Quon - sammiequonohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 00:22:03 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c7d27a2942d2d3d8c018ee254dfb6dd43725a2f5 Comments
overview: Introduce OverviewObserver. Move overview ShellObserver methods to new class OverviewObserver. Test: none Bug: 914147 Change-Id: Ic0290fc9bd7e3144fc6939cc7833e008198a8ec1 Reviewed-on: https://chromium-review.googlesource.com/c/1461678 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#631001}
Changed files
- ash/BUILD.gn
- ash/accelerators/accelerator_unittest.cc
- ash/app_list/app_list_controller_impl.cc
- ash/app_list/app_list_controller_impl.h
- ash/frame/non_client_frame_view_ash.cc
- ash/frame/non_client_frame_view_ash.h
- ash/frame/wide_frame_view.cc
- ash/frame/wide_frame_view.h
- ash/shelf/shelf_layout_manager.cc
- ash/shelf/shelf_layout_manager.h
- ash/shell.cc
- ash/shell.h
- ash/shell_observer.h
- ash/system/overview/overview_button_tray.cc
- ash/system/overview/overview_button_tray.h
- ash/wm/overview/overview_controller.cc
- ash/wm/overview/overview_controller.h
- ash/wm/overview/overview_controller_unittest.cc
- ash/wm/overview/overview_observer.h
- ash/wm/overview/overview_session_unittest.cc
- ash/wm/splitview/split_view_controller.cc
- ash/wm/splitview/split_view_controller.h
- ash/wm/splitview/split_view_controller_unittest.cc
- ash/wm/tablet_mode/tablet_mode_observer.h
- ash/wm/tablet_mode/tablet_mode_window_manager.cc
- ash/wm/tablet_mode/tablet_mode_window_manager.h
- ash/wm/workspace/backdrop_controller.cc
- ash/wm/workspace/backdrop_controller.h
-
Reland "Don't send download pings if the download is cancelled"
Changed by Daniel Rubery - druberyohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:18:50 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 15338196c4b927b1c6f01f214f27873bbd137040 Comments
Reland "Don't send download pings if the download is cancelled" This reverts commit bb4a37675c5397ed15e27b9e2cafbc4b45e21b96. The previous version had the problem that RunUntilIdle() was running inconsistent amounts of tasks, which led to failed EXPECT_CALLs. I've removed the RunUntilIdle() by ensuring the CheckClientDownload always runs its callback, even when the download is destroyed. This is a minor behavior change, but doesn't seem to break anything (the download code doesn't assume the download item exists, so it handles the download destroyed case correctly). Change-Id: Ic036eefa5e1ad97be7bef72b172296112b077e11 Bug: 930372 Reviewed-on: https://chromium-review.googlesource.com/c/1460177 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#631000}
Changed files
- chrome/browser/safe_browsing/download_protection/check_client_download_request.cc
- chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc
-
[ui/vr] Add timeout for in-head permissions prompt.
Changed by Suman Kancherla - sumankancherlaohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:18:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 46e73c59ce5470b3b429f4b1b43376c91d419329 Comments
[ui/vr] Add timeout for in-head permissions prompt. Bug: 912759 Change-Id: I55b69f673d61a0ffa90127ea4e379407a7f9bf87 Reviewed-on: https://chromium-review.googlesource.com/c/1459325 Reviewed-by: Bill Orr <billorr@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#630999}
Changed files
- chrome/browser/vr/ui_host/vr_ui_host_impl.cc
- chrome/browser/vr/ui_host/vr_ui_host_impl.h
-
Roll src/third_party/angle 0029dfe28cf4..6b695c3ffb27 (5 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Tuesday, 12-Feb-19 00:14:46 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e66e9d595149604e44485a1d4a2cd7733dd220ef Comments
Roll src/third_party/angle 0029dfe28cf4..6b695c3ffb27 (5 commits) https://chromium.googlesource.com/angle/angle.git/+log/0029dfe28cf4..6b695c3ffb27 git log 0029dfe28cf4..6b695c3ffb27 --date=short --no-merges --format='%ad %ae %s' 2019-02-11 jmadill@chromium.org Vulkan: Enable WebGLCompatiblityTest. 2019-02-11 jmadill@chromium.org Vulkan: Suppress layer warnings about unbound outputs. 2019-02-11 jmadill@chromium.org Vulkan: Fix UtilsVk invalidating Context descriptors. 2019-02-11 tobine@google.com Vulkan:Adding Cmd Buffer Reset tests 2019-02-11 fjhenigman@chromium.org Vulkan: make GenerateCaps a member of RendererVk. Created with: gclient setdep -r src/third_party/angle@6b695c3ffb27 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ie87758a9d8eed72c699134414d036a6c59a8db7b Reviewed-on: https://chromium-review.googlesource.com/c/1464252 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630998}
Changed files
- DEPS
-
AW docs: steps for net debugging
Changed by Nate Fischer - ntfschrohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:14:41 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b8762b368898d9401c439988be02779d8f757479 Comments
AW docs: steps for net debugging No change to logic, only docs. This adds public docs for WebView's netlog support. This is mostly a copy of http://go/clank-webview/net-debugging, but with modifications for formatting and to call out particular content. Bug: 918221 Test: Upload to gerrit > open file > click "gitiles" Change-Id: I4f140ff6bdefb7a7bc740d7659513b58a43477f1 Reviewed-on: https://chromium-review.googlesource.com/c/1455681 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#630997}
Changed files
- android_webview/docs/net-debugging.md
-
Roll src/third_party/swiftshader d9ce258c174b..64c44b0c53c4 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Tuesday, 12-Feb-19 00:11:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 13badb949a051ddc1dba0b987c602b56b095218a Comments
Roll src/third_party/swiftshader d9ce258c174b..64c44b0c53c4 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/d9ce258c174b..64c44b0c53c4 git log d9ce258c174b..64c44b0c53c4 --date=short --no-merges --format='%ad %ae %s' 2019-02-11 chrisforbes@google.com Add assert for broken locations Created with: gclient setdep -r src/third_party/swiftshader@64c44b0c53c4 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I0c7c90fdad6fffceacda50b336ffe26114c78d23 Reviewed-on: https://chromium-review.googlesource.com/c/1464246 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630996}
Changed files
- DEPS
-
Remove unused SVG attribute names
Changed by Philip Rogers - pdrohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:06:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f0f63cf75081fe88ac8713ff32296bdc765bf836 Comments
Remove unused SVG attribute names A recent paint-dev thread[1] asked if svg_attribute_names.json5 represented supported attributes, and in researching I found many of the values were never implemented at all. Most of these date back to at least 2005, from the original import of ksvg2[2]. This patch removes unused svg attribute names. [1] https://groups.google.com/a/chromium.org/d/msg/paint-dev/OMwLHVnOz68/iY6cTlDQGQAJ [2] https://chromium.googlesource.com/chromium/src/+/b92429242b350855e267679d1fa3991ecc413dad/third_party/WebKit/WebCore/ksvg2/svg/svgattrs.in Change-Id: Iff195325d154b3d81ff795e6338247f165d967c3 Reviewed-on: https://chromium-review.googlesource.com/c/1464205 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#630995}
Changed files
- third_party/blink/renderer/core/svg/svg_attribute_names.json5
-
Roll src/third_party/SPIRV-Tools/src 12b3d7e9d661..40a7940e0572 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Tuesday, 12-Feb-19 00:03:57 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 799f14942ea54550918665b0b3a92cb686d5c830 Comments
Roll src/third_party/SPIRV-Tools/src 12b3d7e9d661..40a7940e0572 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/12b3d7e9d661..40a7940e0572 git log 12b3d7e9d661..40a7940e0572 --date=short --no-merges --format='%ad %ae %s' 2019-02-11 paulthomson@users.noreply.github.com Fix merge blocks opportunity to check if still enabled (#2370) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@40a7940e0572 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I71deb982297763501fc996cb28f1f263dd42b93e Reviewed-on: https://chromium-review.googlesource.com/c/1464253 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630994}
Changed files
- DEPS
-
Remove dummy theme
Changed by Becky Zhou - huayinzohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:03:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e0fc9799e3860cddcec4ea78d751f44af7dc88e0 Comments
Remove dummy theme Bug: 925564 Change-Id: I09a8e705f3cb1ba4872933b76912fd4cd069861a Reviewed-on: https://chromium-review.googlesource.com/c/1464658 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#630993}
Changed files
- chrome/android/java/res/values-v17/styles.xml
-
Replace network_service_chromeos_fyi_gtests with network_service_gtests on cros fyi bot
Changed by Robbie McElrath - rmcelrathohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 23:59:56 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0ada586c83dbabd08eea042db765de1906e9d135 Comments
Replace network_service_chromeos_fyi_gtests with network_service_gtests on cros fyi bot This doesn't change much, just simplifies the test_suites.pyl file. Bug: 920038 Change-Id: I209bec6ea11a75186902f4cbd1445d369e1825c2 Reviewed-on: https://chromium-review.googlesource.com/c/1464938 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#630992}
Changed files
- testing/buildbot/chromium.fyi.json
- testing/buildbot/test_suites.pyl
-
app_list: Modify Assistant main stage
Changed by wutao - wutaoohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 23:53:14 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a8cd13108b46d2836a4a3373d21a4e98723cf6d8 Comments
app_list: Modify Assistant main stage This patch modifies the main stage in embedded Assistant UI. Main changes: 1. Progress indicator is between the dialog plate and the main stage, together with the horizontal line as a separator. This is different than the UX mocks. I will discuss with UX to finalize this. 2. Query text is always centered below the progress indicator. 3. No molecule icon. 4. No greeting text. Bug: 924624 Test: manual Change-Id: I10a206dfab8f5360826ec36972e10e262ba8bab6 Reviewed-on: https://chromium-review.googlesource.com/c/1461276 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#630991}
Changed files
- ash/app_list/BUILD.gn
- ash/app_list/views/assistant/assistant_main_stage.cc
- ash/app_list/views/assistant/assistant_main_stage.h
- ash/app_list/views/assistant/assistant_main_view.cc
- ash/app_list/views/assistant/assistant_main_view.h
-
Change input event prediction default predictor to kalman
Changed by Ella Ge - eirageohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 23:52:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9f2643a84236efe29817100dbcfafffc6f13028a Comments
Change input event prediction default predictor to kalman From the finch result[1] of InputPredictionAccuracy, kalman filter behave better than lsq, so this CL changes the default predictor for input event to kalman. With this change, we can enable pointerevent predictedPoints by the experimental web platform flag, without have to set the predictor by resampling flag or input predictor choice flag. Resampling event is still behind the resampling flag, but when setting the chrome flag to "enable", it will use kalman filter instead of empty predictor, the default predictor before this change. This change also removes the 20ms limit for predicted points and accuracy metric. The 20ms limit will be for resampling only. [1] https://docs.google.com/document/d/1ErAl-wG6LZwkIgSyWAY08LnscaTc20A-uI2srepnpnM/edit#heading=h.ic1dz5hr149b Bug: 885299 Change-Id: I7097dc1f61a256dcc68173a4f1d6cad9fcf585f6 Reviewed-on: https://chromium-review.googlesource.com/c/1455270 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#630990}
Changed files
- content/renderer/input/input_event_prediction.cc
- content/renderer/input/input_event_prediction.h
- content/renderer/input/input_event_prediction_unittest.cc
- ui/events/blink/input_handler_proxy_unittest.cc
- ui/events/blink/prediction/empty_predictor.cc
- ui/events/blink/prediction/empty_predictor.h
- ui/events/blink/prediction/input_predictor.h
- ui/events/blink/prediction/input_predictor_unittest_helpers.cc
- ui/events/blink/prediction/kalman_predictor.cc
- ui/events/blink/prediction/kalman_predictor.h
- ui/events/blink/prediction/least_squares_predictor.cc
- ui/events/blink/prediction/least_squares_predictor.h
- ui/events/blink/prediction/least_squares_predictor_unittest.cc
- ui/events/blink/scroll_predictor.cc
- ui/events/blink/scroll_predictor_unittest.cc
-
Implement RemoteTextInputClient::IsTextEditCommandEnabled
Changed by Xiyuan Xia - xiyuanohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 23:47:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2d57aeb065a96ab01af2fdf0111e8dbf3c4058b6 Comments
Implement RemoteTextInputClient::IsTextEditCommandEnabled Bug: 631527 Change-Id: I1dd1a268ca02dc2cb2a236b1194651edcf2ea373 Reviewed-on: https://chromium-review.googlesource.com/c/1458797 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#630989}
Changed files
- chrome/browser/ui/views/ime_driver/remote_text_input_client.cc
- services/ws/public/mojom/ime/ime.mojom
- ui/aura/mus/input_method_mus.cc
- ui/aura/mus/input_method_mus_unittest.cc
- ui/base/ime/text_edit_commands.h
-
overview: Removed GetOverviewWindowForMinimizedStateForTest.
Changed by Sammie Quon - sammiequonohnoyoudont@google.com Changed at Monday, 11-Feb-19 23:43:40 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6c1c2f24f9314895e46026ac956bf6c013a158f3 Comments
overview: Removed GetOverviewWindowForMinimizedStateForTest. minimized_widget_ is already exposed publicly so this not needed. Test: ash_unittests *Overview* Bug: 914147 Change-Id: I0343ec8ae87f9746653b821d9a4b9af565cea691 Reviewed-on: https://chromium-review.googlesource.com/c/1464063 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#630988}
Changed files
- ash/wm/overview/overview_item.cc
- ash/wm/overview/overview_item.h
- ash/wm/overview/overview_session_unittest.cc
- ash/wm/overview/scoped_overview_transform_window.cc
- ash/wm/overview/scoped_overview_transform_window.h
-
Remove a few unnecessary semicolons.
Changed by Nico Weber - thakisohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 23:42:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e70f4b0e3ae0b77beeb88a64b5f42adea78a8d91 Comments
Remove a few unnecessary semicolons. This CL was uploaded by git cl split. R=timvolodine@chromium.org Bug: 926235 Change-Id: If5d7d74ee74fa1f7610228128bf5b32b915d95c6 Reviewed-on: https://chromium-review.googlesource.com/c/1464128 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#630987}
Changed files
- third_party/blink/renderer/modules/device_orientation/device_motion_event_pump_unittest.cc
- third_party/blink/renderer/modules/device_orientation/device_orientation_event_pump_unittest.cc
-
Import wpt@ae6d56308684b97f30a01b455ce3eb205cba79aa
Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com Changed at Monday, 11-Feb-19 23:41:19 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision dc6872b1af20e85cdc27a147c488e27a9cae5fbb Comments
Import wpt@ae6d56308684b97f30a01b455ce3eb205cba79aa Using wpt-import in Chromium 02d580c1599dd774409f09aea8bfc62c61288fed. With Chromium commits locally applied on WPT: 14c111075b "Implement `Sec-CH-Lang`" af3b056c72 "[WPT] [wasm] Add JS-API tests for wasm threads" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I660eede29802cfd8ec7687bfa51d607f2cf54252 Reviewed-on: https://chromium-review.googlesource.com/c/1464919 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630986}
Changed files
- third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
- third_party/blink/web_tests/external/wpt/html/semantics/embedded-content/the-iframe-element/content_document_changes_only_after_load_matures.html
- third_party/blink/web_tests/external/wpt/html/semantics/embedded-content/the-iframe-element/support/iframe-that-checks-contentDocument.html
-
Tracing: Disable for processes without a TaskScheduler.
Changed by Oystein Eftevaag - oysteineohnoyoudont@google.com Changed at Monday, 11-Feb-19 23:33:22 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e644c4588ba1c8d058aa2370eacef1ba88360f29 Comments
Tracing: Disable for processes without a TaskScheduler. Tracing now gets enabled for all child processes as a feature of the service_manager clientlib, and requires a running TaskScheduler. There's processes that utilize the service_manager clientlib without using a TaskScheduler, like the nacl_loader which never got traced before and currently can crash if tracing gets started; we now just exclude them from tracing. Bug: 925303 Change-Id: I890754b52e2416f951218e682fb8cde69732572c Reviewed-on: https://chromium-review.googlesource.com/c/1460109 Reviewed-by: ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Auto-Submit: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#630985}
Changed files
- services/tracing/public/cpp/traced_process_impl.cc
-
Roll src/third_party/pdfium 2f1edd6a8ac3..c05172e4e216 (3 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Monday, 11-Feb-19 23:28:54 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f0dfc5b003259cd93ebbd2f1111f39c68ed0c676 Comments
Roll src/third_party/pdfium 2f1edd6a8ac3..c05172e4e216 (3 commits) https://pdfium.googlesource.com/pdfium.git/+log/2f1edd6a8ac3..c05172e4e216 git log 2f1edd6a8ac3..c05172e4e216 --date=short --no-merges --format='%ad %ae %s' 2019-02-11 tsepez@chromium.org Consolidate index increment/decrement in cfgas_formatstring.cpp 2019-02-11 licorn@gmail.com v8_initializer: Add cstring header 2019-02-11 tsepez@chromium.org Fix spin in CFGAS_FormatString::FormatStrNum(). Created with: gclient setdep -r src/third_party/pdfium@c05172e4e216 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3a52fc3471a8924e447d9a07a16f9f066d20b6d0 Reviewed-on: https://chromium-review.googlesource.com/c/1464961 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630984}
Changed files
- DEPS
-
Picture-in-Picture: comment flaky test until the flake source is fixed.
Changed by Mounir Lamouri - mlamouriohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 23:28:50 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ae4fbd4a84d45d9a642d19e8b8ff6778bda3bcbc Comments
Picture-in-Picture: comment flaky test until the flake source is fixed. Bug: 919860, 930338 Change-Id: Ia8454760b89671ef1e751153ca075e68078be109 TBR: mlamouri@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1465061 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#630983}
Changed files
- chrome/browser/apps/platform_apps/app_browsertest.cc
-
Replace use of GaiaCookieManagerService in single_client_sessions_sync_test.cc
Changed by Henrique Ferreiro - hferreiroohnoyoudont@igalia.com Changed at Monday, 11-Feb-19 23:25:26 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9714fbe784695f4aaa64c2f81323d3236c948fdf Comments
Replace use of GaiaCookieManagerService in single_client_sessions_sync_test.cc Port to the IdentityManager API. Bug: 926878 Change-Id: Ieb640f44409636ff5013702654f212e8fc0e3762 Reviewed-on: https://chromium-review.googlesource.com/c/1455899 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#630982}
Changed files
- chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc
-
Allow premount to always succeed on all errors
Changed by Jimmy Gong - jimmyxgongohnoyoudont@google.com Changed at Monday, 11-Feb-19 23:10:25 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision eb16dcb7265f8f71f19e46ac12b0becaa8e69cc8 Comments
Allow premount to always succeed on all errors - Previously premount only allowed a subset of errors to succeed. This change removes those restrictions now that host names can be dynamically resolved. Bug: 922273 Test: end to end Change-Id: I66478499710bb7eebf18f77bed71a20f5a3782d7 Reviewed-on: https://chromium-review.googlesource.com/c/1445239 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Auto-Submit: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#630981}
Changed files
- chrome/browser/chromeos/smb_client/smb_service.cc
-
[PE] Avoid crash about unaliased status when skipping fragment clips
Changed by Xianzhu Wang - wangxianzhuohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 23:10:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ac232d25f10993cb8873ff1850fa991d85dcd4ee Comments
[PE] Avoid crash about unaliased status when skipping fragment clips Bug: 929979 Change-Id: I2bd0c2c8088fc1af328db5f7162c5c1c7092c23e Reviewed-on: https://chromium-review.googlesource.com/c/1461098 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#630980}
Changed files
- third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
- third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
- third_party/blink/web_tests/external/wpt/css/css-multicol/multicol-span-all-under-clip-path-crash.html
-
We need '--browser=reference' to come last.
Changed by Caleb Rouleau - crouleauohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 23:09:38 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4a56b276f3e8b3fcd4ef71e9c625595ba2234e77 Comments
We need '--browser=reference' to come last. It's supposed to be '--browser=release', '--browser=reference' TBR=johnchen@chromium.org Bug: 930879,928928 Change-Id: Ifc09a3bd12d8383f56d7d99686d9c9bb9a1c8cae Reviewed-on: https://chromium-review.googlesource.com/c/1464228 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#630979}
Changed files
- testing/scripts/run_performance_tests.py
-
Lift WebGL/ANGLE/Vulkan/Win suppression.
Changed by Jamie Madill - jmadillohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 23:07:41 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7b1b40a963170771691ca222bbb446703e6c7673 Comments
Lift WebGL/ANGLE/Vulkan/Win suppression. The test appears to be passing in ToT. Unknown what fixed it. Bug: angleproject:2987 Change-Id: I6ac001694893d629883019331e5c73d40fd27af1 Tbr: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1464109 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#630978}
Changed files
- content/test/gpu/gpu_tests/webgl_conformance_expectations.py
-
s13n: Remove unnecessary the includes of account_tracker_service.h in ChromePasswordProtectionService
Changed by Gyuyoung Kim - gyuyoungohnoyoudont@igalia.com Changed at Monday, 11-Feb-19 23:07:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5abf5249125f533216f648fb27c43b6aa9390608 Comments
s13n: Remove unnecessary the includes of account_tracker_service.h in ChromePasswordProtectionService There is no use of AccountTrackerService in ChromePasswordProtectionService. This CL removes it. Bug: 922803 Change-Id: Ia57018ca2f84faad979abd0996ac513148e9311a Reviewed-on: https://chromium-review.googlesource.com/c/1462381 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Nathan Parker <nparker@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#630977}
Changed files
- chrome/browser/safe_browsing/chrome_password_protection_service.cc
-
Roll src/third_party/dawn 3b71e65658cd..62e83971caa1 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Monday, 11-Feb-19 23:04:46 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 89e93d31aa3ac1308d6852dfd8f8afd87da6e2b3 Comments
Roll src/third_party/dawn 3b71e65658cd..62e83971caa1 (1 commits) https://dawn.googlesource.com/dawn.git/+log/3b71e65658cd..62e83971caa1 git log 3b71e65658cd..62e83971caa1 --date=short --no-merges --format='%ad %ae %s' 2019-02-11 enga@chromium.org Factor wire server handlers into proper command handlers and doers Created with: gclient setdep -r src/third_party/dawn@62e83971caa1 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I101f074bf46e55351738fddbdb3dea20c9af8dc6 Reviewed-on: https://chromium-review.googlesource.com/c/1464248 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630976}
Changed files
- DEPS
-
[Presentation API] Reject PresentationRequest.start() with the correct error.
Changed by mark a. foltz - mfoltzohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 23:04:01 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 930ea94617e6255f1b358a9a27f8da4a9471f98b Comments
[Presentation API] Reject PresentationRequest.start() with the correct error. This fixes the PresentationService so that start will reject with an OperationError if there is a pending start Promise from the same frame. This matches step 3 of the Presentation API spec [1]. Tested manually with the corresponding WPT [2]. [1] https://w3c.github.io/presentation-api/#selecting-a-presentation-display [2] https://github.com/web-platform-tests/wpt/blob/master/presentation-api/controlling-ua/startNewPresentation_unsettledpromise-manual.https.html Bug: 647504 Change-Id: If3f50e70321136556ed1a3d3ab1f4b763a6aa9eb Reviewed-on: https://chromium-review.googlesource.com/c/1460101 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#630975}
Changed files
- content/browser/presentation/presentation_service_impl.cc
-
cros: Reset auto-login delay on user activity
Changed by Quan Nguyen - qnnguyenohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 23:02:25 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e377eb6cdcdab37607ae25361e06721afcaf1003 Comments
cros: Reset auto-login delay on user activity Bug: 916346 Change-Id: I7e84c986a7358693e030663a4d586668d47deaa1 Reviewed-on: https://chromium-review.googlesource.com/c/1456206 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#630974}
Changed files
- ash/login/login_screen_controller.cc
- ash/login/login_screen_controller.h
- ash/login/mock_login_screen_client.h
- ash/login/ui/lock_contents_view.cc
- ash/login/ui/lock_contents_view.h
- ash/public/interfaces/login_screen.mojom
- chrome/browser/ui/ash/login_screen_client.cc
- chrome/browser/ui/ash/login_screen_client.h
-
Input.dispatchTouchEvent sends events to SyntheticGestureController
Changed by Lan Wei - lanweiohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 23:01:30 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9c6f124b85956ef0691b41b3acece38188855d3f Comments
Input.dispatchTouchEvent sends events to SyntheticGestureController In order to make the synthetic events sent from Input.dispatchTouchEvent close to the native OS events, we should send events to SyntheticGestureController, which will dispatch events to each platform at a very low level. Change-Id: Ic9ad2b0e3add91e8ce67c2b07f7dbaa5527c722b Reviewed-on: https://chromium-review.googlesource.com/c/1428239 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#630973}
Changed files
- content/browser/devtools/protocol/input_handler.cc
- content/browser/devtools/protocol/input_handler.h
- content/browser/renderer_host/input/synthetic_mouse_driver.cc
- content/browser/renderer_host/input/synthetic_mouse_driver.h
- content/browser/renderer_host/input/synthetic_pointer_action.cc
- content/browser/renderer_host/input/synthetic_pointer_action.h
- content/browser/renderer_host/input/synthetic_pointer_driver.h
- content/browser/renderer_host/input/synthetic_touch_driver.cc
- content/browser/renderer_host/input/synthetic_touch_driver.h
- content/common/input/synthetic_pointer_action_params.h
-
[LayoutNG] Remove superflous min/max constraint.
Changed by Ian Kilpatrick - ikilpatrickohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 22:59:27 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e4ca23be58015d952f44fe5171b6dfdd1e23c19c Comments
[LayoutNG] Remove superflous min/max constraint. Change-Id: I3157de7f2b3f2603cab1a4f7e39f7b1aeb6c6b82 Reviewed-on: https://chromium-review.googlesource.com/c/1456868 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#630972}
Changed files
- third_party/blink/renderer/core/layout/ng/ng_block_node.cc
-
[SendTabToSelf] New model API
Changed by Jeffrey Cohen - jeffreycohenohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 22:59:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3c5592738ec65b5c446d11291dde124254d2fc76 Comments
[SendTabToSelf] New model API Bug: 910390 Change-Id: Ia58b9910d60cc00e0d39dd86e167861f7f0f2f24 Reviewed-on: https://chromium-review.googlesource.com/c/1461085 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#630971}
Changed files
- chrome/browser/sync/test/integration/send_tab_to_self_helper.cc
- chrome/browser/sync/test/integration/send_tab_to_self_helper.h
- components/send_tab_to_self/send_tab_to_self_bridge.cc
- components/send_tab_to_self/send_tab_to_self_bridge.h
- components/send_tab_to_self/send_tab_to_self_model.h
- components/send_tab_to_self/send_tab_to_self_model_observer.h