Home | Search | chromium - Builders
Login

Builder Linux Builder Build 106919 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision703e2b8a5b805ecd4fba4bffb76095125330cec4
Got Revision703e2b8a5b805ecd4fba4bffb76095125330cec4

Execution:

Steps and Logfiles:

Show:
  1. ( 329 ms ) setup_build
    running recipe: "chromium"
  2. ( 265 ms ) report builders
     
    running builder 'Linux Builder' on master 'chromium.linux'
  3. ( 3 mins ) bot_update
    [105GB/295GB used (35%)]
  4. ( 876 ms ) swarming.py --version
    0.13
  5. ( 28 secs ) gclient runhooks
  6. ( 585 ms ) read test spec (chromium.linux.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.linux.json
  7. ( 468 ms ) lookup GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    use_goma = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 29 secs ) generate_build_files
  9. ( 2 mins 54 secs ) compile
  10. ( 2 mins 29 secs ) isolate tests
  11. ( 42 mins 59 secs ) package build
  12. ( 828 ms ) trigger
  13. ( 0 ) test_pre_run

Build Properties:

NameValueSource
$build/goma {"jobs": 500} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm965-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539351938097373, "id": "8932866218115914848", "project": "chromium", "tags": ["builder:Linux Builder", "buildset:commit/git/703e2b8a5b805ecd4fba4bffb76095125330cec4", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/703e2b8a5b805ecd4fba4bffb76095125330cec4", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9098296280341632016", "scheduler_job_id:chromium/Linux Builder", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Linux Builder" setup_build
buildnumber 106919 setup_build
mastername "chromium.linux" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "703e2b8a5b805ecd4fba4bffb76095125330cec4" setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "703e2b8a5b805ecd4fba4bffb76095125330cec4" bot_update
got_revision_cp "refs/heads/master@{#599196}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "55d1af14751ad10e0cae741240f013ea67039f45" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25138}" bot_update
swarm_hashes_refs/heads/master(at){#599196}_without_patch {"accessibility_unittests": "1e48b8d3b07497df27a1c0e70b81e81b250af6af", "angle_unittests": "e003f6d10b67d40faacd5df18234e5ec8ede592e", "app_shell_unittests": "86f2933bba55c32aa3e3eafff37ec1ab0b15e531", "aura_unittests": "5c7c01177cd726a14b35df489d12a1cfacd1811e", "base_unittests": "f1ca76557812050da509259936db7c2ba56ad956", "blink_common_unittests": "31458999ef2b9476803a056425f731a581aae1a5", "blink_fuzzer_unittests": "53493372ab9bc6d01a76d00e4baeda63040f3dec", "blink_heap_unittests": "89ea9651ee85a83864f0a92f25d4e10e75bbd908", "blink_platform_unittests": "76159ab1d9ac66add617db900b43c1cab1eb76c1", "boringssl_crypto_tests": "661bc921780c8b99dfbc261df45d8bcc8f41be5e", "boringssl_ssl_tests": "eb62668d1183ed0227f176cff28b2c688939c63c", "browser_tests": "25b9aad5b563329f6eefa4fabd415caf5ba7d822", "cacheinvalidation_unittests": "5b03dee88239769c08684ad78be7d2f2a2045f2a", "capture_unittests": "768d544e29afa222554df82d05a0f62689a941e9", "cast_unittests": "6c4b3f29004d60116c3954799de056587f583521", "cc_unittests": "21a8302d7d1805497fd9275834f65736f0291bfa", "chrome_app_unittests": "c44818fbff6cf87bf5f28317112bba4a80d8e32a", "chromedriver_py_tests": "b02a3800a37c3f99dcf38ac1fe95fb92d8b10ecd", "chromedriver_replay_unittests": "950c040334ad8a7d3fc3ab9bf98bea1f48abdaec", "chromedriver_unittests": "a73543a003d363fc783c419d92082fc7db931851", "components_browsertests": "77d88ff06a3b023b7fb43f7a2c0d235f1050cd35", "components_unittests": "c62f02e0eb70c4f13b094d2a35eaa4798afc2b35", "compositor_unittests": "50bc097a98b0538da8b067e76daf2b850c317b19", "content_browsertests": "a47a036bf9f670b3390cf7f3951e389bd333bd6d", "content_shell_crash_test": "c0e11bd3cd8c6f3841de99a8d676209dc61610db", "content_unittests": "5b5a2832d17cccbd60d8232e1f284a6335b7959e", "cronet_tests": "4ed74955fbc7c58ddf0134d4268f54958bf95c60", "cronet_unittests": "10228af8b801a9143b9a3e4e8b7de533d882a2b4", "crypto_unittests": "d54c62c594ca2bb97286ed4fb71c4834777c00da", "dbus_unittests": "e56658c0ccef3ecccc57fe6b352362a7583e95aa", "device_unittests": "d850e7ca478ac190cd58dbdcbaa5ca4d6d649155", "devtools_closure_compile": "6a4f1e9e85ffd2338b3bf719d2767fe6dfc22591", "devtools_eslint": "c35323ca26b28243c96f459f12676d550d4fcf6b", "display_unittests": "41d15046c80f071dd8cd4f571c8eb8ffa1961b86", "events_unittests": "d18f6737da848d94066e38da32554d41fb5e0199", "extensions_browsertests": "0b5f4b04e8e01ab6b3f8e65cf43642674ee0ea84", "extensions_unittests": "b0a6b3704cd6bcbbccc037026155afff9ab94c69", "filesystem_service_unittests": "9a5ac17da4a980790639933d5c38e612efd0d686", "gcm_unit_tests": "040a5bbc936a3acc4838d3fa52e0d14664db3c4a", "gfx_unittests": "c0f4e2271ad5c9f26de1df735207d3be0bb621c5", "gin_unittests": "f70d7479d8203afa2a45edc57eec2355285f7536", "google_apis_unittests": "4578dc123877c5a44ae1524726bf65949c66d165", "gpu_unittests": "605530778375977d136aeecc62108b536161d620", "headless_browsertests": "9121747ae58fbceca287fc5a2c5a753706bbdfc3", "headless_unittests": "01546778ed45aac7e4a73eefb49ea2272b588a7e", "interactive_ui_tests": "4c9ae320d431740861254d96c05c914fc2033175", "ipc_tests": "ae5746b37a221e4d3c8056609900933b5ae8c3a2", "jingle_unittests": "937051b454e3a0cf0ebc95fb23606e21848e2611", "latency_unittests": "241b0035ab20e104f701002e941e2138c87aca1f", "leveldb_service_unittests": "45f1f6eeeeea3d02eb7b1ba7fbd19aabe1d9e1ce", "libjingle_xmpp_unittests": "04635de9f9ff80308d4226856ee8ef7cfdd8bcf3", "media_blink_unittests": "0cfca2bb0ffb26448da375f4139b450e300d5220", "media_service_unittests": "4a3c2d3f4231d23342c0b380314ebec769a5a22a", "media_unittests": "3fb8d40655bcd0f1e1505660b79c9c24b7795470", "message_center_unittests": "ffa13ad34a9e1b210314e6e54ea158d80ba3d702", "metrics_python_tests": "a7ea6892f85a3f6a50a4cca2c0b6bc4fb51b579d", "midi_unittests": "089e3d2113552be4535582be330c0c474390fc35", "mojo_core_unittests": "79eb82f6d92d57e193f8d509b9afe7e4f5feb860", "mojo_unittests": "b539d574691fa98fe713fc3bde7146404076e999", "nacl_helper_nonsfi_unittests": "47b345b0268d165e4ff5e63ccfdd32a5a106ba9c", "nacl_loader_unittests": "c45028e0ae869eec4983f3c0f8f3b1868d0b0661", "native_theme_unittests": "3b1bc94941eb83e13b143f9a5306653f8e0010a0", "net_unittests": "b04b0308b6f946f74080be0ac21e67a3c981418d", "pdf_unittests": "40d23f36d2f9d63fc8c0f64b66de6e3261f390a6", "ppapi_unittests": "82bb8b5ee27fe6711bd771e44b7ddec2c4518564", "printing_unittests": "05fd57ed5814ec43604f6ebdc7399ccbd2ffd3d5", "remoting_unittests": "cd465226aecb3e79e73f522540b49e6de9c94bfc", "sandbox_linux_unittests": "090d05dacc697263337797658169197d1c5d5b72", "service_manager_unittests": "93f179b6b75c37f3f2cff74537f109685798981f", "services_unittests": "06869f7cd73946661c5a62ec3aaef71d6942815b", "shell_dialogs_unittests": "52d0796ee9c2899432f4ecd61e37ac603c8af9c1", "skia_unittests": "e809c158f42b8e66df19e6c5d81fee8cc3564447", "snapshot_unittests": "f4c0da63db68b277712fd9bc9d21bfabac08dfc3", "sql_unittests": "cc2e7b0053b28be8633893edac261d4f550776cb", "storage_unittests": "8f5dc0aeaf5c10d4deb295c0832d94bbd94333ba", "sync_integration_tests": "c2e28748d9277991c7ec09e7668109b6d2a4d93d", "telemetry_gpu_unittests": "bfca7b4021137b52b8f8acc1022ccca2252a40ad", "telemetry_perf_unittests": "3b93a2bb750bcccadfeb9d9aa3234492cb02a6ea", "telemetry_unittests": "c995cd15586309fb3c9af28d0624328c8769130c", "traffic_annotation_auditor_unittests": "719efced6831e0e35063888f37fc38dc48d74c8c", "ui_base_unittests": "bac21c9b4b35ef6eb84085f62ae3e41d349d8d7d", "ui_touch_selection_unittests": "14792e3ed7e8de7720430953e72a6e77ddb51664", "unit_tests": "4056d040e3f48def09f9976ad7872c6d6747e508", "url_unittests": "fde791c968701aea501be8fed0ed67d2d1d90cd7", "views_perftests": "14abb52ff5632579e0607bd29c02b1af9b046512", "views_unittests": "0a8f9a91f0c4a684169739bc05e0c76f65cfd993", "viz_unittests": "600e9d2578123b4ac1360fe9342edbfd9cd11873", "vr_common_unittests": "9ed7344f7233e30977db409d69fcc3bcb08cda01", "vr_pixeltests": "4205888e48f6e396eaeebe17a54af323aef4b9e7", "webkit_layout_tests_exparchive": "fb0049f67b35efa519d018985d384669a92a6be5", "webkit_python_tests": "79d04ef92dffaa604ec80e513816995983971080", "webkit_unit_tests": "7653528bace7417b0e6132ec601a106dd2861522", "wm_unittests": "7535df9825a431b1a8cab3ad9dd5889c8fc37ff8", "wtf_unittests": "d1a93652dea618be8d4358cf4ddf2527d50db08a"} isolate tests
build_archive_url "gs://chromium-linux-archive/chromium.linux/Linux Builder/full-build-linux_703e2b8a5b805ecd4fba4bffb76095125330cec4.zip" package build

Blamelist:

  1. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
  2. Marc Treib (treibohnoyoudont@chromium.org)
  3. Stephane Zermatten (szermattohnoyoudont@chromium.org)
  4. Peng Huang (penghuangohnoyoudont@chromium.org)
  5. Ben Kelly (wanderviewohnoyoudont@chromium.org)
  6. Shu Chen (shuchenohnoyoudont@google.com)
  7. Findit (findit-for-meohnoyoudont@appspot.gserviceaccount.com)
  8. Colin Blundell (blundellohnoyoudont@chromium.org)
  9. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  10. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  11. Morten Stenshorne (mstenshoohnoyoudont@chromium.org)
  12. Christian Dullweber (dullweberohnoyoudont@chromium.org)
  13. Xida Chen (xidachenohnoyoudont@chromium.org)
  14. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)

Timing:

Create Friday, 12-Oct-18 13:45:38 UTC
Start Friday, 12-Oct-18 13:45:48 UTC
End Friday, 12-Oct-18 14:43:09 UTC
Pending 10 secs
Execution 57 mins 21 secs

All Changes:

  1. Restore FrameLoadRequest::HrefTranslate

    Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:42:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 703e2b8a5b805ecd4fba4bffb76095125330cec4

    Comments

    Restore FrameLoadRequest::HrefTranslate
    
    This was accidentaly removed as part of FrameLoadRequest cleanup.
    
    Bug: none
    Change-Id: I58bf324729d397a2f0340831fd116ab749f7a213
    Reviewed-on: https://chromium-review.googlesource.com/c/1278290
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599196}

    Changed files

    • third_party/blink/renderer/core/html/html_anchor_element.cc
    • third_party/blink/renderer/core/loader/frame_load_request.h
  2. ProfileSyncService cleanup: Remove platform_sync_allowed_provider_

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:42:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f0d63432c51741e6dc0bf48f0b84e4afb63f887f

    Comments

    ProfileSyncService cleanup: Remove platform_sync_allowed_provider_
    
    ProfileSyncService::platform_sync_allowed_provider_ was a callback that
    returned whether Android's "Master Sync" toggle is enabled, and so Sync
    shouldn't start up. However, PSS didn't know when the value changed, so
    the callback was kinda useless, and PSS could easily get into an
    inconsistent state (where there is a disable reason, but Sync is still
    running). Things were working out in practice only because the Android
    UI code also called RequestStart/Stop as necessary.
    So, since PSS needs change notifications anyway, let's make that
    explicit: This CL replaces the callback by a bool, which can be set
    explicitly.
    
    Bug: 867901
    Change-Id: I5b7e9f4657d1f565d9643984eb52ec1df26b5c90
    Reviewed-on: https://chromium-review.googlesource.com/c/1269870
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599195}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java
    • chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java
    • chrome/browser/sync/profile_sync_service_android.cc
    • chrome/browser/sync/profile_sync_service_android.h
    • components/browser_sync/profile_sync_service.cc
    • components/browser_sync/profile_sync_service.h
  3. [Autofill Assistant] Add Mathias and I as owners

    Changed by Stephane Zermatten - szermattohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:39:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b71114eba7ab4e982eaf03186b12503c8ca49c4

    Comments

    [Autofill Assistant] Add Mathias and I as owners
    
    Change-Id: I71ed01f39d1c81c62828d8e4900091e7941e7ab1
    Reviewed-on: https://chromium-review.googlesource.com/c/1278399
    Reviewed-by: Ganggui Tang <gogerald@chromium.org>
    Commit-Queue: Ganggui Tang <gogerald@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599194}

    Changed files

    • components/autofill_assistant/OWNERS
  4. Hook up skia makeYUVAPromiseTexture API

    Changed by Peng Huang - penghuangohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:39:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 33ca177f048a1d593c5486b46f09ac9ea91071a9

    Comments

    Hook up skia makeYUVAPromiseTexture API
    
    Know issues:
     * Skia only draws Y plane.
     * makeYUVAPromiseTexture() will release context, even if it failed.
     * Skia doesn't accept GL_RGBA8 format for a yuva plane
    
    Bug: 824382
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Change-Id: Ic8da2b3de574ef2a0d527c79f34d383a676a3bc0
    Reviewed-on: https://chromium-review.googlesource.com/c/1262421
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Commit-Queue: Peng Huang <penghuang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599193}

    Changed files

    • components/viz/service/display/skia_output_surface.h
    • components/viz/service/display/skia_renderer.cc
    • components/viz/service/display_embedder/skia_output_surface_impl.cc
    • components/viz/service/display_embedder/skia_output_surface_impl.h
    • components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
    • components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.h
  5. Make DataPipeBytesConsumer support ReadableStream loading better.

    Changed by Ben Kelly - wanderviewohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:36:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c43eba9311573672d0773beed07f117d08eed09f

    Comments

    Make DataPipeBytesConsumer support ReadableStream loading better.
    
    This CL fixes some edge condition interactions when being loaded as
    a ReadableStream.  In particular, it:
    
    1. Properly distinguishes between the end of the DataPipe and a closed
       DataPipe with bytes left to be read.  A ReadableStream that is not
       actively draining the pipe could get closed too early.
    2. Responses must support explicit completion in order to handle error
       conditions properly.  This CL makes DataPipeBytesConsumer wait
       for an explicit signal before closing.
    3. Service worker navigation preload is updated to provide the explicit
       completion signals.
    
    Bug: 894815
    Change-Id: I8cff3de94aa2dcbc8deb4a9601a95c13b8ab94d9
    Reviewed-on: https://chromium-review.googlesource.com/c/1272715
    Commit-Queue: Ben Kelly <wanderview@chromium.org>
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599192}

    Changed files

    • content/browser/service_worker/service_worker_browsertest.cc
    • third_party/blink/renderer/core/fetch/bytes_consumer.h
    • third_party/blink/renderer/core/fetch/data_pipe_bytes_consumer.cc
    • third_party/blink/renderer/core/fetch/data_pipe_bytes_consumer.h
    • third_party/blink/renderer/core/fetch/data_pipe_bytes_consumer_test.cc
    • third_party/blink/renderer/core/fetch/fetch_data_loader.cc
    • third_party/blink/renderer/core/fetch/fetch_data_loader.h
    • third_party/blink/renderer/modules/service_worker/fetch_event.cc
    • third_party/blink/renderer/modules/service_worker/fetch_event.h
    • third_party/blink/renderer/modules/service_worker/fetch_respond_with_observer.cc
  6. Avoid using gypi_to_gn.py.

    Changed by Shu Chen - shuchenohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 13:25:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b85f543af1e343404dde1a2c51067b2ed5ac08cb

    Comments

    Avoid using gypi_to_gn.py.
    
    Change-Id: I9bac8317577feaadfa00ec88661175b7338ced4a
    Reviewed-on: https://chromium-review.googlesource.com/c/1267596
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Shu Chen <shuchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599191}

    Changed files

    • third_party/google_input_tools/README.chromium
    • third_party/google_input_tools/builder.py
    • third_party/google_input_tools/closure.gni
    • third_party/google_input_tools/inputview.gni
    • third_party/google_input_tools/inputview.gypi
    • third_party/google_input_tools/update.py
    • ui/keyboard/BUILD.gn
  7. Revert "Files app: Select My files when there are no volumes"

    Changed by Findit - findit-for-meohnoyoudont@appspot.gserviceaccount.com
    Changed at Friday, 12-Oct-18 13:17:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 402571f89e1aff1627ccf491110764c74029e3de

    Comments

    Revert "Files app: Select My files when there are no volumes"
    
    This reverts commit 5cd8c123e452c0b76fbbcaf53e82d86ca7d54930.
    
    Reason for revert:
    
    Findit (https://goo.gl/kROfz5) identified CL at revision 599026 as the
    culprit for flakes in the build cycles as shown on:
    https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNWNkOGMxMjNlNDUyYzBiNzZmYmJjYWY1M2U4MmQ4NmNhN2Q1NDkzMAw
    
    Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/9016
    
    Sample Failed Step: viz_browser_tests
    
    Sample Flaky Test: FileDisplay/FilesAppBrowserTest.Test/fileDisplayWithoutVolumesThenMountDrive_DriveFs
    
    Original change's description:
    > Files app: Select My files when there are no volumes
    > 
    > Make Files app select "My files" when there are no available volumes,
    > this to allow Files app to behave properly when volumes subsequently
    > become available.
    > 
    > Change DirectoryModel.onVolumeInfoListUpdated_ method to check for
    > non-null |displayRoot| before trying to change to |displayRoot|. This
    > fixes the error "Cannot read property 'getParent' of null" when Drive
    > volume becomes available before Downloads volume, which is the default
    > volume/root.
    > 
    > Change FakeDriveFs to unbind the two mojo bindings if they're bound, so
    > DriveFsTestVolume can re-mount itself.
    > 
    > Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*"
    > Bug: 893161, 884967
    > Change-Id: Ic813b25261530495c11c9f641a92f6e07f883702
    > Reviewed-on: https://chromium-review.googlesource.com/c/1272418
    > Reviewed-by: Noel Gordon <noel@chromium.org>
    > Reviewed-by: Sam McNally <sammc@chromium.org>
    > Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599026}
    
    Change-Id: I883485c8fc1bdcc22dba93cc4b03b7c157dcb5f2
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 893161, 884967, 889703
    Reviewed-on: https://chromium-review.googlesource.com/c/1278063
    Cr-Commit-Position: refs/heads/master@{#599190}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
    • chromeos/components/drivefs/fake_drivefs.cc
    • ui/file_manager/file_manager/foreground/js/directory_model.js
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/integration_tests/file_manager/file_display.js
  8. Start using IdentityTestEnvironment in ProfileSyncServiceBundle

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:10:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 863a437d0fdbbba19ad5446420b72d2f91748a72

    Comments

    Start using IdentityTestEnvironment in ProfileSyncServiceBundle
    
    ProfileSyncServiceBundle owns and exposes signin-related objects for
    use by sync tests. These signin-related objects include ones that are
    deprecated by IdentityManager and no longer used directly in the
    production code being tested; however, up until now it has not been
    feasible to convert this test utility to using IdentityTestEnvironment,
    as doing so would have required converting the widespread usage of this
    utility in one go.
    
    We recently introduced an IdentityTestEnvironment usage mode wherein
    it can be supplied with IdentityManager's dependencies from the
    external client, precisely to enable incremental conversion in use cases
    like this. This CL exploits this usage mode to introduce
    IdentityTestEnvironment in ProfileSyncServiceBundle.h and provide an
    example of its usage to eliminate a direct usage of the deprecated
    classes. Once the conversion is complete, ProfileSyncServiceBundle can
    then be changed to *only* hold an IdentityTestEnvironment object.
    
    Bug: 886600, 886599
    Change-Id: I205c3567fc0a9bcd6f7b613c00a247c302d71be5
    Reviewed-on: https://chromium-review.googlesource.com/c/1273065
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599189}

    Changed files

    • components/browser_sync/BUILD.gn
    • components/browser_sync/profile_sync_service_autofill_unittest.cc
    • components/browser_sync/profile_sync_test_util.cc
    • components/browser_sync/profile_sync_test_util.h
  9. Import wpt@e8a20c396e2ed7b7b8b2cacd3128f959e710a243

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:59:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c12ec9eedc27e721f93de806016cfcf26225fde9

    Comments

    Import wpt@e8a20c396e2ed7b7b8b2cacd3128f959e710a243
    
    Using wpt-import in Chromium 68550e484d7eecf6bd1d39fca300644ab2c21f5d.
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25974
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    NOAUTOREVERT=true
    TBR=lukebjerring
    
    No-Export: true
    Change-Id: I132a332cdc953a69e5c54c550a9bb4e5d08c9bb5
    Reviewed-on: https://chromium-review.googlesource.com/c/1277603
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599188}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/webrtc.idl
  10. Roll src-internal f37e9866851d..2cecd6e79600 (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 12:56:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2f64dae1358dab03fb6fb5e12fc444dad20d38f4

    Comments

    Roll src-internal f37e9866851d..2cecd6e79600 (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f37e9866851d..2cecd6e79600
    
    
    Created with:
      gclient setdep -r src-internal@2cecd6e79600
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Iac9c77c5c0927e0ca3862bf5171f5972e5c40ca7
    Reviewed-on: https://chromium-review.googlesource.com/c/1278711
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599187}

    Changed files

    • DEPS
  11. [LayoutNG] Mark nopaint-after-layer-destruction.html as passing again.

    Changed by Morten Stenshorne - mstenshoohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:45:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 17f212ee41ac78c428f851f24fa76ffee0ec8c3d

    Comments

    [LayoutNG] Mark nopaint-after-layer-destruction.html as passing again.
    
    Needed some rebaselining on Mac.
    
    Attempted to mark it as passing here:
    https://chromium-review.googlesource.com/c/1277649
    
    Then a sheriff marked it as failing again:
    https://chromium-review.googlesource.com/c/chromium/src/+/1278785
    
    TBR=kojii@chromium.org,orphis@chromium.org
    
    Change-Id: I4b282cba19e6c94f032c127f70672cf4cfe133ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1278805
    Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599186}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/platform/mac/fast/block/float/nopaint-after-layer-destruction-expected.txt
    • third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng/fast/block/float/nopaint-after-layer-destruction-expected.png
  12. Log UserDeletedCookieOrCacheFromDialog from Android

    Changed by Christian Dullweber - dullweberohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:43:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aeec7095a6a5129132a4fe7e5f5f0abeb2cf8ff3

    Comments

    Log UserDeletedCookieOrCacheFromDialog from Android
    
    We currently log the UserDeletedCookieOrCacheFromDialog histogram from
    Desktop. On Android we only know about total cookie/cache deletion
    and not those started from CBD.
    This CL adds logging of the UserDeletedCookieOrCacheFromDialog histogram
    to the CBD dialog on Android.
    
    Change-Id: I51c1ff6d3c5dc6f531f5bfccc59f522718b1abef
    Reviewed-on: https://chromium-review.googlesource.com/c/1276605
    Commit-Queue: Christian Dullweber <dullweber@chromium.org>
    Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599185}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesBasic.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java
    • content/public/android/BUILD.gn
    • content/public/browser/browsing_data_remover.h
  13. Rename OnHasTouchEventHandlersForTest in InputRouterImpl

    Changed by Xida Chen - xidachenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:40:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0f7980b37fba64a72e95e35f17633e6cb3915321

    Comments

    Rename OnHasTouchEventHandlersForTest in InputRouterImpl
    
    The call site of this function is resetting the |allowed_touch_action_|
    only, so rename this function to ForceResetTouchActionForTest.
    
    This CL should not introduce any behavior change.
    
    Bug: None
    Change-Id: I253d73f4f21bdb6268f43ce535453412f4b32c51
    Reviewed-on: https://chromium-review.googlesource.com/c/1277947
    Commit-Queue: Xida Chen <xidachen@chromium.org>
    Reviewed-by: James MacLean <wjmaclean@chromium.org>
    Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599184}

    Changed files

    • content/browser/renderer_host/input/input_router_impl.cc
    • content/browser/renderer_host/input/input_router_impl.h
    • content/browser/renderer_host/input/touch_action_filter.cc
    • content/browser/renderer_host/input/touch_action_filter.h
    • content/browser/site_per_process_hit_test_browsertest.cc
    • content/public/test/browser_test_utils.cc
  14. Roll src/third_party/webrtc 28d200c24624..55d1af14751a (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 12:35:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9729f6efb4bae858cc91b281091f2df86433da8a

    Comments

    Roll src/third_party/webrtc 28d200c24624..55d1af14751a (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/28d200c24624..55d1af14751a
    
    
    git log 28d200c24624..55d1af14751a --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 terelius@webrtc.org Remove support for microsecond resolution in RtcEventLogs.
    2018-10-12 sprang@webrtc.org Move TemporalLayers to api/video_codecs.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@55d1af14751a
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I15b74c4ebe322c1004b1ba8d1cfb25d82b65614c
    Reviewed-on: https://chromium-review.googlesource.com/c/1278709
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599183}

    Changed files

    • DEPS