Home | Search | chromium - Builders
Login

Builder Linux Builder (dbg) Build 126920 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision7cde465a809facc9ecb61350aaa5c504a36d9174
Got Revision7cde465a809facc9ecb61350aaa5c504a36d9174

Execution:

Steps and Logfiles:

Show:
  1. ( 318 ms ) setup_build
    running recipe: "chromium"
  2. ( 483 ms ) remove .cipd
  3. ( 49 secs ) bot_update
    [111GB/295GB used (37%)]
  4. ( 0 ) ensure_goma
  5. ( 627 ms ) swarming.py --version
    0.13
  6. ( 10 secs ) gclient runhooks
  7. ( 584 ms ) read test spec (chromium.linux.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.linux.json
  8. ( 12 secs ) generate_build_files
  9. ( 2 mins 45 secs ) compile
  10. ( 4 mins 19 secs ) isolate tests
  11. ( 19 mins 26 secs ) package build
  12. ( 1 secs ) trigger

Build Properties:

NameValueSource
$build/goma {"jobs": 500} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm892-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531413282161960, "id": "8941190502203210688", "project": "chromium", "tags": ["builder:Linux Builder (dbg)", "buildset:commit/git/7cde465a809facc9ecb61350aaa5c504a36d9174", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/7cde465a809facc9ecb61350aaa5c504a36d9174", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106620564505616800", "scheduler_job_id:chromium/Linux Builder (dbg)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Linux Builder (dbg)" setup_build
buildnumber 126920 setup_build
mastername "chromium.linux" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "7cde465a809facc9ecb61350aaa5c504a36d9174" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "7cde465a809facc9ecb61350aaa5c504a36d9174" bot_update
got_revision_cp "refs/heads/master@{#574594}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23950}" bot_update
swarm_hashes_refs/heads/master(at){#574594}_without_patch {"accessibility_unittests": "a02d24c185b02d2cc5fc538a52f956a5d1131e82", "angle_unittests": "12cf16fc07debd9532e37ff6399beb2e89300cd4", "app_shell_unittests": "08e2826365d99f1b4922b327b22e63044f838942", "aura_unittests": "53650b0e1853c9ff6241cdf915ecb58a624af2d5", "base_unittests": "012246adec66e15f49b34b544c1486e415f6b8c9", "battor_agent_unittests": "b880606ee30b25c225ba389fb8c69e8492663688", "blink_common_unittests": "9cf264ca463d622c9bacfcb74f66f64a979b5808", "blink_fuzzer_unittests": "dca4ed97e6e44f16ff13d01bd49096db75b703c3", "blink_heap_unittests": "7ea23fe063b1bee75fda4d25295288318c3641a8", "blink_platform_unittests": "b108815d2f3a018da5fe044de906f340791032d3", "boringssl_crypto_tests": "5f0c750f477056d2e754138cb6548d862df524bf", "boringssl_ssl_tests": "7afe60b05fed7c073cd592a0f1efe454e4e345fe", "browser_tests": "85bce1edcb09656c768fb034acf111ac98cdb7d1", "cacheinvalidation_unittests": "6afcb15f84ec6eb976e771c8eabd9df158cc8d00", "capture_unittests": "e1fbe96a4a0d53ad08abffa28a1b10271de3f7c0", "cast_unittests": "6908edebd924e09beea0ebf7433c439aa15f8abc", "cc_unittests": "ed4f5c2e0c493ad478d1a73a5d9601942dd3a83f", "chrome_app_unittests": "27b415dbb9f0394973c78067648685116c39f55b", "chromedriver_unittests": "e813e41e76f901bf3dd8bdb8ea18ac5b7176b143", "components_browsertests": "7228e8cf153f9adc099fe1664e688b6e6c4b9be5", "components_unittests": "f8fdde06e655b239e2f57a67be2f82dd1d9eed42", "compositor_unittests": "94bb2fea3148bcc1b05c1b1cbecbdebe91ce7bca", "content_browsertests": "297ec547e0392c0065960e910b73a0f7b07ded15", "content_shell_crash_test": "fcae4c320e42a0c8422b184fdc8949f810e4a10c", "content_unittests": "3b94dbccbe37c82c1c682f83bea0a2481e65d42c", "cronet_tests": "b286790bc5c036e57644d749b9a6de4401885f63", "cronet_unittests": "98b1b3f42ed82453b0b22c04fb89ec37114216a1", "crypto_unittests": "8353b8939c325d83b6b5ccd0e6531f60ccac473d", "dbus_unittests": "0b70b7976de0b4ed5ed27e99cc31724b8ecaf1ea", "device_unittests": "7ec36bc613fe01b0e56517f6b13e22e33368aaf8", "devtools_closure_compile": "5712bfba0877c61b47ff2e4a83e175fc5256cae0", "devtools_eslint": "b258b411dd1c4c7173cb486e3e20abbb5ad2a7a7", "display_unittests": "a516ecda719bff3ddec76b714e5bb46550e0a719", "events_unittests": "e6607087e8b097b51abb3b7acd454bd0a8dabcf3", "extensions_browsertests": "f11e863463ca9026290ae5d4c321f1bd2521e956", "extensions_unittests": "d9e7e6c8a767529e82e7f13951e155cc46281163", "filesystem_service_unittests": "d1fe5e354d1fa40c82829d60b9b8b9ff6200678a", "gcm_unit_tests": "f490708e16dfdf12d8b442b98bdde3975a960365", "gfx_unittests": "dad05f22423dbdc9440285a2401f5af3cf41105d", "gin_unittests": "cfb5aeb4a30ba6d7f0297ede3d16913fe0edc4a6", "google_apis_unittests": "786ab8891146bc64efc093c07f319071b09ffaed", "gpu_unittests": "4a9c9e47b8db31a882853c21dd43954eb6ec8eff", "headless_browsertests": "1a89e8d4a50b864d3668931643acaf0bebbadd70", "headless_unittests": "7649b8bccfe9ae53953c84f9300041b94d5f3076", "interactive_ui_tests": "5f0366a2161174a614fd81823e8c4610285e7074", "ipc_tests": "0bc5b105bd59ccaad2839aa23864f5552f8126d6", "jingle_unittests": "12ad5788df0616a614da1bd3b36d69a089f62a63", "latency_unittests": "84a0f04939a19d6fd4b91ebaa6999417663b4465", "leveldb_service_unittests": "fde1579d5f1c7e6bece8c20a940961cee2625642", "libjingle_xmpp_unittests": "41b8b5c9aa7495e345f7332db6644ed930e7b34a", "media_blink_unittests": "befb0c6690d62ef5f8d65fb1bb4440f1824ecb47", "media_service_unittests": "bf62d21cd7e9ddf56c483dbf2973d41795574a20", "media_unittests": "ec0d7043f0a8cdb78daa9e62cac83d568355a78f", "message_center_unittests": "6373b069edcd22a5c0c241d3b9fa7908fa8dcd4c", "metrics_python_tests": "d840bbf14a1a5d11d7e42f3762efdc9aaaa3ab30", "midi_unittests": "5dea8860c3e2d5e2f69ca2e6e364b319330c9b79", "mojo_core_unittests": "883065f456fe51a2b34b6387ac404ed611f36678", "mojo_unittests": "7fea59bd51842dfe636a443f0d14c7c33c2f2d8b", "nacl_helper_nonsfi_unittests": "ad47a86c1807471fe1d223930670e96f994b001c", "nacl_loader_unittests": "1f5277efa17123848a3c314a49692cee5a3887f3", "native_theme_unittests": "21721fff92ed46f6d6b1e40e225fcd66adf14fe4", "net_unittests": "7d398fac000e46a66fc711411a3aab1e6f32ecef", "pdf_unittests": "294d5e17d67ab57f8ea3debac9db36054496d455", "ppapi_unittests": "bdc42de065befb70817713561e5def10ee829481", "printing_unittests": "6c419d8b04eaecedba071e332f1ecff706094e0f", "remoting_unittests": "d2e44a2612974eef1e003080e0498eb819331808", "sandbox_linux_unittests": "20a91847cbda7fb9bddcb61bd179f1eaf283bed9", "service_manager_unittests": "9bbf35f0a1579b58d2f383baa2d8a8df4d009e5a", "services_unittests": "a85b67eba305818b8c3200785cceed0a16c8ee0b", "shell_dialogs_unittests": "db56801baee1f198ad801576a908a63215c7f647", "skia_unittests": "aa61eaccb5e1a005924f39e0f17bb558167d37a2", "snapshot_unittests": "dea01f752397827ffba67d238e6308b5397ba417", "sql_unittests": "c05ee65e1cee6f849024179e2231ef717d88a4c1", "storage_unittests": "4d4e86609fc207d22cfc538d7944f9442d91cef6", "sync_integration_tests": "d13759b49ef0db63c01a967c897c9b0f2631f79d", "telemetry_gpu_unittests": "a700f66266c7439e3ca49e1c14b7207844254ecf", "telemetry_perf_unittests": "cfc0f1cbe1de1d1dd5ef411afd7ad0e7e2a451b5", "telemetry_unittests": "0f19afa0f8f624ae1e4e48dc0abe5995bcd0a960", "ui_base_unittests": "ee720127d7ecd125fda58920fb702d1d436bd0cf", "ui_touch_selection_unittests": "e215e8d12b555fc042138a29fbdd77e86399fae4", "unit_tests": "d071fe34130a7d83bedd5b6cb738287538a83605", "url_unittests": "c8754a405349b23161e9beae3a7c7fc8fa130e8d", "views_perftests": "45405f287e31271c845f3af1eaeb04876ae6eaa6", "views_unittests": "c0f21e3b9751f8e69620dac1d83d789a2f9bd36a", "viz_unittests": "8466ea487eabda689b6190a7de60d0ee68f0d6cc", "vr_common_unittests": "135f90708c5244b54f89478dbc38b56b1b911312", "vr_pixeltests": "0dd6b9af8710b588c48fb161c6ed9d158c79b902", "webkit_layout_tests_exparchive": "4c054a9302a03967fe05f3f0bc55a73ead287598", "webkit_python_tests": "6b90d5b97bd50b83f3d280af327e3a5941ae87d7", "webkit_unit_tests": "7efa6733b0a9278e472284a1ed55b8a3b42ac249", "wm_unittests": "a06842017bc2addd7066e55d2a147c48281287de", "wtf_unittests": "8d4c7fc3822cc7a80c9f7a637c47d0e5de6ba747"} isolate tests
build_archive_url "gs://chromium-linux-archive/chromium.linux/Linux Builder (dbg)/full-build-linux_7cde465a809facc9ecb61350aaa5c504a36d9174.zip" package build

Blamelist:

  1. Nick Burris (nburrisohnoyoudont@google.com)
  2. Rayan Kanso (rayankansohnoyoudont@chromium.org)
  3. Mike Reed (reedohnoyoudont@google.com)
  4. Peter E Conn (peconnohnoyoudont@chromium.org)
  5. Peter Kasting (pkastingohnoyoudont@chromium.org)
  6. Takuto Ikuta (tikutaohnoyoudont@chromium.org)
  7. Jay Civelli (jcivelliohnoyoudont@google.com)
  8. Stefan Zager (szagerohnoyoudont@chromium.org)
  9. Bruce Dawson (brucedawsonohnoyoudont@chromium.org)
  10. Peter Kasting (pkastingohnoyoudont@chromium.org)
  11. Fabio Tirelo (ftireloohnoyoudont@chromium.org)
  12. Devlin Cronin (rdevlin.croninohnoyoudont@chromium.org)
  13. Chris Lu (thegreenfrogohnoyoudont@chromium.org)
  14. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  15. Peter Wen (wnwenohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 16:34:42 UTC
Start Thursday, 12-Jul-18 16:34:43 UTC
End Thursday, 12-Jul-18 17:06:10 UTC
Pending 1 secs
Execution 31 mins 26 secs

All Changes:

  1. Settings WebUI: Fix extensions url on cleanup result page

    Changed by Nick Burris - nburrisohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:33:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7cde465a809facc9ecb61350aaa5c504a36d9174

    Comments

    Settings WebUI: Fix extensions url on cleanup result page
    
    The cleaner success string now has HTML in it, and the JS i18n
    function strips it off. i18nAdvanced allows us to let the <a> through to
    the string, but the way the cleanup result page works is it simply sets
    the card text variable ("title") to the result message string. This
    would result in the raw string (with HTML) getting displayed, so the
    title variable needs to also be set to be the inner-h-t-m-l.
    
    Bug: 853339
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I8ea98e9868f83fc14a674841072cc2915c7b4a48
    Reviewed-on: https://chromium-review.googlesource.com/1134191
    Commit-Queue: Nick Burris <nburris@google.com>
    Reviewed-by: proberge <proberge@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574594}

    Changed files

    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
    • chrome/test/data/webui/settings/chrome_cleanup_page_test.js
  2. [Background Fetch] Add DB corruption handler to data manager observer.

    Changed by Rayan Kanso - rayankansohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:31:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 96544636e959581575b9c4f1ac2ecd1c5f40296d

    Comments

    [Background Fetch] Add DB corruption handler to data manager observer.
    
    Bug: 850512
    Change-Id: Iddd2773f63fd7aa0368e980a347c1bef4312f23d
    Reviewed-on: https://chromium-review.googlesource.com/1128839
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574593}

    Changed files

    • content/browser/background_fetch/background_fetch_context.cc
    • content/browser/background_fetch/background_fetch_context.h
    • content/browser/background_fetch/background_fetch_data_manager.cc
    • content/browser/background_fetch/background_fetch_data_manager.h
    • content/browser/background_fetch/background_fetch_data_manager_observer.h
    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.cc
    • content/browser/background_fetch/storage/database_task.cc
    • content/browser/background_fetch/storage/database_task.h
    • content/browser/background_fetch/storage/delete_registration_task.cc
    • content/browser/background_fetch/storage/get_settled_fetches_task.cc
    • content/browser/background_fetch/storage/mark_registration_for_deletion_task.cc
    • content/browser/background_fetch/storage/start_next_pending_request_task.cc
  3. suppress until skia roll

    Changed by Mike Reed - reedohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:30:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dcf8a49d5e3d2440dfc3f8e3126fa266fd25a33b

    Comments

    suppress until skia roll
    
    Bug: 863042
    Change-Id: I97a48047d0b6546055c255538fc31ddcc0a07078
    Reviewed-on: https://chromium-review.googlesource.com/1135288
    Commit-Queue: Mike Reed <reed@chromium.org>
    Commit-Queue: Florin Malita <fmalita@chromium.org>
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574592}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  4. 🤝 Add flag to force showing TWA disclosure.

    Changed by Peter E Conn - peconnohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:28:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 967fc76c423a5e86fc2e04b4655aa463d2ae7c12

    Comments

    🤝 Add flag to force showing TWA disclosure.
    
    Add a flag to force showing the disclosure for developer convenience.
    Also trigger even when there isn't an active tab yet.
    
    Bug: 813100
    Change-Id: I3ccd820d58f82040723a8f8a72097262ba374b82
    Reviewed-on: https://chromium-review.googlesource.com/1116922
    Reviewed-by: Benoit L <lizeb@chromium.org>
    Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
    Commit-Queue: Peter Conn <peconn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574591}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
    • chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
  5. Once TabStrip doesn't need it, there's no reason to expose GetTopOffset().

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:28:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b2b9af8ace2bbc3384147241601d4293f0c2259

    Comments

    Once TabStrip doesn't need it, there's no reason to expose GetTopOffset().
    
    Bug: none
    Change-Id: Ia78dd54f4364e7010ddf3ce16b01e5f5f3c764e4
    Reviewed-on: https://chromium-review.googlesource.com/1134499
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Allen Bauer <kylixrd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574590}

    Changed files

    • chrome/browser/ui/views/tabs/new_tab_button.cc
    • chrome/browser/ui/views/tabs/new_tab_button.h
  6. Keep timestamp in aar.py when file is not changed

    Changed by Takuto Ikuta - tikutaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:22:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d186e03f89aa3fa40dc7266cbc33a0310ac3dd8

    Comments

    Keep timestamp in aar.py when file is not changed
    
    This is a reland of
    https://chromium-review.googlesource.com/c/chromium/src/+/1127565
    I didn't understand filecmp.dircmp.
    
    Changed to use md5_check.CallAndRecordIfStale instead.
    Also let ExtractAll create directory even when it is empty.
    
    Bug: 810298, 860251
    Change-Id: I0d1e2e385ff1a12981473ef422099f638ca174cf
    Reviewed-on: https://chromium-review.googlesource.com/1132818
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574589}

    Changed files

    • build/android/gyp/aar.py
    • build/android/gyp/util/build_utils.py
  7. Simplify FakeGaiaCookieManagerService

    Changed by Jay Civelli - jcivelliohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:18:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8

    Comments

    Simplify FakeGaiaCookieManagerService
    
    Simplifying the FakeGaiaCookieManagerService API by not requiring to
    call Init() with a FakeURLFetcherFactory. The FakeURLFetcherFactory is
    instead a member of the FakeGaiaCookieManagerService.
    
    This API simplification is in preparation for switching GaiaAuthFetcher
    to use the SimpleURLLoader (network service).
    
    Bug: 840396
    Change-Id: I917e4236a53bf251c3a8e82c868d5e4d99655aca
    Reviewed-on: https://chromium-review.googlesource.com/1114226
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Commit-Queue: Jay Civelli <jcivelli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574588}

    Changed files

    • chrome/browser/extensions/api/identity/identity_apitest.cc
    • chrome/browser/search/one_google_bar/one_google_bar_service_unittest.cc
    • chrome/browser/signin/dice_response_handler_unittest.cc
    • chrome/browser/signin/fake_gaia_cookie_manager_service_builder.cc
    • chrome/browser/signin/fake_gaia_cookie_manager_service_builder.h
    • chrome/browser/signin/signin_ui_util_unittest.cc
    • chrome/browser/supervised_user/child_accounts/child_account_service_unittest.cc
    • chrome/browser/ui/views/frame/test_with_browser_view.cc
    • chrome/browser/ui/views/frame/test_with_browser_view.h
    • components/search_provider_logos/logo_service_impl_unittest.cc
    • components/signin/core/browser/account_investigator_unittest.cc
    • components/signin/core/browser/account_reconcilor_unittest.cc
    • components/signin/core/browser/fake_gaia_cookie_manager_service.cc
    • components/signin/core/browser/fake_gaia_cookie_manager_service.h
    • components/signin/core/browser/signin_manager_unittest.cc
  8. Get rid of GraphicsLayer::scrollable_area_

    Changed by Stefan Zager - szagerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:18:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 442f13b7e97747ab09612a101159b1eb26072382

    Comments

    Get rid of GraphicsLayer::scrollable_area_
    
    The only place where it was actually used was in
    GraphicsLayer::SetScrollbarsHiddenIfOverlay, so just forward that
    call to the GraphicsLayerClient.
    
    BUG=823365
    R=pdr@chromium.org,skobes@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I3cdd24ceb1ab51563dbc3b6d9ce50ce9edc77bf8
    Reviewed-on: https://chromium-review.googlesource.com/1132536
    Commit-Queue: Stefan Zager <szager@chromium.org>
    Reviewed-by: Steve Kobes <skobes@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574587}

    Changed files

    • third_party/blink/renderer/core/frame/visual_viewport.cc
    • third_party/blink/renderer/core/frame/visual_viewport.h
    • third_party/blink/renderer/core/layout/scrollbars_test.cc
    • third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
    • third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.h
    • third_party/blink/renderer/core/paint/compositing/graphics_layer_tree_as_text.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer.h
    • third_party/blink/renderer/platform/graphics/graphics_layer_client.h
  9. Add "latency" to list of ETW-traceable events

    Changed by Bruce Dawson - brucedawsonohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:15:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a5d9a9d75a9a8f7f6fb9d749c9b797eb2550d34e

    Comments

    Add "latency" to list of ETW-traceable events
    
    The "latency" category looks like a perfect event category for ETW
    tracing. In particular, TabSwitching::Latency indicates when Chrome
    thinks that tab switching has started and stopped which allows it to be
    profiled in detail. This has revealed where CPU time is going, and how
    long the delay is from when the keyboard event is generated to when
    Chrome starts officially processing it. This was helpful in
    investigating tab switching latency in bug 858944.
    
    This will require an update to UIforETW to fully enable, which I have
    done locally for testing purposes.
    
    Bug: 858944
    Change-Id: I4797b804ea6d35458aa3b4e876a78172a29d5131
    Reviewed-on: https://chromium-review.googlesource.com/1134516
    Reviewed-by: Primiano Tucci <primiano@chromium.org>
    Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574586}

    Changed files

    • base/trace_event/trace_event_etw_export_win.cc
  10. Remove NewTabButton::GetVisibleBounds().

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:13:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f448a241361b03dd2b6fd21ab052774e1074fdf1

    Comments

    Remove NewTabButton::GetVisibleBounds().
    
    This was a computed by constructing the border path and computing the bounding
    box.  However, it was only used for the ink drop, and ink drops are only used in
    newer material mode, where the border path is a square.
    
    Instead, we can use GetContentsBounds(), as long as those are actually
    positioned correctly.  The new tab button has empty space at the top, which is
    included (by the tabstrip) in its size and accounted for when doing painting and
    hittesting.  By adding an empty top border of this thickness, a lot of this code
    can be simplified.  (Further simplifications are coming in a subsequent CL.)
    
    Bug: none
    Change-Id: I431c6100d45b7f92a0ab1c9ed9f81f8fab436ebe
    Reviewed-on: https://chromium-review.googlesource.com/1134399
    Reviewed-by: Allen Bauer <kylixrd@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574585}

    Changed files

    • chrome/browser/ui/views/tabs/new_tab_button.cc
    • chrome/browser/ui/views/tabs/new_tab_button.h
    • chrome/browser/ui/views/tabs/tab_strip.cc
  11. [AF] Use views::Separator in the Autofill dropdown

    Changed by Fabio Tirelo - ftireloohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:13:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ff6fb086724fb3cd20409d3e72065bbd4a84abd

    Comments

    [AF] Use views::Separator in the Autofill dropdown
    
    This is a follow-up of crrev.com/c/1131680 and replace a custom view
    to simulate a separator with a views::Separator view.
    
    Change-Id: I0dc1db9c31039ce0959fa4aa4d37e4e99745a2d1
    Reviewed-on: https://chromium-review.googlesource.com/1133328
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574584}

    Changed files

    • chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
  12. [Extensions Cleanup] Clean up ScriptingPermissionsModifier unittests

    Changed by Devlin Cronin - rdevlin.croninohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:11:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b35e9edf0aed36764ee35db8ed9e66466bb18249

    Comments

    [Extensions Cleanup] Clean up ScriptingPermissionsModifier unittests
    
    Remove a redundant URLPatternSet comparison method from
    ScriptingPermissionsModifier unittests, instead leveraging the
    string comparison and gmock utilities. These are slightly less code
    and offer better failure messages.
    
    Bug: None
    
    Change-Id: Ic8b99f0c9294658d6bdd16738f179a2e352eb408
    Reviewed-on: https://chromium-review.googlesource.com/1134496
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574583}

    Changed files

    • chrome/browser/extensions/scripting_permissions_modifier_unittest.cc
  13. [ios] Set favicon fallback style for UI Refresh for ReadingList

    Changed by Chris Lu - thegreenfrogohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:05:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8eeff01fbfa506b55fc9f1c0126c618a788015a4

    Comments

    [ios] Set favicon fallback style for UI Refresh for ReadingList
    
    - Sets the fallback monogram and background colors to a constant color.
    
    Collections flag off screenshot: https://drive.google.com/file/d/10fYA9oHwx_o3cGWXBSR5P4qXKIPDTcfm/view?usp=sharing
    Collections flag on screenshot: https://drive.google.com/file/d/1WtAYb-fPE6QdR4rIpcWxuZtLjGr7iPNQ/view?usp=sharing
    
    Bug: 851390
    
    Change-Id: I7d67a4129263b2deed52eb7603b3f84aa8b8a201
    Reviewed-on: https://chromium-review.googlesource.com/1125271
    Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574582}

    Changed files

    • ios/chrome/browser/ui/reading_list/reading_list_mediator.mm
  14. Enable StaleWhileRevalidate in experimental features.

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:04:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fc2f58c6417a00888317b79f40fd904b1f6628b

    Comments

    Enable StaleWhileRevalidate in experimental features.
    
    To gather some stability enable it for experimental features before
    we do the origin trial.
    
    BUG=348877
    
    Change-Id: I7598f35ac87b719305c6efa98c37de2eec8031a4
    Reviewed-on: https://chromium-review.googlesource.com/1134883
    Reviewed-by: Robert Flack <flackr@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574581}

    Changed files

    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  15. Android: Default to full instead of fast

    Changed by Peter Wen - wnwenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:04:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5c98d04f201c356e8c4e811f3a43afa5c264750c

    Comments

    Android: Default to full instead of fast
    
    Switch from --full being optional to --fast being optional. Quite a few
    users of generate_gradle.py have found it unintuitive to have red
    underlines by default.
    
    Bug: 620034
    Change-Id: I24a19e16ed21baa19bde97bb2f3077430a73d148
    Reviewed-on: https://chromium-review.googlesource.com/1134882
    Commit-Queue: Peter Wen <wnwen@chromium.org>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574580}

    Changed files

    • build/android/gradle/generate_gradle.py