Home | Search | chromium - Builders
Login

Builder Linux ASan Tests (sandboxed) Build 51458 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision755d6f957abd6af5b8bbbf045ac622b92fea60a5
Got Revision755d6f957abd6af5b8bbbf045ac622b92fea60a5

Execution:

Steps and Logfiles:

Show:
  1. ( 315 ms ) setup_build
    running recipe: "chromium"
  2. ( 222 ms ) report builders
     
    running tester 'Linux ASan Tests (sandboxed)' on master 'chromium.memory'
  3. ( 22 secs ) bot_update
    [46GB/295GB used (15%)]
  4. ( 574 ms ) swarming.py --version
    0.13
  5. ( 9 secs ) gclient runhooks
  6. ( 939 ms ) read test spec (chromium.memory.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.memory.json
  7. ( 442 ms ) lookup builder GN args
     
    dcheck_always_on = true
    is_asan = true
    is_component_build = false
    is_debug = false
    is_lsan = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 433 ms ) build directory
  9. ( 418 ms ) find isolated tests
  10. ( 1 mins ) components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:07.628590
  11. ( 28 mins 20 secs ) content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:29:17.124916
  12. ( 2 secs ) interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:11:09.337854 (shard #0)
    Min shard duration: 0:07:20.413419 (shard #1)
  13. ( 29 secs ) browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:21:57.320040 (shard #6)
    Min shard duration: 0:17:05.928693 (shard #5)
  14. ( 322 ms ) Tests statistics
     
    Stats
    Total shards: 15
    Total runtime: 4:11:25.388689
     

Build Properties:

NameValueSource
$build/goma {"jobs": 500} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm625-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539335522458409, "id": "8932883431161738480", "project": "chromium", "tags": ["builder:Linux ASan Tests (sandboxed)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/755d6f957abd6af5b8bbbf045ac622b92fea60a5", "gitiles_ref:refs/heads/master", "parent_buildername:Linux ASan LSan Builder", "parent_buildnumber:60025", "scheduler_invocation_id:9098313493373279328", "scheduler_job_id:chromium/Linux ASan Tests (sandboxed)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Linux ASan Tests (sandboxed)" setup_build
buildnumber 51458 setup_build
mastername "chromium.memory" setup_build
parent_buildername "Linux ASan LSan Builder" setup_build
parent_got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" setup_build
parent_got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" setup_build
parent_got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" setup_build
parent_got_revision "755d6f957abd6af5b8bbbf045ac622b92fea60a5" setup_build
parent_got_revision_cp "refs/heads/master@{#599145}" setup_build
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" setup_build
parent_got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" setup_build
parent_got_v8_revision_cp "refs/heads/7.1.302@{#1}" setup_build
parent_got_webrtc_revision "a54daf162facb9fe30bcc3e05bd21c1597076157" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25135}" setup_build
parent_mastername "chromium.memory" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "755d6f957abd6af5b8bbbf045ac622b92fea60a5" setup_build
swarm_hashes {"accessibility_unittests": "a83fe10a48f4f4fd566567a2debde5e6387aa3bd", "angle_unittests": "e1a730edf0f1ed5dd01ba6ea9749fa54dd666206", "app_shell_unittests": "874ae2352d28c6fcfe3139c2ca28e1ff4a1c7a1a", "aura_unittests": "b9b378a61378f82c77da8ddcf4b25625cfb95199", "base_unittests": "fa72d68ca985b97b71c5abf1bc702176b1cc4553", "blink_common_unittests": "2620fe530c7a303858e432d70651d9fb1f7c2162", "blink_fuzzer_unittests": "a994f16092699dbee0f6831effba6894fe0e5853", "blink_heap_unittests": "534933d6371ff2c5bd4506598419d529cf97e9bb", "blink_platform_unittests": "0dd26c5405a6a2f841a5a391575ffb23d2b502ab", "boringssl_crypto_tests": "6597779d2b3016c2232a5c545f32cee80c8545cb", "boringssl_ssl_tests": "10dbbfb3d36d0acaa863e43d37047a4eee28905a", "browser_tests": "3fea7d8ef0e9ac8bd13d400038503c2380a9b752", "cacheinvalidation_unittests": "95d7d6aa1b982c5ec604956869eacccf24d0dea5", "capture_unittests": "f402a1ce45006ebf6e51eeec7170e6b3738dba72", "cast_unittests": "2c37f399e3830354f934e18efb99d00800de231d", "cc_unittests": "c8e770fd20ff043b8a75825a3bcec9d1e2bc628e", "chrome_app_unittests": "575af697c6edff092d4f761b41c8d302b12a7818", "chromedriver_unittests": "22e8de77ee239ee52cae7bcd09970ba51af6015a", "components_browsertests": "00a7c10015aafb5b0dedd36d35c8bec4987f371f", "components_unittests": "b261d33cb3c7388876afd746f8856c1e9e0fbb3d", "compositor_unittests": "8b878bb73ed1b75c40e0d803d724d3bd0cbf0059", "content_browsertests": "8ad4d16157658891df38cdee77ab4178c0edfd84", "content_unittests": "7e07578e6513b6df2c263db016350429c54a5d5c", "cronet_tests": "e08d641bbdc2d18a9f77573fca5a7adadd6bafe2", "cronet_unittests": "c21e22fbb42fe7acf7b51744c20f452efad43024", "crypto_unittests": "95b17943fb67a1750609a30764a0eeebe55a4d4b", "dbus_unittests": "b353de926c94e65d112db7d27cd53430f28c22f4", "device_unittests": "b7191a3a796891494a21e86eae2233ed61fdce17", "display_unittests": "1fcd86430f6acf395b1868ace51ebfbaa61e1118", "events_unittests": "4f44055178bac2eae780395ba2378f60d7640599", "extensions_browsertests": "94dfb05702888e2ad8f1b54349c7cdb051a3714c", "extensions_unittests": "bcbefb97fe6c20e4b9bd5720575df30eabf50221", "filesystem_service_unittests": "7b37276eff932e9869dc0b455fb89b05e20a7099", "gcm_unit_tests": "72cd02ff43e189a0e483e8870d273b403a7a1606", "gfx_unittests": "b70e6649284609443a72178e695b2883e782d15c", "gl_tests": "b13a444f7bda0960d18f123980fcbfb7d5c538ef", "gl_unittests": "1c2de6cc855fd95c0c06d005b08475cf56cee24b", "google_apis_unittests": "6cee1fadf15aaa1e261ef852a6ea2f06e1298b83", "gpu_unittests": "95c20cf7b4da81a1f2d5971aeaad15fdd85a25d7", "interactive_ui_tests": "8db6573e829e6598f91a8cf4b042425068c6e54a", "ipc_tests": "7ddd9a258b0fc70c08a569658e5d068fdd1d4e9c", "jingle_unittests": "ce28fb617153c2569b4888057682faf1ab7f9354", "latency_unittests": "d748f0a5d4c6e42a53260bfddfb4a895b6e8bdc9", "leveldb_service_unittests": "1ff5711b965223ef4ab75efdcd6c92cdc8c59ec1", "libjingle_xmpp_unittests": "7e9dacf812740dee4138028e7d53922ee84d82c6", "media_blink_unittests": "a919df76c57159cecd5d1ffdaf2e18eb8421a488", "media_service_unittests": "30a4e831a9f340ddd147d456af3f6b7de42dec0c", "media_unittests": "7190ce5e0b22938edb55c3c1b657f35120abf16a", "message_center_unittests": "24fb5e3a3ac533212b47da8f2a2168cd05aed9d1", "midi_unittests": "78260ae43a2806a5c65729f34696abb5a9ccf8c1", "mojo_core_unittests": "f2c307260b414c5ec6127f53b24965c895d8b622", "mojo_unittests": "e63d16b5670dd6617c0dd9f49aa3e8c6ca215a74", "nacl_helper_nonsfi_unittests": "b52f4c1f746ca9976b38f855e627487076869cf0", "nacl_loader_unittests": "3e20afb7b676c85b625b8ccd60dfdb23e6583df6", "native_theme_unittests": "248a4d11c03f7251281f93ac6ae596ca46d0849d", "net_unittests": "4f49b8de0c9145731af28451139d6ac612260926", "pdf_unittests": "fe9624b06cc8e8f0186ac7f081a4f26b498d5126", "ppapi_unittests": "f34d0acd0f7578c9ad9e8e446a57a4eada6143f4", "printing_unittests": "2a993274feea8cdc25eeb07369a8544125b03009", "remoting_unittests": "09aa0e0e176be384392acacb4813c1edf58796cc", "sandbox_linux_unittests": "9f291cddc2295fde86268e6d730baf79b5b34742", "service_manager_unittests": "dc10a31c4d6f3e722075ebfc2d6768fd198d67b3", "services_unittests": "8f22c56ee66d873afe41108004a8419b8aee4a7b", "shell_dialogs_unittests": "c6c0e716fec703db62665542e0b7e3d992eb8444", "skia_unittests": "1ebe65f03a05bd9a4b90ba2e2c7ac2c33b0ba768", "snapshot_unittests": "04fd9b2f8781c06559cc86c34ffb9b4d2f425c75", "sql_unittests": "c917681278e52634abf0dacb45617608c84dbc54", "storage_unittests": "34d85b2ec8ebed5a6d0dd078be15f459ec0c8df3", "sync_integration_tests": "ee8fde777daccf1bc842c275380956a06f59cf2a", "traffic_annotation_auditor_unittests": "c45ed480d19fa7a7974c51b2e14bad0caba53ed1", "ui_base_unittests": "783c62267849df59bd1db23b94dc23e2205d64df", "ui_touch_selection_unittests": "514951cdef08503259c5c362bb41fd6ee05fdb85", "unit_tests": "1816df7c5b8069fbb13284709d1afb42b18fae57", "url_unittests": "96d1fcda074186bba12a32f11dafabc2d86d1d29", "views_unittests": "ae6429e5732baf3dcf0466fbd593f76577dfbe32", "viz_unittests": "ae8081ed9b4c530157221ffd149567a7a79ef968", "vr_common_unittests": "84935711d86b0716cd1faffd74c5ba7905a6f30e", "vr_pixeltests": "5f21ce5324a6b4f163a741edb795505ac8c95d3a", "webkit_unit_tests": "a34b3f9a19b0e926da5c876c0d65ca3d99a73663", "wm_unittests": "6bdf0223d117c3bd72b5880f8a541a664f8b63e8", "wtf_unittests": "22ade5ec2d953fdc13b5ad1151242255dce8b9c7"} setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "755d6f957abd6af5b8bbbf045ac622b92fea60a5" bot_update
got_revision_cp "refs/heads/master@{#599145}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "a54daf162facb9fe30bcc3e05bd21c1597076157" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25135}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  2. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  3. Florent Castelli (orphisohnoyoudont@chromium.org)
  4. Fergal Daly (fergalohnoyoudont@chromium.org)
  5. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  6. A Olsen (olsenohnoyoudont@chromium.org)
  7. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 09:12:02 UTC
Start Friday, 12-Oct-18 09:12:07 UTC
End Friday, 12-Oct-18 09:43:56 UTC
Pending 5 secs
Execution 31 mins 48 secs

All Changes:

  1. [iOS] Support Accessibility ContentSize on NTP header

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:35:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 755d6f957abd6af5b8bbbf045ac622b92fea60a5

    Comments

    [iOS] Support Accessibility ContentSize on NTP header
    
    This CL changes the header of the "Articles for you" section of the NTP
    to have a better support for the "accessibility" categories of preferred
    content size chosen by the user.
    
    Bug: 893524
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I56ed6f89e7767697083c3e8e5d5a796db3066aee
    Reviewed-on: https://chromium-review.googlesource.com/c/1273522
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599145}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_articles_header_item.mm
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
  2. [iOS] Use Dynamic Type in the empty NTP cell

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:35:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c245af46fb47db066cbdc99a5f578e2b94b2ca2f

    Comments

    [iOS] Use Dynamic Type in the empty NTP cell
    
    This CL adds Dynamic Type to the cell displayed when the NTP's articles
    section is empty.
    
    Bug: 893527
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: If36d6ece1eaac888f606f7730de379aec11ba6be
    Reviewed-on: https://chromium-review.googlesource.com/c/1273536
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599144}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_text_item.mm
  3. Revert "Move InstallAttributes to chromeos/settings"

    Changed by Florent Castelli - orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:33:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f32368f166f8a2d51078a6c6c2f6ffc8c3f2f7a9

    Comments

    Revert "Move InstallAttributes to chromeos/settings"
    
    This reverts commit aa6c62dce936e966e2db445045dd04414553642b.
    
    Reason for revert: Breaks build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-daisy-rel/33402
    
    Original change's description:
    > Move InstallAttributes to chromeos/settings
    > 
    > Necessary for moving CrosSettings to chromeos/settings, so it
    > can eventually be used by Mustash.
    > 
    > The following changes were necessary:
    > 1. Move install_attributes{.h, .cc} and unit_test.cc
    > 2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn
    > (destination)
    > 3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h,
    > which is included by install_attributes.h
    > 
    > 4. Unfortunately, that same dependency lead to a circular dependency.
    > I was able to avoid that by separating out a "common_constants" rule in
    > components/policy/core/common, so that chromeos/settings only depends on
    > that, and not on all of components/policy. So I had to change
    > components/policy/core/common/BUILD.gn
    > and I removed an unnecessary include from
    > components/policy/core/common/cloud/cloud_policy_constants.cc
    > 
    > 5. Update #include directives for install_attributes to point to new
    > location. This is the other 22 files, all with diffs of +1 -1.
    > 
    > Bug: 446937
    > Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288
    > Reviewed-on: https://chromium-review.googlesource.com/c/1264757
    > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    > Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    > Commit-Queue: A Olsen <olsen@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599140}
    
    TBR=stevenjb@chromium.org,emaxx@chromium.org,olsen@chromium.org
    
    Change-Id: I50c58b55830961d97834d86a76088dc50eff672d
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 446937
    Reviewed-on: https://chromium-review.googlesource.com/c/1278748
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599143}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/app_mode/kiosk_app_manager.h
    • chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/dbus/dbus_helper.cc
    • chrome/browser/chromeos/login/demo_mode/demo_session.cc
    • chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
    • chrome/browser/chromeos/policy/blocking_login_browsertest.cc
    • chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
    • chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
    • chrome/browser/chromeos/policy/enrollment_status_chromeos.h
    • chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
    • chrome/browser/chromeos/settings/device_settings_provider.cc
    • chrome/browser/chromeos/settings/install_attributes.cc
    • chrome/browser/chromeos/settings/install_attributes.h
    • chrome/browser/chromeos/settings/install_attributes_unittest.cc
    • chrome/browser/chromeos/settings/stub_install_attributes.h
    • chrome/browser/chromeos/system/device_disabling_manager.cc
    • chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
    • chrome/browser/ui/webui/policy_ui_handler.cc
    • chromeos/DEPS
    • chromeos/settings/BUILD.gn
    • components/policy/core/common/BUILD.gn
    • components/policy/core/common/cloud/cloud_policy_constants.cc
  4. [css, dom] Support partmap="foo: bar" syntax.

    Changed by Fergal Daly - fergalohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:26:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cb84b573a62d8db8d168de16560b4ff78df5bda

    Comments

    [css, dom] Support partmap="foo: bar" syntax.
    
    This is the new syntax agreed for partmap.
    
    Bug: 805271
    Change-Id: I5e8e34551167b4a56706980dae8054e4b7a6fba2
    Reviewed-on: https://chromium-review.googlesource.com/c/1278566
    Commit-Queue: Fergal Daly <fergal@chromium.org>
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599142}

    Changed files

    • third_party/WebKit/LayoutTests/css-shadow-parts/double-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-change-part-name-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-change-partmap-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-complex-selector-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/precedence-part-vs-part.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/simple-forward.html
    • third_party/blink/renderer/core/dom/element_test.cc
    • third_party/blink/renderer/core/dom/names_map.cc
    • third_party/blink/renderer/core/dom/names_map_test.cc
    • third_party/blink/renderer/core/html/parser/html_parser_idioms.h
  5. Chrome OS Powerwash screen: update icon and illustration.

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:22:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision afc97ac06f5d3677c1016d1530c1e196844e2432

    Comments

    Chrome OS Powerwash screen: update icon and illustration.
    
    
    Bug: 894280
    Change-Id: I0d478790d35323008a0622404ebde6983fea06ae
    Reviewed-on: https://chromium-review.googlesource.com/c/1278211
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599141}

    Changed files

    • chrome/browser/resources/chromeos/login/images/1x/reset_illustration_1x.svg
    • chrome/browser/resources/chromeos/login/images/2x/reset_illustration_2x.svg
    • chrome/browser/resources/chromeos/login/images/reset_illustration_1x.png
    • chrome/browser/resources/chromeos/login/images/reset_illustration_2x.png
    • chrome/browser/resources/chromeos/login/oobe_reset.css
    • chrome/browser/resources/chromeos/login/oobe_reset.html
  6. Move InstallAttributes to chromeos/settings

    Changed by A Olsen - olsenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:19:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aa6c62dce936e966e2db445045dd04414553642b

    Comments

    Move InstallAttributes to chromeos/settings
    
    Necessary for moving CrosSettings to chromeos/settings, so it
    can eventually be used by Mustash.
    
    The following changes were necessary:
    1. Move install_attributes{.h, .cc} and unit_test.cc
    2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn
    (destination)
    3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h,
    which is included by install_attributes.h
    
    4. Unfortunately, that same dependency lead to a circular dependency.
    I was able to avoid that by separating out a "common_constants" rule in
    components/policy/core/common, so that chromeos/settings only depends on
    that, and not on all of components/policy. So I had to change
    components/policy/core/common/BUILD.gn
    and I removed an unnecessary include from
    components/policy/core/common/cloud/cloud_policy_constants.cc
    
    5. Update #include directives for install_attributes to point to new
    location. This is the other 22 files, all with diffs of +1 -1.
    
    Bug: 446937
    Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288
    Reviewed-on: https://chromium-review.googlesource.com/c/1264757
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Commit-Queue: A Olsen <olsen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599140}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/app_mode/kiosk_app_manager.h
    • chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/dbus/dbus_helper.cc
    • chrome/browser/chromeos/login/demo_mode/demo_session.cc
    • chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
    • chrome/browser/chromeos/policy/blocking_login_browsertest.cc
    • chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
    • chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
    • chrome/browser/chromeos/policy/enrollment_status_chromeos.h
    • chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
    • chrome/browser/chromeos/settings/device_settings_provider.cc
    • chrome/browser/chromeos/settings/stub_install_attributes.h
    • chrome/browser/chromeos/system/device_disabling_manager.cc
    • chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
    • chrome/browser/ui/webui/policy_ui_handler.cc
    • chromeos/DEPS
    • chromeos/settings/BUILD.gn
    • chromeos/settings/install_attributes.cc
    • chromeos/settings/install_attributes.h
    • chromeos/settings/install_attributes_unittest.cc
    • components/policy/core/common/BUILD.gn
    • components/policy/core/common/cloud/cloud_policy_constants.cc
  7. Import wpt@6446b4dc89324df48019ef6fa4999595d1f80abf

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:18:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 112288aae86b2fcd3dde5b2a67872e292e54a8b0

    Comments

    Import wpt@6446b4dc89324df48019ef6fa4999595d1f80abf
    
    Using wpt-import in Chromium fb7986d88b0b8f174020916003d6939d2d928b83.
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25972
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    hongchan@chromium.org, rtoy@chromium.org:
      external/wpt/webaudio
    
    NOAUTOREVERT=true
    TBR=robertma
    
    No-Export: true
    Change-Id: I9f8c2a91eb58657997bd243420a319e96a3ebc02
    Reviewed-on: https://chromium-review.googlesource.com/c/1278059
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599139}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-reuse.html