Home | Search | chromium - Builders
Login

Builder Linux ASan Tests (sandboxed) Build 48837 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision3e031a4fd51a2eefc216a0f80f4bb139e1812b6c
Got Revision3e031a4fd51a2eefc216a0f80f4bb139e1812b6c

Execution:

Steps and Logfiles:

Show:
  1. ( 299 ms ) setup_build
    running recipe: "chromium"
  2. ( 467 ms ) remove .cipd
  3. ( 4 mins 33 secs ) bot_update
    [95GB/295GB used (32%)]
  4. ( 590 ms ) swarming.py --version
    0.13
  5. ( 38 secs ) gclient runhooks
  6. ( 805 ms ) read test spec (chromium.memory.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.memory.json
  7. ( 3 secs ) build directory
  8. ( 20 mins 4 secs ) extract build
  9. ( 17 secs ) find isolated tests
  10. ( 25 mins ) browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:24:42.378510 (shard #3)
    Min shard duration: 0:17:34.815060 (shard #9)
  11. ( 1 secs ) components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:36.153520
  12. ( 4 mins 10 secs ) content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:29:42.835920
  13. ( 2 secs ) interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:09:51.696030 (shard #0)
    Min shard duration: 0:07:45.795950 (shard #1)
  14. ( 1 secs ) Tests statistics
     
    Stats
    Total shards: 15
    Total runtime: 4:11:47.504602
     

Build Properties:

NameValueSource
$build/goma {"jobs": 500} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm625-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531427993655770, "id": "8941175076083394160", "project": "chromium", "tags": ["builder:Linux ASan Tests (sandboxed)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/3e031a4fd51a2eefc216a0f80f4bb139e1812b6c", "gitiles_ref:refs/heads/master", "parent_buildername:Linux ASan LSan Builder", "parent_buildnumber:56159", "scheduler_invocation_id:9106605138235280144", "scheduler_job_id:chromium/Linux ASan Tests (sandboxed)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Linux ASan Tests (sandboxed)" setup_build
buildnumber 48837 setup_build
mastername "chromium.memory" setup_build
parent_buildername "Linux ASan LSan Builder" setup_build
parent_got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" setup_build
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" setup_build
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" setup_build
parent_got_revision "3e031a4fd51a2eefc216a0f80f4bb139e1812b6c" setup_build
parent_got_revision_cp "refs/heads/master@{#574679}" setup_build
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" setup_build
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" setup_build
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" setup_build
parent_got_webrtc_revision "798ee75d23651e7631775a113742bd09cc02e212" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23952}" setup_build
parent_mastername "chromium.memory" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "3e031a4fd51a2eefc216a0f80f4bb139e1812b6c" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "3e031a4fd51a2eefc216a0f80f4bb139e1812b6c" bot_update
got_revision_cp "refs/heads/master@{#574679}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "798ee75d23651e7631775a113742bd09cc02e212" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23952}" bot_update
swarm_hashes {"accessibility_unittests": "353d4749034b8d3a2212057f36dbb39d20ada56c", "angle_unittests": "9b1430f5df4bf9fe9a397279e8bde8c6b7bde293", "app_shell_unittests": "7e37154c714f80918cd8186823c9ddbb67e7c2a2", "aura_unittests": "194ab274f73abdf09e18db3da3b9094e21c7b33a", "base_unittests": "4bf69087c6b07083498f6d3d56a4f4c5c56d4d27", "battor_agent_unittests": "5e6a42828da61bb238cda10f5ec8a01879e91f4d", "blink_common_unittests": "429dfa2590268bdea718826dbb6fd992cad0df06", "blink_fuzzer_unittests": "1c94192a8e9902c6125191e260b1d7bc31a5c22f", "blink_heap_unittests": "1d43dae248799b8f01060c9fa10f0df87977901f", "blink_platform_unittests": "5a40326ffd1822d596ac2df55128a3e745c7517f", "boringssl_crypto_tests": "e8c75dc81bf99302f3d56dc795ad3be6c478e445", "boringssl_ssl_tests": "9ba49ff18093650a46278a17c2fbe3fd87999c8c", "browser_tests": "8fce0dbdb4d3e9ae93962c8893ca0f676de8cc45", "cacheinvalidation_unittests": "bddcce4fc65046fe3d7b4251b7d959ebc6053fc2", "capture_unittests": "8dd90284d175f6a852927393f0337fbb80151557", "cast_unittests": "b5fdeb0bd00948388c76ef63b9d5ee005359e1a5", "cc_unittests": "01d7f0ca80b85a1498a0711c8f5843f1c1fd581d", "chrome_app_unittests": "0cff8a8e214256721e121b10ce673ed83834c766", "chromedriver_unittests": "5cee28518072e3ef73c8c4757aba75abee0e70a4", "components_browsertests": "296eae371a6babd84461ee0f084e6b55f219893a", "components_unittests": "5ca5e793fe6873c3961bf4492e2a7b2b4cee3031", "compositor_unittests": "508749836503a929bc0ee1532543fd7337d79606", "content_browsertests": "2460f1ef85869640a02f86377d0f752cc948d08b", "content_unittests": "325112e012482d10e38067778567446687238f07", "cronet_tests": "440340115cb91f73a1c259492c0f1fc9c52e3fb9", "cronet_unittests": "7677f1e69c267b0da694673706a081669b232457", "crypto_unittests": "aff06f3fa31bf5773b01995021522eca3603c643", "dbus_unittests": "33092abbf73f2f8f6918f9ff514d66906dc4ff95", "device_unittests": "a37f9e9afbeb0e0dbe3b91d075f608c41f41326b", "display_unittests": "5534a3cf61ec89910e866de8867986abb23d79d0", "events_unittests": "ea3db82017c6489d071d9987d3503a005614b1c5", "extensions_browsertests": "73ce228298c2fad13b1d9d1b58537c1339c34f9c", "extensions_unittests": "e1b3a39e267d756b09af3ae4cdc59fd199f55059", "filesystem_service_unittests": "2964915391dda3e909ada20cf6908f370924d56c", "gcm_unit_tests": "46087a192a9d679188abd82fd34fa53c91f32096", "gfx_unittests": "4eaa6420845fbc3df2751f135ecf5a0b2f06b58f", "gl_tests": "7e2004793d43fbc7deb290d4f1ccbf72bdbdbfa1", "gl_unittests": "b6a08d377fb665b2de9e269cc30758b1edf43627", "google_apis_unittests": "8752402e653ef2e2c4998c06924dd9f760ba21ea", "gpu_unittests": "d341daeabb0d1de9cbb52cd1b3823326c7c36bb3", "interactive_ui_tests": "ebabaf5206537e2d1d11710f431a9a3306ac116a", "ipc_tests": "72aec086446f1ba568d6001ff0b12ff535ca92c9", "jingle_unittests": "66fadb06daa73ec4153f07f1ff4d3792ebf8669d", "latency_unittests": "3d466e894912be91ab6636d85b4c912562bf2c4b", "leveldb_service_unittests": "e739101538096aea621d4384162f8fbbf49cfba6", "libjingle_xmpp_unittests": "0e009feb21eada0f36d24125cea4146aa661dccd", "media_blink_unittests": "f450409e776f83ecaf16f87ffc302c60b4d2505c", "media_service_unittests": "8adcd07d7c3c9c803f07e9f27efe7a673004fd91", "media_unittests": "749add0af54317c61ed73e5a45bd8c4b1aa1ebd8", "message_center_unittests": "5b705ddc690e2ac41a919ee6c917387c0d1ff281", "midi_unittests": "7fa0618838e2f85a7fa8bdd29247edbce25be994", "mojo_core_unittests": "b6e8c2e6255617d1d33b814e040b295787b8e7a3", "mojo_unittests": "4a61a24d0ee231861f09bd2985ea491287b02477", "nacl_helper_nonsfi_unittests": "dbdb928746bc18eb99b3c10afababa958c908cc2", "nacl_loader_unittests": "e375996fa2002d7d8c5dfdd9a3a3adc33a30796f", "native_theme_unittests": "e69901703a326a62c34c2e98dc5276330f8623d9", "net_unittests": "7c6a8214c0824638d0dae37a54606b4933fd5838", "pdf_unittests": "9a3f8718c4723d9b0d98e2dc00bbf575fa50e92e", "ppapi_unittests": "f144728901015b5bb14d1090eb1d19f5b699e5c7", "printing_unittests": "f93b586f321f670dbacacc7b6eeb89a7bb67ab96", "remoting_unittests": "6d5038196fa29ce09c79ac57aab077bcb805ce05", "sandbox_linux_unittests": "b65fb7354c06d83660a94a3de64c8f829cb22a8d", "service_manager_unittests": "a9585373c26e0c5eec4d26a40d706b46bc9e7504", "services_unittests": "f738ad040a40a851e3fdec1793bde2e4cff6b294", "shell_dialogs_unittests": "ed8fd66a52b85c505879d909faaa920e8f5fe17e", "skia_unittests": "caa785953bb689ae621197244e4d600d09216dd8", "snapshot_unittests": "e94efe4a795e45da570163c6ad1e6a7fd0fab749", "sql_unittests": "fb19dbd60e4940707a66295e3001f20a588f6dd2", "storage_unittests": "630b4335dd83627207ac592a224a339bd61b5bc8", "sync_integration_tests": "586bdfd27005dbe11c7b7631b0d6bd4fafcf8a55", "traffic_annotation_auditor_unittests": "05fcb7ff77f69f926454656fc80e1dc8089a323b", "ui_base_unittests": "c1a975dde3735010a314827f11c47a5ba039e328", "ui_touch_selection_unittests": "73dbc60ac356694333b99e5be2a19d8020012dc4", "unit_tests": "d146a9e1821bb4525c5e251737610077868acba2", "url_unittests": "29c170984b188b3313b9eeebca295af695561ca7", "views_unittests": "bc100fb52b39621c71d4d1fd872721522daa5762", "viz_unittests": "053176f40655db97d858113b9ff989cdb20ea04d", "vr_common_unittests": "d2477e580e6a8983a220b0c69c8d34a8425e5b1f", "vr_pixeltests": "add6707262aa02182c89983a11eaa649bb6ebeb1", "webkit_unit_tests": "bbf08fdea1d0db2a2b7f6b9f385483493758172e", "wm_unittests": "0224e976dbb513ed7e1627e5a251ed4fefb6b86c", "wtf_unittests": "c79af766f6f1a4491246a52e6109e2099e8a62de"} find isolated tests

Blamelist:

  1. Kim Paulhamus (kpaulhamusohnoyoudont@chromium.org)
  2. fuchsia-sdk-chromium-autoroll (fuchsia-sdk-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  3. Ian Clelland (iclellandohnoyoudont@chromium.org)
  4. Fabio Tirelo (ftireloohnoyoudont@chromium.org)
  5. Kenneth Russell (kbrohnoyoudont@chromium.org)
  6. perfetto-chromium-autoroll (perfetto-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  7. Daniel Murphy (dmurphohnoyoudont@chromium.org)
  8. Chromite Chromium Autoroll (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  9. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  10. Lei Zhang (thestigohnoyoudont@chromium.org)
  11. Lu Chen (cheluohnoyoudont@chromium.org)
  12. Scott Chen (scottchenohnoyoudont@chromium.org)
  13. Kenneth Russell (kbrohnoyoudont@chromium.org)
  14. Kyle Milka (kmilkaohnoyoudont@chromium.org)
  15. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  16. Erik Luo (luoeohnoyoudont@chromium.org)
  17. Nate Fischer (ntfschrohnoyoudont@chromium.org)
  18. Michael Thiessen (mthiesseohnoyoudont@chromium.org)
  19. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
  20. Lei Zhang (thestigohnoyoudont@chromium.org)
  21. Scott Chen (scottchenohnoyoudont@chromium.org)
  22. Pedro Amaral (amaralpohnoyoudont@chromium.org)
  23. Christian Fremerey (chfremerohnoyoudont@chromium.org)
  24. Chris Palmer (palmerohnoyoudont@chromium.org)
  25. Tiger Oakes (tigeroohnoyoudont@google.com)
  26. Xiaocheng Hu (xiaochenghohnoyoudont@chromium.org)
  27. Weidong Guo (weidonggohnoyoudont@chromium.org)
  28. Min Qin (qinminohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 20:39:53 UTC
Start Thursday, 12-Jul-18 20:39:55 UTC
End Thursday, 12-Jul-18 21:36:21 UTC
Pending 1 secs
Execution 56 mins 25 secs

All Changes:

  1. Disable flaky SitePerProcessHitTestBrowserTest

    Changed by Kim Paulhamus - kpaulhamusohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:35:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e031a4fd51a2eefc216a0f80f4bb139e1812b6c

    Comments

    Disable flaky SitePerProcessHitTestBrowserTest
    
    [OverlapSurfaceHitTestTest]
    
    TBR=sunxd@chromium.org
    
    Bug: 833380
    Change-Id: I7991db84dd9201e59089f08a536bcab00b23d379
    Reviewed-on: https://chromium-review.googlesource.com/1135648
    Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
    Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574679}

    Changed files

    • content/browser/site_per_process_hit_test_browsertest.cc
  2. Roll Fuchsia SDK from cf3c39f9e29d to 64ef9c9bec71

    Changed by fuchsia-sdk-chromium-autoroll - fuchsia-sdk-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:34:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0708b273b84747404d79725f8be67c90f3047079

    Comments

    Roll Fuchsia SDK from cf3c39f9e29d to 64ef9c9bec71
    
    
    The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
    TBR=cr-fuchsia+bot@chromium.org
    
    Change-Id: I44aa919993e7873807987396622c8fcb0bf2a17f
    Reviewed-on: https://chromium-review.googlesource.com/1135632
    Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574678}

    Changed files

    • build/fuchsia/sdk.sha1
  3. Clean up feature policy flags.

    Changed by Ian Clelland - iclellandohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:32:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 77533434f64cde2813381a26cce2247a62070a21

    Comments

    Clean up feature policy flags.
    
    This fixes the default feature list, ensuring that features only appear
    in it if they are actually enabled with the correct runtime feature
    flags. Even if they are shipped as 'stable', they can still be disabled,
    and should not be parsed in that case, or appear in the output of
    document.policy.allowedFeatures().
    
    Bug: 862601
    Change-Id: I207a17818ed6696e9d029b86adcf42e4b58b6516
    Reviewed-on: https://chromium-review.googlesource.com/1133307
    Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    Commit-Queue: Ian Clelland <iclelland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574677}

    Changed files

    • third_party/blink/renderer/platform/feature_policy/feature_policy.cc
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  4. Reland: [af] Adjust dropdown so it doesn't look so close to the input element

    Changed by Fabio Tirelo - ftireloohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:22:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 03daf4e42f99ef9329ec05fc186c1936ffa718a9

    Comments

    Reland: [af] Adjust dropdown so it doesn't look so close to the input element
    
    This relands commit f1c12e6, which was reverted by commit c71c2c1.
    
    The reason for the revert was a crash introduced by c53515c, and
    reverting that commit was very hard due to merge conflicts.
    
    Bug: 847980
    Change-Id: Ib1b6931d3ac697e78c27a6cbcc7e082f0da4b6ef
    Reviewed-on: https://chromium-review.googlesource.com/1135446
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574676}

    Changed files

    • chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
  5. Complete upgrade of Retina Macs to 10.13.5.

    Changed by Kenneth Russell - kbrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:21:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 43d34bd136540d0ff14ed70bfc2a69019338595d

    Comments

    Complete upgrade of Retina Macs to 10.13.5.
    
    Turn off the multi-dimension trigger script.
    
    Fix the configuration of "Optional Mac Retina Release (AMD)"; a
    mistake was made in the earlier CL beginning the upgrade, and the jobs
    didn't auto-migrate from 10.12.6 to 10.13.5.
    
    Bug: 856799
    Tbr: ynovikov@chromium.org
    Change-Id: Ifcceed16154c47ffaa5b682149780bc53f4a101b
    Reviewed-on: https://chromium-review.googlesource.com/1135651
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574675}

    Changed files

    • testing/buildbot/chromium.gpu.fyi.json
    • testing/buildbot/chromium.gpu.json
    • testing/buildbot/waterfalls.pyl
  6. Roll src/third_party/perfetto f37ffaf9b1a1..2af75f76f0e6 (2 commits)

    Changed by perfetto-chromium-autoroll - perfetto-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:21:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7b6920828c5fa9f72dce1b84c9ae95711ae037e5

    Comments

    Roll src/third_party/perfetto f37ffaf9b1a1..2af75f76f0e6 (2 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/f37ffaf9b1a1..2af75f76f0e6
    
    
    git log f37ffaf9b1a1..2af75f76f0e6 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 michaschwab@google.com Merge "Improve Context Architecture, add "isOnCanvas" method"
    2018-07-12 michaschwab@google.com Improve Context Architecture, add "isOnCanvas" method
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@2af75f76f0e6
    
    The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I4222bc49a1619c3cc2972a496dd5e7e961d03363
    Reviewed-on: https://chromium-review.googlesource.com/1135213
    Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574674}

    Changed files

    • DEPS
  7. [SessionStorage] Always delete Session Storage database on Android

    Changed by Daniel Murphy - dmurphohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:18:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 154ac5551c1e0ff8c877b4cd0e26ad6ea30d4860

    Comments

    [SessionStorage] Always delete Session Storage database on Android
    
    Android doesn't have session restore code run, and this code is what
    cleaned up old session storage namespaces from previous browser runs.
    
    So on Android, the session storage context will delete the database
    on startup.
    
    R=mek@chromium.org
    
    Bug: 860030
    Change-Id: Ia7c349811e4970d05a071a0de9ad50117d771855
    Reviewed-on: https://chromium-review.googlesource.com/1125260
    Commit-Queue: Daniel Murphy <dmurph@chromium.org>
    Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574673}

    Changed files

    • content/browser/dom_storage/dom_storage_context_wrapper.cc
    • content/browser/dom_storage/session_storage_context_mojo.cc
    • content/browser/dom_storage/session_storage_context_mojo.h
    • content/browser/dom_storage/session_storage_context_mojo_unittest.cc
  8. Roll src/third_party/chromite 3973c26575e2..ca73efa2232f (1 commits)

    Changed by Chromite Chromium Autoroll - chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:18:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0113967ab2dcdc45364c7cfa35fd095856d7ede5

    Comments

    Roll src/third_party/chromite 3973c26575e2..ca73efa2232f (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/3973c26575e2..ca73efa2232f
    
    
    git log 3973c26575e2..ca73efa2232f --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 stevenjb@chromium.org deploy_chrome: Always prompt to remove rootfs verification
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@ca73efa2232f
    
    The AutoRoll server is located here: https://chromite-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I910679c20d35bb32e7f9e089bdde8a437a37961c
    Reviewed-on: https://chromium-review.googlesource.com/1135208
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574672}

    Changed files

    • DEPS
  9. [Unity][Android] Update string for payments sync datatype

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:17:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab5e146619a4ce43dd36939245a2b6a9a254ef90

    Comments

    [Unity][Android] Update string for payments sync datatype
    
    This CL changes the string used for payments in
    'Sync and Google services' preferences screen.
    
    Bug: 814728
    Change-Id: Ib1932ef94ad6f6b90efa5a59e0ef0500775b9496
    Reviewed-on: https://chromium-review.googlesource.com/1135321
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574671}

    Changed files

    • chrome/android/java/res/xml/sync_customization_preferences.xml
    • chrome/android/java/strings/android_chrome_strings.grd
  10. Move PDFiumEngine doc/form/loading members into PDFiumDocument.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:16:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 94754366872ddaafeb4ec141f971ee47d3350c59

    Comments

    Move PDFiumEngine doc/form/loading members into PDFiumDocument.
    
    Change-Id: I11c1ecff9305a75f66c3de5443fde4d0423163d2
    Reviewed-on: https://chromium-review.googlesource.com/1112498
    Reviewed-by: dsinclair <dsinclair@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574670}

    Changed files

    • pdf/BUILD.gn
    • pdf/pdfium/pdfium_document.cc
    • pdf/pdfium/pdfium_document.h
    • pdf/pdfium/pdfium_engine.cc
    • pdf/pdfium/pdfium_engine.h
  11. Add bad IPC message check at the browser.

    Changed by Lu Chen - cheluohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:15:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f9ecec290e797566bdbbe41459d68a4045e29b5e

    Comments

    Add bad IPC message check at the browser.
    
    Add bad IPC message check to UpdateAnchorElementMetrics. The browser
    will kill the renderer process when it receives a bad message.
    
    Bug: 850624
    Change-Id: I750b6d54e556ddc659cb693844922234b9e845ce
    Reviewed-on: https://chromium-review.googlesource.com/1128259
    Commit-Queue: Lu Chen <chelu@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574669}

    Changed files

    • chrome/browser/navigation_predictor/navigation_predictor.cc
    • chrome/browser/navigation_predictor/navigation_predictor.h
    • chrome/browser/navigation_predictor/navigation_predictor_unittest.cc
    • tools/metrics/histograms/histograms.xml
  12. Settings: fix sync-account-controls banner overflowing border-radius.

    Changed by Scott Chen - scottchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:15:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 66d0e64aa958612d6b9cf38b9b8409925487458b

    Comments

    Settings: fix sync-account-controls banner overflowing border-radius.
    
    Bug: 860265
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ie85c25b7b777463569f4d3b4f01f8a8e524c84f5
    Reviewed-on: https://chromium-review.googlesource.com/1133977
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574668}

    Changed files

    • chrome/browser/resources/settings/people_page/people_page.html
    • chrome/browser/resources/settings/people_page/sync_account_control.html
  13. Update GPU pixel wrangling graphs for macOS 10.13.5 upgrade.

    Changed by Kenneth Russell - kbrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:14:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 32b92d2bc9ae9c12e01f7879de715843ac849ae8

    Comments

    Update GPU pixel wrangling graphs for macOS 10.13.5 upgrade.
    
    Tbr: ynovikov@chromium.org
    Bug: 856799
    Change-Id: I6d7265037477715df7ca7e31290ef88f7ad4f668
    Reviewed-on: https://chromium-review.googlesource.com/1135657
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574667}

    Changed files

    • docs/gpu/pixel_wrangling.md
  14. [NTP] Add Google Photos option for custom backgrounds

    Changed by Kyle Milka - kmilkaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:13:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d87ed83235c1f5505f58b0d51923dfe11db9faae

    Comments

    [NTP] Add Google Photos option for custom backgrounds
    
    Allow users to select one of their photos from Google Photos and set it
    as the NTP background image. Currently only supports users who are
    already signed in to their Google account.
    
    Bug: 848012
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Idef07f3cd107199a8e308fc883c96b9a8da37b1e
    Reviewed-on: https://chromium-review.googlesource.com/1130100
    Commit-Queue: Kyle Milka <kmilka@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574666}

    Changed files

    • chrome/browser/resources/local_ntp/custom_backgrounds.css
    • chrome/browser/resources/local_ntp/custom_backgrounds.js
    • chrome/browser/resources/local_ntp/local_ntp.html
    • chrome/browser/search/background/ntp_background_data.cc
    • chrome/browser/search/background/ntp_background_data.h
    • chrome/browser/search/background/ntp_background_service.cc
    • chrome/browser/search/local_ntp_source.cc
    • chrome/test/data/local_ntp/local_ntp_browsertest.html
  15. Roll src/third_party/skia 56a426a516d0..5551a94b9e0f (15 commits)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:12:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 521effcf577f74a61bd5d6a35074ed2e3d20abd0

    Comments

    Roll src/third_party/skia 56a426a516d0..5551a94b9e0f (15 commits)
    
    https://skia.googlesource.com/skia.git/+log/56a426a516d0..5551a94b9e0f
    
    
    git log 56a426a516d0..5551a94b9e0f --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 mtklein@chromium.org update color management for color shaders
    2018-07-12 brianosman@google.com Update SRGBReadWritePixelsTest again, to only test opaque colors
    2018-07-12 fmalita@chromium.org PathKit/WASM tweaks
    2018-07-12 mtklein@chromium.org update mode color filter color management
    2018-07-12 mtklein@chromium.org remove unused parts of SkModeColorFilter
    2018-07-12 ziadb@google.com Java-only version of SkAR: drawing on android Canvas
    2018-07-12 brianosman@google.com Remove SK_LEGACY_GPU_PIXEL_OPS tests
    2018-07-12 egdaniel@google.com Generate GrVkInterface when we make the GrVkGpu.
    2018-07-12 reed@google.com remove unneeded scale from procs
    2018-07-12 brianosman@google.com In RGBA444TextureTest, use valid premul colors
    2018-07-12 borenet@google.com Roll Chromium manually to last successful CommandBuffer run
    2018-07-12 mtklein@chromium.org fix color management of CPU drawVertices()
    2018-07-12 caryclark@skia.org remove more references to draw filter
    2018-07-12 bsalomon@google.com remove debug gl interface, grcontextfactory context type, and config.
    2018-07-12 benjaminwagner@google.com Upgrade Skolo Mac bots to 10.13.6.
    
    
    Created with:
      gclient setdep -r src/third_party/skia@5551a94b9e0f
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: I31983fe5eb6e60f68f6b46ed52741dd82999eb78
    Reviewed-on: https://chromium-review.googlesource.com/1135209
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574665}

    Changed files

    • DEPS
  16. DevTools: clicking clear on input should focus

    Changed by Erik Luo - luoeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:11:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cdc1f3d342363df455d02fde8bc04d44f5331e5e

    Comments

    DevTools: clicking clear on input should focus
    
    The act of clicking the 'x' clear button blurs focus. This CL ensures
    the input focuses afterwards.
    
    Bug: 831059
    Change-Id: I848296c0981873cd878f5aaaead9654809811349
    Reviewed-on: https://chromium-review.googlesource.com/1134577
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Commit-Queue: Erik Luo <luoe@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574664}

    Changed files

    • third_party/blink/renderer/devtools/front_end/ui/Toolbar.js
  17. AW: trace events for WindowAndroid verification issues

    Changed by Nate Fischer - ntfschrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:10:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f50fc4d425345286e65488344fd85981bef36c94

    Comments

    AW: trace events for WindowAndroid verification issues
    
    No change to logic.
    
    This adds trace events inside AwContents to track WindowAndroid-related
    class verification errors. Specifically, this should illustrate the
    following verification errors:
    
     * WindowAndroid verification errors should cause activityFromContext to
       take longer than necessary.
     * ActivityWindowAndroid fails verification (because its superclass
       WindowAndroid fails verification), causing its constructor to take
       longer than necessary.
    
    R=torne@chromium.org
    
    Bug: 855796
    Test: tools/perf/run_benchmark system_health.webview_startup --browser android-webview-google
    Change-Id: I6633496fd672300216dfa6425910d19a7ae9e3da
    Reviewed-on: https://chromium-review.googlesource.com/1132479
    Reviewed-by: Richard Coles <torne@chromium.org>
    Commit-Queue: Nate Fischer <ntfschr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574663}

    Changed files

    • android_webview/java/src/org/chromium/android_webview/AwContents.java
  18. Fix VR watchlist

    Changed by Michael Thiessen - mthiesseohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:10:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a7bec5b1769172d3b2722182969d5c1ed618bc42

    Comments

    Fix VR watchlist
    
    Broken in https://chromium-review.googlesource.com/c/chromium/src/+/1134091/9/WATCHLISTS.
    
    Change-Id: Id84c46bb2f52d397975e1c3797a182b2becf9c07
    Reviewed-on: https://chromium-review.googlesource.com/1135115
    Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
    Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574662}

    Changed files

    • WATCHLISTS
  19. Restore some checks in FrameLoader::CommitNavigation

    Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:06:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cd7f8b8a57712e9a2b2deb2a10282dea99bdb5eb

    Comments

    Restore some checks in FrameLoader::CommitNavigation
    
    These were dropped when separating StartNavigation from
    CommitNavigation. It's reasonable that we cannot be in StopAllLoaders
    or similar unless there is a nested message loop.
    
    See test for an example how print() triggers this stack:
    ...<message loop running here, dispatched CommitNavigation>...
    IPC::SyncChannel::Send()
    content::RenderThreadImpl::Send()
    printing::PrintRenderFrameHelper::RequestPrintPreview()
    content::RenderFrameImpl::ScriptedPrint()
    blink::ChromeClientImpl::PrintDelegate()
    blink::ChromeClient::Print()
    blink::LocalDOMWindow::FinishedLoading()
    blink::FrameLoader::DidFinishNavigation()
    blink::Document::CheckCompleted()
    blink::FrameLoader::DetachProvisionalDocumentLoader()
    blink::DocumentLoader::StopLoading()
    blink::DocumentLoader::DetachFromFrame()
    blink::WebDocumentLoaderImpl::DetachFromFrame()
    blink::FrameLoader::StopAllLoaders()
    blink::LocalFrame::Detach()
    blink::HTMLPlugInElement::DisconnectContentFrame()
    blink::ChildFrameDisconnector::DisconnectCollectedFrameOwners()
    blink::ContainerNode::WillRemoveChild()
    blink::ContainerNode::RemoveChild()
    ...<JavaScript>...
    
    Bug: 860208, 853487, 862088
    Change-Id: Ieb3f0330828f0a031a97d08cdc1ba7de8a3f0edc
    Reviewed-on: https://chromium-review.googlesource.com/1130223
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574661}

    Changed files

    • third_party/WebKit/LayoutTests/fast/loader/detach-while-printing-expected.txt
    • third_party/WebKit/LayoutTests/fast/loader/detach-while-printing.html
    • third_party/blink/renderer/core/loader/frame_loader.cc
  20. Update PDFExtensionTest test expectation.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:06:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision be8ff3e12884ec3188e5fb909b31a62b9412d808

    Comments

    Update PDFExtensionTest test expectation.
    
    After https://pdfium-review.googlesource.com/35432 got rolled into
    Chromium in r570889, a previously failing test case now started passing.
    
    BUG=860757
    
    Change-Id: I998a0ea8a91770bb27d92491a12ac0816f535054
    Reviewed-on: https://chromium-review.googlesource.com/1132633
    Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574660}

    Changed files

    • chrome/browser/pdf/pdf_extension_test.cc
  21. Settings: fix cups printer search field logic.

    Changed by Scott Chen - scottchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:05:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b1fa8446eb300966ba4c7c4e6c02e9f9f86fedc

    Comments

    Settings: fix cups printer search field logic.
    
    An earlier CL (1088163) broke the logic for drop-down search fields in
    CUPS add/edit printer dialog, by setting the searchTerm_ property to the
    wrong value. This CL fixes that issue.
    
    The aforementioned CL also accidentally notifies the parent of the input
    value too often, which is also fixed in this CL.
    
    Tests are added to prevent both regressions in the future.
    
    Bug: 860475
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I3949c01edacc53b5aa0f8b6b25ef57b3acb00577
    Reviewed-on: https://chromium-review.googlesource.com/1132238
    Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574659}

    Changed files

    • chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
    • chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.js
    • chrome/test/data/webui/settings/cups_printer_page_tests.js
  22. Making a menu button component

    Changed by Pedro Amaral - amaralpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:03:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c59b348ffef08cfdca20701f4f54236f9e6e295

    Comments

    Making a menu button component
    
    Pulling the menu button out of the bottom toolbar component into its
    own class.
    
    Bug: 862863
    
    
    Change-Id: Icb2230259d7f1d3ac2f47f3b8ee33e659579ca96
    Reviewed-on: https://chromium-review.googlesource.com/1132423
    Commit-Queue: Pedro Amaral <amaralp@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Matthew Jones <mdjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574658}

    Changed files

    • chrome/android/java/res/layout/menu_button.xml
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarMediator.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarModel.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/MenuButton.java
    • chrome/android/java_sources.gni
  23. [Video Capture] Abstract out V4L2 API calls to an interface

    Changed by Christian Fremerey - chfremerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:59:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dbf002c655a394a5235cef285a40059f8d32d678

    Comments

    [Video Capture] Abstract out V4L2 API calls to an interface
    
    This CL abstracts V4L2 API calls made from Chromium's video capture
    implementation on Linux out to an interface. This is to enable testability of
    the code that makes such calls without requiring heavy-weight solutions such
    as attaching actual hardware or kernel-level emulators.
    
    This CL is a pure refactoring and has no intended function change.
    
    This CL is part of a series, see Design Doc at
    https://docs.google.com/document/d/1ihGDZloUGdDpZ5XfmiI3AcqsSxOP9kOe5GxXOTqpHW4/edit?usp=sharing
    
    Test: capture_unittests with physical camera attached
    Bug: 768887
    Change-Id: I9208f4a61731c8dc5827c1f5f5ef31d078520270
    Reviewed-on: https://chromium-review.googlesource.com/1120856
    Reviewed-by: Emircan Uysaler <emircan@chromium.org>
    Commit-Queue: Christian Fremerey <chfremer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574657}

    Changed files

    • media/capture/BUILD.gn
    • media/capture/video/linux/v4l2_capture_delegate.cc
    • media/capture/video/linux/v4l2_capture_delegate.h
    • media/capture/video/linux/v4l2_capture_delegate_unittest.cc
    • media/capture/video/linux/v4l2_capture_device.h
    • media/capture/video/linux/v4l2_capture_device_impl.cc
    • media/capture/video/linux/v4l2_capture_device_impl.h
    • media/capture/video/linux/video_capture_device_chromeos.cc
    • media/capture/video/linux/video_capture_device_chromeos.h
    • media/capture/video/linux/video_capture_device_factory_linux.cc
    • media/capture/video/linux/video_capture_device_factory_linux.h
    • media/capture/video/linux/video_capture_device_linux.cc
    • media/capture/video/linux/video_capture_device_linux.h
  24. Change DECHECKs to CHECKs in `base::RingBuffer`.

    Changed by Chris Palmer - palmerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:58:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 940e9a3140b1e0b636f185ff65f20226e997d897

    Comments

    Change DECHECKs to CHECKs in `base::RingBuffer`.
    
    Better safe than sorry!
    
    In the process, do some micro-optimization to make the CHECKs as cheap as
    possible.
    
    Bug: 817982
    Change-Id: I2c45d7e773199a12ce4ae34b4a750ac2b66cb7c2
    Reviewed-on: https://chromium-review.googlesource.com/1134486
    Reviewed-by: danakj <danakj@chromium.org>
    Commit-Queue: Chris Palmer <palmer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574656}

    Changed files

    • base/containers/ring_buffer.h
  25. Groups small symbols at the file level

    Changed by Tiger Oakes - tigeroohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 18:57:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5b84bff2c5ba0511930b78e6d864bfb8ef0bb03

    Comments

    Groups small symbols at the file level
    
    Previously, symbols below min_symbol_size were all placed in an
    "(Other)" file entry at the root of the tree. Now, they are placed
    inside their original file entry but grouped together based on type.
    This ensures byte counts are always accurate, even past the root node.
    This is also the only blocker before we can remove the old UI.
    
    Additionally made some changes to improve first-load performance by
    starting tree building as soon as possible.
    
    Bug: 860303
    Change-Id: I02daee8994d9b7b236837b78585ac8a9c3297125
    Reviewed-on: https://chromium-review.googlesource.com/1135193
    Commit-Queue: Tiger Oakes <tigero@google.com>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Reviewed-by: Peter Wen <wnwen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574655}

    Changed files

    • tools/binary_size/libsupersize/html_report.py
    • tools/binary_size/libsupersize/template_tree_view/index.html
    • tools/binary_size/libsupersize/template_tree_view/start-worker.js
    • tools/binary_size/libsupersize/template_tree_view/state.js
    • tools/binary_size/libsupersize/template_tree_view/tree-ui.js
    • tools/binary_size/libsupersize/template_tree_view/tree-worker.js
  26. Convert two crash layout tests to use testharness

    Changed by Xiaocheng Hu - xiaochenghohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:57:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0279bf752fc5d6e5f0df324190ab72d7bc831010

    Comments

    Convert two crash layout tests to use testharness
    
    The following two layout tests are crash tests and don't need text dump:
    - fast/text/editing-text-crash.html
    - fast/text/text-iterator-crash.html
    
    This patch converts them with testharness for better code health.
    
    Change-Id: I528a681bb6a17e2fb9f6122d6ec42f9722a575df
    Reviewed-on: https://chromium-review.googlesource.com/1134594
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Reviewed-by: Yoichi Osato <yoichio@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574654}

    Changed files

    • third_party/WebKit/LayoutTests/fast/text/editing-text-crash-expected.txt
    • third_party/WebKit/LayoutTests/fast/text/editing-text-crash.html
    • third_party/WebKit/LayoutTests/fast/text/text-iterator-crash-expected.txt
    • third_party/WebKit/LayoutTests/fast/text/text-iterator-crash.html
  27. Introduce GetAppShortcutGlobalQueryItems mojo method

    Changed by Weidong Guo - weidonggohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:56:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f70dc791c0f421c6ac340019a9721df97af0da8d

    Comments

    Introduce GetAppShortcutGlobalQueryItems mojo method
    
    The original solution passing all available app shortcuts metadata to
    Chrome has large latency because getting icons is expensive. This CL
    proposes a new API that passes query and maxResults to Android, and
    searching & results num throttling is done in Android as well.
    Android side change is in ag/4432308.
    
    Bug: 842947
    Test: manual test, latency is controlled in tens milliseconds
    
    Change-Id: I48c168ffd56826c10a4b6d5befb995a087f4a0b2
    Reviewed-on: https://chromium-review.googlesource.com/1117893
    Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Yury Khmel <khmel@chromium.org>
    Reviewed-by: Qiang Xu <warx@google.com>
    Commit-Queue: Weidong Guo <weidongg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574653}

    Changed files

    • chrome/browser/ui/app_list/search/arc/arc_app_shortcuts_search_provider.cc
    • chrome/browser/ui/app_list/search/arc/arc_app_shortcuts_search_provider.h
    • chrome/browser/ui/app_list/search/arc/arc_app_shortcuts_search_provider_unittest.cc
    • chrome/browser/ui/app_list/search/search_controller_factory.cc
    • components/arc/common/app.mojom
    • components/arc/test/fake_app_instance.cc
    • components/arc/test/fake_app_instance.h
  28. Always prompt user if opening a download thru extensions with debugger permission

    Changed by Min Qin - qinminohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:55:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a4a89a53791a508896b388b0d818644834c0d6d

    Comments

    Always prompt user if opening a download thru extensions with debugger permission
    
    The user gesture can be faked, so we shouldn't trust it
    
    BUG=854455
    
    Change-Id: Ib42911a77d3f519554a5b9a4c1464ec50e79f268
    Reviewed-on: https://chromium-review.googlesource.com/1135525
    Reviewed-by: Xing Liu <xingliu@chromium.org>
    Commit-Queue: Min Qin <qinmin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574652}

    Changed files

    • chrome/browser/extensions/api/downloads/downloads_api.cc