Home | Search | chromium - Builders
Login

Builder Linux ASan Tests (sandboxed) Build 48827 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision197e9188dc5be69cb34e1ebd67f86a1146439367
Got Revision197e9188dc5be69cb34e1ebd67f86a1146439367

Execution:

Steps and Logfiles:

Show:
  1. ( 471 ms ) setup_build
    running recipe: "chromium"
  2. ( 442 ms ) remove .cipd
  3. ( 1 mins ) bot_update
    [95GB/295GB used (32%)]
  4. ( 0 ) ensure_goma
  5. ( 570 ms ) swarming.py --version
    0.13
  6. ( 34 secs ) gclient runhooks
  7. ( 692 ms ) read test spec (chromium.memory.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.memory.json
  8. ( 3 secs ) build directory
  9. ( 17 mins 24 secs ) extract build
  10. ( 1 secs ) find isolated tests
  11. ( 0 ) test_pre_run
  12. ( 7 secs ) test_pre_run.[trigger] browser_tests
    Run on OS: 'Ubuntu-14.04'
  13. ( 1 secs ) test_pre_run.[trigger] components_browsertests
    Run on OS: 'Ubuntu-14.04'
  14. ( 960 ms ) test_pre_run.[trigger] content_browsertests
    Run on OS: 'Ubuntu-14.04'
  15. ( 2 secs ) test_pre_run.[trigger] interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
  16. ( 24 mins 49 secs ) browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:24:25.303320 (shard #6)
    Min shard duration: 0:16:52.263880 (shard #8)
  17. ( 1 secs ) components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:07.458260
  18. ( 4 mins 40 secs ) content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:30:07.807430
  19. ( 2 secs ) interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:11:53.937220 (shard #2)
    Min shard duration: 0:08:28.879120 (shard #1)
  20. ( 975 ms ) Tests statistics
     
    Stats
    Total shards: 15
    Total runtime: 4:15:10.791694
     

Build Properties:

NameValueSource
$build/goma {"jobs": 500} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm625-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531397240115840, "id": "8941207323507271392", "project": "chromium", "tags": ["builder:Linux ASan Tests (sandboxed)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/197e9188dc5be69cb34e1ebd67f86a1146439367", "gitiles_ref:refs/heads/master", "parent_buildername:Linux ASan LSan Builder", "parent_buildnumber:56148", "scheduler_invocation_id:9106637385870212016", "scheduler_job_id:chromium/Linux ASan Tests (sandboxed)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Linux ASan Tests (sandboxed)" setup_build
buildnumber 48827 setup_build
mastername "chromium.memory" setup_build
parent_buildername "Linux ASan LSan Builder" setup_build
parent_got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" setup_build
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" setup_build
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" setup_build
parent_got_revision "197e9188dc5be69cb34e1ebd67f86a1146439367" setup_build
parent_got_revision_cp "refs/heads/master@{#574523}" setup_build
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" setup_build
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" setup_build
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" setup_build
parent_got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23944}" setup_build
parent_mastername "chromium.memory" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "197e9188dc5be69cb34e1ebd67f86a1146439367" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "197e9188dc5be69cb34e1ebd67f86a1146439367" bot_update
got_revision_cp "refs/heads/master@{#574523}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23944}" bot_update
swarm_hashes {"accessibility_unittests": "745e86e718ced8c028d67b9659c7d13ad932365a", "angle_unittests": "65d43a58a99ffde83822dbf113edca348dfe4058", "app_shell_unittests": "9d7a96278dec58500d7adfefa7857e60324b6e8b", "aura_unittests": "c1ed7b2d40fa3f29321a2bac2beba5c9e196e699", "base_unittests": "6c74ce44cf81713dc087bdcec2a20e983b0e8c2a", "battor_agent_unittests": "422e4333f9abaf95984ce04c490d5b8f6cfc5b19", "blink_common_unittests": "c0fdff8b43bbb3e784cfaf18f03c30110f8ce33a", "blink_fuzzer_unittests": "897bdda18e9b98830a642689feed4684e463f897", "blink_heap_unittests": "6e61debd575e058b071018e5e642fee450998a02", "blink_platform_unittests": "d127971453785373fc6478f213ba971a558147d3", "boringssl_crypto_tests": "f22f35308ba13d4c3c6c0a74f5c4364eda22405c", "boringssl_ssl_tests": "2f527055e303b2d7c453f25d9bda2ae36697d295", "browser_tests": "54efd42da71393b1e7a9d5a489db21247a89d649", "cacheinvalidation_unittests": "60323b6b4fa82795a771834193660f4c54b343d2", "capture_unittests": "896cc997ef8a252901f1f37921f5879724af2685", "cast_unittests": "df9cee5147e93e5c8ff65b3d8c0943b996d9e84f", "cc_unittests": "b625ed2c3bbd5021f08b86556938d86feff6c7b5", "chrome_app_unittests": "9c3122dcb4ee79e7ead01d0cf6b23ea5060d9d84", "chromedriver_unittests": "7e34553d94c16c1d0e0123346fe01b8eb87ff6a7", "components_browsertests": "e2411cfffadc6ee188fcb6cc2c6442085f41552d", "components_unittests": "e681f170f5cbc9bd89d553c2442040ab3bd79251", "compositor_unittests": "df6f3f1cadc78a5fd3aed734bfeaaf5366d082df", "content_browsertests": "281d7969a91ac77708a33ce86367ea987d5bf75b", "content_unittests": "d22683c7beb9238e45f7646b2250a6cc65567bb2", "cronet_tests": "a1f070765e5b118db6df55c10ed722a1f8732b87", "cronet_unittests": "d9717ba2147f68bb9e672ce08215b039d001c203", "crypto_unittests": "27c9537a4de1c4b9ccd170d4a980250235d17c17", "dbus_unittests": "3499fcf4d9a1221f715ccd0f553d77d4ea62348b", "device_unittests": "075e908c1e007616b8c645f19304ad97cc9c023d", "display_unittests": "20672c43b84afc2e782ce73a6b35178d8ef07e29", "events_unittests": "7bf2047329431febae54ad2794bf2d322ca19ba1", "extensions_browsertests": "466df59506b363ee2d1eb6339fe6c3302963d25b", "extensions_unittests": "f9845bd2343080107cbe92c655cd6bf55653c9df", "filesystem_service_unittests": "d5c609b06267f364de16b6f22cbaa3fa3176fb8b", "gcm_unit_tests": "bfc75bddaa96a3c4c3823a7f87de15c3b5734f13", "gfx_unittests": "cb3e45e8a9e92788215528abb0cfb1d20da6054b", "gl_tests": "9c0988c8393f680a895f23e0979847dd36b6c104", "gl_unittests": "563eea1a115b3b4c624e9705c7158772e34018ed", "google_apis_unittests": "585923ae7169fed85d84e72daadb1f1113153992", "gpu_unittests": "884ddd941a1d5b979975f0c3b553d2bba11c9f20", "interactive_ui_tests": "ad1b8596ee43197314610b17c1e5f63922f036b0", "ipc_tests": "d0543dfb3b321fd55ce04b7c49b31ad27acfab45", "jingle_unittests": "c0e688714c54cbe09acc5f9c72691353c1fa2062", "latency_unittests": "ad78fd1c1a94ce6a15888e5ff3bfb1ec3278a780", "leveldb_service_unittests": "7497405e4a550813171c4914e25e786d16c8f0c5", "libjingle_xmpp_unittests": "af4c990ac805defa01824475bf3481370a3ae297", "media_blink_unittests": "e875ca4d63c51ec09e6e3a9b4022a8bc453b803f", "media_service_unittests": "e94356687c37daf577daac3c0f342a6d4c174e49", "media_unittests": "c490e024bf1daa85e8a2ebc0ac4f870245f572c0", "message_center_unittests": "67bc9b963a0c78fedb0135090b9ec619d9705d0c", "midi_unittests": "d620877266e7c703997843ff95fe0bc8d1d033cd", "mojo_core_unittests": "c3d5b7837e0fd12889448a0be05a0642d25fd4f4", "mojo_unittests": "c54ce46cc127318e78f8acb1a45bbfa257be2964", "nacl_helper_nonsfi_unittests": "67cd2e0a819b2c513af18a24c301dc258b773e29", "nacl_loader_unittests": "3167f315e928d7e539155cee73c84daf66f252a3", "native_theme_unittests": "59c15a9d3d0d0044a598df757c7f7fefa29bb4f3", "net_unittests": "d94a11d4994924a098fd2799c5f08c52e1c3b49f", "pdf_unittests": "c68ae9cd2153dba47addc1f6305ee067b919150b", "ppapi_unittests": "5ba8faa320caa7269668587a664064668061c68c", "printing_unittests": "e59cb926211bf79ea5b2452df3f98ee3fa0ca115", "remoting_unittests": "f23dc3dd96ec9fa61a47172b3e575b5dbed14209", "sandbox_linux_unittests": "b48ffac4c8fb8708d2e44b5c59e0a8044c2ba381", "service_manager_unittests": "d6a6cb72e745bb50d926ed93d05fc1ebbc1e6049", "services_unittests": "ba0724c50736a3155d37a8edd37a50c0819d0f7e", "shell_dialogs_unittests": "eb51c9e66743f2a06046426403f390bf763c1522", "skia_unittests": "b927fe24abec27297cf8ff6ac0996a4736a2679c", "snapshot_unittests": "3b9d2082c5fc937605474f1649e8b78516487c3d", "sql_unittests": "72e0983e0a7b865fae46d38cffb9924f866667ef", "storage_unittests": "71b497934f141758695ab8825a3f128968b70c8e", "sync_integration_tests": "600a34fddd088d2b21597217c8489259b86b197e", "traffic_annotation_auditor_unittests": "a91502b8e6a58727dda72635f2820b6b80ad2a46", "ui_base_unittests": "dd88a3afb29f1af3259879556cb2963b0521821c", "ui_touch_selection_unittests": "73b1d6a56292690a980eddc35de5b58589b0f580", "unit_tests": "bc964692165dda0ef9a04ab2a08714091f15bcf4", "url_unittests": "f9a7e45cca1731fd001e2da7d1700c9d330818cb", "views_unittests": "32b66088664cfd19a6eae8e324ed2f112502a9c9", "viz_unittests": "d39f5c2bb73250a696623115d72f032cae72c0c9", "vr_common_unittests": "a9900c226a2184a2a729122ed3acaf5c37a85d5d", "vr_pixeltests": "65e6823030e366d89c35cdef6a64d9407d532d41", "webkit_unit_tests": "19a520b5394aafa7c87ffabc583ebe014e6e5e69", "wm_unittests": "07361fe0203ea87db9a9ed6c431aa5d09ba5fa0d", "wtf_unittests": "76d79144c37cd893790bdcfb03c429c612b472b9"} find isolated tests

Blamelist:

  1. Mike West (mkwstohnoyoudont@chromium.org)
  2. afdo-chromium-autoroll (afdo-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  3. Tatsuhisa Yamaguchi (yamaguchiohnoyoudont@chromium.org)
  4. Rohit Rao (rohitraoohnoyoudont@chromium.org)
  5. Mark Cogan (marqohnoyoudont@google.com)

Timing:

Create Thursday, 12-Jul-18 12:07:20 UTC
Start Thursday, 12-Jul-18 12:07:24 UTC
End Thursday, 12-Jul-18 12:57:37 UTC
Pending 4 secs
Execution 50 mins 13 secs

All Changes:

  1. Revert "Make NetworkConnectionTracker survive network service crashes and restarts"

    Changed by Mike West - mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:11:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 197e9188dc5be69cb34e1ebd67f86a1146439367

    Comments

    Revert "Make NetworkConnectionTracker survive network service crashes and restarts"
    
    This reverts commit cec0800c372ef670f59999fb3f028013d36b866c.
    
    Reason for revert:
    
    Findit (https://goo.gl/kROfz5) identified this CL at revision 574314 as the culprit
    for introducing flakiness in the tests as shown on:
    https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vY2VjMDgwMGMzNzJlZjY3MGY1OTk5OWZiM2YwMjgwMTNkMzZiODY2Yww
    
    TBR=xunjieli@chromium.org
    
    Bug: 862883
    
    Original change's description:
    > Make NetworkConnectionTracker survive network service crashes and restarts
    > 
    > This CL is to mirror tbansal@'s CL
    > (https://chromium-review.googlesource.com/1058528) to make
    > NetworkConnectionTracker survice network service's crashes and restarts.
    > 
    > Bug: 821009
    > Change-Id: Iec33797c0fd0ce12a8e5fdab9fda0a710eb9a528
    > Reviewed-on: https://chromium-review.googlesource.com/1120738
    > Commit-Queue: Helen Li <xunjieli@chromium.org>
    > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    > Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574314}
    
    TBR=jam@chromium.org,xunjieli@chromium.org,tbansal@chromium.org
    
    Change-Id: I2524f0e04441097e06585f4f2e4cdb948a419641
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 821009
    Reviewed-on: https://chromium-review.googlesource.com/1135006
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574523}

    Changed files

    • chrome/browser/browser_process_impl.cc
    • chrome/browser/net/network_connection_tracker_browsertest.cc
    • chrome/browser/net/network_quality_tracker_browsertest.cc
    • content/public/browser/network_connection_tracker.cc
    • content/public/browser/network_connection_tracker.h
    • content/public/browser/network_connection_tracker_unittest.cc
  2. Roll AFDO from 69.0.3488.0_rc-r1 to 69.0.3489.0_rc-r1

    Changed by afdo-chromium-autoroll - afdo-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 11:04:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a837f9d78ab2670ad242acd3651e0bf1f29a2a39

    Comments

    Roll AFDO from 69.0.3488.0_rc-r1 to 69.0.3489.0_rc-r1
    
    This CL may cause a small binary size increase, roughly proportional
    to how long it's been since our last AFDO profile roll. For larger
    increases (around or exceeding 100KB), please file a bug against
    gbiv@chromium.org. Additional context: https://crbug.com/805539
    
    The AutoRoll server is located here: https://afdo-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=gbiv@chromium.org
    
    Change-Id: I0095acd5d9522beaf64a43baf3bb71106038fe7c
    Reviewed-on: https://chromium-review.googlesource.com/1134870
    Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574522}

    Changed files

    • chrome/android/profiles/newest.txt
  3. Always align slider bubbles to the bottom of the desktop.

    Changed by Tatsuhisa Yamaguchi - yamaguchiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 10:06:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7a0ab14f53bb9b6346969ec10d376d51aff8eceb

    Comments

    Always align slider bubbles to the bottom of the desktop.
    
    The slider was aligned towards the system tray icon view in the shelf
    by the bubble's bottom edge. It meant that the slider bubble was shown
    apart from the bottom of the desktop when the shelf layout is either
    right or left. It was not consistent with popup notification, causing
    view overlap between notifications and a slider bubble.
    
    Bug: 862496
    Change-Id: Ie6db618f8b744ecc4de52ee7a4866ca9e9ecd26c
    Reviewed-on: https://chromium-review.googlesource.com/1134643
    Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
    Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
    Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574521}

    Changed files

    • ash/system/unified/unified_slider_bubble_controller.cc
  4. [ios] Adds icons and hides headers on the main Settings page.

    Changed by Rohit Rao - rohitraoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 10:00:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5f5527a3ed5e88090ce316b8afac85c39cbb0ba8

    Comments

    [ios] Adds icons and hides headers on the main Settings page.
    
    Screenshot: https://drive.google.com/file/d/16aS0MP0LwdGOq8-IJgtIbq4ozXy44meT/view?usp=sharing
    
    BUG=805213,805214
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Iccdd87d8f95fd80b51fcdcfa2caa691c7fcd78b4
    Reviewed-on: https://chromium-review.googlesource.com/1133323
    Reviewed-by: edchin <edchin@chromium.org>
    Commit-Queue: Rohit Rao <rohitrao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574520}

    Changed files

    • ios/chrome/browser/ui/settings/BUILD.gn
    • ios/chrome/browser/ui/settings/cells/settings_switch_item.mm
    • ios/chrome/browser/ui/settings/resources/BUILD.gn
    • ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome.png
    • ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions.png
    • ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms.png
    • ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth.png
    • ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings.png
    • ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_debug.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug.png
    • ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords.png
    • ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy.png
    • ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine.png
    • ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search.png
    • ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search@3x.png
    • ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
  5. [iOS] Tweak tab grid transition animations.

    Changed by Mark Cogan - marqohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 09:57:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e96b9e2a058ddc4573deba9c0159077c8a89b45d

    Comments

    [iOS] Tweak tab grid transition animations.
    
    This CL adjusts the tab grid transition animations.
    
    (A) The timing (curve, delay, and duration) of some of the sub-animations is tweaked.
    
    (B) Because -viewWillAppear: is called inside the animation, some of the
        setup for the animations needs to be done before that method is called;
        the cleanest mechanism seemed to be to make these changes when the view
        disappeared. This is mostly setting the toolbar alpha to zero so it can be
        faded in during the animation.
    
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I8c84f5726a0ce49e13c5fd32ab91295ffbb00e57
    Reviewed-on: https://chromium-review.googlesource.com/1127994
    Commit-Queue: Mark Cogan <marq@chromium.org>
    Reviewed-by: edchin <edchin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574519}

    Changed files

    • ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
    • ios/chrome/browser/ui/tab_grid/transitions/grid_transition_animation.mm