Home | Search | chromium - Builders
Login

Builder KitKat Tablet Tester Build 970 Canonical Ubuntu

Results:

Failure content_shell_test_apk on Android device Nexus 7 [2013] Failure content_browsertests on Android device Nexus 7 [2013] Failure surface_sync_content_browsertests on Android device Nexus 7 [2013] Failure viz_content_browsertests on Android device Nexus 7 [2013] Failure unit_tests on Android device Nexus 7 [2013] Failure chrome_public_test_apk on Android device Nexus 7 [2013]

Trigger Info:

Projectchromium
Revisionc0a0f0be53c7c705076cac5dfc933dc85650e435
Got Revisionc0a0f0be53c7c705076cac5dfc933dc85650e435

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Peter Kasting (pkastingohnoyoudont@chromium.org)
  2. Ned Nguyen (nednguyenohnoyoudont@google.com)
  3. Wez (wezohnoyoudont@chromium.org)
  4. Stephen Martinis (martinissohnoyoudont@chromium.org)
  5. Peter Kasting (pkastingohnoyoudont@chromium.org)
  6. Yafei Duan (romaxohnoyoudont@chromium.org)
  7. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  8. Joe Mason (joenotcharlesohnoyoudont@chromium.org)
  9. Chris Palmer (palmerohnoyoudont@chromium.org)
  10. Kai Ninomiya (kaininoohnoyoudont@chromium.org)
  11. siyua (siyuaohnoyoudont@chromium.org)
  12. Antoine Labour (pimanohnoyoudont@chromium.org)
  13. Scott Violet (skyohnoyoudont@chromium.org)
  14. Jun Mukai (mukaiohnoyoudont@chromium.org)
  15. Matthew Cary (mattcaryohnoyoudont@chromium.org)
  16. depot-tools-chromium-autoroll (depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  17. Wenzhao Zang (wzangohnoyoudont@chromium.org)
  18. Stephen Martinis (martinissohnoyoudont@chromium.org)
  19. Lei Zhang (thestigohnoyoudont@chromium.org)
  20. John Chen (johnchenohnoyoudont@chromium.org)
  21. Adolfo Victoria (adokarohnoyoudont@google.com)
  22. angle-chromium-autoroll (angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  23. Emil A Eklund (eaeohnoyoudont@chromium.org)
  24. Tatiana Buldina (buldinaohnoyoudont@chromium.org)
  25. catapult-chromium-autoroll (catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  26. Dale Curtis (dalecurtisohnoyoudont@chromium.org)
  27. Zhenyao Mo (zmoohnoyoudont@chromium.org)
  28. Cathy Li (chiliohnoyoudont@chromium.org)
  29. Krishna Govind (govindohnoyoudont@chromium.org)
  30. Sebastien Marchand (sebmarchandohnoyoudont@chromium.org)
  31. Manu Cornet (manucornetohnoyoudont@chromium.org)
  32. Kenneth Russell (kbrohnoyoudont@chromium.org)
  33. Matthew Jones (mdjonesohnoyoudont@chromium.org)
  34. Stephen Martinis (martinissohnoyoudont@chromium.org)
  35. Pete Williamson (petewilohnoyoudont@chromium.org)
  36. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  37. Lei Zhang (thestigohnoyoudont@chromium.org)
  38. kristipark (kristiparkohnoyoudont@chromium.org)
  39. Justin DeWitt (dewittjohnoyoudont@chromium.org)
  40. Wei-Yin Chen (陳威尹) (wychenohnoyoudont@chromium.org)
  41. Chris Lu (thegreenfrogohnoyoudont@chromium.org)
  42. pdfium-chromium-autoroll (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  43. Takuto Ikuta (tikutaohnoyoudont@chromium.org)
  44. Mason Freed (masonfreedohnoyoudont@google.com)
  45. Xi Cheng (chengxohnoyoudont@chromium.org)
  46. Christopher Cameron (ccameronohnoyoudont@chromium.org)
  47. Donn Denman (donndohnoyoudont@chromium.org)
  48. Eric Roman (eromanohnoyoudont@chromium.org)
  49. Erik Chen (erikchenohnoyoudont@chromium.org)
  50. Sarah Hu (xiaoyinhohnoyoudont@chromium.org)
  51. Gabriel Charette (gabohnoyoudont@chromium.org)
  52. Travis Skare (skareohnoyoudont@chromium.org)
  53. Derek Cheng (imchengohnoyoudont@chromium.org)
  54. Scott Violet (skyohnoyoudont@chromium.org)
  55. Martin Kreichgauer (martinkrohnoyoudont@google.com)
  56. Peter Wen (wnwenohnoyoudont@chromium.org)
  57. Adrienne Walker (enneohnoyoudont@chromium.org)
  58. Peter Kasting (pkastingohnoyoudont@chromium.org)
  59. Yuwei Huang (yuweihohnoyoudont@chromium.org)
  60. Peter Kasting (pkastingohnoyoudont@chromium.org)
  61. Avi Drissman (aviohnoyoudont@chromium.org)
  62. Weidong Guo (weidonggohnoyoudont@chromium.org)
  63. Raphael Kubo da Costa (raphael.kubo.da.costaohnoyoudont@intel.com)
  64. Yiming Zhou (uwyimingohnoyoudont@google.com)
  65. Henrique Grandinetti (hgrandinettiohnoyoudont@chromium.org)
  66. Sam Maier (smaierohnoyoudont@chromium.org)
  67. John Chen (johnchenohnoyoudont@chromium.org)
  68. Joshua Bell (jsbellohnoyoudont@chromium.org)
  69. Peter Kasting (pkastingohnoyoudont@chromium.org)
  70. Navid Zolghadr (nzolghadrohnoyoudont@chromium.org)
  71. Adrienne Walker (enneohnoyoudont@chromium.org)
  72. Sam Maier (smaierohnoyoudont@chromium.org)
  73. Max Moroz (mmorozohnoyoudont@chromium.org)
  74. Evan Stade (estadeohnoyoudont@chromium.org)
  75. Matt Menke (mmenkeohnoyoudont@chromium.org)
  76. Luke Sorenson (lasorenohnoyoudont@chromium.org)
  77. shyam (shyamsundarpohnoyoudont@chromium.org)
  78. CJ DiMeglio (lethalantidoteohnoyoudont@chromium.org)
  79. Ehsan Karamad (ekaramadohnoyoudont@chromium.org)
  80. Wez (wezohnoyoudont@chromium.org)
  81. Joe Mason (joenotcharlesohnoyoudont@chromium.org)
  82. Peter K. Lee (pklohnoyoudont@chromium.org)
  83. Ehsan Karamad (ekaramadohnoyoudont@chromium.org)
  84. Joanmarie Diggs (jdiggsohnoyoudont@igalia.com)
  85. Christian Biesinger (cbiesingerohnoyoudont@chromium.org)
  86. Stephen Martinis (martinissohnoyoudont@chromium.org)
  87. Chris Harrelson (chrishtrohnoyoudont@chromium.org)
  88. James Cook (jamescookohnoyoudont@chromium.org)
  89. Yue Li (updowndotaohnoyoudont@chromium.org)
  90. Daniel Murphy (dmurphohnoyoudont@chromium.org)
  91. Evan Stade (estadeohnoyoudont@chromium.org)
  92. Jason Chase (chasejohnoyoudont@chromium.org)
  93. Jon Mann (jonmannohnoyoudont@chromium.org)
  94. Ryan Sleevi (rsleeviohnoyoudont@chromium.org)
  95. Mark Pearson (mpearsonohnoyoudont@chromium.org)
  96. John Abd-El-Malek (jamohnoyoudont@chromium.org)
  97. Manas Verma (manasvermaohnoyoudont@google.com)
  98. Kai Ninomiya (kaininoohnoyoudont@chromium.org)
  99. yoshiki iguchi (yoshikiohnoyoudont@chromium.org)
  100. Erik Chen (erikchenohnoyoudont@chromium.org)
  101. <blame list capped at 100 commits> ()

Timing:

Create Saturday, 11-Aug-18 03:34:27 UTC
Start Saturday, 11-Aug-18 03:35:03 UTC
End Saturday, 11-Aug-18 06:56:58 UTC
Pending 35 secs
Execution 3 hrs 21 mins

All Changes:

  1. Revert "[Mac] Add Offset to TextSuggestionsTouchBarController Text Selection"

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 02:05:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c0a0f0be53c7c705076cac5dfc933dc85650e435

    Comments

    Revert "[Mac] Add Offset to TextSuggestionsTouchBarController Text Selection"
    
    This reverts commit 1e3c17435eea13b5ba5d2794985655aa221091d1.
    
    Reason for revert: Breaks Mac tests, see e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8938549477492727648/+/steps/browser_tests_on__none__GPU_on_Mac_on_Mac-10.11/0/logs/TextSuggestionsTouchBarControllerTest.Offset/0
    
    Original change's description:
    > [Mac] Add Offset to TextSuggestionsTouchBarController Text Selection
    > 
    > When the text surrounding the current selection gets too long, only
    > part of it is received by TextSuggestionsTouchBarController. The
    > location of the received text within the total block of text is
    > denoted by an offset. Previously, TextSuggestionsTouchBarController
    > did not take this offset into account, causing crashes when the
    > selection range was past the end of the received text.
    > 
    > The offset is passed along with the text and selection range. The
    > selection range within the received text is calculated using the
    > offset and received selection range. The editing word range is stored
    > both as the range within the received text and the range within the
    > total text for checking when to ignore text selection updates.
    > 
    > RenderWidgetHostView::GetOffsetForSurroundingText() was added to
    > retrieve the offset on WebContents update.
    > 
    > Browser tests were modified to account for the new offset parameter. A
    > new browser test, TextSuggestionsTouchBarController.Offset, was added
    > to test that the controller properly handles offsets.
    > 
    > Bug: 717553
    > Change-Id: I6dce1405fd5c115ca6ddfdbe4157faf75ccc3a6c
    > Reviewed-on: https://chromium-review.googlesource.com/1169597
    > Commit-Queue: Tessa Nijssen <tnijssen@google.com>
    > Reviewed-by: Avi Drissman <avi@chromium.org>
    > Reviewed-by: Sarah Chan <spqchan@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#582205}
    
    TBR=avi@chromium.org,spqchan@chromium.org,tnijssen@google.com
    
    Change-Id: If0acdd0494b5270c4b4e221e16b8e901ce2cacc3
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 717553
    Reviewed-on: https://chromium-review.googlesource.com/1171704
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582423}

    Changed files

    • chrome/browser/ui/cocoa/touchbar/text_suggestions_touch_bar_controller.h
    • chrome/browser/ui/cocoa/touchbar/text_suggestions_touch_bar_controller.mm
    • chrome/browser/ui/cocoa/touchbar/text_suggestions_touch_bar_controller_browsertest.mm
    • content/browser/frame_host/render_widget_host_view_guest.cc
    • content/browser/frame_host/render_widget_host_view_guest.h
    • content/browser/renderer_host/render_widget_host_delegate.h
    • content/browser/renderer_host/render_widget_host_view_base.cc
    • content/browser/renderer_host/render_widget_host_view_base.h
    • content/browser/renderer_host/render_widget_host_view_mac.mm
    • content/browser/web_contents/web_contents_impl.cc
    • content/browser/web_contents/web_contents_impl.h
    • content/public/browser/render_widget_host_view.h
    • content/public/browser/web_contents_observer.h
  2. Always put Telemetry tests at the end to avoid starving fast tests

    Changed by Ned Nguyen - nednguyenohnoyoudont@google.com
    Changed at Saturday, 11-Aug-18 02:02:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c2eb4f79024d096aa0363c946b1eb9a733283ed

    Comments

    Always put Telemetry tests at the end to avoid starving fast tests
    
    This also add this check to PRESUBMIT perf_json_config_validator script
    
    Bug: 873389
    Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
    Change-Id: I16fd762e567d5a41d75a221456e12e14a03f0b85
    Reviewed-on: https://chromium-review.googlesource.com/1171578
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    Commit-Queue: Ned Nguyen <nednguyen@google.com>
    Cr-Commit-Position: refs/heads/master@{#582422}

    Changed files

    • testing/buildbot/chromium.perf.fyi.json
    • testing/buildbot/chromium.perf.json
    • tools/perf/core/perf_data_generator.py
    • tools/perf/core/perf_json_config_validator.py
  3. Clean up some Ozone build files not to assume use of evdev.

    Changed by Wez - wezohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:51:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6d6032964619538763f8ce4a782093f74b86ed49

    Comments

    Clean up some Ozone build files not to assume use of evdev.
    
    Bug: 808287
    Change-Id: Ic699462759818049666babb0587939e4ca687643
    Reviewed-on: https://chromium-review.googlesource.com/1167555
    Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
    Reviewed-by: Michael Spang <spang@chromium.org>
    Commit-Queue: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582421}

    Changed files

    • ui/events/BUILD.gn
    • ui/events/ozone/BUILD.gn
    • ui/events/ozone/keyboard/event_auto_repeat_handler.cc
    • ui/events/ozone/keyboard/event_auto_repeat_handler.h
    • ui/ozone/platform/wayland/wayland_window_unittest.cc
  4. Bump tablet tester execution timeout

    Changed by Stephen Martinis - martinissohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:49:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 711748ea30b592183f2d37f54091dda9f4fee9c2

    Comments

    Bump tablet tester execution timeout
    
    They seem to need longer timeout for now. Hopefully will be temporary.
    
    TBR=bpastene
    
    Bug: 853248
    Change-Id: I6665013085631c69e6d78fe1f43f195e12d3295c
    Reviewed-on: https://chromium-review.googlesource.com/1171909
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    Commit-Queue: Stephen Martinis <martiniss@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582420}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
  5. Disable flaky tests.

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:46:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e064bc93ae45308ecc1b6fa886808ad20bd2225f

    Comments

    Disable flaky tests.
    
    Bug: 622387, 871692
    Change-Id: Ie03b640422b120d903ca56bf9f0650a1ffc23065
    TBR: mgiuca
    Reviewed-on: https://chromium-review.googlesource.com/1171852
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582419}

    Changed files

    • chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
    • chrome/test/data/webui/extensions/cr_extensions_browsertest.js
    • chrome/test/data/webui/settings/cr_settings_browsertest.js
  6. [Offline Pages] Implement live page sharing.

    Changed by Yafei Duan - romaxohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:45:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 514ffca0bacb2fce140defae3a4ae3dcab37bfa0

    Comments

    [Offline Pages] Implement live page sharing.
    
    Implement live page sharing:
    - Adding a new temporary client namespace for the usage of live page
      sharing, which has a limit of one page per url and expiration period
      as one hour.
    - Adding saveAndSharePage in OfflinePageUtils, implementing the workflow
      of save page, get page and share page.
    
    Bug: 870895
    Change-Id: Iab5f074dfa955ba30f8b125a70cedb87e8610246
    Reviewed-on: https://chromium-review.googlesource.com/1162827
    Reviewed-by: Peter Williamson <petewil@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Yafei Duan <romax@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582418}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/offlinepages/GetPagesByNamespaceForLivePageSharingCallback.java
    • chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
    • chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
    • chrome/android/java/src/org/chromium/chrome/browser/offlinepages/SavePageAndShareCallback.java
    • chrome/android/java/src/org/chromium/chrome/browser/share/ShareMenuActionHandler.java
    • chrome/android/java_sources.gni
    • components/offline_pages/core/client_namespace_constants.cc
    • components/offline_pages/core/client_namespace_constants.h
    • components/offline_pages/core/client_policy_controller.cc
    • components/offline_pages/core/client_policy_controller_unittest.cc
    • components/offline_pages/core/model/offline_page_model_utils.cc
    • tools/metrics/histograms/enums.xml
  7. Roll src/third_party/skia 4eac21fee047..f3ca1c6abb07 (18 commits)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Saturday, 11-Aug-18 01:40:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 51acd92215e6b735f2c0f80119f7ca51c031f797

    Comments

    Roll src/third_party/skia 4eac21fee047..f3ca1c6abb07 (18 commits)
    
    https://skia.googlesource.com/skia.git/+log/4eac21fee047..f3ca1c6abb07
    
    
    git log 4eac21fee047..f3ca1c6abb07 --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 brucewang@google.com Implement FreeType COLR/CPAL support.
    2018-08-10 timliang@google.com fixed the size in bytes of vec3s to match Metal standard in Metal gpu backend
    2018-08-10 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2018-08-10 timliang@google.com only set color index if using dual source blending in Metal gpu backend
    2018-08-10 kjlubick@google.com [PathKit] Add various path effects
    2018-08-10 mtklein@google.com clean up SK_LEGACY_CONVERT_PIXELS_IMPL
    2018-08-10 caryclark@skia.org fix text blob example errors
    2018-08-10 caryclark@skia.org fix bookmaker check for enum size
    2018-08-10 liyuqian@google.com Reland "Update ShouldUseAAA with our better complexity estimation"
    2018-08-10 timliang@google.com enabled gms and most unit tests for Metal gpu backend
    2018-08-10 mtklein@google.com switch ubsan to blacklist
    2018-08-10 bungeman@google.com Change generateAdvance to never chain.
    2018-08-10 caryclark@skia.org refresh generated includes
    2018-08-10 fmalita@chromium.org [sksg] Simplify ScopedRenderContext
    2018-08-10 caryclark@skia.org new batch of docs
    2018-08-10 timliang@google.com implemented GrMtlGpuCommandBuffer for draws in Metal gpu backend
    2018-08-10 mtklein@google.com add bounds sanitizer to ASAN/UBSAN bots
    2018-08-10 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader dd662d210afc..c47cd435bf6f (1 commits)
    
    
    Created with:
      gclient setdep -r src/third_party/skia@f3ca1c6abb07
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=djsollen@chromium.org
    
    Change-Id: I5274deea227ad59efbb4157cf2401fcc016ae264
    Reviewed-on: https://chromium-review.googlesource.com/1171445
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582417}

    Changed files

    • DEPS
  8. Mojo: Add ArrayTraits for std::unordered_set

    Changed by Joe Mason - joenotcharlesohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:31:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 576c7e134e5ce40b4ef09482600d9bd51f52d152

    Comments

    Mojo: Add ArrayTraits for std::unordered_set
    
    This is required to typemap chrome_cleaner::PUPData.
    
    R=rockot
    
    Bug: 830892
    Change-Id: I42e29dbd928c1bd9064ba9a75a37493461209b7e
    Reviewed-on: https://chromium-review.googlesource.com/1171736
    Commit-Queue: Joe Mason <joenotcharles@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582416}

    Changed files

    • mojo/public/cpp/bindings/array_traits_stl.h
  9. Change the history state throttle interval from 60 to 120 Hz.

    Changed by Chris Palmer - palmerohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:26:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e4127dd506c501cd3f51d91dc22a3dfa8f5f1ca

    Comments

    Change the history state throttle interval from 60 to 120 Hz.
    
    This is a bit more lenient and may enable some callers, including a flaky test,
    to get (more of) what they need. The test's root problem seems to be data races
    (see issue 847326), however.
    
    Bug: 870861
    Change-Id: I249e9f06fa9a9a9f3b74e53cf2ef3f34b0c2371c
    Reviewed-on: https://chromium-review.googlesource.com/1171825
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Chris Palmer <palmer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582415}

    Changed files

    • third_party/blink/renderer/core/frame/history.cc
  10. Normalize rendering_desktop.json, rendering_mobile.json

    Changed by Kai Ninomiya - kaininoohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:26:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 074cecb79d9d30ec9f2bf6b5b10edb6cd77a8b4f

    Comments

    Normalize rendering_desktop.json, rendering_mobile.json
    
    This is needed because re-recording archives (using record_wpr)
    causes these files to get re-alphabetized automatically.
    This commit lets us re-record an archive without producing an
    unreadable diff.
    
    Doing this also removes the duplicate key
    "androidpolice_mobile_sync_scroll_2018" from rendering_mobile.json.
    
    Tangentially, also delete the unused archive
    rendering_mobile_007.wprgo.sha1.
    
    Bug: 872551, 867368
    Change-Id: Ib15c9c0a8600e7fa510a146ad896aa92e4f9de45
    Reviewed-on: https://chromium-review.googlesource.com/1171677
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Commit-Queue: Kai Ninomiya <kainino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582414}

    Changed files

    • tools/perf/page_sets/data/rendering_desktop.json
    • tools/perf/page_sets/data/rendering_mobile.json
    • tools/perf/page_sets/data/rendering_mobile_007.wprgo.sha1
  11. Add Main Prompts for Card Migration Flow

    Changed by siyua - siyuaohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:24:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6fec3aebc5358345210d473c0ec36fef86ba5937

    Comments

    Add Main Prompts for Card Migration Flow
    
    This is the 1st CL adding view skeleton.
    
    For project details please refer to go/ib-paradise.
    
    Bug: 852904
    Change-Id: Icc10a2598bb15659a6478fc2dbf2734094111494
    Reviewed-on: https://chromium-review.googlesource.com/1149514
    Commit-Queue: Siyu An <siyua@chromium.org>
    Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Reviewed-by: Cait Phillips <caitkp@chromium.org>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Cr-Commit-Position: refs/heads/master@{#582413}

    Changed files

    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/autofill/local_card_migration_dialog.h
    • chrome/browser/ui/autofill/local_card_migration_dialog_controller_impl.cc
    • chrome/browser/ui/autofill/local_card_migration_dialog_controller_impl.h
    • chrome/browser/ui/autofill/local_card_migration_dialog_factory.h
    • chrome/browser/ui/autofill/local_card_migration_dialog_state.h
    • chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc
    • chrome/browser/ui/views/autofill/local_card_migration_dialog_view.h
    • chrome/browser/ui/views/harmony/chrome_layout_provider.cc
    • chrome/browser/ui/views/harmony/chrome_layout_provider.h
    • components/autofill/core/browser/BUILD.gn
    • components/autofill/core/browser/ui/local_card_migration_dialog_controller.h
    • components/autofill_strings.grdp
    • components/resources/autofill_scaled_resources.grdp
    • components/resources/default_100_percent/autofill/migration_header.png
    • components/resources/default_200_percent/autofill/migration_header.png
    • components/resources/default_300_percent/autofill/migration_header.png
  12. Send SharedImage IPC with multi-flush

    Changed by Antoine Labour - pimanohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:14:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 14ff32c26823fa7aff03d2d74790d04acdfb59ab

    Comments

    Send SharedImage IPC with multi-flush
    
    This generalizes the FlushParams to contain sync tokens + IPC::Message instead
    of ad-hoc fields transformed into Messages on the receiving side. This allows
    any Message (that doesn't have handles) to be included into the list, and
    simplifies the service-side handling.
    Existing AsyncFlush and DestroyTransferBuffer messages are now serialized
    client-side, and CreateSharedImage/DestroySharedImage are converted to this
    mechanism, to avoid extra IPCs per tile.
    
    Bug: 870116
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Ib11298c03e249f49aec8e710a3db4195aea33e81
    Reviewed-on: https://chromium-review.googlesource.com/1168731
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
    Commit-Queue: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582412}

    Changed files

    • gpu/command_buffer/common/command_buffer.h
    • gpu/ipc/client/command_buffer_proxy_impl.cc
    • gpu/ipc/client/command_buffer_proxy_impl_unittest.cc
    • gpu/ipc/client/gpu_channel_host.cc
    • gpu/ipc/client/gpu_channel_host.h
    • gpu/ipc/client/shared_image_interface_proxy.cc
    • gpu/ipc/common/BUILD.gn
    • gpu/ipc/common/flush_params.cc
    • gpu/ipc/common/flush_params.h
    • gpu/ipc/common/gpu_messages.h
    • gpu/ipc/common/gpu_param_traits_macros.h
    • gpu/ipc/service/gpu_channel.cc
    • gpu/ipc/service/shared_image_stub.cc
    • gpu/ipc/service/shared_image_stub.h
  13. chromeos: add SingleProcessMash mode

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:14:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b092ae622b9ab3856d64d3eca543e4ecb243be77

    Comments

    chromeos: add SingleProcessMash mode
    
    This makes Ash create an Env if passed SingleProcessMash. In addition this
    makes all window creation go through a factory that ensures the right env is
    supplied.
    
    See https://docs.google.com/document/d/11ha_KioDdXe4iZS2AML1foKnCJlNKm7Q1hFr6VW8dV4/edit
    for more details.
    
    This also adds the feature to ui/base.
    
    BUG=847992
    TEST=covered by tests
    
    Change-Id: Ica3c433627222f0e076dddaf19b1ab09168cebeb
    Reviewed-on: https://chromium-review.googlesource.com/1168282
    Commit-Queue: Scott Violet <sky@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582411}

    Changed files

    • ash/BUILD.gn
    • ash/README.md
    • ash/app_launch_unittest.cc
    • ash/ash_service_unittest.cc
    • ash/components/fast_ink/fast_ink_view.cc
    • ash/display/cursor_window_controller.cc
    • ash/display/display_manager_unittest.cc
    • ash/display/display_util.cc
    • ash/display/mirror_window_controller.cc
    • ash/display/mouse_cursor_event_filter_unittest.cc
    • ash/display/root_window_transformers_unittest.cc
    • ash/display/screen_ash.cc
    • ash/display/screen_position_controller_unittest.cc
    • ash/display/unified_mouse_warp_controller_unittest.cc
    • ash/display/window_tree_host_manager_unittest.cc
    • ash/drag_drop/drag_drop_tracker.cc
    • ash/events/event_rewriter_controller.cc
    • ash/extended_desktop_unittest.cc
    • ash/frame/detached_title_area_renderer.cc
    • ash/frame/header_view.cc
    • ash/host/DEPS
    • ash/host/ash_window_tree_host.cc
    • ash/host/ash_window_tree_host_platform.cc
    • ash/keyboard/arc/arc_input_method_surface_manager_unittest.cc
    • ash/keyboard/test_keyboard_ui.cc
    • ash/magnifier/docked_magnifier_controller.cc
    • ash/magnifier/magnification_controller_unittest.cc
    • ash/metrics/desktop_task_switch_metric_recorder_unittest.cc
    • ash/public/cpp/frame_border_hit_test.cc
    • ash/root_window_controller.cc
    • ash/root_window_controller_unittest.cc
    • ash/shelf/shelf_layout_manager_unittest.cc
    • ash/shelf/shelf_window_watcher_unittest.cc
    • ash/shell.cc
    • ash/shell.h
    • ash/shell_unittest.cc
    • ash/system/message_center/arc/arc_notification_content_view_unittest.cc
    • ash/system/message_center/arc/arc_notification_view_unittest.cc
    • ash/system/message_center/arc/mock_arc_notification_surface.cc
    • ash/system/message_center/arc/mock_arc_notification_surface.h
    • ash/system/night_light/night_light_controller.cc
    • ash/system/overview/overview_button_tray_unittest.cc
    • ash/system/tray/tray_background_view.cc
    • ash/test/ash_test_base.cc
    • ash/test/ash_test_helper.cc
    • ash/test/ash_test_suite.cc
    • ash/test/ui_controls_factory_ash.cc
    • ash/utility/screenshot_controller_unittest.cc
    • ash/wayland/wayland_server_controller.cc
    • ash/wayland/wayland_server_controller.h
    • ash/window_factory.cc
    • ash/window_factory.h
    • ash/window_user_data_unittest.cc
    • ash/wm/ash_focus_rules_unittest.cc
    • ash/wm/cursor_manager_chromeos.cc
    • ash/wm/drag_window_controller.cc
    • ash/wm/drag_window_resizer_unittest.cc
    • ash/wm/immersive_fullscreen_controller_unittest.cc
    • ash/wm/native_cursor_manager_ash_classic.cc
    • ash/wm/non_client_frame_controller.cc
    • ash/wm/overview/window_selector_unittest.cc
    • ash/wm/stacking_controller_unittest.cc
    • ash/wm/system_gesture_event_filter_unittest.cc
    • ash/wm/system_modal_container_layout_manager_unittest.cc
    • ash/wm/top_level_window_factory.cc
    • ash/wm/toplevel_window_event_handler.cc
    • ash/wm/toplevel_window_event_handler_unittest.cc
    • ash/wm/video_detector.cc
    • ash/wm/window_dimmer.cc
    • ash/wm/window_dimmer_unittest.cc
    • ash/wm/workspace/workspace_event_handler_unittest.cc
    • ash/wm/workspace/workspace_layout_manager_unittest.cc
    • ash/wm/workspace/workspace_window_resizer_unittest.cc
    • ash/wm/workspace_controller_unittest.cc
    • ash/ws/window_service_owner.cc
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
    • chrome/browser/ui/ash/ksv/DEPS
    • chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_util.cc
    • components/exo/test/exo_test_base.cc
    • components/exo/wayland/clients/test/wayland_client_test.cc
    • ui/aura/env.cc
    • ui/aura/env.h
    • ui/aura/test/test_windows.cc
    • ui/aura/test/test_windows.h
    • ui/aura/window.cc
    • ui/aura/window.h
    • ui/aura/window_tree_host_platform.cc
    • ui/base/ui_base_features.cc
    • ui/base/ui_base_features.h
  14. refine window finder for mash

    Changed by Jun Mukai - mukaiohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:09:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c0f9aa861fdb9bc534829d3f764e2100cfff71c

    Comments

    refine window finder for mash
    
    Previously window_finder_chromeos (for mash) looks through the
    list of the toplevel browser windows, but it is too simple and
    doesn't work well on several cases.
    
    This CL moves the window finding code to ash, and let WindowTree
    notify the list of windows at the cursor to the client upon
    window moving.
    
    BUG=867074
    TEST=ash_unittests
    
    Change-Id: Ib44ad1a927a31c50cc108eee92ddba4d9bd918ee
    Reviewed-on: https://chromium-review.googlesource.com/1159346
    Commit-Queue: Jun Mukai <mukai@chromium.org>
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582410}

    Changed files

    • ash/BUILD.gn
    • ash/wm/window_finder.cc
    • ash/wm/window_finder.h
    • ash/wm/window_finder_unittest.cc
    • ash/ws/window_service_delegate_impl.cc
    • ash/ws/window_service_delegate_impl.h
    • ash/ws/window_service_delegate_impl_unittest.cc
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/views/tabs/DEPS
    • chrome/browser/ui/views/tabs/tab_drag_controller.cc
    • chrome/browser/ui/views/tabs/window_finder.cc
    • chrome/browser/ui/views/tabs/window_finder.h
    • chrome/browser/ui/views/tabs/window_finder_chromeos.cc
    • content/renderer/mus/renderer_window_tree_client.cc
    • content/renderer/mus/renderer_window_tree_client.h
    • services/ui/public/interfaces/window_tree.mojom
    • services/ui/ws2/BUILD.gn
    • services/ui/ws2/test_change_tracker.cc
    • services/ui/ws2/test_change_tracker.h
    • services/ui/ws2/test_window_tree_client.cc
    • services/ui/ws2/test_window_tree_client.h
    • services/ui/ws2/topmost_window_observer.cc
    • services/ui/ws2/topmost_window_observer.h
    • services/ui/ws2/window_service_delegate.cc
    • services/ui/ws2/window_service_delegate.h
    • services/ui/ws2/window_tree.cc
    • services/ui/ws2/window_tree.h
    • ui/aura/BUILD.gn
    • ui/aura/mus/topmost_window_tracker.cc
    • ui/aura/mus/topmost_window_tracker.h
    • ui/aura/mus/window_tree_client.cc
    • ui/aura/mus/window_tree_client.h
    • ui/aura/test/mus/test_window_tree.cc
    • ui/aura/test/mus/test_window_tree.h
  15. Orderfile: renable misordered symbol threshold in check_orderfile.py.

    Changed by Matthew Cary - mattcaryohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:09:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bdba7075443440ec9b67631bc351866397558f0e

    Comments

    Orderfile: renable misordered symbol threshold in check_orderfile.py.
    
    Bug: 873380
    Change-Id: Iaa194b57f57985a6bc851a2b826555a6d087a57c
    Reviewed-on: https://chromium-review.googlesource.com/1171234
    Commit-Queue: Matthew Cary <mattcary@chromium.org>
    Reviewed-by: Benoit L <lizeb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582409}

    Changed files

    • tools/cygprofile/check_orderfile.py
    • tools/cygprofile/check_orderfile_unittest.py
  16. Roll src/third_party/depot_tools 284b5e0c60ac..6a4e31b4882f (1 commits)

    Changed by depot-tools-chromium-autoroll - depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Saturday, 11-Aug-18 01:08:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3bb07ab082388ed8e0590614162bc1cc9f756bdb

    Comments

    Roll src/third_party/depot_tools 284b5e0c60ac..6a4e31b4882f (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/284b5e0c60ac..6a4e31b4882f
    
    
    git log 284b5e0c60ac..6a4e31b4882f --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 ehmaldonado@chromium.org gclient_scm: Add option to specify the branch the patch is based on.
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@6a4e31b4882f
    
    The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:870279
    TBR=agable@chromium.org
    
    Change-Id: I4563fb1540b017267659c6d67ca8dcbf6f3feb8f
    Reviewed-on: https://chromium-review.googlesource.com/1171443
    Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582408}

    Changed files

    • DEPS
  17. cros: Fix empty preview wallpaper description issue

    Changed by Wenzhao Zang - wzangohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:02:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a59fa8e81cbc0a8d5b5cbb61172d86a4ff4e10a

    Comments

    cros: Fix empty preview wallpaper description issue
    
    Bug: 873340
    Change-Id: Ia5979ba5305b154a27689157db573f8bc6803801
    Reviewed-on: https://chromium-review.googlesource.com/1171790
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582407}

    Changed files

    • chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js
  18. Revert "Add debug chromium bots"

    Changed by Stephen Martinis - martinissohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:59:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f3cf71cc8609b20283f2e3eeb3a378a3c51d544

    Comments

    Revert "Add debug chromium bots"
    
    This reverts commit 2db4180229db1c343018f96400d97944534b7a77.
    
    Reason for revert: Bots are purple, will reland and make sure they're green later.
    
    Original change's description:
    > Add debug chromium bots
    > 
    > These are mirrors of the existing release bots
    > 
    > Bug: 867725
    > Change-Id: I6f59d04a82103572e801273e294534e822d3e03d
    > Reviewed-on: https://chromium-review.googlesource.com/1159172
    > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
    > Reviewed-by: Nodir Turakulov <nodir@chromium.org>
    > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    > Reviewed-by: Kenneth Russell <kbr@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#582390}
    
    TBR=iannucci@chromium.org,vadimsh@chromium.org,dpranke@chromium.org,kbr@chromium.org,nodir@chromium.org,martiniss@chromium.org,jbudorick@chromium.org
    
    Change-Id: I28a27093f09db79c83239070325254df6a1a0dca
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 867725
    Reviewed-on: https://chromium-review.googlesource.com/1171430
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    Commit-Queue: Stephen Martinis <martiniss@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582406}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
    • infra/config/global/luci-milo.cfg
    • infra/config/global/luci-scheduler.cfg
    • testing/buildbot/chromium.json
    • testing/buildbot/test_suite_exceptions.pyl
    • testing/buildbot/waterfalls.pyl
    • tools/mb/mb_config.pyl
  19. Clean up PdfCompositorImpl.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:55:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b2f31335a925a33e3fec9a7d7e765698f4cc3de3

    Comments

    Clean up PdfCompositorImpl.
    
    - Make some methods const.
    - Update some comments.
    - Remove an unimplemented method declaration.
    - Remove an unused method parameter.
    
    Change-Id: I678d740f4915b4d55d5be5fdc6482b7bac18778b
    Reviewed-on: https://chromium-review.googlesource.com/1170401
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Reviewed-by: Wei Li <weili@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582405}

    Changed files

    • components/services/pdf_compositor/pdf_compositor_impl.cc
    • components/services/pdf_compositor/pdf_compositor_impl.h
  20. [ChromeDriver] Fix version string in release branch

    Changed by John Chen - johnchenohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:52:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dbe92472c755ab9519221b35a96c1458a61293cf

    Comments

    [ChromeDriver] Fix version string in release branch
    
    The previous change (r581945) to update version string used by
    ChromeDriver in release branches didn't work, because the top-most
    commit doesn't have the necessary branch info. This CL adds the same
    commit filter used to generate the version string shown by Chrome.
    
    Bug: chromedriver:2080
    Change-Id: I4d7b57a139968d3e5e0f1ebad26d6ed648ab5d72
    Reviewed-on: https://chromium-review.googlesource.com/1171843
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Commit-Queue: John Chen <johnchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582404}

    Changed files

    • chrome/test/chromedriver/embed_version_in_cpp.py
  21. Add vector of intervals range checking to Time Restrictions policy

    Changed by Adolfo Victoria - adokarohnoyoudont@google.com
    Changed at Saturday, 11-Aug-18 00:42:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b3392d988ae23dc52d9b386af47dc6a53a2d22c8

    Comments

    Add vector of intervals range checking to Time Restrictions policy
    
    * Add function GetEndOfCurrent interval to obtain the last end of the
    interval which contains the current time.
    * Add function MaterializeIntervalsToLocalTimezone, which materializes
    the given intervals to the current local timezone.
    * Add function TimeIsInsideCrosSettingsIntervals, which checks if the
    current time is inside the intervals set in cros settings. It then
    returns the localized string of the end of the interval that contains
    the current time.
    
    BUG=chromium:852860
    TEST=added unittests
    
    Change-Id: Ife32e31c8a929827fd14ab9f108c49eacb9c32c3
    Reviewed-on: https://chromium-review.googlesource.com/1132676
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582403}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/policy/device_auto_update_time_restrictions_utils.cc
    • chrome/browser/chromeos/policy/device_auto_update_time_restrictions_utils.h
    • chrome/browser/chromeos/policy/device_auto_update_time_restrictions_utils_unittest.cc
    • chrome/browser/chromeos/policy/weekly_time/time_utils.cc
    • chrome/browser/chromeos/policy/weekly_time/time_utils.h
    • chrome/browser/chromeos/policy/weekly_time/time_utils_unittest.cc
    • chrome/browser/chromeos/policy/weekly_time/weekly_time.h
    • chrome/browser/chromeos/policy/weekly_time/weekly_time_interval.h
  22. Roll src/third_party/angle 077cd858b2d4..ea926a362b77 (3 commits)

    Changed by angle-chromium-autoroll - angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Saturday, 11-Aug-18 00:41:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e4c26fa3e9b08e7dda082537ecfdc254c8d8db35

    Comments

    Roll src/third_party/angle 077cd858b2d4..ea926a362b77 (3 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/077cd858b2d4..ea926a362b77
    
    
    git log 077cd858b2d4..ea926a362b77 --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 jmadill@chromium.org Add angle_perftests README file.
    2018-08-10 jmadill@chromium.org D3D: Use angle::Result error pattern.
    2018-08-10 jmadill@chromium.org Fix AMD detection in angle_end2end_tests.
    
    
    Created with:
      gclient setdep -r src/third_party/angle@ea926a362b77
    
    The AutoRoll server is located here: https://angle-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=ynovikov@chromium.org
    
    Change-Id: I66ef52bae109017756c16854706a5a4b95d73c23
    Reviewed-on: https://chromium-review.googlesource.com/1171403
    Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582402}

    Changed files

    • DEPS
  23. Roll HarfBuzz to 1.8.7

    Changed by Emil A Eklund - eaeohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:35:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 03427d53dc8e88fbde543f6115708a98c2b9b1f0

    Comments

    Roll HarfBuzz to 1.8.7
    
    https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/2b76767bf572364d3d647cdd139f2044a7ad06b2..b6fdcf4f8bd09e065c767939125861c9dc8ff18f
    
    Tbr: drott@chromium.org
    Change-Id: Ie65cb46846224bd90ffa86517a946c44f321f2c7
    Reviewed-on: https://chromium-review.googlesource.com/1170170
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582401}

    Changed files

    • DEPS
    • third_party/harfbuzz-ng/README.chromium
  24. [ChromeDriver] Fix testWindowMinimize and remove old code

    Changed by Tatiana Buldina - buldinaohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:34:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0bd3fb604e6b8598a546503e09f4979d4590ccb8

    Comments

    [ChromeDriver] Fix testWindowMinimize and remove old code
    
    Fix a test failure in Python test case testWindowMinimize, and
    clean up code related to not supported version.
    
    Change-Id: I076cdc90cdaca322bc64530c6bb9eabe6ae9069a
    Reviewed-on: https://chromium-review.googlesource.com/1171805
    Reviewed-by: John Chen <johnchen@chromium.org>
    Commit-Queue: Tatiana Buldina <buldina@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582400}

    Changed files

    • chrome/test/chromedriver/test/run_py_tests.py
  25. Roll src/third_party/catapult 5a4110982f31..21cd5a309631 (1 commits)

    Changed by catapult-chromium-autoroll - catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Saturday, 11-Aug-18 00:34:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 24be12346d5a4ec8ebcc2c0615add14d150496e7

    Comments

    Roll src/third_party/catapult 5a4110982f31..21cd5a309631 (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/5a4110982f31..21cd5a309631
    
    
    git log 5a4110982f31..21cd5a309631 --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 dtu@chromium.org [pinpoint] Ignore comparison_magnitude == 'None' for reruns.
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@21cd5a309631
    
    The AutoRoll server is located here: https://catapult-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:873331
    TBR=sullivan@chromium.org
    
    Change-Id: Ie322f1501b9f5411006fd4d603edf90941097a93
    Reviewed-on: https://chromium-review.googlesource.com/1171404
    Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582399}

    Changed files

    • DEPS
  26. Speculative fix for GSA crashes with MediaCodec callback API.

    Changed by Dale Curtis - dalecurtisohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:32:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7feecd556d5bb5fe3bd419703709c5ce38942123

    Comments

    Speculative fix for GSA crashes with MediaCodec callback API.
    
    Prevents any calls into the native bridge once release() has been
    called on MediaCodecBridge. I've also reordered some member
    variables of the bridge to match their lifetime.
    
    BUG=873094
    TEST=none
    
    Change-Id: Iccf648275bac2d466ce62c5e4e792f9a088b09a0
    Reviewed-on: https://chromium-review.googlesource.com/1171836
    Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
    Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582398}

    Changed files

    • media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
    • media/base/android/media_codec_bridge_impl.cc
    • media/base/android/media_codec_bridge_impl.h
  27. Reduce telemetry based isolate size

    Changed by Zhenyao Mo - zmoohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:19:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1715e3f972fe31826c3aaa4eaef20d0aeb7794c6

    Comments

    Reduce telemetry based isolate size
    
    Excluding some large size data in third_party/catapult/ that are not needed
    in running the telemetry tests.
    
    R=kbr@chromium.org,nednguyen@chromium.org
    
    Change-Id: I10a1968b5a9b02415f5d7f66b33a247d64791578
    Bug: 872521
    Reviewed-on: https://chromium-review.googlesource.com/1166261
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Commit-Queue: Zhenyao Mo <zmo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582397}

    Changed files

    • chrome/test/BUILD.gn
    • tools/perf/chrome_telemetry_build/BUILD.gn
  28. [Offline pages]: Fix css class so we apply download image correctly

    Changed by Cathy Li - chiliohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:07:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d37e211bd2d980098fadcec0151bb533af6cc360

    Comments

    [Offline pages]: Fix css class so we apply download image correctly
    
    Bug: 873124
    Change-Id: I5f5f5af481e9f8e31a1dab141b9b4dac93acc121
    Reviewed-on: https://chromium-review.googlesource.com/1171742
    Reviewed-by: Peter Williamson <petewil@chromium.org>
    Commit-Queue: Cathy Li <chili@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582396}

    Changed files

    • components/neterror/resources/neterror.css
  29. Updating XTBs based on .GRDs from branch master

    Changed by Krishna Govind - govindohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:05:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision af94e466a77ac86e5f795780749c07bb886ebf60

    Comments

    Updating XTBs based on .GRDs from branch master
    
    R=amineer@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I5429bacaf530263c0fe78c4403624d6773d12866
    Reviewed-on: https://chromium-review.googlesource.com/1171858
    Reviewed-by: Krishna Govind <govind@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582395}

    Changed files

    • ash/components/strings/ash_components_strings_mr.xtb
    • ash/strings/ash_strings_ar.xtb
    • ash/strings/ash_strings_bn.xtb
    • ash/strings/ash_strings_es-419.xtb
    • ash/strings/ash_strings_fa.xtb
    • ash/strings/ash_strings_fi.xtb
    • ash/strings/ash_strings_fil.xtb
    • ash/strings/ash_strings_gu.xtb
    • ash/strings/ash_strings_hu.xtb
    • ash/strings/ash_strings_ja.xtb
    • ash/strings/ash_strings_kn.xtb
    • ash/strings/ash_strings_ko.xtb
    • ash/strings/ash_strings_lt.xtb
    • ash/strings/ash_strings_ml.xtb
    • ash/strings/ash_strings_mr.xtb
    • ash/strings/ash_strings_ru.xtb
    • ash/strings/ash_strings_ta.xtb
    • ash/strings/ash_strings_th.xtb
    • ash/strings/ash_strings_tr.xtb
    • ash/strings/ash_strings_vi.xtb
    • ash/strings/ash_strings_zh-CN.xtb
    • ash/strings/ash_strings_zh-TW.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es-419.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fil.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hu.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ja.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ko.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lt.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ru.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_th.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_tr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_vi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_zh-CN.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_zh-TW.xtb
    • chrome/app/resources/chromium_strings_ar.xtb
    • chrome/app/resources/generated_resources_am.xtb
    • chrome/app/resources/generated_resources_ar.xtb
    • chrome/app/resources/generated_resources_bg.xtb
    • chrome/app/resources/generated_resources_bn.xtb
    • chrome/app/resources/generated_resources_ca.xtb
    • chrome/app/resources/generated_resources_cs.xtb
    • chrome/app/resources/generated_resources_da.xtb
    • chrome/app/resources/generated_resources_de.xtb
    • chrome/app/resources/generated_resources_el.xtb
    • chrome/app/resources/generated_resources_en-GB.xtb
    • chrome/app/resources/generated_resources_es-419.xtb
    • chrome/app/resources/generated_resources_es.xtb
    • chrome/app/resources/generated_resources_et.xtb
    • chrome/app/resources/generated_resources_fa.xtb
    • chrome/app/resources/generated_resources_fi.xtb
    • chrome/app/resources/generated_resources_fil.xtb
    • chrome/app/resources/generated_resources_fr.xtb
    • chrome/app/resources/generated_resources_gu.xtb
    • chrome/app/resources/generated_resources_hi.xtb
    • chrome/app/resources/generated_resources_hr.xtb
    • chrome/app/resources/generated_resources_hu.xtb
    • chrome/app/resources/generated_resources_id.xtb
    • chrome/app/resources/generated_resources_it.xtb
    • chrome/app/resources/generated_resources_iw.xtb
    • chrome/app/resources/generated_resources_ja.xtb
    • chrome/app/resources/generated_resources_kn.xtb
    • chrome/app/resources/generated_resources_ko.xtb
    • chrome/app/resources/generated_resources_lt.xtb
    • chrome/app/resources/generated_resources_lv.xtb
    • chrome/app/resources/generated_resources_ml.xtb
    • chrome/app/resources/generated_resources_mr.xtb
    • chrome/app/resources/generated_resources_ms.xtb
    • chrome/app/resources/generated_resources_nl.xtb
    • chrome/app/resources/generated_resources_no.xtb
    • chrome/app/resources/generated_resources_pl.xtb
    • chrome/app/resources/generated_resources_pt-BR.xtb
    • chrome/app/resources/generated_resources_pt-PT.xtb
    • chrome/app/resources/generated_resources_ro.xtb
    • chrome/app/resources/generated_resources_ru.xtb
    • chrome/app/resources/generated_resources_sk.xtb
    • chrome/app/resources/generated_resources_sl.xtb
    • chrome/app/resources/generated_resources_sr.xtb
    • chrome/app/resources/generated_resources_sv.xtb
    • chrome/app/resources/generated_resources_sw.xtb
    • chrome/app/resources/generated_resources_ta.xtb
    • chrome/app/resources/generated_resources_te.xtb
    • chrome/app/resources/generated_resources_th.xtb
    • chrome/app/resources/generated_resources_tr.xtb
    • chrome/app/resources/generated_resources_uk.xtb
    • chrome/app/resources/generated_resources_vi.xtb
    • chrome/app/resources/generated_resources_zh-CN.xtb
    • chrome/app/resources/generated_resources_zh-TW.xtb
    • chrome/app/resources/google_chrome_strings_ar.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_es-419.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fil.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_gu.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hu.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ja.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_kn.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ko.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_lt.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ml.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_mr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ru.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ta.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_th.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_tr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_vi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-CN.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-TW.xtb
    • chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_bn.xtb
    • chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_fa.xtb
    • components/policy/resources/policy_templates_am.xtb
    • components/policy/resources/policy_templates_ar.xtb
    • components/policy/resources/policy_templates_bg.xtb
    • components/policy/resources/policy_templates_bn.xtb
    • components/policy/resources/policy_templates_ca.xtb
    • components/policy/resources/policy_templates_cs.xtb
    • components/policy/resources/policy_templates_da.xtb
    • components/policy/resources/policy_templates_de.xtb
    • components/policy/resources/policy_templates_el.xtb
    • components/policy/resources/policy_templates_en-GB.xtb
    • components/policy/resources/policy_templates_es-419.xtb
    • components/policy/resources/policy_templates_es.xtb
    • components/policy/resources/policy_templates_et.xtb
    • components/policy/resources/policy_templates_fa.xtb
    • components/policy/resources/policy_templates_fi.xtb
    • components/policy/resources/policy_templates_fil.xtb
    • components/policy/resources/policy_templates_fr.xtb
    • components/policy/resources/policy_templates_gu.xtb
    • components/policy/resources/policy_templates_hi.xtb
    • components/policy/resources/policy_templates_hr.xtb
    • components/policy/resources/policy_templates_hu.xtb
    • components/policy/resources/policy_templates_id.xtb
    • components/policy/resources/policy_templates_it.xtb
    • components/policy/resources/policy_templates_iw.xtb
    • components/policy/resources/policy_templates_ja.xtb
    • components/policy/resources/policy_templates_kn.xtb
    • components/policy/resources/policy_templates_ko.xtb
    • components/policy/resources/policy_templates_lt.xtb
    • components/policy/resources/policy_templates_lv.xtb
    • components/policy/resources/policy_templates_ml.xtb
    • components/policy/resources/policy_templates_mr.xtb
    • components/policy/resources/policy_templates_ms.xtb
    • components/policy/resources/policy_templates_nl.xtb
    • components/policy/resources/policy_templates_no.xtb
    • components/policy/resources/policy_templates_pl.xtb
    • components/policy/resources/policy_templates_pt-BR.xtb
    • components/policy/resources/policy_templates_pt-PT.xtb
    • components/policy/resources/policy_templates_ro.xtb
    • components/policy/resources/policy_templates_ru.xtb
    • components/policy/resources/policy_templates_sk.xtb
    • components/policy/resources/policy_templates_sl.xtb
    • components/policy/resources/policy_templates_sr.xtb
    • components/policy/resources/policy_templates_sv.xtb
    • components/policy/resources/policy_templates_sw.xtb
    • components/policy/resources/policy_templates_ta.xtb
    • components/policy/resources/policy_templates_te.xtb
    • components/policy/resources/policy_templates_th.xtb
    • components/policy/resources/policy_templates_tr.xtb
    • components/policy/resources/policy_templates_uk.xtb
    • components/policy/resources/policy_templates_vi.xtb
    • components/policy/resources/policy_templates_zh-CN.xtb
    • components/policy/resources/policy_templates_zh-TW.xtb
    • components/strings/components_strings_am.xtb
    • components/strings/components_strings_ar.xtb
    • components/strings/components_strings_bg.xtb
    • components/strings/components_strings_bn.xtb
    • components/strings/components_strings_ca.xtb
    • components/strings/components_strings_cs.xtb
    • components/strings/components_strings_da.xtb
    • components/strings/components_strings_de.xtb
    • components/strings/components_strings_el.xtb
    • components/strings/components_strings_en-GB.xtb
    • components/strings/components_strings_es-419.xtb
    • components/strings/components_strings_es.xtb
    • components/strings/components_strings_et.xtb
    • components/strings/components_strings_fa.xtb
    • components/strings/components_strings_fi.xtb
    • components/strings/components_strings_fil.xtb
    • components/strings/components_strings_fr.xtb
    • components/strings/components_strings_gu.xtb
    • components/strings/components_strings_hi.xtb
    • components/strings/components_strings_hr.xtb
    • components/strings/components_strings_hu.xtb
    • components/strings/components_strings_id.xtb
    • components/strings/components_strings_it.xtb
    • components/strings/components_strings_iw.xtb
    • components/strings/components_strings_ja.xtb
    • components/strings/components_strings_kn.xtb
    • components/strings/components_strings_ko.xtb
    • components/strings/components_strings_lt.xtb
    • components/strings/components_strings_lv.xtb
    • components/strings/components_strings_ml.xtb
    • components/strings/components_strings_mr.xtb
    • components/strings/components_strings_ms.xtb
    • components/strings/components_strings_nl.xtb
    • components/strings/components_strings_no.xtb
    • components/strings/components_strings_pl.xtb
    • components/strings/components_strings_pt-BR.xtb
    • components/strings/components_strings_pt-PT.xtb
    • components/strings/components_strings_ro.xtb
    • components/strings/components_strings_ru.xtb
    • components/strings/components_strings_sk.xtb
    • components/strings/components_strings_sl.xtb
    • components/strings/components_strings_sr.xtb
    • components/strings/components_strings_sv.xtb
    • components/strings/components_strings_sw.xtb
    • components/strings/components_strings_ta.xtb
    • components/strings/components_strings_te.xtb
    • components/strings/components_strings_th.xtb
    • components/strings/components_strings_tr.xtb
    • components/strings/components_strings_uk.xtb
    • components/strings/components_strings_vi.xtb
    • components/strings/components_strings_zh-CN.xtb
    • components/strings/components_strings_zh-TW.xtb
    • content/app/strings/translations/content_strings_es.xtb
    • content/app/strings/translations/content_strings_fi.xtb
    • content/app/strings/translations/content_strings_mr.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_es-419.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_fi.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_fil.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_gu.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_hu.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ja.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_kn.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ko.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_lt.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ml.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_mr.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_pl.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ru.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ta.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_th.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_tr.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_vi.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_zh-CN.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_zh-TW.xtb
    • ios/chrome/app/strings/resources/ios_google_chrome_strings_pl.xtb
    • ios/chrome/app/strings/resources/ios_strings_am.xtb
    • ios/chrome/app/strings/resources/ios_strings_ar.xtb
    • ios/chrome/app/strings/resources/ios_strings_bg.xtb
    • ios/chrome/app/strings/resources/ios_strings_bn.xtb
    • ios/chrome/app/strings/resources/ios_strings_ca.xtb
    • ios/chrome/app/strings/resources/ios_strings_cs.xtb
    • ios/chrome/app/strings/resources/ios_strings_da.xtb
    • ios/chrome/app/strings/resources/ios_strings_de.xtb
    • ios/chrome/app/strings/resources/ios_strings_el.xtb
    • ios/chrome/app/strings/resources/ios_strings_en-GB.xtb
    • ios/chrome/app/strings/resources/ios_strings_es-419.xtb
    • ios/chrome/app/strings/resources/ios_strings_es.xtb
    • ios/chrome/app/strings/resources/ios_strings_et.xtb
    • ios/chrome/app/strings/resources/ios_strings_fa.xtb
    • ios/chrome/app/strings/resources/ios_strings_fi.xtb
    • ios/chrome/app/strings/resources/ios_strings_fil.xtb
    • ios/chrome/app/strings/resources/ios_strings_fr.xtb
    • ios/chrome/app/strings/resources/ios_strings_gu.xtb
    • ios/chrome/app/strings/resources/ios_strings_hi.xtb
    • ios/chrome/app/strings/resources/ios_strings_hr.xtb
    • ios/chrome/app/strings/resources/ios_strings_hu.xtb
    • ios/chrome/app/strings/resources/ios_strings_id.xtb
    • ios/chrome/app/strings/resources/ios_strings_it.xtb
    • ios/chrome/app/strings/resources/ios_strings_iw.xtb
    • ios/chrome/app/strings/resources/ios_strings_ja.xtb
    • ios/chrome/app/strings/resources/ios_strings_kn.xtb
    • ios/chrome/app/strings/resources/ios_strings_ko.xtb
    • ios/chrome/app/strings/resources/ios_strings_lt.xtb
    • ios/chrome/app/strings/resources/ios_strings_lv.xtb
    • ios/chrome/app/strings/resources/ios_strings_ml.xtb
    • ios/chrome/app/strings/resources/ios_strings_mr.xtb
    • ios/chrome/app/strings/resources/ios_strings_ms.xtb
    • ios/chrome/app/strings/resources/ios_strings_nl.xtb
    • ios/chrome/app/strings/resources/ios_strings_no.xtb
    • ios/chrome/app/strings/resources/ios_strings_pl.xtb
    • ios/chrome/app/strings/resources/ios_strings_pt-BR.xtb
    • ios/chrome/app/strings/resources/ios_strings_pt-PT.xtb
    • ios/chrome/app/strings/resources/ios_strings_ro.xtb
    • ios/chrome/app/strings/resources/ios_strings_ru.xtb
    • ios/chrome/app/strings/resources/ios_strings_sk.xtb
    • ios/chrome/app/strings/resources/ios_strings_sl.xtb
    • ios/chrome/app/strings/resources/ios_strings_sr.xtb
    • ios/chrome/app/strings/resources/ios_strings_sv.xtb
    • ios/chrome/app/strings/resources/ios_strings_sw.xtb
    • ios/chrome/app/strings/resources/ios_strings_ta.xtb
    • ios/chrome/app/strings/resources/ios_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_strings_th.xtb
    • ios/chrome/app/strings/resources/ios_strings_tr.xtb
    • ios/chrome/app/strings/resources/ios_strings_uk.xtb
    • ios/chrome/app/strings/resources/ios_strings_vi.xtb
    • ios/chrome/app/strings/resources/ios_strings_zh-CN.xtb
    • ios/chrome/app/strings/resources/ios_strings_zh-TW.xtb
  30. Add the PageAlmostIdleAndLocalDB experiment to fieldtrial_testing_config.json

    Changed by Sebastien Marchand - sebmarchandohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:04:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fad3162e6ad14ef32cacf0e2e05e474d91041d87

    Comments

    Add the PageAlmostIdleAndLocalDB experiment to fieldtrial_testing_config.json
    
    This moves the PageAlmostIdle and SiteCharacteristicsDatabase features to their
    own experiment so they can easily be shipped to Beta only.
    
    Change-Id: I56c65e4ffb8b389b502a8c03d661ca2c26a66abe
    Reviewed-on: https://chromium-review.googlesource.com/1168107
    Reviewed-by: Chris Hamilton <chrisha@chromium.org>
    Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
    Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582394}

    Changed files

    • testing/variations/fieldtrial_testing_config.json
  31. Add a new type of shelf status/indicator for "active" status

    Changed by Manu Cornet - manucornetohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:04:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b12dd997dd70b06c806c89e16cbf1302eacbd972

    Comments

    Add a new type of shelf status/indicator for "active" status
    
    This will allow us to differentiate between "running" and "active".
    The logic to set this properly depending on status will come in a
    separate CL.
    
    Note that no shelf item is ever marked as STATUS_ACTIVE yet, so
    this CL has no effect on behavior.
    
    Bug: 805612
    Change-Id: I50f985d66659bd35e2b59ab19a898ae5a3634179
    Reviewed-on: https://chromium-review.googlesource.com/1170394
    Commit-Queue: Manu Cornet <manucornet@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582393}

    Changed files

    • ash/public/cpp/shelf_struct_mojom_traits.h
    • ash/public/cpp/shelf_types.h
    • ash/public/interfaces/shelf.mojom
    • ash/shelf/shelf_button.cc
    • ash/shelf/shelf_button.h
    • ash/shelf/shelf_view.cc
  32. Run WebGL 2.0 tests on passthrough cmd decoder on Linux/Intel.

    Changed by Kenneth Russell - kbrohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:01:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c7862cb6e7b0be134f2373e3dae5af8d0f6dc64

    Comments

    Run WebGL 2.0 tests on passthrough cmd decoder on Linux/Intel.
    
    It looks like an oversight that they weren't run on this configuration
    previously.
    
    Tbr: geofflang@chromium.org
    Bug: 872302
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I77e4e175a449cea70254dcc3bab8ea3686fc74d9
    Reviewed-on: https://chromium-review.googlesource.com/1168464
    Reviewed-by: Geoff Lang <geofflang@chromium.org>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582392}

    Changed files

    • testing/buildbot/chromium.gpu.fyi.json
    • testing/buildbot/waterfalls.pyl
  33. Fix new tab animation from tab switcher in Duet

    Changed by Matthew Jones - mdjonesohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:00:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9226b58bb77c84fd444da9d423199356bea96673

    Comments

    Fix new tab animation from tab switcher in Duet
    
    This patch changes the container that the new tab animation runs in
    when Duet is enabled. The container changes position from running on
    top of the toolbars to running beneath them (since the bottom toolbar
    is a persistent fixture). This would negatively impact the top toolbar
    if there were still icons there (since the top toolbar has an
    appearance animation to compensate for the tab appearing on top of
    it). However, since there are no icons, it is not an issue.
    
    Bug: 852012
    Change-Id: I19422b70844f3fd45e7d9318a3c9c9768b407991
    Reviewed-on: https://chromium-review.googlesource.com/1171819
    Commit-Queue: Matthew Jones <mdjones@chromium.org>
    Reviewed-by: Pedro Amaral <amaralp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582391}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayoutBase.java
  34. Add debug chromium bots

    Changed by Stephen Martinis - martinissohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:58:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2db4180229db1c343018f96400d97944534b7a77

    Comments

    Add debug chromium bots
    
    These are mirrors of the existing release bots
    
    Bug: 867725
    Change-Id: I6f59d04a82103572e801273e294534e822d3e03d
    Reviewed-on: https://chromium-review.googlesource.com/1159172
    Commit-Queue: Stephen Martinis <martiniss@chromium.org>
    Reviewed-by: Nodir Turakulov <nodir@chromium.org>
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582390}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
    • infra/config/global/luci-milo.cfg
    • infra/config/global/luci-scheduler.cfg
    • testing/buildbot/chromium.json
    • testing/buildbot/test_suite_exceptions.pyl
    • testing/buildbot/waterfalls.pyl
    • tools/mb/mb_config.pyl
  35. Fix crash that can occur when sharing temporary offline pages

    Changed by Pete Williamson - petewilohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:52:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9603793bf71d4fcce938bb0481dee2448cb5dc27

    Comments

    Fix crash that can occur when sharing temporary offline pages
    
    Sometimes when sharing temporary offline pages, we fail to create the
    content URI.  If we do, fall back to sharing by URL with the URL of the page.
    
    Bug: 871697
    Change-Id: Ie2e895fd708fdf4e5e992ebc2317ee49fd5bcee3
    Reviewed-on: https://chromium-review.googlesource.com/1168587
    Reviewed-by: Yafei Duan <romax@chromium.org>
    Commit-Queue: Peter Williamson <petewil@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582389}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
  36. [Unity][Android] Update margins in sign-in and consent bump screens

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:41:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fff9a68b5bd9965a4690f5d21104529adad34afc

    Comments

    [Unity][Android] Update margins in sign-in and consent bump screens
    
    This CL updates the layout of the streamlined sign-in screen and the
    consent bump screen to accommodate last changes to mocks.
    
    Bug: 814728
    Change-Id: If8f2cdaf39ba175ca60584f9015a4b2ccaf23217
    Reviewed-on: https://chromium-review.googlesource.com/1171226
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582388}

    Changed files

    • chrome/android/java/res/layout/consent_bump_more_options_view.xml
    • chrome/android/java/res/layout/signin_view.xml
    • chrome/android/java/res/values/dimens.xml
  37. Remove is_ready variables in PdfCompositorImplTest.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:41:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f2ae2bec992432aafcbcb760f7efe56aaa423f90

    Comments

    Remove is_ready variables in PdfCompositorImplTest.
    
    Change-Id: I3c0930f22e7ff3ff72611bfb70415b3e122f398e
    Reviewed-on: https://chromium-review.googlesource.com/1171378
    Reviewed-by: Wei Li <weili@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582387}

    Changed files

    • components/services/pdf_compositor/pdf_compositor_impl_unittest.cc
  38. [NTP] Fix arrow navigation order of the restore default options

    Changed by kristipark - kristiparkohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:37:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f7c77a5b154fdb9105958e026f285742b8cef125

    Comments

    [NTP] Fix arrow navigation order of the restore default options
    
    The "Restore default shortcuts" and "Restore default background" options
    are swapped when navigating with arrow keys.
    
    Bug: 872978
    Change-Id: I6078a6fb0a004a81e321a39f08e1f024bf53e9e1
    Reviewed-on: https://chromium-review.googlesource.com/1170195
    Commit-Queue: Kristi Park <kristipark@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582386}

    Changed files

    • chrome/browser/resources/local_ntp/custom_backgrounds.js
  39. [Explore Sites] Create a keyed service.

    Changed by Justin DeWitt - dewittjohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:32:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 40f76ee9d98b9b20c8fd7997786fa11e4352cee8

    Comments

    [Explore Sites] Create a keyed service.
    
    This will host the ExploreSites datastore as well as the downloader.
    
    BUG=867488
    
    Change-Id: Ifff84b6c8316033929ccbd52c32c2f175af117c8
    Reviewed-on: https://chromium-review.googlesource.com/1169588
    Reviewed-by: Cathy Li <chili@chromium.org>
    Commit-Queue: Justin DeWitt <dewittj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582385}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/android/explore_sites/explore_sites_service.h
    • chrome/browser/android/explore_sites/explore_sites_service_factory.cc
    • chrome/browser/android/explore_sites/explore_sites_service_factory.h
    • chrome/browser/android/explore_sites/explore_sites_service_impl.cc
    • chrome/browser/android/explore_sites/explore_sites_service_impl.h
  40. Fix misspelling "existance"

    Changed by Wei-Yin Chen (陳威尹) - wychenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:31:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fec2acecd6a5c82ae15b48fca7d1aa14de1650f4

    Comments

    Fix misspelling "existance"
    
    third_party/ is excluded, except for third_party/WebKit and
    third_party/blink.
    
    This is uncovered by:
    https://chromium-swarm.appspot.com/task?id=3f2afb7b4290f910
    
    Bug: None
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ie17ea50e7f6aba3538acb488df92b4926b52f4c4
    Reviewed-on: https://chromium-review.googlesource.com/1170441
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582384}

    Changed files

    • .gn
    • cc/layers/texture_layer_impl.h
    • cc/trees/layer_tree_settings.h
    • components/metrics/persistent_system_profile.h
    • ios/chrome/browser/ui/browser_view_controller.mm
    • third_party/WebKit/LayoutTests/external/wpt/user-timing/measure.html
    • third_party/WebKit/LayoutTests/external/wpt/user-timing/measure_navigation_timing.html
    • third_party/WebKit/LayoutTests/http/tests/devtools/extensions/multiple-extensions-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/devtools/extensions/multiple-extensions.js
    • third_party/WebKit/LayoutTests/jquery/resources/test/unit/traversing.js
    • third_party/blink/renderer/modules/webdatabase/sqlite/sqlite_file_system_posix.cc
    • third_party/blink/renderer/modules/webdatabase/sqlite/sqlite_file_system_win.cc
    • third_party/blink/renderer/modules/xr/xr_device.cc
    • tools/chrome_proxy/webdriver/protocol_fuzz.py
  41. [ios] Add accessibility identifier for "show history" cell in Recent Tabs

    Changed by Chris Lu - thegreenfrogohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:30:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2bef755ef86d5e4e225a5f70a58858a9078e095f

    Comments

    [ios] Add accessibility identifier for "show history" cell in Recent Tabs
    
    Change-Id: Ib6bcee51114a9fcb05aacd9079d52b65356e18d2
    Reviewed-on: https://chromium-review.googlesource.com/1171680
    Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
    Reviewed-by: Sergio Collazos <sczs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582383}

    Changed files

    • ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_constants.h
    • ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_constants.mm
    • ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm
    • ios/chrome/browser/ui/table_view/cells/table_view_accessory_item.h
    • ios/chrome/browser/ui/table_view/cells/table_view_accessory_item.mm
  42. Roll src/third_party/pdfium e1a7e8589a8c..f36a4644b828 (7 commits)

    Changed by pdfium-chromium-autoroll - pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Friday, 10-Aug-18 23:29:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision afe7c7414699ca66dbf49b162ab2c49083889a4d

    Comments

    Roll src/third_party/pdfium e1a7e8589a8c..f36a4644b828 (7 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/e1a7e8589a8c..f36a4644b828
    
    
    git log e1a7e8589a8c..f36a4644b828 --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 rharrison@chromium.org Remove direct calls to time
    2018-08-10 rharrison@chromium.org Add proxy for syscall time
    2018-08-10 tsepez@chromium.org Remove |typedef struct| in favor of just |struct|.
    2018-08-10 tsepez@chromium.org Consolidate const_casts<> in FXFT_Get_Name_Index()
    2018-08-10 thestig@chromium.org Make CFX_ImageTransformer::CalcData's bitmap non-const.
    2018-08-10 thestig@chromium.org Fix a JBIG2 decoding regression.
    2018-08-10 thestig@chromium.org Remove deprecated flags from fpdf_progressive.h.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@f36a4644b828
    
    The AutoRoll server is located here: https://pdfium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:871848
    TBR=dsinclair@chromium.org
    
    Change-Id: I22721ff61265f49fddd6ffc647ef37cc2f70bc0c
    Reviewed-on: https://chromium-review.googlesource.com/1171442
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582382}

    Changed files

    • DEPS
  43. Increase shards for android buildbot

    Changed by Takuto Ikuta - tikutaohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:26:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 091a32d416d74d48bcaec9693c0ae2589bc2b986

    Comments

    Increase shards for android buildbot
    
    I increased shards for some tests took time on
    https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel/59189
    
    Bug: 868114
    Change-Id: I9ae5c80e0fe641f8946e0d00d8a322721d2de079
    Reviewed-on: https://chromium-review.googlesource.com/1170922
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582381}

    Changed files

    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/test_suites.pyl
  44. Replaced calls to LayoutObject.Style() with LayoutObject.StyleRef().

    Changed by Mason Freed - masonfreedohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 23:14:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 95e719856c142dd807b287f535e3a597c3112e5e

    Comments

    Replaced calls to LayoutObject.Style() with LayoutObject.StyleRef().
    
    Especially within paint, most calls to LayoutObject.Style() are assuming a non-null pointer and
    dereferencing it. To better document the fact that these calls (properly, in most cases)
    assume the layout object contains style, they should be replaced with calls to the StyleRef()
    function, which dereferences the pointer.
    
    Bug: 872508
    Change-Id: Id6a04871c12a2c09d1029ca5aa04ae49099f7fd0
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Reviewed-on: https://chromium-review.googlesource.com/1171144
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Commit-Queue: Mason Freed <masonfreed@google.com>
    Cr-Commit-Position: refs/heads/master@{#582380}

    Changed files

    • third_party/blink/renderer/core/paint/block_painter.cc
    • third_party/blink/renderer/core/paint/box_painter.cc
    • third_party/blink/renderer/core/paint/collapsed_border_painter.cc
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
    • third_party/blink/renderer/core/paint/compositing/compositing_layer_assigner.cc
    • third_party/blink/renderer/core/paint/compositing/compositing_reason_finder.cc
    • third_party/blink/renderer/core/paint/compositing/compositing_requirements_updater.cc
    • third_party/blink/renderer/core/paint/css_mask_painter.cc
    • third_party/blink/renderer/core/paint/details_marker_painter.cc
    • third_party/blink/renderer/core/paint/fieldset_painter.cc
    • third_party/blink/renderer/core/paint/file_upload_control_painter.cc
    • third_party/blink/renderer/core/paint/inline_flow_box_painter.cc
    • third_party/blink/renderer/core/paint/inline_text_box_painter.cc
    • third_party/blink/renderer/core/paint/link_highlight_impl.cc
    • third_party/blink/renderer/core/paint/list_marker_painter.cc
    • third_party/blink/renderer/core/paint/multi_column_set_painter.cc
    • third_party/blink/renderer/core/paint/paint_layer.cc
    • third_party/blink/renderer/core/paint/paint_layer.h
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • third_party/blink/renderer/core/paint/replaced_painter.cc
    • third_party/blink/renderer/core/paint/root_inline_box_painter.cc
    • third_party/blink/renderer/core/paint/scrollable_area_painter.cc
    • third_party/blink/renderer/core/paint/svg_image_painter.cc
    • third_party/blink/renderer/core/paint/svg_inline_text_box_painter.cc
    • third_party/blink/renderer/core/paint/svg_model_object_painter.cc
    • third_party/blink/renderer/core/paint/svg_shape_painter.cc
    • third_party/blink/renderer/core/paint/table_cell_painter.cc
    • third_party/blink/renderer/core/paint/table_painter.cc
    • third_party/blink/renderer/core/paint/view_painter.cc
  45. Retire SampleOrderingSpec::PRESERVE_ORDER as it's not used

    Changed by Xi Cheng - chengxohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:13:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fea7ed541cd675d0ac5d17b2f8fcd6ac82edcffc

    Comments

    Retire SampleOrderingSpec::PRESERVE_ORDER as it's not used
    
    Since SampleOrderingSpec::MAY_SHUFFLE is the only one used in production
    code, there is no need to specify the SampleOrderingSpec parameter hence
    SampleOrderingSpec enum is also retired.
    
    Bug: 851163
    Change-Id: Ie9bf7c39d036db55b1533c4fe3b3f3293a2a8dbf
    Reviewed-on: https://chromium-review.googlesource.com/1171584
    Commit-Queue: Xi Cheng <chengx@chromium.org>
    Reviewed-by: Mike Wittman <wittman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582379}

    Changed files

    • chrome/common/thread_profiler.cc
    • components/metrics/call_stack_profile_builder.cc
    • components/metrics/call_stack_profile_builder_unittest.cc
    • components/metrics/call_stack_profile_params.h
    • components/metrics/call_stack_profile_proto_encoder.cc
    • components/metrics/call_stack_profile_proto_encoder.h
    • components/metrics/call_stack_profile_proto_encoder_unittest.cc
  46. CATransactionGPUCoordinator: Re-enable and make lifetime explicit

    Changed by Christopher Cameron - ccameronohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:10:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 62892558b716d1560264e42929e2be01ead07e71

    Comments

    CATransactionGPUCoordinator: Re-enable and make lifetime explicit
    
    Disalbing the CATransactionGPUCoordinator caused memory corruption bugs
    to go away.
    
    Fix two potential bugs:
    
    1.  Don't post tasks (and potentially change the reference count) inside
        CATransactionGPUCoordinator's constructor. Do this in a separate
        explicit Init function.
    
    1a. Move this initialization to the end of GpuProcessHost:Init (instead
        of being at the beginning of the constructor).
    
    2.  Make CATransactionCoordinator explicitly retain PostCommitObserver
        (which includes CATransactionGPUCoordinator). This fixes a bug
        whereby at shutdown, destroying not-yet-executed posted tasks caused
        the CATransactionGPUCoordinator to be destroyed while the
        CATransactionCoordinator still had a raw pointer to it.
    
    Bug: 871430
    Change-Id: Ie144071cce9ce48e0187cdaf1fcf32df7b62ed75
    Reviewed-on: https://chromium-review.googlesource.com/1171657
    Commit-Queue: ccameron <ccameron@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582378}

    Changed files

    • content/browser/gpu/ca_transaction_gpu_coordinator.cc
    • content/browser/gpu/ca_transaction_gpu_coordinator.h
    • content/browser/gpu/gpu_process_host.cc
    • ui/accelerated_widget_mac/ca_transaction_observer.h
    • ui/accelerated_widget_mac/ca_transaction_observer.mm
  47. [TTS] Remove unused DEPS file.

    Changed by Donn Denman - donndohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:57:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b54b3b3f4c92fac9a597039d7026120e4769a5d4

    Comments

    [TTS] Remove unused DEPS file.
    
    Change-Id: I100542f77eb1ebebf28db6c716733467be61c209
    Reviewed-on: https://chromium-review.googlesource.com/1168503
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Donn Denman <donnd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582377}

    Changed files

    • components/contextual_search/browser/DEPS
  48. Fix a typo in documentation.

    Changed by Eric Roman - eromanohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:56:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c3c53b6d5652202ab79edad721a4a04fb0ccb79

    Comments

    Fix a typo in documentation.
    
    Change-Id: Ibbde1b31fdeade51caf0cb70fefbe915bd7a9af6
    Reviewed-on: https://chromium-review.googlesource.com/1169693
    Commit-Queue: Eric Roman <eroman@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582376}

    Changed files

    • mojo/public/cpp/bindings/callback_helpers.h
  49. Increase DevTools SystemInfoGPU timeout for Windows.

    Changed by Erik Chen - erikchenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:55:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1c9cf51bc70b424ce8d9849d24c115a7f6930772

    Comments

    Increase DevTools SystemInfoGPU timeout for Windows.
    
    Before this CL, DevTools would crash the browser if it did not get a response in
    5 seconds. This timeout is too low for Windows. On Catapult perf tests on
    Windows, it takes ~3 seconds for the GPU process to respond on average, and
    sometimes it takes more than 5 seconds.
    
    Bug: 873112
    Change-Id: I67ee82a1a75df0ba9e1b483a58c66c56a8bf2213
    Reviewed-on: https://chromium-review.googlesource.com/1170584
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582375}

    Changed files

    • content/browser/devtools/protocol/system_info_handler.cc
  50. cros: Add common fingerprint images in ui/chromeos/resources.

    Changed by Sarah Hu - xiaoyinhohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:49:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ccd841a0bbf56f3ddc4ebfbf2430404da75a86f

    Comments

    cros: Add common fingerprint images in ui/chromeos/resources.
    
    This will be used by both oobe and settings.
    
    Bug: 873229
    Change-Id: I1bb3ff8e9666e967ff5445d68085801d009894d5
    Reviewed-on: https://chromium-review.googlesource.com/1171243
    Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
    Reviewed-by: Dan Erat <derat@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582374}

    Changed files

    • ui/chromeos/resources/default_100_percent/fingerprint/fingerprint.png
    • ui/chromeos/resources/default_100_percent/fingerprint/fingerprint_scanner.png
    • ui/chromeos/resources/default_100_percent/fingerprint/tick.png
    • ui/chromeos/resources/default_200_percent/fingerprint/fingerprint.png
    • ui/chromeos/resources/default_200_percent/fingerprint/fingerprint_scanner.png
    • ui/chromeos/resources/default_200_percent/fingerprint/tick.png
    • ui/chromeos/resources/ui_chromeos_resources.grd
  51. [TaskScheduler] Cleanup all remaining base/task_scheduler references for realz

    Changed by Gabriel Charette - gabohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:48:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6bf388aef924443453385373971d022f03652981

    Comments

    [TaskScheduler] Cleanup all remaining base/task_scheduler references for realz
    
    https://cs.chromium.org/search/?q=%22base/task_scheduler%22&sq=package:chromium&type=cs
    will be empty after this CL
    
    TBR=fdoray@chromium.org
    
    Change-Id: I636ff813e461379acfb2822f58034cdd756e7d49
    Reviewed-on: https://chromium-review.googlesource.com/1171108
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Reviewed-by: Robert Liao <robliao@chromium.org>
    Reviewed-by: François Doray <fdoray@chromium.org>
    Commit-Queue: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582373}

    Changed files

    • WATCHLISTS
    • base/task/task_scheduler/task_scheduler.h
  52. [omnibox/drive] Updates for /v1beta -> /v1 api migration.

    Changed by Travis Skare - skareohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:48:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cf7e0b53900f489bcfb7bd7db7b356cfb31d2e5

    Comments

    [omnibox/drive] Updates for /v1beta -> /v1 api migration.
    
    -Use originalURL if provided to dedupe against history.
    -Fix "typo" for corpus restrict request param (I missed it was renamed).
    -Sanitize title, provide default match data.
    
    Bug: 873290
    Change-Id: Idc2d0dd92a6afedc7086c283fe85bb4257a800d3
    Reviewed-on: https://chromium-review.googlesource.com/1171550
    Reviewed-by: Tommy Li <tommycli@chromium.org>
    Commit-Queue: Travis Skare <skare@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582372}

    Changed files

    • components/omnibox/browser/document_provider.cc
    • components/omnibox/browser/document_suggestions_service.cc
  53. [Cast discovery] Reset device lister on ForceDiscovery / user gesture.

    Changed by Derek Cheng - imchengohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:47:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 485629bea392f67ff70fcbed5007f2f91b171737

    Comments

    [Cast discovery] Reset device lister on ForceDiscovery / user gesture.
    
    We've seen cases where Cast discovery code fails to pick up services
    from the ServiceDiscoveryDeviceLister, whereas chrome://inspect
    (CastDeviceProvider) is able to do so. Since Cast discovery's
    ServiceDiscoveryDeviceLister is only created once and is long-lived,
    this suggests it has gone into a bad state after a prolonged period.
    Compared to the CastDeviceProvider's ServiceDiscoveryDeviceLister,
    which gets created/destroyed when the inspect page is loaded/unloaded.
    
    To mitigate this issue, this patch uses the ForceDiscovery() signal to
    recreate a new ServiceDiscoveryDeviceLister in DnsSdDeviceLister
    and kick off the discovery using the new object, and to clear the set
    of services in the cache. This puts DnsSdDeviceLister in a clean state
    which will the current set of services to get through to the Cast
    discovery code.
    
    Bug: 850770
    Change-Id: I3183e9d80f1a4a047b607fe5f844cdfc892f1463
    Reviewed-on: https://chromium-review.googlesource.com/1166022
    Commit-Queue: Derek Cheng <imcheng@chromium.org>
    Reviewed-by: mark a. foltz <mfoltz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582371}

    Changed files

    • chrome/browser/extensions/api/mdns/mdns_api.cc
    • chrome/browser/extensions/api/mdns/mdns_apitest.cc
    • chrome/browser/media/router/discovery/mdns/cast_media_sink_service.cc
    • chrome/browser/media/router/discovery/mdns/cast_media_sink_service_unittest.cc
    • chrome/browser/media/router/discovery/mdns/dns_sd_device_lister.cc
    • chrome/browser/media/router/discovery/mdns/dns_sd_device_lister.h
    • chrome/browser/media/router/discovery/mdns/dns_sd_registry.cc
    • chrome/browser/media/router/discovery/mdns/dns_sd_registry.h
    • chrome/browser/media/router/discovery/mdns/dns_sd_registry_unittest.cc
    • chrome/browser/media/router/test/mock_dns_sd_registry.h
  54. assistant: fix unitialized read

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:46:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 492cb6c0acd8a7714cd8d298d8d8bd83e65edc5d

    Comments

    assistant: fix unitialized read
    
    VisibilityChanged() tests the is_visible_ member before it's been set to any
    value.
    
    BUG=none
    TEST=none
    TBR=xiaohuic@chromium.org
    
    Change-Id: Ic2e95e1f5e615f1621431ab0bd2b8126bcfb87d2
    Reviewed-on: https://chromium-review.googlesource.com/1171553
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582370}

    Changed files

    • ash/assistant/ui/main_stage/assistant_progress_indicator.h
  55. fido/mac: look up credential IDs before proceeding with GetAssertion requests

    Changed by Martin Kreichgauer - martinkrohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 22:46:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a4ac527a4777da75ba6c44ed4a7e1837ed92693d

    Comments

    fido/mac: look up credential IDs before proceeding with GetAssertion requests
    
    This changes the GetAssertion operation for the Touch ID authenticator
    to locate credential IDs in the keychain at the beginning of the
    request. If no matching credential exists, the user is not prompted for
    a fingerprint. A method to locate a credential by ID is extracted from
    the existing code and moved into the Keychain class.
    
    This is done in anticipation of adding the WebAuthn UI. With the new UI,
    GetAssertion requests will only be sent to the Touch ID authenticator,
    if we know a matching credential ID to exist in the keychain.
    
    Bug: 871370
    
    Change-Id: Ie5e4916df2a68bc0e9d7552322d6b993069ce95b
    Reviewed-on: https://chromium-review.googlesource.com/1163927
    Commit-Queue: Martin Kreichgauer <martinkr@google.com>
    Reviewed-by: Balazs Engedy <engedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582369}

    Changed files

    • device/fido/mac/get_assertion_operation.h
    • device/fido/mac/get_assertion_operation.mm
    • device/fido/mac/keychain.h
    • device/fido/mac/keychain.mm
    • device/fido/mac/operation_base.h
  56. Android: Update Android Studio canary version

    Changed by Peter Wen - wnwenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:45:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31634c4f1eae7d2fbac13a7542a0c939417d62f4

    Comments

    Android: Update Android Studio canary version
    
    Bug: 620034
    Change-Id: I33a4437e3fe54f9b7d7ce234a823d4bb05c2046b
    Reviewed-on: https://chromium-review.googlesource.com/1169425
    Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
    Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582368}

    Changed files

    • build/android/gradle/root.jinja
  57. cc: Increase layer tree test timeout for CFI

    Changed by Adrienne Walker - enneohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:44:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d3df98f1195e5772ddbb2e369527e7fa3a920ce9

    Comments

    cc: Increase layer tree test timeout for CFI
    
    Also, generally increase the timeout for layer tree tests.  Most things
    don't need this, however the GL versions of pixel tests end up spending
    quite a bit of time to compile shaders.  When run in parallel, this
    only exacerbates the problem and tests can time out.  Be more generous
    so that folks stop turning off these tests.
    
    Bug: 872733
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I7c08212d454bf0d9ae6ea445fcb46b48b73aea88
    Reviewed-on: https://chromium-review.googlesource.com/1171377
    Reviewed-by: weiliangc <weiliangc@chromium.org>
    Commit-Queue: enne <enne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582367}

    Changed files

    • cc/test/layer_tree_test.cc
  58. Disable failing test (FLAKY_ has no meaning)

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:43:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b6a32c22de15bea00ed58fa55fdeafdb91767f6

    Comments

    Disable failing test (FLAKY_ has no meaning)
    
    Bug: 871812
    Change-Id: I0e4ee3e6539a6e4fa6c48495782a75a74a71dbc3
    TBR: mgiuca
    Reviewed-on: https://chromium-review.googlesource.com/1171681
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582366}

    Changed files

    • third_party/blink/renderer/core/css/font_face_cache_test.cc
  59. [CRD iOS] Using the new audio playback logic

    Changed by Yuwei Huang - yuweihohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:43:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b1e640c47e6cb75a8385ebba2e2aa31aeba732bf

    Comments

    [CRD iOS] Using the new audio playback logic
    
    This CL finishes up the rest of the work of refactoring the audio
    playback logic on iOS.
    
    Bug: 868088
    Change-Id: Iac4c240a8f98a1212bf65c056546f2f3ad14dd2d
    Reviewed-on: https://chromium-review.googlesource.com/1166339
    Commit-Queue: Yuwei Huang <yuweih@chromium.org>
    Reviewed-by: Joe Downing <joedow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582365}

    Changed files

    • remoting/client/audio/BUILD.gn
    • remoting/client/audio/audio_playback_stream.cc
    • remoting/client/audio/audio_playback_stream.h
    • remoting/ios/session/remoting_client.mm
  60. Diable a flaky test on CrOS for the same reason as others on this bug.

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:42:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f8ac232aec054638f6bfd13c783ef7d7d32e48d6

    Comments

    Diable a flaky test on CrOS for the same reason as others on this bug.
    
    Bug: 870732
    Change-Id: I0c7c7a78d7acb2e96f0d0308a758a01059628aa7
    TBR: mgiuca
    Reviewed-on: https://chromium-review.googlesource.com/1171738
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582364}

    Changed files

    • chrome/browser/password_manager/password_manager_browsertest.cc
  61. Never show shortcuts in contextual menus on the Mac.

    Changed by Avi Drissman - aviohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:42:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3c50480db92fe1220814910400ace4683a4d438a

    Comments

    Never show shortcuts in contextual menus on the Mac.
    
    This is platform convention.
    
    BUG=869564
    TEST=as in bug
    
    Change-Id: I3a4dbec12c5047219f255694eb4251405422e8fe
    Reviewed-on: https://chromium-review.googlesource.com/1164307
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582363}

    Changed files

    • ui/base/cocoa/menu_controller.mm
  62. Fix suggestion chip too long issue

    Changed by Weidong Guo - weidonggohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:41:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e448af80c5ba070e15aa387564fc8708fab6edf8

    Comments

    Fix suggestion chip too long issue
    
    Changes:
    Make the suggestion chip text length no longer than 192dip.
    
    Bug: 872948
    Change-Id: I54bc24cfc5b0ecf50d05e8312413e72ca14276e9
    Reviewed-on: https://chromium-review.googlesource.com/1171676
    Commit-Queue: Weidong Guo <weidongg@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582362}

    Changed files

    • ash/app_list/views/suggestion_chip_view.cc
  63. ScopedMockClockOverride: Include <memory>

    Changed by Raphael Kubo da Costa - raphael.kubo.da.costaohnoyoudont@intel.com
    Changed at Friday, 10-Aug-18 22:35:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 51d6da99705952697ed233f6cf9e63e06438ca5d

    Comments

    ScopedMockClockOverride: Include <memory>
    
    IWYU: std::unique_ptr needs <memory>. This fixes the libstdc++ build:
    
        In file included from ../../base/test/scoped_mock_clock_override.cc:5:0:
        ../../base/test/scoped_mock_clock_override.h:39:8: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type
           std::unique_ptr<base::subtle::ScopedTimeClockOverrides> time_clock_overrides_;
                ^~~~~~~~~~
    
    Bug: 818294
    Change-Id: I3b92e51f2565b42869cf2400dd4d3654e112f0fb
    Reviewed-on: https://chromium-review.googlesource.com/1170837
    Reviewed-by: Charlie Andrews <charliea@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
    Cr-Commit-Position: refs/heads/master@{#582361}

    Changed files

    • base/test/scoped_mock_clock_override.h
  64. Add iframe support to the Captured Sites Automation Framework.

    Changed by Yiming Zhou - uwyimingohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 22:35:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 02345664549dc8febb3ed7c839ea98573cd709e8

    Comments

    Add iframe support to the Captured Sites Automation Framework.
    
    This change allows the Captured Sites Automation Framework to replay
    interactions on iframes. As part of this change, I switched the
    automation framework to trigger the autofill popup by clicking on an
    input field instead of pressing the 'DOWN' key, which does not work in
    automation on some iframes.
    
    Also included in this change is a fix I made to address the issue that
    calling 'ASSERT' inside a test function does not abort the test.
    
    Change-Id: I15b30f878f04cb3ee2935879c2da4c474442ab27
    Reviewed-on: https://chromium-review.googlesource.com/1161603
    Commit-Queue: Yiming Zhou <uwyiming@google.com>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582360}

    Changed files

    • chrome/browser/autofill/autofill_captured_sites_interactive_uitest.cc
    • chrome/browser/autofill/autofill_uitest.cc
    • chrome/browser/autofill/autofill_uitest.h
    • chrome/browser/autofill/captured_sites_test_utils.cc
    • chrome/browser/autofill/captured_sites_test_utils.h
    • chrome/test/data/autofill/captured_sites/amazon.test
    • chrome/test/data/autofill/captured_sites/apple.test
    • chrome/test/data/autofill/captured_sites/ebay.test
    • chrome/test/data/autofill/captured_sites/walmart.test
    • chrome/test/data/autofill/captured_sites/zappos.test
  65. Fix search for next time limit start.

    Changed by Henrique Grandinetti - hgrandinettiohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:28:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1765353f3e592cc34c422b6146c0f4b5c1dd0dee

    Comments

    Fix search for next time limit start.
    
    In some situations the next Time Window Limit was not calculated correctly, this
    caused the TimeLimitController to recalculate the time limit constantly.
    
    Bug: 873228
    Change-Id: I6b88792aa6849774778d85d8dea2695192acc172
    Reviewed-on: https://chromium-review.googlesource.com/1171114
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
    Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com>
    Cr-Commit-Position: refs/heads/master@{#582359}

    Changed files

    • chrome/browser/chromeos/child_accounts/usage_time_limit_processor.cc
    • chrome/browser/chromeos/child_accounts/usage_time_limit_processor_unittest.cc
  66. Reland "Android: moving MediaUrlResolver tasks to thread pool"

    Changed by Sam Maier - smaierohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:24:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e9102edc99321bd860523f03cfd63aa153738c9a

    Comments

    Reland "Android: moving MediaUrlResolver tasks to thread pool"
    
    This reverts commit 108f9e6cb07bdf3327b8b62e3ad43703b854662d.
    
    Reason for revert: Just re landing now that gerrit is OK
    
    Original change's description:
    > Revert "Android: moving MediaUrlResolver tasks to thread pool"
    > 
    > This reverts commit d20f6cb34484fbd5e7ca2c651974d71c62e2f4d0.
    > 
    > Reason for revert:Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience.
    > 
    > Original change's description:
    > > Android: moving MediaUrlResolver tasks to thread pool
    > > 
    > > Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This
    > > exector is good for preventing concurrency errors since it guarantees
    > > serial execution, but bad for performance since the entire app shares
    > > this single queue.
    > > 
    > > It looks like this callsite can use the THREAD_POOL_EXECUTOR instead,
    > > since this use doesn't appear to rely on the concurrency guarantees that
    > > SERIAL_EXECUTOR provides.
    > > 
    > > TBR= test file
    > > Bug: 869907
    > > Change-Id: I5770f3f0211d2c10b28f2290973bbfd57bee53f0
    > > Reviewed-on: https://chromium-review.googlesource.com/1159236
    > > Commit-Queue: Sam Maier <smaier@chromium.org>
    > > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    > 
    > TBR=mlamouri@chromium.org,smaier@chromium.org
    > 
    > Change-Id: I5cd823a033bb6443007734d4faf0e1ddf98de648
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 869907
    > Reviewed-on: https://chromium-review.googlesource.com/1169854
    > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
    
    TBR=mlamouri@chromium.org,tandrii@chromium.org,smaier@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 869907
    Change-Id: I31b02f5b543f2fdb8b0b089f241d79ceb720a626
    Reviewed-on: https://chromium-review.googlesource.com/1171702
    Commit-Queue: Sam Maier <smaier@chromium.org>
    Reviewed-by: Sam Maier <smaier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582358}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java
    • chrome/android/junit/src/org/chromium/chrome/browser/media/remote/MediaUrlResolverTest.java
  67. [ChromeDriver] Fix location of browser snapshots

    Changed by John Chen - johnchenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:17:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 46fa89282e8f5cbffee0c90f32dc3d1d998edc54

    Comments

    [ChromeDriver] Fix location of browser snapshots
    
    TBR=crouleau@chromium.org
    
    Change-Id: Id77c7546989bed6f3fdb269abdc2bc2e976ca4cd
    Reviewed-on: https://chromium-review.googlesource.com/1171679
    Reviewed-by: John Chen <johnchen@chromium.org>
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Commit-Queue: John Chen <johnchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582357}

    Changed files

    • chrome/test/chromedriver/archive.py
  68. Web Locks API: Update spec/explainer/idl links

    Changed by Joshua Bell - jsbellohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:12:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision beaa8766c0bea15820663d2881ad782c0c99eddb

    Comments

    Web Locks API: Update spec/explainer/idl links
    
    Spec work has moved into the WICG repository, so update links:
    
    Explainer: https://github.com/WICG/web-locks/
    Spec: https://wicg.github.io/web-locks/
    
    Bug: 161072
    Change-Id: I450beb25d8a7c9c0a80b06b7e84d7ac8db3cece1
    Reviewed-on: https://chromium-review.googlesource.com/1171213
    Commit-Queue: Victor Costan <pwnall@chromium.org>
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Reviewed-by: Victor Costan <pwnall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582356}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/web-locks/META.yml
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/README.md
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/acquire.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/clientids.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/frames.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/held.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/ifAvailable.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/interfaces-serviceworker.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/lock-attributes.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/mode-exclusive.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/mode-mixed.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/mode-shared.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/non-secure-context.tentative.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/opaque-origin.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/query-empty.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/query-order.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/query.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/resource-names.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/secure-context.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/signal.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/steal.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/workers.tentative.https.html
    • third_party/blink/renderer/modules/locks/lock.idl
    • third_party/blink/renderer/modules/locks/lock_info.idl
    • third_party/blink/renderer/modules/locks/lock_manager.idl
    • third_party/blink/renderer/modules/locks/lock_manager_snapshot.idl
    • third_party/blink/renderer/modules/locks/lock_options.idl
    • third_party/blink/renderer/modules/locks/navigator_locks.idl
    • third_party/blink/renderer/modules/locks/worker_navigator_locks.idl
  69. Revert "cros: In OOBE, turn off scrolling if the screen fits in the container"

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:12:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c86f4a25a967715e1b357d2519a3b5fa75606fa5

    Comments

    Revert "cros: In OOBE, turn off scrolling if the screen fits in the container"
    
    This reverts commit 3963b98df61fe488ddbd007ac5933cf62beff0df.
    
    Reason for revert: Consistent failures in ProfileWindowWebUIBrowserTest.UserManagerFocusSingleProfile, see e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20%2832%29%20Tests/36834
    
    Original change's description:
    > cros: In OOBE, turn off scrolling if the screen fits in the container
    > 
    > Bug: 855546
    > Change-Id: I065c2bbd1e3db69dca3f8b18d40ce5beb09f9abd
    > Reviewed-on: https://chromium-review.googlesource.com/1162715
    > Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    > Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#582312}
    
    TBR=alemate@chromium.org,jdufault@chromium.org,qnnguyen@chromium.org
    
    Change-Id: Icd9a6648582e8c49bcdbd4bd79d844745d54c2a9
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 855546
    Reviewed-on: https://chromium-review.googlesource.com/1171703
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582355}

    Changed files

    • ui/login/display_manager.js
  70. Remove has_received_pointer_over state in PEM

    Changed by Navid Zolghadr - nzolghadrohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:08:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0791976d2925f80203afb4a3248033c7a3a6e2de

    Comments

    Remove has_received_pointer_over state in PEM
    
    We used to store whether the target of pointerevent
    has recieved pointerover event or not to handle this
    correctly when capture gets active or lost. But since
    then the spec has change which made this state
    unnecessary.
    
    Change-Id: I98eed286b47463d2e103495ec66750d01e3fe58b
    Reviewed-on: https://chromium-review.googlesource.com/1169918
    Reviewed-by: Ella Ge <eirage@chromium.org>
    Reviewed-by: David Bokan <bokan@chromium.org>
    Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582354}

    Changed files

    • third_party/blink/renderer/core/input/pointer_event_manager.cc
    • third_party/blink/renderer/core/input/pointer_event_manager.h
  71. Handle avoid_stencil_buffers workaround in OOP-R

    Changed by Adrienne Walker - enneohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:04:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fa0603bbbdbe385af7d7a4654fa8ef1796b262a0

    Comments

    Handle avoid_stencil_buffers workaround in OOP-R
    
    This could be handled in Skia, but there's already a context option for
    it, so just forward the workaround setting to that.
    
    Bug: 829614
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Iaeb625ea327b814d07854dd81eb0458598a0c137
    Reviewed-on: https://chromium-review.googlesource.com/1169771
    Commit-Queue: enne <enne@chromium.org>
    Reviewed-by: Zhenyao Mo <zmo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582353}

    Changed files

    • gpu/command_buffer/service/raster_decoder_context_state.cc
  72. Reland "Android: moving FileEnumWorkerTask to thread pool"

    Changed by Sam Maier - smaierohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:56:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e1b5ee020fc4770291e328a91652f948f6b53206

    Comments

    Reland "Android: moving FileEnumWorkerTask to thread pool"
    
    This reverts commit c2af33f66d4079e4306fb698828d6d9d6d4fbe95.
    
    Reason for revert: Just re landing now that gerrit is OK
    
    Original change's description:
    > Revert "Android: moving FileEnumWorkerTask to thread pool"
    >
    > This reverts commit 5eb802f9e1b7c765f77ec4a61f7f448731c36811.
    >
    > Reason for revert: Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience.
    >
    > Original change's description:
    > > Android: moving FileEnumWorkerTask to thread pool
    > >
    > > Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This
    > > exector is good for preventing concurrency errors since it guarantees
    > > serial execution, but bad for performance since the entire app shares
    > > this single queue.
    > >
    > > It looks like this callsite can use the THREAD_POOL_EXECUTOR instead,
    > > since this use doesn't appear to rely on the concurrency guarantees that
    > > SERIAL_EXECUTOR provides.
    > >
    > > Bug: 869907
    > > Change-Id: I266476c44f16ade391dfef0e5a99d33494312598
    > > Reviewed-on: https://chromium-review.googlesource.com/1161089
    > > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    > > Commit-Queue: Sam Maier <smaier@chromium.org>
    >
    > TBR=finnur@chromium.org,smaier@chromium.org
    >
    > Change-Id: I890bfff82b7471f54948c03dea7d2820224e978f
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 869907
    > Reviewed-on: https://chromium-review.googlesource.com/1169851
    > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
    > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
    
    TBR=finnur@chromium.org,tandrii@chromium.org,smaier@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    TBR=Gerrit reland
    
    Bug: 869907
    Change-Id: I4e07a7d43ae7f0af01a248f4c41d42699d041f30
    Reviewed-on: https://chromium-review.googlesource.com/1171427
    Reviewed-by: Sam Maier <smaier@chromium.org>
    Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
    Commit-Queue: Sam Maier <smaier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582352}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java
  73. Update build instructions to recommend using autoninja instead of ninja.

    Changed by Max Moroz - mmorozohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:55:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f5b31fcd43e0d557a4a641c434aecb760a6a4419

    Comments

    Update build instructions to recommend using autoninja instead of ninja.
    
    Change-Id: I327542d2ec81be8d3d4240a82f7121c27c4994b3
    Reviewed-on: https://chromium-review.googlesource.com/1169427
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Max Moroz <mmoroz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582351}

    Changed files

    • docs/accessibility/chromevox_on_desktop_linux.md
    • docs/accessibility/tests.md
    • docs/android_build_instructions.md
    • docs/code_coverage.md
    • docs/fuchsia_build_instructions.md
    • docs/how_to_add_your_feature_flag.md
    • docs/linux_build_instructions.md
    • docs/mac_build_instructions.md
    • docs/testing/layout_tests.md
    • docs/windows_build_instructions.md
  74. Browser Themes: always paint an opaque BG color behind toolbar images

    Changed by Evan Stade - estadeohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:51:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eeddc1fcb0a7897d31eadfddfbf621ce9e9bdaf2

    Comments

    Browser Themes: always paint an opaque BG color behind toolbar images
    
    for both the active tab and the toolbar. This matches the bookmarks
    bar, i.e. PaintBackgroundAttachedMode.
    
    Bug: 866974
    Change-Id: I3a86d2330bf09903f74359e433a4165e3e4d3e8e
    Reviewed-on: https://chromium-review.googlesource.com/1171216
    Commit-Queue: Evan Stade <estade@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582350}

    Changed files

    • chrome/browser/ui/views/tabs/tab.cc
    • chrome/browser/ui/views/toolbar/toolbar_view.cc
  75. Make cert transparency histogram work with the NetworkService.

    Changed by Matt Menke - mmenkeohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:47:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d9cad56fca85981a14b10d32acd4e7039d0d368d

    Comments

    Make cert transparency histogram work with the NetworkService.
    
    In particular, move Net.CertificateTransparency.MainFrameValidSCTCount
    from ResourceDispatcherHost to NavigationURLLoaderImpl.
    
    Bug: 859364
    Change-Id: I2258fc36af30b64b76eb7c5bc2c1f9851bb0f1be
    Reviewed-on: https://chromium-review.googlesource.com/1168093
    Commit-Queue: Matt Menke <mmenke@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582349}

    Changed files

    • content/browser/loader/navigation_url_loader_impl.cc
    • content/browser/loader/resource_dispatcher_host_impl.cc
  76. Uprev env version for rtanalytics-light to 5.0.

    Changed by Luke Sorenson - lasorenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:43:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bc2ecee4a37ac2fbe251c595b8403048319a5c79

    Comments

    Uprev env version for rtanalytics-light to 5.0.
    
    This is to reflect non-forwards / non-backwards compatible changes to
    the interface between rtanalytics_main and librtanalytics.so due to the
    changes to incorporate the use of the Mojo IPC-based video capture
    service.
    
    Bug: 871884
    Change-Id: I97c92be7143609026d34e824b29f524e1f386f11
    Reviewed-on: https://chromium-review.googlesource.com/1165824
    Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    Commit-Queue: Luke Sorenson <lasoren@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582348}

    Changed files

    • chrome/browser/component_updater/cros_component_installer_chromeos.cc
  77. [Chromecast] Backwards compatible AudioFocus

    Changed by shyam - shyamsundarpohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:43:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ccd3df3bec6871edb3531a8a239f5a44a5bb4290

    Comments

    [Chromecast] Backwards compatible AudioFocus
    
    Creating an abstraction called CastAudioFocusRequest to handle backwards
    compatibility of AudioFocus methods in AudioManager.
    
    Merge-With: eureka-internal/191659
    Bug: 112064938
    Test: junit test
    Change-Id: I914cec6a6bd2179f02ab5fd6959fcf3157b3e637
    Reviewed-on: https://chromium-review.googlesource.com/1165884
    Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
    Commit-Queue: Shyamsundar Parthasarathy <shyamsundarp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582347}

    Changed files

    • chromecast/browser/android/BUILD.gn
    • chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastAudioFocusRequest.java
    • chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastAudioManager.java
    • chromecast/browser/android/junit/src/org/chromium/chromecast/shell/CastAudioFocusRequestTest.java
    • chromecast/browser/android/junit/src/org/chromium/chromecast/shell/CastAudioManagerTest.java
  78. Adds use of SurfaceLayerBridge into WebMediaPlayerMS.

    Changed by CJ DiMeglio - lethalantidoteohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:41:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e6e258a17c67e59b03924353b6485f4e36ca612e

    Comments

    Adds use of SurfaceLayerBridge into WebMediaPlayerMS.
    
    This CL allows for WebMediaPlayerMS to create a SurfaceLayerBridge and
    interface with it in order to use a Surface for video playback.
    
    Bug: 746182
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I39174499a7e659eeeef13a81f8f5679d5f73425a
    Reviewed-on: https://chromium-review.googlesource.com/1087587
    Reviewed-by: Frank Liberato <liberato@chromium.org>
    Reviewed-by: Emircan Uysaler <emircan@chromium.org>
    Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582346}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • content/renderer/media/media_factory.cc
    • content/renderer/media/media_factory.h
    • content/renderer/media/stream/webmediaplayer_ms.cc
    • content/renderer/media/stream/webmediaplayer_ms.h
    • content/renderer/media/stream/webmediaplayer_ms_compositor.h
    • content/renderer/media/stream/webmediaplayer_ms_unittest.cc
    • media/base/media_switches.cc
    • media/base/media_switches.h
    • media/blink/webmediaplayer_impl.h
    • media/blink/webmediaplayer_params.cc
    • media/blink/webmediaplayer_params.h
    • tools/metrics/histograms/enums.xml
  79. Move BrowserPluginSpecific tests out of web_view_browsertest.cc

    Changed by Ehsan Karamad - ekaramadohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:39:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8eb68052e037952a13565c5545ca3fdc9dbac2b9

    Comments

    Move BrowserPluginSpecific tests out of web_view_browsertest.cc
    
    The WebViewBrowserPluginSpecificTest class includes tests which use a
    BrowserPluign-based GuestView. Since all GuestViews except MimeHandlerViewGuest
    are now based on cross-process frames, these tests should not be implemented as
    WebViewGuest tests anymore.
    
    This CL introduces a new chrome browser test target for such
    BrowserPluginSpecific tests where the tests instantiate a MimeHandlerViewGuest
    instead of a <webview>.
    
    Ideally, the tests should have lived with the rest of MimeHandlerViewTests in
    extension layer; however, due to chrome layer dependencies it is not possible.
    
    Bug: 659750, 533069, 330264, 870604
    Change-Id: Ica252a60e94bad47cabbff8b9275b8f9fb05d7ae
    Reviewed-on: https://chromium-review.googlesource.com/1168734
    Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
    Reviewed-by: James MacLean <wjmaclean@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582345}

    Changed files

    • chrome/browser/apps/guest_view/web_view_browsertest.cc
    • chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_browsertest.cc
    • chrome/test/BUILD.gn
    • chrome/test/data/extensions/api_test/mime_handler_view/index.js
  80. Disable debug fission under Fuchsia.

    Changed by Wez - wezohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:39:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f273ccbde526a7402e715821163d8349627bf56

    Comments

    Disable debug fission under Fuchsia.
    
    The symbolization in the Fuchsia runner scripts is not set up to work
    with debug information partly split from the binary.
    
    Bug: 777008
    Change-Id: Iedaf4fe56cc8092af21acfd0d244304982a6035c
    Reviewed-on: https://chromium-review.googlesource.com/1170440
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582344}

    Changed files

    • build/config/compiler/BUILD.gn
  81. Make ExecutionMode pretty-printer available for CHECK outside tests

    Changed by Joe Mason - joenotcharlesohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:34:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da2cbfa6d74f34482c227e4715bc0b03c3298f01

    Comments

    Make ExecutionMode pretty-printer available for CHECK outside tests
    
    R=proberge
    
    Bug: 872748
    Change-Id: I42ae9acf6bd189ef45543ddfa15521262c56b95f
    Reviewed-on: https://chromium-review.googlesource.com/1171549
    Reviewed-by: proberge <proberge@chromium.org>
    Commit-Queue: Joe Mason <joenotcharles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582343}

    Changed files

    • chrome/chrome_cleaner/logging/BUILD.gn
    • chrome/chrome_cleaner/settings/BUILD.gn
    • chrome/chrome_cleaner/test/BUILD.gn
    • chrome/test/BUILD.gn
    • components/chrome_cleaner/public/constants/BUILD.gn
    • components/chrome_cleaner/public/constants/constants.cc
    • components/chrome_cleaner/public/constants/constants.h
    • components/chrome_cleaner/public/constants/constants_test_support.cc
  82. Removed ExternalURLTabUsageRecorderTestCase

    Changed by Peter K. Lee - pklohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:32:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7f7fafa75c2080ef3a234472c8926be2ade8b04b

    Comments

    Removed ExternalURLTabUsageRecorderTestCase
    
    Removed ExternalURLTabUsageRecorderTestCase since it contains only one
    disabled Earl Grey test. After some evaluation of the intention of the
    test, it is not clear what purpose it serves/served or whether the code
    being tested isn't already covered by unit tests.
    
    Bug: 852341
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I988f4fc5512b40f331db565af2424e03b5c23b79
    Reviewed-on: https://chromium-review.googlesource.com/1171365
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Peter Lee <pkl@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582342}

    Changed files

    • ios/chrome/browser/metrics/BUILD.gn
    • ios/chrome/browser/metrics/external_url_tab_usage_recorder_egtest.mm
    • ios/chrome/test/earl_grey/BUILD.gn
  83. WATCHLISTS entry for GuestView

    Changed by Ehsan Karamad - ekaramadohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:32:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c20cee27cd645da5b90c992546aa2cb8ae52d8d1

    Comments

    WATCHLISTS entry for GuestView
    
    Adding an entry 'guest_view' for all GuestView related files.
    
    Subscribing myself, wjmaclean@, and mcnee@ to the list.
    
    Bug: None
    Change-Id: I7751b3cb6d8b3163cdc7f1a11342a56a9cd2849b
    Reviewed-on: https://chromium-review.googlesource.com/1171215
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582341}

    Changed files

    • WATCHLISTS
  84. Implement support for new blockquote, caption, and paragraph ARIA roles

    Changed by Joanmarie Diggs - jdiggsohnoyoudont@igalia.com
    Changed at Friday, 10-Aug-18 21:29:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6712c441cd35a71cdc79aff0d61eb817723b49a3

    Comments

    Implement support for new blockquote, caption, and paragraph ARIA roles
    
    These three roles are part of reaching role parity with HTML5. As such,
    they should be exposed via platform accessibility APIs in the same way
    as their native host language counterparts. Thus just add them to the
    map of ARIA roles to internal roles.
    
    Bug: 849650
    Change-Id: I9a513e187a5beccd57fc5c7306929b0fd194b6dd
    Reviewed-on: https://chromium-review.googlesource.com/1169476
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Reviewed-by: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582340}

    Changed files

    • content/browser/accessibility/browser_accessibility_cocoa.mm
    • content/browser/accessibility/dump_accessibility_tree_browsertest.cc
    • content/test/data/accessibility/aria/aria-blockquote-expected-android.txt
    • content/test/data/accessibility/aria/aria-blockquote-expected-auralinux.txt
    • content/test/data/accessibility/aria/aria-blockquote-expected-mac.txt
    • content/test/data/accessibility/aria/aria-blockquote-expected-win.txt
    • content/test/data/accessibility/aria/aria-blockquote.html
    • content/test/data/accessibility/aria/aria-caption-expected-android.txt
    • content/test/data/accessibility/aria/aria-caption-expected-auralinux.txt
    • content/test/data/accessibility/aria/aria-caption-expected-mac.txt
    • content/test/data/accessibility/aria/aria-caption-expected-win.txt
    • content/test/data/accessibility/aria/aria-caption.html
    • content/test/data/accessibility/aria/aria-paragraph-expected-android.txt
    • content/test/data/accessibility/aria/aria-paragraph-expected-auralinux.txt
    • content/test/data/accessibility/aria/aria-paragraph-expected-mac.txt
    • content/test/data/accessibility/aria/aria-paragraph-expected-win.txt
    • content/test/data/accessibility/aria/aria-paragraph.html
    • content/test/data/accessibility/html/blockquote-expected-auralinux.txt
    • content/test/data/accessibility/html/caption-expected-auralinux.txt
    • content/test/data/accessibility/html/p-expected-auralinux.txt
    • third_party/blink/renderer/modules/accessibility/ax_object.cc
  85. [layoutng] Store borders on fragments as well

    Changed by Christian Biesinger - cbiesingerohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:29:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3584222f068fd6c16e2203b8c845945b3aba8f05

    Comments

    [layoutng] Store borders on fragments as well
    
    This avoids recomputing them later.
    
    Also, changes RunOldLayout to use legacy layout to
    compute border/padding to store on the fragment,
    which seems more correct.
    
    R=eae@chromium.org
    
    Bug: 635619
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Id659d7c92eae81431d8e75a26ac3973421afc3d0
    Reviewed-on: https://chromium-review.googlesource.com/1169634
    Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582339}

    Changed files

    • third_party/blink/renderer/core/layout/ng/layout_ng_block_flow.cc
    • third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
    • third_party/blink/renderer/core/layout/ng/ng_block_node.cc
    • third_party/blink/renderer/core/layout/ng/ng_box_fragment.cc
    • third_party/blink/renderer/core/layout/ng/ng_box_fragment.h
    • third_party/blink/renderer/core/layout/ng/ng_column_layout_algorithm.cc
    • third_party/blink/renderer/core/layout/ng/ng_flex_layout_algorithm.cc
    • third_party/blink/renderer/core/layout/ng/ng_fragment_builder.cc
    • third_party/blink/renderer/core/layout/ng/ng_fragment_builder.h
    • third_party/blink/renderer/core/layout/ng/ng_page_layout_algorithm.cc
    • third_party/blink/renderer/core/layout/ng/ng_physical_box_fragment.cc
    • third_party/blink/renderer/core/layout/ng/ng_physical_box_fragment.h
  86. Revert "[ChromeDriver] Fix path for old Chromium snapshots"

    Changed by Stephen Martinis - martinissohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:24:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f5e8bf6941f0fb31103ad926e86729d45b276e01

    Comments

    Revert "[ChromeDriver] Fix path for old Chromium snapshots"
    
    This reverts commit 306be5bf43aee024bf3e91bd2fd3414020ecdb3b.
    
    Reason for revert: GS bucket names have been fixed
    
    Original change's description:
    > [ChromeDriver] Fix path for old Chromium snapshots
    > 
    > Chromium snapshots before revision 579575 are still archived using
    > the old directory name.
    > 
    > TBR=crouleau@chromium.org
    > 
    > Change-Id: I4cc1e9ca51af9f8f21e22214af2110a6d8be8fe7
    > Reviewed-on: https://chromium-review.googlesource.com/1158709
    > Reviewed-by: John Chen <johnchen@chromium.org>
    > Commit-Queue: John Chen <johnchen@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#579802}
    
    TBR=crouleau@chromium.org,johnchen@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Change-Id: I093548f1d0ef02a37ffd8d3d2fe66f7222234e1b
    Reviewed-on: https://chromium-review.googlesource.com/1171426
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Commit-Queue: Stephen Martinis <martiniss@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582338}

    Changed files

    • chrome/test/chromedriver/archive.py
  87. [PE] Stop dirtying compositing inputs on any layout for the root PaintLayer.

    Changed by Chris Harrelson - chrishtrohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:17:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 46520ae13478333fe882e79041b667e5a3112796

    Comments

    [PE] Stop dirtying compositing inputs on any layout for the root PaintLayer.
    
    Instead, dirty them on particular PaintLayers only when their layout changed.
    
    Bug: 410867
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Idf7664b869b1e7205e68adc075bcf828f279cffb
    Reviewed-on: https://chromium-review.googlesource.com/1168142
    Reviewed-by: vmpstr <vmpstr@chromium.org>
    Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582337}

    Changed files

    • third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.cc
    • third_party/blink/renderer/core/paint/paint_layer.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
  88. chromeos: Use Screen::GetDisplayForNewWindows in chrome/browser

    Changed by James Cook - jamescookohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:17:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7363ebc06d042af169ab640f33a3d4b985546000

    Comments

    chromeos: Use Screen::GetDisplayForNewWindows in chrome/browser
    
    display::Screen (and ScreenMus) now has the display for new windows,
    so we can use that when making new browser windows under both mash
    and classic ash. Likewise, we can use display::Screen (as ScreenAsh)
    for new windows inside of ash.
    
    This lets me remove ShellStateClient, a different mechanism that
    accomplishes the same goal in a less general way.
    
    Leave ash::ShellState for now. I will clean that up in a separate CL.
    
    TBR=tsepez@chromium.org
    
    Bug: 764009
    Test: existing browser_tests for browser frame/size
    Change-Id: I5c255dc2bf8fdd48f519f148d29aca3d37e7ae73
    Reviewed-on: https://chromium-review.googlesource.com/1168197
    Reviewed-by: James Cook <jamescook@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582336}

    Changed files

    • ash/display/screen_ash.cc
    • ash/display/screen_ash.h
    • ash/mojo_interface_factory.cc
    • ash/public/interfaces/BUILD.gn
    • ash/public/interfaces/shell_state.mojom
    • ash/shell_state.cc
    • ash/shell_state.h
    • ash/shell_state_unittest.cc
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc
    • chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.h
    • chrome/browser/ui/ash/launcher/crostini_app_display.cc
    • chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc
    • chrome/browser/ui/ash/shell_state_client.cc
    • chrome/browser/ui/ash/shell_state_client.h
    • chrome/browser/ui/ash/shell_state_client_unittest.cc
    • chrome/browser/ui/window_sizer/window_sizer.cc
    • chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc
    • chrome/test/BUILD.gn
    • ui/display/screen.cc
    • ui/display/screen.h
    • ui/views/mus/screen_mus.cc
    • ui/views/mus/screen_mus.h
  89. Remove obsolete dcheck in Assistant service

    Changed by Yue Li - updowndotaohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:16:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 07f5eb56f751c2ab177a66471742d3f10ee41bf8

    Comments

    Remove obsolete dcheck in Assistant service
    
    Bug: b/112447220
    Test: Manual Test
    Change-Id: Idcab08aca234f9f5528529aedb71fbbbdfa29d1d
    Reviewed-on: https://chromium-review.googlesource.com/1171551
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: Yue Li <updowndota@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582335}

    Changed files

    • chromeos/services/assistant/service.cc
  90. [DOMStorage] blink::CachedStorageArea for onion souping

    Changed by Daniel Murphy - dmurphohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:16:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1571d750d7217703d89c44562678eddde611ad50

    Comments

    [DOMStorage] blink::CachedStorageArea for onion souping
    
    As part of onion souping domstorage this adds a couple of new classes
    to blink more or less duplicating the content equivalents:
    
    CachedStorageArea matches content::LocalStorageCachedArea (with some
    minor API changes, in particular around how it acquires a mojom
    StorageArea). Also has improved test coverage compared to the content
    version.
    
    MockStorageArea is very similar to content::MockLevelDBWrapper (with
    the difference that it doesn't implement StoragePartitionService since
    it doesn't need to with the changed API of CachedStorageArea).
    
    Bug: 781870
    Change-Id: Ic64b3bf307fe275d9287669743f186c8470847bb
    Reviewed-on: https://chromium-review.googlesource.com/1166218
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
    Commit-Queue: Daniel Murphy <dmurph@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582334}

    Changed files

    • third_party/blink/public/mojom/dom_storage/storage_area.mojom
    • third_party/blink/renderer/modules/DEPS
    • third_party/blink/renderer/modules/storage/BUILD.gn
    • third_party/blink/renderer/modules/storage/cached_storage_area.cc
    • third_party/blink/renderer/modules/storage/cached_storage_area.h
    • third_party/blink/renderer/modules/storage/cached_storage_area_test.cc
    • third_party/blink/renderer/modules/storage/testing/fake_area_source.h
    • third_party/blink/renderer/modules/storage/testing/mock_storage_area.cc
    • third_party/blink/renderer/modules/storage/testing/mock_storage_area.h
  91. Ash: Port two browser frame tests to Ash.

    Changed by Evan Stade - estadeohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:14:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d30a68227a635fb7ab0f3a98f7280ed0ce189503

    Comments

    Ash: Port two browser frame tests to Ash.
    
    One of them lives on in browser because the Ash version trips a dcheck
    when run in classic Ash mode.
    
    Bug: 854704
    Change-Id: I7822cc088c255b8c16c91cb1b5304c5e2b974115
    Reviewed-on: https://chromium-review.googlesource.com/1170127
    Commit-Queue: Evan Stade <estade@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582333}

    Changed files

    • ash/frame/non_client_frame_view_ash.h
    • ash/frame/non_client_frame_view_ash_unittest.cc
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
    • testing/buildbot/filters/mash.browser_tests.filter
  92. Update watchlist for chasej

    Changed by Jason Chase - chasejohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:07:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dfcd02b9e85ff1aedd636cd9c3dd73fa7cb2612c

    Comments

    Update watchlist for chasej
    
    Remove chasej from background_sync and tweak inclusions for
    origin_trials.
    
    Change-Id: Ie3f19642c491d791f5681ca92e15b34002b51d2e
    Reviewed-on: https://chromium-review.googlesource.com/1171563
    Reviewed-by: Ian Clelland <iclelland@chromium.org>
    Commit-Queue: Jason Chase <chasej@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582332}

    Changed files

    • WATCHLISTS
  93. Add a function to ServiceWorkerContextWrapper which starts a service worker and keeps it alive indefinitely.

    Changed by Jon Mann - jonmannohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:05:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b528b403f16d6a2e3f86605ce9974ae63b7d9cad

    Comments

    Add a function to ServiceWorkerContextWrapper which starts a service worker and keeps it alive indefinitely.
    
    This is only for use in ChromeOS for the Android Web Messages native integration.
    
    Change-Id: Id2357f54078c12db0ad25cd9fe0622d57e34a064
    Bug: 850823
    Reviewed-on: https://chromium-review.googlesource.com/1119580
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Steven Holte <holte@chromium.org>
    Commit-Queue: Jon Mann <jonmann@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582331}

    Changed files

    • chrome/browser/chrome_service_worker_browsertest.cc
    • content/browser/service_worker/embedded_worker_instance.cc
    • content/browser/service_worker/embedded_worker_registry.cc
    • content/browser/service_worker/embedded_worker_registry.h
    • content/browser/service_worker/embedded_worker_test_helper.cc
    • content/browser/service_worker/service_worker_context_wrapper.cc
    • content/browser/service_worker/service_worker_context_wrapper.h
    • content/browser/service_worker/service_worker_metrics.cc
    • content/browser/service_worker/service_worker_metrics.h
    • content/browser/service_worker/service_worker_version.cc
    • content/common/service_worker/service_worker.mojom
    • content/public/browser/service_worker_context.h
    • content/public/test/fake_service_worker_context.cc
    • content/public/test/fake_service_worker_context.h
    • content/renderer/service_worker/service_worker_context_client.cc
    • content/renderer/service_worker/service_worker_context_client.h
    • tools/metrics/histograms/histograms.xml
  94. No longer explicitly initialize a CertVerifier in Cronet

    Changed by Ryan Sleevi - rsleeviohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:02:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5d77f2b5485304ef6f4a8b6bba175fbb801da011

    Comments

    No longer explicitly initialize a CertVerifier in Cronet
    
    Support for file-based persistence was removed in r571588,
    so its no longer necessary for Cronet to explicitly create
    a CertVerifier to guarantee it is a CachingCertVerifier.
    
    Bug: 590875
    Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I23e9e6db12225a7474ce589d9333595729108f1c
    Reviewed-on: https://chromium-review.googlesource.com/1169822
    Reviewed-by: Helen Li <xunjieli@chromium.org>
    Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582330}

    Changed files

    • components/cronet/url_request_context_config.cc
  95. Add csharp@ as owner and Extend Expiration Date of EngineTypes Histograms

    Changed by Mark Pearson - mpearsonohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:00:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dab9c033fb5b47c1e6e334e5d95a402668895719

    Comments

    Add csharp@ as owner and Extend Expiration Date of EngineTypes Histograms
    
    These histograms are used, both within Chrome and within Google, in the
    effort to identify and fight unwanted software and malware.
    
    As such, I'm giving them a longer expiration date: two years.
    
    Bug: 871482
    Change-Id: I320976f7a18dfa3c5c0d6bb6c3bf05ddfec8e5b4
    Reviewed-on: https://chromium-review.googlesource.com/1166197
    Reviewed-by: Chris Sharp <csharp@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Commit-Queue: Mark Pearson <mpearson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582329}

    Changed files

    • tools/metrics/histograms/histograms.xml
  96. Enable some more passing browser tests with network service.

    Changed by John Abd-El-Malek - jamohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:58:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c999b6344a3a2d1bd8dbdd09f83d4499453d336

    Comments

    Enable some more passing browser tests with network service.
    
    Bug: 797292, 859594
    
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: Id4e90f0ebdf5ac172b12c92d80b54348125bc883
    Reviewed-on: https://chromium-review.googlesource.com/1171556
    Reviewed-by: Chris Mumford <cmumford@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582328}

    Changed files

    • testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
  97. [Autofill] Updating strings for Save Card Sign-in Promo

    Changed by Manas Verma - manasvermaohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 20:54:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ad5c66907292930c378b882c1634fad9b2b29eb

    Comments

    [Autofill] Updating strings for Save Card Sign-in Promo
    
    Before: https://screenshot.googleplex.com/5YhNTQYuHV1
    After: https://screenshot.googleplex.com/thg0VSMKzNX
    
    
    Bug: 855186
    Change-Id: I64b1ca9452330a847512c45220bda9173e1a1ac1
    Reviewed-on: https://chromium-review.googlesource.com/1170141
    Commit-Queue: Manas Verma <manasverma@google.com>
    Reviewed-by: Evan Stade <estade@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582327}

    Changed files

    • chrome/browser/ui/views/autofill/save_card_manage_cards_bubble_views.cc
    • chrome/browser/ui/views/autofill/save_card_sign_in_promo_bubble_views.cc
    • components/autofill_strings.grdp
    • components/autofill_strings_grdp/IDS_AUTOFILL_SIGNIN_PROMO_MESSAGE.png.sha1
    • components/autofill_strings_grdp/IDS_AUTOFILL_SIGNIN_PROMO_MESSAGE_DICE_DISABLED.png.sha1
    • components/autofill_strings_grdp/IDS_AUTOFILL_SYNC_PROMO_MESSAGE.png.sha1
  98. Remove qualcomm from ToughWebglPage skipped_gpus

    Changed by Kai Ninomiya - kaininoohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:50:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1236a1623e8f1eb638e33d3d145739fe1ca081d4

    Comments

    Remove qualcomm from ToughWebglPage skipped_gpus
    
    Historically, we haven't been running these WebGL perf tests
    on our Android perf bots (which are all Qualcomm devices).
    This change should hopefully allow us to start tracking WebGL
    perf on mobile.
    
    Bug: 867368
    Change-Id: I8e409d649f6238094928dfdac4cc6f7d2c444ca5
    Reviewed-on: https://chromium-review.googlesource.com/1170032
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Commit-Queue: Kai Ninomiya <kainino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582326}

    Changed files

    • tools/perf/page_sets/rendering/tough_webgl_cases.py
  99. Create a separate flag for inline reply on lock screen

    Changed by yoshiki iguchi - yoshikiohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:49:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 14acb978669ed24653f2b290134c828d6a0a0800

    Comments

    Create a separate flag for inline reply on lock screen
    
    Inline reply on lock screen is not launched at the same time as
    the lock screen notifications. So this CL creates a separate feature
    flag for inline reply.
    
    Bug: b/111391270
    
    Change-Id: I585beba17b3a491ce495f1d6c35ce46b2a6b6686
    Reviewed-on: https://chromium-review.googlesource.com/1166617
    Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
    Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582325}

    Changed files

    • ash/public/cpp/ash_features.cc
    • ash/public/cpp/ash_features.h
    • chrome/browser/chromeos/input_method/input_method_manager_impl.cc
  100. Implement native event observer for Windows.

    Changed by Erik Chen - erikchenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:48:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d5c6237c82cf6fd41b61890bf8439782399c8042

    Comments

    Implement native event observer for Windows.
    
    This CL adds a new MessagePumpForUI::Observer class, which can be used to get
    notifications pre and post MSG dispatch.
    
    Change-Id: I16b0df6d30b41f04f124d4b64d850c278f2c10d9
    Reviewed-on: https://chromium-review.googlesource.com/1166164
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
    Reviewed-by: Timothy Dresser <tdresser@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582324}

    Changed files

    • base/message_loop/message_loop_current.cc
    • base/message_loop/message_loop_current.h
    • base/message_loop/message_pump_win.cc
    • base/message_loop/message_pump_win.h
    • content/browser/scheduler/responsiveness/native_event_observer.cc
    • content/browser/scheduler/responsiveness/native_event_observer.h
    • content/browser/scheduler/responsiveness/native_event_observer_browsertest_win.cc
    • content/test/BUILD.gn
  101. <blame list capped at 100 commits>

    Changed by <blame list capped at 100 commits> -
    Changed at N/A
    Repository
    Branch
    Revision

    Comments

    <blame list capped at 100 commits>