Home | Search | chromium - Builders
Login

Builder KitKat Tablet Tester Build 730 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revisionf261109a91970ace70f10388bf8a39acb9977d4b
Got Revisionf261109a91970ace70f10388bf8a39acb9977d4b

Execution:

Steps and Logfiles:

Show:
  1. ( 334 ms ) setup_build
    running recipe: "chromium"
  2. ( 15 secs ) remove .cipd
  3. ( 5 mins 23 secs ) bot_update
    [81GB/295GB used (27%)]
  4. ( 0 ) ensure_goma
  5. ( 2 secs ) swarming.py --version
    0.13
  6. ( 47 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.android.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
  8. ( 24 secs ) clean local files
  9. ( 1 secs ) tree truth steps
  10. ( 2 secs ) build directory
  11. ( 9 mins 5 secs ) extract build
  12. ( 1 secs ) find isolated tests
  13. ( 0 ) test_pre_run
  14. ( 10 secs ) angle_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:03:22.332830
  15. ( 4 secs ) base_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:04:06.487540
  16. ( 2 secs ) blink_common_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 38s
  17. ( 9 secs ) blink_heap_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:51.357160
  18. ( 1 mins 33 secs ) blink_platform_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 38s
    Shard duration: 0:02:47.452910
  19. ( 2 secs ) boringssl_crypto_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:03:01.195100
  20. ( 2 secs ) boringssl_ssl_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 33s
  21. ( 3 secs ) breakpad_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 26s
  22. ( 2 secs ) cacheinvalidation_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 30s
  23. ( 2 secs ) capture_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 33s
    Shard duration: 51s
  24. ( 2 secs ) cast_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 38s
    Shard duration: 46s
  25. ( 4 secs ) cc_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 53s
    Shard duration: 0:02:43.775310
  26. ( 55 mins 21 secs ) chrome_public_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 0:45:51.184140 (shard #19)
    Max shard duration: 0:14:46.716860 (shard #4)
    Min shard duration: 0:09:47.620000 (shard #19)
  27. ( 1 mins 46 secs ) chrome_sync_shell_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:51:42.627370
    Shard duration: 0:09:20.592350
  28. ( 2 secs ) components_browsertests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:53:38.581850
    Shard duration: 0:03:43.595850
  29. ( 10 mins 52 secs ) components_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 0:56:49.302580 (shard #1)
    Max shard duration: 0:14:51.091990 (shard #1)
    Min shard duration: 0:13:46.298240 (shard #0)
  30. ( 23 mins 54 secs ) content_browsertests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 1:17:29.386210 (shard #5)
    Max shard duration: 0:20:55.676620 (shard #1)
    Min shard duration: 0:18:11.817950 (shard #3)
  31. ( 3 secs ) content_shell_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 1:20:29.699350 (shard #1)
    Max shard duration: 0:14:06.998450 (shard #1)
    Min shard duration: 0:12:25.126400 (shard #0)
  32. ( 2 mins 16 secs ) content_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 1:32:41.416340 (shard #2)
    Max shard duration: 0:06:18.531000 (shard #0)
    Min shard duration: 0:05:36.861440 (shard #2)
  33. ( 2 secs ) crypto_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 34s
  34. ( 2 secs ) device_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:34:58.430180
    Shard duration: 0:01:04.361390
  35. ( 2 secs ) display_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 33s
  36. ( 2 secs ) events_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:35:23.911120
    Shard duration: 48s
  37. ( 2 secs ) gcm_unit_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 56s
  38. ( 5 secs ) gfx_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:02:38.194790
  39. ( 2 secs ) gin_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 37s
  40. ( 2 secs ) gl_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:36:05.169110
    Shard duration: 56s
  41. ( 2 secs ) gl_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 33s
  42. ( 2 secs ) google_apis_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 49s
  43. ( 5 secs ) gpu_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:03:29.917140
  44. ( 2 secs ) ipc_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 32s
  45. ( 2 secs ) jingle_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 50s
  46. ( 2 secs ) latency_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 42s
  47. ( 2 secs ) libjingle_xmpp_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 42s
  48. ( 3 secs ) media_blink_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:37:11.685120
    Shard duration: 0:02:03.209450
  49. ( 2 secs ) media_service_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:38:22.954470
    Shard duration: 0:01:02.543000
  50. ( 5 mins 8 secs ) media_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:39:32.452870
    Shard duration: 0:05:10.502560
  51. ( 2 secs ) midi_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 30s
  52. ( 2 secs ) mojo_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:02:01.646330
  53. ( 3 secs ) mojo_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:37.606480
  54. ( 36 secs ) net_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max shard duration: 0:12:42.360860 (shard #0)
    Min shard duration: 0:11:46.455840 (shard #2)
  55. ( 2 secs ) sandbox_linux_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 31s
  56. ( 5 secs ) services_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:39:35.478100
    Shard duration: 0:02:49.973040
  57. ( 2 secs ) shell_dialogs_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:41:23.599190
    Shard duration: 39s
  58. ( 2 secs ) skia_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:41:24.378320
    Shard duration: 48s
  59. ( 3 secs ) sql_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 45s
  60. ( 3 secs ) storage_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:41:25.092360
    Shard duration: 0:01:25.196560
  61. ( 2 secs ) ui_android_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:42:19.267430
    Shard duration: 36s
  62. ( 2 secs ) ui_base_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 57s
  63. ( 2 secs ) ui_touch_selection_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 32s
  64. ( 11 mins 42 secs ) unit_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 1:43:09.185670 (shard #1)
    Max shard duration: 0:15:59.451520 (shard #0)
    Min shard duration: 0:11:06.609210 (shard #1)
  65. ( 2 secs ) url_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 28s
  66. ( 3 secs ) viz_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:43:09.143930
    Shard duration: 0:01:08.258790
  67. ( 2 secs ) vr_common_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:44:35.281320
    Shard duration: 0:01:17.373260
  68. ( 2 secs ) vr_pixeltests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:44:39.056310
    Shard duration: 0:01:22.196700
  69. ( 9 mins 9 secs ) webkit_unit_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:46:09.483980
    Shard duration: 0:21:32.032840
  70. ( 2 secs ) wtf_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 48s
  71. ( 392 ms ) Tests statistics
     
    Stats
    Total shards: 88
    Total runtime: 9:31:49.020711
     
  72. ( 715 ms ) test_report
  73. ( 3 ms ) recipe result

Build Properties:

NameValueSource
$build/goma {"jobs": 150} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm97-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531414918014980, "id": "8941188786886481488", "project": "chromium", "tags": ["builder:KitKat Tablet Tester", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/f261109a91970ace70f10388bf8a39acb9977d4b", "gitiles_ref:refs/heads/master", "parent_buildername:Android arm Builder (dbg)", "parent_buildnumber:36195", "scheduler_invocation_id:9106618849469630944", "scheduler_job_id:chromium/KitKat Tablet Tester", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "KitKat Tablet Tester" setup_build
buildnumber 730 setup_build
mastername "chromium.android" setup_build
parent_buildername "Android arm Builder (dbg)" setup_build
parent_got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" setup_build
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" setup_build
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" setup_build
parent_got_revision "f261109a91970ace70f10388bf8a39acb9977d4b" setup_build
parent_got_revision_cp "refs/heads/master@{#574557}" setup_build
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" setup_build
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" setup_build
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" setup_build
parent_got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23950}" setup_build
parent_mastername "chromium.android" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "f261109a91970ace70f10388bf8a39acb9977d4b" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "f261109a91970ace70f10388bf8a39acb9977d4b" bot_update
got_revision_cp "refs/heads/master@{#574557}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23950}" bot_update
swarm_hashes {"android_webview_unittests": "7444896b90d3fe2af11b78cb2079969acc3f8b05", "angle_unittests": "e853ca169c1c1783b8fb35cef224c33e1ca0acc8", "base_unittests": "3bc193653918648869ea2cdbe9fb27f967b4cd6b", "blink_common_unittests": "d2055683fb5eac6a3d7fcee3cbbf636835f4e190", "blink_heap_unittests": "2488044bf806f27a5ef051c3631ac829c1075f94", "blink_platform_unittests": "1d77d1963c7127f569f3bac366afe360f06bf949", "boringssl_crypto_tests": "4d44086b89b68e97803b7679c8c7e07d0afe6277", "boringssl_ssl_tests": "2bd4e548f7d586e984739d1d44495ea3f37a3045", "breakpad_unittests": "c03c672f64ad93ed8ed448a7de8d9e283bea56d8", "cacheinvalidation_unittests": "db526fab815338448a63c849e0991156bb67ac12", "capture_unittests": "4a3942f5b3724f78b6b8286f00fd32b3211a257d", "cast_unittests": "234b088e8d603e69677fe25620a313ad31bf86f7", "cc_unittests": "63bc300825342cce2c2f5bb8c1f56d033b695361", "chrome_public_test_apk": "f5e39ce5891eaf047f1527da2c3a2e8a94b21abf", "chrome_public_test_vr_apk": "d01092d67c6bdb2243b1d37700c523c772ac4bfb", "chrome_sync_shell_test_apk": "3b6e47a24fdeb0345499b6e31e069029eba5fb79", "components_browsertests": "50e8fd8fbe3d58ea95dbe7db3ecd22dc00a65cf3", "components_unittests": "7df7a8216a58b217ffdeb72a102b588c25a6fb03", "content_browsertests": "720af59f2afb6de81e5da15506b11b2379d311c9", "content_shell_test_apk": "3bc41e5d767b7aadb5b74ad3c5a8f8fb960e0d8d", "content_unittests": "da7d2ddc58891f052ba101ca9965f64b37d922c3", "crypto_unittests": "111c85fd91f671d9257561ec79b8891003a49864", "device_unittests": "249a027922b5af60a68a8d0bcc9309a0e6ddbd4c", "display_unittests": "c3102a146782ba1d02639173671328636c94da62", "events_unittests": "c45b86865e9ecba57882ecf516347d8ef0a7a8e7", "gcm_unit_tests": "e1961154a0030c97a9dfe1f266232c091171fd4a", "gfx_unittests": "9e18e9efd33e17caf644ad27449e58dd4574bfb3", "gin_unittests": "d1dc7b0d66d5bceb46380c348372c5059cd8840f", "gl_tests": "0ea830f8b5bc418c7e8e146e5679189e226ed2b5", "gl_unittests": "9336f278e45196f878f626f40f985f5efb660d2e", "google_apis_unittests": "574d51271757a21e2259a67f378d209d40e3c946", "gpu_unittests": "82516eff05d260d461cd211eb831a4fc009beb1a", "ipc_tests": "7df5faaa016abb233dd4dc41e4f8fb1356220673", "jingle_unittests": "3a6573cdf953e7772ac6c30ad37098cd6b8ccbc2", "latency_unittests": "46e0e21918b9e2d459e4d224a80a6043ec845eee", "libjingle_xmpp_unittests": "da6ec485b57f4bbd87ab12d60654a3e6a460a3ad", "media_blink_unittests": "e056fffb6eecf5ad25415a28261ebf8cdfded349", "media_service_unittests": "f5b8df54fe691c3ec54fd0f3216fe63c7a395778", "media_unittests": "8dc0eff189619573ae480cf3ece8746047368f68", "midi_unittests": "7feb95ed8d448390c63bbe09f3dc76c5cbbb3436", "mojo_test_apk": "ea0463d0febfbabe2d1a6eb0236de9a30c54e7d6", "mojo_unittests": "745787c7e4055fb5ae80d052812a8f35c670cf48", "net_unittests": "91b21110d3962433cde5c33a39b30407ab2f5dea", "sandbox_linux_unittests": "3e9d1c803c502bbf3c6fa0faf2dad99465cc18a1", "services_unittests": "e7159091140b8a62333461dc5da8ee91e35f74e9", "shell_dialogs_unittests": "70d9e3a0b23d68bf9d0813643d57d64b779f4208", "skia_unittests": "8de895e2e91c50b205e72d616fc627581c37e4ad", "sql_unittests": "68ec56ca49fc6e64a987eae9e5cc36639b5aeba4", "storage_unittests": "50d92be274fd8cf4ced6d6ddf2568455bbcd6fb1", "ui_android_unittests": "18e4f9073e2c17aef4f6ba46d94608f3e18f51bc", "ui_base_unittests": "d96f02d85e422329a446d3cea66c80d56e5c0a0c", "ui_touch_selection_unittests": "b5c205262c95d51d96984d4d81cdd8ca2af0e549", "unit_tests": "0236806d553e1184a8a163ca6079afd2dd728528", "url_unittests": "386d342199f197f5bfec2a07d8c3510e4a1aa1ee", "viz_unittests": "ddbe02b9d45661945a922a53e6dbdb204770e33c", "vr_common_unittests": "4707162b5408392887a3001186862e4ef3ec80a5", "vr_pixeltests": "3738de90eb7097902cd0ba2acf7b4d5fb35e34b5", "webkit_unit_tests": "2bbbe72941323774fbbbc1566a9dc98aabd0aff8", "webview_instrumentation_test_apk": "1ab2281c79dcd2c3c277814c48e787aec25b25c9", "wtf_unittests": "3ba41d0bc8de5d0145d4bf926b750668805bb5ab"} find isolated tests

Blamelist:

  1. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  2. pdfium-chromium-autoroll (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  3. Tiger Oakes (tigeroohnoyoudont@google.com)
  4. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  5. clamy (clamyohnoyoudont@chromium.org)
  6. Jan Wilken Doerrie (jdoerrieohnoyoudont@chromium.org)
  7. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  8. Colin Blundell (blundellohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 17:01:58 UTC
Start Thursday, 12-Jul-18 17:02:34 UTC
End Thursday, 12-Jul-18 19:29:28 UTC
Pending 36 secs
Execution 2 hrs 26 mins

All Changes:

  1. [Unity][Android] Increase char limit for 'Sync and Google services'

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 14:33:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f261109a91970ace70f10388bf8a39acb9977d4b

    Comments

    [Unity][Android] Increase char limit for 'Sync and Google services'
    
    This CL increases the char limit for 'Sync and Google services'
    translations to 40 characters. It also enables text wrapping for
    preference title that uses this string.
    
    Bug: 814728
    Change-Id: If1b2c3bb9d83a01a2fa13ddd38d39323dc94e689
    Reviewed-on: https://chromium-review.googlesource.com/1131126
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574557}

    Changed files

    • chrome/android/java/res/xml/main_preferences.xml
    • chrome/android/java/strings/android_chrome_strings.grd
  2. Roll src/third_party/pdfium 5ff09fb5ee90..6aa2190f70a8 (1 commits)

    Changed by pdfium-chromium-autoroll - pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 14:29:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df1df391ec8f9534d21219ea753c260c4357588b

    Comments

    Roll src/third_party/pdfium 5ff09fb5ee90..6aa2190f70a8 (1 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/5ff09fb5ee90..6aa2190f70a8
    
    
    git log 5ff09fb5ee90..6aa2190f70a8 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 thestig@chromium.org Use JSGetObject() in even more places.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@6aa2190f70a8
    
    The AutoRoll server is located here: https://pdfium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:862059
    TBR=dsinclair@chromium.org
    
    Change-Id: I1f8681742658f04204fb7df938c0667e814d84c6
    Reviewed-on: https://chromium-review.googlesource.com/1134951
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574556}

    Changed files

    • DEPS
  3. Adds favicon for supersize UI

    Changed by Tiger Oakes - tigeroohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 14:25:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e6d9ffa49bc8e4b239cf5ebe1e7b886764280f5a

    Comments

    Adds favicon for supersize UI
    
    Creates a simple icon by taking the pie chart icon and giving it colors
    from the Chromium logo.
    (https://material.io/tools/icons/?search=pie_chart&icon=pie_chart)
    
    Icon:
    https://notwoods.github.io/chrome-supersize-reports/icon.png
    
    Bug: 847599
    Change-Id: Ib711bf0c717b9339914ec4ba2d9f369b33fb84d7
    Reviewed-on: https://chromium-review.googlesource.com/1134195
    Reviewed-by: agrieve <agrieve@chromium.org>
    Reviewed-by: Peter Wen <wnwen@chromium.org>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Commit-Queue: Tiger Oakes <tigero@google.com>
    Cr-Commit-Position: refs/heads/master@{#574555}

    Changed files

    • tools/binary_size/libsupersize/html_report.py
    • tools/binary_size/libsupersize/template_tree_view/favicon.ico
    • tools/binary_size/libsupersize/template_tree_view/index.html
  4. Roll src/third_party/skia 4d6a844365e7..56a426a516d0 (2 commits)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 14:11:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 84a2e1ca7620207a3183a275d73d247035d4c078

    Comments

    Roll src/third_party/skia 4d6a844365e7..56a426a516d0 (2 commits)
    
    https://skia.googlesource.com/skia.git/+log/4d6a844365e7..56a426a516d0
    
    
    git log 4d6a844365e7..56a426a516d0 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 5598148b7613..c9c259cccb2e (1 commits)
    2018-07-12 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    
    
    Created with:
      gclient setdep -r src/third_party/skia@56a426a516d0
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: Iae08a82a8704081e534320f9183df4acbccb30d5
    Reviewed-on: https://chromium-review.googlesource.com/1134950
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574554}

    Changed files

    • DEPS
  5. Store multiple NavigationRequests in RenderFrameHost

    Changed by clamy - clamyohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:52:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d3bfdb09875f6b6cdadd5075d7c1f7305b5118ec

    Comments

    Store multiple NavigationRequests in RenderFrameHost
    
    This CL makes it so that RenderFrameHost can store several
    NavigationRequests waiting to commit instead of just one. This avoids
    deleting a NavigationRequest that would later commit (which can happen
    in quick navigations with a renderer process that is slow to process the
    commit).
    
    The regression test was originally written by arthursonzogni@chromium.org in
    https://chromium-review.googlesource.com/c/chromium/src/+/671351.
    
    The background for this change can be found in the following design doc:
    https://docs.google.com/document/d/1mXjxYJptb_bZ_EqGMF-c4LTSnhjt6Gn_WVvSrsinpq8/edit#.
    
    Bug: 738177
    Change-Id: Idd666e41bd2094c90fa576c77cdc26fb7b54cd7f
    Reviewed-on: https://chromium-review.googlesource.com/1082440
    Commit-Queue: Camille Lamy <clamy@chromium.org>
    Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574553}

    Changed files

    • content/browser/browser_side_navigation_browsertest.cc
    • content/browser/frame_host/navigation_controller_impl_browsertest.cc
    • content/browser/frame_host/navigation_controller_impl_unittest.cc
    • content/browser/frame_host/navigation_request.cc
    • content/browser/frame_host/navigator_impl_unittest.cc
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl.h
    • content/browser/frame_host/render_frame_host_impl_browsertest.cc
    • content/browser/frame_host/render_frame_host_manager.cc
    • content/browser/frame_host/render_frame_host_manager_unittest.cc
    • content/browser/renderer_host/render_widget_host_view_browsertest.cc
    • content/browser/security_exploit_browsertest.cc
    • content/browser/site_per_process_browsertest.cc
    • content/browser/web_contents/web_contents_impl_unittest.cc
    • content/browser/webauth/webauth_browsertest.cc
    • content/public/test/browser_test_utils.cc
    • content/public/test/navigation_simulator.cc
    • content/public/test/test_renderer_host.cc
    • content/test/data/infinite_load_1.html
    • content/test/data/infinite_load_2.html
    • content/test/did_commit_provisional_load_interceptor.cc
    • content/test/did_commit_provisional_load_interceptor.h
    • content/test/test_render_frame_host.cc
    • content/test/test_render_frame_host.h
    • content/test/test_web_contents.cc
  6. [bluetooth] Move Map of Characteristics in Gatt Service

    Changed by Jan Wilken Doerrie - jdoerrieohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:43:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision efd642e61e6933f8e78a607f02b2478652547e92

    Comments

    [bluetooth] Move Map of Characteristics in Gatt Service
    
    This change cleans up BluetoothRemoteGattService and its implementations
    by moving the map of characteristics into the base class. This allows
    for less code duplication and a simplified interface. Furthermore, a
    AddCharacterisitic helper method is introduced.
    
    Bug: 821766
    Change-Id: Ib370c599f1c8519d497a379c976c89c48d7ecb56
    Reviewed-on: https://chromium-review.googlesource.com/1131178
    Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574552}

    Changed files

    • content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
    • device/bluetooth/bluetooth_remote_gatt_characteristic.h
    • device/bluetooth/bluetooth_remote_gatt_service.cc
    • device/bluetooth/bluetooth_remote_gatt_service.h
    • device/bluetooth/bluetooth_remote_gatt_service_android.cc
    • device/bluetooth/bluetooth_remote_gatt_service_android.h
    • device/bluetooth/bluetooth_remote_gatt_service_mac.h
    • device/bluetooth/bluetooth_remote_gatt_service_mac.mm
    • device/bluetooth/bluetooth_remote_gatt_service_win.cc
    • device/bluetooth/bluetooth_remote_gatt_service_win.h
    • device/bluetooth/bluetooth_remote_gatt_service_winrt.cc
    • device/bluetooth/bluetooth_remote_gatt_service_winrt.h
    • device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc
    • device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.h
    • device/bluetooth/cast/bluetooth_remote_gatt_service_cast.cc
    • device/bluetooth/cast/bluetooth_remote_gatt_service_cast.h
    • device/bluetooth/device_unittest.cc
    • device/bluetooth/test/fake_remote_gatt_service.cc
    • device/bluetooth/test/fake_remote_gatt_service.h
    • device/bluetooth/test/mock_bluetooth_gatt_service.cc
    • device/bluetooth/test/mock_bluetooth_gatt_service.h
    • device/fido/fido_ble_connection_unittest.cc
  7. [iOS] Create FindInPage UI for UI Refresh

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:41:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 81f3e175814bb20d103aa178a71272c2cd422193

    Comments

    [iOS] Create FindInPage UI for UI Refresh
    
    This CL creates the FindInPage UI to be used with UI Refresh.
    
    Bug: 805504
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ib6f5adcfde4560a589fed323a717b02c4566621d
    Reviewed-on: https://chromium-review.googlesource.com/1133160
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574551}

    Changed files

    • ios/chrome/browser/ui/find_bar/BUILD.gn
    • ios/chrome/browser/ui/find_bar/find_bar_controller_ios.mm
    • ios/chrome/browser/ui/find_bar/find_bar_ui_element.h
    • ios/chrome/browser/ui/find_bar/find_bar_view.h
    • ios/chrome/browser/ui/find_bar/find_bar_view.mm
  8. MutablePO2TS: Fire token available when adding invalid token at startup

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:40:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d373e8d468f12b8ca7bbf6b979961e3a3f29cc73

    Comments

    MutablePO2TS: Fire token available when adding invalid token at startup
    
    ProfileOAuth2TokenService maintains the invariant that if the user is
    signed in at startup, the primary account is always present in
    PO2TS::GetAccounts().
    
    To maintain this invariant, MutableProfileOAuth2TokenServiceDelegate
    performs the following action when the load of tokens from the on-disk
    database is complete: if the user is signed in, it checks whether there
    is a token present for the primary account and if not, inserts an
    invalid token for that account. (The token can be absent due to e.g. a
    failure to decrypt the database on disk for whatever reason).
    
    However, MutablePO2TSDelegate does *not* fire the
    OnRefreshTokenAvailable() callback in that case. This breaks the
    implicit expectation of clients that when ProfileOAuth2TokenService adds
    an account, it will always fire OnRefreshTokenAvailable(). It is also
    inconsistent with the behavior if the primary account happens to have
    an invalid token on disk that is successfully decrypted: in that case,
    MutablePO2TSDelegate will fire the observer callback, but of course,
    from clients' POV there is no difference whatsoever between these two
    cases.
    
    In particular, the failure of this invariant can cause IdentityManager
    to crash if a user in this situation later signs out, as the token
    being revoked violates IdentityManager's expectation that it had
    previously been made aware of that token via a notification that it
    was available.
    
    This CL remedies the problem by firing OnRefreshTokenAvailable() in
    this case. It also extends the relevant MutablePO2TSDelegate unittest
    to fail without this change and succeed with this change.
    
    Bug: 860011
    Change-Id: I66cebda29ec56d79f209f6b2c93dff67797c57b4
    Reviewed-on: https://chromium-review.googlesource.com/1126861
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574550}

    Changed files

    • chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc
    • chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.h
    • chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc