Home | Search | chromium - Builders
Login

Builder KitKat Tablet Tester Build 727 Canonical Ubuntu

Results:

Failure chrome_public_test_apk on Android device Nexus 7 [2013]

Trigger Info:

Projectchromium
Revisionf59c5558bcae3a45e08edc99450f00242e5e7ce0
Got Revisionf59c5558bcae3a45e08edc99450f00242e5e7ce0

Execution:

Steps and Logfiles:

Show:
  1. ( 292 ms ) setup_build
    running recipe: "chromium"
  2. ( 1 secs ) remove .cipd
  3. ( 1 mins 58 secs ) bot_update
    [81GB/295GB used (27%)]
  4. ( 0 ) ensure_goma
  5. ( 647 ms ) swarming.py --version
    0.13
  6. ( 43 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.android.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
  8. ( 3 secs ) clean local files
  9. ( 1 secs ) tree truth steps
  10. ( 2 secs ) build directory
  11. ( 8 mins 59 secs ) extract build
  12. ( 1 secs ) find isolated tests
  13. ( 0 ) test_pre_run
  14. ( 12 secs ) angle_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:03:22.332830
  15. ( 4 secs ) base_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:04:20.306440
  16. ( 2 secs ) blink_common_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 42s
  17. ( 2 secs ) blink_heap_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:39.365210
  18. ( 1 mins 11 secs ) blink_platform_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 14s
    Shard duration: 0:02:51.939370
  19. ( 2 secs ) boringssl_crypto_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:03:01.195100
  20. ( 2 secs ) boringssl_ssl_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 33s
  21. ( 2 secs ) breakpad_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 26s
  22. ( 2 secs ) cacheinvalidation_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 30s
  23. ( 2 secs ) capture_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 34s
    Shard duration: 0:01:43.685320
  24. ( 2 secs ) cast_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 37s
    Shard duration: 0:01:46.073810
  25. ( 6 secs ) cc_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 52s
    Shard duration: 0:02:42.924670
  26. ( 58 mins 53 secs ) chrome_public_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 0:49:50.460580 (shard #19)
    Max shard duration: 0:14:20.914270 (shard #14)
    Min shard duration: 0:10:59.442900 (shard #19)
    failures:
    org.chromium.chrome.browser.autofill.keyboard_accessory.ManualFillingIntegrationTest#testAccessorySheetHiddenUntilManuallyTriggered
     
  27. ( 4 mins 31 secs ) chrome_sync_shell_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:57:37.500150
    Shard duration: 0:09:24.715540
  28. ( 2 secs ) components_browsertests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:58:59.688130
    Shard duration: 0:04:55.059140
  29. ( 10 mins 23 secs ) components_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 1:01:18.829530 (shard #1)
    Max shard duration: 0:15:50.748680 (shard #1)
    Min shard duration: 0:14:53.189180 (shard #0)
  30. ( 23 mins 47 secs ) content_browsertests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 1:23:07.919950 (shard #5)
    Max shard duration: 0:20:47.429670 (shard #0)
    Min shard duration: 0:17:44.051330 (shard #3)
  31. ( 3 secs ) content_shell_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 1:26:10.903870 (shard #1)
    Max shard duration: 0:13:18.374500 (shard #1)
    Min shard duration: 0:12:52.191260 (shard #0)
  32. ( 1 mins 20 secs ) content_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 1:37:00.505090 (shard #2)
    Max shard duration: 0:06:18.098460 (shard #0)
    Min shard duration: 0:05:39.994450 (shard #1)
  33. ( 2 secs ) crypto_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 34s
  34. ( 2 secs ) device_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:39:44.369350
    Shard duration: 0:01:09.553980
  35. ( 2 secs ) display_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 31s
  36. ( 2 secs ) events_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:39:44.095860
    Shard duration: 42s
  37. ( 2 secs ) gcm_unit_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 51s
  38. ( 5 secs ) gfx_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:02:32.478120
  39. ( 2 secs ) gin_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 37s
  40. ( 2 secs ) gl_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:40:40.799010
    Shard duration: 54s
  41. ( 2 secs ) gl_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 39s
  42. ( 2 secs ) google_apis_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 50s
  43. ( 5 secs ) gpu_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:03:43.250120
  44. ( 2 secs ) ipc_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 32s
  45. ( 2 secs ) jingle_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 55s
  46. ( 2 secs ) latency_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 45s
  47. ( 2 secs ) libjingle_xmpp_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 42s
  48. ( 3 secs ) media_blink_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:40:57.524820
    Shard duration: 0:02:08.915010
  49. ( 9 secs ) media_service_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:41:22.117500
    Shard duration: 59s
  50. ( 2 mins 36 secs ) media_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:41:41.503610
    Shard duration: 0:05:05.170390
  51. ( 2 secs ) midi_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 30s
  52. ( 2 secs ) mojo_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:02:01.646330
  53. ( 3 secs ) mojo_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:33.559260
  54. ( 31 secs ) net_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max shard duration: 0:12:42.360860 (shard #0)
    Min shard duration: 0:11:46.455840 (shard #2)
  55. ( 2 secs ) sandbox_linux_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 31s
  56. ( 4 secs ) services_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:42:04.539730
    Shard duration: 0:03:01.899010
  57. ( 2 secs ) shell_dialogs_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:42:31.367820
    Shard duration: 34s
  58. ( 2 secs ) skia_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:42:53.049100
    Shard duration: 48s
  59. ( 2 secs ) sql_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 45s
  60. ( 2 secs ) storage_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:43:11.137520
    Shard duration: 0:01:28.577410
  61. ( 2 secs ) ui_android_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:43:20.683460
    Shard duration: 36s
  62. ( 3 secs ) ui_base_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:02.343620
  63. ( 2 secs ) ui_touch_selection_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 37s
  64. ( 10 mins ) unit_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 1:44:25.476000 (shard #1)
    Max shard duration: 0:14:39.457750 (shard #0)
    Min shard duration: 0:12:14.450650 (shard #1)
  65. ( 2 secs ) url_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 28s
  66. ( 2 secs ) viz_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:44:54.361990
    Shard duration: 0:01:02.580710
  67. ( 2 secs ) vr_common_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:45:34.942950
    Shard duration: 0:01:40.795400
  68. ( 2 secs ) vr_pixeltests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:46:16.920120
    Shard duration: 0:01:22.137380
  69. ( 9 mins 16 secs ) webkit_unit_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:46:41.801720
    Shard duration: 0:21:17.569160
  70. ( 2 secs ) wtf_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 58s
  71. ( 407 ms ) Tests statistics
     
    Stats
    Total shards: 88
    Total runtime: 9:33:59.206263
     
  72. ( 263 ms ) test_report
  73. ( 4 ms ) Failure reason

Build Properties:

NameValueSource
$build/goma {"jobs": 150} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm97-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531389245742320, "id": "8941215706214592240", "project": "chromium", "tags": ["builder:KitKat Tablet Tester", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/f59c5558bcae3a45e08edc99450f00242e5e7ce0", "gitiles_ref:refs/heads/master", "parent_buildername:Android arm Builder (dbg)", "parent_buildnumber:36189", "scheduler_invocation_id:9106645768478340192", "scheduler_job_id:chromium/KitKat Tablet Tester", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "KitKat Tablet Tester" setup_build
buildnumber 727 setup_build
mastername "chromium.android" setup_build
parent_buildername "Android arm Builder (dbg)" setup_build
parent_got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" setup_build
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" setup_build
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" setup_build
parent_got_revision "f59c5558bcae3a45e08edc99450f00242e5e7ce0" setup_build
parent_got_revision_cp "refs/heads/master@{#574501}" setup_build
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" setup_build
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" setup_build
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" setup_build
parent_got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23944}" setup_build
parent_mastername "chromium.android" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "f59c5558bcae3a45e08edc99450f00242e5e7ce0" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "f59c5558bcae3a45e08edc99450f00242e5e7ce0" bot_update
got_revision_cp "refs/heads/master@{#574501}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23944}" bot_update
swarm_hashes {"android_webview_unittests": "46aa15296e381d56b87c4192c23226bb962da282", "angle_unittests": "e853ca169c1c1783b8fb35cef224c33e1ca0acc8", "base_unittests": "08bb01d3a3cb8d780fa9e844dbb862d42b9fcb1b", "blink_common_unittests": "e195a4e707cb283f49ba6f35a744c633fef4a8c7", "blink_heap_unittests": "4f92e4b7054aeed74fac64b855bb87665a8ddf69", "blink_platform_unittests": "e2e5c74faaaa3be4b2243a6e5097bdcc4a4ed725", "boringssl_crypto_tests": "4d44086b89b68e97803b7679c8c7e07d0afe6277", "boringssl_ssl_tests": "2bd4e548f7d586e984739d1d44495ea3f37a3045", "breakpad_unittests": "c03c672f64ad93ed8ed448a7de8d9e283bea56d8", "cacheinvalidation_unittests": "db526fab815338448a63c849e0991156bb67ac12", "capture_unittests": "cabf85ee7d1dc1a171520ef275fc8de9a3c496fa", "cast_unittests": "43f8e025d72b81c46be58e9f6489df28ea728c53", "cc_unittests": "c7efdb996575848da63fa05411b49852b18f0eb0", "chrome_public_test_apk": "3749b39f8a760b7675b958b35739c3511b5d0a57", "chrome_public_test_vr_apk": "397e3f41bde3bf59c2f7a983c206430599145588", "chrome_sync_shell_test_apk": "0624331f5c01a4207d9e9e908137b48f221a1432", "components_browsertests": "045d0837e5469d08422a305f334f6a06690fabd2", "components_unittests": "c0b79afcd02cd1fad413d78371a7777351f018b8", "content_browsertests": "493357c76000fb46a6c31a2c5680f183606cf4ce", "content_shell_test_apk": "b0f0f9a52afd534c75d568e9b4a1667c58ebb2d9", "content_unittests": "463edf37a044aeef838f613abc98b90139b9745e", "crypto_unittests": "111c85fd91f671d9257561ec79b8891003a49864", "device_unittests": "36f67981dc27d2d14c6978f9879842e7b4c45c0a", "display_unittests": "3e6fccef598480ab972d78b5aef2ba5628e56817", "events_unittests": "d9af3407e72bf1a78bd5db9472b89f3bba8766df", "gcm_unit_tests": "acb2d88d385a335a81ee193a5743e6e315b7992b", "gfx_unittests": "58d05add0bf4a213bf780197b8877cc0d6a599c7", "gin_unittests": "d1dc7b0d66d5bceb46380c348372c5059cd8840f", "gl_tests": "d1c2db39178e66056e787d5f31726400b1e78bfa", "gl_unittests": "44623a4283a8eeaa6c375ddce0f5c6312d0c10cc", "google_apis_unittests": "23246c305c275e668ef3959f83ce7db95ab7e368", "gpu_unittests": "cc6472e2524d2f26ff90690d473cbb9542ec419d", "ipc_tests": "7df5faaa016abb233dd4dc41e4f8fb1356220673", "jingle_unittests": "1d37dd95c140a73d571bf2999c81bf114466e1c3", "latency_unittests": "7912271d9aa54081892548cb3c4cb667f7f0a72b", "libjingle_xmpp_unittests": "da6ec485b57f4bbd87ab12d60654a3e6a460a3ad", "media_blink_unittests": "60c1c624dc3fea694e2432d29ab8846f8b22db36", "media_service_unittests": "ba887f1594f2820fa5f0d5f017eae2f6c42e0155", "media_unittests": "d07b16a5f17dfc9b33100cfc3ff6328510a748d5", "midi_unittests": "7feb95ed8d448390c63bbe09f3dc76c5cbbb3436", "mojo_test_apk": "ea0463d0febfbabe2d1a6eb0236de9a30c54e7d6", "mojo_unittests": "a5d495bca01551b461d12a436c003720db3992ad", "net_unittests": "91b21110d3962433cde5c33a39b30407ab2f5dea", "sandbox_linux_unittests": "3e9d1c803c502bbf3c6fa0faf2dad99465cc18a1", "services_unittests": "1397abb925f1d9e8fc0ad954f4d82eb2d8226f86", "shell_dialogs_unittests": "bf6f9b1e1cbf937fe6dcc81eb6baae9878815ba6", "skia_unittests": "6066e8eebef36d01dfa13fb91709f631c5d5ee9b", "sql_unittests": "68ec56ca49fc6e64a987eae9e5cc36639b5aeba4", "storage_unittests": "4d80d24d0b98acae1faf313800287797220b51db", "ui_android_unittests": "26e316f50f61bf665f41caa6faaf8d0a99316cac", "ui_base_unittests": "ba1367bb29427276dd59d616e90921cc1c3357f6", "ui_touch_selection_unittests": "6eee9bc319dd0de814ced669a414036c444d93c1", "unit_tests": "d835e3238172292df617e39cbe76813f13a00a4f", "url_unittests": "386d342199f197f5bfec2a07d8c3510e4a1aa1ee", "viz_unittests": "14059c19cd8554e13e1e9f33ae1363f7c465b645", "vr_common_unittests": "ed33f3a9f55399139e6b5530876460544dd6d67a", "vr_pixeltests": "25913bfb3d4f8a1ba3de3762f289fff6b7de602b", "webkit_unit_tests": "ce4a57687da72678e86839387d6db0721162d202", "webview_instrumentation_test_apk": "20e00d102b5a1f8606e2a5917d94f36e035fbcbe", "wtf_unittests": "cd26ba4f6e54716edaffd97ad0ceb8f41cff4f20"} find isolated tests

Blamelist:

  1. Hitoshi Yoshida (periaohnoyoudont@chromium.org)
  2. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
  3. Alan Cutter (alancutterohnoyoudont@chromium.org)
  4. Marc Treib (treibohnoyoudont@chromium.org)
  5. Dominic Mazzoni (dmazzoniohnoyoudont@chromium.org)
  6. Hirokazu Honda (hirohohnoyoudont@chromium.org)
  7. cathiechen (cathiechenohnoyoudont@tencent.com)
  8. Stefan Zager (szagerohnoyoudont@chromium.org)
  9. Jun Mukai (mukaiohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 09:54:05 UTC
Start Thursday, 12-Jul-18 09:54:07 UTC
End Thursday, 12-Jul-18 12:16:30 UTC
Pending 2 secs
Execution 2 hrs 22 mins

All Changes:

  1. oilpan: Make ImageLoader::Task::script_state_ WeakPersistent

    Changed by Hitoshi Yoshida - periaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:41:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f59c5558bcae3a45e08edc99450f00242e5e7ce0

    Comments

    oilpan: Make ImageLoader::Task::script_state_ WeakPersistent
    
    ImageLoader::Task class does not actually own the script state,
    so its reference can be weak.
    This CL makes the reference weak.
    
    Bug: 773605
    Change-Id: Ib5761227e6582a8519a9d10ffaa00226559ee3d6
    Reviewed-on: https://chromium-review.googlesource.com/1134629
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574501}

    Changed files

    • third_party/blink/renderer/core/loader/image_loader.cc
  2. Change test to use full-path-for-testing attribute selector

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:12:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a8460b3e49c7b9ee03dcf56af71a0d76c0f60e4

    Comments

    Change test to use full-path-for-testing attribute selector
    
    This makes this test compatible with directory tree having My Files or
    not, and makes the test more readable too.
    
    This is a preparation to enable new navigation (with My Files) by
    default.
    
    Bug: 857335
    No-presubmit: true
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ia35bc2cc7c91e0492f0158990bfc397a6b57da21
    Reviewed-on: https://chromium-review.googlesource.com/1133610
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574500}

    Changed files

    • ui/file_manager/integration_tests/file_manager/context_menu.js
    • ui/file_manager/integration_tests/file_manager/create_new_folder.js
    • ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
  3. Add find bar icon to hosted app windows

    Changed by Alan Cutter - alancutterohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:03:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e35f205a1441afebe9987e606c7c876d5bfc4594

    Comments

    Add find bar icon to hosted app windows
    
    This CL moves the find icon from LocationBarView into PageActionIconContainerView
    enabling the icon to appear in hosted app window title bars.
    
    This change also fixes the find icon getting nudged by
    crrev.com/108c0687254683b3beeaa32b6e0a86f2046a867e.
    
    Before 108c0687254683b3beeaa32b6e0a86f2046a867e:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346964&signed_aid=IuPvufZswamla90tWW5FCg==&inline=1
    Before CL:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346965&signed_aid=Aiy5ATHUK4cWS64MyuRMdQ==&inline=1
    After CL:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346968&signed_aid=DR3vtzLR7tlPH3cEwibshQ==&inline=1
    
    Bug: 788051, 814531
    Change-Id: I5fa60cce484bd2553131582fc39e6737da34e967
    Reviewed-on: https://chromium-review.googlesource.com/1054908
    Commit-Queue: Alan Cutter <alancutter@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574499}

    Changed files

    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
    • chrome/browser/ui/find_bar/find_bar_controller.cc
    • chrome/browser/ui/location_bar/location_bar.h
    • chrome/browser/ui/page_action/page_action_icon_container.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
    • chrome/browser/ui/views/frame/browser_view_layout.cc
    • chrome/browser/ui/views/frame/hosted_app_button_container.cc
    • chrome/browser/ui/views/frame/hosted_app_button_container.h
    • chrome/browser/ui/views/frame/toolbar_button_provider.h
    • chrome/browser/ui/views/location_bar/find_bar_icon.cc
    • chrome/browser/ui/views/location_bar/find_bar_icon.h
    • chrome/browser/ui/views/location_bar/location_bar_view.cc
    • chrome/browser/ui/views/location_bar/location_bar_view.h
    • chrome/browser/ui/views/page_action/page_action_icon_container_view.cc
    • chrome/browser/ui/views/page_action/page_action_icon_container_view.h
    • chrome/browser/ui/views/toolbar/toolbar_view.cc
    • chrome/browser/ui/views/toolbar/toolbar_view.h
    • chrome/test/base/test_browser_window.h
  4. Replace ThreadChecker by SequenceChecker in /components/sync*

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 06:54:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fc8a763a002339d6a7821e3c69d45ad8642dafc1

    Comments

    Replace ThreadChecker by SequenceChecker in /components/sync*
    
    https://crrev.com/c/1131474 removed the unnecessary thread-affinity,
    this one adjusts the checks accordingly.
    
    Bug: 846238
    Change-Id: If4e1145712fe99f4d8236d93e4f645e69c3e7655
    Reviewed-on: https://chromium-review.googlesource.com/1131738
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574498}

    Changed files

    • components/sync/driver/glue/sync_backend_host_core.cc
    • components/sync/driver/glue/sync_backend_host_core.h
    • components/sync/driver/glue/sync_backend_host_impl.cc
    • components/sync/driver/glue/sync_backend_host_impl.h
    • components/sync/driver/sync_service_crypto.cc
    • components/sync/driver/sync_service_crypto.h
    • components/sync/engine/sync_backend_registrar.cc
    • components/sync/engine/sync_backend_registrar.h
    • components/sync/engine_impl/debug_info_event_listener.cc
    • components/sync/engine_impl/debug_info_event_listener.h
    • components/sync/engine_impl/model_type_worker.cc
    • components/sync/engine_impl/model_type_worker.h
    • components/sync/engine_impl/net/server_connection_manager.cc
    • components/sync/engine_impl/net/server_connection_manager.h
    • components/sync/engine_impl/sync_manager_impl.cc
    • components/sync/engine_impl/sync_manager_impl.h
    • components/sync/engine_impl/sync_manager_impl_unittest.cc
    • components/sync/test/engine/fake_model_worker.cc
    • components/sync/test/engine/fake_model_worker.h
    • components/sync_bookmarks/bookmark_change_processor.cc
    • components/sync_bookmarks/bookmark_change_processor.h
  5. Track changes to nodes that are in the AX tree but aren't laid out.

    Changed by Dominic Mazzoni - dmazzoniohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 06:41:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d535bf95b998d1061629905139485c937272fc3b

    Comments

    Track changes to nodes that are in the AX tree but aren't laid out.
    
    Previously we only had hooks to update the children of a node in the
    AX tree when LayoutObjects were inserted or removed. That left out some
    corner cases when Nodes are inserted or removed that are part of the
    AX tree but not laid out, like nodes in the accessible / fallback content
    for a canvas.
    
    Bug: 862311
    Change-Id: I9482a9e0dc9ba45368b2fc87ea3449bdd4ef1c50
    Reviewed-on: https://chromium-review.googlesource.com/1132119
    Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574497}

    Changed files

    • third_party/WebKit/LayoutTests/accessibility/children-changed-in-canvas.html
    • third_party/blink/renderer/core/dom/element.cc
    • third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
    • third_party/blink/renderer/modules/accessibility/ax_layout_object.h
    • third_party/blink/renderer/modules/accessibility/ax_node_object.cc
    • third_party/blink/renderer/modules/accessibility/ax_node_object.h
  6. media/gpu/test/RenderingHelper: Unify interface to process video frame

    Changed by Hirokazu Honda - hirohohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 06:09:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c9e1a62b97488da8c36e7c12d0fe9769a60b4238

    Comments

    media/gpu/test/RenderingHelper: Unify interface to process video frame
    
    VDA test client calls RenderingHelper::RenderThumbnail() if a thumbnail is made
    from a video frame. Otherwise, it calls RenderingHelper::QueueVideoFrame().
    RenderingHelper itself knows which function to be called, and thus these
    functions should be unified into a single interface.
    
    BUG=chromium:834170
    TEST=VDA unittest at veyron_minnie and eve
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I106d4ce1c05b003d6333a6865a8d96e276031598
    Reviewed-on: https://chromium-review.googlesource.com/1122656
    Reviewed-by: Pawel Osciak <posciak@chromium.org>
    Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574496}

    Changed files

    • media/gpu/test/rendering_helper.cc
    • media/gpu/test/rendering_helper.h
    • media/gpu/video_decode_accelerator_unittest.cc
  7. [LayoutNG]Make the first marker of nested list occupying a whole line

    Changed by cathiechen - cathiechenohnoyoudont@tencent.com
    Changed at Thursday, 12-Jul-18 05:58:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 347323ce0f71964c59a50c507f14484baff8a386

    Comments

    [LayoutNG]Make the first marker of nested list occupying a whole line
    
    In legacy Layout, there's line-break between marker and the nesting
    <ul>/<ol>. In order to keep consistency with it, add NeedsOccupyWholeLine()
    in LayoutNGListMarker to indicate that marker would occupy a line.
    During Layout(), this kind of marker won't be added to container_builder_,
    and layout directly. And its margin will be handled after layout.
    
    Bug: 725277
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Ie9f6dbca0945c8e031ec7bb44594db2e96773462
    Reviewed-on: https://chromium-review.googlesource.com/1132819
    Commit-Queue: cathie chen <cathiechen@tencent.com>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574495}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/doctypes/001-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/doctypes/003-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/doctypes/004-expected.txt
    • third_party/blink/renderer/core/layout/ng/list/layout_ng_list_marker.cc
    • third_party/blink/renderer/core/layout/ng/list/layout_ng_list_marker.h
    • third_party/blink/renderer/core/layout/ng/list/ng_unpositioned_list_marker.h
    • third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
    • third_party/blink/renderer/core/paint/ng/ng_box_fragment_painter.cc
  8. Move scroll-related platform test code into core/testing/

    Changed by Stefan Zager - szagerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:49:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ecb9b545a199897e05ca621e40fd5e93289f82bd

    Comments

    Move scroll-related platform test code into core/testing/
    
    Also delete unused fake_scrollable_area.h.
    
    BUG=823365
    R=skobes@chromium.org,pdr@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I5620b9c31d53d523108c0c7a3a247264e588fc90
    Reviewed-on: https://chromium-review.googlesource.com/1132380
    Reviewed-by: Steve Kobes <skobes@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Commit-Queue: Stefan Zager <szager@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574494}

    Changed files

    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/editing/rendered_position_test.cc
    • third_party/blink/renderer/core/frame/frame_test_helpers.h
    • third_party/blink/renderer/core/paint/compositing/compositing_layer_property_updater_test.cc
    • third_party/blink/renderer/core/testing/core_unit_test_helper.h
    • third_party/blink/renderer/core/testing/use_mock_scrollbar_settings.h
    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
    • third_party/blink/renderer/platform/graphics/test/fake_scrollable_area.h
  9. check |focused_surface_| on SetCursorType

    Changed by Jun Mukai - mukaiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:47:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5939dab948bcde131510fa955f2802e93159238

    Comments

    check |focused_surface_| on SetCursorType
    
    SetCursorType hasn't checked the focused surface, thus it could
    change the cursor shapes even though the mouse pointer isn't
    related to the apps under exo.
    
    BUG=b/111360026
    TEST=the new test case in exo_unittests
    
    Change-Id: Ibacb0b8689720caa00ec206848cc6efb74854946
    Reviewed-on: https://chromium-review.googlesource.com/1134185
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Commit-Queue: Jun Mukai <mukai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574493}

    Changed files

    • components/exo/pointer.cc
    • components/exo/pointer_unittest.cc