Home | Search | chromium - Builders
Login

Builder KitKat Tablet Tester Build 20104 Canonical Ubuntu

Results:

Failure chrome_public_test_apk on Android device Nexus 7 [2013] Failure components_unittests on Android device Nexus 7 [2013]

Trigger Info:

Projectchromium
Revisionade4af4613155382362249d55cf0435932541483
Got Revisionade4af4613155382362249d55cf0435932541483

Execution:

Steps and Logfiles:

Show:
  1. ( 368 ms ) setup_build
    running recipe: "chromium"
  2. ( 720 ms ) report builders
     
    running tester 'KitKat Tablet Tester' on master 'chromium.android'
  3. ( 7 mins 33 secs ) bot_update
    [61GB/295GB used (20%)]
  4. ( 1 secs ) swarming.py --version
    0.14
  5. ( 51 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.android.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
  7. ( 480 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = true
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_os = "android"
    use_goma = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 18 secs ) clean local files
  9. ( 4 secs ) tree truth steps
  10. ( 441 ms ) build directory
  11. ( 1 secs ) find isolated tests
  12. ( 3 mins 56 secs ) angle_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 11s
    Shard duration: 0:03:33.679638
  13. ( 6 mins 18 secs ) base_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:06:00.314772
  14. ( 49 secs ) blink_common_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 40s
  15. ( 1 mins 57 secs ) blink_heap_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 13s
    Shard duration: 0:01:42.182738
  16. ( 3 mins 2 secs ) blink_platform_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 17s
    Shard duration: 0:02:39.744669
  17. ( 3 mins 39 secs ) boringssl_crypto_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 10s
    Shard duration: 0:03:22.331232
  18. ( 48 secs ) boringssl_ssl_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 41s
  19. ( 36 secs ) breakpad_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 26s
  20. ( 34 secs ) cacheinvalidation_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 28s
  21. ( 1 mins 3 secs ) capture_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 59s
  22. ( 58 secs ) cast_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 10s
    Shard duration: 46s
  23. ( 3 mins 41 secs ) cc_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 10s
    Shard duration: 0:03:21.636645
  24. ( 1 hrs 19 mins ) chrome_public_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 1:06:20.356936 (shard #19)
    Max shard duration: 0:17:09.005414 (shard #6)
    Min shard duration: 0:12:43.558772 (shard #19)
    failures:
    org.chromium.chrome.browser.customtabs.CustomTabActivityTest#testSetTopBarHeight_withModuleAndExtras_heightUpdated
     
  25. ( 5 mins 52 secs ) components_browsertests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:05:37.815626
  26. ( 13 mins 47 secs ) components_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 56s (shard #3)
    Max shard duration: 0:13:07.335480 (shard #0)
    Min shard duration: 0:09:28.559799 (shard #2)
    failures:
    SharedProtoDatabaseTest.CreateClient_FailsWithoutCreate
     
  27. ( 48 mins 1 secs ) content_browsertests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 0:32:56.876998 (shard #8)
    Max shard duration: 0:20:01.793086 (shard #7)
    Min shard duration: 0:14:44.255258 (shard #8)
  28. ( 3 mins 2 secs ) perfetto_content_browsertests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:02:57.602074
  29. ( 11 mins 6 secs ) content_shell_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 49s (shard #2)
    Max shard duration: 0:10:09.551015 (shard #2)
    Min shard duration: 0:09:02.546020 (shard #1)
  30. ( 6 mins 44 secs ) content_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 14s (shard #1)
    Max shard duration: 0:06:19.290145 (shard #2)
    Min shard duration: 0:05:51.577365 (shard #0)
  31. ( 43 secs ) crypto_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 35s
  32. ( 1 mins 17 secs ) device_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:14.026277
  33. ( 39 secs ) display_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 32s
  34. ( 58 secs ) events_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 52s
  35. ( 1 mins 6 secs ) gcm_unit_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 53s
  36. ( 3 mins 21 secs ) gfx_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 15s
    Shard duration: 0:02:56.460229
  37. ( 51 secs ) gin_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 42s
  38. ( 1 mins 19 secs ) gl_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 12s
    Shard duration: 0:01:03.354300
  39. ( 41 secs ) gl_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 35s
  40. ( 59 secs ) google_apis_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 51s
  41. ( 3 mins 53 secs ) gpu_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:03:38.057012
  42. ( 4 mins 47 secs ) ipc_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:04:36.840088
  43. ( 57 secs ) jingle_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 51s
  44. ( 44 secs ) latency_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 35s
  45. ( 1 mins 27 secs ) libjingle_xmpp_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 14s
    Shard duration: 0:01:12.271908
  46. ( 2 mins 25 secs ) media_blink_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:02:17.816179
  47. ( 1 mins 21 secs ) media_service_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 13s
    Shard duration: 0:01:02.839968
  48. ( 5 mins 43 secs ) media_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:05:20.877104
  49. ( 39 secs ) midi_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 30s
  50. ( 2 mins 34 secs ) mojo_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 15s
    Shard duration: 0:02:15.799266
  51. ( 13 mins 48 secs ) mojo_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 12s
    Shard duration: 0:13:30.785848
  52. ( 16 mins 38 secs ) net_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 55s (shard #2)
    Max shard duration: 0:14:56.038925 (shard #1)
    Min shard duration: 0:12:10.248816 (shard #2)
  53. ( 34 secs ) sandbox_linux_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 23s
  54. ( 4 mins 46 secs ) services_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 13s
    Shard duration: 0:04:26.676465
  55. ( 46 secs ) shell_dialogs_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 44s
  56. ( 48 secs ) skia_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 46s
  57. ( 1 mins 19 secs ) sql_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:10.199329
  58. ( 2 mins 24 secs ) storage_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:02:11.092450
  59. ( 48 secs ) ui_android_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 45s
  60. ( 1 mins 23 secs ) ui_base_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:16.393239
  61. ( 52 secs ) ui_touch_selection_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 15s
    Shard duration: 33s
  62. ( 25 mins 42 secs ) unit_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 0:17:11.679666 (shard #9)
    Max shard duration: 0:09:20.011496 (shard #0)
    Min shard duration: 0:07:03.999551 (shard #9)
  63. ( 1 mins 15 secs ) url_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:01.809946
  64. ( 1 mins 33 secs ) viz_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:21.254504
  65. ( 1 mins 38 secs ) vr_common_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 11s
    Shard duration: 0:01:24.888562
  66. ( 2 mins 8 secs ) vr_pixeltests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 17s
    Shard duration: 0:01:24.672614
  67. ( 16 mins 27 secs ) webkit_unit_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 50s (shard #1)
    Max shard duration: 0:15:57.447698 (shard #0)
    Min shard duration: 0:13:53.608200 (shard #1)
  68. ( 41 secs ) wtf_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 38s
  69. ( 246 ms ) Tests statistics
     
    Stats
    Total shards: 103
    Total runtime: 12:23:02.552821
     
  70. ( 258 ms ) test_report
  71. ( 3 ms ) Failure reason

Build Properties:

NameValueSource
$build/goma {"jobs": 150} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm97-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544129510256559, "id": "8927856570611799856", "project": "chromium", "tags": ["builder:KitKat Tablet Tester", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/ade4af4613155382362249d55cf0435932541483", "gitiles_ref:refs/heads/master", "parent_buildername:Android arm Builder (dbg)", "parent_buildnumber:38822", "scheduler_invocation_id:9093286632827039616", "scheduler_job_id:chromium/KitKat Tablet Tester", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "KitKat Tablet Tester" setup_build
buildnumber 20104 setup_build
mastername "chromium.android" setup_build
parent_buildername "Android arm Builder (dbg)" setup_build
parent_got_angle_revision "9092bdc7a76f8f79d7fba775880fecbd3e729ea4" setup_build
parent_got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" setup_build
parent_got_dawn_revision "5aacd29d5e7ed44d3cb0d1c690fbd0fc5152978f" setup_build
parent_got_nacl_revision "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" setup_build
parent_got_revision "ade4af4613155382362249d55cf0435932541483" setup_build
parent_got_revision_cp "refs/heads/master@{#614452}" setup_build
parent_got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" setup_build
parent_got_v8_revision "f5137533bdfac762e980b17eb7b4a2433dd07d1d" setup_build
parent_got_v8_revision_cp "refs/heads/7.3.39@{#1}" setup_build
parent_got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25919}" setup_build
parent_mastername "chromium.android" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "ade4af4613155382362249d55cf0435932541483" setup_build
swarm_hashes {"android_webview_unittests": "c56f9192728ee4345801e64e0d61044a3735b3d3", "angle_unittests": "5915698354b082872b0062f0ad6249f155fc18de", "base_unittests": "24037e44026c7d24ed4fb99388dabb5ea87fb30a", "blink_common_unittests": "05b87deb83ff0f0cfa7b1c878d58f31177e47f93", "blink_heap_unittests": "b1efa82b64a3dd85d4bf8aaca40ed24ca81a72f6", "blink_platform_unittests": "617218160a7c199ef64cfe8f50e1a20aee6bdc4a", "boringssl_crypto_tests": "d17c60b2ddda0c4df8430eda616a123becc33f0b", "boringssl_ssl_tests": "49d79ef5352a4617281526d207b39e5bd11c3a76", "breakpad_unittests": "2b9f962dc04ddcf4cfe0cc252cfe3fc7ca82a679", "cacheinvalidation_unittests": "0555a324f7c2138eb03ca33126403db8cd492101", "capture_unittests": "48c12187e3efc3784d1edb2a47a31bcdf94fb3ee", "cast_unittests": "5e497436a243e76772eee568962c514a10e2c92a", "cc_unittests": "e4ef234d4487cb7c0023b0057071f0fdd297c4e0", "chrome_public_test_apk": "2676c0c301ea9025f68625c3ed388b7e80f49880", "chrome_public_test_vr_apk": "a2c932b5f68d8f84092eef3c53c3c5ac6c531536", "components_browsertests": "3cc029e437f295878a21580d6a0387e4e4c58b05", "components_unittests": "1859315750d06427804a82620ca61539771a86ac", "content_browsertests": "5292fa9e8b432a828633f39ae1fb5ae463e66643", "content_shell_test_apk": "23985ffaa5ee15fae407630e211f17259b1e8aa5", "content_unittests": "20724bccdf26793649e96f5942da7a6d18fb44e1", "crypto_unittests": "fc69d9e1cd20d1735e9d7c80d2da21a07b6b0c09", "device_unittests": "055594eeecdf30ae91755db0c4e6528187b34637", "display_unittests": "9e7aa89a73b38cb8bcb2b302807c51ad376f8032", "events_unittests": "141b375894e9319e7b93fae62c3b26672d76ba32", "gcm_unit_tests": "a7bcb1d51a2dced7755050be585531710d2d46b0", "gfx_unittests": "4ded7a44b0d128dca12e3f7a71e9c240bf9651f0", "gin_unittests": "b59dab629cdd9d35d1dde74b4d04bf5d53794a6d", "gl_tests": "6771d9867b1c2c7eb83c27c1ace6f326697f24f4", "gl_unittests": "7cdf3cefe15e43bf13a079cd4a086438ca59d3d4", "google_apis_unittests": "883ceaaa735a156b9ab933c92bf79ad8709c93f0", "gpu_unittests": "1e9a8296d87f5c17f6abfa5db22cb29f4a3de583", "ipc_tests": "f65463d363465085f7d4bfabc8bc0c7181dc298e", "jingle_unittests": "f43dae278eba1f8e8f77e144fff9da31c2d775ff", "latency_unittests": "a6fe89bc79a44f83f3df292b69050afcf3f9e2d5", "libjingle_xmpp_unittests": "6f8c28fc05176d25175f4b2fa3b8319880579d15", "media_blink_unittests": "6dbfe0967d364441bec0d0004000520edf6cdd40", "media_service_unittests": "91f787d25604a66bdc2424a10dffdb65a5c91af7", "media_unittests": "6342da3c05326ad59aca9e36f8f1dae3a126f6a4", "midi_unittests": "a1402d01d5fe8c32f8d572c069dafe529d13bcc5", "mojo_test_apk": "5b0a9298340e282de1e28ac2cd9ac7ae0c1598ac", "mojo_unittests": "288d532e6b370245fa45b49eb0889ea3c4159a3d", "net_unittests": "fe44e3671c8de3209922dbdb6a59fe06a9ee09ff", "sandbox_linux_unittests": "886e2c9fee11636329aa52995c4759a8ba362ba2", "services_unittests": "9994b06cb7608f90cfdd5c6d37517b88bc62fa5e", "shell_dialogs_unittests": "87031d61ef72fa8803987f86872792b515e4694c", "skia_unittests": "0a88437b04a87d17f7f2564e8bc43168535e59ee", "sql_unittests": "77e5823fdff4bf8a129cd90738a3639a694c6f81", "storage_unittests": "4e825e4f0b3347054442d7e40f0686634fc71726", "ui_android_unittests": "5b6952ee8f5cf80d1a398492ad9b75d2c3fc46ec", "ui_base_unittests": "5dbe27e2098813a44b000cb0c4457edce97aca0b", "ui_touch_selection_unittests": "af0104fc0c0c795b7b9497609b1098a060211dbd", "unit_tests": "2104b4c0751b5201818e33e687976846b518aa9f", "url_unittests": "352563258d7f5464d54a9696f079f23cb2bc1abb", "viz_unittests": "ecc1cadba350276316484d3076021b2c5dcdda46", "vr_common_unittests": "f9f2120db9bb19f33b71e279f24a1ec793e2bb0d", "vr_pixeltests": "7422b9dc240371310281efb78bf942f18df73ecf", "webkit_layout_tests_exparchive": "a480371bea84c0c10471c77aa438689a219a7a48", "webkit_unit_tests": "0981c7e0b1ee051781d8f526ab2ba6e0cc001e91", "webview_cts_tests": "afe0d6de8537071611d3a850808037717588b622", "webview_instrumentation_test_apk": "5ca06b314cf92b5d3930dc162f20f5ae19a15f04", "wtf_unittests": "9462744a3faa3122ac9a468eafa4afcc6aa8dd57"} setup_build
got_angle_revision "9092bdc7a76f8f79d7fba775880fecbd3e729ea4" bot_update
got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" bot_update
got_dawn_revision "5aacd29d5e7ed44d3cb0d1c690fbd0fc5152978f" bot_update
got_nacl_revision "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" bot_update
got_revision "ade4af4613155382362249d55cf0435932541483" bot_update
got_revision_cp "refs/heads/master@{#614452}" bot_update
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" bot_update
got_v8_revision "f5137533bdfac762e980b17eb7b4a2433dd07d1d" bot_update
got_v8_revision_cp "refs/heads/7.3.39@{#1}" bot_update
got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25919}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  2. Andrew Comminos (acomminosohnoyoudont@fb.com)
  3. Justin Cohen (justincohenohnoyoudont@google.com)
  4. Ben Wagner (bungemanohnoyoudont@chromium.org)
  5. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  6. Ken MacKay (kmackayohnoyoudont@chromium.org)
  7. Jeremy Roman (jbromanohnoyoudont@chromium.org)
  8. Aiden Benner (abennerohnoyoudont@google.com)
  9. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  10. Katie Dillon (kdillonohnoyoudont@chromium.org)
  11. Clark DuVall (cduvallohnoyoudont@chromium.org)
  12. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  13. Jeffrey Yasskin (jyasskinohnoyoudont@chromium.org)
  14. Max Moroz (mmorozohnoyoudont@chromium.org)
  15. Chase Phillips (cmpohnoyoudont@chromium.org)
  16. Reilly Grant (reillygohnoyoudont@chromium.org)
  17. Jun Cai (juncaiohnoyoudont@chromium.org)
  18. Jun Mukai (mukaiohnoyoudont@chromium.org)
  19. Nektarios Paisios (nektarohnoyoudont@chromium.org)
  20. Etienne Pierre-Doray (etiennepohnoyoudont@chromium.org)
  21. Kyle Milka (kmilkaohnoyoudont@chromium.org)
  22. Scott Violet (skyohnoyoudont@chromium.org)
  23. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  24. Alex Newcomer (newcomerohnoyoudont@chromium.org)
  25. Theresa (twellingtonohnoyoudont@chromium.org)
  26. Joshua Peraza (jperazaohnoyoudont@chromium.org)
  27. Ian Kilpatrick (ikilpatrickohnoyoudont@chromium.org)
  28. Hongchan Choi (hongchanohnoyoudont@chromium.org)
  29. Erik Luo (luoeohnoyoudont@chromium.org)
  30. Anastasia Helfinstein (anastasiohnoyoudont@google.com)
  31. Bill Orr (billorrohnoyoudont@chromium.org)
  32. Reilly Grant (reillygohnoyoudont@chromium.org)
  33. Scott Violet (skyohnoyoudont@chromium.org)
  34. Ryan Tseng (hinokaohnoyoudont@chromium.org)
  35. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  36. Piotr Bialecki (bialpioohnoyoudont@chromium.org)
  37. chuanl (chuanlohnoyoudont@google.com)
  38. Kush Sinha (sinhakohnoyoudont@chromium.org)
  39. agrieve (agrieveohnoyoudont@chromium.org)
  40. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  41. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  42. Etienne Pierre-Doray (etiennepohnoyoudont@chromium.org)
  43. Andrew Xu (andrewxuohnoyoudont@chromium.org)
  44. Mohamed Amir Yosef (mamirohnoyoudont@chromium.org)
  45. Mounir Lamouri (mlamouriohnoyoudont@chromium.org)
  46. Eugene But (eugenebutohnoyoudont@google.com)
  47. iOS Autoroller (ios-autorollerohnoyoudont@chromium.org)
  48. Kurt Horimoto (kkhorimotoohnoyoudont@chromium.org)
  49. Sam Maier (smaierohnoyoudont@chromium.org)
  50. Stephane Zermatten (szermattohnoyoudont@chromium.org)
  51. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  52. Steven Bennetts (stevenjbohnoyoudont@chromium.org)
  53. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  54. jonross (jonrossohnoyoudont@chromium.org)
  55. sebsg (sebsgohnoyoudont@chromium.org)
  56. Henrik Grunell (grunellohnoyoudont@chromium.org)
  57. Ned Nguyen (nednguyenohnoyoudont@google.com)
  58. David Jean (djeanohnoyoudont@google.com)
  59. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  60. Jun Cai (juncaiohnoyoudont@chromium.org)
  61. Xida Chen (xidachenohnoyoudont@chromium.org)
  62. Guido Urdaneta (guidouohnoyoudont@chromium.org)
  63. Roger McFarlane (rogermohnoyoudont@chromium.org)
  64. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  65. Carlos Caballero (carlscabohnoyoudont@google.com)
  66. Dan Harrington (harringtondohnoyoudont@chromium.org)
  67. Elly Fong-Jones (ellyjonesohnoyoudont@chromium.org)
  68. Anthony Vallee-Dubois (anthonyvdohnoyoudont@chromium.org)
  69. Clemens Arbesser (arbesserohnoyoudont@google.com)
  70. Mason Freed (masonfreedohnoyoudont@chromium.org)
  71. Takuto Ikuta (tikutaohnoyoudont@chromium.org)
  72. Elly Fong-Jones (ellyjonesohnoyoudont@chromium.org)
  73. Takuto Ikuta (tikutaohnoyoudont@chromium.org)
  74. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  75. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  76. jdoerrie (jdoerrieohnoyoudont@chromium.org)
  77. Yi Su (mrsuyiohnoyoudont@chromium.org)
  78. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  79. Carlos Caballero (carlscabohnoyoudont@google.com)
  80. Vladimir Levin (vmpstrohnoyoudont@chromium.org)
  81. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  82. Jeremy Roman (jbromanohnoyoudont@chromium.org)
  83. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  84. Carlos Caballero (carlscabohnoyoudont@google.com)
  85. Carlos Caballero (carlscabohnoyoudont@google.com)
  86. Clemens Arbesser (arbesserohnoyoudont@google.com)
  87. Yi Gu (yiguohnoyoudont@chromium.org)
  88. Peng Huang (penghuangohnoyoudont@chromium.org)
  89. Xiyuan Xia (xiyuanohnoyoudont@chromium.org)
  90. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  91. Noel Gordon (noelohnoyoudont@chromium.org)
  92. Raphael Kubo da Costa (raphael.kubo.da.costaohnoyoudont@intel.com)
  93. Nicolas Pena (npmohnoyoudont@chromium.org)
  94. Takuto Ikuta (tikutaohnoyoudont@chromium.org)
  95. Raphael Kubo da Costa (raphael.kubo.da.costaohnoyoudont@intel.com)
  96. Sergey Kuznetsov (kuznetsovsohnoyoudont@yandex-team.ru)
  97. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  98. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  99. Andreea Costinas (acostinasohnoyoudont@google.com)
  100. Yi Su (mrsuyiohnoyoudont@chromium.org)
  101. <blame list capped at 100 commits> ()

Timing:

Create Thursday, 06-Dec-18 20:51:50 UTC
Start Thursday, 06-Dec-18 20:52:23 UTC
End Friday, 07-Dec-18 02:33:07 UTC
Pending 33 secs
Execution 5 hrs 40 mins

All Changes:

  1. Roll src/third_party/angle d300548fcc28..9092bdc7a76f (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 19:38:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ade4af4613155382362249d55cf0435932541483

    Comments

    Roll src/third_party/angle d300548fcc28..9092bdc7a76f (1 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/d300548fcc28..9092bdc7a76f
    
    
    git log d300548fcc28..9092bdc7a76f --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 ianelliott@google.com Fix crash in A4A opt-in/out logic.
    
    
    Created with:
      gclient setdep -r src/third_party/angle@9092bdc7a76f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=ynovikov@chromium.org
    
    Change-Id: I6cd9ec9ba8e9310f1ad0e5d615edd35732b8701d
    Reviewed-on: https://chromium-review.googlesource.com/c/1365980
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614452}

    Changed files

    • DEPS
  2. Check the source browsing context's CSP in Location::SetLocation prior to dispatching a navigation to a `javascript:` URL.

    Changed by Andrew Comminos - acomminosohnoyoudont@fb.com
    Changed at Thursday, 06-Dec-18 19:37:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0e3b0c22a5c596bdc24a391b3f02952c1c3e4f1b

    Comments

    Check the source browsing context's CSP in Location::SetLocation prior to dispatching a navigation to a `javascript:` URL.
    
    Makes `javascript:` navigations via window.location.href compliant with
    https://html.spec.whatwg.org/#navigate, which states that the source
    browsing context must be checked (rather than the current browsing
    context).
    
    Bug: 909865
    Change-Id: Id6aef6eef56865e164816c67eb9fe07ea1cb1b4e
    Reviewed-on: https://chromium-review.googlesource.com/c/1359823
    Reviewed-by: Andy Paicu <andypaicu@chromium.org>
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Andrew Comminos <acomminos@fb.com>
    Cr-Commit-Position: refs/heads/master@{#614451}

    Changed files

    • third_party/blink/renderer/core/frame/location.cc
    • third_party/blink/web_tests/external/wpt/content-security-policy/navigation/to-javascript-parent-initiated-parent-csp-disallow.html
  3. [ios] Add more metrics to iOS preload controller.

    Changed by Justin Cohen - justincohenohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 19:36:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 118fee6c362144aaf3fb5672556a6a849a8560f6

    Comments

    [ios] Add more metrics to iOS preload controller.
    
    Add histograms to track last committed index, time from
    prerender creation to release, and if it's from an NTP.
    
    Bug: 911763
    Change-Id: I3bfa423a8cb916f18002f0b6b25ba4f4b56eafa6
    Reviewed-on: https://chromium-review.googlesource.com/c/1361637
    Commit-Queue: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: Brian White <bcwhite@chromium.org>
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Reviewed-by: Peter Lee <pkl@chromium.org>
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614450}

    Changed files

    • ios/chrome/browser/prerender/preload_controller.mm
    • ios/chrome/browser/ui/browser_view_controller.mm
    • tools/metrics/histograms/histograms.xml
  4. Roll src/third_party/harfbuzz-ng/src/ 79e7e3445..6ad3fcdda (20 commits)

    Changed by Ben Wagner - bungemanohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:34:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d134629b8e55f8cd2aebadb417d464c27b26c2ee

    Comments

    Roll src/third_party/harfbuzz-ng/src/ 79e7e3445..6ad3fcdda (20 commits)
    
    https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/79e7e3445efe..6ad3fcddaf2b
    
    $ git log 79e7e3445..6ad3fcdda --date=short --no-merges --format='%ad %ae %s'
    2018-12-05 ariza add minimized test case for oss-fuzz issue 11714
    2018-12-05 ariza check number of blends against args on stack
    2018-12-05 ariza add minimized test case for oss-fuzz issue 11713
    2018-12-05 ariza sanitize variationStore in CFF2 against its size
    2018-12-05 ariza add minimized test case for oss-fuzz issue 11691
    2018-12-05 ariza sanitize CFF1 & CFF2 global subrs
    2018-12-05 ariza fix oss-fuzz issue 11675 (ASSERT: count <= str.len)
    2018-12-05 ariza minimized test case for oss-fuzz issue 11674
    2018-12-05 ariza fixed a bug with fractional part in a negative value
    2018-12-05 ebrahim [os2] Make newer table fields accessible (#1452)
    2018-12-05 ebrahim [fdsc] Implement the table parsing
    2018-12-05 ebrahim [gasp] Implement the table parsing
    2018-12-05 ariza fix unsigned long const
    2018-12-05 ariza fix signed/unsigned comparison
    2018-12-04 ariza use sized int types in parse_bcd
    2018-12-04 ariza refix
    2018-12-04 ariza fix bug
    2018-12-04 ariza fix typo
    2018-12-04 ariza include float.h
    2018-12-04 ariza check overflow & clamp
    
    Created with:
      roll-dep src/third_party/harfbuzz-ng/src
    R=bashi@chromium.org,behdad@chromium.org,behdad@google.com,drott@chromium.org,eae@chromium.org,jshin@chromium.org
    
    Change-Id: I0c9478f13e127622adddc8960008c4d970a447d9
    Reviewed-on: https://chromium-review.googlesource.com/c/1365803
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Ben Wagner <bungeman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614449}

    Changed files

    • DEPS
    • third_party/harfbuzz-ng/BUILD.gn
    • third_party/harfbuzz-ng/README.chromium
  5. Roll src/third_party/chromite 71928dd258ca..aee33ef79380 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 19:33:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dfeb488de5aaf3636ed9436c220e92a27ffec623

    Comments

    Roll src/third_party/chromite 71928dd258ca..aee33ef79380 (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/71928dd258ca..aee33ef79380
    
    
    git log 71928dd258ca..aee33ef79380 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 chrome-bot@chromium.org Update config settings by config-updater.
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@aee33ef79380
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I69a44dcdc025e42150d670631450c70f938af78a
    Reviewed-on: https://chromium-review.googlesource.com/c/1366195
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614448}

    Changed files

    • DEPS
  6. [Chromecast] Only enable CastAudioMixer where needed

    Changed by Ken MacKay - kmackayohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:31:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 79b4157706b6b2d702d4a431efe3e16a4d72bfc2

    Comments

    [Chromecast] Only enable CastAudioMixer where needed
    
    We only need the mixer in CastAudioManager when the CMA backend does not
    support mixing.
    
    Bug: internal b/79728288
    Change-Id: Ib2950350fd1b72bfd61d8cf42bbec47105e93927
    Reviewed-on: https://chromium-review.googlesource.com/c/1366259
    Reviewed-by: Sergey Volk <servolk@chromium.org>
    Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614447}

    Changed files

    • chromecast/browser/BUILD.gn
    • chromecast/browser/cast_content_browser_client.cc
    • chromecast/chromecast.gni
  7. Convert relaxed atomics in AudioHandler derived classes to use std::atomic.

    Changed by Jeremy Roman - jbromanohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:31:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3fa81b306229acf0f78dd41f8d3c89b6d5042596

    Comments

    Convert relaxed atomics in AudioHandler derived classes to use std::atomic.
    
    Bug: 736037
    Change-Id: I47b75930aceca3ec76f9816e0d76418b24e378bf
    Reviewed-on: https://chromium-review.googlesource.com/c/1363907
    Reviewed-by: Hongchan Choi <hongchan@chromium.org>
    Commit-Queue: Jeremy Roman <jbroman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614446}

    Changed files

    • third_party/blink/renderer/modules/webaudio/audio_param.cc
    • third_party/blink/renderer/modules/webaudio/audio_param.h
    • third_party/blink/renderer/modules/webaudio/dynamics_compressor_node.cc
    • third_party/blink/renderer/modules/webaudio/dynamics_compressor_node.h
  8. Add ErrorProne check to assert use of android.support.annotation.Nullable

    Changed by Aiden Benner - abennerohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 19:29:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f6f6371df0c9151ab37afb7ec65f15300a764edd

    Comments

    Add ErrorProne check to assert use of android.support.annotation.Nullable
    
    Adds an android ErrorProne check to give a compiler error
    when using javax Nullable instead of android Nullable.
    See bug for motivation.
    
    Bug: 771683
    Change-Id: I6384fa515405159e3fa894303022cad8bfc389b9
    Reviewed-on: https://chromium-review.googlesource.com/c/1363677
    Commit-Queue: Aiden Benner <abenner@google.com>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614445}

    Changed files

    • tools/android/errorprone_plugin/BUILD.gn
    • tools/android/errorprone_plugin/src/org/chromium/tools/errorprone/plugin/AndroidNullableCheck.java
  9. Roll src/third_party/skia 69e5785d9f00..ae9dfc0e5845 (6 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 19:28:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a218cc31ad1906bf93bf9d39c00b9a196bded00e

    Comments

    Roll src/third_party/skia 69e5785d9f00..ae9dfc0e5845 (6 commits)
    
    https://skia.googlesource.com/skia.git/+log/69e5785d9f00..ae9dfc0e5845
    
    
    git log 69e5785d9f00..ae9dfc0e5845 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 kjlubick@google.com [canvaskit] In Canvas2d, move matrix to internal canvas
    2018-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader bd49ad09c5ca..c730c3846064 (1 commits)
    2018-12-06 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2018-12-06 bsalomon@google.com Reland "Bypass interval tracking and assignment of read-only texures in GrResourceAllocator."
    2018-12-06 ethannicholas@google.com switched GrVkCopyManager to use secondary command buffer instead of AMD-specific workaround
    2018-12-06 bsalomon@google.com Revert "Use unnormalized coords all the way through with GL_TEXTURE_RECTANGLE textures."
    
    
    Created with:
      gclient setdep -r src/third_party/skia@ae9dfc0e5845
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jcgregorio@chromium.org
    
    Change-Id: Ie5bd98d000c45bc295618bbb85e0b6b816624d3b
    Reviewed-on: https://chromium-review.googlesource.com/c/1365758
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614444}

    Changed files

    • DEPS
  10. Exposing ErrorEvent interface to workers.

    Changed by Katie Dillon - kdillonohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:24:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ef7e4c4dcae40ae9c40823847f748e80346ae71

    Comments

    Exposing ErrorEvent interface to workers.
    
    According to current specs (https://html.spec.whatwg.org/#the-errorevent-interface)
    the ErrorEvent interface should be exposed to the window and workers.
    
    Bug: 852769
    Change-Id: I38b057113fa6f56d473b75a7f328635f46f73af5
    Reviewed-on: https://chromium-review.googlesource.com/c/1362003
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Katie Dillon <kdillon@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614443}

    Changed files

    • third_party/blink/renderer/core/events/error_event.idl
    • third_party/blink/web_tests/TestExpectations
    • third_party/blink/web_tests/external/wpt/WebIDL/ecmascript-binding/no-regexp-special-casing.any.worker-expected.txt
    • third_party/blink/web_tests/external/wpt/workers/semantics/interface-objects/001.worker-expected.txt
    • third_party/blink/web_tests/external/wpt/workers/semantics/interface-objects/003-expected.txt
    • third_party/blink/web_tests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
    • third_party/blink/web_tests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
    • third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
    • third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
    • third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
    • third_party/blink/web_tests/webexposed/global-interface-listing-shared-worker-expected.txt
  11. Allow third party cookies for requests from chrome-extension schemes

    Changed by Clark DuVall - cduvallohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:17:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 042756580e2aa3917d3215744f8428d3a4b672b4

    Comments

    Allow third party cookies for requests from chrome-extension schemes
    
    This fixes a regression where requests from extension background pages
    were not getting third party cookies. XHR requests from extensions
    should be allowed to see cookies from URLs that are listed in the
    permissions of the manifest, even if third party cookies are blocked.
    
    A previous change (http://crrev.com/c/1195147) missed this bit of
    functionality from here:
    https://cs.chromium.org/chromium/src/components/content_settings/core/browser/cookie_settings.cc?l=126&rcl=43732e6d56e5b5556590891fcbdb3c53a44fad5f
    
    Bug: 788738
    Change-Id: Ie239f7077772513f54c9d2a9c811774986d24506
    Reviewed-on: https://chromium-review.googlesource.com/c/1364696
    Reviewed-by: Will Harris <wfh@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Clark DuVall <cduvall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614442}

    Changed files

    • chrome/browser/net/network_context_configuration_browsertest.cc
    • chrome/browser/net/profile_network_context_service.cc
    • services/network/cookie_manager.cc
    • services/network/cookie_settings.cc
    • services/network/cookie_settings.h
    • services/network/cookie_settings_unittest.cc
    • services/network/public/mojom/cookie_manager.mojom
  12. Roll src/third_party/perfetto 6ae9526278fc..2d82f1496ad6 (5 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 19:16:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6f57571795c09e55baf346db98141204a3a62f65

    Comments

    Roll src/third_party/perfetto 6ae9526278fc..2d82f1496ad6 (5 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/6ae9526278fc..2d82f1496ad6
    
    
    git log 6ae9526278fc..2d82f1496ad6 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 fmayer@google.com Add script to continuously pull and run fuzzers.
    2018-12-06 fmayer@google.com Merge "Add script to run all fuzzers."
    2018-12-06 hjd@google.com Merge "trace_processor: Add regression test for span join two views"
    2018-12-06 hjd@google.com Merge "perfetto-ui: Add profileable query UI"
    2018-12-06 eseckler@google.com Fix TracingServiceImplTest.CommitToForbiddenBufferIsDiscarded on debug.
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@2d82f1496ad6
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:69150303
    TBR=perfetto-bugs@google.com
    
    Change-Id: I7acb4631e389a069d1114f01135ac8354d3950cc
    Reviewed-on: https://chromium-review.googlesource.com/c/1365759
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614441}

    Changed files

    • DEPS
  13. Revert "Disable the new tab-loading animation"

    Changed by Jeffrey Yasskin - jyasskinohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:13:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 742b8857c4dd0ab4550f7b2c1f200ce5be406b9c

    Comments

    Revert "Disable the new tab-loading animation"
    
    This reverts commit 355b8185716292a8f145c77168ee89148ecabf31.
    
    Reason for revert: Made several tests flaky: https://crbug.com/912543
    
    Original change's description:
    > Disable the new tab-loading animation
    > 
    > Makes sure that a lot of animation-related code is bypassed when the
    > new-tab-animation flag is off. This should hopefully fix a couple of
    > performance regressions that have not yet been root caused so that they
    > don't go out with M72.
    > 
    > Bug: chromium:912328, chromium:905745, chromium:905918, chromium:910265
    > Change-Id: Id3f131db427eb3ee1618d6c9683fd5e47dc134e8
    > Reviewed-on: https://chromium-review.googlesource.com/c/1364212
    > Reviewed-by: Sidney San Martín <sdy@chromium.org>
    > Commit-Queue: Peter Boström <pbos@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614199}
    
    TBR=pbos@chromium.org,sdy@chromium.org
    
    Change-Id: Ib4c022a255ad085c1716d3559a7f84dcb61c2785
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:912328, chromium:905745, chromium:905918, chromium:910265
    Reviewed-on: https://chromium-review.googlesource.com/c/1366359
    Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
    Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614440}

    Changed files

    • chrome/browser/ui/views/tabs/tab_icon.cc
    • chrome/browser/ui/views/tabs/tab_unittest.cc
    • chrome/common/chrome_features.cc
  14. Reland "Switch all libFuzzer and AFL builds (except Windows) to is_component_build=true."

    Changed by Max Moroz - mmorozohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:11:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b9f77956c8f6e93ff67ad7ef5ae6d1528ae367c1

    Comments

    Reland "Switch all libFuzzer and AFL builds (except Windows) to is_component_build=true."
    
    This is a reland of 446c61f501b4b971c63ba40e1667e5b0d8ca76c8
    
    The reason for the previous revert should be fixed now by https://crrev.com/c/1362457
    
    Original change's description:
    > Switch all libFuzzer and AFL builds (except Windows) to is_component_build=true.
    >
    > Bug: 701825
    > Change-Id: I4b361daa1eae576f402818b467684efa5380df88
    > Reviewed-on: https://chromium-review.googlesource.com/c/1361297
    > Commit-Queue: Max Moroz <mmoroz@chromium.org>
    > Reviewed-by: Jonathan Metzman <metzman@chromium.org>
    > Reviewed-by: Ben Pastene <bpastene@chromium.org>
    > Reviewed-by: Abhishek Arya <inferno@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#613700}
    
    Bug: 701825
    Change-Id: I6f6336f7203600a62f760866a54ad03281dd6c13
    Reviewed-on: https://chromium-review.googlesource.com/c/1365084
    Reviewed-by: Abhishek Arya <inferno@chromium.org>
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Commit-Queue: Max Moroz <mmoroz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614439}

    Changed files

    • tools/mb/mb_config.pyl
  15. IndexedDB: Map mojom key to blink IDBKey

    Changed by Chase Phillips - cmpohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:11:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f56c0db093f876ac4dc8326b4ef396f458053ce4

    Comments

    IndexedDB: Map mojom key to blink IDBKey
    
    Bug: 717812
    Change-Id: I59d74bd808e2a7e30264ec3a8dafd30964552f0a
    Reviewed-on: https://chromium-review.googlesource.com/c/1354334
    Commit-Queue: Chase Phillips <cmp@chromium.org>
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Reviewed-by: Daniel Murphy <dmurph@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614438}

    Changed files

    • third_party/blink/renderer/bindings/modules/v8/v8_binding_for_modules_test.cc
    • third_party/blink/renderer/modules/indexeddb/BUILD.gn
    • third_party/blink/renderer/modules/indexeddb/idb_cursor.cc
    • third_party/blink/renderer/modules/indexeddb/idb_factory.cc
    • third_party/blink/renderer/modules/indexeddb/idb_key.cc
    • third_party/blink/renderer/modules/indexeddb/idb_key.h
    • third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
    • third_party/blink/renderer/modules/indexeddb/idb_value.cc
    • third_party/blink/renderer/modules/indexeddb/idb_value.h
    • third_party/blink/renderer/modules/indexeddb/indexed_db_blink.typemap
    • third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.cc
    • third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.h
    • third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
    • third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.h
    • third_party/blink/renderer/modules/indexeddb/indexed_db_key_builder.cc
    • third_party/blink/renderer/modules/indexeddb/indexed_db_key_builder.h
    • third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.cc
    • third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.h
    • third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.cc
    • third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_callbacks.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_cursor.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_database.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_database_impl_unittest.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_key.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_key.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_key_range.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_key_range.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_value.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_value.h
  16. [bluetooth][win] Force uncached characteristic value reads

    Changed by Reilly Grant - reillygohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:07:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d810f68079066a4a8f9e9a3c3730fc1bcdf72f7a

    Comments

    [bluetooth][win] Force uncached characteristic value reads
    
    The ReadValueAsync() method will return the characteristic value
    cached by Windows. It appears that when a value is written to a
    characteristic Windows assumes that the device will respond with the
    value written and will update its cache to that value. This is a
    problem for devices which do not follow this behavior and instead
    respond with an unrelated value.
    
    This change switches to using the ReadValueWithCacheModeAsync() method
    and passes the BluetoothCacheMode_Uncached flag in order to force
    Windows to always read the value directly from the device.
    
    Bug: 904114
    Change-Id: I76b214abd0004fc311e1f32a9457273df60a6f54
    Reviewed-on: https://chromium-review.googlesource.com/c/1364393
    Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Commit-Queue: Reilly Grant <reillyg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614437}

    Changed files

    • device/bluetooth/bluetooth_remote_gatt_characteristic_winrt.cc
    • device/bluetooth/test/fake_gatt_characteristic_winrt.cc
  17. Revert "Network Service: Migrate drive::JobScheduler to NetworkConnectionTracker"

    Changed by Jun Cai - juncaiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:06:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bee8665911f1e87abbd90b9aa4e0ccb141ee2575

    Comments

    Revert "Network Service: Migrate drive::JobScheduler to NetworkConnectionTracker"
    
    This reverts commit e2d41b1393eb57790a1634640b1aa149a7c5fc24.
    
    Reason for revert:
    linux-chromeos-rel bot failed at:
    https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/16932
    
    Original change's description:
    > Network Service: Migrate drive::JobScheduler to NetworkConnectionTracker
    > 
    > This CL migrates drive::JobScheduler from NetworkChangeNotifier to
    > NetworkConnectionTracker, which works with the network service enabled.
    > 
    > The "Initial upload" patch of this CL is the same as:
    > https://chromium-review.googlesource.com/c/chromium/src/+/1236558
    > 
    > Bug: 887038
    > Change-Id: Ib19f501f6a85a0c32dc81d47ea4b161b5a726efe
    > Reviewed-on: https://chromium-review.googlesource.com/c/1287040
    > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
    > Reviewed-by: Naoki Fukino <fukino@chromium.org>
    > Commit-Queue: Jun Cai <juncai@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614393}
    
    TBR=hashimoto@chromium.org,fukino@chromium.org,juncai@chromium.org
    
    Change-Id: I72e70bae035cab91ec3d325d7aec66d9f90b5499
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 887038
    Reviewed-on: https://chromium-review.googlesource.com/c/1366260
    Reviewed-by: Jun Cai <juncai@chromium.org>
    Commit-Queue: Jun Cai <juncai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614436}

    Changed files

    • chrome/browser/chromeos/drive/drive_integration_service.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
    • components/drive/about_resource_loader_unittest.cc
    • components/drive/change_list_loader_unittest.cc
    • components/drive/directory_loader_unittest.cc
    • components/drive/file_system/operation_test_base.cc
    • components/drive/file_system_unittest.cc
    • components/drive/job_scheduler.cc
    • components/drive/job_scheduler.h
    • components/drive/job_scheduler_unittest.cc
    • components/drive/start_page_token_loader_unittest.cc
    • components/drive/sync_client_unittest.cc
    • components/drive/team_drive_change_list_loader_unittest.cc
    • components/drive/team_drive_list_loader_unittest.cc
  18. Remove dependency on WindowTreeHost from UIControlsOzone in Mus

    Changed by Jun Mukai - mukaiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:06:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8dbf8cb7525f089bfb08506c2ac7e40dccf49ac0

    Comments

    Remove dependency on WindowTreeHost from UIControlsOzone in Mus
    
    The WindowTreeHost is tied with a toplevel window in Mus; removal
    of WindowTreeHost can happen very easily.
    
    Note that this CL only allows two of the three reported failures
    DetachToBrowserTabDragControllerTest.DragAllToSeparateWindow
    DetachToBrowserTabDragControllerTest.DragAllToSeparateWindowAndCancel
    
    DetachToBrowserTabDragControllerTest.DragSingleTabToSeparateWindow
    is confirmed not crashing, but failing anyways.
    
    Bug: 910791
    Test: single_process_mash_interactive_ui_tests
    Change-Id: If2edb91951e01df13c510a1cd71d1d0ed6d45244
    Reviewed-on: https://chromium-review.googlesource.com/c/1363854
    Commit-Queue: Jun Mukai <mukai@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614435}

    Changed files

    • chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
    • ui/aura/test/ui_controls_factory_ozone.cc
  19. AXNodeData: Adds the ability to remove attributes and doesn't allow duplicate attributes to be added

    Changed by Nektarios Paisios - nektarohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:05:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 95fc875c1a7130a6f6e319bacb6c5bc1ea9e1f09

    Comments

    AXNodeData: Adds the ability to remove attributes and doesn't allow duplicate attributes to be added
    
    When trying to work with AXVirtualViews in order to make TableView and TreeView accessible, one quickly realizes that it is not efficient to destroy and re-create all the accessibility nodes that are affected by a selection change.
    While this is inevitable if crossing a process boundary, e.g. serializing and sending modifications to the accessibility tree from the renderer to the browser, it is unnecessary in Views since they run in the same process.
    Instead of destroying and re-creating the accessibility nodes every time the user moves inside these controls, it's better to simply modify a few attributes, such as the focused state and selected bool attribute.
    Also took the opportunity to disallow adding duplicate attributes because this has been a source of bugs in the past.
    Instead of a DCHECK I prefer to remove the old attribute and add the new one, because this will not break any existing code.
    R=aleventhal@chromium.org, dmazzoni@chromium.org
    
    Change-Id: I34e566b0d5c9c6b8e2e33187996236913ec6a5b3
    Reviewed-on: https://chromium-review.googlesource.com/c/1365802
    Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614434}

    Changed files

    • ui/accessibility/ax_node_data.cc
    • ui/accessibility/ax_node_data.h
  20. [TaskScheduler]: Migrate off of AssertBlockingAllowedDeprecated in /chrome/browser/app_controller_mac.mm

    Changed by Etienne Pierre-Doray - etiennepohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:02:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a620e5ec9ccbf30be37fd4004d95ed3c2032334d

    Comments

    [TaskScheduler]: Migrate off of AssertBlockingAllowedDeprecated in /chrome/browser/app_controller_mac.mm
    
    base::AssertBlockingAllowedDeprecated is deprecated in favor of
    ScopedBlockingCall, which serves as a precise annotation of
    the scope that may/will block.
    
    Please make sure of the following:
      - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
        If this is not the case, ScopedBlockingCall should be instantiated
        closer to the blocking call. See scoped_blocking_call.h for more
        info. Please let me know when/where the blocking call happens if this needs
        to be changed.
      - Parameter |blocking_type| matches expectation:
          MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
          WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
            server synchronously).
        See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
        not be the best fit if we know that this callsite is guaranteed to block.
      - The ScopedBlockingCall's scope covers the entirety of the blocking operation
        previously asserted against by the AssertBlockingAllowed().
      - Calls to blocking //base APIs don't need to be annotated
        with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read,
        base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their
        own internal annotations.
    
    Refer to the top-level CL if necessary :
    https://chromium-review.googlesource.com/c/chromium/src/+/1338391
    
    Please CQ if LGTY!
    
    This CL was uploaded by git cl split.
    
    R=mark@chromium.org
    
    Bug: 903957
    Change-Id: I6b8a4fa67bfabb263bf80d78fb3ca8a295b3fcab
    Reviewed-on: https://chromium-review.googlesource.com/c/1366075
    Reviewed-by: Mark Mentovai <mark@chromium.org>
    Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614433}

    Changed files

    • chrome/browser/app_controller_mac.mm
  21. [NTP] Remove UI MD flag

    Changed by Kyle Milka - kmilkaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 19:00:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0896159f33c40980e46c43ff7c56c84dcf7b4aa1

    Comments

    [NTP] Remove UI MD flag
    
    Remove flag for ntp md ui. Change the new styling to be the
    default and remove the md class, this mainly affects the fakebox
    as the icons are styled via md-icons.
    
    Mostly a reland of https://crrev.com/c/1265024.
    
    Bug: 905386
    Change-Id: I62db12fe3cea1e85ed615f1ad2fbb9ea211f585e
    Reviewed-on: https://chromium-review.googlesource.com/c/1361720
    Reviewed-by: Kristi Park <kristipark@chromium.org>
    Reviewed-by: Brian White <bcwhite@chromium.org>
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Kyle Milka <kmilka@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614432}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag-metadata.json
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • chrome/browser/resources/local_ntp/local_ntp.css
    • chrome/browser/resources/local_ntp/local_ntp.js
    • chrome/browser/search/local_ntp_source.cc
    • chrome/browser/search/ntp_features.cc
    • chrome/browser/search/ntp_features.h
    • chrome/browser/ui/search/local_ntp_browsertest.cc
    • chrome/test/data/local_ntp/local_ntp_browsertest.js
    • testing/variations/fieldtrial_testing_config.json
  22. chromeos: add LOG to figure out crash

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:59:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bd76e5f452c349df7a9febf422932f67e50dc50a

    Comments

    chromeos: add LOG to figure out crash
    
    CHECK() in an official build eats its parameters. Add a LOG statement to help
    figure out why CHECK() is being hit.
    
    BUG=912228
    TEST=none
    
    Change-Id: I6fd0ffc04eb1db128f10acee7a1ed5131980e486
    Reviewed-on: https://chromium-review.googlesource.com/c/1365835
    Reviewed-by: James Cook <jamescook@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614431}

    Changed files

    • ui/aura/mus/in_flight_change.cc
  23. Roll src/third_party/SPIRV-Tools/src 2e4563d94f9d..aa270e568a3f (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 18:50:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a21025682fd1c24239ed4808f1c1870f74f5bb19

    Comments

    Roll src/third_party/SPIRV-Tools/src 2e4563d94f9d..aa270e568a3f (1 commits)
    
    https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2e4563d94f9d..aa270e568a3f
    
    
    git log 2e4563d94f9d..aa270e568a3f --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 stevenperron@google.com Be more explicit about SPIRV_WERROR option. (#2141)
    
    
    Created with:
      gclient setdep -r src/third_party/SPIRV-Tools/src@aa270e568a3f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: Ifb3e0f98bcb32754e848a5a9822efd67723b982f
    Reviewed-on: https://chromium-review.googlesource.com/c/1365757
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614430}

    Changed files

    • DEPS
  24. cros: Update AppsGridView bottom drag buffer

    Changed by Alex Newcomer - newcomerohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:49:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9504f17bdd7940d0d8064259f57291baa895002e

    Comments

    cros: Update AppsGridView bottom drag buffer
    
    The AppsGridView is transformed to fit on screens that use display zoom.
    
    Use the current transform to calculate the bottom of the AppsGridView,
    then consider all drags below AppsGridView "in the buffer". The old
    buffer values do not make sense with the redesign, and with a scaled
    display.
    
    Bug: 907914
    Change-Id: I40e15fc8ba4f1022a9def18ac97fd0bab0d2d031
    Reviewed-on: https://chromium-review.googlesource.com/c/1354479
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: Alex Newcomer <newcomer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614429}

    Changed files

    • ash/app_list/views/apps_grid_view.cc
    • ash/app_list/views/apps_grid_view_unittest.cc
  25. [EoC] Fix and re-enable in-product help test and add a new one

    Changed by Theresa - twellingtonohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:47:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e0b574a4d998f620204f784c8e7cb02b9aa941d8

    Comments

    [EoC] Fix and re-enable in-product help test and add a new one
    
    The FakeTracker used to stub out the feature engagement system never
    triggered the onInitializedCallback, so the test was failing because
    ContextualSuggestionsMediator#mCanShowIph never got set to true.
    
    Trigger the callback as soon as FakeTracker#addOnInitializedCallback is
    called, re-enable the EoC test and add a new test for the IPH variant
    that requires a reverse scroll.
    
    BUG=890947
    
    Change-Id: Idcaf4435a585b738b7421e7510f24b146d536403
    Reviewed-on: https://chromium-review.googlesource.com/c/1362434
    Commit-Queue: Theresa <twellington@chromium.org>
    Reviewed-by: Becky Zhou <huayinz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614428}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/contextual_suggestions/FakeTracker.java
  26. android: Implement DumpWithoutCrashing() from child processes

    Changed by Joshua Peraza - jperazaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:45:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6b424b920a9170a35eb79ffb283078f4598f6716

    Comments

    android: Implement DumpWithoutCrashing() from child processes
    
    Bug: 911834
    Change-Id: I1901745a79f40748791d5c9a0dee1f45fb7ca88a
    Reviewed-on: https://chromium-review.googlesource.com/c/1362189
    Reviewed-by: Mark Mentovai <mark@chromium.org>
    Commit-Queue: Joshua Peraza <jperaza@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614427}

    Changed files

    • components/crash/content/app/crashpad.cc
    • components/crash/content/app/crashpad_linux.cc
    • components/crash/content/browser/crash_handler_host_linux.cc
  27. [LayoutNG] Simplify & correct static position for OOF positioned.

    Changed by Ian Kilpatrick - ikilpatrickohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:41:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f77f8ad37d9fe5ad966d482e601671a588e68207

    Comments

    [LayoutNG] Simplify & correct static position for OOF positioned.
    
    This patch is primarily simplifies how we determine the static position
    for an OOF positioned node, within the inline context.
    
    There are many fixes, (see test cases).
    
    Additionally, fixed positioned nodes, now work when they have an inline
    level containing block.
    
    Bug: 636993
    Change-Id: I36b573578fc85d9ba9b757f258ec7391eec73c0a
    Reviewed-on: https://chromium-review.googlesource.com/c/1356999
    Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
    Reviewed-by: Aleks Totic <atotic@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614426}

    Changed files

    • third_party/blink/renderer/core/layout/ng/geometry/ng_logical_offset.cc
    • third_party/blink/renderer/core/layout/ng/geometry/ng_logical_offset.h
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_box_state.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_box_state.h
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm.h
    • third_party/blink/renderer/core/layout/ng/inline/ng_line_box_fragment_builder.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_line_box_fragment_builder.h
    • third_party/blink/renderer/core/layout/ng/ng_box_fragment_builder.cc
    • third_party/blink/renderer/core/layout/ng/ng_box_fragment_builder.h
    • third_party/blink/renderer/core/layout/ng/ng_container_fragment_builder.cc
    • third_party/blink/renderer/core/layout/ng/ng_container_fragment_builder.h
    • third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.cc
    • third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.h
    • third_party/blink/renderer/core/layout/ng/ng_out_of_flow_positioned_descendant.h
    • third_party/blink/web_tests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/blink/web_tests/TestExpectations
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/htb-ltr-ltr.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/htb-ltr-rtl.tentative.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/htb-ref.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/htb-rtl-ltr.tentative.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/htb-rtl-rtl.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/vlr-ltr-ltr.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/vlr-ltr-rtl.tentative.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/vlr-ref.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/vlr-rtl-ltr.tentative.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/vlr-rtl-rtl.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/vrl-ltr-ltr.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/vrl-ltr-rtl.tentative.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/vrl-ref.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/vrl-rtl-ltr.tentative.html
    • third_party/blink/web_tests/external/wpt/css/css-position/static-position/vrl-rtl-rtl.html
  28. Remove LOG(ERROR)s for debugging purpose

    Changed by Hongchan Choi - hongchanohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:38:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e9735f4354b21bdb795cb75ce70b7d51178ebaab

    Comments

    Remove LOG(ERROR)s for debugging purpose
    
    Multiple LOG(ERROR)s were introduced by the CL
    (https://chromium-review.googlesource.com/c/1355333) but it looks like
    a mistake.
    
    Change-Id: Id3ab8dc6ab999ef37f4d6c0d05985be0e48a5c64
    Reviewed-on: https://chromium-review.googlesource.com/c/1365551
    Commit-Queue: Hongchan Choi <hongchan@chromium.org>
    Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614425}

    Changed files

    • third_party/blink/renderer/modules/webaudio/audio_context.cc
  29. DevTools: enable Console keyboard navigation by default

    Changed by Erik Luo - luoeohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:37:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 48789ec6e4da515fdeda4ec1c3d569a06466790c

    Comments

    DevTools: enable Console keyboard navigation by default
    
    Bug: 865674
    Change-Id: I6f1bf84a2113f64cc0c00839067f4e41ca72f483
    Reviewed-on: https://chromium-review.googlesource.com/c/1330295
    Commit-Queue: Erik Luo <luoe@chromium.org>
    Reviewed-by: Joel Einbinder <einbinder@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614424}

    Changed files

    • third_party/blink/renderer/devtools/front_end/main/Main.js
  30. Prepare Switch Access event handler for mash.

    Changed by Anastasia Helfinstein - anastasiohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 18:35:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 74fe33533bbf0873b3944bffe8c9ec0f4f3f5ce0

    Comments

    Prepare Switch Access event handler for mash.
    
    Create a Switch Access event handler in ash/, and convert the current
    handler in chrome/ to a delegate.
    
    Bug: 905439
    Change-Id: I7cca3cf8883f1e1fd0bfa6f5c02797ce020b46b5
    Reviewed-on: https://chromium-review.googlesource.com/c/1354037
    Reviewed-by: James Cook <jamescook@chromium.org>
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Reviewed-by: David Tseng <dtseng@chromium.org>
    Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
    Cr-Commit-Position: refs/heads/master@{#614423}

    Changed files

    • ash/BUILD.gn
    • ash/accessibility/accessibility_controller.cc
    • ash/accessibility/accessibility_controller.h
    • ash/events/OWNERS
    • ash/events/switch_access_event_handler.cc
    • ash/events/switch_access_event_handler.h
    • ash/events/switch_access_event_handler_unittest.cc
    • ash/public/interfaces/accessibility_controller.mojom
    • chrome/browser/accessibility/accessibility_extension_api.cc
    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/accessibility/accessibility_manager.cc
    • chrome/browser/chromeos/accessibility/accessibility_manager.h
    • chrome/browser/chromeos/accessibility/switch_access_browsertest.cc
    • chrome/browser/chromeos/accessibility/switch_access_event_handler.cc
    • chrome/browser/chromeos/accessibility/switch_access_event_handler.h
    • chrome/browser/chromeos/accessibility/switch_access_event_handler_delegate.cc
    • chrome/browser/chromeos/accessibility/switch_access_event_handler_delegate.h
    • chrome/browser/chromeos/preferences.cc
    • chrome/browser/ui/ash/accessibility/accessibility_controller_client_unittest.cc
  31. Fix watchlist and owners for chrome/services/isolated_xr_device

    Changed by Bill Orr - billorrohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:27:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 165281bde1ac0911644f1bc947c9a1e4e37af0f7

    Comments

    Fix watchlist and owners for chrome/services/isolated_xr_device
    
    Fix watchlist and owners for chrome/services/isolated_xr_device.
    
    Change-Id: I26bcb8301a1d0e79850a8218fc1b8bb961efaca0
    Reviewed-on: https://chromium-review.googlesource.com/c/1364337
    Reviewed-by: David Dorwin <ddorwin@chromium.org>
    Commit-Queue: Bill Orr <billorr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614422}

    Changed files

    • WATCHLISTS
    • chrome/services/isolated_xr_device/OWNERS
  32. Mark expired Bluetooth Socket histograms obsolete

    Changed by Reilly Grant - reillygohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:23:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ef14b6505703c04034ac99d6b4231b40ed6cac6d

    Comments

    Mark expired Bluetooth Socket histograms obsolete
    
    Code to generate these histograms was removed in r614051.
    
    Bug: 899953,899957,899960
    Change-Id: Ie667a64fffe45f0ae8bcf436eb6be991262cdec0
    Reviewed-on: https://chromium-review.googlesource.com/c/1363953
    Reviewed-by: Jesse Doherty <jwd@chromium.org>
    Commit-Queue: Reilly Grant <reillyg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614421}

    Changed files

    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  33. chromeos: refactor LockWindow

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:22:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b1e4803dd916d499f16209589ff06a0745a8e474

    Comments

    chromeos: refactor LockWindow
    
    LockWindow is used from both chrome and ash. LockWindow reaches directly into
    ash and parents a widget to ash's hierarchy. This won't work from the chrome
    side. The code has been refactored in two ways:
    
    . ash specific functionality has been moved into LockLayoutManager.
    . a factory function for creating the widget is added to ash/public/cpp. The
      function takes an argument that dictates how it works. Specifically in
      ash code the parent is supplied, outside of ash the container id is used.
    
    BUG=899862
    TEST=covered by tests
    
    Change-Id: I4c0ca9c91948df9f653f5cb97bb6bc1c48c09301
    Reviewed-on: https://chromium-review.googlesource.com/c/1364076
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614420}

    Changed files

    • ash/BUILD.gn
    • ash/login/login_screen_controller.cc
    • ash/login/login_screen_test_api.cc
    • ash/login/ui/lock_screen.cc
    • ash/login/ui/lock_screen.h
    • ash/login/ui/lock_window.cc
    • ash/login/ui/lock_window.h
    • ash/login/ui/lock_window_unittest.cc
    • ash/login/ui/login_bubble.cc
    • ash/public/cpp/BUILD.gn
    • ash/public/cpp/lock_screen_widget_factory.cc
    • ash/public/cpp/lock_screen_widget_factory.h
    • ash/shelf/login_shelf_view.cc
    • ash/system/message_center/ash_message_center_lock_screen_controller.cc
    • ash/system/tray/tray_background_view.cc
    • ash/wm/lock_layout_manager.cc
    • chrome/browser/chromeos/login/lock/DEPS
    • chrome/browser/chromeos/login/lock/webui_screen_locker.cc
    • chrome/browser/chromeos/login/lock/webui_screen_locker.h
    • testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
  34. Revert "Replace blink::ToIsolate(ExecutionContext) with blink::ExecutionContext->GetIsolate()"

    Changed by Ryan Tseng - hinokaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:13:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e908ae1d722150daddb6a3074842d564e29b6694

    Comments

    Revert "Replace blink::ToIsolate(ExecutionContext) with blink::ExecutionContext->GetIsolate()"
    
    This reverts commit e206e5c21ee57618fc3c7fa9d59a60360d39f711.
    
    Reason for revert: Crashing
    Crash report: crbug.com/912480
    Fuzzer report: crbug.com/912451
    
    Likely due to nullptr contexts passed in blink::probe::AsyncTaskCanceled() and blink::probe::AsyncTaskCanceledBreakable()
    
    Original change's description:
    > Replace blink::ToIsolate(ExecutionContext) with blink::ExecutionContext->GetIsolate()
    > 
    > And remove blink::ToIsolate(ExecutionContext) altogether.
    > 
    > Bug: 889542
    > Change-Id: I33e787acbde47b76cceb77288c82356bc5fa8411
    > Reviewed-on: https://chromium-review.googlesource.com/c/1355944
    > Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    > Reviewed-by: Kentaro Hara <haraken@chromium.org>
    > Commit-Queue: Ryan Tseng <hinoka@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614197}
    
    TBR=hinoka@chromium.org,yukishiino@chromium.org,haraken@chromium.org
    
    Change-Id: Icea742f3e380e87491d1a8606cf7c10e5c2a7c4c
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 889542
    Reviewed-on: https://chromium-review.googlesource.com/c/1365881
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    Commit-Queue: Ryan Tseng <hinoka@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614419}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/script_event_listener.cc
    • third_party/blink/renderer/bindings/core/v8/script_promise_property_base.cc
    • third_party/blink/renderer/bindings/core/v8/script_promise_property_test.cc
    • third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.cc
    • third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h
    • third_party/blink/renderer/core/frame/csp/content_security_policy.cc
    • third_party/blink/renderer/core/html/html_frame_element_base.cc
    • third_party/blink/renderer/core/messaging/message_port.cc
    • third_party/blink/renderer/core/probe/core_probes.cc
    • third_party/blink/renderer/core/trustedtypes/trusted_types_util.cc
    • third_party/blink/renderer/core/workers/dedicated_worker.cc
    • third_party/blink/renderer/core/workers/dedicated_worker_messaging_proxy.cc
    • third_party/blink/renderer/core/workers/experimental/task.cc
    • third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc
    • third_party/blink/renderer/modules/indexeddb/idb_key_range.cc
    • third_party/blink/renderer/modules/payments/abort_payment_respond_with_observer.cc
    • third_party/blink/renderer/modules/payments/can_make_payment_respond_with_observer.cc
    • third_party/blink/renderer/modules/payments/payment_request_respond_with_observer.cc
    • third_party/blink/renderer/modules/service_worker/fetch_respond_with_observer.cc
    • third_party/blink/renderer/modules/time_zone_monitor/time_zone_monitor_client.cc
  35. [Signin][Android] Remove password field from AccountHolder

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:08:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 94fa8ee397d7527c33e9be475fce4ca18bfd6e12

    Comments

    [Signin][Android] Remove password field from AccountHolder
    
    This CL removes password field from
    org.chromium.components.signin.test.util.AccountHolder and related test
    classes. This field is never used and doesn't make much sense in current
    account management model.
    
    Bug: None
    Change-Id: I207476bdad1f0059fcab4893d326b7463f4f85f2
    Reviewed-on: https://chromium-review.googlesource.com/c/1365591
    Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614418}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PasswordViewingTypeTest.java
    • chrome/android/javatests/src/org/chromium/chrome/test/util/ChromeSigninUtilsTest.java
    • chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeSigninUtils.java
    • components/signin/core/browser/android/javatests/src/org/chromium/components/signin/test/util/AccountHolder.java
  36. Modify aar.py to enumerate .so files

    Changed by Piotr Bialecki - bialpioohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:07:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6065e789cb75b094748d6a55f74a7508039e8bd3

    Comments

    Modify aar.py to enumerate .so files
    
    Modify android_aar_prebuilt template in android/rules.gni to
    leverage information about native libraries in aar archive
    and unpack them.
    
    The above changes are needed to allow us to cleanly
    take a dependency on ARCore.
    
    Bug: 887669
    Change-Id: I32f9d4fd284c9357bcc115f3ee14ca72cfdd684d
    Reviewed-on: https://chromium-review.googlesource.com/c/1362288
    Reviewed-by: Bill Orr <billorr@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614417}

    Changed files

    • build/android/gyp/aar.py
    • build/config/android/rules.gni
  37. Add setTopBarHeight in ActivityHostImpl.

    Changed by chuanl - chuanlohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 18:06:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c01a2a44506aafbb2ff2d7a8c610260b74982138

    Comments

    Add setTopBarHeight in ActivityHostImpl.
    
    This is guarded by the CCTModuleCustomHeader Finch feature.
    
    Bug: 882404
    Change-Id: I118b6d859596e321cb2f058ee3f370c8c26eb41e
    Reviewed-on: https://chromium-review.googlesource.com/c/1333653
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Reviewed-by: Matthew Jones <mdjones@chromium.org>
    Reviewed-by: Chris Palmer <palmer@chromium.org>
    Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
    Commit-Queue: John Lin <chuanl@google.com>
    Cr-Commit-Position: refs/heads/master@{#614416}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabTopBarDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/dynamicmodule/ActivityHostImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
  38. ARC: Ignore account updates for which a refresh token is not present

    Changed by Kush Sinha - sinhakohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:02:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 37a377ec76e2c3fafe0d86ffecc765b23b4633ba

    Comments

    ARC: Ignore account updates for which a refresh token is not present
    
    As accounts are being migrated to Chrome OS Account Manager, we may have
    some accounts for which we do not have a valid refresh token yet.
    
    Do not attempt to push these accounts to ARC. When these accounts do get
    a valid refresh token, ArcAuthService will be notified again.
    
    Bug: 871690
    Test: browser_tests --gtest_filter="*ArcAuthService*Test*"
    Change-Id: Id69d8b2deed80adf455a42f4393de33b3f099022
    Reviewed-on: https://chromium-review.googlesource.com/c/1350175
    Reviewed-by: Yury Khmel <khmel@chromium.org>
    Commit-Queue: Kush Sinha <sinhak@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614415}

    Changed files

    • chrome/browser/chromeos/arc/auth/arc_auth_service.cc
    • chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc
  39. android_webview: Remove extracted pak file cleanup logic

    Changed by agrieve - agrieveohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 18:01:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7f85b75a6d0ca2431e811c9d245765ea60773263

    Comments

    android_webview: Remove extracted pak file cleanup logic
    
    This removes some cleanup that now has very low odds of being
    necessary. It was to clean up accidentally extracted files
    for users of M60 and M61 Monochrome (15 months ago).
    
    Bug: 756580
    Change-Id: I502d7080ec26d0301a9e17e07ae9f5b7266ac088
    Reviewed-on: https://chromium-review.googlesource.com/c/1364019
    Reviewed-by: Richard Coles <torne@chromium.org>
    Commit-Queue: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614414}

    Changed files

    • android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
  40. Roll src-internal 3803956c4af7..a7fc8655690d (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 18:01:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 84d7fb2bf2f79989653e257c1a8f9395f060c2a6

    Comments

    Roll src-internal 3803956c4af7..a7fc8655690d (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3803956c4af7..a7fc8655690d
    
    
    Created with:
      gclient setdep -r src-internal@a7fc8655690d
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Id0c5837a852e741ceb14c762676aff02d0ef6ce0
    Reviewed-on: https://chromium-review.googlesource.com/c/1365755
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614413}

    Changed files

    • DEPS
  41. Import wpt@6185fc083a08ea74f0ddfffff917321fb6ffa42d

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 18:00:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 82be89cec654871a1ba8277151b966b7ec4a4be4

    Comments

    Import wpt@6185fc083a08ea74f0ddfffff917321fb6ffa42d
    
    Using wpt-import in Chromium 454a4f0cb9c837740bbb0bb1f07809728f98f4a6.
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    chcunningham@chromium.org, wolenetz@chromium.org:
      external/wpt/media-source
    jsbell@chromium.org:
      external/wpt/resources
    
    NOAUTOREVERT=true
    TBR=raphael.kubo.da.costa
    
    No-Export: true
    Change-Id: Ia09e3aaf2750bf36e54d5e1fbc6bb85fa85476c9
    Reviewed-on: https://chromium-review.googlesource.com/c/1365716
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614412}

    Changed files

    • third_party/blink/web_tests/NeverFixTests
    • third_party/blink/web_tests/SlowTests
    • third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
    • third_party/blink/web_tests/external/wpt/css/css-overscroll-behavior/overscrollBehavior-manual.html
    • third_party/blink/web_tests/external/wpt/interfaces/web-nfc.idl
    • third_party/blink/web_tests/external/wpt/media-source/mediasource-invalid-codec.html
    • third_party/blink/web_tests/external/wpt/media-source/mp4/invalid-codec.mp4
    • third_party/blink/web_tests/external/wpt/media-source/webm/invalid-codec.webm
    • third_party/blink/web_tests/external/wpt/resources/testharness.js
    • third_party/blink/web_tests/external/wpt/svg/interact/scripted/composed.window.svg
    • third_party/blink/web_tests/external/wpt/svg/interact/scripted/focus-events.svg
    • third_party/blink/web_tests/external/wpt/svg/interact/scripted/focus-tabindex-default-value.svg
    • third_party/blink/web_tests/external/wpt/svg/interact/scripted/resources/blank.htm
    • third_party/blink/web_tests/external/wpt/svg/interact/scripted/tabindex-focus-flag-expected.txt
    • third_party/blink/web_tests/external/wpt/svg/interact/scripted/tabindex-focus-flag.svg
    • third_party/blink/web_tests/external/wpt/web-nfc/idlharness.https.window-expected.txt
  42. [TaskScheduler]: Migrate off of ScopedAllowWait in /base

    Changed by Etienne Pierre-Doray - etiennepohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:59:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 030ca0ae838b897e824961a4b15e86d3ad2719ce

    Comments

    [TaskScheduler]: Migrate off of ScopedAllowWait in /base
    
    base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
    explicit counterpart.
    
    It should have been replaced by :
     * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
     * base::ScopedAllowBaseSyncPrimitives in non-test files
     * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads
       that don't allow blocking
    The last one is strongly frowned upon but this CL aims to document existing
    behavior rather than address it. Owners are encouraged to follow-up by fixing
    unnecessary waits and more particularly unnecessary waits
    outside-blocking-scope.
    
    Note: The non-for-testing versions require friend'ing in thread_restrictions.h
    but care was taken to add these friends ahead of git cl split (since it wasn't
    possible to do a line-by-line associated CL split).
    Refer to the top-level CL if necessary :
    https://chromium-review.googlesource.com/c/chromium/src/+/1288533
    
    Please CQ if LGTY!
    
    This CL was uploaded by git cl split.
    
    R=danakj@chromium.org
    
    Bug: 766678
    Change-Id: Ibe3a0f37c044cc58d5d25eacc2bb2aba6441de3a
    Reviewed-on: https://chromium-review.googlesource.com/c/1325218
    Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
    Reviewed-by: Chris Hamilton <chrisha@chromium.org>
    Reviewed-by: danakj <danakj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614411}

    Changed files

    • base/test/thread_test_helper.cc
    • base/threading/simple_thread.cc
    • base/threading/thread.cc
    • cc/raster/single_thread_task_graph_runner.cc
    • chrome/browser/memory/memory_kills_monitor.cc
  43. Fix rounding error in coordinate conversion

    Changed by Andrew Xu - andrewxuohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:56:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a6cdb0f015d98d56b2eddcd20624875762ddb6ba

    Comments

    Fix rounding error in coordinate conversion
    
    Fix the rounding error in code for coordinate conversion from
    native host coordinate to screen DIP coordinate.
    
    In the original code, when mouse cursor is in the warp region of
    secondary display, its screen DIP coordinate which is computed by
    ConvertHostPointToRelativeToRootWindow may be out of secondary display
    due to rounding error. It is also found that this rounding error only
    happens with specific display zoom factors and display rotation
    degrees.
    
    Test: ash_unittests
    
    Bug: 905035
    Change-Id: I4570dee911777ad820ede6677f7a3382f5b9a5fc
    Reviewed-on: https://chromium-review.googlesource.com/c/1364392
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Commit-Queue: Andrew Xu <andrewxu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614410}

    Changed files

    • ash/display/extended_mouse_warp_controller.cc
    • ash/display/extended_mouse_warp_controller.h
    • ash/display/extended_mouse_warp_controller_unittest.cc
    • ash/display/screen_position_controller.cc
    • ash/display/screen_position_controller_unittest.cc
    • ash/host/ash_window_tree_host_platform.h
  44. [Sync] Fix initialization in sync_file_system_browsertest

    Changed by Mohamed Amir Yosef - mamirohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:55:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7ba8f46fbafda0457b26c1d714f55bcc7b7555ae

    Comments

    [Sync] Fix initialization in sync_file_system_browsertest
    
    In sync_file_system_browsertest.cc
    
    The following code snippet
    
    info.account_id = kGaiaId;
    info.account_id = kEmail;
    
    Assigns info.account_id and directly overrides it with another value
    which renders the first assignment useless.
    
    Change-Id: Ia27e36e6d9f54fba7c5e179492408c327ff2bb67
    Reviewed-on: https://chromium-review.googlesource.com/c/1363283
    Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614409}

    Changed files

    • chrome/browser/apps/platform_apps/api/sync_file_system/sync_file_system_browsertest.cc
  45. Autoplay: remove cross-origin autoplay policy from //chrome and //content.

    Changed by Mounir Lamouri - mlamouriohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:55:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 04c8595b3d4c10d8ce02c057084a8e46df0d8c1e

    Comments

    Autoplay: remove cross-origin autoplay policy from //chrome and //content.
    
    This isn't removing the code in Blink but prevents users from setting this
    autoplay policy.
    
    Bug: 911795
    Change-Id: I8803813a1971d2c0082af164ed8d73a48e3a1cf7
    Reviewed-on: https://chromium-review.googlesource.com/c/1362225
    Reviewed-by: Becca Hughes <beccahughes@chromium.org>
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614408}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/ui/webui/media/media_engagement_ui.cc
    • content/browser/renderer_host/render_view_host_impl.cc
    • content/public/common/web_preferences.h
    • content/renderer/render_view_impl.cc
    • media/base/media_switches.cc
    • media/base/media_switches.h
  46. Verify correctness of WebState::GetTitle during session restore.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 17:51:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b8b0c79967271555e0d197b0ac874d2c61bd641

    Comments

    Verify correctness of WebState::GetTitle during session restore.
    
    Cached title is returned during restoration and URL hostname is returned
    right after restoration is complete, but before the page finishes load.
    
    Bug: 877671
    Change-Id: Ie7375a3c0c47a77417f1d10bb4bb0d48d6127da1
    Reviewed-on: https://chromium-review.googlesource.com/c/1363968
    Reviewed-by: Danyao Wang <danyao@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614407}

    Changed files

    • ios/web/web_state/web_state_unittest.mm
  47. [MDC roll] Roll Material Motion Interchange to 6c385396ae7d3ee6752c3d625e322138eb8e25fc

    Changed by iOS Autoroller - ios-autorollerohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:46:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0ae3d0c44adc34d53f2a6a29a16971553b1ff8f5

    Comments

    [MDC roll] Roll Material Motion Interchange to 6c385396ae7d3ee6752c3d625e322138eb8e25fc
    
    TBR=smut
    
    Change-Id: I3d7d55c3e0301c6db509d674e1f42b33392ee933
    Reviewed-on: https://chromium-review.googlesource.com/c/1365795
    Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
    Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614406}

    Changed files

    • DEPS
    • ios/third_party/motion_interchange_objc/README.chromium
  48. [iOS] Update OpenInToolbar bottom margin constraint for new windows.

    Changed by Kurt Horimoto - kkhorimotoohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:44:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c8bcca4e25ae2b9046f8cf4c31d94b179d45e4a7

    Comments

    [iOS] Update OpenInToolbar bottom margin constraint for new windows.
    
    Previously OpenInToolbar updated its bottom constraint when moved to
    a new superview.  This occurs when the toolbar is added to the tab's
    view (CRWWebControllerContainerView) when a tab is navigated to an
    exportable URL.  If the foreground tab is changed after this occurs, the
    tab's view is removed from the hierarchy, which deactivates the
    bottom margin height constraint since the open in toolbar is removed
    from the BVC's hierarchy.  OpenInToolbar.bottomMarginConstraint is not
    reset, however, because the OpenInToolbar's superview doesn't change
    from the tab view.  Updating the constraint for window changes rather
    than superview changes will catch this and reset the constraint to nil
    when the tab's view is removed from the BVC's hierarchy.
    
    The crash in the referenced bug occured because the WKScrollView is
    being updated while the tab's view is not visible due to delayed
    JavaScript execution that is used to apply the PageDisplayState.
    
    Bug: 907485
    Change-Id: Iedd05d5cf6657e26372235d026fd2c34e87f9c95
    Reviewed-on: https://chromium-review.googlesource.com/c/1364162
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614405}

    Changed files

    • ios/chrome/browser/ui/open_in_toolbar.mm
  49. Rolling buildtools 04161ec8..7d88270d

    Changed by Sam Maier - smaierohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:35:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9b5c0a7e5bf7a73942ba783b6180f83a4d63b1e4

    Comments

    Rolling buildtools 04161ec8..7d88270d
    
    Also updates docs on how to build clang-format.
    
    Bug: 911708, 907181
    Change-Id: I55b3d9833b030fece1eb52c3b6b53492959582b2
    Reviewed-on: https://chromium-review.googlesource.com/c/1365081
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614404}

    Changed files

    • DEPS
    • docs/updating_clang_format_binaries.md
  50. [Autofill Assistant] Fix gestures in partial overlay mode.

    Changed by Stephane Zermatten - szermattohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:30:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 188b097f0df3ade4cdc73a68ff51ad8035972b39

    Comments

    [Autofill Assistant] Fix gestures in partial overlay mode.
    
    With this patch, scroll, fling and pinch gestures in partial overlay
    mode work and feel the same way as in normal mode, even outside of the
    touchable area.
    
    Before this patch, when in partial overlay mode, scroll was simulated -
    badly, fling and pinch did not work at all.
    
    The way this now works, when touching outside of the touchable area in
    partial overlay mode, events are buffered just long enough to make sure
    that the gesture is not a tap. Afterwards, the events are forwarded
    directly to the compositor view holder.
    
    To keep things sane, and events anchored at the same position throughout
    the gesture, the dynamic update of the view margin is turned off unless
    in accessibility mode - and we don't intercept gestures in accessibility
    mode anyways.
    
    This change also removes the now unnecessary support for calling
    javascript scrollBy from Android Java.
    
    Bug: 806868
    Change-Id: I605a8659543bd2140c124e9b79e9b9b9de606c55
    Reviewed-on: https://chromium-review.googlesource.com/c/1362935
    Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614403}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/TouchEventFilter.java
    • chrome/browser/android/autofill_assistant/ui_controller_android.cc
    • chrome/browser/android/autofill_assistant/ui_controller_android.h
    • components/autofill_assistant/browser/controller.cc
    • components/autofill_assistant/browser/controller.h
    • components/autofill_assistant/browser/ui_delegate.h
    • components/autofill_assistant/browser/web_controller.cc
    • components/autofill_assistant/browser/web_controller.h
  51. [Signin][Android] Reset SigninHelper shared prefs in SigninTestUtil

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:27:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b0262e8f0abfde39fcf63e6047510b41bade79bd

    Comments

    [Signin][Android] Reset SigninHelper shared prefs in SigninTestUtil
    
    This CL replaces SigninHelper.resetAccountRenameEventIndex with
    resetSharedPrefs that clears all shared preferences saved by
    SigninHelper. resetSharedPrefs is invoked from SigninTestUtil to make
    sure the state doesn't leak between tests.
    
    Bug: 906712
    Change-Id: I439783e0c0977621f4492fb882c3825f91cb6b3a
    Reviewed-on: https://chromium-review.googlesource.com/c/1365242
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614402}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/signin/SigninHelper.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java
    • chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/signin/SigninTestUtil.java
  52. Update Mash FYI browser_tests filter

    Changed by Steven Bennetts - stevenjbohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:27:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5036b8ef6edb94c35cd5c5d8b6ab4d2b0f3e94b4

    Comments

    Update Mash FYI browser_tests filter
    
    Bug: 646565
    
    For keyboard specific change to policy_browsertest.cc:
    TBR=emaxx@chromium.org
    
    Change-Id: I214a6563614e83c912de7eb8b880a995fda2f89d
    Reviewed-on: https://chromium-review.googlesource.com/c/1363898
    Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614401}

    Changed files

    • chrome/browser/policy/policy_browsertest.cc
    • chrome/browser/ui/ash/keyboard/keyboard_controller_browsertest.cc
    • testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter
  53. Roll src/third_party/perfetto 06b4f7386a8c..6ae9526278fc (3 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 17:26:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6d7e45d18cb08da70c65d1583787364a7e948f78

    Comments

    Roll src/third_party/perfetto 06b4f7386a8c..6ae9526278fc (3 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/06b4f7386a8c..6ae9526278fc
    
    
    git log 06b4f7386a8c..6ae9526278fc --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 fmayer@google.com profiling: Do not disable SELinux by default in script.
    2018-12-06 fmayer@google.com Merge "profiling: Improve bookeeping."
    2018-12-06 fmayer@google.com Merge "profiler: Use sequence number for interner ID."
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@6ae9526278fc
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:117762471
    TBR=perfetto-bugs@google.com
    
    Change-Id: Ie435d664e7d91a309a0b66937bb75144cf94dc58
    Reviewed-on: https://chromium-review.googlesource.com/c/1365756
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614400}

    Changed files

    • DEPS
  54. Remove Crash Expectation for fullscreen/full-screen-inline-split-crash.html

    Changed by jonross - jonrossohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:26:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b270bbd6b31a08acc546d943f7d615ae58a36943

    Comments

    Remove Crash Expectation for fullscreen/full-screen-inline-split-crash.html
    
    fullscreen/full-screen-inline-split-crash.html was crashing on Android, do to a
    check which is only valid on Mac. This Check has since been restricted to Mac
    only.
    
    We no longer expect this to crash. And new crashes should be logged as they
    would be different bugs. The most recent run on flaky dashboard shows a pass,
    though there is only one recent run found.
    
    I'm removing the crash expectation.
    
    TEST=fullscreen/full-screen-inline-split-crash.html
    
    Bug: 883591
    Change-Id: I3863ac01cba653af98ac4bdb95d326d170ac70d1
    Reviewed-on: https://chromium-review.googlesource.com/c/1364211
    Reviewed-by: kylechar <kylechar@chromium.org>
    Commit-Queue: Jonathan Ross <jonross@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614399}

    Changed files

    • third_party/blink/web_tests/TestExpectations
  55. [AF] Update ShouldSuggestServerCards to check opt in in sync-transport.

    Changed by sebsg - sebsgohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:25:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e93500b9d63f42bfac14872be6bec7560b8479a

    Comments

    [AF] Update ShouldSuggestServerCards to check  opt in in sync-transport.
    
    For users that are in sync transport mode, server cards should only be
    suggested if the user has opted-in to seeing them.
    
    Bug: 907929
    Change-Id: I45d855fa6072a1ecb85a4c35244280b0ec8cb4fb
    Reviewed-on: https://chromium-review.googlesource.com/c/1365086
    Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
    Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614398}

    Changed files

    • components/autofill/core/browser/personal_data_manager.cc
    • components/autofill/core/browser/personal_data_manager_unittest.cc
  56. Feature to enable system AEC.

    Changed by Henrik Grunell - grunellohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:25:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 63f2d772b2664b4572190bcd497280afdc6d559f

    Comments

    Feature to enable system AEC.
    
    This lets users enable the system AEC for testing purposes.
    
    If there is no system echo canceller available, getUserMedia with echo cancellation enabled will fail.
    
    Bug: 776327
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Ie041bc1d205762875f9ad4817d8d3441d967256e
    Reviewed-on: https://chromium-review.googlesource.com/c/1113440
    Commit-Queue: Henrik Grunell <grunell@chromium.org>
    Reviewed-by: Olga Sharonova <olka@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Guido Urdaneta <guidou@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614397}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag-metadata.json
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • content/renderer/media/stream/media_stream_constraints_util_audio.cc
    • media/audio/audio_features.cc
    • media/audio/audio_features.h
    • tools/metrics/histograms/enums.xml
  57. Improve error messaging of perf_data_generator when benchmarks scheduled state is incorrect

    Changed by Ned Nguyen - nednguyenohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 17:24:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7226f9435afe250b14abe22d33dcc2ba72bb4116

    Comments

    Improve error messaging of perf_data_generator when benchmarks scheduled state is incorrect
    
    For Telemetry or non Telemetry benchmarks, these two states generally need to match:
    1) The states of all benchmarks that are tracked BenchmarkMetadata objects. This
    will results in benchmarks being generated in https://bit.ly/chrome-benchmarks
    list.
    2) The states of all benchmarks that are scheduled, either directly (for
    non Telemetry benchmarks) as a 'script' in src-side json, or indirectly through
    benchmark shard map files.
    
    The only exception to this is when users add a new Telemetry benchmark but need
    to defer the job of scheduling it to Telemetry/Chrome Client Infrastructure team
    member.
    
    This CL improves perf_data_generator check to make it clear which cases of
    inconsistent states are happening & what to do about each of them.
    
    For example, assuming a user rename blink_perf.paint benchmark to blink_perf.paint2
    
    Without this CL, the error message is:
    
    AssertionError: Please update NON_TELEMETRY_BENCHMARKS as below:
    Remove blink_perf.paint2 from NON_TELEMETRY_BENCHMARKS
    Add blink_perf.paint to NON_TELEMETRY_BENCHMARKS
    
    With this CL, the error message is:
    
    * Telemetry benchmark blink_perf.paint2 exists but is not scheduled to
    run. Rename it to UNSCHEDULED_blink_perf.paint2, then file a crbug
    against Telemetry and ChromeClient Infrastructure team to schedule the
    benchmark on the perf waterfall.
    
    * Telemetry benchmark blink_perf.paint no longer exists but is
    scheduled. File a bug against Telemetry and/or Chrome Client
    Infrastructure team to remove the corresponding benchmark class and
    deschedule the benchmark on the perf waterfall. After that, you can
    safely remove the benchmark's dependency code, e.g: stories, WPR
    archives, metrics,..
    
    
    Bug: 911828
    Change-Id: Ia9e9746391eb1e9932c8e0619a25e3273a77e9c5
    Reviewed-on: https://chromium-review.googlesource.com/c/1363681
    Commit-Queue: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
    Reviewed-by: Emily Hanley <eyaich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614396}

    Changed files

    • tools/perf/core/perf_data_generator.py
    • tools/perf/core/perf_data_generator_unittest.py
  58. [ios] Add credit card logo to manual fallback cells

    Changed by David Jean - djeanohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 17:21:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7b27d290eab4ed6d50a84f1ddf959e82039afeff

    Comments

    [ios] Add credit card logo to manual fallback cells
    
    Bug: 912516
    Change-Id: Ibb72af9f02dfe63a206e7039bb388009b1ecd670
    Reviewed-on: https://chromium-review.googlesource.com/c/1365448
    Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    Commit-Queue: David Jean <djean@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614395}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/action_cell.mm
    • ios/chrome/browser/ui/autofill/manual_fill/credit_card.h
    • ios/chrome/browser/ui/autofill/manual_fill/credit_card.mm
    • ios/chrome/browser/ui/autofill/manual_fill/credit_card_form.mm
    • ios/chrome/browser/ui/autofill/manual_fill/credit_card_unittest.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_address_cell.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_card_cell.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_cell_utils.h
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_cell_utils.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_password_cell.mm
  59. Roll src/third_party/skia b45d5124816e..69e5785d9f00 (5 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 17:17:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6d53fe10d0ecc6897202868f2fbc8fe8b8c1f29c

    Comments

    Roll src/third_party/skia b45d5124816e..69e5785d9f00 (5 commits)
    
    https://skia.googlesource.com/skia.git/+log/b45d5124816e..69e5785d9f00
    
    
    git log b45d5124816e..69e5785d9f00 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 jvanverth@google.com Add RG_88 texture format
    2018-12-06 bsalomon@google.com Revert "Revert "Mark wrapped textures imported into SkImages as "read only".""
    2018-12-06 brianosman@google.com Add glenarrow to GPU BonusConfigs bots
    2018-12-06 jvanverth@google.com Reland "Fallback mipmap creation for YUVA images."
    2018-12-06 caryclark@skia.org fix bookmaker
    
    
    Created with:
      gclient setdep -r src/third_party/skia@69e5785d9f00
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jcgregorio@chromium.org
    
    Change-Id: Ibd613da5fd186bba27bfe363e347e45335b28086
    Reviewed-on: https://chromium-review.googlesource.com/c/1365428
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614394}

    Changed files

    • DEPS
  60. Network Service: Migrate drive::JobScheduler to NetworkConnectionTracker

    Changed by Jun Cai - juncaiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:15:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e2d41b1393eb57790a1634640b1aa149a7c5fc24

    Comments

    Network Service: Migrate drive::JobScheduler to NetworkConnectionTracker
    
    This CL migrates drive::JobScheduler from NetworkChangeNotifier to
    NetworkConnectionTracker, which works with the network service enabled.
    
    The "Initial upload" patch of this CL is the same as:
    https://chromium-review.googlesource.com/c/chromium/src/+/1236558
    
    Bug: 887038
    Change-Id: Ib19f501f6a85a0c32dc81d47ea4b161b5a726efe
    Reviewed-on: https://chromium-review.googlesource.com/c/1287040
    Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
    Reviewed-by: Naoki Fukino <fukino@chromium.org>
    Commit-Queue: Jun Cai <juncai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614393}

    Changed files

    • chrome/browser/chromeos/drive/drive_integration_service.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
    • components/drive/about_resource_loader_unittest.cc
    • components/drive/change_list_loader_unittest.cc
    • components/drive/directory_loader_unittest.cc
    • components/drive/file_system/operation_test_base.cc
    • components/drive/file_system_unittest.cc
    • components/drive/job_scheduler.cc
    • components/drive/job_scheduler.h
    • components/drive/job_scheduler_unittest.cc
    • components/drive/start_page_token_loader_unittest.cc
    • components/drive/sync_client_unittest.cc
    • components/drive/team_drive_change_list_loader_unittest.cc
    • components/drive/team_drive_list_loader_unittest.cc
  61. [BrowserTest] Deflake TouchActionBrowserTest

    Changed by Xida Chen - xidachenohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:12:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cc4b7196ecbd35a92870ed88bb47b4cd658aff4f

    Comments

    [BrowserTest] Deflake TouchActionBrowserTest
    
    In these browser tests, we inject a synthetic gesture scroll, and jank
    the main thread sometimes, and then check the scroll offset by
    executing:
    "document.scrollingElement.scrollTop" and ".scrollLeft"
    
    From the resut when it is flaky, it seems that even though the
    compositor frame's metadata shows that the scroll offset is >=
    half of the expected scroll offset, the main thread's scroll offset
    might still smaller than half of the expected scroll offset.
    
    This CL makes change to just check that it actually scrolled on the
    expected axis (from the main thread), instead of checking the scroll
    offset.
    
    Bug: 876323
    Change-Id: Ieee6f44304c67e8db89bc4e899ae8e69e8416f33
    Reviewed-on: https://chromium-review.googlesource.com/c/1363863
    Commit-Queue: Xida Chen <xidachen@chromium.org>
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614392}

    Changed files

    • content/browser/renderer_host/input/touch_action_browsertest.cc
  62. Address race between device notifications and enumerations in AudioDeviceListenerMac

    Changed by Guido Urdaneta - guidouohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:12:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01694e809e567530443ffb8687fd5f3956f79c0f

    Comments

    Address race between device notifications and enumerations in AudioDeviceListenerMac
    
    Originally AudioDeviceListenerMac assumed that once CoreAudio reports that a device does not exist,
    it was no longer possible to get notifications related to that device, so it was safe to remove
    the listener for that device.
    However, since notifications can come from multiple threads and the corresponding callbacks make
    a thread jump, we have observed that it is indeed possible to get notifications about removed devices
    which can lead to a crash if the listener for that notification has been removed.
    To address this issue, this CL does not remove listeners when the device is removed, but instead
    marks the listener as deleted and posts a task to remove listeners that have been marked as deleted
    for several seconds, at a time when we can confidently no longer expect notifications from the removed device.
    
    Bug: 911311
    Change-Id: I07cc9c8e24a0cfdfadcc04d0e8bd33e14ab61422
    Reviewed-on: https://chromium-review.googlesource.com/c/1363187
    Commit-Queue: Guido Urdaneta <guidou@chromium.org>
    Reviewed-by: Oskar Sundbom <ossu@chromium.org>
    Reviewed-by: Olga Sharonova <olka@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614391}

    Changed files

    • media/audio/mac/audio_device_listener_mac.cc
    • media/audio/mac/audio_device_listener_mac.h
  63. [sheriff] Update TestExpectations for flaky layout test

    Changed by Roger McFarlane - rogermohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:10:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f668bb5e368b109bd420c2525055ffbd6de3f064

    Comments

    [sheriff] Update TestExpectations for flaky layout test
    
    compositing/visibility/overlays-persist-on-navigation.html
    
    TBR: jyasskin@chromium.org
    Bug: 912570
    Change-Id: Iab922b37a9081c3b0a83490e738bda1d03cf24d3
    Reviewed-on: https://chromium-review.googlesource.com/c/1365715
    Commit-Queue: Roger McFarlane <rogerm@chromium.org>
    Reviewed-by: Roger McFarlane <rogerm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614390}

    Changed files

    • third_party/blink/web_tests/TestExpectations
  64. Roll src/third_party/depot_tools 2e00228777c0..f94f910e9a1f (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 17:09:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c8d5c3b4617238d24caa5e87093bc9e80148b6e

    Comments

    Roll src/third_party/depot_tools 2e00228777c0..f94f910e9a1f (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2e00228777c0..f94f910e9a1f
    
    
    git log 2e00228777c0..f94f910e9a1f --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 tikuta@chromium.org [ninjalog] disable log upload
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@f94f910e9a1f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:900161
    TBR=agable@chromium.org
    
    Change-Id: Id3ec9912b3cfeaff57a05c560c43f6945ba75dda
    Reviewed-on: https://chromium-review.googlesource.com/c/1365429
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614389}

    Changed files

    • DEPS
  65. [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in ssl_errors

    Changed by Carlos Caballero - carlscabohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 17:08:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6e29ed936c19b696b115972f7016aefc417edb55

    Comments

    [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in ssl_errors
    
    MessageLoop will go away, eventually.
    
    BUG=891670
    
    Change-Id: I297de47c1dd4d2a58276c136d8b48216ed4fd769
    Reviewed-on: https://chromium-review.googlesource.com/c/1353889
    Reviewed-by: Carlos IL <carlosil@chromium.org>
    Commit-Queue: Carlos Caballero <carlscab@google.com>
    Cr-Commit-Position: refs/heads/master@{#614388}

    Changed files

    • components/ssl_errors/error_classification_unittest.cc
  66. remove static destructable variables from add_unique_urls_task_unittest.cc

    Changed by Dan Harrington - harringtondohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:55:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e45074e7d2cef61213347c47fa6657c2b5904fa4

    Comments

    remove static destructable variables from add_unique_urls_task_unittest.cc
    
    Also updated a comment as suggested in a previous code review.
    
    Change-Id: If59276e9261ac2ba82ece5086798f34933df5040
    Reviewed-on: https://chromium-review.googlesource.com/c/1362473
    Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
    Commit-Queue: Dan H <harringtond@google.com>
    Cr-Commit-Position: refs/heads/master@{#614387}

    Changed files

    • components/offline_pages/core/prefetch/prefetch_item.h
    • components/offline_pages/core/prefetch/tasks/add_unique_urls_task_unittest.cc
  67. passwords: don't eat space KeyPressed on Mac

    Changed by Elly Fong-Jones - ellyjonesohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:54:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 848e9aed3705fe5ca9392b26f90caf4221c96850

    Comments

    passwords: don't eat space KeyPressed on Mac
    
    On Mac, KeyPressed is what activates buttons, not KeyReleased, so eating
    KeyPressed breaks this button.
    
    Bug: 910070
    Change-Id: I4776bc3b14ac52879ad96c20d55f93126ba349d7
    Reviewed-on: https://chromium-review.googlesource.com/c/1361627
    Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614386}

    Changed files

    • chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc
    • chrome/browser/ui/views/passwords/manage_passwords_icon_views.h
  68. Remove iOS Translate Event Logging in Sync

    Changed by Anthony Vallee-Dubois - anthonyvdohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:54:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 375260f7da26d6910344c5904c849b916ff217c8

    Comments

    Remove iOS Translate Event Logging in Sync
    
    The feature is disabled by default, no config currently applies, and it
    was decided to stop collecting these events. This removes the iOS
    portion of the code because it allows removing a translate -> sync
    dependency that was preventing another change from landing.
    
    Bug: 896719,911781
    Change-Id: I54c40dc1154bb6619d876dbd3fc86e3d22078e99
    Reviewed-on: https://chromium-review.googlesource.com/c/1361927
    Reviewed-by: Roger McFarlane <rogerm@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Commit-Queue: anthonyvd <anthonyvd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614385}

    Changed files

    • ios/chrome/browser/translate/BUILD.gn
    • ios/chrome/browser/translate/chrome_ios_translate_client.mm
  69. [Autofill Assistant] Onboarding buttons are now aligned with the Terms&Conditions box.

    Changed by Clemens Arbesser - arbesserohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 16:53:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c8e849191083c16cb2b18e3d219fbe008741c26d

    Comments

    [Autofill Assistant] Onboarding buttons are now aligned with the Terms&Conditions box.
    
    Before: https://screenshot.googleplex.com/ESkLNquDXJd.png
    After: https://screenshot.googleplex.com/tEssthOhzV9.png
    
    Bug: 806868
    Change-Id: I628e6aaa3bf11f453096c80dfc05266393db6ede
    Reviewed-on: https://chromium-review.googlesource.com/c/1365435
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Clemens Arbesser <arbesser@google.com>
    Cr-Commit-Position: refs/heads/master@{#614384}

    Changed files

    • chrome/android/java/res_autofill_assistant/layout/init_screen.xml
  70. Implement correct opacity and filter handling within backdrop-filter

    Changed by Mason Freed - masonfreedohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:49:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7e7e4790f28e6339dd2de044e851b43de5028cbc

    Comments

    Implement correct opacity and filter handling within backdrop-filter
    
    Prior to this CL, opacity and filters applied to the backdrop-filtered
    element did not get applied to the backdrop-filtered backdrop. Now, the
    opacity and filters get applied directly to the backdrop-filtered
    image directly, which is an approximation but should be very close.
    
    Also fixed up a few of the backdrop-filter tests to account for this,
    and removed a few lines from TestExpectations that now work.
    
    Bug: 497522, 524689
    Change-Id: If671bdf65ac0ae04cf175143eb8949ff4be0837b
    Reviewed-on: https://chromium-review.googlesource.com/c/1357626
    Reviewed-by: vmpstr <vmpstr@chromium.org>
    Commit-Queue: Mason Freed <masonfreed@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614383}

    Changed files

    • cc/trees/layer_tree_host_pixeltest_filters.cc
    • components/viz/service/display/gl_renderer.cc
    • components/viz/service/display/gl_renderer.h
    • components/viz/service/display/skia_renderer.cc
    • components/viz/service/display/software_renderer.cc
    • components/viz/test/data/backdrop_filter_rotated_sw.png
    • third_party/blink/web_tests/TestExpectations
    • third_party/blink/web_tests/css3/filters/backdrop-filter-basic-blur-expected.png
    • third_party/blink/web_tests/css3/filters/backdrop-filter-basic-blur.html
    • third_party/blink/web_tests/css3/filters/backdrop-filter-plus-filter-expected.html
    • third_party/blink/web_tests/css3/filters/backdrop-filter-plus-filter.html
    • third_party/blink/web_tests/css3/filters/backdrop-filter-rendering-expected.html
    • third_party/blink/web_tests/css3/filters/backdrop-filter-rendering.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-basic-background-color-ref.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-basic-background-color.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-basic-opacity-2-ref.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-basic-opacity-2.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-clip-rect.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-edge-pixels-ref.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-edge-pixels.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-isolation-fixed.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-isolation-isolate.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-isolation-ref.html
    • third_party/blink/web_tests/external/wpt/css/filter-effects/backdrop-filter-isolation.html
  71. simplify DEPS using !=

    Changed by Takuto Ikuta - tikutaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:43:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e306cbad4a10443729a396127a1a6d28db536afd

    Comments

    simplify DEPS using !=
    
    Change-Id: I801fad16f64b1cce56ea5ecb1aced0e93bf992cd
    Reviewed-on: https://chromium-review.googlesource.com/c/1364935
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614382}

    Changed files

    • DEPS
  72. flags: remove enable-fullscreen-tab-detaching

    Changed by Elly Fong-Jones - ellyjonesohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:43:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e9957f7b592e93bba2519525e143fd3e8a7d37e2

    Comments

    flags: remove enable-fullscreen-tab-detaching
    
    This flag is not used anywhere in the code.
    
    Bug: 912155
    Change-Id: I38343c739a2fc2580aa04f9bf120ab0b74ba6929
    Reviewed-on: https://chromium-review.googlesource.com/c/1363436
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Reviewed-by: Robert Sesek <rsesek@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614381}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag-metadata.json
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • chrome/common/chrome_switches.cc
    • chrome/common/chrome_switches.h
  73. [android pylib] support go swarming client in gtest merge script

    Changed by Takuto Ikuta - tikutaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:42:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7383bfa895ea1e7288ed021e5618a5f674f0eff7

    Comments

    [android pylib] support go swarming client in gtest merge script
    
    go swarming client have different directory structure of task outputs from python.
    In go client, directory name of task output become task_id, not shard index like in python.
    let me support both directory structure during migration.
    
    This is cherry-pick of
    https://chromium-review.googlesource.com/c/chromium/tools/build/+/1360817
    
    This is to prevent infra failure like
    https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel/145571
    
    Bug: 894045
    Change-Id: I91da3b0b99ea7a984852ee76f20a09f23e9f490e
    Reviewed-on: https://chromium-review.googlesource.com/c/1364995
    Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614380}

    Changed files

    • build/android/pylib/results/presentation/standard_gtest_merge.py
  74. Roll src/third_party/webrtc 628f37a6fe24..18f0c3c038fc (4 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 16:35:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ebf220173e186b0fcc4798a1f4f089bffd440451

    Comments

    Roll src/third_party/webrtc 628f37a6fe24..18f0c3c038fc (4 commits)
    
    https://webrtc.googlesource.com/src.git/+log/628f37a6fe24..18f0c3c038fc
    
    
    git log 628f37a6fe24..18f0c3c038fc --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 solenberg@webrtc.org Add RegisterAudioSendPayload() method
    2018-12-06 nisse@webrtc.org Use opaque int as payload_type in MediaTransportInterface
    2018-12-06 artit@webrtc.org Fix iOS version for internal.client.webrtc perf test
    2018-12-06 terelius@webrtc.org Fix performance bug in CreateSendSideBweSimulationGraph
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@18f0c3c038fc
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Ifbb867efd8a5e86d9623621b8f48610c342a9aa9
    Reviewed-on: https://chromium-review.googlesource.com/c/1365425
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614379}

    Changed files

    • DEPS
  75. [ribbon] Use CSSPropertyName when reifying in StyleValueFactory.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:34:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bbede4251138524fef777d5b155fe9ae1b1e2915

    Comments

    [ribbon] Use CSSPropertyName when reifying in StyleValueFactory.
    
    Now that we have an object that can represent both native property names
    and custom property names, let's use it.
    
    Sidenote: the reification functions in StyleValueFactory can not take
    CSSProperty instances. This is because reification needs to happen on
    worklets, where we don't have the context of a Document (which again is
    needed to access the property registry).
    
    There should be no behavior change in this CL.
    
    Change-Id: I0d39a8e83628389699003bb7998548267635dffd
    Reviewed-on: https://chromium-review.googlesource.com/c/1361041
    Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
    Reviewed-by: Xida Chen <xidachen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614378}

    Changed files

    • third_party/blink/renderer/core/css/css_property_name.h
    • third_party/blink/renderer/core/css/css_property_name_test.cc
    • third_party/blink/renderer/core/css/cssom/style_property_map.cc
    • third_party/blink/renderer/core/css/cssom/style_property_map_read_only_main_thread.cc
    • third_party/blink/renderer/core/css/cssom/style_value_factory.cc
    • third_party/blink/renderer/core/css/cssom/style_value_factory.h
  76. [clang-tidy] Apply modernize-loop-convert in /base/i18n

    Changed by jdoerrie - jdoerrieohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:32:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 812de1576d58185d036dc7483646b6b109d87e54

    Comments

    [clang-tidy] Apply modernize-loop-convert in /base/i18n
    
    This change applies clang-tidy's modernize-loop-convert [1] in /base/i18n.
    
    Reproduction steps:
    - run clang-tidy's modernize-loop-convert
    - run git cl format
    - manually remove unused constants due to -Wunused-const-variable
    
    [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-loop-convert.html
    
    This CL was uploaded by git cl split.
    
    R=jshin@chromium.org
    
    Bug: 895746
    Change-Id: I9b9790b60aaca3f6afb2b4bd1109d800aec5b26a
    Reviewed-on: https://chromium-review.googlesource.com/c/1282404
    Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Reviewed-by: Jungshik Shin <jshin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614377}

    Changed files

    • base/i18n/break_iterator_unittest.cc
    • base/i18n/build_utf8_validator_tables.cc
    • base/i18n/file_util_icu_unittest.cc
    • base/i18n/number_formatting_unittest.cc
    • base/i18n/rtl_unittest.cc
    • base/i18n/streaming_utf8_validator_perftest.cc
    • base/i18n/streaming_utf8_validator_unittest.cc
  77. Trivial fix in PasswordDetailsTableViewController.

    Changed by Yi Su - mrsuyiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:22:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8f89c208303009df6334d2f961e7e5e5a4e6fcc7

    Comments

    Trivial fix in PasswordDetailsTableViewController.
    
    This CL changes the _weakDelegate of PasswordDetailsTableViewController
    from an instance var to a property, and replaces the mock class in
    PasswordDetailsTableViewControllerUnittest with OCMock.
    
    Bug: 894791
    Change-Id: I1cbb95e2f8aa3fb6befd3010040b0fe1ff4463d9
    Reviewed-on: https://chromium-review.googlesource.com/c/1361245
    Commit-Queue: Yi Su <mrsuyi@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614376}

    Changed files

    • ios/chrome/browser/ui/settings/password_details_table_view_controller.mm
    • ios/chrome/browser/ui/settings/password_details_table_view_controller_unittest.mm
  78. Roll src/third_party/perfetto f6a1cb2d8968..06b4f7386a8c (4 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 16:19:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d5132268fd2c639e018c94a217f8a1b858d45fac

    Comments

    Roll src/third_party/perfetto f6a1cb2d8968..06b4f7386a8c (4 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/f6a1cb2d8968..06b4f7386a8c
    
    
    git log f6a1cb2d8968..06b4f7386a8c --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 primiano@google.com Merge "Implement ftrace flushing"
    2018-12-06 eseckler@google.com Merge "tracing service: Verify target buffers specified in commit requests"
    2018-12-06 eseckler@google.com Merge "trace writer: Register/unregister on writer creation/destruction"
    2018-12-06 eseckler@google.com Merge "trace writer: Set the kChunkNeedsPatching flag when necessary"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@06b4f7386a8c
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Idda6e5efcff897194b1a51547934631761a92561
    Reviewed-on: https://chromium-review.googlesource.com/c/1365427
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614375}

    Changed files

    • DEPS
  79. [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in unified_consent

    Changed by Carlos Caballero - carlscabohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 16:16:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b3860213db9788a157bb1ed7db2b13842aadb3e8

    Comments

    [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in unified_consent
    
    MessageLoop will go away, eventually.
    
    BUG=891670
    
    Change-Id: Icbd30eb1886bb00105cd8ae5a8b158ffa9a397ea
    Reviewed-on: https://chromium-review.googlesource.com/c/1352427
    Reviewed-by: Thomas Tangl <tangltom@chromium.org>
    Commit-Queue: Carlos Caballero <carlscab@google.com>
    Cr-Commit-Position: refs/heads/master@{#614374}

    Changed files

    • components/unified_consent/unified_consent_service_unittest.cc
  80. [DL] Don't immediately update the locked element frame rect.

    Changed by Vladimir Levin - vmpstrohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:15:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 43a377d1697ac74ec5e45f739ee90becbcf253df

    Comments

    [DL] Don't immediately update the locked element frame rect.
    
    This patch ensures that we do layout in a pending frame rect, which is
    only put in place for children of the locked element during layout.
    
    After the promise is resolved, we put the pending frame rect as the
    active one and ensure that we relayout the previously locked box itself.
    
    This means that if the promise resolution, for example, removed the
    element as is the case in
    https://docs.google.com/document/d/1VrcVA5JyBmYn0Yi4wjPt1l9ce5Mhf-zu6o63p_mt98w/edit
    
    Then we never commit what was a pending layout and never see a flash
    of laid out content.
    
    R=chrishtr@chromium.org, mstensho@chromium.org
    
    Bug: 907613, 882663
    Change-Id: I7d03ae73ea4cb96c17ce8bb4162718155c2072be
    Reviewed-on: https://chromium-review.googlesource.com/c/1358969
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Commit-Queue: vmpstr <vmpstr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614373}

    Changed files

    • third_party/blink/renderer/core/display_lock/display_lock_context.cc
    • third_party/blink/renderer/core/display_lock/display_lock_context.h
    • third_party/blink/renderer/core/layout/layout_block.cc
    • third_party/blink/renderer/core/layout/layout_box.h
    • third_party/blink/renderer/core/layout/layout_object.h
    • third_party/blink/web_tests/display-lock/lock-before-append/measure-and-remove-expected.html
    • third_party/blink/web_tests/display-lock/lock-before-append/measure-and-remove.html
  81. Roll src/third_party/dawn bdd887fce76c..5aacd29d5e7e (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 16:14:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df691e06ba773e8f2bd42f8020a96e303da324d1

    Comments

    Roll src/third_party/dawn bdd887fce76c..5aacd29d5e7e (1 commits)
    
    https://dawn.googlesource.com/dawn.git/+log/bdd887fce76c..5aacd29d5e7e
    
    
    git log bdd887fce76c..5aacd29d5e7e --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 cwallez@chromium.org ProcTable: only cast the return value if needed.
    
    
    Created with:
      gclient setdep -r src/third_party/dawn@5aacd29d5e7e
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=cwallez@chromium.org
    
    Change-Id: I629fa6a92ef21293c055a467c0becb4c16cc13bb
    Reviewed-on: https://chromium-review.googlesource.com/c/1365424
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614372}

    Changed files

    • DEPS
  82. Move blink::InstanceCounters to use relaxed std::atomic, and add a warning comment.

    Changed by Jeremy Roman - jbromanohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:12:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 63ff3ddea380122470a6633bb72be00c1b153e63

    Comments

    Move blink::InstanceCounters to use relaxed std::atomic, and add a warning comment.
    
    The comment is added because it is clearly tempting to rely on these counters
    to provide an accurate count of the number of instances that exist across threads,
    but that is not something that can be computed with atomics (which do not provide
    mutual exclusion).
    
    It doesn't appear that these atomics intend to synchronize any other memory access
    (and in fact in many cases are used only from a single thread).
    
    Bug: 736037
    Change-Id: I2372ae73878361024779aadb39a72983f4faa3bb
    Reviewed-on: https://chromium-review.googlesource.com/c/1355885
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Jeremy Roman <jbroman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614371}

    Changed files

    • third_party/blink/renderer/platform/instance_counters.cc
    • third_party/blink/renderer/platform/instance_counters.h
  83. Roll src-internal 44685896babc..3803956c4af7 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 16:10:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fcc9d76b468f3dae15a524e8b049732dde465850

    Comments

    Roll src-internal 44685896babc..3803956c4af7 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/44685896babc..3803956c4af7
    
    
    Created with:
      gclient setdep -r src-internal@3803956c4af7
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I62764da8eaf39f1e4804b1100243cd8038fa6046
    Reviewed-on: https://chromium-review.googlesource.com/c/1365426
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614370}

    Changed files

    • DEPS
  84. [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in subresource_filter

    Changed by Carlos Caballero - carlscabohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 16:10:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ad0f7767c18d3300fe7becde35058c50bf48ffd4

    Comments

    [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in subresource_filter
    
    MessageLoop will go away, eventually.
    
    BUG=891670
    
    Change-Id: I3fcddf556b24d65f93a7d575093d89ab45e5e22e
    Reviewed-on: https://chromium-review.googlesource.com/c/1352783
    Reviewed-by: Dominic Battré <battre@chromium.org>
    Commit-Queue: Carlos Caballero <carlscab@google.com>
    Cr-Commit-Position: refs/heads/master@{#614369}

    Changed files

    • components/subresource_filter/content/browser/async_document_subresource_filter_unittest.cc
  85. [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in reading_list

    Changed by Carlos Caballero - carlscabohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 16:09:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38b88b324987071d63453326c3eff948c64ac80c

    Comments

    [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in reading_list
    
    MessageLoop will go away, eventually.
    
    BUG=891670
    
    Change-Id: I4525159fc6e326db0f77bd38a1a8cca63ae9ab28
    Reviewed-on: https://chromium-review.googlesource.com/c/1352764
    Commit-Queue: Carlos Caballero <carlscab@google.com>
    Reviewed-by: Eric Noyau <noyau@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614368}

    Changed files

    • components/reading_list/core/reading_list_store_unittest.cc
  86. [Autofill Assistant] Added terms&conditions link to the onboarding.

    Changed by Clemens Arbesser - arbesserohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 16:01:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cd919f3f010e5b6de66e39935e9799217778cd5a

    Comments

    [Autofill Assistant] Added terms&conditions link to the onboarding.
    
    Note that this URL is currently under construction, the corresponding issue is here: b/120547988
    
    Bug: 806868
    Change-Id: Ic7ecf90682c392cbe7762ec451570e651e4f5f79
    Reviewed-on: https://chromium-review.googlesource.com/c/1365446
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Commit-Queue: Clemens Arbesser <arbesser@google.com>
    Cr-Commit-Position: refs/heads/master@{#614367}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/FirstRunScreen.java
    • chrome/android/java/strings/android_chrome_strings.grd
  87. [cc] Fix incorrect KeyframeModel::InEffect() calculation on the cc side

    Changed by Yi Gu - yiguohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:01:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f22e0fbd1e6b06ff4d59faf95b2338f750fc0dac

    Comments

    [cc] Fix incorrect KeyframeModel::InEffect() calculation on the cc side
    
    By spec [1], an animation effect is "in effect" if its active time is
    not unresolved. However, if the effect is in the "after phase" and its
    fill mode is neither "forwards" nor "both", its active time should be
    unresolved which makes the effect not "in effect". Our cc logic doesn't
    handle this case correctly.
    
    This bug was not exposed because for regular animations we cancel the
    animation on compositor in such scenario. But for worklet animations
    that's not the case.
    
    This patch adds the logic of calculating phases and the corresponding
    active time based on the spec [2].
    
    [1] https://drafts.csswg.org/web-animations/#in-effect
    [2] https://drafts.csswg.org/web-animations/#active-time
    
    Bug: 906675
    Change-Id: I8872719432ede1eeeb1e7bdcf3b5f0312787c0d7
    Reviewed-on: https://chromium-review.googlesource.com/c/1342598
    Commit-Queue: Yi Gu <yigu@chromium.org>
    Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
    Reviewed-by: Majid Valipour <majidvp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614366}

    Changed files

    • cc/animation/keyframe_model.cc
    • cc/animation/keyframe_model.h
    • cc/animation/keyframe_model_unittest.cc
    • third_party/blink/web_tests/TestExpectations
    • third_party/blink/web_tests/animations/animationworklet/worklet-animation-local-time-after-duration.html
  88. Fix SnapshotBrowserTest.AsyncMultiWindowTest for SkiaRenderer + DDL

    Changed by Peng Huang - penghuangohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:52:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b80c413d66b8cbc37db662ee9b141691b79c0eae

    Comments

    Fix SnapshotBrowserTest.AsyncMultiWindowTest for SkiaRenderer + DDL
    
    Bug: 911793
    Change-Id: I937e902d7e9ff7e046710558e48e4765b3ec06ee
    Reviewed-on: https://chromium-review.googlesource.com/c/1363864
    Reviewed-by: weiliangc <weiliangc@chromium.org>
    Commit-Queue: Peng Huang <penghuang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614365}

    Changed files

    • components/viz/service/display/direct_renderer.cc
    • components/viz/service/display/gl_renderer.cc
    • components/viz/service/display/skia_renderer.cc
  89. cros: Fix startup page focus

    Changed by Xiyuan Xia - xiyuanohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:52:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2a66b11ee57844b24718b518f170706bc9242eab

    Comments

    cros: Fix startup page focus
    
    - Move RestoreFocus from BrowserView::Show to OnWidgetActivationChanged
      to do it when the browser window is activated;
    - Remove SetInitialFocus in SessionRestoreImpl::ShowBrowser since
      BrowserView change should do that as part of RestoreFocus;
    - Also remove the debugging code for SetInitialFocus crash
      under SessionRestoreImpl::RestoreTab since ShowBrowser no longer
      calls SetInitialFocus;
    
    Bug: 859257, 850626, 908524
    Change-Id: Ia24e4d68e1386de84765f914bb75319c9887dfd1
    Reviewed-on: https://chromium-review.googlesource.com/c/1313728
    Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614364}

    Changed files

    • chrome/browser/sessions/session_restore.cc
    • chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc
    • chrome/browser/ui/views/frame/browser_view.cc
    • chrome/browser/ui/views/frame/browser_view.h
    • chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc
    • chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
    • chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc
    • content/browser/web_contents/web_contents_impl.cc
    • content/browser/web_contents/web_contents_impl.h
  90. Roll src/third_party/skia 7b7ab595d908..b45d5124816e (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 15:46:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 57fc861db699982ad4c3aa3e0a509a1626cc6146

    Comments

    Roll src/third_party/skia 7b7ab595d908..b45d5124816e (2 commits)
    
    https://skia.googlesource.com/skia.git/+log/7b7ab595d908..b45d5124816e
    
    
    git log 7b7ab595d908..b45d5124816e --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 halcanary@google.com bin/sysopen: script moved to bin
    2018-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 8f1b7a66a5e3..d300548fcc28 (1 commits)
    
    
    Created with:
      gclient setdep -r src/third_party/skia@b45d5124816e
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jcgregorio@chromium.org
    
    Change-Id: I3d2ffa675f1a4bc1a9509ab85ecb6c7b974dc5f9
    Reviewed-on: https://chromium-review.googlesource.com/c/1365423
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614363}

    Changed files

    • DEPS
  91. Closure compile list_thumbnail_loader_unittest

    Changed by Noel Gordon - noelohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:36:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 454a4f0cb9c837740bbb0bb1f07809728f98f4a6

    Comments

    Closure compile list_thumbnail_loader_unittest
    
     - remove list_thumbnail_loader_unittest.html
     - add BUILD rules to auto-generate and compile this unittest
     - add @types to the unittest vars
     - inline the canvas dataURL image creation step in Setup()
     - fix all Closure compiler errors
    
    No change in test behavior, no new tests.
    
    Bug: 912557
    Change-Id: I157b0c1ef56704901e760e6f5125e4e05ea76377
    Reviewed-on: https://chromium-review.googlesource.com/c/1364999
    Commit-Queue: Stuart Langley <slangley@chromium.org>
    Reviewed-by: Stuart Langley <slangley@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614362}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_jstest.cc
    • ui/file_manager/file_manager/foreground/js/BUILD.gn
    • ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.html
    • ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.js
  92. Mark upcoming WPT media-source test as WontFix

    Changed by Raphael Kubo da Costa - raphael.kubo.da.costaohnoyoudont@intel.com
    Changed at Thursday, 06-Dec-18 15:35:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 15bf688046abf6202ae6151e2459409060b9def6

    Comments

    Mark upcoming WPT media-source test as WontFix
    
    This test requires MP4 support in content_shell; that's not enabled by
    default and breaks WPT imports.
    
    TBR=chcunningham@chromium.org, wolenetz@chromium.org
    
    No-Try: true
    Change-Id: I3f176312cec46c8ef03dad5d40106c721b0f9723
    Reviewed-on: https://chromium-review.googlesource.com/c/1365613
    Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
    Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
    Cr-Commit-Position: refs/heads/master@{#614361}

    Changed files

    • third_party/blink/web_tests/NeverFixTests
  93. [EventTiming] Make PerformanceEventTiming Exposed=Window

    Changed by Nicolas Pena - npmohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:33:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fa0f7396931a4b55b3f8aba9de6345817a4fa081

    Comments

    [EventTiming] Make PerformanceEventTiming Exposed=Window
    
    This CL makes PerformanceEventTiming IDL consistent with the spec, after
    https://github.com/WICG/event-timing/pull/16. Note that EventCount is
    not yet implemented.
    
    Bug: 823744
    Change-Id: I01779ed82cba0cfea0542ab74cc95b4e7adc8aac
    Reviewed-on: https://chromium-review.googlesource.com/c/1363961
    Reviewed-by: Timothy Dresser <tdresser@chromium.org>
    Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614360}

    Changed files

    • third_party/blink/renderer/core/timing/performance_event_timing.idl
  94. [swarming] Remove non CIPD managed luci-go package

    Changed by Takuto Ikuta - tikutaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:29:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d5c1c0b4189d3e625d7e5a1c0568f255d911d5b6

    Comments

    [swarming] Remove non CIPD managed luci-go package
    
    Bug: 851596
    Change-Id: I834ccae440b5590525644e4ad9e9d3c952038547
    Reviewed-on: https://chromium-review.googlesource.com/c/1364976
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
    Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614359}

    Changed files

    • DEPS
    • tools/luci-go/.gitignore
    • tools/luci-go/linux64/isolate.sha1
    • tools/luci-go/mac64/isolate.sha1
    • tools/luci-go/win64/isolate.exe.sha1
  95. gpu_init: Stop inlining GpuInit::TakeDefaultOffscreenSurface()

    Changed by Raphael Kubo da Costa - raphael.kubo.da.costaohnoyoudont@intel.com
    Changed at Thursday, 06-Dec-18 15:22:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 763b79a9142f3f063eca4504dc9a45b7e75e252f

    Comments

    gpu_init: Stop inlining GpuInit::TakeDefaultOffscreenSurface()
    
    This fixes the GCC build after commit b6ef3ba2a3 ("Pass GpuPreferences to
    in-process GPU in Mash"):
    
        In file included from ../../content/utility/utility_service_factory.h:12,
                         from ../../content/utility/utility_service_factory.cc:5:
        ../../base/memory/scoped_refptr.h: In instantiation of ‘static void scoped_refptr<T>::Release(T*) [with T = gl::GLSurface]’:
        ../../base/memory/scoped_refptr.h:208:14:   required from ‘scoped_refptr<T>::~scoped_refptr() [with T = gl::GLSurface]’
        ../../gpu/ipc/service/gpu_init.h:70:48:   required from here
        ../../base/memory/scoped_refptr.h:284:8: error: invalid use of incomplete type ‘class gl::GLSurface’
           ptr->Release();
           ~~~~~^~~~~~~
        In file included from ../../services/viz/service.h:8,
                         from ../../content/utility/utility_service_factory.cc:35:
        ../../gpu/ipc/service/gpu_init.h:22:7: note: forward declaration of ‘class gl::GLSurface’
         class GLSurface;
               ^~~~~~~~~
    
    gpu_init.h forward-declares gl::GLSurface but using std::move() with GCC
    seems to require a full declaration for things to work.
    
    Bug: 819294
    Change-Id: Ib22ca2f8af6977869571292acf780042507a8afd
    Reviewed-on: https://chromium-review.googlesource.com/c/1365249
    Reviewed-by: Jonathan Backer <backer@chromium.org>
    Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
    Cr-Commit-Position: refs/heads/master@{#614358}

    Changed files

    • gpu/ipc/service/gpu_init.cc
    • gpu/ipc/service/gpu_init.h
  96. Cleanup ContentClient and ContentBrowserClient.

    Changed by Sergey Kuznetsov - kuznetsovsohnoyoudont@yandex-team.ru
    Changed at Thursday, 06-Dec-18 15:14:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d6f9ac554c7ac46b1401183b8925ca96327e2cf3

    Comments

    Cleanup ContentClient and ContentBrowserClient.
    
    Otherwise dangling pointers are leave - this can affect other
    tests. For example, if some test uses content::TestBrowserThreadBundle
    and runs after AndroidWebViewStateSerializerTest, this test will fail.
    
    Change-Id: Ic39f5e10a68a232ca2b3d58dcd21dc61bab29e43
    Reviewed-on: https://chromium-review.googlesource.com/c/1354445
    Commit-Queue: Bo <boliu@chromium.org>
    Reviewed-by: Bo <boliu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614357}

    Changed files

    • android_webview/browser/state_serializer_unittest.cc
  97. Roll src/third_party/SPIRV-Tools/src 03afee3b9081..2e4563d94f9d (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 15:14:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c5413cf5e311b79d1ba90bb3f69ab0ec5bd52d14

    Comments

    Roll src/third_party/SPIRV-Tools/src 03afee3b9081..2e4563d94f9d (1 commits)
    
    https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/03afee3b9081..2e4563d94f9d
    
    
    git log 03afee3b9081..2e4563d94f9d --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 stevenperron@google.com Document in the context what happens with id overflow. (#2159)
    
    
    Created with:
      gclient setdep -r src/third_party/SPIRV-Tools/src@2e4563d94f9d
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I3d9b965d9a72ca7f3180c5a14e4ed28a7ce905db
    Reviewed-on: https://chromium-review.googlesource.com/c/1365422
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614356}

    Changed files

    • DEPS
  98. Roll src/third_party/perfetto 659c1b009ec3..f6a1cb2d8968 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 15:12:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dc4e8d2d0fefe947d4dd4456a96c76d6dfc0a8ad

    Comments

    Roll src/third_party/perfetto 659c1b009ec3..f6a1cb2d8968 (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/659c1b009ec3..f6a1cb2d8968
    
    
    git log 659c1b009ec3..f6a1cb2d8968 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 lalitm@google.com Merge "trace_processor: speed up args table even more"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@f6a1cb2d8968
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Iefd01cf34bed9c2c688570386aa10a75fdaa45f4
    Reviewed-on: https://chromium-review.googlesource.com/c/1365421
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614355}

    Changed files

    • DEPS
  99. Run tests when policy_test_cases.json changes

    Changed by Andreea Costinas - acostinasohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 15:12:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0c940428a52570c147124aed3eb41f080e9a5be6

    Comments

    Run tests when policy_test_cases.json changes
    
    BUG=498579
    
    Change-Id: I0ef207bbcf210de686902b2248f4e0c96453b707
    Reviewed-on: https://chromium-review.googlesource.com/c/1365236
    Commit-Queue: Andreea-Elena Costinas <acostinas@google.com>
    Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614354}

    Changed files

    • chrome/test/data/policy/PRESUBMIT.py
    • components/policy/resources/PRESUBMIT.py
  100. Remove highlight delay for FindInPage results out of screen.

    Changed by Yi Su - mrsuyiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 15:10:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 40735d1fe4a48f42b6ec7b71dcaa92c3f04a095f

    Comments

    Remove highlight delay for FindInPage results out of screen.
    
    In current implementation of find_in_page.js, when user navigates to a
    match result out of the screen, the orange highlight will be added to it
    with a 250ms delay. In previous version, the callback invoked after
    250ms will always add orange highlight to the current selected match
    result, and the CL(http://crrev/c/1347363) accidently changed the logic
    and created a bug. If user clicks "goNext" fast enough, selected match
    result may get highlighted permanently.
    
    However, after deeper investigation, the delayed highlight seems to be
    buggy from the begining. Navigating backward to a match result that is
    inside the screen will also meets the condition and trigger the delay,
    but the 250ms is just too short to be noticed.
    Besides, why we need the delay is also mysterious, and here is my guess:
    In ancient time the find_in_page.js do two things, first scroll to the
    match result and then do the highlight, and somehow UIWebView requires
    us to add a delay(see the comments in old version code). Then the
    scrolling work moved from Js into OC, so there are two lines about
    scrolling that are commented out.
    
    Since UX has also confirmed that delay on highlight is not necessary, it
    should be removed now.
    
    Bug: 911611
    Change-Id: If0fef219b33954e243e527f3b50dbe836f753ede
    Reviewed-on: https://chromium-review.googlesource.com/c/1365610
    Reviewed-by: Peter Lee <pkl@chromium.org>
    Commit-Queue: Yi Su <mrsuyi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614353}

    Changed files

    • ios/chrome/browser/find_in_page/resources/find_in_page.js
  101. <blame list capped at 100 commits>

    Changed by <blame list capped at 100 commits> -
    Changed at N/A
    Repository
    Branch
    Revision

    Comments

    <blame list capped at 100 commits>