Home | Search | chromium - Builders
Login

Builder KitKat Tablet Tester Build 1542 Canonical Ubuntu

Results:

Failure content_shell_test_apk on Android device Nexus 7 [2013] Failure content_browsertests on Android device Nexus 7 [2013] Failure chrome_public_test_apk on Android device Nexus 7 [2013]

Trigger Info:

Projectchromium
Revision17f321cb0b8198ca3c72ac8dbf9a6acbd3588df0
Got Revision17f321cb0b8198ca3c72ac8dbf9a6acbd3588df0

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Aga Wronska (agawronskaohnoyoudont@chromium.org)
  2. Ian Clelland (iclellandohnoyoudont@chromium.org)
  3. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  4. Roger Tawa (rogertaohnoyoudont@chromium.org)
  5. Ryan Hansberry (hansberryohnoyoudont@chromium.org)
  6. Dominick Ng (dominicknohnoyoudont@chromium.org)
  7. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  8. chrome-release-bot (chrome-release-botohnoyoudont@chromium.org)
  9. Kyle Horimoto (khorimotoohnoyoudont@google.com)
  10. Sadrul Habib Chowdhury (sadrulohnoyoudont@chromium.org)
  11. Azeem Arshad (azeemarshadohnoyoudont@chromium.org)
  12. Albert J. Wong (ajwongohnoyoudont@chromium.org)
  13. Becky Zhou (huayinzohnoyoudont@chromium.org)
  14. wutao (wutaoohnoyoudont@chromium.org)
  15. David Black (dmblackohnoyoudont@google.com)
  16. David Black (dmblackohnoyoudont@google.com)
  17. Pavel Feldman (pfeldmanohnoyoudont@chromium.org)
  18. Zhizhou Yang (zhizhouyohnoyoudont@google.com)
  19. Scott Chen (scottchenohnoyoudont@chromium.org)
  20. Patti (patricialorohnoyoudont@chromium.org)
  21. Kent Tamura (tkentohnoyoudont@chromium.org)
  22. Henrique Nakashima (hnakashimaohnoyoudont@chromium.org)
  23. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  24. John Rummell (jrummellohnoyoudont@chromium.org)
  25. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  26. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  27. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  28. Edward Lemur (ehmaldonadoohnoyoudont@chromium.org)
  29. Eric Roman (eromanohnoyoudont@chromium.org)
  30. Jeremy Klein (jlkleinohnoyoudont@google.com)
  31. Jeremy Klein (jlkleinohnoyoudont@google.com)
  32. Lei Zhang (thestigohnoyoudont@chromium.org)
  33. Nico Weber (thakisohnoyoudont@chromium.org)
  34. khmel@chromium.org (khmelohnoyoudont@chromium.org)
  35. HyeockJinKim (kherootzohnoyoudont@gmail.com)
  36. rbpotter (rbpotterohnoyoudont@chromium.org)
  37. Xiaocheng Hu (xiaochenghohnoyoudont@chromium.org)
  38. Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
  39. Thomas Anderson (thomasandersonohnoyoudont@chromium.org)
  40. Sunny Sachanandani (sunnypsohnoyoudont@chromium.org)
  41. Albert J. Wong (ajwongohnoyoudont@chromium.org)
  42. Avi Drissman (aviohnoyoudont@chromium.org)
  43. Albert J. Wong (ajwongohnoyoudont@chromium.org)
  44. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  45. James Cook (jamescookohnoyoudont@chromium.org)
  46. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  47. Jun Cai (juncaiohnoyoudont@chromium.org)
  48. Chris Lu (thegreenfrogohnoyoudont@chromium.org)
  49. Jordy Greenblatt (jordynassohnoyoudont@chromium.org)
  50. Kurt Horimoto (kkhorimotoohnoyoudont@chromium.org)
  51. Timothy Loh (timlohohnoyoudont@chromium.org)
  52. Bret Sepulveda (bsepohnoyoudont@chromium.org)
  53. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  54. Daniel Erat (deratohnoyoudont@chromium.org)
  55. Manuel Rego Casasnovas (regoohnoyoudont@igalia.com)
  56. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  57. Christian Biesinger (cbiesingerohnoyoudont@chromium.org)
  58. Dmitry Titov (dimichohnoyoudont@chromium.org)
  59. Ted Meyer (tmathmeyerohnoyoudont@chromium.org)
  60. Toni Barzic (tbarzicohnoyoudont@google.com)
  61. Alex Moshchuk (alexmosohnoyoudont@chromium.org)
  62. Emil A Eklund (eaeohnoyoudont@chromium.org)
  63. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
  64. Karan Bhatia (karandeepbohnoyoudont@chromium.org)
  65. siyua (siyuaohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 04:52:25 UTC
Start Friday, 12-Oct-18 04:52:50 UTC
End Friday, 12-Oct-18 07:36:16 UTC
Pending 24 secs
Execution 2 hrs 43 mins

All Changes:

  1. Demo mode: Add debug logs to demo mode setup.

    Changed by Aga Wronska - agawronskaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 03:38:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 17f321cb0b8198ca3c72ac8dbf9a6acbd3588df0

    Comments

    Demo mode: Add debug logs to demo mode setup.
    
    Logging demo setup steps will help to determine at what point problems
    occured for example in case of infinite loading.
    
    Change-Id: I04725e4c9d0de12553f6f14fb3d8ee7d106e9699
    Reviewed-on: https://chromium-review.googlesource.com/c/1277957
    Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
    Commit-Queue: Aga Wronska <agawronska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599088}

    Changed files

    • chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc
  2. Enable FP reporting for sensor policy violations.

    Changed by Ian Clelland - iclellandohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 03:36:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a4699db12f4e711719ba1d225ff7c82d62a2a6c

    Comments

    Enable FP reporting for sensor policy violations.
    
    This queues a report through the Reporting API whenever the Generic Sensor API
    is used in a frame in which the specific sensor is not allowed according to
    feature policy.
    
    Bug: 867471
    Change-Id: I9c50f4a331b2b2230890ee0c357047704af8425a
    Reviewed-on: https://chromium-review.googlesource.com/c/1263041
    Reviewed-by: Reilly Grant <reillyg@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Ian Clelland <iclelland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599087}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/generic-sensor-reporting.https.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/generic-sensor-reporting.https.html.headers
    • third_party/blink/renderer/core/frame/device_single_window_event_controller.cc
    • third_party/blink/renderer/modules/sensor/sensor.cc
  3. Roll src/third_party/chromite d23bbdb87b57..9a72c51a329f (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 03:34:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b2cf2dab488e2544ca9bb60b18778ac736257c13

    Comments

    Roll src/third_party/chromite d23bbdb87b57..9a72c51a329f (2 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/d23bbdb87b57..9a72c51a329f
    
    
    git log d23bbdb87b57..9a72c51a329f --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 vapier@chromium.org paygen: download_cache_unittest: convert to lib.gs & delete gslib.Cat
    2018-10-12 vapier@chromium.org paygen: gslib: drop unused Stat
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@9a72c51a329f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I5c3d6623dd88c54fd144213025257ecc157d0565
    Reviewed-on: https://chromium-review.googlesource.com/c/1278489
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599086}

    Changed files

    • DEPS
  4. Fix compile confirm no-op in win builders.

    Changed by Roger Tawa - rogertaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 03:34:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 50cfd443f039957406f1eec2324d058bb9726e60

    Comments

    Fix compile confirm no-op in win builders.
    
    Bug: 893874
    Change-Id: Id07fb2e9d67403cb77d571df41b4b2aef11bb46d
    Reviewed-on: https://chromium-review.googlesource.com/c/1278475
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599085}

    Changed files

    • chrome/credential_provider/gaiacp/BUILD.gn
  5. [CrOS MultiDevice] Display a modal webview of links in MultiDevice OOBE screen.

    Changed by Ryan Hansberry - hansberryohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 03:21:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cfebc9e310c9fd4494d0944b3133745224aa01f9

    Comments

    [CrOS MultiDevice] Display a modal webview of links in MultiDevice OOBE screen.
    
    Links can't be opened like they usually would be in OOBE, because there's no
    browser to open them in. This CL creates a webview modal which is displayed
    when the user clicks on one of the two "Learn More" links in the MultiDevice
    OOBE screen, and loads it with the appropriate URL.
    
    Screenshot: https://screenshot.googleplex.com/JL9nfShorRA.png
    
    Bug: 893349
    Change-Id: I1ac06ea26857adcdf1f3113756e95e15b2f8a127
    Reviewed-on: https://chromium-review.googlesource.com/c/1275296
    Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599084}

    Changed files

    • chrome/browser/resources/chromeos/login/multidevice_setup_first_run.html
    • chrome/browser/resources/chromeos/login/multidevice_setup_first_run.js
    • chrome/browser/resources/chromeos/login/screen_multidevice_setup.html
    • ui/webui/resources/cr_components/chromeos/multidevice_setup/BUILD.gn
    • ui/webui/resources/cr_components/chromeos/multidevice_setup/start_setup_page.html
    • ui/webui/resources/cr_components/chromeos/multidevice_setup/start_setup_page.js
  6. Add the CrOS intent helper as a browser supporting WebAPKs.

    Changed by Dominick Ng - dominicknohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 03:21:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4729eda6b9057a0a052573a7cb9c9af46f907eae

    Comments

    Add the CrOS intent helper as a browser supporting WebAPKs.
    
    This will allow WebAPKs to be bounced to the desktop browser on Chrome
    OS devices.
    
    BUG=893927
    
    Change-Id: Ic70b58d2ab2b23960cc894dd3420174b523908e6
    Reviewed-on: https://chromium-review.googlesource.com/c/1272756
    Reviewed-by: Xi Han <hanxi@chromium.org>
    Commit-Queue: Dominick Ng <dominickn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599083}

    Changed files

    • chrome/android/webapk/shell_apk/current_version/current_version.gni
    • chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/HostBrowserUtils.java
  7. Roll src/third_party/angle f2ed299569c0..c4533eae082f (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 03:12:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d47784f23ea51b0b1def44a767780f383be6b090

    Comments

    Roll src/third_party/angle f2ed299569c0..c4533eae082f (1 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/f2ed299569c0..c4533eae082f
    
    
    git log f2ed299569c0..c4533eae082f --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 yizhou.jiang@intel.com Enable ANGLE_texture_multisample in glsl in es 3.0
    
    
    Created with:
      gclient setdep -r src/third_party/angle@c4533eae082f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=fjhenigman@chromium.org
    
    Change-Id: Ie5a6b652c2c723a90215ae863749da0c24965d4d
    Reviewed-on: https://chromium-review.googlesource.com/c/1278528
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599082}

    Changed files

    • DEPS
  8. Updating trunk VERSION from 3578.0 to 3579.0 and incrementing major version to 72

    Changed by chrome-release-bot - chrome-release-botohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 03:08:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 16e778a19743677a294dd155583e11f265f0d065

    Comments

    Updating trunk VERSION from 3578.0 to 3579.0 and incrementing major version to 72
    
    # This is an automated release commit.
    # Do not revert without consulting chrome-pmo@google.com.
    NOAUTOREVERT=true
    TBR=benmason@chromium.org
    
    Change-Id: I81c44eb87bd68655b6cbc34a68cde6f851a839f0
    Reviewed-on: https://chromium-review.googlesource.com/c/1278328
    Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599081}

    Changed files

    • chrome/MAJOR_BRANCH_DATE
    • chrome/VERSION
  9. [CrOS MultiDevice] Add Shutdown() handling in MultiDevice KeyedServices.

    Changed by Kyle Horimoto - khorimotoohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 03:06:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f49ce435169672969142e5da5303def870e7fd98

    Comments

    [CrOS MultiDevice] Add Shutdown() handling in MultiDevice KeyedServices.
    
    This ensures that connections to our Mojo services are disconnected,
    which will result in the Shutdown() code added in this CL will run:
    https://chromium-review.googlesource.com/c/chromium/src/+/1274886
    
    Bug: 884066
    Change-Id: Ifb4fad53fc9d1a693ae83099dc43ee9908303ea7
    TBR: jhawkins@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/c/1277588
    Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
    Reviewed-by: Jeremy Klein <jlklein@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599080}

    Changed files

    • chrome/browser/chromeos/android_sms/android_sms_service.cc
    • chrome/browser/chromeos/device_sync/device_sync_client_factory.cc
    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
    • chrome/browser/chromeos/multidevice_setup/multidevice_setup_client_factory.cc
    • chromeos/services/device_sync/BUILD.gn
    • chromeos/services/device_sync/device_sync_base.cc
    • chromeos/services/device_sync/device_sync_base.h
    • chromeos/services/device_sync/device_sync_impl.cc
    • chromeos/services/device_sync/fake_device_sync.cc
  10. android: Dump for delayed presentation timestamp.

    Changed by Sadrul Habib Chowdhury - sadrulohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:55:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31c0c1c2517f38fb1e0ed336c4e70d261b97e69d

    Comments

    android: Dump for delayed presentation timestamp.
    
    It looks like on android, presentation timestamps can sometimes be very
    large. DumpWithoutCrashing() in such cases to collect some data to
    understand why/when/where this is happening.
    
    BUG=894440
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Change-Id: I22817f68014c3f57f7180accc593506eee86f291
    Reviewed-on: https://chromium-review.googlesource.com/c/1276549
    Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
    Reviewed-by: kylechar <kylechar@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599079}

    Changed files

    • base/timer/elapsed_timer.h
    • components/viz/service/display/display.cc
    • components/viz/service/display/display.h
  11. Add Android Messages usage info in notifications settings.

    Changed by Azeem Arshad - azeemarshadohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:51:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b9d0776816b987172184af69d6de4a09def7dca6

    Comments

    Add Android Messages usage info in notifications settings.
    
    This CL adds a special note under messages for android entry
    in notification permissions to indicate usage in ChromeOS multidevice
    features. This note will be displayed whenever the messages
    sync feature is enabled. Please refer screenshot:
    https://screenshot.googleplex.com/VnGZ1qApzHk.png
    
    Bug: 845706
    Change-Id: Ibcbe706cf9c579d980e4440825b8bc70b64466df
    Reviewed-on: https://chromium-review.googlesource.com/c/1260503
    Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
    Reviewed-by: Jeremy Klein <jlklein@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599078}

    Changed files

    • chrome/app/settings_strings.grdp
    • chrome/browser/resources/settings/multidevice_page/multidevice_browser_proxy.js
    • chrome/browser/resources/settings/settings_resources.grd
    • chrome/browser/resources/settings/site_settings/BUILD.gn
    • chrome/browser/resources/settings/site_settings/site_list.html
    • chrome/browser/resources/settings/site_settings/site_list.js
    • chrome/browser/resources/settings/site_settings/site_list_entry.js
    • chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/webui/settings/chromeos/multidevice_handler.cc
    • chrome/browser/ui/webui/settings/chromeos/multidevice_handler.h
    • chrome/browser/ui/webui/settings/chromeos/multidevice_handler_unittest.cc
    • chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
    • chrome/test/data/webui/settings/cr_settings_browsertest.js
    • chrome/test/data/webui/settings/multidevice_page_tests.js
    • chrome/test/data/webui/settings/multidevice_subpage_tests.js
    • chrome/test/data/webui/settings/site_list_entry_tests.js
    • chrome/test/data/webui/settings/site_list_tests.js
    • chrome/test/data/webui/settings/test_multidevice_browser_proxy.js
    • chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js
  12. Use unique_ptr<> for BrowserPluginGuest creation APIs

    Changed by Albert J. Wong - ajwongohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:50:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c55cc64d0a527b307b12e547fc5b5c1f1a93c70b

    Comments

    Use unique_ptr<> for BrowserPluginGuest creation APIs
    
    Bug: 419087
    Change-Id: Ic870c7059fef752560d0299064a0cef4a1733f3a
    Reviewed-on: https://chromium-review.googlesource.com/c/1277594
    Commit-Queue: Albert J. Wong <ajwong@chromium.org>
    Reviewed-by: Nasko Oskov <nasko@chromium.org>
    Reviewed-by: danakj <danakj@chromium.org>
    Reviewed-by: James MacLean <wjmaclean@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599077}

    Changed files

    • content/browser/browser_plugin/browser_plugin_guest.cc
    • content/browser/browser_plugin/browser_plugin_guest.h
    • content/browser/web_contents/web_contents_impl.cc
    • content/browser/web_contents/web_contents_impl.h
  13. Update VR JS dialog goldens

    Changed by Becky Zhou - huayinzohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:37:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c72c4a77a976bc67bbcb4a5bc2340ac48b47f5ae

    Comments

    Update VR JS dialog goldens
    
    Bug: 894660
    Change-Id: Ib8b7d6484bd050daf4d295c1c9367bd132cb9e80
    Reviewed-on: https://chromium-review.googlesource.com/c/1278269
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Becky Zhou <huayinz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599076}

    Changed files

    • components/test/data/js_dialogs/render_tests/VrBrowserJavaScriptModalDialogTest.js_modal_view_vr_alert.Pixel_XL-25.png
    • components/test/data/js_dialogs/render_tests/VrBrowserJavaScriptModalDialogTest.js_modal_view_vr_alert.Pixel_XL-26.png
    • components/test/data/js_dialogs/render_tests/VrBrowserJavaScriptModalDialogTest.js_modal_view_vr_confirm.Pixel_XL-25.png
    • components/test/data/js_dialogs/render_tests/VrBrowserJavaScriptModalDialogTest.js_modal_view_vr_confirm.Pixel_XL-26.png
    • components/test/data/js_dialogs/render_tests/VrBrowserJavaScriptModalDialogTest.js_modal_view_vr_prompt.Pixel_XL-25.png
    • components/test/data/js_dialogs/render_tests/VrBrowserJavaScriptModalDialogTest.js_modal_view_vr_prompt.Pixel_XL-26.png
  14. assistant: Check status before starting service

    Changed by wutao - wutaoohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:33:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2a789a6e4d2c639cfe39db5b7b19edd6a0837ad6

    Comments

    assistant: Check status before starting service
    
    This cl checks the |allowed_status| before starting assistant service.
    
    Bug: b/117371953
    Test: manual.
    Change-Id: I0b638db9d92abd5f54c5f7f41d5f66c25a719f77
    Reviewed-on: https://chromium-review.googlesource.com/c/1278345
    Commit-Queue: Tao Wu <wutao@chromium.org>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599075}

    Changed files

    • chrome/browser/ui/ash/assistant/assistant_client.cc
  15. Modify Assistant DialogPlate icons and shift greeting label.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 02:32:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ddbc8a4da719464b3ebdbdae529019bc64964738

    Comments

    Modify Assistant DialogPlate icons and shift greeting label.
    
    Per request from UI/UX folks, enlarging DialogPlate icons sizes to
    24dip and adjusting left inset for voice input modality layout container.
    
    Note that the vector icon files themselves were also updated per request
    in the bug to ensure consistency of internal padding.
    
    Also per request, the greeting label is shifted up by 4dip.
    
    See bug for discussion/screenshots.
    
    Bug: b:112313532
    Change-Id: I5b72c6867452470abbc8bd562c83ba37492279ea
    Reviewed-on: https://chromium-review.googlesource.com/c/1276947
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599074}

    Changed files

    • ash/assistant/ui/dialog_plate/action_view.cc
    • ash/assistant/ui/dialog_plate/dialog_plate.cc
    • ash/assistant/ui/main_stage/assistant_main_stage.cc
    • ash/resources/vector_icons/BUILD.gn
    • ash/resources/vector_icons/keyboard.icon
    • ash/resources/vector_icons/mic.icon
    • ash/resources/vector_icons/settings.icon
  16. Move response processing out of UiElementContainerView.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 02:27:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 74869ac201a1859b4acc0bc0e0b14304f99843fb

    Comments

    Move response processing out of UiElementContainerView.
    
    This CL moves processing logic out of UiElementContainerView and into
    AssistantResponseProcessor which is owned by
    AssistantInteractionController.
    
    The controller will now initiate processing of the Assistant response
    before it is finalized. This cleans up the view logic considerably as
    well as provides better synchronization of animations since processing
    will have already occurred prior to the stage initiating a change.
    
    Bug: b:117344968, b:116751668
    Change-Id: I3ac1300978a3448fd7e244b6a7312ec9bf3c39bd
    Reviewed-on: https://chromium-review.googlesource.com/c/1265820
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599073}

    Changed files

    • ash/BUILD.gn
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/assistant_response_processor.cc
    • ash/assistant/assistant_response_processor.h
    • ash/assistant/model/assistant_interaction_model.cc
    • ash/assistant/model/assistant_interaction_model.h
    • ash/assistant/model/assistant_interaction_model_observer.h
    • ash/assistant/model/assistant_response.cc
    • ash/assistant/model/assistant_response.h
    • ash/assistant/model/assistant_response_observer.h
    • ash/assistant/model/assistant_ui_element.cc
    • ash/assistant/model/assistant_ui_element.h
    • ash/assistant/ui/assistant_mini_view.cc
    • ash/assistant/ui/assistant_mini_view.h
    • ash/assistant/ui/assistant_ui_constants.h
    • ash/assistant/ui/main_stage/assistant_header_view.cc
    • ash/assistant/ui/main_stage/assistant_header_view.h
    • ash/assistant/ui/main_stage/assistant_main_stage.cc
    • ash/assistant/ui/main_stage/assistant_main_stage.h
    • ash/assistant/ui/main_stage/suggestion_container_view.cc
    • ash/assistant/ui/main_stage/suggestion_container_view.h
    • ash/assistant/ui/main_stage/ui_element_container_view.cc
    • ash/assistant/ui/main_stage/ui_element_container_view.h
  17. DevTools: use invoke_ notation for the DOM.getNodeForLocation

    Changed by Pavel Feldman - pfeldmanohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:26:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a5b00caf3bd7d17a327de3ddef647259af155ee

    Comments

    DevTools: use invoke_ notation for the DOM.getNodeForLocation
    
    Bug: 893705
    Change-Id: I6df37f886de9c080fa20c972df7457b0a726ce3e
    Reviewed-on: https://chromium-review.googlesource.com/c/1278206
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599072}

    Changed files

    • third_party/blink/renderer/devtools/front_end/sdk/DOMModel.js
  18. nacl_helper: Removing ldflags which intended to fix crash in ThinLTO

    Changed by Zhizhou Yang - zhizhouyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 02:15:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38a512ee8468d9a18ccdbe57f02344d93e1e4729

    Comments

    nacl_helper: Removing ldflags which intended to fix crash in ThinLTO
    
    This patch will remove a linker flag for ThinLTO. The flag was first
    introduced to work around a nacl crash bug. After the compiler upgrade,
    there is no need to keep this work around.
    
    I tested the nacl_helper code size changes on several different boards:
    on samus: 30MB -> 11MB
    on elm: 19MB -> 7MB
    on veyton-minnie: 19MB -> 7MB
    
    Tested correctness by trying to reproduce https://crbug.com/799642 and
    no error shows up.
    
    BUG=chromium:799642
    TEST=USE="afdo_use" emerge-samus chromeos-chrome
    
    Change-Id: I6fff65700e6d5a5d0e02ad810def5317ea912263
    Reviewed-on: https://chromium-review.googlesource.com/c/1277596
    Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
    Commit-Queue: Zhizhou Yang <zhizhouy@google.com>
    Cr-Commit-Position: refs/heads/master@{#599071}

    Changed files

    • components/nacl/loader/BUILD.gn
  19. Reland "NUX Onboarding: clean up build process."

    Changed by Scott Chen - scottchenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:15:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f68c9b2548a5f1a2462146e1efc36165571c055c

    Comments

    Reland "NUX Onboarding: clean up build process."
    
    The original CL 1252906 was reverted due to breaking unit tests for
    branded window builds.
    
    This CL fixes that by removing obsolete unit tests. It was testing the
    mechanism that conditionally directs users to the chrome://welcome/email
    and chrome://welcome/apps experiment URLs, which will no longer be used.
    
    Bug: 874153
    Change-Id: I3b92b53e191606a6f5889cf17b15a570ce566994
    Reviewed-on: https://chromium-review.googlesource.com/c/1275294
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599070}

    Changed files

    • BUILD.gn
    • chrome/browser/profiles/profile_manager.cc
    • chrome/browser/resources/BUILD.gn
    • chrome/browser/resources/welcome/onboarding_welcome/BUILD.gn
    • chrome/browser/resources/welcome/onboarding_welcome/email/BUILD.gn
    • chrome/browser/resources/welcome/onboarding_welcome/google_apps/BUILD.gn
    • chrome/browser/resources/welcome/onboarding_welcome/set_as_default/BUILD.gn
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/startup/startup_browser_creator.cc
    • chrome/browser/ui/startup/startup_tab_provider.cc
    • chrome/browser/ui/startup/startup_tab_provider.h
    • chrome/browser/ui/startup/startup_tab_provider_unittest.cc
    • chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc
    • chrome/browser/ui/webui/welcome/nux_helper.cc
    • chrome/browser/ui/webui/welcome/nux_helper.h
    • chrome/browser/ui/webui/welcome/welcome_ui.cc
    • chrome/browser/ui/webui/welcome/welcome_ui.h
    • chrome/common/pref_names.cc
    • chrome/common/pref_names.h
  20. Revert "splitscreen: Adjust bubble dialog bounds if splitscreen is active."

    Changed by Patti - patricialorohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:14:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e41458e037d2d6eea8297dfee4006848bb6f123a

    Comments

    Revert "splitscreen: Adjust bubble dialog bounds if splitscreen is active."
    
    This reverts commit c3acb7ba6a2b6565656736f3050bfc593baf4781.
    
    Reason for revert: This change may be causing ash_unittests to fail on multiple builders - see crbug.com/894683
    
    Original change's description:
    > splitscreen: Adjust bubble dialog bounds if splitscreen is active.
    > 
    > When a dialog is added to a window that's currently showig in
    > splitscreen, we should adjust the dialog bounds to show the dialog
    > aligned within its own side of the split, rather than across the divider
    > bar.
    > 
    > Note the divider is still placed on top of the snapped windows and its
    > transient children if they are placed in default container.
    > 
    > Bug: 878268
    > Change-Id: Ibdd71f1d42aac419ef73ae9f7a2f78af6bf36880
    > Reviewed-on: https://chromium-review.googlesource.com/c/1274197
    > Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#598827}
    
    TBR=xiyuan@chromium.org,xdai@chromium.org
    
    Change-Id: I74d78ce0184d2028811872ac633da33ede16f296
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 878268, 894683
    Reviewed-on: https://chromium-review.googlesource.com/c/1277907
    Reviewed-by: Patti <patricialor@chromium.org>
    Commit-Queue: Patti <patricialor@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599069}

    Changed files

    • ash/wm/splitview/split_view_controller_unittest.cc
    • ash/wm/splitview/split_view_divider.cc
    • ash/wm/splitview/split_view_divider.h
  21. Make PRESUBMIT.py and tests in LayoutTests/ workable in web_tests/.

    Changed by Kent Tamura - tkentohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:07:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59dc2a72979d66089c58d1c0da8f835ec2894692

    Comments

    Make PRESUBMIT.py and tests in LayoutTests/ workable in web_tests/.
    
    This CL makes LayoutTests/PRESUBMIT.py and some tests in LayoutTests/
    workable in blink/web_tests/ too.
    Moving LayoutTests directory gets easier by this CL.
    
    * PRESUBMIT.py
     - Use PresubmitLocalPath() instead of 'LayoutTests'
     - Remove unnecessary check for existence of 'LayoutTests' in
      AffectedFiles(), which returns files under the PRESUBMIT directory.
      _FindNewViolationsOfRule() also handles only files under the
      PRESUBMIT directory.
    
    * Tests
     - Update code searching for 'LayoutTests' so that it searches for
       'web_tests' too.
     - Drop 'LayoutTests' from test expectations if we can
     - Introduce relativeTestPath()
    
    Change-Id: I741ab3cb29d8e6c2a35e3b7669f92744f76c2839
    Bug: 843412
    Reviewed-on: https://chromium-review.googlesource.com/c/1276047
    Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599068}

    Changed files

    • third_party/WebKit/LayoutTests/PRESUBMIT.py
    • third_party/WebKit/LayoutTests/cssom/cssfloat-cssom.html
    • third_party/WebKit/LayoutTests/editing/assert_selection.js
    • third_party/WebKit/LayoutTests/editing/pasteboard/drag-files-to-editable-element.html
    • third_party/WebKit/LayoutTests/fast/dom/Window/dom-access-from-closure-iframe-expected.txt
    • third_party/WebKit/LayoutTests/fast/dom/Window/dom-access-from-closure-window-expected.txt
    • third_party/WebKit/LayoutTests/fast/dom/Window/dom-access-from-closure-window-with-gc-expected.txt
    • third_party/WebKit/LayoutTests/fast/dom/Window/resources/dom-access-from-closure-iframe-child.html
    • third_party/WebKit/LayoutTests/fast/dom/Window/resources/dom-access-from-closure-window-child.html
    • third_party/WebKit/LayoutTests/fast/dom/documenturi-not-affected-by-base-tag-expected.txt
    • third_party/WebKit/LayoutTests/fast/dom/documenturi-not-affected-by-base-tag.html
    • third_party/WebKit/LayoutTests/fast/frames/frame-src-attribute-expected.txt
    • third_party/WebKit/LayoutTests/fast/frames/frame-src-attribute.html
    • third_party/WebKit/LayoutTests/fast/js/script-tests/exception-line-number.js
    • third_party/WebKit/LayoutTests/fast/workers/constructor-proto.html
    • third_party/WebKit/LayoutTests/fast/workers/resources/worker-location.js
    • third_party/WebKit/LayoutTests/fast/workers/resources/worker-navigator.js
    • third_party/WebKit/LayoutTests/fast/workers/resources/worker-replace-self.js
    • third_party/WebKit/LayoutTests/http/tests/devtools/file-system-project.js
    • third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/network-uisourcecode-provider.js
    • third_party/WebKit/LayoutTests/inspector-protocol/dom-snapshot/dom-snapshot-getSnapshot-expected.txt
    • third_party/WebKit/LayoutTests/inspector-protocol/dom-snapshot/dom-snapshot-getSnapshot.js
    • third_party/WebKit/LayoutTests/resources/common.js
  22. Stop after type mismatch of args of a message received by PDF Plugin.

    Changed by Henrique Nakashima - hnakashimaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:06:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ba3e80058ac8ed66fefa0ec3c68adba8edcac6e2

    Comments

    Stop after type mismatch of args of a message received by PDF Plugin.
    
    Previously, after HandleMessage matched the message type, if the
    argument types were wrong it would keep trying to match with the
    other message types.
    
    Change-Id: Ia270ddc0ac4614b3ef998bcd30d3686f987dd809
    Reviewed-on: https://chromium-review.googlesource.com/c/1277445
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599067}

    Changed files

    • pdf/out_of_process_instance.cc
  23. Import wpt@639d29d0f4f7932109ce83039d3d057f4cac75b0

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:04:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a19a0bb310f57c27fe5dbfe5bdca3244ac430091

    Comments

    Import wpt@639d29d0f4f7932109ce83039d3d057f4cac75b0
    
    Using wpt-import in Chromium 08d41ac558fd84035f4fea691370edf2fe7373d9.
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25970
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
      external/wpt/fetch
    
    NOAUTOREVERT=true
    TBR=foolip
    
    No-Export: true
    Change-Id: Ic18cb6ace02a8e07c8b1c4fcca71bd9ce8704ebd
    Reviewed-on: https://chromium-review.googlesource.com/c/1278142
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599066}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/fetch/api/abort/serviceworker-intercepted.https.html
    • third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/destination/resources/fetch-destination-worker-no-load-event.js
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/postmessage-to-client.https.html
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/about-blank-replacement-ping-frame.py
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/enable-client-message-queue.html
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/message-vs-microtask.html
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/nested-iframe-parent.html
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/stalling-service-worker.js
  24. Don't try RemoveTemporarySession test if license server not available.

    Changed by John Rummell - jrummellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 01:57:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 44229dd3259f368779bfc384620e127c0c0abba9

    Comments

    Don't try RemoveTemporarySession test if license server not available.
    
    BUG=894422
    TEST=test passes on Windows
    
    Change-Id: I3907fecda3642f542db153e68ce12cb33c074402
    Reviewed-on: https://chromium-review.googlesource.com/c/1278467
    Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
    Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599065}

    Changed files

    • chrome/browser/media/encrypted_media_browsertest.cc
  25. Roll src-internal 55ac0aa2f68f..616feb1a7c2c (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 01:57:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 040907c0408cd98d7ee1d368002c258b8356c41a

    Comments

    Roll src-internal 55ac0aa2f68f..616feb1a7c2c (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/55ac0aa2f68f..616feb1a7c2c
    
    
    Created with:
      gclient setdep -r src-internal@616feb1a7c2c
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ia68c999e8e301f47fc1e0dadeb8cd369a1377495
    Reviewed-on: https://chromium-review.googlesource.com/c/1277840
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599064}

    Changed files

    • DEPS
  26. Roll src/third_party/pdfium c7f66edd2244..94f3ca931552 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 01:54:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1949eebad19138b6a0e701255b6c3a9ad2e9868b

    Comments

    Roll src/third_party/pdfium c7f66edd2244..94f3ca931552 (2 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/c7f66edd2244..94f3ca931552
    
    
    git log c7f66edd2244..94f3ca931552 --date=short --no-merges --format='%ad %ae %s'
    2018-10-11 thestig@chromium.org Fix some nits in CJS_Document helpers.
    2018-10-11 thestig@chromium.org Use pdfium::Vector2D in CCodec_FaxEncoder ctor.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@94f3ca931552
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I062fef526b85eec3b0d299893951ad74a10d4b2c
    Reviewed-on: https://chromium-review.googlesource.com/c/1278485
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599063}

    Changed files

    • DEPS
  27. Roll src/third_party/chromite 7078e2599b7b..d23bbdb87b57 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 01:47:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4aaee5b116fefa626ebf5dcb400e609cafcfebed

    Comments

    Roll src/third_party/chromite 7078e2599b7b..d23bbdb87b57 (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/7078e2599b7b..d23bbdb87b57
    
    
    git log 7078e2599b7b..d23bbdb87b57 --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 gmx@chromium.org kip: enable new tcmalloc
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@d23bbdb87b57
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I7c19b61739142e56b9c1053adbbf8b5884e2738c
    Reviewed-on: https://chromium-review.googlesource.com/c/1277836
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599062}

    Changed files

    • DEPS
  28. cq.cfg: Fix path_regexp TODOs.

    Changed by Edward Lemur - ehmaldonadoohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 01:41:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 347bb67558d64a078cc2f025965d9edbe3aed995

    Comments

    cq.cfg: Fix path_regexp TODOs.
    
    Bug: 881860
    Change-Id: I32d8c17e2501010a24b9550c433407dfd55a3807
    Reviewed-on: https://chromium-review.googlesource.com/c/1278525
    Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
    Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599061}

    Changed files

    • infra/config/branch/cq.cfg
  29. Handle a BOM when converting PAC file to UTF16.

    Changed by Eric Roman - eromanohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 01:30:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 598760f52aa37c308598575dbd037d7c9f3fcba5

    Comments

    Handle a BOM when converting PAC file to UTF16.
    
    Bug: 891526
    Change-Id: I3ecda33cc7c1dbc2df96a613c5723a77ead9806c
    Reviewed-on: https://chromium-review.googlesource.com/c/1258505
    Reviewed-by: Matt Mueller <mattm@chromium.org>
    Commit-Queue: Eric Roman <eroman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599060}

    Changed files

    • net/data/pac_file_fetcher_unittest/utf8_bom
    • net/data/pac_file_fetcher_unittest/utf8_bom.mock-http-headers
    • net/proxy_resolution/pac_file_fetcher_impl.cc
    • net/proxy_resolution/pac_file_fetcher_impl_unittest.cc
  30. Fix a11y test error for multidevice settings.

    Changed by Jeremy Klein - jlkleinohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 01:29:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cf4ff7aa5b049728149b2a55e6a021301fa6657

    Comments

    Fix a11y test error for multidevice settings.
    
    Adding a temporary exception for one link-in-text-block error. This
    error comes from the fact that we (intentionally) removed the underline
    from the learn more links in our settings. I've filed crbug.com/894602
    to work with UX on a new strategy and remove this exception.
    
    Bug: 894602
    Change-Id: I0da37adfee02699415a011939dbfc6d4e1d93f34
    Reviewed-on: https://chromium-review.googlesource.com/c/1278131
    Commit-Queue: Jeremy Klein <jlklein@chromium.org>
    Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599059}

    Changed files

    • chrome/test/data/webui/settings/a11y/multidevice_features_a11y_test.js
  31. Make Instant Tethering work with legacy hosts before hosts update.

    Changed by Jeremy Klein - jlkleinohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 01:26:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1c6c9d1b3bb70322ae10fb4be29a5adfb5cfa587

    Comments

    Make Instant Tethering work with legacy hosts before hosts update.
    
    The phone side flags and enrollment will be slower than the ChromeOS
    rollout. In order to avoid breaking Instant Tethering in the meantime,
    look for cases where:
    
    1) There are no host devices reporting BETTER_TOGETHER_HOST support.
    2) There is at least one host device reporting INSTANT_TETHER_HOST
    support.
    
    In this scenario, the only possiblity is that this host device has not
    reenrolled yet after receiving the new flags.
    
    Bug: 893769
    Change-Id: Ib7fd0acdbe80903a499dd0dd42fd60365304371d
    Reviewed-on: https://chromium-review.googlesource.com/c/1277272
    Commit-Queue: Jeremy Klein <jlklein@chromium.org>
    Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599058}

    Changed files

    • chrome/browser/chromeos/tether/tether_service.cc
    • chrome/browser/chromeos/tether/tether_service_unittest.cc
    • chromeos/components/tether/tether_host_fetcher_impl.cc
    • chromeos/components/tether/tether_host_fetcher_impl.h
    • chromeos/components/tether/tether_host_fetcher_impl_unittest.cc
  32. Mark more members const in cloud_print::JobStatusUpdater.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 01:24:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bcb24b8f745411839bdd26219dc407a0d3817394

    Comments

    Mark more members const in cloud_print::JobStatusUpdater.
    
    Also remove some unused/redundant headers, and remove a check that will
    always evaluate to true.
    
    Change-Id: I816ab3154c50b1f0f1f8c4fc738760b97e607d7e
    Reviewed-on: https://chromium-review.googlesource.com/c/1277677
    Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599057}

    Changed files

    • chrome/service/cloud_print/job_status_updater.cc
    • chrome/service/cloud_print/job_status_updater.h
  33. Revert "Set symbol_level=0 on Windows Deterministic."

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 01:20:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f8ebcecf7a1b5a9d628ed8dd81727da65fff7ecc

    Comments

    Revert "Set symbol_level=0 on Windows Deterministic."
    
    This reverts commit 4e9c4b371d71f4b6fe73fce2272cf4e31d11e250.
    
    Reason for revert: This might no longer be needed; revert to check.
    
    (I thought the bot built in two different build dirs, and for that
    to work we need to land https://chromium-review.googlesource.com/c/chromium/src/+/1273479
    first, but it builds in one dir, moves that elsewhere, and builds
    in that dir again. We should probably make it build in two different
    dirs once that other CL is in, to make sure that that keeps working.)
    
    Original change's description:
    > Set symbol_level=0 on Windows Deterministic.
    > 
    > If /debug is passed to lld, the pdb aging in PDB70DebugInfo currently
    > means that repeat builds get different PDB70DebugInfo headers, so for now
    > don't pass /debug to the linker.
    > 
    > Bug: 330260
    > Change-Id: I86e6b470ad95f3f6556c8f8f69d6d394a32661ff
    > Reviewed-on: https://chromium-review.googlesource.com/1162948
    > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    > Commit-Queue: Nico Weber <thakis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#580765}
    
    TBR=thakis@chromium.org,dpranke@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 330260
    Change-Id: I8637e6c089464eddc7d9cfc35f6fa28b0cd54987
    Reviewed-on: https://chromium-review.googlesource.com/c/1277486
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599056}

    Changed files

    • tools/mb/mb_config.pyl
  34. arc: Add extra logging for app mojom connection

    Changed by khmel@chromium.org - khmelohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 01:14:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9df42e7973b3de51c882b991e926a297c18f6bcc

    Comments

    arc: Add extra logging for app mojom connection
    
    TEST=Manually
    BUG=b:117366533
    
    Change-Id: I1038cbd9adf7e92df1953a428cd9b1a9bceb9b45
    Reviewed-on: https://chromium-review.googlesource.com/c/1278291
    Commit-Queue: Yury Khmel <khmel@chromium.org>
    Commit-Queue: Yusuke Sato <yusukes@chromium.org>
    Reviewed-by: Yusuke Sato <yusukes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599055}

    Changed files

    • chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
  35. Remove SpeechSynthesisConstants namespace

    Changed by HyeockJinKim - kherootzohnoyoudont@gmail.com
    Changed at Friday, 12-Oct-18 01:12:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f23bb6eb62b50840802a155c3603e7427e960160

    Comments

    Remove SpeechSynthesisConstants namespace
    
    Remove sub-namespace and rename symbols
    to start with WebSpeechSynthesisConstants.
    
    Bug: 889726
    Change-Id: I48be833ca3b71f6a482f23d168a2aeaf212323f4
    Reviewed-on: https://chromium-review.googlesource.com/c/1257722
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Luke Halliwell <halliwell@chromium.org>
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
    Cr-Commit-Position: refs/heads/master@{#599054}

    Changed files

    • chrome/browser/chromeos/preferences.cc
    • chrome/browser/speech/extension_api/tts_extension_api.cc
    • chrome/browser/speech/tts_controller_impl.cc
    • chrome/browser/speech/tts_controller_unittest.cc
    • chromecast/browser/tts/tts_controller_impl.cc
    • third_party/blink/public/platform/web_speech_synthesis_constants.h
    • third_party/blink/renderer/platform/speech/platform_speech_synthesis_utterance.h
  36. Settings UI: Fix PeoplePageSetupPinDialogTest to work with Polymer2

    Changed by rbpotter - rbpotterohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 01:08:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fcb5be8f285963a1aca816d8764e03e9cd1624b3

    Comments

    Settings UI: Fix PeoplePageSetupPinDialogTest to work with Polymer2
    
    Fixing CrSettingsPeoplePageSetupPinDialogTest.All with 2 changes:
    (1) Reading updated pin dialog from the pin-change event, rather than
        from |pinKeyboardValue_|. In Polymer 2, this value is not updated
        at the time the pin-change event arrives.
    (1) In the test for the backspace button, set the value in cr-input
        instead of on the pinKeyboard directly, so that |selectionStart_|,
        used to determine if the backspace key should be enabled, will be
        > 0.
    
    Bug: 875454
    Change-Id: Iec83f3a85a4d04fe710cb6b5e23b99d59be54f49
    Reviewed-on: https://chromium-review.googlesource.com/c/1274462
    Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599053}

    Changed files

    • chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
    • testing/buildbot/filters/webui_polymer2_browser_tests.filter
    • ui/webui/resources/cr_components/chromeos/quick_unlock/setup_pin_keyboard.js
  37. Layout test text dump rebaseline using Element.innerText part 1

    Changed by Xiaocheng Hu - xiaochenghohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 01:07:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 90115af8ecbdd8015ff48566d4a88a95810c83ee

    Comments

    Layout test text dump rebaseline using Element.innerText part 1
    
    This patch changes tests in the following directories to use
    Element.innerText for text dump:
    
    accessibility/
    animations/
    battery-status/
    bindings/
    clipboard/
    compositing/
    crypto/
    
    Most of this patch is mechanical rebaseline, except:
    - Some LayoutNG-specific baselines become redundant and are
      removed
    - One test is turned into failure with LayoutNG flag due to
      LayoutNG innerText bug with ellipsis (crbug.com/873957).
    
    Bug: 887148
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Idf28a2696b4824f3fd845c7392b588544e8de1d3
    Reviewed-on: https://chromium-review.googlesource.com/c/1239165
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599052}

    Changed files

    • content/shell/test_runner/test_interfaces.cc
    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/WebKit/LayoutTests/accessibility/accessibility-hit-test-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/accessibility-node-memory-management-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/accessibility-node-reparent-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/accessibility-object-detached-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/add-to-menu-list-crashes-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/adopt-node-causes-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/anchor-linked-anonymous-block-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/anonymous-render-block-in-continuation-causes-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-checkbox-checked-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-checkbox-checked-mixed-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-checkbox-sends-notification-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-controls-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-controls-with-tabs-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-describedby-on-input-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-disabled-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-fallback-roles-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-flowto-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-hidden-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-hidden-hides-all-elements-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-hidden-update-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-hidden-updates-alldescendants-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-hidden-with-elements-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-label-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-labelledby-on-input-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-aria-label-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-label-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-list-and-listitem-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-none-role-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-option-role-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-orientation-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-presentational-role-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-readonly-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-roles-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-scrollbar-role-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-setsize-posinset-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-tab-roles-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-tables-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-text-role-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-toggle-button-with-title-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-used-on-image-maps-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/br-element-has-correct-title-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/button-title-uses-inner-img-alt-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/calling-accessibility-methods-with-pending-layout-causes-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/canvas-accessibilitynodeobject-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/canvas-description-and-role-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/canvas-fallback-content-2-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/canvas-fallback-content-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/canvas-fallback-content-labels-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/chromium-only-roles-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/clickable-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/color-well-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/computed-name-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/computed-role-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/container-node-delete-causes-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/content-changed-notification-causes-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/contenteditable-hidden-div-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/contenteditable-notifications-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/contenteditable-table-check-causes-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/corresponding-control-deleted-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/crash-determining-aria-role-when-label-present-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/crash-on-accessing-properties-at-initial-state-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/crash-with-noelement-selectbox-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/crashing-a-tag-in-map-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/css-generated-content-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/css-styles-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/disabled-controls-not-focusable-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/div-within-anchors-causes-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/dl-role-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/draw-focus-if-needed-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/duplicate-child-nodes-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/element-role-mapping-focusable-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/element-role-mapping-normal-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/ellipsis-text-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/file-upload-button-with-axpress-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/first-letter-text-transform-causes-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/focusable-div-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/hang-in-isignored-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/heading-level-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/image-link-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/image-link-inline-cont-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/image-map-title-causes-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/image-map-update-parent-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/image-map-with-indirect-area-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/image-map1-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/image-map2-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/img-alt-tag-only-whitespace-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/img-aria-button-alt-tag-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/img-fallsback-to-title-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/inline-continuations-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/inline-text-bidi-bounds-for-range-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/inline-text-change-style-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/inline-text-changes-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/inline-text-input-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/inline-text-textarea-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/inline-text-word-boundaries-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/inline-text-word-boundary-causes-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/input-aria-required-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/input-file-causes-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/input-image-alt-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/input-type-password-value-and-selection-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/input-type-range-aria-value-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/input-type-range-value-change-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/input-type-text-caret-position-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/input-type-text-selection-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/insert-adjacent-html-causes-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/insert-selected-option-into-select-causes-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/is-ignored-change-sends-notification-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/is-richly-editable-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/label-element-press-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/label-for-control-hittest-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/legend-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/link-inside-button-accessible-text-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/link-inside-label-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/listbox-enabled-states-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/listitem-presentation-inherited-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/main-element-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/media-controls-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/menu-item-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/menu-list-popup-reuses-objects-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/menu-list-selection-changed-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/menu-list-sends-change-notification-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/meter-value-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/nested-layout-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/nochildren-elements-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/non-data-table-cell-title-ui-element-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/non-native-image-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/notification-listeners-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/onclick-handlers-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/platform-name-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/presentation-owned-elements-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/presentational-elements-with-focus-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/press-works-on-control-types-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/radio-button-title-label-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/readonly-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/removed-anonymous-block-child-causes-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/removed-continuation-element-causes-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/role-attribute-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/scroll-div-horiz-sends-notification-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/scroll-div-sends-notification-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/scroll-to-global-point-main-window-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/scroll-to-global-point-nested-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/scroll-to-make-visible-div-overflow-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/scroll-to-make-visible-main-window-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/scroll-to-make-visible-nested-2-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/scroll-to-make-visible-nested-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/scroll-to-make-visible-with-subfocus-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/scroll-window-horiz-sends-notification-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/scroll-window-sends-notification-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/selection-change-notification-aria-textbox-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/selection-change-notification-contenteditable-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/selection-change-notification-input-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/selection-change-notification-statictext-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/selection-change-notification-textarea-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/selection-states-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/spinbutton-value-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/svg-bounds-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/svg-image-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/svg-path-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/table-caption-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/table-cell-for-column-and-row-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/table-cells-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/table-cells-with-colspan-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/table-destroyed-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/table-detection-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/table-header-column-row-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/table-headers-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/table-one-cell-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/table-remove-cell-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/table-row-with-aria-role-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/table-with-empty-thead-causes-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/table-with-hidden-head-section-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/table-with-rules-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/textarea-caret-position-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/textarea-line-for-index-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/textarea-selection-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/textbox-role-on-contenteditable-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/title-ui-element-correctness-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/updating-attribute-in-table-causes-crash-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/whitespace-in-name-calc-expected.txt
    • third_party/WebKit/LayoutTests/animations/animation-css-rule-types-expected.txt
    • third_party/WebKit/LayoutTests/animations/change-in-animation-frame-expected.txt
    • third_party/WebKit/LayoutTests/animations/computed-style-expected.txt
    • third_party/WebKit/LayoutTests/animations/display-none-cancel-computedstyle-expected.txt
    • third_party/WebKit/LayoutTests/animations/events/animation-end-event-short-iterations-expected.txt
    • third_party/WebKit/LayoutTests/animations/events/animation-events-create-expected.txt
    • third_party/WebKit/LayoutTests/animations/events/animation-iteration-event-short-iterations-expected.txt
    • third_party/WebKit/LayoutTests/animations/events/events-with-short-duration-and-delay-expected.txt
    • third_party/WebKit/LayoutTests/animations/hit-testing/inline-element-animation-end-hit-test-expected.txt
    • third_party/WebKit/LayoutTests/animations/keyframes-rule-expected.txt
    • third_party/WebKit/LayoutTests/animations/lazy-detached-animation-stop-expected.txt
    • third_party/WebKit/LayoutTests/animations/prefixed/animation-events-prefixed-01-expected.txt
    • third_party/WebKit/LayoutTests/animations/prefixed/animation-events-prefixed-02-expected.txt
    • third_party/WebKit/LayoutTests/animations/prefixed/animation-events-prefixed-03-expected.txt
    • third_party/WebKit/LayoutTests/animations/prefixed/animation-events-unprefixed-01-expected.txt
    • third_party/WebKit/LayoutTests/animations/prefixed/animation-events-unprefixed-02-expected.txt
    • third_party/WebKit/LayoutTests/animations/prefixed/animation-events-unprefixed-03-expected.txt
    • third_party/WebKit/LayoutTests/animations/prefixed/animation-inherit-initial-unprefixed-expected.txt
    • third_party/WebKit/LayoutTests/animations/prefixed/keyframes-cssom-prefixed-02-expected.txt
    • third_party/WebKit/LayoutTests/animations/prefixed/keyframes-cssom-unprefixed-02-expected.txt
    • third_party/WebKit/LayoutTests/animations/stability/element-animate-float-crash-expected.txt
    • third_party/WebKit/LayoutTests/animations/stability/empty-keyframes-expected.txt
    • third_party/WebKit/LayoutTests/animations/stability/option-element-crash-expected.txt
    • third_party/WebKit/LayoutTests/animations/timing/timing-model-expected.txt
    • third_party/WebKit/LayoutTests/animations/wrong-keyframe-name-expected.txt
    • third_party/WebKit/LayoutTests/battery-status/api-defined-expected.txt
    • third_party/WebKit/LayoutTests/battery-status/detached-no-crash-expected.txt
    • third_party/WebKit/LayoutTests/battery-status/multiple-promises-after-resolve-expected.txt
    • third_party/WebKit/LayoutTests/battery-status/multiple-promises-expected.txt
    • third_party/WebKit/LayoutTests/battery-status/multiple-windows-expected.txt
    • third_party/WebKit/LayoutTests/battery-status/multiple-windows-page-visibility-expected.txt
    • third_party/WebKit/LayoutTests/battery-status/no-gc-with-eventlisteners-expected.txt
    • third_party/WebKit/LayoutTests/battery-status/no-leak-on-detached-use-expected.txt
    • third_party/WebKit/LayoutTests/battery-status/page-visibility-expected.txt
    • third_party/WebKit/LayoutTests/battery-status/promise-with-eventlisteners-expected.txt
    • third_party/WebKit/LayoutTests/battery-status/restricted-level-precision-expected.txt
    • third_party/WebKit/LayoutTests/bindings/blink-in-js-asan-crash-expected.txt
    • third_party/WebKit/LayoutTests/bindings/idl-dictionary-unittest-expected.txt
    • third_party/WebKit/LayoutTests/bindings/idl-union-type-unittest-expected.txt
    • third_party/WebKit/LayoutTests/clipboard/readtext-denied.https-expected.txt
    • third_party/WebKit/LayoutTests/clipboard/readtext-granted.https-expected.txt
    • third_party/WebKit/LayoutTests/clipboard/writetext-denied.https-expected.txt
    • third_party/WebKit/LayoutTests/clipboard/writetext-granted.https-expected.txt
    • third_party/WebKit/LayoutTests/compositing/animation/hidden-composited-expected.txt
    • third_party/WebKit/LayoutTests/compositing/backface-visibility/backface-visibility-image-expected.txt
    • third_party/WebKit/LayoutTests/compositing/backface-visibility/backface-visibility-webgl-expected.txt
    • third_party/WebKit/LayoutTests/compositing/backing/no-backing-foreground-layer-expected.txt
    • third_party/WebKit/LayoutTests/compositing/child-transform-layer-requires-box-expected.txt
    • third_party/WebKit/LayoutTests/compositing/columns/geometry-map-paginated-assert-expected.txt
    • third_party/WebKit/LayoutTests/compositing/composited-negative-zindex-child-expected.txt
    • third_party/WebKit/LayoutTests/compositing/contents-opaque/control-layer-expected.txt
    • third_party/WebKit/LayoutTests/compositing/draws-content/canvas-background-layer-expected.txt
    • third_party/WebKit/LayoutTests/compositing/draws-content/webgl-background-layer-expected.txt
    • third_party/WebKit/LayoutTests/compositing/empty-render-surface-crasher-expected.txt
    • third_party/WebKit/LayoutTests/compositing/force-compositing-mode/no-overflow-iframe-layer-expected.txt
    • third_party/WebKit/LayoutTests/compositing/force-compositing-mode/overflow-hidden-iframe-layer-expected.txt
    • third_party/WebKit/LayoutTests/compositing/force-compositing-mode/overflow-iframe-enter-compositing-expected.txt
    • third_party/WebKit/LayoutTests/compositing/force-compositing-mode/overflow-iframe-layer-expected.txt
    • third_party/WebKit/LayoutTests/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt
    • third_party/WebKit/LayoutTests/compositing/geometry/bounds-ignores-hidden-expected.txt
    • third_party/WebKit/LayoutTests/compositing/geometry/clipped-video-controller-expected.txt
    • third_party/WebKit/LayoutTests/compositing/geometry/empty-embed-rects-expected.txt
    • third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-composited-page-scale-down-expected.txt
    • third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-composited-page-scale-expected.txt
    • third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-composited-page-scale-scroll-expected.txt
    • third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.txt
    • third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.txt
    • third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.txt
    • third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale-expected.txt
    • third_party/WebKit/LayoutTests/compositing/geometry/foreground-layer-expected.txt
    • third_party/WebKit/LayoutTests/compositing/geometry/geometry-map-scroll-during-layout-assertion-expected.txt
    • third_party/WebKit/LayoutTests/compositing/geometry/object-clip-rects-assertion-expected.txt
    • third_party/WebKit/LayoutTests/compositing/geometry/repaint-foreground-layer-expected.txt
    • third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-inline-block-crash-expected.txt
    • third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-no-graphics-layer-region-based-multicol-expected.txt
    • third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-pixel-rotated-div-expected.txt
    • third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-pixel-rotated-link-expected.txt
    • third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-pixel-transparent-expected.txt
    • third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-with-squashing-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/become-composited-nested-iframes-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/become-overlapped-iframe-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/composited-iframe-transition-flicker-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/composited-parent-iframe-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/connect-compositing-iframe-delayed-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/connect-compositing-iframe-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/connect-compositing-iframe2-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/connect-compositing-iframe3-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/crash-mouse-event-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/enter-compositing-iframe-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/iframe-composited-scrolling-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/iframe-composited-scrolling-hide-and-show-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/iframe-resize-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/iframe-size-from-zero-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/iframe-size-to-zero-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/invisible-nested-iframe-show-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/layout-on-compositing-change-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/overlapped-iframe-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/overlapped-nested-iframes-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/resizer-expected.txt
    • third_party/WebKit/LayoutTests/compositing/iframes/scrolling-iframe-expected.txt
    • third_party/WebKit/LayoutTests/compositing/images/clip-on-directly-composited-image-expected.txt
    • third_party/WebKit/LayoutTests/compositing/images/content-image-expected.txt
    • third_party/WebKit/LayoutTests/compositing/images/direct-image-dynamic-border-draws-content-expected.txt
    • third_party/WebKit/LayoutTests/compositing/layer-creation/animation-overlap-with-children-expected.txt
    • third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt
    • third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt
    • third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-invisible-scroll-reasons-expected.txt
    • third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-no-content-scroll-reason-expected.txt
    • third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-nonscrollable-iframes-in-scrollable-page-expected.txt
    • third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-dynamic-expected.txt
    • third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-positioning-expected.txt
    • third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt
    • third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-expected.txt
    • third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll-expected.txt
    • third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt
    • third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scroll-reason-expected.txt
    • third_party/WebKit/LayoutTests/compositing/layer-creation/iframe-background-attachment-fixed-expected.txt
    • third_party/WebKit/LayoutTests/compositing/layer-creation/main-thread-scrolling-for-non-composited-fixed-position-expected.txt
    • third_party/WebKit/LayoutTests/compositing/layer-creation/main-thread-scrolling-non-composited-fixed-overflow-hidden-expected.txt
    • third_party/WebKit/LayoutTests/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt
    • third_party/WebKit/LayoutTests/compositing/layer-creation/rotate3d-overlap-expected.txt
    • third_party/WebKit/LayoutTests/compositing/layout-width-change-expected.txt
    • third_party/WebKit/LayoutTests/compositing/overflow/avoid-ancestor-clip-for-scroll-children-expected.txt
    • third_party/WebKit/LayoutTests/compositing/overflow/do-not-crash-use-after-free-update-widget-positions-expected.txt
    • third_party/WebKit/LayoutTests/compositing/overflow/iframe-inside-overflow-clipping-expected.txt
    • third_party/WebKit/LayoutTests/compositing/overflow/iframe-nested-scroll-children-expected.txt
    • third_party/WebKit/LayoutTests/compositing/overflow/iframe-scroll-children-expected.txt
    • third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-pointer-events-toggle-expected.txt
    • third_party/WebKit/LayoutTests/compositing/overflow/scrolls-with-respect-to-expected.txt
    • third_party/WebKit/LayoutTests/compositing/scrollbars/custom-composited-add-vertical-then-horizontal-expected.txt
    • third_party/WebKit/LayoutTests/compositing/self-painting-layers2-expected.txt
    • third_party/WebKit/LayoutTests/compositing/squashing/add-remove-squashed-layers-expected.txt
    • third_party/WebKit/LayoutTests/compositing/squashing/backing-owner-determines-scroll-parent-expected.txt
    • third_party/WebKit/LayoutTests/compositing/squashing/clipping-backface-assert-expected.txt
    • third_party/WebKit/LayoutTests/compositing/squashing/do-not-squash-scroll-child-with-composited-descendants-expected.txt
    • third_party/WebKit/LayoutTests/compositing/squashing/repaint-child-of-squashed-expected.txt
    • third_party/WebKit/LayoutTests/compositing/squashing/squash-above-fixed-1-expected.txt
    • third_party/WebKit/LayoutTests/compositing/squashing/squash-above-fixed-2-expected.txt
    • third_party/WebKit/LayoutTests/compositing/squashing/squash-above-fixed-3-expected.txt
    • third_party/WebKit/LayoutTests/compositing/squashing/squash-compositing-hover-expected.txt
    • third_party/WebKit/LayoutTests/compositing/squashing/squash-transform-repainting-child-expected.txt
    • third_party/WebKit/LayoutTests/compositing/squashing/squash-transform-repainting-transformed-child-expected.txt
    • third_party/WebKit/LayoutTests/compositing/squashing/squashed-layer-loses-graphicslayer-expected.txt
    • third_party/WebKit/LayoutTests/compositing/squashing/squashed-repaints-expected.txt
    • third_party/WebKit/LayoutTests/compositing/transitions/opacity-on-inline-expected.txt
    • third_party/WebKit/LayoutTests/compositing/visibility/compositing-and-visibility-turned-off-together-expected.txt
    • third_party/WebKit/LayoutTests/compositing/visibility/hidden-iframe-expected.txt
    • third_party/WebKit/LayoutTests/compositing/visibility/visibility-image-layers-expected.txt
    • third_party/WebKit/LayoutTests/compositing/webgl/webgl-copy-image-expected.txt
    • third_party/WebKit/LayoutTests/crypto/array-buffer-view-offset-expected.txt
    • third_party/WebKit/LayoutTests/crypto/crypto-gc-expected.txt
    • third_party/WebKit/LayoutTests/crypto/gc-2-expected.txt
    • third_party/WebKit/LayoutTests/crypto/gc-3-expected.txt
    • third_party/WebKit/LayoutTests/crypto/gc-expected.txt
    • third_party/WebKit/LayoutTests/crypto/random-values-expected.txt
    • third_party/WebKit/LayoutTests/crypto/random-values-limits-expected.txt
    • third_party/WebKit/LayoutTests/crypto/random-values-types-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/abandon-crypto-operation-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/abandon-crypto-operation2-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-cbc/cloneKey-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-cbc/decrypt-failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-cbc/encrypt-decrypt-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-cbc/failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-cbc/generate-key-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-cbc/generateKey-failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-cbc/import-jwk-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-cbc/invalid-length-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-cbc/unwrap-failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-cbc/unwrap-rsa-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-cbc/wrap-rsa-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-cbc/wrap-rsa-non-extractable-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-cbc/wrong-key-class-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-ctr/cloneKey-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-ctr/failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-ctr/generateKey-failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-export-key-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-gcm/cloneKey-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-gcm/encrypt-decrypt-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-gcm/failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-generateKey-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-key-algorithm-mismatch-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-key-usages-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-kw/cloneKey-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-kw/generateKey-failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-kw/key-manipulation-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-kw/wrap-unwrap-aes-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/aes-kw/wrapKey-unwrapKey-raw-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/algorithm-identifier-as-string-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/cryptokey-interface-is-visible-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/derive-hkdf-keys-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/deserialize-legacy-aes-key-empty-usages-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/digest-arraybuffer-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/digest-failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/ec-export-private-key-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/ec-export-public-key-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/ecdh/cloneKey-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/ecdh/deriveBits-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/ecdh/deriveBits-failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/ecdh/deriveKey-aes-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/ecdh/deriveKey-failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/ecdh/deriveKey-hmac-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/ecdh/generate-key-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/ecdh/import-export-raw-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/ecdh/import-jwk-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/ecdsa/cloneKey-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/ecdsa/generate-key-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/ecdsa/generateKey-failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/ecdsa/import-jwk-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/ecdsa/sign-verify-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/encrypt-neutered-data-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/exportKey-badParameters-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/exportKey-unextractable-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/hkdf/cloneKey-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/hkdf/deriveBits-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/hkdf/deriveBits-failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/hkdf/deriveBits-rfc5869-test-vectors-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/hkdf/deriveKey-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/hkdf/exportKey-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/hkdf/importKey-failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/hkdf/unwrapKey-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/hmac/cloneKey-empty-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/hmac/cloneKey-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/hmac/export-key-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/hmac/generate-key-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/hmac/generateKey-failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/hmac/import-jwk-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/hmac/legacy-empty-key-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/hmac/sign-verify-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/import-aes-key-bad-length-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/import-jwk-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/importKey-badParameters-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/importKey-normalize-usages-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/jwk-export-use-values-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/jwk-import-use-values-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/modify-encrypt-data-during-normalization-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/modify-importKey-data-during-normalization-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/modify-verify-data-during-normalization-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/neuter-algorithm-data-during-encrypt-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/neuter-encrypt-data-during-normalization-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/pbkdf2/cloneKey-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/pbkdf2/deriveBits-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/pbkdf2/deriveBits-failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/pbkdf2/deriveBits-rfc6070-test-vectors-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/pbkdf2/deriveKey-aes-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/pbkdf2/deriveKey-failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/pbkdf2/importKey-failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/rsa-export-key-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/rsa-export-private-key-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/rsa-importKey-badUsages-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/rsa-indexeddb-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/rsa-oaep/encrypt-failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/rsa-oaep/generate-non-extractable-key-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/rsa-oaep/generateKey-failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/rsa-oaep/key-manipulation-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/rsa-oaep/plaintext-length-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/rsa-oaep/wrap-unwrap-aes-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/rsa-pss/verify-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5/cloneKey-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5/generate-key-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5/generate-key-with-leading-zeroes-in-exponent-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5/generateKey-failures-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5/import-jwk-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5/import-jwk-small-key-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5/sign-verify-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/sha/digest-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/sign-verify-badParameters-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/unwrapKey-badParameters-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/unwrapKey-lacks-usage-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/worker-subtle-crypto-concurrent-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/wrapKey-badParameters-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/wrapKey-lacks-usage-expected.txt
    • third_party/WebKit/LayoutTests/crypto/subtle/wrapKey-unextractable-expected.txt
    • third_party/WebKit/LayoutTests/crypto/worker-random-values-concurrent-expected.txt
    • third_party/WebKit/LayoutTests/crypto/worker-random-values-expected.txt
    • third_party/WebKit/LayoutTests/crypto/worker-random-values-limits-expected.txt
    • third_party/WebKit/LayoutTests/crypto/worker-random-values-types-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/aria-disabled-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/canvas-accessibilitynodeobject-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/canvas-fallback-content-2-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/canvas-fallback-content-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/color-well-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/css-generated-content-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/css-styles-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/element-role-mapping-focusable-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/image-link-inline-cont-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/image-map1-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/img-fallsback-to-title-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/input-type-range-aria-value-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/radio-button-title-label-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/removed-continuation-element-causes-crash-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/scroll-div-horiz-sends-notification-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/table-one-cell-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/textarea-caret-position-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/textarea-selection-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/whitespace-in-name-calc-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/animations/lazy-detached-animation-stop-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/bindings/blink-in-js-asan-crash-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/geometry/composited-in-columns-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/geometry/foreground-layer-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/gestures/gesture-tapHighlight-pixel-rotated-link-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/iframes/layout-on-compositing-change-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/layer-creation/fixed-position-nonscrollable-iframes-in-scrollable-page-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/layer-creation/rotate3d-overlap-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/overflow/iframe-scroll-children-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/squashing/squash-transform-repainting-child-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/squashing/squash-transform-repainting-transformed-child-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/compositing/webgl/webgl-copy-image-expected.txt
    • third_party/WebKit/LayoutTests/platform/linux/accessibility/css-generated-content-expected.txt
    • third_party/WebKit/LayoutTests/platform/linux/accessibility/inline-text-bounds-for-range-expected.txt
    • third_party/WebKit/LayoutTests/platform/linux/accessibility/inline-text-word-boundaries-expected.txt
    • third_party/WebKit/LayoutTests/platform/mac/accessibility/inline-text-bounds-for-range-expected.txt
    • third_party/WebKit/LayoutTests/platform/mac/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt
    • third_party/WebKit/LayoutTests/platform/mac/compositing/geometry/composited-in-columns-expected.txt
    • third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/textarea-scroll-touch-expected.txt
    • third_party/WebKit/LayoutTests/platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt
    • third_party/WebKit/LayoutTests/platform/win/accessibility/css-generated-content-expected.txt
    • third_party/WebKit/LayoutTests/platform/win/accessibility/inline-text-bounds-for-range-expected.txt
    • third_party/WebKit/LayoutTests/platform/win/accessibility/inline-text-word-boundaries-expected.txt
    • third_party/WebKit/LayoutTests/platform/win/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt
    • third_party/WebKit/LayoutTests/platform/win/compositing/geometry/composited-in-columns-expected.txt
    • third_party/WebKit/LayoutTests/platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt
    • third_party/WebKit/LayoutTests/platform/win/compositing/overflow/textarea-scroll-touch-expected.txt
    • third_party/WebKit/LayoutTests/platform/win/compositing/visibility/visibility-image-layers-dynamic-expected.txt
    • third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/do-not-crash-use-after-free-update-widget-positions-expected.txt
  38. Remove Mojo API for SignedHTTPExchange LayoutTests

    Changed by Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 01:06:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 245821d0c52eb90549eff1e4e2ba4a4bfb619a1b

    Comments

    Remove Mojo API for SignedHTTPExchange LayoutTests
    
    This removes internal testing API that overrides SignedExchange
    signature verification time, which is no longer needed since
    --ignore-certificate-errors-spki-list now ignores signature
    timestamp errors.
    
    This is mostly a revert of https://crrev.com/c/991833.
    
    Bug: 803774
    Change-Id: I5b2f77062d897f6c025566ea98fe740735ae8172
    Reviewed-on: https://chromium-review.googlesource.com/c/1270457
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599051}

    Changed files

    • content/browser/BUILD.gn
    • content/browser/storage_partition_impl.cc
    • content/browser/storage_partition_impl.h
    • content/browser/web_package/web_package_context_impl.cc
    • content/browser/web_package/web_package_context_impl.h
    • content/public/browser/BUILD.gn
    • content/public/browser/storage_partition.h
    • content/public/browser/web_package_context.h
    • content/public/test/test_storage_partition.cc
    • content/public/test/test_storage_partition.h
    • content/shell/browser/content_shell_browser_manifest_overlay.json
    • content/shell/browser/layout_test/blink_test_controller.cc
    • content/shell/browser/layout_test/layout_test_content_browser_client.cc
    • third_party/blink/public/mojom/BUILD.gn
    • third_party/blink/public/mojom/web_package/OWNERS
    • third_party/blink/public/mojom/web_package/README.md
    • third_party/blink/public/mojom/web_package/web_package_internals.mojom
  39. Revert "macOS V2 Sandbox: Report correct sandbox profile for nacl-loader."

    Changed by Thomas Anderson - thomasandersonohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 01:04:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fdaedf46b82802f3117e5a00ba39f4b67b9259ee

    Comments

    Revert "macOS V2 Sandbox: Report correct sandbox profile for nacl-loader."
    
    This reverts commit 6d83f4b9d0930defb0b583bc7dcce4b63971fcc8.
    
    Reason for revert: Suspected cause of browser_test failures on "Mac10.13 Tests (dbg)":
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/5697
    
    Original change's description:
    > macOS V2 Sandbox: Report correct sandbox profile for nacl-loader.
    > 
    > The nacl loader process, used only on macOS, currently tries to load an
    > invalid profile type under the V2 sandbox. This loads the correct type.
    > 
    > Bug: 892554
    > Change-Id: I7b2733db426e3c91181b1f375d791d2918ac6763
    > Reviewed-on: https://chromium-review.googlesource.com/c/1268671
    > Reviewed-by: Robert Sesek <rsesek@chromium.org>
    > Reviewed-by: Derek Schuff <dschuff@chromium.org>
    > Reviewed-by: Greg Kerr <kerrnel@chromium.org>
    > Reviewed-by: Tom Sepez <tsepez@chromium.org>
    > Commit-Queue: Greg Kerr <kerrnel@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#598380}
    
    TBR=dschuff@chromium.org,tsepez@chromium.org,kerrnel@chromium.org,rsesek@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 892554
    Change-Id: Ib5a7767695fce263830cf9329da0cda99aaab9b7
    Reviewed-on: https://chromium-review.googlesource.com/c/1278162
    Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599050}

    Changed files

    • components/nacl/loader/DEPS
    • components/nacl/loader/nacl_main_platform_delegate_mac.mm
    • services/service_manager/sandbox/sandbox_type.cc
    • services/service_manager/sandbox/switches.cc
    • services/service_manager/sandbox/switches.h
  40. Use flexible surface compatibility extension for default pbuffer surface

    Changed by Sunny Sachanandani - sunnypsohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 01:03:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 41072825386f9076b22fa5bee68b2fcdaa6950e6

    Comments

    Use flexible surface compatibility extension for default pbuffer surface
    
    EGL_ANGLE_flexible_surface_compatibility allows contexts to be able to
    bind to surfaces with different formats e.g. with or without alpha.
    
    With DirectComposition, we have a real surface inside a Begin/EndDraw
    pair, and use a default 1x1 pbuffer surface outside of that.  That
    surface must be created with flexible surface compatibility so that we
    can MakeCurrent outside of Begin/EndDraw.
    
    Noticed this while working on a related change.  There were some crashes
    in MakeCurrent in SetSwapInterval which was fixed in a different way by
    removing SetSwapInterval, but it's possible the root cause was this.
    
    Bug: 800950
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I05aa1a61bfa0d1445778bbd9599d3f630dddbe8c
    Reviewed-on: https://chromium-review.googlesource.com/c/1237535
    Reviewed-by: Zhenyao Mo <zmo@chromium.org>
    Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599049}

    Changed files

    • gpu/ipc/service/direct_composition_child_surface_win.cc
    • gpu/ipc/service/direct_composition_surface_win.cc
  41. Remove RWH null-checks for input_router_.

    Changed by Albert J. Wong - ajwongohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 01:02:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b49966db7f4fad6ec98c39965b74a9cc1aeb11a3

    Comments

    Remove RWH null-checks for input_router_.
    
    The |input_router_| field is initialized early in the constructor and
    only ever replaced with a new instance so null-ness is not possible.
    
    Bug: 545684
    Change-Id: Ib6ecbffd20cebfd5f6c5f23557494681b11435f2
    Reviewed-on: https://chromium-review.googlesource.com/c/1277585
    Commit-Queue: Albert J. Wong <ajwong@chromium.org>
    Reviewed-by: James MacLean <wjmaclean@chromium.org>
    Reviewed-by: danakj <danakj@chromium.org>
    Reviewed-by: Nasko Oskov <nasko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599048}

    Changed files

    • content/browser/renderer_host/render_widget_host_impl.cc
  42. Remove an MSVC-required macro.

    Changed by Avi Drissman - aviohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 01:01:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b00a9e7e3d434f208e89fb2734a9c78634c2faef

    Comments

    Remove an MSVC-required macro.
    
    BUG=none
    
    Change-Id: I118976f80f3c605f7b2c5cb05e8b60278fded19d
    Reviewed-on: https://chromium-review.googlesource.com/c/1272495
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599047}

    Changed files

    • base/component_export.h
    • base/macros.h
    • base/metrics/histogram_macros.h
    • base/metrics/histogram_macros_local.h
  43. Add InputEventShim for intercepting RWH messages.

    Changed by Albert J. Wong - ajwongohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 00:57:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eb28e7e34aba87013ba804e64faa214cce5caf94

    Comments

    Add InputEventShim for intercepting RWH messages.
    
    As part of the effort to stop RenderWidgetHost from forwarding
    it's messages in OnMessageReceived() on to other classes (which
    lead to spooky message-action at a distance), this introduces
    a new shim class InputEventShim that allows BrowserPlugin to
    override various input event related messages in RenderWidgetHost.
    
    This also simplifies some of the message routing in InputRouter
    allowing it to NOT be a IPC::Listner, which again, makes inter-class
    relations more explicit.
    
    There should be no functionality change.
    
    Bug: 419087
    Change-Id: I75f2f4cc1d1b6d36373c75dc7b4ae7bd7af1afe4
    Reviewed-on: https://chromium-review.googlesource.com/c/1274606
    Reviewed-by: Albert J. Wong <ajwong@chromium.org>
    Reviewed-by: James MacLean <wjmaclean@chromium.org>
    Reviewed-by: Nasko Oskov <nasko@chromium.org>
    Reviewed-by: danakj <danakj@chromium.org>
    Commit-Queue: Albert J. Wong <ajwong@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599046}

    Changed files

    • content/browser/BUILD.gn
    • content/browser/browser_plugin/browser_plugin_guest.cc
    • content/browser/browser_plugin/browser_plugin_guest.h
    • content/browser/renderer_host/input/input_router.h
    • content/browser/renderer_host/input/input_router_client.h
    • content/browser/renderer_host/input/input_router_impl.cc
    • content/browser/renderer_host/input/input_router_impl.h
    • content/browser/renderer_host/input/input_router_impl_unittest.cc
    • content/browser/renderer_host/input/mock_input_router_client.cc
    • content/browser/renderer_host/input/mock_input_router_client.h
    • content/browser/renderer_host/input_event_shim.h
    • content/browser/renderer_host/render_widget_host_delegate.cc
    • content/browser/renderer_host/render_widget_host_delegate.h
    • content/browser/renderer_host/render_widget_host_impl.cc
    • content/browser/renderer_host/render_widget_host_impl.h
    • content/browser/renderer_host/render_widget_host_unittest.cc
    • content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
    • content/browser/web_contents/web_contents_impl.cc
    • content/browser/web_contents/web_contents_impl.h
    • content/common/view_messages.h
    • content/common/widget_messages.h
    • content/renderer/render_widget.cc
  44. Roll src/third_party/depot_tools 47faa068e8ff..066e11079d98 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 00:57:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 51c5b53d9a2cdb8f50902902e514fd9817452fcc

    Comments

    Roll src/third_party/depot_tools 47faa068e8ff..066e11079d98 (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/47faa068e8ff..066e11079d98
    
    
    git log 47faa068e8ff..066e11079d98 --date=short --no-merges --format='%ad %ae %s'
    2018-10-11 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@066e11079d98
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=agable@chromium.org
    
    Change-Id: Ib36b95d43c0bf2ffa7161c1ce49349c6f59b3873
    Reviewed-on: https://chromium-review.googlesource.com/c/1277763
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599045}

    Changed files

    • DEPS
  45. Enable SystemUse24HourClockPolicyTest under SingleProcessMash

    Changed by James Cook - jamescookohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 00:54:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 173691dfcd0360f53729c61a7c7c1e130dd41280

    Comments

    Enable SystemUse24HourClockPolicyTest under SingleProcessMash
    
    It passes for me locally. I don't see anything in the test or the
    underlying code that depends on the mash mode. I'm not sure why it
    was being skipped.
    
    Bug: none
    Change-Id: I300bd010ffa68c3cb5c6efec2df316752971084c
    Reviewed-on: https://chromium-review.googlesource.com/c/1277954
    Reviewed-by: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599044}

    Changed files

    • testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
  46. Roll src/third_party/webrtc fb226af64dad..1cd39fa9ea0c (14 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 00:53:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fc36ab03f1e4ca2ca8d1565109b32b51f3dda7bf

    Comments

    Roll src/third_party/webrtc fb226af64dad..1cd39fa9ea0c (14 commits)
    
    https://webrtc.googlesource.com/src.git/+log/fb226af64dad..1cd39fa9ea0c
    
    
    git log fb226af64dad..1cd39fa9ea0c --date=short --no-merges --format='%ad %ae %s'
    2018-10-11 jonaso@webrtc.org make CreateOffer/CreateAnswer use ice credentials of pooled sessions.
    2018-10-11 yvesg@webrtc.org Headers shouldn't include themselves.
    2018-10-11 benwright@webrtc.org Move CryptoOptions to api/crypto from rtc_base/sslstreamadapter.h
    2018-10-11 srte@webrtc.org Adds handling of untracked data to congestion controller.
    2018-10-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f34485ffde..9d052f4b6f (598711:598839)
    2018-10-11 srte@webrtc.org Removes socket addresses from PacketInfo struct.
    2018-10-11 srte@webrtc.org Adds tracking of allocated but unacknowledged bitrate.
    2018-10-11 nisse@webrtc.org Delete unused utf8 conversion utilities
    2018-10-11 srte@webrtc.org Adds IP overhead info to PacketInfo.
    2018-10-11 devicentepena@webrtc.org AEC3: Enabling by default the use of the stationarity properties at render at init
    2018-10-11 terelius@webrtc.org RtcEventLogSource no longer uses deprecated parsing functions.
    2018-10-11 yvesg@webrtc.org Fix race conditions for ReofferDoesNotCallOnTrack test.
    2018-10-11 gustaf@webrtc.org AEC3: Kill kill-switches
    2018-10-11 srte@webrtc.org Adds default values for feedback/allocation indicators.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@1cd39fa9ea0c
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:None,chromium:894439
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Idd9b3d88e5b4ce791774fabce00dfddd33a9ad21
    Reviewed-on: https://chromium-review.googlesource.com/c/1277758
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599043}

    Changed files

    • DEPS
  47. Reland: Network Service: Migrate chromeos::assistant::NetworkProviderImpl to NetworkConnectionTracker

    Changed by Jun Cai - juncaiohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 00:51:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5128829431a529499fe3b9de8ca4345a080da84

    Comments

    Reland: Network Service: Migrate chromeos::assistant::NetworkProviderImpl to NetworkConnectionTracker
    
    The original CL is:
    https://chromium-review.googlesource.com/c/chromium/src/+/1270950
    and the Initial upload is the same as the original CL.
    
    The reland CL fixes compile error on chromeos.
    
    TBR=jam@chromium.org, stevenjb@chromium.org, xiaohuic@chromium.org, rmcelrath@chromium.org
    
    Bug: 887040
    Change-Id: Ic0cf9d07f7c7d6c5c59694c1414bc38b83a36456
    Reviewed-on: https://chromium-review.googlesource.com/c/1277647
    Reviewed-by: Jun Cai <juncai@chromium.org>
    Reviewed-by: Joel Hockey <joelhockey@chromium.org>
    Commit-Queue: Jun Cai <juncai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599042}

    Changed files

    • chrome/browser/profiles/profile_impl.cc
    • chromeos/services/assistant/BUILD.gn
    • chromeos/services/assistant/DEPS
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/platform/network_provider_impl.cc
    • chromeos/services/assistant/platform/network_provider_impl.h
    • chromeos/services/assistant/platform_api_impl.cc
    • chromeos/services/assistant/platform_api_impl.h
    • chromeos/services/assistant/service.cc
    • chromeos/services/assistant/service.h
    • chromeos/services/assistant/service_unittest.cc
  48. [ios] Use FaviconLoader in Bookmarks

    Changed by Chris Lu - thegreenfrogohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 00:49:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a88c577abd9b7bf34e3970a1952f3fba2fa84d30

    Comments

    [ios] Use FaviconLoader in Bookmarks
    
    - Deletes favicon logic in bookmarks and just calls FaviconForUrl to retrieve favicon.
    - Adds TouchIconFromGoogleServer() for all Google Server requests made by FaviconLoader to ensure they stay in the database longer.
    - Removing LargeIconService request cancel logic, since it was deemed an unnecessary complexity (https://docs.google.com/document/d/1-c4YEmRta2qcg2HC9VzQZoeI9CBG3yccfN3GBITU910/edit)
    
    Change-Id: Ib44d53e4d50ac27c2871bb7916370fc9ccfe6380
    Reviewed-on: https://chromium-review.googlesource.com/c/1262414
    Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
    Reviewed-by: edchin <edchin@chromium.org>
    Reviewed-by: Sergio Collazos <sczs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599041}

    Changed files

    • ios/chrome/browser/favicon/favicon_loader.mm
    • ios/chrome/browser/ui/bookmarks/BUILD.gn
    • ios/chrome/browser/ui/bookmarks/bookmark_home_consumer.h
    • ios/chrome/browser/ui/bookmarks/bookmark_home_mediator.mm
    • ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
  49. [CrOS MultiDevice] Set default Settings subpage title

    Changed by Jordy Greenblatt - jordynassohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 00:39:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 57f721cbce7a1b8e729520dc1db7ff899d2f3c73

    Comments

    [CrOS MultiDevice] Set default Settings subpage title
    
    In principle a user should never be in the subpage without a host set
    so we didn't bother to put in a default for the case of no set host
    when we made the page in the first place. However, this seems to be
    causing a11y test failures, so we are using the label text for the
    settings main page which is exactly what we want (i.e. the host name)
    when the host is set. In other words, this should look the same to the
    user.
    
    Change-Id: I03ddf0cd298d9ca8eb832e14cff354c419d5acb6
    Reviewed-on: https://chromium-review.googlesource.com/c/1277680
    Reviewed-by: Jeremy Klein <jlklein@chromium.org>
    Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
    Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599040}

    Changed files

    • chrome/browser/resources/settings/multidevice_page/multidevice_page.html
  50. [iOS] Pick new touch location for context menu test

    Changed by Kurt Horimoto - kkhorimotoohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 00:38:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 72a47feacbf4554331511037d8570bb1f5dad9cc

    Comments

    [iOS] Pick new touch location for context menu test
    
    The WKWebView frame relative to the image frame has been changed; so
    update the touch location.
    
    Bug: 894597
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Ifdf34f7596352a9414c562fee09e4b2b561702b9
    Reviewed-on: https://chromium-review.googlesource.com/c/1277831
    Reviewed-by: Peter Lee <pkl@chromium.org>
    Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
    Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599039}

    Changed files

    • ios/chrome/browser/context_menu/BUILD.gn
    • ios/chrome/browser/context_menu/context_menu_egtest.mm
  51. Properly filter out transient Crostini windows from the shelf

    Changed by Timothy Loh - timlohohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 00:36:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bf10ece3f79ead0ff1d488ae3b61fbc559e6f3c8

    Comments

    Properly filter out transient Crostini windows from the shelf
    
    Transient Crostini windows are supposed to be filtered from the shelf,
    but we are checking for a transient parent on window Init, which is
    before it actually gets set. This was causing a UAF on profile switching
    as MultiUserWindowManagerChromeOS::SetWindowOwner() is not supposed to
    be called with transient windows.
    
    Bug: 845843
    Change-Id: Iec7b48cb03fff22775c31ce08c398ba750836463
    Reviewed-on: https://chromium-review.googlesource.com/c/1266475
    Commit-Queue: Timothy Loh <timloh@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599038}

    Changed files

    • chrome/browser/ui/ash/launcher/crostini_app_window_shelf_controller.cc
  52. Mark touch released events handled by default on Windows.

    Changed by Bret Sepulveda - bsepohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 00:36:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c6058c3e1f9a4118c88bf487e6c5a3fe2f562269

    Comments

    Mark touch released events handled by default on Windows.
    
    When a touch event is not handled, WindowEventDispatcher will generate
    gesture events from it. However, when those gesture events are marked as
    handled that handling doesn't propagate back to the original touch
    event.
    
    For bug 852241, the hamburger menu only handles gesture events. On
    Windows, selecting an option with a touch would cause the hamburger menu
    to close, but because the touch event wasn't marked as handled Windows
    would pass it along to the underlying window, causing it to gain focus.
    Most of the time it would be gaining focus anyway (since the hamburger
    menu just closed) so this isn't noticeable, but the Cast dialog is a
    newly-added surface that closes if it loses focus. In this case, it
    seems to not appear at all.
    
    Similarly for bug 866421, when the guest window becomes restored it
    reveals the window underneath and then Windows passes the event along,
    giving it focus.
    
    This patch marks all touch released as handled by default, which
    prevents Windows from ever propagating them. These events generate the
    tap gestures that cause the state change in the hamburger menu and
    window size in the above bugs.
    
    Bug: 852241, 866421
    Change-Id: I10a67d56fdc46d5b91282e0f395c895339f71951
    Reviewed-on: https://chromium-review.googlesource.com/c/1260507
    Commit-Queue: Bret Sepulveda <bsep@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599037}

    Changed files

    • ui/views/win/hwnd_message_handler.cc
  53. Roll src-internal 865321239f56..55ac0aa2f68f (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 00:31:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ea750a2dbc2b5fee0d62e1927b3513d9466e3ed

    Comments

    Roll src-internal 865321239f56..55ac0aa2f68f (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/865321239f56..55ac0aa2f68f
    
    
    Created with:
      gclient setdep -r src-internal@55ac0aa2f68f
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I8570cdea9745766fdfb3c8f741685c81d8850ad4
    Reviewed-on: https://chromium-review.googlesource.com/c/1277761
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599036}

    Changed files

    • DEPS
  54. chromeos: Fix autotestPrivate.getHistograms for other procs.

    Changed by Daniel Erat - deratohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 00:31:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3d21c42593b6f372d43e65856beb558153e96f09

    Comments

    chromeos: Fix autotestPrivate.getHistograms for other procs.
    
    Make the chrome.autotestPrivate API's getHistograms function
    call content::FetchHistogramsAsynchronously() and
    base::StatisticsRecorder::ImportProvidedHistograms() to
    fetch and incorporate histogram data from other processes,
    similar to what chrome://histograms does.
    
    Without this, the function (which is called over the Chrome
    DevTools Protocol by Chrome OS integration tests) serves
    stale data. For example,
    Media.GpuVideoDecoderInitializeStatus samples are missing
    since that histogram is recorded from renderer processes.
    
    Bug: 893937
    Change-Id: Id6415f1a32b41ad7ddeb251216f09b2314eb5980
    Reviewed-on: https://chromium-review.googlesource.com/c/1274892
    Commit-Queue: Dan Erat <derat@chromium.org>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599035}

    Changed files

    • chrome/browser/chromeos/extensions/autotest_private/autotest_private_api.cc
    • chrome/browser/chromeos/extensions/autotest_private/autotest_private_api.h
  55. Fix perf regression in LayoutBoxModelObject::RelativePositionOffset()

    Changed by Manuel Rego Casasnovas - regoohnoyoudont@igalia.com
    Changed at Friday, 12-Oct-18 00:23:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4226ddf99103e493d7afb23a4c7902ee496108b6

    Comments

    Fix perf regression in LayoutBoxModelObject::RelativePositionOffset()
    
    In r597543 we introduced a performance regression
    due to the changes in LayoutBoxModelObject::RelativePositionOffset().
    One of the main differences is that AvailableHeight|Width()
    was called always as part of the method,
    while that was not the case before.
    
    This patches moves the calls to AvailableHeight|Width()
    to the moment where they are needed, trying to minimize
    the impact in performance and come back to previous numbers.
    
    No new tests as it's already covered by existent ones.
    
    BUG=893884,835607
    
    Change-Id: Id8aaba4736a821af9f401492206840c12a2be0e6
    Reviewed-on: https://chromium-review.googlesource.com/c/1273117
    Commit-Queue: Manuel Rego <rego@igalia.com>
    Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#599034}

    Changed files

    • third_party/blink/renderer/core/layout/layout_box_model_object.cc
  56. Roll src/third_party/angle 956ab4d9fab3..f2ed299569c0 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 00:20:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aefd059dae13f857dd4b5e5bc0cdf5a99595daca

    Comments

    Roll src/third_party/angle 956ab4d9fab3..f2ed299569c0 (1 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/956ab4d9fab3..f2ed299569c0
    
    
    git log 956ab4d9fab3..f2ed299569c0 --date=short --no-merges --format='%ad %ae %s'
    2018-10-11 oetuaho@nvidia.com Add support for EXT_texture_compression_bptc
    
    
    Created with:
      gclient setdep -r src/third_party/angle@f2ed299569c0
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=fjhenigman@chromium.org
    
    Change-Id: Iba0b0ee4efdbd58c43377f5d51954311efa4f5b5
    Reviewed-on: https://chromium-review.googlesource.com/c/1277760
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599033}

    Changed files

    • DEPS
  57. [layoutng] Inline NGFragment functions

    Changed by Christian Biesinger - cbiesingerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 00:18:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cea42e7d3d4e5f8d923fd193897126776fea3c90

    Comments

    [layoutng] Inline NGFragment functions
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Ic83a2e5e50d2c992b394098a78add327d973ce34
    Reviewed-on: https://chromium-review.googlesource.com/c/1276847
    Commit-Queue: Emil A Eklund <eae@chromium.org>
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599032}

    Changed files

    • third_party/blink/renderer/core/layout/BUILD.gn
    • third_party/blink/renderer/core/layout/ng/ng_box_fragment.cc
    • third_party/blink/renderer/core/layout/ng/ng_box_fragment.h
    • third_party/blink/renderer/core/layout/ng/ng_fragment.cc
    • third_party/blink/renderer/core/layout/ng/ng_fragment.h
  58. Replace sparse histogram with a linear one. This avoids extra lock on reporting.

    Changed by Dmitry Titov - dimichohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 00:16:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c2d4f3e39d0af7a283b748040cceb089de4fb172

    Comments

    Replace sparse histogram with a linear one. This avoids extra lock on reporting.
    
    Bug: 867488
    Change-Id: If8b99bc2e5c4636ed42d5e68d9e08dc099e8bb27
    Reviewed-on: https://chromium-review.googlesource.com/c/1277818
    Reviewed-by: Peter Williamson <petewil@chromium.org>
    Commit-Queue: Dmitry Titov <dimich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599031}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryCardView.java
  59. Increment the track ID to ensure unique IDs.

    Changed by Ted Meyer - tmathmeyerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 00:15:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 44d5ef3148c5461893c5b77012a9046f37b69c20

    Comments

    Increment the track ID to ensure unique IDs.
    
    In the case of a corrupt media files where tracks are not unique, we
    need to ensure that map entries are. It isn't sufficient to let ffmpeg
    handle this, since it will sometimes report duplicates:
    https://clusterfuzz.com/v2/testcase-detail/6184666533724160?noredirect=1
    where both the audio and video track have a default track_id of 1.
    
    Bug: 877847
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I7e2bc16b39c5d23e9310463c54c9f3cba8bdbfa5
    Reviewed-on: https://chromium-review.googlesource.com/c/1269446
    Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
    Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599030}

    Changed files

    • media/filters/ffmpeg_demuxer.cc
  60. Handle needs permission update engine status in oobe

    Changed by Toni Barzic - tbarzicohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 00:13:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c88e218fbf088c003309254ebba10c5d725e9a88

    Comments

    Handle needs permission update engine status in oobe
    
    Updates OOBE update screen to handle
    UPDATE_STATUS_NEED_PERMISSION_TO_UPDATE update status. This status is
    reported update engine when a new version is found while attempting
    an update over cellular connection. To proceed with the update, a user
    permission is required.
    
    This updates the OOBE update screen to show a message informing the
    user that an update is required, and that updating over cellular might
    cause coverage charges. If the user clicks back, the OOBE goes back to
    the network selection screen. If the user clicks next, the update
    engine is informed of the user permission, and update is attempted
    again.
    
    BUG=889948
    
    Change-Id: Icff7a77043677f2fa87dac916e0a2030ade5f728
    Reviewed-on: https://chromium-review.googlesource.com/c/1272808
    Commit-Queue: Toni Baržić <tbarzic@chromium.org>
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599029}

    Changed files

    • chrome/app/chromeos_strings.grdp
    • chrome/app/chromeos_strings_grdp/IDS_UPDATE_OVER_CELLULAR_PROMPT_MESSAGE.png.sha1
    • chrome/app/chromeos_strings_grdp/IDS_UPDATE_OVER_CELLULAR_PROMPT_TITLE.png.sha1
    • chrome/browser/chromeos/login/screens/screen_exit_code.h
    • chrome/browser/chromeos/login/screens/update_screen.cc
    • chrome/browser/chromeos/login/screens/update_screen.h
    • chrome/browser/chromeos/login/wizard_controller.cc
    • chrome/browser/chromeos/login/wizard_controller.h
    • chrome/browser/chromeos/login/wizard_controller_browsertest.cc
    • chrome/browser/resources/chromeos/login/oobe_screen_update.js
    • chrome/browser/resources/chromeos/login/oobe_update.html
    • chrome/browser/resources/chromeos/login/oobe_update.js
    • chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc
  61. Switch CanAccessDataForOrigin to use DetermineProcessLockURL.

    Changed by Alex Moshchuk - alexmosohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 00:09:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 68e20c09efe0c5c16c19c10d260d81c9d06ae802

    Comments

    Switch CanAccessDataForOrigin to use DetermineProcessLockURL.
    
    CanAccessDataForOrigin currently calls GetSiteForURL() to determine
    what should be checked against the process's origin lock.  This isn't
    entirely accurate, as GetSiteForURL() defaults to using effective
    URLs, which we don't want to use for comparing origin locks.
    Fortunately, we also pass in null for browser_context, which
    effectively avoids effective URL resolution:
    ChromeContentBrowserClient::GetEffectiveURL returns back the original
    URL in that case.  This CL change this call to use
    DetermineProcessLockForURL() instead, which is more correct.
    
    This CL also removes a stale comment about hosted apps not being able
    to set cookies.  That is no longer true, since we now lock hosted apps
    to their underlying web origin, which doesn't get in the way of IO
    thread enforcements.
    
    Bug: 160576, 718516, 794315
    Change-Id: I092e9bf89b3a9fc5807824bbe51d1de6589ddae3
    Reviewed-on: https://chromium-review.googlesource.com/c/1276560
    Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599028}

    Changed files

    • content/browser/child_process_security_policy_impl.cc
  62. Optimize and inline EnclosingLayoutRect

    Changed by Emil A Eklund - eaeohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 00:08:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6da50028fa26708eb11a01422d225e5f790693fc

    Comments

    Optimize and inline EnclosingLayoutRect
    
    The FloatRect version of EnclosingLayoutRect shows up rather prominently
    in profiling data for both layout and LayoutNG, particularly in the font
    metrics and text shaping code. This change reduces the time spent in the
    method by half by avoiding overhead and allowing it to be inlined.
    
    Change-Id: Ica28d6a41edf476619f581c2ff2d9471d13f7c12
    Reviewed-on: https://chromium-review.googlesource.com/c/1277597
    Reviewed-by: Stefan Zager <szager@chromium.org>
    Commit-Queue: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599027}

    Changed files

    • third_party/blink/renderer/platform/geometry/layout_rect.cc
    • third_party/blink/renderer/platform/geometry/layout_rect.h
  63. Files app: Select My files when there are no volumes

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 00:07:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5cd8c123e452c0b76fbbcaf53e82d86ca7d54930

    Comments

    Files app: Select My files when there are no volumes
    
    Make Files app select "My files" when there are no available volumes,
    this to allow Files app to behave properly when volumes subsequently
    become available.
    
    Change DirectoryModel.onVolumeInfoListUpdated_ method to check for
    non-null |displayRoot| before trying to change to |displayRoot|. This
    fixes the error "Cannot read property 'getParent' of null" when Drive
    volume becomes available before Downloads volume, which is the default
    volume/root.
    
    Change FakeDriveFs to unbind the two mojo bindings if they're bound, so
    DriveFsTestVolume can re-mount itself.
    
    Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*"
    Bug: 893161, 884967
    Change-Id: Ic813b25261530495c11c9f641a92f6e07f883702
    Reviewed-on: https://chromium-review.googlesource.com/c/1272418
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Reviewed-by: Sam McNally <sammc@chromium.org>
    Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599026}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
    • chromeos/components/drivefs/fake_drivefs.cc
    • ui/file_manager/file_manager/foreground/js/directory_model.js
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/integration_tests/file_manager/file_display.js
  64. DNR: Prepend json parse errors for ruleset file with the file's name.

    Changed by Karan Bhatia - karandeepbohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 00:06:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 07535c1a3fa02420e25c51fe9ce52d926da19bc6

    Comments

    DNR: Prepend json parse errors for ruleset file with the file's name.
    
    This CL improves the json parse error shown to the user for the declarative net
    request ruleset file by prepending it with the ruleset filename.
    
    BUG=None
    
    Change-Id: I3cc907b6223745dd94ae71e78216105d2317ae43
    Reviewed-on: https://chromium-review.googlesource.com/c/1275137
    Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
    Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599025}

    Changed files

    • chrome/browser/extensions/api/declarative_net_request/rule_indexing_unittest.cc
    • extensions/browser/api/declarative_net_request/utils.cc
  65. Fix migration requirements checks that broke settings page previously

    Changed by siyua - siyuaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 00:06:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 531265ba09c218fb9b06244e3efbb700d3d5d3b3

    Comments

    Fix migration requirements checks that broke settings page previously
    
    Reason: When the user browses in guest window the sync service and identity
    manager are not available.
    
    Bug: 894377
    Change-Id: I8dd48d39f51d54230e7db8ec34bdbb9abd065530
    Reviewed-on: https://chromium-review.googlesource.com/c/1277814
    Commit-Queue: Siyu An <siyua@chromium.org>
    Reviewed-by: Hector Carmona <hcarmona@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599024}

    Changed files

    • chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc