Home | Search | chromium - Builders
Login

Builder KitKat Phone Tester (dbg) Build 8710 Canonical Ubuntu

Results:

Failure blink_heap_unittests on Android device Nexus 5

Trigger Info:

Projectchromium
Revision3a30357690bfd391e2ddab461c6bd48e2c8a5580
Got Revision3a30357690bfd391e2ddab461c6bd48e2c8a5580

Execution:

Steps and Logfiles:

Show:
  1. ( 332 ms ) setup_build
    running recipe: "chromium"
  2. ( 3 mins 18 secs ) bot_update
    [84GB/295GB used (28%)]
  3. ( 0 ) ensure_goma
  4. ( 1 secs ) swarming.py --version
    0.13
  5. ( 30 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.android.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
  7. ( 16 secs ) clean local files
  8. ( 424 ms ) tree truth steps
  9. ( 2 secs ) build directory
  10. ( 9 mins ) extract build
  11. ( 1 secs ) find isolated tests
  12. ( 0 ) test_pre_run
  13. ( 8 secs ) angle_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:02:24.252270
  14. ( 5 secs ) base_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:03:15.414790
  15. ( 2 secs ) blink_common_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 39s
  16. ( 2 secs ) blink_heap_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 46s
  17. ( 4 secs ) blink_platform_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:56.556620
  18. ( 2 secs ) boringssl_crypto_tests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:02:24.287140
  19. ( 2 secs ) boringssl_ssl_tests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 34s
  20. ( 2 secs ) breakpad_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 25s
  21. ( 2 secs ) cacheinvalidation_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 25s
  22. ( 2 secs ) capture_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:06:52.630040
    Shard duration: 47s
  23. ( 2 secs ) cast_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 36s
  24. ( 4 secs ) cc_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:03:00.851240
  25. ( 2 secs ) components_browsertests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:02:46.680870
  26. ( 2 secs ) perfetto_content_browsertests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:02:38.089590
  27. ( 2 secs ) crypto_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 37s
  28. ( 3 secs ) device_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 47s
  29. ( 2 secs ) display_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 29s
  30. ( 7 secs ) events_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 44s
  31. ( 2 secs ) gcm_unit_tests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:33.295900
  32. ( 5 secs ) gfx_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:02:02.748540
  33. ( 2 secs ) gin_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 29s
  34. ( 2 secs ) gl_tests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 45s
  35. ( 2 secs ) gl_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 46s
  36. ( 2 secs ) google_apis_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 44s
  37. ( 5 secs ) gpu_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:02:31.508670
  38. ( 2 secs ) ipc_tests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 28s
  39. ( 3 secs ) jingle_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:29.058590
  40. ( 2 secs ) latency_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 32s
  41. ( 2 secs ) libjingle_xmpp_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 41s
  42. ( 3 secs ) media_blink_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:29.204450
  43. ( 2 secs ) media_service_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 50s
  44. ( 8 secs ) media_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:03:38.024160
  45. ( 2 secs ) midi_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 31s
  46. ( 2 secs ) mojo_test_apk on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:02:38.790620
  47. ( 3 secs ) mojo_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:13.628510
  48. ( 2 secs ) sandbox_linux_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 22s
  49. ( 3 secs ) services_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:02:21.425070
  50. ( 2 secs ) shell_dialogs_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 28s
  51. ( 2 secs ) skia_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:10.385180
  52. ( 2 secs ) sql_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 31s
  53. ( 2 secs ) storage_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:51.156630
  54. ( 2 secs ) ui_android_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 30s
  55. ( 2 secs ) ui_base_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:21.124180
  56. ( 2 secs ) ui_touch_selection_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 26s
  57. ( 2 secs ) url_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:10.727000
  58. ( 3 secs ) viz_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 59s
  59. ( 3 secs ) vr_common_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:32.464650
  60. ( 2 secs ) vr_pixeltests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:12.922780
  61. ( 2 secs ) wtf_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 37s
  62. ( 2 secs ) chrome_public_test_vr_apk on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:07:23.383930 (shard #0)
    Min shard duration: 0:06:59.229990 (shard #1)
  63. ( 2 secs ) chrome_sync_shell_test_apk on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:05:53.075520 (shard #0)
    Min shard duration: 0:03:54.821440 (shard #1)
  64. ( 14 secs ) webkit_unit_tests on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:10:22.018870 (shard #0)
    Min shard duration: 0:07:58.973780 (shard #1)
  65. ( 3 secs ) content_shell_test_apk on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:07:54.635250 (shard #0)
    Min shard duration: 0:07:01.714150 (shard #1)
  66. ( 8 secs ) content_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:04:54.897780 (shard #0)
    Min shard duration: 0:04:19.543300 (shard #1)
  67. ( 34 secs ) net_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:10:29.058370 (shard #1)
    Min shard duration: 0:08:47.322390 (shard #0)
  68. ( 12 secs ) components_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:06:55.669790 (shard #3)
    Min shard duration: 0:06:30.676500 (shard #1)
  69. ( 11 secs ) content_browsertests on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:10:59.621050 (shard #6)
    Min shard duration: 0:08:40.907770 (shard #8)
  70. ( 11 secs ) surface_sync_content_browsertests on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:11:06.391680 (shard #5)
    Min shard duration: 0:08:56.083870 (shard #8)
  71. ( 4 secs ) unit_tests on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:08:09.971520 (shard #8)
    Min shard duration: 0:03:55.012050 (shard #3)
  72. ( 35 secs ) chrome_public_test_apk on Android device Nexus 5
    Run on OS: 'Android'
    Max shard duration: 0:13:17.287570 (shard #9)
    Min shard duration: 0:08:42.610060 (shard #19)
  73. ( 19 secs ) webkit_layout_tests on Android device Nexus 5 (experimental)
    Run on OS: 'Android'
    Max shard duration: 0:07:13.765440 (shard #6)
    Min shard duration: 0:03:27.877480 (shard #9)
    Total tests: 988
    * Passed: 869 (866 expected, 3 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 117 (117 expected, 0 unexpected)
    * Flaky: 2 (2 expected, 0 unexpected)
     
  74. ( 348 ms ) Tests statistics
     
    Stats
    Total shards: 128
    Total runtime: 10:32:31.675872
     
  75. ( 268 ms ) test_report
  76. ( 4 ms ) Failure reason

Build Properties:

NameValueSource
$build/goma {"jobs": 150} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm96-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1533969609633420, "id": "8938509998567664272", "project": "chromium", "tags": ["builder:KitKat Phone Tester (dbg)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/3a30357690bfd391e2ddab461c6bd48e2c8a5580", "gitiles_ref:refs/heads/master", "parent_buildername:Android arm Builder (dbg)", "parent_buildnumber:36746", "scheduler_invocation_id:9103940060745619104", "scheduler_job_id:chromium/KitKat Phone Tester (dbg)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "KitKat Phone Tester (dbg)" setup_build
buildnumber 8710 setup_build
mastername "chromium.android" setup_build
parent_buildername "Android arm Builder (dbg)" setup_build
parent_got_angle_revision "ea926a362b7748679d72bd56780d29c2ff20fd27" setup_build
parent_got_buildtools_revision "9a90d9aaadeb5e04327ed05775f45132e4b3523f" setup_build
parent_got_nacl_revision "96088f46727b75b2f6a24e1b62e5cc59ddb4612d" setup_build
parent_got_revision "3a30357690bfd391e2ddab461c6bd48e2c8a5580" setup_build
parent_got_revision_cp "refs/heads/master@{#582430}" setup_build
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" setup_build
parent_got_v8_revision "4fe3de13fc5c2592559bb5e49e1a81a6d09a2efd" setup_build
parent_got_v8_revision_cp "refs/heads/7.0.193@{#2}" setup_build
parent_got_webrtc_revision "f5f5373372584fdcbf658a5c11ec28242c7fcd5e" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#24263}" setup_build
parent_mastername "chromium.android" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "3a30357690bfd391e2ddab461c6bd48e2c8a5580" setup_build
got_angle_revision "ea926a362b7748679d72bd56780d29c2ff20fd27" bot_update
got_buildtools_revision "9a90d9aaadeb5e04327ed05775f45132e4b3523f" bot_update
got_nacl_revision "96088f46727b75b2f6a24e1b62e5cc59ddb4612d" bot_update
got_revision "3a30357690bfd391e2ddab461c6bd48e2c8a5580" bot_update
got_revision_cp "refs/heads/master@{#582430}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "4fe3de13fc5c2592559bb5e49e1a81a6d09a2efd" bot_update
got_v8_revision_cp "refs/heads/7.0.193@{#2}" bot_update
got_webrtc_revision "f5f5373372584fdcbf658a5c11ec28242c7fcd5e" bot_update
got_webrtc_revision_cp "refs/heads/master@{#24263}" bot_update
swarm_hashes {"android_webview_unittests": "52fb93c5db1eb7741daf84ce10d8318c3df3114d", "angle_unittests": "b1ff4155d8beab0f58ad881e9163adb8749a6b71", "base_unittests": "aa4c21a32a82191e960812e8f19d37daea1850e4", "blink_common_unittests": "10a0717f22f1d8402e43e9c77555ecc442430f51", "blink_heap_unittests": "62c897c338dd26a311bbb09c122103378a6ca04d", "blink_platform_unittests": "31f0923430dc70ac0ac0635946886b02a614bf5c", "boringssl_crypto_tests": "ceeca725ffba7d858d6579fa3cf7542bdf9b3664", "boringssl_ssl_tests": "c9c8f7ab647f746c8e6e9d510cb91894648e91a1", "breakpad_unittests": "feabf6667f553e47afdc78caf4c502909fd75f13", "cacheinvalidation_unittests": "c1d393b9353a6c4575f896ef2072ae589734440a", "capture_unittests": "7ec9e1e182e6d2e35a5f66a872b5b149b8078fc2", "cast_unittests": "0444cc5d61ccddd8813bdb25ad2353176bc8e260", "cc_unittests": "8dac40e643e614507d184ed7751313f29d67d841", "chrome_public_test_apk": "543eaf200b81a5347c945881de49c8679d9e9e2a", "chrome_public_test_vr_apk": "5f6add12e3c3d41a5bed3d1e6e3ca5b6ad33ce54", "chrome_sync_shell_test_apk": "75a7e8fd232d2387e45cf94b0836bbe5c579c031", "components_browsertests": "793dec1439f3cc8cde06d12b63487b3d1c7fd9fe", "components_unittests": "6c136c920384f166ac188bd276f405a796f3fbae", "content_browsertests": "2011a5fbfe09a4af7b38e4fe38cef7442ef31bc8", "content_shell_test_apk": "3136387715a6f96df0e45955bdba774cbbda5b3a", "content_unittests": "750737d18ce36da3828ee038dae6a4c037057faa", "crypto_unittests": "15224084ae0c913550ac4a1cf7e2fa54218ab9bf", "device_unittests": "490ffaa8a92a048a9a5ac401e066a9e81eebe3c5", "display_unittests": "fe81ae773668d2de6ecdee44d3f0fb58741dfacb", "events_unittests": "1609ab0c40a3b01b62267d5e74b159a7d844720b", "gcm_unit_tests": "8035b09bfd9d9d106bcbc9c57a108da660fac7a7", "gfx_unittests": "fb4e36da7a6250444d5e65da999a2172dd27f21a", "gin_unittests": "4eacec3f46d3ee88d361ff8c4f5715bbc08677b1", "gl_tests": "087e8a9eba20885198cb43a06b315178694e8b50", "gl_unittests": "831c70f2d5d64a2d3d1dfe39b37cf6f2af6abc1b", "google_apis_unittests": "7ad004ab4f4395a8d0cd72091f1addfdc52eebda", "gpu_unittests": "00fd78b47db3c000bc7ac7f86d4882662e00bdc0", "ipc_tests": "1303777f0d98fb8dbb6a21726ffcb00e2c066e0e", "jingle_unittests": "1317bfb4ba938fa38f3b43d5a27cc82b8893f830", "latency_unittests": "d719f5cb2c157ebb07ea3b13d9ff3606504fd2dc", "libjingle_xmpp_unittests": "30b50f99239dcb628d35e387a51ee6ab45ed85a0", "media_blink_unittests": "eb2248f6799f5719f75f23e8bba982a2d053a639", "media_service_unittests": "d6cb6d6c84bf76b22b7062c01bcfee6922eeede0", "media_unittests": "e959119fb5423c79b36d227faab6bebd8e33f36b", "midi_unittests": "4ad2f9ad151f6d28c73ad283c4a2b9ce79d6f5de", "mojo_test_apk": "6bf38fa60acbf8e2233cf97f121552e822f8ef8a", "mojo_unittests": "b1269709b0fc52a44c7cc1c92092a9f2e7bca338", "net_unittests": "a6b845246d586de93cb10d6e854bcafd28ad72fc", "sandbox_linux_unittests": "5db1ee0a966bea5948f96d96618b02309e2305bd", "services_unittests": "0b3868e59eede6611ec84b0a2123663cd3c0dba6", "shell_dialogs_unittests": "8feac38d18339b4faf949b99dcd8eaf82ef00969", "skia_unittests": "54233873d38f8e568601eb04eb6e1ed46c766045", "sql_unittests": "dc690a54a02a6d1cae48835b3a49756525d77533", "storage_unittests": "990c542c277922c4699f62737534ce72dd2f6c18", "ui_android_unittests": "fb25c6caaf8599eed27dd605ba77756ec3afccc8", "ui_base_unittests": "cc4f71cd52a27807dd2681e07c73f0da10c94216", "ui_touch_selection_unittests": "e879fb4354e1fc17e040d9cc3b598ddf4925a63b", "unit_tests": "02b5cd76c183e336a2f6c13187b590a5fb4ca73b", "url_unittests": "ed2edd997108121909a1f5c9020bd0ca57df6def", "viz_unittests": "e08f4049632cd53d1cc0e6f8dde472292979c2ae", "vr_common_unittests": "5d10add4156a90a6ac3c06ec341a5132d044da2b", "vr_pixeltests": "813f2fbed8d169e327b76ca518d54e5a095971a4", "webkit_layout_tests_exparchive": "b78fa83e4a2ee2fa3273d142fa8628383ccde415", "webkit_unit_tests": "f9c9b2eaea56cc5dd9fd6811e1aec6e6a73fb27f", "webview_instrumentation_test_apk": "c3df274304110068fc5fcb124117e14f17af2842", "wtf_unittests": "768aaee8afd45a402f9a4cdc561a71bccd34d913"} find isolated tests

Blamelist:

  1. Findit (findit-for-meohnoyoudont@appspot.gserviceaccount.com)
  2. Peter Kasting (pkastingohnoyoudont@chromium.org)
  3. Yuwei Huang (yuweihohnoyoudont@chromium.org)

Timing:

Create Saturday, 11-Aug-18 06:40:09 UTC
Start Saturday, 11-Aug-18 06:40:28 UTC
End Saturday, 11-Aug-18 07:10:34 UTC
Pending 19 secs
Execution 30 mins 5 secs

All Changes:

  1. Revert "Add vector of intervals range checking to Time Restrictions policy"

    Changed by Findit - findit-for-meohnoyoudont@appspot.gserviceaccount.com
    Changed at Saturday, 11-Aug-18 05:19:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3a30357690bfd391e2ddab461c6bd48e2c8a5580

    Comments

    Revert "Add vector of intervals range checking to Time Restrictions policy"
    
    This reverts commit b3392d988ae23dc52d9b386af47dc6a53a2d22c8.
    
    Reason for revert:
    
    Findit (https://goo.gl/kROfz5) identified CL at revision 582403 as the
    culprit for failures in the build cycles as shown on:
    https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2IzMzkyZDk4OGFlMjNkYzUyZDliMzg2YWY0N2RjNmE1M2EyZDIyYzgM
    
    Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28575
    
    Sample Failed Step: unit_tests
    
    Original change's description:
    > Add vector of intervals range checking to Time Restrictions policy
    > 
    > * Add function GetEndOfCurrent interval to obtain the last end of the
    > interval which contains the current time.
    > * Add function MaterializeIntervalsToLocalTimezone, which materializes
    > the given intervals to the current local timezone.
    > * Add function TimeIsInsideCrosSettingsIntervals, which checks if the
    > current time is inside the intervals set in cros settings. It then
    > returns the localized string of the end of the interval that contains
    > the current time.
    > 
    > BUG=chromium:852860
    > TEST=added unittests
    > 
    > Change-Id: Ife32e31c8a929827fd14ab9f108c49eacb9c32c3
    > Reviewed-on: https://chromium-review.googlesource.com/1132676
    > Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    > Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#582403}
    
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    BUG=chromium:852860
    
    Change-Id: I1663fc559003d938270da4b8fd7e85719b8e9e01
    Reviewed-on: https://chromium-review.googlesource.com/1172003
    Cr-Commit-Position: refs/heads/master@{#582430}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/policy/device_auto_update_time_restrictions_utils.cc
    • chrome/browser/chromeos/policy/device_auto_update_time_restrictions_utils.h
    • chrome/browser/chromeos/policy/device_auto_update_time_restrictions_utils_unittest.cc
    • chrome/browser/chromeos/policy/weekly_time/time_utils.cc
    • chrome/browser/chromeos/policy/weekly_time/time_utils.h
    • chrome/browser/chromeos/policy/weekly_time/time_utils_unittest.cc
    • chrome/browser/chromeos/policy/weekly_time/weekly_time.h
    • chrome/browser/chromeos/policy/weekly_time/weekly_time_interval.h
  2. Revert "Remove unnecessary tab key press from Focus_AdvanceFocus test"

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 05:15:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6df1590559bd965c71b181b4d948e0ea3318189a

    Comments

    Revert "Remove unnecessary tab key press from Focus_AdvanceFocus test"
    
    This reverts commit 5eeadd143332f6fc6c26af924d8a38d5f49b06a2.
    
    Reason for revert: Seems to have caused failures on mac_cocoa_rel, see e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8938549477439492256/+/steps/interactive_ui_tests/0/logs/WebViewFocusInteractiveTest.Focus_AdvanceFocus/0
    
    Original change's description:
    > Remove unnecessary tab key press from Focus_AdvanceFocus test
    > 
    > The associated bug which required this extra tab is fixed.
    > 
    > Bug: 147644
    > Change-Id: Ied21533accc82613053e119aa2c5c64fc9de8343
    > Reviewed-on: https://chromium-review.googlesource.com/1170986
    > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
    > Commit-Queue: Kevin McNee <mcnee@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#582240}
    
    TBR=ekaramad@chromium.org,mcnee@chromium.org
    
    Change-Id: I6c84e6950d7f74ae5b15eec084a536115e635ceb
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 147644
    Reviewed-on: https://chromium-review.googlesource.com/1172002
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582429}

    Changed files

    • chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
  3. [CRD iOS] Make ChromotingSession own the AudioStub

    Changed by Yuwei Huang - yuweihohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 04:59:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 206d44a2086dc771c898b5d3f9da0bcd95f6c0a7

    Comments

    [CRD iOS] Make ChromotingSession own the AudioStub
    
    Previously AudioStub is owned by the the (Remoting|Jni)Client class and
    being passed to ChromotingSession as a WeakPtr. The AudioStub is not
    used after it is passed to ChromotingSession and it is a burden for the
    *Client class to manage its lifetime.
    
    This CL fixes this by making ChromotingSession own the AudioStub.
    
    Bug: 868088
    Change-Id: I067f321b3aab7110df7bb85a8b8c519ea889865e
    Reviewed-on: https://chromium-review.googlesource.com/1171840
    Reviewed-by: Joe Downing <joedow@chromium.org>
    Commit-Queue: Yuwei Huang <yuweih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582428}

    Changed files

    • remoting/client/audio/audio_playback_stream.cc
    • remoting/client/audio/audio_playback_stream.h
    • remoting/client/chromoting_session.cc
    • remoting/client/chromoting_session.h
    • remoting/client/jni/jni_client.cc
    • remoting/client/jni/jni_client.h
    • remoting/ios/session/remoting_client.mm