Home | Search | chromium - Builders
Login

Builder Jumbo Mac Build 35219 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revision436a1ba8ec7676a2a014611c127eff1df05a9bf3
Got Revision436a1ba8ec7676a2a014611c127eff1df05a9bf3

Execution:

Steps and Logfiles:

Show:
  1. ( 340 ms ) setup_build
    running recipe: "chromium"
  2. ( 264 ms ) report builders
     
    running builder/tester 'Jumbo Mac' on master 'chromium.fyi'
  3. ( 1 mins 39 secs ) bot_update
    [93GB/232GB used (40%)]
  4. ( 924 ms ) swarming.py --version
    0.14
  5. ( 169 ms ) ensure_installed
  6. ( 14 secs ) gclient runhooks
  7. ( 888 ms ) read test spec (chromium.fyi.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.fyi.json
  8. ( 370 ms ) lookup GN args
     
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    use_jumbo_build = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  9. ( 21 secs ) generate_build_files
  10. ( 712 ms ) clang_revision
  11. ( 5 mins 26 secs ) compile
  12. ( 12 secs ) compile confirm no-op

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build225-m9" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544168556096375, "id": "8927815628081572928", "project": "chromium", "tags": ["builder:Jumbo Mac", "buildset:commit/git/436a1ba8ec7676a2a014611c127eff1df05a9bf3", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/436a1ba8ec7676a2a014611c127eff1df05a9bf3", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9093245690161827712", "scheduler_job_id:chromium/Jumbo Mac", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Jumbo Mac" setup_build
buildnumber 35219 setup_build
mastername "chromium.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "436a1ba8ec7676a2a014611c127eff1df05a9bf3" setup_build
got_angle_revision "c3e3731cd3b2a3044f1bdec906c8557cc3edae77" bot_update
got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" bot_update
got_dawn_revision "0f50114b3c6849238eedf95236137d614fed4be2" bot_update
got_nacl_revision "8e13fe5e85640b063aefcb88a3ccb52abf6e28e8" bot_update
got_revision "436a1ba8ec7676a2a014611c127eff1df05a9bf3" bot_update
got_revision_cp "refs/heads/master@{#614634}" bot_update
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" bot_update
got_v8_revision "fd3bdfdac02db5d3ab67b707cfe9ca814947d18e" bot_update
got_v8_revision_cp "refs/heads/7.3.56@{#1}" bot_update
got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25919}" bot_update
got_clang_revision "346388-5" clang_revision

Blamelist:

  1. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  2. Avi Drissman (aviohnoyoudont@chromium.org)
  3. Alan Cutter (alancutterohnoyoudont@chromium.org)
  4. Christopher Cameron (ccameronohnoyoudont@chromium.org)
  5. Peter Kotwicz (pkotwiczohnoyoudont@chromium.org)
  6. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  7. Shu Chen (shuchenohnoyoudont@google.com)

Timing:

Create Friday, 07-Dec-18 07:42:36 UTC
Start Friday, 07-Dec-18 07:43:31 UTC
End Friday, 07-Dec-18 07:54:03 UTC
Pending 55 secs
Execution 10 mins 32 secs

All Changes:

  1. Roll src-internal 3e90e0805dd5..d6f7eee8488a (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 07:42:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 436a1ba8ec7676a2a014611c127eff1df05a9bf3

    Comments

    Roll src-internal 3e90e0805dd5..d6f7eee8488a (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3e90e0805dd5..d6f7eee8488a
    
    
    Created with:
      gclient setdep -r src-internal@d6f7eee8488a
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I235a2cc7484e30914cdeb8f754ab2ae852ce6592
    Reviewed-on: https://chromium-review.googlesource.com/c/1366882
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614634}

    Changed files

    • DEPS
  2. Remove linked_ptr from the extensions trackers.

    Changed by Avi Drissman - aviohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 07:21:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38d4c8616dd560586a6e29165b77eadd5a2ca1ed

    Comments

    Remove linked_ptr from the extensions trackers.
    
    BUG=582001
    
    Change-Id: I4141f3fe268d34e5d078740b5ef12b4f02b5efb1
    Reviewed-on: https://chromium-review.googlesource.com/c/1364550
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614633}

    Changed files

    • chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.cc
    • chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.h
    • chrome/browser/extensions/api/declarative_content/declarative_content_is_bookmarked_condition_tracker.cc
    • chrome/browser/extensions/api/declarative_content/declarative_content_is_bookmarked_condition_tracker.h
    • chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.cc
    • chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.h
  3. Revert "Add chrome_proxy.exe target on Windows"

    Changed by Alan Cutter - alancutterohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 07:03:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0edcdf14a29397ba43d8e303bcf01f04705ed95e

    Comments

    Revert "Add chrome_proxy.exe target on Windows"
    
    This reverts commit 86e7ed69a96f03ffcbb6af63d632f7951bf34b28.
    
    Reason for revert: Broke Chrome Canary update while the browser is open.
    Bug: 912716
    
    Original change's description:
    > Add chrome_proxy.exe target on Windows
    >
    > This change adds a new executable to Windows called chrome_proxy.exe which
    > opens chrome.exe with all arguments forwarded.
    >
    > In a future patch bookmark app shortcuts will be updated to point to
    > chrome_proxy.exe instead of chrome.exe so they don't pick up the
    > chrome.VisualElementsManifest.xml file when pinned to the Windows 10
    > start menu. This fixes a bug where pinned bookmark app shortcuts all
    > use the Chrome logo instead of their own.
    >
    > Bug: 732357
    > Change-Id: I551093f6f111041b424d30ec3f829fa6a06a265c
    > Reviewed-on: https://chromium-review.googlesource.com/c/1362695
    > Reviewed-by: Greg Thompson <grt@chromium.org>
    > Reviewed-by: Lei Zhang <thestig@chromium.org>
    > Commit-Queue: Alan Cutter <alancutter@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614177}
    
    TBR=thestig@chromium.org,alancutter@chromium.org,mgiuca@chromium.org,grt@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    NOPRESUBMIT=TRUE # TBR doesn't apply because this revert touches an OWNERS file.
    
    Bug: 732357
    Change-Id: I73cddef3173e3abc22f8c8c4720d84f9a9069ab1
    Reviewed-on: https://chromium-review.googlesource.com/c/1366471
    Commit-Queue: Alan Cutter <alancutter@chromium.org>
    Reviewed-by: Alan Cutter <alancutter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614632}

    Changed files

    • chrome/BUILD.gn
    • chrome/chrome_proxy/BUILD.gn
    • chrome/chrome_proxy/OWNERS
    • chrome/chrome_proxy/chrome_proxy.ver
    • chrome/chrome_proxy/chrome_proxy_main_win.cc
    • chrome/installer/mini_installer/BUILD.gn
    • chrome/installer/mini_installer/chrome.release
    • chrome/installer/setup/install_worker.cc
    • chrome/installer/setup/install_worker.h
    • chrome/installer/setup/setup_main.cc
    • chrome/installer/util/util_constants.cc
    • chrome/installer/util/util_constants.h
    • chrome/test/mini_installer/config/chrome_beta_installed.prop
    • chrome/test/mini_installer/config/chrome_canary_installed.prop
    • chrome/test/mini_installer/config/chrome_dev_installed.prop
    • chrome/test/mini_installer/config/chrome_multi_system_installed.prop
    • chrome/test/mini_installer/config/chrome_multi_user_installed.prop
    • chrome/test/mini_installer/config/chrome_system_installed.prop
    • chrome/test/mini_installer/config/chrome_user_installed.prop
    • chrome/test/mini_installer/config/previous_chrome_canary_installed.prop
    • chrome/test/mini_installer/config/previous_chrome_system_installed.prop
    • chrome/test/mini_installer/config/previous_chrome_user_installed.prop
    • chrome/tools/build/win/FILES.cfg
  4. RemoteMacViews: Wire up menu items and shortcut keys

    Changed by Christopher Cameron - ccameronohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 07:00:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1c1992d02fa89792498f5e3533772bd65d93973d

    Comments

    RemoteMacViews: Wire up menu items and shortcut keys
    
    For menu items and shortcut keys to work, PWA windows need to have the
    ChromeCommandDispatcherDelegate and BrowserWindowCommandHandler
    structures set on them.
    
    This cannot be done by a method on views_bridge_mac::mojom::
    BridgedNativeWidget, because the structures to be created exist in
    Chrome, which would be a layering violation.
    
    Introduce a method to chrome::mojom::AppShim which takes a widget id,
    creates the ChromeCommandDispatcherDelegate and
    BrowserWindowCommandHandler, and assigns them to the corresponding
    BridgedNativeWidgetImpl.
    
    Bug: 895169
    Change-Id: Ie1d333bec235d7b6101d5b19aa89a74136d54a7a
    Reviewed-on: https://chromium-review.googlesource.com/c/1364210
    Commit-Queue: ccameron <ccameron@chromium.org>
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Reviewed-by: Robert Sesek <rsesek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614631}

    Changed files

    • chrome/app_shim/app_shim_controller.h
    • chrome/app_shim/app_shim_controller.mm
    • chrome/browser/apps/app_shim/app_shim_host_mac.cc
    • chrome/browser/apps/app_shim/app_shim_host_mac.h
    • chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc
    • chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm
    • chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc
    • chrome/browser/apps/app_shim/extension_app_shim_handler_mac.h
    • chrome/browser/ui/views/frame/browser_frame_mac.mm
    • chrome/common/mac/app_shim.mojom
    • ui/views/cocoa/bridged_native_widget_unittest.mm
    • ui/views/widget/native_widget_mac.h
  5. [Android Tests] Fix several FirstRunIntegrationTests

    Changed by Peter Kotwicz - pkotwiczohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:57:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ca54644ff73878027d7903ab3bd6288561e68a8

    Comments

    [Android Tests] Fix several FirstRunIntegrationTests
    
    This CL converts several FirstRunIntegrationTests to JUnit tests and
    re-enables them.
    
    BUG=911316
    
    Change-Id: I7aada68234fe9a5cb25ee3bef29538cec537d49a
    Reviewed-on: https://chromium-review.googlesource.com/c/1362812
    Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
    Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614630}

    Changed files

    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationUnitTest.java
  6. Roll src/third_party/skia 309f1deddf8e..f3babcd0afb3 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 06:49:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8112997ce464e3fa4ae5ca8e166c7adc1de03e35

    Comments

    Roll src/third_party/skia 309f1deddf8e..f3babcd0afb3 (2 commits)
    
    https://skia.googlesource.com/skia.git/+log/309f1deddf8e..f3babcd0afb3
    
    
    git log 309f1deddf8e..f3babcd0afb3 --date=short --no-merges --format='%ad %ae %s'
    2018-12-07 sergeyu@chromium.org Reland "Add SkFontMgr implementation for Fuchsia"
    2018-12-07 reed@google.com Revert "Add SkFontMgr implementation for Fuchsia"
    
    
    Created with:
      gclient setdep -r src/third_party/skia@f3babcd0afb3
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jcgregorio@chromium.org
    
    Change-Id: Ieefefb070c45ba63a5efa3872a75e1d4140b5e41
    Reviewed-on: https://chromium-review.googlesource.com/c/1367116
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614629}

    Changed files

    • DEPS
  7. Updates the order of key mappings to match the same as layout rendering in VK.

    Changed by Shu Chen - shuchenohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 06:48:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 65054bfdd84984501e8054b2f96edacc1bab93a9

    Comments

    Updates the order of key mappings to match the same as layout rendering in VK.
    
    The modifier importance priority is: Altgr > Shift > Capslock.
    So if user presses a key with Shift + Altgr + Capslock and the key mapping is not defined for the input method.
    It will fallback to other key mappings in this order:
     - Shift + Altgr
     - Altgr + Capslock
     - Shift + Capslock
     - Altgr
     - Shift
     - Capslock
     - Normal
    
    Bug: 910049
    Change-Id: I3a274ba02671977a075ee27441acf429cf4569cb
    Reviewed-on: https://chromium-review.googlesource.com/c/1356735
    Reviewed-by: Leo Zhang <googleo@chromium.org>
    Commit-Queue: Leo Zhang <googleo@chromium.org>
    Commit-Queue: Shu Chen <shuchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614628}

    Changed files

    • chromeos/services/ime/public/cpp/rulebased/def/fa.cc
    • chromeos/services/ime/public/cpp/rulebased/def/lo.cc
    • chromeos/services/ime/public/cpp/rulebased/def/ta_inscript.cc
    • chromeos/services/ime/public/cpp/rulebased/def/ta_phone.cc
    • chromeos/services/ime/public/cpp/rulebased/def/th.cc