Builder Jumbo Linux x64 Build 30720
Results:
Success
Trigger Info:
Project | chromium |
Revision | 881f038dd7b969c5ff9fa11f4b946de2141a75e5 |
Got Revision | 881f038dd7b969c5ff9fa11f4b946de2141a75e5 |
Execution:
- Source: Task 429682fe0d9e8a10
- Bot: swarm1859-c4
- Recipe: chromium
Steps and Logfiles:
Show:-
- - no logs -
-
( 1 secs ) read test spec (chromium.fyi.json)path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.fyi.json
-
( 433 ms ) lookup GN argsis_component_build = falseis_debug = falsejumbo_file_merge_limit = 50strip_absolute_paths_from_debug_symbols = truesymbol_level = 0use_goma = trueuse_jumbo_build = truegoma_dir = "/b/swarming/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm1859-c4" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548297007901517, "id": "8923486632601040368", "project": "chromium", "tags": ["builder:Jumbo Linux x64", "buildset:commit/git/881f038dd7b969c5ff9fa11f4b946de2141a75e5", "scheduler_invocation_id:9088916695116883648", "scheduler_job_id:chromium/Jumbo Linux x64", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "Jumbo Linux x64" | setup_build |
buildnumber | 30720 | setup_build |
mastername | "chromium.fyi" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
repository | "https://chromium.googlesource.com/chromium/src.git" | setup_build |
revision | "881f038dd7b969c5ff9fa11f4b946de2141a75e5" | setup_build |
got_angle_revision | "47ca1b2fa3990e51a2ced20f7a7d3589a5477ad1" | bot_update |
got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | bot_update |
got_dawn_revision | "c0f31e73e481f32d308cb6232e75e6d860d97063" | bot_update |
got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
got_revision | "881f038dd7b969c5ff9fa11f4b946de2141a75e5" | bot_update |
got_revision_cp | "refs/heads/master@{#625483}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "9df9418edf64d6a080ba569ef43cd5ca0171a820" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.492@{#2}" | bot_update |
got_webrtc_revision | "b0397d69a93a909fc0b29ffdb9236bab1e1b2db7" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26368}" | bot_update |
Blamelist:
- Sky Malice (skymohnoyoudont@chromium.org)
Timing:
Create | Thursday, 24-Jan-19 02:30:07 UTC |
Start | Thursday, 24-Jan-19 02:30:09 UTC |
End | Thursday, 24-Jan-19 02:36:53 UTC |
Pending | 1 secs |
Execution | 6 mins 44 secs |
All Changes:
-
[Feed] Switch to using onClearAllWithRefresh.
Changed by Sky Malice - skymohnoyoudont@chromium.org Changed at Thursday, 24-Jan-19 02:28:54 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 881f038dd7b969c5ff9fa11f4b946de2141a75e5 Comments
[Feed] Switch to using onClearAllWithRefresh. The Feed has requested that when we wipe out suggestions and then fetch new articles, instead of sequentially calling onClearAll and triggerRefresh, instead we just call onClearAllWithRefresh. This will let them handle these operations more gracefully and avoid races. The host classes were not initially structured to facilitate this. The scheduler, which must decide if we want to trigger a refresh or not, is not the same host that has access to the AppLifecycleListener which is what has the onClearAllWithRefresh method. This change plums a boolean back up from the scheduler to the FeedAppLifecycle so that we can decide if onClearAllWithRefresh or onClearAll should be called after an event occurs that wipes out all articles. Bug: 919901, 913874 Change-Id: I7684673a6367ba4aa90390ef98f8da938ac14c71 Reviewed-on: https://chromium-review.googlesource.com/c/1409479 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#625483}
Changed files
- chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedAppLifecycle.java
- chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedScheduler.java
- chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedSchedulerBridge.java
- chrome/android/javatests/src/org/chromium/chrome/browser/feed/FeedAppLifecycleTest.java
- chrome/browser/android/feed/feed_scheduler_bridge.cc
- chrome/browser/android/feed/feed_scheduler_bridge.h
- components/feed/core/feed_scheduler_host.cc
- components/feed/core/feed_scheduler_host.h
- components/feed/core/feed_scheduler_host_unittest.cc