Home | Search | chromium - Builders
Login

Builder GPU FYI Win x64 Builder (dbg) Build 3157 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision03daf4e42f99ef9329ec05fc186c1936ffa718a9
Got Revision03daf4e42f99ef9329ec05fc186c1936ffa718a9

Execution:

Steps and Logfiles:

Show:
  1. ( 761 ms ) setup_build
    running recipe: "chromium"
  2. ( 4 secs ) taskkill
  3. ( 354 ms ) remove .cipd
  4. ( 4 mins 11 secs ) bot_update
    [101GB/299GB used (33%)]
  5. ( 0 ) ensure_goma
  6. ( 2 secs ) swarming.py --version
    0.13
  7. ( 1 mins 35 secs ) gclient runhooks
  8. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: C:\b\swarming\w\ir\cache\builder\src\testing\buildbot\chromium.gpu.fyi.json
  9. ( 48 mins 10 secs ) compile
  10. ( 2 mins 26 secs ) compile confirm no-op
  11. ( 4 mins 54 secs ) package build

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm763-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531423509691670, "id": "8941179777860717616", "project": "chromium", "tags": ["builder:GPU FYI Win x64 Builder (dbg)", "buildset:commit/git/03daf4e42f99ef9329ec05fc186c1936ffa718a9", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/03daf4e42f99ef9329ec05fc186c1936ffa718a9", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106609840028309712", "scheduler_job_id:chromium/GPU FYI Win x64 Builder (dbg)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "GPU FYI Win x64 Builder (dbg)" setup_build
buildnumber 3157 setup_build
mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "03daf4e42f99ef9329ec05fc186c1936ffa718a9" setup_build
got_angle_revision "1617e69e3883e77f8ae05680576d08d905fcc70f" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "03daf4e42f99ef9329ec05fc186c1936ffa718a9" bot_update
got_revision_cp "refs/heads/master@{#574676}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "798ee75d23651e7631775a113742bd09cc02e212" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23952}" bot_update
build_archive_url "gs://chromium-gpu-fyi-archive/chromium.gpu.fyi/GPU FYI Win x64 Builder (dbg)/full-build-win32_03daf4e42f99ef9329ec05fc186c1936ffa718a9.zip" package build

Blamelist:

  1. Fabio Tirelo (ftireloohnoyoudont@chromium.org)
  2. Kenneth Russell (kbrohnoyoudont@chromium.org)
  3. perfetto-chromium-autoroll (perfetto-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  4. Daniel Murphy (dmurphohnoyoudont@chromium.org)
  5. Chromite Chromium Autoroll (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  6. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  7. Lei Zhang (thestigohnoyoudont@chromium.org)
  8. Lu Chen (cheluohnoyoudont@chromium.org)
  9. Scott Chen (scottchenohnoyoudont@chromium.org)
  10. Kenneth Russell (kbrohnoyoudont@chromium.org)
  11. Kyle Milka (kmilkaohnoyoudont@chromium.org)
  12. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  13. Erik Luo (luoeohnoyoudont@chromium.org)
  14. Nate Fischer (ntfschrohnoyoudont@chromium.org)
  15. Michael Thiessen (mthiesseohnoyoudont@chromium.org)
  16. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
  17. Lei Zhang (thestigohnoyoudont@chromium.org)
  18. Scott Chen (scottchenohnoyoudont@chromium.org)
  19. Pedro Amaral (amaralpohnoyoudont@chromium.org)
  20. Christian Fremerey (chfremerohnoyoudont@chromium.org)
  21. Chris Palmer (palmerohnoyoudont@chromium.org)
  22. Tiger Oakes (tigeroohnoyoudont@google.com)
  23. Xiaocheng Hu (xiaochenghohnoyoudont@chromium.org)
  24. Weidong Guo (weidonggohnoyoudont@chromium.org)
  25. Min Qin (qinminohnoyoudont@chromium.org)
  26. Patrick Noland (pnolandohnoyoudont@google.com)
  27. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
  28. Thomas Tangl (tangltomohnoyoudont@chromium.org)
  29. Manu Cornet (manucornetohnoyoudont@chromium.org)
  30. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  31. Rayan Kanso (rayankansohnoyoudont@chromium.org)
  32. Tom Anderson (thomasandersonohnoyoudont@chromium.org)
  33. Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
  34. wutao (wutaoohnoyoudont@chromium.org)
  35. Helen Li (xunjieliohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 19:25:09 UTC
Start Thursday, 12-Jul-18 19:25:11 UTC
End Thursday, 12-Jul-18 20:37:37 UTC
Pending 2 secs
Execution 1 hrs 12 mins

All Changes:

  1. Reland: [af] Adjust dropdown so it doesn't look so close to the input element

    Changed by Fabio Tirelo - ftireloohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:22:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 03daf4e42f99ef9329ec05fc186c1936ffa718a9

    Comments

    Reland: [af] Adjust dropdown so it doesn't look so close to the input element
    
    This relands commit f1c12e6, which was reverted by commit c71c2c1.
    
    The reason for the revert was a crash introduced by c53515c, and
    reverting that commit was very hard due to merge conflicts.
    
    Bug: 847980
    Change-Id: Ib1b6931d3ac697e78c27a6cbcc7e082f0da4b6ef
    Reviewed-on: https://chromium-review.googlesource.com/1135446
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574676}

    Changed files

    • chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
  2. Complete upgrade of Retina Macs to 10.13.5.

    Changed by Kenneth Russell - kbrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:21:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 43d34bd136540d0ff14ed70bfc2a69019338595d

    Comments

    Complete upgrade of Retina Macs to 10.13.5.
    
    Turn off the multi-dimension trigger script.
    
    Fix the configuration of "Optional Mac Retina Release (AMD)"; a
    mistake was made in the earlier CL beginning the upgrade, and the jobs
    didn't auto-migrate from 10.12.6 to 10.13.5.
    
    Bug: 856799
    Tbr: ynovikov@chromium.org
    Change-Id: Ifcceed16154c47ffaa5b682149780bc53f4a101b
    Reviewed-on: https://chromium-review.googlesource.com/1135651
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574675}

    Changed files

    • testing/buildbot/chromium.gpu.fyi.json
    • testing/buildbot/chromium.gpu.json
    • testing/buildbot/waterfalls.pyl
  3. Roll src/third_party/perfetto f37ffaf9b1a1..2af75f76f0e6 (2 commits)

    Changed by perfetto-chromium-autoroll - perfetto-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:21:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7b6920828c5fa9f72dce1b84c9ae95711ae037e5

    Comments

    Roll src/third_party/perfetto f37ffaf9b1a1..2af75f76f0e6 (2 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/f37ffaf9b1a1..2af75f76f0e6
    
    
    git log f37ffaf9b1a1..2af75f76f0e6 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 michaschwab@google.com Merge "Improve Context Architecture, add "isOnCanvas" method"
    2018-07-12 michaschwab@google.com Improve Context Architecture, add "isOnCanvas" method
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@2af75f76f0e6
    
    The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I4222bc49a1619c3cc2972a496dd5e7e961d03363
    Reviewed-on: https://chromium-review.googlesource.com/1135213
    Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574674}

    Changed files

    • DEPS
  4. [SessionStorage] Always delete Session Storage database on Android

    Changed by Daniel Murphy - dmurphohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:18:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 154ac5551c1e0ff8c877b4cd0e26ad6ea30d4860

    Comments

    [SessionStorage] Always delete Session Storage database on Android
    
    Android doesn't have session restore code run, and this code is what
    cleaned up old session storage namespaces from previous browser runs.
    
    So on Android, the session storage context will delete the database
    on startup.
    
    R=mek@chromium.org
    
    Bug: 860030
    Change-Id: Ia7c349811e4970d05a071a0de9ad50117d771855
    Reviewed-on: https://chromium-review.googlesource.com/1125260
    Commit-Queue: Daniel Murphy <dmurph@chromium.org>
    Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574673}

    Changed files

    • content/browser/dom_storage/dom_storage_context_wrapper.cc
    • content/browser/dom_storage/session_storage_context_mojo.cc
    • content/browser/dom_storage/session_storage_context_mojo.h
    • content/browser/dom_storage/session_storage_context_mojo_unittest.cc
  5. Roll src/third_party/chromite 3973c26575e2..ca73efa2232f (1 commits)

    Changed by Chromite Chromium Autoroll - chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:18:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0113967ab2dcdc45364c7cfa35fd095856d7ede5

    Comments

    Roll src/third_party/chromite 3973c26575e2..ca73efa2232f (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/3973c26575e2..ca73efa2232f
    
    
    git log 3973c26575e2..ca73efa2232f --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 stevenjb@chromium.org deploy_chrome: Always prompt to remove rootfs verification
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@ca73efa2232f
    
    The AutoRoll server is located here: https://chromite-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I910679c20d35bb32e7f9e089bdde8a437a37961c
    Reviewed-on: https://chromium-review.googlesource.com/1135208
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574672}

    Changed files

    • DEPS
  6. [Unity][Android] Update string for payments sync datatype

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:17:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab5e146619a4ce43dd36939245a2b6a9a254ef90

    Comments

    [Unity][Android] Update string for payments sync datatype
    
    This CL changes the string used for payments in
    'Sync and Google services' preferences screen.
    
    Bug: 814728
    Change-Id: Ib1932ef94ad6f6b90efa5a59e0ef0500775b9496
    Reviewed-on: https://chromium-review.googlesource.com/1135321
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574671}

    Changed files

    • chrome/android/java/res/xml/sync_customization_preferences.xml
    • chrome/android/java/strings/android_chrome_strings.grd
  7. Move PDFiumEngine doc/form/loading members into PDFiumDocument.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:16:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 94754366872ddaafeb4ec141f971ee47d3350c59

    Comments

    Move PDFiumEngine doc/form/loading members into PDFiumDocument.
    
    Change-Id: I11c1ecff9305a75f66c3de5443fde4d0423163d2
    Reviewed-on: https://chromium-review.googlesource.com/1112498
    Reviewed-by: dsinclair <dsinclair@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574670}

    Changed files

    • pdf/BUILD.gn
    • pdf/pdfium/pdfium_document.cc
    • pdf/pdfium/pdfium_document.h
    • pdf/pdfium/pdfium_engine.cc
    • pdf/pdfium/pdfium_engine.h
  8. Add bad IPC message check at the browser.

    Changed by Lu Chen - cheluohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:15:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f9ecec290e797566bdbbe41459d68a4045e29b5e

    Comments

    Add bad IPC message check at the browser.
    
    Add bad IPC message check to UpdateAnchorElementMetrics. The browser
    will kill the renderer process when it receives a bad message.
    
    Bug: 850624
    Change-Id: I750b6d54e556ddc659cb693844922234b9e845ce
    Reviewed-on: https://chromium-review.googlesource.com/1128259
    Commit-Queue: Lu Chen <chelu@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574669}

    Changed files

    • chrome/browser/navigation_predictor/navigation_predictor.cc
    • chrome/browser/navigation_predictor/navigation_predictor.h
    • chrome/browser/navigation_predictor/navigation_predictor_unittest.cc
    • tools/metrics/histograms/histograms.xml
  9. Settings: fix sync-account-controls banner overflowing border-radius.

    Changed by Scott Chen - scottchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:15:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 66d0e64aa958612d6b9cf38b9b8409925487458b

    Comments

    Settings: fix sync-account-controls banner overflowing border-radius.
    
    Bug: 860265
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ie85c25b7b777463569f4d3b4f01f8a8e524c84f5
    Reviewed-on: https://chromium-review.googlesource.com/1133977
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574668}

    Changed files

    • chrome/browser/resources/settings/people_page/people_page.html
    • chrome/browser/resources/settings/people_page/sync_account_control.html
  10. Update GPU pixel wrangling graphs for macOS 10.13.5 upgrade.

    Changed by Kenneth Russell - kbrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:14:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 32b92d2bc9ae9c12e01f7879de715843ac849ae8

    Comments

    Update GPU pixel wrangling graphs for macOS 10.13.5 upgrade.
    
    Tbr: ynovikov@chromium.org
    Bug: 856799
    Change-Id: I6d7265037477715df7ca7e31290ef88f7ad4f668
    Reviewed-on: https://chromium-review.googlesource.com/1135657
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574667}

    Changed files

    • docs/gpu/pixel_wrangling.md
  11. [NTP] Add Google Photos option for custom backgrounds

    Changed by Kyle Milka - kmilkaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:13:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d87ed83235c1f5505f58b0d51923dfe11db9faae

    Comments

    [NTP] Add Google Photos option for custom backgrounds
    
    Allow users to select one of their photos from Google Photos and set it
    as the NTP background image. Currently only supports users who are
    already signed in to their Google account.
    
    Bug: 848012
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Idef07f3cd107199a8e308fc883c96b9a8da37b1e
    Reviewed-on: https://chromium-review.googlesource.com/1130100
    Commit-Queue: Kyle Milka <kmilka@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574666}

    Changed files

    • chrome/browser/resources/local_ntp/custom_backgrounds.css
    • chrome/browser/resources/local_ntp/custom_backgrounds.js
    • chrome/browser/resources/local_ntp/local_ntp.html
    • chrome/browser/search/background/ntp_background_data.cc
    • chrome/browser/search/background/ntp_background_data.h
    • chrome/browser/search/background/ntp_background_service.cc
    • chrome/browser/search/local_ntp_source.cc
    • chrome/test/data/local_ntp/local_ntp_browsertest.html
  12. Roll src/third_party/skia 56a426a516d0..5551a94b9e0f (15 commits)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:12:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 521effcf577f74a61bd5d6a35074ed2e3d20abd0

    Comments

    Roll src/third_party/skia 56a426a516d0..5551a94b9e0f (15 commits)
    
    https://skia.googlesource.com/skia.git/+log/56a426a516d0..5551a94b9e0f
    
    
    git log 56a426a516d0..5551a94b9e0f --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 mtklein@chromium.org update color management for color shaders
    2018-07-12 brianosman@google.com Update SRGBReadWritePixelsTest again, to only test opaque colors
    2018-07-12 fmalita@chromium.org PathKit/WASM tweaks
    2018-07-12 mtklein@chromium.org update mode color filter color management
    2018-07-12 mtklein@chromium.org remove unused parts of SkModeColorFilter
    2018-07-12 ziadb@google.com Java-only version of SkAR: drawing on android Canvas
    2018-07-12 brianosman@google.com Remove SK_LEGACY_GPU_PIXEL_OPS tests
    2018-07-12 egdaniel@google.com Generate GrVkInterface when we make the GrVkGpu.
    2018-07-12 reed@google.com remove unneeded scale from procs
    2018-07-12 brianosman@google.com In RGBA444TextureTest, use valid premul colors
    2018-07-12 borenet@google.com Roll Chromium manually to last successful CommandBuffer run
    2018-07-12 mtklein@chromium.org fix color management of CPU drawVertices()
    2018-07-12 caryclark@skia.org remove more references to draw filter
    2018-07-12 bsalomon@google.com remove debug gl interface, grcontextfactory context type, and config.
    2018-07-12 benjaminwagner@google.com Upgrade Skolo Mac bots to 10.13.6.
    
    
    Created with:
      gclient setdep -r src/third_party/skia@5551a94b9e0f
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: I31983fe5eb6e60f68f6b46ed52741dd82999eb78
    Reviewed-on: https://chromium-review.googlesource.com/1135209
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574665}

    Changed files

    • DEPS
  13. DevTools: clicking clear on input should focus

    Changed by Erik Luo - luoeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:11:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cdc1f3d342363df455d02fde8bc04d44f5331e5e

    Comments

    DevTools: clicking clear on input should focus
    
    The act of clicking the 'x' clear button blurs focus. This CL ensures
    the input focuses afterwards.
    
    Bug: 831059
    Change-Id: I848296c0981873cd878f5aaaead9654809811349
    Reviewed-on: https://chromium-review.googlesource.com/1134577
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Commit-Queue: Erik Luo <luoe@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574664}

    Changed files

    • third_party/blink/renderer/devtools/front_end/ui/Toolbar.js
  14. AW: trace events for WindowAndroid verification issues

    Changed by Nate Fischer - ntfschrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:10:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f50fc4d425345286e65488344fd85981bef36c94

    Comments

    AW: trace events for WindowAndroid verification issues
    
    No change to logic.
    
    This adds trace events inside AwContents to track WindowAndroid-related
    class verification errors. Specifically, this should illustrate the
    following verification errors:
    
     * WindowAndroid verification errors should cause activityFromContext to
       take longer than necessary.
     * ActivityWindowAndroid fails verification (because its superclass
       WindowAndroid fails verification), causing its constructor to take
       longer than necessary.
    
    R=torne@chromium.org
    
    Bug: 855796
    Test: tools/perf/run_benchmark system_health.webview_startup --browser android-webview-google
    Change-Id: I6633496fd672300216dfa6425910d19a7ae9e3da
    Reviewed-on: https://chromium-review.googlesource.com/1132479
    Reviewed-by: Richard Coles <torne@chromium.org>
    Commit-Queue: Nate Fischer <ntfschr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574663}

    Changed files

    • android_webview/java/src/org/chromium/android_webview/AwContents.java
  15. Fix VR watchlist

    Changed by Michael Thiessen - mthiesseohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:10:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a7bec5b1769172d3b2722182969d5c1ed618bc42

    Comments

    Fix VR watchlist
    
    Broken in https://chromium-review.googlesource.com/c/chromium/src/+/1134091/9/WATCHLISTS.
    
    Change-Id: Id84c46bb2f52d397975e1c3797a182b2becf9c07
    Reviewed-on: https://chromium-review.googlesource.com/1135115
    Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
    Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574662}

    Changed files

    • WATCHLISTS
  16. Restore some checks in FrameLoader::CommitNavigation

    Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:06:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cd7f8b8a57712e9a2b2deb2a10282dea99bdb5eb

    Comments

    Restore some checks in FrameLoader::CommitNavigation
    
    These were dropped when separating StartNavigation from
    CommitNavigation. It's reasonable that we cannot be in StopAllLoaders
    or similar unless there is a nested message loop.
    
    See test for an example how print() triggers this stack:
    ...<message loop running here, dispatched CommitNavigation>...
    IPC::SyncChannel::Send()
    content::RenderThreadImpl::Send()
    printing::PrintRenderFrameHelper::RequestPrintPreview()
    content::RenderFrameImpl::ScriptedPrint()
    blink::ChromeClientImpl::PrintDelegate()
    blink::ChromeClient::Print()
    blink::LocalDOMWindow::FinishedLoading()
    blink::FrameLoader::DidFinishNavigation()
    blink::Document::CheckCompleted()
    blink::FrameLoader::DetachProvisionalDocumentLoader()
    blink::DocumentLoader::StopLoading()
    blink::DocumentLoader::DetachFromFrame()
    blink::WebDocumentLoaderImpl::DetachFromFrame()
    blink::FrameLoader::StopAllLoaders()
    blink::LocalFrame::Detach()
    blink::HTMLPlugInElement::DisconnectContentFrame()
    blink::ChildFrameDisconnector::DisconnectCollectedFrameOwners()
    blink::ContainerNode::WillRemoveChild()
    blink::ContainerNode::RemoveChild()
    ...<JavaScript>...
    
    Bug: 860208, 853487, 862088
    Change-Id: Ieb3f0330828f0a031a97d08cdc1ba7de8a3f0edc
    Reviewed-on: https://chromium-review.googlesource.com/1130223
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574661}

    Changed files

    • third_party/WebKit/LayoutTests/fast/loader/detach-while-printing-expected.txt
    • third_party/WebKit/LayoutTests/fast/loader/detach-while-printing.html
    • third_party/blink/renderer/core/loader/frame_loader.cc
  17. Update PDFExtensionTest test expectation.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:06:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision be8ff3e12884ec3188e5fb909b31a62b9412d808

    Comments

    Update PDFExtensionTest test expectation.
    
    After https://pdfium-review.googlesource.com/35432 got rolled into
    Chromium in r570889, a previously failing test case now started passing.
    
    BUG=860757
    
    Change-Id: I998a0ea8a91770bb27d92491a12ac0816f535054
    Reviewed-on: https://chromium-review.googlesource.com/1132633
    Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574660}

    Changed files

    • chrome/browser/pdf/pdf_extension_test.cc
  18. Settings: fix cups printer search field logic.

    Changed by Scott Chen - scottchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:05:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b1fa8446eb300966ba4c7c4e6c02e9f9f86fedc

    Comments

    Settings: fix cups printer search field logic.
    
    An earlier CL (1088163) broke the logic for drop-down search fields in
    CUPS add/edit printer dialog, by setting the searchTerm_ property to the
    wrong value. This CL fixes that issue.
    
    The aforementioned CL also accidentally notifies the parent of the input
    value too often, which is also fixed in this CL.
    
    Tests are added to prevent both regressions in the future.
    
    Bug: 860475
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I3949c01edacc53b5aa0f8b6b25ef57b3acb00577
    Reviewed-on: https://chromium-review.googlesource.com/1132238
    Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574659}

    Changed files

    • chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
    • chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.js
    • chrome/test/data/webui/settings/cups_printer_page_tests.js
  19. Making a menu button component

    Changed by Pedro Amaral - amaralpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:03:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c59b348ffef08cfdca20701f4f54236f9e6e295

    Comments

    Making a menu button component
    
    Pulling the menu button out of the bottom toolbar component into its
    own class.
    
    Bug: 862863
    
    
    Change-Id: Icb2230259d7f1d3ac2f47f3b8ee33e659579ca96
    Reviewed-on: https://chromium-review.googlesource.com/1132423
    Commit-Queue: Pedro Amaral <amaralp@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Matthew Jones <mdjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574658}

    Changed files

    • chrome/android/java/res/layout/menu_button.xml
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarMediator.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarModel.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/MenuButton.java
    • chrome/android/java_sources.gni
  20. [Video Capture] Abstract out V4L2 API calls to an interface

    Changed by Christian Fremerey - chfremerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:59:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dbf002c655a394a5235cef285a40059f8d32d678

    Comments

    [Video Capture] Abstract out V4L2 API calls to an interface
    
    This CL abstracts V4L2 API calls made from Chromium's video capture
    implementation on Linux out to an interface. This is to enable testability of
    the code that makes such calls without requiring heavy-weight solutions such
    as attaching actual hardware or kernel-level emulators.
    
    This CL is a pure refactoring and has no intended function change.
    
    This CL is part of a series, see Design Doc at
    https://docs.google.com/document/d/1ihGDZloUGdDpZ5XfmiI3AcqsSxOP9kOe5GxXOTqpHW4/edit?usp=sharing
    
    Test: capture_unittests with physical camera attached
    Bug: 768887
    Change-Id: I9208f4a61731c8dc5827c1f5f5ef31d078520270
    Reviewed-on: https://chromium-review.googlesource.com/1120856
    Reviewed-by: Emircan Uysaler <emircan@chromium.org>
    Commit-Queue: Christian Fremerey <chfremer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574657}

    Changed files

    • media/capture/BUILD.gn
    • media/capture/video/linux/v4l2_capture_delegate.cc
    • media/capture/video/linux/v4l2_capture_delegate.h
    • media/capture/video/linux/v4l2_capture_delegate_unittest.cc
    • media/capture/video/linux/v4l2_capture_device.h
    • media/capture/video/linux/v4l2_capture_device_impl.cc
    • media/capture/video/linux/v4l2_capture_device_impl.h
    • media/capture/video/linux/video_capture_device_chromeos.cc
    • media/capture/video/linux/video_capture_device_chromeos.h
    • media/capture/video/linux/video_capture_device_factory_linux.cc
    • media/capture/video/linux/video_capture_device_factory_linux.h
    • media/capture/video/linux/video_capture_device_linux.cc
    • media/capture/video/linux/video_capture_device_linux.h
  21. Change DECHECKs to CHECKs in `base::RingBuffer`.

    Changed by Chris Palmer - palmerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:58:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 940e9a3140b1e0b636f185ff65f20226e997d897

    Comments

    Change DECHECKs to CHECKs in `base::RingBuffer`.
    
    Better safe than sorry!
    
    In the process, do some micro-optimization to make the CHECKs as cheap as
    possible.
    
    Bug: 817982
    Change-Id: I2c45d7e773199a12ce4ae34b4a750ac2b66cb7c2
    Reviewed-on: https://chromium-review.googlesource.com/1134486
    Reviewed-by: danakj <danakj@chromium.org>
    Commit-Queue: Chris Palmer <palmer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574656}

    Changed files

    • base/containers/ring_buffer.h
  22. Groups small symbols at the file level

    Changed by Tiger Oakes - tigeroohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 18:57:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5b84bff2c5ba0511930b78e6d864bfb8ef0bb03

    Comments

    Groups small symbols at the file level
    
    Previously, symbols below min_symbol_size were all placed in an
    "(Other)" file entry at the root of the tree. Now, they are placed
    inside their original file entry but grouped together based on type.
    This ensures byte counts are always accurate, even past the root node.
    This is also the only blocker before we can remove the old UI.
    
    Additionally made some changes to improve first-load performance by
    starting tree building as soon as possible.
    
    Bug: 860303
    Change-Id: I02daee8994d9b7b236837b78585ac8a9c3297125
    Reviewed-on: https://chromium-review.googlesource.com/1135193
    Commit-Queue: Tiger Oakes <tigero@google.com>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Reviewed-by: Peter Wen <wnwen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574655}

    Changed files

    • tools/binary_size/libsupersize/html_report.py
    • tools/binary_size/libsupersize/template_tree_view/index.html
    • tools/binary_size/libsupersize/template_tree_view/start-worker.js
    • tools/binary_size/libsupersize/template_tree_view/state.js
    • tools/binary_size/libsupersize/template_tree_view/tree-ui.js
    • tools/binary_size/libsupersize/template_tree_view/tree-worker.js
  23. Convert two crash layout tests to use testharness

    Changed by Xiaocheng Hu - xiaochenghohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:57:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0279bf752fc5d6e5f0df324190ab72d7bc831010

    Comments

    Convert two crash layout tests to use testharness
    
    The following two layout tests are crash tests and don't need text dump:
    - fast/text/editing-text-crash.html
    - fast/text/text-iterator-crash.html
    
    This patch converts them with testharness for better code health.
    
    Change-Id: I528a681bb6a17e2fb9f6122d6ec42f9722a575df
    Reviewed-on: https://chromium-review.googlesource.com/1134594
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Reviewed-by: Yoichi Osato <yoichio@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574654}

    Changed files

    • third_party/WebKit/LayoutTests/fast/text/editing-text-crash-expected.txt
    • third_party/WebKit/LayoutTests/fast/text/editing-text-crash.html
    • third_party/WebKit/LayoutTests/fast/text/text-iterator-crash-expected.txt
    • third_party/WebKit/LayoutTests/fast/text/text-iterator-crash.html
  24. Introduce GetAppShortcutGlobalQueryItems mojo method

    Changed by Weidong Guo - weidonggohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:56:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f70dc791c0f421c6ac340019a9721df97af0da8d

    Comments

    Introduce GetAppShortcutGlobalQueryItems mojo method
    
    The original solution passing all available app shortcuts metadata to
    Chrome has large latency because getting icons is expensive. This CL
    proposes a new API that passes query and maxResults to Android, and
    searching & results num throttling is done in Android as well.
    Android side change is in ag/4432308.
    
    Bug: 842947
    Test: manual test, latency is controlled in tens milliseconds
    
    Change-Id: I48c168ffd56826c10a4b6d5befb995a087f4a0b2
    Reviewed-on: https://chromium-review.googlesource.com/1117893
    Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Yury Khmel <khmel@chromium.org>
    Reviewed-by: Qiang Xu <warx@google.com>
    Commit-Queue: Weidong Guo <weidongg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574653}

    Changed files

    • chrome/browser/ui/app_list/search/arc/arc_app_shortcuts_search_provider.cc
    • chrome/browser/ui/app_list/search/arc/arc_app_shortcuts_search_provider.h
    • chrome/browser/ui/app_list/search/arc/arc_app_shortcuts_search_provider_unittest.cc
    • chrome/browser/ui/app_list/search/search_controller_factory.cc
    • components/arc/common/app.mojom
    • components/arc/test/fake_app_instance.cc
    • components/arc/test/fake_app_instance.h
  25. Always prompt user if opening a download thru extensions with debugger permission

    Changed by Min Qin - qinminohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:55:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a4a89a53791a508896b388b0d818644834c0d6d

    Comments

    Always prompt user if opening a download thru extensions with debugger permission
    
    The user gesture can be faked, so we shouldn't trust it
    
    BUG=854455
    
    Change-Id: Ib42911a77d3f519554a5b9a4c1464ec50e79f268
    Reviewed-on: https://chromium-review.googlesource.com/1135525
    Reviewed-by: Xing Liu <xingliu@chromium.org>
    Commit-Queue: Min Qin <qinmin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574652}

    Changed files

    • chrome/browser/extensions/api/downloads/downloads_api.cc
  26. Check against null frame_ in GetCanonicalUrlForSharing

    Changed by Patrick Noland - pnolandohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 18:50:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dd341220c263993037559e62938d54d5cf091a2c

    Comments

    Check against null frame_ in GetCanonicalUrlForSharing
    
    Bug: 852350
    Change-Id: Ib6c4cc79572d3dad22f663ec61a20bc54f5d7a8f
    Reviewed-on: https://chromium-review.googlesource.com/1117847
    Commit-Queue: Charlie Reis <creis@chromium.org>
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574651}

    Changed files

    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl_browsertest.cc
  27. FrameLoader: move CancelParsing and CheckCompleted earlier

    Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:50:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae5ca38f28d3e136c7def1fe7444afed1db7ea9a

    Comments

    FrameLoader: move CancelParsing and CheckCompleted earlier
    
    This way we do it before creating new provisional loader, which
    will help in the future when there would be no provisional loader.
    
    Added Document::Abort method which encapsulates CancelParsing
    and CheckCompleted and also does not issue undesired DidFinishNavigation.
    
    Bug: 831155
    Change-Id: Ica5d968508d7aed7bb07125702ceeaeb6f389497
    Reviewed-on: https://chromium-review.googlesource.com/1119262
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574650}

    Changed files

    • third_party/WebKit/LayoutTests/http/tests/loading/onreadystatechange-detach-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/loading/onreadystatechange-window-stop.html
    • third_party/blink/renderer/core/dom/document.cc
    • third_party/blink/renderer/core/dom/document.h
    • third_party/blink/renderer/core/loader/frame_loader.cc
  28. [unified-consent] Add unified-consent logic to sync confirmation dialog

    Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:49:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ce72c61e3d03607baa3881262eaf5f9d6a06df67

    Comments

    [unified-consent] Add unified-consent logic to sync confirmation dialog
    
    When unified consent is enabled and the user opts into the new unified
    consent sync dialog, unified-consent is given and all services enabled.
    
    Additional changes:
     - Introduce FakeUnifiedConsentServiceClient
     - Add a builder function that creates a UnifiedConsentService for
     testing, using FakeUnifiedConsentServiceClient
    
    Bug: 862202
    Change-Id: I7c70bc45ebbc561916fd618f0b1850525b2cffe0
    Reviewed-on: https://chromium-review.googlesource.com/1131513
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574649}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc
    • chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.h
    • chrome/browser/ui/webui/signin/dice_turn_sync_on_helper_unittest.cc
    • chrome/browser/unified_consent/unified_consent_service_factory.cc
    • chrome/browser/unified_consent/unified_consent_test_util.cc
    • chrome/browser/unified_consent/unified_consent_test_util.h
    • components/unified_consent/unified_consent_service.cc
    • components/unified_consent/unified_consent_service.h
    • components/unified_consent/unified_consent_service_unittest.cc
  29. Shelf new UI: center items on the total shelf size

    Changed by Manu Cornet - manucornetohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:46:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e2ccd76952b57016daccdd19fde7a54d1719a7b

    Comments

    Shelf new UI: center items on the total shelf size
    
    Bug: 805612
    Change-Id: I9c6e0c0aab7f39681bec850ee18d890a9410990c
    Reviewed-on: https://chromium-review.googlesource.com/1135298
    Commit-Queue: Manu Cornet <manucornet@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574648}

    Changed files

    • ash/shelf/shelf_view.cc
  30. [Unity][Android] Update personalized sign-in promo descriptions

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:43:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1806fde687718fd19118e7a6f09e0d5610239cb5

    Comments

    [Unity][Android] Update personalized sign-in promo descriptions
    
    This CL adds a second set of description strings for personalized
    sign-in promos. This set of strings is shown if UnifiedConsent feature
    is enabled.
    
    Bug: 814728
    Change-Id: I1d90a2ec786397326b6d80011c0de6d31468431b
    Reviewed-on: https://chromium-review.googlesource.com/1131500
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574647}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
    • chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoController.java
    • chrome/android/java/strings/android_chrome_strings.grd
    • chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
  31. [Background Fetch] Fix dispatched event name on failure.

    Changed by Rayan Kanso - rayankansohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:42:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7523f88574031a353b4ce24fa9cb87dfbcc2b11

    Comments

    [Background Fetch] Fix dispatched event name on failure.
    
    TBR=falken@chromium.org
    
    Change-Id: Iba46fbe0eee3a886a847fc259d45e51ecfa81dd1
    Reviewed-on: https://chromium-review.googlesource.com/1135451
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574646}

    Changed files

    • third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc
  32. Fix tabstrip edges not redrawing when entering/leaving single tab mode

    Changed by Tom Anderson - thomasandersonohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:42:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 901634eeb056e61914c0b70b43adff655d156c2b

    Comments

    Fix tabstrip edges not redrawing when entering/leaving single tab mode
    
    BUG=860859
    R=pkasting
    
    Change-Id: I9766d6c175fa6bdd8906c58448bf94ae85a17141
    Reviewed-on: https://chromium-review.googlesource.com/1135512
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574645}

    Changed files

    • chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
  33. [Fuchsia] Update webrunner to quit when sys::Runner is closed.

    Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:33:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c40e749cd5d48a9ee9fd02f822c18857d52b813b

    Comments

    [Fuchsia] Update webrunner to quit when sys::Runner is closed.
    
    appmgr process normally creates a single sys::Runner connection for
    each runner process and then closes it when it no longer needs the
    runner. Updagted webrunner implementation to quit after sys::Runned
    is destroyed.
    
    Bug: 856416
    Change-Id: I071b37093917a932a837eebfdf1f1a6e23e837de
    Reviewed-on: https://chromium-review.googlesource.com/1134415
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574644}

    Changed files

    • base/fuchsia/scoped_service_binding.h
    • base/fuchsia/service_directory_unittest.cc
    • webrunner/app/main.cc
  34. Assistant: Fix the notification type

    Changed by wutao - wutaoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:33:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 94e0357b298de459bbfb9c75942fc8193db16203

    Comments

    Assistant: Fix the notification type
    
    Changed the assistant notification type to SYSTEM_COMPONENT.
    
    Bug: b/79493568
    Test: manual.
    Change-Id: I12bb925f3e430fbd74c518be89aba9bd7d31b871
    Reviewed-on: https://chromium-review.googlesource.com/1135574
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: Tao Wu <wutao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574643}

    Changed files

    • ash/assistant/assistant_notification_controller.cc
  35. Reland "Make NetworkConnectionTracker survive network service crashes and restarts"

    Changed by Helen Li - xunjieliohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:30:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d24ee7bc5a14573a8a761c45222f68efb4bef3b0

    Comments

    Reland "Make NetworkConnectionTracker survive network service crashes and restarts"
    
    This reverts commit 197e9188dc5be69cb34e1ebd67f86a1146439367.
    
    Reason for revert: There is a racy test expectation that causes the test to timeout.
    This CL fixes the test.
    
    Bug: 862883, 821009
    Change-Id: I1cb4d8db6ea3f5c683f95bcc3187f6c6b4d6fdbd
    Reviewed-on: https://chromium-review.googlesource.com/1135290
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Helen Li <xunjieli@chromium.org>
    Commit-Queue: Helen Li <xunjieli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574642}

    Changed files

    • chrome/browser/browser_process_impl.cc
    • chrome/browser/net/network_connection_tracker_browsertest.cc
    • chrome/browser/net/network_quality_tracker_browsertest.cc
    • content/public/browser/network_connection_tracker.cc
    • content/public/browser/network_connection_tracker.h
    • content/public/browser/network_connection_tracker_unittest.cc