Builder GPU FYI Win Clang Builder (dbg)
Build 7458
Results:
Internal Failure
Trigger Info:
| Project | chromium |
| Revision | 0edcdf14a29397ba43d8e303bcf01f04705ed95e |
Execution:
- Source: Task 41a058f4abcb9910
- Bot: swarm768-c4
- Recipe: chromium
Steps and Logfiles:
Show:-
- - no logs -
Build Properties:
| Name | Value | Source |
|---|
Blamelist:
- Alan Cutter (alancutterohnoyoudont@chromium.org)
- Christopher Cameron (ccameronohnoyoudont@chromium.org)
- Peter Kotwicz (pkotwiczohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Shu Chen (shuchenohnoyoudont@google.com)
- Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
Timing:
| Create | Friday, 07-Dec-18 07:17:37 UTC |
| Start | Friday, 07-Dec-18 07:17:41 UTC |
| End | Friday, 07-Dec-18 07:26:13 UTC |
| Pending | 4 secs |
| Execution | 8 mins 32 secs |
All Changes:
-
Revert "Add chrome_proxy.exe target on Windows"
Changed by Alan Cutter - alancutterohnoyoudont@chromium.org Changed at Friday, 07-Dec-18 07:03:46 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0edcdf14a29397ba43d8e303bcf01f04705ed95e Comments
Revert "Add chrome_proxy.exe target on Windows" This reverts commit 86e7ed69a96f03ffcbb6af63d632f7951bf34b28. Reason for revert: Broke Chrome Canary update while the browser is open. Bug: 912716 Original change's description: > Add chrome_proxy.exe target on Windows > > This change adds a new executable to Windows called chrome_proxy.exe which > opens chrome.exe with all arguments forwarded. > > In a future patch bookmark app shortcuts will be updated to point to > chrome_proxy.exe instead of chrome.exe so they don't pick up the > chrome.VisualElementsManifest.xml file when pinned to the Windows 10 > start menu. This fixes a bug where pinned bookmark app shortcuts all > use the Chrome logo instead of their own. > > Bug: 732357 > Change-Id: I551093f6f111041b424d30ec3f829fa6a06a265c > Reviewed-on: https://chromium-review.googlesource.com/c/1362695 > Reviewed-by: Greg Thompson <grt@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614177} TBR=thestig@chromium.org,alancutter@chromium.org,mgiuca@chromium.org,grt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. NOPRESUBMIT=TRUE # TBR doesn't apply because this revert touches an OWNERS file. Bug: 732357 Change-Id: I73cddef3173e3abc22f8c8c4720d84f9a9069ab1 Reviewed-on: https://chromium-review.googlesource.com/c/1366471 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#614632}
Changed files
- chrome/BUILD.gn
- chrome/chrome_proxy/BUILD.gn
- chrome/chrome_proxy/OWNERS
- chrome/chrome_proxy/chrome_proxy.ver
- chrome/chrome_proxy/chrome_proxy_main_win.cc
- chrome/installer/mini_installer/BUILD.gn
- chrome/installer/mini_installer/chrome.release
- chrome/installer/setup/install_worker.cc
- chrome/installer/setup/install_worker.h
- chrome/installer/setup/setup_main.cc
- chrome/installer/util/util_constants.cc
- chrome/installer/util/util_constants.h
- chrome/test/mini_installer/config/chrome_beta_installed.prop
- chrome/test/mini_installer/config/chrome_canary_installed.prop
- chrome/test/mini_installer/config/chrome_dev_installed.prop
- chrome/test/mini_installer/config/chrome_multi_system_installed.prop
- chrome/test/mini_installer/config/chrome_multi_user_installed.prop
- chrome/test/mini_installer/config/chrome_system_installed.prop
- chrome/test/mini_installer/config/chrome_user_installed.prop
- chrome/test/mini_installer/config/previous_chrome_canary_installed.prop
- chrome/test/mini_installer/config/previous_chrome_system_installed.prop
- chrome/test/mini_installer/config/previous_chrome_user_installed.prop
- chrome/tools/build/win/FILES.cfg
-
RemoteMacViews: Wire up menu items and shortcut keys
Changed by Christopher Cameron - ccameronohnoyoudont@chromium.org Changed at Friday, 07-Dec-18 07:00:51 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1c1992d02fa89792498f5e3533772bd65d93973d Comments
RemoteMacViews: Wire up menu items and shortcut keys For menu items and shortcut keys to work, PWA windows need to have the ChromeCommandDispatcherDelegate and BrowserWindowCommandHandler structures set on them. This cannot be done by a method on views_bridge_mac::mojom:: BridgedNativeWidget, because the structures to be created exist in Chrome, which would be a layering violation. Introduce a method to chrome::mojom::AppShim which takes a widget id, creates the ChromeCommandDispatcherDelegate and BrowserWindowCommandHandler, and assigns them to the corresponding BridgedNativeWidgetImpl. Bug: 895169 Change-Id: Ie1d333bec235d7b6101d5b19aa89a74136d54a7a Reviewed-on: https://chromium-review.googlesource.com/c/1364210 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#614631}
Changed files
- chrome/app_shim/app_shim_controller.h
- chrome/app_shim/app_shim_controller.mm
- chrome/browser/apps/app_shim/app_shim_host_mac.cc
- chrome/browser/apps/app_shim/app_shim_host_mac.h
- chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc
- chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm
- chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc
- chrome/browser/apps/app_shim/extension_app_shim_handler_mac.h
- chrome/browser/ui/views/frame/browser_frame_mac.mm
- chrome/common/mac/app_shim.mojom
- ui/views/cocoa/bridged_native_widget_unittest.mm
- ui/views/widget/native_widget_mac.h
-
[Android Tests] Fix several FirstRunIntegrationTests
Changed by Peter Kotwicz - pkotwiczohnoyoudont@chromium.org Changed at Friday, 07-Dec-18 06:57:01 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1ca54644ff73878027d7903ab3bd6288561e68a8 Comments
[Android Tests] Fix several FirstRunIntegrationTests This CL converts several FirstRunIntegrationTests to JUnit tests and re-enables them. BUG=911316 Change-Id: I7aada68234fe9a5cb25ee3bef29538cec537d49a Reviewed-on: https://chromium-review.googlesource.com/c/1362812 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#614630}
Changed files
- chrome/android/java_sources.gni
- chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java
- chrome/android/junit/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationUnitTest.java
-
Roll src/third_party/skia 309f1deddf8e..f3babcd0afb3 (2 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Friday, 07-Dec-18 06:49:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8112997ce464e3fa4ae5ca8e166c7adc1de03e35 Comments
Roll src/third_party/skia 309f1deddf8e..f3babcd0afb3 (2 commits) https://skia.googlesource.com/skia.git/+log/309f1deddf8e..f3babcd0afb3 git log 309f1deddf8e..f3babcd0afb3 --date=short --no-merges --format='%ad %ae %s' 2018-12-07 sergeyu@chromium.org Reland "Add SkFontMgr implementation for Fuchsia" 2018-12-07 reed@google.com Revert "Add SkFontMgr implementation for Fuchsia" Created with: gclient setdep -r src/third_party/skia@f3babcd0afb3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: Ieefefb070c45ba63a5efa3872a75e1d4140b5e41 Reviewed-on: https://chromium-review.googlesource.com/c/1367116 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614629}
Changed files
- DEPS
-
Updates the order of key mappings to match the same as layout rendering in VK.
Changed by Shu Chen - shuchenohnoyoudont@google.com Changed at Friday, 07-Dec-18 06:48:36 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 65054bfdd84984501e8054b2f96edacc1bab93a9 Comments
Updates the order of key mappings to match the same as layout rendering in VK. The modifier importance priority is: Altgr > Shift > Capslock. So if user presses a key with Shift + Altgr + Capslock and the key mapping is not defined for the input method. It will fallback to other key mappings in this order: - Shift + Altgr - Altgr + Capslock - Shift + Capslock - Altgr - Shift - Capslock - Normal Bug: 910049 Change-Id: I3a274ba02671977a075ee27441acf429cf4569cb Reviewed-on: https://chromium-review.googlesource.com/c/1356735 Reviewed-by: Leo Zhang <googleo@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#614628}
Changed files
- chromeos/services/ime/public/cpp/rulebased/def/fa.cc
- chromeos/services/ime/public/cpp/rulebased/def/lo.cc
- chromeos/services/ime/public/cpp/rulebased/def/ta_inscript.cc
- chromeos/services/ime/public/cpp/rulebased/def/ta_phone.cc
- chromeos/services/ime/public/cpp/rulebased/def/th.cc
-
Import wpt@2d0f68b3c512b4ba268b09fac224830f866a5720
Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com Changed at Friday, 07-Dec-18 06:36:58 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b38c320095ae37996d50a735f7d2690c9e0eed10 Comments
Import wpt@2d0f68b3c512b4ba268b09fac224830f866a5720 Using wpt-import in Chromium c71812f1007dae45bce45b451c384bf9c0dbd356. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I379fefc2dcbcf7082675a8eced0893890f23b0ef Reviewed-on: https://chromium-review.googlesource.com/c/1367132 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614627}
Changed files
- third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
- third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-track-stats.https-expected.txt
- third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-track-stats.https.html
- third_party/blink/web_tests/external/wpt/webrtc/legacy/RTCPeerConnection-addStream.https.html
- third_party/blink/web_tests/external/wpt/webrtc/no-media-call.html