Home | Search | chromium - Builders
Login

Builder GPU FYI Win Builder Build 17489 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13
Got Revision5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Tanja Gornak (melandoryohnoyoudont@chromium.org)
  2. Etienne Bergeron (etiennebohnoyoudont@chromium.org)
  3. Ehsan Karamad (ekaramadohnoyoudont@chromium.org)
  4. Sergey Kuznetsov (kuznetsovsohnoyoudont@yandex-team.ru)
  5. Mihai Sardarescu (msardaohnoyoudont@chromium.org)
  6. Matthew Cary (mattcaryohnoyoudont@chromium.org)
  7. Jaeyong Bae (jdragon.baeohnoyoudont@gmail.com)

Timing:

Create Friday, 12-Oct-18 14:40:14 UTC
Start Friday, 12-Oct-18 14:40:19 UTC
End Friday, 12-Oct-18 14:48:38 UTC
Pending 5 secs
Execution 8 mins 19 secs

All Changes:

  1. [Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering.

    Changed by Tanja Gornak - melandoryohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 14:39:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13

    Comments

    [Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering.
    
    * The service shouldn't unregister from the topics, when handler
    the Handler is unregistering from topic (as stated in the documentation
    for for UnregisterHandler).
    * Sync shouldn't unregister on browser shutdown
    
    TBR=gab@chromium.org, pavely@chromium.org
    
    Bug: 894752, 801985
    Change-Id: If676d159ba7d7beeebf325bce2e78b5847da3f76
    Reviewed-on: https://chromium-review.googlesource.com/c/1277908
    Reviewed-by: Tatiana Gornak <melandory@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Commit-Queue: Tatiana Gornak <melandory@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599206}

    Changed files

    • chrome/browser/prefs/browser_prefs.cc
    • components/invalidation/impl/BUILD.gn
    • components/invalidation/impl/fcm_fake_invalidator.cc
    • components/invalidation/impl/fcm_invalidation_listener.cc
    • components/invalidation/impl/fcm_invalidation_listener.h
    • components/invalidation/impl/fcm_invalidation_service.cc
    • components/invalidation/impl/fcm_invalidation_service.h
    • components/invalidation/impl/fcm_invalidation_service_unittest.cc
    • components/invalidation/impl/invalidator_registrar.cc
    • components/invalidation/impl/invalidator_registrar.h
    • components/invalidation/impl/invalidator_registrar_with_memory.cc
    • components/invalidation/impl/invalidator_registrar_with_memory.h
    • components/invalidation/public/invalidation_util.h
    • components/sync/driver/glue/sync_backend_host_impl.cc
  2. Add trace events to investigate pathological fonts loading

    Changed by Etienne Bergeron - etiennebohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 14:33:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3638eaae091158d771e3ac8ce7d45c2ac925fb32

    Comments

    Add trace events to investigate pathological fonts loading
    
    This CL is adding trace events to look closer on some slow cases
    happening in the browser process. Traces will be collected via
    slow-reports and an investigation will be continued based on results of
    these events.
    
    R=fdoray@chromium.org, ccameron@chromium.org
    
    Bug: 894459
    Change-Id: I2e3c37e9a42ceef9ca9aea5ec94a125db247aa77
    Reviewed-on: https://chromium-review.googlesource.com/c/1277825
    Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
    Reviewed-by: ccameron <ccameron@chromium.org>
    Reviewed-by: François Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599205}

    Changed files

    • ui/gfx/render_text_harfbuzz.cc
  3. Apply 'lazyload' feature policy for images

    Changed by Ehsan Karamad - ekaramadohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 14:32:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 03b4fcd98e2647b8560c90b7f650a7f57cff96da

    Comments

    Apply 'lazyload' feature policy for images
    
    In CL 1171374 'lazyload' feature policy was introduced as a new
    policy-controlled feature which would modify (restrict) the usage of the
    lazyload attribute. The implementation only applied the feature to frame
    owner elements. This CL extends the policy's coverage to images as well.
    
    Bug: 869492
    Change-Id: I9a2bd309ac366b75308b657d3ea129a7717ad23f
    Reviewed-on: https://chromium-review.googlesource.com/c/1251024
    Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
    Reviewed-by: Fredrik Söderquist <fs@opera.com>
    Reviewed-by: rajendrant <rajendrant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599204}

    Changed files

    • third_party/WebKit/LayoutTests/NeverFixTests
    • third_party/WebKit/LayoutTests/VirtualTestSuites
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/lazyload/lazyload-disabled-image-tentative.sub.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/lazyload/lazyload-disabled-image-tentative.sub.html.headers
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/lazyload/lazyload-enabled-image-tentative.sub.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/lazyload/lazyload-image-attribute-on-sanity-check-tentative.sub.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/resources/common.js
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/resources/lazyload.png
    • third_party/blink/renderer/core/html/html_image_element.cc
    • third_party/blink/renderer/core/html/parser/html_preload_scanner.cc
    • third_party/blink/renderer/core/html/parser/html_preload_scanner.h
    • third_party/blink/renderer/core/loader/image_loader.cc
  4. Fix possible crash when |change_dispatcher_| gone.

    Changed by Sergey Kuznetsov - kuznetsovsohnoyoudont@yandex-team.ru
    Changed at Friday, 12-Oct-18 14:29:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0edf161ea086a970d14c9946ded919743e693731

    Comments

    Fix possible crash when |change_dispatcher_| gone.
    
    Nothing prevents CookieMonsterChangeDispatcher::Subscription to
    outlive CookieMonsterChangeDispatcher.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Ifa2cd0c8def9ae1c63a0a3d37bd469bbbc78e5ca
    Reviewed-on: https://chromium-review.googlesource.com/c/1242460
    Commit-Queue: Maks Orlovich <morlovich@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Reviewed-by: Maks Orlovich <morlovich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599203}

    Changed files

    • ios/net/cookies/cookie_store_ios.h
    • ios/net/cookies/cookie_store_ios.mm
    • net/cookies/cookie_monster_change_dispatcher.cc
    • net/cookies/cookie_store_change_unittest.h
    • net/cookies/cookie_store_unittest.h
  5. Rename method in token service diagnostic observer for clarity

    Changed by Mihai Sardarescu - msardaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 14:27:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 466b727ac3cd8f967fed05a86562c01616824627

    Comments

    Rename method in token service diagnostic observer for clarity
    
    Bug: NONE
    Change-Id: I18d05d59ba0be38d7598396fab2cef8b44647fcf
    Reviewed-on: https://chromium-review.googlesource.com/c/1278754
    Reviewed-by: Thomas Tangl <tangltom@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599202}

    Changed files

    • components/signin/core/browser/about_signin_internals.cc
    • components/signin/core/browser/about_signin_internals.h
    • google_apis/gaia/oauth2_token_service.cc
    • google_apis/gaia/oauth2_token_service.h
  6. Orderfile: skip madvise if ordering has not been done.

    Changed by Matthew Cary - mattcaryohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 14:19:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ea3132cbbc836b398e523438627cc27349505196

    Comments

    Orderfile: skip madvise if ordering has not been done.
    
    Change a CHECK to an logged warning if madvise is attempted when code
    ordering has not been performed. This happens on upstream builds
    including arm64 builds.
    
    Bug: 894748
    Change-Id: Icdb7ae0c94cfad5beec0215c6186e29135c1079a
    Reviewed-on: https://chromium-review.googlesource.com/c/1278746
    Reviewed-by: Egor Pasko <pasko@chromium.org>
    Reviewed-by: Matthew Cary <mattcary@chromium.org>
    Reviewed-by: Benoit L <lizeb@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Matthew Cary <mattcary@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599201}

    Changed files

    • base/android/library_loader/library_prefetcher.cc
  7. Remove prefs::kReverseAutologinEnabled & DisableOneClickSignIn

    Changed by Jaeyong Bae - jdragon.baeohnoyoudont@gmail.com
    Changed at Friday, 12-Oct-18 14:12:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6e7d226c7a576e4b90de8460df4f11cff2e3cd0a

    Comments

    Remove prefs::kReverseAutologinEnabled & DisableOneClickSignIn
    
    This patch means removing the preference and functions
    that reference it.
    Because preference is set but never read, that is indeed obsolete.
    
    Bug: 889908
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I22a80bed2387b08480dae9c930bb1d329dd8c45d
    Reviewed-on: https://chromium-review.googlesource.com/c/1264343
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599200}

    Changed files

    • chrome/browser/prefs/browser_prefs.cc
    • chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
    • components/signin/core/browser/signin_manager.cc
    • components/signin/core/browser/signin_manager.h
    • components/signin/core/browser/signin_manager_base.cc
    • components/signin/core/browser/signin_pref_names.cc
    • components/signin/core/browser/signin_pref_names.h
    • ios/chrome/browser/prefs/browser_prefs.mm