Home | Search | chromium - Builders
Login

Builder GPU FYI Linux Ozone Builder Build 28741 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision550a880d7628b63df3bddfa634a17b915f88c85b
Got Revision550a880d7628b63df3bddfa634a17b915f88c85b

Execution:

Steps and Logfiles:

Show:
  1. ( 0 ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. tzik (tzikohnoyoudont@chromium.org)
  2. Patrick Monette (pmonetteohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 21:31:18 UTC
Start Thursday, 12-Jul-18 21:31:21 UTC
End Thursday, 12-Jul-18 21:33:22 UTC
Pending 3 secs
Execution 2 mins 1 secs

All Changes:

  1. Replace base::Timer with behavior-specific timers in //chrome and //ui

    Changed by tzik - tzikohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 21:29:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 550a880d7628b63df3bddfa634a17b915f88c85b

    Comments

    Replace base::Timer with behavior-specific timers in //chrome and //ui
    
    This CL replaces base::Timer with its subclasses.
    As base::Timer changes its behavior subject to its construction time
    flags, that makes hard to see the actual timer behavior, especially
    it's unclear when a timer is injected from other components.
    Also, that OnceCallback support of base::Timer is hard to implement on
    the dynamically determined invocation pattern.
    
    Bug: 850247
    Change-Id: I842cb4ffc6eeb2715b7abd710a232230fae627bf
    Reviewed-on: https://chromium-review.googlesource.com/1128779
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574729}

    Changed files

    • chrome/browser/conflicts/module_blacklist_cache_updater_win.cc
    • chrome/browser/conflicts/module_blacklist_cache_updater_win.h
    • chrome/browser/conflicts/module_database_win.cc
    • chrome/browser/conflicts/module_database_win.h
    • chrome/browser/google/google_search_domain_mixing_metrics_emitter.cc
    • chrome/browser/google/google_search_domain_mixing_metrics_emitter.h
    • chrome/browser/notifications/notification_permission_context.cc
    • chrome/browser/profiles/profile_destroyer.cc
    • chrome/browser/profiles/profile_destroyer.h
    • chrome/browser/speech/speech_recognizer.cc
    • chrome/browser/task_manager/task_manager_interface.cc
    • chrome/browser/task_manager/task_manager_interface.h
    • chrome/browser/ui/bookmarks/bookmark_browsertest.cc
    • chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
    • chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_animation_controller.h
    • chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_animation_controller.mm
    • chrome/browser/ui/hung_plugin_tab_helper.cc
    • chrome/browser/ui/media_router/media_router_ui_base.cc
    • chrome/browser/ui/views/confirm_quit_bubble_controller.cc
    • chrome/browser/ui/views/confirm_quit_bubble_controller.h
    • chrome/browser/ui/views/confirm_quit_bubble_controller_unittest.cc
    • chrome/browser/ui/views/tabs/tab_drag_controller.cc
    • chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
    • chrome/browser/ui/views/toolbar/browser_app_menu_button.h
    • ui/display/mac/screen_mac.mm
    • ui/views/animation/ink_drop_impl.cc
    • ui/views/controls/scroll_view_unittest.cc
    • ui/views/controls/scrollbar/base_scroll_bar.cc
    • ui/views/controls/scrollbar/base_scroll_bar.h
    • ui/views/controls/scrollbar/cocoa_scroll_bar.h
    • ui/views/controls/scrollbar/cocoa_scroll_bar.mm
    • ui/views/controls/scrollbar/overlay_scroll_bar.cc
    • ui/views/controls/scrollbar/overlay_scroll_bar.h
  2. Add OnKnownModuleLoaded to ModuleDatabaseObserver

    Changed by Patrick Monette - pmonetteohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 21:29:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0582b161a84a9168d78f3725cfbaa3e6a009961b

    Comments

    Add OnKnownModuleLoaded to ModuleDatabaseObserver
    
    This will be used by the IncompatibleApplicationsUpdater and
    ModuleBlacklistCacheUpdater instances to re-analyze a module when it
    loads into the process.
    
    Bug: 846953
    Change-Id: I327fce954cc281dd312732823ef168a4086ea787
    Reviewed-on: https://chromium-review.googlesource.com/1135634
    Reviewed-by: Chris Hamilton <chrisha@chromium.org>
    Commit-Queue: Patrick Monette <pmonette@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574728}

    Changed files

    • chrome/browser/conflicts/module_database_observer_win.h
    • chrome/browser/conflicts/module_database_win.cc
    • chrome/browser/conflicts/module_database_win.h
    • chrome/browser/conflicts/module_database_win_unittest.cc