Builder Chromium Mac 10.13
Build 6517
Results:
Failure boringssl_crypto_tests on Intel GPU on Mac Failure chrome_app_unittests on Intel GPU on Mac Failure blink_common_unittests on Intel GPU on Mac Failure angle_unittests on Intel GPU on Mac Failure cc_unittests on Intel GPU on Mac Failure app_shell_unittests on Intel GPU on Mac Failure accessibility_unittests on Intel GPU on Mac Failure content_browsertests on Intel GPU on Mac Failure cast_unittests on Intel GPU on Mac Failure base_unittests on Intel GPU on Mac Failure components_browsertests on Intel GPU on Mac Failure components_unittests on Intel GPU on Mac Failure blink_fuzzer_unittests on Intel GPU on Mac Failure non_viz_browser_tests on Intel GPU on Mac Failure capture_unittests on Intel GPU on Mac Failure cacheinvalidation_unittests on Intel GPU on Mac Failure browser_tests on Intel GPU on Mac Failure boringssl_ssl_tests on Intel GPU on Mac Failure chromedriver_unittests on Intel GPU on Mac Failure webui_polymer2_browser_tests on Intel GPU on Mac Failure blink_heap_unittests on Intel GPU on Mac Failure blink_platform_unittests on Intel GPU on Mac Failure extensions_unittests on Intel GPU on Mac Failure media_blink_unittests on Intel GPU on Mac Failure libjingle_xmpp_unittests on Intel GPU on Mac Failure extensions_browsertests on Intel GPU on Mac Failure viz_content_browsertests on Intel GPU on Mac Failure media_service_unittests on Intel GPU on Mac Failure webui_polymer2_interactive_ui_tests on Intel GPU on Mac Failure display_unittests on Intel GPU on Mac Failure google_apis_unittests on Intel GPU on Mac Failure viz_content_unittests on Intel GPU on Mac Failure device_unittests on Intel GPU on Mac Failure non_viz_content_browsertests on Intel GPU on Mac Failure crypto_unittests on Intel GPU on Mac Failure cronet_tests on Intel GPU on Mac Failure crashpad_tests on Intel GPU on Mac Failure perfetto_content_browsertests on Intel GPU on Mac Failure content_unittests on Intel GPU on Mac Failure gpu_unittests on Intel GPU on Mac Failure latency_unittests on Intel GPU on Mac Failure gfx_unittests on Intel GPU on Mac Failure cronet_unittests on Intel GPU on Mac Failure network_service_headless_browsertests on Intel GPU on Mac Failure filesystem_service_unittests on Intel GPU on Mac Failure jingle_unittests on Intel GPU on Mac Failure gcm_unit_tests on Intel GPU on Mac Failure events_unittests on Intel GPU on Mac Failure headless_browsertests on Intel GPU on Mac Failure gin_unittests on Intel GPU on Mac Failure leveldb_service_unittests on Intel GPU on Mac Failure headless_unittests on Intel GPU on Mac Failure non_viz_content_unittests on Intel GPU on Mac Failure interactive_ui_tests on Intel GPU on Mac Failure ipc_tests on Intel GPU on Mac Failure unit_tests on Intel GPU on Mac Failure views_perftests on Intel GPU on Mac Failure url_unittests on Intel GPU on Mac Failure storage_unittests on Intel GPU on Mac Failure telemetry_unittests on Intel GPU on Mac Failure webkit_unit_tests on Intel GPU on Mac Failure ui_base_unittests on Intel GPU on Mac Failure views_unittests on Intel GPU on Mac Failure ui_touch_selection_unittests on Intel GPU on Mac Failure viz_unittests on Intel GPU on Mac Failure sync_integration_tests on Intel GPU on Mac Failure midi_unittests on Intel GPU on Mac Failure remoting_unittests on Intel GPU on Mac Failure services_unittests on Intel GPU on Mac Failure snapshot_unittests on Intel GPU on Mac Failure ppapi_unittests on Intel GPU on Mac Failure mojo_unittests on Intel GPU on Mac Failure telemetry_gpu_unittests on Intel GPU on Mac Failure chromedriver_replay_unittests on Intel GPU on Mac Failure service_manager_unittests on Intel GPU on Mac Failure native_theme_unittests on Intel GPU on Mac Failure chromedriver_py_tests on Intel GPU on Mac Failure skia_unittests on Intel GPU on Mac Failure wtf_unittests on Intel GPU on Mac Failure pdf_unittests on Intel GPU on Mac Failure net_unittests on Intel GPU on Mac Failure telemetry_perf_unittests on Intel GPU on Mac Failure media_unittests on Intel GPU on Mac Failure printing_unittests on Intel GPU on Mac Failure content_shell_crash_test on Intel GPU on Mac Failure nacl_loader_unittests on Intel GPU on Mac Failure sandbox_mac_unittests on Intel GPU on Mac Failure shell_dialogs_unittests on Intel GPU on Mac Failure sql_unittests on Intel GPU on Mac Failure webkit_python_tests on Intel GPU on Mac Failure message_center_unittests on Intel GPU on Mac Failure components_perftests on Intel GPU on Mac
Trigger Info:
Project | chromium |
Revision | 4f89d4e9f1855a53eb25c055b97cc85ee4fe3172 |
Got Revision | 4f89d4e9f1855a53eb25c055b97cc85ee4fe3172 |
Execution:
- Source: Task 42f77da585735f10
- Bot: build226-m9
- Recipe: chromium
Steps and Logfiles:
Show:-
- - no logs -
-
( 1 secs ) read test spec (chromium.fyi.json)path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.fyi.json
-
( 435 ms ) lookup GN argsis_component_build = falseis_debug = falsestrip_absolute_paths_from_debug_symbols = trueuse_goma = truegoma_dir = "/b/s/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
( 995 ms ) [trigger] network_service_headless_browsertests on Intel GPU on MacRun on OS: 'Mac-10.13'
-
- - no logs -
-
( 1 secs ) metrics_python_tests on Intel GPU on MacRun on OS: 'Mac-10.13'Shard duration: 9sTotal tests: 74* Passed: 74 (74 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- stdout
- some shards did not complete: 0, 1, 2, 3, 4, 5
- swarming.summary
- Merge script log
- step_metadata
- shard #0 expired, not enough capacity
- shard #1 expired, not enough capacity
- shard #2 expired, not enough capacity
- shard #3 expired, not enough capacity
- shard #4 expired, not enough capacity
- shard #5 expired, not enough capacity
- missing shard #0
- missing shard #1
- missing shard #2
- missing shard #3
- missing shard #4
- missing shard #5
-
- stdout
- some shards did not complete: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- swarming.summary
- Merge script log
- step_metadata
- shard #0 expired, not enough capacity
- shard #1 expired, not enough capacity
- shard #2 expired, not enough capacity
- shard #3 expired, not enough capacity
- shard #4 expired, not enough capacity
- shard #5 expired, not enough capacity
- shard #6 expired, not enough capacity
- shard #7 expired, not enough capacity
- shard #8 expired, not enough capacity
- shard #9 expired, not enough capacity
- missing shard #0
- missing shard #1
- missing shard #2
- missing shard #3
- missing shard #4
- missing shard #5
- missing shard #6
- missing shard #7
- missing shard #8
- missing shard #9
-
- stdout
- some shards did not complete: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- swarming.summary
- Merge script log
- step_metadata
- shard #0 expired, not enough capacity
- shard #1 expired, not enough capacity
- shard #2 expired, not enough capacity
- shard #3 expired, not enough capacity
- shard #4 expired, not enough capacity
- shard #5 expired, not enough capacity
- shard #6 expired, not enough capacity
- shard #7 expired, not enough capacity
- shard #8 expired, not enough capacity
- shard #9 expired, not enough capacity
- missing shard #0
- missing shard #1
- missing shard #2
- missing shard #3
- missing shard #4
- missing shard #5
- missing shard #6
- missing shard #7
- missing shard #8
- missing shard #9
-
- stdout
- some shards did not complete: 0, 1, 2, 3
- swarming.summary
- Merge script log
- step_metadata
- shard #0 expired, not enough capacity
- shard #1 expired, not enough capacity
- shard #2 expired, not enough capacity
- shard #3 expired, not enough capacity
- missing shard #0
- missing shard #1
- missing shard #2
- missing shard #3
-
- stdout
- some shards did not complete: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- swarming.summary
- Merge script log
- step_metadata
- shard #0 expired, not enough capacity
- shard #1 expired, not enough capacity
- shard #2 expired, not enough capacity
- shard #3 expired, not enough capacity
- shard #4 expired, not enough capacity
- shard #5 expired, not enough capacity
- shard #6 expired, not enough capacity
- shard #7 expired, not enough capacity
- shard #8 expired, not enough capacity
- shard #9 expired, not enough capacity
- missing shard #0
- missing shard #1
- missing shard #2
- missing shard #3
- missing shard #4
- missing shard #5
- missing shard #6
- missing shard #7
- missing shard #8
- missing shard #9
-
- stdout
- some shards did not complete: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- swarming.summary
- Merge script log
- step_metadata
- shard #0 expired, not enough capacity
- shard #1 expired, not enough capacity
- shard #2 expired, not enough capacity
- shard #3 expired, not enough capacity
- shard #4 expired, not enough capacity
- shard #5 expired, not enough capacity
- shard #6 expired, not enough capacity
- shard #7 expired, not enough capacity
- shard #8 expired, not enough capacity
- shard #9 expired, not enough capacity
- missing shard #0
- missing shard #1
- missing shard #2
- missing shard #3
- missing shard #4
- missing shard #5
- missing shard #6
- missing shard #7
- missing shard #8
- missing shard #9
-
- stdout
- json.output
- swarming.summary
- Merge script log
- outdir_json
- step_metadata
- shard #0 expired, not enough capacity
- shard #1 expired, not enough capacity
- shard #2 expired, not enough capacity
- shard #3 expired, not enough capacity
- shard #4 expired, not enough capacity
- shard #5 expired, not enough capacity
- shard #6 expired, not enough capacity
- shard #7 expired, not enough capacity
- shard #8 expired, not enough capacity
- shard #9 expired, not enough capacity
- shard #10 expired, not enough capacity
- shard #11 expired, not enough capacity
- missing shard #0
- missing shard #1
- missing shard #2
- missing shard #3
- missing shard #4
- missing shard #5
- missing shard #6
- missing shard #7
- missing shard #8
- missing shard #9
- missing shard #10
- missing shard #11
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/buildbucket | {"build": {"builder": {"bucket": "ci", "builder": "Chromium Mac 10.13", "project": "chromium"}, "createTime": "2019-02-11T22:27:27.705568Z", "createdBy": "user:luci-scheduler@appspot.gserviceaccount.com", "id": "8921780557711650768", "infra": {"buildbucket": {"serviceConfigRevision": "ef156230f5cd7f8c23f689fa4dc7f92742cd904d"}, "recipe": {"cipdPackage": "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build", "name": "chromium"}, "swarming": {"hostname": "chromium-swarm.appspot.com"}}, "input": {"gitilesCommit": {"host": "chromium.googlesource.com", "id": "4f89d4e9f1855a53eb25c055b97cc85ee4fe3172", "project": "chromium/src", "ref": "refs/heads/master"}}, "number": 6517, "tags": [{"key": "builder", "value": "Chromium Mac 10.13"}, {"key": "buildset", "value": "commit/git/4f89d4e9f1855a53eb25c055b97cc85ee4fe3172"}, {"key": "buildset", "value": "commit/gitiles/chromium.googlesource.com/chromium/src/+/4f89d4e9f1855a53eb25c055b97cc85ee4fe3172"}, {"key": "scheduler_invocation_id", "value": "9087210620055366048"}, {"key": "scheduler_job_id", "value": "chromium/Chromium Mac 10.13"}, {"key": "user_agent", "value": "luci-scheduler"}]}} | setup_build |
$recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "build226-m9" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1549924047705568, "id": "8921780557711650768", "project": "chromium", "tags": ["build_address:luci.chromium.ci/Chromium Mac 10.13/6517", "builder:Chromium Mac 10.13", "buildset:commit/git/4f89d4e9f1855a53eb25c055b97cc85ee4fe3172", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/4f89d4e9f1855a53eb25c055b97cc85ee4fe3172", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9087210620055366048", "scheduler_job_id:chromium/Chromium Mac 10.13", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "Chromium Mac 10.13" | setup_build |
buildnumber | 6517 | setup_build |
mastername | "chromium.fyi" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
repository | "https://chromium.googlesource.com/chromium/src.git" | setup_build |
revision | "4f89d4e9f1855a53eb25c055b97cc85ee4fe3172" | setup_build |
got_angle_revision | "0029dfe28cf4ed9e6fa0928a632063f4b72b63f1" | bot_update |
got_dawn_revision | "3b71e65658cdb3dd5c8455241e3a5b8576b5b1dc" | bot_update |
got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
got_revision | "4f89d4e9f1855a53eb25c055b97cc85ee4fe3172" | bot_update |
got_revision_cp | "refs/heads/master@{#630957}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "0e223be0fe07b0ae6eceb58b48cb1719c39db14e" | bot_update |
got_v8_revision_cp | "refs/heads/7.4.137@{#1}" | bot_update |
got_webrtc_revision | "f13c2cd9ee41f4ca572232a4e397b05449474632" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26626}" | bot_update |
got_clang_revision | "353250-1" | clang_revision |
isolate_server | "https://isolateserver.appspot.com" | isolate tests |
swarm_hashes_refs/heads/master(at){#630957}_without_patch | {"accessibility_unittests": "d6289a0b33cce7978d004ac0516b17fa265cf0c0", "angle_unittests": "f5371f77a261a850b50bf1ed0996fc6ae2877ef1", "app_shell_unittests": "77f2f7ac18d1145af94258a6c994d678c554d98c", "base_unittests": "b0879109d27df53489fcd0e8d6ec621182efc6ab", "blink_common_unittests": "7fd6e0ef6be0e0d29fe6e39e95cfbc018678ef83", "blink_fuzzer_unittests": "b9de042060cfedb994f4f68a1ef673be2cea361c", "blink_heap_unittests": "875c70182a64d6c21cdfafd39a0e0bc01ae9f97c", "blink_platform_unittests": "ce8804a6068d6a17b58a10cb64ed3273ac6473fc", "boringssl_crypto_tests": "d9a78e16a5d6496d52d59ad76a3dc75c09aad151", "boringssl_ssl_tests": "e65506ffe268c2a3314d579df76368ce7325da3d", "browser_tests": "71651cfaaae3e15c7a916ff0912db9190490e35c", "cacheinvalidation_unittests": "9b372391e538184f2b382d56c4d1832ba0b25326", "capture_unittests": "c7d957bb0545f487da2d05090fe1b3dc369451f9", "cast_unittests": "4ece311273142e292b1537886eaf302dacee50e6", "cc_unittests": "51d442aa724b6a2cddaeff9e148c1fd3a963b288", "chrome_app_unittests": "2d99ca7a5d2c96a8a4f74da412328ac31475108e", "chromedriver_py_tests": "abddf32246544217d2d20cd8bc0e0338c496ca9c", "chromedriver_replay_unittests": "af039ee07397b927108951882aeb91eeff012f68", "chromedriver_unittests": "c74a502c4988c3f3f24e215cc095648f8e95df26", "components_browsertests": "42dc86df5353bb3f97a783049b248eae5818eebe", "components_perftests": "2267f7e296e0dff6915b41a93ba9acefa5c97385", "components_unittests": "13c6691f90723a5ff5eeb36f63e1e409e124f521", "content_browsertests": "7ab0b94134e8183d6d33dc965be86b6d198cabc8", "content_shell_crash_test": "cd460b6f150d0e198780a811afe2782cc0bea550", "content_unittests": "151bfa83f971ce7c32d623b6dd0ac33a645eadeb", "crashpad_tests": "c80aa59f32747b91c5770c9abaa5703aa41e3898", "cronet_tests": "50f61f680df8c5430dca60550c5f48727bf94110", "cronet_unittests": "df9109427356a934536413fd833d76a20f2f6c27", "crypto_unittests": "cb8fe799f4be68d179558c26c92bfaa5829a8d96", "device_unittests": "4e00b884fc796d766634bd4b57068915c1f3ccd1", "display_unittests": "7567e4cc9414a2c8c58ffdf0ef7beaf87ab0fb45", "events_unittests": "052bef11a3c4a9dab269a7054a12a84d594751e0", "extensions_browsertests": "b7a086a506269009fc3ffee21ff785af2a782fc6", "extensions_unittests": "c52b4345d8f4e78a9c94140001b3513d28ae38e2", "filesystem_service_unittests": "2dc9dbd2cca7cc716b64fb770f10319e766caa6c", "gcm_unit_tests": "5a10a83b215a215acd37f0d0763fd85e8f095e9a", "gfx_unittests": "f54e00c19def6d021215bb847f8f347e03d23650", "gin_unittests": "943b31629e8498ba393428a53c53763bc2321061", "google_apis_unittests": "49d58a3ac64904bf0319aeb96a28108675dabb95", "gpu_unittests": "bac87f73ba88b43bb2a7382d3390945b539188a5", "headless_browsertests": "20f989f12c29851b03ae1efbe1659af88afcbbdc", "headless_unittests": "fab5f56b5e1aa784d63ffc368c482d85e366a22f", "interactive_ui_tests": "711e724670cfeb20761ceffe78eccf026f18f0d9", "ipc_tests": "882fb364fdf0a5e5251037c99491f6c80830301f", "jingle_unittests": "f8994b2c8c4ab88f297a1d38f300542196159e4e", "latency_unittests": "df27238964b24bb1a1d4da1d71d3d4ca6316549a", "leveldb_service_unittests": "2d272a8dcf2e5de6948e574527debfef27533d00", "libjingle_xmpp_unittests": "bc3d63479e49f8bf582503866838903ef416f8ed", "media_blink_unittests": "53e0e08fd83ec553d2a09a34be2b2f741dd78b93", "media_service_unittests": "6303cfd0c942af5247f173675bd65507a92611da", "media_unittests": "c18e6c9715d31ad8601217e9c50e75970e6755b4", "message_center_unittests": "9705270febe96d4aaa09da772fe5b7ac1f1b3183", "metrics_python_tests": "f238e9436fb92af0236d9e001f43acabc8897c68", "midi_unittests": "b0b4827ca20ad7f90cabeafeb2d00403e3d3e791", "mojo_unittests": "649355dfc6c5456b51c83205099de632b17189a5", "nacl_loader_unittests": "7b0bc0871c4545d4e392cbf0063ffdd1e0a211fd", "native_theme_unittests": "23333a683e8fb43dc85f628de22751ae2b61ce5a", "net_unittests": "cd616dc12997cbd1e0dbedc103211ae910480477", "pdf_unittests": "6f11dc327e95765f4e7b7666302688035e93c7cf", "ppapi_unittests": "e36f4b138dd6f4243cf7f607306cb421daa13511", "printing_unittests": "ec8b7b281572baa3fed2a729b1600fbb3dc76057", "remoting_unittests": "a8b6b4ebf2963eb7e042cdaf7a0547058fc3a5ca", "sandbox_mac_unittests": "52fe9a7f4d31609aea43b29e73a132bb6f00655c", "service_manager_unittests": "f83c233e52d5ea99192f8f6b9bb37da208e607f8", "services_unittests": "669e49791f23030a08b8c1aea6852c9f83295185", "shell_dialogs_unittests": "3afc091ced2d92c6e6d16d1c918fbe07e84fb225", "skia_unittests": "3c695083a4044d8c5f4b566a7c5692d17cc0b9e8", "snapshot_unittests": "c36eef2bec323f4343659f536c9d3b5bc90f36a2", "sql_unittests": "3956520bd7c587d2ff5e5e405a0a18cf092db1be", "storage_unittests": "74350c79bb06227ad330a84db56126591142b4d4", "sync_integration_tests": "b219a8ddae0fa6bf9c5a1a09e1479073b8e7b905", "telemetry_gpu_unittests": "7846826285da44d05e61f2c1c483d34b81705610", "telemetry_perf_unittests": "3ccea043ab74029ed115d6d51ca10a8b4fe1b60d", "telemetry_unittests": "6037c22ab6d06be35ab8f86b27fbaad2c2eb2031", "ui_base_unittests": "dc30d90e2825600021981708a3893dfe465c4d6d", "ui_touch_selection_unittests": "b2f1e1ab110462e0fc5bb8befc7f48a2f0562023", "unit_tests": "6cf981b5dac5226885e87cdda6a68655ba76096e", "url_unittests": "f2574de77849016e83bbf1769bcc14bdfe91441f", "views_perftests": "6733b25d50dd53b196911e24998a55aa22858b45", "views_unittests": "0ac5fd3ac6a8dd6290586675f7d285e11ef229f6", "viz_unittests": "19e7c3940099e94e7017d75921814bc245405a33", "webkit_python_tests": "5622a24a805556cdd3ece27ba06521309cbd2b90", "webkit_unit_tests": "204e2eebad5dc00b4cad342342721869c774e651", "wtf_unittests": "eb622e86af816626fe1b71328259668904538499"} | isolate tests |
swarm_hashes | {"accessibility_unittests": "d6289a0b33cce7978d004ac0516b17fa265cf0c0", "angle_unittests": "f5371f77a261a850b50bf1ed0996fc6ae2877ef1", "app_shell_unittests": "77f2f7ac18d1145af94258a6c994d678c554d98c", "base_unittests": "b0879109d27df53489fcd0e8d6ec621182efc6ab", "blink_common_unittests": "7fd6e0ef6be0e0d29fe6e39e95cfbc018678ef83", "blink_fuzzer_unittests": "b9de042060cfedb994f4f68a1ef673be2cea361c", "blink_heap_unittests": "875c70182a64d6c21cdfafd39a0e0bc01ae9f97c", "blink_platform_unittests": "ce8804a6068d6a17b58a10cb64ed3273ac6473fc", "boringssl_crypto_tests": "d9a78e16a5d6496d52d59ad76a3dc75c09aad151", "boringssl_ssl_tests": "e65506ffe268c2a3314d579df76368ce7325da3d", "browser_tests": "71651cfaaae3e15c7a916ff0912db9190490e35c", "cacheinvalidation_unittests": "9b372391e538184f2b382d56c4d1832ba0b25326", "capture_unittests": "c7d957bb0545f487da2d05090fe1b3dc369451f9", "cast_unittests": "4ece311273142e292b1537886eaf302dacee50e6", "cc_unittests": "51d442aa724b6a2cddaeff9e148c1fd3a963b288", "chrome_app_unittests": "2d99ca7a5d2c96a8a4f74da412328ac31475108e", "chromedriver_py_tests": "abddf32246544217d2d20cd8bc0e0338c496ca9c", "chromedriver_replay_unittests": "af039ee07397b927108951882aeb91eeff012f68", "chromedriver_unittests": "c74a502c4988c3f3f24e215cc095648f8e95df26", "components_browsertests": "42dc86df5353bb3f97a783049b248eae5818eebe", "components_perftests": "2267f7e296e0dff6915b41a93ba9acefa5c97385", "components_unittests": "13c6691f90723a5ff5eeb36f63e1e409e124f521", "content_browsertests": "7ab0b94134e8183d6d33dc965be86b6d198cabc8", "content_shell_crash_test": "cd460b6f150d0e198780a811afe2782cc0bea550", "content_unittests": "151bfa83f971ce7c32d623b6dd0ac33a645eadeb", "crashpad_tests": "c80aa59f32747b91c5770c9abaa5703aa41e3898", "cronet_tests": "50f61f680df8c5430dca60550c5f48727bf94110", "cronet_unittests": "df9109427356a934536413fd833d76a20f2f6c27", "crypto_unittests": "cb8fe799f4be68d179558c26c92bfaa5829a8d96", "device_unittests": "4e00b884fc796d766634bd4b57068915c1f3ccd1", "display_unittests": "7567e4cc9414a2c8c58ffdf0ef7beaf87ab0fb45", "events_unittests": "052bef11a3c4a9dab269a7054a12a84d594751e0", "extensions_browsertests": "b7a086a506269009fc3ffee21ff785af2a782fc6", "extensions_unittests": "c52b4345d8f4e78a9c94140001b3513d28ae38e2", "filesystem_service_unittests": "2dc9dbd2cca7cc716b64fb770f10319e766caa6c", "gcm_unit_tests": "5a10a83b215a215acd37f0d0763fd85e8f095e9a", "gfx_unittests": "f54e00c19def6d021215bb847f8f347e03d23650", "gin_unittests": "943b31629e8498ba393428a53c53763bc2321061", "google_apis_unittests": "49d58a3ac64904bf0319aeb96a28108675dabb95", "gpu_unittests": "bac87f73ba88b43bb2a7382d3390945b539188a5", "headless_browsertests": "20f989f12c29851b03ae1efbe1659af88afcbbdc", "headless_unittests": "fab5f56b5e1aa784d63ffc368c482d85e366a22f", "interactive_ui_tests": "711e724670cfeb20761ceffe78eccf026f18f0d9", "ipc_tests": "882fb364fdf0a5e5251037c99491f6c80830301f", "jingle_unittests": "f8994b2c8c4ab88f297a1d38f300542196159e4e", "latency_unittests": "df27238964b24bb1a1d4da1d71d3d4ca6316549a", "leveldb_service_unittests": "2d272a8dcf2e5de6948e574527debfef27533d00", "libjingle_xmpp_unittests": "bc3d63479e49f8bf582503866838903ef416f8ed", "media_blink_unittests": "53e0e08fd83ec553d2a09a34be2b2f741dd78b93", "media_service_unittests": "6303cfd0c942af5247f173675bd65507a92611da", "media_unittests": "c18e6c9715d31ad8601217e9c50e75970e6755b4", "message_center_unittests": "9705270febe96d4aaa09da772fe5b7ac1f1b3183", "metrics_python_tests": "f238e9436fb92af0236d9e001f43acabc8897c68", "midi_unittests": "b0b4827ca20ad7f90cabeafeb2d00403e3d3e791", "mojo_unittests": "649355dfc6c5456b51c83205099de632b17189a5", "nacl_loader_unittests": "7b0bc0871c4545d4e392cbf0063ffdd1e0a211fd", "native_theme_unittests": "23333a683e8fb43dc85f628de22751ae2b61ce5a", "net_unittests": "cd616dc12997cbd1e0dbedc103211ae910480477", "pdf_unittests": "6f11dc327e95765f4e7b7666302688035e93c7cf", "ppapi_unittests": "e36f4b138dd6f4243cf7f607306cb421daa13511", "printing_unittests": "ec8b7b281572baa3fed2a729b1600fbb3dc76057", "remoting_unittests": "a8b6b4ebf2963eb7e042cdaf7a0547058fc3a5ca", "sandbox_mac_unittests": "52fe9a7f4d31609aea43b29e73a132bb6f00655c", "service_manager_unittests": "f83c233e52d5ea99192f8f6b9bb37da208e607f8", "services_unittests": "669e49791f23030a08b8c1aea6852c9f83295185", "shell_dialogs_unittests": "3afc091ced2d92c6e6d16d1c918fbe07e84fb225", "skia_unittests": "3c695083a4044d8c5f4b566a7c5692d17cc0b9e8", "snapshot_unittests": "c36eef2bec323f4343659f536c9d3b5bc90f36a2", "sql_unittests": "3956520bd7c587d2ff5e5e405a0a18cf092db1be", "storage_unittests": "74350c79bb06227ad330a84db56126591142b4d4", "sync_integration_tests": "b219a8ddae0fa6bf9c5a1a09e1479073b8e7b905", "telemetry_gpu_unittests": "7846826285da44d05e61f2c1c483d34b81705610", "telemetry_perf_unittests": "3ccea043ab74029ed115d6d51ca10a8b4fe1b60d", "telemetry_unittests": "6037c22ab6d06be35ab8f86b27fbaad2c2eb2031", "ui_base_unittests": "dc30d90e2825600021981708a3893dfe465c4d6d", "ui_touch_selection_unittests": "b2f1e1ab110462e0fc5bb8befc7f48a2f0562023", "unit_tests": "6cf981b5dac5226885e87cdda6a68655ba76096e", "url_unittests": "f2574de77849016e83bbf1769bcc14bdfe91441f", "views_perftests": "6733b25d50dd53b196911e24998a55aa22858b45", "views_unittests": "0ac5fd3ac6a8dd6290586675f7d285e11ef229f6", "viz_unittests": "19e7c3940099e94e7017d75921814bc245405a33", "webkit_python_tests": "5622a24a805556cdd3ece27ba06521309cbd2b90", "webkit_unit_tests": "204e2eebad5dc00b4cad342342721869c774e651", "wtf_unittests": "eb622e86af816626fe1b71328259668904538499"} | find isolated tests |
Blamelist:
- Tarun Bansal (tbansalohnoyoudont@chromium.org)
- Brian Sheedy (bsheedyohnoyoudont@chromium.org)
- Tom Tan (Tom.Tanohnoyoudont@microsoft.com)
- Nico Weber (thakisohnoyoudont@chromium.org)
- James Cook (jamescookohnoyoudont@chromium.org)
- siyua (siyuaohnoyoudont@chromium.org)
- Ian Kilpatrick (ikilpatrickohnoyoudont@chromium.org)
- chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
- Daniel Erat (deratohnoyoudont@chromium.org)
- Anthony Cui (cuianthonyohnoyoudont@google.com)
- Nico Weber (thakisohnoyoudont@chromium.org)
- Emircan Uysaler (emircanohnoyoudont@chromium.org)
- Tommy C. Li (tommycliohnoyoudont@chromium.org)
- Gabriel Marin (gmxohnoyoudont@chromium.org)
- Jimmy Gong (jimmyxgongohnoyoudont@google.com)
- Victor Costan (pwnallohnoyoudont@chromium.org)
- Nico Weber (thakisohnoyoudont@chromium.org)
- Ben Pastene (bpasteneohnoyoudont@chromium.org)
- Jesse Doherty (jwdohnoyoudont@chromium.org)
- Nico Weber (thakisohnoyoudont@chromium.org)
- Nico Weber (thakisohnoyoudont@chromium.org)
- John Rummell (jrummellohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Katie Dektar (katieohnoyoudont@chromium.org)
- Lan Wei (lanweiohnoyoudont@chromium.org)
- Elly Fong-Jones (ellyjonesohnoyoudont@chromium.org)
- Vladimir Levin (vmpstrohnoyoudont@chromium.org)
- Vladimir Levin (vmpstrohnoyoudont@chromium.org)
- Alexei Filippov (alphohnoyoudont@chromium.org)
- James Cook (jamescookohnoyoudont@chromium.org)
- Nico Weber (thakisohnoyoudont@chromium.org)
- Luna Lu (loonybearohnoyoudont@chromium.org)
- Istiaque Ahmed (lazyboyohnoyoudont@chromium.org)
- Joshua Bell (jsbellohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Greg Kerr (kerrnelohnoyoudont@chromium.org)
- Mark Mentovai (markohnoyoudont@chromium.org)
- Abhijeet Kandalkar (abhijeetohnoyoudont@igalia.com)
- Nico Weber (thakisohnoyoudont@chromium.org)
- Nico Weber (thakisohnoyoudont@chromium.org)
- Pavel Feldman (pfeldmanohnoyoudont@chromium.org)
- David Benjamin (davidbenohnoyoudont@chromium.org)
- Raul Tambre (raulohnoyoudont@tambre.ee)
- Alex Ilin (alexilinohnoyoudont@chromium.org)
- Martin Robinson (mrobinsonohnoyoudont@igalia.com)
- Sergey Kuznetsov (kuznetsovsohnoyoudont@yandex-team.ru)
- Siddhartha (ssidohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Ken MacKay (kmackayohnoyoudont@chromium.org)
- Katie D (katieohnoyoudont@chromium.org)
- Yashar Dabiran (yashardohnoyoudont@google.com)
- Nico Weber (thakisohnoyoudont@chromium.org)
- Dana Fried (dfriedohnoyoudont@chromium.org)
- Nico Weber (thakisohnoyoudont@chromium.org)
- Nico Weber (thakisohnoyoudont@chromium.org)
Timing:
Create | Monday, 11-Feb-19 22:27:27 UTC |
Start | Monday, 11-Feb-19 22:28:14 UTC |
End | Tuesday, 12-Feb-19 00:43:45 UTC |
Pending | 46 secs |
Execution | 2 hrs 15 mins |
All Changes:
-
Remove unnecessary dependencies to previews/core
Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 22:23:12 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4f89d4e9f1855a53eb25c055b97cc85ee4fe3172 Comments
Remove unnecessary dependencies to previews/core Do not allow data_reduction_proxy/core to depend on previews/core. This will allow us to move most of the previews/core/* to previews/content/ in the next CL. Do not allow cyclic dependency between previews and d_r_p: Do not allow previews to depend on d_r_p. Move some of the files from core/ to content/. There is no functional change in this CL. Change-Id: Ie5fa660c4880cd965445b44bada5cbd553601685 Bug: 930802 Reviewed-on: https://chromium-review.googlesource.com/c/1462146 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#630957}
Changed files
- chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_base.cc
- chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_base_unittest.cc
- chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_test_utils.h
- components/data_reduction_proxy/DEPS
- components/data_reduction_proxy/content/DEPS
- components/data_reduction_proxy/content/browser/BUILD.gn
- components/data_reduction_proxy/content/browser/data_reduction_proxy_page_load_timing.cc
- components/data_reduction_proxy/content/browser/data_reduction_proxy_page_load_timing.h
- components/data_reduction_proxy/content/browser/data_reduction_proxy_pingback_client_impl.cc
- components/data_reduction_proxy/content/browser/data_reduction_proxy_pingback_client_impl_unittest.cc
- components/data_reduction_proxy/core/browser/BUILD.gn
- components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
- components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
- components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
- components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
- components/data_reduction_proxy/core/browser/data_reduction_proxy_util.cc
- components/data_reduction_proxy/core/browser/data_reduction_proxy_util.h
- components/data_reduction_proxy/core/common/BUILD.gn
- components/previews/DEPS
- components/previews/content/DEPS
-
Revert "Generate and use the real key to sign UMA/UKM uploads."
Changed by Brian Sheedy - bsheedyohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 22:20:44 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision fb3e31c8d1e41521922140d97911e0a9c21ee1aa Comments
Revert "Generate and use the real key to sign UMA/UKM uploads." This reverts commit 867eeca2649677b1f7c30e6bf24863d3454e9315. Reason for revert: Cause of https://crbug.com/930891 Original change's description: > Generate and use the real key to sign UMA/UKM uploads. > > BUG=906202 > > Change-Id: I10d2de8a1f30c0a56cc95f69aa6c252f171dca73 > Reviewed-on: https://chromium-review.googlesource.com/c/1461089 > Commit-Queue: Jesse Doherty <jwd@chromium.org> > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630939} TBR=rogerta@chromium.org,jwd@chromium.org,rkaplow@chromium.org Change-Id: If85da5416f52f414942ca8d75e5f5b4611a86842 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 906202 Reviewed-on: https://chromium-review.googlesource.com/c/1465066 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#630956}
Changed files
- chrome/browser/metrics/chrome_metrics_service_client.cc
- chrome/browser/metrics/chrome_metrics_service_client.h
- google_apis/BUILD.gn
- google_apis/google_api_keys.cc
- google_apis/google_api_keys.h
-
Create symlink to x64 dump_syms.exe for Windows ARM64 cross build
Changed by Tom Tan - Tom.Tanohnoyoudont@microsoft.com Changed at Monday, 11-Feb-19 22:19:46 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3f06239755de04e6974c949ca7c42eca123df962 Comments
Create symlink to x64 dump_syms.exe for Windows ARM64 cross build Dump_syms.exe runs on build server for symbols post processing, so it needs build for host arch in cross compilation. This fixes build break of dump_sym.exe for Windows ARM64. Bug: 927113 Change-Id: I93b38fde320ea17020359a4a3f490a7210e1eae7 Reviewed-on: https://chromium-review.googlesource.com/c/1455460 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#630955}
Changed files
- third_party/breakpad/BUILD.gn
-
Remove a few unnecessary semicolons.
Changed by Nico Weber - thakisohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 22:19:37 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1e116aef5014aaad0f0f47e24b408eab75d4026d Comments
Remove a few unnecessary semicolons. This CL was uploaded by git cl split. R=estade@chromium.org Bug: 926235 Change-Id: I6ee4ea7330118790ce4d041ce2bf5e57ecaf0fa2 Reviewed-on: https://chromium-review.googlesource.com/c/1463404 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#630954}
Changed files
- chrome/browser/ui/views/infobars/infobar_view.cc
-
Change debug "crash ash" shortcut to use LOG(FATAL)
Changed by James Cook - jamescookohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 22:18:37 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 100b63a811198f0492c76bb79917e0181688dbdd Comments
Change debug "crash ash" shortcut to use LOG(FATAL) Otherwise it doesn't print anything to the chrome logs. Bug: none Change-Id: Idd14955e17b885116785d6dcaed6bbb1a2961cda Reviewed-on: https://chromium-review.googlesource.com/c/1464929 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#630953}
Changed files
- ash/accelerators/debug_commands.cc
-
Add more brower test for Autofill local card migration flow.
Changed by siyua - siyuaohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 22:18:24 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 748ce38bd1083cc8846cb214073b7ef129e1e4a1 Comments
Add more brower test for Autofill local card migration flow. Added a wait observer in autofill_uitest_util to observe personal_data_manager since deleting card in personal_data_manager is an asynchronous process. Bug: 897998 Change-Id: I7996d4d6969658f124d646451a4573b2d6c54614 Reviewed-on: https://chromium-review.googlesource.com/c/1459795 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#630952}
Changed files
- chrome/browser/autofill/autofill_uitest_util.cc
- chrome/browser/autofill/autofill_uitest_util.h
- chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.h
- chrome/browser/ui/views/autofill/local_card_migration_browsertest.cc
- chrome/browser/ui/views/autofill/migratable_card_view.cc
- chrome/browser/ui/views/autofill/migratable_card_view.h
- components/autofill/core/browser/local_card_migration_manager.cc
-
[LayoutNG] Make border_padding be required for ng_length_utils.cc
Changed by Ian Kilpatrick - ikilpatrickohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 22:13:35 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0c43d7d47dd696350b763ca873f2116f0c9c0fb8 Comments
[LayoutNG] Make border_padding be required for ng_length_utils.cc This is primarily a cleanup. Bug: 635619 Change-Id: I7baf9ac1e98d55be89a9eb903b1b0ada311f847a Reviewed-on: https://chromium-review.googlesource.com/c/1461352 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Reviewed-by: Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#630951}
Changed files
- third_party/blink/renderer/core/layout/ng/ng_absolute_utils.cc
- third_party/blink/renderer/core/layout/ng/ng_absolute_utils.h
- third_party/blink/renderer/core/layout/ng/ng_absolute_utils_test.cc
- third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
- third_party/blink/renderer/core/layout/ng/ng_column_layout_algorithm.cc
- third_party/blink/renderer/core/layout/ng/ng_fieldset_layout_algorithm.cc
- third_party/blink/renderer/core/layout/ng/ng_flex_layout_algorithm.cc
- third_party/blink/renderer/core/layout/ng/ng_flex_layout_algorithm.h
- third_party/blink/renderer/core/layout/ng/ng_length_utils.cc
- third_party/blink/renderer/core/layout/ng/ng_length_utils.h
- third_party/blink/renderer/core/layout/ng/ng_length_utils_test.cc
- third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.cc
- third_party/blink/renderer/core/layout/ng/ng_page_layout_algorithm.cc
-
Roll src-internal 4ddd89fe2fbd..c15741b70f84 (6 commits)
Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com Changed at Monday, 11-Feb-19 22:12:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e9c25fa6551c26d53b01f85fe1be2f279557accf Comments
Roll src-internal 4ddd89fe2fbd..c15741b70f84 (6 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4ddd89fe2fbd..c15741b70f84 Created with: gclient setdep -r src-internal@c15741b70f84 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/123994572,chromium:891734 TBR=mmoss@chromium.org Change-Id: I3595f9bc8a44bc5997cc0e223a88f23438da2869 Reviewed-on: https://chromium-review.googlesource.com/c/1464250 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630950}
Changed files
- DEPS
-
ash: Handle missing battery time estimates from powerd.
Changed by Daniel Erat - deratohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 22:04:02 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 572a0429d6479b50f9e29c94e2d841d54dfb8bc1 Comments
ash: Handle missing battery time estimates from powerd. Update ash::PowerStatus, ash::BatteryNotification, and ash::PowerNotificationController to disregard unset or negative battery_time_to_empty_sec and battery_time_to_full_sec fields in the PowerSupplyProperties protobufs sent by powerd. powerd sends a -1 time-to-empty value if the battery current is so close to zero that the estimate would be ridiculously high. Chrome would formerly display a low-battery notification when seeing one of these negative estimates. Bug: 930358 Change-Id: I54b52891cd8527dedec9c6fe3dbb16728d9996a3 Reviewed-on: https://chromium-review.googlesource.com/c/1461691 Auto-Submit: Dan Erat <derat@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#630949}
Changed files
- ash/system/power/battery_notification.cc
- ash/system/power/power_notification_controller.cc
- ash/system/power/power_notification_controller_unittest.cc
- ash/system/power/power_status.cc
- ash/system/power/power_status.h
- ash/system/power/power_status_unittest.cc
-
[VR] Moved VR strings to VR DFM
Changed by Anthony Cui - cuianthonyohnoyoudont@google.com Changed at Monday, 11-Feb-19 22:03:27 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 96649f5167f91410e86cd0c79e4d835d32307ec1 Comments
[VR] Moved VR strings to VR DFM Steps taken to move Chrome VR strings out of base module: - Moved Chrome VR related Strings out of android_chrome_strings.grd into new grd file - Created new java_strings_grd target and new android_resources target for vr strings - Linked new resource target into VR target android_library("java") - Modified SilenceLintErrors.java to remove references to VR strings - Modified VrShellDelegate.java to use a new Context to access VR string resources, accommodating for new VR package - Defined a new resource ID mapping in module_names_to_package_ids.gni and used it for vr_module_tmpl.gni, to ensure VR strings are given unique resource IDs - Changes to support translations: added new grd file to translation_expectations.pyl and created placeholder .xtb files in new directory vr_translations Bug: 930158 Change-Id: Ib6593eb2a51d6efb664bc5ded82e5b2fdf85d7e2 Reviewed-on: https://chromium-review.googlesource.com/c/1460873 Commit-Queue: Anthony Cui <cuianthony@google.com> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#630948}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/vr/SilenceLintErrors.java
- chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java
- chrome/android/java/strings/android_chrome_strings.grd
- chrome/android/java/strings/android_chrome_vr_strings.grd
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_am.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_ar.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_bg.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_bn.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_ca.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_cs.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_da.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_de.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_el.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_en-GB.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_es-419.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_es.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_et.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_fa.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_fi.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_fil.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_fr.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_gu.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_hi.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_hr.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_hu.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_id.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_it.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_iw.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_ja.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_kn.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_ko.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_lt.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_lv.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_ml.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_mr.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_ms.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_nl.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_no.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_pl.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_pt-BR.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_pt-PT.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_ro.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_ru.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_sk.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_sl.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_sr.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_sv.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_sw.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_ta.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_te.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_th.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_tr.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_uk.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_vi.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_zh-CN.xtb
- chrome/android/java/strings/vr_translations/android_chrome_vr_strings_zh-TW.xtb
- chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrInstallUpdateInfoBarTest.java
- chrome/android/modules/module_names_to_package_ids.gni
- chrome/android/modules/vr/vr_module_tmpl.gni
- chrome/browser/android/vr/BUILD.gn
- tools/gritsettings/translation_expectations.pyl
-
Remove a few unnecessary semicolons.
Changed by Nico Weber - thakisohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 22:01:09 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 210c0bc960e20e49891ca9a65a28133fbfdd9943 Comments
Remove a few unnecessary semicolons. This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Bug: 926235 Change-Id: I9e2fa638ffdf3363ad319c897f22e7e81ced6ef7 Reviewed-on: https://chromium-review.googlesource.com/c/1463645 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#630947}
Changed files
- extensions/browser/browsertest_util_browsertest.cc
- extensions/browser/event_listener_map.h
- extensions/browser/extension_creator.cc
- extensions/browser/extension_pref_value_map_unittest.cc
- extensions/browser/process_manager.h
- extensions/browser/process_manager_delegate.h
- extensions/browser/url_loader_factory_manager_browsertest.cc
- extensions/common/csp_validator_unittest.cc
- extensions/common/manifest_handlers/csp_info_unittest.cc
-
Do not allow audio to be approved by default for getDisplayMedia()
Changed by Emircan Uysaler - emircanohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:58:44 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a97583c9b4117f3bb559b218f6eb2ae065dd5fe8 Comments
Do not allow audio to be approved by default for getDisplayMedia() This CL changed picker UI behavior for getDisplayMedia() such that audio checkbox is not ticked by default. This is a restriction defined in the spec. Bug: 896333 Change-Id: I63709e895818a0cca6264cdb76528537828bc372 Reviewed-on: https://chromium-review.googlesource.com/c/1450854 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Weiyong Yao <braveyao@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#630946}
Changed files
- chrome/browser/media/webrtc/desktop_media_picker.h
- chrome/browser/media/webrtc/display_media_access_handler.cc
- chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.mm
- chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.h
- chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm
- chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_unittest.mm
- chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
-
Omnibox: Add mechanism to toggle popup closing on blur
Changed by Tommy C. Li - tommycliohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:57:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 999b56373f00b3dd849218cc1390f7f213fbd745 Comments
Omnibox: Add mechanism to toggle popup closing on blur When we show a modal bubble relating to one of the omnibox suggestions, we don't want the popup to close when the window is blurred. This is important, as the user should not lose the context of what they are operating on when the popup closes. Additionally, the modal bubble is parented by the popup window, so the popup closing would also inadvertedly close the bubble. This CL adds a toggle boolean on the popup model to be used by the bubble. Bug: 929477 Change-Id: I9ee38326588d72b51b0b551ca10a15a4a8438176 Reviewed-on: https://chromium-review.googlesource.com/c/1464346 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#630945}
Changed files
- chrome/browser/ui/views/omnibox/omnibox_view_views.cc
- components/omnibox/browser/omnibox_popup_model.h
-
Add two new hooks to allocator_extension.h
Changed by Gabriel Marin - gmxohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:54:10 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 686003cec250fd1f8aa1870b317a38c4adcb5356 Comments
Add two new hooks to allocator_extension.h Add two hooks to allocator_extension.h: 1) SetNumericProperty() to set the value associated with a given property; 2) GetHeapSample() to retrieve a sample of live objects and the stack traces that allocated those objects. BUG=b:121160411 Change-Id: I3cdc8edd906c8d4ddec2f1394b2862e94a86451d Reviewed-on: https://chromium-review.googlesource.com/c/1446796 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#630944}
Changed files
- base/allocator/allocator_extension.cc
- base/allocator/allocator_extension.h
-
Enable UpdateSharePath on ERROR_NOT_FOUND from StartReadDirectory.
Changed by Jimmy Gong - jimmyxgongohnoyoudont@google.com Changed at Monday, 11-Feb-19 21:49:15 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 67f4db4f6fae43c5b30c1970bb2aa0fb000f0cd3 Comments
Enable UpdateSharePath on ERROR_NOT_FOUND from StartReadDirectory. - UpdateSharePath will start when ERROR_NOT_FOUND is returned from StartReadDirectory. Bug: 922273 Test: end to end Change-Id: I5f8b08628ebe7fba84af0aaff05345bb93227083 Reviewed-on: https://chromium-review.googlesource.com/c/1444599 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Auto-Submit: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#630943}
Changed files
- chrome/browser/chromeos/smb_client/smb_file_system.cc
- chrome/browser/chromeos/smb_client/smb_file_system.h
-
sqlite: Upgrade from 3.26.0 to 3.27.1.
Changed by Victor Costan - pwnallohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:44:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d664d4a4adac34fccb9879380cf4863321c6a64a Comments
sqlite: Upgrade from 3.26.0 to 3.27.1. The upgrade lets us remove ~40 backports that we have accumulated since the last release. It unfortunately also introduces one new patch, which is needed to keep SQLite compiling with SQLITE_OMIT_WINDOWFUNC. Bug: 930560 Change-Id: I4f5e1301581f443f8593ad7943663fd4f3484780 Reviewed-on: https://chromium-review.googlesource.com/c/1462202 Reviewed-by: Chris Mumford <cmumford@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#630942}
Changed files
- third_party/sqlite/amalgamation/rename_exports.h
- third_party/sqlite/amalgamation/shell/shell.c
- third_party/sqlite/amalgamation/sqlite3.c
- third_party/sqlite/amalgamation/sqlite3.h
- third_party/sqlite/patches/0001-Modify-default-VFS-to-support-WebDatabase.patch
- third_party/sqlite/patches/0002-Virtual-table-supporting-recovery-of-corrupted-datab.patch
- third_party/sqlite/patches/0003-Custom-shell.c-helpers-to-load-Chromium-s-ICU-data.patch
- third_party/sqlite/patches/0004-fts3-Disable-fts3_tokenizer-and-fts4.patch
- third_party/sqlite/patches/0005-fuchsia-Use-dot-file-locking-for-sqlite.patch
- third_party/sqlite/patches/0006-Fix-compilation-with-SQLITE_OMIT_WINDOWFUNC.patch
- third_party/sqlite/patches/0006-Fix-dbfuzz2-for-Clusterfuzz.patch
- third_party/sqlite/patches/0007-Fix-dbfuzz2.c-compilation-errors-on-Windows.patch
- third_party/sqlite/patches/0007-Fix-the-Makefile-so-that-it-honors-CFLAGS-when-build.patch
- third_party/sqlite/patches/0008-Adjustments-to-the-page-cache-to-try-to-avoid-harmle.patch
- third_party/sqlite/patches/0009-Remove-an-ALWAYS-from-a-branch-that-is-not-always-ta.patch
- third_party/sqlite/patches/0010-Fix-a-problem-with-nested-CTEs-with-the-same-table.patch
- third_party/sqlite/patches/0011-Fix-detection-of-self-referencing-rows-in-foreign-ke.patch
- third_party/sqlite/patches/0012-Fix-a-segfault-caused-by-using-the-RAISE-function-in.patch
- third_party/sqlite/patches/0013-Fix-for-an-assert-that-could-be-false.patch
- third_party/sqlite/patches/0014-Fix-another-problem-found-by-Matthew-Denton-s-new-fu.patch
- third_party/sqlite/patches/0015-Report-a-new-corruption-case.patch
- third_party/sqlite/patches/0016-Avoid-a-buffer-overread-in-ptrmapPutOvflPtr.patch
- third_party/sqlite/patches/0017-Improved-detection-of-cell-corruption-in-sqlite3Vdbe.patch
- third_party/sqlite/patches/0018-Fix-a-segfault-in-fts3-prompted-by-a-corrupted-datab.patch
- third_party/sqlite/patches/0019-Prevent-integer-overflow-from-leading-to-buffer-over.patch
- third_party/sqlite/patches/0020-Add-extra-tests-for-database-corruption-inside-defra.patch
- third_party/sqlite/patches/0021-Fix-an-off-by-one-error-on-a-Goto-in-the-code-genera.patch
- third_party/sqlite/patches/0022-Fix-overread-on-corrupted-btree-key.patch
- third_party/sqlite/patches/0023-Avoid-buffer-overreads-on-corrupted-database-files.patch
- third_party/sqlite/patches/0024-Fix-integer-overflow-while-running-PRAGMA-integrity_.patch
- third_party/sqlite/patches/0025-Improved-corruption-handling-while-balancing-pages.patch
- third_party/sqlite/patches/0026-Avoid-reading-off-the-front-of-a-page-buffer-when-ba.patch
- third_party/sqlite/patches/0027-Fix-MSAN-error-in-sqlite3VdbeRecordUnpack-on-a-corru.patch
- third_party/sqlite/patches/0028-Fix-deleting-a-B-tree-entry-in-a-corrupt-database.patch
- third_party/sqlite/patches/0029-Fix-sorting-results-with-SRT_EphemTab-and-a-LIMIT-cl.patch
- third_party/sqlite/patches/0030-Fix-detection-of-orphaned-and-malformed-autoindexes.patch
- third_party/sqlite/patches/0031-Fix-potential-buffer-overread.patch
- third_party/sqlite/patches/0032-Fix-handling-negative-number-of-pages-database-field.patch
- third_party/sqlite/patches/0033-Fix-corner-case-in-inserting-null-into-integer-prima.patch
- third_party/sqlite/patches/0034-Fix-insert-infinite-recursion-on-some-corrupted-data.patch
- third_party/sqlite/patches/0035-Fix-null-pointer-dereference-in-sqlite3ExprCompare.patch
- third_party/sqlite/patches/0036-Fix-NEVER-that-is-sometimes-true.patch
- third_party/sqlite/patches/0037-Initialize-extra-bytes-allocated-for-saved-cursor-po.patch
- third_party/sqlite/patches/0038-Fix-leaks-caused-by-circular-references-in-vtable-sh.patch
- third_party/sqlite/patches/0039-Fix-overly-large-malloc-on-btree-corruption.patch
- third_party/sqlite/patches/0040-Fix-null-pointer-access-on-corrupted-index-key.patch
- third_party/sqlite/patches/0041-Fix-INSERT-INTO-.-SELECT-FROM-on-corrupt-database.patch
- third_party/sqlite/patches/0042-Fix-integer-overflow-in-sqlite3VdbeRecordUnpack.patch
- third_party/sqlite/patches/0043-Fix-memcpy-with-overlapping-buffers-in-corrupted-dat.patch
- third_party/sqlite/patches/0044-Fix-null-dereference-in-UPDATE-OR-REPLACE.patch
- third_party/sqlite/patches/0045-Fix-heap-buffer-overflow-while-rebalancing-corrupt-d.patch
- third_party/sqlite/src/Makefile.in
- third_party/sqlite/src/Makefile.msc
- third_party/sqlite/src/VERSION
- third_party/sqlite/src/autoconf/Makefile.msc
- third_party/sqlite/src/configure
- third_party/sqlite/src/ext/expert/expert1.test
- third_party/sqlite/src/ext/fts3/fts3.c
- third_party/sqlite/src/ext/fts3/fts3Int.h
- third_party/sqlite/src/ext/fts3/fts3_aux.c
- third_party/sqlite/src/ext/fts3/fts3_expr.c
- third_party/sqlite/src/ext/fts3/fts3_hash.c
- third_party/sqlite/src/ext/fts3/fts3_icu.c
- third_party/sqlite/src/ext/fts3/fts3_snippet.c
- third_party/sqlite/src/ext/fts3/fts3_term.c
- third_party/sqlite/src/ext/fts3/fts3_test.c
- third_party/sqlite/src/ext/fts3/fts3_tokenize_vtab.c
- third_party/sqlite/src/ext/fts3/fts3_unicode.c
- third_party/sqlite/src/ext/fts3/fts3_unicode2.c
- third_party/sqlite/src/ext/fts3/fts3_write.c
- third_party/sqlite/src/ext/fts3/unicode/mkunicode.tcl
- third_party/sqlite/src/ext/fts3/unicode/parseunicode.tcl
- third_party/sqlite/src/ext/fts5/fts5.h
- third_party/sqlite/src/ext/fts5/fts5Int.h
- third_party/sqlite/src/ext/fts5/fts5_aux.c
- third_party/sqlite/src/ext/fts5/fts5_buffer.c
- third_party/sqlite/src/ext/fts5/fts5_config.c
- third_party/sqlite/src/ext/fts5/fts5_expr.c
- third_party/sqlite/src/ext/fts5/fts5_hash.c
- third_party/sqlite/src/ext/fts5/fts5_index.c
- third_party/sqlite/src/ext/fts5/fts5_main.c
- third_party/sqlite/src/ext/fts5/fts5_storage.c
- third_party/sqlite/src/ext/fts5/fts5_test_mi.c
- third_party/sqlite/src/ext/fts5/fts5_test_tok.c
- third_party/sqlite/src/ext/fts5/fts5_tokenize.c
- third_party/sqlite/src/ext/fts5/fts5_unicode2.c
- third_party/sqlite/src/ext/fts5/fts5_varint.c
- third_party/sqlite/src/ext/fts5/fts5_vocab.c
- third_party/sqlite/src/ext/fts5/test/fts5aa.test
- third_party/sqlite/src/ext/fts5/test/fts5ai.test
- third_party/sqlite/src/ext/fts5/test/fts5ak.test
- third_party/sqlite/src/ext/fts5/test/fts5circref.test
- third_party/sqlite/src/ext/fts5/test/fts5corrupt3.test
- third_party/sqlite/src/ext/fts5/test/fts5interrupt.test
- third_party/sqlite/src/ext/fts5/test/fts5tokenizer.test
- third_party/sqlite/src/ext/fts5/test/fts5umlaut.test
- third_party/sqlite/src/ext/fts5/test/fts5unicode3.test
- third_party/sqlite/src/ext/fts5/test/fts5update.test
- third_party/sqlite/src/ext/fts5/test/fts5vocab.test
- third_party/sqlite/src/ext/fts5/test/fts5vocab2.test
- third_party/sqlite/src/ext/misc/amatch.c
- third_party/sqlite/src/ext/misc/closure.c
- third_party/sqlite/src/ext/misc/csv.c
- third_party/sqlite/src/ext/misc/dbdump.c
- third_party/sqlite/src/ext/misc/eval.c
- third_party/sqlite/src/ext/misc/fileio.c
- third_party/sqlite/src/ext/misc/fuzzer.c
- third_party/sqlite/src/ext/misc/json1.c
- third_party/sqlite/src/ext/misc/memstat.c
- third_party/sqlite/src/ext/misc/memtrace.c
- third_party/sqlite/src/ext/misc/mmapwarm.c
- third_party/sqlite/src/ext/misc/nextchar.c
- third_party/sqlite/src/ext/misc/percentile.c
- third_party/sqlite/src/ext/misc/prefixes.c
- third_party/sqlite/src/ext/misc/regexp.c
- third_party/sqlite/src/ext/misc/unionvtab.c
- third_party/sqlite/src/ext/misc/vfslog.c
- third_party/sqlite/src/ext/misc/zipfile.c
- third_party/sqlite/src/ext/rbu/rbu_common.tcl
- third_party/sqlite/src/ext/rbu/rbuvacuum2.test
- third_party/sqlite/src/ext/rbu/rbuvacuum3.test
- third_party/sqlite/src/ext/rbu/sqlite3rbu.c
- third_party/sqlite/src/ext/rbu/sqlite3rbu.h
- third_party/sqlite/src/ext/rbu/test_rbu.c
- third_party/sqlite/src/ext/rtree/geopoly.c
- third_party/sqlite/src/ext/rtree/rtree.c
- third_party/sqlite/src/ext/rtree/rtree1.test
- third_party/sqlite/src/ext/rtree/rtree6.test
- third_party/sqlite/src/ext/rtree/rtreecirc.test
- third_party/sqlite/src/ext/rtree/rtreefuzz001.test
- third_party/sqlite/src/ext/session/changeset.c
- third_party/sqlite/src/ext/session/changesetfuzz.c
- third_party/sqlite/src/ext/session/session_speed_test.c
- third_party/sqlite/src/ext/session/sessionwor.test
- third_party/sqlite/src/ext/session/sqlite3session.c
- third_party/sqlite/src/ext/session/sqlite3session.h
- third_party/sqlite/src/main.mk
- third_party/sqlite/src/manifest
- third_party/sqlite/src/manifest.uuid
- third_party/sqlite/src/src/alter.c
- third_party/sqlite/src/src/analyze.c
- third_party/sqlite/src/src/attach.c
- third_party/sqlite/src/src/btree.c
- third_party/sqlite/src/src/btree.h
- third_party/sqlite/src/src/btreeInt.h
- third_party/sqlite/src/src/build.c
- third_party/sqlite/src/src/callback.c
- third_party/sqlite/src/src/dbstat.c
- third_party/sqlite/src/src/delete.c
- third_party/sqlite/src/src/expr.c
- third_party/sqlite/src/src/fkey.c
- third_party/sqlite/src/src/func.c
- third_party/sqlite/src/src/global.c
- third_party/sqlite/src/src/hash.c
- third_party/sqlite/src/src/insert.c
- third_party/sqlite/src/src/legacy.c
- third_party/sqlite/src/src/loadext.c
- third_party/sqlite/src/src/main.c
- third_party/sqlite/src/src/memdb.c
- third_party/sqlite/src/src/pager.c
- third_party/sqlite/src/src/parse.y
- third_party/sqlite/src/src/pcache1.c
- third_party/sqlite/src/src/pragma.c
- third_party/sqlite/src/src/pragma.h
- third_party/sqlite/src/src/prepare.c
- third_party/sqlite/src/src/printf.c
- third_party/sqlite/src/src/resolve.c
- third_party/sqlite/src/src/select.c
- third_party/sqlite/src/src/shell.c.in
- third_party/sqlite/src/src/sqlite.h.in
- third_party/sqlite/src/src/sqliteInt.h
- third_party/sqlite/src/src/tclsqlite.c
- third_party/sqlite/src/src/test1.c
- third_party/sqlite/src/src/test_journal.c
- third_party/sqlite/src/src/test_vfs.c
- third_party/sqlite/src/src/tokenize.c
- third_party/sqlite/src/src/treeview.c
- third_party/sqlite/src/src/trigger.c
- third_party/sqlite/src/src/update.c
- third_party/sqlite/src/src/util.c
- third_party/sqlite/src/src/vacuum.c
- third_party/sqlite/src/src/vdbe.c
- third_party/sqlite/src/src/vdbe.h
- third_party/sqlite/src/src/vdbeInt.h
- third_party/sqlite/src/src/vdbeapi.c
- third_party/sqlite/src/src/vdbeaux.c
- third_party/sqlite/src/src/vdbemem.c
- third_party/sqlite/src/src/vtab.c
- third_party/sqlite/src/src/walker.c
- third_party/sqlite/src/src/where.c
- third_party/sqlite/src/src/whereInt.h
- third_party/sqlite/src/src/wherecode.c
- third_party/sqlite/src/src/whereexpr.c
- third_party/sqlite/src/src/window.c
- third_party/sqlite/src/test/altercol.test
- third_party/sqlite/src/test/altertab.test
- third_party/sqlite/src/test/altertab2.test
- third_party/sqlite/src/test/altertab3.test
- third_party/sqlite/src/test/autoindex1.test
- third_party/sqlite/src/test/bestindex3.test
- third_party/sqlite/src/test/btree02.test
- third_party/sqlite/src/test/conflict.test
- third_party/sqlite/src/test/corruptL.test
- third_party/sqlite/src/test/cost.test
- third_party/sqlite/src/test/csv01.test
- third_party/sqlite/src/test/dbfuzz001.test
- third_party/sqlite/src/test/dbfuzz2.c
- third_party/sqlite/src/test/e_select.test
- third_party/sqlite/src/test/eqp.test
- third_party/sqlite/src/test/fallocate.test
- third_party/sqlite/src/test/fkey8.test
- third_party/sqlite/src/test/fts3_common.tcl
- third_party/sqlite/src/test/fts3aa.test
- third_party/sqlite/src/test/fts3aux2.test
- third_party/sqlite/src/test/fts3corrupt4.test
- third_party/sqlite/src/test/fts3expr5.test
- third_party/sqlite/src/test/fts3fault.test
- third_party/sqlite/src/test/fts3fuzz001.test
- third_party/sqlite/src/test/fts3snippet.test
- third_party/sqlite/src/test/fts4umlaut.test
- third_party/sqlite/src/test/fuzz4.test
- third_party/sqlite/src/test/fuzzcheck.c
- third_party/sqlite/src/test/fuzzdata7.db
- third_party/sqlite/src/test/fuzzdata8.db
- third_party/sqlite/src/test/index6.test
- third_party/sqlite/src/test/indexexpr2.test
- third_party/sqlite/src/test/insert.test
- third_party/sqlite/src/test/insertfault.test
- third_party/sqlite/src/test/join.test
- third_party/sqlite/src/test/join5.test
- third_party/sqlite/src/test/json101.test
- third_party/sqlite/src/test/lock_common.tcl
- third_party/sqlite/src/test/memdb1.test
- third_party/sqlite/src/test/misc1.test
- third_party/sqlite/src/test/misc7.test
- third_party/sqlite/src/test/normalize.test
- third_party/sqlite/src/test/ossfuzz.c
- third_party/sqlite/src/test/permutations.test
- third_party/sqlite/src/test/prefixes.test
- third_party/sqlite/src/test/releasetest.tcl
- third_party/sqlite/src/test/resetdb.test
- third_party/sqlite/src/test/rowvalue4.test
- third_party/sqlite/src/test/select1.test
- third_party/sqlite/src/test/shell1.test
- third_party/sqlite/src/test/shell4.test
- third_party/sqlite/src/test/shmlock.test
- third_party/sqlite/src/test/snapshot_fault.test
- third_party/sqlite/src/test/tabfunc01.test
- third_party/sqlite/src/test/tester.tcl
- third_party/sqlite/src/test/triggerC.test
- third_party/sqlite/src/test/triggerF.test
- third_party/sqlite/src/test/unionvtab.test
- third_party/sqlite/src/test/update2.test
- third_party/sqlite/src/test/vacuum-into.test
- third_party/sqlite/src/test/vtabdrop.test
- third_party/sqlite/src/test/wal.test
- third_party/sqlite/src/test/walfault2.test
- third_party/sqlite/src/test/walvfs.test
- third_party/sqlite/src/test/where7.test
- third_party/sqlite/src/test/where9.test
- third_party/sqlite/src/test/whereI.test
- third_party/sqlite/src/test/window1.test
- third_party/sqlite/src/test/with1.test
- third_party/sqlite/src/test/with3.test
- third_party/sqlite/src/test/zeroblob.test
- third_party/sqlite/src/tool/dbtotxt.c
- third_party/sqlite/src/tool/dbtotxt.md
- third_party/sqlite/src/tool/index_usage.c
- third_party/sqlite/src/tool/lemon.c
- third_party/sqlite/src/tool/lempar.c
- third_party/sqlite/src/tool/mkpragmatab.tcl
-
Remove a few unnecessary semicolons.
Changed by Nico Weber - thakisohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:44:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision cb794ec4e1fbca070a128145fb4dcadd3442b36b Comments
Remove a few unnecessary semicolons. This CL was uploaded by git cl split. R=olka@chromium.org Bug: 926235 Change-Id: I73d086269e45e50cb8cd79cd4ca6da78c4e02dc4 Reviewed-on: https://chromium-review.googlesource.com/c/1464160 Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#630941}
Changed files
- content/browser/renderer_host/media/audio_input_stream_handle_unittest.cc
- content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc
- content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
- content/browser/renderer_host/media/old_render_frame_audio_input_stream_factory_unittest.cc
-
Add chromeos-kevin-compile-rel to all //chromeos/CHROMEOS_LKGM changes.
Changed by Ben Pastene - bpasteneohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:39:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7fea93ffbb7e61e962de55de9ab1ccef3ebf69a1 Comments
Add chromeos-kevin-compile-rel to all //chromeos/CHROMEOS_LKGM changes. This will ensure an sdk exists for kevin when the lkgm gets rolled. Note that the chromeos-kevin-rel bot also runs tests, but the OS of the devices on that bot get updated separately. So using that trybot for lkgm rolls would end up having test compiled at the newer lkgm version, but running on devices on the older lkgm version. So we'll just use the compile-only version of the bot for now. Bug: 866062, 926874 Change-Id: I7c3c8641c012e1a8a75d642cda66bade275961ee Reviewed-on: https://chromium-review.googlesource.com/c/1450308 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#630940}
Changed files
- docs/infra/cq_builders.md
- infra/config/global/commit-queue.cfg
-
Generate and use the real key to sign UMA/UKM uploads.
Changed by Jesse Doherty - jwdohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:34:44 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 867eeca2649677b1f7c30e6bf24863d3454e9315 Comments
Generate and use the real key to sign UMA/UKM uploads. BUG=906202 Change-Id: I10d2de8a1f30c0a56cc95f69aa6c252f171dca73 Reviewed-on: https://chromium-review.googlesource.com/c/1461089 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#630939}
Changed files
- chrome/browser/metrics/chrome_metrics_service_client.cc
- chrome/browser/metrics/chrome_metrics_service_client.h
- google_apis/BUILD.gn
- google_apis/google_api_keys.cc
- google_apis/google_api_keys.h
-
Remove a few unnecessary semicolons.
Changed by Nico Weber - thakisohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:33:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2cc4de25df81fba3a84454b9bee4033e24fabf69 Comments
Remove a few unnecessary semicolons. This CL was uploaded by git cl split. R=olka@chromium.org Bug: 926235 Change-Id: If9fcc8254e262e7559789263856fe332416ff429 Reviewed-on: https://chromium-review.googlesource.com/c/1464442 Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#630938}
Changed files
- content/browser/speech/endpointer/endpointer_unittest.cc
-
Remove a few unnecessary semicolons.
Changed by Nico Weber - thakisohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:30:30 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 58374d62184cf13e0b13f7f9de418f6f745351fd Comments
Remove a few unnecessary semicolons. This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 926235 Change-Id: Ie8966bafe3fffa9ef355e9b2871cf26fc5afcdcd Reviewed-on: https://chromium-review.googlesource.com/c/1463641 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#630937}
Changed files
- dbus/end_to_end_async_unittest.cc
- dbus/mock_unittest.cc
-
Add trace events for EME events in CdmAdapter
Changed by John Rummell - jrummellohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:30:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1abef01219c07c6aed08949114b71bfc6ff6368a Comments
Add trace events for EME events in CdmAdapter Adding tracing for events generated by EME to better understand when the CDM generates them, plus displaying some limited information on what they contain. BUG=929999 TEST=tracing manually Change-Id: I3ae23be0d0987b3d8399c60b70d882a41e1ec92f Reviewed-on: https://chromium-review.googlesource.com/c/1461336 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#630936}
Changed files
- media/cdm/cdm_adapter.cc
-
Roll src/third_party/pdfium 011147f5b36f..2f1edd6a8ac3 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Monday, 11-Feb-19 21:28:13 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5e41e9c51645e3957c7e23a78183131c348de978 Comments
Roll src/third_party/pdfium 011147f5b36f..2f1edd6a8ac3 (1 commits) https://pdfium.googlesource.com/pdfium.git/+log/011147f5b36f..2f1edd6a8ac3 git log 011147f5b36f..2f1edd6a8ac3 --date=short --no-merges --format='%ad %ae %s' 2019-02-11 thestig@chromium.org Break off parts of CXFA_ItemLayoutProcessor::GotoNextContainerNode(). Created with: gclient setdep -r src/third_party/pdfium@2f1edd6a8ac3 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I567244cf9742a0cb494e2055904aa4b464f7a8e8 Reviewed-on: https://chromium-review.googlesource.com/c/1464247 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630935}
Changed files
- DEPS
-
Revert "Fixing a few tests for user_prompts in ChromeDriver"
Changed by Katie Dektar - katieohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:23:46 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9c72f09bb2c01bd86602bfb480ab692d2ca7f820 Comments
Revert "Fixing a few tests for user_prompts in ChromeDriver" This reverts commit 49f2169655c614e4e2d6379b2b8cc2d6b4c8be09. Reason for revert: Failing mac tests due to null outerHTML Bug:930861 Original change's description: > Fixing a few tests for user_prompts in ChromeDriver > > Bug: 929418 > Change-Id: If4d576954c873853c7c3bef622a47ef9079f06b3 > Reviewed-on: https://chromium-review.googlesource.com/c/1461311 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: John Jansen <johnjan@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#630845} TBR=johnchen@chromium.org,johnjan@microsoft.com Change-Id: I73e4ff9f0e5c1e517b9d45030ab5bfcc1ab88c51 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 929418 Reviewed-on: https://chromium-review.googlesource.com/c/1464933 Reviewed-by: Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#630934}
Changed files
- chrome/test/chromedriver/window_commands.cc
-
Set click count correctly to dispatch "dblclick" event
Changed by Lan Wei - lanweiohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:18:18 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 34e7e9808340047ec28d689a082bb6dace02a1ee Comments
Set click count correctly to dispatch "dblclick" event In order to dispatch the "dblclick" event to DOM by sending synthetic mouse events, we have to check the most recent two mouse press events. If their dispatched times and locations are close enough, we will set the mouse event's click count to 2, which will generate the "dblclick" event. Bug: 606367 Change-Id: I049d6463c6bf1393c9e8b496662359eeeef7682b Reviewed-on: https://chromium-review.googlesource.com/c/1413362 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#630933}
Changed files
- content/browser/renderer_host/input/synthetic_gesture_target_aura.cc
- content/browser/renderer_host/input/synthetic_mouse_driver.cc
- content/browser/renderer_host/input/synthetic_mouse_driver.h
- content/browser/renderer_host/input/synthetic_pointer_action.cc
- content/browser/renderer_host/input/synthetic_pointer_driver.h
- content/browser/renderer_host/input/synthetic_touch_driver.cc
- content/browser/renderer_host/input/synthetic_touch_driver.h
- third_party/blink/web_tests/external/wpt/uievents/click/auxclick_event-manual-expected.txt
- third_party/blink/web_tests/external/wpt/uievents/click/auxclick_event.html
- third_party/blink/web_tests/external/wpt/uievents/click/mouse-dblclick-event.html
- third_party/blink/web_tests/external/wpt_automation/uievents/click/auxclick_event-manual-automation.js
- third_party/blink/web_tests/fast/events/dblclick-addEventListener-expected.txt
- third_party/blink/web_tests/fast/events/dblclick-addEventListener.html
-
flags: assign disable-cast-streaming-hw-encoding to miu
Changed by Elly Fong-Jones - ellyjonesohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:16:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 67712eb616f1abe7852e4ae61b86d84020e377f6 Comments
flags: assign disable-cast-streaming-hw-encoding to miu Per email discussion. Bug: None Change-Id: I31332a90c82d8953f8bb995da66eb599a7618755 Reviewed-on: https://chromium-review.googlesource.com/c/1463459 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#630932}
Changed files
- chrome/browser/flag-metadata.json
-
[DL]: Keep a reference to the Document on the DL context.
Changed by Vladimir Levin - vmpstrohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:15:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 14420cfe85731189c947c266de7fe803c4014450 Comments
[DL]: Keep a reference to the Document on the DL context. This patch adds a weak member to the document associated with the locked element. This accomplishes two things: 1. It simplifies access to the document instead of going through element_. 2. It ensures that if the element_ is destroyed we can still keep the locked context counts updated on the document. If the document goes away, then we're safe anyway since the counts are destroyed along with it. R=chrishtr@chromium.org Bug: 882663 Change-Id: Iabbbc185c1b9199aba1f22dccd6837fe6f98a4df Reviewed-on: https://chromium-review.googlesource.com/c/1456641 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#630931}
Changed files
- third_party/blink/renderer/core/display_lock/display_lock_context.cc
- third_party/blink/renderer/core/display_lock/display_lock_context.h
-
[DL]: Add isLocked attribute.
Changed by Vladimir Levin - vmpstrohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:14:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9f53096d939d84c4cf8319265114e8e1e505d407 Comments
[DL]: Add isLocked attribute. In order to simplify interactions with the display lock context, this patch adds an isLocked attribute which returns true if the lock is acquired and not yet committed. R=chrishtr@chromium.org Bug: 882663 Change-Id: Icc99732a79818d415ff0ac486ebd5f450a874eb5 Reviewed-on: https://chromium-review.googlesource.com/c/1464202 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#630930}
Changed files
- third_party/blink/renderer/core/display_lock/display_lock_context.h
- third_party/blink/renderer/core/display_lock/display_lock_context.idl
- third_party/blink/renderer/core/display_lock/display_lock_context_test.cc
- third_party/blink/web_tests/display-lock/lock-after-append/is-locked-attribute.html
- third_party/blink/web_tests/display-lock/lock-before-append/is-locked-attribute.html
-
DevTools: Expose renderer tasks on the performance panel.
Changed by Alexei Filippov - alphohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:09:32 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6682b219ce38adb3b2302235ac3c4e2080cf46b2 Comments
DevTools: Expose renderer tasks on the performance panel. Drive-by: Rename 'Other' category to 'System'. BUG=681863 Change-Id: I6e2f71a9ad01280b2c13314a65d3a535fa54a31a Reviewed-on: https://chromium-review.googlesource.com/c/1452774 Commit-Queue: Alexei Filippov <alph@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Auto-Submit: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#630929}
Changed files
- base/task/sequence_manager/thread_controller_impl.cc
- base/task/sequence_manager/thread_controller_with_message_pump_impl.cc
- base/trace_event/builtin_categories.h
- third_party/blink/renderer/devtools/front_end/performance_test_runner/TimelineTestRunner.js
- third_party/blink/renderer/devtools/front_end/sdk/TracingModel.js
- third_party/blink/renderer/devtools/front_end/timeline/TimelineController.js
- third_party/blink/renderer/devtools/front_end/timeline/TimelinePanel.js
- third_party/blink/renderer/devtools/front_end/timeline/TimelineUIUtils.js
- third_party/blink/renderer/devtools/front_end/timeline_model/TimelineModel.js
- third_party/blink/renderer/devtools/front_end/timeline_model/TimelineModelFilter.js
- third_party/blink/web_tests/http/tests/devtools/tracing/timeline-js/timeline-js-blackboxing-expected.txt
- third_party/blink/web_tests/http/tests/devtools/tracing/timeline-misc/timeline-aggregated-details-expected.txt
- third_party/blink/web_tests/http/tests/devtools/tracing/timeline-misc/timeline-filtering-expected.txt
- third_party/blink/web_tests/http/tests/devtools/tracing/timeline-misc/timeline-filtering.js
- third_party/blink/web_tests/http/tests/devtools/tracing/timeline-receive-response-event-expected.txt
- third_party/blink/web_tests/http/tests/devtools/tracing/timeline-time/timeline-time-expected.txt
-
content: Fix fling scrolls down sometimes reversing direction
Changed by James Cook - jamescookohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:08:57 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ee6cb6cfe33823f27ceda245b070eee8e9d046bd Comments
content: Fix fling scrolls down sometimes reversing direction Ensure that content::FlingController can handle a compositor animation observer OnAnimationStep() call with a timestamp that is earlier than when the fling animation started (and hence earlier than the initial ProgressFling call), but still after the fling-start event timestamp. Bug: 924279 Test: added to content_unittests Change-Id: I89b07c0b7f774726a01b7107c9ab93482e549436 Reviewed-on: https://chromium-review.googlesource.com/c/1459800 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Sahel Sharify <sahel@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#630928}
Changed files
- content/browser/renderer_host/input/fling_controller.cc
- content/browser/renderer_host/input/fling_controller.h
- content/browser/renderer_host/input/fling_controller_unittest.cc
-
Remove a few unnecessary semicolons.
Changed by Nico Weber - thakisohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:04:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f32f1ac4509ff48800289f78441258ee2f63b379 Comments
Remove a few unnecessary semicolons. This CL was uploaded by git cl split. R=mal@chromium.org Bug: 926235 Change-Id: I7fc07aca2a0fba79a46e8bc81193944f1c3964e4 Reviewed-on: https://chromium-review.googlesource.com/c/1463380 Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#630927}
Changed files
- components/component_updater/configurator_impl_unittest.cc
-
Move policy validation for unoptimized-images and legacy-formats to image loader
Changed by Luna Lu - loonybearohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:03:01 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c9813e4401011f1b4c9237bb85a83bd3d2be547e Comments
Move policy validation for unoptimized-images and legacy-formats to image loader To avoid image policy validated / reported multiple times, this CL moves the validation of non-layout-dependant policies to image loader ImageNotifyFinished so that the validatiom will only happen once per image load. Bug: 926199 Change-Id: I3ec2b8da16e8719f73d09e6feba8dddbba7059d1 Reviewed-on: https://chromium-review.googlesource.com/c/1446065 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#630926}
Changed files
- third_party/blink/renderer/core/html/html_image_element.cc
- third_party/blink/renderer/core/html/html_image_element.h
- third_party/blink/renderer/core/layout/layout_image.cc
- third_party/blink/renderer/core/layout/layout_image.h
- third_party/blink/renderer/core/loader/image_loader.cc
- third_party/blink/renderer/core/paint/image_painter.cc
- third_party/blink/web_tests/http/tests/images/feature-policy-legacy-formats-expected.txt
- third_party/blink/web_tests/http/tests/images/feature-policy-unoptimized-images-cached-image-expected.txt
- third_party/blink/web_tests/http/tests/images/feature-policy-unoptimized-images-expected.txt
-
Remove ProcessMap::Item() constructor as it is not used.
Changed by Istiaque Ahmed - lazyboyohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 20:56:40 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e4a7c15e8a36a371fc03520fd57a3d1dad7a33af Comments
Remove ProcessMap::Item() constructor as it is not used. Bug: None Test: Cleanup, no visible changes expected. Change-Id: I66d0bef0eef87ed9fde375ae74cb4b6e3b34d54c Reviewed-on: https://chromium-review.googlesource.com/c/1462137 Auto-Submit: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#630925}
Changed files
- extensions/browser/process_map.cc
-
Browsing Data: Simplify CannedBrowsingDataXYZHelper classes
Changed by Joshua Bell - jsbellohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 20:55:53 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 52369085faa3a3c1555b54245f8c28da9178335f Comments
Browsing Data: Simplify CannedBrowsingDataXYZHelper classes The CannedBrowsingDataXYZHelper classes allow sparse population of a CookiesTreeModel. Pending data is recorded when the storage type is accessed, and the model is populated lazily from that pending data when the UI is shown (the "Cookies in use" UI off the origin chip in the infobar). Apart from cookies, this UI shows only that the storage was accessed; no size or "last modified" times like the main uses of the CookiesTreeModel. The CannedBrowsingDataXYZHelpers mostly grew via "cargo culting", storing unnecessary data. Simplify and standardize to just storing origins accessed. TBR=bsazonov Change-Id: I62d80609821155a6bad6ec27aa5e340bea8528f2 Reviewed-on: https://chromium-review.googlesource.com/c/1432374 Reviewed-by: Raymes Khoury <raymes@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Auto-Submit: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#630924}
Changed files
- chrome/browser/android/signin/signin_manager_android_unittest.cc
- chrome/browser/browsing_data/browsing_data_cache_storage_helper.cc
- chrome/browser/browsing_data/browsing_data_cache_storage_helper.h
- chrome/browser/browsing_data/browsing_data_cache_storage_helper_browsertest.cc
- chrome/browser/browsing_data/browsing_data_cache_storage_helper_unittest.cc
- chrome/browser/browsing_data/browsing_data_database_helper.cc
- chrome/browser/browsing_data/browsing_data_database_helper.h
- chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc
- chrome/browser/browsing_data/browsing_data_database_helper_unittest.cc
- chrome/browser/browsing_data/browsing_data_file_system_helper.cc
- chrome/browser/browsing_data/browsing_data_file_system_helper.h
- chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc
- chrome/browser/browsing_data/browsing_data_indexed_db_helper.cc
- chrome/browser/browsing_data/browsing_data_indexed_db_helper.h
- chrome/browser/browsing_data/browsing_data_indexed_db_helper_browsertest.cc
- chrome/browser/browsing_data/browsing_data_indexed_db_helper_unittest.cc
- chrome/browser/browsing_data/browsing_data_local_storage_helper.cc
- chrome/browser/browsing_data/browsing_data_local_storage_helper.h
- chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc
- chrome/browser/browsing_data/browsing_data_local_storage_helper_unittest.cc
- chrome/browser/browsing_data/browsing_data_service_worker_helper.cc
- chrome/browser/browsing_data/browsing_data_service_worker_helper.h
- chrome/browser/browsing_data/browsing_data_service_worker_helper_unittest.cc
- chrome/browser/browsing_data/mock_browsing_data_local_storage_helper.cc
- chrome/browser/content_settings/local_shared_objects_container.cc
- chrome/browser/content_settings/tab_specific_content_settings.cc
-
Roll src/third_party/depot_tools aec259ea6232..98f4a99359d5 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Monday, 11-Feb-19 20:54:10 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d92f68e2a67bdda649a2da05ee261324c6cde3a5 Comments
Roll src/third_party/depot_tools aec259ea6232..98f4a99359d5 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/aec259ea6232..98f4a99359d5 git log aec259ea6232..98f4a99359d5 --date=short --no-merges --format='%ad %ae %s' 2019-02-11 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@98f4a99359d5 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ia6a165f820626609854851551639f7a6486c581c Reviewed-on: https://chromium-review.googlesource.com/c/1464362 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630923}
Changed files
- DEPS
-
Roll src/third_party/cros_system_api/ dbbd7b449..3cf556ebe (1 commit)
Changed by Greg Kerr - kerrnelohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 20:50:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f066020d9c8b54f8f0d1652c320500d703c59785 Comments
Roll src/third_party/cros_system_api/ dbbd7b449..3cf556ebe (1 commit) https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/dbbd7b449a7f..3cf556ebeb2d $ git log dbbd7b449..3cf556ebe --date=short --no-merges --format='%ad %ae %s' 2019-02-01 sidereal vm_tools: Add DeleteLxdContainer command to cicerone Created with: roll-dep src/third_party/cros_system_api Bug: 927840 Change-Id: Iaa1c38d556d264733c8caf3ce577222cc1139085 Reviewed-on: https://chromium-review.googlesource.com/c/1464169 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#630922}
Changed files
- DEPS
-
Update Crashpad to bba9d0819c12a4bf39bebafb6233e000aa8a446c
Changed by Mark Mentovai - markohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 20:46:54 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e83e3e2a505cdaccc0ab71b023b5348a67010231 Comments
Update Crashpad to bba9d0819c12a4bf39bebafb6233e000aa8a446c 0dde0ef81c4b Add missing using statement in notify_server_test.cc 8694cbf33e88 Update gtest to 9518a57428ae 6a209070e46a Change deprecated gtest TEST_CASE macros to TEST_SUITE 79f4a3970a64 Use GTEST_SKIP() instead of custom DISABLED_TEST() 1fc95dc3ccb6 [fuchsia] Add zx_vmo_replace_as_executable to tests f66a125cd592 Move POSIX-only include into #ifdef guard, preventing warnings of undefined symbols in some conservative build configurations 84ef87ef5109 Fix arm64 CONTEXT for crashy_test_program caad799c28f2 Delete chromium-specific macOS rpaths 152aa8d1f903 Add missing limits header to crashpad ff5a25e11f55 Remove a few unnecessary semicolons bba9d0819c12 Revert "Use GTEST_SKIP() instead of custom DISABLED_TEST()" Change-Id: Ic79e6132cfc602d6d229dd37b8c3cbac7db482cf Reviewed-on: https://chromium-review.googlesource.com/c/1427384 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#630921}
Changed files
- third_party/crashpad/README.chromium
- third_party/crashpad/crashpad/DEPS
- third_party/crashpad/crashpad/handler/BUILD.gn
- third_party/crashpad/crashpad/handler/win/crashy_test_program.cc
- third_party/crashpad/crashpad/minidump/minidump_user_stream_writer.cc
- third_party/crashpad/crashpad/snapshot/crashpad_info_client_options_test.cc
- third_party/crashpad/crashpad/snapshot/crashpad_types/crashpad_info_reader.cc
- third_party/crashpad/crashpad/snapshot/elf/elf_image_reader_test.cc
- third_party/crashpad/crashpad/snapshot/fuchsia/process_snapshot_fuchsia_test.cc
- third_party/crashpad/crashpad/snapshot/linux/cpu_context_linux.cc
- third_party/crashpad/crashpad/snapshot/minidump/minidump_stream.h
- third_party/crashpad/crashpad/test/multiprocess.h
- third_party/crashpad/crashpad/test/multiprocess_exec_test.cc
- third_party/crashpad/crashpad/third_party/gtest/BUILD.gn
- third_party/crashpad/crashpad/third_party/gtest/gmock.gyp
- third_party/crashpad/crashpad/third_party/gtest/gtest.gyp
- third_party/crashpad/crashpad/tools/generate_dump.cc
- third_party/crashpad/crashpad/util/linux/memory_map.cc
- third_party/crashpad/crashpad/util/misc/from_pointer_cast_test.cc
- third_party/crashpad/crashpad/util/misc/lexing.cc
- third_party/crashpad/crashpad/util/net/http_body_test.cc
- third_party/crashpad/crashpad/util/net/http_transport_test.cc
-
Remove unwanted header.
Changed by Abhijeet Kandalkar - abhijeetohnoyoudont@igalia.com Changed at Monday, 11-Feb-19 20:40:11 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d4d135b86a57bc65d6819c60ce7646a020e2533a Comments
Remove unwanted header. This CL eliminate stale include of account_tracker_service.h in from oauth2_browsertest.cc file. Bug: 930719 Change-Id: I5ca327b04fa21def2620c772390d19203f74ccf3 Reviewed-on: https://chromium-review.googlesource.com/c/1464819 Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#630920}
Changed files
- chrome/browser/chromeos/login/signin/oauth2_browsertest.cc
-
Remove a few unnecessary semicolons.
Changed by Nico Weber - thakisohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 20:39:09 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b2c594aa722ce518fa2b42c9f46279a5c8edd7ac Comments
Remove a few unnecessary semicolons. This CL was uploaded by git cl split. R=sadrul@chromium.org Bug: 926235 Change-Id: I9e8a5eebb0105220aa7842ef6c1bd2d6c1a53877 Reviewed-on: https://chromium-review.googlesource.com/c/1464221 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#630919}
Changed files
- ui/views/test/menu_test_utils.h
- ui/views/widget/widget_unittest.cc
-
Remove a few unnecessary semicolons.
Changed by Nico Weber - thakisohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 20:39:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 71e8ec1ddce1e485ccfb0982e13d9e40daa9e81c Comments
Remove a few unnecessary semicolons. This CL was uploaded by git cl split. R=sadrul@chromium.org Bug: 926235 Change-Id: I832731f0be3596b2727c38adb0197bf38fd40a73 Reviewed-on: https://chromium-review.googlesource.com/c/1464166 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#630918}
Changed files
- components/ui_devtools/views/widget_element_unittest.cc
-
DevTools: migrate devtools message to an explicit BigBuffer-backed type.
Changed by Pavel Feldman - pfeldmanohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 20:32:14 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4531a5dae4faa5d428d09ee61ff06e61b5042ee9 Comments
DevTools: migrate devtools message to an explicit BigBuffer-backed type. Bug: 929862 Change-Id: I26dff920a775a65a8f8de300122facaa66228314 Reviewed-on: https://chromium-review.googlesource.com/c/1461537 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#630917}
Changed files
- content/browser/devtools/devtools_session.cc
- content/browser/devtools/devtools_session.h
- third_party/blink/public/mojom/devtools/devtools_agent.mojom
- third_party/blink/renderer/core/inspector/devtools_session.cc
- third_party/blink/renderer/core/inspector/devtools_session.h
-
Roll src/third_party/boringssl/src 70fe61055..7ef4223fb
Changed by David Benjamin - davidbenohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 20:30:55 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0cf6267d1889197fecd9cb633690b3c810056007 Comments
Roll src/third_party/boringssl/src 70fe61055..7ef4223fb https://boringssl.googlesource.com/boringssl/+log/70fe6105565e71e44e0a2a4ee617a26fd8fdcd96..7ef4223fb32431529a797c5b8d3bf26ece6c138b Bug: none Change-Id: Iebe10d2d1c2357b8636330f439d91ee3e96f2be1 Reviewed-on: https://chromium-review.googlesource.com/c/1464332 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#630916}
Changed files
- DEPS
-
//chromeos: Convert base::(U)Int(64)ToString(16) to NumberToString(16)
Changed by Raul Tambre - raulohnoyoudont@tambre.ee Changed at Monday, 11-Feb-19 20:29:42 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d252a66e5a681cbafb331a81d7e1c4f917a1cceb Comments
//chromeos: Convert base::(U)Int(64)ToString(16) to NumberToString(16) The former non-overloaded variants are deprecated. Removed casts where they are now unnecessary. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: I45e55f81b13beb76128bb2a3364d7b3567efbf9b Reviewed-on: https://chromium-review.googlesource.com/c/1461876 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#630915}
Changed files
- chromeos/components/multidevice/logging/logging_unittest.cc
- chromeos/dbus/fake_session_manager_client.cc
- chromeos/geolocation/simple_geolocation_request.cc
- chromeos/geolocation/simple_geolocation_unittest.cc
- chromeos/network/client_cert_util.cc
- chromeos/network/geolocation_handler_unittest.cc
- chromeos/network/network_cert_migrator_unittest.cc
- chromeos/network/network_state_handler.cc
- chromeos/network/network_util.cc
- chromeos/network/onc/onc_certificate_importer_impl_unittest.cc
- chromeos/network/onc/onc_utils_unittest.cc
- chromeos/network/onc/onc_validator.cc
- chromeos/system/statistics_provider.cc
- chromeos/timezone/timezone_request.cc
-
android: Fix CallbackHelper wait condition for handling spurious wakeups
Changed by Alex Ilin - alexilinohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 20:28:33 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 01c89c38581ae916e2b076d9e51aa88c03809641 Comments
android: Fix CallbackHelper wait condition for handling spurious wakeups Documentation to the java.lang.Object#wait() says "that applications must guard against it [spurious wakeup] by testing for the condition that should have caused the thread to be awakened, and continuing to wait if the condition is not satisfied". CallbackHelper#waitForCallback() is not guarded against spurious wakeups and treats them as if the timeout would expire. The CL fixes it by checking the timeout condition in the loop statement. This problem was discovered after running tests for the reached code profiler (https://crrev.com/c/1393328). The profiler periodically sends signals to all threads in the Chrome processes that may be the cause of the spurious wakeup. Bug: 916263 Change-Id: Id649272994a454937d236af5fa95b762ad838b58 Reviewed-on: https://chromium-review.googlesource.com/c/1464581 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#630914}
Changed files
- base/test/android/javatests/src/org/chromium/base/test/util/CallbackHelper.java
-
Add support for ATK_RELATION_EMBEDS and ATK_RELATION_EMBEDDED_BY
Changed by Martin Robinson - mrobinsonohnoyoudont@igalia.com Changed at Monday, 11-Feb-19 20:28:11 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d6515885616229add551ae1c5bf96a7c81b3b578 Comments
Add support for ATK_RELATION_EMBEDS and ATK_RELATION_EMBEDDED_BY Add support for these two ATK specific relations, which map between a window and its embedded document, the accessible with role of ATK_ROLE_DOCUMENT_WEB, which corresponds to the toplevel document in a traditional browser window. This is complicated by the fact that this relationship extends between two accessibility trees. In order to accomplish this we have the kEmbeddedById attribute carry a unique accessible id and manage the reverse relationship via special-cased code. Bug: 895833 Change-Id: I0261931914379aa7df320e0b44a15e4f98d46275 Reviewed-on: https://chromium-review.googlesource.com/c/1451886 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#630913}
Changed files
- chrome/browser/ui/views/accessibility/browser_accessibility_uitest_auralinux.cc
- content/browser/accessibility/browser_accessibility_manager.cc
- content/browser/accessibility/browser_accessibility_manager_auralinux.cc
- ui/accessibility/platform/ax_platform_node_auralinux.cc
- ui/accessibility/platform/ax_platform_node_auralinux.h
-
Propagate user activation state to RenderFrameHost clients.
Changed by Sergey Kuznetsov - kuznetsovsohnoyoudont@yandex-team.ru Changed at Monday, 11-Feb-19 20:26:50 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 32257a2574d134b80887790b16dec751eb86d50f Comments
Propagate user activation state to RenderFrameHost clients. UserActivationV2 calculates effective_transient_activation_state before calling CanCreateWindow. But it propagates params->mimic_user_gesture to clients, but it is not valid value for user_gesture. This invalid value can confuse clients, for example WebChromeClient#onCreateWindow webview api call. R=mustaq@chromium.org Bug: 927254 Change-Id: I900a8f7f91a21f29bd54e3e8e0c74c41dfdd47fc Reviewed-on: https://chromium-review.googlesource.com/c/1449392 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#630912}
Changed files
- android_webview/javatests/src/org/chromium/android_webview/test/PopupWindowTest.java
- android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java
- content/browser/frame_host/interstitial_page_impl.cc
- content/browser/frame_host/interstitial_page_impl.h
- content/browser/frame_host/render_frame_host_delegate.h
- content/browser/frame_host/render_frame_host_impl.cc
- content/browser/web_contents/web_contents_impl.cc
- content/browser/web_contents/web_contents_impl.h
- content/renderer/render_view_impl.cc
- content/test/test_web_contents.cc
- content/test/test_web_contents.h
-
Refactor proto database classes to use less templates
Changed by Siddhartha - ssidohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 20:24:23 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f5a0e0cc5765dcf36ad1351ebfeb89d6c431e242 Comments
Refactor proto database classes to use less templates The templated functions in proto database are needed only for parsing and serializing proto values. But, this needs to happen on background task runner and not the client task runner. In reality all the classes are templated in leveldb_proto, and the parse and serialize happens on the proto_leveldb_wrapper level. This costs us a lot of binary size. This cl removes templates from all the classes and moves the parse and serialize functionality to the top class ProtoDatabaseImpl. The ProtoDatabaseWrapper is split into 2 classes: ProtoDatabaseImpl and ProtoDatabaseSelector. The ProtoDatabaseImpl will handle the templated behavior required. ProtoDatabaseSelector will handle the migration between unique and shared database. ProtoDatabaseImpl will be called on client task runner. All the functionality of this class is moved to ProtoDatabaseSelector and will run on the background task runner. ProtoDatabaseImpl has parse / serialize which will run as a wrapper around transactions to ProtoDatabaseSelector calls. Now, ProtoDatabaseSelector needs to imitate the current use case of unique database. Some clients use the database in synchronous way, ie: SyncFunction() { db->Init(); db->Update(); db->Delete(); } This used to work as expected because unique database in previous world just posts the given task to background runner and finishes it. Update() and Delete() will only fail in case of Init() failure. But, now since Init() runs as multiple tasks, the transaction order is not guaranteed. To guarantee the transaction order we need: 1. Wait till Init() finishes to run transactions. 2. All transactions must be run as a posted single background task. So, ProtoDatabaseSelector will queue transactions till Init() is completed. This CL does not fix the 2nd behavior yet, since proto_leveldb_wrapper is still asynchronous after this change. This will be fixed as a follow up. But, currently there is not client using the api in a way to be affected. This CL then removes all the templated behavior in remaining classes and uses them as a string value. BUG=870813 Change-Id: I70ab3fb813f351dd99bc7ab93e41638521573f6d Reviewed-on: https://chromium-review.googlesource.com/c/1419199 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#630911}
Changed files
- components/leveldb_proto/BUILD.gn
- components/leveldb_proto/internal/migration_delegate.cc
- components/leveldb_proto/internal/migration_delegate.h
- components/leveldb_proto/internal/proto_database_impl.cc
- components/leveldb_proto/internal/proto_database_impl.h
- components/leveldb_proto/internal/proto_database_impl_unittest.cc
- components/leveldb_proto/internal/proto_database_perftest.cc
- components/leveldb_proto/internal/proto_database_selector.cc
- components/leveldb_proto/internal/proto_database_selector.h
- components/leveldb_proto/internal/proto_database_wrapper.cc
- components/leveldb_proto/internal/proto_database_wrapper.h
- components/leveldb_proto/internal/proto_leveldb_wrapper.cc
- components/leveldb_proto/internal/proto_leveldb_wrapper.h
- components/leveldb_proto/internal/shared_proto_database.cc
- components/leveldb_proto/internal/shared_proto_database.h
- components/leveldb_proto/internal/shared_proto_database_client.cc
- components/leveldb_proto/internal/shared_proto_database_client.h
- components/leveldb_proto/internal/shared_proto_database_client_unittest.cc
- components/leveldb_proto/internal/shared_proto_database_unittest.cc
- components/leveldb_proto/internal/unique_proto_database.cc
- components/leveldb_proto/internal/unique_proto_database.h
- components/leveldb_proto/internal/unique_proto_database_unittest.cc
- components/leveldb_proto/public/proto_database.h
- components/leveldb_proto/public/proto_database_provider.cc
- components/leveldb_proto/public/proto_database_provider.h
- components/leveldb_proto/testing/fake_db.h
-
Roll src/third_party/angle fe59f6b5ed2b..0029dfe28cf4 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Monday, 11-Feb-19 20:24:14 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 897ee87be723023dcbe53be48078a3d4907bbf90 Comments
Roll src/third_party/angle fe59f6b5ed2b..0029dfe28cf4 (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/fe59f6b5ed2b..0029dfe28cf4 git log fe59f6b5ed2b..0029dfe28cf4 --date=short --no-merges --format='%ad %ae %s' 2019-02-11 spang@chromium.org Vulkan: Respect EGL_HEIGHT & EGL_WIDTH in SurfaceVk Created with: gclient setdep -r src/third_party/angle@0029dfe28cf4 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: If08b7c3a55cb2ef2668b5db5e33805fa75e938b6 Reviewed-on: https://chromium-review.googlesource.com/c/1464245 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630910}
Changed files
- DEPS
-
[Chromecast] Add missing dependency
Changed by Ken MacKay - kmackayohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 20:22:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision de8ba6e989deac5f78d7ee04071200a74781df01 Comments
[Chromecast] Add missing dependency Change-Id: I059fb1e7e2e3ae1070df32013f38cd019270f8fd Reviewed-on: https://chromium-review.googlesource.com/c/1464645 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#630909}
Changed files
- chromecast/browser/BUILD.gn
-
Disabling flaky test SingleClientSessionsWithDeferRecyclingSyncTest.NavigateThenCloseTabThenOpenTab.
Changed by Katie D - katieohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 20:19:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f79eb695ed7f3be5659cd5b4028909c748410bfb Comments
Disabling flaky test SingleClientSessionsWithDeferRecyclingSyncTest.NavigateThenCloseTabThenOpenTab. TBR=mastiz@chromium.org Bug: 930413 Change-Id: I1e174117aaa80d145daf96936cea3c5da203f1c6 Reviewed-on: https://chromium-review.googlesource.com/c/1464445 Reviewed-by: Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#630908}
Changed files
- chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc
-
Add platform-dependent feature support to runtime_enabled_features.json5
Changed by Yashar Dabiran - yashardohnoyoudont@google.com Changed at Monday, 11-Feb-19 20:18:27 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3d64fa45cc16a98afc0c9fa00c5c32d2e364300d Comments
Add platform-dependent feature support to runtime_enabled_features.json5 This CL adds support for dictionary values in runtime_enabled_features.json5 and lets the feature status to be specified by different platform options. You can find the design doc here: https://docs.google.com/document/d/1CNizF9pdFs7Hc42coTet4ftX9KhMU5eP86W_GYxcUcE/ Bug: 711300 Change-Id: I420963bb91ca1eff5993c81d3bb521e814270353 Reviewed-on: https://chromium-review.googlesource.com/c/1463979 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Commit-Queue: Yashar Dabiran <yashard@google.com> Cr-Commit-Position: refs/heads/master@{#630907}
Changed files
- third_party/blink/renderer/build/scripts/PRESUBMIT.py
- third_party/blink/renderer/build/scripts/json5_generator.py
- third_party/blink/renderer/build/scripts/json5_generator_unittest.py
- third_party/blink/renderer/build/scripts/make_runtime_features.py
- third_party/blink/renderer/build/scripts/templates/runtime_enabled_features.cc.tmpl
- third_party/blink/renderer/build/scripts/tests/json5_generator_invalid_key.json5
- third_party/blink/renderer/build/scripts/tests/json5_generator_invalid_value.json5
- third_party/blink/renderer/build/scripts/tests/json5_generator_no_valid_keys.json5
- third_party/blink/renderer/build/scripts/tests/json5_generator_valid_dict_value.json5
- third_party/blink/renderer/platform/runtime_enabled_features.json5
-
Remove a few unnecessary semicolons.
Changed by Nico Weber - thakisohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 20:18:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 94e2fe3ad1a7beabf23f0d8cd5354d48014016a1 Comments
Remove a few unnecessary semicolons. This CL was uploaded by git cl split. R=jkarlin@chromium.org Bug: 926235 Change-Id: I0a75f7f68b840b71844e2e3d48208aed1cf7e037 Reviewed-on: https://chromium-review.googlesource.com/c/1463506 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#630906}
Changed files
- third_party/blink/renderer/modules/netinfo/network_information.cc
-
Placeholder preview image for hover cards (first pass).
Changed by Dana Fried - dfriedohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 20:16:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6597261658f9a505605659b70306bddb4aad70e9 Comments
Placeholder preview image for hover cards (first pass). Note: This is all behind a flag. Still to do: * Switch to og:image or screenshot instead of favicon where possible. * Shrink bubble margins around the image to UX spec. * Use more appealing image scaling mode. * There is one frame of pop when the card switches to a new tab where the old image is still visible (this is a hover card rendering issue). Bug: 928954 Change-Id: I86b7cf9af1fa7d5b64a884a3f39e12ec40b21457 Reviewed-on: https://chromium-review.googlesource.com/c/1459978 Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#630905}
Changed files
- chrome/browser/ui/views/tabs/tab_hover_card_bubble_view.cc
- chrome/browser/ui/views/tabs/tab_hover_card_bubble_view.h
-
Remove a few unnecessary semicolons.
Changed by Nico Weber - thakisohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 20:14:30 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e5943f727c52a9e8130da5c68e24794d08d7cab0 Comments
Remove a few unnecessary semicolons. This CL was uploaded by git cl split. R=jrummell@chromium.org Bug: 926235 Change-Id: I236c83347ed4f75a49dbe37454dbcfa8cdbae84a Reviewed-on: https://chromium-review.googlesource.com/c/1464122 Reviewed-by: John Rummell <jrummell@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#630904}
Changed files
- media/base/pipeline_impl_unittest.cc
- media/base/renderer_factory_selector_unittest.cc
- media/cdm/library_cdm/clear_key_cdm/clear_key_cdm.cc
- media/ffmpeg/ffmpeg_regression_tests.cc
- media/learning/impl/learning_session_impl_unittest.cc
-
Remove a few unnecessary semicolons.
Changed by Nico Weber - thakisohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 20:11:01 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e6e9dffe79fc43e89493862f0a09b39df9c07a87 Comments
Remove a few unnecessary semicolons. This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Bug: 926235 Change-Id: I38ebe3d7596adb9e0b300c1d1692deeb16cf8682 Reviewed-on: https://chromium-review.googlesource.com/c/1464441 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#630903}
Changed files
- extensions/renderer/bindings/api_request_handler_unittest.cc