Home | Search | chromium - Builders
Login

Builder Chromium Linux Goma RBE Staging Build 20794 Canonical Ubuntu

Results:

Internal Failure

Trigger Info:

Projectchromium
Revision38d4c8616dd560586a6e29165b77eadd5a2ca1ed

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    coordinator: no such stream

Build Properties:

NameValueSource

Blamelist:

  1. Avi Drissman (aviohnoyoudont@chromium.org)
  2. Alan Cutter (alancutterohnoyoudont@chromium.org)
  3. Christopher Cameron (ccameronohnoyoudont@chromium.org)
  4. Peter Kotwicz (pkotwiczohnoyoudont@chromium.org)

Timing:

Create Friday, 07-Dec-18 07:21:49 UTC
Start Friday, 07-Dec-18 07:22:25 UTC
End Friday, 07-Dec-18 07:33:05 UTC
Pending 36 secs
Execution 10 mins 39 secs

All Changes:

  1. Remove linked_ptr from the extensions trackers.

    Changed by Avi Drissman - aviohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 07:21:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38d4c8616dd560586a6e29165b77eadd5a2ca1ed

    Comments

    Remove linked_ptr from the extensions trackers.
    
    BUG=582001
    
    Change-Id: I4141f3fe268d34e5d078740b5ef12b4f02b5efb1
    Reviewed-on: https://chromium-review.googlesource.com/c/1364550
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614633}

    Changed files

    • chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.cc
    • chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.h
    • chrome/browser/extensions/api/declarative_content/declarative_content_is_bookmarked_condition_tracker.cc
    • chrome/browser/extensions/api/declarative_content/declarative_content_is_bookmarked_condition_tracker.h
    • chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.cc
    • chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.h
  2. Revert "Add chrome_proxy.exe target on Windows"

    Changed by Alan Cutter - alancutterohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 07:03:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0edcdf14a29397ba43d8e303bcf01f04705ed95e

    Comments

    Revert "Add chrome_proxy.exe target on Windows"
    
    This reverts commit 86e7ed69a96f03ffcbb6af63d632f7951bf34b28.
    
    Reason for revert: Broke Chrome Canary update while the browser is open.
    Bug: 912716
    
    Original change's description:
    > Add chrome_proxy.exe target on Windows
    >
    > This change adds a new executable to Windows called chrome_proxy.exe which
    > opens chrome.exe with all arguments forwarded.
    >
    > In a future patch bookmark app shortcuts will be updated to point to
    > chrome_proxy.exe instead of chrome.exe so they don't pick up the
    > chrome.VisualElementsManifest.xml file when pinned to the Windows 10
    > start menu. This fixes a bug where pinned bookmark app shortcuts all
    > use the Chrome logo instead of their own.
    >
    > Bug: 732357
    > Change-Id: I551093f6f111041b424d30ec3f829fa6a06a265c
    > Reviewed-on: https://chromium-review.googlesource.com/c/1362695
    > Reviewed-by: Greg Thompson <grt@chromium.org>
    > Reviewed-by: Lei Zhang <thestig@chromium.org>
    > Commit-Queue: Alan Cutter <alancutter@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614177}
    
    TBR=thestig@chromium.org,alancutter@chromium.org,mgiuca@chromium.org,grt@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    NOPRESUBMIT=TRUE # TBR doesn't apply because this revert touches an OWNERS file.
    
    Bug: 732357
    Change-Id: I73cddef3173e3abc22f8c8c4720d84f9a9069ab1
    Reviewed-on: https://chromium-review.googlesource.com/c/1366471
    Commit-Queue: Alan Cutter <alancutter@chromium.org>
    Reviewed-by: Alan Cutter <alancutter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614632}

    Changed files

    • chrome/BUILD.gn
    • chrome/chrome_proxy/BUILD.gn
    • chrome/chrome_proxy/OWNERS
    • chrome/chrome_proxy/chrome_proxy.ver
    • chrome/chrome_proxy/chrome_proxy_main_win.cc
    • chrome/installer/mini_installer/BUILD.gn
    • chrome/installer/mini_installer/chrome.release
    • chrome/installer/setup/install_worker.cc
    • chrome/installer/setup/install_worker.h
    • chrome/installer/setup/setup_main.cc
    • chrome/installer/util/util_constants.cc
    • chrome/installer/util/util_constants.h
    • chrome/test/mini_installer/config/chrome_beta_installed.prop
    • chrome/test/mini_installer/config/chrome_canary_installed.prop
    • chrome/test/mini_installer/config/chrome_dev_installed.prop
    • chrome/test/mini_installer/config/chrome_multi_system_installed.prop
    • chrome/test/mini_installer/config/chrome_multi_user_installed.prop
    • chrome/test/mini_installer/config/chrome_system_installed.prop
    • chrome/test/mini_installer/config/chrome_user_installed.prop
    • chrome/test/mini_installer/config/previous_chrome_canary_installed.prop
    • chrome/test/mini_installer/config/previous_chrome_system_installed.prop
    • chrome/test/mini_installer/config/previous_chrome_user_installed.prop
    • chrome/tools/build/win/FILES.cfg
  3. RemoteMacViews: Wire up menu items and shortcut keys

    Changed by Christopher Cameron - ccameronohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 07:00:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1c1992d02fa89792498f5e3533772bd65d93973d

    Comments

    RemoteMacViews: Wire up menu items and shortcut keys
    
    For menu items and shortcut keys to work, PWA windows need to have the
    ChromeCommandDispatcherDelegate and BrowserWindowCommandHandler
    structures set on them.
    
    This cannot be done by a method on views_bridge_mac::mojom::
    BridgedNativeWidget, because the structures to be created exist in
    Chrome, which would be a layering violation.
    
    Introduce a method to chrome::mojom::AppShim which takes a widget id,
    creates the ChromeCommandDispatcherDelegate and
    BrowserWindowCommandHandler, and assigns them to the corresponding
    BridgedNativeWidgetImpl.
    
    Bug: 895169
    Change-Id: Ie1d333bec235d7b6101d5b19aa89a74136d54a7a
    Reviewed-on: https://chromium-review.googlesource.com/c/1364210
    Commit-Queue: ccameron <ccameron@chromium.org>
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Reviewed-by: Robert Sesek <rsesek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614631}

    Changed files

    • chrome/app_shim/app_shim_controller.h
    • chrome/app_shim/app_shim_controller.mm
    • chrome/browser/apps/app_shim/app_shim_host_mac.cc
    • chrome/browser/apps/app_shim/app_shim_host_mac.h
    • chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc
    • chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm
    • chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc
    • chrome/browser/apps/app_shim/extension_app_shim_handler_mac.h
    • chrome/browser/ui/views/frame/browser_frame_mac.mm
    • chrome/common/mac/app_shim.mojom
    • ui/views/cocoa/bridged_native_widget_unittest.mm
    • ui/views/widget/native_widget_mac.h
  4. [Android Tests] Fix several FirstRunIntegrationTests

    Changed by Peter Kotwicz - pkotwiczohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:57:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ca54644ff73878027d7903ab3bd6288561e68a8

    Comments

    [Android Tests] Fix several FirstRunIntegrationTests
    
    This CL converts several FirstRunIntegrationTests to JUnit tests and
    re-enables them.
    
    BUG=911316
    
    Change-Id: I7aada68234fe9a5cb25ee3bef29538cec537d49a
    Reviewed-on: https://chromium-review.googlesource.com/c/1362812
    Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
    Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614630}

    Changed files

    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationUnitTest.java