Home | Search | chromium - Builders
Login

Builder Cast Linux Build 62513 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision306f652506c5622c732f3b61e0d000074078b877
Got Revision306f652506c5622c732f3b61e0d000074078b877

Execution:

Steps and Logfiles:

Show:
  1. ( 329 ms ) setup_build
    running recipe: "chromium"
  2. ( 224 ms ) report builders
     
    running builder/tester 'Cast Linux' on master 'chromium.linux'
  3. ( 45 secs ) bot_update
    [93GB/295GB used (31%)]
  4. ( 600 ms ) swarming.py --version
    0.13
  5. ( 10 secs ) gclient runhooks
  6. ( 589 ms ) read test spec (chromium.linux.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.linux.json
  7. ( 487 ms ) lookup GN args
     
    is_chromecast = true
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 583 ms ) clang_revision
  9. ( 55 mins 24 secs ) compile
  10. ( 39 secs ) isolate tests
  11. ( 439 ms ) find isolated tests
  12. ( 5 secs ) cast_shell_browsertests
    cast_shell_browsertests
    12 disabled
  13. ( 1 secs ) wait for tasks
  14. ( 3 secs ) angle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 33s
  15. ( 1 secs ) cacheinvalidation_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  16. ( 1 secs ) boringssl_ssl_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  17. ( 2 secs ) base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 23s
  18. ( 1 secs ) cast_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  19. ( 2 secs ) gpu_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  20. ( 1 secs ) media_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  21. ( 1 secs ) ui_touch_selection_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  22. ( 1 secs ) crypto_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  23. ( 1 secs ) cast_media_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 20s
  24. ( 1 secs ) wtf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  25. ( 1 secs ) jingle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  26. ( 1 secs ) perfetto_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  27. ( 1 secs ) gin_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  28. ( 3 secs ) content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 34s
  29. ( 1 secs ) skia_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  30. ( 1 secs ) ipc_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  31. ( 1 secs ) components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 16s
  32. ( 1 secs ) mojo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  33. ( 2 secs ) blink_platform_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  34. ( 1 secs ) cast_shell_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  35. ( 1 secs ) shell_dialogs_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  36. ( 1 secs ) events_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  37. ( 1 secs ) boringssl_crypto_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  38. ( 1 secs ) sql_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  39. ( 1 secs ) cast_audio_backend_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  40. ( 1 secs ) cast_base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  41. ( 1 secs ) url_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  42. ( 1 secs ) storage_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  43. ( 1 secs ) libjingle_xmpp_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  44. ( 1 secs ) blink_heap_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  45. ( 1 secs ) sandbox_linux_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  46. ( 1 secs ) cast_graphics_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  47. ( 1 secs ) ui_base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  48. ( 1 secs ) capture_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  49. ( 1 secs ) gcm_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  50. ( 1 secs ) google_apis_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  51. ( 1 secs ) media_blink_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  52. ( 14 secs ) net_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:09.412720
  53. ( 1 secs ) latency_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  54. ( 1 secs ) cast_crash_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  55. ( 1 secs ) blink_common_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  56. ( 1 secs ) midi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  57. ( 767 ms ) wait for tasks (2)
  58. ( 6 secs ) components_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:04.346054
  59. ( 4 secs ) media_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 24s
  60. ( 2 secs ) services_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 23s
  61. ( 6 secs ) webkit_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 39s
  62. ( 2 mins 17 secs ) content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:07:30.449342
  63. ( 769 ms ) Tests statistics
     
    Stats
    Total shards: 48
    Total runtime: 0:14:49.227761
     
  64. ( 1 ms ) recipe result

Build Properties:

NameValueSource
$build/goma {"jobs": 50} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm981-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1542163268038290, "id": "8929918325011928800", "project": "chromium", "tags": ["builder:Cast Linux", "buildset:commit/git/306f652506c5622c732f3b61e0d000074078b877", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/306f652506c5622c732f3b61e0d000074078b877", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095348387106101776", "scheduler_job_id:chromium/Cast Linux", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Cast Linux" setup_build
buildnumber 62513 setup_build
mastername "chromium.linux" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "306f652506c5622c732f3b61e0d000074078b877" setup_build
got_angle_revision "d1a55e393e65601ba26e2d76bd46a12fc6bc4e3e" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "597e1587b4bfc7bf89895c7c879ae58b649da3c5" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "306f652506c5622c732f3b61e0d000074078b877" bot_update
got_revision_cp "refs/heads/master@{#607878}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "dd90e943fb1fb45baaafb93e5055f60d6c94348e" bot_update
got_v8_revision_cp "refs/heads/7.2.320@{#1}" bot_update
got_webrtc_revision "6dbf0e43a5ff4768fea849de829c84e5470d544b" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25628}" bot_update
got_clang_revision "346388-1" clang_revision
swarm_hashes_refs/heads/master(at){#607878}_without_patch {"angle_unittests": "dcdc6334b6bdc4a346bd1f9bf97848b4ab0e248d", "base_unittests": "9237fa61781415fbbaa75d7ea0e7dc27e835f1ac", "blink_common_unittests": "bd2dc8fc662c78d2841c08dddeab549013a2bd35", "blink_heap_unittests": "2bd97d6bdb4a598319e3cb8446f49036d611b0e6", "blink_platform_unittests": "a03d9ae46c9aa1928af30658f85b2b503196edaf", "boringssl_crypto_tests": "8e4679ca5b1f6a922afcec547f5454a3a8bcf2dd", "boringssl_ssl_tests": "e565dbc8ed8363bb7aab6894e33472048930e7f3", "cacheinvalidation_unittests": "1de90d89abf921f0ae6d7dc9cde140b614491ed9", "capture_unittests": "8322c203dc221d24ce52bd47069c2c1769bbedea", "cast_audio_backend_unittests": "f34f31d94ede286b11d63d0fe3ba1461f5c5b63d", "cast_base_unittests": "9eecae5980aa98509bff8989dc5191f82ccf1ba6", "cast_crash_unittests": "c92de9b69f158cb7ef0f5c853d193b991403f354", "cast_graphics_unittests": "5d01079525ed149683e1ff867f516551d98578ec", "cast_media_unittests": "27a9880577f387124f841f4604346c50c02b7e5c", "cast_shell_unittests": "988c5a23b2b3af3b0bd534b255c30502e5e8cd9d", "cast_unittests": "6a9fc2e474062d03c73f0e6b2a6e74d15b3200f1", "components_browsertests": "edb658ceba9a1e4eae14c3f457cc028b8d4ee5fa", "components_unittests": "e2345997714503a0b0401d853dd10d790b95950f", "content_browsertests": "ed561fe4692ea8af6b6f6d99bb95b1f321c06926", "content_unittests": "a84b51a8f748a70c628d5257d0b8d07bf3ba1345", "crypto_unittests": "c3b14bf9eb10c81a897ab073831401184237c8a3", "events_unittests": "204d9a00d9015ce4d3e1f4c14fbfa222f08f0f74", "gcm_unit_tests": "15529bb664cfcf675d5350bd5481c96d63e6adf5", "gin_unittests": "215c95f11801d8097046b8cb2da3bf1ce3958a3e", "google_apis_unittests": "132c82cab23e50afd44cafcf25196d6aa17c9ed8", "gpu_unittests": "9d1ecfa50dd7b56908776042cf0b4e74b345c3b2", "ipc_tests": "8b22fd1dce29c63434044d809a68c38f0f7ef926", "jingle_unittests": "cd3355ae5ae7c07781bffcbfb29dff44862f1f80", "latency_unittests": "69472bac59fa6e21bea6e3fbc310d663716cc6b2", "libjingle_xmpp_unittests": "a3fd5d2e65a3e25ea84dbb074528d248e902c5f2", "media_blink_unittests": "9edaaf388ec98bd4e2b0990babbc36d55ed5cde3", "media_service_unittests": "6ef48543bc854bcd1ed6f5ece716a3f4dd721fcc", "media_unittests": "1f8288f66ee043c87a2b0e4400a045a0ce308627", "midi_unittests": "e98bb7113ee8f3dd06fb64527f23f772e994348e", "mojo_unittests": "ea511c2a358bcd5b1d92a00fe2b534a07665a2c7", "net_unittests": "d263d201a645dbaf173d86b66995f91b0c2f85e0", "sandbox_linux_unittests": "9f277ae41cbb10bcd5f653125cc2266a753ebf22", "services_unittests": "8694272f10f539a3dea403f0c167fc2a2cecae2d", "shell_dialogs_unittests": "ad9948a54718133bcadae6cb4dcf49cc836d56f6", "skia_unittests": "2661c2798b44691fdd57e72c7d6851745e001d15", "sql_unittests": "abe4760a54f3e608e1d2c86e2e2ba8dcdb486139", "storage_unittests": "cdecd2c13e49e4d8b54a4432b8d51caa0989c51e", "ui_base_unittests": "3d11abe606115e01b8868b490815a1a7da51494e", "ui_touch_selection_unittests": "80dc0ff44b74f1f1bb4ec71148bae0250cf3666c", "url_unittests": "10e34ac39eacc5255d0cd5f9724269bea7e1745d", "webkit_unit_tests": "c3aaa27b245559ff34c380cd5a60c0e9450d13c0", "wtf_unittests": "b12d270c631796b87bd941c2795cf86d445bfa5f"} isolate tests
swarm_hashes {"angle_unittests": "dcdc6334b6bdc4a346bd1f9bf97848b4ab0e248d", "base_unittests": "9237fa61781415fbbaa75d7ea0e7dc27e835f1ac", "blink_common_unittests": "bd2dc8fc662c78d2841c08dddeab549013a2bd35", "blink_heap_unittests": "2bd97d6bdb4a598319e3cb8446f49036d611b0e6", "blink_platform_unittests": "a03d9ae46c9aa1928af30658f85b2b503196edaf", "boringssl_crypto_tests": "8e4679ca5b1f6a922afcec547f5454a3a8bcf2dd", "boringssl_ssl_tests": "e565dbc8ed8363bb7aab6894e33472048930e7f3", "cacheinvalidation_unittests": "1de90d89abf921f0ae6d7dc9cde140b614491ed9", "capture_unittests": "8322c203dc221d24ce52bd47069c2c1769bbedea", "cast_audio_backend_unittests": "f34f31d94ede286b11d63d0fe3ba1461f5c5b63d", "cast_base_unittests": "9eecae5980aa98509bff8989dc5191f82ccf1ba6", "cast_crash_unittests": "c92de9b69f158cb7ef0f5c853d193b991403f354", "cast_graphics_unittests": "5d01079525ed149683e1ff867f516551d98578ec", "cast_media_unittests": "27a9880577f387124f841f4604346c50c02b7e5c", "cast_shell_unittests": "988c5a23b2b3af3b0bd534b255c30502e5e8cd9d", "cast_unittests": "6a9fc2e474062d03c73f0e6b2a6e74d15b3200f1", "components_browsertests": "edb658ceba9a1e4eae14c3f457cc028b8d4ee5fa", "components_unittests": "e2345997714503a0b0401d853dd10d790b95950f", "content_browsertests": "ed561fe4692ea8af6b6f6d99bb95b1f321c06926", "content_unittests": "a84b51a8f748a70c628d5257d0b8d07bf3ba1345", "crypto_unittests": "c3b14bf9eb10c81a897ab073831401184237c8a3", "events_unittests": "204d9a00d9015ce4d3e1f4c14fbfa222f08f0f74", "gcm_unit_tests": "15529bb664cfcf675d5350bd5481c96d63e6adf5", "gin_unittests": "215c95f11801d8097046b8cb2da3bf1ce3958a3e", "google_apis_unittests": "132c82cab23e50afd44cafcf25196d6aa17c9ed8", "gpu_unittests": "9d1ecfa50dd7b56908776042cf0b4e74b345c3b2", "ipc_tests": "8b22fd1dce29c63434044d809a68c38f0f7ef926", "jingle_unittests": "cd3355ae5ae7c07781bffcbfb29dff44862f1f80", "latency_unittests": "69472bac59fa6e21bea6e3fbc310d663716cc6b2", "libjingle_xmpp_unittests": "a3fd5d2e65a3e25ea84dbb074528d248e902c5f2", "media_blink_unittests": "9edaaf388ec98bd4e2b0990babbc36d55ed5cde3", "media_service_unittests": "6ef48543bc854bcd1ed6f5ece716a3f4dd721fcc", "media_unittests": "1f8288f66ee043c87a2b0e4400a045a0ce308627", "midi_unittests": "e98bb7113ee8f3dd06fb64527f23f772e994348e", "mojo_unittests": "ea511c2a358bcd5b1d92a00fe2b534a07665a2c7", "net_unittests": "d263d201a645dbaf173d86b66995f91b0c2f85e0", "sandbox_linux_unittests": "9f277ae41cbb10bcd5f653125cc2266a753ebf22", "services_unittests": "8694272f10f539a3dea403f0c167fc2a2cecae2d", "shell_dialogs_unittests": "ad9948a54718133bcadae6cb4dcf49cc836d56f6", "skia_unittests": "2661c2798b44691fdd57e72c7d6851745e001d15", "sql_unittests": "abe4760a54f3e608e1d2c86e2e2ba8dcdb486139", "storage_unittests": "cdecd2c13e49e4d8b54a4432b8d51caa0989c51e", "ui_base_unittests": "3d11abe606115e01b8868b490815a1a7da51494e", "ui_touch_selection_unittests": "80dc0ff44b74f1f1bb4ec71148bae0250cf3666c", "url_unittests": "10e34ac39eacc5255d0cd5f9724269bea7e1745d", "webkit_unit_tests": "c3aaa27b245559ff34c380cd5a60c0e9450d13c0", "wtf_unittests": "b12d270c631796b87bd941c2795cf86d445bfa5f"} find isolated tests

Blamelist:

  1. Jordy Greenblatt (jordynassohnoyoudont@chromium.org)
  2. Sandra Sun (sunyunjiaohnoyoudont@chromium.org)
  3. Bo Liu (boliuohnoyoudont@chromium.org)
  4. Kenneth Russell (kbrohnoyoudont@chromium.org)
  5. Victor Miura (vmiuraohnoyoudont@chromium.org)
  6. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  7. Michael Lippautz (mlippautzohnoyoudont@chromium.org)
  8. David Black (dmblackohnoyoudont@google.com)
  9. Lei Zhang (thestigohnoyoudont@chromium.org)
  10. Yuichiro Hanada (yhanadaohnoyoudont@chromium.org)
  11. Sadrul Habib Chowdhury (sadrulohnoyoudont@chromium.org)
  12. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  13. Mei Liang (meiliangohnoyoudont@chromium.org)
  14. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  15. Quan Nguyen (qnnguyenohnoyoudont@chromium.org)
  16. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  17. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  18. yiyix (yiyixohnoyoudont@chromium.org)
  19. Hiroshige Hayashizaki (hiroshigeohnoyoudont@chromium.org)

Timing:

Create Wednesday, 14-Nov-18 02:41:08 UTC
Start Wednesday, 14-Nov-18 02:41:10 UTC
End Wednesday, 14-Nov-18 03:47:26 UTC
Pending 2 secs
Execution 1 hrs 6 mins

All Changes:

  1. [CrOS Tether] Add chromeos switch for ignoring wired connections

    Changed by Jordy Greenblatt - jordynassohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:38:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 306f652506c5622c732f3b61e0d000074078b877

    Comments

    [CrOS Tether] Add chromeos switch for ignoring wired connections
    
    This adds a chromeos switch to allow tether host scans to occur in
    spite of ethernet connections. This is a followup to CL 1332693.
    
    -----
    
    TESTING:
    
    I confirmed manually that turning off the switch prevented a host scan
    when ethernet is plugged in while turning it on allowed the 'tether
    host found' notification.
    
    
    Bug: 904609
    Change-Id: If0938796841228415c72fb6ccc9b0a52c3d64786
    Reviewed-on: https://chromium-review.googlesource.com/c/1334206
    Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
    Reviewed-by: Jeremy Klein <jlklein@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607878}

    Changed files

    • chromeos/chromeos_switches.cc
    • chromeos/chromeos_switches.h
    • chromeos/components/tether/host_scan_scheduler_impl.cc
    • chromeos/components/tether/host_scan_scheduler_impl.h
    • chromeos/components/tether/host_scanner_impl.cc
    • chromeos/components/tether/host_scanner_impl.h
  2. Should clamp the scrolloffset during scroll animation.

    Changed by Sandra Sun - sunyunjiaohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:34:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 48c6865ab227d5776cd73a984ef34be7f90da2c0

    Comments

    Should clamp the scrolloffset during scroll animation.
    
    Currently, once we decide to animate a scroll to an offset, we update
    the scroll a little bit each frame until it reaches the specified
    offset.
    
    However, during the animation, the scroller's maximum scroll offset
    might become smaller than the specified offset. For example, on an
    android device, a user wants to find a string in a page. After tapping
    the 'search' icon on the virtual keyboard, the smooth scroll is
    initialized but the window's size becomes larger as the virtual
    keyboard disappears. In such cases, if we still decide to animate to
    the originally specified offset, the page won't be rendered correctly.
    We should always clamp the scroll offset during the animation.
    
    Bug: 902905
    Change-Id: I3a3117be0aff40bc012206d741f5142d12de2a7b
    Reviewed-on: https://chromium-review.googlesource.com/c/1329542
    Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
    Reviewed-by: David Bokan <bokan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607877}

    Changed files

    • third_party/WebKit/LayoutTests/fast/scroll-behavior/smooth-scroll/clamp-scroll-offset-if-size-changes-during-animation.html
    • third_party/blink/renderer/core/scroll/scroll_animator_compositor_coordinator.cc
  3. cc: Invalidate for needs_prepare_tiles

    Changed by Bo Liu - boliuohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:33:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 43a7801fe8d646b7099d5e72a151c8eab5a3bffc

    Comments

    cc: Invalidate for needs_prepare_tiles
    
    Problem is when CanDraw is false but needs_prepare_tiles is true
    Scheduler will keep requesting begin frames but do nothing in a
    begin frame since invalidate is blocked on CanDraw.
    
    We already have an efficient shortcut that does not involve actually
    producing a frame if invalidate is only requested for
    needs_prepare_tiles. So the simple fix is simply allow invalidates for
    this case.
    
    Bug: 900557
    Change-Id: Ib3c3e213e2e2461d7aa1b8dd8d2e91ab64042feb
    Reviewed-on: https://chromium-review.googlesource.com/c/1334550
    Commit-Queue: Bo <boliu@chromium.org>
    Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607876}

    Changed files

    • cc/scheduler/scheduler_state_machine.cc
    • cc/scheduler/scheduler_unittest.cc
  4. Allow SharedArrayBuffer with FlexibleArrayBufferView.

    Changed by Kenneth Russell - kbrohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:26:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9fd73df94beeba86347d3afb8b521269669a22fb

    Comments

    Allow SharedArrayBuffer with FlexibleArrayBufferView.
    
    Assertions fail when running multithreaded WebAssembly code which uses
    WebGL.
    
    Bug: 905000
    Change-Id: Ic45df5f43aa859a5f9225586f4836919ef31b54a
    Reviewed-on: https://chromium-review.googlesource.com/c/1334844
    Reviewed-by: James Darpinian <jdarpinian@chromium.org>
    Commit-Queue: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607875}

    Changed files

    • third_party/blink/renderer/core/typed_arrays/flexible_array_buffer_view.h
    • third_party/blink/renderer/modules/webgl/webgl2_rendering_context_base.idl
    • third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.idl
  5. Remove old *_scroll_200_layer_grid rendering stories.

    Changed by Victor Miura - vmiuraohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:23:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9d5ca99f28add2c0b844511a2416d1f555726c9b

    Comments

    Remove old *_scroll_200_layer_grid rendering stories.
    
    These stories are superceded by newer stories such as
    infinite_scroll_root_n_layers_99 and css_opacity_plus_n_layers_99.
    
    Now that we have had overlapping data from the new stories for some
    time, the old stories can be removed.
    
    BUG=878951
    
    Change-Id: Idb146ed7d9f5420bac1d5217e86c6547a772efe5
    Reviewed-on: https://chromium-review.googlesource.com/c/1334929
    Commit-Queue: Victor Miura <vmiura@chromium.org>
    Reviewed-by: Annie Sullivan <sullivan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607874}

    Changed files

    • tools/perf/page_sets/rendering/tough_compositor_cases.py
  6. Roll src/third_party/pdfium f768692bdef0..f28410e9eb26 (16 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 02:22:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 83f03e20f711be2eefa401ebf3dd4035976e5264

    Comments

    Roll src/third_party/pdfium f768692bdef0..f28410e9eb26 (16 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/f768692bdef0..f28410e9eb26
    
    
    git log f768692bdef0..f28410e9eb26 --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 tsepez@chromium.org Use {{include}} directive in more tests.
    2018-11-14 tsepez@chromium.org Introduce {{include}} directive for PDF file fixup.
    2018-11-14 tsepez@chromium.org Add CPDF_IndirectObjectHolder::New<T>()
    2018-11-13 thestig@chromium.org Add more tests for transfer function creation and usage.
    2018-11-12 tsepez@chromium.org Test pushbutton specific field properties.
    2018-11-10 thestig@chromium.org Roll tools/clang/ 3041f30dd..31f2d265b (4 commits)
    2018-11-10 thestig@chromium.org Roll build/ a09219387..81ffd0040 (178 commits)
    2018-11-10 thestig@chromium.org Roll buildtools/ 2dff9c9c7..fdce2ad26 (2 commits)
    2018-11-10 thestig@chromium.org Roll DEPS for catapult to 5d509166
    2018-11-10 thestig@chromium.org Roll third_party/googletest/src/ d52663267..2e68926a9 (68 commits)
    2018-11-10 thestig@chromium.org Roll third_party/instrumented_libraries/ 323cf3219..a959e4f0c (4 commits)
    2018-11-10 thestig@chromium.org Roll third_party/zlib/ dcf1d0f8c..dde5ce526 (6 commits)
    2018-11-10 thestig@chromium.org Roll third_party/depot_tools/ 71e3be7a5..ddbeac1c0 (78 commits; 12 trivial rolls)
    2018-11-10 thestig@chromium.org Roll third_party/icu/ c56c67199..45f655f2f (11 commits)
    2018-11-10 thestig@chromium.org Roll third_party/skia/ fa7df23d8..36b85be49 (158 commits; 11 trivial rolls)
    2018-11-10 thestig@chromium.org Roll third_party/freetype/src/ f56830ed4..fb0d66d04 (20 commits)
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@f28410e9eb26
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I532bd42f0153e67d50628395705ccd33a1350831
    Reviewed-on: https://chromium-review.googlesource.com/c/1334572
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607873}

    Changed files

    • DEPS
  7. [heap] Fix GC forbidden scopes for mixin construction

    Changed by Michael Lippautz - mlippautzohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:20:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ac99379aadb42b81baec1c5c3c1b44b9851a0ac7

    Comments

    [heap] Fix GC forbidden scopes for mixin construction
    
    Mixin construction relies on the fact that no garbage collection can be
    triggered.
    
    When moving to the new MakeGarbageCollected bottleneck the hook for
    mixin construction was dropped. This restores previous behavior.
    
    In a followup GarabgeCollectedMixin::operator new() should be inlined in
    the construct trait, creating the invariant that all operator new()
    methods are deleted for Oilpan.
    
    Bug: 904546, 757708
    Change-Id: I47e672f1cb3035d8a4bea72d90bfceb2a31c5d89
    Reviewed-on: https://chromium-review.googlesource.com/c/1333761
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607872}

    Changed files

    • third_party/blink/renderer/platform/heap/heap.h
    • third_party/blink/renderer/platform/heap/heap_test.cc
  8. Revise Assistant strings for Related Info.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 02:20:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 91af083690ca920d3d9dbef765b2f0eebdbd7dd0

    Comments

    Revise Assistant strings for Related Info.
    
    Per request, modifying Assistant strings for Related Info. These
    strings occur in Chrome Settings and Assistant OOBE.
    
    See bug for screenshots.
    
    Bug: b:119503388
    Change-Id: I9219c59dceac4207061e978efe68633f89d7034b
    Reviewed-on: https://chromium-review.googlesource.com/c/1334279
    Reviewed-by: Ken Rockot <rockot@google.com>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: David Black <dmblack@google.com>
    Cr-Commit-Position: refs/heads/master@{#607871}

    Changed files

    • chrome/app/chromeos_strings.grdp
    • chrome/app/settings_strings.grdp
  9. Sort flag descriptions.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:19:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0a318aff84d336a795b51456383b8e830594a2a4

    Comments

    Sort flag descriptions.
    
    Move some out of place flag descriptions to the right sections.
    
    Change-Id: I61569c122d8b5c93adcad002661a13fc33dcd14a
    Reviewed-on: https://chromium-review.googlesource.com/c/1330893
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Reviewed-by: Becca Hughes <beccahughes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607870}

    Changed files

    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
  10. Reland: Disable Android IMEs according to given ImeInfo.

    Changed by Yuichiro Hanada - yhanadaohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:19:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e3199eebf9f6278aa9ce8914b9315f6de041471b

    Comments

    Reland: Disable Android IMEs according to given ImeInfo.
    
    The original CL is crrev.com/c/1331294 and it was reverted due to
    MSan failure. The failure should be fixed by adding initialization for
    |is_removing_imm_entry_|.
    
    Android IMEs can be disabled in Android side by using 'ime' command.
    This CL ensures that disabled IMEs are also disabled in Chrome OS's
    InputMethodManager.
    
    Bug: b/119274469
    Change-Id: I4f9067cabf96fcb28d594a72856df1e34d469114
    Reviewed-on: https://chromium-review.googlesource.com/c/1334672
    Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
    Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607869}

    Changed files

    • chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service.cc
    • chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service.h
  11. cc: Make sure a CompletionEvent is always signaled.

    Changed by Sadrul Habib Chowdhury - sadrulohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:18:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 02d11389962b1a683fe21f2e0bbb5ff4e75bf271

    Comments

    cc: Make sure a CompletionEvent is always signaled.
    
    It looks like there is a CompletionEvent that is never getting signaled
    from the compositor thread, and the main-thread stays blocked on it.
    This causes a fair number of hangs in the renderers (~30% of all hangs
    or crashes in cc/ code in stable channel on Windows). Try using a
    ScopedCompletionEvent to make sure all CompletionEvents are always
    signaled, and see if that helps.
    
    BUG=622080
    
    Change-Id: Ic25089f0e4f671182b18c1b44e278196eeb040c2
    Reviewed-on: https://chromium-review.googlesource.com/c/1332726
    Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
    Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607868}

    Changed files

    • cc/trees/proxy_impl.cc
    • cc/trees/proxy_impl.h
  12. Roll src/third_party/catapult 6d64a5e5e40b..6ce627d2b73d (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 02:18:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 536b73ebdf0e46c85bf316c9955b2742ec03b502

    Comments

    Roll src/third_party/catapult 6d64a5e5e40b..6ce627d2b73d (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/6d64a5e5e40b..6ce627d2b73d
    
    
    git log 6d64a5e5e40b..6ce627d2b73d --date=short --no-merges --format='%ad %ae %s'
    2018-11-13 benjhayden@chromium.org Add place-holder for v2spa.
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@6ce627d2b73d
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=sullivan@chromium.org
    
    Change-Id: Ib7d97fbe1d8d8c99104429375797b359ca00350d
    Reviewed-on: https://chromium-review.googlesource.com/c/1334587
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607867}

    Changed files

    • DEPS
  13. Follow up on histograms added in CL:1313550

    Changed by Mei Liang - meiliangohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:17:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e45f8be19fdb67b95053e3667ef83837d52e5a36

    Comments

    Follow up on histograms added in CL:1313550
    
    This CL updates the histogram metadata.
    
    Bug: 890502
    Change-Id: I20fa1f69a3b7fc720fc314d2be98bff6fd175415
    Reviewed-on: https://chromium-review.googlesource.com/c/1333781
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Commit-Queue: Ilya Sherman <isherman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607866}

    Changed files

    • tools/metrics/histograms/histograms.xml
  14. Update V8 to version 7.2.320.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 02:17:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0fe1eeb424e7372ad6b171e969e195d043416b50

    Comments

    Update V8 to version 7.2.320.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/9d32daac..dd90e943
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: Iaa8537cab02e312ed8ee99a20c6bc64ed446c2b3
    Reviewed-on: https://chromium-review.googlesource.com/c/1334562
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607865}

    Changed files

    • DEPS
  15. cros: Fix long emails messing up Remove User button placement

    Changed by Quan Nguyen - qnnguyenohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:16:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 96f5ccc36864e1cf5867211d7d0eea29fa2d7c80

    Comments

    cros: Fix long emails messing up Remove User button placement
    
    The email label now uses the same layout rule as the user name label, which
    fixes the same bug, but for long emails rather than long user names.
    
    Bug: 902362
    Change-Id: Icfde3129078ffd6a5977b388210bf2773e0ee405
    Reviewed-on: https://chromium-review.googlesource.com/c/1334827
    Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607864}

    Changed files

    • ash/login/ui/login_bubble.cc
    • ash/login/ui/login_bubble_unittest.cc
  16. Roll src/third_party/skia 9d958b54af30..6c242459120d (5 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 02:16:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b6aac239b9d6eb64f7dd7ee9806b17ee7cd9a9e1

    Comments

    Roll src/third_party/skia 9d958b54af30..6c242459120d (5 commits)
    
    https://skia.googlesource.com/skia.git/+log/9d958b54af30..6c242459120d
    
    
    git log 9d958b54af30..6c242459120d --date=short --no-merges --format='%ad %ae %s'
    2018-11-13 brianosman@google.com Remove SK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS from Skia's Chromium GN
    2018-11-13 scroggo@google.com Remove unused SkPath::unique()
    2018-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6ed398b46847..b3c4d88a647a (1 commits)
    2018-11-13 scroggo@google.com Build custom empty SkFontMgr for Android Framework
    2018-11-13 jvanverth@google.com Avoid overflow in bufferOffset calculations
    
    
    Created with:
      gclient setdep -r src/third_party/skia@6c242459120d
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    
    BUG=chromium:b/118742766
    TBR=rmistry@chromium.org
    
    Change-Id: Ife94330d4007392c300980f4c387e0fd8267bcb7
    Reviewed-on: https://chromium-review.googlesource.com/c/1334249
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607863}

    Changed files

    • DEPS
  17. Roll src/third_party/angle f9143725470b..d1a55e393e65 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 02:15:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 36d98fc346b8506fb91139149e605c6d7b57bc80

    Comments

    Roll src/third_party/angle f9143725470b..d1a55e393e65 (1 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/f9143725470b..d1a55e393e65
    
    
    git log f9143725470b..d1a55e393e65 --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 jmadill@chromium.org Expand dEQP-GLES3 suppressions.
    
    
    Created with:
      gclient setdep -r src/third_party/angle@d1a55e393e65
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:822310
    TBR=cwallez@chromium.org
    
    Change-Id: I707d1a122db30dcf53255adc0ee1a749552ffe02
    Reviewed-on: https://chromium-review.googlesource.com/c/1334570
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607862}

    Changed files

    • DEPS
  18. FrameMetrics: Track the skipped frame rate during scrolling event only

    Changed by yiyix - yiyixohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:15:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 08e71a98c5f020c4af56d2a092512bb87742c1db

    Comments

    FrameMetrics: Track the skipped frame rate during scrolling event only
    
    Skipped Frame tracker used to record every frame produced at all times.
    With that approach, it's hard to study the correlation between the user
    actions and the skipped frame rate. In this patch, we only track the
    skipped frame rate during scrolling events. More user actions will be
    added in the future cls.
    
    Design doc on skipped frame tracker:
    https://docs.google.com/document/d/1SqqdQsdh9CA5SRHCvkI_FDcc-vBW-saEj1kh4-qTBwg
    
    Videos on how it used to work:
    https://drive.google.com/open?id=1S5fnq8VrqvUIYFZjvIi4GNA3ekIdggG0
    
    Bug: 894149
    
    Change-Id: I02441cb5c9f551cc80b51ea1dcbafa3c492cb5ce
    Reviewed-on: https://chromium-review.googlesource.com/c/1334103
    Reviewed-by: danakj <danakj@chromium.org>
    Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
    Commit-Queue: Yi Xu <yiyix@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607861}

    Changed files

    • cc/trees/layer_tree_host_impl.cc
    • ui/latency/skipped_frame_tracker_unittest.cc
  19. Implement FetchClientSettingsObject::GetHttpsState()

    Changed by Hiroshige Hayashizaki - hiroshigeohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:14:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e2de0f9a45dc3e898f5c784f1054667d662c5e10

    Comments

    Implement FetchClientSettingsObject::GetHttpsState()
    
    Previously, FetchClientSettingsObjectImpl
    - Is used as WorkerFetchContext's FetchClientSettingsObject,
    - Implements GetHttpsState(), and
    - Is used for checking mixed contents on workers.
    
    Issue 880027 will introduce outsideSettings WorkerFetchContext
    which will have FetchClientSettingsObjectSnapshot as its
    FetchClientSettingsObject [1].
    
    Therefore, this CL switches
    - WorkerFetchContext's FetchClientSettingsObject and
    - MixedContentChecker::IsMixedContent()
    to use FetchClientSettingsObject (not ...Impl), and
    implements GetHttpsState() in FetchClientSettingsObject
    and FetchClientSettingsObjectSnapshot.
    
    This CL shouldn't change the behavior at this time, because
    WorkerFetchContext's FetchClientSettingsObject is still
    a FetchClientSettingsObjectImpl object, and thus mixed content
    checks is done using already-implemented
    FetchClientSettingsObjectImpl::GetHttpsState().
    
    The code path added in this CL will be used in [2].
    
    [1] https://chromium-review.googlesource.com/1328043
    [2] https://chromium-review.googlesource.com/1328164
    
    Bug: 880027
    Change-Id: I399694bd239c21fe9b5a650fcb689fb2c98572f5
    Reviewed-on: https://chromium-review.googlesource.com/c/1328162
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Reviewed-by: Mike West <mkwst@chromium.org>
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607860}

    Changed files

    • third_party/blink/renderer/core/execution_context/execution_context.cc
    • third_party/blink/renderer/core/loader/frame_fetch_context.cc
    • third_party/blink/renderer/core/loader/mixed_content_checker.cc
    • third_party/blink/renderer/core/loader/mixed_content_checker.h
    • third_party/blink/renderer/core/loader/worker_fetch_context.cc
    • third_party/blink/renderer/core/loader/worker_fetch_context.h
    • third_party/blink/renderer/core/script/fetch_client_settings_object_impl.h
    • third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object.h
    • third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object_snapshot.cc
    • third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object_snapshot.h
    • third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
    • third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h