Home | Search | chromium - Builders
Login

Builder Android Build 88125 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revisionf7c234b0272dff6ce746e9eaac813497986913c3
Got Revisionf7c234b0272dff6ce746e9eaac813497986913c3

Execution:

Steps and Logfiles:

Show:
  1. ( 294 ms ) setup_build
    running recipe: "chromium"
  2. ( 1 secs ) remove .cipd
  3. ( 53 secs ) bot_update
    [77GB/295GB used (26%)]
  4. ( 0 ) ensure_goma
  5. ( 747 ms ) swarming.py --version
    0.13
  6. ( 12 secs ) clobber
  7. ( 11 secs ) gclient runhooks
  8. ( 237 ms ) read test spec (chromium.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.json
  9. ( 3 secs ) clean local files
  10. ( 938 ms ) tree truth steps
  11. ( 23 mins 7 secs ) compile
  12. ( 3 secs ) compile confirm no-op
    This should have been a no-op, but it wasn't.
  13. ( 8 secs ) archive_build

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm581-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531413683550050, "id": "8941190081316390256", "project": "chromium", "tags": ["builder:Android", "buildset:commit/git/f7c234b0272dff6ce746e9eaac813497986913c3", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/f7c234b0272dff6ce746e9eaac813497986913c3", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106620143501341024", "scheduler_job_id:chromium/Android", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Android" setup_build
buildnumber 88125 setup_build
mastername "chromium" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "f7c234b0272dff6ce746e9eaac813497986913c3" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "f7c234b0272dff6ce746e9eaac813497986913c3" bot_update
got_revision_cp "refs/heads/master@{#574598}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23950}" bot_update

Blamelist:

  1. Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
  2. Becky Zhou (huayinzohnoyoudont@chromium.org)
  3. Nico Weber (thakisohnoyoudont@chromium.org)
  4. David Grogan (dgroganohnoyoudont@chromium.org)
  5. Nick Burris (nburrisohnoyoudont@google.com)
  6. Rayan Kanso (rayankansohnoyoudont@chromium.org)
  7. Mike Reed (reedohnoyoudont@google.com)
  8. Peter E Conn (peconnohnoyoudont@chromium.org)
  9. Peter Kasting (pkastingohnoyoudont@chromium.org)
  10. Takuto Ikuta (tikutaohnoyoudont@chromium.org)
  11. Jay Civelli (jcivelliohnoyoudont@google.com)
  12. Stefan Zager (szagerohnoyoudont@chromium.org)
  13. Bruce Dawson (brucedawsonohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 16:41:23 UTC
Start Thursday, 12-Jul-18 16:41:28 UTC
End Thursday, 12-Jul-18 17:07:05 UTC
Pending 4 secs
Execution 25 mins 37 secs

All Changes:

  1. [Fuchsia] Address CR comments in sys::Runner implementation

    Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:39:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f7c234b0272dff6ce746e9eaac813497986913c3

    Comments

    [Fuchsia] Address CR comments in sys::Runner implementation
    
    When addressing comments on https://crrev.com//c//1114377 I hit CQ+1
    prematurely and landed the change without my changes that addresed
    review comments. Landing them separately.
    
    Bug: 856416
    Change-Id: I1b691d824f381e9ec0a75ff7ce90b2f45171c13a
    Reviewed-on: https://chromium-review.googlesource.com/1133968
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574598}

    Changed files

    • webrunner/BUILD.gn
    • webrunner/app/component_controller_impl.cc
    • webrunner/app/component_controller_impl.h
    • webrunner/app/main.cc
    • webrunner/app/web_content_runner.cc
    • webrunner/app/web_content_runner.h
  2. [Feed] Scroll and focus handling for the FeedNewTabPage

    Changed by Becky Zhou - huayinzohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:36:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b54d1975f16b7efae2408a1428fbde7207556a29

    Comments

    [Feed] Scroll and focus handling for the FeedNewTabPage
    
    + Implement NewTabPageLayout.ScrollDelegate to the FeedNewTabPage
    + Refactor snap scroll logic to a new class to make it reusable
    + Add top padding for the FeedNewTabPage to display correctly on tablet
    + Fix a small bug that search box is not enabled after auto snap scroll
    
    Bug: 860028, 860032, 862470
    Change-Id: I5bda9696a4515281378c1effe47b6ad47fdd4c49
    Reviewed-on: https://chromium-review.googlesource.com/1133594
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Becky Zhou <huayinz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574597}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/SnapScrollHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java
  3. Remove most android-specific hard_timeout and shard overrides.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:35:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1a64d6771d8b24f079f24e41ebaf14f672747084

    Comments

    Remove most android-specific hard_timeout and shard overrides.
    
    These were added during android swarming bring-up.  We shouldn't use
    per-bot exceptions for this.
    
    Also remove a random sharding setting for base_unittests on ToTMac
    that doesn't look necessary.
    
    Bug: 843511
    Change-Id: Ia20771786f1b4106cd86d24d446e0a66f319dbff
    Reviewed-on: https://chromium-review.googlesource.com/1134531
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574596}

    Changed files

    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.swarm.json
    • testing/buildbot/test_suite_exceptions.pyl
  4. [css-tables] Make table's max-content honor captions' min-content

    Changed by David Grogan - dgroganohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:34:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dff5931455e0302289a3cc9027fd3f98cfe22fca

    Comments

    [css-tables] Make table's max-content honor captions' min-content
    
    Table's min-content already honored it.
    
    We'd apparently never been bitten before by tables occasionally having
    min-content > max-content. A new DCHECK in LayoutNG exposed it.
    
    Bug: 857185
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I49009a4988fbf38c1bf745a4f028e4e8b050804b
    Reviewed-on: https://chromium-review.googlesource.com/1121251
    Commit-Queue: David Grogan <dgrogan@chromium.org>
    Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574595}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/fast/table/caption-min-greater-than-max-crash.html
    • third_party/WebKit/LayoutTests/fast/table/spans-min-greater-than-max-crash.html
    • third_party/blink/renderer/core/layout/layout_table.cc
    • third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
  5. Settings WebUI: Fix extensions url on cleanup result page

    Changed by Nick Burris - nburrisohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:33:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7cde465a809facc9ecb61350aaa5c504a36d9174

    Comments

    Settings WebUI: Fix extensions url on cleanup result page
    
    The cleaner success string now has HTML in it, and the JS i18n
    function strips it off. i18nAdvanced allows us to let the <a> through to
    the string, but the way the cleanup result page works is it simply sets
    the card text variable ("title") to the result message string. This
    would result in the raw string (with HTML) getting displayed, so the
    title variable needs to also be set to be the inner-h-t-m-l.
    
    Bug: 853339
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I8ea98e9868f83fc14a674841072cc2915c7b4a48
    Reviewed-on: https://chromium-review.googlesource.com/1134191
    Commit-Queue: Nick Burris <nburris@google.com>
    Reviewed-by: proberge <proberge@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574594}

    Changed files

    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
    • chrome/test/data/webui/settings/chrome_cleanup_page_test.js
  6. [Background Fetch] Add DB corruption handler to data manager observer.

    Changed by Rayan Kanso - rayankansohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:31:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 96544636e959581575b9c4f1ac2ecd1c5f40296d

    Comments

    [Background Fetch] Add DB corruption handler to data manager observer.
    
    Bug: 850512
    Change-Id: Iddd2773f63fd7aa0368e980a347c1bef4312f23d
    Reviewed-on: https://chromium-review.googlesource.com/1128839
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574593}

    Changed files

    • content/browser/background_fetch/background_fetch_context.cc
    • content/browser/background_fetch/background_fetch_context.h
    • content/browser/background_fetch/background_fetch_data_manager.cc
    • content/browser/background_fetch/background_fetch_data_manager.h
    • content/browser/background_fetch/background_fetch_data_manager_observer.h
    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.cc
    • content/browser/background_fetch/storage/database_task.cc
    • content/browser/background_fetch/storage/database_task.h
    • content/browser/background_fetch/storage/delete_registration_task.cc
    • content/browser/background_fetch/storage/get_settled_fetches_task.cc
    • content/browser/background_fetch/storage/mark_registration_for_deletion_task.cc
    • content/browser/background_fetch/storage/start_next_pending_request_task.cc
  7. suppress until skia roll

    Changed by Mike Reed - reedohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:30:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dcf8a49d5e3d2440dfc3f8e3126fa266fd25a33b

    Comments

    suppress until skia roll
    
    Bug: 863042
    Change-Id: I97a48047d0b6546055c255538fc31ddcc0a07078
    Reviewed-on: https://chromium-review.googlesource.com/1135288
    Commit-Queue: Mike Reed <reed@chromium.org>
    Commit-Queue: Florin Malita <fmalita@chromium.org>
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574592}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  8. 🤝 Add flag to force showing TWA disclosure.

    Changed by Peter E Conn - peconnohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:28:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 967fc76c423a5e86fc2e04b4655aa463d2ae7c12

    Comments

    🤝 Add flag to force showing TWA disclosure.
    
    Add a flag to force showing the disclosure for developer convenience.
    Also trigger even when there isn't an active tab yet.
    
    Bug: 813100
    Change-Id: I3ccd820d58f82040723a8f8a72097262ba374b82
    Reviewed-on: https://chromium-review.googlesource.com/1116922
    Reviewed-by: Benoit L <lizeb@chromium.org>
    Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
    Commit-Queue: Peter Conn <peconn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574591}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
    • chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
  9. Once TabStrip doesn't need it, there's no reason to expose GetTopOffset().

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:28:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b2b9af8ace2bbc3384147241601d4293f0c2259

    Comments

    Once TabStrip doesn't need it, there's no reason to expose GetTopOffset().
    
    Bug: none
    Change-Id: Ia78dd54f4364e7010ddf3ce16b01e5f5f3c764e4
    Reviewed-on: https://chromium-review.googlesource.com/1134499
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Allen Bauer <kylixrd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574590}

    Changed files

    • chrome/browser/ui/views/tabs/new_tab_button.cc
    • chrome/browser/ui/views/tabs/new_tab_button.h
  10. Keep timestamp in aar.py when file is not changed

    Changed by Takuto Ikuta - tikutaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:22:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d186e03f89aa3fa40dc7266cbc33a0310ac3dd8

    Comments

    Keep timestamp in aar.py when file is not changed
    
    This is a reland of
    https://chromium-review.googlesource.com/c/chromium/src/+/1127565
    I didn't understand filecmp.dircmp.
    
    Changed to use md5_check.CallAndRecordIfStale instead.
    Also let ExtractAll create directory even when it is empty.
    
    Bug: 810298, 860251
    Change-Id: I0d1e2e385ff1a12981473ef422099f638ca174cf
    Reviewed-on: https://chromium-review.googlesource.com/1132818
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574589}

    Changed files

    • build/android/gyp/aar.py
    • build/android/gyp/util/build_utils.py
  11. Simplify FakeGaiaCookieManagerService

    Changed by Jay Civelli - jcivelliohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:18:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8

    Comments

    Simplify FakeGaiaCookieManagerService
    
    Simplifying the FakeGaiaCookieManagerService API by not requiring to
    call Init() with a FakeURLFetcherFactory. The FakeURLFetcherFactory is
    instead a member of the FakeGaiaCookieManagerService.
    
    This API simplification is in preparation for switching GaiaAuthFetcher
    to use the SimpleURLLoader (network service).
    
    Bug: 840396
    Change-Id: I917e4236a53bf251c3a8e82c868d5e4d99655aca
    Reviewed-on: https://chromium-review.googlesource.com/1114226
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Commit-Queue: Jay Civelli <jcivelli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574588}

    Changed files

    • chrome/browser/extensions/api/identity/identity_apitest.cc
    • chrome/browser/search/one_google_bar/one_google_bar_service_unittest.cc
    • chrome/browser/signin/dice_response_handler_unittest.cc
    • chrome/browser/signin/fake_gaia_cookie_manager_service_builder.cc
    • chrome/browser/signin/fake_gaia_cookie_manager_service_builder.h
    • chrome/browser/signin/signin_ui_util_unittest.cc
    • chrome/browser/supervised_user/child_accounts/child_account_service_unittest.cc
    • chrome/browser/ui/views/frame/test_with_browser_view.cc
    • chrome/browser/ui/views/frame/test_with_browser_view.h
    • components/search_provider_logos/logo_service_impl_unittest.cc
    • components/signin/core/browser/account_investigator_unittest.cc
    • components/signin/core/browser/account_reconcilor_unittest.cc
    • components/signin/core/browser/fake_gaia_cookie_manager_service.cc
    • components/signin/core/browser/fake_gaia_cookie_manager_service.h
    • components/signin/core/browser/signin_manager_unittest.cc
  12. Get rid of GraphicsLayer::scrollable_area_

    Changed by Stefan Zager - szagerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:18:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 442f13b7e97747ab09612a101159b1eb26072382

    Comments

    Get rid of GraphicsLayer::scrollable_area_
    
    The only place where it was actually used was in
    GraphicsLayer::SetScrollbarsHiddenIfOverlay, so just forward that
    call to the GraphicsLayerClient.
    
    BUG=823365
    R=pdr@chromium.org,skobes@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I3cdd24ceb1ab51563dbc3b6d9ce50ce9edc77bf8
    Reviewed-on: https://chromium-review.googlesource.com/1132536
    Commit-Queue: Stefan Zager <szager@chromium.org>
    Reviewed-by: Steve Kobes <skobes@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574587}

    Changed files

    • third_party/blink/renderer/core/frame/visual_viewport.cc
    • third_party/blink/renderer/core/frame/visual_viewport.h
    • third_party/blink/renderer/core/layout/scrollbars_test.cc
    • third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
    • third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.h
    • third_party/blink/renderer/core/paint/compositing/graphics_layer_tree_as_text.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer.h
    • third_party/blink/renderer/platform/graphics/graphics_layer_client.h
  13. Add "latency" to list of ETW-traceable events

    Changed by Bruce Dawson - brucedawsonohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:15:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a5d9a9d75a9a8f7f6fb9d749c9b797eb2550d34e

    Comments

    Add "latency" to list of ETW-traceable events
    
    The "latency" category looks like a perfect event category for ETW
    tracing. In particular, TabSwitching::Latency indicates when Chrome
    thinks that tab switching has started and stopped which allows it to be
    profiled in detail. This has revealed where CPU time is going, and how
    long the delay is from when the keyboard event is generated to when
    Chrome starts officially processing it. This was helpful in
    investigating tab switching latency in bug 858944.
    
    This will require an update to UIforETW to fully enable, which I have
    done locally for testing purposes.
    
    Bug: 858944
    Change-Id: I4797b804ea6d35458aa3b4e876a78172a29d5131
    Reviewed-on: https://chromium-review.googlesource.com/1134516
    Reviewed-by: Primiano Tucci <primiano@chromium.org>
    Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574586}

    Changed files

    • base/trace_event/trace_event_etw_export_win.cc