Home | Search | chromium - Builders
Login

Builder Android arm Builder (dbg) Build 37874 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision40a6cb9be79a8d05395498a705e59d50cbb77f57
Got Revision40a6cb9be79a8d05395498a705e59d50cbb77f57

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
  2. Alexandre Courbot (acourbotohnoyoudont@chromium.org)
  3. Jochen Eisinger (jochenohnoyoudont@chromium.org)
  4. Yuta Kitamura (yutakohnoyoudont@chromium.org)
  5. Eliot Courtney (edcourtneyohnoyoudont@google.com)
  6. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  7. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  8. Amos Lim (eui-sang.limohnoyoudont@samsung.com)
  9. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
  10. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  11. momohatt (momohatt10ohnoyoudont@gmail.com)
  12. Noel Gordon (noelohnoyoudont@chromium.org)
  13. John Z Wu (jzwohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 08:06:39 UTC
Start Friday, 12-Oct-18 08:06:44 UTC
End Friday, 12-Oct-18 09:11:30 UTC
Pending 4 secs
Execution 1 hrs 4 mins

All Changes:

  1. Fix naming issue when renaming files inside My files

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:02:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 40a6cb9be79a8d05395498a705e59d50cbb77f57

    Comments

    Fix naming issue when renaming files inside My files
    
    Change DirectoryModel to "unwrap" VolumeEntry when it's selected via
    file list. This fixes the issue where after selecting a VolumeEntry any
    operation in the private API would fail because it wouldn't be able to
    send a VolumeEntry to private API, because it requires a real Entry.
    
    This fixes the user issue of trying to rename and always getting "Use
    shorter name" error, even with a short name.
    
    Update FakeEntry to be an implementation of FilesAppDirEntry, since all
    users were using as directory, also update some functions to typing to
    use FilesAppDirEntry instead of FakeEntry which is more correct.
    
    Test: browser_tests --gtest_filter="*/myFilesFolderRename"
    Bug: 889636
    Change-Id: Ieb75ffbb811a91e4742fb7a49a3badfd129376ad
    Reviewed-on: https://chromium-review.googlesource.com/c/1276067
    Reviewed-by: Joel Hockey <joelhockey@chromium.org>
    Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599136}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • ui/file_manager/file_manager/background/js/volume_info_impl.js
    • ui/file_manager/file_manager/common/js/files_app_entry_types.js
    • ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.js
    • ui/file_manager/file_manager/foreground/js/directory_model.js
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
    • ui/file_manager/file_manager/foreground/js/file_watcher.js
    • ui/file_manager/integration_tests/file_manager/my_files.js
  2. media/gpu/v4l2: workaround VIDIOC_G_FMT bug in libtegrav4l2.so.

    Changed by Alexandre Courbot - acourbotohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:54:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 029544dab67d79059b7610a92890091520ef7603

    Comments

    media/gpu/v4l2: workaround VIDIOC_G_FMT bug in libtegrav4l2.so.
    
    libtegrav4l2.so's implementation of V4L2_G_FMT has a bug which will make
    it return 0 planes for single-plane multiplanar formats. We obviously
    cannot have a multiplanar format with 0 planes, so add a workaround at
    the fake-ioctl level. Implement it as a case-switch for future-proofing
    against other workarounds we will likely have to add.
    
    Also add a few recommendations in v4l2_device.cc against the temptation
    to spare some memory by using an appropriately-sized array of
    v4l2_planes: it turns out libv4l2 also likes to write above the number
    of passed planes, and using anything shorter than VIDEO_MAX_PLANES will
    result in memory corruption DCHECKS being raised.
    
    BUG=893661
    TEST=Checked that VDA unittest was passing on both hana and nyan_big.
    
    Change-Id: I7ea638f19f5bf0bdfaa0a47885577eb9dec4c225
    Reviewed-on: https://chromium-review.googlesource.com/c/1275727
    Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
    Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
    Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599135}

    Changed files

    • media/gpu/v4l2/tegra_v4l2_device.cc
    • media/gpu/v4l2/v4l2_device.cc
  3. Add browser tests for when we show the cookie exception

    Changed by Jochen Eisinger - jochenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:53:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df554d02051d43d493d30cdf39fb1ee7566355bf

    Comments

    Add browser tests for when we show the cookie exception
    
    Depending on the sync / sign-in state.
    
    BUG=890925
    R=tangltom@chromium.org, msarda@chromium.org
    
    Change-Id: I784f13a4981250f851df770d111a13969a6892a6
    Reviewed-on: https://chromium-review.googlesource.com/c/1273521
    Commit-Queue: Jochen Eisinger <jochen@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599134}

    Changed files

    • chrome/browser/browsing_data/counters/browsing_data_counter_utils_browsertest.cc
    • chrome/test/BUILD.gn
  4. Move thread-related functionalities in Platform to Thread.

    Changed by Yuta Kitamura - yutakohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:47:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9deeac4682dc2c2a45fdf483c376c75011a09241

    Comments

    Move thread-related functionalities in Platform to Thread.
    
    This CL moves the most of implementation for Thread in Platform to
    Thread, so the Platform would contain less implementation (ideally,
    Platform should be a pure interface to embedders).
    
    Previously the global state of threads was stored in Platform, and
    this CL moves it to Thread. Now the thread-local storage for Blink
    threads and the main and compositor thread objects are stored as
    the global variable in thread.cc. This way, the threads state is
    completely separated from Platform. Old threading functions in
    Platform are deprecated now, and they will be migrated to Thread ones
    later.
    
    Due to those changes, some test utilities need to be updated. As the
    state of threads is not stored in Platform, the tests that need to
    override their main thread have to do that by themselves. To
    facilitate this, two new utility classes, ScopedMainThreadOverrider
    and ScopedSchedulerOverrider, are introduced, and TestingPlatform-
    SupportWithCustomScheduler is removed in favor of the new utilities.
    
    Bug: 826203
    Change-Id: Ieb702dc85b7ffd75991055038f1165c2bfd7d058
    Reviewed-on: https://chromium-review.googlesource.com/c/1273115
    Commit-Queue: Yuta Kitamura <yutak@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599133}

    Changed files

    • content/renderer/render_thread_impl.cc
    • third_party/blink/public/platform/platform.h
    • third_party/blink/renderer/core/dom/idle_deadline_test.cc
    • third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/exported/platform.cc
    • third_party/blink/renderer/platform/scheduler/common/thread.cc
    • third_party/blink/renderer/platform/scheduler/public/thread.h
    • third_party/blink/renderer/platform/testing/scoped_main_thread_overrider.cc
    • third_party/blink/renderer/platform/testing/scoped_main_thread_overrider.h
    • third_party/blink/renderer/platform/testing/scoped_scheduler_overrider.cc
    • third_party/blink/renderer/platform/testing/scoped_scheduler_overrider.h
    • third_party/blink/renderer/platform/testing/testing_platform_support.cc
    • third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.cc
    • third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.h
    • third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.cc
    • third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.h
  5. Let ClientControlledState apply animation during bounds change.

    Changed by Eliot Courtney - edcourtneyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 07:45:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 68084907a40caccccb72dd14c0ad3139b97747f7

    Comments

    Let ClientControlledState apply animation during bounds change.
    
    This CL introduces a new BoundsChangeAnimationType for
    ClientControlledState which will animate the window bounds for a
    specified duration.
    
    Bug: b/115291749
    Bug: 841886
    Test: Tested with local PIP prototype - applies animation.
    Change-Id: I8eda8b2131b8d3f679ade5cfbe64d7378efd6881
    Reviewed-on: https://chromium-review.googlesource.com/c/1218385
    Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599132}

    Changed files

    • ash/wm/client_controlled_state.cc
    • ash/wm/client_controlled_state.h
    • ash/wm/client_controlled_state_unittest.cc
    • ash/wm/default_state.cc
    • ash/wm/window_state.cc
    • ash/wm/window_state.h
    • ash/wm/wm_event.cc
    • ash/wm/wm_event.h
    • components/exo/client_controlled_shell_surface.cc
    • components/exo/client_controlled_shell_surface_unittest.cc
  6. [iOS] Remove ReadingList empty view

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:44:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a53cbb1cdf96e0695e4d24cd408b52cc826d5088

    Comments

    [iOS] Remove ReadingList empty view
    
    This view was used in the old ReadingList implementation.
    
    Bug: none
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Id4fa1df5a00f0dd572a2d4951764f422231e3874
    Reviewed-on: https://chromium-review.googlesource.com/c/1276966
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599131}

    Changed files

    • ios/chrome/browser/ui/reading_list/BUILD.gn
    • ios/chrome/browser/ui/reading_list/empty_reading_list_background_view.h
    • ios/chrome/browser/ui/reading_list/empty_reading_list_background_view.mm
    • ios/chrome/browser/ui/reading_list/reading_list_egtest.mm
  7. Chrome OS: Integrate PIN setup into Discover UI

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:43:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f479db8f992be027ddc9b715919df65ad4e40bb6

    Comments

    Chrome OS: Integrate PIN setup into Discover UI
    
    Bug: 852553
    Change-Id: I460a420b1dd0024eaebb114aac2368a7bb3f28ae
    Reviewed-on: https://chromium-review.googlesource.com/c/1249496
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599130}

    Changed files

    • chrome/app/chromeos_strings.grdp
    • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP.png.sha1
    • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_DONE.png.sha1
    • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_PASSWORD_SUBTITLE.png.sha1
    • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_PASSWORD_TITLE.png.sha1
    • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_SUBTITLE3.png.sha1
    • chrome/browser/chromeos/login/session/user_session_manager.cc
    • chrome/browser/resources/chromeos/login/discover/discover_app.html
    • chrome/browser/resources/chromeos/login/discover/discover_app.js
    • chrome/browser/resources/chromeos/login/discover/discover_components.html
    • chrome/browser/resources/chromeos/login/discover/discover_components.js
    • chrome/browser/resources/chromeos/login/discover/discover_module_behavior.js
    • chrome/browser/resources/chromeos/login/discover/discover_ui.html
    • chrome/browser/resources/chromeos/login/discover/discover_ui.js
    • chrome/browser/resources/chromeos/login/discover/discover_welcome.css
    • chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.css
    • chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.html
    • chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.js
    • chrome/browser/resources/chromeos/login/discover/modules/images/pin_illustration_1x.svg
    • chrome/browser/resources/chromeos/login/discover/modules/images/pin_illustration_2x.svg
    • chrome/browser/resources/chromeos/login/screen_discover.html
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.h
    • chrome/browser/ui/webui/chromeos/login/discover/discover_module.h
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_launch_help_app.cc
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_launch_help_app.h
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_pin_setup.cc
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_pin_setup.h
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_redeem_offers.cc
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_redeem_offers.h
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_sync_files.cc
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_sync_files.h
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_welcome.cc
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_welcome.h
    • chrome/common/extensions/api/_api_features.json
  8. Change cpp.tmpl files to cc.tmpl

    Changed by Amos Lim - eui-sang.limohnoyoudont@samsung.com
    Changed at Friday, 12-Oct-18 07:35:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 07c46624768cb8f779f4c872aa5951d3cb7d7920

    Comments

    Change cpp.tmpl files to cc.tmpl
    
    Formats of C++ template files are mixed up with cpp.tmpl and cc.tmpl.
    Unify C++ template files to cc.tmpl
    
    Bug: 894684
    Change-Id: I4f7413f29809bcd3262a20c7f40a23e63ba45d3a
    Reviewed-on: https://chromium-review.googlesource.com/c/1278567
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
    Cr-Commit-Position: refs/heads/master@{#599129}

    Changed files

    • third_party/blink/renderer/bindings/scripts/code_generator_v8.py
    • third_party/blink/renderer/bindings/scripts/generate_v8_context_snapshot_external_references.py
    • third_party/blink/renderer/bindings/templates/attributes.cc.tmpl
    • third_party/blink/renderer/bindings/templates/callback_function.cc.tmpl
    • third_party/blink/renderer/bindings/templates/callback_interface.cc.tmpl
    • third_party/blink/renderer/bindings/templates/callback_invoke.cc.tmpl
    • third_party/blink/renderer/bindings/templates/constants.cc.tmpl
    • third_party/blink/renderer/bindings/templates/dictionary_impl.cc.tmpl
    • third_party/blink/renderer/bindings/templates/dictionary_impl.h.tmpl
    • third_party/blink/renderer/bindings/templates/dictionary_impl_common.cc.tmpl
    • third_party/blink/renderer/bindings/templates/dictionary_v8.cc.tmpl
    • third_party/blink/renderer/bindings/templates/external_reference_table.cc.tmpl
    • third_party/blink/renderer/bindings/templates/interface.cc.tmpl
    • third_party/blink/renderer/bindings/templates/interface_base.cc.tmpl
    • third_party/blink/renderer/bindings/templates/methods.cc.tmpl
    • third_party/blink/renderer/bindings/templates/partial_interface.cc.tmpl
    • third_party/blink/renderer/bindings/templates/templates.gni
    • third_party/blink/renderer/bindings/templates/union_container.cc.tmpl
    • third_party/blink/renderer/bindings/templates/utilities.cc.tmpl
    • third_party/blink/renderer/bindings/tests/results/core/array_buffer_or_array_buffer_view_or_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/boolean_or_element_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/boolean_or_string_or_unrestricted_double.cc
    • third_party/blink/renderer/bindings/tests/results/core/boolean_or_test_callback_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/byte_string_or_node_list.cc
    • third_party/blink/renderer/bindings/tests/results/core/byte_string_sequence_sequence_or_byte_string_byte_string_record.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_double_or_null_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_double_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_long_or_boolean_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_string.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_string_or_double_or_string_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/element_sequence_or_byte_string_double_or_string_record.cc
    • third_party/blink/renderer/bindings/tests/results/core/float_or_boolean.cc
    • third_party/blink/renderer/bindings/tests/results/core/long_or_boolean.cc
    • third_party/blink/renderer/bindings/tests/results/core/long_or_test_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/long_sequence_or_event.cc
    • third_party/blink/renderer/bindings/tests/results/core/nested_union_type.cc
    • third_party/blink/renderer/bindings/tests/results/core/node_or_node_list.cc
    • third_party/blink/renderer/bindings/tests/results/core/string_or_array_buffer_or_array_buffer_view.cc
    • third_party/blink/renderer/bindings/tests/results/core/string_or_double.cc
    • third_party/blink/renderer/bindings/tests/results/core/string_or_string_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_dictionary_derived.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_enum_or_double.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_or_null_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_interface_2_or_uint8_array.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_interface_event_init.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_interface_or_long.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_interface_or_test_interface_empty.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_permissive_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/unrestricted_double_or_string.cc
    • third_party/blink/renderer/bindings/tests/results/core/unsigned_long_long_or_boolean_or_test_callback_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_optional_any_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_variadic_any_args.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_array_buffer.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_array_buffer_view.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_data_view.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_long_callback_function.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_string_sequence_callback_function_long_sequence_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_svg_test_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_attributes.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_functions.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_constants.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary_derived.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_global.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_primary_global.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_2.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_3.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_check_security.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_conditional_secure_context.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_2.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_3.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_4.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_custom_constructor.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_document.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_empty.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init_constructor.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_target.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor_2.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_node.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_origin_trial_enabled.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_secure_context.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_legacy_callback_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_node.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_object.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_permissive_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_special_operations.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_special_operations_not_enumerable.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_typedefs.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_variadic_constructor_arguments.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_treat_non_object_as_null_boolean_function.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_treat_non_object_as_null_void_function.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_uint8_clamped_array.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_dictionary_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_enum_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_interface_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_test_interface_sequence_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_typedef.cc
    • third_party/blink/renderer/bindings/tests/results/core/xml_http_request_or_string.cc
    • third_party/blink/renderer/bindings/tests/results/modules/boolean_or_string.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_inherited_legacy_unenumerable_named_properties.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_2_partial.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_5.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_partial.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_not_enumerable_named_getter.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_sub_object.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_void_callback_function_modules.cc
    • third_party/blink/renderer/core/css/css_primitive_value.h
  9. CrOS FilesApp: Add Manage Linux sharing top menu link to settings page

    Changed by Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:33:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 836e5cd90af24fa6af71e4e633d1c0fb41ca0765

    Comments

    CrOS FilesApp: Add Manage Linux sharing top menu link to settings page
    
    Shown when crostini and flag crostini-files are enabled.
    Links to chrome://settings/crostini/crostiniShared.
    Record UMA for clicks.
    
    Bug: 878324
    Change-Id: Ie09cd5c07edbe6dc0d0bcc22fee78b14981b2020
    Reviewed-on: https://chromium-review.googlesource.com/c/1277130
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599128}

    Changed files

    • chrome/app/file_manager_strings.grdp
    • chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_MANAGE_LINUX_SHARING_BUTTON_LABEL.png.sha1
    • chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
    • tools/metrics/histograms/enums.xml
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/file_manager/foreground/js/file_manager_commands.js
    • ui/file_manager/file_manager/main.html
    • ui/file_manager/file_manager/test/crostini_share.js
  10. Roll src-internal aebffd21b13f..7781cb9daa22 (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 07:17:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d6d014a7e5ef0d330fef991ab82343f02e71b6f8

    Comments

    Roll src-internal aebffd21b13f..7781cb9daa22 (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aebffd21b13f..7781cb9daa22
    
    
    Created with:
      gclient setdep -r src-internal@7781cb9daa22
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ib8911116b9b81a6503414f98f9988cd10a39144e
    Reviewed-on: https://chromium-review.googlesource.com/c/1278303
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599127}

    Changed files

    • DEPS
  11. [ServiceWorker] Add WPT tests to check request header for update

    Changed by momohatt - momohatt10ohnoyoudont@gmail.com
    Changed at Friday, 12-Oct-18 07:05:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4512662655ea5694ebba6c13055e99c9a0b2d096

    Comments

    [ServiceWorker] Add WPT tests to check request header for update
    
    Spec requires that during the update of service workers, request headers
    for fetching main scripts should include "Service-Worker" field, while
    that for fetching importScripts() resources should not.
    This patch adds WPT tests to validate this behavior.
    
    Change-Id: I24949fd0b375f6b811a73ce24aae87a4ea7c234f
    Reviewed-on: https://chromium-review.googlesource.com/c/1267297
    Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599126}

    Changed files

    • AUTHORS
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/service-worker-header.py
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/service-worker-header.https.html
  12. Add Quick View audio load test

    Changed by Noel Gordon - noelohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:04:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae2fcf0ef323eb487edced1ab876a090b3f9ce1e

    Comments

    Add Quick View audio load test
    
    Now we have the QuickView <webview> infra to detect the 'loaded' state
    of the <webview> content, add a <file-safe-media> audio test, and also
    check the <webview> renders its content on a transparent black body.
    
    This test exposed an issue in Blink node code. When the modal <dialog>
    is calling showModal(), its flat tree distribution can be out-of-date,
    causing a DCHECK crash when testing if the Quick View <dialog> element
    contains sibling <iframe id="command-dispatcher"> [1].
    
    Fix that: FlatTreeTraversal::ContainsIncludingPseudoElement() requires
    that its node arguments have up-to-date flat tree distribution. Ensure
    the <dialog>'s flat tree distribution is up-of-date _before_ trying to
    propagate the "inert" bit into sub-frames.
    
    Add crash test: html/dialog/showmodal-shadow-sibling-frame-crash.html
    
    [1] Known crash reports already exist: issue 789094 issue 804047.
    
    test: browser_tests --gtest_filter="QuickView*openQuickViewAudio"
    Bug: 891150, 789094, 804047
    Change-Id: I714585272fc775c157f6d0bd97143af27bf2b961
    Reviewed-on: https://chromium-review.googlesource.com/c/1264138
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599125}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • third_party/WebKit/LayoutTests/html/dialog/showmodal-shadow-sibling-frame-crash-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/showmodal-shadow-sibling-frame-crash.html
    • third_party/blink/renderer/core/html/html_dialog_element.cc
    • ui/file_manager/integration_tests/file_manager/quick_view.js
  13. Clarify |stopSyncAndClearIdentity| with additional comment.

    Changed by John Z Wu - jzwohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:03:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3255a4ba5a80b407cc61864a85c469842894f469

    Comments

    Clarify |stopSyncAndClearIdentity| with additional comment.
    
    Namely, it is OK to call it multiple times.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I7348628de6e39ca50461c25db7343cd46b5f069a
    Reviewed-on: https://chromium-review.googlesource.com/c/1278061
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599124}

    Changed files

    • ios/web_view/public/cwv_sync_controller.h